{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/217249137","pull_request_review_id":154915609,"id":217249137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzI0OTEzNw==","diff_hunk":"@@ -1,42 +1,55 @@\n-#!/bin/bash\n+#!/usr/bin/env bash\n set -e\n \n-echo \"Rendering Kubernetes core manifests...\"\n-\n-# shellcheck disable=SC2154\n-/usr/bin/podman run \\\n-    --volume \"$PWD:/assets:z\" \\\n-    --volume /etc/kubernetes:/etc/kubernetes:z \\\n-    \"${kube_core_renderer_image}\" \\\n-    --config=/assets/kco-config.yaml \\\n-    --output=/assets\n-\n-echo \"Rendering MCO manifests...\"\n-\n-# shellcheck disable=SC2154\n-/usr/bin/podman run \\\n-    --user 0 \\\n-    --volume \"$PWD:/assets:z\" \\\n-    \"${machine_config_operator_image}\" \\\n-    bootstrap \\\n-    --etcd-ca=/assets/tls/etcd-client-ca.crt \\\n-    --root-ca=/assets/tls/root-ca.crt \\\n-    --config-file=/assets/manifests/cluster-config.yaml \\\n-    --dest-dir=/assets/mco-bootstrap \\\n-    --images-json-configmap=/assets/manifests/machine-config-operator-01-images-configmap.yaml\n-\n-mkdir -p /etc/kubernetes/manifests/\n-mkdir -p /etc/mcc/bootstrap/\n-mkdir -p /etc/ssl/mcs/\n-# Bootstrap MachineConfigController uses /etc/mcc/bootstrap/manifests/ dir to\n-# 1. read the controller config rendered by MachineConfigOperator\n-# 2. read the default MachineConfigPools rendered by MachineConfigOperator\n-# 3. read any additional MachineConfigs that are needed for the default MachineConfigPools.\n-cp -r \"$PWD/mco-bootstrap/manifests\" /etc/mcc/bootstrap/manifests\n-# /etc/ssl/mcs/tls.{crt, key} are locations for MachineConfigServer's tls assets.\n-cp \"$PWD/tls/machine-config-server.crt\" /etc/ssl/mcs/tls.crt\n-cp \"$PWD/tls/machine-config-server.key\" /etc/ssl/mcs/tls.key\n-cp \"$PWD/mco-bootstrap/machineconfigoperator-bootstrap-pod.yaml\" /etc/kubernetes/manifests/\n+mkdir --parents /etc/kubernetes/manifests/\n+\n+if [ ! -d \"$PWD/kco-bootstrap\" ]\n+then\n+\techo \"Rendering Kubernetes core manifests...\"\n+\n+\t# shellcheck disable=SC2154\n+\tpodman run \\\n+\t\t--volume \"$PWD:/assets:z\" \\\n+\t\t--volume /etc/kubernetes:/etc/kubernetes:z \\\n+\t\t\"${kube_core_renderer_image}\" \\\n+\t\t--config=/assets/kco-config.yaml \\\n+\t\t--output=/assets/kco-bootstrap\n+\n+\tcp --recursive \"$PWD/kco-bootstrap/bootstrap-configs\" /etc/kubernetes/bootstrap-configs\n+\tcp --recursive \"$PWD/kco-bootstrap/bootstrap-configs\" .","path":"modules/bootkube/resources/bootkube.sh","position":56,"original_position":56,"commit_id":"954c009d80687796661df72c4fa725f92857bfe5","original_commit_id":"954c009d80687796661df72c4fa725f92857bfe5","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"We can \r\n* Change conditional to /etc and drop cp .\r\n* Keep it as is, no big deal","created_at":"2018-09-13T03:13:06Z","updated_at":"2018-09-13T03:13:06Z","html_url":"https://github.com/openshift/installer/pull/244#discussion_r217249137","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/244","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/217249137"},"html":{"href":"https://github.com/openshift/installer/pull/244#discussion_r217249137"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/244"}},"in_reply_to_id":217241213},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/244","id":215135949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTM1OTQ5","html_url":"https://github.com/openshift/installer/pull/244","diff_url":"https://github.com/openshift/installer/pull/244.diff","patch_url":"https://github.com/openshift/installer/pull/244.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/244","number":244,"state":"open","locked":false,"title":"modules: attempt to make bootstrap more robust","user":{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"body":"This runs bootkube.service and tectonic.service repeatedly until they\r\nsucceed. This isn't going to work in its current form (bootkube still\r\nhas trouble being restarted) but it gets us closer.","created_at":"2018-09-13T00:57:03Z","updated_at":"2018-09-13T03:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17f927ae1a741fe99bb2f8429df1ed75d0a38529","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rajatchopra","id":982221,"node_id":"MDQ6VXNlcjk4MjIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false},{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959730450,"node_id":"MDU6TGFiZWw5NTk3MzA0NTA=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/244/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/244/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/244/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/954c009d80687796661df72c4fa725f92857bfe5","head":{"label":"crawford:boot","ref":"boot","sha":"954c009d80687796661df72c4fa725f92857bfe5","user":{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"repo":{"id":139646222,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2NDYyMjI=","name":"installer","full_name":"crawford/installer","owner":{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crawford/installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/crawford/installer","forks_url":"https://api.github.com/repos/crawford/installer/forks","keys_url":"https://api.github.com/repos/crawford/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crawford/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crawford/installer/teams","hooks_url":"https://api.github.com/repos/crawford/installer/hooks","issue_events_url":"https://api.github.com/repos/crawford/installer/issues/events{/number}","events_url":"https://api.github.com/repos/crawford/installer/events","assignees_url":"https://api.github.com/repos/crawford/installer/assignees{/user}","branches_url":"https://api.github.com/repos/crawford/installer/branches{/branch}","tags_url":"https://api.github.com/repos/crawford/installer/tags","blobs_url":"https://api.github.com/repos/crawford/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crawford/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crawford/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/crawford/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crawford/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/crawford/installer/languages","stargazers_url":"https://api.github.com/repos/crawford/installer/stargazers","contributors_url":"https://api.github.com/repos/crawford/installer/contributors","subscribers_url":"https://api.github.com/repos/crawford/installer/subscribers","subscription_url":"https://api.github.com/repos/crawford/installer/subscription","commits_url":"https://api.github.com/repos/crawford/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/crawford/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/crawford/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/crawford/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/crawford/installer/contents/{+path}","compare_url":"https://api.github.com/repos/crawford/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crawford/installer/merges","archive_url":"https://api.github.com/repos/crawford/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crawford/installer/downloads","issues_url":"https://api.github.com/repos/crawford/installer/issues{/number}","pulls_url":"https://api.github.com/repos/crawford/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/crawford/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/crawford/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crawford/installer/labels{/name}","releases_url":"https://api.github.com/repos/crawford/installer/releases{/id}","deployments_url":"https://api.github.com/repos/crawford/installer/deployments","created_at":"2018-07-03T23:29:46Z","updated_at":"2018-07-18T13:44:51Z","pushed_at":"2018-09-13T01:31:04Z","git_url":"git://github.com/crawford/installer.git","ssh_url":"git@github.com:crawford/installer.git","clone_url":"https://github.com/crawford/installer.git","svn_url":"https://github.com/crawford/installer","homepage":"","size":36480,"stargazers_count":1,"watchers_count":1,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6308b8d23d5b5d7e7b94b7d7e33caab1552af4df","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-09-13T01:49:02Z","pushed_at":"2018-09-13T01:48:58Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":36479,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":29,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/244"},"html":{"href":"https://github.com/openshift/installer/pull/244"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/244"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/954c009d80687796661df72c4fa725f92857bfe5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abhinavdahiya"}}