{"action":"created","issue":{"url":"https://api.github.com/repos/nipy/nibabel/issues/661","repository_url":"https://api.github.com/repos/nipy/nibabel","labels_url":"https://api.github.com/repos/nipy/nibabel/issues/661/labels{/name}","comments_url":"https://api.github.com/repos/nipy/nibabel/issues/661/comments","events_url":"https://api.github.com/repos/nipy/nibabel/issues/661/events","html_url":"https://github.com/nipy/nibabel/pull/661","id":360449351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzA2OTM4","number":661,"title":"RF+ENH: nib-diff - allow to specify absolute and/or relative maximal diff to tolerate","user":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"labels":[{"id":43043,"node_id":"MDU6TGFiZWw0MzA0Mw==","url":"https://api.github.com/repos/nipy/nibabel/labels/enhancement","name":"enhancement","color":"23db5d","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-09-14T20:46:20Z","updated_at":"2018-10-03T14:53:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nipy/nibabel/pulls/661","html_url":"https://github.com/nipy/nibabel/pull/661","diff_url":"https://github.com/nipy/nibabel/pull/661.diff","patch_url":"https://github.com/nipy/nibabel/pull/661.patch"},"body":"So now it should be possible to get an idea on how much data in the given files differs:\r\n\r\n    $> nib-diff --ma 0.000001 --mr .001 ./tests-run/output/./sub-1_T1w_5mm_noise_corrected.nii.gz /tmp/sub-1_T1w_5mm_noise_corrected.nii.gz\r\n    These files are different.\r\n    Field          1:sub-1_T1w_5mm_noise_corrected.nii.gz                   2:sub-1_T1w_5mm_noise_corrected.nii.gz\r\n    DATA(md5)      65df09c06b236342eaf7e2fe57aabf55                       3c6e9069e6e054e714f2894419848df0\r\n    DATA(diff 1:)  -                                                      abs: 7.6293945e-06, rel: 0.002224694\r\n\r\nand could be applied to >2 files as well\r\n\r\nTODOs\r\n- [ ] seek feedback regarding naming of parameters (e.g. `data_max_abs_diff`) - they are kinda mouthful but wanted to be specific happen we add some later on dedicated to header etc\r\n- [ ] seek feedback regarding output formatting\r\n- [ ] seek feedback regarding \"logic\" - ATM specification of --ma would also affect estimation of relative difference.  I did it on purpose so we could easily avoid divisions in tiny numbers, which could reach high values.  But may be that is undesired?\r\n- [x] add tests\r\n\r\nattn @chrispycheng "},"comment":{"url":"https://api.github.com/repos/nipy/nibabel/issues/comments/426667507","html_url":"https://github.com/nipy/nibabel/pull/661#issuecomment-426667507","issue_url":"https://api.github.com/repos/nipy/nibabel/issues/661","id":426667507,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY2NzUwNw==","user":{"login":"yarikoptic","id":39889,"node_id":"MDQ6VXNlcjM5ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/39889?v=4","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T14:53:28Z","updated_at":"2018-10-03T14:53:28Z","author_association":"MEMBER","body":"> > I would have stick to the default (float64) as providing the best \"fidelity\" as decided by nibabel in general to be the default data type to be returned\r\n> \r\n> Okay. Just making sure that's what you wanted. If diffing BOLD series, that could get expensive quickly.\r\n\r\nindeed... but if we decide to provide help for those, we should just add  another parameter (`dtype`) so user could specify explicitly.  Could be done in a separate PR."}}
{"actor":{"display_login":"yarikoptic"}}