{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-bids/issues/50","repository_url":"https://api.github.com/repos/mne-tools/mne-bids","labels_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/50/comments","events_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/50/events","html_url":"https://github.com/mne-tools/mne-bids/issues/50","id":340451239,"node_id":"MDU6SXNzdWUzNDA0NTEyMzk=","number":50,"title":"Handling empty room data","user":{"login":"monkeyman192","id":8000597,"node_id":"MDQ6VXNlcjgwMDA1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8000597?v=4","gravatar_id":"","url":"https://api.github.com/users/monkeyman192","html_url":"https://github.com/monkeyman192","followers_url":"https://api.github.com/users/monkeyman192/followers","following_url":"https://api.github.com/users/monkeyman192/following{/other_user}","gists_url":"https://api.github.com/users/monkeyman192/gists{/gist_id}","starred_url":"https://api.github.com/users/monkeyman192/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkeyman192/subscriptions","organizations_url":"https://api.github.com/users/monkeyman192/orgs","repos_url":"https://api.github.com/users/monkeyman192/repos","events_url":"https://api.github.com/users/monkeyman192/events{/privacy}","received_events_url":"https://api.github.com/users/monkeyman192/received_events","type":"User","site_admin":false},"labels":[{"id":590206823,"node_id":"MDU6TGFiZWw1OTAyMDY4MjM=","url":"https://api.github.com/repos/mne-tools/mne-bids/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-bids/milestones/2","html_url":"https://github.com/mne-tools/mne-bids/milestone/2","labels_url":"https://api.github.com/repos/mne-tools/mne-bids/milestones/2/labels","id":3635551,"node_id":"MDk6TWlsZXN0b25lMzYzNTU1MQ==","number":2,"title":"0.2","description":"0.2","creator":{"login":"jasmainak","id":15852194,"node_id":"MDQ6VXNlcjE1ODUyMTk0","avatar_url":"https://avatars3.githubusercontent.com/u/15852194?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":9,"state":"open","created_at":"2018-09-08T14:16:57Z","updated_at":"2018-11-27T19:10:15Z","due_on":"2018-12-25T08:00:00Z","closed_at":null},"comments":7,"created_at":"2018-07-12T00:39:09Z","updated_at":"2018-12-18T04:45:34Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"It would be nice to be able to handle data that is specified to be as empty room data automatically.\r\nTo do this I propose adding an extra argument to `raw_to_bids`. Something along the lines of (this is the docstring for it):\r\n```python\r\n\"\"\"\r\n    emptyroom : False | bool | string\r\n        Whether or not the supplied file is for the empty room measurement\r\n        If False we do nothing.\r\n        If True the file is used as an empty room file and handled appropriately\r\n        If a path is specified it is assumed that this file is the empty room file path\r\n\"\"\"\r\n```\r\nIf the value is True then it will process the file in such a way as to generate all the empty room data (also see code snippet in #48 ).\r\nThe data for the recording time can all be extracted from the raw files, so it can all be done automatically.\r\n\r\nThe path specified is to allow for the `AssociatedEmptyRoom` value in the sidecar .json to be set.\r\nI couldn't think of a better way to specify this value than setting it as a string here. It's reusing the argument however for two (similar) but different objectives. This is also the only part of this that I don't think can really be done automatically (unless you add another argument like 'has_emptyroom' which essentially generates the empty room path. Not sure whether it would be better to get this to happen externally or not...)\r\n"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-bids/issues/comments/448094960","html_url":"https://github.com/mne-tools/mne-bids/issues/50#issuecomment-448094960","issue_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/50","id":448094960,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODA5NDk2MA==","user":{"login":"jasmainak","id":15852194,"node_id":"MDQ6VXNlcjE1ODUyMTk0","avatar_url":"https://avatars3.githubusercontent.com/u/15852194?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T04:45:34Z","updated_at":"2018-12-18T04:45:34Z","author_association":"MEMBER","body":"+1 for modifying the MNE sample data example to show also how to add an `emptyroom` subject. I would prefer if we didn't hack / change the bids_basename that the user provided."}}
{"actor":{"display_login":"jasmainak"}}