{"action":"created","issue":{"url":"https://api.github.com/repos/OData/odata.net/issues/1169","repository_url":"https://api.github.com/repos/OData/odata.net","labels_url":"https://api.github.com/repos/OData/odata.net/issues/1169/labels{/name}","comments_url":"https://api.github.com/repos/OData/odata.net/issues/1169/comments","events_url":"https://api.github.com/repos/OData/odata.net/issues/1169/events","html_url":"https://github.com/OData/odata.net/pull/1169","id":326848715,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwODA1ODY4","number":1169,"title":"Convert custom attributes to DataContract/DataMember","user":{"login":"robertmclaws","id":1657085,"node_id":"MDQ6VXNlcjE2NTcwODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1657085?v=4","gravatar_id":"","url":"https://api.github.com/users/robertmclaws","html_url":"https://github.com/robertmclaws","followers_url":"https://api.github.com/users/robertmclaws/followers","following_url":"https://api.github.com/users/robertmclaws/following{/other_user}","gists_url":"https://api.github.com/users/robertmclaws/gists{/gist_id}","starred_url":"https://api.github.com/users/robertmclaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertmclaws/subscriptions","organizations_url":"https://api.github.com/users/robertmclaws/orgs","repos_url":"https://api.github.com/users/robertmclaws/repos","events_url":"https://api.github.com/users/robertmclaws/events{/privacy}","received_events_url":"https://api.github.com/users/robertmclaws/received_events","type":"User","site_admin":false},"labels":[{"id":710014451,"node_id":"MDU6TGFiZWw3MTAwMTQ0NTE=","url":"https://api.github.com/repos/OData/odata.net/labels/docs-needed","name":"docs-needed","color":"ededed","default":false},{"id":402960498,"node_id":"MDU6TGFiZWw0MDI5NjA0OTg=","url":"https://api.github.com/repos/OData/odata.net/labels/feature","name":"feature","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-27T20:40:45Z","updated_at":"2018-05-30T18:36:23Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/OData/odata.net/pulls/1169","html_url":"https://github.com/OData/odata.net/pull/1169","diff_url":"https://github.com/OData/odata.net/pull/1169.diff","patch_url":"https://github.com/OData/odata.net/pull/1169.patch"},"body":"<!-- markdownlint-disable MD002 MD041 -->\r\n\r\n### Issues\r\n\r\n*This pull request fixes issue #554, and makes progress on #1003.\r\n\r\n### Description\r\n\r\nChanges generated entities to use DataContract/DataMember instead of custom attributes that a) serve the same function and b) tightly-couple the generated objects to Microsoft.OData.Client.dll.\r\n\r\n### Checklist (Uncheck if it is not completed)\r\n\r\n- [ ] *Test cases added*\r\n- [ ] *Build and test with one-click build and test script passed*\r\n\r\n### Additional work necessary\r\n\r\n- [ ] *Determine if compatibility shims need to be added to continue support for EntityTypeAttribute and OriginalNameAttribute, or if the T4 templates provide reasonable enough protection from upgrade issues.*\r\n- [ ] *Check against automated unit tests. All 6001 tests inside VS2017 passed.*\r\n- [ ] *Document the change and how it affects proxies / codegen.*\r\n\r\n*If documentation update is needed, please add \"Docs Needed\" label to the issue and provide details about the required document change in the issue.*\r\n"},"comment":{"url":"https://api.github.com/repos/OData/odata.net/issues/comments/393271218","html_url":"https://github.com/OData/odata.net/pull/1169#issuecomment-393271218","issue_url":"https://api.github.com/repos/OData/odata.net/issues/1169","id":393271218,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzI3MTIxOA==","user":{"login":"AlanWong-MS","id":22382722,"node_id":"MDQ6VXNlcjIyMzgyNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22382722?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanWong-MS","html_url":"https://github.com/AlanWong-MS","followers_url":"https://api.github.com/users/AlanWong-MS/followers","following_url":"https://api.github.com/users/AlanWong-MS/following{/other_user}","gists_url":"https://api.github.com/users/AlanWong-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanWong-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanWong-MS/subscriptions","organizations_url":"https://api.github.com/users/AlanWong-MS/orgs","repos_url":"https://api.github.com/users/AlanWong-MS/repos","events_url":"https://api.github.com/users/AlanWong-MS/events{/privacy}","received_events_url":"https://api.github.com/users/AlanWong-MS/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T18:36:23Z","updated_at":"2018-05-30T18:36:23Z","author_association":"CONTRIBUTOR","body":"Hi @robertmclaws, many thanks for the PR. I currently have a full plate and may not be able to get to reviewing your PR this week. In the meantime, it looks like the buddy build reports many test failures (more than 100) from the OData.Tests.E2E.sln test suite. You can wait for me to code review first before attempting to dive into the test cases, but just wanted to give visibility on the buddy build complained about."}}
{"actor":{"display_login":"AlanWong-MS"}}