{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/216970221","pull_request_review_id":154572919,"id":216970221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjk3MDIyMQ==","diff_hunk":"@@ -552,18 +549,11 @@ public String getSearchUrl() {\n     \tList<Action> result = new ArrayList<Action>();\n     \tresult.addAll(getOwner().getViewActions());\n     \tsynchronized (this) {","path":"core/src/main/java/hudson/model/View.java","position":20,"original_position":20,"commit_id":"2f6ce52a14fceb902264ffa36d03072159a69332","original_commit_id":"2f6ce52a14fceb902264ffa36d03072159a69332","user":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"body":"nope","created_at":"2018-09-12T10:03:02Z","updated_at":"2018-09-12T10:03:02Z","html_url":"https://github.com/jenkinsci/jenkins/pull/3608#discussion_r216970221","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/216970221"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/3608#discussion_r216970221"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608"}},"in_reply_to_id":216969886},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608","id":212774954,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzc0OTU0","html_url":"https://github.com/jenkinsci/jenkins/pull/3608","diff_url":"https://github.com/jenkinsci/jenkins/pull/3608.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/3608.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3608","number":3608,"state":"open","locked":false,"title":"JENKINS-53353 Do not cache results of View.getActions()","user":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"body":"See [JENKINS-53353](https://issues.jenkins-ci.org/browse/JENKINS-53353).\r\n\r\nPlugins that may affect the view, eg via TransientViewActionFactory\r\nthat get installed _after_ a `view` has been initally viewed\r\nwill not be able to add anything to the view if the results\r\nof getActions() are cached.\r\n\r\n### Proposed changelog entries\r\n\r\n* Entry 1: Removed caching in Views - Plugins that affected the View, but are installed _after_ the initial rendering/viewing of the `View` will not be called again and do not contribute to the `View`.\r\n\r\n### Submitter checklist\r\n\r\n- [x] JIRA issue is well described\r\n- [x] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). [Examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)\r\n      * Use the `Internal: ` prefix if the change has no user-visible impact (API, test frameworks, etc.)\r\n- [ ] Appropriate autotests or explanation to why this change has no tests\r\n      * No existing tests present for the caching. Code is simplistic enough and removes functionality so unnecessary to add tests.\r\n- [ ] For dependency updates: links to external changelogs and, if possible, full diffs\r\n\r\n@reviewbybees @jtnord\r\n","created_at":"2018-09-03T15:07:25Z","updated_at":"2018-09-12T10:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e606cceda5635efced068992ddd7e33777c3e0c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3608/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/2f6ce52a14fceb902264ffa36d03072159a69332","head":{"label":"agentgonzo:JENKINS-53353","ref":"JENKINS-53353","sha":"2f6ce52a14fceb902264ffa36d03072159a69332","user":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"repo":{"id":126055378,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwNTUzNzg=","name":"jenkins","full_name":"agentgonzo/jenkins","owner":{"login":"agentgonzo","id":1652511,"node_id":"MDQ6VXNlcjE2NTI1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1652511?v=4","gravatar_id":"","url":"https://api.github.com/users/agentgonzo","html_url":"https://github.com/agentgonzo","followers_url":"https://api.github.com/users/agentgonzo/followers","following_url":"https://api.github.com/users/agentgonzo/following{/other_user}","gists_url":"https://api.github.com/users/agentgonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/agentgonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentgonzo/subscriptions","organizations_url":"https://api.github.com/users/agentgonzo/orgs","repos_url":"https://api.github.com/users/agentgonzo/repos","events_url":"https://api.github.com/users/agentgonzo/events{/privacy}","received_events_url":"https://api.github.com/users/agentgonzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agentgonzo/jenkins","description":"Jenkins automation server","fork":true,"url":"https://api.github.com/repos/agentgonzo/jenkins","forks_url":"https://api.github.com/repos/agentgonzo/jenkins/forks","keys_url":"https://api.github.com/repos/agentgonzo/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agentgonzo/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agentgonzo/jenkins/teams","hooks_url":"https://api.github.com/repos/agentgonzo/jenkins/hooks","issue_events_url":"https://api.github.com/repos/agentgonzo/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/agentgonzo/jenkins/events","assignees_url":"https://api.github.com/repos/agentgonzo/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/agentgonzo/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/agentgonzo/jenkins/tags","blobs_url":"https://api.github.com/repos/agentgonzo/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agentgonzo/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agentgonzo/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/agentgonzo/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agentgonzo/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/agentgonzo/jenkins/languages","stargazers_url":"https://api.github.com/repos/agentgonzo/jenkins/stargazers","contributors_url":"https://api.github.com/repos/agentgonzo/jenkins/contributors","subscribers_url":"https://api.github.com/repos/agentgonzo/jenkins/subscribers","subscription_url":"https://api.github.com/repos/agentgonzo/jenkins/subscription","commits_url":"https://api.github.com/repos/agentgonzo/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/agentgonzo/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/agentgonzo/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/agentgonzo/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/agentgonzo/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/agentgonzo/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agentgonzo/jenkins/merges","archive_url":"https://api.github.com/repos/agentgonzo/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agentgonzo/jenkins/downloads","issues_url":"https://api.github.com/repos/agentgonzo/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/agentgonzo/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/agentgonzo/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/agentgonzo/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agentgonzo/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/agentgonzo/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/agentgonzo/jenkins/deployments","created_at":"2018-03-20T17:17:05Z","updated_at":"2018-06-01T03:24:46Z","pushed_at":"2018-09-04T10:49:21Z","git_url":"git://github.com/agentgonzo/jenkins.git","ssh_url":"git@github.com:agentgonzo/jenkins.git","clone_url":"https://github.com/agentgonzo/jenkins.git","svn_url":"https://github.com/agentgonzo/jenkins","homepage":"https://jenkins.io/","size":108991,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"2652a1b1eb90b5859686f505a0c6459af2dc2299","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNjA3","name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins automation server","fork":false,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2018-09-12T07:58:56Z","pushed_at":"2018-09-12T08:25:44Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":108857,"stargazers_count":11110,"watchers_count":11110,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4775,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4775,"open_issues":103,"watchers":11110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/3608"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3608"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3608/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3608/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/2f6ce52a14fceb902264ffa36d03072159a69332"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agentgonzo"}}