{"action":"created","comment":{"url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/comments/169614684","pull_request_review_id":98166344,"id":169614684,"diff_hunk":"@@ -159,9 +159,8 @@ int sanity_check_capability_opts (void) {\n ","path":"tools/tpm2_getcap.c","position":7,"original_position":1,"commit_id":"8fd9baeef98f8bcc1ba3a611a1688c7b422a469c","original_commit_id":"f558c48423402c83ebde85f442b067cd21363216","user":{"login":"martinezjavier","id":498974,"avatar_url":"https://avatars0.githubusercontent.com/u/498974?v=4","gravatar_id":"","url":"https://api.github.com/users/martinezjavier","html_url":"https://github.com/martinezjavier","followers_url":"https://api.github.com/users/martinezjavier/followers","following_url":"https://api.github.com/users/martinezjavier/following{/other_user}","gists_url":"https://api.github.com/users/martinezjavier/gists{/gist_id}","starred_url":"https://api.github.com/users/martinezjavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinezjavier/subscriptions","organizations_url":"https://api.github.com/users/martinezjavier/orgs","repos_url":"https://api.github.com/users/martinezjavier/repos","events_url":"https://api.github.com/users/martinezjavier/events{/privacy}","received_events_url":"https://api.github.com/users/martinezjavier/received_events","type":"User","site_admin":false},"body":"In the commit message:\r\n\r\ns/cononical/canonical\r\ns/Ie/i.e\r\ns/worK/work","created_at":"2018-02-21T11:55:17Z","updated_at":"2018-02-21T11:55:17Z","html_url":"https://github.com/tpm2-software/tpm2-tools/pull/898#discussion_r169614684","pull_request_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/comments/169614684"},"html":{"href":"https://github.com/tpm2-software/tpm2-tools/pull/898#discussion_r169614684"},"pull_request":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898"}}},"pull_request":{"url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898","id":169733414,"html_url":"https://github.com/tpm2-software/tpm2-tools/pull/898","diff_url":"https://github.com/tpm2-software/tpm2-tools/pull/898.diff","patch_url":"https://github.com/tpm2-software/tpm2-tools/pull/898.patch","issue_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues/898","number":898,"state":"open","locked":false,"title":"Yaml output","user":{"login":"williamcroberts","id":17750791,"avatar_url":"https://avatars0.githubusercontent.com/u/17750791?v=4","gravatar_id":"","url":"https://api.github.com/users/williamcroberts","html_url":"https://github.com/williamcroberts","followers_url":"https://api.github.com/users/williamcroberts/followers","following_url":"https://api.github.com/users/williamcroberts/following{/other_user}","gists_url":"https://api.github.com/users/williamcroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/williamcroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamcroberts/subscriptions","organizations_url":"https://api.github.com/users/williamcroberts/orgs","repos_url":"https://api.github.com/users/williamcroberts/repos","events_url":"https://api.github.com/users/williamcroberts/events{/privacy}","received_events_url":"https://api.github.com/users/williamcroberts/received_events","type":"User","site_admin":false},"body":"Audit the tools for printf usages and replace with tpm2_tool_output. Also verify that output is in a YAML compliant format. Add tests that verify that the output can be loaded via the YAML module in python.\r\n\r\nFixes: #634 ","created_at":"2018-02-16T21:47:25Z","updated_at":"2018-02-21T11:55:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ea0df75b465a0b29a8d2d4e0f5a87dd624ed729","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898/commits","review_comments_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898/comments","review_comment_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues/898/comments","statuses_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/statuses/8fd9baeef98f8bcc1ba3a611a1688c7b422a469c","head":{"label":"williamcroberts:yaml-output","ref":"yaml-output","sha":"8fd9baeef98f8bcc1ba3a611a1688c7b422a469c","user":{"login":"williamcroberts","id":17750791,"avatar_url":"https://avatars0.githubusercontent.com/u/17750791?v=4","gravatar_id":"","url":"https://api.github.com/users/williamcroberts","html_url":"https://github.com/williamcroberts","followers_url":"https://api.github.com/users/williamcroberts/followers","following_url":"https://api.github.com/users/williamcroberts/following{/other_user}","gists_url":"https://api.github.com/users/williamcroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/williamcroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamcroberts/subscriptions","organizations_url":"https://api.github.com/users/williamcroberts/orgs","repos_url":"https://api.github.com/users/williamcroberts/repos","events_url":"https://api.github.com/users/williamcroberts/events{/privacy}","received_events_url":"https://api.github.com/users/williamcroberts/received_events","type":"User","site_admin":false},"repo":{"id":75121993,"name":"tpm2.0-tools","full_name":"williamcroberts/tpm2.0-tools","owner":{"login":"williamcroberts","id":17750791,"avatar_url":"https://avatars0.githubusercontent.com/u/17750791?v=4","gravatar_id":"","url":"https://api.github.com/users/williamcroberts","html_url":"https://github.com/williamcroberts","followers_url":"https://api.github.com/users/williamcroberts/followers","following_url":"https://api.github.com/users/williamcroberts/following{/other_user}","gists_url":"https://api.github.com/users/williamcroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/williamcroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamcroberts/subscriptions","organizations_url":"https://api.github.com/users/williamcroberts/orgs","repos_url":"https://api.github.com/users/williamcroberts/repos","events_url":"https://api.github.com/users/williamcroberts/events{/privacy}","received_events_url":"https://api.github.com/users/williamcroberts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/williamcroberts/tpm2.0-tools","description":null,"fork":true,"url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools","forks_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/forks","keys_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/teams","hooks_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/hooks","issue_events_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/issues/events{/number}","events_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/events","assignees_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/assignees{/user}","branches_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/branches{/branch}","tags_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/tags","blobs_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/languages","stargazers_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/stargazers","contributors_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/contributors","subscribers_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/subscribers","subscription_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/subscription","commits_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/contents/{+path}","compare_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/merges","archive_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/downloads","issues_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/issues{/number}","pulls_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/labels{/name}","releases_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/releases{/id}","deployments_url":"https://api.github.com/repos/williamcroberts/tpm2.0-tools/deployments","created_at":"2016-11-29T21:05:25Z","updated_at":"2017-06-19T21:35:45Z","pushed_at":"2018-02-21T04:29:57Z","git_url":"git://github.com/williamcroberts/tpm2.0-tools.git","ssh_url":"git@github.com:williamcroberts/tpm2.0-tools.git","clone_url":"https://github.com/williamcroberts/tpm2.0-tools.git","svn_url":"https://github.com/williamcroberts/tpm2.0-tools","homepage":null,"size":3823,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tpm2-software:master","ref":"master","sha":"1f218d99dec6c1ca11fee5d668970fdabb05ae56","user":{"login":"tpm2-software","id":34488697,"avatar_url":"https://avatars3.githubusercontent.com/u/34488697?v=4","gravatar_id":"","url":"https://api.github.com/users/tpm2-software","html_url":"https://github.com/tpm2-software","followers_url":"https://api.github.com/users/tpm2-software/followers","following_url":"https://api.github.com/users/tpm2-software/following{/other_user}","gists_url":"https://api.github.com/users/tpm2-software/gists{/gist_id}","starred_url":"https://api.github.com/users/tpm2-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpm2-software/subscriptions","organizations_url":"https://api.github.com/users/tpm2-software/orgs","repos_url":"https://api.github.com/users/tpm2-software/repos","events_url":"https://api.github.com/users/tpm2-software/events{/privacy}","received_events_url":"https://api.github.com/users/tpm2-software/received_events","type":"Organization","site_admin":false},"repo":{"id":41126332,"name":"tpm2-tools","full_name":"tpm2-software/tpm2-tools","owner":{"login":"tpm2-software","id":34488697,"avatar_url":"https://avatars3.githubusercontent.com/u/34488697?v=4","gravatar_id":"","url":"https://api.github.com/users/tpm2-software","html_url":"https://github.com/tpm2-software","followers_url":"https://api.github.com/users/tpm2-software/followers","following_url":"https://api.github.com/users/tpm2-software/following{/other_user}","gists_url":"https://api.github.com/users/tpm2-software/gists{/gist_id}","starred_url":"https://api.github.com/users/tpm2-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpm2-software/subscriptions","organizations_url":"https://api.github.com/users/tpm2-software/orgs","repos_url":"https://api.github.com/users/tpm2-software/repos","events_url":"https://api.github.com/users/tpm2-software/events{/privacy}","received_events_url":"https://api.github.com/users/tpm2-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tpm2-software/tpm2-tools","description":"The source repository for the TPM (Trusted Platform Module) 2 tools","fork":false,"url":"https://api.github.com/repos/tpm2-software/tpm2-tools","forks_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/forks","keys_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/teams","hooks_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/hooks","issue_events_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues/events{/number}","events_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/events","assignees_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/assignees{/user}","branches_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/branches{/branch}","tags_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/tags","blobs_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/languages","stargazers_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/stargazers","contributors_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/contributors","subscribers_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/subscribers","subscription_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/subscription","commits_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/contents/{+path}","compare_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/merges","archive_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/downloads","issues_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues{/number}","pulls_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/labels{/name}","releases_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/releases{/id}","deployments_url":"https://api.github.com/repos/tpm2-software/tpm2-tools/deployments","created_at":"2015-08-21T01:07:28Z","updated_at":"2018-02-21T00:02:26Z","pushed_at":"2018-02-21T04:29:58Z","git_url":"git://github.com/tpm2-software/tpm2-tools.git","ssh_url":"git@github.com:tpm2-software/tpm2-tools.git","clone_url":"https://github.com/tpm2-software/tpm2-tools.git","svn_url":"https://github.com/tpm2-software/tpm2-tools","homepage":"","size":3807,"stargazers_count":90,"watchers_count":90,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":74,"open_issues":73,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898"},"html":{"href":"https://github.com/tpm2-software/tpm2-tools/pull/898"},"issue":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues/898"},"comments":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tools/statuses/8fd9baeef98f8bcc1ba3a611a1688c7b422a469c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martinezjavier"}}