{"action":"opened","number":65,"pull_request":{"url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/65","id":215809202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODA5MjAy","html_url":"https://github.com/line-school2018summer/tokyo-c-client/pull/65","diff_url":"https://github.com/line-school2018summer/tokyo-c-client/pull/65.diff","patch_url":"https://github.com/line-school2018summer/tokyo-c-client/pull/65.patch","issue_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/65","number":65,"state":"open","locked":false,"title":"バグとり","user":{"login":"hatiparallel","id":42106190,"node_id":"MDQ6VXNlcjQyMTA2MTkw","avatar_url":"https://avatars3.githubusercontent.com/u/42106190?v=4","gravatar_id":"","url":"https://api.github.com/users/hatiparallel","html_url":"https://github.com/hatiparallel","followers_url":"https://api.github.com/users/hatiparallel/followers","following_url":"https://api.github.com/users/hatiparallel/following{/other_user}","gists_url":"https://api.github.com/users/hatiparallel/gists{/gist_id}","starred_url":"https://api.github.com/users/hatiparallel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatiparallel/subscriptions","organizations_url":"https://api.github.com/users/hatiparallel/orgs","repos_url":"https://api.github.com/users/hatiparallel/repos","events_url":"https://api.github.com/users/hatiparallel/events{/privacy}","received_events_url":"https://api.github.com/users/hatiparallel/received_events","type":"User","site_admin":false},"body":"MemberProfileActivityとかの新しいファイルが作られていますが、いったん気にしないでください。存在しているだけです。\r\n\r\n今回、以下2点のバグを除きました（少なくとも僕の手元では何度も試して今のところ起こらなくなっています）。\r\n・自分自身が知らぬ間に他人になっている\r\n・なんか何もしていないときに突然通知が来る\r\n\r\n以下、詳しいバグの原因の説明です。暇なら読んでください。\r\n\r\nこの2つの原因となっていたのはMember.lookupの中です。\r\ncacheをclient.getPersonの返り値として新たに定義したことにより、ここで強制的にisFriendが2になっています。これにより何が起こるかというと、PollingActivityにおいて\r\n・新しいメッセージが来たとき、そのauthorをMember.lookupに渡しているので、「自分自身からのメッセージを受信した瞬間に自分自身が他人になる」という現象が起きる。\r\n・友達情報の更新時刻となる5分を過ぎたとき、PollingActivityから呼んだMember.lookupの中でそいつのisFriendをRelation.OTHERにしたあとで、呼び出し元のPollingActivityでもう一度isFriendをRelation.FRIENDにしている。これによって「友達になったよ～」って通知が来る。","created_at":"2018-09-16T07:51:43Z","updated_at":"2018-09-16T07:51:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/65/commits","review_comments_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/65/comments","review_comment_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/65/comments","statuses_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/statuses/01f6eac39bcc1f5b99fdc3da80c84fcf609b3e17","head":{"label":"line-school2018summer:kawashima","ref":"kawashima","sha":"01f6eac39bcc1f5b99fdc3da80c84fcf609b3e17","user":{"login":"line-school2018summer","id":42237401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM3NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/42237401?v=4","gravatar_id":"","url":"https://api.github.com/users/line-school2018summer","html_url":"https://github.com/line-school2018summer","followers_url":"https://api.github.com/users/line-school2018summer/followers","following_url":"https://api.github.com/users/line-school2018summer/following{/other_user}","gists_url":"https://api.github.com/users/line-school2018summer/gists{/gist_id}","starred_url":"https://api.github.com/users/line-school2018summer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line-school2018summer/subscriptions","organizations_url":"https://api.github.com/users/line-school2018summer/orgs","repos_url":"https://api.github.com/users/line-school2018summer/repos","events_url":"https://api.github.com/users/line-school2018summer/events{/privacy}","received_events_url":"https://api.github.com/users/line-school2018summer/received_events","type":"Organization","site_admin":false},"repo":{"id":144242805,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyNDI4MDU=","name":"tokyo-c-client","full_name":"line-school2018summer/tokyo-c-client","private":false,"owner":{"login":"line-school2018summer","id":42237401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM3NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/42237401?v=4","gravatar_id":"","url":"https://api.github.com/users/line-school2018summer","html_url":"https://github.com/line-school2018summer","followers_url":"https://api.github.com/users/line-school2018summer/followers","following_url":"https://api.github.com/users/line-school2018summer/following{/other_user}","gists_url":"https://api.github.com/users/line-school2018summer/gists{/gist_id}","starred_url":"https://api.github.com/users/line-school2018summer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line-school2018summer/subscriptions","organizations_url":"https://api.github.com/users/line-school2018summer/orgs","repos_url":"https://api.github.com/users/line-school2018summer/repos","events_url":"https://api.github.com/users/line-school2018summer/events{/privacy}","received_events_url":"https://api.github.com/users/line-school2018summer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/line-school2018summer/tokyo-c-client","description":null,"fork":false,"url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client","forks_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/forks","keys_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/teams","hooks_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/hooks","issue_events_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/events{/number}","events_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/events","assignees_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/assignees{/user}","branches_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/branches{/branch}","tags_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/tags","blobs_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/statuses/{sha}","languages_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/languages","stargazers_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/stargazers","contributors_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/contributors","subscribers_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/subscribers","subscription_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/subscription","commits_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/contents/{+path}","compare_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/merges","archive_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/downloads","issues_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues{/number}","pulls_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls{/number}","milestones_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/milestones{/number}","notifications_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/labels{/name}","releases_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/releases{/id}","deployments_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/deployments","created_at":"2018-08-10T05:54:31Z","updated_at":"2018-09-15T09:59:23Z","pushed_at":"2018-09-16T07:40:04Z","git_url":"git://github.com/line-school2018summer/tokyo-c-client.git","ssh_url":"git@github.com:line-school2018summer/tokyo-c-client.git","clone_url":"https://github.com/line-school2018summer/tokyo-c-client.git","svn_url":"https://github.com/line-school2018summer/tokyo-c-client","homepage":null,"size":473,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"line-school2018summer:master","ref":"master","sha":"99965a69e0e6021bc396a4b5e728ae284c196757","user":{"login":"line-school2018summer","id":42237401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM3NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/42237401?v=4","gravatar_id":"","url":"https://api.github.com/users/line-school2018summer","html_url":"https://github.com/line-school2018summer","followers_url":"https://api.github.com/users/line-school2018summer/followers","following_url":"https://api.github.com/users/line-school2018summer/following{/other_user}","gists_url":"https://api.github.com/users/line-school2018summer/gists{/gist_id}","starred_url":"https://api.github.com/users/line-school2018summer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line-school2018summer/subscriptions","organizations_url":"https://api.github.com/users/line-school2018summer/orgs","repos_url":"https://api.github.com/users/line-school2018summer/repos","events_url":"https://api.github.com/users/line-school2018summer/events{/privacy}","received_events_url":"https://api.github.com/users/line-school2018summer/received_events","type":"Organization","site_admin":false},"repo":{"id":144242805,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyNDI4MDU=","name":"tokyo-c-client","full_name":"line-school2018summer/tokyo-c-client","private":false,"owner":{"login":"line-school2018summer","id":42237401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM3NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/42237401?v=4","gravatar_id":"","url":"https://api.github.com/users/line-school2018summer","html_url":"https://github.com/line-school2018summer","followers_url":"https://api.github.com/users/line-school2018summer/followers","following_url":"https://api.github.com/users/line-school2018summer/following{/other_user}","gists_url":"https://api.github.com/users/line-school2018summer/gists{/gist_id}","starred_url":"https://api.github.com/users/line-school2018summer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line-school2018summer/subscriptions","organizations_url":"https://api.github.com/users/line-school2018summer/orgs","repos_url":"https://api.github.com/users/line-school2018summer/repos","events_url":"https://api.github.com/users/line-school2018summer/events{/privacy}","received_events_url":"https://api.github.com/users/line-school2018summer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/line-school2018summer/tokyo-c-client","description":null,"fork":false,"url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client","forks_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/forks","keys_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/teams","hooks_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/hooks","issue_events_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/events{/number}","events_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/events","assignees_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/assignees{/user}","branches_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/branches{/branch}","tags_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/tags","blobs_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/statuses/{sha}","languages_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/languages","stargazers_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/stargazers","contributors_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/contributors","subscribers_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/subscribers","subscription_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/subscription","commits_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/contents/{+path}","compare_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/merges","archive_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/downloads","issues_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues{/number}","pulls_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls{/number}","milestones_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/milestones{/number}","notifications_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/labels{/name}","releases_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/releases{/id}","deployments_url":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/deployments","created_at":"2018-08-10T05:54:31Z","updated_at":"2018-09-15T09:59:23Z","pushed_at":"2018-09-16T07:40:04Z","git_url":"git://github.com/line-school2018summer/tokyo-c-client.git","ssh_url":"git@github.com:line-school2018summer/tokyo-c-client.git","clone_url":"https://github.com/line-school2018summer/tokyo-c-client.git","svn_url":"https://github.com/line-school2018summer/tokyo-c-client","homepage":null,"size":473,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/65"},"html":{"href":"https://github.com/line-school2018summer/tokyo-c-client/pull/65"},"issue":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/65"},"comments":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/line-school2018summer/tokyo-c-client/statuses/01f6eac39bcc1f5b99fdc3da80c84fcf609b3e17"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":131,"deletions":23,"changed_files":9}}
{"actor":{"display_login":"hatiparallel"}}