{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments/240891762","pull_request_review_id":184024178,"id":240891762,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDg5MTc2Mg==","diff_hunk":"@@ -1941,12 +1941,30 @@ function isLintable(document: vscode.TextDocument): boolean {\n     return document.languageId === 'yaml' || document.languageId === 'json' || document.languageId === 'helm';\n }\n \n+function linterEnabled(enabledLinters: string[], name: string): boolean {\n+    for (const linter of enabledLinters) {\n+        if (linter === name) {\n+            return true;\n+        }\n+    }\n+    return false;\n+}\n+\n async function kubernetesLint(document: vscode.TextDocument): Promise<void> {\n     // Is it a Kubernetes document?\n     if (!isLintable(document)) {\n         return;\n     }\n-    const linterPromises = linters.map((l) => l.lint(document));\n+    const enabledLinters = config.getEnabledLinters();\n+    if (enabledLinters.length === 0) {\n+        return;\n+    }\n+    const linterPromises: Promise<vscode.Diagnostic[]>[] = [];\n+    linters.map((l) => {","path":"src/extension.ts","position":null,"original_position":24,"commit_id":"62b110d84f09dab3fe54cc141b92014f618fa6bf","original_commit_id":"795a7e2e8d6e4e715d62ba0a688eade0d0a4ced8","user":{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-12-12T06:09:30Z","updated_at":"2018-12-12T06:09:31Z","html_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/411#discussion_r240891762","pull_request_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments/240891762"},"html":{"href":"https://github.com/Azure/vscode-kubernetes-tools/pull/411#discussion_r240891762"},"pull_request":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411"}},"in_reply_to_id":240309270},"pull_request":{"url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411","id":236337211,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzM3MjEx","html_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/411","diff_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/411.diff","patch_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/411.patch","issue_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/411","number":411,"state":"open","locked":false,"title":"Add configuration for enable/disable linters.","user":{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"body":"Fixes #408 #399 ","created_at":"2018-12-05T21:59:05Z","updated_at":"2018-12-12T06:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbe27bc04e88e372d2092547c95e7c0863762f93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411/commits","review_comments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411/comments","review_comment_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/411/comments","statuses_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/statuses/62b110d84f09dab3fe54cc141b92014f618fa6bf","head":{"label":"brendandburns:linter","ref":"linter","sha":"62b110d84f09dab3fe54cc141b92014f618fa6bf","user":{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"repo":{"id":128458750,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0NTg3NTA=","name":"vscode-kubernetes-tools","full_name":"brendandburns/vscode-kubernetes-tools","private":false,"owner":{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brendandburns/vscode-kubernetes-tools","description":"Kubernetes extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools","forks_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/forks","keys_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/teams","hooks_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/hooks","issue_events_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/issues/events{/number}","events_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/events","assignees_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/assignees{/user}","branches_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/branches{/branch}","tags_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/tags","blobs_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/languages","stargazers_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/stargazers","contributors_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/contributors","subscribers_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/subscribers","subscription_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/subscription","commits_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/contents/{+path}","compare_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/merges","archive_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/downloads","issues_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/issues{/number}","pulls_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/labels{/name}","releases_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/releases{/id}","deployments_url":"https://api.github.com/repos/brendandburns/vscode-kubernetes-tools/deployments","created_at":"2018-04-06T19:38:11Z","updated_at":"2018-04-06T19:38:13Z","pushed_at":"2018-12-12T06:08:31Z","git_url":"git://github.com/brendandburns/vscode-kubernetes-tools.git","ssh_url":"git@github.com:brendandburns/vscode-kubernetes-tools.git","clone_url":"https://github.com/brendandburns/vscode-kubernetes-tools.git","svn_url":"https://github.com/brendandburns/vscode-kubernetes-tools","homepage":null,"size":4708,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"61e13f4b2353ada70ec0e3207cc099aabfe734e7","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":98263285,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI2MzI4NQ==","name":"vscode-kubernetes-tools","full_name":"Azure/vscode-kubernetes-tools","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/vscode-kubernetes-tools","description":"Kubernetes extension for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools","forks_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/forks","keys_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/teams","hooks_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/hooks","issue_events_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/events","assignees_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/tags","blobs_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/languages","stargazers_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/stargazers","contributors_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/contributors","subscribers_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/subscribers","subscription_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/subscription","commits_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/merges","archive_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/downloads","issues_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/labels{/name}","releases_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/deployments","created_at":"2017-07-25T04:12:07Z","updated_at":"2018-12-12T04:58:42Z","pushed_at":"2018-12-12T06:08:32Z","git_url":"git://github.com/Azure/vscode-kubernetes-tools.git","ssh_url":"git@github.com:Azure/vscode-kubernetes-tools.git","clone_url":"https://github.com/Azure/vscode-kubernetes-tools.git","svn_url":"https://github.com/Azure/vscode-kubernetes-tools","homepage":null,"size":4779,"stargazers_count":161,"watchers_count":161,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":53,"open_issues":63,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411"},"html":{"href":"https://github.com/Azure/vscode-kubernetes-tools/pull/411"},"issue":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/411"},"comments":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/statuses/62b110d84f09dab3fe54cc141b92014f618fa6bf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"brendandburns"}}