{"action":"created","issue":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/280","repository_url":"https://api.github.com/repos/jtablesaw/tablesaw","labels_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/280/comments","events_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/280/events","html_url":"https://github.com/jtablesaw/tablesaw/issues/280","id":315626594,"node_id":"MDU6SXNzdWUzMTU2MjY1OTQ=","number":280,"title":"Document some examples using Smile and Tablesaw together","user":{"login":"lwhite1","id":3430274,"node_id":"MDQ6VXNlcjM0MzAyNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3430274?v=4","gravatar_id":"","url":"https://api.github.com/users/lwhite1","html_url":"https://github.com/lwhite1","followers_url":"https://api.github.com/users/lwhite1/followers","following_url":"https://api.github.com/users/lwhite1/following{/other_user}","gists_url":"https://api.github.com/users/lwhite1/gists{/gist_id}","starred_url":"https://api.github.com/users/lwhite1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwhite1/subscriptions","organizations_url":"https://api.github.com/users/lwhite1/orgs","repos_url":"https://api.github.com/users/lwhite1/repos","events_url":"https://api.github.com/users/lwhite1/events{/privacy}","received_events_url":"https://api.github.com/users/lwhite1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-04-18T20:16:11Z","updated_at":"2018-07-16T16:49:21Z","closed_at":null,"author_association":"COLLABORATOR","body":"The current development branch removes Smile integration. As it is nearing completion, I'm considering adding it back, since it wouldn't be too much work (probably) to bring it in line with the changes not that they're settling down.\r\n\r\nIf you have an opinion on the matter, it would be a great time to make your voice heard. \r\n\r\nAdding @ms123s, in case you would like to weigh in. "},"comment":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/comments/405312036","html_url":"https://github.com/jtablesaw/tablesaw/issues/280#issuecomment-405312036","issue_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/280","id":405312036,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTMxMjAzNg==","user":{"login":"benmccann","id":322311,"node_id":"MDQ6VXNlcjMyMjMxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/322311?v=4","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T16:49:21Z","updated_at":"2018-07-16T16:49:21Z","author_association":"COLLABORATOR","body":"K-fold cross validation is one example I remember hitting. I had to switch most of my code to Smile directly to do it. Another thing that was frustrating was trying to use the Smile documentation because I'd have to figure out what the Tablesaw equivalent of each operation was\r\n\r\nYes, agreed on the variable names. That's my biggest issue with using Smile directly. [I filed an issue about that in the Smile repo](https://github.com/haifengl/smile/issues/297) and the maintainer replied \"will do\". I just sent [a PR to add the feature directly to Smile](https://github.com/haifengl/smile/pull/336)\r\n\r\n[I just filed an issue for the OLS fitted values as well](https://github.com/haifengl/smile/issues/334). It's another thing that really seems like it belongs in Smile directly that we could add there\r\n\r\nEven if we wanted a wrapper, our wrappers would be much cleaner with this functionality in Smile. E.g. we took the String output of the Smile `OLS` and did a find and replace on the variable names previously. With these improvements to Smile, we could probably just create converter classes that returned the Smile objects directly instead of entirely wrapping them. That'd probably be a lot nicer for users as they'd then have access to 100% of the Smile functionality and could use the Smile documentation"}}
{"actor":{"display_login":"benmccann"}}