{"action":"created","issue":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1239","repository_url":"https://api.github.com/repos/lightningnetwork/lnd","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1239/labels{/name}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1239/comments","events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1239/events","html_url":"https://github.com/lightningnetwork/lnd/pull/1239","id":322267019,"number":1239,"title":"walletunlocker/lnd: eliminate extra scrypt invocation","user":{"login":"guggero","id":1008879,"avatar_url":"https://avatars0.githubusercontent.com/u/1008879?v=4","gravatar_id":"","url":"https://api.github.com/users/guggero","html_url":"https://github.com/guggero","followers_url":"https://api.github.com/users/guggero/followers","following_url":"https://api.github.com/users/guggero/following{/other_user}","gists_url":"https://api.github.com/users/guggero/gists{/gist_id}","starred_url":"https://api.github.com/users/guggero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guggero/subscriptions","organizations_url":"https://api.github.com/users/guggero/orgs","repos_url":"https://api.github.com/users/guggero/repos","events_url":"https://api.github.com/users/guggero/events{/privacy}","received_events_url":"https://api.github.com/users/guggero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-11T11:42:34Z","updated_at":"2018-05-21T21:15:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/1239","html_url":"https://github.com/lightningnetwork/lnd/pull/1239","diff_url":"https://github.com/lightningnetwork/lnd/pull/1239.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/1239.patch"},"body":"This PR fixes #1223:\r\nThe number of scrypt invocations is reduced from 3 to 2 by passing the unlocked wallet instance back from the `UnlockerService` when using the `unlock` command.\r\n\r\nI wasn't able to see a big decrease in the time needed to unlock the wallet on my fast notebook (around 3.2 seconds, both with and without the improvement).\r\nBut as mentioned in the issue, this should be more noticeable on devices with less computing power."},"comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments/390785304","html_url":"https://github.com/lightningnetwork/lnd/pull/1239#issuecomment-390785304","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/1239","id":390785304,"user":{"login":"cfromknecht","id":2013993,"avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T21:15:50Z","updated_at":"2018-05-21T21:15:50Z","author_association":"COLLABORATOR","body":"tACK! Tried this locally and time to spin up lnd dropped dramatically. From what I could discern from the logs it looks like it might have taken off about 1.2s :)\r\n\r\nCan you split up the commits so there is one per modified file??"}}
{"actor":{"display_login":"cfromknecht"}}