{"action":"created","issue":{"url":"https://api.github.com/repos/cms-dev/cms/issues/937","repository_url":"https://api.github.com/repos/cms-dev/cms","labels_url":"https://api.github.com/repos/cms-dev/cms/issues/937/labels{/name}","comments_url":"https://api.github.com/repos/cms-dev/cms/issues/937/comments","events_url":"https://api.github.com/repos/cms-dev/cms/issues/937/events","html_url":"https://github.com/cms-dev/cms/pull/937","id":314059121,"number":937,"title":"Simplify evaluation_step_after_run","user":{"login":"stefano-maggiolo","id":485490,"avatar_url":"https://avatars2.githubusercontent.com/u/485490?v=4","gravatar_id":"","url":"https://api.github.com/users/stefano-maggiolo","html_url":"https://github.com/stefano-maggiolo","followers_url":"https://api.github.com/users/stefano-maggiolo/followers","following_url":"https://api.github.com/users/stefano-maggiolo/following{/other_user}","gists_url":"https://api.github.com/users/stefano-maggiolo/gists{/gist_id}","starred_url":"https://api.github.com/users/stefano-maggiolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefano-maggiolo/subscriptions","organizations_url":"https://api.github.com/users/stefano-maggiolo/orgs","repos_url":"https://api.github.com/users/stefano-maggiolo/repos","events_url":"https://api.github.com/users/stefano-maggiolo/events{/privacy}","received_events_url":"https://api.github.com/users/stefano-maggiolo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-13T10:45:59Z","updated_at":"2018-04-13T10:55:58Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cms-dev/cms/pulls/937","html_url":"https://github.com/cms-dev/cms/pull/937","diff_url":"https://github.com/cms-dev/cms/pull/937.diff","patch_url":"https://github.com/cms-dev/cms/pull/937.patch"},"body":"This is intended to be just a simplification without change in behaviour (apart from different log strings).\r\n\r\nPossible future change: add an \"evaluation_success\" return value and get rid of is_evaluation_passed\r\n\r\nLikely future change: reorganize the evaluation steps to return the correct stats for all processes in all cases.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cms-dev/cms/937)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cms-dev/cms/issues/comments/381100481","html_url":"https://github.com/cms-dev/cms/pull/937#issuecomment-381100481","issue_url":"https://api.github.com/repos/cms-dev/cms/issues/937","id":381100481,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-04-13T10:55:58Z","updated_at":"2018-04-13T10:55:58Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=h1) Report\n> Merging [#937](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=desc) into [master](https://codecov.io/gh/cms-dev/cms/commit/274e1512e98c0933a784536b8117ba267edebd11?src=pr&el=desc) will **decrease** coverage by `0.11%`.\n> The diff coverage is `50%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/cms-dev/cms/pull/937/graphs/tree.svg?token=XVAwZdiUV8&src=pr&height=150&width=650)](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #937      +/-   ##\n==========================================\n- Coverage   62.16%   62.05%   -0.12%     \n==========================================\n  Files         209      209              \n  Lines       17060    17049      -11     \n==========================================\n- Hits        10606    10580      -26     \n- Misses       6454     6469      +15\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #functionaltests | `47.32% <50%> (-0.15%)` | :arrow_down: |\n| #unittests | `38.26% <0%> (+0.01%)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cms/grading/\\_\\_init\\_\\_.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL2dyYWRpbmcvX19pbml0X18ucHk=) | `69.23% <50%> (-1.83%)` | :arrow_down: |\n| [cms/io/service.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL2lvL3NlcnZpY2UucHk=) | `73.41% <0%> (-2.9%)` | :arrow_down: |\n| [cms/io/triggeredservice.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL2lvL3RyaWdnZXJlZHNlcnZpY2UucHk=) | `88% <0%> (-2%)` | :arrow_down: |\n| [cms/server/contest/handlers/taskusertest.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9jb250ZXN0L2hhbmRsZXJzL3Rhc2t1c2VydGVzdC5weQ==) | `46.88% <0%> (-1.84%)` | :arrow_down: |\n| [cms/grading/tasktypes/Batch.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL2dyYWRpbmcvdGFza3R5cGVzL0JhdGNoLnB5) | `81.66% <0%> (-1.67%)` | :arrow_down: |\n| [cms/io/rpc.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL2lvL3JwYy5weQ==) | `93.37% <0%> (-1.4%)` | :arrow_down: |\n| [cms/service/Worker.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvV29ya2VyLnB5) | `84.21% <0%> (-1.06%)` | :arrow_down: |\n| [cms/server/contest/handlers/contest.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9jb250ZXN0L2hhbmRsZXJzL2NvbnRlc3QucHk=) | `89.1% <0%> (-1%)` | :arrow_down: |\n| [cms/service/EvaluationService.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvRXZhbHVhdGlvblNlcnZpY2UucHk=) | `67.94% <0%> (-0.77%)` | :arrow_down: |\n| [cms/server/contest/handlers/tasksubmission.py](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9jb250ZXN0L2hhbmRsZXJzL3Rhc2tzdWJtaXNzaW9uLnB5) | `48.27% <0%> (-0.39%)` | :arrow_down: |\n| ... and [8 more](https://codecov.io/gh/cms-dev/cms/pull/937/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=footer). Last update [274e151...8ad2a37](https://codecov.io/gh/cms-dev/cms/pull/937?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}