{"action":"created","issue":{"url":"https://api.github.com/repos/hydroshare/hydroshare/issues/2688","repository_url":"https://api.github.com/repos/hydroshare/hydroshare","labels_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/2688/labels{/name}","comments_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/2688/comments","events_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/2688/events","html_url":"https://github.com/hydroshare/hydroshare/pull/2688","id":307021706,"number":2688,"title":"2673 comma delimiter","user":{"login":"sblack-usu","id":35820390,"avatar_url":"https://avatars1.githubusercontent.com/u/35820390?v=4","gravatar_id":"","url":"https://api.github.com/users/sblack-usu","html_url":"https://github.com/sblack-usu","followers_url":"https://api.github.com/users/sblack-usu/followers","following_url":"https://api.github.com/users/sblack-usu/following{/other_user}","gists_url":"https://api.github.com/users/sblack-usu/gists{/gist_id}","starred_url":"https://api.github.com/users/sblack-usu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sblack-usu/subscriptions","organizations_url":"https://api.github.com/users/sblack-usu/orgs","repos_url":"https://api.github.com/users/sblack-usu/repos","events_url":"https://api.github.com/users/sblack-usu/events{/privacy}","received_events_url":"https://api.github.com/users/sblack-usu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-20T20:14:34Z","updated_at":"2018-03-21T19:58:40Z","closed_at":"2018-03-21T19:58:36Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hydroshare/hydroshare/pulls/2688","html_url":"https://github.com/hydroshare/hydroshare/pull/2688","diff_url":"https://github.com/hydroshare/hydroshare/pull/2688.diff","patch_url":"https://github.com/hydroshare/hydroshare/pull/2688.patch"},"body":"<!--\r\n\r\nPlease read, and add your text at the bottom of this message.\r\n\r\nThanks for contributing code to HydroShare. In order to maintain code quality and expedite this process, please assist the development team by making sure the following is present in this pull request.\r\n\r\nFor more information, see https://docs.google.com/document/d/1dzxqlZW5fKNEyQSeKiSFq-SmS-VOPCva95XXkBjPExs\r\n\r\n-->\r\n\r\n### Pull Request Checklist: \r\n- [x] Positive Test Case Written by Dev\r\n\r\n<!-- Enter steps that a QA engineer, stakeholder, or user documentation writer would follow to test the positive or \"successful\" case of the functionality your code provides or fixes -->\r\n\r\n- [x] Automated Testing\r\n\r\n<!-- Our Jenkins Instance is set up to automatically test every commit from a pull request. Code coverage must not decrease so new functionality or code paths added during a bug fix must have appropriate tests written. Every test must pass, including PEP8 code formatting tests. -->\r\n\r\n- [x] Sufficient User and Developer Documentation\r\n\r\n<!-- Please email your positive test case lbrazil@cuahsi.org, who will make the decision regarding user documentation. -->\r\n\r\n- [x] Passing Jenkins Build\r\n\r\n<!-- Our Jenkins Instance is set up to automatically test every commit from a pull request. Every test must pass, including PEP8 code formatting tests. -->\r\n\r\n- [x] Peer Code review and approval\r\n\r\n<!-- This is the process by which a peer developer on the HydroShare team will read the changeset, provide feedback, and ultimately give a formal approval to the code before it passes PR status. -->\r\n\r\n### Positive Test Case\r\n1. Navigate to the signup page in hydroshare.  Add a few different organizations, include at least one organization with a comma (if you start typing puerto rico, you'll see some orgs with commas) and at least one without.  Create the account and activate it.  Navigate to the profile page and validate all the organizations are displayed correctly.\r\n\r\n2. With the same account created in test case 1, navigate to the profile and select edit.  Add and remove at least on organization with a comma and one organization without a comma.  Click save and validate the organizations displayed are correct.\r\n"},"comment":{"url":"https://api.github.com/repos/hydroshare/hydroshare/issues/comments/375075983","html_url":"https://github.com/hydroshare/hydroshare/pull/2688#issuecomment-375075983","issue_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/2688","id":375075983,"user":{"login":"Lizabrazil","id":13852599,"avatar_url":"https://avatars2.githubusercontent.com/u/13852599?v=4","gravatar_id":"","url":"https://api.github.com/users/Lizabrazil","html_url":"https://github.com/Lizabrazil","followers_url":"https://api.github.com/users/Lizabrazil/followers","following_url":"https://api.github.com/users/Lizabrazil/following{/other_user}","gists_url":"https://api.github.com/users/Lizabrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/Lizabrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lizabrazil/subscriptions","organizations_url":"https://api.github.com/users/Lizabrazil/orgs","repos_url":"https://api.github.com/users/Lizabrazil/repos","events_url":"https://api.github.com/users/Lizabrazil/events{/privacy}","received_events_url":"https://api.github.com/users/Lizabrazil/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T19:58:40Z","updated_at":"2018-03-21T19:58:40Z","author_association":"NONE","body":"If there are certain characters that are still not allowed in organization then that should be documented, please let me know if that is the case. It should really be documented on the interface level if a user tries to add an invalid character. "}}
{"actor":{"display_login":"Lizabrazil"}}