{"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/241601533","pull_request_review_id":184918342,"id":241601533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTYwMTUzMw==","diff_hunk":"@@ -10,9 +10,7 @@ export function createPipette (\n   tiprackModel: ?string,\n   overrideId?: string\n ): ?PipetteData {\n-  // for backwards compatibility, strip version suffix (_v1, _v1.3 etc)","path":"protocol-designer/src/pipettes/utils.js","position":12,"original_position":12,"commit_id":"f42cee22a2f59958d50927e63092d8d86ab090f6","original_commit_id":"f42cee22a2f59958d50927e63092d8d86ab090f6","user":{"login":"IanLondon","id":11590381,"node_id":"MDQ6VXNlcjExNTkwMzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"factored this logic out to step-forms utils instead of copy-pasting it (we can remove this on the next JSON schema breaking change, it's from when name was optional and model was required)","created_at":"2018-12-13T23:39:33Z","updated_at":"2018-12-13T23:39:33Z","html_url":"https://github.com/Opentrons/opentrons/pull/2823#discussion_r241601533","pull_request_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/241601533"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/2823#discussion_r241601533"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823"}}},"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823","id":238567025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTY3MDI1","html_url":"https://github.com/Opentrons/opentrons/pull/2823","diff_url":"https://github.com/Opentrons/opentrons/pull/2823.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/2823.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/2823","number":2823,"state":"open","locked":false,"title":"refactor(protocol-designer): create step-form reducers","user":{"login":"IanLondon","id":11590381,"node_id":"MDQ6VXNlcjExNTkwMzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"## overview\r\n\r\nThis is a first step in the architecture change in which we're removing the \"initial state\" reducers labware/pipettes/liquids and making all \"initial state\" concerns a\r\n\r\nThe new are reducers under the `stepForms` in redux. Nothing is pulling from them yet.\r\n\r\nNo UI should be affected. All assessment of this PR has got to be in redux-devtools.\r\n\r\n## changelog\r\n\r\n* in comments\r\n\r\n## review requests\r\n\r\n`stepForms.labwareInvariantProperties` keeps track of the types (names? models? :angry: ) of all the labware that exist in the protocol (exist = has an ID anywhere in the state). This reducer should be synced with the labware on the deck when you:\r\n- create a new protocol (auto-generated tipracks should show up)\r\n- load a protocol\r\n- add a labware on the deck\r\n- delete a labware from the deck\r\n- and in all these cases, the fixed-trash should always be present under the id `trashId` (make sure you're looking at state not diff - I already confused myself doing that)\r\n\r\n`stepForms.pipetteInvariantProperties` keeps track of the names of pipettes (eg \"p10_single\") that exist in the protocol. This reducer should be synced with the pipettes you see on the File page when you:\r\n- create a new protocol\r\n- load a file\r\n- edit pipettes\r\n\r\nThe above reducers deal with properties that are invariant across time for a given entity (ie just labware type / pipette name).\r\n\r\nThe main philosophy guiding this refactor is: everything temporal that is able to change across the timeline goes into the step forms. So we have an \"invisible\" step form at `stepForms, with a special id `__INITIAL_DECK_SETUP_STEP__` which is used as a constant by actions which in the current design will only be able to affect the initial deck setup step and not other steps.\r\n\r\nSo `stepForms.savedStepForms.__INITIAL_DECK_SETUP_STEP__.labwareLocationUpdate` should always be synced with the labware locations you see on the deck in the UI:\r\n- create labware on the deck\r\n- delete labware from the deck\r\n- move a labware\r\n- create a new protocol (the automatically-generated tipracks you see in the UI should appear in here)\r\n- load a protocol (protocols with no __INITIAL_DECK_SETUP_STEP__ in the steplist should automatically get this step)\r\n- should always have `trashId: \"12\"` somewhere in there (make sure you're looking at state not diff)\r\n\r\nLastly, please take a glance and make sure all the other step forms are still updating normally. If you go around creating, editing, reordering, and deleting step forms thru the UI, the `stepForms.savedStepForms` and `steplist.savedStepForms` states should always sync and match exactly (except for the presence of the __INITIAL_DECK_SETUP_STEP__ in the new `stepForms`\r\n\r\n# Next steps (loose draft)\r\n\r\nMy immediate next step is doing the same stuff I did with labware here (in the initial deck setup step) with pipettes `pipetteId: mount`.\r\n\r\nThere's still a big hunk of work to do:\r\n- Move over the non-ui parts of the `steplist/` atom and\r\n- Gradually pointing the selectors away from the old `containers` and `pipettes` reducers, notably making robotStateTimeline and substep-timeline selectors use the initial labware/pipettes data from\r\n- Cleaning up handleFormChange and using it in the new unsavedForm and savedStepForms reducers\r\n","created_at":"2018-12-13T23:34:09Z","updated_at":"2018-12-13T23:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"711db8908b189f57155e6058968208b5dd7cafab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mcous","id":2963448,"node_id":"MDQ6VXNlcjI5NjM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false},{"login":"b-cooper","id":4731953,"node_id":"MDQ6VXNlcjQ3MzE5NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4731953?v=4","gravatar_id":"","url":"https://api.github.com/users/b-cooper","html_url":"https://github.com/b-cooper","followers_url":"https://api.github.com/users/b-cooper/followers","following_url":"https://api.github.com/users/b-cooper/following{/other_user}","gists_url":"https://api.github.com/users/b-cooper/gists{/gist_id}","starred_url":"https://api.github.com/users/b-cooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-cooper/subscriptions","organizations_url":"https://api.github.com/users/b-cooper/orgs","repos_url":"https://api.github.com/users/b-cooper/repos","events_url":"https://api.github.com/users/b-cooper/events{/privacy}","received_events_url":"https://api.github.com/users/b-cooper/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":749345056,"node_id":"MDU6TGFiZWw3NDkzNDUwNTY=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/WIP","name":"WIP","color":"bc0903","default":false},{"id":770645862,"node_id":"MDU6TGFiZWw3NzA2NDU4NjI=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/protocol%20designer","name":"protocol designer","color":"440f89","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/2823/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/f42cee22a2f59958d50927e63092d8d86ab090f6","head":{"label":"Opentrons:pd_experiment-refactor-reducers","ref":"pd_experiment-refactor-reducers","sha":"f42cee22a2f59958d50927e63092d8d86ab090f6","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","private":false,"owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-12-13T20:08:52Z","pushed_at":"2018-12-13T23:34:10Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":33538,"stargazers_count":88,"watchers_count":88,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":256,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":256,"watchers":88,"default_branch":"edge"}},"base":{"label":"Opentrons:edge","ref":"edge","sha":"f6559b14d3cfd2d24cb916a45057629e49ced69d","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","private":false,"owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-12-13T20:08:52Z","pushed_at":"2018-12-13T23:34:10Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":33538,"stargazers_count":88,"watchers_count":88,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":256,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":256,"watchers":88,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/2823"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/2823"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/2823/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2823/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/f42cee22a2f59958d50927e63092d8d86ab090f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"IanLondon"}}