{"action":"created","comment":{"url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments/239631708","pull_request_review_id":182468617,"id":239631708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTYzMTcwOA==","diff_hunk":"@@ -0,0 +1,46 @@\n+﻿using FluentAssertions;\r\n+using HomesEngland.UseCase.GenerateAssets;\r\n+using HomesEngland.UseCase.ImportAssets.Models;\r\n+using NUnit.Framework;\r\n+using HomesEngland.UseCase.Models;\r\n+\r\n+namespace HomesEnglandTest.UseCase.GenerateAssets\r\n+{\r\n+    [TestFixture]\r\n+    public class ImportAssetsInputParserTests\r\n+    {\r\n+        private IInputParser<ImportAssetConsoleInput> _classUnderTest;\r\n+        public ImportAssetsInputParserTests()\r\n+        {\r\n+            _classUnderTest = new ImportAssetInputParser();\r\n+        }\r\n+\r\n+        [TestCase(\"--file\", \"100\", \"--delimiter\", \";\")]\r\n+        [TestCase(\"--file\", \"200\", \"--delimiter\", \",\")]\r\n+        [TestCase(\"--file\", \"200\", \"--delimiter\", \"\\t\")]\r\n+        public void GivenValidInput_InputSanitizer_ReturnsRequest(string arg1, string arg2, string arg3, string arg4)\r\n+        {\r\n+            //arrange\r\n+            string[] args = new string[] { arg1, arg2, arg3,arg4 };\r\n+            //act\r\n+            var response = _classUnderTest.Parse(args);\r\n+            //assert\r\n+            response.Should().NotBeNull();\r\n+            response.Delimiter.Should().Be(arg4);\r\n+        }\r\n+\r\n+        [TestCase(\"--file\", \"100\", \"--delimite\", \";\")]\r\n+        [TestCase(\"--file\", \"200\", \"--delimter\", \",\")]\r\n+        [TestCase(\"--file\", \"200\", \"--delimier\", \"\\t\")]\r\n+        public void GivenInValidInput_InputSanitizer_ReturnsRequest(string arg1, string arg2, string arg3, string arg4)\r","path":"HomesEnglandTest/UseCase/GenerateAssets/ImportAssetsInputParserTests.cs","position":35,"original_position":35,"commit_id":"2b25ba47f1ff4c56f7361c084b1c968096422187","original_commit_id":"2b25ba47f1ff4c56f7361c084b1c968096422187","user":{"login":"danielburnley","id":976254,"node_id":"MDQ6VXNlcjk3NjI1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/976254?v=4","gravatar_id":"","url":"https://api.github.com/users/danielburnley","html_url":"https://github.com/danielburnley","followers_url":"https://api.github.com/users/danielburnley/followers","following_url":"https://api.github.com/users/danielburnley/following{/other_user}","gists_url":"https://api.github.com/users/danielburnley/gists{/gist_id}","starred_url":"https://api.github.com/users/danielburnley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielburnley/subscriptions","organizations_url":"https://api.github.com/users/danielburnley/orgs","repos_url":"https://api.github.com/users/danielburnley/repos","events_url":"https://api.github.com/users/danielburnley/events{/privacy}","received_events_url":"https://api.github.com/users/danielburnley/received_events","type":"User","site_admin":false},"body":"Could name these a bit better:\r\n\r\n```\r\nfileFlag, fileValue(?), delimiterFlag, delimiterValue\r\n```\r\n\r\nor something. I find it hard to read the test cases & method and understand what each part is","created_at":"2018-12-06T22:02:43Z","updated_at":"2018-12-06T22:06:33Z","html_url":"https://github.com/homes-england/asset-register-api/pull/81#discussion_r239631708","pull_request_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments/239631708"},"html":{"href":"https://github.com/homes-england/asset-register-api/pull/81#discussion_r239631708"},"pull_request":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81","id":236254765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjU0NzY1","html_url":"https://github.com/homes-england/asset-register-api/pull/81","diff_url":"https://github.com/homes-england/asset-register-api/pull/81.diff","patch_url":"https://github.com/homes-england/asset-register-api/pull/81.patch","issue_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/81","number":81,"state":"open","locked":false,"title":"Feature/csv importer","user":{"login":"PinkhamSoftware","id":5268123,"node_id":"MDQ6VXNlcjUyNjgxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268123?v=4","gravatar_id":"","url":"https://api.github.com/users/PinkhamSoftware","html_url":"https://github.com/PinkhamSoftware","followers_url":"https://api.github.com/users/PinkhamSoftware/followers","following_url":"https://api.github.com/users/PinkhamSoftware/following{/other_user}","gists_url":"https://api.github.com/users/PinkhamSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/PinkhamSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinkhamSoftware/subscriptions","organizations_url":"https://api.github.com/users/PinkhamSoftware/orgs","repos_url":"https://api.github.com/users/PinkhamSoftware/repos","events_url":"https://api.github.com/users/PinkhamSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/PinkhamSoftware/received_events","type":"User","site_admin":false},"body":"What this does:\r\n- Import csv file format\r\n- Allows for you to specify a delimiter\r\n\r\nWhat this doesn't do:\r\n- Test logging as this happens through extensions\r\n- Any validation on the data being imported.","created_at":"2018-12-05T17:11:20Z","updated_at":"2018-12-06T22:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daae056e7e065e5ddcb0ebdc7c391b194612471f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81/commits","review_comments_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81/comments","review_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/81/comments","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/2b25ba47f1ff4c56f7361c084b1c968096422187","head":{"label":"homes-england:feature/csv-importer","ref":"feature/csv-importer","sha":"2b25ba47f1ff4c56f7361c084b1c968096422187","user":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"repo":{"id":153280886,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODA4ODY=","name":"asset-register-api","full_name":"homes-england/asset-register-api","private":false,"owner":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/homes-england/asset-register-api","description":"Homes England Asset Register API","fork":false,"url":"https://api.github.com/repos/homes-england/asset-register-api","forks_url":"https://api.github.com/repos/homes-england/asset-register-api/forks","keys_url":"https://api.github.com/repos/homes-england/asset-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homes-england/asset-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homes-england/asset-register-api/teams","hooks_url":"https://api.github.com/repos/homes-england/asset-register-api/hooks","issue_events_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/homes-england/asset-register-api/events","assignees_url":"https://api.github.com/repos/homes-england/asset-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/homes-england/asset-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/homes-england/asset-register-api/tags","blobs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homes-england/asset-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/homes-england/asset-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/homes-england/asset-register-api/languages","stargazers_url":"https://api.github.com/repos/homes-england/asset-register-api/stargazers","contributors_url":"https://api.github.com/repos/homes-england/asset-register-api/contributors","subscribers_url":"https://api.github.com/repos/homes-england/asset-register-api/subscribers","subscription_url":"https://api.github.com/repos/homes-england/asset-register-api/subscription","commits_url":"https://api.github.com/repos/homes-england/asset-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/homes-england/asset-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/homes-england/asset-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/homes-england/asset-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homes-england/asset-register-api/merges","archive_url":"https://api.github.com/repos/homes-england/asset-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homes-england/asset-register-api/downloads","issues_url":"https://api.github.com/repos/homes-england/asset-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/homes-england/asset-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/homes-england/asset-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homes-england/asset-register-api/labels{/name}","releases_url":"https://api.github.com/repos/homes-england/asset-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/homes-england/asset-register-api/deployments","created_at":"2018-10-16T12:22:31Z","updated_at":"2018-12-05T15:15:38Z","pushed_at":"2018-12-06T16:37:22Z","git_url":"git://github.com/homes-england/asset-register-api.git","ssh_url":"git@github.com:homes-england/asset-register-api.git","clone_url":"https://github.com/homes-england/asset-register-api.git","svn_url":"https://github.com/homes-england/asset-register-api","homepage":"","size":463,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"homes-england:master","ref":"master","sha":"776429f06d5b4ae38d9d4c65a10cfa43db9b46ec","user":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"repo":{"id":153280886,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODA4ODY=","name":"asset-register-api","full_name":"homes-england/asset-register-api","private":false,"owner":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/homes-england/asset-register-api","description":"Homes England Asset Register API","fork":false,"url":"https://api.github.com/repos/homes-england/asset-register-api","forks_url":"https://api.github.com/repos/homes-england/asset-register-api/forks","keys_url":"https://api.github.com/repos/homes-england/asset-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homes-england/asset-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homes-england/asset-register-api/teams","hooks_url":"https://api.github.com/repos/homes-england/asset-register-api/hooks","issue_events_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/homes-england/asset-register-api/events","assignees_url":"https://api.github.com/repos/homes-england/asset-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/homes-england/asset-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/homes-england/asset-register-api/tags","blobs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homes-england/asset-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/homes-england/asset-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/homes-england/asset-register-api/languages","stargazers_url":"https://api.github.com/repos/homes-england/asset-register-api/stargazers","contributors_url":"https://api.github.com/repos/homes-england/asset-register-api/contributors","subscribers_url":"https://api.github.com/repos/homes-england/asset-register-api/subscribers","subscription_url":"https://api.github.com/repos/homes-england/asset-register-api/subscription","commits_url":"https://api.github.com/repos/homes-england/asset-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/homes-england/asset-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/homes-england/asset-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/homes-england/asset-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homes-england/asset-register-api/merges","archive_url":"https://api.github.com/repos/homes-england/asset-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homes-england/asset-register-api/downloads","issues_url":"https://api.github.com/repos/homes-england/asset-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/homes-england/asset-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/homes-england/asset-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homes-england/asset-register-api/labels{/name}","releases_url":"https://api.github.com/repos/homes-england/asset-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/homes-england/asset-register-api/deployments","created_at":"2018-10-16T12:22:31Z","updated_at":"2018-12-05T15:15:38Z","pushed_at":"2018-12-06T16:37:22Z","git_url":"git://github.com/homes-england/asset-register-api.git","ssh_url":"git@github.com:homes-england/asset-register-api.git","clone_url":"https://github.com/homes-england/asset-register-api.git","svn_url":"https://github.com/homes-england/asset-register-api","homepage":"","size":463,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81"},"html":{"href":"https://github.com/homes-england/asset-register-api/pull/81"},"issue":{"href":"https://api.github.com/repos/homes-england/asset-register-api/issues/81"},"comments":{"href":"https://api.github.com/repos/homes-england/asset-register-api/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/homes-england/asset-register-api/statuses/2b25ba47f1ff4c56f7361c084b1c968096422187"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielburnley"}}