{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments/185379301","pull_request_review_id":116754591,"id":185379301,"diff_hunk":"@@ -7,26 +7,30 @@ Abstract supertype for set objects used to encode constraints.\n \"\"\"\n abstract type AbstractSet end\n \n+\"\"\"\n+    dimension(s::AbstractSet)\n+\n+Return the underlying dimension (number of vector components) in the set `s`, i.e.,","path":"src/sets.jl","position":7,"original_position":7,"commit_id":"75302a6abe594bbc1e8a341842e6100ce4f4eab3","original_commit_id":"75302a6abe594bbc1e8a341842e6100ce4f4eab3","user":{"login":"mlubin","id":1733683,"avatar_url":"https://avatars3.githubusercontent.com/u/1733683?v=4","gravatar_id":"","url":"https://api.github.com/users/mlubin","html_url":"https://github.com/mlubin","followers_url":"https://api.github.com/users/mlubin/followers","following_url":"https://api.github.com/users/mlubin/following{/other_user}","gists_url":"https://api.github.com/users/mlubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlubin/subscriptions","organizations_url":"https://api.github.com/users/mlubin/orgs","repos_url":"https://api.github.com/users/mlubin/repos","events_url":"https://api.github.com/users/mlubin/events{/privacy}","received_events_url":"https://api.github.com/users/mlubin/received_events","type":"User","site_admin":false},"body":"\"number of vector components\" doesn't quite make sense anymore. Please clarify the definition.","created_at":"2018-05-02T02:08:10Z","updated_at":"2018-05-02T02:10:26Z","html_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/342#discussion_r185379301","pull_request_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments/185379301"},"html":{"href":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/342#discussion_r185379301"},"pull_request":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342","id":185303728,"html_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/342","diff_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/342.diff","patch_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/342.patch","issue_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/342","number":342,"state":"open","locked":false,"title":"Define dimension for AbstractScalarSet, add some tests.","user":{"login":"tkoolen","id":2585880,"avatar_url":"https://avatars0.githubusercontent.com/u/2585880?v=4","gravatar_id":"","url":"https://api.github.com/users/tkoolen","html_url":"https://github.com/tkoolen","followers_url":"https://api.github.com/users/tkoolen/followers","following_url":"https://api.github.com/users/tkoolen/following{/other_user}","gists_url":"https://api.github.com/users/tkoolen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkoolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkoolen/subscriptions","organizations_url":"https://api.github.com/users/tkoolen/orgs","repos_url":"https://api.github.com/users/tkoolen/repos","events_url":"https://api.github.com/users/tkoolen/events{/privacy}","received_events_url":"https://api.github.com/users/tkoolen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-01T23:47:39Z","updated_at":"2018-05-02T02:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aafb857b67c899037666bb2d509ca8bcb34828f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/342/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/75302a6abe594bbc1e8a341842e6100ce4f4eab3","head":{"label":"tkoolen:tk/scalar-dim","ref":"tk/scalar-dim","sha":"75302a6abe594bbc1e8a341842e6100ce4f4eab3","user":{"login":"tkoolen","id":2585880,"avatar_url":"https://avatars0.githubusercontent.com/u/2585880?v=4","gravatar_id":"","url":"https://api.github.com/users/tkoolen","html_url":"https://github.com/tkoolen","followers_url":"https://api.github.com/users/tkoolen/followers","following_url":"https://api.github.com/users/tkoolen/following{/other_user}","gists_url":"https://api.github.com/users/tkoolen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkoolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkoolen/subscriptions","organizations_url":"https://api.github.com/users/tkoolen/orgs","repos_url":"https://api.github.com/users/tkoolen/repos","events_url":"https://api.github.com/users/tkoolen/events{/privacy}","received_events_url":"https://api.github.com/users/tkoolen/received_events","type":"User","site_admin":false},"repo":{"id":121275256,"name":"MathOptInterface.jl","full_name":"tkoolen/MathOptInterface.jl","owner":{"login":"tkoolen","id":2585880,"avatar_url":"https://avatars0.githubusercontent.com/u/2585880?v=4","gravatar_id":"","url":"https://api.github.com/users/tkoolen","html_url":"https://github.com/tkoolen","followers_url":"https://api.github.com/users/tkoolen/followers","following_url":"https://api.github.com/users/tkoolen/following{/other_user}","gists_url":"https://api.github.com/users/tkoolen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkoolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkoolen/subscriptions","organizations_url":"https://api.github.com/users/tkoolen/orgs","repos_url":"https://api.github.com/users/tkoolen/repos","events_url":"https://api.github.com/users/tkoolen/events{/privacy}","received_events_url":"https://api.github.com/users/tkoolen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkoolen/MathOptInterface.jl","description":"An abstraction layer for mathematical optimization solvers.","fork":true,"url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl","forks_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/forks","keys_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/teams","hooks_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/events","assignees_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/tags","blobs_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/languages","stargazers_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/subscription","commits_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/merges","archive_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/downloads","issues_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/releases{/id}","deployments_url":"https://api.github.com/repos/tkoolen/MathOptInterface.jl/deployments","created_at":"2018-02-12T17:00:30Z","updated_at":"2018-02-12T17:00:31Z","pushed_at":"2018-05-01T23:51:32Z","git_url":"git://github.com/tkoolen/MathOptInterface.jl.git","ssh_url":"git@github.com:tkoolen/MathOptInterface.jl.git","clone_url":"https://github.com/tkoolen/MathOptInterface.jl.git","svn_url":"https://github.com/tkoolen/MathOptInterface.jl","homepage":"http://www.juliaopt.org/","size":1333,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaOpt:master","ref":"master","sha":"cd3115d5f6e2808bfa166ede71b3da16bf392a51","user":{"login":"JuliaOpt","id":5667382,"avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":95823645,"name":"MathOptInterface.jl","full_name":"JuliaOpt/MathOptInterface.jl","owner":{"login":"JuliaOpt","id":5667382,"avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaOpt/MathOptInterface.jl","description":"An abstraction layer for mathematical optimization solvers.","fork":false,"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl","forks_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/deployments","created_at":"2017-06-29T22:02:15Z","updated_at":"2018-05-01T21:56:34Z","pushed_at":"2018-05-02T00:01:11Z","git_url":"git://github.com/JuliaOpt/MathOptInterface.jl.git","ssh_url":"git@github.com:JuliaOpt/MathOptInterface.jl.git","clone_url":"https://github.com/JuliaOpt/MathOptInterface.jl.git","svn_url":"https://github.com/JuliaOpt/MathOptInterface.jl","homepage":"http://www.juliaopt.org/","size":1845,"stargazers_count":27,"watchers_count":27,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":35,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342"},"html":{"href":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/342"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/342"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/75302a6abe594bbc1e8a341842e6100ce4f4eab3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mlubin"}}