{"action":"created","issue":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/86","repository_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks","labels_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/86/comments","events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/86/events","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/86","id":348569221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODg4Mjg2","number":86,"title":"Add ability to specify a list of additional security groups to attach to","user":{"login":"hobbsh","id":600818,"node_id":"MDQ6VXNlcjYwMDgxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/600818?v=4","gravatar_id":"","url":"https://api.github.com/users/hobbsh","html_url":"https://github.com/hobbsh","followers_url":"https://api.github.com/users/hobbsh/followers","following_url":"https://api.github.com/users/hobbsh/following{/other_user}","gists_url":"https://api.github.com/users/hobbsh/gists{/gist_id}","starred_url":"https://api.github.com/users/hobbsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hobbsh/subscriptions","organizations_url":"https://api.github.com/users/hobbsh/orgs","repos_url":"https://api.github.com/users/hobbsh/repos","events_url":"https://api.github.com/users/hobbsh/events{/privacy}","received_events_url":"https://api.github.com/users/hobbsh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-08T04:17:18Z","updated_at":"2018-09-04T15:55:14Z","closed_at":"2018-09-04T15:35:47Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/86","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/86","diff_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/86.diff","patch_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/86.patch"},"body":"# PR o'clock\r\n\r\n## Description\r\n\r\nThis addresses #47 - I have been using this in a local fork and noticed there was an open issue for it. Basically, this allows the user to specify a list of additional existing security groups which will merge with `worker_security_group_id` if specified. This might make `worker_security_group_id` unnecessary, although it's assumed that the additional security groups are unaffiliated with the EKS cluster and more for VPC transit to other areas.\r\n\r\nPlease let me know what you think. \r\n\r\n### Checklist\r\n\r\n- [x] `terraform fmt` and `terraform validate` both work from the root and `examples/eks_test_fixture` directories (look in CI for an example)\r\n- [ ] Tests for the changes have been added and passing (for bug fixes/features)\r\n- [ ] Test results are pasted in this PR (in lieu of CI)\r\n- [x] Docs have been updated using `terraform-docs` per `README.md` instructions\r\n- [x] I've added my change to CHANGELOG.md\r\n- [x] Any breaking changes are highlighted above\r\n"},"comment":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/comments/418421503","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/86#issuecomment-418421503","issue_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/86","id":418421503,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODQyMTUwMw==","user":{"login":"mr-joshua","id":20648121,"node_id":"MDQ6VXNlcjIwNjQ4MTIx","avatar_url":"https://avatars2.githubusercontent.com/u/20648121?v=4","gravatar_id":"","url":"https://api.github.com/users/mr-joshua","html_url":"https://github.com/mr-joshua","followers_url":"https://api.github.com/users/mr-joshua/followers","following_url":"https://api.github.com/users/mr-joshua/following{/other_user}","gists_url":"https://api.github.com/users/mr-joshua/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-joshua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-joshua/subscriptions","organizations_url":"https://api.github.com/users/mr-joshua/orgs","repos_url":"https://api.github.com/users/mr-joshua/repos","events_url":"https://api.github.com/users/mr-joshua/events{/privacy}","received_events_url":"https://api.github.com/users/mr-joshua/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T15:55:14Z","updated_at":"2018-09-04T15:55:14Z","author_association":"CONTRIBUTOR","body":"@hobbsh and @max-rocket-internet my apologies"}}
{"actor":{"display_login":"mr-joshua"}}