{"action":"created","comment":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments/224103694","pull_request_review_id":163389874,"id":224103694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDEwMzY5NA==","diff_hunk":"@@ -649,6 +649,11 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi\n \t\t\t\t\t\t\t\t\t\t\tskipModulesNativeCheck: !liveSyncData.watchAllFiles\n \t\t\t\t\t\t\t\t\t\t}, { skipNativePrepare: deviceBuildInfoDescriptor.skipNativePrepare });\n \n+\t\t\t\t\t\t\t\t\t\tif (liveSyncData.useHotModuleReload && appInstalledOnDeviceResult.appInstalled) {\n+\t\t\t\t\t\t\t\t\t\t\tconst additionalFilesToSync = currentHmrData && currentHmrData.fallbackFiles && currentHmrData.fallbackFiles[device.deviceInfo.platform];\n+\t\t\t\t\t\t\t\t\t\t\t_.each(additionalFilesToSync, fileToSync => currentFilesToSync.push(fileToSync));","path":"lib/services/livesync/livesync-service.ts","position":6,"original_position":6,"commit_id":"b55fbe1c57f57223034b006985eb288f5bc99caa","original_commit_id":"b55fbe1c57f57223034b006985eb288f5bc99caa","user":{"login":"KristianDD","id":2412096,"node_id":"MDQ6VXNlcjI0MTIwOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2412096?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianDD","html_url":"https://github.com/KristianDD","followers_url":"https://api.github.com/users/KristianDD/followers","following_url":"https://api.github.com/users/KristianDD/following{/other_user}","gists_url":"https://api.github.com/users/KristianDD/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianDD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianDD/subscriptions","organizations_url":"https://api.github.com/users/KristianDD/orgs","repos_url":"https://api.github.com/users/KristianDD/repos","events_url":"https://api.github.com/users/KristianDD/events{/privacy}","received_events_url":"https://api.github.com/users/KristianDD/received_events","type":"User","site_admin":false},"body":"I would prefer this:\r\n```TypeScript\r\nconst additionalFilesToSync = currentHmrData && currentHmrData.fallbackFiles && currentHmrData.fallbackFiles[device.deviceInfo.platform] || [];\r\nfileToSync.push(...additionalFilesToSync);\r\n```\r\n\r\nBut it is just personal preference. Not a blocker.","created_at":"2018-10-10T14:35:31Z","updated_at":"2018-10-10T14:35:37Z","html_url":"https://github.com/NativeScript/nativescript-cli/pull/4006#discussion_r224103694","pull_request_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments/224103694"},"html":{"href":"https://github.com/NativeScript/nativescript-cli/pull/4006#discussion_r224103694"},"pull_request":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006"}}},"pull_request":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006","id":221719641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzE5NjQx","html_url":"https://github.com/NativeScript/nativescript-cli/pull/4006","diff_url":"https://github.com/NativeScript/nativescript-cli/pull/4006.diff","patch_url":"https://github.com/NativeScript/nativescript-cli/pull/4006.patch","issue_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/4006","number":4006,"state":"open","locked":false,"title":"fix: apply changes correctly when app is uninstalled from device during the execution of `tns run android --hmr` command","user":{"login":"Fatme","id":760518,"node_id":"MDQ6VXNlcjc2MDUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/760518?v=4","gravatar_id":"","url":"https://api.github.com/users/Fatme","html_url":"https://github.com/Fatme","followers_url":"https://api.github.com/users/Fatme/followers","following_url":"https://api.github.com/users/Fatme/following{/other_user}","gists_url":"https://api.github.com/users/Fatme/gists{/gist_id}","starred_url":"https://api.github.com/users/Fatme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fatme/subscriptions","organizations_url":"https://api.github.com/users/Fatme/orgs","repos_url":"https://api.github.com/users/Fatme/repos","events_url":"https://api.github.com/users/Fatme/events{/privacy}","received_events_url":"https://api.github.com/users/Fatme/received_events","type":"User","site_admin":false},"body":"In case when `tns run android --hmr` command is executed and the app is uninstalled from device during the execution of command, {N} CLI installs the application again on device but the changes are not applied. When a change occurs during the execution of command, {N} CLI sends only `.hot-update` files on device. (without `bundle.js` and `vendor.js`). But in this specific case {N} CLI should send all files on device including `bundle.js` and/or `vendor.js`.\r\n\r\n## PR Checklist\r\n\r\n- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.\r\n- [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.\r\n- [ ] You have signed the [CLA](http://www.nativescript.org/cla).\r\n- [ ] All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base\r\n- [ ] Tests for the changes are included.\r\n\r\n## Steps to reproduce:;\r\n1. `run android --hmr`\r\n\r\n2. make changes – applied \r\n\r\n3. Uninstall app without stop the proccess \r\n\r\n4. Make new changes and save \r\n\r\n5. The app will install without new changes \r\n","created_at":"2018-10-10T09:33:36Z","updated_at":"2018-10-10T14:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fbffe9bc604b68c65778565f936b2ae2012b5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006/commits","review_comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006/comments","review_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/4006/comments","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/b55fbe1c57f57223034b006985eb288f5bc99caa","head":{"label":"NativeScript:fatme/fix-reinstalled-hmr","ref":"fatme/fix-reinstalled-hmr","sha":"b55fbe1c57f57223034b006985eb288f5bc99caa","user":{"login":"NativeScript","id":7392261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTIyNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":21347346,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM0NzM0Ng==","name":"nativescript-cli","full_name":"NativeScript/nativescript-cli","private":false,"owner":{"login":"NativeScript","id":7392261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTIyNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NativeScript/nativescript-cli","description":"Command-line interface for building NativeScript apps","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-cli","forks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-cli/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-cli/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-cli/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-cli/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-cli/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-cli/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/deployments","created_at":"2014-06-30T10:21:20Z","updated_at":"2018-10-10T14:25:44Z","pushed_at":"2018-10-10T14:25:44Z","git_url":"git://github.com/NativeScript/nativescript-cli.git","ssh_url":"git@github.com:NativeScript/nativescript-cli.git","clone_url":"https://github.com/NativeScript/nativescript-cli.git","svn_url":"https://github.com/NativeScript/nativescript-cli","homepage":"https://www.npmjs.com/package/nativescript","size":51793,"stargazers_count":743,"watchers_count":743,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":129,"open_issues":199,"watchers":743,"default_branch":"master"}},"base":{"label":"NativeScript:master","ref":"master","sha":"fd8a83a6ebe91be52bfd00a69494e0c5edcfda8d","user":{"login":"NativeScript","id":7392261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTIyNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":21347346,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM0NzM0Ng==","name":"nativescript-cli","full_name":"NativeScript/nativescript-cli","private":false,"owner":{"login":"NativeScript","id":7392261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTIyNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NativeScript/nativescript-cli","description":"Command-line interface for building NativeScript apps","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-cli","forks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-cli/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-cli/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-cli/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-cli/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-cli/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-cli/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-cli/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-cli/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-cli/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/deployments","created_at":"2014-06-30T10:21:20Z","updated_at":"2018-10-10T14:25:44Z","pushed_at":"2018-10-10T14:25:44Z","git_url":"git://github.com/NativeScript/nativescript-cli.git","ssh_url":"git@github.com:NativeScript/nativescript-cli.git","clone_url":"https://github.com/NativeScript/nativescript-cli.git","svn_url":"https://github.com/NativeScript/nativescript-cli","homepage":"https://www.npmjs.com/package/nativescript","size":51793,"stargazers_count":743,"watchers_count":743,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":129,"open_issues":199,"watchers":743,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006"},"html":{"href":"https://github.com/NativeScript/nativescript-cli/pull/4006"},"issue":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/4006"},"comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/4006/comments"},"review_comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006/comments"},"review_comment":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/4006/commits"},"statuses":{"href":"https://api.github.com/repos/NativeScript/nativescript-cli/statuses/b55fbe1c57f57223034b006985eb288f5bc99caa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KristianDD"}}