{"action":"opened","number":1118,"pull_request":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/1118","id":241127579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTI3NTc5","html_url":"https://github.com/Zilliqa/Zilliqa/pull/1118","diff_url":"https://github.com/Zilliqa/Zilliqa/pull/1118.diff","patch_url":"https://github.com/Zilliqa/Zilliqa/pull/1118.patch","issue_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/1118","number":1118,"state":"open","locked":false,"title":"Periodic cleanup of gossip raw message store","user":{"login":"sandipbhoir","id":42535511,"node_id":"MDQ6VXNlcjQyNTM1NTEx","avatar_url":"https://avatars1.githubusercontent.com/u/42535511?v=4","gravatar_id":"","url":"https://api.github.com/users/sandipbhoir","html_url":"https://github.com/sandipbhoir","followers_url":"https://api.github.com/users/sandipbhoir/followers","following_url":"https://api.github.com/users/sandipbhoir/following{/other_user}","gists_url":"https://api.github.com/users/sandipbhoir/gists{/gist_id}","starred_url":"https://api.github.com/users/sandipbhoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandipbhoir/subscriptions","organizations_url":"https://api.github.com/users/sandipbhoir/orgs","repos_url":"https://api.github.com/users/sandipbhoir/repos","events_url":"https://api.github.com/users/sandipbhoir/events{/privacy}","received_events_url":"https://api.github.com/users/sandipbhoir/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR addressess unbounded growth of below two storages:\r\n\r\n- **m_rumorHashRawMsgBimap:** maps rumor hash to the full rumor message content\r\n- **m_rumorIdHashBimap:** maps sequential rumorId integers to rumor message hashes\r\n\r\nBelow two need not to considered:\r\n- **m_tmpRumorHashSet:** temporary rumor hash store to ensure duplicate rumors are not\r\ndistributed - **No more used in our codebase.**\r\n- **m_hashesSubscriberMap:** if a node is asked for a message he does not have, the asking\r\nnode gets subscribed to this message (entries inside this map get deleted once subscribed\r\nmessages are delivered) - **which is good enough to control the growth of this container** \r\n\r\n## Review Suggestion\r\nPlease check the file changed.\r\n\r\n## Status\r\n\r\n### Implementation\r\n<!-- Add more TODOs before \"ready for review\", if any  -->\r\n- [x] **ready for review**\r\n\r\n### Integration Test (Core Team)\r\n<!-- This is for core team only, ignore this if you are a community contributor -->\r\n\r\n<!-- append the commit digest to inform the others of the versions you have tested -->\r\n- [x] local machine test\r\n<!-- - [ ] local machine test (commit: bbbbbbbb) -->\r\n<!-- - [ ] local machine test (commit: cccccccc) -->\r\n<!-- - [ ] local machine test (commit: dddddddd) -->\r\n- [ ] small-scale cloud test\r\n<!-- - [ ] small-scale cloud test (commit: bbbbbbbb) -->\r\n<!-- - [ ] small-scale cloud test (commit: cccccccc) -->\r\n<!-- - [ ] small-scale cloud test (commit: dddddddd) -->\r\n","created_at":"2018-12-27T10:51:18Z","updated_at":"2018-12-27T10:51:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"sandipbhoir","id":42535511,"node_id":"MDQ6VXNlcjQyNTM1NTEx","avatar_url":"https://avatars1.githubusercontent.com/u/42535511?v=4","gravatar_id":"","url":"https://api.github.com/users/sandipbhoir","html_url":"https://github.com/sandipbhoir","followers_url":"https://api.github.com/users/sandipbhoir/followers","following_url":"https://api.github.com/users/sandipbhoir/following{/other_user}","gists_url":"https://api.github.com/users/sandipbhoir/gists{/gist_id}","starred_url":"https://api.github.com/users/sandipbhoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandipbhoir/subscriptions","organizations_url":"https://api.github.com/users/sandipbhoir/orgs","repos_url":"https://api.github.com/users/sandipbhoir/repos","events_url":"https://api.github.com/users/sandipbhoir/events{/privacy}","received_events_url":"https://api.github.com/users/sandipbhoir/received_events","type":"User","site_admin":false},"assignees":[{"login":"sandipbhoir","id":42535511,"node_id":"MDQ6VXNlcjQyNTM1NTEx","avatar_url":"https://avatars1.githubusercontent.com/u/42535511?v=4","gravatar_id":"","url":"https://api.github.com/users/sandipbhoir","html_url":"https://github.com/sandipbhoir","followers_url":"https://api.github.com/users/sandipbhoir/followers","following_url":"https://api.github.com/users/sandipbhoir/following{/other_user}","gists_url":"https://api.github.com/users/sandipbhoir/gists{/gist_id}","starred_url":"https://api.github.com/users/sandipbhoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandipbhoir/subscriptions","organizations_url":"https://api.github.com/users/sandipbhoir/orgs","repos_url":"https://api.github.com/users/sandipbhoir/repos","events_url":"https://api.github.com/users/sandipbhoir/events{/privacy}","received_events_url":"https://api.github.com/users/sandipbhoir/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":990370924,"node_id":"MDU6TGFiZWw5OTAzNzA5MjQ=","url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels/Ready","name":"Ready","color":"8ded6a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/1118/commits","review_comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/1118/comments","review_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/1118/comments","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/ce45310c18e08e9f2a3ec853e214b3155f086376","head":{"label":"Zilliqa:feature/periodic-cleanup-gossip-store","ref":"feature/periodic-cleanup-gossip-store","sha":"ce45310c18e08e9f2a3ec853e214b3155f086376","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","private":false,"owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-12-27T10:04:13Z","pushed_at":"2018-12-27T10:40:39Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":35449,"stargazers_count":712,"watchers_count":712,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":155,"open_issues":97,"watchers":712,"default_branch":"master"}},"base":{"label":"Zilliqa:master","ref":"master","sha":"5a5bf6c5f662383a33455dd045aef7437da41511","user":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0OTU2MzA=","name":"Zilliqa","full_name":"Zilliqa/Zilliqa","private":false,"owner":{"login":"Zilliqa","id":32560879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTYwODc5","avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-12-27T10:04:13Z","pushed_at":"2018-12-27T10:40:39Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":35449,"stargazers_count":712,"watchers_count":712,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":155,"open_issues":97,"watchers":712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/1118"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/1118"},"issue":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/1118"},"comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/1118/comments"},"review_comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/1118/comments"},"review_comment":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/1118/commits"},"statuses":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/ce45310c18e08e9f2a3ec853e214b3155f086376"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":75,"deletions":13,"changed_files":6}}
{"actor":{"display_login":"sandipbhoir"}}