{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/194228539","pull_request_review_id":127367456,"id":194228539,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDIyODUzOQ==","diff_hunk":"@@ -98,6 +98,24 @@ struct mca_atomic_base_module_1_0_0_t {\n                         const void *value,\n                         size_t nlong,\n                         int pe);\n+    int (*atomic_fand)(void *target,","path":"oshmem/mca/atomic/atomic.h","position":12,"original_position":12,"commit_id":"b39bc2e657ef72d5578dd3ddd3788b5f0949825c","original_commit_id":"b39bc2e657ef72d5578dd3ddd3788b5f0949825c","user":{"login":"yosefe","id":2255631,"node_id":"MDQ6VXNlcjIyNTU2MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2255631?v=4","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"what do you think about separating \"op\" and \"fop\"? to avoid extra branch in atomic module functions\r\nso the number of functions here would be 10: add,and,or,xor,fadd,fand,for,fxor,swap,cswap","created_at":"2018-06-09T14:03:29Z","updated_at":"2018-06-09T14:09:48Z","html_url":"https://github.com/open-mpi/ompi/pull/5208#discussion_r194228539","pull_request_url":"https://api.github.com/repos/open-mpi/ompi/pulls/5208","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/194228539"},"html":{"href":"https://github.com/open-mpi/ompi/pull/5208#discussion_r194228539"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/5208"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/5208","id":191758654,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzU4NjU0","html_url":"https://github.com/open-mpi/ompi/pull/5208","diff_url":"https://github.com/open-mpi/ompi/pull/5208.diff","patch_url":"https://github.com/open-mpi/ompi/pull/5208.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/5208","number":5208,"state":"open","locked":false,"title":"OSHMEM: added bitwise atomics implementation infra (spec v1.4)","user":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"body":"- added MCA calls for atomics AND, OR & XOR\r\n- updated basic implementation for new atomics (refactoring)\r\n- added stubs for new atomics to UCX & MCM MCA's\r\n- added API spec 1.4 for atomics [f]add, swap & cswap\r\n\r\nSigned-off-by: Sergey Oblomov <sergeyo@mellanox.com>","created_at":"2018-05-31T13:44:55Z","updated_at":"2018-06-09T14:09:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a09d18ee81749ccd348fd5c8df5a241695b8c0e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":659687073,"node_id":"MDU6TGFiZWw2NTk2ODcwNzM=","url":"https://api.github.com/repos/open-mpi/ompi/labels/Target:%20master","name":"Target: master","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/5208/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/5208/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/5208/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/b39bc2e657ef72d5578dd3ddd3788b5f0949825c","head":{"label":"hoopoepg:topic/bitwise-atomics","ref":"topic/bitwise-atomics","sha":"b39bc2e657ef72d5578dd3ddd3788b5f0949825c","user":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"repo":{"id":119408699,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDg2OTk=","name":"ompi","full_name":"hoopoepg/ompi","owner":{"login":"hoopoepg","id":2535990,"node_id":"MDQ6VXNlcjI1MzU5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoopoepg/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/hoopoepg/ompi","forks_url":"https://api.github.com/repos/hoopoepg/ompi/forks","keys_url":"https://api.github.com/repos/hoopoepg/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoopoepg/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoopoepg/ompi/teams","hooks_url":"https://api.github.com/repos/hoopoepg/ompi/hooks","issue_events_url":"https://api.github.com/repos/hoopoepg/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/hoopoepg/ompi/events","assignees_url":"https://api.github.com/repos/hoopoepg/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/hoopoepg/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/hoopoepg/ompi/tags","blobs_url":"https://api.github.com/repos/hoopoepg/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoopoepg/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoopoepg/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoopoepg/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoopoepg/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/hoopoepg/ompi/languages","stargazers_url":"https://api.github.com/repos/hoopoepg/ompi/stargazers","contributors_url":"https://api.github.com/repos/hoopoepg/ompi/contributors","subscribers_url":"https://api.github.com/repos/hoopoepg/ompi/subscribers","subscription_url":"https://api.github.com/repos/hoopoepg/ompi/subscription","commits_url":"https://api.github.com/repos/hoopoepg/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoopoepg/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoopoepg/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoopoepg/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoopoepg/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/hoopoepg/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoopoepg/ompi/merges","archive_url":"https://api.github.com/repos/hoopoepg/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoopoepg/ompi/downloads","issues_url":"https://api.github.com/repos/hoopoepg/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/hoopoepg/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/hoopoepg/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/hoopoepg/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoopoepg/ompi/labels{/name}","releases_url":"https://api.github.com/repos/hoopoepg/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/hoopoepg/ompi/deployments","created_at":"2018-01-29T16:27:39Z","updated_at":"2018-01-29T16:28:02Z","pushed_at":"2018-06-09T12:30:42Z","git_url":"git://github.com/hoopoepg/ompi.git","ssh_url":"git@github.com:hoopoepg/ompi.git","clone_url":"https://github.com/hoopoepg/ompi.git","svn_url":"https://github.com/hoopoepg/ompi","homepage":null,"size":115664,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"f5631e546d06d2a2ca2b256ca223c769cf321d6f","user":{"login":"open-mpi","id":2165682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNjU2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"node_id":"MDEwOlJlcG9zaXRvcnkyNDEwNzAwMQ==","name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNjU2ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2018-06-08T19:23:06Z","pushed_at":"2018-06-09T12:30:44Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":115701,"stargazers_count":535,"watchers_count":535,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":328,"open_issues":370,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/5208"},"html":{"href":"https://github.com/open-mpi/ompi/pull/5208"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/5208"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/5208/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/5208/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/5208/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/b39bc2e657ef72d5578dd3ddd3788b5f0949825c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yosefe"}}