{"action":"created","issue":{"url":"https://api.github.com/repos/bashu/django-airports/issues/18","repository_url":"https://api.github.com/repos/bashu/django-airports","labels_url":"https://api.github.com/repos/bashu/django-airports/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/bashu/django-airports/issues/18/comments","events_url":"https://api.github.com/repos/bashu/django-airports/issues/18/events","html_url":"https://github.com/bashu/django-airports/pull/18","id":307468303,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc2NjQ4MzUx","number":18,"title":"toward 0.2 release","user":{"login":"eracle","id":3613943,"node_id":"MDQ6VXNlcjM2MTM5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3613943?v=4","gravatar_id":"","url":"https://api.github.com/users/eracle","html_url":"https://github.com/eracle","followers_url":"https://api.github.com/users/eracle/followers","following_url":"https://api.github.com/users/eracle/following{/other_user}","gists_url":"https://api.github.com/users/eracle/gists{/gist_id}","starred_url":"https://api.github.com/users/eracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eracle/subscriptions","organizations_url":"https://api.github.com/users/eracle/orgs","repos_url":"https://api.github.com/users/eracle/repos","events_url":"https://api.github.com/users/eracle/events{/privacy}","received_events_url":"https://api.github.com/users/eracle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-22T00:52:38Z","updated_at":"2018-07-11T15:53:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bashu/django-airports/pulls/18","html_url":"https://github.com/bashu/django-airports/pull/18","diff_url":"https://github.com/bashu/django-airports/pull/18.diff","patch_url":"https://github.com/bashu/django-airports/pull/18.patch"},"body":"Hi there! Here's some changes toward 0.2 release.\r\n"},"comment":{"url":"https://api.github.com/repos/bashu/django-airports/issues/comments/404220383","html_url":"https://github.com/bashu/django-airports/pull/18#issuecomment-404220383","issue_url":"https://api.github.com/repos/bashu/django-airports/issues/18","id":404220383,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDIyMDM4Mw==","user":{"login":"vlinhart","id":874223,"node_id":"MDQ6VXNlcjg3NDIyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/874223?v=4","gravatar_id":"","url":"https://api.github.com/users/vlinhart","html_url":"https://github.com/vlinhart","followers_url":"https://api.github.com/users/vlinhart/followers","following_url":"https://api.github.com/users/vlinhart/following{/other_user}","gists_url":"https://api.github.com/users/vlinhart/gists{/gist_id}","starred_url":"https://api.github.com/users/vlinhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlinhart/subscriptions","organizations_url":"https://api.github.com/users/vlinhart/orgs","repos_url":"https://api.github.com/users/vlinhart/repos","events_url":"https://api.github.com/users/vlinhart/events{/privacy}","received_events_url":"https://api.github.com/users/vlinhart/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T15:53:17Z","updated_at":"2018-07-11T15:53:17Z","author_association":"CONTRIBUTOR","body":"Nice work but does it really need to break backward compatibility? (removing `airport_id`). It would also be nice if the airport import was able to update values not just add them. The names of airports get changed and the use of get_object_or_create as is will try to create a new one in case of a change which will fail since the IATA stays the same and is the primary key now. \r\n \r\nMaybe this would help:\r\n\r\n```python\r\nAirport.objects.update_or_create(iata=iata, icao=icao, defaults=dict(name=name, altitude=altitude, location=point, country=country, city=city))\r\n```\r\nit will update existing and create a new ones."}}
{"actor":{"display_login":"vlinhart"}}