{"action":"created","comment":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/comments/233026356","pull_request_review_id":174348172,"id":233026356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzAyNjM1Ng==","diff_hunk":"@@ -108,7 +108,7 @@ function buildNightlyHTML(files) {\n     var nameOfFile = (eachAsset.binary_name);\n     var uppercaseFilename = nameOfFile.toUpperCase(); // make the name of the file uppercase\n     NIGHTLYOBJECT.thisPlatform = findPlatform(eachAsset); // get the searchableName, e.g. MAC or X64_LINUX.\n-    var type = nameOfFile.includes('-jre') ? 'jre' : 'jdk';\n+    var type = nameOfFile.indexOf('-jre') !== -1 ? 'jre' : 'jdk';","path":"src/js/nightly.js","position":5,"original_position":5,"commit_id":"a8039a719ad542db1512ca14608bb51ec5a593b7","original_commit_id":"a8039a719ad542db1512ca14608bb51ec5a593b7","user":{"login":"supahgreg","id":288958,"node_id":"MDQ6VXNlcjI4ODk1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/288958?v=4","gravatar_id":"","url":"https://api.github.com/users/supahgreg","html_url":"https://github.com/supahgreg","followers_url":"https://api.github.com/users/supahgreg/followers","following_url":"https://api.github.com/users/supahgreg/following{/other_user}","gists_url":"https://api.github.com/users/supahgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/supahgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supahgreg/subscriptions","organizations_url":"https://api.github.com/users/supahgreg/orgs","repos_url":"https://api.github.com/users/supahgreg/repos","events_url":"https://api.github.com/users/supahgreg/events{/privacy}","received_events_url":"https://api.github.com/users/supahgreg/received_events","type":"User","site_admin":false},"body":"Do you mean to the code?  The new line is fairly standard JS, so that might not be worthwhile.  The need for this change is due to IE not supporting `includes`, preventing IE users (thinking corporate settings mostly) from using the Nightly page.","created_at":"2018-11-13T12:59:06Z","updated_at":"2018-11-13T12:59:06Z","html_url":"https://github.com/AdoptOpenJDK/openjdk-website/pull/360#discussion_r233026356","pull_request_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/comments/233026356"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-website/pull/360#discussion_r233026356"},"pull_request":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360"}},"in_reply_to_id":233023985},"pull_request":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360","id":230361660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzYxNjYw","html_url":"https://github.com/AdoptOpenJDK/openjdk-website/pull/360","diff_url":"https://github.com/AdoptOpenJDK/openjdk-website/pull/360.diff","patch_url":"https://github.com/AdoptOpenJDK/openjdk-website/pull/360.patch","issue_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues/360","number":360,"state":"open","locked":false,"title":"Add 'Array.prototype.find' polyfill","user":{"login":"supahgreg","id":288958,"node_id":"MDQ6VXNlcjI4ODk1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/288958?v=4","gravatar_id":"","url":"https://api.github.com/users/supahgreg","html_url":"https://github.com/supahgreg","followers_url":"https://api.github.com/users/supahgreg/followers","following_url":"https://api.github.com/users/supahgreg/following{/other_user}","gists_url":"https://api.github.com/users/supahgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/supahgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supahgreg/subscriptions","organizations_url":"https://api.github.com/users/supahgreg/orgs","repos_url":"https://api.github.com/users/supahgreg/repos","events_url":"https://api.github.com/users/supahgreg/events{/privacy}","received_events_url":"https://api.github.com/users/supahgreg/received_events","type":"User","site_admin":false},"body":"The Releases page redo included a call to [`Array.prototype.find`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find), which IE doesn't like.  This adds a polyfill to get it working again.\r\n\r\nAnother option would be to include [`@babel/polyfill`](https://babeljs.io/docs/en/babel-polyfill) to avoid worrying about specific polyfills.\r\n\r\n*edit:* I've added a small fix for the Nightly page, since IE also doesn't like [`String.prototype.includes`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes).\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `npm test` passes\r\n- [x] contribution guidelines followed [here](https://github.com/AdoptOpenJDK/openjdk-website/blob/master/CONTRIBUTING.md)\r\n","created_at":"2018-11-13T06:28:08Z","updated_at":"2018-11-13T12:59:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f66c41fb9fdd5dbc7204832aca935766a3f7293","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":562904472,"node_id":"MDU6TGFiZWw1NjI5MDQ0NzI=","url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/labels/enhancement","name":"enhancement","color":"006b75","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360/commits","review_comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360/comments","review_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues/360/comments","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/statuses/a8039a719ad542db1512ca14608bb51ec5a593b7","head":{"label":"supahgreg:array-find-polyfill","ref":"array-find-polyfill","sha":"a8039a719ad542db1512ca14608bb51ec5a593b7","user":{"login":"supahgreg","id":288958,"node_id":"MDQ6VXNlcjI4ODk1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/288958?v=4","gravatar_id":"","url":"https://api.github.com/users/supahgreg","html_url":"https://github.com/supahgreg","followers_url":"https://api.github.com/users/supahgreg/followers","following_url":"https://api.github.com/users/supahgreg/following{/other_user}","gists_url":"https://api.github.com/users/supahgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/supahgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supahgreg/subscriptions","organizations_url":"https://api.github.com/users/supahgreg/orgs","repos_url":"https://api.github.com/users/supahgreg/repos","events_url":"https://api.github.com/users/supahgreg/events{/privacy}","received_events_url":"https://api.github.com/users/supahgreg/received_events","type":"User","site_admin":false},"repo":{"id":154007644,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwMDc2NDQ=","name":"openjdk-website","full_name":"supahgreg/openjdk-website","private":false,"owner":{"login":"supahgreg","id":288958,"node_id":"MDQ6VXNlcjI4ODk1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/288958?v=4","gravatar_id":"","url":"https://api.github.com/users/supahgreg","html_url":"https://github.com/supahgreg","followers_url":"https://api.github.com/users/supahgreg/followers","following_url":"https://api.github.com/users/supahgreg/following{/other_user}","gists_url":"https://api.github.com/users/supahgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/supahgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supahgreg/subscriptions","organizations_url":"https://api.github.com/users/supahgreg/orgs","repos_url":"https://api.github.com/users/supahgreg/repos","events_url":"https://api.github.com/users/supahgreg/events{/privacy}","received_events_url":"https://api.github.com/users/supahgreg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/supahgreg/openjdk-website","description":"Website source","fork":true,"url":"https://api.github.com/repos/supahgreg/openjdk-website","forks_url":"https://api.github.com/repos/supahgreg/openjdk-website/forks","keys_url":"https://api.github.com/repos/supahgreg/openjdk-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supahgreg/openjdk-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supahgreg/openjdk-website/teams","hooks_url":"https://api.github.com/repos/supahgreg/openjdk-website/hooks","issue_events_url":"https://api.github.com/repos/supahgreg/openjdk-website/issues/events{/number}","events_url":"https://api.github.com/repos/supahgreg/openjdk-website/events","assignees_url":"https://api.github.com/repos/supahgreg/openjdk-website/assignees{/user}","branches_url":"https://api.github.com/repos/supahgreg/openjdk-website/branches{/branch}","tags_url":"https://api.github.com/repos/supahgreg/openjdk-website/tags","blobs_url":"https://api.github.com/repos/supahgreg/openjdk-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supahgreg/openjdk-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supahgreg/openjdk-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/supahgreg/openjdk-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supahgreg/openjdk-website/statuses/{sha}","languages_url":"https://api.github.com/repos/supahgreg/openjdk-website/languages","stargazers_url":"https://api.github.com/repos/supahgreg/openjdk-website/stargazers","contributors_url":"https://api.github.com/repos/supahgreg/openjdk-website/contributors","subscribers_url":"https://api.github.com/repos/supahgreg/openjdk-website/subscribers","subscription_url":"https://api.github.com/repos/supahgreg/openjdk-website/subscription","commits_url":"https://api.github.com/repos/supahgreg/openjdk-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/supahgreg/openjdk-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/supahgreg/openjdk-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/supahgreg/openjdk-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/supahgreg/openjdk-website/contents/{+path}","compare_url":"https://api.github.com/repos/supahgreg/openjdk-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supahgreg/openjdk-website/merges","archive_url":"https://api.github.com/repos/supahgreg/openjdk-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supahgreg/openjdk-website/downloads","issues_url":"https://api.github.com/repos/supahgreg/openjdk-website/issues{/number}","pulls_url":"https://api.github.com/repos/supahgreg/openjdk-website/pulls{/number}","milestones_url":"https://api.github.com/repos/supahgreg/openjdk-website/milestones{/number}","notifications_url":"https://api.github.com/repos/supahgreg/openjdk-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supahgreg/openjdk-website/labels{/name}","releases_url":"https://api.github.com/repos/supahgreg/openjdk-website/releases{/id}","deployments_url":"https://api.github.com/repos/supahgreg/openjdk-website/deployments","created_at":"2018-10-21T12:50:02Z","updated_at":"2018-10-21T12:50:04Z","pushed_at":"2018-11-13T06:56:54Z","git_url":"git://github.com/supahgreg/openjdk-website.git","ssh_url":"git@github.com:supahgreg/openjdk-website.git","clone_url":"https://github.com/supahgreg/openjdk-website.git","svn_url":"https://github.com/supahgreg/openjdk-website","homepage":"https://adoptopenjdk.net/","size":2347,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AdoptOpenJDK:master","ref":"master","sha":"de3055d8c5b8f53480693f9e337c41ce07e7831e","user":{"login":"AdoptOpenJDK","id":1673867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzM4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1673867?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"repo":{"id":85294780,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI5NDc4MA==","name":"openjdk-website","full_name":"AdoptOpenJDK/openjdk-website","private":false,"owner":{"login":"AdoptOpenJDK","id":1673867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzM4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1673867?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AdoptOpenJDK/openjdk-website","description":"Website source","fork":false,"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website","forks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/forks","keys_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/teams","hooks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/hooks","issue_events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues/events{/number}","events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/events","assignees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/assignees{/user}","branches_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/branches{/branch}","tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/tags","blobs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/statuses/{sha}","languages_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/languages","stargazers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/stargazers","contributors_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/contributors","subscribers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/subscribers","subscription_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/subscription","commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/contents/{+path}","compare_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/merges","archive_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/downloads","issues_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues{/number}","pulls_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls{/number}","milestones_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/milestones{/number}","notifications_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/labels{/name}","releases_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/releases{/id}","deployments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/deployments","created_at":"2017-03-17T09:34:04Z","updated_at":"2018-11-12T21:56:28Z","pushed_at":"2018-11-13T06:56:55Z","git_url":"git://github.com/AdoptOpenJDK/openjdk-website.git","ssh_url":"git@github.com:AdoptOpenJDK/openjdk-website.git","clone_url":"https://github.com/AdoptOpenJDK/openjdk-website.git","svn_url":"https://github.com/AdoptOpenJDK/openjdk-website","homepage":"https://adoptopenjdk.net/","size":2390,"stargazers_count":23,"watchers_count":23,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":33,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-website/pull/360"},"issue":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues/360"},"comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-website/statuses/a8039a719ad542db1512ca14608bb51ec5a593b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"supahgreg"}}