{"action":"created","issue":{"url":"https://api.github.com/repos/bosnet/sebak/issues/446","repository_url":"https://api.github.com/repos/bosnet/sebak","labels_url":"https://api.github.com/repos/bosnet/sebak/issues/446/labels{/name}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/446/comments","events_url":"https://api.github.com/repos/bosnet/sebak/issues/446/events","html_url":"https://github.com/bosnet/sebak/pull/446","id":362388692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTIyOTcx","number":446,"title":"Checking `BaseReserve` for new created account","user":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"labels":[{"id":904295035,"node_id":"MDU6TGFiZWw5MDQyOTUwMzU=","url":"https://api.github.com/repos/bosnet/sebak/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"assignees":[{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-09-20T22:19:11Z","updated_at":"2018-09-23T08:32:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/446","html_url":"https://github.com/bosnet/sebak/pull/446","diff_url":"https://github.com/bosnet/sebak/pull/446.diff","patch_url":"https://github.com/bosnet/sebak/pull/446.patch"},"body":"### Github Issue\r\n\r\nresolves #242 \r\n\r\n### Background\r\n\r\nCurrent tokennet has limit for new created account, it must be received up to base reserve, `0.1`BOS. If not, the new account will not be created.\r\n\r\n### Solution\r\n\r\nThe `Amount` is set in `common.BaseReserve` like `common.BaseFee`. In the 2 parts, the base reserve will be checked,\r\n\r\n1. `OperationCreateAccount.IsWellformed()`\r\n1. `BlockAccount.Save()`"},"comment":{"url":"https://api.github.com/repos/bosnet/sebak/issues/comments/423800563","html_url":"https://github.com/bosnet/sebak/pull/446#issuecomment-423800563","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/446","id":423800563,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzgwMDU2Mw==","user":{"login":"Geod24","id":2180215,"node_id":"MDQ6VXNlcjIxODAyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2180215?v=4","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"created_at":"2018-09-23T08:32:17Z","updated_at":"2018-09-23T08:32:17Z","author_association":"CONTRIBUTOR","body":"@spikeekips I understand the implementation, I'm asking for the rationale behind it.\r\nI understand why Stellar has a minimum balance, but why do we do that only during account creation ?"}}
{"actor":{"display_login":"Geod24"}}