{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/227617750","pull_request_review_id":167700366,"id":227617750,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzYxNzc1MA==","diff_hunk":"@@ -4356,9 +4359,8 @@ def luf(lamdaexpr, *args, **kwargs):\n     array([[1, 2],\n            [4, 5]], dtype=int16)\n     >>> y.view(dtype=[('width', np.int16), ('length', np.int16)])\n-    Traceback (most recent call last):\n-      File \"<stdin>\", line 1, in <module>\n-    ValueError: new type not compatible with array.","path":"numpy/core/_add_newdocs.py","position":436,"original_position":436,"commit_id":"faec8f9ccf3aaa002e4ffb8bbc751c187ce4f130","original_commit_id":"faec8f9ccf3aaa002e4ffb8bbc751c187ce4f130","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"Showing the message is useful here","created_at":"2018-10-24T01:32:03Z","updated_at":"2018-10-24T01:32:03Z","html_url":"https://github.com/numpy/numpy/pull/12253#discussion_r227617750","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/12253","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/227617750"},"html":{"href":"https://github.com/numpy/numpy/pull/12253#discussion_r227617750"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12253"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/12253","id":225224074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjI0MDc0","html_url":"https://github.com/numpy/numpy/pull/12253","diff_url":"https://github.com/numpy/numpy/pull/12253.diff","patch_url":"https://github.com/numpy/numpy/pull/12253.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/12253","number":12253,"state":"open","locked":false,"title":"WIP, DOC, TST: enable doctests","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"body":"Related to #9415, but using doctests proper--this is pretty painful, although I'm making progress & there are some real issues in the docstrings.\r\n\r\nUsing this command locally: `python runtests.py -- --doctest-modules --ignore=numpy/ma/version.py --ignore=numpy/f2py/__main__.py --ignore=numpy/distutils/msvc9compiler.py --ignore=numpy/core/generate_numpy_api.py --ignore=numpy/core/cversions.py --ignore=numpy/testing -n 3 >& log.txt`\r\n\r\nTo do:\r\n\r\n- [ ] resolve remaining doctest errors locally\r\n- [ ] hook up to CI with a 3.x doctest job","created_at":"2018-10-23T23:58:22Z","updated_at":"2018-10-24T01:32:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30dc195c776610eb890175177029c8fad733d20d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6359990,"node_id":"MDU6TGFiZWw2MzU5OTkw","url":"https://api.github.com/repos/numpy/numpy/labels/04%20-%20Documentation","name":"04 - Documentation","color":"fef2c0","default":false},{"id":6359945,"node_id":"MDU6TGFiZWw2MzU5OTQ1","url":"https://api.github.com/repos/numpy/numpy/labels/05%20-%20Testing","name":"05 - Testing","color":"fef2c0","default":false},{"id":1024395160,"node_id":"MDU6TGFiZWwxMDI0Mzk1MTYw","url":"https://api.github.com/repos/numpy/numpy/labels/25%20-%20WIP","name":"25 - WIP","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/12253/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/12253/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/12253/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/faec8f9ccf3aaa002e4ffb8bbc751c187ce4f130","head":{"label":"tylerjereddy:enable_doctests","ref":"enable_doctests","sha":"faec8f9ccf3aaa002e4ffb8bbc751c187ce4f130","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"repo":{"id":116427166,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY0MjcxNjY=","name":"numpy","full_name":"tylerjereddy/numpy","private":false,"owner":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tylerjereddy/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/tylerjereddy/numpy","forks_url":"https://api.github.com/repos/tylerjereddy/numpy/forks","keys_url":"https://api.github.com/repos/tylerjereddy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylerjereddy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylerjereddy/numpy/teams","hooks_url":"https://api.github.com/repos/tylerjereddy/numpy/hooks","issue_events_url":"https://api.github.com/repos/tylerjereddy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/tylerjereddy/numpy/events","assignees_url":"https://api.github.com/repos/tylerjereddy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/tylerjereddy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/tylerjereddy/numpy/tags","blobs_url":"https://api.github.com/repos/tylerjereddy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylerjereddy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylerjereddy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylerjereddy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylerjereddy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/tylerjereddy/numpy/languages","stargazers_url":"https://api.github.com/repos/tylerjereddy/numpy/stargazers","contributors_url":"https://api.github.com/repos/tylerjereddy/numpy/contributors","subscribers_url":"https://api.github.com/repos/tylerjereddy/numpy/subscribers","subscription_url":"https://api.github.com/repos/tylerjereddy/numpy/subscription","commits_url":"https://api.github.com/repos/tylerjereddy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylerjereddy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylerjereddy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylerjereddy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylerjereddy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/tylerjereddy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylerjereddy/numpy/merges","archive_url":"https://api.github.com/repos/tylerjereddy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylerjereddy/numpy/downloads","issues_url":"https://api.github.com/repos/tylerjereddy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/tylerjereddy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/tylerjereddy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/tylerjereddy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylerjereddy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/tylerjereddy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/tylerjereddy/numpy/deployments","created_at":"2018-01-05T21:11:17Z","updated_at":"2018-10-04T19:04:04Z","pushed_at":"2018-10-23T23:44:49Z","git_url":"git://github.com/tylerjereddy/numpy.git","ssh_url":"git@github.com:tylerjereddy/numpy.git","clone_url":"https://github.com/tylerjereddy/numpy.git","svn_url":"https://github.com/tylerjereddy/numpy","homepage":"http://www.numpy.org/","size":60649,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"numpy_azure_win"}},"base":{"label":"numpy:master","ref":"master","sha":"7fbcc4eaf22a01ac3282179b49c6363485263fbf","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-10-24T01:00:12Z","pushed_at":"2018-10-23T23:58:23Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":61576,"stargazers_count":8445,"watchers_count":8445,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3067,"mirror_url":null,"archived":false,"open_issues_count":2004,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3067,"open_issues":2004,"watchers":8445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12253"},"html":{"href":"https://github.com/numpy/numpy/pull/12253"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/12253"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/12253/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12253/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12253/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/faec8f9ccf3aaa002e4ffb8bbc751c187ce4f130"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eric-wieser"}}