{"action":"closed","number":53405,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/53405","id":208655764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjU1NzY0","html_url":"https://github.com/rust-lang/rust/pull/53405","diff_url":"https://github.com/rust-lang/rust/pull/53405.diff","patch_url":"https://github.com/rust-lang/rust/pull/53405.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/53405","number":53405,"state":"closed","locked":false,"title":"restore the page title after escaping out of a search","user":{"login":"oconnor663","id":860932,"node_id":"MDQ6VXNlcjg2MDkzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/860932?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnor663","html_url":"https://github.com/oconnor663","followers_url":"https://api.github.com/users/oconnor663/followers","following_url":"https://api.github.com/users/oconnor663/following{/other_user}","gists_url":"https://api.github.com/users/oconnor663/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnor663/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnor663/subscriptions","organizations_url":"https://api.github.com/users/oconnor663/orgs","repos_url":"https://api.github.com/users/oconnor663/repos","events_url":"https://api.github.com/users/oconnor663/events{/privacy}","received_events_url":"https://api.github.com/users/oconnor663/received_events","type":"User","site_admin":false},"body":"Currently if I start a search in the docs, but then hit ESC, the \"Results for...\" title is still there in my browser tab. This is a simple attempt to fix that. I see that there's a separate `var previousTitle = document.title` thing happening in `startSearch()`, but as far as I can tell that's only related to the back stack? I'd also appreciate feedback on the right place to declare the `titleBeforeSearch` variable.\r\n\r\nTesting-wise, I've confirmed by hand that the tab title restores correctly after building with `./x.py doc --stage 1 src/libstd`, but nothing more involved than that. What else should I test?","created_at":"2018-08-15T19:21:48Z","updated_at":"2018-08-21T18:16:31Z","closed_at":"2018-08-21T18:16:31Z","merged_at":"2018-08-21T18:16:31Z","merge_commit_sha":"207550981fb3f152ceacaf23fa5ac1727dad17ab","assignee":{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"assignees":[{"login":"GuillaumeGomez","id":3050060,"node_id":"MDQ6VXNlcjMwNTAwNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3050060?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583437191,"node_id":"MDU6TGFiZWw1ODM0MzcxOTE=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/53405/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/53405/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/53405/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/207550981fb3f152ceacaf23fa5ac1727dad17ab","head":{"label":"oconnor663:search_esc","ref":"search_esc","sha":"207550981fb3f152ceacaf23fa5ac1727dad17ab","user":{"login":"oconnor663","id":860932,"node_id":"MDQ6VXNlcjg2MDkzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/860932?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnor663","html_url":"https://github.com/oconnor663","followers_url":"https://api.github.com/users/oconnor663/followers","following_url":"https://api.github.com/users/oconnor663/following{/other_user}","gists_url":"https://api.github.com/users/oconnor663/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnor663/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnor663/subscriptions","organizations_url":"https://api.github.com/users/oconnor663/orgs","repos_url":"https://api.github.com/users/oconnor663/repos","events_url":"https://api.github.com/users/oconnor663/events{/privacy}","received_events_url":"https://api.github.com/users/oconnor663/received_events","type":"User","site_admin":false},"repo":{"id":51803155,"node_id":"MDEwOlJlcG9zaXRvcnk1MTgwMzE1NQ==","name":"rust","full_name":"oconnor663/rust","owner":{"login":"oconnor663","id":860932,"node_id":"MDQ6VXNlcjg2MDkzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/860932?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnor663","html_url":"https://github.com/oconnor663","followers_url":"https://api.github.com/users/oconnor663/followers","following_url":"https://api.github.com/users/oconnor663/following{/other_user}","gists_url":"https://api.github.com/users/oconnor663/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnor663/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnor663/subscriptions","organizations_url":"https://api.github.com/users/oconnor663/orgs","repos_url":"https://api.github.com/users/oconnor663/repos","events_url":"https://api.github.com/users/oconnor663/events{/privacy}","received_events_url":"https://api.github.com/users/oconnor663/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oconnor663/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/oconnor663/rust","forks_url":"https://api.github.com/repos/oconnor663/rust/forks","keys_url":"https://api.github.com/repos/oconnor663/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oconnor663/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oconnor663/rust/teams","hooks_url":"https://api.github.com/repos/oconnor663/rust/hooks","issue_events_url":"https://api.github.com/repos/oconnor663/rust/issues/events{/number}","events_url":"https://api.github.com/repos/oconnor663/rust/events","assignees_url":"https://api.github.com/repos/oconnor663/rust/assignees{/user}","branches_url":"https://api.github.com/repos/oconnor663/rust/branches{/branch}","tags_url":"https://api.github.com/repos/oconnor663/rust/tags","blobs_url":"https://api.github.com/repos/oconnor663/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oconnor663/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oconnor663/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/oconnor663/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oconnor663/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/oconnor663/rust/languages","stargazers_url":"https://api.github.com/repos/oconnor663/rust/stargazers","contributors_url":"https://api.github.com/repos/oconnor663/rust/contributors","subscribers_url":"https://api.github.com/repos/oconnor663/rust/subscribers","subscription_url":"https://api.github.com/repos/oconnor663/rust/subscription","commits_url":"https://api.github.com/repos/oconnor663/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/oconnor663/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/oconnor663/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/oconnor663/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/oconnor663/rust/contents/{+path}","compare_url":"https://api.github.com/repos/oconnor663/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oconnor663/rust/merges","archive_url":"https://api.github.com/repos/oconnor663/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oconnor663/rust/downloads","issues_url":"https://api.github.com/repos/oconnor663/rust/issues{/number}","pulls_url":"https://api.github.com/repos/oconnor663/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/oconnor663/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/oconnor663/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oconnor663/rust/labels{/name}","releases_url":"https://api.github.com/repos/oconnor663/rust/releases{/id}","deployments_url":"https://api.github.com/repos/oconnor663/rust/deployments","created_at":"2016-02-16T02:52:59Z","updated_at":"2016-02-16T02:53:15Z","pushed_at":"2018-08-20T21:03:57Z","git_url":"git://github.com/oconnor663/rust.git","ssh_url":"git@github.com:oconnor663/rust.git","clone_url":"https://github.com/oconnor663/rust.git","svn_url":"https://github.com/oconnor663/rust","homepage":"http://www.rust-lang.org","size":384387,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"d767ee11616390d128853a06f5addb619e79213f","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-08-21T17:17:21Z","pushed_at":"2018-08-21T18:16:09Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":387969,"stargazers_count":30121,"watchers_count":30121,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5121,"mirror_url":null,"archived":false,"open_issues_count":4223,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5121,"open_issues":4223,"watchers":30121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53405"},"html":{"href":"https://github.com/rust-lang/rust/pull/53405"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53405"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53405/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53405/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53405/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/207550981fb3f152ceacaf23fa5ac1727dad17ab"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"node_id":"MDQ6VXNlcjMzNzIzNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bors"}}