{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8282","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8282/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8282/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8282/events","html_url":"https://github.com/RobotLocomotion/drake/pull/8282","id":302943562,"number":8282,"title":"Bind PoseBundle, FrameVelocity, PoseAggregator","user":{"login":"jadecastro","id":1655653,"avatar_url":"https://avatars2.githubusercontent.com/u/1655653?v=4","gravatar_id":"","url":"https://api.github.com/users/jadecastro","html_url":"https://github.com/jadecastro","followers_url":"https://api.github.com/users/jadecastro/followers","following_url":"https://api.github.com/users/jadecastro/following{/other_user}","gists_url":"https://api.github.com/users/jadecastro/gists{/gist_id}","starred_url":"https://api.github.com/users/jadecastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadecastro/subscriptions","organizations_url":"https://api.github.com/users/jadecastro/orgs","repos_url":"https://api.github.com/users/jadecastro/repos","events_url":"https://api.github.com/users/jadecastro/events{/privacy}","received_events_url":"https://api.github.com/users/jadecastro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false},"assignees":[{"login":"sherm1","id":4088016,"avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-03-07T02:36:54Z","updated_at":"2018-03-09T17:38:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/8282","html_url":"https://github.com/RobotLocomotion/drake/pull/8282","diff_url":"https://github.com/RobotLocomotion/drake/pull/8282.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/8282.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/8282)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/371885512","html_url":"https://github.com/RobotLocomotion/drake/pull/8282#issuecomment-371885512","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8282","id":371885512,"user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T17:38:12Z","updated_at":"2018-03-09T17:38:12Z","author_association":"MEMBER","body":"BTW PR title mentions PoseBundle, FrameVelocity, PoseAggregator but not SpatialVector & SpatialVelocity -- update?\n<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>, pending a few minor BTWs.\n\n---\n\nReviewed 5 of 19 files at r2, 6 of 11 files at r3, 6 of 9 files at r4.\nReview status: all files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[bindings/pydrake/multibody/multibody_tree_py.cc, line 52 at r4](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-L7Aipq93GMqTjK9Qxmg:-L7Aipq93GMqTjK9Qxmh:bbksn9n) ([raw file](https://github.com/robotlocomotion/drake/blob/62df224ab424d11aa0505c78cb75a3e049d9d31b/bindings/pydrake/multibody/multibody_tree_py.cc#L52)):*\n> ```cpp\n> \n> PYBIND11_MODULE(multibody_tree, m) {\n>   m.doc() = \"MultiBodyTree functionality.\";\n> ```\n\nBTW \"MultibodyTree\" (no capital B)\n\n---\n\n*[bindings/pydrake/systems/rendering_py.cc, line 44 at r4](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-L7AhcbZRWwlpGKdm84G:-L7AhcbZRWwlpGKdm84H:b-rd29a) ([raw file](https://github.com/robotlocomotion/drake/blob/62df224ab424d11aa0505c78cb75a3e049d9d31b/bindings/pydrake/systems/rendering_py.cc#L44)):*\n> ```cpp\n>   // N.B. We simplify the get/set signatures below to temporarily sidestep\n>   // dependence on multibody.\n>   // TODO(jadecastro) Revert this once the bindings for SpatialVelocity exist.\n> ```\n\nBTW I don't understand this TODO. This PR adds the bindings for SpatialVelocity. Should something be reverted here now?\n\n---\n\n*[bindings/pydrake/test/all_test.py, line 94 at r4](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-L7AjR8wwUUuB-KMwkwP:-L7AjR8wwUUuB-KMwkwQ:b3g7cd1) ([raw file](https://github.com/robotlocomotion/drake/blob/62df224ab424d11aa0505c78cb75a3e049d9d31b/bindings/pydrake/test/all_test.py#L94)):*\n> ```Python\n>             \"Isometry3\",\n>             \"Quaternion\",\n>         )\n> ```\n\nBTW should the above list include PoseBundle, FrameVelocity, PoseAggregator ?\n\n---\n\n*[systems/rendering/frame_velocity.h, line 29 at r4](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-L7An_miJq3P7tHxzkSm:-L7An_miJq3P7tHxzkSn:b-96fmly) ([raw file](https://github.com/robotlocomotion/drake/blob/62df224ab424d11aa0505c78cb75a3e049d9d31b/systems/rendering/frame_velocity.h#L29)):*\n> ```objc\n> \n>   /// Fully-parameterized constructor.\n>   /// @param velocity the entire spatial velocity Xdot_WA.\n> ```\n\nBTW Xdot_WA -> V_WA.  Spatial velocity symbol is \"V\". It is not actually the time derivative of X_WA although Xdot and V are linearly related.\n\n---\n\n*[systems/rendering/pose_vector.cc, line 21 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-L731kCZ2LnvH8GqdajR:-L7AoF4jcamcalUXbFno:b9j9n43) ([raw file](https://github.com/robotlocomotion/drake/blob/057b61a217c056f335e1e179762768015970fdd5/systems/rendering/pose_vector.cc#L21)):*\n<details><summary><i>Previously, jadecastro (Jonathan DeCastro) wrote…</i></summary><blockquote>\n\nDone.\n</blockquote></details>\n\nLooks good to me.\n\n---\n\n*[systems/rendering/pose_vector.h, line 27 at r4](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-L7AoV0tVIxcK8E6GEgz:-L7AoV0tVIxcK8E6GEh-:bzfdlaf) ([raw file](https://github.com/robotlocomotion/drake/blob/62df224ab424d11aa0505c78cb75a3e049d9d31b/systems/rendering/pose_vector.h#L27)):*\n> ```objc\n>   /// Fully-parameterized constructor.\n>   /// @param rotation the rotation R_WA.\n>   /// @param translation the translation p_WA.\n> ```\n\nBTW, to make this less tautological, consider something like\n```\n@param rotation the orientation R_WA of frame A in the world frame W.\n@param translation the position vector p_WA giving A's origin measured from W's origin, expressed in W.\n```\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/8282#-:-L7AixD-eQZVtugCK2-5:bq7mkv)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"sherm1"}}