{"action":"closed","number":1988,"pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1988","id":230611128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjExMTI4","html_url":"https://github.com/rockstor/rockstor-core/pull/1988","diff_url":"https://github.com/rockstor/rockstor-core/pull/1988.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/1988.patch","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1988","number":1988,"state":"closed","locked":false,"title":"improve pool import with disabled or indeterminate quota state. Fixes #1987","user":{"login":"phillxnet","id":2521585,"node_id":"MDQ6VXNlcjI1MjE1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2521585?v=4","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"body":"Add sensitivity / heed warnings re a quota disabled state (often only displayed for a short period and accompanied by otherwise normal quota enabled behaviour) and additionally make our 'btrfs qgroup assign' wrapper fail elegantly in this interim / indeterminate quota state.\r\n\r\nAddressed issue could in rare situations also block share creation.\r\n\r\nSummary:\r\n\r\n- Enhance qgroup_max() re qgroup disabled warnings.\r\n- Enhance are_quotas_enabled() re qgroup disabled warnings.\r\n- Don’t fail import / share creation for failure to quota group assign: log as error and continue.\r\n\r\nFixes #1987 \r\nSee issue text for more context.\r\n\r\n@schakrava Ready for review.\r\n\r\nTesting:\r\n\r\nDuring unrelated Rockstor development on docker-ce a larger number of docker service enable / disable cycles were performed. This is suspected as the cause for a then persistent indeterminate quota state that blocked further share creation. See issue:\r\n\"docker-ce dictating pool quota enabled disabled status\" #1906\r\nfor buggy docker-ce btrfs quota interaction.\r\nIt was then also noticed that importing certain prior quota disabled pools failed in a related manner.\r\nPost pr the remaining reproducer examples behaved as expected, ie share creation was fixed and imports were successful in the respective instances.","created_at":"2018-11-13T20:17:53Z","updated_at":"2018-11-15T13:31:57Z","closed_at":"2018-11-15T13:31:56Z","merged_at":"2018-11-15T13:31:56Z","merge_commit_sha":"83df2978e0867287928c0a88242b8684bad9b63b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1988/commits","review_comments_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1988/comments","review_comment_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1988/comments","statuses_url":"https://api.github.com/repos/rockstor/rockstor-core/statuses/0c0a6906c3aa39c5810259de4eb15c4d90a8d106","head":{"label":"phillxnet:1987_improve_pool_import_with_disabled_or_indeterminate_quota_state","ref":"1987_improve_pool_import_with_disabled_or_indeterminate_quota_state","sha":"0c0a6906c3aa39c5810259de4eb15c4d90a8d106","user":{"login":"phillxnet","id":2521585,"node_id":"MDQ6VXNlcjI1MjE1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2521585?v=4","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"repo":{"id":35962271,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk2MjI3MQ==","name":"rockstor-core","full_name":"phillxnet/rockstor-core","private":false,"owner":{"login":"phillxnet","id":2521585,"node_id":"MDQ6VXNlcjI1MjE1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2521585?v=4","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phillxnet/rockstor-core","description":"Rockstor core","fork":true,"url":"https://api.github.com/repos/phillxnet/rockstor-core","forks_url":"https://api.github.com/repos/phillxnet/rockstor-core/forks","keys_url":"https://api.github.com/repos/phillxnet/rockstor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phillxnet/rockstor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phillxnet/rockstor-core/teams","hooks_url":"https://api.github.com/repos/phillxnet/rockstor-core/hooks","issue_events_url":"https://api.github.com/repos/phillxnet/rockstor-core/issues/events{/number}","events_url":"https://api.github.com/repos/phillxnet/rockstor-core/events","assignees_url":"https://api.github.com/repos/phillxnet/rockstor-core/assignees{/user}","branches_url":"https://api.github.com/repos/phillxnet/rockstor-core/branches{/branch}","tags_url":"https://api.github.com/repos/phillxnet/rockstor-core/tags","blobs_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phillxnet/rockstor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/phillxnet/rockstor-core/languages","stargazers_url":"https://api.github.com/repos/phillxnet/rockstor-core/stargazers","contributors_url":"https://api.github.com/repos/phillxnet/rockstor-core/contributors","subscribers_url":"https://api.github.com/repos/phillxnet/rockstor-core/subscribers","subscription_url":"https://api.github.com/repos/phillxnet/rockstor-core/subscription","commits_url":"https://api.github.com/repos/phillxnet/rockstor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phillxnet/rockstor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phillxnet/rockstor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phillxnet/rockstor-core/contents/{+path}","compare_url":"https://api.github.com/repos/phillxnet/rockstor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phillxnet/rockstor-core/merges","archive_url":"https://api.github.com/repos/phillxnet/rockstor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phillxnet/rockstor-core/downloads","issues_url":"https://api.github.com/repos/phillxnet/rockstor-core/issues{/number}","pulls_url":"https://api.github.com/repos/phillxnet/rockstor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/phillxnet/rockstor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/phillxnet/rockstor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phillxnet/rockstor-core/labels{/name}","releases_url":"https://api.github.com/repos/phillxnet/rockstor-core/releases{/id}","deployments_url":"https://api.github.com/repos/phillxnet/rockstor-core/deployments","created_at":"2015-05-20T17:10:38Z","updated_at":"2018-11-10T14:46:11Z","pushed_at":"2018-11-13T19:53:59Z","git_url":"git://github.com/phillxnet/rockstor-core.git","ssh_url":"git@github.com:phillxnet/rockstor-core.git","clone_url":"https://github.com/phillxnet/rockstor-core.git","svn_url":"https://github.com/phillxnet/rockstor-core","homepage":"http://www.rockstor.com/docs/contribute.html","size":14039,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rockstor:master","ref":"master","sha":"71f6657fe9102dc4b48c6bb30e19b2abe15b99d3","user":{"login":"rockstor","id":4014253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMTQyNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4014253?v=4","gravatar_id":"","url":"https://api.github.com/users/rockstor","html_url":"https://github.com/rockstor","followers_url":"https://api.github.com/users/rockstor/followers","following_url":"https://api.github.com/users/rockstor/following{/other_user}","gists_url":"https://api.github.com/users/rockstor/gists{/gist_id}","starred_url":"https://api.github.com/users/rockstor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockstor/subscriptions","organizations_url":"https://api.github.com/users/rockstor/orgs","repos_url":"https://api.github.com/users/rockstor/repos","events_url":"https://api.github.com/users/rockstor/events{/privacy}","received_events_url":"https://api.github.com/users/rockstor/received_events","type":"Organization","site_admin":false},"repo":{"id":9136748,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM2NzQ4","name":"rockstor-core","full_name":"rockstor/rockstor-core","private":false,"owner":{"login":"rockstor","id":4014253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMTQyNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4014253?v=4","gravatar_id":"","url":"https://api.github.com/users/rockstor","html_url":"https://github.com/rockstor","followers_url":"https://api.github.com/users/rockstor/followers","following_url":"https://api.github.com/users/rockstor/following{/other_user}","gists_url":"https://api.github.com/users/rockstor/gists{/gist_id}","starred_url":"https://api.github.com/users/rockstor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockstor/subscriptions","organizations_url":"https://api.github.com/users/rockstor/orgs","repos_url":"https://api.github.com/users/rockstor/repos","events_url":"https://api.github.com/users/rockstor/events{/privacy}","received_events_url":"https://api.github.com/users/rockstor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rockstor/rockstor-core","description":"Linux/BTRFS based Network Attached Storage(NAS)","fork":false,"url":"https://api.github.com/repos/rockstor/rockstor-core","forks_url":"https://api.github.com/repos/rockstor/rockstor-core/forks","keys_url":"https://api.github.com/repos/rockstor/rockstor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rockstor/rockstor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rockstor/rockstor-core/teams","hooks_url":"https://api.github.com/repos/rockstor/rockstor-core/hooks","issue_events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/events{/number}","events_url":"https://api.github.com/repos/rockstor/rockstor-core/events","assignees_url":"https://api.github.com/repos/rockstor/rockstor-core/assignees{/user}","branches_url":"https://api.github.com/repos/rockstor/rockstor-core/branches{/branch}","tags_url":"https://api.github.com/repos/rockstor/rockstor-core/tags","blobs_url":"https://api.github.com/repos/rockstor/rockstor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rockstor/rockstor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rockstor/rockstor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rockstor/rockstor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rockstor/rockstor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rockstor/rockstor-core/languages","stargazers_url":"https://api.github.com/repos/rockstor/rockstor-core/stargazers","contributors_url":"https://api.github.com/repos/rockstor/rockstor-core/contributors","subscribers_url":"https://api.github.com/repos/rockstor/rockstor-core/subscribers","subscription_url":"https://api.github.com/repos/rockstor/rockstor-core/subscription","commits_url":"https://api.github.com/repos/rockstor/rockstor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rockstor/rockstor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rockstor/rockstor-core/contents/{+path}","compare_url":"https://api.github.com/repos/rockstor/rockstor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rockstor/rockstor-core/merges","archive_url":"https://api.github.com/repos/rockstor/rockstor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rockstor/rockstor-core/downloads","issues_url":"https://api.github.com/repos/rockstor/rockstor-core/issues{/number}","pulls_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rockstor/rockstor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rockstor/rockstor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/labels{/name}","releases_url":"https://api.github.com/repos/rockstor/rockstor-core/releases{/id}","deployments_url":"https://api.github.com/repos/rockstor/rockstor-core/deployments","created_at":"2013-03-31T21:41:57Z","updated_at":"2018-11-14T18:12:20Z","pushed_at":"2018-11-15T13:31:56Z","git_url":"git://github.com/rockstor/rockstor-core.git","ssh_url":"git@github.com:rockstor/rockstor-core.git","clone_url":"https://github.com/rockstor/rockstor-core.git","svn_url":"https://github.com/rockstor/rockstor-core","homepage":"http://www.rockstor.com/docs/contribute.html","size":14038,"stargazers_count":332,"watchers_count":332,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":100,"open_issues":321,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1988"},"html":{"href":"https://github.com/rockstor/rockstor-core/pull/1988"},"issue":{"href":"https://api.github.com/repos/rockstor/rockstor-core/issues/1988"},"comments":{"href":"https://api.github.com/repos/rockstor/rockstor-core/issues/1988/comments"},"review_comments":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1988/comments"},"review_comment":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1988/commits"},"statuses":{"href":"https://api.github.com/repos/rockstor/rockstor-core/statuses/0c0a6906c3aa39c5810259de4eb15c4d90a8d106"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"schakrava","id":1123552,"node_id":"MDQ6VXNlcjExMjM1NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1123552?v=4","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"schakrava"}}