{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/199630341","pull_request_review_id":133787920,"id":199630341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTYzMDM0MQ==","diff_hunk":"@@ -27,6 +27,7 @@ func (b *Broker) Deprovision(u user.Info, instanceID string) *api.Response {\n \t\tif kerrors.IsNotFound(err) {\n \t\t\treturn api.NewResponse(http.StatusGone, &api.DeprovisionResponse{}, nil)\n \t\t}\n+\t\tglog.Errorf(\"Failed BrokerTemplateInstances.Get(): instanceID %s\", instanceID)","path":"pkg/templateservicebroker/servicebroker/deprovision.go","position":4,"original_position":4,"commit_id":"aeac3417fe83ba43f636485468c8720bb63e5684","original_commit_id":"aeac3417fe83ba43f636485468c8720bb63e5684","user":{"login":"johnkim76","id":2566892,"node_id":"MDQ6VXNlcjI1NjY4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"body":"understood, I will remove/restore the added loggings","created_at":"2018-07-02T21:45:39Z","updated_at":"2018-07-02T21:45:40Z","html_url":"https://github.com/openshift/origin/pull/20099#discussion_r199630341","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/20099","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/199630341"},"html":{"href":"https://github.com/openshift/origin/pull/20099#discussion_r199630341"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/20099"}},"in_reply_to_id":199364787},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20099","id":197449092,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDQ5MDky","html_url":"https://github.com/openshift/origin/pull/20099","diff_url":"https://github.com/openshift/origin/pull/20099.diff","patch_url":"https://github.com/openshift/origin/pull/20099.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/20099","number":20099,"state":"open","locked":false,"title":"Bug 1579194 - Fixes handling of multiple provision request","user":{"login":"johnkim76","id":2566892,"node_id":"MDQ6VXNlcjI1NjY4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"body":"Bug 1579194\r\nBug 1584970\r\nThis correctly handles the case when multiple provision requests come in for the same Broker Template Instance.\r\n\r\nAPI changes would be a better solution, however went with this approach, since the migration costs to do the API changes would not be practical at this point.","created_at":"2018-06-26T14:45:50Z","updated_at":"2018-07-02T21:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae21ae29bcdc783fa75d75ac8dfac7940a9f4f00","assignee":{"login":"bparees","id":4974046,"node_id":"MDQ6VXNlcjQ5NzQwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"node_id":"MDQ6VXNlcjQ5NzQwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jwmatthews","id":206875,"node_id":"MDQ6VXNlcjIwNjg3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/206875?v=4","gravatar_id":"","url":"https://api.github.com/users/jwmatthews","html_url":"https://github.com/jwmatthews","followers_url":"https://api.github.com/users/jwmatthews/followers","following_url":"https://api.github.com/users/jwmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jwmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jwmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwmatthews/subscriptions","organizations_url":"https://api.github.com/users/jwmatthews/orgs","repos_url":"https://api.github.com/users/jwmatthews/repos","events_url":"https://api.github.com/users/jwmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jwmatthews/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":223051294,"node_id":"MDU6TGFiZWwyMjMwNTEyOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":683198191,"node_id":"MDU6TGFiZWw2ODMxOTgxOTE=","url":"https://api.github.com/repos/openshift/origin/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":640547984,"node_id":"MDU6TGFiZWw2NDA1NDc5ODQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/20099/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/20099/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20099/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/aeac3417fe83ba43f636485468c8720bb63e5684","head":{"label":"johnkim76:bug_1579194","ref":"bug_1579194","sha":"aeac3417fe83ba43f636485468c8720bb63e5684","user":{"login":"johnkim76","id":2566892,"node_id":"MDQ6VXNlcjI1NjY4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"repo":{"id":86491810,"node_id":"MDEwOlJlcG9zaXRvcnk4NjQ5MTgxMA==","name":"origin","full_name":"johnkim76/origin","owner":{"login":"johnkim76","id":2566892,"node_id":"MDQ6VXNlcjI1NjY4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnkim76/origin","description":"Enterprise Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/johnkim76/origin","forks_url":"https://api.github.com/repos/johnkim76/origin/forks","keys_url":"https://api.github.com/repos/johnkim76/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnkim76/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnkim76/origin/teams","hooks_url":"https://api.github.com/repos/johnkim76/origin/hooks","issue_events_url":"https://api.github.com/repos/johnkim76/origin/issues/events{/number}","events_url":"https://api.github.com/repos/johnkim76/origin/events","assignees_url":"https://api.github.com/repos/johnkim76/origin/assignees{/user}","branches_url":"https://api.github.com/repos/johnkim76/origin/branches{/branch}","tags_url":"https://api.github.com/repos/johnkim76/origin/tags","blobs_url":"https://api.github.com/repos/johnkim76/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnkim76/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnkim76/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnkim76/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnkim76/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/johnkim76/origin/languages","stargazers_url":"https://api.github.com/repos/johnkim76/origin/stargazers","contributors_url":"https://api.github.com/repos/johnkim76/origin/contributors","subscribers_url":"https://api.github.com/repos/johnkim76/origin/subscribers","subscription_url":"https://api.github.com/repos/johnkim76/origin/subscription","commits_url":"https://api.github.com/repos/johnkim76/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnkim76/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnkim76/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnkim76/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnkim76/origin/contents/{+path}","compare_url":"https://api.github.com/repos/johnkim76/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnkim76/origin/merges","archive_url":"https://api.github.com/repos/johnkim76/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnkim76/origin/downloads","issues_url":"https://api.github.com/repos/johnkim76/origin/issues{/number}","pulls_url":"https://api.github.com/repos/johnkim76/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/johnkim76/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/johnkim76/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnkim76/origin/labels{/name}","releases_url":"https://api.github.com/repos/johnkim76/origin/releases{/id}","deployments_url":"https://api.github.com/repos/johnkim76/origin/deployments","created_at":"2017-03-28T18:08:25Z","updated_at":"2018-06-19T19:04:42Z","pushed_at":"2018-06-27T15:30:53Z","git_url":"git://github.com/johnkim76/origin.git","ssh_url":"git@github.com:johnkim76/origin.git","clone_url":"https://github.com/johnkim76/origin.git","svn_url":"https://github.com/johnkim76/origin","homepage":"http://www.openshift.org","size":944212,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"db3845c60123e1ad62793307aa689b9711dd364c","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjY2OA==","name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-07-02T18:51:44Z","pushed_at":"2018-07-02T21:44:33Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":921051,"stargazers_count":4732,"watchers_count":4732,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2941,"mirror_url":null,"archived":false,"open_issues_count":701,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2941,"open_issues":701,"watchers":4732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/20099"},"html":{"href":"https://github.com/openshift/origin/pull/20099"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/20099"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/20099/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/20099/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/20099/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/aeac3417fe83ba43f636485468c8720bb63e5684"}},"author_association":"NONE"}}
{"actor":{"display_login":"johnkim76"}}