{"action":"created","comment":{"url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments/226716234","pull_request_review_id":166611243,"id":226716234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjcxNjIzNA==","diff_hunk":"@@ -23,6 +23,10 @@ class Secrets\n   #  - secret_module_and_one_more_secret\n   # encryption_key: default\n   #\n+  # Config file /modules/gcp-secret-mgmt/config.yaml\n+  # is needed to preserve the order of encryption keys.","path":"shared/rakefiles/secrets.rb","position":5,"original_position":5,"commit_id":"a0d2f9e030767a37fd15fbac49a7e5b1c576c5cf","original_commit_id":"a0d2f9e030767a37fd15fbac49a7e5b1c576c5cf","user":{"login":"mrtyler","id":1369918,"node_id":"MDQ6VXNlcjEzNjk5MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1369918?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtyler","html_url":"https://github.com/mrtyler","followers_url":"https://api.github.com/users/mrtyler/followers","following_url":"https://api.github.com/users/mrtyler/following{/other_user}","gists_url":"https://api.github.com/users/mrtyler/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtyler/subscriptions","organizations_url":"https://api.github.com/users/mrtyler/orgs","repos_url":"https://api.github.com/users/mrtyler/repos","events_url":"https://api.github.com/users/mrtyler/events{/privacy}","received_events_url":"https://api.github.com/users/mrtyler/received_events","type":"User","site_admin":false},"body":"I would expand on why preserving order is important.","created_at":"2018-10-19T17:00:48Z","updated_at":"2018-10-19T17:01:07Z","html_url":"https://github.com/gpii-ops/gpii-infra/pull/185#discussion_r226716234","pull_request_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments/226716234"},"html":{"href":"https://github.com/gpii-ops/gpii-infra/pull/185#discussion_r226716234"},"pull_request":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185","id":223809606,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODA5NjA2","html_url":"https://github.com/gpii-ops/gpii-infra/pull/185","diff_url":"https://github.com/gpii-ops/gpii-infra/pull/185.diff","patch_url":"https://github.com/gpii-ops/gpii-infra/pull/185.patch","issue_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/185","number":185,"state":"open","locked":false,"title":"[GPII-3456] Add encryption keys config to keep the order","user":{"login":"natarajaya","id":917560,"node_id":"MDQ6VXNlcjkxNzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"body":"As discovered by Alfredo, Terraform freaks out in case order of the encryption keys changes.","created_at":"2018-10-18T02:48:49Z","updated_at":"2018-10-19T17:01:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85fe77e2425e2669a1d9aa70674a8225613757be","assignee":{"login":"natarajaya","id":917560,"node_id":"MDQ6VXNlcjkxNzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"assignees":[{"login":"natarajaya","id":917560,"node_id":"MDQ6VXNlcjkxNzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185/commits","review_comments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185/comments","review_comment_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/185/comments","statuses_url":"https://api.github.com/repos/gpii-ops/gpii-infra/statuses/a0d2f9e030767a37fd15fbac49a7e5b1c576c5cf","head":{"label":"natarajaya:master","ref":"master","sha":"a0d2f9e030767a37fd15fbac49a7e5b1c576c5cf","user":{"login":"natarajaya","id":917560,"node_id":"MDQ6VXNlcjkxNzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"repo":{"id":130919780,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5MTk3ODA=","name":"gpii-infra","full_name":"natarajaya/gpii-infra","private":false,"owner":{"login":"natarajaya","id":917560,"node_id":"MDQ6VXNlcjkxNzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/natarajaya/gpii-infra","description":null,"fork":true,"url":"https://api.github.com/repos/natarajaya/gpii-infra","forks_url":"https://api.github.com/repos/natarajaya/gpii-infra/forks","keys_url":"https://api.github.com/repos/natarajaya/gpii-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natarajaya/gpii-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natarajaya/gpii-infra/teams","hooks_url":"https://api.github.com/repos/natarajaya/gpii-infra/hooks","issue_events_url":"https://api.github.com/repos/natarajaya/gpii-infra/issues/events{/number}","events_url":"https://api.github.com/repos/natarajaya/gpii-infra/events","assignees_url":"https://api.github.com/repos/natarajaya/gpii-infra/assignees{/user}","branches_url":"https://api.github.com/repos/natarajaya/gpii-infra/branches{/branch}","tags_url":"https://api.github.com/repos/natarajaya/gpii-infra/tags","blobs_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natarajaya/gpii-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/natarajaya/gpii-infra/languages","stargazers_url":"https://api.github.com/repos/natarajaya/gpii-infra/stargazers","contributors_url":"https://api.github.com/repos/natarajaya/gpii-infra/contributors","subscribers_url":"https://api.github.com/repos/natarajaya/gpii-infra/subscribers","subscription_url":"https://api.github.com/repos/natarajaya/gpii-infra/subscription","commits_url":"https://api.github.com/repos/natarajaya/gpii-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/natarajaya/gpii-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/natarajaya/gpii-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/natarajaya/gpii-infra/contents/{+path}","compare_url":"https://api.github.com/repos/natarajaya/gpii-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natarajaya/gpii-infra/merges","archive_url":"https://api.github.com/repos/natarajaya/gpii-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natarajaya/gpii-infra/downloads","issues_url":"https://api.github.com/repos/natarajaya/gpii-infra/issues{/number}","pulls_url":"https://api.github.com/repos/natarajaya/gpii-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/natarajaya/gpii-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/natarajaya/gpii-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natarajaya/gpii-infra/labels{/name}","releases_url":"https://api.github.com/repos/natarajaya/gpii-infra/releases{/id}","deployments_url":"https://api.github.com/repos/natarajaya/gpii-infra/deployments","created_at":"2018-04-24T22:17:14Z","updated_at":"2018-10-19T01:07:34Z","pushed_at":"2018-10-19T04:23:54Z","git_url":"git://github.com/natarajaya/gpii-infra.git","ssh_url":"git@github.com:natarajaya/gpii-infra.git","clone_url":"https://github.com/natarajaya/gpii-infra.git","svn_url":"https://github.com/natarajaya/gpii-infra","homepage":null,"size":1443,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gpii-ops:master","ref":"master","sha":"40c3a370da77aae48369469f187802649e55f1b9","user":{"login":"gpii-ops","id":10503302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTAzMzAy","avatar_url":"https://avatars1.githubusercontent.com/u/10503302?v=4","gravatar_id":"","url":"https://api.github.com/users/gpii-ops","html_url":"https://github.com/gpii-ops","followers_url":"https://api.github.com/users/gpii-ops/followers","following_url":"https://api.github.com/users/gpii-ops/following{/other_user}","gists_url":"https://api.github.com/users/gpii-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/gpii-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpii-ops/subscriptions","organizations_url":"https://api.github.com/users/gpii-ops/orgs","repos_url":"https://api.github.com/users/gpii-ops/repos","events_url":"https://api.github.com/users/gpii-ops/events{/privacy}","received_events_url":"https://api.github.com/users/gpii-ops/received_events","type":"Organization","site_admin":false},"repo":{"id":97767979,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzc2Nzk3OQ==","name":"gpii-infra","full_name":"gpii-ops/gpii-infra","private":false,"owner":{"login":"gpii-ops","id":10503302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTAzMzAy","avatar_url":"https://avatars1.githubusercontent.com/u/10503302?v=4","gravatar_id":"","url":"https://api.github.com/users/gpii-ops","html_url":"https://github.com/gpii-ops","followers_url":"https://api.github.com/users/gpii-ops/followers","following_url":"https://api.github.com/users/gpii-ops/following{/other_user}","gists_url":"https://api.github.com/users/gpii-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/gpii-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpii-ops/subscriptions","organizations_url":"https://api.github.com/users/gpii-ops/orgs","repos_url":"https://api.github.com/users/gpii-ops/repos","events_url":"https://api.github.com/users/gpii-ops/events{/privacy}","received_events_url":"https://api.github.com/users/gpii-ops/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gpii-ops/gpii-infra","description":null,"fork":true,"url":"https://api.github.com/repos/gpii-ops/gpii-infra","forks_url":"https://api.github.com/repos/gpii-ops/gpii-infra/forks","keys_url":"https://api.github.com/repos/gpii-ops/gpii-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpii-ops/gpii-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpii-ops/gpii-infra/teams","hooks_url":"https://api.github.com/repos/gpii-ops/gpii-infra/hooks","issue_events_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/events{/number}","events_url":"https://api.github.com/repos/gpii-ops/gpii-infra/events","assignees_url":"https://api.github.com/repos/gpii-ops/gpii-infra/assignees{/user}","branches_url":"https://api.github.com/repos/gpii-ops/gpii-infra/branches{/branch}","tags_url":"https://api.github.com/repos/gpii-ops/gpii-infra/tags","blobs_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpii-ops/gpii-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/gpii-ops/gpii-infra/languages","stargazers_url":"https://api.github.com/repos/gpii-ops/gpii-infra/stargazers","contributors_url":"https://api.github.com/repos/gpii-ops/gpii-infra/contributors","subscribers_url":"https://api.github.com/repos/gpii-ops/gpii-infra/subscribers","subscription_url":"https://api.github.com/repos/gpii-ops/gpii-infra/subscription","commits_url":"https://api.github.com/repos/gpii-ops/gpii-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpii-ops/gpii-infra/contents/{+path}","compare_url":"https://api.github.com/repos/gpii-ops/gpii-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpii-ops/gpii-infra/merges","archive_url":"https://api.github.com/repos/gpii-ops/gpii-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpii-ops/gpii-infra/downloads","issues_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues{/number}","pulls_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/gpii-ops/gpii-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/gpii-ops/gpii-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpii-ops/gpii-infra/labels{/name}","releases_url":"https://api.github.com/repos/gpii-ops/gpii-infra/releases{/id}","deployments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/deployments","created_at":"2017-07-19T22:54:03Z","updated_at":"2018-10-19T11:49:02Z","pushed_at":"2018-10-19T13:53:26Z","git_url":"git://github.com/gpii-ops/gpii-infra.git","ssh_url":"git@github.com:gpii-ops/gpii-infra.git","clone_url":"https://github.com/gpii-ops/gpii-infra.git","svn_url":"https://github.com/gpii-ops/gpii-infra","homepage":null,"size":1432,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":10,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185"},"html":{"href":"https://github.com/gpii-ops/gpii-infra/pull/185"},"issue":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/185"},"comments":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/statuses/a0d2f9e030767a37fd15fbac49a7e5b1c576c5cf"}},"author_association":"NONE"}}
{"actor":{"display_login":"mrtyler"}}