{"action":"closed","number":1391,"pull_request":{"url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1391","id":178781222,"html_url":"https://github.com/FreeCAD/FreeCAD/pull/1391","diff_url":"https://github.com/FreeCAD/FreeCAD/pull/1391.diff","patch_url":"https://github.com/FreeCAD/FreeCAD/pull/1391.patch","issue_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1391","number":1391,"state":"closed","locked":false,"title":"[For v0.18] Sketcher: External Geometry as defining","user":{"login":"abdullahtahiriyo","id":5249162,"avatar_url":"https://avatars2.githubusercontent.com/u/5249162?v=4","gravatar_id":"","url":"https://api.github.com/users/abdullahtahiriyo","html_url":"https://github.com/abdullahtahiriyo","followers_url":"https://api.github.com/users/abdullahtahiriyo/followers","following_url":"https://api.github.com/users/abdullahtahiriyo/following{/other_user}","gists_url":"https://api.github.com/users/abdullahtahiriyo/gists{/gist_id}","starred_url":"https://api.github.com/users/abdullahtahiriyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdullahtahiriyo/subscriptions","organizations_url":"https://api.github.com/users/abdullahtahiriyo/orgs","repos_url":"https://api.github.com/users/abdullahtahiriyo/repos","events_url":"https://api.github.com/users/abdullahtahiriyo/events{/privacy}","received_events_url":"https://api.github.com/users/abdullahtahiriyo/received_events","type":"User","site_admin":false},"body":"https://forum.freecadweb.org/viewtopic.php?f=10&t=27727#p224065\r\n\r\nThank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:\r\n\r\n- [x] Branch rebased on latest master `git pull --rebase upstream master`\r\n- [ ] Unit tests confirmed to pass by running `./bin/FreeCAD --run-test 0`\r\n- [x] Commit message is [well-written](https://chris.beams.io/posts/git-commit/)\r\n- [ ] Commit message includes `issue #<id>` or `fixes #<id>` where `<id>` is the [associated MantisBT](https://freecadweb.org/wiki/tracker#GitHub_and_MantisBT) issue id if one exists\r\n\r\nAnd please remember to update the Wiki with the features added or changed once this PR is merged.\r\n\r\n---\r\n","created_at":"2018-04-02T06:23:14Z","updated_at":"2018-04-23T18:28:08Z","closed_at":"2018-04-23T18:28:08Z","merged_at":null,"merge_commit_sha":"3cd165badfdf543740ce5e5ece8ddfb9fb36a258","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1391/commits","review_comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1391/comments","review_comment_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1391/comments","statuses_url":"https://api.github.com/repos/FreeCAD/FreeCAD/statuses/19ed94a9780b3bb4807545ee0ef96221bb306c7c","head":{"label":"abdullahtahiriyo:_external_as_defining_newlinkproperty_7","ref":"_external_as_defining_newlinkproperty_7","sha":"19ed94a9780b3bb4807545ee0ef96221bb306c7c","user":{"login":"abdullahtahiriyo","id":5249162,"avatar_url":"https://avatars2.githubusercontent.com/u/5249162?v=4","gravatar_id":"","url":"https://api.github.com/users/abdullahtahiriyo","html_url":"https://github.com/abdullahtahiriyo","followers_url":"https://api.github.com/users/abdullahtahiriyo/followers","following_url":"https://api.github.com/users/abdullahtahiriyo/following{/other_user}","gists_url":"https://api.github.com/users/abdullahtahiriyo/gists{/gist_id}","starred_url":"https://api.github.com/users/abdullahtahiriyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdullahtahiriyo/subscriptions","organizations_url":"https://api.github.com/users/abdullahtahiriyo/orgs","repos_url":"https://api.github.com/users/abdullahtahiriyo/repos","events_url":"https://api.github.com/users/abdullahtahiriyo/events{/privacy}","received_events_url":"https://api.github.com/users/abdullahtahiriyo/received_events","type":"User","site_admin":false},"repo":{"id":20015075,"name":"FreeCAD_sf_master","full_name":"abdullahtahiriyo/FreeCAD_sf_master","owner":{"login":"abdullahtahiriyo","id":5249162,"avatar_url":"https://avatars2.githubusercontent.com/u/5249162?v=4","gravatar_id":"","url":"https://api.github.com/users/abdullahtahiriyo","html_url":"https://github.com/abdullahtahiriyo","followers_url":"https://api.github.com/users/abdullahtahiriyo/followers","following_url":"https://api.github.com/users/abdullahtahiriyo/following{/other_user}","gists_url":"https://api.github.com/users/abdullahtahiriyo/gists{/gist_id}","starred_url":"https://api.github.com/users/abdullahtahiriyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdullahtahiriyo/subscriptions","organizations_url":"https://api.github.com/users/abdullahtahiriyo/orgs","repos_url":"https://api.github.com/users/abdullahtahiriyo/repos","events_url":"https://api.github.com/users/abdullahtahiriyo/events{/privacy}","received_events_url":"https://api.github.com/users/abdullahtahiriyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abdullahtahiriyo/FreeCAD_sf_master","description":"mirror of the FreeCAD sf.net git master branch. Clone this one if you want to start FreeCAD development!  ","fork":true,"url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master","forks_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/forks","keys_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/teams","hooks_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/hooks","issue_events_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/issues/events{/number}","events_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/events","assignees_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/assignees{/user}","branches_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/branches{/branch}","tags_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/tags","blobs_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/git/refs{/sha}","trees_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/statuses/{sha}","languages_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/languages","stargazers_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/stargazers","contributors_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/contributors","subscribers_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/subscribers","subscription_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/subscription","commits_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/commits{/sha}","git_commits_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/git/commits{/sha}","comments_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/comments{/number}","issue_comment_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/issues/comments{/number}","contents_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/contents/{+path}","compare_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/merges","archive_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/downloads","issues_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/issues{/number}","pulls_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/pulls{/number}","milestones_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/milestones{/number}","notifications_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/labels{/name}","releases_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/releases{/id}","deployments_url":"https://api.github.com/repos/abdullahtahiriyo/FreeCAD_sf_master/deployments","created_at":"2014-05-21T09:05:37Z","updated_at":"2016-11-21T10:15:04Z","pushed_at":"2018-04-23T18:26:08Z","git_url":"git://github.com/abdullahtahiriyo/FreeCAD_sf_master.git","ssh_url":"git@github.com:abdullahtahiriyo/FreeCAD_sf_master.git","clone_url":"https://github.com/abdullahtahiriyo/FreeCAD_sf_master.git","svn_url":"https://github.com/abdullahtahiriyo/FreeCAD_sf_master","homepage":null,"size":567311,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeCAD:master","ref":"master","sha":"2891173923bcecaace64e0544f5773facbdef436","user":{"login":"FreeCAD","id":2306237,"avatar_url":"https://avatars1.githubusercontent.com/u/2306237?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeCAD","html_url":"https://github.com/FreeCAD","followers_url":"https://api.github.com/users/FreeCAD/followers","following_url":"https://api.github.com/users/FreeCAD/following{/other_user}","gists_url":"https://api.github.com/users/FreeCAD/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCAD/subscriptions","organizations_url":"https://api.github.com/users/FreeCAD/orgs","repos_url":"https://api.github.com/users/FreeCAD/repos","events_url":"https://api.github.com/users/FreeCAD/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCAD/received_events","type":"Organization","site_admin":false},"repo":{"id":5736080,"name":"FreeCAD","full_name":"FreeCAD/FreeCAD","owner":{"login":"FreeCAD","id":2306237,"avatar_url":"https://avatars1.githubusercontent.com/u/2306237?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeCAD","html_url":"https://github.com/FreeCAD","followers_url":"https://api.github.com/users/FreeCAD/followers","following_url":"https://api.github.com/users/FreeCAD/following{/other_user}","gists_url":"https://api.github.com/users/FreeCAD/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCAD/subscriptions","organizations_url":"https://api.github.com/users/FreeCAD/orgs","repos_url":"https://api.github.com/users/FreeCAD/repos","events_url":"https://api.github.com/users/FreeCAD/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeCAD/FreeCAD","description":"This is the official source code of FreeCAD, a free and opensource multiplatform 3D parametric modeler","fork":false,"url":"https://api.github.com/repos/FreeCAD/FreeCAD","forks_url":"https://api.github.com/repos/FreeCAD/FreeCAD/forks","keys_url":"https://api.github.com/repos/FreeCAD/FreeCAD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeCAD/FreeCAD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeCAD/FreeCAD/teams","hooks_url":"https://api.github.com/repos/FreeCAD/FreeCAD/hooks","issue_events_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/events{/number}","events_url":"https://api.github.com/repos/FreeCAD/FreeCAD/events","assignees_url":"https://api.github.com/repos/FreeCAD/FreeCAD/assignees{/user}","branches_url":"https://api.github.com/repos/FreeCAD/FreeCAD/branches{/branch}","tags_url":"https://api.github.com/repos/FreeCAD/FreeCAD/tags","blobs_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeCAD/FreeCAD/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeCAD/FreeCAD/languages","stargazers_url":"https://api.github.com/repos/FreeCAD/FreeCAD/stargazers","contributors_url":"https://api.github.com/repos/FreeCAD/FreeCAD/contributors","subscribers_url":"https://api.github.com/repos/FreeCAD/FreeCAD/subscribers","subscription_url":"https://api.github.com/repos/FreeCAD/FreeCAD/subscription","commits_url":"https://api.github.com/repos/FreeCAD/FreeCAD/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeCAD/FreeCAD/contents/{+path}","compare_url":"https://api.github.com/repos/FreeCAD/FreeCAD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeCAD/FreeCAD/merges","archive_url":"https://api.github.com/repos/FreeCAD/FreeCAD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeCAD/FreeCAD/downloads","issues_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues{/number}","pulls_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeCAD/FreeCAD/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeCAD/FreeCAD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeCAD/FreeCAD/labels{/name}","releases_url":"https://api.github.com/repos/FreeCAD/FreeCAD/releases{/id}","deployments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/deployments","created_at":"2012-09-09T08:25:02Z","updated_at":"2018-04-23T16:20:59Z","pushed_at":"2018-04-23T18:27:36Z","git_url":"git://github.com/FreeCAD/FreeCAD.git","ssh_url":"git@github.com:FreeCAD/FreeCAD.git","clone_url":"https://github.com/FreeCAD/FreeCAD.git","svn_url":"https://github.com/FreeCAD/FreeCAD","homepage":"http://www.freecadweb.org","size":634340,"stargazers_count":2455,"watchers_count":2455,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":933,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":933,"open_issues":18,"watchers":2455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1391"},"html":{"href":"https://github.com/FreeCAD/FreeCAD/pull/1391"},"issue":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1391"},"comments":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1391/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1391/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1391/commits"},"statuses":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/statuses/19ed94a9780b3bb4807545ee0ef96221bb306c7c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":23,"additions":1217,"deletions":222,"changed_files":17}}
{"actor":{"display_login":"abdullahtahiriyo"}}