{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/comments/187358537","pull_request_review_id":119122720,"id":187358537,"diff_hunk":"@@ -112,14 +112,34 @@\n                         </configuration>\n                     </execution>\n                     <execution>\n-                        <id>gulp build</id>\n-                        <goals>\n-                            <goal>gulp</goal>\n-                        </goals>\n-                        <phase>generate-resources</phase>\n-                        <configuration>\n-                            <arguments>build</arguments>\n-                        </configuration>\n+                      <id>gulp brand</id>\n+                      <goals>\n+                        <goal>gulp</goal>\n+                      </goals>\n+\n+                      <!-- optional: the default phase is \"generate-resources\" -->\n+                      <phase>generate-resources</phase>\n+\n+                      <configuration>\n+                        <!-- optional: if not specified, it will run gulp's default\n+                        task (and you can remove this whole <configuration> section.) -->\n+                        <arguments>brand --repo ${branding.repo} --branch ${branding.branch}</arguments>","path":"pom.xml","position":23,"original_position":23,"commit_id":"7284934aaff16175e4ce1a7bd1852b1437a63872","original_commit_id":"b22bc7a560632d014a0e74049fcd5dd8365e87d9","user":{"login":"ryanemerson","id":765332,"avatar_url":"https://avatars3.githubusercontent.com/u/765332?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanemerson","html_url":"https://github.com/ryanemerson","followers_url":"https://api.github.com/users/ryanemerson/followers","following_url":"https://api.github.com/users/ryanemerson/following{/other_user}","gists_url":"https://api.github.com/users/ryanemerson/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanemerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanemerson/subscriptions","organizations_url":"https://api.github.com/users/ryanemerson/orgs","repos_url":"https://api.github.com/users/ryanemerson/repos","events_url":"https://api.github.com/users/ryanemerson/events{/privacy}","received_events_url":"https://api.github.com/users/ryanemerson/received_events","type":"User","site_admin":false},"body":"So at the moment when we call `mvn clean install`, both `gulp brand` and then `gulp build` are being called. We should just need to call `gulp build`. In `gulpfile.js` we can simply add `brand` as one of the requirements for the `build` task. If no `cmdParams.repo` or `cmdParams.branch` is specified, then do nothing (the current code in `brand.js`). In the pom.xml, we can set the default value of `branding.repo` and `branding.branch` to be empty, so unless these parameters are set no branding with external repos occur when `mvn clean install` is called.","created_at":"2018-05-10T15:04:27Z","updated_at":"2018-05-10T15:04:27Z","html_url":"https://github.com/infinispan/infinispan-management-console/pull/244#discussion_r187358537","pull_request_url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/comments/187358537"},"html":{"href":"https://github.com/infinispan/infinispan-management-console/pull/244#discussion_r187358537"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244"}},"in_reply_to_id":187300897},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244","id":183047561,"html_url":"https://github.com/infinispan/infinispan-management-console/pull/244","diff_url":"https://github.com/infinispan/infinispan-management-console/pull/244.diff","patch_url":"https://github.com/infinispan/infinispan-management-console/pull/244.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan-management-console/issues/244","number":244,"state":"open","locked":false,"title":"ISPN-9039 Parametrized admin console branding","user":{"login":"vblagoje","id":458335,"avatar_url":"https://avatars0.githubusercontent.com/u/458335?v=4","gravatar_id":"","url":"https://api.github.com/users/vblagoje","html_url":"https://github.com/vblagoje","followers_url":"https://api.github.com/users/vblagoje/followers","following_url":"https://api.github.com/users/vblagoje/following{/other_user}","gists_url":"https://api.github.com/users/vblagoje/gists{/gist_id}","starred_url":"https://api.github.com/users/vblagoje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vblagoje/subscriptions","organizations_url":"https://api.github.com/users/vblagoje/orgs","repos_url":"https://api.github.com/users/vblagoje/repos","events_url":"https://api.github.com/users/vblagoje/events{/privacy}","received_events_url":"https://api.github.com/users/vblagoje/received_events","type":"User","site_admin":false},"body":"@ryanemerson just a preview of how we can do all the string related branding. Comments and feedback welcome. We'll deal with images separately","created_at":"2018-04-20T12:28:02Z","updated_at":"2018-05-10T15:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42ed7eb2db119c9a6291948c22b2c75d1b971090","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan-management-console/issues/244/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan-management-console/statuses/7284934aaff16175e4ce1a7bd1852b1437a63872","head":{"label":"vblagoje:t_9039","ref":"t_9039","sha":"7284934aaff16175e4ce1a7bd1852b1437a63872","user":{"login":"vblagoje","id":458335,"avatar_url":"https://avatars0.githubusercontent.com/u/458335?v=4","gravatar_id":"","url":"https://api.github.com/users/vblagoje","html_url":"https://github.com/vblagoje","followers_url":"https://api.github.com/users/vblagoje/followers","following_url":"https://api.github.com/users/vblagoje/following{/other_user}","gists_url":"https://api.github.com/users/vblagoje/gists{/gist_id}","starred_url":"https://api.github.com/users/vblagoje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vblagoje/subscriptions","organizations_url":"https://api.github.com/users/vblagoje/orgs","repos_url":"https://api.github.com/users/vblagoje/repos","events_url":"https://api.github.com/users/vblagoje/events{/privacy}","received_events_url":"https://api.github.com/users/vblagoje/received_events","type":"User","site_admin":false},"repo":{"id":31507376,"name":"infinispan-management-console","full_name":"vblagoje/infinispan-management-console","owner":{"login":"vblagoje","id":458335,"avatar_url":"https://avatars0.githubusercontent.com/u/458335?v=4","gravatar_id":"","url":"https://api.github.com/users/vblagoje","html_url":"https://github.com/vblagoje","followers_url":"https://api.github.com/users/vblagoje/followers","following_url":"https://api.github.com/users/vblagoje/following{/other_user}","gists_url":"https://api.github.com/users/vblagoje/gists{/gist_id}","starred_url":"https://api.github.com/users/vblagoje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vblagoje/subscriptions","organizations_url":"https://api.github.com/users/vblagoje/orgs","repos_url":"https://api.github.com/users/vblagoje/repos","events_url":"https://api.github.com/users/vblagoje/events{/privacy}","received_events_url":"https://api.github.com/users/vblagoje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vblagoje/infinispan-management-console","description":"Infinispan Web Management Console","fork":true,"url":"https://api.github.com/repos/vblagoje/infinispan-management-console","forks_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/forks","keys_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/teams","hooks_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/hooks","issue_events_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/issues/events{/number}","events_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/events","assignees_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/assignees{/user}","branches_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/branches{/branch}","tags_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/tags","blobs_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/statuses/{sha}","languages_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/languages","stargazers_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/stargazers","contributors_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/contributors","subscribers_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/subscribers","subscription_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/subscription","commits_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/contents/{+path}","compare_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/merges","archive_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/downloads","issues_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/issues{/number}","pulls_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/pulls{/number}","milestones_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/milestones{/number}","notifications_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/labels{/name}","releases_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/releases{/id}","deployments_url":"https://api.github.com/repos/vblagoje/infinispan-management-console/deployments","created_at":"2015-03-01T19:15:36Z","updated_at":"2016-10-24T10:38:09Z","pushed_at":"2018-05-10T14:41:46Z","git_url":"git://github.com/vblagoje/infinispan-management-console.git","ssh_url":"git@github.com:vblagoje/infinispan-management-console.git","clone_url":"https://github.com/vblagoje/infinispan-management-console.git","svn_url":"https://github.com/vblagoje/infinispan-management-console","homepage":null,"size":1964,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"11ad69c11efec67e00efe141541246d000512f8e","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":27542064,"name":"infinispan-management-console","full_name":"infinispan/infinispan-management-console","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan-management-console","description":"Infinispan Web Management Console","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan-management-console","forks_url":"https://api.github.com/repos/infinispan/infinispan-management-console/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan-management-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan-management-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan-management-console/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan-management-console/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan-management-console/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan-management-console/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan-management-console/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan-management-console/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan-management-console/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan-management-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan-management-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan-management-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan-management-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan-management-console/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan-management-console/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan-management-console/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan-management-console/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan-management-console/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan-management-console/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan-management-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan-management-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan-management-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan-management-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan-management-console/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan-management-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan-management-console/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan-management-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan-management-console/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan-management-console/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan-management-console/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan-management-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan-management-console/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan-management-console/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan-management-console/deployments","created_at":"2014-12-04T13:38:41Z","updated_at":"2018-05-04T10:04:17Z","pushed_at":"2018-05-10T14:41:47Z","git_url":"git://github.com/infinispan/infinispan-management-console.git","ssh_url":"git@github.com:infinispan/infinispan-management-console.git","clone_url":"https://github.com/infinispan/infinispan-management-console.git","svn_url":"https://github.com/infinispan/infinispan-management-console","homepage":null,"size":1867,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":22,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244"},"html":{"href":"https://github.com/infinispan/infinispan-management-console/pull/244"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/issues/244"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan-management-console/statuses/7284934aaff16175e4ce1a7bd1852b1437a63872"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ryanemerson"}}