{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/hscim/pulls/comments/217142350","pull_request_review_id":154774506,"id":217142350,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE0MjM1MA==","diff_hunk":"@@ -50,10 +54,16 @@ liftAtomic :: STM a -> ReaderT TestStorage Handler a\n liftAtomic = liftIO . atomically\n \n instance UserDB TestServer where\n-  list = do\n+  list mbFilter = do\n     m <- userDB <$> ask\n     l <- liftIO . atomically $ ListT.toList $ STMMap.stream m\n-    return $ fromList $ snd <$> l\n+    let check user = case mbFilter of\n+          Nothing -> Right True\n+          Just f  -> over _Left FilterError $\n+                     filterUser f (value (thing user))\n+    return $\n+      fromList . sortWith (Common.id . thing) <$>\n+      filterM check (snd <$> l)","path":"src/Web/SCIM/Server/Mock.hs","position":47,"original_position":47,"commit_id":"3c88e3504ff78c89e6d87db398ace0005bcbf6cb","original_commit_id":"81b72bb52cccef4b1e9917f170afdbb703b1bca6","user":{"login":"fisx","id":10210727,"node_id":"MDQ6VXNlcjEwMjEwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/10210727?v=4","gravatar_id":"","url":"https://api.github.com/users/fisx","html_url":"https://github.com/fisx","followers_url":"https://api.github.com/users/fisx/followers","following_url":"https://api.github.com/users/fisx/following{/other_user}","gists_url":"https://api.github.com/users/fisx/gists{/gist_id}","starred_url":"https://api.github.com/users/fisx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisx/subscriptions","organizations_url":"https://api.github.com/users/fisx/orgs","repos_url":"https://api.github.com/users/fisx/repos","events_url":"https://api.github.com/users/fisx/events{/privacy}","received_events_url":"https://api.github.com/users/fisx/received_events","type":"User","site_admin":false},"body":"I just noticed that there are a lot of one-letter variables here.  Did that slip through in my previous reviews?  Please try to avoid one-letter variables (or fight me for it), and please fix it now iff you feel like it.","created_at":"2018-09-12T18:31:36Z","updated_at":"2018-09-12T18:41:13Z","html_url":"https://github.com/wireapp/hscim/pull/11#discussion_r217142350","pull_request_url":"https://api.github.com/repos/wireapp/hscim/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wireapp/hscim/pulls/comments/217142350"},"html":{"href":"https://github.com/wireapp/hscim/pull/11#discussion_r217142350"},"pull_request":{"href":"https://api.github.com/repos/wireapp/hscim/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/hscim/pulls/11","id":215016434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDE2NDM0","html_url":"https://github.com/wireapp/hscim/pull/11","diff_url":"https://github.com/wireapp/hscim/pull/11.diff","patch_url":"https://github.com/wireapp/hscim/pull/11.patch","issue_url":"https://api.github.com/repos/wireapp/hscim/issues/11","number":11,"state":"open","locked":false,"title":"Pass the Okta compliance test (final PR!)","user":{"login":"neongreen","id":1523306,"node_id":"MDQ6VXNlcjE1MjMzMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1523306?v=4","gravatar_id":"","url":"https://api.github.com/users/neongreen","html_url":"https://github.com/neongreen","followers_url":"https://api.github.com/users/neongreen/followers","following_url":"https://api.github.com/users/neongreen/following{/other_user}","gists_url":"https://api.github.com/users/neongreen/gists{/gist_id}","starred_url":"https://api.github.com/users/neongreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neongreen/subscriptions","organizations_url":"https://api.github.com/users/neongreen/orgs","repos_url":"https://api.github.com/users/neongreen/repos","events_url":"https://api.github.com/users/neongreen/events{/privacy}","received_events_url":"https://api.github.com/users/neongreen/received_events","type":"User","site_admin":false},"body":"https://www.runscope.com/radar/gm7h3y05bhbc/9ccf7a6b-9489-49b4-b384-053f0f09bfca/history/b32cb030-5f77-4ff1-9d27-e2d1fc45d83a\r\n\r\nCan be reviewed commit-by-commit.","created_at":"2018-09-12T16:05:01Z","updated_at":"2018-09-12T18:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"351900dbede67ebc05e21a94c22291e71e449633","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/hscim/pulls/11/commits","review_comments_url":"https://api.github.com/repos/wireapp/hscim/pulls/11/comments","review_comment_url":"https://api.github.com/repos/wireapp/hscim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/hscim/issues/11/comments","statuses_url":"https://api.github.com/repos/wireapp/hscim/statuses/3c88e3504ff78c89e6d87db398ace0005bcbf6cb","head":{"label":"wireapp:four","ref":"four","sha":"3c88e3504ff78c89e6d87db398ace0005bcbf6cb","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":126029023,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwMjkwMjM=","name":"hscim","full_name":"wireapp/hscim","owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/hscim","description":"System for Cross-domain Identity Management (SCIM)","fork":false,"url":"https://api.github.com/repos/wireapp/hscim","forks_url":"https://api.github.com/repos/wireapp/hscim/forks","keys_url":"https://api.github.com/repos/wireapp/hscim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/hscim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/hscim/teams","hooks_url":"https://api.github.com/repos/wireapp/hscim/hooks","issue_events_url":"https://api.github.com/repos/wireapp/hscim/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/hscim/events","assignees_url":"https://api.github.com/repos/wireapp/hscim/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/hscim/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/hscim/tags","blobs_url":"https://api.github.com/repos/wireapp/hscim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/hscim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/hscim/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/hscim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/hscim/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/hscim/languages","stargazers_url":"https://api.github.com/repos/wireapp/hscim/stargazers","contributors_url":"https://api.github.com/repos/wireapp/hscim/contributors","subscribers_url":"https://api.github.com/repos/wireapp/hscim/subscribers","subscription_url":"https://api.github.com/repos/wireapp/hscim/subscription","commits_url":"https://api.github.com/repos/wireapp/hscim/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/hscim/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/hscim/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/hscim/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/hscim/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/hscim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/hscim/merges","archive_url":"https://api.github.com/repos/wireapp/hscim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/hscim/downloads","issues_url":"https://api.github.com/repos/wireapp/hscim/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/hscim/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/hscim/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/hscim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/hscim/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/hscim/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/hscim/deployments","created_at":"2018-03-20T14:19:51Z","updated_at":"2018-09-10T15:34:30Z","pushed_at":"2018-09-12T16:05:02Z","git_url":"git://github.com/wireapp/hscim.git","ssh_url":"git@github.com:wireapp/hscim.git","clone_url":"https://github.com/wireapp/hscim.git","svn_url":"https://github.com/wireapp/hscim","homepage":"","size":98,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"wireapp:master","ref":"master","sha":"5a402d302af725b98930ce17e4380cee18f9b429","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":126029023,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwMjkwMjM=","name":"hscim","full_name":"wireapp/hscim","owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/hscim","description":"System for Cross-domain Identity Management (SCIM)","fork":false,"url":"https://api.github.com/repos/wireapp/hscim","forks_url":"https://api.github.com/repos/wireapp/hscim/forks","keys_url":"https://api.github.com/repos/wireapp/hscim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/hscim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/hscim/teams","hooks_url":"https://api.github.com/repos/wireapp/hscim/hooks","issue_events_url":"https://api.github.com/repos/wireapp/hscim/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/hscim/events","assignees_url":"https://api.github.com/repos/wireapp/hscim/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/hscim/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/hscim/tags","blobs_url":"https://api.github.com/repos/wireapp/hscim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/hscim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/hscim/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/hscim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/hscim/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/hscim/languages","stargazers_url":"https://api.github.com/repos/wireapp/hscim/stargazers","contributors_url":"https://api.github.com/repos/wireapp/hscim/contributors","subscribers_url":"https://api.github.com/repos/wireapp/hscim/subscribers","subscription_url":"https://api.github.com/repos/wireapp/hscim/subscription","commits_url":"https://api.github.com/repos/wireapp/hscim/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/hscim/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/hscim/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/hscim/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/hscim/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/hscim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/hscim/merges","archive_url":"https://api.github.com/repos/wireapp/hscim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/hscim/downloads","issues_url":"https://api.github.com/repos/wireapp/hscim/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/hscim/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/hscim/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/hscim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/hscim/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/hscim/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/hscim/deployments","created_at":"2018-03-20T14:19:51Z","updated_at":"2018-09-10T15:34:30Z","pushed_at":"2018-09-12T16:05:02Z","git_url":"git://github.com/wireapp/hscim.git","ssh_url":"git@github.com:wireapp/hscim.git","clone_url":"https://github.com/wireapp/hscim.git","svn_url":"https://github.com/wireapp/hscim","homepage":"","size":98,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/hscim/pulls/11"},"html":{"href":"https://github.com/wireapp/hscim/pull/11"},"issue":{"href":"https://api.github.com/repos/wireapp/hscim/issues/11"},"comments":{"href":"https://api.github.com/repos/wireapp/hscim/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/hscim/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/hscim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/hscim/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/hscim/statuses/3c88e3504ff78c89e6d87db398ace0005bcbf6cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fisx"}}