{"action":"closed","issue":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/567","repository_url":"https://api.github.com/repos/0xProject/0x-monorepo","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/567/labels{/name}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/567/comments","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/567/events","html_url":"https://github.com/0xProject/0x-monorepo/issues/567","id":318779177,"number":567,"title":"validateOrderFillableOrThrowAsync throws INSUFFICIENT_MAKER_FEE_BALANCE on ZRX buy","user":{"login":"lukeautry","id":8770560,"avatar_url":"https://avatars0.githubusercontent.com/u/8770560?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeautry","html_url":"https://github.com/lukeautry","followers_url":"https://api.github.com/users/lukeautry/followers","following_url":"https://api.github.com/users/lukeautry/following{/other_user}","gists_url":"https://api.github.com/users/lukeautry/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeautry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeautry/subscriptions","organizations_url":"https://api.github.com/users/lukeautry/orgs","repos_url":"https://api.github.com/users/lukeautry/repos","events_url":"https://api.github.com/users/lukeautry/events{/privacy}","received_events_url":"https://api.github.com/users/lukeautry/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"dekz","id":27389,"avatar_url":"https://avatars0.githubusercontent.com/u/27389?v=4","gravatar_id":"","url":"https://api.github.com/users/dekz","html_url":"https://github.com/dekz","followers_url":"https://api.github.com/users/dekz/followers","following_url":"https://api.github.com/users/dekz/following{/other_user}","gists_url":"https://api.github.com/users/dekz/gists{/gist_id}","starred_url":"https://api.github.com/users/dekz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dekz/subscriptions","organizations_url":"https://api.github.com/users/dekz/orgs","repos_url":"https://api.github.com/users/dekz/repos","events_url":"https://api.github.com/users/dekz/events{/privacy}","received_events_url":"https://api.github.com/users/dekz/received_events","type":"User","site_admin":false},"assignees":[{"login":"dekz","id":27389,"avatar_url":"https://avatars0.githubusercontent.com/u/27389?v=4","gravatar_id":"","url":"https://api.github.com/users/dekz","html_url":"https://github.com/dekz","followers_url":"https://api.github.com/users/dekz/followers","following_url":"https://api.github.com/users/dekz/following{/other_user}","gists_url":"https://api.github.com/users/dekz/gists{/gist_id}","starred_url":"https://api.github.com/users/dekz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dekz/subscriptions","organizations_url":"https://api.github.com/users/dekz/orgs","repos_url":"https://api.github.com/users/dekz/repos","events_url":"https://api.github.com/users/dekz/events{/privacy}","received_events_url":"https://api.github.com/users/dekz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-30T03:42:37Z","updated_at":"2018-05-02T00:16:45Z","closed_at":"2018-05-02T00:16:45Z","author_association":"CONTRIBUTOR","body":"My understanding of the expected behavior is that ZRX fees can be met as long as the other side of the trade has sufficient ZRX to pay the fees. This is pretty important for an exchange that accepts ZRX for fees as it allows users to enter the market without actually having ZRX yet. This works well with filling orders.\r\n\r\nWe've noticed that new limit orders (WETH maker, ZRX taker) are flagged as INSUFFICIENT_MAKER_FEE_BALANCE by validateOrderFillableOrThrowAsync in one of our workers. This is an example of an order that was flagged:\r\n\r\n```\r\n{\r\n   \"exchangeContractAddress\":\"0x12459c951127e0c374ff9105dda097662a027093\",\r\n   \"expirationUnixTimestampSec\":\"4102444800\",\r\n   \"feeRecipient\":\"0x173a2467cece1f752eb8416e337d0f0b58cad795\",\r\n   \"maker\":\"0xfaa53a74dd64e46b6e7a82893a4dec6904bdb606\",\r\n   \"makerFee\":\"96353762307020101\",\r\n   \"makerTokenAddress\":\"0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2\",\r\n   \"makerTokenAmount\":\"180100000000000000\",\r\n \"salt\":\"36174368916192981979559457829026432346101896339670862948314220586933861773564\",\r\n   \"serializedEcSignature\":\"{\\\"v\\\":27,\\\"r\\\":\\\"0xb620ea5714e9d1052e40b537aa71fe65a45d490a01718ace8cc479e337dedc80\\\",\\\"s\\\":\\\"0x561b95bfeae5edcf0da93bb1ce358220699e79a6bf931e4622d6a12f7b545349\\\"}\",\r\n   \"taker\":\"0x0000000000000000000000000000000000000000\",\r\n   \"takerFee\":\"200000000000000000\",\r\n   \"takerTokenAddress\":\"0xe41d2489571d322189246dafa5ebde1f4699f498\",\r\n   \"takerTokenAmount\":\"100000000000000000000\",\r\n   \"orderHash\":\"0x422a2c767e24a4d121cfee29157007efff0a543e9c91e8db9506b2f93ced4d98\"\r\n}\r\n```\r\n\r\n1) Is this actually a valid order, i.e. does the Exchange contract support 'just in time' purchases of ZRX?\r\n2) If so, shouldn't the JS client handle this edge case?"}}
{"actor":{"display_login":"dekz"}}