{"action":"created","comment":{"url":"https://api.github.com/repos/openebs/openebs/pulls/comments/189816579","pull_request_review_id":122066152,"id":189816579,"diff_hunk":"@@ -29,10 +29,14 @@ spec:\n           mountPath: /dev     \n         - name: tmp\n           mountPath: /tmp\n-          mountPropagation: Bidirectional\n+#         mountPropagation: Bidirectional\n+        lifecycle:\n+          postStart:\n+            exec:\n+              command: [\"/bin/sh\", \"-c\", \"sleep 15\"]","path":"k8s/crd-samples/deployment-cstor-pool.yaml","position":18,"original_position":18,"commit_id":"a315d5f050adfd3d43fee9112a294f84201094af","original_commit_id":"a315d5f050adfd3d43fee9112a294f84201094af","user":{"login":"avishnu","id":7765078,"avatar_url":"https://avatars2.githubusercontent.com/u/7765078?v=4","gravatar_id":"","url":"https://api.github.com/users/avishnu","html_url":"https://github.com/avishnu","followers_url":"https://api.github.com/users/avishnu/followers","following_url":"https://api.github.com/users/avishnu/following{/other_user}","gists_url":"https://api.github.com/users/avishnu/gists{/gist_id}","starred_url":"https://api.github.com/users/avishnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avishnu/subscriptions","organizations_url":"https://api.github.com/users/avishnu/orgs","repos_url":"https://api.github.com/users/avishnu/repos","events_url":"https://api.github.com/users/avishnu/events{/privacy}","received_events_url":"https://api.github.com/users/avishnu/received_events","type":"User","site_admin":false},"body":"Why do we start both the containers with \"-c\" \"sleep 15\" cmd-line arguments?","created_at":"2018-05-22T08:31:34Z","updated_at":"2018-05-22T08:31:34Z","html_url":"https://github.com/openebs/openebs/pull/1540#discussion_r189816579","pull_request_url":"https://api.github.com/repos/openebs/openebs/pulls/1540","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openebs/openebs/pulls/comments/189816579"},"html":{"href":"https://github.com/openebs/openebs/pull/1540#discussion_r189816579"},"pull_request":{"href":"https://api.github.com/repos/openebs/openebs/pulls/1540"}}},"pull_request":{"url":"https://api.github.com/repos/openebs/openebs/pulls/1540","id":189378032,"html_url":"https://github.com/openebs/openebs/pull/1540","diff_url":"https://github.com/openebs/openebs/pull/1540.diff","patch_url":"https://github.com/openebs/openebs/pull/1540.patch","issue_url":"https://api.github.com/repos/openebs/openebs/issues/1540","number":1540,"state":"open","locked":false,"title":"Upload yaml files for cstor-pool","user":{"login":"gkGaneshR","id":14148430,"avatar_url":"https://avatars3.githubusercontent.com/u/14148430?v=4","gravatar_id":"","url":"https://api.github.com/users/gkGaneshR","html_url":"https://github.com/gkGaneshR","followers_url":"https://api.github.com/users/gkGaneshR/followers","following_url":"https://api.github.com/users/gkGaneshR/following{/other_user}","gists_url":"https://api.github.com/users/gkGaneshR/gists{/gist_id}","starred_url":"https://api.github.com/users/gkGaneshR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkGaneshR/subscriptions","organizations_url":"https://api.github.com/users/gkGaneshR/orgs","repos_url":"https://api.github.com/users/gkGaneshR/repos","events_url":"https://api.github.com/users/gkGaneshR/events{/privacy}","received_events_url":"https://api.github.com/users/gkGaneshR/received_events","type":"User","site_admin":false},"body":"1. Why is this change necessary ?\r\nfixes: openebs/openebs#1539\r\n\r\n2. How does this change address the issue ?\r\nThe initial version of cstor-pool deployment and custom resource yaml\r\nis updated.\r\n\r\n3. How to verify this change ?\r\nMake sure /var/openebs/shared-<a2b> dir is present in deploy yaml.\r\nkubectl apply -f pool-resource-cluster-1.yaml\r\nGet UID of the corresponding pool\r\nMake sure the same UID is passed as env variable to deployment yaml.\r\nMake sure the disk specified on CR is present\r\nkubectl apply -f deployment-cstor-pool.yaml\r\nTo verify,\r\nkubectl logs cstor-pool-deploy-<guid> -c cstor-pool-mgmt\r\nCan also verify by kubectl exec into pod,\r\nCheck status of CR if it is online for successful pool creation,\r\noffline for failure.\r\nTo delete,\r\nkubectl delete -f pool-resource-cluster-1.yaml\r\nIf successful deletion,\r\nCR is deleted, Can also verify from zpool status by kubectl exec into pod\r\nIf deletion is failed,\r\ncstorpool Status field shows deletion-failed.\r\n\r\n**Special notes for your reviewer**: The image name here will be changed to openebs once the business logic pr is raised, reviewed and merged in openebs/maya.\r\nStatus should always be init to create pool.\r\nThis is developed and verified on minikube environment.\r\nStart k8s cluster like this,\r\n\r\nReference: https://docs.google.com/document/d/1Q5W3uHktHa-vOm8oGp-3kpAQ3V1tvyk5AYmxxtf57Rg/edit?usp=sharing\r\n\r\nSigned-off-by: gkGaneshR <gkganesh126@gmail.com>\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you -->\r\n","created_at":"2018-05-21T13:23:26Z","updated_at":"2018-05-22T08:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4ef762a51f0b218d8461ab703c2a52297ac7ecd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/openebs/pulls/1540/commits","review_comments_url":"https://api.github.com/repos/openebs/openebs/pulls/1540/comments","review_comment_url":"https://api.github.com/repos/openebs/openebs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/openebs/issues/1540/comments","statuses_url":"https://api.github.com/repos/openebs/openebs/statuses/a315d5f050adfd3d43fee9112a294f84201094af","head":{"label":"gkGaneshR:alpha-cstor-pool","ref":"alpha-cstor-pool","sha":"a315d5f050adfd3d43fee9112a294f84201094af","user":{"login":"gkGaneshR","id":14148430,"avatar_url":"https://avatars3.githubusercontent.com/u/14148430?v=4","gravatar_id":"","url":"https://api.github.com/users/gkGaneshR","html_url":"https://github.com/gkGaneshR","followers_url":"https://api.github.com/users/gkGaneshR/followers","following_url":"https://api.github.com/users/gkGaneshR/following{/other_user}","gists_url":"https://api.github.com/users/gkGaneshR/gists{/gist_id}","starred_url":"https://api.github.com/users/gkGaneshR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkGaneshR/subscriptions","organizations_url":"https://api.github.com/users/gkGaneshR/orgs","repos_url":"https://api.github.com/users/gkGaneshR/repos","events_url":"https://api.github.com/users/gkGaneshR/events{/privacy}","received_events_url":"https://api.github.com/users/gkGaneshR/received_events","type":"User","site_admin":false},"repo":{"id":94696467,"name":"openebs","full_name":"gkGaneshR/openebs","owner":{"login":"gkGaneshR","id":14148430,"avatar_url":"https://avatars3.githubusercontent.com/u/14148430?v=4","gravatar_id":"","url":"https://api.github.com/users/gkGaneshR","html_url":"https://github.com/gkGaneshR","followers_url":"https://api.github.com/users/gkGaneshR/followers","following_url":"https://api.github.com/users/gkGaneshR/following{/other_user}","gists_url":"https://api.github.com/users/gkGaneshR/gists{/gist_id}","starred_url":"https://api.github.com/users/gkGaneshR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkGaneshR/subscriptions","organizations_url":"https://api.github.com/users/gkGaneshR/orgs","repos_url":"https://api.github.com/users/gkGaneshR/repos","events_url":"https://api.github.com/users/gkGaneshR/events{/privacy}","received_events_url":"https://api.github.com/users/gkGaneshR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkGaneshR/openebs","description":"OpenEBS is containerized storage for containers integrated tightly into K8S and other environments and based on distributed block storage and containerization of storage control.  OpenEBS derives intent from K8S and other YAML or JSON such as per container QoS SLAs, tiering and replica policies, and more.  OpenEBS is EBS API compliant as well.   ","fork":true,"url":"https://api.github.com/repos/gkGaneshR/openebs","forks_url":"https://api.github.com/repos/gkGaneshR/openebs/forks","keys_url":"https://api.github.com/repos/gkGaneshR/openebs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkGaneshR/openebs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkGaneshR/openebs/teams","hooks_url":"https://api.github.com/repos/gkGaneshR/openebs/hooks","issue_events_url":"https://api.github.com/repos/gkGaneshR/openebs/issues/events{/number}","events_url":"https://api.github.com/repos/gkGaneshR/openebs/events","assignees_url":"https://api.github.com/repos/gkGaneshR/openebs/assignees{/user}","branches_url":"https://api.github.com/repos/gkGaneshR/openebs/branches{/branch}","tags_url":"https://api.github.com/repos/gkGaneshR/openebs/tags","blobs_url":"https://api.github.com/repos/gkGaneshR/openebs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkGaneshR/openebs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkGaneshR/openebs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkGaneshR/openebs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkGaneshR/openebs/statuses/{sha}","languages_url":"https://api.github.com/repos/gkGaneshR/openebs/languages","stargazers_url":"https://api.github.com/repos/gkGaneshR/openebs/stargazers","contributors_url":"https://api.github.com/repos/gkGaneshR/openebs/contributors","subscribers_url":"https://api.github.com/repos/gkGaneshR/openebs/subscribers","subscription_url":"https://api.github.com/repos/gkGaneshR/openebs/subscription","commits_url":"https://api.github.com/repos/gkGaneshR/openebs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkGaneshR/openebs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkGaneshR/openebs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkGaneshR/openebs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkGaneshR/openebs/contents/{+path}","compare_url":"https://api.github.com/repos/gkGaneshR/openebs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkGaneshR/openebs/merges","archive_url":"https://api.github.com/repos/gkGaneshR/openebs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkGaneshR/openebs/downloads","issues_url":"https://api.github.com/repos/gkGaneshR/openebs/issues{/number}","pulls_url":"https://api.github.com/repos/gkGaneshR/openebs/pulls{/number}","milestones_url":"https://api.github.com/repos/gkGaneshR/openebs/milestones{/number}","notifications_url":"https://api.github.com/repos/gkGaneshR/openebs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkGaneshR/openebs/labels{/name}","releases_url":"https://api.github.com/repos/gkGaneshR/openebs/releases{/id}","deployments_url":"https://api.github.com/repos/gkGaneshR/openebs/deployments","created_at":"2017-06-18T15:39:14Z","updated_at":"2018-03-13T17:51:27Z","pushed_at":"2018-05-21T13:56:18Z","git_url":"git://github.com/gkGaneshR/openebs.git","ssh_url":"git@github.com:gkGaneshR/openebs.git","clone_url":"https://github.com/gkGaneshR/openebs.git","svn_url":"https://github.com/gkGaneshR/openebs","homepage":"http://openebs.readthedocs.io/en/latest/Overview.html","size":15529,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openebs:master","ref":"master","sha":"df2e87aeb4ed3ffc5724f6f3d63fa3353f4b3e0b","user":{"login":"openebs","id":20769039,"avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":64654523,"name":"openebs","full_name":"openebs/openebs","owner":{"login":"openebs","id":20769039,"avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openebs/openebs","description":"OpenEBS is containerized block storage written in Go for cloud native and other environments w/ per container (or pod) QoS SLAs, tiering and replica policies across AZs and environments, and predictable and scalable performance.  ","fork":false,"url":"https://api.github.com/repos/openebs/openebs","forks_url":"https://api.github.com/repos/openebs/openebs/forks","keys_url":"https://api.github.com/repos/openebs/openebs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/openebs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/openebs/teams","hooks_url":"https://api.github.com/repos/openebs/openebs/hooks","issue_events_url":"https://api.github.com/repos/openebs/openebs/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/openebs/events","assignees_url":"https://api.github.com/repos/openebs/openebs/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/openebs/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/openebs/tags","blobs_url":"https://api.github.com/repos/openebs/openebs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/openebs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/openebs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/openebs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/openebs/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/openebs/languages","stargazers_url":"https://api.github.com/repos/openebs/openebs/stargazers","contributors_url":"https://api.github.com/repos/openebs/openebs/contributors","subscribers_url":"https://api.github.com/repos/openebs/openebs/subscribers","subscription_url":"https://api.github.com/repos/openebs/openebs/subscription","commits_url":"https://api.github.com/repos/openebs/openebs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/openebs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/openebs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/openebs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/openebs/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/openebs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/openebs/merges","archive_url":"https://api.github.com/repos/openebs/openebs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/openebs/downloads","issues_url":"https://api.github.com/repos/openebs/openebs/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/openebs/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/openebs/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/openebs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/openebs/labels{/name}","releases_url":"https://api.github.com/repos/openebs/openebs/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/openebs/deployments","created_at":"2016-08-01T09:33:32Z","updated_at":"2018-05-21T23:41:26Z","pushed_at":"2018-05-22T06:27:23Z","git_url":"git://github.com/openebs/openebs.git","ssh_url":"git@github.com:openebs/openebs.git","clone_url":"https://github.com/openebs/openebs.git","svn_url":"https://github.com/openebs/openebs","homepage":"https://www.openebs.io","size":18833,"stargazers_count":5194,"watchers_count":5194,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":447,"mirror_url":null,"archived":false,"open_issues_count":465,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":447,"open_issues":465,"watchers":5194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/openebs/pulls/1540"},"html":{"href":"https://github.com/openebs/openebs/pull/1540"},"issue":{"href":"https://api.github.com/repos/openebs/openebs/issues/1540"},"comments":{"href":"https://api.github.com/repos/openebs/openebs/issues/1540/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/openebs/pulls/1540/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/openebs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/openebs/pulls/1540/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/openebs/statuses/a315d5f050adfd3d43fee9112a294f84201094af"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"avishnu"}}