{"action":"created","issue":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/27027","repository_url":"https://api.github.com/repos/twbs/bootstrap","labels_url":"https://api.github.com/repos/twbs/bootstrap/issues/27027/labels{/name}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/27027/comments","events_url":"https://api.github.com/repos/twbs/bootstrap/issues/27027/events","html_url":"https://github.com/twbs/bootstrap/pull/27027","id":348068306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTA2MDAy","number":27027,"title":"users/adamsiv/rtl-support","user":{"login":"DigitalKrony","id":1834700,"node_id":"MDQ6VXNlcjE4MzQ3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1834700?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalKrony","html_url":"https://github.com/DigitalKrony","followers_url":"https://api.github.com/users/DigitalKrony/followers","following_url":"https://api.github.com/users/DigitalKrony/following{/other_user}","gists_url":"https://api.github.com/users/DigitalKrony/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalKrony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalKrony/subscriptions","organizations_url":"https://api.github.com/users/DigitalKrony/orgs","repos_url":"https://api.github.com/users/DigitalKrony/repos","events_url":"https://api.github.com/users/DigitalKrony/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalKrony/received_events","type":"User","site_admin":false},"labels":[{"id":210556,"node_id":"MDU6TGFiZWwyMTA1NTY=","url":"https://api.github.com/repos/twbs/bootstrap/labels/css","name":"css","color":"563d7c","default":false},{"id":148230,"node_id":"MDU6TGFiZWwxNDgyMzA=","url":"https://api.github.com/repos/twbs/bootstrap/labels/feature","name":"feature","color":"4bb14b","default":false},{"id":250176882,"node_id":"MDU6TGFiZWwyNTAxNzY4ODI=","url":"https://api.github.com/repos/twbs/bootstrap/labels/v4","name":"v4","color":"563d7c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-06T20:19:53Z","updated_at":"2018-08-09T14:04:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/27027","html_url":"https://github.com/twbs/bootstrap/pull/27027","diff_url":"https://github.com/twbs/bootstrap/pull/27027.diff","patch_url":"https://github.com/twbs/bootstrap/pull/27027.patch"},"body":"On behalf of Microsoft, I'm submitting this pull-request.\r\n\r\nWe have taken Bootstrap 4.x on as a dependency for a project, however, we have requirements for our websites to work in an international arena as well as maintain perf goals and an easy dev story. To that end, the best case in order to align these things is to integrate internationalization directly into Bootstrap. You'll find the appropriate update within. \r\n\r\nThe chages in the files below simply add in the `dir` attribute to the HTML tag to allow ease of testing. While testing the RTL story wihtin the doc site, these must be set to `\"rtl\"`.\r\n- site > _layouts >\r\n    - default.html\r\n    - docs.html\r\n    - home.html\r\n    - redirect.html\r\n\r\nThe update to the SCSS is realativly simple. I've added three variables to the `_variables.scss`. \r\n- $dir:String = ltr (default) || rtl\r\n- $left:String = left (default) || right (is set based on $dir)\r\n- $right:String = right (default) || left (is set based on $dir)\r\n\r\nThese three variables work in conjunction with eachother. By `!default`  `$dir` is set to `ltr`. Following this varaible, there's `$left` and `$right`. These two variables are set via a function (`set-dir(left|right)` ) base on the value of `$dir` for ease of use. The `$dir` variable also sets a global `direction: $dir` style decloration to capture finer style requirements for things like inputs and sudo elements."},"comment":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/411769149","html_url":"https://github.com/twbs/bootstrap/pull/27027#issuecomment-411769149","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/27027","id":411769149,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTc2OTE0OQ==","user":{"login":"andresgalante","id":1832037,"node_id":"MDQ6VXNlcjE4MzIwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T14:04:17Z","updated_at":"2018-08-09T14:04:17Z","author_association":"MEMBER","body":"@DigitalKrony it'll be up to @mdo to decide if this goes in and when. The thing to consider is that if this is creating a breaking change, it'll have to land in v5."}}
{"actor":{"display_login":"andresgalante"}}