{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/184208295","pull_request_review_id":115357598,"id":184208295,"diff_hunk":"@@ -97,6 +109,14 @@ export class ConfigurePipelineTemplateModalController implements IController {\n   }\n \n   public buildConfig(): IPipelineTemplateConfig {\n+    let inheritConfig = [];\n+    if (this.state.inheritTemplateParameters) {\n+      inheritConfig.push('parameters');\n+    } else if (this.state.inheritTemplateExpectedArtifacts) {","path":"app/scripts/modules/core/src/pipeline/config/templates/configurePipelineTemplateModal.controller.ts","position":null,"original_position":35,"commit_id":"fe20d6d538ef49e96e372dc661b6632901c72342","original_commit_id":"d1136c817c8d23e144b81e718b5bed4d9c30f656","user":{"login":"benjaminws","id":121679,"avatar_url":"https://avatars2.githubusercontent.com/u/121679?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminws","html_url":"https://github.com/benjaminws","followers_url":"https://api.github.com/users/benjaminws/followers","following_url":"https://api.github.com/users/benjaminws/following{/other_user}","gists_url":"https://api.github.com/users/benjaminws/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminws/subscriptions","organizations_url":"https://api.github.com/users/benjaminws/orgs","repos_url":"https://api.github.com/users/benjaminws/repos","events_url":"https://api.github.com/users/benjaminws/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminws/received_events","type":"User","site_admin":false},"body":"Wasn't a fan of the conditional blocks anyway, cleaned it up","created_at":"2018-04-25T21:15:57Z","updated_at":"2018-04-25T21:15:57Z","html_url":"https://github.com/spinnaker/deck/pull/5214#discussion_r184208295","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/5214","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/184208295"},"html":{"href":"https://github.com/spinnaker/deck/pull/5214#discussion_r184208295"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5214"}},"in_reply_to_id":184196729},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/5214","id":183102173,"html_url":"https://github.com/spinnaker/deck/pull/5214","diff_url":"https://github.com/spinnaker/deck/pull/5214.diff","patch_url":"https://github.com/spinnaker/deck/pull/5214.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/5214","number":5214,"state":"open","locked":false,"title":"feat(pipeline_templates) Allow Pipelines to Inherit Pipeline Template Configuration","user":{"login":"benjaminws","id":121679,"avatar_url":"https://avatars2.githubusercontent.com/u/121679?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminws","html_url":"https://github.com/benjaminws","followers_url":"https://api.github.com/users/benjaminws/followers","following_url":"https://api.github.com/users/benjaminws/following{/other_user}","gists_url":"https://api.github.com/users/benjaminws/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminws/subscriptions","organizations_url":"https://api.github.com/users/benjaminws/orgs","repos_url":"https://api.github.com/users/benjaminws/repos","events_url":"https://api.github.com/users/benjaminws/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminws/received_events","type":"User","site_admin":false},"body":"Currently, if you specify a pipeline template with parameters, triggers, or expected artifacts and then try to create a template with it in deck, the configuration is not inherited and has to be recreated by hand in the new pipeline. This behavior works as expected with roer / cli / API.\r\n\r\n![template-inherit](https://user-images.githubusercontent.com/121679/39060946-c39b97c2-4490-11e8-9930-94a4e87b8fbd.gif)\r\n","created_at":"2018-04-20T15:49:26Z","updated_at":"2018-04-25T21:15:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dea5d1a18ceab2dd9c0d635c1c20efe77c8bb11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/5214/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/5214/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/5214/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/fe20d6d538ef49e96e372dc661b6632901c72342","head":{"label":"DataDog:ben/inherit-from-template","ref":"ben/inherit-from-template","sha":"fe20d6d538ef49e96e372dc661b6632901c72342","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":114792637,"name":"deck","full_name":"DataDog/deck","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/deck","description":"Management UI for Spinnaker | DataDog Fork","fork":true,"url":"https://api.github.com/repos/DataDog/deck","forks_url":"https://api.github.com/repos/DataDog/deck/forks","keys_url":"https://api.github.com/repos/DataDog/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/deck/teams","hooks_url":"https://api.github.com/repos/DataDog/deck/hooks","issue_events_url":"https://api.github.com/repos/DataDog/deck/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/deck/events","assignees_url":"https://api.github.com/repos/DataDog/deck/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/deck/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/deck/tags","blobs_url":"https://api.github.com/repos/DataDog/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/deck/languages","stargazers_url":"https://api.github.com/repos/DataDog/deck/stargazers","contributors_url":"https://api.github.com/repos/DataDog/deck/contributors","subscribers_url":"https://api.github.com/repos/DataDog/deck/subscribers","subscription_url":"https://api.github.com/repos/DataDog/deck/subscription","commits_url":"https://api.github.com/repos/DataDog/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/deck/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/deck/merges","archive_url":"https://api.github.com/repos/DataDog/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/deck/downloads","issues_url":"https://api.github.com/repos/DataDog/deck/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/deck/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/deck/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/deck/deployments","created_at":"2017-12-19T17:24:31Z","updated_at":"2018-04-19T23:22:25Z","pushed_at":"2018-04-25T21:09:09Z","git_url":"git://github.com/DataDog/deck.git","ssh_url":"git@github.com:DataDog/deck.git","clone_url":"https://github.com/DataDog/deck.git","svn_url":"https://github.com/DataDog/deck","homepage":"","size":31279,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"ba49271cd8f46c5d7f6052ffd23179c8fecfa548","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2018-04-25T20:47:38Z","pushed_at":"2018-04-25T21:09:11Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":31251,"stargazers_count":135,"watchers_count":135,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":289,"open_issues":5,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5214"},"html":{"href":"https://github.com/spinnaker/deck/pull/5214"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/5214"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/5214/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5214/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5214/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/fe20d6d538ef49e96e372dc661b6632901c72342"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjaminws"}}