{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments/239355677","pull_request_review_id":182117149,"id":239355677,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTM1NTY3Nw==","diff_hunk":"@@ -139,6 +139,22 @@ func TestPDScalerScaleOut(t *testing.T) {\n \t\t\terr:              true,\n \t\t\tchanged:          false,\n \t\t},\n+\t\t{\n+\t\t\tname: \"failover now\",\n+\t\t\tupdate: func(tc *v1alpha1.TidbCluster) {\n+\t\t\t\tnormalPDMember(tc)\n+\t\t\t\ttc.Status.PD.FailureMembers = map[string]v1alpha1.PDFailureMember{\n+\t\t\t\t\t\"pd-0\": {PodName: \"pd-0\"},\n+\t\t\t\t}","path":"pkg/manager/member/pd_scaler_test.go","position":10,"original_position":10,"commit_id":"79de958f57895300344a062e55a1f06090a3d930","original_commit_id":"79de958f57895300344a062e55a1f06090a3d930","user":{"login":"xiaojingchen","id":5999258,"node_id":"MDQ6VXNlcjU5OTkyNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5999258?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaojingchen","html_url":"https://github.com/xiaojingchen","followers_url":"https://api.github.com/users/xiaojingchen/followers","following_url":"https://api.github.com/users/xiaojingchen/following{/other_user}","gists_url":"https://api.github.com/users/xiaojingchen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaojingchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaojingchen/subscriptions","organizations_url":"https://api.github.com/users/xiaojingchen/orgs","repos_url":"https://api.github.com/users/xiaojingchen/repos","events_url":"https://api.github.com/users/xiaojingchen/events{/privacy}","received_events_url":"https://api.github.com/users/xiaojingchen/received_events","type":"User","site_admin":false},"body":"add ` tc.Status.PD.Members[\"pd-0\"].Health=false`。","created_at":"2018-12-06T07:58:41Z","updated_at":"2018-12-06T07:58:41Z","html_url":"https://github.com/pingcap/tidb-operator/pull/217#discussion_r239355677","pull_request_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments/239355677"},"html":{"href":"https://github.com/pingcap/tidb-operator/pull/217#discussion_r239355677"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217","id":236423569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDIzNTY5","html_url":"https://github.com/pingcap/tidb-operator/pull/217","diff_url":"https://github.com/pingcap/tidb-operator/pull/217.diff","patch_url":"https://github.com/pingcap/tidb-operator/pull/217.patch","issue_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/217","number":217,"state":"open","locked":false,"title":"fix pd-failover: scale out directly when failover occurs","user":{"login":"weekface","id":9758,"node_id":"MDQ6VXNlcjk3NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9758?v=4","gravatar_id":"","url":"https://api.github.com/users/weekface","html_url":"https://github.com/weekface","followers_url":"https://api.github.com/users/weekface/followers","following_url":"https://api.github.com/users/weekface/following{/other_user}","gists_url":"https://api.github.com/users/weekface/gists{/gist_id}","starred_url":"https://api.github.com/users/weekface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weekface/subscriptions","organizations_url":"https://api.github.com/users/weekface/orgs","repos_url":"https://api.github.com/users/weekface/repos","events_url":"https://api.github.com/users/weekface/events{/privacy}","received_events_url":"https://api.github.com/users/weekface/received_events","type":"User","site_admin":false},"body":"@tennix @xiaojingchen PTAL","created_at":"2018-12-06T06:40:47Z","updated_at":"2018-12-06T07:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbb5e610bd45c24f3c566b53992ba9c128c7c8bf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tennix","id":7932127,"node_id":"MDQ6VXNlcjc5MzIxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7932127?v=4","gravatar_id":"","url":"https://api.github.com/users/tennix","html_url":"https://github.com/tennix","followers_url":"https://api.github.com/users/tennix/followers","following_url":"https://api.github.com/users/tennix/following{/other_user}","gists_url":"https://api.github.com/users/tennix/gists{/gist_id}","starred_url":"https://api.github.com/users/tennix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tennix/subscriptions","organizations_url":"https://api.github.com/users/tennix/orgs","repos_url":"https://api.github.com/users/tennix/repos","events_url":"https://api.github.com/users/tennix/events{/privacy}","received_events_url":"https://api.github.com/users/tennix/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/217/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb-operator/statuses/79de958f57895300344a062e55a1f06090a3d930","head":{"label":"weekface:fix-pd-failover","ref":"fix-pd-failover","sha":"79de958f57895300344a062e55a1f06090a3d930","user":{"login":"weekface","id":9758,"node_id":"MDQ6VXNlcjk3NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9758?v=4","gravatar_id":"","url":"https://api.github.com/users/weekface","html_url":"https://github.com/weekface","followers_url":"https://api.github.com/users/weekface/followers","following_url":"https://api.github.com/users/weekface/following{/other_user}","gists_url":"https://api.github.com/users/weekface/gists{/gist_id}","starred_url":"https://api.github.com/users/weekface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weekface/subscriptions","organizations_url":"https://api.github.com/users/weekface/orgs","repos_url":"https://api.github.com/users/weekface/repos","events_url":"https://api.github.com/users/weekface/events{/privacy}","received_events_url":"https://api.github.com/users/weekface/received_events","type":"User","site_admin":false},"repo":{"id":144795399,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3OTUzOTk=","name":"tidb-operator","full_name":"weekface/tidb-operator","private":false,"owner":{"login":"weekface","id":9758,"node_id":"MDQ6VXNlcjk3NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9758?v=4","gravatar_id":"","url":"https://api.github.com/users/weekface","html_url":"https://github.com/weekface","followers_url":"https://api.github.com/users/weekface/followers","following_url":"https://api.github.com/users/weekface/following{/other_user}","gists_url":"https://api.github.com/users/weekface/gists{/gist_id}","starred_url":"https://api.github.com/users/weekface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weekface/subscriptions","organizations_url":"https://api.github.com/users/weekface/orgs","repos_url":"https://api.github.com/users/weekface/repos","events_url":"https://api.github.com/users/weekface/events{/privacy}","received_events_url":"https://api.github.com/users/weekface/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weekface/tidb-operator","description":"TiDB operator creates and manages TiDB clusters running in Kubernetes","fork":true,"url":"https://api.github.com/repos/weekface/tidb-operator","forks_url":"https://api.github.com/repos/weekface/tidb-operator/forks","keys_url":"https://api.github.com/repos/weekface/tidb-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weekface/tidb-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weekface/tidb-operator/teams","hooks_url":"https://api.github.com/repos/weekface/tidb-operator/hooks","issue_events_url":"https://api.github.com/repos/weekface/tidb-operator/issues/events{/number}","events_url":"https://api.github.com/repos/weekface/tidb-operator/events","assignees_url":"https://api.github.com/repos/weekface/tidb-operator/assignees{/user}","branches_url":"https://api.github.com/repos/weekface/tidb-operator/branches{/branch}","tags_url":"https://api.github.com/repos/weekface/tidb-operator/tags","blobs_url":"https://api.github.com/repos/weekface/tidb-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weekface/tidb-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weekface/tidb-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/weekface/tidb-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weekface/tidb-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/weekface/tidb-operator/languages","stargazers_url":"https://api.github.com/repos/weekface/tidb-operator/stargazers","contributors_url":"https://api.github.com/repos/weekface/tidb-operator/contributors","subscribers_url":"https://api.github.com/repos/weekface/tidb-operator/subscribers","subscription_url":"https://api.github.com/repos/weekface/tidb-operator/subscription","commits_url":"https://api.github.com/repos/weekface/tidb-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/weekface/tidb-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/weekface/tidb-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/weekface/tidb-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/weekface/tidb-operator/contents/{+path}","compare_url":"https://api.github.com/repos/weekface/tidb-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weekface/tidb-operator/merges","archive_url":"https://api.github.com/repos/weekface/tidb-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weekface/tidb-operator/downloads","issues_url":"https://api.github.com/repos/weekface/tidb-operator/issues{/number}","pulls_url":"https://api.github.com/repos/weekface/tidb-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/weekface/tidb-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/weekface/tidb-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weekface/tidb-operator/labels{/name}","releases_url":"https://api.github.com/repos/weekface/tidb-operator/releases{/id}","deployments_url":"https://api.github.com/repos/weekface/tidb-operator/deployments","created_at":"2018-08-15T02:25:54Z","updated_at":"2018-11-28T07:55:20Z","pushed_at":"2018-12-06T06:40:05Z","git_url":"git://github.com/weekface/tidb-operator.git","ssh_url":"git@github.com:weekface/tidb-operator.git","clone_url":"https://github.com/weekface/tidb-operator.git","svn_url":"https://github.com/weekface/tidb-operator","homepage":"","size":49047,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"ebcb306ed5df36f235c03aded7ebe3ced5854d0d","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":143867478,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4Njc0Nzg=","name":"tidb-operator","full_name":"pingcap/tidb-operator","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb-operator","description":"TiDB operator creates and manages TiDB clusters running in Kubernetes","fork":false,"url":"https://api.github.com/repos/pingcap/tidb-operator","forks_url":"https://api.github.com/repos/pingcap/tidb-operator/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-operator/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-operator/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-operator/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-operator/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-operator/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-operator/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-operator/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-operator/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-operator/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-operator/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-operator/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-operator/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-operator/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-operator/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-operator/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-operator/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-operator/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-operator/deployments","created_at":"2018-08-07T12:04:33Z","updated_at":"2018-12-04T13:22:31Z","pushed_at":"2018-12-06T06:55:52Z","git_url":"git://github.com/pingcap/tidb-operator.git","ssh_url":"git@github.com:pingcap/tidb-operator.git","clone_url":"https://github.com/pingcap/tidb-operator.git","svn_url":"https://github.com/pingcap/tidb-operator","homepage":"","size":49012,"stargazers_count":196,"watchers_count":196,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":47,"open_issues":29,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217"},"html":{"href":"https://github.com/pingcap/tidb-operator/pull/217"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb-operator/issues/217"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb-operator/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb-operator/statuses/79de958f57895300344a062e55a1f06090a3d930"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiaojingchen"}}