{"action":"created","issue":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2705","repository_url":"https://api.github.com/repos/varnishcache/varnish-cache","labels_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2705/labels{/name}","comments_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2705/comments","events_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2705/events","html_url":"https://github.com/varnishcache/varnish-cache/pull/2705","id":330976619,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODMxMTEw","number":2705,"title":"A handfull of steps towards fixing #1799","user":{"login":"hermunn","id":17638537,"node_id":"MDQ6VXNlcjE3NjM4NTM3","avatar_url":"https://avatars2.githubusercontent.com/u/17638537?v=4","gravatar_id":"","url":"https://api.github.com/users/hermunn","html_url":"https://github.com/hermunn","followers_url":"https://api.github.com/users/hermunn/followers","following_url":"https://api.github.com/users/hermunn/following{/other_user}","gists_url":"https://api.github.com/users/hermunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hermunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hermunn/subscriptions","organizations_url":"https://api.github.com/users/hermunn/orgs","repos_url":"https://api.github.com/users/hermunn/repos","events_url":"https://api.github.com/users/hermunn/events{/privacy}","received_events_url":"https://api.github.com/users/hermunn/received_events","type":"User","site_admin":false},"labels":[{"id":404480667,"node_id":"MDU6TGFiZWw0MDQ0ODA2Njc=","url":"https://api.github.com/repos/varnishcache/varnish-cache/labels/a=bugwash","name":"a=bugwash","color":"ff8800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-10T15:12:14Z","updated_at":"2018-06-29T12:53:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/pulls/2705","html_url":"https://github.com/varnishcache/varnish-cache/pull/2705","diff_url":"https://github.com/varnishcache/varnish-cache/pull/2705.diff","patch_url":"https://github.com/varnishcache/varnish-cache/pull/2705.patch"},"body":"These five commits are hopefully on the right path to finally closing #1799, but we are still not there.\r\n\r\nOnly one, the last, of these five commits is not eligible for back porting. This commit changes VCL/the final state machine, and can conceivably break some users' VCL logic. Actually, this can be discussed, as the only change is that we go to miss with a 304 candidate for \"keep\" objects, while other cases stay the same.\r\n\r\nNot included is the patch where `return (miss)` in `sub vcl_hit` gets disallowed."},"comment":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/comments/401345293","html_url":"https://github.com/varnishcache/varnish-cache/pull/2705#issuecomment-401345293","issue_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2705","id":401345293,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTM0NTI5Mw==","user":{"login":"hermunn","id":17638537,"node_id":"MDQ6VXNlcjE3NjM4NTM3","avatar_url":"https://avatars2.githubusercontent.com/u/17638537?v=4","gravatar_id":"","url":"https://api.github.com/users/hermunn","html_url":"https://github.com/hermunn","followers_url":"https://api.github.com/users/hermunn/followers","following_url":"https://api.github.com/users/hermunn/following{/other_user}","gists_url":"https://api.github.com/users/hermunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hermunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hermunn/subscriptions","organizations_url":"https://api.github.com/users/hermunn/orgs","repos_url":"https://api.github.com/users/hermunn/repos","events_url":"https://api.github.com/users/hermunn/events{/privacy}","received_events_url":"https://api.github.com/users/hermunn/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T12:53:18Z","updated_at":"2018-06-29T12:53:18Z","author_association":"CONTRIBUTOR","body":"> I wonder if the req_fsm side of it could be made more readable if we gave HSH_Lookup specific return values for HSH_HITMISS / HSH_HITPASS\r\n\r\nI agree with @daghf, but I think should be merged with @nigoroll's patch on top. I will fix the docs as proposed, amend, rebase and force push with @nigoroll's rewrite patch on top. When everything looks good I will add a comment here."}}
{"actor":{"display_login":"hermunn"}}