{"action":"created","issue":{"url":"https://api.github.com/repos/cilium/cilium/issues/6318","repository_url":"https://api.github.com/repos/cilium/cilium","labels_url":"https://api.github.com/repos/cilium/cilium/issues/6318/labels{/name}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/6318/comments","events_url":"https://api.github.com/repos/cilium/cilium/issues/6318/events","html_url":"https://github.com/cilium/cilium/pull/6318","id":385512339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDY3NjU5","number":6318,"title":"Fix issue where closed TCP connections would remain in connection tracking table much longer than intended","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"labels":[{"id":721252768,"node_id":"MDU6TGFiZWw3MjEyNTI3Njg=","url":"https://api.github.com/repos/cilium/cilium/labels/area/datapath","name":"area/datapath","color":"bfdadc","default":false},{"id":1007718548,"node_id":"MDU6TGFiZWwxMDA3NzE4NTQ4","url":"https://api.github.com/repos/cilium/cilium/labels/needs-backport/1.2","name":"needs-backport/1.2","color":"4f3daa","default":false},{"id":1090496685,"node_id":"MDU6TGFiZWwxMDkwNDk2Njg1","url":"https://api.github.com/repos/cilium/cilium/labels/needs-backport/1.3","name":"needs-backport/1.3","color":"d4c5f9","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":732924468,"node_id":"MDU6TGFiZWw3MzI5MjQ0Njg=","url":"https://api.github.com/repos/cilium/cilium/labels/release-note/bug","name":"release-note/bug","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/20","html_url":"https://github.com/cilium/cilium/milestone/20","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/20/labels","id":3736769,"node_id":"MDk6TWlsZXN0b25lMzczNjc2OQ==","number":20,"title":"1.4-bugfix","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":41,"state":"open","created_at":"2018-10-14T10:00:35Z","updated_at":"2018-11-29T00:14:21Z","due_on":"2018-12-03T08:00:00Z","closed_at":null},"comments":3,"created_at":"2018-11-29T00:14:21Z","updated_at":"2018-11-29T00:31:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/6318","html_url":"https://github.com/cilium/cilium/pull/6318","diff_url":"https://github.com/cilium/cilium/pull/6318.diff","patch_url":"https://github.com/cilium/cilium/pull/6318.patch"},"body":"Previously, access into tcp flags was governed using a bitfield declared\r\nbased on the endianness of the host CPU, even though the packet data is\r\nalways in network byte-order. This would mean that any direct access of\r\nflags would access the wrong bits in the packet, and would cause\r\nconntrack entries for closed TCP connections to expire as long as 12\r\nhours after a connection was closed.\r\n\r\nFix this issue by redefining the tcp flags struct to store in a 32-bit\r\nstructure, then use the Linux `TCP_FLAG_*` defines to check / store the\r\nappropriate TCP flag bits.\r\n\r\nFixes: #6280\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/6318)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cilium/cilium/issues/comments/442659406","html_url":"https://github.com/cilium/cilium/pull/6318#issuecomment-442659406","issue_url":"https://api.github.com/repos/cilium/cilium/issues/6318","id":442659406,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjY1OTQwNg==","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T00:31:40Z","updated_at":"2018-11-29T00:31:40Z","author_association":"CONTRIBUTOR","body":"test-me-please"}}
{"actor":{"display_login":"joestringer"}}