{"action":"created","comment":{"url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/comments/236047438","pull_request_review_id":178055821,"id":236047438,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA0NzQzOA==","diff_hunk":"@@ -0,0 +1,28 @@\n+package com.danit.dto.service;\n+\n+import lombok.Data;\n+import lombok.ToString;\n+\n+import java.util.Date;\n+\n+@ToString\n+@Data\n+public class ClientListRequestDto {\n+\n+  public String search;\n+\n+  public String firstName;\n+\n+  public String lastName;\n+\n+  public String gender;","path":"src/main/java/com/danit/dto/service/ClientListRequestDto.java","position":18,"original_position":18,"commit_id":"e5f9ce7e4fc851487b5c6bcdb2e7537f4b4c9192","original_commit_id":"e5f9ce7e4fc851487b5c6bcdb2e7537f4b4c9192","user":{"login":"SonarCloudBot","id":44142700,"node_id":"MDQ6VXNlcjQ0MTQyNzAw","avatar_url":"https://avatars0.githubusercontent.com/u/44142700?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarCloudBot","html_url":"https://github.com/SonarCloudBot","followers_url":"https://api.github.com/users/SonarCloudBot/followers","following_url":"https://api.github.com/users/SonarCloudBot/following{/other_user}","gists_url":"https://api.github.com/users/SonarCloudBot/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarCloudBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarCloudBot/subscriptions","organizations_url":"https://api.github.com/users/SonarCloudBot/orgs","repos_url":"https://api.github.com/users/SonarCloudBot/repos","events_url":"https://api.github.com/users/SonarCloudBot/events{/privacy}","received_events_url":"https://api.github.com/users/SonarCloudBot/received_events","type":"User","site_admin":false},"body":"![Vulnerability](https://sonarsource.github.io/sonar-github/vulnerability.png 'Vulnerability') Vulnerability: Make gender a static final constant or non-public and provide accessors if needed. ([squid:ClassVariableVisibilityCheck](https://sonarcloud.io/organizations/final-project-group/rules#rule_key=squid%3AClassVariableVisibilityCheck))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=final-project-key&pullRequest=98&issues=AWdGJvkTEEvrFDMBCdKl&open=AWdGJvkTEEvrFDMBCdKl)\n\n[ISSUE_KEY]: AWdGJvkTEEvrFDMBCdKl","created_at":"2018-11-24T16:42:33Z","updated_at":"2018-11-24T16:42:34Z","html_url":"https://github.com/Thealoner/danit-final-project/pull/98#discussion_r236047438","pull_request_url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/comments/236047438"},"html":{"href":"https://github.com/Thealoner/danit-final-project/pull/98#discussion_r236047438"},"pull_request":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98","id":233322634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzIyNjM0","html_url":"https://github.com/Thealoner/danit-final-project/pull/98","diff_url":"https://github.com/Thealoner/danit-final-project/pull/98.diff","patch_url":"https://github.com/Thealoner/danit-final-project/pull/98.patch","issue_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues/98","number":98,"state":"open","locked":false,"title":"Paginating filtering sorting impl","user":{"login":"enhancer13","id":44034271,"node_id":"MDQ6VXNlcjQ0MDM0Mjcx","avatar_url":"https://avatars3.githubusercontent.com/u/44034271?v=4","gravatar_id":"","url":"https://api.github.com/users/enhancer13","html_url":"https://github.com/enhancer13","followers_url":"https://api.github.com/users/enhancer13/followers","following_url":"https://api.github.com/users/enhancer13/following{/other_user}","gists_url":"https://api.github.com/users/enhancer13/gists{/gist_id}","starred_url":"https://api.github.com/users/enhancer13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enhancer13/subscriptions","organizations_url":"https://api.github.com/users/enhancer13/orgs","repos_url":"https://api.github.com/users/enhancer13/repos","events_url":"https://api.github.com/users/enhancer13/events{/privacy}","received_events_url":"https://api.github.com/users/enhancer13/received_events","type":"User","site_admin":false},"body":"#added new pagination structure\r\n#added filtering by fields\r\n#added global filtering\r\n#changed CustomDateSerializer","created_at":"2018-11-24T14:29:08Z","updated_at":"2018-11-24T16:42:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37dfc0ff4c169124c184167d925f4cc6f520cc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98/commits","review_comments_url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98/comments","review_comment_url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues/98/comments","statuses_url":"https://api.github.com/repos/Thealoner/danit-final-project/statuses/e5f9ce7e4fc851487b5c6bcdb2e7537f4b4c9192","head":{"label":"Thealoner:paginating-filtering-impl","ref":"paginating-filtering-impl","sha":"e5f9ce7e4fc851487b5c6bcdb2e7537f4b4c9192","user":{"login":"Thealoner","id":10584616,"node_id":"MDQ6VXNlcjEwNTg0NjE2","avatar_url":"https://avatars2.githubusercontent.com/u/10584616?v=4","gravatar_id":"","url":"https://api.github.com/users/Thealoner","html_url":"https://github.com/Thealoner","followers_url":"https://api.github.com/users/Thealoner/followers","following_url":"https://api.github.com/users/Thealoner/following{/other_user}","gists_url":"https://api.github.com/users/Thealoner/gists{/gist_id}","starred_url":"https://api.github.com/users/Thealoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thealoner/subscriptions","organizations_url":"https://api.github.com/users/Thealoner/orgs","repos_url":"https://api.github.com/users/Thealoner/repos","events_url":"https://api.github.com/users/Thealoner/events{/privacy}","received_events_url":"https://api.github.com/users/Thealoner/received_events","type":"User","site_admin":false},"repo":{"id":152455121,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NTUxMjE=","name":"danit-final-project","full_name":"Thealoner/danit-final-project","private":false,"owner":{"login":"Thealoner","id":10584616,"node_id":"MDQ6VXNlcjEwNTg0NjE2","avatar_url":"https://avatars2.githubusercontent.com/u/10584616?v=4","gravatar_id":"","url":"https://api.github.com/users/Thealoner","html_url":"https://github.com/Thealoner","followers_url":"https://api.github.com/users/Thealoner/followers","following_url":"https://api.github.com/users/Thealoner/following{/other_user}","gists_url":"https://api.github.com/users/Thealoner/gists{/gist_id}","starred_url":"https://api.github.com/users/Thealoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thealoner/subscriptions","organizations_url":"https://api.github.com/users/Thealoner/orgs","repos_url":"https://api.github.com/users/Thealoner/repos","events_url":"https://api.github.com/users/Thealoner/events{/privacy}","received_events_url":"https://api.github.com/users/Thealoner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Thealoner/danit-final-project","description":null,"fork":false,"url":"https://api.github.com/repos/Thealoner/danit-final-project","forks_url":"https://api.github.com/repos/Thealoner/danit-final-project/forks","keys_url":"https://api.github.com/repos/Thealoner/danit-final-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thealoner/danit-final-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thealoner/danit-final-project/teams","hooks_url":"https://api.github.com/repos/Thealoner/danit-final-project/hooks","issue_events_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues/events{/number}","events_url":"https://api.github.com/repos/Thealoner/danit-final-project/events","assignees_url":"https://api.github.com/repos/Thealoner/danit-final-project/assignees{/user}","branches_url":"https://api.github.com/repos/Thealoner/danit-final-project/branches{/branch}","tags_url":"https://api.github.com/repos/Thealoner/danit-final-project/tags","blobs_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thealoner/danit-final-project/statuses/{sha}","languages_url":"https://api.github.com/repos/Thealoner/danit-final-project/languages","stargazers_url":"https://api.github.com/repos/Thealoner/danit-final-project/stargazers","contributors_url":"https://api.github.com/repos/Thealoner/danit-final-project/contributors","subscribers_url":"https://api.github.com/repos/Thealoner/danit-final-project/subscribers","subscription_url":"https://api.github.com/repos/Thealoner/danit-final-project/subscription","commits_url":"https://api.github.com/repos/Thealoner/danit-final-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thealoner/danit-final-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thealoner/danit-final-project/contents/{+path}","compare_url":"https://api.github.com/repos/Thealoner/danit-final-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thealoner/danit-final-project/merges","archive_url":"https://api.github.com/repos/Thealoner/danit-final-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thealoner/danit-final-project/downloads","issues_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues{/number}","pulls_url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls{/number}","milestones_url":"https://api.github.com/repos/Thealoner/danit-final-project/milestones{/number}","notifications_url":"https://api.github.com/repos/Thealoner/danit-final-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thealoner/danit-final-project/labels{/name}","releases_url":"https://api.github.com/repos/Thealoner/danit-final-project/releases{/id}","deployments_url":"https://api.github.com/repos/Thealoner/danit-final-project/deployments","created_at":"2018-10-10T16:29:37Z","updated_at":"2018-11-24T15:17:00Z","pushed_at":"2018-11-24T16:37:06Z","git_url":"git://github.com/Thealoner/danit-final-project.git","ssh_url":"git@github.com:Thealoner/danit-final-project.git","clone_url":"https://github.com/Thealoner/danit-final-project.git","svn_url":"https://github.com/Thealoner/danit-final-project","homepage":null,"size":944,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"Thealoner:master","ref":"master","sha":"17ed681aaeff1668fe2551e885292b8a6984332a","user":{"login":"Thealoner","id":10584616,"node_id":"MDQ6VXNlcjEwNTg0NjE2","avatar_url":"https://avatars2.githubusercontent.com/u/10584616?v=4","gravatar_id":"","url":"https://api.github.com/users/Thealoner","html_url":"https://github.com/Thealoner","followers_url":"https://api.github.com/users/Thealoner/followers","following_url":"https://api.github.com/users/Thealoner/following{/other_user}","gists_url":"https://api.github.com/users/Thealoner/gists{/gist_id}","starred_url":"https://api.github.com/users/Thealoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thealoner/subscriptions","organizations_url":"https://api.github.com/users/Thealoner/orgs","repos_url":"https://api.github.com/users/Thealoner/repos","events_url":"https://api.github.com/users/Thealoner/events{/privacy}","received_events_url":"https://api.github.com/users/Thealoner/received_events","type":"User","site_admin":false},"repo":{"id":152455121,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NTUxMjE=","name":"danit-final-project","full_name":"Thealoner/danit-final-project","private":false,"owner":{"login":"Thealoner","id":10584616,"node_id":"MDQ6VXNlcjEwNTg0NjE2","avatar_url":"https://avatars2.githubusercontent.com/u/10584616?v=4","gravatar_id":"","url":"https://api.github.com/users/Thealoner","html_url":"https://github.com/Thealoner","followers_url":"https://api.github.com/users/Thealoner/followers","following_url":"https://api.github.com/users/Thealoner/following{/other_user}","gists_url":"https://api.github.com/users/Thealoner/gists{/gist_id}","starred_url":"https://api.github.com/users/Thealoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thealoner/subscriptions","organizations_url":"https://api.github.com/users/Thealoner/orgs","repos_url":"https://api.github.com/users/Thealoner/repos","events_url":"https://api.github.com/users/Thealoner/events{/privacy}","received_events_url":"https://api.github.com/users/Thealoner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Thealoner/danit-final-project","description":null,"fork":false,"url":"https://api.github.com/repos/Thealoner/danit-final-project","forks_url":"https://api.github.com/repos/Thealoner/danit-final-project/forks","keys_url":"https://api.github.com/repos/Thealoner/danit-final-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thealoner/danit-final-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thealoner/danit-final-project/teams","hooks_url":"https://api.github.com/repos/Thealoner/danit-final-project/hooks","issue_events_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues/events{/number}","events_url":"https://api.github.com/repos/Thealoner/danit-final-project/events","assignees_url":"https://api.github.com/repos/Thealoner/danit-final-project/assignees{/user}","branches_url":"https://api.github.com/repos/Thealoner/danit-final-project/branches{/branch}","tags_url":"https://api.github.com/repos/Thealoner/danit-final-project/tags","blobs_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thealoner/danit-final-project/statuses/{sha}","languages_url":"https://api.github.com/repos/Thealoner/danit-final-project/languages","stargazers_url":"https://api.github.com/repos/Thealoner/danit-final-project/stargazers","contributors_url":"https://api.github.com/repos/Thealoner/danit-final-project/contributors","subscribers_url":"https://api.github.com/repos/Thealoner/danit-final-project/subscribers","subscription_url":"https://api.github.com/repos/Thealoner/danit-final-project/subscription","commits_url":"https://api.github.com/repos/Thealoner/danit-final-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thealoner/danit-final-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thealoner/danit-final-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thealoner/danit-final-project/contents/{+path}","compare_url":"https://api.github.com/repos/Thealoner/danit-final-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thealoner/danit-final-project/merges","archive_url":"https://api.github.com/repos/Thealoner/danit-final-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thealoner/danit-final-project/downloads","issues_url":"https://api.github.com/repos/Thealoner/danit-final-project/issues{/number}","pulls_url":"https://api.github.com/repos/Thealoner/danit-final-project/pulls{/number}","milestones_url":"https://api.github.com/repos/Thealoner/danit-final-project/milestones{/number}","notifications_url":"https://api.github.com/repos/Thealoner/danit-final-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thealoner/danit-final-project/labels{/name}","releases_url":"https://api.github.com/repos/Thealoner/danit-final-project/releases{/id}","deployments_url":"https://api.github.com/repos/Thealoner/danit-final-project/deployments","created_at":"2018-10-10T16:29:37Z","updated_at":"2018-11-24T15:17:00Z","pushed_at":"2018-11-24T16:37:06Z","git_url":"git://github.com/Thealoner/danit-final-project.git","ssh_url":"git@github.com:Thealoner/danit-final-project.git","clone_url":"https://github.com/Thealoner/danit-final-project.git","svn_url":"https://github.com/Thealoner/danit-final-project","homepage":null,"size":944,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98"},"html":{"href":"https://github.com/Thealoner/danit-final-project/pull/98"},"issue":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/issues/98"},"comments":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/Thealoner/danit-final-project/statuses/e5f9ce7e4fc851487b5c6bcdb2e7537f4b4c9192"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"SonarCloudBot"}}