{"action":"opened","number":22426,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22426","id":215167034,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTY3MDM0","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22426","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/22426.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/22426.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22426","number":22426,"state":"open","locked":false,"title":"Fixed MotionMaster::MoveChase default parameters","user":{"login":"kelno","id":3866946,"node_id":"MDQ6VXNlcjM4NjY5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3866946?v=4","gravatar_id":"","url":"https://api.github.com/users/kelno","html_url":"https://github.com/kelno","followers_url":"https://api.github.com/users/kelno/followers","following_url":"https://api.github.com/users/kelno/following{/other_user}","gists_url":"https://api.github.com/users/kelno/gists{/gist_id}","starred_url":"https://api.github.com/users/kelno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelno/subscriptions","organizations_url":"https://api.github.com/users/kelno/orgs","repos_url":"https://api.github.com/users/kelno/repos","events_url":"https://api.github.com/users/kelno/events{/privacy}","received_events_url":"https://api.github.com/users/kelno/received_events","type":"User","site_admin":false},"body":"**Changes proposed:**\r\n\r\nWhen calling MotionMaster::MoveChase with a distance, the angle was intended to be optional but actually wasn't.\r\nIn the definition:\r\nhttps://github.com/TrinityCore/TrinityCore/blob/70955ed3a68a58701ae50c8f0f9afdec4f60853d/src/server/game/Movement/MotionMaster.h#L144\r\nAngle was never optional because the Optional object was always initialized at 0.0f if no value was provided by the caller.\r\n\r\n**Target branch(es):** 3.3.5\r\n\r\n**Issues addressed:** \r\nThis fixes for example ranged PlayerAI's chasing at an angle instead of chasing directly towards target.\r\nThis should also fix a lot of other seemingly strange chase behavior in scripts, when a chase distance is used.\r\n\r\n**Tests performed:**\r\nDoes build, tested with a hunter character mind controlled by a creature.\r\n","created_at":"2018-09-13T05:17:15Z","updated_at":"2018-09-13T05:17:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22426/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22426/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22426/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/bf36f70d3ded448122159b99b763e216ce624a82","head":{"label":"kelno:fixchase","ref":"fixchase","sha":"bf36f70d3ded448122159b99b763e216ce624a82","user":{"login":"kelno","id":3866946,"node_id":"MDQ6VXNlcjM4NjY5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3866946?v=4","gravatar_id":"","url":"https://api.github.com/users/kelno","html_url":"https://github.com/kelno","followers_url":"https://api.github.com/users/kelno/followers","following_url":"https://api.github.com/users/kelno/following{/other_user}","gists_url":"https://api.github.com/users/kelno/gists{/gist_id}","starred_url":"https://api.github.com/users/kelno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelno/subscriptions","organizations_url":"https://api.github.com/users/kelno/orgs","repos_url":"https://api.github.com/users/kelno/repos","events_url":"https://api.github.com/users/kelno/events{/privacy}","received_events_url":"https://api.github.com/users/kelno/received_events","type":"User","site_admin":false},"repo":{"id":57130817,"node_id":"MDEwOlJlcG9zaXRvcnk1NzEzMDgxNw==","name":"TrinityCore","full_name":"kelno/TrinityCore","owner":{"login":"kelno","id":3866946,"node_id":"MDQ6VXNlcjM4NjY5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3866946?v=4","gravatar_id":"","url":"https://api.github.com/users/kelno","html_url":"https://github.com/kelno","followers_url":"https://api.github.com/users/kelno/followers","following_url":"https://api.github.com/users/kelno/following{/other_user}","gists_url":"https://api.github.com/users/kelno/gists{/gist_id}","starred_url":"https://api.github.com/users/kelno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelno/subscriptions","organizations_url":"https://api.github.com/users/kelno/orgs","repos_url":"https://api.github.com/users/kelno/repos","events_url":"https://api.github.com/users/kelno/events{/privacy}","received_events_url":"https://api.github.com/users/kelno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kelno/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/kelno/TrinityCore","forks_url":"https://api.github.com/repos/kelno/TrinityCore/forks","keys_url":"https://api.github.com/repos/kelno/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelno/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelno/TrinityCore/teams","hooks_url":"https://api.github.com/repos/kelno/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/kelno/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/kelno/TrinityCore/events","assignees_url":"https://api.github.com/repos/kelno/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/kelno/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/kelno/TrinityCore/tags","blobs_url":"https://api.github.com/repos/kelno/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelno/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelno/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelno/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelno/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/kelno/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/kelno/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/kelno/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/kelno/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/kelno/TrinityCore/subscription","commits_url":"https://api.github.com/repos/kelno/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelno/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelno/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelno/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelno/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/kelno/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelno/TrinityCore/merges","archive_url":"https://api.github.com/repos/kelno/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelno/TrinityCore/downloads","issues_url":"https://api.github.com/repos/kelno/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/kelno/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/kelno/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/kelno/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelno/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/kelno/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/kelno/TrinityCore/deployments","created_at":"2016-04-26T13:34:00Z","updated_at":"2018-05-18T20:08:13Z","pushed_at":"2018-09-13T05:09:24Z","git_url":"git://github.com/kelno/TrinityCore.git","ssh_url":"git@github.com:kelno/TrinityCore.git","clone_url":"https://github.com/kelno/TrinityCore.git","svn_url":"https://github.com/kelno/TrinityCore","homepage":"http://www.trinitycore.org","size":651693,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"70955ed3a68a58701ae50c8f0f9afdec4f60853d","user":{"login":"TrinityCore","id":539602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzOTYwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0NDEy","name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzOTYwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.3.5.26972, 3.3.5 = 3.3.5a.12340)","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2018-09-13T05:01:31Z","pushed_at":"2018-09-13T01:28:07Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":716435,"stargazers_count":4681,"watchers_count":4681,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4149,"mirror_url":null,"archived":false,"open_issues_count":1451,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4149,"open_issues":1451,"watchers":4681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22426"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/22426"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22426"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22426/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22426/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22426/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/bf36f70d3ded448122159b99b763e216ce624a82"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"kelno"}}