{"action":"created","issue":{"url":"https://api.github.com/repos/hpc/mpifileutils/issues/201","repository_url":"https://api.github.com/repos/hpc/mpifileutils","labels_url":"https://api.github.com/repos/hpc/mpifileutils/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/hpc/mpifileutils/issues/201/comments","events_url":"https://api.github.com/repos/hpc/mpifileutils/issues/201/events","html_url":"https://github.com/hpc/mpifileutils/pull/201","id":385083420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTM0NTUw","number":201,"title":"Fix dcmp lite mode metadata check","user":{"login":"dsikich","id":20403624,"node_id":"MDQ6VXNlcjIwNDAzNjI0","avatar_url":"https://avatars3.githubusercontent.com/u/20403624?v=4","gravatar_id":"","url":"https://api.github.com/users/dsikich","html_url":"https://github.com/dsikich","followers_url":"https://api.github.com/users/dsikich/followers","following_url":"https://api.github.com/users/dsikich/following{/other_user}","gists_url":"https://api.github.com/users/dsikich/gists{/gist_id}","starred_url":"https://api.github.com/users/dsikich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsikich/subscriptions","organizations_url":"https://api.github.com/users/dsikich/orgs","repos_url":"https://api.github.com/users/dsikich/repos","events_url":"https://api.github.com/users/dsikich/events{/privacy}","received_events_url":"https://api.github.com/users/dsikich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-28T03:18:08Z","updated_at":"2018-11-28T20:59:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/hpc/mpifileutils/pulls/201","html_url":"https://github.com/hpc/mpifileutils/pull/201","diff_url":"https://github.com/hpc/mpifileutils/pull/201.diff","patch_url":"https://github.com/hpc/mpifileutils/pull/201.patch"},"body":"This mode was not comparing the modification times correctly\r\nin the compare function. It was mistakenly using the compare lists\r\ninstead of the original src and dst lists. The compare lists are\r\nempty in lite mode and only used when comparing the contents of a\r\nfile."},"comment":{"url":"https://api.github.com/repos/hpc/mpifileutils/issues/comments/442602590","html_url":"https://github.com/hpc/mpifileutils/pull/201#issuecomment-442602590","issue_url":"https://api.github.com/repos/hpc/mpifileutils/issues/201","id":442602590,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjYwMjU5MA==","user":{"login":"adammoody","id":1105742,"node_id":"MDQ6VXNlcjExMDU3NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1105742?v=4","gravatar_id":"","url":"https://api.github.com/users/adammoody","html_url":"https://github.com/adammoody","followers_url":"https://api.github.com/users/adammoody/followers","following_url":"https://api.github.com/users/adammoody/following{/other_user}","gists_url":"https://api.github.com/users/adammoody/gists{/gist_id}","starred_url":"https://api.github.com/users/adammoody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammoody/subscriptions","organizations_url":"https://api.github.com/users/adammoody/orgs","repos_url":"https://api.github.com/users/adammoody/repos","events_url":"https://api.github.com/users/adammoody/events{/privacy}","received_events_url":"https://api.github.com/users/adammoody/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T20:59:56Z","updated_at":"2018-11-28T20:59:56Z","author_association":"MEMBER","body":"I'm confused a bit looking at that surrounding code.  There are a couple lines that set the CONTENTS to be COMMON after the if block which compares mtimes.\r\n\r\nhttps://github.com/hpc/mpifileutils/blob/f5be21671f357435d5fbdbff6607d29d11bf1a74/src/dcmp/dcmp.c#L943\r\n\r\nIn the non-lite mode, it seems like we wouldn't know that until after reading bytes to compare data.\r\n\r\nShould those COMMON lines be moved up inside of the if lite block?\r\n\r\nhttps://github.com/hpc/mpifileutils/blob/f5be21671f357435d5fbdbff6607d29d11bf1a74/src/dcmp/dcmp.c#L931"}}
{"actor":{"display_login":"adammoody"}}