{"action":"created","issue":{"url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1","repository_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin","labels_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1/comments","events_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1/events","html_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1","id":325986235,"number":1,"title":"This gets the demo into a working state.","user":{"login":"jdotrjs","id":37101247,"avatar_url":"https://avatars0.githubusercontent.com/u/37101247?v=4","gravatar_id":"","url":"https://api.github.com/users/jdotrjs","html_url":"https://github.com/jdotrjs","followers_url":"https://api.github.com/users/jdotrjs/followers","following_url":"https://api.github.com/users/jdotrjs/following{/other_user}","gists_url":"https://api.github.com/users/jdotrjs/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotrjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotrjs/subscriptions","organizations_url":"https://api.github.com/users/jdotrjs/orgs","repos_url":"https://api.github.com/users/jdotrjs/repos","events_url":"https://api.github.com/users/jdotrjs/events{/privacy}","received_events_url":"https://api.github.com/users/jdotrjs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-24T06:51:47Z","updated_at":"2018-05-24T17:03:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/pulls/1","html_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1","diff_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1.diff","patch_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1.patch"},"body":"I left in some of my debugging jank that wasn't game stopping (so no `debugger` calls) which we'll probably want to pull out. (I'm mostly talking about `bulletID`). I also didn't test anything _except_ the default demo so there are likely some bugs still left to clean out.\r\n\r\nSome comments I have that still need to be cleaned up in my code:\r\n\r\n- Instead of making a deep call into the bullet manager like so: `this.data.bulletManager.eventEmitter.emit('kill', this);`I might handle this by passing a function that can be called to report a kill; this makes the structure of bulletManager less visible to the bullet. I also didn't comb the codebase for other uses of the old style signal stuff (`onKill.dispatch`)\r\n- all the console.log needs to go\r\n- the bulletID stuff is maybe useful but unnecessary; i used it just to make sure my theory of reusing the first bullet in the pool was correct\r\n- `Bullet#update` is a shitshow right now :shame_hat:. I added a comment but basically I just inline create a new Rectangle which is not the right thing to do; a bit of spelunking is in order\r\n\r\nThoughts on future work -- interactions with the signaling and physics systems are pretty different in v3 than v2 so I think we'll need to pay specific attention to those edges before calling it done.\r\n\r\nAll in all this feels really good, I'm glad you decided to pick up porting it and I'm pretty excited to drop it into my next game when it's ready to go live, <3!\r\n\r\nThanks @16patsle!\r\n\r\n(random ps. I reflowed the text because of my editor but forgot to roll it back; sorry about that 😿)"},"comment":{"url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/comments/391788427","html_url":"https://github.com/16patsle/phaser3-weapon-plugin/pull/1#issuecomment-391788427","issue_url":"https://api.github.com/repos/16patsle/phaser3-weapon-plugin/issues/1","id":391788427,"user":{"login":"16patsle","id":7686840,"avatar_url":"https://avatars1.githubusercontent.com/u/7686840?v=4","gravatar_id":"","url":"https://api.github.com/users/16patsle","html_url":"https://github.com/16patsle","followers_url":"https://api.github.com/users/16patsle/followers","following_url":"https://api.github.com/users/16patsle/following{/other_user}","gists_url":"https://api.github.com/users/16patsle/gists{/gist_id}","starred_url":"https://api.github.com/users/16patsle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/16patsle/subscriptions","organizations_url":"https://api.github.com/users/16patsle/orgs","repos_url":"https://api.github.com/users/16patsle/repos","events_url":"https://api.github.com/users/16patsle/events{/privacy}","received_events_url":"https://api.github.com/users/16patsle/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T17:03:24Z","updated_at":"2018-05-24T17:03:24Z","author_association":"OWNER","body":"I'm merging this now, and I'll cleanup the code later. We could probably still need your debugging stuff, so I'm keeping it for now."}}
{"actor":{"display_login":"16patsle"}}