{"action":"opened","number":707,"pull_request":{"url":"https://api.github.com/repos/thomaschampagne/elevate/pulls/707","id":235248151,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjQ4MTUx","html_url":"https://github.com/thomaschampagne/elevate/pull/707","diff_url":"https://github.com/thomaschampagne/elevate/pull/707.diff","patch_url":"https://github.com/thomaschampagne/elevate/pull/707.patch","issue_url":"https://api.github.com/repos/thomaschampagne/elevate/issues/707","number":707,"state":"open","locked":false,"title":"Feature: Add links to legend activities","user":{"login":"dlh3","id":648035,"node_id":"MDQ6VXNlcjY0ODAzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/648035?v=4","gravatar_id":"","url":"https://api.github.com/users/dlh3","html_url":"https://github.com/dlh3","followers_url":"https://api.github.com/users/dlh3/followers","following_url":"https://api.github.com/users/dlh3/following{/other_user}","gists_url":"https://api.github.com/users/dlh3/gists{/gist_id}","starred_url":"https://api.github.com/users/dlh3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlh3/subscriptions","organizations_url":"https://api.github.com/users/dlh3/orgs","repos_url":"https://api.github.com/users/dlh3/repos","events_url":"https://api.github.com/users/dlh3/events{/privacy}","received_events_url":"https://api.github.com/users/dlh3/received_events","type":"User","site_admin":false},"body":"Let me begin by saying that Node.js and Chrome extensions are definitely not my domain, so I am offering this PR on a best-effort basis.  \r\n\r\nCommit 2ae6557 was necessary because event-stream@3.3.6 could not be found when I ran `npm install`.  I believe that version included a backdoor or other major vulnerability and was pulled from NPM.  I don't know if my approach here was correct (I suspect some of the changes in that commit are unwanted), but it unblocked me and allowed for the installation of dependencies.\r\n\r\nThe actual feature-related changes were pretty minimal, but I was unable to test them.  When I am using the published extension (from the Chrome Web Store), I can move the mouse out of the graph and the legend remains populated with the activities from whichever day I was on before moving the mouse out of the graph.  Strangely, this is not the case when I build and load the extension locally.  For my version (even before my changes), the legend clears when I move the mouse out of the grid.  No errors are logged in the dev console or chrome://extensions dashboard.  I also tried `npm run build:prod`, but that made no difference.\r\n\r\nAnyways, the proposed feature is pretty straightforward.  It would be great if the activities in the fitness trend legend were links so a user could click to open that specific activity from the legend (rather than clicking the graph to open all activities on a given day, or scrolling down to find the activity in the table).  I keep finding myself trying to click an activity in the legend, so it just felt like the links should intuitively be there but they were missing.\r\n\r\nFeel free to use part or all of this PR, or perhaps implement completely differently.  In any case, I'd love to see this change included in a future version.  \r\n\r\nThanks for the amazing project!","created_at":"2018-12-02T09:33:54Z","updated_at":"2018-12-02T09:33:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thomaschampagne/elevate/pulls/707/commits","review_comments_url":"https://api.github.com/repos/thomaschampagne/elevate/pulls/707/comments","review_comment_url":"https://api.github.com/repos/thomaschampagne/elevate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thomaschampagne/elevate/issues/707/comments","statuses_url":"https://api.github.com/repos/thomaschampagne/elevate/statuses/19c2467909881eb5cbc846b61f25aadde0be7588","head":{"label":"dlh3:feature/add-links-to-legend-activities","ref":"feature/add-links-to-legend-activities","sha":"19c2467909881eb5cbc846b61f25aadde0be7588","user":{"login":"dlh3","id":648035,"node_id":"MDQ6VXNlcjY0ODAzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/648035?v=4","gravatar_id":"","url":"https://api.github.com/users/dlh3","html_url":"https://github.com/dlh3","followers_url":"https://api.github.com/users/dlh3/followers","following_url":"https://api.github.com/users/dlh3/following{/other_user}","gists_url":"https://api.github.com/users/dlh3/gists{/gist_id}","starred_url":"https://api.github.com/users/dlh3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlh3/subscriptions","organizations_url":"https://api.github.com/users/dlh3/orgs","repos_url":"https://api.github.com/users/dlh3/repos","events_url":"https://api.github.com/users/dlh3/events{/privacy}","received_events_url":"https://api.github.com/users/dlh3/received_events","type":"User","site_admin":false},"repo":{"id":160030644,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAwMzA2NDQ=","name":"elevate","full_name":"dlh3/elevate","private":false,"owner":{"login":"dlh3","id":648035,"node_id":"MDQ6VXNlcjY0ODAzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/648035?v=4","gravatar_id":"","url":"https://api.github.com/users/dlh3","html_url":"https://github.com/dlh3","followers_url":"https://api.github.com/users/dlh3/followers","following_url":"https://api.github.com/users/dlh3/following{/other_user}","gists_url":"https://api.github.com/users/dlh3/gists{/gist_id}","starred_url":"https://api.github.com/users/dlh3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlh3/subscriptions","organizations_url":"https://api.github.com/users/dlh3/orgs","repos_url":"https://api.github.com/users/dlh3/repos","events_url":"https://api.github.com/users/dlh3/events{/privacy}","received_events_url":"https://api.github.com/users/dlh3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dlh3/elevate","description":"Browser extension for strava. \"Elevate\" tracks your fitness and progressions over time. Analyse deeper your activities & segments. And more... https://thomaschampagne.github.io/elevate/ (formerly named stravistix)","fork":true,"url":"https://api.github.com/repos/dlh3/elevate","forks_url":"https://api.github.com/repos/dlh3/elevate/forks","keys_url":"https://api.github.com/repos/dlh3/elevate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlh3/elevate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlh3/elevate/teams","hooks_url":"https://api.github.com/repos/dlh3/elevate/hooks","issue_events_url":"https://api.github.com/repos/dlh3/elevate/issues/events{/number}","events_url":"https://api.github.com/repos/dlh3/elevate/events","assignees_url":"https://api.github.com/repos/dlh3/elevate/assignees{/user}","branches_url":"https://api.github.com/repos/dlh3/elevate/branches{/branch}","tags_url":"https://api.github.com/repos/dlh3/elevate/tags","blobs_url":"https://api.github.com/repos/dlh3/elevate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlh3/elevate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlh3/elevate/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlh3/elevate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlh3/elevate/statuses/{sha}","languages_url":"https://api.github.com/repos/dlh3/elevate/languages","stargazers_url":"https://api.github.com/repos/dlh3/elevate/stargazers","contributors_url":"https://api.github.com/repos/dlh3/elevate/contributors","subscribers_url":"https://api.github.com/repos/dlh3/elevate/subscribers","subscription_url":"https://api.github.com/repos/dlh3/elevate/subscription","commits_url":"https://api.github.com/repos/dlh3/elevate/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlh3/elevate/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlh3/elevate/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlh3/elevate/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlh3/elevate/contents/{+path}","compare_url":"https://api.github.com/repos/dlh3/elevate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlh3/elevate/merges","archive_url":"https://api.github.com/repos/dlh3/elevate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlh3/elevate/downloads","issues_url":"https://api.github.com/repos/dlh3/elevate/issues{/number}","pulls_url":"https://api.github.com/repos/dlh3/elevate/pulls{/number}","milestones_url":"https://api.github.com/repos/dlh3/elevate/milestones{/number}","notifications_url":"https://api.github.com/repos/dlh3/elevate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlh3/elevate/labels{/name}","releases_url":"https://api.github.com/repos/dlh3/elevate/releases{/id}","deployments_url":"https://api.github.com/repos/dlh3/elevate/deployments","created_at":"2018-12-02T09:09:49Z","updated_at":"2018-12-02T09:09:52Z","pushed_at":"2018-12-02T09:13:06Z","git_url":"git://github.com/dlh3/elevate.git","ssh_url":"git@github.com:dlh3/elevate.git","clone_url":"https://github.com/dlh3/elevate.git","svn_url":"https://github.com/dlh3/elevate","homepage":"","size":21778,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"thomaschampagne:develop","ref":"develop","sha":"5896591a6fc17790ca668a33a35da4625052239b","user":{"login":"thomaschampagne","id":151973,"node_id":"MDQ6VXNlcjE1MTk3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/151973?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaschampagne","html_url":"https://github.com/thomaschampagne","followers_url":"https://api.github.com/users/thomaschampagne/followers","following_url":"https://api.github.com/users/thomaschampagne/following{/other_user}","gists_url":"https://api.github.com/users/thomaschampagne/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaschampagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaschampagne/subscriptions","organizations_url":"https://api.github.com/users/thomaschampagne/orgs","repos_url":"https://api.github.com/users/thomaschampagne/repos","events_url":"https://api.github.com/users/thomaschampagne/events{/privacy}","received_events_url":"https://api.github.com/users/thomaschampagne/received_events","type":"User","site_admin":false},"repo":{"id":25056806,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA1NjgwNg==","name":"elevate","full_name":"thomaschampagne/elevate","private":false,"owner":{"login":"thomaschampagne","id":151973,"node_id":"MDQ6VXNlcjE1MTk3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/151973?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaschampagne","html_url":"https://github.com/thomaschampagne","followers_url":"https://api.github.com/users/thomaschampagne/followers","following_url":"https://api.github.com/users/thomaschampagne/following{/other_user}","gists_url":"https://api.github.com/users/thomaschampagne/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaschampagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaschampagne/subscriptions","organizations_url":"https://api.github.com/users/thomaschampagne/orgs","repos_url":"https://api.github.com/users/thomaschampagne/repos","events_url":"https://api.github.com/users/thomaschampagne/events{/privacy}","received_events_url":"https://api.github.com/users/thomaschampagne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thomaschampagne/elevate","description":"Browser extension for strava. \"Elevate\" tracks your fitness and progressions over time. Analyse deeper your activities & segments. And more... https://thomaschampagne.github.io/elevate/ (formerly named stravistix)","fork":false,"url":"https://api.github.com/repos/thomaschampagne/elevate","forks_url":"https://api.github.com/repos/thomaschampagne/elevate/forks","keys_url":"https://api.github.com/repos/thomaschampagne/elevate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaschampagne/elevate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaschampagne/elevate/teams","hooks_url":"https://api.github.com/repos/thomaschampagne/elevate/hooks","issue_events_url":"https://api.github.com/repos/thomaschampagne/elevate/issues/events{/number}","events_url":"https://api.github.com/repos/thomaschampagne/elevate/events","assignees_url":"https://api.github.com/repos/thomaschampagne/elevate/assignees{/user}","branches_url":"https://api.github.com/repos/thomaschampagne/elevate/branches{/branch}","tags_url":"https://api.github.com/repos/thomaschampagne/elevate/tags","blobs_url":"https://api.github.com/repos/thomaschampagne/elevate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaschampagne/elevate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaschampagne/elevate/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaschampagne/elevate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaschampagne/elevate/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaschampagne/elevate/languages","stargazers_url":"https://api.github.com/repos/thomaschampagne/elevate/stargazers","contributors_url":"https://api.github.com/repos/thomaschampagne/elevate/contributors","subscribers_url":"https://api.github.com/repos/thomaschampagne/elevate/subscribers","subscription_url":"https://api.github.com/repos/thomaschampagne/elevate/subscription","commits_url":"https://api.github.com/repos/thomaschampagne/elevate/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaschampagne/elevate/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaschampagne/elevate/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaschampagne/elevate/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomaschampagne/elevate/contents/{+path}","compare_url":"https://api.github.com/repos/thomaschampagne/elevate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaschampagne/elevate/merges","archive_url":"https://api.github.com/repos/thomaschampagne/elevate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaschampagne/elevate/downloads","issues_url":"https://api.github.com/repos/thomaschampagne/elevate/issues{/number}","pulls_url":"https://api.github.com/repos/thomaschampagne/elevate/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaschampagne/elevate/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaschampagne/elevate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaschampagne/elevate/labels{/name}","releases_url":"https://api.github.com/repos/thomaschampagne/elevate/releases{/id}","deployments_url":"https://api.github.com/repos/thomaschampagne/elevate/deployments","created_at":"2014-10-10T23:24:52Z","updated_at":"2018-12-01T12:45:46Z","pushed_at":"2018-12-01T12:45:44Z","git_url":"git://github.com/thomaschampagne/elevate.git","ssh_url":"git@github.com:thomaschampagne/elevate.git","clone_url":"https://github.com/thomaschampagne/elevate.git","svn_url":"https://github.com/thomaschampagne/elevate","homepage":"","size":21778,"stargazers_count":488,"watchers_count":488,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":187,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":110,"open_issues":187,"watchers":488,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/thomaschampagne/elevate/pulls/707"},"html":{"href":"https://github.com/thomaschampagne/elevate/pull/707"},"issue":{"href":"https://api.github.com/repos/thomaschampagne/elevate/issues/707"},"comments":{"href":"https://api.github.com/repos/thomaschampagne/elevate/issues/707/comments"},"review_comments":{"href":"https://api.github.com/repos/thomaschampagne/elevate/pulls/707/comments"},"review_comment":{"href":"https://api.github.com/repos/thomaschampagne/elevate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thomaschampagne/elevate/pulls/707/commits"},"statuses":{"href":"https://api.github.com/repos/thomaschampagne/elevate/statuses/19c2467909881eb5cbc846b61f25aadde0be7588"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":32,"deletions":31,"changed_files":6}}
{"actor":{"display_login":"dlh3"}}