{"action":"created","issue":{"url":"https://api.github.com/repos/textpattern/textpattern/issues/1241","repository_url":"https://api.github.com/repos/textpattern/textpattern","labels_url":"https://api.github.com/repos/textpattern/textpattern/issues/1241/labels{/name}","comments_url":"https://api.github.com/repos/textpattern/textpattern/issues/1241/comments","events_url":"https://api.github.com/repos/textpattern/textpattern/issues/1241/events","html_url":"https://github.com/textpattern/textpattern/issues/1241","id":313347310,"number":1241,"title":"File upload misbehaving in `dev`?","user":{"login":"petecooper","id":226578,"avatar_url":"https://avatars1.githubusercontent.com/u/226578?v=4","gravatar_id":"","url":"https://api.github.com/users/petecooper","html_url":"https://github.com/petecooper","followers_url":"https://api.github.com/users/petecooper/followers","following_url":"https://api.github.com/users/petecooper/following{/other_user}","gists_url":"https://api.github.com/users/petecooper/gists{/gist_id}","starred_url":"https://api.github.com/users/petecooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petecooper/subscriptions","organizations_url":"https://api.github.com/users/petecooper/orgs","repos_url":"https://api.github.com/users/petecooper/repos","events_url":"https://api.github.com/users/petecooper/events{/privacy}","received_events_url":"https://api.github.com/users/petecooper/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-04-11T14:24:08Z","updated_at":"2018-04-11T21:06:40Z","closed_at":"2018-04-11T15:42:29Z","author_association":"MEMBER","body":"(Might just be the demo site, it's not clear…would appreciate additional testing from other folks reading this running on `dev`)\r\n\r\n### Expected behaviour\r\n\r\nPermitted file uploads to be available.\r\n\r\n### Actual behaviour\r\n\r\nPermitted file uploads are seemingly not available.\r\n\r\n### Steps to reproduce\r\n\r\n* log in with rights to upload a new file (Publisher, Managing Editor, etc)\r\n* visit `/textpattern/index.php?event=file`\r\n* select a file for upload\r\n* note progress bar appears and disappears straight away\r\n* select an unsuitable file for upload (e.g. above upload limit)\r\n* note error about file not suitable for uploading\r\n\r\nWorks fine in beta, broken in `dev`.\r\n\r\n#### Additional information\r\n\r\nTextpattern version: current `4.7.0-dev` from about 2 hours ago\r\n\r\nAttached a 1m46s SFW screencast (no audio), bottom window is beta (works), top window is dev (broken?).\r\n\r\n[dev file upload.zip](https://github.com/textpattern/textpattern/files/1899217/dev.file.upload.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/textpattern/textpattern/issues/comments/380595778","html_url":"https://github.com/textpattern/textpattern/issues/1241#issuecomment-380595778","issue_url":"https://api.github.com/repos/textpattern/textpattern/issues/1241","id":380595778,"user":{"login":"Bloke","id":21252,"avatar_url":"https://avatars0.githubusercontent.com/u/21252?v=4","gravatar_id":"","url":"https://api.github.com/users/Bloke","html_url":"https://github.com/Bloke","followers_url":"https://api.github.com/users/Bloke/followers","following_url":"https://api.github.com/users/Bloke/following{/other_user}","gists_url":"https://api.github.com/users/Bloke/gists{/gist_id}","starred_url":"https://api.github.com/users/Bloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bloke/subscriptions","organizations_url":"https://api.github.com/users/Bloke/orgs","repos_url":"https://api.github.com/users/Bloke/repos","events_url":"https://api.github.com/users/Bloke/events{/privacy}","received_events_url":"https://api.github.com/users/Bloke/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T21:06:40Z","updated_at":"2018-04-11T21:06:40Z","author_association":"OWNER","body":"Interesting. Under normal circumstances, this seems like desired behaviour. If a Txp admin wants to let people upload colossal files, but the underlying server limits it to chunking, that's great. You can upload massive files in N-bytes hunks where N is the lower of the PHP/web server limit.\r\n\r\nHowever, in a public-facing situation such as the demo site this is not really what you want, as Pete says. Anyone could visit the prefs panel, set the max file size to BIGINT or something really huge, start uploading a 1.21 Gigawatt file and tie the server up in knots, or at least prevent others from enjoying the service while the upload is in progress.\r\n\r\nThis could perhaps be mitigated with a running-from-the-file-system plugin to limit the value to some nominal maximum of Pete's choosing without impacting the user experience. Or find some way to throttle it back to a hard limit set somewhere else by the server, if that makes sense.\r\n\r\nOr when you investigate Docker et al, find some way to limit the available user space that way, maybe?"}}
{"actor":{"display_login":"Bloke"}}