{"action":"created","comment":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/comments/180614779","pull_request_review_id":111065068,"id":180614779,"diff_hunk":"@@ -0,0 +1,52 @@\n+package client\n+\n+import (\n+\t\"bytes\"\n+\t\"context\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"net/http\"\n+\t\"strings\"\n+\t\"testing\"\n+)\n+\n+func TestContainerResizeError(t *testing.T) {\n+\tclient := &APIClient{\n+\t\tHTTPCli: newMockClient(errorMockResponse(http.StatusInternalServerError, \"Server error\")),\n+\t}\n+\terr := client.ContainerResize(context.Background(), \"nothing\", \"\", \"\")\n+\tif err == nil || !strings.Contains(err.Error(), \"Server error\") {\n+\t\tt.Fatalf(\"expected a Server Error, got %v\", err)\n+\t}\n+}\n+\n+func TestContainerResize(t *testing.T) {\n+\texpectedURL := \"/containers/container_id/resize\"\n+\n+\thttpClient := newMockClient(func(req *http.Request) (*http.Response, error) {\n+\t\tif !strings.HasPrefix(req.URL.Path, expectedURL) {\n+\t\t\treturn nil, fmt.Errorf(\"Expected URL '%s', got '%s'\", expectedURL, req.URL)","path":"client/container_resize_test.go","position":28,"original_position":28,"commit_id":"86c7f9ad4a8507a6eed76eb9c5368aea585c7630","original_commit_id":"86c7f9ad4a8507a6eed76eb9c5368aea585c7630","user":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars3.githubusercontent.com/u/9465626?v=4","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"body":"Yes, I think what @zhuangqh mentioned is reasonable. Could someone fix this totally in a single pull request. @ZouRui89 ","created_at":"2018-04-11T01:46:19Z","updated_at":"2018-04-11T01:46:20Z","html_url":"https://github.com/alibaba/pouch/pull/1090#discussion_r180614779","pull_request_url":"https://api.github.com/repos/alibaba/pouch/pulls/1090","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments/180614779"},"html":{"href":"https://github.com/alibaba/pouch/pull/1090#discussion_r180614779"},"pull_request":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1090"}},"in_reply_to_id":180418420},"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1090","id":180542617,"html_url":"https://github.com/alibaba/pouch/pull/1090","diff_url":"https://github.com/alibaba/pouch/pull/1090.diff","patch_url":"https://github.com/alibaba/pouch/pull/1090.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1090","number":1090,"state":"open","locked":false,"title":"test:add container resize and restart test","user":{"login":"Dewey-Ding","id":26279653,"avatar_url":"https://avatars2.githubusercontent.com/u/26279653?v=4","gravatar_id":"","url":"https://api.github.com/users/Dewey-Ding","html_url":"https://github.com/Dewey-Ding","followers_url":"https://api.github.com/users/Dewey-Ding/followers","following_url":"https://api.github.com/users/Dewey-Ding/following{/other_user}","gists_url":"https://api.github.com/users/Dewey-Ding/gists{/gist_id}","starred_url":"https://api.github.com/users/Dewey-Ding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dewey-Ding/subscriptions","organizations_url":"https://api.github.com/users/Dewey-Ding/orgs","repos_url":"https://api.github.com/users/Dewey-Ding/repos","events_url":"https://api.github.com/users/Dewey-Ding/events{/privacy}","received_events_url":"https://api.github.com/users/Dewey-Ding/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Dewey-Ding <deweyding@gmail.com>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nadd container resize and restart test\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n","created_at":"2018-04-10T09:35:35Z","updated_at":"2018-04-11T01:46:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27f1300a233f43c7f90aeaf3f3cbcac99326662c","assignee":{"login":"ZouRui89","id":32304680,"avatar_url":"https://avatars3.githubusercontent.com/u/32304680?v=4","gravatar_id":"","url":"https://api.github.com/users/ZouRui89","html_url":"https://github.com/ZouRui89","followers_url":"https://api.github.com/users/ZouRui89/followers","following_url":"https://api.github.com/users/ZouRui89/following{/other_user}","gists_url":"https://api.github.com/users/ZouRui89/gists{/gist_id}","starred_url":"https://api.github.com/users/ZouRui89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZouRui89/subscriptions","organizations_url":"https://api.github.com/users/ZouRui89/orgs","repos_url":"https://api.github.com/users/ZouRui89/repos","events_url":"https://api.github.com/users/ZouRui89/events{/privacy}","received_events_url":"https://api.github.com/users/ZouRui89/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZouRui89","id":32304680,"avatar_url":"https://avatars3.githubusercontent.com/u/32304680?v=4","gravatar_id":"","url":"https://api.github.com/users/ZouRui89","html_url":"https://github.com/ZouRui89","followers_url":"https://api.github.com/users/ZouRui89/followers","following_url":"https://api.github.com/users/ZouRui89/following{/other_user}","gists_url":"https://api.github.com/users/ZouRui89/gists{/gist_id}","starred_url":"https://api.github.com/users/ZouRui89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZouRui89/subscriptions","organizations_url":"https://api.github.com/users/ZouRui89/orgs","repos_url":"https://api.github.com/users/ZouRui89/repos","events_url":"https://api.github.com/users/ZouRui89/events{/privacy}","received_events_url":"https://api.github.com/users/ZouRui89/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722339975,"url":"https://api.github.com/repos/alibaba/pouch/labels/areas/test","name":"areas/test","color":"1d76db","default":false},{"id":722355122,"url":"https://api.github.com/repos/alibaba/pouch/labels/size/L","name":"size/L","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1090/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/86c7f9ad4a8507a6eed76eb9c5368aea585c7630","head":{"label":"Dewey-Ding:master","ref":"master","sha":"86c7f9ad4a8507a6eed76eb9c5368aea585c7630","user":{"login":"Dewey-Ding","id":26279653,"avatar_url":"https://avatars2.githubusercontent.com/u/26279653?v=4","gravatar_id":"","url":"https://api.github.com/users/Dewey-Ding","html_url":"https://github.com/Dewey-Ding","followers_url":"https://api.github.com/users/Dewey-Ding/followers","following_url":"https://api.github.com/users/Dewey-Ding/following{/other_user}","gists_url":"https://api.github.com/users/Dewey-Ding/gists{/gist_id}","starred_url":"https://api.github.com/users/Dewey-Ding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dewey-Ding/subscriptions","organizations_url":"https://api.github.com/users/Dewey-Ding/orgs","repos_url":"https://api.github.com/users/Dewey-Ding/repos","events_url":"https://api.github.com/users/Dewey-Ding/events{/privacy}","received_events_url":"https://api.github.com/users/Dewey-Ding/received_events","type":"User","site_admin":false},"repo":{"id":127306241,"name":"pouch","full_name":"Dewey-Ding/pouch","owner":{"login":"Dewey-Ding","id":26279653,"avatar_url":"https://avatars2.githubusercontent.com/u/26279653?v=4","gravatar_id":"","url":"https://api.github.com/users/Dewey-Ding","html_url":"https://github.com/Dewey-Ding","followers_url":"https://api.github.com/users/Dewey-Ding/followers","following_url":"https://api.github.com/users/Dewey-Ding/following{/other_user}","gists_url":"https://api.github.com/users/Dewey-Ding/gists{/gist_id}","starred_url":"https://api.github.com/users/Dewey-Ding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dewey-Ding/subscriptions","organizations_url":"https://api.github.com/users/Dewey-Ding/orgs","repos_url":"https://api.github.com/users/Dewey-Ding/repos","events_url":"https://api.github.com/users/Dewey-Ding/events{/privacy}","received_events_url":"https://api.github.com/users/Dewey-Ding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dewey-Ding/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":true,"url":"https://api.github.com/repos/Dewey-Ding/pouch","forks_url":"https://api.github.com/repos/Dewey-Ding/pouch/forks","keys_url":"https://api.github.com/repos/Dewey-Ding/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dewey-Ding/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dewey-Ding/pouch/teams","hooks_url":"https://api.github.com/repos/Dewey-Ding/pouch/hooks","issue_events_url":"https://api.github.com/repos/Dewey-Ding/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/Dewey-Ding/pouch/events","assignees_url":"https://api.github.com/repos/Dewey-Ding/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/Dewey-Ding/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/Dewey-Ding/pouch/tags","blobs_url":"https://api.github.com/repos/Dewey-Ding/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dewey-Ding/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dewey-Ding/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dewey-Ding/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dewey-Ding/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/Dewey-Ding/pouch/languages","stargazers_url":"https://api.github.com/repos/Dewey-Ding/pouch/stargazers","contributors_url":"https://api.github.com/repos/Dewey-Ding/pouch/contributors","subscribers_url":"https://api.github.com/repos/Dewey-Ding/pouch/subscribers","subscription_url":"https://api.github.com/repos/Dewey-Ding/pouch/subscription","commits_url":"https://api.github.com/repos/Dewey-Ding/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dewey-Ding/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dewey-Ding/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dewey-Ding/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dewey-Ding/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/Dewey-Ding/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dewey-Ding/pouch/merges","archive_url":"https://api.github.com/repos/Dewey-Ding/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dewey-Ding/pouch/downloads","issues_url":"https://api.github.com/repos/Dewey-Ding/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/Dewey-Ding/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/Dewey-Ding/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/Dewey-Ding/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dewey-Ding/pouch/labels{/name}","releases_url":"https://api.github.com/repos/Dewey-Ding/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/Dewey-Ding/pouch/deployments","created_at":"2018-03-29T14:50:42Z","updated_at":"2018-04-10T09:33:16Z","pushed_at":"2018-04-10T09:33:15Z","git_url":"git://github.com/Dewey-Ding/pouch.git","ssh_url":"git@github.com:Dewey-Ding/pouch.git","clone_url":"https://github.com/Dewey-Ding/pouch.git","svn_url":"https://github.com/Dewey-Ding/pouch","homepage":"","size":8264,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"15c9cbbfb91c44b8bf80f1173509f2d4b859cb53","user":{"login":"alibaba","id":1961952,"avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"name":"pouch","full_name":"alibaba/pouch","owner":{"login":"alibaba","id":1961952,"avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alibaba/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-04-11T01:38:19Z","pushed_at":"2018-04-11T01:40:22Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"","size":8265,"stargazers_count":2360,"watchers_count":2360,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":428,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":428,"open_issues":106,"watchers":2360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1090"},"html":{"href":"https://github.com/alibaba/pouch/pull/1090"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1090"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/86c7f9ad4a8507a6eed76eb9c5368aea585c7630"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"allencloud"}}