{"action":"created","comment":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/comments/207979709","pull_request_review_id":143699937,"id":207979709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk3OTcwOQ==","diff_hunk":"@@ -800,6 +821,17 @@ private void uploadToRPubs(RSConnectPublishInput input,\n          RSConnectPublishResult result,\n          final ProgressIndicator indicator)\n    {\n+      if (input.getContentType() == CONTENT_TYPE_DOCUMENT && \n+            (!input.hasDocOutput() || !supportedRPubsDocExtension(input.getDocOutput())))\n+      {\n+         display_.showErrorMessage(\"Publish Document\",","path":"src/gwt/src/org/rstudio/studio/client/rsconnect/RSConnect.java","position":93,"original_position":93,"commit_id":"9fc64686bc5bffa2103f698490ab04c62567c10d","original_commit_id":"9fc64686bc5bffa2103f698490ab04c62567c10d","user":{"login":"jmcphers","id":470418,"node_id":"MDQ6VXNlcjQ3MDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/470418?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcphers","html_url":"https://github.com/jmcphers","followers_url":"https://api.github.com/users/jmcphers/followers","following_url":"https://api.github.com/users/jmcphers/following{/other_user}","gists_url":"https://api.github.com/users/jmcphers/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcphers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcphers/subscriptions","organizations_url":"https://api.github.com/users/jmcphers/orgs","repos_url":"https://api.github.com/users/jmcphers/repos","events_url":"https://api.github.com/users/jmcphers/events{/privacy}","received_events_url":"https://api.github.com/users/jmcphers/received_events","type":"User","site_admin":false},"body":"Nit: as earlier, I think we should have a separate error message for unsupported extensions","created_at":"2018-08-06T18:01:25Z","updated_at":"2018-08-06T18:01:35Z","html_url":"https://github.com/rstudio/rstudio/pull/3266#discussion_r207979709","pull_request_url":"https://api.github.com/repos/rstudio/rstudio/pulls/3266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/comments/207979709"},"html":{"href":"https://github.com/rstudio/rstudio/pull/3266#discussion_r207979709"},"pull_request":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3266"}}},"pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/3266","id":206267508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjY3NTA4","html_url":"https://github.com/rstudio/rstudio/pull/3266","diff_url":"https://github.com/rstudio/rstudio/pull/3266.diff","patch_url":"https://github.com/rstudio/rstudio/pull/3266.patch","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/3266","number":3266,"state":"open","locked":false,"title":"Allow publishing rendered content from the Source pane","user":{"login":"gtritchie","id":10569626,"node_id":"MDQ6VXNlcjEwNTY5NjI2","avatar_url":"https://avatars3.githubusercontent.com/u/10569626?v=4","gravatar_id":"","url":"https://api.github.com/users/gtritchie","html_url":"https://github.com/gtritchie","followers_url":"https://api.github.com/users/gtritchie/followers","following_url":"https://api.github.com/users/gtritchie/following{/other_user}","gists_url":"https://api.github.com/users/gtritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/gtritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtritchie/subscriptions","organizations_url":"https://api.github.com/users/gtritchie/orgs","repos_url":"https://api.github.com/users/gtritchie/repos","events_url":"https://api.github.com/users/gtritchie/events{/privacy}","received_events_url":"https://api.github.com/users/gtritchie/received_events","type":"User","site_admin":false},"body":"In RStudio 1.0 you could publish rendered content from the Source pane. The IDE would auto-run rendering before showing the publishing wizard (if current output was missing or out-of-date) to ensure it was available if user went down a publish-wizard path that needed it. However, publishing source to Connect does not need it, and often rendering on the client is not going to work at all for Connect users, so it was confusing and time-consuming.\r\n\r\nRStudio 1.1 removed the ability to publish rendered content from the Source pane. It would only publish source from editor (i.e. publish source to Connect). To publish rendered content, had to use the Publish button on the rendered preview in viewer/window. Though this is logical, many users were used to using the editor's publish button and thought the ability to publish to RPubs or publish output-only to Connect had been removed.\r\n\r\nThis change puts back the ability to publish content from the Source pane. However, it does not do auto-render as in 1.0 to avoid the problems mentioned. Per conversation with @jmcphers, chose to show an error message if user goes down a publish path requiring rendered content, and it was missing, telling them to go do the render and try again. Injecting auto-render into the appropriate place in publishing wizard was deemed too messy, at least for 1.2.\r\n\r\nAlso detect when an attempt is made to publish unsupported rendered output to RPubs (e.g. PDF, MS-Word), instead of letting the deployment package show an obscure error in the console.\r\n\r\nDid not do the work to support publishing of other static-content formats such as PDF, Word, PPT, directly from the IDE. Broke that out into a separate issue to work on next.\r\n\r\nFixes #2816","created_at":"2018-08-06T00:49:31Z","updated_at":"2018-08-06T18:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"055abbcf9a84888889c3c74f02a1b4fdf37888dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rstudio/rstudio/pulls/3266/commits","review_comments_url":"https://api.github.com/repos/rstudio/rstudio/pulls/3266/comments","review_comment_url":"https://api.github.com/repos/rstudio/rstudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/3266/comments","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/9fc64686bc5bffa2103f698490ab04c62567c10d","head":{"label":"rstudio:feature/pub-from-editor","ref":"feature/pub-from-editor","sha":"9fc64686bc5bffa2103f698490ab04c62567c10d","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":1147463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDYz","name":"rstudio","full_name":"rstudio/rstudio","owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/rstudio","description":"RStudio is an integrated development environment (IDE) for R","fork":false,"url":"https://api.github.com/repos/rstudio/rstudio","forks_url":"https://api.github.com/repos/rstudio/rstudio/forks","keys_url":"https://api.github.com/repos/rstudio/rstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/rstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/rstudio/teams","hooks_url":"https://api.github.com/repos/rstudio/rstudio/hooks","issue_events_url":"https://api.github.com/repos/rstudio/rstudio/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/rstudio/events","assignees_url":"https://api.github.com/repos/rstudio/rstudio/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/rstudio/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/rstudio/tags","blobs_url":"https://api.github.com/repos/rstudio/rstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/rstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/rstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/rstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/rstudio/languages","stargazers_url":"https://api.github.com/repos/rstudio/rstudio/stargazers","contributors_url":"https://api.github.com/repos/rstudio/rstudio/contributors","subscribers_url":"https://api.github.com/repos/rstudio/rstudio/subscribers","subscription_url":"https://api.github.com/repos/rstudio/rstudio/subscription","commits_url":"https://api.github.com/repos/rstudio/rstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/rstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/rstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/rstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/rstudio/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/rstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/rstudio/merges","archive_url":"https://api.github.com/repos/rstudio/rstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/rstudio/downloads","issues_url":"https://api.github.com/repos/rstudio/rstudio/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/rstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/rstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/rstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/rstudio/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/rstudio/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/rstudio/deployments","created_at":"2010-12-07T19:10:25Z","updated_at":"2018-08-06T13:06:21Z","pushed_at":"2018-08-06T00:49:32Z","git_url":"git://github.com/rstudio/rstudio.git","ssh_url":"git@github.com:rstudio/rstudio.git","clone_url":"https://github.com/rstudio/rstudio.git","svn_url":"https://github.com/rstudio/rstudio","homepage":"https://www.rstudio.com/products/rstudio/","size":98153,"stargazers_count":2360,"watchers_count":2360,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":598,"mirror_url":null,"archived":false,"open_issues_count":698,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":598,"open_issues":698,"watchers":2360,"default_branch":"master"}},"base":{"label":"rstudio:master","ref":"master","sha":"68d30dbbaada445f55519c5ccf00dd934b825b11","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":1147463,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3NDYz","name":"rstudio","full_name":"rstudio/rstudio","owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/rstudio","description":"RStudio is an integrated development environment (IDE) for R","fork":false,"url":"https://api.github.com/repos/rstudio/rstudio","forks_url":"https://api.github.com/repos/rstudio/rstudio/forks","keys_url":"https://api.github.com/repos/rstudio/rstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/rstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/rstudio/teams","hooks_url":"https://api.github.com/repos/rstudio/rstudio/hooks","issue_events_url":"https://api.github.com/repos/rstudio/rstudio/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/rstudio/events","assignees_url":"https://api.github.com/repos/rstudio/rstudio/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/rstudio/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/rstudio/tags","blobs_url":"https://api.github.com/repos/rstudio/rstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/rstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/rstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/rstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/rstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/rstudio/languages","stargazers_url":"https://api.github.com/repos/rstudio/rstudio/stargazers","contributors_url":"https://api.github.com/repos/rstudio/rstudio/contributors","subscribers_url":"https://api.github.com/repos/rstudio/rstudio/subscribers","subscription_url":"https://api.github.com/repos/rstudio/rstudio/subscription","commits_url":"https://api.github.com/repos/rstudio/rstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/rstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/rstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/rstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/rstudio/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/rstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/rstudio/merges","archive_url":"https://api.github.com/repos/rstudio/rstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/rstudio/downloads","issues_url":"https://api.github.com/repos/rstudio/rstudio/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/rstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/rstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/rstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/rstudio/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/rstudio/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/rstudio/deployments","created_at":"2010-12-07T19:10:25Z","updated_at":"2018-08-06T13:06:21Z","pushed_at":"2018-08-06T00:49:32Z","git_url":"git://github.com/rstudio/rstudio.git","ssh_url":"git@github.com:rstudio/rstudio.git","clone_url":"https://github.com/rstudio/rstudio.git","svn_url":"https://github.com/rstudio/rstudio","homepage":"https://www.rstudio.com/products/rstudio/","size":98153,"stargazers_count":2360,"watchers_count":2360,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":598,"mirror_url":null,"archived":false,"open_issues_count":698,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":598,"open_issues":698,"watchers":2360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3266"},"html":{"href":"https://github.com/rstudio/rstudio/pull/3266"},"issue":{"href":"https://api.github.com/repos/rstudio/rstudio/issues/3266"},"comments":{"href":"https://api.github.com/repos/rstudio/rstudio/issues/3266/comments"},"review_comments":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3266/comments"},"review_comment":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rstudio/rstudio/pulls/3266/commits"},"statuses":{"href":"https://api.github.com/repos/rstudio/rstudio/statuses/9fc64686bc5bffa2103f698490ab04c62567c10d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmcphers"}}