{"action":"closed","number":20638,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20638","id":187000116,"html_url":"https://github.com/nodejs/node/pull/20638","diff_url":"https://github.com/nodejs/node/pull/20638.diff","patch_url":"https://github.com/nodejs/node/pull/20638.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20638","number":20638,"state":"closed","locked":false,"title":"test: add tests for fsPromises.truncate and FileHandle.truncate","user":{"login":"shisama","id":9845816,"avatar_url":"https://avatars0.githubusercontent.com/u/9845816?v=4","gravatar_id":"","url":"https://api.github.com/users/shisama","html_url":"https://github.com/shisama","followers_url":"https://api.github.com/users/shisama/followers","following_url":"https://api.github.com/users/shisama/following{/other_user}","gists_url":"https://api.github.com/users/shisama/gists{/gist_id}","starred_url":"https://api.github.com/users/shisama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shisama/subscriptions","organizations_url":"https://api.github.com/users/shisama/orgs","repos_url":"https://api.github.com/users/shisama/repos","events_url":"https://api.github.com/users/shisama/events{/privacy}","received_events_url":"https://api.github.com/users/shisama/received_events","type":"User","site_admin":false},"body":"To increase test coverage, added tests for fsPromises.truncate\r\nand FileHandle.truncate.\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-05-09T18:17:20Z","updated_at":"2018-05-30T17:09:17Z","closed_at":"2018-05-30T17:09:17Z","merged_at":null,"merge_commit_sha":"a7fe1983f485df7de9d4d064ea18e80116f61038","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20638/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20638/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20638/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/a35a91cea6e2ec66e6c8c5b1aa1aee58d3a4dee2","head":{"label":"shisama:test-fs-promises-truncate","ref":"test-fs-promises-truncate","sha":"a35a91cea6e2ec66e6c8c5b1aa1aee58d3a4dee2","user":{"login":"shisama","id":9845816,"avatar_url":"https://avatars0.githubusercontent.com/u/9845816?v=4","gravatar_id":"","url":"https://api.github.com/users/shisama","html_url":"https://github.com/shisama","followers_url":"https://api.github.com/users/shisama/followers","following_url":"https://api.github.com/users/shisama/following{/other_user}","gists_url":"https://api.github.com/users/shisama/gists{/gist_id}","starred_url":"https://api.github.com/users/shisama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shisama/subscriptions","organizations_url":"https://api.github.com/users/shisama/orgs","repos_url":"https://api.github.com/users/shisama/repos","events_url":"https://api.github.com/users/shisama/events{/privacy}","received_events_url":"https://api.github.com/users/shisama/received_events","type":"User","site_admin":false},"repo":{"id":131617462,"name":"node","full_name":"shisama/node","owner":{"login":"shisama","id":9845816,"avatar_url":"https://avatars0.githubusercontent.com/u/9845816?v=4","gravatar_id":"","url":"https://api.github.com/users/shisama","html_url":"https://github.com/shisama","followers_url":"https://api.github.com/users/shisama/followers","following_url":"https://api.github.com/users/shisama/following{/other_user}","gists_url":"https://api.github.com/users/shisama/gists{/gist_id}","starred_url":"https://api.github.com/users/shisama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shisama/subscriptions","organizations_url":"https://api.github.com/users/shisama/orgs","repos_url":"https://api.github.com/users/shisama/repos","events_url":"https://api.github.com/users/shisama/events{/privacy}","received_events_url":"https://api.github.com/users/shisama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shisama/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/shisama/node","forks_url":"https://api.github.com/repos/shisama/node/forks","keys_url":"https://api.github.com/repos/shisama/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shisama/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shisama/node/teams","hooks_url":"https://api.github.com/repos/shisama/node/hooks","issue_events_url":"https://api.github.com/repos/shisama/node/issues/events{/number}","events_url":"https://api.github.com/repos/shisama/node/events","assignees_url":"https://api.github.com/repos/shisama/node/assignees{/user}","branches_url":"https://api.github.com/repos/shisama/node/branches{/branch}","tags_url":"https://api.github.com/repos/shisama/node/tags","blobs_url":"https://api.github.com/repos/shisama/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shisama/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shisama/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/shisama/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shisama/node/statuses/{sha}","languages_url":"https://api.github.com/repos/shisama/node/languages","stargazers_url":"https://api.github.com/repos/shisama/node/stargazers","contributors_url":"https://api.github.com/repos/shisama/node/contributors","subscribers_url":"https://api.github.com/repos/shisama/node/subscribers","subscription_url":"https://api.github.com/repos/shisama/node/subscription","commits_url":"https://api.github.com/repos/shisama/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/shisama/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/shisama/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/shisama/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/shisama/node/contents/{+path}","compare_url":"https://api.github.com/repos/shisama/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shisama/node/merges","archive_url":"https://api.github.com/repos/shisama/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shisama/node/downloads","issues_url":"https://api.github.com/repos/shisama/node/issues{/number}","pulls_url":"https://api.github.com/repos/shisama/node/pulls{/number}","milestones_url":"https://api.github.com/repos/shisama/node/milestones{/number}","notifications_url":"https://api.github.com/repos/shisama/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shisama/node/labels{/name}","releases_url":"https://api.github.com/repos/shisama/node/releases{/id}","deployments_url":"https://api.github.com/repos/shisama/node/deployments","created_at":"2018-04-30T16:08:03Z","updated_at":"2018-05-30T15:04:51Z","pushed_at":"2018-05-30T15:10:34Z","git_url":"git://github.com/shisama/node.git","ssh_url":"git@github.com:shisama/node.git","clone_url":"https://github.com/shisama/node.git","svn_url":"https://github.com/shisama/node","homepage":"https://nodejs.org","size":377399,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8fac1d910f3b45fb4ee0479a0d565b564a08b35b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-05-30T17:07:59Z","pushed_at":"2018-05-30T17:09:10Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":378860,"stargazers_count":49435,"watchers_count":49435,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10416,"mirror_url":null,"archived":false,"open_issues_count":748,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10416,"open_issues":748,"watchers":49435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20638"},"html":{"href":"https://github.com/nodejs/node/pull/20638"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20638"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20638/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20638/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20638/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/a35a91cea6e2ec66e6c8c5b1aa1aee58d3a4dee2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":30,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"BridgeAR"}}