{"action":"created","issue":{"url":"https://api.github.com/repos/google/go-cloud/issues/834","repository_url":"https://api.github.com/repos/google/go-cloud","labels_url":"https://api.github.com/repos/google/go-cloud/issues/834/labels{/name}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/834/comments","events_url":"https://api.github.com/repos/google/go-cloud/issues/834/events","html_url":"https://github.com/google/go-cloud/pull/834","id":385746293,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjQ1NDA3","number":834,"title":"internal/pubsub/drivertest: minor improvements","user":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-11-29T13:52:23Z","updated_at":"2018-11-29T17:17:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/834","html_url":"https://github.com/google/go-cloud/pull/834","diff_url":"https://github.com/google/go-cloud/pull/834.diff","patch_url":"https://github.com/google/go-cloud/pull/834.patch"},"body":"- Make the test table-driven, allowing harness creation/close to happen in one place.\n\n- Remove the HarnessMaker type.\n\n- Remove the testing.T arg from the harness maker (it can just return an error).\n\n- Change empty slices to nil slices (more idiomatic)."},"comment":{"url":"https://api.github.com/repos/google/go-cloud/issues/comments/442917778","html_url":"https://github.com/google/go-cloud/pull/834#issuecomment-442917778","issue_url":"https://api.github.com/repos/google/go-cloud/issues/834","id":442917778,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjkxNzc3OA==","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T17:17:17Z","updated_at":"2018-11-29T17:17:17Z","author_association":"CONTRIBUTOR","body":"Please take a look at `blob` or `runtimevar` conformance tests; this code follows the same pattern. Consistency is good, so if you see something to be improved, it should be changed for all 3.\r\n\r\nHowever, there are good reasons for most of the things you've changed. Until `pubsub` has a working driver implementation using record/replay, it may not be obvious.\r\n\r\n> * Make the test table-driven, allowing harness creation/close to happen in one place.\r\n\r\nThis doesn't work well for tests with record/replay; the harness is recreated each time to allow for a separate record/replay file per test.\r\n\r\n> * Remove the HarnessMaker type.\r\n\r\nSame.\r\n\r\n> * Remove the testing.T arg from the harness maker (it can just return an error).\r\n\r\nThe record/replay utilities we have need a `testing.T` (e.g., so they can fail the test during replay if no matching request is found).\r\n\r\n> * Change empty slices to nil slices (more idiomatic).\r\n\r\nThis seems fine, separate PR?"}}
{"actor":{"display_login":"vangent"}}