{"action":"created","comment":{"url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments/173940767","pull_request_review_id":103211339,"id":173940767,"diff_hunk":"@@ -1,20 +1,31 @@\n package net.squanchy.service.firestore.injection\n \n+import com.google.firebase.auth.FirebaseAuth\n import com.google.firebase.firestore.FirebaseFirestore\n import dagger.Module\n import dagger.Provides\n import net.squanchy.injection.ApplicationLifecycle\n+import net.squanchy.service.firestore.FirebaseAuthService\n import net.squanchy.service.firestore.FirestoreDbService\n \n @Module\n class FirestoreModule {","path":"app/src/main/java/net/squanchy/service/firestore/injection/FirestoreModule.kt","position":12,"original_position":12,"commit_id":"95d568d20f2cf22b58d6e1bfb3e6b4f00737f76d","original_commit_id":"a48adcb10a23be5f73320bbbf84a2b4b9362137b","user":{"login":"fourlastor","id":1263058,"avatar_url":"https://avatars1.githubusercontent.com/u/1263058?v=4","gravatar_id":"","url":"https://api.github.com/users/fourlastor","html_url":"https://github.com/fourlastor","followers_url":"https://api.github.com/users/fourlastor/followers","following_url":"https://api.github.com/users/fourlastor/following{/other_user}","gists_url":"https://api.github.com/users/fourlastor/gists{/gist_id}","starred_url":"https://api.github.com/users/fourlastor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fourlastor/subscriptions","organizations_url":"https://api.github.com/users/fourlastor/orgs","repos_url":"https://api.github.com/users/fourlastor/repos","events_url":"https://api.github.com/users/fourlastor/events{/privacy}","received_events_url":"https://api.github.com/users/fourlastor/received_events","type":"User","site_admin":false},"body":"probably the best thing is to have everything inside a `firebase` package (which is the 3rd party offering the services) and then we'll have `FirestoreDbService` (which is the particular firebase service we're using)","created_at":"2018-03-12T20:45:39Z","updated_at":"2018-03-12T20:48:31Z","html_url":"https://github.com/squanchy-dev/squanchy-android/pull/475#discussion_r173940767","pull_request_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments/173940767"},"html":{"href":"https://github.com/squanchy-dev/squanchy-android/pull/475#discussion_r173940767"},"pull_request":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475","id":174479732,"html_url":"https://github.com/squanchy-dev/squanchy-android/pull/475","diff_url":"https://github.com/squanchy-dev/squanchy-android/pull/475.diff","patch_url":"https://github.com/squanchy-dev/squanchy-android/pull/475.patch","issue_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/475","number":475,"state":"open","locked":false,"title":"Firestore/cleanup","user":{"login":"quiro91","id":1331440,"avatar_url":"https://avatars2.githubusercontent.com/u/1331440?v=4","gravatar_id":"","url":"https://api.github.com/users/quiro91","html_url":"https://github.com/quiro91","followers_url":"https://api.github.com/users/quiro91/followers","following_url":"https://api.github.com/users/quiro91/following{/other_user}","gists_url":"https://api.github.com/users/quiro91/gists{/gist_id}","starred_url":"https://api.github.com/users/quiro91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quiro91/subscriptions","organizations_url":"https://api.github.com/users/quiro91/orgs","repos_url":"https://api.github.com/users/quiro91/repos","events_url":"https://api.github.com/users/quiro91/events{/privacy}","received_events_url":"https://api.github.com/users/quiro91/received_events","type":"User","site_admin":false},"body":"## Problem\r\n\r\nAfter moving from the RTD to Firestore there's a bunch of stuff we need to clean up a bit\r\n\r\n## Solution\r\n\r\nClean it up. This is the first of two PRs to address this issue\r\n\r\n### Paired with \r\n\r\nNobody\r\n","created_at":"2018-03-12T20:04:55Z","updated_at":"2018-03-12T20:48:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e42f1f687347dc9252723fa3ba7fe077125ab89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475/commits","review_comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475/comments","review_comment_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/475/comments","statuses_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/95d568d20f2cf22b58d6e1bfb3e6b4f00737f76d","head":{"label":"squanchy-dev:firestore/cleanup","ref":"firestore/cleanup","sha":"95d568d20f2cf22b58d6e1bfb3e6b4f00737f76d","user":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars1.githubusercontent.com/u/27221069?v=4","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":72942055,"name":"squanchy-android","full_name":"squanchy-dev/squanchy-android","owner":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars1.githubusercontent.com/u/27221069?v=4","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squanchy-dev/squanchy-android","description":"Open source Android app for your conferences","fork":false,"url":"https://api.github.com/repos/squanchy-dev/squanchy-android","forks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/forks","keys_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/teams","hooks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/hooks","issue_events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/events{/number}","events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/events","assignees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/assignees{/user}","branches_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/branches{/branch}","tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/tags","blobs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/{sha}","languages_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/languages","stargazers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/stargazers","contributors_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contributors","subscribers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscribers","subscription_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscription","commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contents/{+path}","compare_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/merges","archive_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/downloads","issues_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues{/number}","pulls_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls{/number}","milestones_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/milestones{/number}","notifications_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/labels{/name}","releases_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/releases{/id}","deployments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/deployments","created_at":"2016-11-05T17:26:17Z","updated_at":"2018-03-09T10:30:34Z","pushed_at":"2018-03-12T20:43:39Z","git_url":"git://github.com/squanchy-dev/squanchy-android.git","ssh_url":"git@github.com:squanchy-dev/squanchy-android.git","clone_url":"https://github.com/squanchy-dev/squanchy-android.git","svn_url":"https://github.com/squanchy-dev/squanchy-android","homepage":"","size":23485,"stargazers_count":141,"watchers_count":141,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":31,"open_issues":43,"watchers":141,"default_branch":"develop"}},"base":{"label":"squanchy-dev:feature-move-to-firestore","ref":"feature-move-to-firestore","sha":"4328c2fc55eefafa5559dccf96a627779bb39a81","user":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars1.githubusercontent.com/u/27221069?v=4","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":72942055,"name":"squanchy-android","full_name":"squanchy-dev/squanchy-android","owner":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars1.githubusercontent.com/u/27221069?v=4","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squanchy-dev/squanchy-android","description":"Open source Android app for your conferences","fork":false,"url":"https://api.github.com/repos/squanchy-dev/squanchy-android","forks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/forks","keys_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/teams","hooks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/hooks","issue_events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/events{/number}","events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/events","assignees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/assignees{/user}","branches_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/branches{/branch}","tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/tags","blobs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/{sha}","languages_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/languages","stargazers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/stargazers","contributors_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contributors","subscribers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscribers","subscription_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscription","commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contents/{+path}","compare_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/merges","archive_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/downloads","issues_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues{/number}","pulls_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls{/number}","milestones_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/milestones{/number}","notifications_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/labels{/name}","releases_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/releases{/id}","deployments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/deployments","created_at":"2016-11-05T17:26:17Z","updated_at":"2018-03-09T10:30:34Z","pushed_at":"2018-03-12T20:43:39Z","git_url":"git://github.com/squanchy-dev/squanchy-android.git","ssh_url":"git@github.com:squanchy-dev/squanchy-android.git","clone_url":"https://github.com/squanchy-dev/squanchy-android.git","svn_url":"https://github.com/squanchy-dev/squanchy-android","homepage":"","size":23485,"stargazers_count":141,"watchers_count":141,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":31,"open_issues":43,"watchers":141,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475"},"html":{"href":"https://github.com/squanchy-dev/squanchy-android/pull/475"},"issue":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/475"},"comments":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/95d568d20f2cf22b58d6e1bfb3e6b4f00737f76d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fourlastor"}}