{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/195004143","pull_request_review_id":128283430,"id":195004143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTAwNDE0Mw==","diff_hunk":"@@ -433,5 +433,19 @@ private static RemoteInstanceSetting[] GetRemoteInstances()\n             }\n             return new RemoteInstanceSetting[0];\n         }\n+\n+        static string Subscope(string address)","path":"src/ServiceControl/Infrastructure/Settings/Settings.cs","position":126,"original_position":126,"commit_id":"a7a07ea347a328789d8d6addc539ffbdaa74dc4b","original_commit_id":"9be162cc6b38262dc1ed5104c5da423984470e0c","user":{"login":"SzymonPobiega","id":163318,"node_id":"MDQ6VXNlcjE2MzMxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/163318?v=4","gravatar_id":"","url":"https://api.github.com/users/SzymonPobiega","html_url":"https://github.com/SzymonPobiega","followers_url":"https://api.github.com/users/SzymonPobiega/followers","following_url":"https://api.github.com/users/SzymonPobiega/following{/other_user}","gists_url":"https://api.github.com/users/SzymonPobiega/gists{/gist_id}","starred_url":"https://api.github.com/users/SzymonPobiega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzymonPobiega/subscriptions","organizations_url":"https://api.github.com/users/SzymonPobiega/orgs","repos_url":"https://api.github.com/users/SzymonPobiega/repos","events_url":"https://api.github.com/users/SzymonPobiega/events{/privacy}","received_events_url":"https://api.github.com/users/SzymonPobiega/received_events","type":"User","site_admin":false},"body":"In V5 there was not translation. It has been introduced in V6. Here's the problem:\r\n * If we treat the values stored by SCMU/user as *transport address* then we allow various funny characters there i.e. SQL transport can use multiple `@` e.g. `myQueue@mySchema@myCatalog`. It would be impossible to figure out, for any transport, where to \"inject\" the subscope.\r\n * If we treat the values stored by SMU as *logical endpoint name* then we can use the `Subscope` in `LogicalAddress` and then employ the transport to translate. The downside is that you can't connect SC to any given non-standard catalog (in SQL transport)\r\n\r\nI think that I like the second option more as parsing the transport-specific address string is dangerous. ","created_at":"2018-06-13T08:58:36Z","updated_at":"2018-06-13T08:58:36Z","html_url":"https://github.com/Particular/ServiceControl/pull/1186#discussion_r195004143","pull_request_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/195004143"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/1186#discussion_r195004143"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186"}},"in_reply_to_id":194998137},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186","id":194509393,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTA5Mzkz","html_url":"https://github.com/Particular/ServiceControl/pull/1186","diff_url":"https://github.com/Particular/ServiceControl/pull/1186.diff","patch_url":"https://github.com/Particular/ServiceControl/pull/1186.patch","issue_url":"https://api.github.com/repos/Particular/ServiceControl/issues/1186","number":1186,"state":"open","locked":false,"title":"Settings","user":{"login":"danielmarbach","id":174258,"node_id":"MDQ6VXNlcjE3NDI1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/174258?v=4","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-13T08:37:07Z","updated_at":"2018-06-13T08:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6ab2a65f4235ca7a0e7fb74f3274f2ba03ebd1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikeminutillo","id":124014,"node_id":"MDQ6VXNlcjEyNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/124014?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeminutillo","html_url":"https://github.com/mikeminutillo","followers_url":"https://api.github.com/users/mikeminutillo/followers","following_url":"https://api.github.com/users/mikeminutillo/following{/other_user}","gists_url":"https://api.github.com/users/mikeminutillo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeminutillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeminutillo/subscriptions","organizations_url":"https://api.github.com/users/mikeminutillo/orgs","repos_url":"https://api.github.com/users/mikeminutillo/repos","events_url":"https://api.github.com/users/mikeminutillo/events{/privacy}","received_events_url":"https://api.github.com/users/mikeminutillo/received_events","type":"User","site_admin":false},{"login":"SzymonPobiega","id":163318,"node_id":"MDQ6VXNlcjE2MzMxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/163318?v=4","gravatar_id":"","url":"https://api.github.com/users/SzymonPobiega","html_url":"https://github.com/SzymonPobiega","followers_url":"https://api.github.com/users/SzymonPobiega/followers","following_url":"https://api.github.com/users/SzymonPobiega/following{/other_user}","gists_url":"https://api.github.com/users/SzymonPobiega/gists{/gist_id}","starred_url":"https://api.github.com/users/SzymonPobiega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzymonPobiega/subscriptions","organizations_url":"https://api.github.com/users/SzymonPobiega/orgs","repos_url":"https://api.github.com/users/SzymonPobiega/repos","events_url":"https://api.github.com/users/SzymonPobiega/events{/privacy}","received_events_url":"https://api.github.com/users/SzymonPobiega/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/issues/1186/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/a7a07ea347a328789d8d6addc539ffbdaa74dc4b","head":{"label":"Particular:settings","ref":"settings","sha":"a7a07ea347a328789d8d6addc539ffbdaa74dc4b","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":7913469,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzNDY5","name":"ServiceControl","full_name":"Particular/ServiceControl","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl","description":"Backend for ServiceInsight and ServicePulse","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl","forks_url":"https://api.github.com/repos/Particular/ServiceControl/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl/deployments","created_at":"2013-01-30T11:42:44Z","updated_at":"2018-06-11T07:49:25Z","pushed_at":"2018-06-13T08:45:01Z","git_url":"git://github.com/Particular/ServiceControl.git","ssh_url":"git@github.com:Particular/ServiceControl.git","clone_url":"https://github.com/Particular/ServiceControl.git","svn_url":"https://github.com/Particular/ServiceControl","homepage":"https://docs.particular.net/servicecontrol/","size":48219,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":87,"watchers":18,"default_branch":"master"}},"base":{"label":"Particular:nsb-upgrade","ref":"nsb-upgrade","sha":"b72cba9c40a49ae6598edd8fdc757b3c921eb4ba","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":7913469,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzNDY5","name":"ServiceControl","full_name":"Particular/ServiceControl","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl","description":"Backend for ServiceInsight and ServicePulse","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl","forks_url":"https://api.github.com/repos/Particular/ServiceControl/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl/deployments","created_at":"2013-01-30T11:42:44Z","updated_at":"2018-06-11T07:49:25Z","pushed_at":"2018-06-13T08:45:01Z","git_url":"git://github.com/Particular/ServiceControl.git","ssh_url":"git@github.com:Particular/ServiceControl.git","clone_url":"https://github.com/Particular/ServiceControl.git","svn_url":"https://github.com/Particular/ServiceControl","homepage":"https://docs.particular.net/servicecontrol/","size":48219,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":87,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/1186"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceControl/issues/1186"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceControl/issues/1186/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1186/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceControl/statuses/a7a07ea347a328789d8d6addc539ffbdaa74dc4b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SzymonPobiega"}}