{"action":"created","issue":{"url":"https://api.github.com/repos/larryb100/pwp-capstones/issues/1","repository_url":"https://api.github.com/repos/larryb100/pwp-capstones","labels_url":"https://api.github.com/repos/larryb100/pwp-capstones/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/larryb100/pwp-capstones/issues/1/comments","events_url":"https://api.github.com/repos/larryb100/pwp-capstones/issues/1/events","html_url":"https://github.com/larryb100/pwp-capstones/issues/1","id":341731215,"node_id":"MDU6SXNzdWUzNDE3MzEyMTU=","number":1,"title":"Project Review","user":{"login":"jordanwillis","id":7652259,"node_id":"MDQ6VXNlcjc2NTIyNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7652259?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanwillis","html_url":"https://github.com/jordanwillis","followers_url":"https://api.github.com/users/jordanwillis/followers","following_url":"https://api.github.com/users/jordanwillis/following{/other_user}","gists_url":"https://api.github.com/users/jordanwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanwillis/subscriptions","organizations_url":"https://api.github.com/users/jordanwillis/orgs","repos_url":"https://api.github.com/users/jordanwillis/repos","events_url":"https://api.github.com/users/jordanwillis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanwillis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-17T01:17:40Z","updated_at":"2018-07-17T05:53:47Z","closed_at":null,"author_association":"NONE","body":" ## Rubric Score\r\n \r\n### Criteria 1: Valid Python Code\r\n* _Score Level:_ 4/4\r\n* _Comment(s):_ Great job writing valid code, I didn't encounter any errors or issues!\r\n \r\n### Criteria 2: Implementation of Project Requirements\r\n* _Score Level:_ 3/4\r\n* _Comment(s):_ You did a nice job implementing the project requirements!  I found a couple of small issues that I described below.\r\n\r\n1. Don't forget that sentences can end in other characters beyond just periods in your `get_average_sentence_length` function (for example ? or !).  Therefore, you should account for these in your logic as well like this.\r\n\r\n``` python\r\ndef get_average_sentence_length(text):\r\n    no_questions = text.replace('?', '.')\r\n    no_exclaim = no_questions.replace('!', '.')\r\n    sentences = no_exclaim.split('.')\r\n    sentence_lengths = []\r\n    \r\n    for sentence in sentences:\r\n        words = sentence.split()\r\n        sentence_lengths.append(len(words))\r\n\r\n    average = sum(sentence_lengths) / len(sentence_lengths)\r\n    return average\r\n```\r\n\r\n2. Don't forget you need to divide by 3 in your `find_text_similarity` function before returning.  Your current implementation is adding the 3 values together but not performing the division.  The reason for the division is because we need to take an average of each of the different similarity scores.\r\n \r\n### Criteria 3: Software Architecture\r\n* _Score Level:_ 4/4\r\n* _Comment(s):_ Great work, you split everything up into proper classes and functions!\r\n \r\n### Criteria 4: Uses Python Language Features\r\n* _Score Level:_ 4/4\r\n* _Comment(s):_ Great work effectively using many python built-in functions and language features!  I especially liked your very nice `prepare_data` implementation!  I had not thought of that approach yet, plus one-liners that are easy to read and make sense are always slick.\r\n\r\n### Criteria 5: Produces Accurate Output\r\n* _Score Level:_ 3/4\r\n* _Comment(s):_ Congratulations, you found the correct murderer!  Even though you identified the correct person your output was technically incorrect due to the division problem in your `find_text_similarity`.  Here is what the correct answers were.\r\n\r\n```\r\nLily Trebuchet \r\n0.553127686544467\r\nMyrtle Beech \r\n0.13770600101747985\r\nGregg T. Fishy \r\n0.43826902657493294\r\n```\r\n\r\nIf you think about it, we would not expect an answer to ever be greater than 1 because even if you compared the same text together, the best similarity score that they could have is 1 (e.g. 100%).\r\n \r\n### Overall Score: 18/20\r\nOverall you did a fantastic job on this project and demonstrated that you learned a lot in this course!  Keep up the great work!!\r\n"},"comment":{"url":"https://api.github.com/repos/larryb100/pwp-capstones/issues/comments/405467789","html_url":"https://github.com/larryb100/pwp-capstones/issues/1#issuecomment-405467789","issue_url":"https://api.github.com/repos/larryb100/pwp-capstones/issues/1","id":405467789,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTQ2Nzc4OQ==","user":{"login":"jordanwillis","id":7652259,"node_id":"MDQ6VXNlcjc2NTIyNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7652259?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanwillis","html_url":"https://github.com/jordanwillis","followers_url":"https://api.github.com/users/jordanwillis/followers","following_url":"https://api.github.com/users/jordanwillis/following{/other_user}","gists_url":"https://api.github.com/users/jordanwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanwillis/subscriptions","organizations_url":"https://api.github.com/users/jordanwillis/orgs","repos_url":"https://api.github.com/users/jordanwillis/repos","events_url":"https://api.github.com/users/jordanwillis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanwillis/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T05:53:47Z","updated_at":"2018-07-17T05:53:47Z","author_association":"NONE","body":"No worries, that pressure can unfortunately get in the way sometimes!  The good thing is that it was just an omission mistake (e.g. you forgot to add the division) and not an implementation or coding mistake! 👍 "}}
{"actor":{"display_login":"jordanwillis"}}