{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments/209111635","pull_request_review_id":145065126,"id":209111635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTExMTYzNQ==","diff_hunk":"@@ -22,10 +22,12 @@\n \n import com.google.cloud.pubsub.v1.MessageReceiver;\n import com.google.cloud.pubsub.v1.Subscriber;\n+import com.google.protobuf.Empty;","path":"spring-cloud-gcp-pubsub/src/main/java/org/springframework/cloud/gcp/pubsub/core/subscriber/PubSubSubscriberOperations.java","position":4,"original_position":4,"commit_id":"4b3de573782087e46642faa1a13bc10c956cca65","original_commit_id":"4b3de573782087e46642faa1a13bc10c956cca65","user":{"login":"dhoard","id":19376470,"node_id":"MDQ6VXNlcjE5Mzc2NDcw","avatar_url":"https://avatars0.githubusercontent.com/u/19376470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhoard","html_url":"https://github.com/dhoard","followers_url":"https://api.github.com/users/dhoard/followers","following_url":"https://api.github.com/users/dhoard/following{/other_user}","gists_url":"https://api.github.com/users/dhoard/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoard/subscriptions","organizations_url":"https://api.github.com/users/dhoard/orgs","repos_url":"https://api.github.com/users/dhoard/repos","events_url":"https://api.github.com/users/dhoard/events{/privacy}","received_events_url":"https://api.github.com/users/dhoard/received_events","type":"User","site_admin":false},"body":"Makes sense to me.","created_at":"2018-08-09T23:46:40Z","updated_at":"2018-08-09T23:46:41Z","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/859#discussion_r209111635","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments/209111635"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-gcp/pull/859#discussion_r209111635"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859"}},"in_reply_to_id":209077044},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859","id":201184306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTg0MzA2","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/859","diff_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/859.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/859.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/859","number":859,"state":"open","locked":false,"title":"Added the ability to use asynchronous acknowledgement [WIP]","user":{"login":"dhoard","id":19376470,"node_id":"MDQ6VXNlcjE5Mzc2NDcw","avatar_url":"https://avatars0.githubusercontent.com/u/19376470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhoard","html_url":"https://github.com/dhoard","followers_url":"https://api.github.com/users/dhoard/followers","following_url":"https://api.github.com/users/dhoard/following{/other_user}","gists_url":"https://api.github.com/users/dhoard/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoard/subscriptions","organizations_url":"https://api.github.com/users/dhoard/orgs","repos_url":"https://api.github.com/users/dhoard/repos","events_url":"https://api.github.com/users/dhoard/events{/privacy}","received_events_url":"https://api.github.com/users/dhoard/received_events","type":"User","site_admin":false},"body":"Added the ability to use asynchronous acknowledgement for use cases\r\nwhere the developer wants maximum performance.\r\n\r\nCloses #739.","created_at":"2018-07-13T04:22:57Z","updated_at":"2018-08-09T23:46:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8da9fb8e8deb0e1ea8a34d3c501c126ce6d9ec2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":925670225,"node_id":"MDU6TGFiZWw5MjU2NzAyMjU=","url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/labels/pubsub","name":"pubsub","color":"efd021","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/859/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/4b3de573782087e46642faa1a13bc10c956cca65","head":{"label":"dhoard:dhoard.739.add-asynchronous-acknowledgement","ref":"dhoard.739.add-asynchronous-acknowledgement","sha":"4b3de573782087e46642faa1a13bc10c956cca65","user":{"login":"dhoard","id":19376470,"node_id":"MDQ6VXNlcjE5Mzc2NDcw","avatar_url":"https://avatars0.githubusercontent.com/u/19376470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhoard","html_url":"https://github.com/dhoard","followers_url":"https://api.github.com/users/dhoard/followers","following_url":"https://api.github.com/users/dhoard/following{/other_user}","gists_url":"https://api.github.com/users/dhoard/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoard/subscriptions","organizations_url":"https://api.github.com/users/dhoard/orgs","repos_url":"https://api.github.com/users/dhoard/repos","events_url":"https://api.github.com/users/dhoard/events{/privacy}","received_events_url":"https://api.github.com/users/dhoard/received_events","type":"User","site_admin":false},"repo":{"id":139048015,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNDgwMTU=","name":"spring-cloud-gcp","full_name":"dhoard/spring-cloud-gcp","owner":{"login":"dhoard","id":19376470,"node_id":"MDQ6VXNlcjE5Mzc2NDcw","avatar_url":"https://avatars0.githubusercontent.com/u/19376470?v=4","gravatar_id":"","url":"https://api.github.com/users/dhoard","html_url":"https://github.com/dhoard","followers_url":"https://api.github.com/users/dhoard/followers","following_url":"https://api.github.com/users/dhoard/following{/other_user}","gists_url":"https://api.github.com/users/dhoard/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoard/subscriptions","organizations_url":"https://api.github.com/users/dhoard/orgs","repos_url":"https://api.github.com/users/dhoard/repos","events_url":"https://api.github.com/users/dhoard/events{/privacy}","received_events_url":"https://api.github.com/users/dhoard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhoard/spring-cloud-gcp","description":"Integration for Google Cloud Platform APIs with Spring","fork":true,"url":"https://api.github.com/repos/dhoard/spring-cloud-gcp","forks_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/forks","keys_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/teams","hooks_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/hooks","issue_events_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/issues/events{/number}","events_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/events","assignees_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/assignees{/user}","branches_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/branches{/branch}","tags_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/tags","blobs_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/statuses/{sha}","languages_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/languages","stargazers_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/stargazers","contributors_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/contributors","subscribers_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/subscribers","subscription_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/subscription","commits_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/contents/{+path}","compare_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/merges","archive_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/downloads","issues_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/issues{/number}","pulls_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/pulls{/number}","milestones_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/milestones{/number}","notifications_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/labels{/name}","releases_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/releases{/id}","deployments_url":"https://api.github.com/repos/dhoard/spring-cloud-gcp/deployments","created_at":"2018-06-28T17:16:13Z","updated_at":"2018-08-08T02:40:40Z","pushed_at":"2018-08-08T02:56:58Z","git_url":"git://github.com/dhoard/spring-cloud-gcp.git","ssh_url":"git@github.com:dhoard/spring-cloud-gcp.git","clone_url":"https://github.com/dhoard/spring-cloud-gcp.git","svn_url":"https://github.com/dhoard/spring-cloud-gcp","homepage":null,"size":3471,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"371616e33e7ba083e722c8d7bcad2fd285f157f3","user":{"login":"spring-cloud","id":7815877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":86105877,"node_id":"MDEwOlJlcG9zaXRvcnk4NjEwNTg3Nw==","name":"spring-cloud-gcp","full_name":"spring-cloud/spring-cloud-gcp","owner":{"login":"spring-cloud","id":7815877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTU4Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp","description":"Integration for Google Cloud Platform APIs with Spring","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/deployments","created_at":"2017-03-24T19:58:20Z","updated_at":"2018-08-09T21:44:32Z","pushed_at":"2018-08-09T21:34:30Z","git_url":"git://github.com/spring-cloud/spring-cloud-gcp.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-gcp.git","clone_url":"https://github.com/spring-cloud/spring-cloud-gcp.git","svn_url":"https://github.com/spring-cloud/spring-cloud-gcp","homepage":null,"size":3424,"stargazers_count":151,"watchers_count":151,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":68,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-gcp/pull/859"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/859"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/4b3de573782087e46642faa1a13bc10c956cca65"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dhoard"}}