{"action":"closed","number":541,"pull_request":{"url":"https://api.github.com/repos/zalando-stups/senza/pulls/541","id":220494778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDk0Nzc4","html_url":"https://github.com/zalando-stups/senza/pull/541","diff_url":"https://github.com/zalando-stups/senza/pull/541.diff","patch_url":"https://github.com/zalando-stups/senza/pull/541.patch","issue_url":"https://api.github.com/repos/zalando-stups/senza/issues/541","number":541,"state":"closed","locked":false,"title":"fixed the user data encoding by using the proper base64","user":{"login":"lmineiro","id":4234681,"node_id":"MDQ6VXNlcjQyMzQ2ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4234681?v=4","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false},"body":"The function `base64.urlsafe_b64encode()` would fail to properly encode the `>` character, as stated in #540 \r\n\r\nThat affected the Elastigroup creation whenever the `>` was present in the user data.\r\n\r\nFor the CloudFormation template the fix was to use the same deferred call to `Fn::Base64`, just [like for the native Auto Scaling Groups](https://github.com/zalando-stups/senza/blob/0b7c7cee8d7c4f1a2bc01c9cc2cad42171292d98/senza/components/taupage_auto_scaling_group.py#L144).\r\n\r\nThe patch command was changed to use the correct `base64.b64encode()` function.","created_at":"2018-10-04T19:42:36Z","updated_at":"2018-10-05T06:48:59Z","closed_at":"2018-10-05T06:48:59Z","merged_at":"2018-10-05T06:48:59Z","merge_commit_sha":"b55e95be3e91e7132b76995090d566461e0243f8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jmcs","id":3719966,"node_id":"MDQ6VXNlcjM3MTk5NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3719966?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcs","html_url":"https://github.com/jmcs","followers_url":"https://api.github.com/users/jmcs/followers","following_url":"https://api.github.com/users/jmcs/following{/other_user}","gists_url":"https://api.github.com/users/jmcs/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcs/subscriptions","organizations_url":"https://api.github.com/users/jmcs/orgs","repos_url":"https://api.github.com/users/jmcs/repos","events_url":"https://api.github.com/users/jmcs/events{/privacy}","received_events_url":"https://api.github.com/users/jmcs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-stups/senza/pulls/541/commits","review_comments_url":"https://api.github.com/repos/zalando-stups/senza/pulls/541/comments","review_comment_url":"https://api.github.com/repos/zalando-stups/senza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-stups/senza/issues/541/comments","statuses_url":"https://api.github.com/repos/zalando-stups/senza/statuses/7e7be9c8c1dec7e7f67f8d17079af31dbf415a40","head":{"label":"lmineiro:fix-user-data-encoding","ref":"fix-user-data-encoding","sha":"7e7be9c8c1dec7e7f67f8d17079af31dbf415a40","user":{"login":"lmineiro","id":4234681,"node_id":"MDQ6VXNlcjQyMzQ2ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4234681?v=4","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false},"repo":{"id":139729901,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3Mjk5MDE=","name":"senza","full_name":"lmineiro/senza","private":false,"owner":{"login":"lmineiro","id":4234681,"node_id":"MDQ6VXNlcjQyMzQ2ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4234681?v=4","gravatar_id":"","url":"https://api.github.com/users/lmineiro","html_url":"https://github.com/lmineiro","followers_url":"https://api.github.com/users/lmineiro/followers","following_url":"https://api.github.com/users/lmineiro/following{/other_user}","gists_url":"https://api.github.com/users/lmineiro/gists{/gist_id}","starred_url":"https://api.github.com/users/lmineiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmineiro/subscriptions","organizations_url":"https://api.github.com/users/lmineiro/orgs","repos_url":"https://api.github.com/users/lmineiro/repos","events_url":"https://api.github.com/users/lmineiro/events{/privacy}","received_events_url":"https://api.github.com/users/lmineiro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lmineiro/senza","description":"Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way","fork":true,"url":"https://api.github.com/repos/lmineiro/senza","forks_url":"https://api.github.com/repos/lmineiro/senza/forks","keys_url":"https://api.github.com/repos/lmineiro/senza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmineiro/senza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmineiro/senza/teams","hooks_url":"https://api.github.com/repos/lmineiro/senza/hooks","issue_events_url":"https://api.github.com/repos/lmineiro/senza/issues/events{/number}","events_url":"https://api.github.com/repos/lmineiro/senza/events","assignees_url":"https://api.github.com/repos/lmineiro/senza/assignees{/user}","branches_url":"https://api.github.com/repos/lmineiro/senza/branches{/branch}","tags_url":"https://api.github.com/repos/lmineiro/senza/tags","blobs_url":"https://api.github.com/repos/lmineiro/senza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmineiro/senza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmineiro/senza/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmineiro/senza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmineiro/senza/statuses/{sha}","languages_url":"https://api.github.com/repos/lmineiro/senza/languages","stargazers_url":"https://api.github.com/repos/lmineiro/senza/stargazers","contributors_url":"https://api.github.com/repos/lmineiro/senza/contributors","subscribers_url":"https://api.github.com/repos/lmineiro/senza/subscribers","subscription_url":"https://api.github.com/repos/lmineiro/senza/subscription","commits_url":"https://api.github.com/repos/lmineiro/senza/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmineiro/senza/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmineiro/senza/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmineiro/senza/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmineiro/senza/contents/{+path}","compare_url":"https://api.github.com/repos/lmineiro/senza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmineiro/senza/merges","archive_url":"https://api.github.com/repos/lmineiro/senza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmineiro/senza/downloads","issues_url":"https://api.github.com/repos/lmineiro/senza/issues{/number}","pulls_url":"https://api.github.com/repos/lmineiro/senza/pulls{/number}","milestones_url":"https://api.github.com/repos/lmineiro/senza/milestones{/number}","notifications_url":"https://api.github.com/repos/lmineiro/senza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmineiro/senza/labels{/name}","releases_url":"https://api.github.com/repos/lmineiro/senza/releases{/id}","deployments_url":"https://api.github.com/repos/lmineiro/senza/deployments","created_at":"2018-07-04T14:03:17Z","updated_at":"2018-09-28T07:22:51Z","pushed_at":"2018-10-04T20:32:55Z","git_url":"git://github.com/lmineiro/senza.git","ssh_url":"git@github.com:lmineiro/senza.git","clone_url":"https://github.com/lmineiro/senza.git","svn_url":"https://github.com/lmineiro/senza","homepage":"https://pypi.python.org/pypi/stups-senza","size":1788,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando-stups:master","ref":"master","sha":"0b7c7cee8d7c4f1a2bc01c9cc2cad42171292d98","user":{"login":"zalando-stups","id":11431876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDMxODc2","avatar_url":"https://avatars1.githubusercontent.com/u/11431876?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"repo":{"id":33120392,"node_id":"MDEwOlJlcG9zaXRvcnkzMzEyMDM5Mg==","name":"senza","full_name":"zalando-stups/senza","private":false,"owner":{"login":"zalando-stups","id":11431876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDMxODc2","avatar_url":"https://avatars1.githubusercontent.com/u/11431876?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando-stups/senza","description":"Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way","fork":false,"url":"https://api.github.com/repos/zalando-stups/senza","forks_url":"https://api.github.com/repos/zalando-stups/senza/forks","keys_url":"https://api.github.com/repos/zalando-stups/senza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-stups/senza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-stups/senza/teams","hooks_url":"https://api.github.com/repos/zalando-stups/senza/hooks","issue_events_url":"https://api.github.com/repos/zalando-stups/senza/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-stups/senza/events","assignees_url":"https://api.github.com/repos/zalando-stups/senza/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-stups/senza/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-stups/senza/tags","blobs_url":"https://api.github.com/repos/zalando-stups/senza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-stups/senza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-stups/senza/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-stups/senza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-stups/senza/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-stups/senza/languages","stargazers_url":"https://api.github.com/repos/zalando-stups/senza/stargazers","contributors_url":"https://api.github.com/repos/zalando-stups/senza/contributors","subscribers_url":"https://api.github.com/repos/zalando-stups/senza/subscribers","subscription_url":"https://api.github.com/repos/zalando-stups/senza/subscription","commits_url":"https://api.github.com/repos/zalando-stups/senza/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-stups/senza/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-stups/senza/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-stups/senza/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-stups/senza/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-stups/senza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-stups/senza/merges","archive_url":"https://api.github.com/repos/zalando-stups/senza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-stups/senza/downloads","issues_url":"https://api.github.com/repos/zalando-stups/senza/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-stups/senza/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-stups/senza/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-stups/senza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-stups/senza/labels{/name}","releases_url":"https://api.github.com/repos/zalando-stups/senza/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-stups/senza/deployments","created_at":"2015-03-30T11:56:30Z","updated_at":"2018-09-28T07:44:24Z","pushed_at":"2018-10-05T06:48:59Z","git_url":"git://github.com/zalando-stups/senza.git","ssh_url":"git@github.com:zalando-stups/senza.git","clone_url":"https://github.com/zalando-stups/senza.git","svn_url":"https://github.com/zalando-stups/senza","homepage":"https://pypi.python.org/pypi/stups-senza","size":1699,"stargazers_count":95,"watchers_count":95,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":69,"open_issues":64,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/541"},"html":{"href":"https://github.com/zalando-stups/senza/pull/541"},"issue":{"href":"https://api.github.com/repos/zalando-stups/senza/issues/541"},"comments":{"href":"https://api.github.com/repos/zalando-stups/senza/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-stups/senza/statuses/7e7be9c8c1dec7e7f67f8d17079af31dbf415a40"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jmcs","id":3719966,"node_id":"MDQ6VXNlcjM3MTk5NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3719966?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcs","html_url":"https://github.com/jmcs","followers_url":"https://api.github.com/users/jmcs/followers","following_url":"https://api.github.com/users/jmcs/following{/other_user}","gists_url":"https://api.github.com/users/jmcs/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcs/subscriptions","organizations_url":"https://api.github.com/users/jmcs/orgs","repos_url":"https://api.github.com/users/jmcs/repos","events_url":"https://api.github.com/users/jmcs/events{/privacy}","received_events_url":"https://api.github.com/users/jmcs/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":40,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"jmcs"}}