{"action":"created","comment":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/184844691","pull_request_review_id":116126449,"id":184844691,"diff_hunk":"@@ -99,7 +104,7 @@ export interface TableProps<T> {\n   expandRowByClick?: boolean;\n   onExpandedRowsChange?: (expandedRowKeys: string[] | number[]) => void;\n   onExpand?: (expanded: boolean, record: T) => void;\n-  onChange?: (pagination: TablePaginationConfig | boolean, filters: string[], sorter: Object) => any;\n+  onChange?: (pagination: TablePaginationConfig | boolean, filters: Record<keyof T, string[]>, sorter: Record<keyof T, SorterResult>) => any;","path":"components/table/interface.tsx","position":19,"original_position":19,"commit_id":"cd69e80a28521bbff609122dc9ab4d7046a7433b","original_commit_id":"cd69e80a28521bbff609122dc9ab4d7046a7433b","user":{"login":"yesmeck","id":465125,"avatar_url":"https://avatars0.githubusercontent.com/u/465125?v=4","gravatar_id":"","url":"https://api.github.com/users/yesmeck","html_url":"https://github.com/yesmeck","followers_url":"https://api.github.com/users/yesmeck/followers","following_url":"https://api.github.com/users/yesmeck/following{/other_user}","gists_url":"https://api.github.com/users/yesmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/yesmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesmeck/subscriptions","organizations_url":"https://api.github.com/users/yesmeck/orgs","repos_url":"https://api.github.com/users/yesmeck/repos","events_url":"https://api.github.com/users/yesmeck/events{/privacy}","received_events_url":"https://api.github.com/users/yesmeck/received_events","type":"User","site_admin":false},"body":"Only one sorter can apply at the same time.","created_at":"2018-04-28T08:05:15Z","updated_at":"2018-04-28T08:05:15Z","html_url":"https://github.com/ant-design/ant-design/pull/10294#discussion_r184844691","pull_request_url":"https://api.github.com/repos/ant-design/ant-design/pulls/10294","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/184844691"},"html":{"href":"https://github.com/ant-design/ant-design/pull/10294#discussion_r184844691"},"pull_request":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10294"}},"in_reply_to_id":184844267},"pull_request":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/10294","id":184763716,"html_url":"https://github.com/ant-design/ant-design/pull/10294","diff_url":"https://github.com/ant-design/ant-design/pull/10294.diff","patch_url":"https://github.com/ant-design/ant-design/pull/10294.patch","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/10294","number":10294,"state":"open","locked":false,"title":"Fix #9859, #9858","user":{"login":"Jack-Works","id":5390719,"avatar_url":"https://avatars3.githubusercontent.com/u/5390719?v=4","gravatar_id":"","url":"https://api.github.com/users/Jack-Works","html_url":"https://github.com/Jack-Works","followers_url":"https://api.github.com/users/Jack-Works/followers","following_url":"https://api.github.com/users/Jack-Works/following{/other_user}","gists_url":"https://api.github.com/users/Jack-Works/gists{/gist_id}","starred_url":"https://api.github.com/users/Jack-Works/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jack-Works/subscriptions","organizations_url":"https://api.github.com/users/Jack-Works/orgs","repos_url":"https://api.github.com/users/Jack-Works/repos","events_url":"https://api.github.com/users/Jack-Works/events{/privacy}","received_events_url":"https://api.github.com/users/Jack-Works/received_events","type":"User","site_admin":false},"body":"First of all, thank you for your contribution! :-)\r\n\r\nPlease makes sure that these checkboxes are checked before submitting your PR, thank you!\r\n\r\n* [x] Make sure that you propose PR to right branch: bugfix for `master`, feature for latest active branch `feature-x.x`.\r\n* [x] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).\r\n* [x] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.\r\n* [x] Rebase before creating a PR to keep commit history clear.\r\n* [x] Add some descriptions and refer relative issues for you PR.\r\n\r\nExtra checklist:\r\n\r\n**if** *isBugFix* **:**\r\n\r\n  * [ ] Make sure that you add at least one unit test for the bug which you had fixed.\r\n\r\n**elif** *isNewFeature* **:**\r\n\r\n  * [ ] Update API docs for the component.\r\n  * [ ] Update/Add demo to demonstrate new feature.\r\n  * [ ] Update TypeScript definition for the component.\r\n  * [ ] Add unit tests for the feature.\r\n","created_at":"2018-04-28T04:36:02Z","updated_at":"2018-04-28T08:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f85b87cae313b37e3f90d5b523754acb03d37a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ant-design/ant-design/pulls/10294/commits","review_comments_url":"https://api.github.com/repos/ant-design/ant-design/pulls/10294/comments","review_comment_url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/10294/comments","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/cd69e80a28521bbff609122dc9ab4d7046a7433b","head":{"label":"Jack-Works:patch-1","ref":"patch-1","sha":"cd69e80a28521bbff609122dc9ab4d7046a7433b","user":{"login":"Jack-Works","id":5390719,"avatar_url":"https://avatars3.githubusercontent.com/u/5390719?v=4","gravatar_id":"","url":"https://api.github.com/users/Jack-Works","html_url":"https://github.com/Jack-Works","followers_url":"https://api.github.com/users/Jack-Works/followers","following_url":"https://api.github.com/users/Jack-Works/following{/other_user}","gists_url":"https://api.github.com/users/Jack-Works/gists{/gist_id}","starred_url":"https://api.github.com/users/Jack-Works/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jack-Works/subscriptions","organizations_url":"https://api.github.com/users/Jack-Works/orgs","repos_url":"https://api.github.com/users/Jack-Works/repos","events_url":"https://api.github.com/users/Jack-Works/events{/privacy}","received_events_url":"https://api.github.com/users/Jack-Works/received_events","type":"User","site_admin":false},"repo":{"id":131372747,"name":"ant-design","full_name":"Jack-Works/ant-design","owner":{"login":"Jack-Works","id":5390719,"avatar_url":"https://avatars3.githubusercontent.com/u/5390719?v=4","gravatar_id":"","url":"https://api.github.com/users/Jack-Works","html_url":"https://github.com/Jack-Works","followers_url":"https://api.github.com/users/Jack-Works/followers","following_url":"https://api.github.com/users/Jack-Works/following{/other_user}","gists_url":"https://api.github.com/users/Jack-Works/gists{/gist_id}","starred_url":"https://api.github.com/users/Jack-Works/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jack-Works/subscriptions","organizations_url":"https://api.github.com/users/Jack-Works/orgs","repos_url":"https://api.github.com/users/Jack-Works/repos","events_url":"https://api.github.com/users/Jack-Works/events{/privacy}","received_events_url":"https://api.github.com/users/Jack-Works/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jack-Works/ant-design","description":"🐜 A UI Design Language","fork":true,"url":"https://api.github.com/repos/Jack-Works/ant-design","forks_url":"https://api.github.com/repos/Jack-Works/ant-design/forks","keys_url":"https://api.github.com/repos/Jack-Works/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jack-Works/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jack-Works/ant-design/teams","hooks_url":"https://api.github.com/repos/Jack-Works/ant-design/hooks","issue_events_url":"https://api.github.com/repos/Jack-Works/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/Jack-Works/ant-design/events","assignees_url":"https://api.github.com/repos/Jack-Works/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/Jack-Works/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/Jack-Works/ant-design/tags","blobs_url":"https://api.github.com/repos/Jack-Works/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jack-Works/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jack-Works/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jack-Works/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jack-Works/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/Jack-Works/ant-design/languages","stargazers_url":"https://api.github.com/repos/Jack-Works/ant-design/stargazers","contributors_url":"https://api.github.com/repos/Jack-Works/ant-design/contributors","subscribers_url":"https://api.github.com/repos/Jack-Works/ant-design/subscribers","subscription_url":"https://api.github.com/repos/Jack-Works/ant-design/subscription","commits_url":"https://api.github.com/repos/Jack-Works/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jack-Works/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jack-Works/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jack-Works/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jack-Works/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/Jack-Works/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jack-Works/ant-design/merges","archive_url":"https://api.github.com/repos/Jack-Works/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jack-Works/ant-design/downloads","issues_url":"https://api.github.com/repos/Jack-Works/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/Jack-Works/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/Jack-Works/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/Jack-Works/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jack-Works/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/Jack-Works/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/Jack-Works/ant-design/deployments","created_at":"2018-04-28T04:29:25Z","updated_at":"2018-04-28T04:29:33Z","pushed_at":"2018-04-28T07:45:23Z","git_url":"git://github.com/Jack-Works/ant-design.git","ssh_url":"git@github.com:Jack-Works/ant-design.git","clone_url":"https://github.com/Jack-Works/ant-design.git","svn_url":"https://github.com/Jack-Works/ant-design","homepage":"http://ant.design","size":239251,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ant-design:master","ref":"master","sha":"8b6488256281a9db62378506e79b040a3d695bea","user":{"login":"ant-design","id":12101536,"avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"name":"ant-design","full_name":"ant-design/ant-design","owner":{"login":"ant-design","id":12101536,"avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-design/ant-design","description":"🐜 A UI Design Language","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2018-04-28T07:56:27Z","pushed_at":"2018-04-28T07:46:29Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"http://ant.design","size":239250,"stargazers_count":27569,"watchers_count":27569,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8191,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8191,"open_issues":204,"watchers":27569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10294"},"html":{"href":"https://github.com/ant-design/ant-design/pull/10294"},"issue":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/10294"},"comments":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/10294/comments"},"review_comments":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10294/comments"},"review_comment":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10294/commits"},"statuses":{"href":"https://api.github.com/repos/ant-design/ant-design/statuses/cd69e80a28521bbff609122dc9ab4d7046a7433b"}},"author_association":"NONE"}}
{"actor":{"display_login":"yesmeck"}}