{"action":"created","issue":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1451","repository_url":"https://api.github.com/repos/gemini-hlsw/ocs","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1451/labels{/name}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1451/comments","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1451/events","html_url":"https://github.com/gemini-hlsw/ocs/pull/1451","id":308012986,"number":1451,"title":"REL-3390: Added Arbitraries, PIO, AlmostEquals, and test cases for GHOST asterisms.","user":{"login":"sraaphorst","id":8795653,"avatar_url":"https://avatars1.githubusercontent.com/u/8795653?v=4","gravatar_id":"","url":"https://api.github.com/users/sraaphorst","html_url":"https://github.com/sraaphorst","followers_url":"https://api.github.com/users/sraaphorst/followers","following_url":"https://api.github.com/users/sraaphorst/following{/other_user}","gists_url":"https://api.github.com/users/sraaphorst/gists{/gist_id}","starred_url":"https://api.github.com/users/sraaphorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sraaphorst/subscriptions","organizations_url":"https://api.github.com/users/sraaphorst/orgs","repos_url":"https://api.github.com/users/sraaphorst/repos","events_url":"https://api.github.com/users/sraaphorst/events{/privacy}","received_events_url":"https://api.github.com/users/sraaphorst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-23T12:35:17Z","updated_at":"2018-03-29T14:13:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1451","html_url":"https://github.com/gemini-hlsw/ocs/pull/1451","diff_url":"https://github.com/gemini-hlsw/ocs/pull/1451.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/1451.patch"},"body":"This PR:\r\n\r\n1. Adds the ability to create `Arbitrary` GHOST asterisms and their components;\r\n2. Adds the `ParamSetCodec` or `ParamCodec` code to write out / read in GHOST asterisms and their components;\r\n3. Adds `AlmostEqual` operations for GHOST asterisms and their components; and\r\n4. Adds `GhostAsterism` testing to `AsterismParamSetCodecSpec`.\r\n\r\nI am not really happy with part (1) of this PR, as this turned out to be a lot more complicated than I thought, since GHOST can take up to three `Coordinates` in some cases, and I was trying to cover as many possibilities as I could. We are still missing some possibilities (e.g. sky position out of range, target position in range) but adding these would make the already overly long code much longer.\r\n\r\nIf anyone has any suggestions as to how to simplify this mess, I would be thrilled to hear it."},"comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments/377248568","html_url":"https://github.com/gemini-hlsw/ocs/pull/1451#issuecomment-377248568","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1451","id":377248568,"user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars3.githubusercontent.com/u/3615303?v=4","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T14:13:47Z","updated_at":"2018-03-29T14:13:47Z","author_association":"CONTRIBUTOR","body":"Code wise this seems fine, unfortunately I don't know enough about GHOST to review the details"}}
{"actor":{"display_login":"cquiroz"}}