{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/comments/170384443","pull_request_review_id":99072499,"id":170384443,"diff_hunk":"@@ -44,7 +44,8 @@ var DEFAULTS = {\n   sourceLinesSpanLibraryFrames: 0,\n   flushInterval: 10,\n   transactionMaxSpans: Infinity,\n-  transactionSampleRate: 1.0\n+  transactionSampleRate: 1.0,\n+  serverTimeout: Infinity","path":"lib/config.js","position":6,"original_position":6,"commit_id":"43f1bc8848815227ae7d3e651ef4a85821e6d0ca","original_commit_id":"43f1bc8848815227ae7d3e651ef4a85821e6d0ca","user":{"login":"Qard","id":205482,"avatar_url":"https://avatars0.githubusercontent.com/u/205482?v=4","gravatar_id":"","url":"https://api.github.com/users/Qard","html_url":"https://github.com/Qard","followers_url":"https://api.github.com/users/Qard/followers","following_url":"https://api.github.com/users/Qard/following{/other_user}","gists_url":"https://api.github.com/users/Qard/gists{/gist_id}","starred_url":"https://api.github.com/users/Qard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qard/subscriptions","organizations_url":"https://api.github.com/users/Qard/orgs","repos_url":"https://api.github.com/users/Qard/repos","events_url":"https://api.github.com/users/Qard/events{/privacy}","received_events_url":"https://api.github.com/users/Qard/received_events","type":"User","site_admin":false},"body":"Sounds good to me. I just went with Infinity because that was the *original* behaviour. Having an actually *reasonable* timeout is definitely a good idea though.","created_at":"2018-02-23T22:30:11Z","updated_at":"2018-02-23T22:30:11Z","html_url":"https://github.com/elastic/apm-agent-nodejs/pull/238#discussion_r170384443","pull_request_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/comments/170384443"},"html":{"href":"https://github.com/elastic/apm-agent-nodejs/pull/238#discussion_r170384443"},"pull_request":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238"}},"in_reply_to_id":170384056},"pull_request":{"url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238","id":168373979,"html_url":"https://github.com/elastic/apm-agent-nodejs/pull/238","diff_url":"https://github.com/elastic/apm-agent-nodejs/pull/238.diff","patch_url":"https://github.com/elastic/apm-agent-nodejs/pull/238.patch","issue_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues/238","number":238,"state":"open","locked":false,"title":"feat(config): add serverTimeout","user":{"login":"Qard","id":205482,"avatar_url":"https://avatars0.githubusercontent.com/u/205482?v=4","gravatar_id":"","url":"https://api.github.com/users/Qard","html_url":"https://github.com/Qard","followers_url":"https://api.github.com/users/Qard/followers","following_url":"https://api.github.com/users/Qard/following{/other_user}","gists_url":"https://api.github.com/users/Qard/gists{/gist_id}","starred_url":"https://api.github.com/users/Qard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qard/subscriptions","organizations_url":"https://api.github.com/users/Qard/orgs","repos_url":"https://api.github.com/users/Qard/repos","events_url":"https://api.github.com/users/Qard/events{/privacy}","received_events_url":"https://api.github.com/users/Qard/received_events","type":"User","site_admin":false},"body":"Fixes #210 \r\n\r\nThis depends on https://github.com/elastic/apm-nodejs-http-client/pull/1 landing and getting released.","created_at":"2018-02-10T00:38:42Z","updated_at":"2018-02-23T22:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4b7287933df3d40e36774696708bae6bb7c54b1","assignee":{"login":"Qard","id":205482,"avatar_url":"https://avatars0.githubusercontent.com/u/205482?v=4","gravatar_id":"","url":"https://api.github.com/users/Qard","html_url":"https://github.com/Qard","followers_url":"https://api.github.com/users/Qard/followers","following_url":"https://api.github.com/users/Qard/following{/other_user}","gists_url":"https://api.github.com/users/Qard/gists{/gist_id}","starred_url":"https://api.github.com/users/Qard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qard/subscriptions","organizations_url":"https://api.github.com/users/Qard/orgs","repos_url":"https://api.github.com/users/Qard/repos","events_url":"https://api.github.com/users/Qard/events{/privacy}","received_events_url":"https://api.github.com/users/Qard/received_events","type":"User","site_admin":false},"assignees":[{"login":"Qard","id":205482,"avatar_url":"https://avatars0.githubusercontent.com/u/205482?v=4","gravatar_id":"","url":"https://api.github.com/users/Qard","html_url":"https://github.com/Qard","followers_url":"https://api.github.com/users/Qard/followers","following_url":"https://api.github.com/users/Qard/following{/other_user}","gists_url":"https://api.github.com/users/Qard/gists{/gist_id}","starred_url":"https://api.github.com/users/Qard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qard/subscriptions","organizations_url":"https://api.github.com/users/Qard/orgs","repos_url":"https://api.github.com/users/Qard/repos","events_url":"https://api.github.com/users/Qard/events{/privacy}","received_events_url":"https://api.github.com/users/Qard/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":664230009,"url":"https://api.github.com/repos/elastic/apm-agent-nodejs/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":673291665,"url":"https://api.github.com/repos/elastic/apm-agent-nodejs/labels/in%20progress","name":"in progress","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238/commits","review_comments_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238/comments","review_comment_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues/238/comments","statuses_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/statuses/43f1bc8848815227ae7d3e651ef4a85821e6d0ca","head":{"label":"Qard:server-timeout","ref":"server-timeout","sha":"43f1bc8848815227ae7d3e651ef4a85821e6d0ca","user":{"login":"Qard","id":205482,"avatar_url":"https://avatars0.githubusercontent.com/u/205482?v=4","gravatar_id":"","url":"https://api.github.com/users/Qard","html_url":"https://github.com/Qard","followers_url":"https://api.github.com/users/Qard/followers","following_url":"https://api.github.com/users/Qard/following{/other_user}","gists_url":"https://api.github.com/users/Qard/gists{/gist_id}","starred_url":"https://api.github.com/users/Qard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qard/subscriptions","organizations_url":"https://api.github.com/users/Qard/orgs","repos_url":"https://api.github.com/users/Qard/repos","events_url":"https://api.github.com/users/Qard/events{/privacy}","received_events_url":"https://api.github.com/users/Qard/received_events","type":"User","site_admin":false},"repo":{"id":113207541,"name":"apm-agent-nodejs","full_name":"Qard/apm-agent-nodejs","owner":{"login":"Qard","id":205482,"avatar_url":"https://avatars0.githubusercontent.com/u/205482?v=4","gravatar_id":"","url":"https://api.github.com/users/Qard","html_url":"https://github.com/Qard","followers_url":"https://api.github.com/users/Qard/followers","following_url":"https://api.github.com/users/Qard/following{/other_user}","gists_url":"https://api.github.com/users/Qard/gists{/gist_id}","starred_url":"https://api.github.com/users/Qard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qard/subscriptions","organizations_url":"https://api.github.com/users/Qard/orgs","repos_url":"https://api.github.com/users/Qard/repos","events_url":"https://api.github.com/users/Qard/events{/privacy}","received_events_url":"https://api.github.com/users/Qard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qard/apm-agent-nodejs","description":"Elastic APM Node.js Agent (Alpha)","fork":true,"url":"https://api.github.com/repos/Qard/apm-agent-nodejs","forks_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/forks","keys_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/teams","hooks_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/hooks","issue_events_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/events","assignees_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/tags","blobs_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/languages","stargazers_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/stargazers","contributors_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/contributors","subscribers_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/subscribers","subscription_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/subscription","commits_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/merges","archive_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/downloads","issues_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/Qard/apm-agent-nodejs/deployments","created_at":"2017-12-05T16:40:05Z","updated_at":"2017-12-05T16:40:07Z","pushed_at":"2018-02-16T02:23:26Z","git_url":"git://github.com/Qard/apm-agent-nodejs.git","ssh_url":"git@github.com:Qard/apm-agent-nodejs.git","clone_url":"https://github.com/Qard/apm-agent-nodejs.git","svn_url":"https://github.com/Qard/apm-agent-nodejs","homepage":"https://www.elastic.co/guide/en/apm/agent/nodejs/current/index.html","size":1590,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7697c5cf1689b9f23545e7d273dbd370350197d4","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":99673273,"name":"apm-agent-nodejs","full_name":"elastic/apm-agent-nodejs","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/apm-agent-nodejs","description":"Elastic APM Node.js Agent","fork":false,"url":"https://api.github.com/repos/elastic/apm-agent-nodejs","forks_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/forks","keys_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/teams","hooks_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/events","assignees_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/tags","blobs_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/subscription","commits_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/merges","archive_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/downloads","issues_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-agent-nodejs/deployments","created_at":"2017-08-08T09:07:27Z","updated_at":"2018-02-23T10:46:56Z","pushed_at":"2018-02-23T20:10:16Z","git_url":"git://github.com/elastic/apm-agent-nodejs.git","ssh_url":"git@github.com:elastic/apm-agent-nodejs.git","clone_url":"https://github.com/elastic/apm-agent-nodejs.git","svn_url":"https://github.com/elastic/apm-agent-nodejs","homepage":"https://www.elastic.co/guide/en/apm/agent/nodejs/current/index.html","size":1521,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":20,"open_issues":34,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238"},"html":{"href":"https://github.com/elastic/apm-agent-nodejs/pull/238"},"issue":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues/238"},"comments":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/apm-agent-nodejs/statuses/43f1bc8848815227ae7d3e651ef4a85821e6d0ca"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Qard"}}