{"action":"created","comment":{"url":"https://api.github.com/repos/erdc/proteus/pulls/comments/183197759","pull_request_review_id":114158078,"id":183197759,"diff_hunk":"@@ -5918,7 +5914,7 @@ namespace proteus\n                                                           isAdvectiveFluxBoundary_w[ebNE_kb],\n                                                           dmom_u_ham_grad_p_ext[0],//=1/rho\n                                                           normal,\n-                                                          porosity_ext*rhoSave, //multiply by rho. mql. CHECK.\n+                                                          porosity_ext*dmom_u_acc_u_ext, //multiply by rho. mql. CHECK.","path":"proteus/mprans/RANS3PF2D.h","position":397,"original_position":843,"commit_id":"108afffbfe804154be67d5b3f2d8ca2d73dffd33","original_commit_id":"137d1eb2e7bda46816bea91f8b29d37206048d3e","user":{"login":"cekees","id":613654,"avatar_url":"https://avatars1.githubusercontent.com/u/613654?v=4","gravatar_id":"","url":"https://api.github.com/users/cekees","html_url":"https://github.com/cekees","followers_url":"https://api.github.com/users/cekees/followers","following_url":"https://api.github.com/users/cekees/following{/other_user}","gists_url":"https://api.github.com/users/cekees/gists{/gist_id}","starred_url":"https://api.github.com/users/cekees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cekees/subscriptions","organizations_url":"https://api.github.com/users/cekees/orgs","repos_url":"https://api.github.com/users/cekees/repos","events_url":"https://api.github.com/users/cekees/events{/privacy}","received_events_url":"https://api.github.com/users/cekees/received_events","type":"User","site_admin":false},"body":"@manuel-quezada , these are similar to comment above.","created_at":"2018-04-21T02:38:36Z","updated_at":"2018-04-21T02:43:17Z","html_url":"https://github.com/erdc/proteus/pull/612#discussion_r183197759","pull_request_url":"https://api.github.com/repos/erdc/proteus/pulls/612","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/erdc/proteus/pulls/comments/183197759"},"html":{"href":"https://github.com/erdc/proteus/pull/612#discussion_r183197759"},"pull_request":{"href":"https://api.github.com/repos/erdc/proteus/pulls/612"}},"in_reply_to_id":176499176},"pull_request":{"url":"https://api.github.com/repos/erdc/proteus/pulls/612","id":143079363,"html_url":"https://github.com/erdc/proteus/pull/612","diff_url":"https://github.com/erdc/proteus/pull/612.diff","patch_url":"https://github.com/erdc/proteus/pull/612.patch","issue_url":"https://api.github.com/repos/erdc/proteus/issues/612","number":612,"state":"open","locked":false,"title":"gco rans3p","user":{"login":"Giovanni-Cozzuto-1989","id":15638848,"avatar_url":"https://avatars2.githubusercontent.com/u/15638848?v=4","gravatar_id":"","url":"https://api.github.com/users/Giovanni-Cozzuto-1989","html_url":"https://github.com/Giovanni-Cozzuto-1989","followers_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/followers","following_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/following{/other_user}","gists_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/gists{/gist_id}","starred_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/subscriptions","organizations_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/orgs","repos_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/repos","events_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/events{/privacy}","received_events_url":"https://api.github.com/users/Giovanni-Cozzuto-1989/received_events","type":"User","site_admin":false},"body":"This PR is for working with the three phase solver and creating benchmark for sediment transport problems.\r\n\r\n- [x] Conservation is preserved.\r\n- [x] Check and fix hsu stress formulation in SedClosure.\r\n- [x] Check and fix the signs of momentum interface for both fluid and sediment.\r\n- [x] Check and fix the signs of hamiltonian term (pressure) for both fluid and sediment.\r\n- [x] Check and fix the use of phi_s in RANS3PF and RANS3PSed coupled with vos.\r\n- [x] Check and fix the use of density through sediment and fluid model.\r\n- [x] Check and fix the penalty coefficient used for perturbating Navier-Stokes.\r\n- [x] Check and fix the post-step correction terms in velocity field for both sediment and fluid phases.\r\n- [x] Check and fix both density and viscosity used for the momentum interface calculation in SedClosure.\r\n- [x] Check and fix sediment pressure for frictional contact.\r\n- [x] Check and fix sediment shear stress for frictional contact. \r\n- [x] Check and fix limiters to prevent pressure blowing up.  \r\n- [x] Check and fix gradient of vos to be plugged into the pressure correction in contact stress module. \r\n\r\n\r\n\r\n","created_at":"2017-09-26T09:15:01Z","updated_at":"2018-04-21T02:43:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bef23db132cec7607777e5056de6c179ade99f66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/erdc/proteus/pulls/612/commits","review_comments_url":"https://api.github.com/repos/erdc/proteus/pulls/612/comments","review_comment_url":"https://api.github.com/repos/erdc/proteus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erdc/proteus/issues/612/comments","statuses_url":"https://api.github.com/repos/erdc/proteus/statuses/108afffbfe804154be67d5b3f2d8ca2d73dffd33","head":{"label":"erdc:gco_rans3p","ref":"gco_rans3p","sha":"108afffbfe804154be67d5b3f2d8ca2d73dffd33","user":{"login":"erdc","id":616627,"avatar_url":"https://avatars1.githubusercontent.com/u/616627?v=4","gravatar_id":"","url":"https://api.github.com/users/erdc","html_url":"https://github.com/erdc","followers_url":"https://api.github.com/users/erdc/followers","following_url":"https://api.github.com/users/erdc/following{/other_user}","gists_url":"https://api.github.com/users/erdc/gists{/gist_id}","starred_url":"https://api.github.com/users/erdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdc/subscriptions","organizations_url":"https://api.github.com/users/erdc/orgs","repos_url":"https://api.github.com/users/erdc/repos","events_url":"https://api.github.com/users/erdc/events{/privacy}","received_events_url":"https://api.github.com/users/erdc/received_events","type":"Organization","site_admin":false},"repo":{"id":2212385,"name":"proteus","full_name":"erdc/proteus","owner":{"login":"erdc","id":616627,"avatar_url":"https://avatars1.githubusercontent.com/u/616627?v=4","gravatar_id":"","url":"https://api.github.com/users/erdc","html_url":"https://github.com/erdc","followers_url":"https://api.github.com/users/erdc/followers","following_url":"https://api.github.com/users/erdc/following{/other_user}","gists_url":"https://api.github.com/users/erdc/gists{/gist_id}","starred_url":"https://api.github.com/users/erdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdc/subscriptions","organizations_url":"https://api.github.com/users/erdc/orgs","repos_url":"https://api.github.com/users/erdc/repos","events_url":"https://api.github.com/users/erdc/events{/privacy}","received_events_url":"https://api.github.com/users/erdc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/erdc/proteus","description":"A computational methods and simulation toolkit","fork":false,"url":"https://api.github.com/repos/erdc/proteus","forks_url":"https://api.github.com/repos/erdc/proteus/forks","keys_url":"https://api.github.com/repos/erdc/proteus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erdc/proteus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erdc/proteus/teams","hooks_url":"https://api.github.com/repos/erdc/proteus/hooks","issue_events_url":"https://api.github.com/repos/erdc/proteus/issues/events{/number}","events_url":"https://api.github.com/repos/erdc/proteus/events","assignees_url":"https://api.github.com/repos/erdc/proteus/assignees{/user}","branches_url":"https://api.github.com/repos/erdc/proteus/branches{/branch}","tags_url":"https://api.github.com/repos/erdc/proteus/tags","blobs_url":"https://api.github.com/repos/erdc/proteus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erdc/proteus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erdc/proteus/git/refs{/sha}","trees_url":"https://api.github.com/repos/erdc/proteus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erdc/proteus/statuses/{sha}","languages_url":"https://api.github.com/repos/erdc/proteus/languages","stargazers_url":"https://api.github.com/repos/erdc/proteus/stargazers","contributors_url":"https://api.github.com/repos/erdc/proteus/contributors","subscribers_url":"https://api.github.com/repos/erdc/proteus/subscribers","subscription_url":"https://api.github.com/repos/erdc/proteus/subscription","commits_url":"https://api.github.com/repos/erdc/proteus/commits{/sha}","git_commits_url":"https://api.github.com/repos/erdc/proteus/git/commits{/sha}","comments_url":"https://api.github.com/repos/erdc/proteus/comments{/number}","issue_comment_url":"https://api.github.com/repos/erdc/proteus/issues/comments{/number}","contents_url":"https://api.github.com/repos/erdc/proteus/contents/{+path}","compare_url":"https://api.github.com/repos/erdc/proteus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erdc/proteus/merges","archive_url":"https://api.github.com/repos/erdc/proteus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erdc/proteus/downloads","issues_url":"https://api.github.com/repos/erdc/proteus/issues{/number}","pulls_url":"https://api.github.com/repos/erdc/proteus/pulls{/number}","milestones_url":"https://api.github.com/repos/erdc/proteus/milestones{/number}","notifications_url":"https://api.github.com/repos/erdc/proteus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erdc/proteus/labels{/name}","releases_url":"https://api.github.com/repos/erdc/proteus/releases{/id}","deployments_url":"https://api.github.com/repos/erdc/proteus/deployments","created_at":"2011-08-15T21:28:25Z","updated_at":"2018-04-20T20:19:03Z","pushed_at":"2018-04-20T19:36:24Z","git_url":"git://github.com/erdc/proteus.git","ssh_url":"git@github.com:erdc/proteus.git","clone_url":"https://github.com/erdc/proteus.git","svn_url":"https://github.com/erdc/proteus","homepage":"http://proteustoolkit.org","size":302485,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":128,"watchers":26,"default_branch":"master"}},"base":{"label":"erdc:master","ref":"master","sha":"adc393fe922da87b0aa622fafeccf4c03411cc65","user":{"login":"erdc","id":616627,"avatar_url":"https://avatars1.githubusercontent.com/u/616627?v=4","gravatar_id":"","url":"https://api.github.com/users/erdc","html_url":"https://github.com/erdc","followers_url":"https://api.github.com/users/erdc/followers","following_url":"https://api.github.com/users/erdc/following{/other_user}","gists_url":"https://api.github.com/users/erdc/gists{/gist_id}","starred_url":"https://api.github.com/users/erdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdc/subscriptions","organizations_url":"https://api.github.com/users/erdc/orgs","repos_url":"https://api.github.com/users/erdc/repos","events_url":"https://api.github.com/users/erdc/events{/privacy}","received_events_url":"https://api.github.com/users/erdc/received_events","type":"Organization","site_admin":false},"repo":{"id":2212385,"name":"proteus","full_name":"erdc/proteus","owner":{"login":"erdc","id":616627,"avatar_url":"https://avatars1.githubusercontent.com/u/616627?v=4","gravatar_id":"","url":"https://api.github.com/users/erdc","html_url":"https://github.com/erdc","followers_url":"https://api.github.com/users/erdc/followers","following_url":"https://api.github.com/users/erdc/following{/other_user}","gists_url":"https://api.github.com/users/erdc/gists{/gist_id}","starred_url":"https://api.github.com/users/erdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdc/subscriptions","organizations_url":"https://api.github.com/users/erdc/orgs","repos_url":"https://api.github.com/users/erdc/repos","events_url":"https://api.github.com/users/erdc/events{/privacy}","received_events_url":"https://api.github.com/users/erdc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/erdc/proteus","description":"A computational methods and simulation toolkit","fork":false,"url":"https://api.github.com/repos/erdc/proteus","forks_url":"https://api.github.com/repos/erdc/proteus/forks","keys_url":"https://api.github.com/repos/erdc/proteus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erdc/proteus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erdc/proteus/teams","hooks_url":"https://api.github.com/repos/erdc/proteus/hooks","issue_events_url":"https://api.github.com/repos/erdc/proteus/issues/events{/number}","events_url":"https://api.github.com/repos/erdc/proteus/events","assignees_url":"https://api.github.com/repos/erdc/proteus/assignees{/user}","branches_url":"https://api.github.com/repos/erdc/proteus/branches{/branch}","tags_url":"https://api.github.com/repos/erdc/proteus/tags","blobs_url":"https://api.github.com/repos/erdc/proteus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erdc/proteus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erdc/proteus/git/refs{/sha}","trees_url":"https://api.github.com/repos/erdc/proteus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erdc/proteus/statuses/{sha}","languages_url":"https://api.github.com/repos/erdc/proteus/languages","stargazers_url":"https://api.github.com/repos/erdc/proteus/stargazers","contributors_url":"https://api.github.com/repos/erdc/proteus/contributors","subscribers_url":"https://api.github.com/repos/erdc/proteus/subscribers","subscription_url":"https://api.github.com/repos/erdc/proteus/subscription","commits_url":"https://api.github.com/repos/erdc/proteus/commits{/sha}","git_commits_url":"https://api.github.com/repos/erdc/proteus/git/commits{/sha}","comments_url":"https://api.github.com/repos/erdc/proteus/comments{/number}","issue_comment_url":"https://api.github.com/repos/erdc/proteus/issues/comments{/number}","contents_url":"https://api.github.com/repos/erdc/proteus/contents/{+path}","compare_url":"https://api.github.com/repos/erdc/proteus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erdc/proteus/merges","archive_url":"https://api.github.com/repos/erdc/proteus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erdc/proteus/downloads","issues_url":"https://api.github.com/repos/erdc/proteus/issues{/number}","pulls_url":"https://api.github.com/repos/erdc/proteus/pulls{/number}","milestones_url":"https://api.github.com/repos/erdc/proteus/milestones{/number}","notifications_url":"https://api.github.com/repos/erdc/proteus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erdc/proteus/labels{/name}","releases_url":"https://api.github.com/repos/erdc/proteus/releases{/id}","deployments_url":"https://api.github.com/repos/erdc/proteus/deployments","created_at":"2011-08-15T21:28:25Z","updated_at":"2018-04-20T20:19:03Z","pushed_at":"2018-04-20T19:36:24Z","git_url":"git://github.com/erdc/proteus.git","ssh_url":"git@github.com:erdc/proteus.git","clone_url":"https://github.com/erdc/proteus.git","svn_url":"https://github.com/erdc/proteus","homepage":"http://proteustoolkit.org","size":302485,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":128,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erdc/proteus/pulls/612"},"html":{"href":"https://github.com/erdc/proteus/pull/612"},"issue":{"href":"https://api.github.com/repos/erdc/proteus/issues/612"},"comments":{"href":"https://api.github.com/repos/erdc/proteus/issues/612/comments"},"review_comments":{"href":"https://api.github.com/repos/erdc/proteus/pulls/612/comments"},"review_comment":{"href":"https://api.github.com/repos/erdc/proteus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erdc/proteus/pulls/612/commits"},"statuses":{"href":"https://api.github.com/repos/erdc/proteus/statuses/108afffbfe804154be67d5b3f2d8ca2d73dffd33"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cekees"}}