{"action":"created","issue":{"url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71","repository_url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch","labels_url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71/comments","events_url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71/events","html_url":"https://github.com/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71","id":342262540,"node_id":"MDU6SXNzdWUzNDIyNjI1NDA=","number":71,"title":"Sink doesn't check if stream already exists before trying to create it","user":{"login":"dcopestake","id":5802381,"node_id":"MDQ6VXNlcjU4MDIzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5802381?v=4","gravatar_id":"","url":"https://api.github.com/users/dcopestake","html_url":"https://github.com/dcopestake","followers_url":"https://api.github.com/users/dcopestake/followers","following_url":"https://api.github.com/users/dcopestake/following{/other_user}","gists_url":"https://api.github.com/users/dcopestake/gists{/gist_id}","starred_url":"https://api.github.com/users/dcopestake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcopestake/subscriptions","organizations_url":"https://api.github.com/users/dcopestake/orgs","repos_url":"https://api.github.com/users/dcopestake/repos","events_url":"https://api.github.com/users/dcopestake/events{/privacy}","received_events_url":"https://api.github.com/users/dcopestake/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-18T10:07:56Z","updated_at":"2018-07-18T11:17:32Z","closed_at":"2018-07-18T11:17:32Z","author_association":"NONE","body":"I added a `ILogStreamNameProvider` implementation which basically just uses the hostname as the stream name, however I then hit issues as after the stream had been created the first time as the sink just attempts to recreate the stream without checking if it already exists. There is a check to see if the log group already exists, so it'd be handy if there was a similar check for the stream as well."},"comment":{"url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/comments/405896917","html_url":"https://github.com/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71#issuecomment-405896917","issue_url":"https://api.github.com/repos/Cimpress-MCP/serilog-sinks-awscloudwatch/issues/71","id":405896917,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTg5NjkxNw==","user":{"login":"dcopestake","id":5802381,"node_id":"MDQ6VXNlcjU4MDIzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5802381?v=4","gravatar_id":"","url":"https://api.github.com/users/dcopestake","html_url":"https://github.com/dcopestake","followers_url":"https://api.github.com/users/dcopestake/followers","following_url":"https://api.github.com/users/dcopestake/following{/other_user}","gists_url":"https://api.github.com/users/dcopestake/gists{/gist_id}","starred_url":"https://api.github.com/users/dcopestake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcopestake/subscriptions","organizations_url":"https://api.github.com/users/dcopestake/orgs","repos_url":"https://api.github.com/users/dcopestake/repos","events_url":"https://api.github.com/users/dcopestake/events{/privacy}","received_events_url":"https://api.github.com/users/dcopestake/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T11:17:32Z","updated_at":"2018-07-18T11:17:32Z","author_association":"NONE","body":"Looking through the code a bit more, I can see you kind of rely on the `ILogStreamNameProvider` returning a unique name each time because of the retry logic when the sink is unable to update the log stream sequence token (i.e. it then tries to create a new stream). So I guess my issue is kind of invalid! I'll close this."}}
{"actor":{"display_login":"dcopestake"}}