{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/3934","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3934/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3934/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3934/events","html_url":"https://github.com/envoyproxy/envoy/pull/3934","id":343772661,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzI1Njcw","number":3934,"title":"logging: Requiring details for RELEASE_ASSERT","user":{"login":"alyssawilk","id":18220477,"node_id":"MDQ6VXNlcjE4MjIwNDc3","avatar_url":"https://avatars2.githubusercontent.com/u/18220477?v=4","gravatar_id":"","url":"https://api.github.com/users/alyssawilk","html_url":"https://github.com/alyssawilk","followers_url":"https://api.github.com/users/alyssawilk/followers","following_url":"https://api.github.com/users/alyssawilk/following{/other_user}","gists_url":"https://api.github.com/users/alyssawilk/gists{/gist_id}","starred_url":"https://api.github.com/users/alyssawilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyssawilk/subscriptions","organizations_url":"https://api.github.com/users/alyssawilk/orgs","repos_url":"https://api.github.com/users/alyssawilk/repos","events_url":"https://api.github.com/users/alyssawilk/events{/privacy}","received_events_url":"https://api.github.com/users/alyssawilk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-07-23T19:54:47Z","updated_at":"2018-07-25T13:09:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3934","html_url":"https://github.com/envoyproxy/envoy/pull/3934","diff_url":"https://github.com/envoyproxy/envoy/pull/3934.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3934.patch"},"body":"Like #3842 but for ASSERT rather than RELEASE_ASSERT\r\n\r\nAgain for folks with in-house ASSERT macros,  I suggest\r\nfor file in `grep -rIl ASSERT`; do sed  -i 's/\\(\\ ASSERT(.*\\).;/\\1, \"\"\\);/' $file; done\r\n\r\n*Risk Level*: Low (should break builds only)\r\n*Testing*: bazel //test/...\r\n*Docs Changes*: n/a\r\n*Release Notes*: n/a\r\n"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/407748432","html_url":"https://github.com/envoyproxy/envoy/pull/3934#issuecomment-407748432","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3934","id":407748432,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzc0ODQzMg==","user":{"login":"alyssawilk","id":18220477,"node_id":"MDQ6VXNlcjE4MjIwNDc3","avatar_url":"https://avatars2.githubusercontent.com/u/18220477?v=4","gravatar_id":"","url":"https://api.github.com/users/alyssawilk","html_url":"https://github.com/alyssawilk","followers_url":"https://api.github.com/users/alyssawilk/followers","following_url":"https://api.github.com/users/alyssawilk/following{/other_user}","gists_url":"https://api.github.com/users/alyssawilk/gists{/gist_id}","starred_url":"https://api.github.com/users/alyssawilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyssawilk/subscriptions","organizations_url":"https://api.github.com/users/alyssawilk/orgs","repos_url":"https://api.github.com/users/alyssawilk/repos","events_url":"https://api.github.com/users/alyssawilk/events{/privacy}","received_events_url":"https://api.github.com/users/alyssawilk/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T13:09:36Z","updated_at":"2018-07-25T13:09:36Z","author_association":"CONTRIBUTOR","body":"@htuch I already agreed to make it optional, just ended up out yesterday so didn't get it shipped.\r\nw.r.t. the error in question I suspect we all agree it should be handled by config validation but do you think it's a bad thing to have a useful error message in the interim?  If not I think we're in agreement again. :-)"}}
{"actor":{"display_login":"alyssawilk"}}