{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-signalr/pulls/comments/244270694","pull_request_review_id":188229538,"id":244270694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDI3MDY5NA==","diff_hunk":"@@ -24,5 +26,11 @@ public Task DisposeAsync()\n         {\n             throw new NotImplementedException();\n         }\n+\n+        internal ServiceHubContext(IHubContext<Hub> hubContext, IHubLifetimeManagerForUserGroup lifetimeManager)","path":"src/Microsoft.Azure.SignalRService/ServiceHubContext.cs","position":22,"original_position":22,"commit_id":"d321fa3da2b63f13d799ee46c47cd74885549365","original_commit_id":"d321fa3da2b63f13d799ee46c47cd74885549365","user":{"login":"realwanpengli","id":38236089,"node_id":"MDQ6VXNlcjM4MjM2MDg5","avatar_url":"https://avatars2.githubusercontent.com/u/38236089?v=4","gravatar_id":"","url":"https://api.github.com/users/realwanpengli","html_url":"https://github.com/realwanpengli","followers_url":"https://api.github.com/users/realwanpengli/followers","following_url":"https://api.github.com/users/realwanpengli/following{/other_user}","gists_url":"https://api.github.com/users/realwanpengli/gists{/gist_id}","starred_url":"https://api.github.com/users/realwanpengli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realwanpengli/subscriptions","organizations_url":"https://api.github.com/users/realwanpengli/orgs","repos_url":"https://api.github.com/users/realwanpengli/repos","events_url":"https://api.github.com/users/realwanpengli/events{/privacy}","received_events_url":"https://api.github.com/users/realwanpengli/received_events","type":"User","site_admin":false},"body":"No need to make the constructor internal since the class is internal. make it public","created_at":"2018-12-28T06:40:10Z","updated_at":"2018-12-28T06:40:11Z","html_url":"https://github.com/Azure/azure-signalr/pull/306#discussion_r244270694","pull_request_url":"https://api.github.com/repos/Azure/azure-signalr/pulls/306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-signalr/pulls/comments/244270694"},"html":{"href":"https://github.com/Azure/azure-signalr/pull/306#discussion_r244270694"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-signalr/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-signalr/pulls/306","id":240746848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzQ2ODQ4","html_url":"https://github.com/Azure/azure-signalr/pull/306","diff_url":"https://github.com/Azure/azure-signalr/pull/306.diff","patch_url":"https://github.com/Azure/azure-signalr/pull/306.patch","issue_url":"https://api.github.com/repos/Azure/azure-signalr/issues/306","number":306,"state":"open","locked":false,"title":" SignalrService framework","user":{"login":"realwanpengli","id":38236089,"node_id":"MDQ6VXNlcjM4MjM2MDg5","avatar_url":"https://avatars2.githubusercontent.com/u/38236089?v=4","gravatar_id":"","url":"https://api.github.com/users/realwanpengli","html_url":"https://github.com/realwanpengli","followers_url":"https://api.github.com/users/realwanpengli/followers","following_url":"https://api.github.com/users/realwanpengli/following{/other_user}","gists_url":"https://api.github.com/users/realwanpengli/gists{/gist_id}","starred_url":"https://api.github.com/users/realwanpengli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realwanpengli/subscriptions","organizations_url":"https://api.github.com/users/realwanpengli/orgs","repos_url":"https://api.github.com/users/realwanpengli/repos","events_url":"https://api.github.com/users/realwanpengli/events{/privacy}","received_events_url":"https://api.github.com/users/realwanpengli/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-24T09:37:26Z","updated_at":"2018-12-28T06:40:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e176364dc0237cd7eed81fe94a8bae6c11cffde4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-signalr/pulls/306/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-signalr/pulls/306/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-signalr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-signalr/issues/306/comments","statuses_url":"https://api.github.com/repos/Azure/azure-signalr/statuses/d321fa3da2b63f13d799ee46c47cd74885549365","head":{"label":"Azure:wanl/signalrServiceSdk","ref":"wanl/signalrServiceSdk","sha":"d321fa3da2b63f13d799ee46c47cd74885549365","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":123069751,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwNjk3NTE=","name":"azure-signalr","full_name":"Azure/azure-signalr","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-signalr","description":"Azure SignalR Service SDK for .NET","fork":false,"url":"https://api.github.com/repos/Azure/azure-signalr","forks_url":"https://api.github.com/repos/Azure/azure-signalr/forks","keys_url":"https://api.github.com/repos/Azure/azure-signalr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-signalr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-signalr/teams","hooks_url":"https://api.github.com/repos/Azure/azure-signalr/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-signalr/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-signalr/events","assignees_url":"https://api.github.com/repos/Azure/azure-signalr/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-signalr/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-signalr/tags","blobs_url":"https://api.github.com/repos/Azure/azure-signalr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-signalr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-signalr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-signalr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-signalr/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-signalr/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-signalr/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-signalr/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-signalr/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-signalr/subscription","commits_url":"https://api.github.com/repos/Azure/azure-signalr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-signalr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-signalr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-signalr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-signalr/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-signalr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-signalr/merges","archive_url":"https://api.github.com/repos/Azure/azure-signalr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-signalr/downloads","issues_url":"https://api.github.com/repos/Azure/azure-signalr/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-signalr/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-signalr/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-signalr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-signalr/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-signalr/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-signalr/deployments","created_at":"2018-02-27T03:52:57Z","updated_at":"2018-12-27T19:40:56Z","pushed_at":"2018-12-28T05:58:36Z","git_url":"git://github.com/Azure/azure-signalr.git","ssh_url":"git@github.com:Azure/azure-signalr.git","clone_url":"https://github.com/Azure/azure-signalr.git","svn_url":"https://github.com/Azure/azure-signalr","homepage":"https://aka.ms/signalr-service","size":1355,"stargazers_count":43,"watchers_count":43,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":26,"watchers":43,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"6730bbf64a06ad38a0bcefe55a2d3b1feabfcd31","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":123069751,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwNjk3NTE=","name":"azure-signalr","full_name":"Azure/azure-signalr","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-signalr","description":"Azure SignalR Service SDK for .NET","fork":false,"url":"https://api.github.com/repos/Azure/azure-signalr","forks_url":"https://api.github.com/repos/Azure/azure-signalr/forks","keys_url":"https://api.github.com/repos/Azure/azure-signalr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-signalr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-signalr/teams","hooks_url":"https://api.github.com/repos/Azure/azure-signalr/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-signalr/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-signalr/events","assignees_url":"https://api.github.com/repos/Azure/azure-signalr/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-signalr/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-signalr/tags","blobs_url":"https://api.github.com/repos/Azure/azure-signalr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-signalr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-signalr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-signalr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-signalr/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-signalr/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-signalr/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-signalr/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-signalr/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-signalr/subscription","commits_url":"https://api.github.com/repos/Azure/azure-signalr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-signalr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-signalr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-signalr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-signalr/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-signalr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-signalr/merges","archive_url":"https://api.github.com/repos/Azure/azure-signalr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-signalr/downloads","issues_url":"https://api.github.com/repos/Azure/azure-signalr/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-signalr/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-signalr/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-signalr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-signalr/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-signalr/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-signalr/deployments","created_at":"2018-02-27T03:52:57Z","updated_at":"2018-12-27T19:40:56Z","pushed_at":"2018-12-28T05:58:36Z","git_url":"git://github.com/Azure/azure-signalr.git","ssh_url":"git@github.com:Azure/azure-signalr.git","clone_url":"https://github.com/Azure/azure-signalr.git","svn_url":"https://github.com/Azure/azure-signalr","homepage":"https://aka.ms/signalr-service","size":1355,"stargazers_count":43,"watchers_count":43,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":26,"watchers":43,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-signalr/pulls/306"},"html":{"href":"https://github.com/Azure/azure-signalr/pull/306"},"issue":{"href":"https://api.github.com/repos/Azure/azure-signalr/issues/306"},"comments":{"href":"https://api.github.com/repos/Azure/azure-signalr/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-signalr/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-signalr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-signalr/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-signalr/statuses/d321fa3da2b63f13d799ee46c47cd74885549365"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"realwanpengli"}}