{"push_id":2512758595,"size":13,"distinct_size":13,"ref":"refs/heads/master","head":"483f38ccd842c2e1d8fa8c5d44cf4789e58cca08","before":"dd06cdd4bda8eb255809e1daf08625d2ea46a2d8","commits":[{"sha":"05ba976a41c4f6b0259f317ee9788e3efd82f600","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"lightningd: --dev-no-reconnect needs to always suppress reconnection.\n\nIt didn't in the restore-from-db case.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/05ba976a41c4f6b0259f317ee9788e3efd82f600"},{"sha":"d0bfd8407a64451dbdecd2c3f3dc1ca9e8ccd407","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"test_lightningd.py: catch unexpected reconnections.\n\nI had a weird failure which was caused by an unexpected disconnect and\nreconnecct.  Since we are prersistend and recover from these, they can\nslip through our tests; most tests don't involve reconnection, so we\nneed to catch this explicitly.\n\nFor the connect() helper, we always suppress reconnection; tests which\nwant it all want other options so don't use this helper anyway.  (Actually,\nafter I said that, test_closing_while_disconnected was added when I\nrebased, which did require it, so I had to open-code that one).\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/d0bfd8407a64451dbdecd2c3f3dc1ca9e8ccd407"},{"sha":"7604f27fb8751b4c5f833a53706e2408efdefb8a","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"lightningd: make sure openingd and uncommitted_channel free each other.\n\nWithout this, we can get errors on shutdown:\n\nValgrind error file: valgrind-errors.27444\n==27444== Invalid read of size 8\n==27444==    at 0x1950E2: secp256k1_pubkey_load (secp256k1.c:127)\n==27444==    by 0x19CF87: secp256k1_ec_pubkey_serialize (secp256k1.c:189)\n==27444==    by 0x14FED9: towire_pubkey (towire.c:59)\n==27444==    by 0x15AAFB: towire_gossipctl_peer_disconnected (gen_gossip_wire.c:969)\n==27444==    by 0x1253EF: opening_channel_errmsg (opening_control.c:526)\n==27444==    by 0x1386A3: destroy_subd (subd.c:589)\n==27444==    by 0x18222C: notify (tal.c:240)\n==27444==    by 0x1826E1: del_tree (tal.c:400)\n==27444==    by 0x182733: del_tree (tal.c:410)\n==27444==    by 0x182733: del_tree (tal.c:410)\n==27444==    by 0x182B1F: tal_free (tal.c:511)\n==27444==    by 0x11FC53: main (lightningd.c:410)\n==27444==  Address 0x6c3af98 is 72 bytes inside a block of size 216 free'd\n==27444==    at 0x4C30D3B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\n==27444==    by 0x1827BC: del_tree (tal.c:421)\n==27444==    by 0x182B1F: tal_free (tal.c:511)\n==27444==    by 0x11F3C7: shutdown_subdaemons (lightningd.c:211)\n==27444==    by 0x11FC27: main (lightningd.c:406)\n==27444==  Block was alloc'd at\n==27444==    at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\n==27444==    by 0x182296: allocate (tal.c:250)\n==27444==    by 0x182863: tal_alloc_ (tal.c:448)\n==27444==    by 0x12F2DF: new_peer (peer_control.c:74)\n==27444==    by 0x125600: new_uncommitted_channel (opening_control.c:576)\n==27444==    by 0x125870: peer_accept_channel (opening_control.c:668)\n==27444==    by 0x13032A: peer_sent_nongossip (peer_control.c:427)\n==27444==    by 0x116B9E: peer_nongossip (gossip_control.c:60)\n==27444==    by 0x116F2B: gossip_msg (gossip_control.c:172)\n==27444==    by 0x138323: sd_msg_read (subd.c:503)\n==27444==    by 0x137C02: read_fds (subd.c:330)\n==27444==    by 0x175550: next_plan (io.c:59)\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/7604f27fb8751b4c5f833a53706e2408efdefb8a"},{"sha":"22fe2c921fc9316ae8903ae62028383f9ffe54e3","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"lightningd: commit short-channel-id to db when we create it.\n\nWe'd usually commit to the db soon, but there's a window where it\ncould be missed.\n\nAlso moves loc into the block it's used and make it tmpctx to avoid\nan explicit free.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/22fe2c921fc9316ae8903ae62028383f9ffe54e3"},{"sha":"bee795ed68b8899cdae5ecf3273897ba286a5277","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"channeld: don't do explicit state update.\n\nWe missed it in some corner cases where we crashed/were killed between\nbeing told of the lockin and sending the channel_normal_operation message.\nWhen we were restarted, we were told both sides were locked in already,\nso we never updated the state.\n\nPull the entire \"tell channeld\" logic into channel_control.c, and make\nit clear that we need to keep waching if we cant't tell channeld.  I think\nwe did get this correct in practice, since funding_announce_cb has the\nsame test, but it's better to be clear.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/bee795ed68b8899cdae5ecf3273897ba286a5277"},{"sha":"8e976150adb4c98cdb3aee2a31db21e9489a3e66","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"json_fundchannel: fix release vs connect/nongossip race.\n\nThe new connect code revealed an existing race: we tell gossipd to\nrelease the peer, but at the same time it connects in.  gossipd fails\nthe release because the peer is remote, and json_fundchannel fails.\n\nInstead, we catch this race when we get peer_connected() and we were\ntrying to open a channel.  It means keeping a list of fundchannels which\nare awaiting a gossipd response though.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/8e976150adb4c98cdb3aee2a31db21e9489a3e66"},{"sha":"5551c161ca539db43e9c4f2f6887402b9f448d62","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"gossipd: finish startup before master prints that it's ready.\n\nWe're about to remove automatic retrying of connect, and that uncovered\nthat we actually print out our \"Server started\" message before we create\nthe listening socket.\n\nMove the init higher (outside the db transaction) and make it a\nrequest/response, the loop until it's done.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/5551c161ca539db43e9c4f2f6887402b9f448d62"},{"sha":"d2b4e09e2773a09464ae0f4d2248fa4224c508b6","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"lightningd: re-allow closing negotiation when CLOSINGD_COMPLETE\n\nd822ba1ee accidentally removed this case, which is important: if the\nother side didn't get our final matching closing_signed, it will\nreconnect and try again.  We consider the channel no longer \"active\"\nand thus ignore it, and get upset when it send the\n`channel_reestablish` message.\n\nWe could just consider CLOSINGD_COMPLETE to be active, but then we'd\nhave to wait for the closing transaction to be mined before we'd allow\nanother connection.\n\nWe can't special case it when the peer reconnects, because there\ncould be (in theory) multiple channels for that peer in CLOSINGD_COMPLETE,\nand we don't know which one to reestablish.\n\nSo, we need to catch this when they send the reestablish, and hand\nthat msg to closingd to do negotiation again.  We already have code\nto note that we're in CLOSINGD_COMPLETE and thus ignore any result\nit gives us.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/d2b4e09e2773a09464ae0f4d2248fa4224c508b6"},{"sha":"16d5015d563076d581e9ce1312fceacdb229fe9d","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"lightningd: fix shutdown with unconfirmed channel.\n\nWe free the peers explicitly, but we don't free the unconfirmed channel:\nthe result is that it gets freed twice.\n\nThe workaround is to free the unconfirmed channel explicitly, but really\nthe peer should be tal_link'ed as it's basically a reference counted\nstructure.\n\n1.974911451 lightningd(17906):INFO: 03b4bca72572889d4b44cd0f194f73d54972af367e1917579283122ee10fa05f54 chan #1: Owning subdaemon lightning_openingd died (62464)\n1.980118094 lightningd(17906):BROKEN: FATAL SIGNAL 6\n1.980150447 lightningd(17906):BROKEN: backtrace: common/daemon.c:42 (crashdump) 0x432ba0\n1.980161268 lightningd(17906):BROKEN: backtrace: (null):0 ((null)) 0x7faeb18ff4af\n1.980167045 lightningd(17906):BROKEN: backtrace: (null):0 ((null)) 0x7faeb18ff428\n1.980171271 lightningd(17906):BROKEN: backtrace: (null):0 ((null)) 0x7faeb1901029\n1.980175847 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:98 (call_error) 0x47543e\n1.980181814 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:170 (check_bounds) 0x4755fb\n1.980188065 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:180 (to_tal_hdr) 0x475649\n1.980193756 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:504 (tal_free) 0x47600d\n1.980199402 lightningd(17906):BROKEN: backtrace: lightningd/peer_control.c:118 (delete_peer) 0x423990\n1.980205498 lightningd(17906):BROKEN: backtrace: lightningd/opening_control.c:574 (destroy_uncommitted_channel) 0x419df3\n1.980212380 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:240 (notify) 0x4757b0\n1.980218052 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:400 (del_tree) 0x475c61\n1.980223398 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:511 (tal_free) 0x476093\n1.980229174 lightningd(17906):BROKEN: backtrace: lightningd/opening_control.c:549 (opening_channel_errmsg) 0x419d1a\n1.980236227 lightningd(17906):BROKEN: backtrace: lightningd/subd.c:590 (destroy_subd) 0x42cf43\n1.980242348 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:240 (notify) 0x4757b0\n1.980247771 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:400 (del_tree) 0x475c61\n1.980252814 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:410 (del_tree) 0x475cb1\n1.980258356 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:410 (del_tree) 0x475cb1\n1.980263311 lightningd(17906):BROKEN: backtrace: ccan/ccan/tal/tal.c:511 (tal_free) 0x476093\n1.980269189 lightningd(17906):BROKEN: backtrace: lightningd/lightningd.c:412 (main) 0x4144ed\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/16d5015d563076d581e9ce1312fceacdb229fe9d"},{"sha":"e2ba1d2290daeba9055e9e88a6cbeaa9faa4628e","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"test_lightningd.py: test_closing_different_fees must wait for txs to hit mempool\n\nCareful log examination revealed that we were generating a block before one\nof the mutual close txs had entered the mempool.  This is rare because it\nmeans that both peers have to be too slow.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/e2ba1d2290daeba9055e9e88a6cbeaa9faa4628e"},{"sha":"5ff0d40fedf9c95ee83fc2d307fe2f9709bcce66","author":{"name":"Rusty Russell","email":"df9728c9e5104131c08c7adb03af425394842596@rustcorp.com.au"},"message":"travis: don't retry failing tests.\n\nRetrying gives spurious failures, since we see transactions from previous\nruns.  That makes it near impossible to diagnose the actual problem.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/5ff0d40fedf9c95ee83fc2d307fe2f9709bcce66"},{"sha":"eb42804fcc018905ffcb96e70d75b28b27f4a694","author":{"name":"ZmnSCPxj","email":"48278e2fd4904f8859315a39ff8e04b6d77c9bfc@protonmail.com"},"message":"invoice: Support providing preimage when making invoice.","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/eb42804fcc018905ffcb96e70d75b28b27f4a694"},{"sha":"483f38ccd842c2e1d8fa8c5d44cf4789e58cca08","author":{"name":"Christian Decker","email":"bd5e2b43faa09124ca3857e2b70edbfebff5e94e@gmail.com"},"message":"Merge branch 'master' into master","distinct":true,"url":"https://api.github.com/repos/fixone/lightning/commits/483f38ccd842c2e1d8fa8c5d44cf4789e58cca08"}]}
{"actor":{"display_login":"cdecker"}}