{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/223428712","pull_request_review_id":162553184,"id":223428712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQyODcxMg==","diff_hunk":"@@ -1342,8 +1342,8 @@ func TestCZSubChannelTraceCreationDeletion(t *testing.T) {\n \t\tif len(scm.Trace.Events) == 0 {\n \t\t\treturn false, fmt.Errorf(\"there should be at least one trace event for subChannel not 0\")\n \t\t}\n-\t\tif scm.Trace.Events[len(scm.Trace.Events)-1].Desc != \"Subchannel Deleted\" {\n-\t\t\treturn false, fmt.Errorf(\"the first trace event should be \\\"Subchannel Deleted\\\", not %q\", scm.Trace.Events[0].Desc)\n+\t\tif got, want := scm.Trace.Events[len(scm.Trace.Events)-1].Desc, \"Subchannel Deleted\"; got != want {\n+\t\t\treturn false, fmt.Errorf(\"the last trace event should be \\\"%s\\\", not %q\", want, got)","path":"test/channelz_test.go","position":7,"original_position":7,"commit_id":"15da8819f4d50f7d526b6719a95f35cb90dc76b7","original_commit_id":"15da8819f4d50f7d526b6719a95f35cb90dc76b7","user":{"login":"dfawley","id":26072277,"node_id":"MDQ6VXNlcjI2MDcyMjc3","avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"body":"`\\\"%s\\\"` --> `%q`","created_at":"2018-10-08T16:39:23Z","updated_at":"2018-10-08T16:39:23Z","html_url":"https://github.com/grpc/grpc-go/pull/2346#discussion_r223428712","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2346","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/223428712"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2346#discussion_r223428712"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2346"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/2346","id":219827012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODI3MDEy","html_url":"https://github.com/grpc/grpc-go/pull/2346","diff_url":"https://github.com/grpc/grpc-go/pull/2346.diff","patch_url":"https://github.com/grpc/grpc-go/pull/2346.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/2346","number":2346,"state":"open","locked":false,"title":"Fix onclose state transition","user":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"body":"When onClose occurs during WaitForHandshake, it should immediately\r\nexit createTransport instead of leaving CONNECTING and entering READY.\r\n\r\nFurthermore, when any onClose happens, the state should change to\r\nTRANSIENT FAILURE.\r\n\r\nFixes #2340\r\nFixes #2341\r\n\r\nAlso fixes an unreported bug in which entering READY causes a\r\nDial call to end prematurely, instead of blocking until a READY\r\ntransport is found.","created_at":"2018-10-02T20:00:42Z","updated_at":"2018-10-08T16:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acf32984d58fb4698e28d0b258d5d3c9151fae30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2346/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2346/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/2346/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/15da8819f4d50f7d526b6719a95f35cb90dc76b7","head":{"label":"jadekler:fix_onclose_state_transition","ref":"fix_onclose_state_transition","sha":"15da8819f4d50f7d526b6719a95f35cb90dc76b7","user":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"repo":{"id":115153337,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxNTMzMzc=","name":"grpc-go","full_name":"jadekler/grpc-go","private":false,"owner":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jadekler/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/jadekler/grpc-go","forks_url":"https://api.github.com/repos/jadekler/grpc-go/forks","keys_url":"https://api.github.com/repos/jadekler/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jadekler/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jadekler/grpc-go/teams","hooks_url":"https://api.github.com/repos/jadekler/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/jadekler/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/jadekler/grpc-go/events","assignees_url":"https://api.github.com/repos/jadekler/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/jadekler/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/jadekler/grpc-go/tags","blobs_url":"https://api.github.com/repos/jadekler/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jadekler/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jadekler/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/jadekler/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jadekler/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/jadekler/grpc-go/languages","stargazers_url":"https://api.github.com/repos/jadekler/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/jadekler/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/jadekler/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/jadekler/grpc-go/subscription","commits_url":"https://api.github.com/repos/jadekler/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/jadekler/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/jadekler/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/jadekler/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/jadekler/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/jadekler/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jadekler/grpc-go/merges","archive_url":"https://api.github.com/repos/jadekler/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jadekler/grpc-go/downloads","issues_url":"https://api.github.com/repos/jadekler/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/jadekler/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/jadekler/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/jadekler/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jadekler/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/jadekler/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/jadekler/grpc-go/deployments","created_at":"2017-12-22T22:05:27Z","updated_at":"2017-12-22T22:05:29Z","pushed_at":"2018-10-08T00:27:02Z","git_url":"git://github.com/jadekler/grpc-go.git","ssh_url":"git@github.com:jadekler/grpc-go.git","clone_url":"https://github.com/jadekler/grpc-go.git","svn_url":"https://github.com/jadekler/grpc-go","homepage":"","size":6804,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"179dc63634ee7ddc0cba387340062048410ae237","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkwNw==","name":"grpc-go","full_name":"grpc/grpc-go","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2018-10-08T15:10:59Z","pushed_at":"2018-10-08T00:27:06Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":7234,"stargazers_count":6585,"watchers_count":6585,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1273,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1273,"open_issues":100,"watchers":6585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2346"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2346"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2346"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2346/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2346/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2346/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/15da8819f4d50f7d526b6719a95f35cb90dc76b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dfawley"}}