{"action":"created","issue":{"url":"https://api.github.com/repos/iheartradio/play-swagger/issues/214","repository_url":"https://api.github.com/repos/iheartradio/play-swagger","labels_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/214/comments","events_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/214/events","html_url":"https://github.com/iheartradio/play-swagger/pull/214","id":306494609,"number":214,"title":"Use external source to provision description to action parameters and definitions","user":{"login":"sohoffice","id":3193955,"avatar_url":"https://avatars0.githubusercontent.com/u/3193955?v=4","gravatar_id":"","url":"https://api.github.com/users/sohoffice","html_url":"https://github.com/sohoffice","followers_url":"https://api.github.com/users/sohoffice/followers","following_url":"https://api.github.com/users/sohoffice/following{/other_user}","gists_url":"https://api.github.com/users/sohoffice/gists{/gist_id}","starred_url":"https://api.github.com/users/sohoffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohoffice/subscriptions","organizations_url":"https://api.github.com/users/sohoffice/orgs","repos_url":"https://api.github.com/users/sohoffice/repos","events_url":"https://api.github.com/users/sohoffice/events{/privacy}","received_events_url":"https://api.github.com/users/sohoffice/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-19T14:49:02Z","updated_at":"2018-03-20T14:14:57Z","closed_at":"2018-03-19T22:27:24Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/214","html_url":"https://github.com/iheartradio/play-swagger/pull/214","diff_url":"https://github.com/iheartradio/play-swagger/pull/214.diff","patch_url":"https://github.com/iheartradio/play-swagger/pull/214.patch"},"body":"Hi\r\n\r\nI've added the capability to accept descriptions from an external java properties file. The java properties file can be provided either manually or by some other sbt plugins. To companion this change, I've also created a new sbt plugin to extract the description out of the scaladoc of scala source codes. The 2 plugins seem to work nicely and the swagger doc looks more complete now.\r\n\r\nPlease can you review this PR and let me know what you think ?\r\n\r\nPs. I've also made changes to play2.6 branch, but they are basically the same as the master branch. so I guess I don't have to submit it again ?"},"comment":{"url":"https://api.github.com/repos/iheartradio/play-swagger/issues/comments/374613013","html_url":"https://github.com/iheartradio/play-swagger/pull/214#issuecomment-374613013","issue_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/214","id":374613013,"user":{"login":"kailuowang","id":83257,"avatar_url":"https://avatars3.githubusercontent.com/u/83257?v=4","gravatar_id":"","url":"https://api.github.com/users/kailuowang","html_url":"https://github.com/kailuowang","followers_url":"https://api.github.com/users/kailuowang/followers","following_url":"https://api.github.com/users/kailuowang/following{/other_user}","gists_url":"https://api.github.com/users/kailuowang/gists{/gist_id}","starred_url":"https://api.github.com/users/kailuowang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kailuowang/subscriptions","organizations_url":"https://api.github.com/users/kailuowang/orgs","repos_url":"https://api.github.com/users/kailuowang/repos","events_url":"https://api.github.com/users/kailuowang/events{/privacy}","received_events_url":"https://api.github.com/users/kailuowang/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T14:14:57Z","updated_at":"2018-03-20T14:14:57Z","author_association":"CONTRIBUTOR","body":"@sohoffice thanks very much for your contribution. I think a separate plugin is a great solution. Of course, you can keep and continue to develop your fork. play-swagger is licensed under Apache 2."}}
{"actor":{"display_login":"kailuowang"}}