{"action":"created","issue":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/3290","repository_url":"https://api.github.com/repos/danielgindi/Charts","labels_url":"https://api.github.com/repos/danielgindi/Charts/issues/3290/labels{/name}","comments_url":"https://api.github.com/repos/danielgindi/Charts/issues/3290/comments","events_url":"https://api.github.com/repos/danielgindi/Charts/issues/3290/events","html_url":"https://github.com/danielgindi/Charts/pull/3290","id":299280953,"number":3290,"title":"Implemented a simple animation for highlighting","user":{"login":"kalmurzayev","id":2243005,"avatar_url":"https://avatars0.githubusercontent.com/u/2243005?v=4","gravatar_id":"","url":"https://api.github.com/users/kalmurzayev","html_url":"https://github.com/kalmurzayev","followers_url":"https://api.github.com/users/kalmurzayev/followers","following_url":"https://api.github.com/users/kalmurzayev/following{/other_user}","gists_url":"https://api.github.com/users/kalmurzayev/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmurzayev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmurzayev/subscriptions","organizations_url":"https://api.github.com/users/kalmurzayev/orgs","repos_url":"https://api.github.com/users/kalmurzayev/repos","events_url":"https://api.github.com/users/kalmurzayev/events{/privacy}","received_events_url":"https://api.github.com/users/kalmurzayev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/danielgindi/Charts/milestones/1","html_url":"https://github.com/danielgindi/Charts/milestone/1","labels_url":"https://api.github.com/repos/danielgindi/Charts/milestones/1/labels","id":2932602,"number":1,"title":"4.0.0","description":"A Swift-ification of the library. Mainly modern API naming. Lots of internal updates, bug fixes.","creator":{"login":"petester42","id":296718,"avatar_url":"https://avatars0.githubusercontent.com/u/296718?v=4","gravatar_id":"","url":"https://api.github.com/users/petester42","html_url":"https://github.com/petester42","followers_url":"https://api.github.com/users/petester42/followers","following_url":"https://api.github.com/users/petester42/following{/other_user}","gists_url":"https://api.github.com/users/petester42/gists{/gist_id}","starred_url":"https://api.github.com/users/petester42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petester42/subscriptions","organizations_url":"https://api.github.com/users/petester42/orgs","repos_url":"https://api.github.com/users/petester42/repos","events_url":"https://api.github.com/users/petester42/events{/privacy}","received_events_url":"https://api.github.com/users/petester42/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":14,"state":"open","created_at":"2017-11-23T05:07:07Z","updated_at":"2018-02-24T01:51:10Z","due_on":"2018-05-14T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-02-22T09:37:50Z","updated_at":"2018-02-24T04:57:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/danielgindi/Charts/pulls/3290","html_url":"https://github.com/danielgindi/Charts/pull/3290","diff_url":"https://github.com/danielgindi/Charts/pull/3290.diff","patch_url":"https://github.com/danielgindi/Charts/pull/3290.patch"},"body":"Hi!\r\nI implemented an animated highlighting for `PieChartView`.\r\n- I extended IPieChartDataSet protocol to include `isSelectionAnimated` and `selectionShiftDuration`\r\n- I added these properties in PieChartDataSet by setting their default values to `false` and `0.5` by default\r\n- overriden `func highlightValue(_ highlight: Highlight?, callDelegate: Bool)` to include checking `isSelectionAnimated` and animating slice if needed\r\n- added unit tests checking if animation occurs only when `isSelectionAnimated` is enabled\r\n\r\nWill be happy to hear your feedback and make necessary changes "},"comment":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/comments/368200323","html_url":"https://github.com/danielgindi/Charts/pull/3290#issuecomment-368200323","issue_url":"https://api.github.com/repos/danielgindi/Charts/issues/3290","id":368200323,"user":{"login":"kalmurzayev","id":2243005,"avatar_url":"https://avatars0.githubusercontent.com/u/2243005?v=4","gravatar_id":"","url":"https://api.github.com/users/kalmurzayev","html_url":"https://github.com/kalmurzayev","followers_url":"https://api.github.com/users/kalmurzayev/followers","following_url":"https://api.github.com/users/kalmurzayev/following{/other_user}","gists_url":"https://api.github.com/users/kalmurzayev/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmurzayev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmurzayev/subscriptions","organizations_url":"https://api.github.com/users/kalmurzayev/orgs","repos_url":"https://api.github.com/users/kalmurzayev/repos","events_url":"https://api.github.com/users/kalmurzayev/events{/privacy}","received_events_url":"https://api.github.com/users/kalmurzayev/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T04:57:47Z","updated_at":"2018-02-24T04:57:47Z","author_association":"NONE","body":"Great. So should I probably rebase my branch onto branch 4.0?"}}
{"actor":{"display_login":"kalmurzayev"}}