{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/207655663","pull_request_review_id":143320364,"id":207655663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzY1NTY2Mw==","diff_hunk":"@@ -72,6 +72,8 @@ public interface INamedTypeSymbol : ITypeSymbol\n         /// </summary>\n         ImmutableArray<ITypeSymbol> TypeArguments { get; }\n \n+        ImmutableArray<Nullability> TypeArgumentNullability { get; }","path":"src/Compilers/Core/Portable/Symbols/INamedTypeSymbol.cs","position":4,"original_position":4,"commit_id":"d0b8c54adfc5b3552005c3a1e1c5ec73f5e2c263","original_commit_id":"d0b8c54adfc5b3552005c3a1e1c5ec73f5e2c263","user":{"login":"jasonmalinowski","id":201340,"node_id":"MDQ6VXNlcjIwMTM0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/201340?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"body":"Is there any reason we aren't doing some struct that holds a TypeSymbol and it's nullability, and having an ImmutableArray of that struct to hold both at once? My gut right now is saying the IDE is immediately going to create such a thing, and use that wherever we're using ITypeSymbols today.","created_at":"2018-08-03T20:15:26Z","updated_at":"2018-08-03T20:15:26Z","html_url":"https://github.com/dotnet/roslyn/pull/28860#discussion_r207655663","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28860","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/207655663"},"html":{"href":"https://github.com/dotnet/roslyn/pull/28860#discussion_r207655663"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28860"}},"in_reply_to_id":205846588},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/28860","id":204249180,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjQ5MTgw","html_url":"https://github.com/dotnet/roslyn/pull/28860","diff_url":"https://github.com/dotnet/roslyn/pull/28860.diff","patch_url":"https://github.com/dotnet/roslyn/pull/28860.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/28860","number":28860,"state":"open","locked":false,"title":"Nullable API Additions","user":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"body":"Contains the additions we are considering to add to the symbol API to expose nullability. This PR only has API additions, no implementation. It is expected to fail CI. @jcouv, @cston, @gafter, please review to make sure this is in line with what you were expecting.","created_at":"2018-07-26T19:53:32Z","updated_at":"2018-08-03T20:15:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ad75ad3bd8ad8c685bec23b12528f1bae990db0","assignee":{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":344899605,"node_id":"MDU6TGFiZWwzNDQ4OTk2MDU=","url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Nullable%20Reference%20Types","name":"New Language Feature - Nullable Reference Types","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28860/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/28860/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/28860/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/d0b8c54adfc5b3552005c3a1e1c5ec73f5e2c263","head":{"label":"333fred:nullable-api","ref":"nullable-api","sha":"d0b8c54adfc5b3552005c3a1e1c5ec73f5e2c263","user":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"repo":{"id":70755125,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc1NTEyNQ==","name":"roslyn","full_name":"333fred/roslyn","owner":{"login":"333fred","id":2371880,"node_id":"MDQ6VXNlcjIzNzE4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/333fred/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/333fred/roslyn","forks_url":"https://api.github.com/repos/333fred/roslyn/forks","keys_url":"https://api.github.com/repos/333fred/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/333fred/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/333fred/roslyn/teams","hooks_url":"https://api.github.com/repos/333fred/roslyn/hooks","issue_events_url":"https://api.github.com/repos/333fred/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/333fred/roslyn/events","assignees_url":"https://api.github.com/repos/333fred/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/333fred/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/333fred/roslyn/tags","blobs_url":"https://api.github.com/repos/333fred/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/333fred/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/333fred/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/333fred/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/333fred/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/333fred/roslyn/languages","stargazers_url":"https://api.github.com/repos/333fred/roslyn/stargazers","contributors_url":"https://api.github.com/repos/333fred/roslyn/contributors","subscribers_url":"https://api.github.com/repos/333fred/roslyn/subscribers","subscription_url":"https://api.github.com/repos/333fred/roslyn/subscription","commits_url":"https://api.github.com/repos/333fred/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/333fred/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/333fred/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/333fred/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/333fred/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/333fred/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/333fred/roslyn/merges","archive_url":"https://api.github.com/repos/333fred/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/333fred/roslyn/downloads","issues_url":"https://api.github.com/repos/333fred/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/333fred/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/333fred/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/333fred/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/333fred/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/333fred/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/333fred/roslyn/deployments","created_at":"2016-10-13T01:01:16Z","updated_at":"2018-06-26T20:55:25Z","pushed_at":"2018-08-01T22:09:41Z","git_url":"git://github.com/333fred/roslyn.git","ssh_url":"git@github.com:333fred/roslyn.git","clone_url":"https://github.com/333fred/roslyn.git","svn_url":"https://github.com/333fred/roslyn","homepage":"","size":363700,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"dotnet:features/NullableReferenceTypes","ref":"features/NullableReferenceTypes","sha":"5bd5f0f7e5c8d6b1b89e776ea68c1b6108055181","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-08-03T19:31:27Z","pushed_at":"2018-08-03T19:31:00Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":421842,"stargazers_count":9666,"watchers_count":9666,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2298,"mirror_url":null,"archived":false,"open_issues_count":4999,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2298,"open_issues":4999,"watchers":9666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28860"},"html":{"href":"https://github.com/dotnet/roslyn/pull/28860"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/28860"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/28860/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28860/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/28860/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/d0b8c54adfc5b3552005c3a1e1c5ec73f5e2c263"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jasonmalinowski"}}