{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/website-cms/pulls/comments/180019929","pull_request_review_id":110366099,"id":180019929,"diff_hunk":"@@ -324,15 +324,23 @@ def form_get_request_values(self):\n             # and this will make the form machinery miss all the fields\n             _values = self.request.args\n         # normal fields\n-        values = {\n-            k: v for k, v in _values.items()\n-            if k not in ('csrf_token', )\n-        }\n+        res = {}\n+        for k, v in _values.items():\n+            if k in ('csrf_token', ):\n+                continue\n+            if k.endswith(':list'):\n+                # fields w/ multiple values\n+                # TODO\n+                # 1. add test and docs\n+                # 2. support more \"transformers\" (`:int` for instance)\n+                v = _values.getlist(k)","path":"cms_form/models/cms_form_mixin.py","position":80,"original_position":17,"commit_id":"3efa08b4b5aacb9aa5256ec99da7f821604887fb","original_commit_id":"05bc1e135ac18f63796b268fbac572e2b1691322","user":{"login":"tschanzt","id":358342,"avatar_url":"https://avatars1.githubusercontent.com/u/358342?v=4","gravatar_id":"","url":"https://api.github.com/users/tschanzt","html_url":"https://github.com/tschanzt","followers_url":"https://api.github.com/users/tschanzt/followers","following_url":"https://api.github.com/users/tschanzt/following{/other_user}","gists_url":"https://api.github.com/users/tschanzt/gists{/gist_id}","starred_url":"https://api.github.com/users/tschanzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschanzt/subscriptions","organizations_url":"https://api.github.com/users/tschanzt/orgs","repos_url":"https://api.github.com/users/tschanzt/repos","events_url":"https://api.github.com/users/tschanzt/events{/privacy}","received_events_url":"https://api.github.com/users/tschanzt/received_events","type":"User","site_admin":false},"body":"Interesting, didn't know that.","created_at":"2018-04-09T08:26:56Z","updated_at":"2018-04-09T08:26:56Z","html_url":"https://github.com/OCA/website-cms/pull/52#discussion_r180019929","pull_request_url":"https://api.github.com/repos/OCA/website-cms/pulls/52","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OCA/website-cms/pulls/comments/180019929"},"html":{"href":"https://github.com/OCA/website-cms/pull/52#discussion_r180019929"},"pull_request":{"href":"https://api.github.com/repos/OCA/website-cms/pulls/52"}},"in_reply_to_id":179816734},"pull_request":{"url":"https://api.github.com/repos/OCA/website-cms/pulls/52","id":179985694,"html_url":"https://github.com/OCA/website-cms/pull/52","diff_url":"https://github.com/OCA/website-cms/pull/52.diff","patch_url":"https://github.com/OCA/website-cms/pull/52.patch","issue_url":"https://api.github.com/repos/OCA/website-cms/issues/52","number":52,"state":"open","locked":false,"title":"Misc form fix/imp","user":{"login":"simahawk","id":347149,"avatar_url":"https://avatars2.githubusercontent.com/u/347149?v=4","gravatar_id":"","url":"https://api.github.com/users/simahawk","html_url":"https://github.com/simahawk","followers_url":"https://api.github.com/users/simahawk/followers","following_url":"https://api.github.com/users/simahawk/following{/other_user}","gists_url":"https://api.github.com/users/simahawk/gists{/gist_id}","starred_url":"https://api.github.com/users/simahawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simahawk/subscriptions","organizations_url":"https://api.github.com/users/simahawk/orgs","repos_url":"https://api.github.com/users/simahawk/repos","events_url":"https://api.github.com/users/simahawk/events{/privacy}","received_events_url":"https://api.github.com/users/simahawk/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-06T15:45:09Z","updated_at":"2018-04-09T08:26:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd0abcac16420f9b22bb020bdfdbcb60d1354896","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/website-cms/pulls/52/commits","review_comments_url":"https://api.github.com/repos/OCA/website-cms/pulls/52/comments","review_comment_url":"https://api.github.com/repos/OCA/website-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/website-cms/issues/52/comments","statuses_url":"https://api.github.com/repos/OCA/website-cms/statuses/3efa08b4b5aacb9aa5256ec99da7f821604887fb","head":{"label":"simahawk:11-fix-imp","ref":"11-fix-imp","sha":"3efa08b4b5aacb9aa5256ec99da7f821604887fb","user":{"login":"simahawk","id":347149,"avatar_url":"https://avatars2.githubusercontent.com/u/347149?v=4","gravatar_id":"","url":"https://api.github.com/users/simahawk","html_url":"https://github.com/simahawk","followers_url":"https://api.github.com/users/simahawk/followers","following_url":"https://api.github.com/users/simahawk/following{/other_user}","gists_url":"https://api.github.com/users/simahawk/gists{/gist_id}","starred_url":"https://api.github.com/users/simahawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simahawk/subscriptions","organizations_url":"https://api.github.com/users/simahawk/orgs","repos_url":"https://api.github.com/users/simahawk/repos","events_url":"https://api.github.com/users/simahawk/events{/privacy}","received_events_url":"https://api.github.com/users/simahawk/received_events","type":"User","site_admin":false},"repo":{"id":69871262,"name":"website-cms","full_name":"simahawk/website-cms","owner":{"login":"simahawk","id":347149,"avatar_url":"https://avatars2.githubusercontent.com/u/347149?v=4","gravatar_id":"","url":"https://api.github.com/users/simahawk","html_url":"https://github.com/simahawk","followers_url":"https://api.github.com/users/simahawk/followers","following_url":"https://api.github.com/users/simahawk/following{/other_user}","gists_url":"https://api.github.com/users/simahawk/gists{/gist_id}","starred_url":"https://api.github.com/users/simahawk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simahawk/subscriptions","organizations_url":"https://api.github.com/users/simahawk/orgs","repos_url":"https://api.github.com/users/simahawk/repos","events_url":"https://api.github.com/users/simahawk/events{/privacy}","received_events_url":"https://api.github.com/users/simahawk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simahawk/website-cms","description":"CMS features for Odoo website","fork":true,"url":"https://api.github.com/repos/simahawk/website-cms","forks_url":"https://api.github.com/repos/simahawk/website-cms/forks","keys_url":"https://api.github.com/repos/simahawk/website-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simahawk/website-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simahawk/website-cms/teams","hooks_url":"https://api.github.com/repos/simahawk/website-cms/hooks","issue_events_url":"https://api.github.com/repos/simahawk/website-cms/issues/events{/number}","events_url":"https://api.github.com/repos/simahawk/website-cms/events","assignees_url":"https://api.github.com/repos/simahawk/website-cms/assignees{/user}","branches_url":"https://api.github.com/repos/simahawk/website-cms/branches{/branch}","tags_url":"https://api.github.com/repos/simahawk/website-cms/tags","blobs_url":"https://api.github.com/repos/simahawk/website-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simahawk/website-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simahawk/website-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/simahawk/website-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simahawk/website-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/simahawk/website-cms/languages","stargazers_url":"https://api.github.com/repos/simahawk/website-cms/stargazers","contributors_url":"https://api.github.com/repos/simahawk/website-cms/contributors","subscribers_url":"https://api.github.com/repos/simahawk/website-cms/subscribers","subscription_url":"https://api.github.com/repos/simahawk/website-cms/subscription","commits_url":"https://api.github.com/repos/simahawk/website-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/simahawk/website-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/simahawk/website-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/simahawk/website-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/simahawk/website-cms/contents/{+path}","compare_url":"https://api.github.com/repos/simahawk/website-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simahawk/website-cms/merges","archive_url":"https://api.github.com/repos/simahawk/website-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simahawk/website-cms/downloads","issues_url":"https://api.github.com/repos/simahawk/website-cms/issues{/number}","pulls_url":"https://api.github.com/repos/simahawk/website-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/simahawk/website-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/simahawk/website-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simahawk/website-cms/labels{/name}","releases_url":"https://api.github.com/repos/simahawk/website-cms/releases{/id}","deployments_url":"https://api.github.com/repos/simahawk/website-cms/deployments","created_at":"2016-10-03T13:05:56Z","updated_at":"2017-03-14T11:23:22Z","pushed_at":"2018-04-08T17:52:39Z","git_url":"git://github.com/simahawk/website-cms.git","ssh_url":"git@github.com:simahawk/website-cms.git","clone_url":"https://github.com/simahawk/website-cms.git","svn_url":"https://github.com/simahawk/website-cms","homepage":null,"size":1364,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":2,"open_issues":3,"watchers":1,"default_branch":"9.0"}},"base":{"label":"OCA:11.0","ref":"11.0","sha":"d8d32bffcc5edec7093abf4123db4158e2d2b88f","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":69856925,"name":"website-cms","full_name":"OCA/website-cms","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/website-cms","description":"CMS features for Odoo website","fork":false,"url":"https://api.github.com/repos/OCA/website-cms","forks_url":"https://api.github.com/repos/OCA/website-cms/forks","keys_url":"https://api.github.com/repos/OCA/website-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/website-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/website-cms/teams","hooks_url":"https://api.github.com/repos/OCA/website-cms/hooks","issue_events_url":"https://api.github.com/repos/OCA/website-cms/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/website-cms/events","assignees_url":"https://api.github.com/repos/OCA/website-cms/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/website-cms/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/website-cms/tags","blobs_url":"https://api.github.com/repos/OCA/website-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/website-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/website-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/website-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/website-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/website-cms/languages","stargazers_url":"https://api.github.com/repos/OCA/website-cms/stargazers","contributors_url":"https://api.github.com/repos/OCA/website-cms/contributors","subscribers_url":"https://api.github.com/repos/OCA/website-cms/subscribers","subscription_url":"https://api.github.com/repos/OCA/website-cms/subscription","commits_url":"https://api.github.com/repos/OCA/website-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/website-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/website-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/website-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/website-cms/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/website-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/website-cms/merges","archive_url":"https://api.github.com/repos/OCA/website-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/website-cms/downloads","issues_url":"https://api.github.com/repos/OCA/website-cms/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/website-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/website-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/website-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/website-cms/labels{/name}","releases_url":"https://api.github.com/repos/OCA/website-cms/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/website-cms/deployments","created_at":"2016-10-03T09:25:33Z","updated_at":"2018-04-08T08:21:16Z","pushed_at":"2018-04-08T17:52:40Z","git_url":"git://github.com/OCA/website-cms.git","ssh_url":"git@github.com:OCA/website-cms.git","clone_url":"https://github.com/OCA/website-cms.git","svn_url":"https://github.com/OCA/website-cms","homepage":null,"size":1099,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":33,"open_issues":13,"watchers":13,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/website-cms/pulls/52"},"html":{"href":"https://github.com/OCA/website-cms/pull/52"},"issue":{"href":"https://api.github.com/repos/OCA/website-cms/issues/52"},"comments":{"href":"https://api.github.com/repos/OCA/website-cms/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/website-cms/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/website-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/website-cms/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/website-cms/statuses/3efa08b4b5aacb9aa5256ec99da7f821604887fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tschanzt"}}