{"action":"created","comment":{"url":"https://api.github.com/repos/robotology/yarp/pulls/comments/213250170","pull_request_review_id":150045276,"id":213250170,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI1MDE3MA==","diff_hunk":"@@ -862,8 +862,15 @@ int diffList(folderType fType, bool verbose)\n             std::string userPath = rf.findPath((getFolderStringName(fType) + PATH_SEPARATOR + (*subDirIt)).c_str(), opts);\n             if (userPath == \"\")\n                 continue;\n-            if (recursiveDiff(installedPath + PATH_SEPARATOR + (*subDirIt).c_str(), userPath, tmp)>0)\n-                std::cout << (*subDirIt) << std::endl;\n+            try\n+            {\n+                if (recursiveDiff(installedPath + PATH_SEPARATOR + (*subDirIt).c_str(), userPath, tmp)>0)\n+                    std::cout << (*subDirIt) << std::endl;\n+            }\n+            catch (...)\n+            {\n+                printf(\"Excpetion occurred during call to diffList() on path \\\"%s\\\"\\n\", userPath.c_str());","path":"src/yarp-config/yarpcontextutils.cpp","position":13,"original_position":13,"commit_id":"0356fd43659a29744254e13d4b6fde859c0e2ed3","original_commit_id":"0356fd43659a29744254e13d4b6fde859c0e2ed3","user":{"login":"damn1","id":19439151,"node_id":"MDQ6VXNlcjE5NDM5MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"body":"In `recursiveDiff()` there is a call to `patch_toText()` and that's the function that can raise an exception. I decided to catch it here in order to print the error at the same level where the success result is printed.","created_at":"2018-08-28T09:49:52Z","updated_at":"2018-08-28T09:49:53Z","html_url":"https://github.com/robotology/yarp/pull/1825#discussion_r213250170","pull_request_url":"https://api.github.com/repos/robotology/yarp/pulls/1825","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments/213250170"},"html":{"href":"https://github.com/robotology/yarp/pull/1825#discussion_r213250170"},"pull_request":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1825"}},"in_reply_to_id":213026410},"pull_request":{"url":"https://api.github.com/repos/robotology/yarp/pulls/1825","id":205955429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTU1NDI5","html_url":"https://github.com/robotology/yarp/pull/1825","diff_url":"https://github.com/robotology/yarp/pull/1825.diff","patch_url":"https://github.com/robotology/yarp/pull/1825.patch","issue_url":"https://api.github.com/repos/robotology/yarp/issues/1825","number":1825,"state":"open","locked":false,"title":"Coverity fixes","user":{"login":"damn1","id":19439151,"node_id":"MDQ6VXNlcjE5NDM5MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"body":"New fixes","created_at":"2018-08-03T08:07:11Z","updated_at":"2018-08-28T09:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"602e0a96cdac71eca3723f993692c8b54e6fbb6b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"randaz81","id":2869969,"node_id":"MDQ6VXNlcjI4Njk5Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2869969?v=4","gravatar_id":"","url":"https://api.github.com/users/randaz81","html_url":"https://github.com/randaz81","followers_url":"https://api.github.com/users/randaz81/followers","following_url":"https://api.github.com/users/randaz81/following{/other_user}","gists_url":"https://api.github.com/users/randaz81/gists{/gist_id}","starred_url":"https://api.github.com/users/randaz81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randaz81/subscriptions","organizations_url":"https://api.github.com/users/randaz81/orgs","repos_url":"https://api.github.com/users/randaz81/repos","events_url":"https://api.github.com/users/randaz81/events{/privacy}","received_events_url":"https://api.github.com/users/randaz81/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":616198434,"node_id":"MDU6TGFiZWw2MTYxOTg0MzQ=","url":"https://api.github.com/repos/robotology/yarp/labels/PR%20Type:%20Bugfix","name":"PR Type: Bugfix","color":"7210a0","default":false},{"id":1010344015,"node_id":"MDU6TGFiZWwxMDEwMzQ0MDE1","url":"https://api.github.com/repos/robotology/yarp/labels/Target:%20YARP%20master","name":"Target: YARP master","color":"d93f0b","default":false},{"id":469279033,"node_id":"MDU6TGFiZWw0NjkyNzkwMzM=","url":"https://api.github.com/repos/robotology/yarp/labels/Type:%20Cleanup","name":"Type: Cleanup","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/yarp/pulls/1825/commits","review_comments_url":"https://api.github.com/repos/robotology/yarp/pulls/1825/comments","review_comment_url":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/1825/comments","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/0356fd43659a29744254e13d4b6fde859c0e2ed3","head":{"label":"damn1:coverity_fix_4","ref":"coverity_fix_4","sha":"0356fd43659a29744254e13d4b6fde859c0e2ed3","user":{"login":"damn1","id":19439151,"node_id":"MDQ6VXNlcjE5NDM5MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"repo":{"id":104322647,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzMjI2NDc=","name":"yarp","full_name":"damn1/yarp","owner":{"login":"damn1","id":19439151,"node_id":"MDQ6VXNlcjE5NDM5MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/19439151?v=4","gravatar_id":"","url":"https://api.github.com/users/damn1","html_url":"https://github.com/damn1","followers_url":"https://api.github.com/users/damn1/followers","following_url":"https://api.github.com/users/damn1/following{/other_user}","gists_url":"https://api.github.com/users/damn1/gists{/gist_id}","starred_url":"https://api.github.com/users/damn1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damn1/subscriptions","organizations_url":"https://api.github.com/users/damn1/orgs","repos_url":"https://api.github.com/users/damn1/repos","events_url":"https://api.github.com/users/damn1/events{/privacy}","received_events_url":"https://api.github.com/users/damn1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damn1/yarp","description":"YARP - Yet Another Robot Platform","fork":true,"url":"https://api.github.com/repos/damn1/yarp","forks_url":"https://api.github.com/repos/damn1/yarp/forks","keys_url":"https://api.github.com/repos/damn1/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damn1/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damn1/yarp/teams","hooks_url":"https://api.github.com/repos/damn1/yarp/hooks","issue_events_url":"https://api.github.com/repos/damn1/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/damn1/yarp/events","assignees_url":"https://api.github.com/repos/damn1/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/damn1/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/damn1/yarp/tags","blobs_url":"https://api.github.com/repos/damn1/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damn1/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damn1/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/damn1/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damn1/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/damn1/yarp/languages","stargazers_url":"https://api.github.com/repos/damn1/yarp/stargazers","contributors_url":"https://api.github.com/repos/damn1/yarp/contributors","subscribers_url":"https://api.github.com/repos/damn1/yarp/subscribers","subscription_url":"https://api.github.com/repos/damn1/yarp/subscription","commits_url":"https://api.github.com/repos/damn1/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/damn1/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/damn1/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/damn1/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/damn1/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/damn1/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damn1/yarp/merges","archive_url":"https://api.github.com/repos/damn1/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damn1/yarp/downloads","issues_url":"https://api.github.com/repos/damn1/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/damn1/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/damn1/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/damn1/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damn1/yarp/labels{/name}","releases_url":"https://api.github.com/repos/damn1/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/damn1/yarp/deployments","created_at":"2017-09-21T08:35:59Z","updated_at":"2017-09-21T08:36:07Z","pushed_at":"2018-08-03T15:27:07Z","git_url":"git://github.com/damn1/yarp.git","ssh_url":"git@github.com:damn1/yarp.git","clone_url":"https://github.com/damn1/yarp.git","svn_url":"https://github.com/damn1/yarp","homepage":"http://www.yarp.it","size":71982,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotology:master","ref":"master","sha":"4bca59c4f41bff16e9b4d453257878ab263745be","user":{"login":"robotology","id":1587191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":9517720,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE3NzIw","name":"yarp","full_name":"robotology/yarp","owner":{"login":"robotology","id":1587191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODcxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/yarp","description":"YARP - Yet Another Robot Platform","fork":false,"url":"https://api.github.com/repos/robotology/yarp","forks_url":"https://api.github.com/repos/robotology/yarp/forks","keys_url":"https://api.github.com/repos/robotology/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/yarp/teams","hooks_url":"https://api.github.com/repos/robotology/yarp/hooks","issue_events_url":"https://api.github.com/repos/robotology/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/yarp/events","assignees_url":"https://api.github.com/repos/robotology/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/yarp/tags","blobs_url":"https://api.github.com/repos/robotology/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/yarp/languages","stargazers_url":"https://api.github.com/repos/robotology/yarp/stargazers","contributors_url":"https://api.github.com/repos/robotology/yarp/contributors","subscribers_url":"https://api.github.com/repos/robotology/yarp/subscribers","subscription_url":"https://api.github.com/repos/robotology/yarp/subscription","commits_url":"https://api.github.com/repos/robotology/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/yarp/merges","archive_url":"https://api.github.com/repos/robotology/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/yarp/downloads","issues_url":"https://api.github.com/repos/robotology/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/yarp/labels{/name}","releases_url":"https://api.github.com/repos/robotology/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/yarp/deployments","created_at":"2013-04-18T09:13:24Z","updated_at":"2018-08-22T14:08:46Z","pushed_at":"2018-08-22T14:10:29Z","git_url":"git://github.com/robotology/yarp.git","ssh_url":"git@github.com:robotology/yarp.git","clone_url":"https://github.com/robotology/yarp.git","svn_url":"https://github.com/robotology/yarp","homepage":"http://www.yarp.it","size":72055,"stargazers_count":223,"watchers_count":223,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":109,"open_issues":226,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1825"},"html":{"href":"https://github.com/robotology/yarp/pull/1825"},"issue":{"href":"https://api.github.com/repos/robotology/yarp/issues/1825"},"comments":{"href":"https://api.github.com/repos/robotology/yarp/issues/1825/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1825/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1825/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/yarp/statuses/0356fd43659a29744254e13d4b6fde859c0e2ed3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"damn1"}}