{"action":"created","comment":{"url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/comments/184706034","pull_request_review_id":115960691,"id":184706034,"diff_hunk":"@@ -84,9 +84,15 @@ bool Adafruit_AM2320::begin() {\n /**************************************************************************/\n float Adafruit_AM2320::readTemperature() {\n   uint16_t t = readRegister16(AM2320_REG_TEMP_H);\n+  float ft;\n   if (t == 0xFFFF) return NAN;\n-\n-  float ft = (int16_t)t;\n+  // check sign bit - the temperature mSB is signd , bit 0-15 are mignitude\n+  if(t >= 32768){","path":"Adafruit_AM2320.cpp","position":9,"original_position":9,"commit_id":"0244adadd4398430bb942fdd57473010b8dbbc8a","original_commit_id":"0244adadd4398430bb942fdd57473010b8dbbc8a","user":{"login":"jerryneedell","id":15856834,"avatar_url":"https://avatars0.githubusercontent.com/u/15856834?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryneedell","html_url":"https://github.com/jerryneedell","followers_url":"https://api.github.com/users/jerryneedell/followers","following_url":"https://api.github.com/users/jerryneedell/following{/other_user}","gists_url":"https://api.github.com/users/jerryneedell/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryneedell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryneedell/subscriptions","organizations_url":"https://api.github.com/users/jerryneedell/orgs","repos_url":"https://api.github.com/users/jerryneedell/repos","events_url":"https://api.github.com/users/jerryneedell/events{/privacy}","received_events_url":"https://api.github.com/users/jerryneedell/received_events","type":"User","site_admin":false},"body":"sounds good - will implement\r\n","created_at":"2018-04-27T14:33:19Z","updated_at":"2018-04-27T14:33:19Z","html_url":"https://github.com/adafruit/Adafruit_AM2320/pull/3#discussion_r184706034","pull_request_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/comments/184706034"},"html":{"href":"https://github.com/adafruit/Adafruit_AM2320/pull/3#discussion_r184706034"},"pull_request":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3"}},"in_reply_to_id":184705661},"pull_request":{"url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3","id":184633680,"html_url":"https://github.com/adafruit/Adafruit_AM2320/pull/3","diff_url":"https://github.com/adafruit/Adafruit_AM2320/pull/3.diff","patch_url":"https://github.com/adafruit/Adafruit_AM2320/pull/3.patch","issue_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues/3","number":3,"state":"open","locked":false,"title":" fix negative temperature handling","user":{"login":"jerryneedell","id":15856834,"avatar_url":"https://avatars0.githubusercontent.com/u/15856834?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryneedell","html_url":"https://github.com/jerryneedell","followers_url":"https://api.github.com/users/jerryneedell/followers","following_url":"https://api.github.com/users/jerryneedell/following{/other_user}","gists_url":"https://api.github.com/users/jerryneedell/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryneedell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryneedell/subscriptions","organizations_url":"https://api.github.com/users/jerryneedell/orgs","repos_url":"https://api.github.com/users/jerryneedell/repos","events_url":"https://api.github.com/users/jerryneedell/events{/privacy}","received_events_url":"https://api.github.com/users/jerryneedell/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\n\r\nfixes #2  - tested by placing sensor in freezer\r\n\r\n\r\n\r\n```\r\nHum: 20.10\r\nTemp: 0.30\r\nHum: 20.20\r\nTemp: 0.10\r\nHum: 20.30\r\nTemp: 0.10\r\nHum: 20.50\r\nTemp: 0.00\r\nHum: 20.60\r\nTemp: -0.30\r\nHum: 20.70\r\nTemp: -0.40\r\nHum: 20.80\r\nTemp: -0.60\r\nHum: 20.90\r\nTemp: -0.50\r\n\r\n```\r\n\r\n","created_at":"2018-04-27T14:11:37Z","updated_at":"2018-04-27T14:33:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d095d54344d4c1dc754167873ffd11a603bc7077","assignee":null,"assignees":[],"requested_reviewers":[{"login":"caternuson","id":8755041,"avatar_url":"https://avatars2.githubusercontent.com/u/8755041?v=4","gravatar_id":"","url":"https://api.github.com/users/caternuson","html_url":"https://github.com/caternuson","followers_url":"https://api.github.com/users/caternuson/followers","following_url":"https://api.github.com/users/caternuson/following{/other_user}","gists_url":"https://api.github.com/users/caternuson/gists{/gist_id}","starred_url":"https://api.github.com/users/caternuson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caternuson/subscriptions","organizations_url":"https://api.github.com/users/caternuson/orgs","repos_url":"https://api.github.com/users/caternuson/repos","events_url":"https://api.github.com/users/caternuson/events{/privacy}","received_events_url":"https://api.github.com/users/caternuson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3/commits","review_comments_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3/comments","review_comment_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues/3/comments","statuses_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/statuses/0244adadd4398430bb942fdd57473010b8dbbc8a","head":{"label":"jerryneedell:jerryn_negative","ref":"jerryn_negative","sha":"0244adadd4398430bb942fdd57473010b8dbbc8a","user":{"login":"jerryneedell","id":15856834,"avatar_url":"https://avatars0.githubusercontent.com/u/15856834?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryneedell","html_url":"https://github.com/jerryneedell","followers_url":"https://api.github.com/users/jerryneedell/followers","following_url":"https://api.github.com/users/jerryneedell/following{/other_user}","gists_url":"https://api.github.com/users/jerryneedell/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryneedell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryneedell/subscriptions","organizations_url":"https://api.github.com/users/jerryneedell/orgs","repos_url":"https://api.github.com/users/jerryneedell/repos","events_url":"https://api.github.com/users/jerryneedell/events{/privacy}","received_events_url":"https://api.github.com/users/jerryneedell/received_events","type":"User","site_admin":false},"repo":{"id":131297067,"name":"Adafruit_AM2320","full_name":"jerryneedell/Adafruit_AM2320","owner":{"login":"jerryneedell","id":15856834,"avatar_url":"https://avatars0.githubusercontent.com/u/15856834?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryneedell","html_url":"https://github.com/jerryneedell","followers_url":"https://api.github.com/users/jerryneedell/followers","following_url":"https://api.github.com/users/jerryneedell/following{/other_user}","gists_url":"https://api.github.com/users/jerryneedell/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryneedell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryneedell/subscriptions","organizations_url":"https://api.github.com/users/jerryneedell/orgs","repos_url":"https://api.github.com/users/jerryneedell/repos","events_url":"https://api.github.com/users/jerryneedell/events{/privacy}","received_events_url":"https://api.github.com/users/jerryneedell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerryneedell/Adafruit_AM2320","description":"Arduino library for AM2320 sensor","fork":true,"url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320","forks_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/forks","keys_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/teams","hooks_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/hooks","issue_events_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/issues/events{/number}","events_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/events","assignees_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/assignees{/user}","branches_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/branches{/branch}","tags_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/tags","blobs_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/languages","stargazers_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/stargazers","contributors_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/contributors","subscribers_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/subscribers","subscription_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/subscription","commits_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/contents/{+path}","compare_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/merges","archive_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/downloads","issues_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/issues{/number}","pulls_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/labels{/name}","releases_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/releases{/id}","deployments_url":"https://api.github.com/repos/jerryneedell/Adafruit_AM2320/deployments","created_at":"2018-04-27T13:01:01Z","updated_at":"2018-04-27T13:01:03Z","pushed_at":"2018-04-27T14:02:20Z","git_url":"git://github.com/jerryneedell/Adafruit_AM2320.git","ssh_url":"git@github.com:jerryneedell/Adafruit_AM2320.git","clone_url":"https://github.com/jerryneedell/Adafruit_AM2320.git","svn_url":"https://github.com/jerryneedell/Adafruit_AM2320","homepage":null,"size":121,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adafruit:master","ref":"master","sha":"f13cf3fd755c2f019e890471ade6250ca85c66b7","user":{"login":"adafruit","id":181069,"avatar_url":"https://avatars3.githubusercontent.com/u/181069?v=4","gravatar_id":"","url":"https://api.github.com/users/adafruit","html_url":"https://github.com/adafruit","followers_url":"https://api.github.com/users/adafruit/followers","following_url":"https://api.github.com/users/adafruit/following{/other_user}","gists_url":"https://api.github.com/users/adafruit/gists{/gist_id}","starred_url":"https://api.github.com/users/adafruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adafruit/subscriptions","organizations_url":"https://api.github.com/users/adafruit/orgs","repos_url":"https://api.github.com/users/adafruit/repos","events_url":"https://api.github.com/users/adafruit/events{/privacy}","received_events_url":"https://api.github.com/users/adafruit/received_events","type":"Organization","site_admin":false},"repo":{"id":124255032,"name":"Adafruit_AM2320","full_name":"adafruit/Adafruit_AM2320","owner":{"login":"adafruit","id":181069,"avatar_url":"https://avatars3.githubusercontent.com/u/181069?v=4","gravatar_id":"","url":"https://api.github.com/users/adafruit","html_url":"https://github.com/adafruit","followers_url":"https://api.github.com/users/adafruit/followers","following_url":"https://api.github.com/users/adafruit/following{/other_user}","gists_url":"https://api.github.com/users/adafruit/gists{/gist_id}","starred_url":"https://api.github.com/users/adafruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adafruit/subscriptions","organizations_url":"https://api.github.com/users/adafruit/orgs","repos_url":"https://api.github.com/users/adafruit/repos","events_url":"https://api.github.com/users/adafruit/events{/privacy}","received_events_url":"https://api.github.com/users/adafruit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adafruit/Adafruit_AM2320","description":"Arduino library for AM2320 sensor","fork":false,"url":"https://api.github.com/repos/adafruit/Adafruit_AM2320","forks_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/forks","keys_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/teams","hooks_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/hooks","issue_events_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues/events{/number}","events_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/events","assignees_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/assignees{/user}","branches_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/branches{/branch}","tags_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/tags","blobs_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/git/refs{/sha}","trees_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/statuses/{sha}","languages_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/languages","stargazers_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/stargazers","contributors_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/contributors","subscribers_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/subscribers","subscription_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/subscription","commits_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/commits{/sha}","git_commits_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/git/commits{/sha}","comments_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/comments{/number}","issue_comment_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues/comments{/number}","contents_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/contents/{+path}","compare_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/merges","archive_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/downloads","issues_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues{/number}","pulls_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls{/number}","milestones_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/milestones{/number}","notifications_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/labels{/name}","releases_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/releases{/id}","deployments_url":"https://api.github.com/repos/adafruit/Adafruit_AM2320/deployments","created_at":"2018-03-07T15:22:55Z","updated_at":"2018-04-05T11:15:59Z","pushed_at":"2018-04-27T14:11:38Z","git_url":"git://github.com/adafruit/Adafruit_AM2320.git","ssh_url":"git@github.com:adafruit/Adafruit_AM2320.git","clone_url":"https://github.com/adafruit/Adafruit_AM2320.git","svn_url":"https://github.com/adafruit/Adafruit_AM2320","homepage":null,"size":121,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3"},"html":{"href":"https://github.com/adafruit/Adafruit_AM2320/pull/3"},"issue":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues/3"},"comments":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/adafruit/Adafruit_AM2320/statuses/0244adadd4398430bb942fdd57473010b8dbbc8a"}},"author_association":"NONE"}}
{"actor":{"display_login":"jerryneedell"}}