{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/177117525","pull_request_review_id":106935095,"id":177117525,"diff_hunk":"@@ -1026,7 +1026,7 @@ static int ompi_comm_allreduce_group_broadcast (ompi_comm_request_t *request)\n {\n     ompi_comm_allreduce_context_t *context = (ompi_comm_allreduce_context_t *) request->context;\n     ompi_comm_cid_context_t *cid_context = context->cid_context;\n-    ompi_request_t *subreq[2];","path":"ompi/communicator/comm_cid.c","position":13,"original_position":13,"commit_id":"863299976b787464c26caf2ed82887bba11d32d0","original_commit_id":"863299976b787464c26caf2ed82887bba11d32d0","user":{"login":"bosilca","id":642701,"avatar_url":"https://avatars3.githubusercontent.com/u/642701?v=4","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false},"body":"This is not necessary as subreq is a temporary array and the requests inside are copied using the subreq_count. Moreover, from a technical perspective these are supposed to be set to MPI_REQUEST_NULL and not to 0. This comment apply everywhere where such array is used.","created_at":"2018-03-26T14:48:20Z","updated_at":"2018-03-26T15:02:58Z","html_url":"https://github.com/open-mpi/ompi/pull/4962#discussion_r177117525","pull_request_url":"https://api.github.com/repos/open-mpi/ompi/pulls/4962","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/177117525"},"html":{"href":"https://github.com/open-mpi/ompi/pull/4962#discussion_r177117525"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/4962"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/4962","id":177237986,"html_url":"https://github.com/open-mpi/ompi/pull/4962","diff_url":"https://github.com/open-mpi/ompi/pull/4962.diff","patch_url":"https://github.com/open-mpi/ompi/pull/4962.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/4962","number":4962,"state":"open","locked":false,"title":"A bunch of CID fixes","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars2.githubusercontent.com/u/617316?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"body":"Fix a variety of low-impact Coverity issues.","created_at":"2018-03-24T13:44:44Z","updated_at":"2018-03-26T15:02:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ef9729d3b557d0f7d86be62d75e2e30290ebd34","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hjelmn","id":1226817,"avatar_url":"https://avatars1.githubusercontent.com/u/1226817?v=4","gravatar_id":"","url":"https://api.github.com/users/hjelmn","html_url":"https://github.com/hjelmn","followers_url":"https://api.github.com/users/hjelmn/followers","following_url":"https://api.github.com/users/hjelmn/following{/other_user}","gists_url":"https://api.github.com/users/hjelmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hjelmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjelmn/subscriptions","organizations_url":"https://api.github.com/users/hjelmn/orgs","repos_url":"https://api.github.com/users/hjelmn/repos","events_url":"https://api.github.com/users/hjelmn/events{/privacy}","received_events_url":"https://api.github.com/users/hjelmn/received_events","type":"User","site_admin":false},{"login":"edgargabriel","id":8238622,"avatar_url":"https://avatars2.githubusercontent.com/u/8238622?v=4","gravatar_id":"","url":"https://api.github.com/users/edgargabriel","html_url":"https://github.com/edgargabriel","followers_url":"https://api.github.com/users/edgargabriel/followers","following_url":"https://api.github.com/users/edgargabriel/following{/other_user}","gists_url":"https://api.github.com/users/edgargabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/edgargabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgargabriel/subscriptions","organizations_url":"https://api.github.com/users/edgargabriel/orgs","repos_url":"https://api.github.com/users/edgargabriel/repos","events_url":"https://api.github.com/users/edgargabriel/events{/privacy}","received_events_url":"https://api.github.com/users/edgargabriel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":129984007,"url":"https://api.github.com/repos/open-mpi/ompi/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/4962/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/4962/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/4962/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/863299976b787464c26caf2ed82887bba11d32d0","head":{"label":"jsquyres:pr/cid-fixes","ref":"pr/cid-fixes","sha":"863299976b787464c26caf2ed82887bba11d32d0","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars2.githubusercontent.com/u/617316?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"repo":{"id":24734558,"name":"ompi","full_name":"jsquyres/ompi","owner":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars2.githubusercontent.com/u/617316?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsquyres/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/jsquyres/ompi","forks_url":"https://api.github.com/repos/jsquyres/ompi/forks","keys_url":"https://api.github.com/repos/jsquyres/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsquyres/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsquyres/ompi/teams","hooks_url":"https://api.github.com/repos/jsquyres/ompi/hooks","issue_events_url":"https://api.github.com/repos/jsquyres/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/jsquyres/ompi/events","assignees_url":"https://api.github.com/repos/jsquyres/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/jsquyres/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/jsquyres/ompi/tags","blobs_url":"https://api.github.com/repos/jsquyres/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsquyres/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsquyres/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsquyres/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsquyres/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/jsquyres/ompi/languages","stargazers_url":"https://api.github.com/repos/jsquyres/ompi/stargazers","contributors_url":"https://api.github.com/repos/jsquyres/ompi/contributors","subscribers_url":"https://api.github.com/repos/jsquyres/ompi/subscribers","subscription_url":"https://api.github.com/repos/jsquyres/ompi/subscription","commits_url":"https://api.github.com/repos/jsquyres/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsquyres/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsquyres/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsquyres/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsquyres/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/jsquyres/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsquyres/ompi/merges","archive_url":"https://api.github.com/repos/jsquyres/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsquyres/ompi/downloads","issues_url":"https://api.github.com/repos/jsquyres/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/jsquyres/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/jsquyres/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/jsquyres/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsquyres/ompi/labels{/name}","releases_url":"https://api.github.com/repos/jsquyres/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/jsquyres/ompi/deployments","created_at":"2014-10-02T20:06:11Z","updated_at":"2016-03-25T22:01:17Z","pushed_at":"2018-03-26T14:35:12Z","git_url":"git://github.com/jsquyres/ompi.git","ssh_url":"git@github.com:jsquyres/ompi.git","clone_url":"https://github.com/jsquyres/ompi.git","svn_url":"https://github.com/jsquyres/ompi","homepage":null,"size":119580,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"19e85a32984146612b14f0bf2b9d3c4bd685d49d","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2018-03-26T01:24:50Z","pushed_at":"2018-03-26T14:35:15Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":114649,"stargazers_count":492,"watchers_count":492,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":364,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":309,"open_issues":364,"watchers":492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/4962"},"html":{"href":"https://github.com/open-mpi/ompi/pull/4962"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/4962"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/4962/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/4962/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/4962/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/863299976b787464c26caf2ed82887bba11d32d0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bosilca"}}