{"action":"created","issue":{"url":"https://api.github.com/repos/mullvad/openvpn/issues/4","repository_url":"https://api.github.com/repos/mullvad/openvpn","labels_url":"https://api.github.com/repos/mullvad/openvpn/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/mullvad/openvpn/issues/4/comments","events_url":"https://api.github.com/repos/mullvad/openvpn/issues/4/events","html_url":"https://github.com/mullvad/openvpn/pull/4","id":322810170,"number":4,"title":"Send auth. failure reason between server and client plugins","user":{"login":"jvff","id":3216731,"avatar_url":"https://avatars3.githubusercontent.com/u/3216731?v=4","gravatar_id":"","url":"https://api.github.com/users/jvff","html_url":"https://github.com/jvff","followers_url":"https://api.github.com/users/jvff/followers","following_url":"https://api.github.com/users/jvff/following{/other_user}","gists_url":"https://api.github.com/users/jvff/gists{/gist_id}","starred_url":"https://api.github.com/users/jvff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvff/subscriptions","organizations_url":"https://api.github.com/users/jvff/orgs","repos_url":"https://api.github.com/users/jvff/repos","events_url":"https://api.github.com/users/jvff/events{/privacy}","received_events_url":"https://api.github.com/users/jvff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"faern","id":332294,"avatar_url":"https://avatars1.githubusercontent.com/u/332294?v=4","gravatar_id":"","url":"https://api.github.com/users/faern","html_url":"https://github.com/faern","followers_url":"https://api.github.com/users/faern/followers","following_url":"https://api.github.com/users/faern/following{/other_user}","gists_url":"https://api.github.com/users/faern/gists{/gist_id}","starred_url":"https://api.github.com/users/faern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faern/subscriptions","organizations_url":"https://api.github.com/users/faern/orgs","repos_url":"https://api.github.com/users/faern/repos","events_url":"https://api.github.com/users/faern/events{/privacy}","received_events_url":"https://api.github.com/users/faern/received_events","type":"User","site_admin":false},"assignees":[{"login":"faern","id":332294,"avatar_url":"https://avatars1.githubusercontent.com/u/332294?v=4","gravatar_id":"","url":"https://api.github.com/users/faern","html_url":"https://github.com/faern","followers_url":"https://api.github.com/users/faern/followers","following_url":"https://api.github.com/users/faern/following{/other_user}","gists_url":"https://api.github.com/users/faern/gists{/gist_id}","starred_url":"https://api.github.com/users/faern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faern/subscriptions","organizations_url":"https://api.github.com/users/faern/orgs","repos_url":"https://api.github.com/users/faern/repos","events_url":"https://api.github.com/users/faern/events{/privacy}","received_events_url":"https://api.github.com/users/faern/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-05-14T13:11:13Z","updated_at":"2018-05-15T09:48:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mullvad/openvpn/pulls/4","html_url":"https://github.com/mullvad/openvpn/pull/4","diff_url":"https://github.com/mullvad/openvpn/pull/4.diff","patch_url":"https://github.com/mullvad/openvpn/pull/4.patch"},"body":"This is the port of the changes sent to upstream OpenVPN. This replaces PR #2, so that one should be closed after this PR is merged.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mullvad/openvpn/4)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/mullvad/openvpn/issues/comments/389109485","html_url":"https://github.com/mullvad/openvpn/pull/4#issuecomment-389109485","issue_url":"https://api.github.com/repos/mullvad/openvpn/issues/4","id":389109485,"user":{"login":"jvff","id":3216731,"avatar_url":"https://avatars3.githubusercontent.com/u/3216731?v=4","gravatar_id":"","url":"https://api.github.com/users/jvff","html_url":"https://github.com/jvff","followers_url":"https://api.github.com/users/jvff/followers","following_url":"https://api.github.com/users/jvff/following{/other_user}","gists_url":"https://api.github.com/users/jvff/gists{/gist_id}","starred_url":"https://api.github.com/users/jvff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvff/subscriptions","organizations_url":"https://api.github.com/users/jvff/orgs","repos_url":"https://api.github.com/users/jvff/repos","events_url":"https://api.github.com/users/jvff/events{/privacy}","received_events_url":"https://api.github.com/users/jvff/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T09:48:34Z","updated_at":"2018-05-15T09:48:34Z","author_association":"NONE","body":"\n\n\n\n\n\n\n\n*[src/openvpn/push.c, line 77 at r2](https://reviewable.io/reviews/mullvad/openvpn/4#-LCTyEHM1ikVSdsST6vu:-LCYBP6x8V4wOlb85lEq:byk80ft) ([raw file](https://github.com/mullvad/openvpn/blob/24d5892cc71ff2c411913b4c5780d7d2c0f6b4e5/src/openvpn/push.c#L77)):*\n<details><summary><i>Previously, faern (Linus Färnstrand) wrote…</i></summary><blockquote>\n\nDepending on how one define necessary I guess. With the `#ifdef` the code will be removed and the binary smaller and simpler. Does not have to do the branching at all at runtime. Like with management, I suppose `if (management)` will always be false when management is disabled even without the conditional compilation in place?\n\nBut from searching the code base it seems inconsistent if they guard such parts with `#ifdef` or not, so I'm not sure what the desired solution upstream is.\n</blockquote></details>\n\nIn the end the result should be the same, the compiler should just remove the dead code, but it's true that some extra compilation time is needed whereas the preprocessor could just have removed it very early.\n\nI still don't completely understand how OpenVPN configures itself, it seems to be complex. Hopefully someone upstream will give us some feedback :/\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/mullvad/openvpn/4)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jvff"}}