{"action":"created","comment":{"url":"https://api.github.com/repos/Vasar007/FANUC/pulls/comments/170432037","pull_request_review_id":99122779,"id":170432037,"diff_hunk":"@@ -0,0 +1,57 @@\n+#include \"newRM.h\"\n+#define PI 3.14159265\n+\n+\n+RoboModel::DhParameters::\n+DhParameters(const double d, const double q, const double a, const double alpha)\n+    : _dParam(d),\n+      _qParam(q),\n+      _aParam(a),\n+      _alphaParam(alpha)\n+{\n+}\n+\n+\n+RoboModel::RoboModel(std::vector<std::array<double, 4>> input)\n+{\n+    _kinematicChain.reserve(input.size());\n+    for (auto& i : input)\n+        _kinematicChain.emplace_back(i[0], i[1], i[2], i[3]);","path":"TenzoMath/Source/newRM.cpp","position":19,"original_position":19,"commit_id":"a9bf6add462426f7db5596bc72fbb1a6b96cd133","original_commit_id":"a9bf6add462426f7db5596bc72fbb1a6b96cd133","user":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"body":"**(note, repeatedly)**: Does not match our code style!","created_at":"2018-02-24T20:45:05Z","updated_at":"2018-02-24T20:46:25Z","html_url":"https://github.com/Vasar007/FANUC/pull/26#discussion_r170432037","pull_request_url":"https://api.github.com/repos/Vasar007/FANUC/pulls/26","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Vasar007/FANUC/pulls/comments/170432037"},"html":{"href":"https://github.com/Vasar007/FANUC/pull/26#discussion_r170432037"},"pull_request":{"href":"https://api.github.com/repos/Vasar007/FANUC/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Vasar007/FANUC/pulls/26","id":170845839,"html_url":"https://github.com/Vasar007/FANUC/pull/26","diff_url":"https://github.com/Vasar007/FANUC/pull/26.diff","patch_url":"https://github.com/Vasar007/FANUC/pull/26.patch","issue_url":"https://api.github.com/repos/Vasar007/FANUC/issues/26","number":26,"state":"open","locked":false,"title":"Strain Gauge module import","user":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"body":"- Impoorted `Strain Gauge` and module of @nikita03565;\r\n- Added additional cond_var in `ServerLayer`;\r\n- Removed extra headers and libs;\r\n- Added SFML-64 support;\r\n- Swapped some safe-functions from `SimpleClient` to `ServerLayer`;\r\n- Replaced all `reinterpet_cast`s with double `static_cast`;\r\n- Reworked launch methods of `SimpleCient` and `ServerLayer`;\r\n- Deleted additional dependencies folders;\r\n- Changed code with new code style.\r\n\r\nStart your review with this file:\r\nhttps://github.com/Vasar007/FANUC/pull/26/files#diff-666aa04ddf406851bd27d0dcf36921d0","created_at":"2018-02-22T19:37:54Z","updated_at":"2018-02-24T20:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aea67b0b7ecf498cde56f4d945d98f09411e2e1","assignee":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"assignees":[{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},{"login":"danila19991","id":21951917,"avatar_url":"https://avatars2.githubusercontent.com/u/21951917?v=4","gravatar_id":"","url":"https://api.github.com/users/danila19991","html_url":"https://github.com/danila19991","followers_url":"https://api.github.com/users/danila19991/followers","following_url":"https://api.github.com/users/danila19991/following{/other_user}","gists_url":"https://api.github.com/users/danila19991/gists{/gist_id}","starred_url":"https://api.github.com/users/danila19991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danila19991/subscriptions","organizations_url":"https://api.github.com/users/danila19991/orgs","repos_url":"https://api.github.com/users/danila19991/repos","events_url":"https://api.github.com/users/danila19991/events{/privacy}","received_events_url":"https://api.github.com/users/danila19991/received_events","type":"User","site_admin":false},{"login":"ptrdiff","id":33400860,"avatar_url":"https://avatars1.githubusercontent.com/u/33400860?v=4","gravatar_id":"","url":"https://api.github.com/users/ptrdiff","html_url":"https://github.com/ptrdiff","followers_url":"https://api.github.com/users/ptrdiff/followers","following_url":"https://api.github.com/users/ptrdiff/following{/other_user}","gists_url":"https://api.github.com/users/ptrdiff/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrdiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrdiff/subscriptions","organizations_url":"https://api.github.com/users/ptrdiff/orgs","repos_url":"https://api.github.com/users/ptrdiff/repos","events_url":"https://api.github.com/users/ptrdiff/events{/privacy}","received_events_url":"https://api.github.com/users/ptrdiff/received_events","type":"User","site_admin":false},{"login":"nikita03565","id":33401112,"avatar_url":"https://avatars0.githubusercontent.com/u/33401112?v=4","gravatar_id":"","url":"https://api.github.com/users/nikita03565","html_url":"https://github.com/nikita03565","followers_url":"https://api.github.com/users/nikita03565/followers","following_url":"https://api.github.com/users/nikita03565/following{/other_user}","gists_url":"https://api.github.com/users/nikita03565/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita03565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita03565/subscriptions","organizations_url":"https://api.github.com/users/nikita03565/orgs","repos_url":"https://api.github.com/users/nikita03565/repos","events_url":"https://api.github.com/users/nikita03565/events{/privacy}","received_events_url":"https://api.github.com/users/nikita03565/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ptrdiff","id":33400860,"avatar_url":"https://avatars1.githubusercontent.com/u/33400860?v=4","gravatar_id":"","url":"https://api.github.com/users/ptrdiff","html_url":"https://github.com/ptrdiff","followers_url":"https://api.github.com/users/ptrdiff/followers","following_url":"https://api.github.com/users/ptrdiff/following{/other_user}","gists_url":"https://api.github.com/users/ptrdiff/gists{/gist_id}","starred_url":"https://api.github.com/users/ptrdiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptrdiff/subscriptions","organizations_url":"https://api.github.com/users/ptrdiff/orgs","repos_url":"https://api.github.com/users/ptrdiff/repos","events_url":"https://api.github.com/users/ptrdiff/events{/privacy}","received_events_url":"https://api.github.com/users/ptrdiff/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":741361634,"url":"https://api.github.com/repos/Vasar007/FANUC/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Vasar007/FANUC/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Vasar007/FANUC/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Vasar007/FANUC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vasar007/FANUC/issues/26/comments","statuses_url":"https://api.github.com/repos/Vasar007/FANUC/statuses/a9bf6add462426f7db5596bc72fbb1a6b96cd133","head":{"label":"Vasar007:Vasilyev","ref":"Vasilyev","sha":"a9bf6add462426f7db5596bc72fbb1a6b96cd133","user":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"repo":{"id":109609822,"name":"FANUC","full_name":"Vasar007/FANUC","owner":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vasar007/FANUC","description":"Project on robotics","fork":false,"url":"https://api.github.com/repos/Vasar007/FANUC","forks_url":"https://api.github.com/repos/Vasar007/FANUC/forks","keys_url":"https://api.github.com/repos/Vasar007/FANUC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vasar007/FANUC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vasar007/FANUC/teams","hooks_url":"https://api.github.com/repos/Vasar007/FANUC/hooks","issue_events_url":"https://api.github.com/repos/Vasar007/FANUC/issues/events{/number}","events_url":"https://api.github.com/repos/Vasar007/FANUC/events","assignees_url":"https://api.github.com/repos/Vasar007/FANUC/assignees{/user}","branches_url":"https://api.github.com/repos/Vasar007/FANUC/branches{/branch}","tags_url":"https://api.github.com/repos/Vasar007/FANUC/tags","blobs_url":"https://api.github.com/repos/Vasar007/FANUC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vasar007/FANUC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vasar007/FANUC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vasar007/FANUC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vasar007/FANUC/statuses/{sha}","languages_url":"https://api.github.com/repos/Vasar007/FANUC/languages","stargazers_url":"https://api.github.com/repos/Vasar007/FANUC/stargazers","contributors_url":"https://api.github.com/repos/Vasar007/FANUC/contributors","subscribers_url":"https://api.github.com/repos/Vasar007/FANUC/subscribers","subscription_url":"https://api.github.com/repos/Vasar007/FANUC/subscription","commits_url":"https://api.github.com/repos/Vasar007/FANUC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vasar007/FANUC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vasar007/FANUC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vasar007/FANUC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vasar007/FANUC/contents/{+path}","compare_url":"https://api.github.com/repos/Vasar007/FANUC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vasar007/FANUC/merges","archive_url":"https://api.github.com/repos/Vasar007/FANUC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vasar007/FANUC/downloads","issues_url":"https://api.github.com/repos/Vasar007/FANUC/issues{/number}","pulls_url":"https://api.github.com/repos/Vasar007/FANUC/pulls{/number}","milestones_url":"https://api.github.com/repos/Vasar007/FANUC/milestones{/number}","notifications_url":"https://api.github.com/repos/Vasar007/FANUC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vasar007/FANUC/labels{/name}","releases_url":"https://api.github.com/repos/Vasar007/FANUC/releases{/id}","deployments_url":"https://api.github.com/repos/Vasar007/FANUC/deployments","created_at":"2017-11-05T19:37:16Z","updated_at":"2017-12-04T07:54:28Z","pushed_at":"2018-02-23T09:04:03Z","git_url":"git://github.com/Vasar007/FANUC.git","ssh_url":"git@github.com:Vasar007/FANUC.git","clone_url":"https://github.com/Vasar007/FANUC.git","svn_url":"https://github.com/Vasar007/FANUC","homepage":null,"size":16613,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Vasar007:master","ref":"master","sha":"30cac9373d992ce30d9d504d54a3345207ecb5c4","user":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"repo":{"id":109609822,"name":"FANUC","full_name":"Vasar007/FANUC","owner":{"login":"Vasar007","id":21951872,"avatar_url":"https://avatars3.githubusercontent.com/u/21951872?v=4","gravatar_id":"","url":"https://api.github.com/users/Vasar007","html_url":"https://github.com/Vasar007","followers_url":"https://api.github.com/users/Vasar007/followers","following_url":"https://api.github.com/users/Vasar007/following{/other_user}","gists_url":"https://api.github.com/users/Vasar007/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasar007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasar007/subscriptions","organizations_url":"https://api.github.com/users/Vasar007/orgs","repos_url":"https://api.github.com/users/Vasar007/repos","events_url":"https://api.github.com/users/Vasar007/events{/privacy}","received_events_url":"https://api.github.com/users/Vasar007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vasar007/FANUC","description":"Project on robotics","fork":false,"url":"https://api.github.com/repos/Vasar007/FANUC","forks_url":"https://api.github.com/repos/Vasar007/FANUC/forks","keys_url":"https://api.github.com/repos/Vasar007/FANUC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vasar007/FANUC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vasar007/FANUC/teams","hooks_url":"https://api.github.com/repos/Vasar007/FANUC/hooks","issue_events_url":"https://api.github.com/repos/Vasar007/FANUC/issues/events{/number}","events_url":"https://api.github.com/repos/Vasar007/FANUC/events","assignees_url":"https://api.github.com/repos/Vasar007/FANUC/assignees{/user}","branches_url":"https://api.github.com/repos/Vasar007/FANUC/branches{/branch}","tags_url":"https://api.github.com/repos/Vasar007/FANUC/tags","blobs_url":"https://api.github.com/repos/Vasar007/FANUC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vasar007/FANUC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vasar007/FANUC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vasar007/FANUC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vasar007/FANUC/statuses/{sha}","languages_url":"https://api.github.com/repos/Vasar007/FANUC/languages","stargazers_url":"https://api.github.com/repos/Vasar007/FANUC/stargazers","contributors_url":"https://api.github.com/repos/Vasar007/FANUC/contributors","subscribers_url":"https://api.github.com/repos/Vasar007/FANUC/subscribers","subscription_url":"https://api.github.com/repos/Vasar007/FANUC/subscription","commits_url":"https://api.github.com/repos/Vasar007/FANUC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vasar007/FANUC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vasar007/FANUC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vasar007/FANUC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vasar007/FANUC/contents/{+path}","compare_url":"https://api.github.com/repos/Vasar007/FANUC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vasar007/FANUC/merges","archive_url":"https://api.github.com/repos/Vasar007/FANUC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vasar007/FANUC/downloads","issues_url":"https://api.github.com/repos/Vasar007/FANUC/issues{/number}","pulls_url":"https://api.github.com/repos/Vasar007/FANUC/pulls{/number}","milestones_url":"https://api.github.com/repos/Vasar007/FANUC/milestones{/number}","notifications_url":"https://api.github.com/repos/Vasar007/FANUC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vasar007/FANUC/labels{/name}","releases_url":"https://api.github.com/repos/Vasar007/FANUC/releases{/id}","deployments_url":"https://api.github.com/repos/Vasar007/FANUC/deployments","created_at":"2017-11-05T19:37:16Z","updated_at":"2017-12-04T07:54:28Z","pushed_at":"2018-02-23T09:04:03Z","git_url":"git://github.com/Vasar007/FANUC.git","ssh_url":"git@github.com:Vasar007/FANUC.git","clone_url":"https://github.com/Vasar007/FANUC.git","svn_url":"https://github.com/Vasar007/FANUC","homepage":null,"size":16613,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vasar007/FANUC/pulls/26"},"html":{"href":"https://github.com/Vasar007/FANUC/pull/26"},"issue":{"href":"https://api.github.com/repos/Vasar007/FANUC/issues/26"},"comments":{"href":"https://api.github.com/repos/Vasar007/FANUC/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Vasar007/FANUC/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Vasar007/FANUC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vasar007/FANUC/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Vasar007/FANUC/statuses/a9bf6add462426f7db5596bc72fbb1a6b96cd133"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Vasar007"}}