{"action":"closed","number":238,"pull_request":{"url":"https://api.github.com/repos/sveltejs/sapper/pulls/238","id":181722753,"html_url":"https://github.com/sveltejs/sapper/pull/238","diff_url":"https://github.com/sveltejs/sapper/pull/238.diff","patch_url":"https://github.com/sveltejs/sapper/pull/238.patch","issue_url":"https://api.github.com/repos/sveltejs/sapper/issues/238","number":238,"state":"closed","locked":false,"title":"feature(service-worker): Allow disabling service-worker with DISABLE_SERVICE_WORKER environment variable","user":{"login":"hexagon6","id":6619032,"avatar_url":"https://avatars1.githubusercontent.com/u/6619032?v=4","gravatar_id":"","url":"https://api.github.com/users/hexagon6","html_url":"https://github.com/hexagon6","followers_url":"https://api.github.com/users/hexagon6/followers","following_url":"https://api.github.com/users/hexagon6/following{/other_user}","gists_url":"https://api.github.com/users/hexagon6/gists{/gist_id}","starred_url":"https://api.github.com/users/hexagon6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexagon6/subscriptions","organizations_url":"https://api.github.com/users/hexagon6/orgs","repos_url":"https://api.github.com/users/hexagon6/repos","events_url":"https://api.github.com/users/hexagon6/events{/privacy}","received_events_url":"https://api.github.com/users/hexagon6/received_events","type":"User","site_admin":false},"body":"feature(service-worker): Allow disabling service-worker with `DISABLE_SERVICE_WORKER` environment variable.\r\n\r\nThis feature allows to disable service workers, when starting sapper. e.g. `DISABLE_SERVICE_WORKER=true sapper dev`\r\n\r\nThis can make sense if you're developing and unreliable cache invalidation breaks your development experience, since service workers can break the refresh button: https://redfin.engineering/service-workers-break-the-browsers-refresh-button-by-default-here-s-why-56f9417694\r\n\r\nI know this does not solve the problem, but might be useful if you don't want to hassle with the refreshing behavior of your browser.\r\n\r\n@Rich-Harris If you think this deserves to be set in a different way, let me know and I'll change it.","created_at":"2018-04-15T21:44:31Z","updated_at":"2018-04-15T22:13:29Z","closed_at":"2018-04-15T22:13:29Z","merged_at":null,"merge_commit_sha":"a45fd7df74ea7fc4d55ce46d5ed02013642fd315","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sveltejs/sapper/pulls/238/commits","review_comments_url":"https://api.github.com/repos/sveltejs/sapper/pulls/238/comments","review_comment_url":"https://api.github.com/repos/sveltejs/sapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sveltejs/sapper/issues/238/comments","statuses_url":"https://api.github.com/repos/sveltejs/sapper/statuses/5a75b02101c964de197b1860f0c73f1a4f375bf0","head":{"label":"hexagon6:master","ref":"master","sha":"5a75b02101c964de197b1860f0c73f1a4f375bf0","user":{"login":"hexagon6","id":6619032,"avatar_url":"https://avatars1.githubusercontent.com/u/6619032?v=4","gravatar_id":"","url":"https://api.github.com/users/hexagon6","html_url":"https://github.com/hexagon6","followers_url":"https://api.github.com/users/hexagon6/followers","following_url":"https://api.github.com/users/hexagon6/following{/other_user}","gists_url":"https://api.github.com/users/hexagon6/gists{/gist_id}","starred_url":"https://api.github.com/users/hexagon6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexagon6/subscriptions","organizations_url":"https://api.github.com/users/hexagon6/orgs","repos_url":"https://api.github.com/users/hexagon6/repos","events_url":"https://api.github.com/users/hexagon6/events{/privacy}","received_events_url":"https://api.github.com/users/hexagon6/received_events","type":"User","site_admin":false},"repo":{"id":129649389,"name":"sapper","full_name":"hexagon6/sapper","owner":{"login":"hexagon6","id":6619032,"avatar_url":"https://avatars1.githubusercontent.com/u/6619032?v=4","gravatar_id":"","url":"https://api.github.com/users/hexagon6","html_url":"https://github.com/hexagon6","followers_url":"https://api.github.com/users/hexagon6/followers","following_url":"https://api.github.com/users/hexagon6/following{/other_user}","gists_url":"https://api.github.com/users/hexagon6/gists{/gist_id}","starred_url":"https://api.github.com/users/hexagon6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexagon6/subscriptions","organizations_url":"https://api.github.com/users/hexagon6/orgs","repos_url":"https://api.github.com/users/hexagon6/repos","events_url":"https://api.github.com/users/hexagon6/events{/privacy}","received_events_url":"https://api.github.com/users/hexagon6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hexagon6/sapper","description":"Military-grade progressive web apps, powered by Svelte","fork":true,"url":"https://api.github.com/repos/hexagon6/sapper","forks_url":"https://api.github.com/repos/hexagon6/sapper/forks","keys_url":"https://api.github.com/repos/hexagon6/sapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexagon6/sapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexagon6/sapper/teams","hooks_url":"https://api.github.com/repos/hexagon6/sapper/hooks","issue_events_url":"https://api.github.com/repos/hexagon6/sapper/issues/events{/number}","events_url":"https://api.github.com/repos/hexagon6/sapper/events","assignees_url":"https://api.github.com/repos/hexagon6/sapper/assignees{/user}","branches_url":"https://api.github.com/repos/hexagon6/sapper/branches{/branch}","tags_url":"https://api.github.com/repos/hexagon6/sapper/tags","blobs_url":"https://api.github.com/repos/hexagon6/sapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexagon6/sapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexagon6/sapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexagon6/sapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexagon6/sapper/statuses/{sha}","languages_url":"https://api.github.com/repos/hexagon6/sapper/languages","stargazers_url":"https://api.github.com/repos/hexagon6/sapper/stargazers","contributors_url":"https://api.github.com/repos/hexagon6/sapper/contributors","subscribers_url":"https://api.github.com/repos/hexagon6/sapper/subscribers","subscription_url":"https://api.github.com/repos/hexagon6/sapper/subscription","commits_url":"https://api.github.com/repos/hexagon6/sapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexagon6/sapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexagon6/sapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexagon6/sapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexagon6/sapper/contents/{+path}","compare_url":"https://api.github.com/repos/hexagon6/sapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexagon6/sapper/merges","archive_url":"https://api.github.com/repos/hexagon6/sapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexagon6/sapper/downloads","issues_url":"https://api.github.com/repos/hexagon6/sapper/issues{/number}","pulls_url":"https://api.github.com/repos/hexagon6/sapper/pulls{/number}","milestones_url":"https://api.github.com/repos/hexagon6/sapper/milestones{/number}","notifications_url":"https://api.github.com/repos/hexagon6/sapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexagon6/sapper/labels{/name}","releases_url":"https://api.github.com/repos/hexagon6/sapper/releases{/id}","deployments_url":"https://api.github.com/repos/hexagon6/sapper/deployments","created_at":"2018-04-15T20:47:04Z","updated_at":"2018-04-15T21:14:50Z","pushed_at":"2018-04-15T21:14:49Z","git_url":"git://github.com/hexagon6/sapper.git","ssh_url":"git@github.com:hexagon6/sapper.git","clone_url":"https://github.com/hexagon6/sapper.git","svn_url":"https://github.com/hexagon6/sapper","homepage":"https://sapper.svelte.technology","size":1225,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sveltejs:master","ref":"master","sha":"2758382c68d4ba56eae53119436fb97929be69bb","user":{"login":"sveltejs","id":23617963,"avatar_url":"https://avatars1.githubusercontent.com/u/23617963?v=4","gravatar_id":"","url":"https://api.github.com/users/sveltejs","html_url":"https://github.com/sveltejs","followers_url":"https://api.github.com/users/sveltejs/followers","following_url":"https://api.github.com/users/sveltejs/following{/other_user}","gists_url":"https://api.github.com/users/sveltejs/gists{/gist_id}","starred_url":"https://api.github.com/users/sveltejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveltejs/subscriptions","organizations_url":"https://api.github.com/users/sveltejs/orgs","repos_url":"https://api.github.com/users/sveltejs/repos","events_url":"https://api.github.com/users/sveltejs/events{/privacy}","received_events_url":"https://api.github.com/users/sveltejs/received_events","type":"Organization","site_admin":false},"repo":{"id":113865039,"name":"sapper","full_name":"sveltejs/sapper","owner":{"login":"sveltejs","id":23617963,"avatar_url":"https://avatars1.githubusercontent.com/u/23617963?v=4","gravatar_id":"","url":"https://api.github.com/users/sveltejs","html_url":"https://github.com/sveltejs","followers_url":"https://api.github.com/users/sveltejs/followers","following_url":"https://api.github.com/users/sveltejs/following{/other_user}","gists_url":"https://api.github.com/users/sveltejs/gists{/gist_id}","starred_url":"https://api.github.com/users/sveltejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveltejs/subscriptions","organizations_url":"https://api.github.com/users/sveltejs/orgs","repos_url":"https://api.github.com/users/sveltejs/repos","events_url":"https://api.github.com/users/sveltejs/events{/privacy}","received_events_url":"https://api.github.com/users/sveltejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sveltejs/sapper","description":"Military-grade progressive web apps, powered by Svelte","fork":false,"url":"https://api.github.com/repos/sveltejs/sapper","forks_url":"https://api.github.com/repos/sveltejs/sapper/forks","keys_url":"https://api.github.com/repos/sveltejs/sapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sveltejs/sapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sveltejs/sapper/teams","hooks_url":"https://api.github.com/repos/sveltejs/sapper/hooks","issue_events_url":"https://api.github.com/repos/sveltejs/sapper/issues/events{/number}","events_url":"https://api.github.com/repos/sveltejs/sapper/events","assignees_url":"https://api.github.com/repos/sveltejs/sapper/assignees{/user}","branches_url":"https://api.github.com/repos/sveltejs/sapper/branches{/branch}","tags_url":"https://api.github.com/repos/sveltejs/sapper/tags","blobs_url":"https://api.github.com/repos/sveltejs/sapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sveltejs/sapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sveltejs/sapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/sveltejs/sapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sveltejs/sapper/statuses/{sha}","languages_url":"https://api.github.com/repos/sveltejs/sapper/languages","stargazers_url":"https://api.github.com/repos/sveltejs/sapper/stargazers","contributors_url":"https://api.github.com/repos/sveltejs/sapper/contributors","subscribers_url":"https://api.github.com/repos/sveltejs/sapper/subscribers","subscription_url":"https://api.github.com/repos/sveltejs/sapper/subscription","commits_url":"https://api.github.com/repos/sveltejs/sapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/sveltejs/sapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/sveltejs/sapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/sveltejs/sapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/sveltejs/sapper/contents/{+path}","compare_url":"https://api.github.com/repos/sveltejs/sapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sveltejs/sapper/merges","archive_url":"https://api.github.com/repos/sveltejs/sapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sveltejs/sapper/downloads","issues_url":"https://api.github.com/repos/sveltejs/sapper/issues{/number}","pulls_url":"https://api.github.com/repos/sveltejs/sapper/pulls{/number}","milestones_url":"https://api.github.com/repos/sveltejs/sapper/milestones{/number}","notifications_url":"https://api.github.com/repos/sveltejs/sapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sveltejs/sapper/labels{/name}","releases_url":"https://api.github.com/repos/sveltejs/sapper/releases{/id}","deployments_url":"https://api.github.com/repos/sveltejs/sapper/deployments","created_at":"2017-12-11T13:54:33Z","updated_at":"2018-04-15T10:15:32Z","pushed_at":"2018-04-15T21:44:32Z","git_url":"git://github.com/sveltejs/sapper.git","ssh_url":"git@github.com:sveltejs/sapper.git","clone_url":"https://github.com/sveltejs/sapper.git","svn_url":"https://github.com/sveltejs/sapper","homepage":"https://sapper.svelte.technology","size":1224,"stargazers_count":756,"watchers_count":756,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":32,"open_issues":53,"watchers":756,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sveltejs/sapper/pulls/238"},"html":{"href":"https://github.com/sveltejs/sapper/pull/238"},"issue":{"href":"https://api.github.com/repos/sveltejs/sapper/issues/238"},"comments":{"href":"https://api.github.com/repos/sveltejs/sapper/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/sveltejs/sapper/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/sveltejs/sapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sveltejs/sapper/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/sveltejs/sapper/statuses/5a75b02101c964de197b1860f0c73f1a4f375bf0"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"hexagon6"}}