{"action":"created","comment":{"url":"https://api.github.com/repos/neulab/xnmt/pulls/comments/185422234","pull_request_review_id":116802408,"id":185422234,"diff_hunk":"@@ -25,25 +26,38 @@ def get_padded_sent(self, token, pad_len):\n class SimpleSentenceInput(Input):\n   \"\"\"\n   A simple sent, represented as a list of tokens\n-  \n+\n   Args:\n     words (List[int]): list of integer word ids\n-    vocab (Vocab):\n+    Annotation (Dict): annotation for the sentence","path":"xnmt/input.py","position":24,"original_position":24,"commit_id":"9d481eadc7cc312b03a7b6bfe64b2aaaa4187d4f","original_commit_id":"9d481eadc7cc312b03a7b6bfe64b2aaaa4187d4f","user":{"login":"msperber","id":1821303,"avatar_url":"https://avatars2.githubusercontent.com/u/1821303?v=4","gravatar_id":"","url":"https://api.github.com/users/msperber","html_url":"https://github.com/msperber","followers_url":"https://api.github.com/users/msperber/followers","following_url":"https://api.github.com/users/msperber/following{/other_user}","gists_url":"https://api.github.com/users/msperber/gists{/gist_id}","starred_url":"https://api.github.com/users/msperber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msperber/subscriptions","organizations_url":"https://api.github.com/users/msperber/orgs","repos_url":"https://api.github.com/users/msperber/repos","events_url":"https://api.github.com/users/msperber/events{/privacy}","received_events_url":"https://api.github.com/users/msperber/received_events","type":"User","site_admin":false},"body":"Could you remove the annotation here, and instead directly pass the information to the component that needs it (maybe using ```!Ref```) if possible? Given the growing number of features in XNMT, I think it is becoming more and more important to keep the basic interface clean. (I think you mentioned before that this would be possible)","created_at":"2018-05-02T08:18:20Z","updated_at":"2018-05-02T08:26:26Z","html_url":"https://github.com/neulab/xnmt/pull/380#discussion_r185422234","pull_request_url":"https://api.github.com/repos/neulab/xnmt/pulls/380","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/comments/185422234"},"html":{"href":"https://github.com/neulab/xnmt/pull/380#discussion_r185422234"},"pull_request":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/neulab/xnmt/pulls/380","id":185335442,"html_url":"https://github.com/neulab/xnmt/pull/380","diff_url":"https://github.com/neulab/xnmt/pull/380.diff","patch_url":"https://github.com/neulab/xnmt/pull/380.patch","issue_url":"https://api.github.com/repos/neulab/xnmt/issues/380","number":380,"state":"open","locked":false,"title":"Merge Latest segmenting transducer","user":{"login":"philip30","id":5228140,"avatar_url":"https://avatars1.githubusercontent.com/u/5228140?v=4","gravatar_id":"","url":"https://api.github.com/users/philip30","html_url":"https://github.com/philip30","followers_url":"https://api.github.com/users/philip30/followers","following_url":"https://api.github.com/users/philip30/following{/other_user}","gists_url":"https://api.github.com/users/philip30/gists{/gist_id}","starred_url":"https://api.github.com/users/philip30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philip30/subscriptions","organizations_url":"https://api.github.com/users/philip30/orgs","repos_url":"https://api.github.com/users/philip30/repos","events_url":"https://api.github.com/users/philip30/events{/privacy}","received_events_url":"https://api.github.com/users/philip30/received_events","type":"User","site_admin":false},"body":"This is all the works on the segmenting transducer. It is working, and I'd want to merge so that I don't have to always merge things manually. This branch is still WIP.","created_at":"2018-05-02T04:57:09Z","updated_at":"2018-05-02T08:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5638f8fc1338b5597ba67e7a93fd532b93cc905","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neulab/xnmt/pulls/380/commits","review_comments_url":"https://api.github.com/repos/neulab/xnmt/pulls/380/comments","review_comment_url":"https://api.github.com/repos/neulab/xnmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neulab/xnmt/issues/380/comments","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/9d481eadc7cc312b03a7b6bfe64b2aaaa4187d4f","head":{"label":"neulab:segmentation_experiment","ref":"segmentation_experiment","sha":"9d481eadc7cc312b03a7b6bfe64b2aaaa4187d4f","user":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"repo":{"id":79833244,"name":"xnmt","full_name":"neulab/xnmt","owner":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neulab/xnmt","description":"eXtensible Neural Machine Translation","fork":false,"url":"https://api.github.com/repos/neulab/xnmt","forks_url":"https://api.github.com/repos/neulab/xnmt/forks","keys_url":"https://api.github.com/repos/neulab/xnmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neulab/xnmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neulab/xnmt/teams","hooks_url":"https://api.github.com/repos/neulab/xnmt/hooks","issue_events_url":"https://api.github.com/repos/neulab/xnmt/issues/events{/number}","events_url":"https://api.github.com/repos/neulab/xnmt/events","assignees_url":"https://api.github.com/repos/neulab/xnmt/assignees{/user}","branches_url":"https://api.github.com/repos/neulab/xnmt/branches{/branch}","tags_url":"https://api.github.com/repos/neulab/xnmt/tags","blobs_url":"https://api.github.com/repos/neulab/xnmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neulab/xnmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neulab/xnmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neulab/xnmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neulab/xnmt/languages","stargazers_url":"https://api.github.com/repos/neulab/xnmt/stargazers","contributors_url":"https://api.github.com/repos/neulab/xnmt/contributors","subscribers_url":"https://api.github.com/repos/neulab/xnmt/subscribers","subscription_url":"https://api.github.com/repos/neulab/xnmt/subscription","commits_url":"https://api.github.com/repos/neulab/xnmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neulab/xnmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neulab/xnmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neulab/xnmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neulab/xnmt/contents/{+path}","compare_url":"https://api.github.com/repos/neulab/xnmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neulab/xnmt/merges","archive_url":"https://api.github.com/repos/neulab/xnmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neulab/xnmt/downloads","issues_url":"https://api.github.com/repos/neulab/xnmt/issues{/number}","pulls_url":"https://api.github.com/repos/neulab/xnmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neulab/xnmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neulab/xnmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neulab/xnmt/labels{/name}","releases_url":"https://api.github.com/repos/neulab/xnmt/releases{/id}","deployments_url":"https://api.github.com/repos/neulab/xnmt/deployments","created_at":"2017-01-23T18:18:54Z","updated_at":"2018-05-02T04:10:55Z","pushed_at":"2018-05-02T05:01:27Z","git_url":"git://github.com/neulab/xnmt.git","ssh_url":"git@github.com:neulab/xnmt.git","clone_url":"https://github.com/neulab/xnmt.git","svn_url":"https://github.com/neulab/xnmt","homepage":null,"size":17147,"stargazers_count":88,"watchers_count":88,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":24,"open_issues":22,"watchers":88,"default_branch":"master"}},"base":{"label":"neulab:master","ref":"master","sha":"b303ec2e5540efef9dfbaf7722de0d4e8f568503","user":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"repo":{"id":79833244,"name":"xnmt","full_name":"neulab/xnmt","owner":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neulab/xnmt","description":"eXtensible Neural Machine Translation","fork":false,"url":"https://api.github.com/repos/neulab/xnmt","forks_url":"https://api.github.com/repos/neulab/xnmt/forks","keys_url":"https://api.github.com/repos/neulab/xnmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neulab/xnmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neulab/xnmt/teams","hooks_url":"https://api.github.com/repos/neulab/xnmt/hooks","issue_events_url":"https://api.github.com/repos/neulab/xnmt/issues/events{/number}","events_url":"https://api.github.com/repos/neulab/xnmt/events","assignees_url":"https://api.github.com/repos/neulab/xnmt/assignees{/user}","branches_url":"https://api.github.com/repos/neulab/xnmt/branches{/branch}","tags_url":"https://api.github.com/repos/neulab/xnmt/tags","blobs_url":"https://api.github.com/repos/neulab/xnmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neulab/xnmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neulab/xnmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neulab/xnmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neulab/xnmt/languages","stargazers_url":"https://api.github.com/repos/neulab/xnmt/stargazers","contributors_url":"https://api.github.com/repos/neulab/xnmt/contributors","subscribers_url":"https://api.github.com/repos/neulab/xnmt/subscribers","subscription_url":"https://api.github.com/repos/neulab/xnmt/subscription","commits_url":"https://api.github.com/repos/neulab/xnmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neulab/xnmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neulab/xnmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neulab/xnmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neulab/xnmt/contents/{+path}","compare_url":"https://api.github.com/repos/neulab/xnmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neulab/xnmt/merges","archive_url":"https://api.github.com/repos/neulab/xnmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neulab/xnmt/downloads","issues_url":"https://api.github.com/repos/neulab/xnmt/issues{/number}","pulls_url":"https://api.github.com/repos/neulab/xnmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neulab/xnmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neulab/xnmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neulab/xnmt/labels{/name}","releases_url":"https://api.github.com/repos/neulab/xnmt/releases{/id}","deployments_url":"https://api.github.com/repos/neulab/xnmt/deployments","created_at":"2017-01-23T18:18:54Z","updated_at":"2018-05-02T04:10:55Z","pushed_at":"2018-05-02T05:01:27Z","git_url":"git://github.com/neulab/xnmt.git","ssh_url":"git@github.com:neulab/xnmt.git","clone_url":"https://github.com/neulab/xnmt.git","svn_url":"https://github.com/neulab/xnmt","homepage":null,"size":17147,"stargazers_count":88,"watchers_count":88,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":24,"open_issues":22,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/380"},"html":{"href":"https://github.com/neulab/xnmt/pull/380"},"issue":{"href":"https://api.github.com/repos/neulab/xnmt/issues/380"},"comments":{"href":"https://api.github.com/repos/neulab/xnmt/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/neulab/xnmt/statuses/9d481eadc7cc312b03a7b6bfe64b2aaaa4187d4f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"msperber"}}