{"action":"created","issue":{"url":"https://api.github.com/repos/AdamISZ/from0k2bp/issues/6","repository_url":"https://api.github.com/repos/AdamISZ/from0k2bp","labels_url":"https://api.github.com/repos/AdamISZ/from0k2bp/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/AdamISZ/from0k2bp/issues/6/comments","events_url":"https://api.github.com/repos/AdamISZ/from0k2bp/issues/6/events","html_url":"https://github.com/AdamISZ/from0k2bp/pull/6","id":357887130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzkzMTc0","number":6,"title":"Clarify section 4.2","user":{"login":"jnewbery","id":1063656,"node_id":"MDQ6VXNlcjEwNjM2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T01:32:43Z","updated_at":"2018-09-07T14:36:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/AdamISZ/from0k2bp/pulls/6","html_url":"https://github.com/AdamISZ/from0k2bp/pull/6","diff_url":"https://github.com/AdamISZ/from0k2bp/pull/6.diff","patch_url":"https://github.com/AdamISZ/from0k2bp/pull/6.patch"},"body":"A couple of places that tripped me up in section 4.2:\r\n\r\n- existing wording made it sound like dx and dy were commitments rather than nonce vectors, which the prover then sends commitments to. I've added some suggested wording changes to make this clearer.\r\n- currently, section 4.2 says that a commitment to the dot product is sent in the challenge step. I believe this should say the commitment step."},"comment":{"url":"https://api.github.com/repos/AdamISZ/from0k2bp/issues/comments/419459568","html_url":"https://github.com/AdamISZ/from0k2bp/pull/6#issuecomment-419459568","issue_url":"https://api.github.com/repos/AdamISZ/from0k2bp/issues/6","id":419459568,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQ1OTU2OA==","user":{"login":"AdamISZ","id":4278257,"node_id":"MDQ6VXNlcjQyNzgyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4278257?v=4","gravatar_id":"","url":"https://api.github.com/users/AdamISZ","html_url":"https://github.com/AdamISZ","followers_url":"https://api.github.com/users/AdamISZ/followers","following_url":"https://api.github.com/users/AdamISZ/following{/other_user}","gists_url":"https://api.github.com/users/AdamISZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamISZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamISZ/subscriptions","organizations_url":"https://api.github.com/users/AdamISZ/orgs","repos_url":"https://api.github.com/users/AdamISZ/repos","events_url":"https://api.github.com/users/AdamISZ/events{/privacy}","received_events_url":"https://api.github.com/users/AdamISZ/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T14:36:37Z","updated_at":"2018-09-07T14:36:37Z","author_association":"OWNER","body":"The first one: yes, totally agreed, the existing wording is not viable, and `nonce vector` is a good replacement name for the d_x, d_y terms.\r\nThe second one: yep, thanks.\r\nI'll merge both these PRs and update the pdf now, thanks for the review."}}
{"actor":{"display_login":"AdamISZ"}}