{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/runtime/issues/867","repository_url":"https://api.github.com/repos/kata-containers/runtime","labels_url":"https://api.github.com/repos/kata-containers/runtime/issues/867/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/867/comments","events_url":"https://api.github.com/repos/kata-containers/runtime/issues/867/events","html_url":"https://github.com/kata-containers/runtime/pull/867","id":375108782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjMxMzM2","number":867,"title":"virtcontainers: Rely on new interface LinkType field","user":{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-29T16:37:53Z","updated_at":"2018-10-31T20:01:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/867","html_url":"https://github.com/kata-containers/runtime/pull/867","diff_url":"https://github.com/kata-containers/runtime/pull/867.diff","patch_url":"https://github.com/kata-containers/runtime/pull/867.patch"},"body":"The logic wants that virtcontainers should be the place where the common packages should be defined. This pull request takes care of defining generic network structures into a new package `pkg/types/types.go`, which is basically a duplication of what is defined by the agent. But this allows virtcontainers and its consumers (kata-runtime, kata-netmon, kata-containerd-shim) to be independent from the agent.\r\n\r\nBased on the new package that define a new field `LinkType` for the structure `Interface`, Kata does not need anymore to do any assumption about the type of interface that needs to be added.\r\n\r\nFixes #866\r\nFixes #876"},"comment":{"url":"https://api.github.com/repos/kata-containers/runtime/issues/comments/434827677","html_url":"https://github.com/kata-containers/runtime/pull/867#issuecomment-434827677","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/867","id":434827677,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDgyNzY3Nw==","user":{"login":"sboeuf","id":22890413,"node_id":"MDQ6VXNlcjIyODkwNDEz","avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T20:01:09Z","updated_at":"2018-10-31T20:01:09Z","author_association":"CONTRIBUTOR","body":"/test"}}
{"actor":{"display_login":"sboeuf"}}