{"action":"created","comment":{"url":"https://api.github.com/repos/ropensci/drake/pulls/comments/165847300","pull_request_review_id":93848068,"id":165847300,"diff_hunk":"@@ -349,6 +349,7 @@ drake_config <- function(\n     packages = packages,\n     prework = prework\n   )\n+  add_ignore(path = \".gitignore\", verbose = FALSE)","path":"R/config.R","position":4,"original_position":4,"commit_id":"099aded32d23683f8eab5fc9bd4d6d810a51cb10","original_commit_id":"099aded32d23683f8eab5fc9bd4d6d810a51cb10","user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars0.githubusercontent.com/u/1741643?v=4","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"body":"@wlandau: Is `drake_config()` meant to be a pure function?","created_at":"2018-02-04T15:11:07Z","updated_at":"2018-02-04T15:13:20Z","html_url":"https://github.com/ropensci/drake/pull/234#discussion_r165847300","pull_request_url":"https://api.github.com/repos/ropensci/drake/pulls/234","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ropensci/drake/pulls/comments/165847300"},"html":{"href":"https://github.com/ropensci/drake/pull/234#discussion_r165847300"},"pull_request":{"href":"https://api.github.com/repos/ropensci/drake/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/ropensci/drake/pulls/234","id":167012285,"html_url":"https://github.com/ropensci/drake/pull/234","diff_url":"https://github.com/ropensci/drake/pull/234.diff","patch_url":"https://github.com/ropensci/drake/pull/234.patch","issue_url":"https://api.github.com/repos/ropensci/drake/issues/234","number":234,"state":"open","locked":false,"title":"Add .drake directory to .gitignore ","user":{"login":"uribo","id":228649,"avatar_url":"https://avatars0.githubusercontent.com/u/228649?v=4","gravatar_id":"","url":"https://api.github.com/users/uribo","html_url":"https://github.com/uribo","followers_url":"https://api.github.com/users/uribo/followers","following_url":"https://api.github.com/users/uribo/following{/other_user}","gists_url":"https://api.github.com/users/uribo/gists{/gist_id}","starred_url":"https://api.github.com/users/uribo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uribo/subscriptions","organizations_url":"https://api.github.com/users/uribo/orgs","repos_url":"https://api.github.com/users/uribo/repos","events_url":"https://api.github.com/users/uribo/events{/privacy}","received_events_url":"https://api.github.com/users/uribo/received_events","type":"User","site_admin":false},"body":"The content of this PR is simple.\r\nIn the project using drake, it is added to `.gitignore` when `drake::make()` is executed for the first time.\r\n\r\nUsing the drake environment, files and data to the `.drake` directory stored, but this is not normally included in version control by git (it is also in [this package](https://github.com/ropensci/drake/blob/master/.gitignore#L16)). \r\n\r\nSo, in order to prevent git management of `.drake` folder by the user's unintentionally, like adding behaviors of adding various hidden files in [httr’s](https://github.com/r-lib/httr) `.httr-oauth` file and [usethis](https://github.com/r-lib/usethis) package, add to the `.gitignore`.\r\n\r\n![nzafu5qxle](https://user-images.githubusercontent.com/228649/35778520-a3117440-0a02-11e8-9a2b-1d0d3b3a4e8c.gif)\r\n","created_at":"2018-02-04T14:24:37Z","updated_at":"2018-02-04T15:13:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"971d7750dcd193d92274e93d4da603996c3e77e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ropensci/drake/pulls/234/commits","review_comments_url":"https://api.github.com/repos/ropensci/drake/pulls/234/comments","review_comment_url":"https://api.github.com/repos/ropensci/drake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ropensci/drake/issues/234/comments","statuses_url":"https://api.github.com/repos/ropensci/drake/statuses/099aded32d23683f8eab5fc9bd4d6d810a51cb10","head":{"label":"uribo:add-ignore-drake","ref":"add-ignore-drake","sha":"099aded32d23683f8eab5fc9bd4d6d810a51cb10","user":{"login":"uribo","id":228649,"avatar_url":"https://avatars0.githubusercontent.com/u/228649?v=4","gravatar_id":"","url":"https://api.github.com/users/uribo","html_url":"https://github.com/uribo","followers_url":"https://api.github.com/users/uribo/followers","following_url":"https://api.github.com/users/uribo/following{/other_user}","gists_url":"https://api.github.com/users/uribo/gists{/gist_id}","starred_url":"https://api.github.com/users/uribo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uribo/subscriptions","organizations_url":"https://api.github.com/users/uribo/orgs","repos_url":"https://api.github.com/users/uribo/repos","events_url":"https://api.github.com/users/uribo/events{/privacy}","received_events_url":"https://api.github.com/users/uribo/received_events","type":"User","site_admin":false},"repo":{"id":120190308,"name":"drake","full_name":"uribo/drake","owner":{"login":"uribo","id":228649,"avatar_url":"https://avatars0.githubusercontent.com/u/228649?v=4","gravatar_id":"","url":"https://api.github.com/users/uribo","html_url":"https://github.com/uribo","followers_url":"https://api.github.com/users/uribo/followers","following_url":"https://api.github.com/users/uribo/following{/other_user}","gists_url":"https://api.github.com/users/uribo/gists{/gist_id}","starred_url":"https://api.github.com/users/uribo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uribo/subscriptions","organizations_url":"https://api.github.com/users/uribo/orgs","repos_url":"https://api.github.com/users/uribo/repos","events_url":"https://api.github.com/users/uribo/events{/privacy}","received_events_url":"https://api.github.com/users/uribo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uribo/drake","description":"An R-focused pipeline toolkit for reproducibility and high-performance computing","fork":true,"url":"https://api.github.com/repos/uribo/drake","forks_url":"https://api.github.com/repos/uribo/drake/forks","keys_url":"https://api.github.com/repos/uribo/drake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uribo/drake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uribo/drake/teams","hooks_url":"https://api.github.com/repos/uribo/drake/hooks","issue_events_url":"https://api.github.com/repos/uribo/drake/issues/events{/number}","events_url":"https://api.github.com/repos/uribo/drake/events","assignees_url":"https://api.github.com/repos/uribo/drake/assignees{/user}","branches_url":"https://api.github.com/repos/uribo/drake/branches{/branch}","tags_url":"https://api.github.com/repos/uribo/drake/tags","blobs_url":"https://api.github.com/repos/uribo/drake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uribo/drake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uribo/drake/git/refs{/sha}","trees_url":"https://api.github.com/repos/uribo/drake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uribo/drake/statuses/{sha}","languages_url":"https://api.github.com/repos/uribo/drake/languages","stargazers_url":"https://api.github.com/repos/uribo/drake/stargazers","contributors_url":"https://api.github.com/repos/uribo/drake/contributors","subscribers_url":"https://api.github.com/repos/uribo/drake/subscribers","subscription_url":"https://api.github.com/repos/uribo/drake/subscription","commits_url":"https://api.github.com/repos/uribo/drake/commits{/sha}","git_commits_url":"https://api.github.com/repos/uribo/drake/git/commits{/sha}","comments_url":"https://api.github.com/repos/uribo/drake/comments{/number}","issue_comment_url":"https://api.github.com/repos/uribo/drake/issues/comments{/number}","contents_url":"https://api.github.com/repos/uribo/drake/contents/{+path}","compare_url":"https://api.github.com/repos/uribo/drake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uribo/drake/merges","archive_url":"https://api.github.com/repos/uribo/drake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uribo/drake/downloads","issues_url":"https://api.github.com/repos/uribo/drake/issues{/number}","pulls_url":"https://api.github.com/repos/uribo/drake/pulls{/number}","milestones_url":"https://api.github.com/repos/uribo/drake/milestones{/number}","notifications_url":"https://api.github.com/repos/uribo/drake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uribo/drake/labels{/name}","releases_url":"https://api.github.com/repos/uribo/drake/releases{/id}","deployments_url":"https://api.github.com/repos/uribo/drake/deployments","created_at":"2018-02-04T14:06:56Z","updated_at":"2018-02-04T14:06:58Z","pushed_at":"2018-02-04T14:22:28Z","git_url":"git://github.com/uribo/drake.git","ssh_url":"git@github.com:uribo/drake.git","clone_url":"https://github.com/uribo/drake.git","svn_url":"https://github.com/uribo/drake","homepage":"https://ropensci.github.io/drake","size":84852,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ropensci:master","ref":"master","sha":"0d8bca6297d345c38b81205422e2ae17b7921ae1","user":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars3.githubusercontent.com/u/1200269?v=4","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"repo":{"id":82609103,"name":"drake","full_name":"ropensci/drake","owner":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars3.githubusercontent.com/u/1200269?v=4","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ropensci/drake","description":"An R-focused pipeline toolkit for reproducibility and high-performance computing","fork":false,"url":"https://api.github.com/repos/ropensci/drake","forks_url":"https://api.github.com/repos/ropensci/drake/forks","keys_url":"https://api.github.com/repos/ropensci/drake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropensci/drake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropensci/drake/teams","hooks_url":"https://api.github.com/repos/ropensci/drake/hooks","issue_events_url":"https://api.github.com/repos/ropensci/drake/issues/events{/number}","events_url":"https://api.github.com/repos/ropensci/drake/events","assignees_url":"https://api.github.com/repos/ropensci/drake/assignees{/user}","branches_url":"https://api.github.com/repos/ropensci/drake/branches{/branch}","tags_url":"https://api.github.com/repos/ropensci/drake/tags","blobs_url":"https://api.github.com/repos/ropensci/drake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropensci/drake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropensci/drake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropensci/drake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropensci/drake/statuses/{sha}","languages_url":"https://api.github.com/repos/ropensci/drake/languages","stargazers_url":"https://api.github.com/repos/ropensci/drake/stargazers","contributors_url":"https://api.github.com/repos/ropensci/drake/contributors","subscribers_url":"https://api.github.com/repos/ropensci/drake/subscribers","subscription_url":"https://api.github.com/repos/ropensci/drake/subscription","commits_url":"https://api.github.com/repos/ropensci/drake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropensci/drake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropensci/drake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropensci/drake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ropensci/drake/contents/{+path}","compare_url":"https://api.github.com/repos/ropensci/drake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropensci/drake/merges","archive_url":"https://api.github.com/repos/ropensci/drake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropensci/drake/downloads","issues_url":"https://api.github.com/repos/ropensci/drake/issues{/number}","pulls_url":"https://api.github.com/repos/ropensci/drake/pulls{/number}","milestones_url":"https://api.github.com/repos/ropensci/drake/milestones{/number}","notifications_url":"https://api.github.com/repos/ropensci/drake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropensci/drake/labels{/name}","releases_url":"https://api.github.com/repos/ropensci/drake/releases{/id}","deployments_url":"https://api.github.com/repos/ropensci/drake/deployments","created_at":"2017-02-20T22:28:40Z","updated_at":"2018-02-04T11:07:50Z","pushed_at":"2018-02-04T14:24:38Z","git_url":"git://github.com/ropensci/drake.git","ssh_url":"git@github.com:ropensci/drake.git","clone_url":"https://github.com/ropensci/drake.git","svn_url":"https://github.com/ropensci/drake","homepage":"https://ropensci.github.io/drake","size":84850,"stargazers_count":119,"watchers_count":119,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":16,"open_issues":18,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ropensci/drake/pulls/234"},"html":{"href":"https://github.com/ropensci/drake/pull/234"},"issue":{"href":"https://api.github.com/repos/ropensci/drake/issues/234"},"comments":{"href":"https://api.github.com/repos/ropensci/drake/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/ropensci/drake/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/ropensci/drake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ropensci/drake/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/ropensci/drake/statuses/099aded32d23683f8eab5fc9bd4d6d810a51cb10"}},"author_association":"NONE"}}
{"actor":{"display_login":"krlmlr"}}