{"action":"created","issue":{"url":"https://api.github.com/repos/DivadNojnarg/bs4Dash/issues/13","repository_url":"https://api.github.com/repos/DivadNojnarg/bs4Dash","labels_url":"https://api.github.com/repos/DivadNojnarg/bs4Dash/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/DivadNojnarg/bs4Dash/issues/13/comments","events_url":"https://api.github.com/repos/DivadNojnarg/bs4Dash/issues/13/events","html_url":"https://github.com/DivadNojnarg/bs4Dash/issues/13","id":363660964,"node_id":"MDU6SXNzdWUzNjM2NjA5NjQ=","number":13,"title":"bs4TabPanel tabName does not accept space","user":{"login":"stephLH","id":10184065,"node_id":"MDQ6VXNlcjEwMTg0MDY1","avatar_url":"https://avatars2.githubusercontent.com/u/10184065?v=4","gravatar_id":"","url":"https://api.github.com/users/stephLH","html_url":"https://github.com/stephLH","followers_url":"https://api.github.com/users/stephLH/followers","following_url":"https://api.github.com/users/stephLH/following{/other_user}","gists_url":"https://api.github.com/users/stephLH/gists{/gist_id}","starred_url":"https://api.github.com/users/stephLH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephLH/subscriptions","organizations_url":"https://api.github.com/users/stephLH/orgs","repos_url":"https://api.github.com/users/stephLH/repos","events_url":"https://api.github.com/users/stephLH/events{/privacy}","received_events_url":"https://api.github.com/users/stephLH/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-25T16:18:28Z","updated_at":"2018-09-26T11:59:03Z","closed_at":null,"author_association":"NONE","body":"I cannot set a tab name with space inside `bs4TabPanel `. \r\nThe content of the second tab is not updated :\r\n```\r\nlibrary(shiny)\r\nlibrary(bs4Dash)\r\n\r\nshinyApp(\r\n  ui = bs4DashPage(\r\n    navbar = bs4DashNavbar(),\r\n    sidebar = bs4DashSidebar(\r\n      bs4SidebarMenuItem(\r\n        \"Tabs\",\r\n        tabName = \"tabs\"\r\n      )\r\n    ),\r\n    body = bs4DashBody(\r\n      bs4TabItems(\r\n        bs4TabItem(\r\n          tabName = \"tabs\",\r\n          bs4TabCard(\r\n            bs4TabPanel(\r\n              tabName = \"tab name 1\",\r\n              active = TRUE,\r\n              \"text 1\"\r\n            ),\r\n            bs4TabPanel(\r\n              tabName = \"tab name 2\",\r\n              \"text 2\"\r\n            )\r\n          )\r\n        )\r\n      )\r\n    )\r\n  ),\r\n  server = function(input, output) {}\r\n)\r\n```\r\nBut it works with a `tabPanel` in `shinydashboard` :\r\n```\r\nlibrary(shiny)\r\nlibrary(shinydashboard)\r\n\r\nshinyApp(\r\n  ui = dashboardPage(\r\n    header = dashboardHeader(),\r\n    sidebar = bs4DashSidebar(\r\n      sidebarMenu(\r\n        menuSubItem(\r\n          \"Tabs\",\r\n          tabName = \"tabs\"\r\n        )\r\n      )\r\n    ),\r\n    body = dashboardBody(\r\n      tabItems(\r\n        tabItem(\r\n          tabName = \"tabs\",\r\n          tabBox(\r\n            tabPanel(\r\n              title = \"tab name 1\",\r\n              \"text 1\"\r\n            ),\r\n            tabPanel(\r\n              title = \"tab name 2\",\r\n              \"text 2\"\r\n            )\r\n          )\r\n        )\r\n      )\r\n    )\r\n  ),\r\n  server = function(input, output) {}\r\n)\r\n```"},"comment":{"url":"https://api.github.com/repos/DivadNojnarg/bs4Dash/issues/comments/424688887","html_url":"https://github.com/DivadNojnarg/bs4Dash/issues/13#issuecomment-424688887","issue_url":"https://api.github.com/repos/DivadNojnarg/bs4Dash/issues/13","id":424688887,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDY4ODg4Nw==","user":{"login":"DivadNojnarg","id":18291543,"node_id":"MDQ6VXNlcjE4MjkxNTQz","avatar_url":"https://avatars3.githubusercontent.com/u/18291543?v=4","gravatar_id":"","url":"https://api.github.com/users/DivadNojnarg","html_url":"https://github.com/DivadNojnarg","followers_url":"https://api.github.com/users/DivadNojnarg/followers","following_url":"https://api.github.com/users/DivadNojnarg/following{/other_user}","gists_url":"https://api.github.com/users/DivadNojnarg/gists{/gist_id}","starred_url":"https://api.github.com/users/DivadNojnarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivadNojnarg/subscriptions","organizations_url":"https://api.github.com/users/DivadNojnarg/orgs","repos_url":"https://api.github.com/users/DivadNojnarg/repos","events_url":"https://api.github.com/users/DivadNojnarg/events{/privacy}","received_events_url":"https://api.github.com/users/DivadNojnarg/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T11:59:03Z","updated_at":"2018-09-26T11:59:03Z","author_association":"OWNER","body":"Thanks for the report. \r\nPlease download the latest level version:\r\n`devtools:install_github(DivadNojnarg/bs4Dash)`\r\nBelow you will find a list of what is fixed. Let me know if you still have problems. If not, I will close ;)\r\n# bs4Dash 0.3.0.9000\r\n## Bug fix\r\n- fix #8: Compatibility with shinyWidgets pickerInput. Thanks @pvictor.\r\n- fix #13 in `bs4TabItem`: handle tabName with space. Thanks @stephLH.\r\n- fix `bs4TabCard`: when the user set 2 or more tabs active at the same time, only \r\nthe first one is selected"}}
{"actor":{"display_login":"DivadNojnarg"}}