{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3337","repository_url":"https://api.github.com/repos/magnumripper/JohnTheRipper","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3337/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3337/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3337/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/3337","id":345939885,"node_id":"MDU6SXNzdWUzNDU5Mzk4ODU=","number":3337,"title":"dmg-opencl PLAINTEXT_LENGTH increase causes failure","user":{"login":"iiojiojoij","id":41927452,"node_id":"MDQ6VXNlcjQxOTI3NDUy","avatar_url":"https://avatars2.githubusercontent.com/u/41927452?v=4","gravatar_id":"","url":"https://api.github.com/users/iiojiojoij","html_url":"https://github.com/iiojiojoij","followers_url":"https://api.github.com/users/iiojiojoij/followers","following_url":"https://api.github.com/users/iiojiojoij/following{/other_user}","gists_url":"https://api.github.com/users/iiojiojoij/gists{/gist_id}","starred_url":"https://api.github.com/users/iiojiojoij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iiojiojoij/subscriptions","organizations_url":"https://api.github.com/users/iiojiojoij/orgs","repos_url":"https://api.github.com/users/iiojiojoij/repos","events_url":"https://api.github.com/users/iiojiojoij/events{/privacy}","received_events_url":"https://api.github.com/users/iiojiojoij/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-07-30T21:21:16Z","updated_at":"2018-08-01T09:27:31Z","closed_at":"2018-08-01T09:24:05Z","author_association":"NONE","body":"I am on latest release. \r\n\r\nI'm trying to make dmg-opencl match dmg's PLAINTEXT_LENGTH.  CPU dmg has length 125, dmg-opencl has 64.  Changing dmg-opencl's PLAINTEXT_LENGTH to anything above 64 causes a get_key/set_key mismatch.\r\n\r\nI changed PLAINTEXT_LENGTH to 125 in opencl_dmg_fmt_plug.c to 125, but that causes a mismatch between get_key and set_key at the 65th character.\r\n\r\nThen, if I change the `#define GETPOS` macro in opencl_dmg_fmt to use PLAINTEXT_LENGTH (125) instead of the hard-coded 64, it goes all the way to 124 characters, but the last character is wrong.\r\n\r\nBeen at it for days. Maybe I'm missing something.\r\n\r\nAlso, if I change PLAINTEXT_LENGTH to 68, for example, then I get a cmp_all(3) failure.\r\n\r\n### PLAINTEXT_LENGTH = 125 (original 64)\r\n> Benchmarking: dmg-opencl, Apple DMG [PBKDF2-SHA1 3DES/AES OpenCL]... /\r\n> getkey = 80808080.901234567890123456789012345678901234567890123456789012380808080.0123456789012345678901234567890123456789012345678901\r\n> setkey = 80808080.90123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234\r\n> FAILED (max. length in index 0: wrote 125, got 125 back)`\r\n\r\n\r\n### PLAINTEXT_LENGTH = 125 and GETPOS modified to have PLANTEXT_LENGTH (125) instead of 64\r\n> Benchmarking: dmg-opencl, Apple DMG [PBKDF2-SHA1 3DES/AES OpenCL]... /\r\n> getkey = 80808080.90123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901230\r\n> setkey = 80808080.90123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234\r\n> FAILED (max. length in index 0: wrote 125, got 125 back)`\r\n---\r\nOpenCL headers 2.1"},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/409512620","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/3337#issuecomment-409512620","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/3337","id":409512620,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTUxMjYyMA==","user":{"login":"magnumripper","id":1268598,"node_id":"MDQ6VXNlcjEyNjg1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1268598?v=4","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T09:27:31Z","updated_at":"2018-08-01T09:27:31Z","author_association":"OWNER","body":"@kholia since this was so easy and unintrusive we can do it to more formats using PBKDF2-HMAC-XX although 64 is usually enough for any use. We'll just have to remember it for next similar request."}}
{"actor":{"display_login":"magnumripper"}}