{"action":"closed","number":4380,"pull_request":{"url":"https://api.github.com/repos/pypa/warehouse/pulls/4380","id":204594383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTk0Mzgz","html_url":"https://github.com/pypa/warehouse/pull/4380","diff_url":"https://github.com/pypa/warehouse/pull/4380.diff","patch_url":"https://github.com/pypa/warehouse/pull/4380.patch","issue_url":"https://api.github.com/repos/pypa/warehouse/issues/4380","number":4380,"state":"closed","locked":false,"title":"Without JS, show default navbar and notification that some things might be broken","user":{"login":"cpulvermacher","id":905027,"node_id":"MDQ6VXNlcjkwNTAyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/905027?v=4","gravatar_id":"","url":"https://api.github.com/users/cpulvermacher","html_url":"https://github.com/cpulvermacher","followers_url":"https://api.github.com/users/cpulvermacher/followers","following_url":"https://api.github.com/users/cpulvermacher/following{/other_user}","gists_url":"https://api.github.com/users/cpulvermacher/gists{/gist_id}","starred_url":"https://api.github.com/users/cpulvermacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpulvermacher/subscriptions","organizations_url":"https://api.github.com/users/cpulvermacher/orgs","repos_url":"https://api.github.com/users/cpulvermacher/repos","events_url":"https://api.github.com/users/cpulvermacher/events{/privacy}","received_events_url":"https://api.github.com/users/cpulvermacher/received_events","type":"User","site_admin":false},"body":"This PR does includes two things:\r\n- Showing the logged-out version of the navbar in case CSI fails, so users can log in without JavaScript. \r\n- Show a notification at the top if JS is disabled, and disable the fixed positioning to avoid hiding the menu bar.\r\n\r\nLet me know if this can be improved, in particular I'm not entirely sure if the way I've imported the macro is OK.","created_at":"2018-07-28T14:01:52Z","updated_at":"2018-07-28T15:44:51Z","closed_at":"2018-07-28T15:44:51Z","merged_at":"2018-07-28T15:44:51Z","merge_commit_sha":"717fac8134cac7d128489a2cae123f5518b14e1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/warehouse/pulls/4380/commits","review_comments_url":"https://api.github.com/repos/pypa/warehouse/pulls/4380/comments","review_comment_url":"https://api.github.com/repos/pypa/warehouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/warehouse/issues/4380/comments","statuses_url":"https://api.github.com/repos/pypa/warehouse/statuses/5cf0b360a6f107cd66bfdc436c182c8627382371","head":{"label":"cpulvermacher:3828-noscript","ref":"3828-noscript","sha":"5cf0b360a6f107cd66bfdc436c182c8627382371","user":{"login":"cpulvermacher","id":905027,"node_id":"MDQ6VXNlcjkwNTAyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/905027?v=4","gravatar_id":"","url":"https://api.github.com/users/cpulvermacher","html_url":"https://github.com/cpulvermacher","followers_url":"https://api.github.com/users/cpulvermacher/followers","following_url":"https://api.github.com/users/cpulvermacher/following{/other_user}","gists_url":"https://api.github.com/users/cpulvermacher/gists{/gist_id}","starred_url":"https://api.github.com/users/cpulvermacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpulvermacher/subscriptions","organizations_url":"https://api.github.com/users/cpulvermacher/orgs","repos_url":"https://api.github.com/users/cpulvermacher/repos","events_url":"https://api.github.com/users/cpulvermacher/events{/privacy}","received_events_url":"https://api.github.com/users/cpulvermacher/received_events","type":"User","site_admin":false},"repo":{"id":142668544,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2Njg1NDQ=","name":"warehouse","full_name":"cpulvermacher/warehouse","owner":{"login":"cpulvermacher","id":905027,"node_id":"MDQ6VXNlcjkwNTAyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/905027?v=4","gravatar_id":"","url":"https://api.github.com/users/cpulvermacher","html_url":"https://github.com/cpulvermacher","followers_url":"https://api.github.com/users/cpulvermacher/followers","following_url":"https://api.github.com/users/cpulvermacher/following{/other_user}","gists_url":"https://api.github.com/users/cpulvermacher/gists{/gist_id}","starred_url":"https://api.github.com/users/cpulvermacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpulvermacher/subscriptions","organizations_url":"https://api.github.com/users/cpulvermacher/orgs","repos_url":"https://api.github.com/users/cpulvermacher/repos","events_url":"https://api.github.com/users/cpulvermacher/events{/privacy}","received_events_url":"https://api.github.com/users/cpulvermacher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpulvermacher/warehouse","description":"The Python Package Repository","fork":true,"url":"https://api.github.com/repos/cpulvermacher/warehouse","forks_url":"https://api.github.com/repos/cpulvermacher/warehouse/forks","keys_url":"https://api.github.com/repos/cpulvermacher/warehouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpulvermacher/warehouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpulvermacher/warehouse/teams","hooks_url":"https://api.github.com/repos/cpulvermacher/warehouse/hooks","issue_events_url":"https://api.github.com/repos/cpulvermacher/warehouse/issues/events{/number}","events_url":"https://api.github.com/repos/cpulvermacher/warehouse/events","assignees_url":"https://api.github.com/repos/cpulvermacher/warehouse/assignees{/user}","branches_url":"https://api.github.com/repos/cpulvermacher/warehouse/branches{/branch}","tags_url":"https://api.github.com/repos/cpulvermacher/warehouse/tags","blobs_url":"https://api.github.com/repos/cpulvermacher/warehouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpulvermacher/warehouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpulvermacher/warehouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpulvermacher/warehouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpulvermacher/warehouse/statuses/{sha}","languages_url":"https://api.github.com/repos/cpulvermacher/warehouse/languages","stargazers_url":"https://api.github.com/repos/cpulvermacher/warehouse/stargazers","contributors_url":"https://api.github.com/repos/cpulvermacher/warehouse/contributors","subscribers_url":"https://api.github.com/repos/cpulvermacher/warehouse/subscribers","subscription_url":"https://api.github.com/repos/cpulvermacher/warehouse/subscription","commits_url":"https://api.github.com/repos/cpulvermacher/warehouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpulvermacher/warehouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpulvermacher/warehouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpulvermacher/warehouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpulvermacher/warehouse/contents/{+path}","compare_url":"https://api.github.com/repos/cpulvermacher/warehouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpulvermacher/warehouse/merges","archive_url":"https://api.github.com/repos/cpulvermacher/warehouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpulvermacher/warehouse/downloads","issues_url":"https://api.github.com/repos/cpulvermacher/warehouse/issues{/number}","pulls_url":"https://api.github.com/repos/cpulvermacher/warehouse/pulls{/number}","milestones_url":"https://api.github.com/repos/cpulvermacher/warehouse/milestones{/number}","notifications_url":"https://api.github.com/repos/cpulvermacher/warehouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpulvermacher/warehouse/labels{/name}","releases_url":"https://api.github.com/repos/cpulvermacher/warehouse/releases{/id}","deployments_url":"https://api.github.com/repos/cpulvermacher/warehouse/deployments","created_at":"2018-07-28T10:30:13Z","updated_at":"2018-07-28T10:30:17Z","pushed_at":"2018-07-28T15:35:45Z","git_url":"git://github.com/cpulvermacher/warehouse.git","ssh_url":"git@github.com:cpulvermacher/warehouse.git","clone_url":"https://github.com/cpulvermacher/warehouse.git","svn_url":"https://github.com/cpulvermacher/warehouse","homepage":"https://pypi.org/","size":112570,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"3fc5055234995129b6d24348652867500e67c72c","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":9120498,"node_id":"MDEwOlJlcG9zaXRvcnk5MTIwNDk4","name":"warehouse","full_name":"pypa/warehouse","owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/warehouse","description":"The Python Package Repository","fork":false,"url":"https://api.github.com/repos/pypa/warehouse","forks_url":"https://api.github.com/repos/pypa/warehouse/forks","keys_url":"https://api.github.com/repos/pypa/warehouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/warehouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/warehouse/teams","hooks_url":"https://api.github.com/repos/pypa/warehouse/hooks","issue_events_url":"https://api.github.com/repos/pypa/warehouse/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/warehouse/events","assignees_url":"https://api.github.com/repos/pypa/warehouse/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/warehouse/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/warehouse/tags","blobs_url":"https://api.github.com/repos/pypa/warehouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/warehouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/warehouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/warehouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/warehouse/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/warehouse/languages","stargazers_url":"https://api.github.com/repos/pypa/warehouse/stargazers","contributors_url":"https://api.github.com/repos/pypa/warehouse/contributors","subscribers_url":"https://api.github.com/repos/pypa/warehouse/subscribers","subscription_url":"https://api.github.com/repos/pypa/warehouse/subscription","commits_url":"https://api.github.com/repos/pypa/warehouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/warehouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/warehouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/warehouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/warehouse/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/warehouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/warehouse/merges","archive_url":"https://api.github.com/repos/pypa/warehouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/warehouse/downloads","issues_url":"https://api.github.com/repos/pypa/warehouse/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/warehouse/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/warehouse/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/warehouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/warehouse/labels{/name}","releases_url":"https://api.github.com/repos/pypa/warehouse/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/warehouse/deployments","created_at":"2013-03-30T19:03:53Z","updated_at":"2018-07-28T15:35:40Z","pushed_at":"2018-07-28T15:44:51Z","git_url":"git://github.com/pypa/warehouse.git","ssh_url":"git@github.com:pypa/warehouse.git","clone_url":"https://github.com/pypa/warehouse.git","svn_url":"https://github.com/pypa/warehouse","homepage":"https://pypi.org/","size":112575,"stargazers_count":1868,"watchers_count":1868,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":418,"mirror_url":null,"archived":false,"open_issues_count":279,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":418,"open_issues":279,"watchers":1868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/warehouse/pulls/4380"},"html":{"href":"https://github.com/pypa/warehouse/pull/4380"},"issue":{"href":"https://api.github.com/repos/pypa/warehouse/issues/4380"},"comments":{"href":"https://api.github.com/repos/pypa/warehouse/issues/4380/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/warehouse/pulls/4380/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/warehouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/warehouse/pulls/4380/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/warehouse/statuses/5cf0b360a6f107cd66bfdc436c182c8627382371"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nlhkabu","id":3323703,"node_id":"MDQ6VXNlcjMzMjM3MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/3323703?v=4","gravatar_id":"","url":"https://api.github.com/users/nlhkabu","html_url":"https://github.com/nlhkabu","followers_url":"https://api.github.com/users/nlhkabu/followers","following_url":"https://api.github.com/users/nlhkabu/following{/other_user}","gists_url":"https://api.github.com/users/nlhkabu/gists{/gist_id}","starred_url":"https://api.github.com/users/nlhkabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlhkabu/subscriptions","organizations_url":"https://api.github.com/users/nlhkabu/orgs","repos_url":"https://api.github.com/users/nlhkabu/repos","events_url":"https://api.github.com/users/nlhkabu/events{/privacy}","received_events_url":"https://api.github.com/users/nlhkabu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":27,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"nlhkabu"}}