{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-base-driver/pulls/comments/216051670","pull_request_review_id":153458091,"id":216051670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA1MTY3MA==","diff_hunk":"@@ -8,9 +8,9 @@ import { renameKey } from '../basedriver/helpers';\n import B from 'bluebird';\n import BaseDriver from '../basedriver/driver';\n \n-\n const mjsonwpLog = logger.getLogger('MJSONWP');\n const w3cLog = logger.getLogger('W3C');\n+const genericProtocolLog = logger.getLogger('GENERIC');","path":"lib/protocol/protocol.js","position":7,"original_position":7,"commit_id":"307708aef15924ad1c3c2c072963dd8b6d182d7d","original_commit_id":"307708aef15924ad1c3c2c072963dd8b6d182d7d","user":{"login":"mykola-mokhnach","id":7767781,"node_id":"MDQ6VXNlcjc3Njc3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"I prefer GENERIC, because we include data for both protocols into the response if the protocol is neither W3C nor JSONWP","created_at":"2018-09-07T18:37:05Z","updated_at":"2018-09-07T18:37:06Z","html_url":"https://github.com/appium/appium-base-driver/pull/257#discussion_r216051670","pull_request_url":"https://api.github.com/repos/appium/appium-base-driver/pulls/257","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-base-driver/pulls/comments/216051670"},"html":{"href":"https://github.com/appium/appium-base-driver/pull/257#discussion_r216051670"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-base-driver/pulls/257"}},"in_reply_to_id":216023784},"pull_request":{"url":"https://api.github.com/repos/appium/appium-base-driver/pulls/257","id":213891696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODkxNjk2","html_url":"https://github.com/appium/appium-base-driver/pull/257","diff_url":"https://github.com/appium/appium-base-driver/pull/257.diff","patch_url":"https://github.com/appium/appium-base-driver/pull/257.patch","issue_url":"https://api.github.com/repos/appium/appium-base-driver/issues/257","number":257,"state":"open","locked":false,"title":"Fix protocol detection inside the routing function","user":{"login":"mykola-mokhnach","id":7767781,"node_id":"MDQ6VXNlcjc3Njc3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"I hope this will address https://github.com/appium/appium/issues/11300","created_at":"2018-09-07T10:56:56Z","updated_at":"2018-09-07T18:37:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f89df0cc0c131cad5320fd02e4eb22735edd7c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dpgraham","id":852574,"node_id":"MDQ6VXNlcjg1MjU3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/852574?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgraham","html_url":"https://github.com/dpgraham","followers_url":"https://api.github.com/users/dpgraham/followers","following_url":"https://api.github.com/users/dpgraham/following{/other_user}","gists_url":"https://api.github.com/users/dpgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgraham/subscriptions","organizations_url":"https://api.github.com/users/dpgraham/orgs","repos_url":"https://api.github.com/users/dpgraham/repos","events_url":"https://api.github.com/users/dpgraham/events{/privacy}","received_events_url":"https://api.github.com/users/dpgraham/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-base-driver/pulls/257/commits","review_comments_url":"https://api.github.com/repos/appium/appium-base-driver/pulls/257/comments","review_comment_url":"https://api.github.com/repos/appium/appium-base-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-base-driver/issues/257/comments","statuses_url":"https://api.github.com/repos/appium/appium-base-driver/statuses/307708aef15924ad1c3c2c072963dd8b6d182d7d","head":{"label":"mykola-mokhnach:current_proto","ref":"current_proto","sha":"307708aef15924ad1c3c2c072963dd8b6d182d7d","user":{"login":"mykola-mokhnach","id":7767781,"node_id":"MDQ6VXNlcjc3Njc3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"repo":{"id":81566211,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU2NjIxMQ==","name":"appium-base-driver","full_name":"mykola-mokhnach/appium-base-driver","owner":{"login":"mykola-mokhnach","id":7767781,"node_id":"MDQ6VXNlcjc3Njc3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mykola-mokhnach/appium-base-driver","description":"Base class for an Appium driver","fork":true,"url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver","forks_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/forks","keys_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/teams","hooks_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/hooks","issue_events_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/events","assignees_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/tags","blobs_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/languages","stargazers_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/stargazers","contributors_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/contributors","subscribers_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/subscribers","subscription_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/subscription","commits_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/merges","archive_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/downloads","issues_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/labels{/name}","releases_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/releases{/id}","deployments_url":"https://api.github.com/repos/mykola-mokhnach/appium-base-driver/deployments","created_at":"2017-02-10T13:08:11Z","updated_at":"2018-09-07T07:46:19Z","pushed_at":"2018-09-07T18:35:09Z","git_url":"git://github.com/mykola-mokhnach/appium-base-driver.git","ssh_url":"git@github.com:mykola-mokhnach/appium-base-driver.git","clone_url":"https://github.com/mykola-mokhnach/appium-base-driver.git","svn_url":"https://github.com/mykola-mokhnach/appium-base-driver","homepage":null,"size":895,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"eee6d6ddd1700311a6f6f34b75dfbd1664ccc60b","user":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":35977087,"node_id":"MDEwOlJlcG9zaXRvcnkzNTk3NzA4Nw==","name":"appium-base-driver","full_name":"appium/appium-base-driver","owner":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-base-driver","description":"Base class for an Appium driver","fork":false,"url":"https://api.github.com/repos/appium/appium-base-driver","forks_url":"https://api.github.com/repos/appium/appium-base-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-base-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-base-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-base-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-base-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-base-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-base-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-base-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-base-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-base-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-base-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-base-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-base-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-base-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-base-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-base-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-base-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-base-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-base-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-base-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-base-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-base-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-base-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-base-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-base-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-base-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-base-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-base-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-base-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-base-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-base-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-base-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-base-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-base-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-base-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-base-driver/deployments","created_at":"2015-05-20T22:15:40Z","updated_at":"2018-09-07T14:18:15Z","pushed_at":"2018-09-07T14:18:13Z","git_url":"git://github.com/appium/appium-base-driver.git","ssh_url":"git@github.com:appium/appium-base-driver.git","clone_url":"https://github.com/appium/appium-base-driver.git","svn_url":"https://github.com/appium/appium-base-driver","homepage":null,"size":878,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":1,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-base-driver/pulls/257"},"html":{"href":"https://github.com/appium/appium-base-driver/pull/257"},"issue":{"href":"https://api.github.com/repos/appium/appium-base-driver/issues/257"},"comments":{"href":"https://api.github.com/repos/appium/appium-base-driver/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-base-driver/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-base-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-base-driver/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-base-driver/statuses/307708aef15924ad1c3c2c072963dd8b6d182d7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mykola-mokhnach"}}