{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69243","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69243/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69243/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69243/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69243","id":365081195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTE1MDE0","number":69243,"title":"Fix setting admission plugins on local-up-cluster.sh","user":{"login":"jfchevrette","id":3001,"node_id":"MDQ6VXNlcjMwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3001?v=4","gravatar_id":"","url":"https://api.github.com/users/jfchevrette","html_url":"https://github.com/jfchevrette","followers_url":"https://api.github.com/users/jfchevrette/followers","following_url":"https://api.github.com/users/jfchevrette/following{/other_user}","gists_url":"https://api.github.com/users/jfchevrette/gists{/gist_id}","starred_url":"https://api.github.com/users/jfchevrette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfchevrette/subscriptions","organizations_url":"https://api.github.com/users/jfchevrette/orgs","repos_url":"https://api.github.com/users/jfchevrette/repos","events_url":"https://api.github.com/users/jfchevrette/events{/privacy}","received_events_url":"https://api.github.com/users/jfchevrette/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"assignees":[{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-09-29T00:57:28Z","updated_at":"2018-10-01T01:54:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69243","html_url":"https://github.com/kubernetes/kubernetes/pull/69243","diff_url":"https://github.com/kubernetes/kubernetes/pull/69243.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69243.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n`hack/local-up-cluster.sh` currently do not honor setting `ENABLE_ADMISSION_PLUGINS` because the list is overriden later on in the script before the apiserver is started.\r\n\r\nThis PR moves the list higher up as a default list of admission plugins and then allows overriding the defaults via the expected ENV variable when starting the cluster.\r\n\r\n**Which issue(s) this PR fixes**\r\nNo issue created. Should I create one?\r\n\r\n**Special notes for your reviewer**:\r\nI have not found tests for this script. I did run it and was able to manually validate that the list of admission plugin is either set to default or to those I chose via the environment variable.\r\n\r\nThis is a first contribution. I will appreciate any comments on how I can improve future contributions.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/425770888","html_url":"https://github.com/kubernetes/kubernetes/pull/69243#issuecomment-425770888","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69243","id":425770888,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTc3MDg4OA==","user":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T01:54:49Z","updated_at":"2018-10-01T01:54:49Z","author_association":"MEMBER","body":"/test pull-kubernetes-e2e-kops-aws"}}
{"actor":{"display_login":"dims"}}