{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/168917580","pull_request_review_id":97370136,"id":168917580,"diff_hunk":"@@ -34,29 +34,50 @@ set(URL https://github.com/grpc/grpc)\n set(VERSION bfcbad3b86c7912968dc8e64f2121c920dad4dfb)\n set_target_description(grpc \"Remote Procedure Call library\" ${URL} ${VERSION})\n \n+iroha_get_lib_name(GPRLIB       gpr               SHARED)","path":"cmake/Modules/Findgrpc.cmake","position":4,"original_position":4,"commit_id":"0a9efb035a2437943af7675b85e4fcf96f2f7563","original_commit_id":"c1416b8135999ce6da45c6f746a06c29f1fbd963","user":{"login":"Warchant","id":1867551,"avatar_url":"https://avatars0.githubusercontent.com/u/1867551?v=4","gravatar_id":"","url":"https://api.github.com/users/Warchant","html_url":"https://github.com/Warchant","followers_url":"https://api.github.com/users/Warchant/followers","following_url":"https://api.github.com/users/Warchant/following{/other_user}","gists_url":"https://api.github.com/users/Warchant/gists{/gist_id}","starred_url":"https://api.github.com/users/Warchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warchant/subscriptions","organizations_url":"https://api.github.com/users/Warchant/orgs","repos_url":"https://api.github.com/users/Warchant/repos","events_url":"https://api.github.com/users/Warchant/events{/privacy}","received_events_url":"https://api.github.com/users/Warchant/received_events","type":"User","site_admin":false},"body":"```\r\nroot@b7b6b07ca39c:/# ldd irohad\\\r\n>\r\n\tlinux-vdso.so.1 =>  (0x00007ffdbc7fd000)\r\n\tlibtbb.so.2 => not found\r\n\tlibgrpc++.so => /usr/local/lib/libgrpc++.so (0x00007fe5af5ec000)\r\n\tlibpq.so.5 => not found\r\n\tlibboost_filesystem.so.1.65.1 => /usr/local/lib/libboost_filesystem.so.1.65.1 (0x00007fe5af3d1000)\r\n\tlibboost_system.so.1.65.1 => /usr/local/lib/libboost_system.so.1.65.1 (0x00007fe5af1cc000)\r\n\tlibprotobuf.so => /usr/local/lib/libprotobuf.so (0x00007fe5ae9da000)\r\n\tlibpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fe5ae7bd000)\r\n\tlibed25519.so.1.2.2 => /usr/local/lib/libed25519.so.1.2.2 (0x00007fe5ae5a5000)\r\n\tlibstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fe5ae223000)\r\n\tlibm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fe5adf1a000)\r\n\tlibgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fe5add04000)\r\n\tlibc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fe5ad93a000)\r\n\t/lib64/ld-linux-x86-64.so.2 (0x00007fe5af929000)\r\n\tlibgrpc.so => not found\r\n\tlibgpr.so => not found\r\n\tlibz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fe5ad720000)\r\n```","created_at":"2018-02-17T09:42:21Z","updated_at":"2018-02-17T09:42:21Z","html_url":"https://github.com/hyperledger/iroha/pull/983#discussion_r168917580","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/983","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/168917580"},"html":{"href":"https://github.com/hyperledger/iroha/pull/983#discussion_r168917580"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/983"}},"in_reply_to_id":168815004},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/983","id":169508423,"html_url":"https://github.com/hyperledger/iroha/pull/983","diff_url":"https://github.com/hyperledger/iroha/pull/983.diff","patch_url":"https://github.com/hyperledger/iroha/pull/983.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/983","number":983,"state":"open","locked":false,"title":"CMake Improvements","user":{"login":"Warchant","id":1867551,"avatar_url":"https://avatars0.githubusercontent.com/u/1867551?v=4","gravatar_id":"","url":"https://api.github.com/users/Warchant","html_url":"https://github.com/Warchant","followers_url":"https://api.github.com/users/Warchant/followers","following_url":"https://api.github.com/users/Warchant/following{/other_user}","gists_url":"https://api.github.com/users/Warchant/gists{/gist_id}","starred_url":"https://api.github.com/users/Warchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warchant/subscriptions","organizations_url":"https://api.github.com/users/Warchant/orgs","repos_url":"https://api.github.com/users/Warchant/repos","events_url":"https://api.github.com/users/Warchant/events{/privacy}","received_events_url":"https://api.github.com/users/Warchant/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n\r\n- [x] CircleCI:\r\n\t- [x] remove redis\r\n\t- [x] change build type to Coverage\r\n\t- [x] Reduce parallelism from 4 to 3 in CircleCI to prevent internal compiler error due to lack of memory\r\n- [x] CMake:\r\n\t- [x] set minimal required version to 3.7\r\n\t- [x] organize cmake code in better structure\r\n\t- [x] pass compiler, generator and launcher to dependencies (only for CMake dependencies)\r\n\t- [x] fix bug in clang-format target -- it formatted sources at external and build (but they should have been excluded)\r\n\t- [x] cmake optimizations in dependencies, such as paths to libs\r\n\t- [x] Setup build types\r\n\t\t- (all) - default flags which are appended to all build types (default)\r\n\t\t- Debug - debug build, no optimizations\r\n\t\t- Release - release build with optimizations, binary stripping, no debug symbols included\r\n\t\t- Coverage - new build type, which installs flags for coverage builds (-O1)\r\n- [x] XCode:\r\n\t- [x] add ccache support\r\n\t- [x] fix build of dependencies which use cmake \r\n\t- [ ] dependencies with Makefile can not be fixed for XCode, **hunter** will be used to fix.\r\n- [x] Docker:\r\n\t- [x] update CMake to 3.10.2\r\n\t- [x] add latest CURL with SSL support (needed by hunter)\r\n\r\n\r\n### Benefits\r\n\r\nBetter, more readable cmake code. Bugfixes. Cleanup. \r\n\r\n### Possible Drawbacks \r\n\r\nNone.\r\n","created_at":"2018-02-15T22:54:59Z","updated_at":"2018-02-17T09:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3d07c4f6c620dfc838a10323f3e6696800500df","assignee":{"login":"Warchant","id":1867551,"avatar_url":"https://avatars0.githubusercontent.com/u/1867551?v=4","gravatar_id":"","url":"https://api.github.com/users/Warchant","html_url":"https://github.com/Warchant","followers_url":"https://api.github.com/users/Warchant/followers","following_url":"https://api.github.com/users/Warchant/following{/other_user}","gists_url":"https://api.github.com/users/Warchant/gists{/gist_id}","starred_url":"https://api.github.com/users/Warchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warchant/subscriptions","organizations_url":"https://api.github.com/users/Warchant/orgs","repos_url":"https://api.github.com/users/Warchant/repos","events_url":"https://api.github.com/users/Warchant/events{/privacy}","received_events_url":"https://api.github.com/users/Warchant/received_events","type":"User","site_admin":false},"assignees":[{"login":"Warchant","id":1867551,"avatar_url":"https://avatars0.githubusercontent.com/u/1867551?v=4","gravatar_id":"","url":"https://api.github.com/users/Warchant","html_url":"https://github.com/Warchant","followers_url":"https://api.github.com/users/Warchant/followers","following_url":"https://api.github.com/users/Warchant/following{/other_user}","gists_url":"https://api.github.com/users/Warchant/gists{/gist_id}","starred_url":"https://api.github.com/users/Warchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warchant/subscriptions","organizations_url":"https://api.github.com/users/Warchant/orgs","repos_url":"https://api.github.com/users/Warchant/repos","events_url":"https://api.github.com/users/Warchant/events{/privacy}","received_events_url":"https://api.github.com/users/Warchant/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lebdron","id":14347159,"avatar_url":"https://avatars1.githubusercontent.com/u/14347159?v=4","gravatar_id":"","url":"https://api.github.com/users/lebdron","html_url":"https://github.com/lebdron","followers_url":"https://api.github.com/users/lebdron/followers","following_url":"https://api.github.com/users/lebdron/following{/other_user}","gists_url":"https://api.github.com/users/lebdron/gists{/gist_id}","starred_url":"https://api.github.com/users/lebdron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lebdron/subscriptions","organizations_url":"https://api.github.com/users/lebdron/orgs","repos_url":"https://api.github.com/users/lebdron/repos","events_url":"https://api.github.com/users/lebdron/events{/privacy}","received_events_url":"https://api.github.com/users/lebdron/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":684699993,"url":"https://api.github.com/repos/hyperledger/iroha/labels/needs-review","name":"needs-review","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/983/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/983/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/983/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/0a9efb035a2437943af7675b85e4fcf96f2f7563","head":{"label":"hyperledger:feature/cmake-fixes","ref":"feature/cmake-fixes","sha":"0a9efb035a2437943af7675b85e4fcf96f2f7563","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-02-16T16:02:21Z","pushed_at":"2018-02-17T09:11:26Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":44880,"stargazers_count":597,"watchers_count":597,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":195,"open_issues":55,"watchers":597,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"6df02bef364a439054659cbfb756f6688256cc1c","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-02-16T16:02:21Z","pushed_at":"2018-02-17T09:11:26Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":44880,"stargazers_count":597,"watchers_count":597,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":195,"open_issues":55,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/983"},"html":{"href":"https://github.com/hyperledger/iroha/pull/983"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/983"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/983/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/983/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/983/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/0a9efb035a2437943af7675b85e4fcf96f2f7563"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Warchant"}}