{"action":"created","comment":{"url":"https://api.github.com/repos/webcompat/webcompat.com/pulls/comments/219716729","pull_request_review_id":157957382,"id":219716729,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcxNjcyOQ==","diff_hunk":"@@ -113,5 +113,11 @@ def test_form_rendering(self):\n         self.assertTrue('Mac OS X 10.13' in rv.data)\n         self.assertTrue('http://example.com/' in rv.data)\n \n+    def test_wellknown_subpath(self):\n+        \"\"\"Test that the /.wellknown/subpath route gets 404.\"\"\"\n+        rv = self.app.get('/.well-known/{subpath}')","path":"tests/unit/test_rendering.py","position":6,"original_position":6,"commit_id":"33324bdd60128707204cd7fedba040cc7b86538f","original_commit_id":"33324bdd60128707204cd7fedba040cc7b86538f","user":{"login":"karlcow","id":505230,"node_id":"MDQ6VXNlcjUwNTIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/505230?v=4","gravatar_id":"","url":"https://api.github.com/users/karlcow","html_url":"https://github.com/karlcow","followers_url":"https://api.github.com/users/karlcow/followers","following_url":"https://api.github.com/users/karlcow/following{/other_user}","gists_url":"https://api.github.com/users/karlcow/gists{/gist_id}","starred_url":"https://api.github.com/users/karlcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlcow/subscriptions","organizations_url":"https://api.github.com/users/karlcow/orgs","repos_url":"https://api.github.com/users/karlcow/repos","events_url":"https://api.github.com/users/karlcow/events{/privacy}","received_events_url":"https://api.github.com/users/karlcow/received_events","type":"User","site_admin":false},"body":"here the code is testing a `{subpath}` variable, which is not we are trying to do. The `{subpath}` in the flask route is a keyword we are using later on in the template. See [variable rules](http://flask.pocoo.org/docs/1.0/quickstart/#variable-rules)\r\n\r\nWe are trying to test if any string after `/.well-known/` will trigger a 404. For example `/.well-known/wonderland` or `/.well-known/jupiter` really anything should trigger a 404.\r\n\r\nSo you can name any tests routes, the name doesn't matter.","created_at":"2018-09-24T00:05:54Z","updated_at":"2018-09-24T00:07:34Z","html_url":"https://github.com/webcompat/webcompat.com/pull/2593#discussion_r219716729","pull_request_url":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/webcompat/webcompat.com/pulls/comments/219716729"},"html":{"href":"https://github.com/webcompat/webcompat.com/pull/2593#discussion_r219716729"},"pull_request":{"href":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593"}}},"pull_request":{"url":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593","id":217504789,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTA0Nzg5","html_url":"https://github.com/webcompat/webcompat.com/pull/2593","diff_url":"https://github.com/webcompat/webcompat.com/pull/2593.diff","patch_url":"https://github.com/webcompat/webcompat.com/pull/2593.patch","issue_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/2593","number":2593,"state":"open","locked":false,"title":"added subpath parameter to the wellknown function","user":{"login":"kritisingh1","id":22004158,"node_id":"MDQ6VXNlcjIyMDA0MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/22004158?v=4","gravatar_id":"","url":"https://api.github.com/users/kritisingh1","html_url":"https://github.com/kritisingh1","followers_url":"https://api.github.com/users/kritisingh1/followers","following_url":"https://api.github.com/users/kritisingh1/following{/other_user}","gists_url":"https://api.github.com/users/kritisingh1/gists{/gist_id}","starred_url":"https://api.github.com/users/kritisingh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kritisingh1/subscriptions","organizations_url":"https://api.github.com/users/kritisingh1/orgs","repos_url":"https://api.github.com/users/kritisingh1/repos","events_url":"https://api.github.com/users/kritisingh1/events{/privacy}","received_events_url":"https://api.github.com/users/kritisingh1/received_events","type":"User","site_admin":false},"body":"Fixes issue #2587 \r\nI also made minor correction in the file `test_urls.py`\r\n@karlcow Please review.\r\n","created_at":"2018-09-23T11:10:28Z","updated_at":"2018-09-24T00:07:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3231cb205404fa77d8706bf2b7ce5b005c1938f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593/commits","review_comments_url":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593/comments","review_comment_url":"https://api.github.com/repos/webcompat/webcompat.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/2593/comments","statuses_url":"https://api.github.com/repos/webcompat/webcompat.com/statuses/33324bdd60128707204cd7fedba040cc7b86538f","head":{"label":"kritisingh1:subpath","ref":"subpath","sha":"33324bdd60128707204cd7fedba040cc7b86538f","user":{"login":"kritisingh1","id":22004158,"node_id":"MDQ6VXNlcjIyMDA0MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/22004158?v=4","gravatar_id":"","url":"https://api.github.com/users/kritisingh1","html_url":"https://github.com/kritisingh1","followers_url":"https://api.github.com/users/kritisingh1/followers","following_url":"https://api.github.com/users/kritisingh1/following{/other_user}","gists_url":"https://api.github.com/users/kritisingh1/gists{/gist_id}","starred_url":"https://api.github.com/users/kritisingh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kritisingh1/subscriptions","organizations_url":"https://api.github.com/users/kritisingh1/orgs","repos_url":"https://api.github.com/users/kritisingh1/repos","events_url":"https://api.github.com/users/kritisingh1/events{/privacy}","received_events_url":"https://api.github.com/users/kritisingh1/received_events","type":"User","site_admin":false},"repo":{"id":149266984,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkyNjY5ODQ=","name":"webcompat.com","full_name":"kritisingh1/webcompat.com","private":false,"owner":{"login":"kritisingh1","id":22004158,"node_id":"MDQ6VXNlcjIyMDA0MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/22004158?v=4","gravatar_id":"","url":"https://api.github.com/users/kritisingh1","html_url":"https://github.com/kritisingh1","followers_url":"https://api.github.com/users/kritisingh1/followers","following_url":"https://api.github.com/users/kritisingh1/following{/other_user}","gists_url":"https://api.github.com/users/kritisingh1/gists{/gist_id}","starred_url":"https://api.github.com/users/kritisingh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kritisingh1/subscriptions","organizations_url":"https://api.github.com/users/kritisingh1/orgs","repos_url":"https://api.github.com/users/kritisingh1/repos","events_url":"https://api.github.com/users/kritisingh1/events{/privacy}","received_events_url":"https://api.github.com/users/kritisingh1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kritisingh1/webcompat.com","description":"Source code for","fork":true,"url":"https://api.github.com/repos/kritisingh1/webcompat.com","forks_url":"https://api.github.com/repos/kritisingh1/webcompat.com/forks","keys_url":"https://api.github.com/repos/kritisingh1/webcompat.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kritisingh1/webcompat.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kritisingh1/webcompat.com/teams","hooks_url":"https://api.github.com/repos/kritisingh1/webcompat.com/hooks","issue_events_url":"https://api.github.com/repos/kritisingh1/webcompat.com/issues/events{/number}","events_url":"https://api.github.com/repos/kritisingh1/webcompat.com/events","assignees_url":"https://api.github.com/repos/kritisingh1/webcompat.com/assignees{/user}","branches_url":"https://api.github.com/repos/kritisingh1/webcompat.com/branches{/branch}","tags_url":"https://api.github.com/repos/kritisingh1/webcompat.com/tags","blobs_url":"https://api.github.com/repos/kritisingh1/webcompat.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kritisingh1/webcompat.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kritisingh1/webcompat.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/kritisingh1/webcompat.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kritisingh1/webcompat.com/statuses/{sha}","languages_url":"https://api.github.com/repos/kritisingh1/webcompat.com/languages","stargazers_url":"https://api.github.com/repos/kritisingh1/webcompat.com/stargazers","contributors_url":"https://api.github.com/repos/kritisingh1/webcompat.com/contributors","subscribers_url":"https://api.github.com/repos/kritisingh1/webcompat.com/subscribers","subscription_url":"https://api.github.com/repos/kritisingh1/webcompat.com/subscription","commits_url":"https://api.github.com/repos/kritisingh1/webcompat.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/kritisingh1/webcompat.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/kritisingh1/webcompat.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/kritisingh1/webcompat.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/kritisingh1/webcompat.com/contents/{+path}","compare_url":"https://api.github.com/repos/kritisingh1/webcompat.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kritisingh1/webcompat.com/merges","archive_url":"https://api.github.com/repos/kritisingh1/webcompat.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kritisingh1/webcompat.com/downloads","issues_url":"https://api.github.com/repos/kritisingh1/webcompat.com/issues{/number}","pulls_url":"https://api.github.com/repos/kritisingh1/webcompat.com/pulls{/number}","milestones_url":"https://api.github.com/repos/kritisingh1/webcompat.com/milestones{/number}","notifications_url":"https://api.github.com/repos/kritisingh1/webcompat.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kritisingh1/webcompat.com/labels{/name}","releases_url":"https://api.github.com/repos/kritisingh1/webcompat.com/releases{/id}","deployments_url":"https://api.github.com/repos/kritisingh1/webcompat.com/deployments","created_at":"2018-09-18T10:01:53Z","updated_at":"2018-09-18T10:01:56Z","pushed_at":"2018-09-23T11:07:41Z","git_url":"git://github.com/kritisingh1/webcompat.com.git","ssh_url":"git@github.com:kritisingh1/webcompat.com.git","clone_url":"https://github.com/kritisingh1/webcompat.com.git","svn_url":"https://github.com/kritisingh1/webcompat.com","homepage":"https://webcompat.com","size":12452,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webcompat:master","ref":"master","sha":"95e0cd84dddf8d45166bd3f4d47b4470299c247d","user":{"login":"webcompat","id":6175168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNzUxNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/6175168?v=4","gravatar_id":"","url":"https://api.github.com/users/webcompat","html_url":"https://github.com/webcompat","followers_url":"https://api.github.com/users/webcompat/followers","following_url":"https://api.github.com/users/webcompat/following{/other_user}","gists_url":"https://api.github.com/users/webcompat/gists{/gist_id}","starred_url":"https://api.github.com/users/webcompat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcompat/subscriptions","organizations_url":"https://api.github.com/users/webcompat/orgs","repos_url":"https://api.github.com/users/webcompat/repos","events_url":"https://api.github.com/users/webcompat/events{/privacy}","received_events_url":"https://api.github.com/users/webcompat/received_events","type":"Organization","site_admin":false},"repo":{"id":15174830,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3NDgzMA==","name":"webcompat.com","full_name":"webcompat/webcompat.com","private":false,"owner":{"login":"webcompat","id":6175168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNzUxNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/6175168?v=4","gravatar_id":"","url":"https://api.github.com/users/webcompat","html_url":"https://github.com/webcompat","followers_url":"https://api.github.com/users/webcompat/followers","following_url":"https://api.github.com/users/webcompat/following{/other_user}","gists_url":"https://api.github.com/users/webcompat/gists{/gist_id}","starred_url":"https://api.github.com/users/webcompat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webcompat/subscriptions","organizations_url":"https://api.github.com/users/webcompat/orgs","repos_url":"https://api.github.com/users/webcompat/repos","events_url":"https://api.github.com/users/webcompat/events{/privacy}","received_events_url":"https://api.github.com/users/webcompat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webcompat/webcompat.com","description":"Source code for","fork":false,"url":"https://api.github.com/repos/webcompat/webcompat.com","forks_url":"https://api.github.com/repos/webcompat/webcompat.com/forks","keys_url":"https://api.github.com/repos/webcompat/webcompat.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webcompat/webcompat.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webcompat/webcompat.com/teams","hooks_url":"https://api.github.com/repos/webcompat/webcompat.com/hooks","issue_events_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/events{/number}","events_url":"https://api.github.com/repos/webcompat/webcompat.com/events","assignees_url":"https://api.github.com/repos/webcompat/webcompat.com/assignees{/user}","branches_url":"https://api.github.com/repos/webcompat/webcompat.com/branches{/branch}","tags_url":"https://api.github.com/repos/webcompat/webcompat.com/tags","blobs_url":"https://api.github.com/repos/webcompat/webcompat.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webcompat/webcompat.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webcompat/webcompat.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/webcompat/webcompat.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webcompat/webcompat.com/statuses/{sha}","languages_url":"https://api.github.com/repos/webcompat/webcompat.com/languages","stargazers_url":"https://api.github.com/repos/webcompat/webcompat.com/stargazers","contributors_url":"https://api.github.com/repos/webcompat/webcompat.com/contributors","subscribers_url":"https://api.github.com/repos/webcompat/webcompat.com/subscribers","subscription_url":"https://api.github.com/repos/webcompat/webcompat.com/subscription","commits_url":"https://api.github.com/repos/webcompat/webcompat.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/webcompat/webcompat.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/webcompat/webcompat.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/webcompat/webcompat.com/contents/{+path}","compare_url":"https://api.github.com/repos/webcompat/webcompat.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webcompat/webcompat.com/merges","archive_url":"https://api.github.com/repos/webcompat/webcompat.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webcompat/webcompat.com/downloads","issues_url":"https://api.github.com/repos/webcompat/webcompat.com/issues{/number}","pulls_url":"https://api.github.com/repos/webcompat/webcompat.com/pulls{/number}","milestones_url":"https://api.github.com/repos/webcompat/webcompat.com/milestones{/number}","notifications_url":"https://api.github.com/repos/webcompat/webcompat.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webcompat/webcompat.com/labels{/name}","releases_url":"https://api.github.com/repos/webcompat/webcompat.com/releases{/id}","deployments_url":"https://api.github.com/repos/webcompat/webcompat.com/deployments","created_at":"2013-12-13T21:44:40Z","updated_at":"2018-09-23T22:07:37Z","pushed_at":"2018-09-23T23:58:45Z","git_url":"git://github.com/webcompat/webcompat.com.git","ssh_url":"git@github.com:webcompat/webcompat.com.git","clone_url":"https://github.com/webcompat/webcompat.com.git","svn_url":"https://github.com/webcompat/webcompat.com","homepage":"https://webcompat.com","size":12454,"stargazers_count":140,"watchers_count":140,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":192,"license":null,"forks":98,"open_issues":192,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593"},"html":{"href":"https://github.com/webcompat/webcompat.com/pull/2593"},"issue":{"href":"https://api.github.com/repos/webcompat/webcompat.com/issues/2593"},"comments":{"href":"https://api.github.com/repos/webcompat/webcompat.com/issues/2593/comments"},"review_comments":{"href":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593/comments"},"review_comment":{"href":"https://api.github.com/repos/webcompat/webcompat.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webcompat/webcompat.com/pulls/2593/commits"},"statuses":{"href":"https://api.github.com/repos/webcompat/webcompat.com/statuses/33324bdd60128707204cd7fedba040cc7b86538f"}},"author_association":"NONE"}}
{"actor":{"display_login":"karlcow"}}