{"action":"created","comment":{"url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/comments/226236657","pull_request_review_id":166004612,"id":226236657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIzNjY1Nw==","diff_hunk":"@@ -30,16 +30,19 @@ final class DogsViewController: UIViewController {\n         \n         tableView.dataSource = nil // Required as dataSource is being replaced\n         \n-        let input = DogsViewModel.Input(filterString: searchBar.rx.text.asObservable())\n+        let searchBarText = searchBar.rx.text.asObservable()\n         \n+        let input = DogsViewModel.Input(query: searchBarText)\n         let output = viewModel.transform(input)\n         \n-        output.networkRequestResult\n+        viewModel.filterDogs(query: searchBarText, dogs: output.networkRequestResult)\n             .bind(to: tableView.rx.items(cellIdentifier: \"dogCell\", cellType: UITableViewCell.self)) { row, dog, cell in\n                 cell.textLabel?.text = dog.breed\n-            }\n-            .disposed(by: disposeBag)\n+        }.disposed(by: disposeBag)\n         \n-        // TODO: Bind searchBar to data\n+        searchBar.rx.searchButtonClicked.asObservable()\n+            .bind {\n+                self.searchBar.resignFirstResponder()","path":"NCU-Project/Dogs/DogsViewController.swift","position":21,"original_position":21,"commit_id":"f6c622ad70d3d9c641610b3a6af281bc9d90859d","original_commit_id":"97d0b35582680ced34ae9052e003150ba62347d7","user":{"login":"tailec","id":10499966,"node_id":"MDQ6VXNlcjEwNDk5OTY2","avatar_url":"https://avatars3.githubusercontent.com/u/10499966?v=4","gravatar_id":"","url":"https://api.github.com/users/tailec","html_url":"https://github.com/tailec","followers_url":"https://api.github.com/users/tailec/followers","following_url":"https://api.github.com/users/tailec/following{/other_user}","gists_url":"https://api.github.com/users/tailec/gists{/gist_id}","starred_url":"https://api.github.com/users/tailec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tailec/subscriptions","organizations_url":"https://api.github.com/users/tailec/orgs","repos_url":"https://api.github.com/users/tailec/repos","events_url":"https://api.github.com/users/tailec/events{/privacy}","received_events_url":"https://api.github.com/users/tailec/received_events","type":"User","site_admin":false},"body":"nice one, good choice of keeping this in view controller\r\ncan add `guard let strongSelf = self else { return }` because of possible memory leak here","created_at":"2018-10-18T09:37:59Z","updated_at":"2018-10-18T09:40:20Z","html_url":"https://github.com/simonrowlands/NCU-Project/pull/3#discussion_r226236657","pull_request_url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/comments/226236657"},"html":{"href":"https://github.com/simonrowlands/NCU-Project/pull/3#discussion_r226236657"},"pull_request":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3","id":223663971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjYzOTcx","html_url":"https://github.com/simonrowlands/NCU-Project/pull/3","diff_url":"https://github.com/simonrowlands/NCU-Project/pull/3.diff","patch_url":"https://github.com/simonrowlands/NCU-Project/pull/3.patch","issue_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/3","number":3,"state":"open","locked":false,"title":"+Filter by dog breed name","user":{"login":"simonrowlands","id":19956230,"node_id":"MDQ6VXNlcjE5OTU2MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/19956230?v=4","gravatar_id":"","url":"https://api.github.com/users/simonrowlands","html_url":"https://github.com/simonrowlands","followers_url":"https://api.github.com/users/simonrowlands/followers","following_url":"https://api.github.com/users/simonrowlands/following{/other_user}","gists_url":"https://api.github.com/users/simonrowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/simonrowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonrowlands/subscriptions","organizations_url":"https://api.github.com/users/simonrowlands/orgs","repos_url":"https://api.github.com/users/simonrowlands/repos","events_url":"https://api.github.com/users/simonrowlands/events{/privacy}","received_events_url":"https://api.github.com/users/simonrowlands/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-17T16:04:42Z","updated_at":"2018-10-18T09:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1aed57525552045059b2efe6659e5d78aa96fa3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3/commits","review_comments_url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3/comments","review_comment_url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/3/comments","statuses_url":"https://api.github.com/repos/simonrowlands/NCU-Project/statuses/f6c622ad70d3d9c641610b3a6af281bc9d90859d","head":{"label":"simonrowlands:develop","ref":"develop","sha":"f6c622ad70d3d9c641610b3a6af281bc9d90859d","user":{"login":"simonrowlands","id":19956230,"node_id":"MDQ6VXNlcjE5OTU2MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/19956230?v=4","gravatar_id":"","url":"https://api.github.com/users/simonrowlands","html_url":"https://github.com/simonrowlands","followers_url":"https://api.github.com/users/simonrowlands/followers","following_url":"https://api.github.com/users/simonrowlands/following{/other_user}","gists_url":"https://api.github.com/users/simonrowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/simonrowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonrowlands/subscriptions","organizations_url":"https://api.github.com/users/simonrowlands/orgs","repos_url":"https://api.github.com/users/simonrowlands/repos","events_url":"https://api.github.com/users/simonrowlands/events{/privacy}","received_events_url":"https://api.github.com/users/simonrowlands/received_events","type":"User","site_admin":false},"repo":{"id":153121933,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxMjE5MzM=","name":"NCU-Project","full_name":"simonrowlands/NCU-Project","private":false,"owner":{"login":"simonrowlands","id":19956230,"node_id":"MDQ6VXNlcjE5OTU2MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/19956230?v=4","gravatar_id":"","url":"https://api.github.com/users/simonrowlands","html_url":"https://github.com/simonrowlands","followers_url":"https://api.github.com/users/simonrowlands/followers","following_url":"https://api.github.com/users/simonrowlands/following{/other_user}","gists_url":"https://api.github.com/users/simonrowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/simonrowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonrowlands/subscriptions","organizations_url":"https://api.github.com/users/simonrowlands/orgs","repos_url":"https://api.github.com/users/simonrowlands/repos","events_url":"https://api.github.com/users/simonrowlands/events{/privacy}","received_events_url":"https://api.github.com/users/simonrowlands/received_events","type":"User","site_admin":false},"html_url":"https://github.com/simonrowlands/NCU-Project","description":"A personal project for NCU","fork":false,"url":"https://api.github.com/repos/simonrowlands/NCU-Project","forks_url":"https://api.github.com/repos/simonrowlands/NCU-Project/forks","keys_url":"https://api.github.com/repos/simonrowlands/NCU-Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonrowlands/NCU-Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonrowlands/NCU-Project/teams","hooks_url":"https://api.github.com/repos/simonrowlands/NCU-Project/hooks","issue_events_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/events{/number}","events_url":"https://api.github.com/repos/simonrowlands/NCU-Project/events","assignees_url":"https://api.github.com/repos/simonrowlands/NCU-Project/assignees{/user}","branches_url":"https://api.github.com/repos/simonrowlands/NCU-Project/branches{/branch}","tags_url":"https://api.github.com/repos/simonrowlands/NCU-Project/tags","blobs_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonrowlands/NCU-Project/statuses/{sha}","languages_url":"https://api.github.com/repos/simonrowlands/NCU-Project/languages","stargazers_url":"https://api.github.com/repos/simonrowlands/NCU-Project/stargazers","contributors_url":"https://api.github.com/repos/simonrowlands/NCU-Project/contributors","subscribers_url":"https://api.github.com/repos/simonrowlands/NCU-Project/subscribers","subscription_url":"https://api.github.com/repos/simonrowlands/NCU-Project/subscription","commits_url":"https://api.github.com/repos/simonrowlands/NCU-Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonrowlands/NCU-Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonrowlands/NCU-Project/contents/{+path}","compare_url":"https://api.github.com/repos/simonrowlands/NCU-Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonrowlands/NCU-Project/merges","archive_url":"https://api.github.com/repos/simonrowlands/NCU-Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonrowlands/NCU-Project/downloads","issues_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues{/number}","pulls_url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls{/number}","milestones_url":"https://api.github.com/repos/simonrowlands/NCU-Project/milestones{/number}","notifications_url":"https://api.github.com/repos/simonrowlands/NCU-Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonrowlands/NCU-Project/labels{/name}","releases_url":"https://api.github.com/repos/simonrowlands/NCU-Project/releases{/id}","deployments_url":"https://api.github.com/repos/simonrowlands/NCU-Project/deployments","created_at":"2018-10-15T13:53:07Z","updated_at":"2018-10-17T08:33:25Z","pushed_at":"2018-10-18T09:33:57Z","git_url":"git://github.com/simonrowlands/NCU-Project.git","ssh_url":"git@github.com:simonrowlands/NCU-Project.git","clone_url":"https://github.com/simonrowlands/NCU-Project.git","svn_url":"https://github.com/simonrowlands/NCU-Project","homepage":null,"size":469,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"simonrowlands:master","ref":"master","sha":"5f6835d56bbfa948798f94e3ab143d8b18c6ffa2","user":{"login":"simonrowlands","id":19956230,"node_id":"MDQ6VXNlcjE5OTU2MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/19956230?v=4","gravatar_id":"","url":"https://api.github.com/users/simonrowlands","html_url":"https://github.com/simonrowlands","followers_url":"https://api.github.com/users/simonrowlands/followers","following_url":"https://api.github.com/users/simonrowlands/following{/other_user}","gists_url":"https://api.github.com/users/simonrowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/simonrowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonrowlands/subscriptions","organizations_url":"https://api.github.com/users/simonrowlands/orgs","repos_url":"https://api.github.com/users/simonrowlands/repos","events_url":"https://api.github.com/users/simonrowlands/events{/privacy}","received_events_url":"https://api.github.com/users/simonrowlands/received_events","type":"User","site_admin":false},"repo":{"id":153121933,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxMjE5MzM=","name":"NCU-Project","full_name":"simonrowlands/NCU-Project","private":false,"owner":{"login":"simonrowlands","id":19956230,"node_id":"MDQ6VXNlcjE5OTU2MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/19956230?v=4","gravatar_id":"","url":"https://api.github.com/users/simonrowlands","html_url":"https://github.com/simonrowlands","followers_url":"https://api.github.com/users/simonrowlands/followers","following_url":"https://api.github.com/users/simonrowlands/following{/other_user}","gists_url":"https://api.github.com/users/simonrowlands/gists{/gist_id}","starred_url":"https://api.github.com/users/simonrowlands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonrowlands/subscriptions","organizations_url":"https://api.github.com/users/simonrowlands/orgs","repos_url":"https://api.github.com/users/simonrowlands/repos","events_url":"https://api.github.com/users/simonrowlands/events{/privacy}","received_events_url":"https://api.github.com/users/simonrowlands/received_events","type":"User","site_admin":false},"html_url":"https://github.com/simonrowlands/NCU-Project","description":"A personal project for NCU","fork":false,"url":"https://api.github.com/repos/simonrowlands/NCU-Project","forks_url":"https://api.github.com/repos/simonrowlands/NCU-Project/forks","keys_url":"https://api.github.com/repos/simonrowlands/NCU-Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonrowlands/NCU-Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonrowlands/NCU-Project/teams","hooks_url":"https://api.github.com/repos/simonrowlands/NCU-Project/hooks","issue_events_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/events{/number}","events_url":"https://api.github.com/repos/simonrowlands/NCU-Project/events","assignees_url":"https://api.github.com/repos/simonrowlands/NCU-Project/assignees{/user}","branches_url":"https://api.github.com/repos/simonrowlands/NCU-Project/branches{/branch}","tags_url":"https://api.github.com/repos/simonrowlands/NCU-Project/tags","blobs_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonrowlands/NCU-Project/statuses/{sha}","languages_url":"https://api.github.com/repos/simonrowlands/NCU-Project/languages","stargazers_url":"https://api.github.com/repos/simonrowlands/NCU-Project/stargazers","contributors_url":"https://api.github.com/repos/simonrowlands/NCU-Project/contributors","subscribers_url":"https://api.github.com/repos/simonrowlands/NCU-Project/subscribers","subscription_url":"https://api.github.com/repos/simonrowlands/NCU-Project/subscription","commits_url":"https://api.github.com/repos/simonrowlands/NCU-Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonrowlands/NCU-Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonrowlands/NCU-Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonrowlands/NCU-Project/contents/{+path}","compare_url":"https://api.github.com/repos/simonrowlands/NCU-Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonrowlands/NCU-Project/merges","archive_url":"https://api.github.com/repos/simonrowlands/NCU-Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonrowlands/NCU-Project/downloads","issues_url":"https://api.github.com/repos/simonrowlands/NCU-Project/issues{/number}","pulls_url":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls{/number}","milestones_url":"https://api.github.com/repos/simonrowlands/NCU-Project/milestones{/number}","notifications_url":"https://api.github.com/repos/simonrowlands/NCU-Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonrowlands/NCU-Project/labels{/name}","releases_url":"https://api.github.com/repos/simonrowlands/NCU-Project/releases{/id}","deployments_url":"https://api.github.com/repos/simonrowlands/NCU-Project/deployments","created_at":"2018-10-15T13:53:07Z","updated_at":"2018-10-17T08:33:25Z","pushed_at":"2018-10-18T09:33:57Z","git_url":"git://github.com/simonrowlands/NCU-Project.git","ssh_url":"git@github.com:simonrowlands/NCU-Project.git","clone_url":"https://github.com/simonrowlands/NCU-Project.git","svn_url":"https://github.com/simonrowlands/NCU-Project","homepage":null,"size":469,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3"},"html":{"href":"https://github.com/simonrowlands/NCU-Project/pull/3"},"issue":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/3"},"comments":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/simonrowlands/NCU-Project/statuses/f6c622ad70d3d9c641610b3a6af281bc9d90859d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tailec"}}