{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/244250186","pull_request_review_id":188204997,"id":244250186,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDI1MDE4Ng==","diff_hunk":"@@ -1221,8 +1224,23 @@ void EngineBuffer::updateIndicators(double speed, int iBufferSize) {\n         const double samplePositionToSeconds = 1.0 / m_trackSampleRateOld\n                 / kSamplesPerFrame / m_tempo_ratio_old;\n         m_timeElapsed->set(m_filepos_play * samplePositionToSeconds);\n-        m_timeRemaining->set(std::max(m_trackSamplesOld - m_filepos_play, 0.0) *\n-                samplePositionToSeconds);\n+        double timeRemaining = std::max(m_trackSamplesOld - m_filepos_play, 0.0) *\n+                samplePositionToSeconds;\n+        m_timeRemaining->set(timeRemaining);\n+\n+        auto pFactory = WaveformWidgetFactory::instance();","path":"src/engine/enginebuffer.cpp","position":43,"original_position":43,"commit_id":"30a2be8677be20effb08cae444f9a5ab752e6288","original_commit_id":"30a2be8677be20effb08cae444f9a5ab752e6288","user":{"login":"daschuer","id":1777442,"node_id":"MDQ6VXNlcjE3Nzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"replaygainsettings is only a wrapper around the get calls into the config, This does not suite here. WaveformWidgetFactory hold the integer value directly. \r\nI have actually started to fix the dependency issue, but have reverted the code, since I have noticed the the value is in the [Waveform] group, which will clutter the engine anyway. \r\nA complete fix would be finally too big.\r\n \r\n","created_at":"2018-12-28T01:51:14Z","updated_at":"2018-12-28T01:51:14Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1963#discussion_r244250186","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/244250186"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1963#discussion_r244250186"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963"}},"in_reply_to_id":244225968},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963","id":240879851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODc5ODUx","html_url":"https://github.com/mixxxdj/mixxx/pull/1963","diff_url":"https://github.com/mixxxdj/mixxx/pull/1963.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1963.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1963","number":1963,"state":"open","locked":false,"title":"widget independent End of track CO","user":{"login":"daschuer","id":1777442,"node_id":"MDQ6VXNlcjE3Nzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"This makes the End of track CO independent from any widget. \r\nIt is required to remove the invisible waveform from https://github.com/mixxxdj/mixxx/pull/1933","created_at":"2018-12-25T14:56:54Z","updated_at":"2018-12-28T01:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03aebe4dee25522d649a1735d22ebf2f5f5888c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1963/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/30a2be8677be20effb08cae444f9a5ab752e6288","head":{"label":"daschuer:end_of_track","ref":"end_of_track","sha":"30a2be8677be20effb08cae444f9a5ab752e6288","user":{"login":"daschuer","id":1777442,"node_id":"MDQ6VXNlcjE3Nzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"repo":{"id":10669071,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY2OTA3MQ==","name":"mixxx","full_name":"daschuer/mixxx","private":false,"owner":{"login":"daschuer","id":1777442,"node_id":"MDQ6VXNlcjE3Nzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/daschuer/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/daschuer/mixxx","forks_url":"https://api.github.com/repos/daschuer/mixxx/forks","keys_url":"https://api.github.com/repos/daschuer/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daschuer/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daschuer/mixxx/teams","hooks_url":"https://api.github.com/repos/daschuer/mixxx/hooks","issue_events_url":"https://api.github.com/repos/daschuer/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/daschuer/mixxx/events","assignees_url":"https://api.github.com/repos/daschuer/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/daschuer/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/daschuer/mixxx/tags","blobs_url":"https://api.github.com/repos/daschuer/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daschuer/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daschuer/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/daschuer/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daschuer/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/daschuer/mixxx/languages","stargazers_url":"https://api.github.com/repos/daschuer/mixxx/stargazers","contributors_url":"https://api.github.com/repos/daschuer/mixxx/contributors","subscribers_url":"https://api.github.com/repos/daschuer/mixxx/subscribers","subscription_url":"https://api.github.com/repos/daschuer/mixxx/subscription","commits_url":"https://api.github.com/repos/daschuer/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/daschuer/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/daschuer/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/daschuer/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/daschuer/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/daschuer/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daschuer/mixxx/merges","archive_url":"https://api.github.com/repos/daschuer/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daschuer/mixxx/downloads","issues_url":"https://api.github.com/repos/daschuer/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/daschuer/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/daschuer/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/daschuer/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daschuer/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/daschuer/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/daschuer/mixxx/deployments","created_at":"2013-06-13T15:21:23Z","updated_at":"2018-12-16T08:08:38Z","pushed_at":"2018-12-28T00:43:10Z","git_url":"git://github.com/daschuer/mixxx.git","ssh_url":"git@github.com:daschuer/mixxx.git","clone_url":"https://github.com/daschuer/mixxx.git","svn_url":"https://github.com/daschuer/mixxx","homepage":null,"size":305668,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"a47a6dd6543d7804ca249ac66f9ab5f44abfdd7e","user":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjAzMQ==","name":"mixxx","full_name":"mixxxdj/mixxx","private":false,"owner":{"login":"mixxxdj","id":1743769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDM3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2018-12-28T00:35:56Z","pushed_at":"2018-12-28T00:46:49Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":301614,"stargazers_count":1189,"watchers_count":1189,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":546,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":546,"open_issues":96,"watchers":1189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1963"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1963"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1963/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1963/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/30a2be8677be20effb08cae444f9a5ab752e6288"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"daschuer"}}