{"action":"created","comment":{"url":"https://api.github.com/repos/elasticio/mssql-component/pulls/comments/195445030","pull_request_review_id":128815544,"id":195445030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQ0NTAzMA==","diff_hunk":"@@ -14,7 +14,18 @@ let connection;\n  * @param cfg\n  */\n function init(cfg) {\n-    const conString = cfg.uri;\n+    const conString = 'mssql://'\n+      + cfg.username","path":"lib/actions/select.js","position":null,"original_position":6,"commit_id":"3daa06e31157d93fc98ba2e12d3d2bad807fb2a8","original_commit_id":"37f65db18ac3e73536670c81b0815a1bc536f263","user":{"login":"kirill-levitskiy-elasticio","id":40201204,"node_id":"MDQ6VXNlcjQwMjAxMjA0","avatar_url":"https://avatars1.githubusercontent.com/u/40201204?v=4","gravatar_id":"","url":"https://api.github.com/users/kirill-levitskiy-elasticio","html_url":"https://github.com/kirill-levitskiy-elasticio","followers_url":"https://api.github.com/users/kirill-levitskiy-elasticio/followers","following_url":"https://api.github.com/users/kirill-levitskiy-elasticio/following{/other_user}","gists_url":"https://api.github.com/users/kirill-levitskiy-elasticio/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-levitskiy-elasticio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-levitskiy-elasticio/subscriptions","organizations_url":"https://api.github.com/users/kirill-levitskiy-elasticio/orgs","repos_url":"https://api.github.com/users/kirill-levitskiy-elasticio/repos","events_url":"https://api.github.com/users/kirill-levitskiy-elasticio/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-levitskiy-elasticio/received_events","type":"User","site_admin":false},"body":"The issue was fixed in the last commit by escaping special characters in username","created_at":"2018-06-14T14:27:45Z","updated_at":"2018-06-14T14:27:45Z","html_url":"https://github.com/elasticio/mssql-component/pull/7#discussion_r195445030","pull_request_url":"https://api.github.com/repos/elasticio/mssql-component/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elasticio/mssql-component/pulls/comments/195445030"},"html":{"href":"https://github.com/elasticio/mssql-component/pull/7#discussion_r195445030"},"pull_request":{"href":"https://api.github.com/repos/elasticio/mssql-component/pulls/7"}},"in_reply_to_id":195409038},"pull_request":{"url":"https://api.github.com/repos/elasticio/mssql-component/pulls/7","id":194824812,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODI0ODEy","html_url":"https://github.com/elasticio/mssql-component/pull/7","diff_url":"https://github.com/elasticio/mssql-component/pull/7.diff","patch_url":"https://github.com/elasticio/mssql-component/pull/7.patch","issue_url":"https://api.github.com/repos/elasticio/mssql-component/issues/7","number":7,"state":"open","locked":false,"title":"Split URI to user-friendly configuration parameters","user":{"login":"kirill-levitskiy-elasticio","id":40201204,"node_id":"MDQ6VXNlcjQwMjAxMjA0","avatar_url":"https://avatars1.githubusercontent.com/u/40201204?v=4","gravatar_id":"","url":"https://api.github.com/users/kirill-levitskiy-elasticio","html_url":"https://github.com/kirill-levitskiy-elasticio","followers_url":"https://api.github.com/users/kirill-levitskiy-elasticio/followers","following_url":"https://api.github.com/users/kirill-levitskiy-elasticio/following{/other_user}","gists_url":"https://api.github.com/users/kirill-levitskiy-elasticio/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-levitskiy-elasticio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-levitskiy-elasticio/subscriptions","organizations_url":"https://api.github.com/users/kirill-levitskiy-elasticio/orgs","repos_url":"https://api.github.com/users/kirill-levitskiy-elasticio/repos","events_url":"https://api.github.com/users/kirill-levitskiy-elasticio/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-levitskiy-elasticio/received_events","type":"User","site_admin":false},"body":"Currently one have to enter an MSSQL URI as a string like:\r\n\r\nmssql://username:password@localhost/database\r\n\r\nIssues with it:\r\n\r\nNot very user friendly\r\nPassword is visible in UI and not protected\r\nHowever, advantages are that many possible settings could be build in as encoded in URI. We need t good solution to combine streights but not weaknesses.\r\n\r\nIssue: [https://github.com/elasticio/mssql-component/issues/6](url)","created_at":"2018-06-14T09:06:58Z","updated_at":"2018-06-14T14:27:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49fa82dcdff2ee91c355259a04557d852951bc77","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elasticio/mssql-component/pulls/7/commits","review_comments_url":"https://api.github.com/repos/elasticio/mssql-component/pulls/7/comments","review_comment_url":"https://api.github.com/repos/elasticio/mssql-component/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elasticio/mssql-component/issues/7/comments","statuses_url":"https://api.github.com/repos/elasticio/mssql-component/statuses/3daa06e31157d93fc98ba2e12d3d2bad807fb2a8","head":{"label":"elasticio:URI_config_params","ref":"URI_config_params","sha":"3daa06e31157d93fc98ba2e12d3d2bad807fb2a8","user":{"login":"elasticio","id":1560253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1560253?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticio","html_url":"https://github.com/elasticio","followers_url":"https://api.github.com/users/elasticio/followers","following_url":"https://api.github.com/users/elasticio/following{/other_user}","gists_url":"https://api.github.com/users/elasticio/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticio/subscriptions","organizations_url":"https://api.github.com/users/elasticio/orgs","repos_url":"https://api.github.com/users/elasticio/repos","events_url":"https://api.github.com/users/elasticio/events{/privacy}","received_events_url":"https://api.github.com/users/elasticio/received_events","type":"Organization","site_admin":false},"repo":{"id":81496043,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQ5NjA0Mw==","name":"mssql-component","full_name":"elasticio/mssql-component","owner":{"login":"elasticio","id":1560253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1560253?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticio","html_url":"https://github.com/elasticio","followers_url":"https://api.github.com/users/elasticio/followers","following_url":"https://api.github.com/users/elasticio/following{/other_user}","gists_url":"https://api.github.com/users/elasticio/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticio/subscriptions","organizations_url":"https://api.github.com/users/elasticio/orgs","repos_url":"https://api.github.com/users/elasticio/repos","events_url":"https://api.github.com/users/elasticio/events{/privacy}","received_events_url":"https://api.github.com/users/elasticio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticio/mssql-component","description":"Microsoft SQL Server integration component for elastic.io platform","fork":false,"url":"https://api.github.com/repos/elasticio/mssql-component","forks_url":"https://api.github.com/repos/elasticio/mssql-component/forks","keys_url":"https://api.github.com/repos/elasticio/mssql-component/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticio/mssql-component/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticio/mssql-component/teams","hooks_url":"https://api.github.com/repos/elasticio/mssql-component/hooks","issue_events_url":"https://api.github.com/repos/elasticio/mssql-component/issues/events{/number}","events_url":"https://api.github.com/repos/elasticio/mssql-component/events","assignees_url":"https://api.github.com/repos/elasticio/mssql-component/assignees{/user}","branches_url":"https://api.github.com/repos/elasticio/mssql-component/branches{/branch}","tags_url":"https://api.github.com/repos/elasticio/mssql-component/tags","blobs_url":"https://api.github.com/repos/elasticio/mssql-component/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticio/mssql-component/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticio/mssql-component/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticio/mssql-component/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticio/mssql-component/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticio/mssql-component/languages","stargazers_url":"https://api.github.com/repos/elasticio/mssql-component/stargazers","contributors_url":"https://api.github.com/repos/elasticio/mssql-component/contributors","subscribers_url":"https://api.github.com/repos/elasticio/mssql-component/subscribers","subscription_url":"https://api.github.com/repos/elasticio/mssql-component/subscription","commits_url":"https://api.github.com/repos/elasticio/mssql-component/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticio/mssql-component/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticio/mssql-component/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticio/mssql-component/issues/comments{/number}","contents_url":"https://api.github.com/repos/elasticio/mssql-component/contents/{+path}","compare_url":"https://api.github.com/repos/elasticio/mssql-component/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticio/mssql-component/merges","archive_url":"https://api.github.com/repos/elasticio/mssql-component/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticio/mssql-component/downloads","issues_url":"https://api.github.com/repos/elasticio/mssql-component/issues{/number}","pulls_url":"https://api.github.com/repos/elasticio/mssql-component/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticio/mssql-component/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticio/mssql-component/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticio/mssql-component/labels{/name}","releases_url":"https://api.github.com/repos/elasticio/mssql-component/releases{/id}","deployments_url":"https://api.github.com/repos/elasticio/mssql-component/deployments","created_at":"2017-02-09T21:21:06Z","updated_at":"2018-06-14T08:57:59Z","pushed_at":"2018-06-14T14:19:36Z","git_url":"git://github.com/elasticio/mssql-component.git","ssh_url":"git@github.com:elasticio/mssql-component.git","clone_url":"https://github.com/elasticio/mssql-component.git","svn_url":"https://github.com/elasticio/mssql-component","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticio:master","ref":"master","sha":"aa3274966f50f9aaaf2a125092a9210b8bb6f5e9","user":{"login":"elasticio","id":1560253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1560253?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticio","html_url":"https://github.com/elasticio","followers_url":"https://api.github.com/users/elasticio/followers","following_url":"https://api.github.com/users/elasticio/following{/other_user}","gists_url":"https://api.github.com/users/elasticio/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticio/subscriptions","organizations_url":"https://api.github.com/users/elasticio/orgs","repos_url":"https://api.github.com/users/elasticio/repos","events_url":"https://api.github.com/users/elasticio/events{/privacy}","received_events_url":"https://api.github.com/users/elasticio/received_events","type":"Organization","site_admin":false},"repo":{"id":81496043,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQ5NjA0Mw==","name":"mssql-component","full_name":"elasticio/mssql-component","owner":{"login":"elasticio","id":1560253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1560253?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticio","html_url":"https://github.com/elasticio","followers_url":"https://api.github.com/users/elasticio/followers","following_url":"https://api.github.com/users/elasticio/following{/other_user}","gists_url":"https://api.github.com/users/elasticio/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticio/subscriptions","organizations_url":"https://api.github.com/users/elasticio/orgs","repos_url":"https://api.github.com/users/elasticio/repos","events_url":"https://api.github.com/users/elasticio/events{/privacy}","received_events_url":"https://api.github.com/users/elasticio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticio/mssql-component","description":"Microsoft SQL Server integration component for elastic.io platform","fork":false,"url":"https://api.github.com/repos/elasticio/mssql-component","forks_url":"https://api.github.com/repos/elasticio/mssql-component/forks","keys_url":"https://api.github.com/repos/elasticio/mssql-component/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticio/mssql-component/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticio/mssql-component/teams","hooks_url":"https://api.github.com/repos/elasticio/mssql-component/hooks","issue_events_url":"https://api.github.com/repos/elasticio/mssql-component/issues/events{/number}","events_url":"https://api.github.com/repos/elasticio/mssql-component/events","assignees_url":"https://api.github.com/repos/elasticio/mssql-component/assignees{/user}","branches_url":"https://api.github.com/repos/elasticio/mssql-component/branches{/branch}","tags_url":"https://api.github.com/repos/elasticio/mssql-component/tags","blobs_url":"https://api.github.com/repos/elasticio/mssql-component/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticio/mssql-component/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticio/mssql-component/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticio/mssql-component/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticio/mssql-component/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticio/mssql-component/languages","stargazers_url":"https://api.github.com/repos/elasticio/mssql-component/stargazers","contributors_url":"https://api.github.com/repos/elasticio/mssql-component/contributors","subscribers_url":"https://api.github.com/repos/elasticio/mssql-component/subscribers","subscription_url":"https://api.github.com/repos/elasticio/mssql-component/subscription","commits_url":"https://api.github.com/repos/elasticio/mssql-component/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticio/mssql-component/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticio/mssql-component/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticio/mssql-component/issues/comments{/number}","contents_url":"https://api.github.com/repos/elasticio/mssql-component/contents/{+path}","compare_url":"https://api.github.com/repos/elasticio/mssql-component/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticio/mssql-component/merges","archive_url":"https://api.github.com/repos/elasticio/mssql-component/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticio/mssql-component/downloads","issues_url":"https://api.github.com/repos/elasticio/mssql-component/issues{/number}","pulls_url":"https://api.github.com/repos/elasticio/mssql-component/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticio/mssql-component/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticio/mssql-component/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticio/mssql-component/labels{/name}","releases_url":"https://api.github.com/repos/elasticio/mssql-component/releases{/id}","deployments_url":"https://api.github.com/repos/elasticio/mssql-component/deployments","created_at":"2017-02-09T21:21:06Z","updated_at":"2018-06-14T08:57:59Z","pushed_at":"2018-06-14T14:19:36Z","git_url":"git://github.com/elasticio/mssql-component.git","ssh_url":"git@github.com:elasticio/mssql-component.git","clone_url":"https://github.com/elasticio/mssql-component.git","svn_url":"https://github.com/elasticio/mssql-component","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticio/mssql-component/pulls/7"},"html":{"href":"https://github.com/elasticio/mssql-component/pull/7"},"issue":{"href":"https://api.github.com/repos/elasticio/mssql-component/issues/7"},"comments":{"href":"https://api.github.com/repos/elasticio/mssql-component/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticio/mssql-component/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticio/mssql-component/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elasticio/mssql-component/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/elasticio/mssql-component/statuses/3daa06e31157d93fc98ba2e12d3d2bad807fb2a8"}},"author_association":"NONE"}}
{"actor":{"display_login":"kirill-levitskiy-elasticio"}}