{"action":"created","issue":{"url":"https://api.github.com/repos/ncw/rclone/issues/2270","repository_url":"https://api.github.com/repos/ncw/rclone","labels_url":"https://api.github.com/repos/ncw/rclone/issues/2270/labels{/name}","comments_url":"https://api.github.com/repos/ncw/rclone/issues/2270/comments","events_url":"https://api.github.com/repos/ncw/rclone/issues/2270/events","html_url":"https://github.com/ncw/rclone/pull/2270","id":316780798,"number":2270,"title":"copy: mkdir empty source directories to destination - fixes #1837","user":{"login":"ishuah","id":321040,"avatar_url":"https://avatars2.githubusercontent.com/u/321040?v=4","gravatar_id":"","url":"https://api.github.com/users/ishuah","html_url":"https://github.com/ishuah","followers_url":"https://api.github.com/users/ishuah/followers","following_url":"https://api.github.com/users/ishuah/following{/other_user}","gists_url":"https://api.github.com/users/ishuah/gists{/gist_id}","starred_url":"https://api.github.com/users/ishuah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishuah/subscriptions","organizations_url":"https://api.github.com/users/ishuah/orgs","repos_url":"https://api.github.com/users/ishuah/repos","events_url":"https://api.github.com/users/ishuah/events{/privacy}","received_events_url":"https://api.github.com/users/ishuah/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-23T11:59:15Z","updated_at":"2018-04-28T09:08:26Z","closed_at":"2018-04-27T15:15:33Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ncw/rclone/pulls/2270","html_url":"https://github.com/ncw/rclone/pull/2270","diff_url":"https://github.com/ncw/rclone/pull/2270.diff","patch_url":"https://github.com/ncw/rclone/pull/2270.patch"},"body":"This PR simply creates empty src directories on the destination. Addresses #1837 "},"comment":{"url":"https://api.github.com/repos/ncw/rclone/issues/comments/385155544","html_url":"https://github.com/ncw/rclone/pull/2270#issuecomment-385155544","issue_url":"https://api.github.com/repos/ncw/rclone/issues/2270","id":385155544,"user":{"login":"ncw","id":536803,"avatar_url":"https://avatars2.githubusercontent.com/u/536803?v=4","gravatar_id":"","url":"https://api.github.com/users/ncw","html_url":"https://github.com/ncw","followers_url":"https://api.github.com/users/ncw/followers","following_url":"https://api.github.com/users/ncw/following{/other_user}","gists_url":"https://api.github.com/users/ncw/gists{/gist_id}","starred_url":"https://api.github.com/users/ncw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncw/subscriptions","organizations_url":"https://api.github.com/users/ncw/orgs","repos_url":"https://api.github.com/users/ncw/repos","events_url":"https://api.github.com/users/ncw/events{/privacy}","received_events_url":"https://api.github.com/users/ncw/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T09:08:26Z","updated_at":"2018-04-28T09:08:26Z","author_association":"OWNER","body":"I'm sorry, I had to revert this in 74cbdea0ef860e8a9c77d049343d8d1fd14e36d4 \r\n\r\nUnfortunately the `s.srcEmptyDirs` contains all directories not just empty ones so this attempts to recreate all the directories in the sync.\r\n\r\nThis isn't incorrect, but it is inefficient and the debug message that it has created so many directories confuses the users.\r\n\r\nSo I think we need to work on making sure empty directories only get in to that variable only.  This isn't completely straight forward though!\r\n\r\nMy best idea was to turn the []string into a map[string]struct{} then add the directories the places they are added at the moment, but remove them if we ever find anything within them."}}
{"actor":{"display_login":"ncw"}}