{"action":"created","comment":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments/229693788","pull_request_review_id":170251828,"id":229693788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTY5Mzc4OA==","diff_hunk":"@@ -531,39 +530,26 @@\n     <Compile Include=\"Runtime\\WebRuntimeComponent.cs\" />\n     <Compile Include=\"Editors\\PublishedStatusController.cs\" />\n     <Compile Include=\"Editors\\NuCacheStatusController.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\Action.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionAssignDomain.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionBrowse.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionChangeDocType.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionCollection.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionCollectionBuilder.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionCopy.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionCreateBlueprintFromContent.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionDelete.cs\" />\n-    <Compile Include=\"_Legacy\\Actions\\ActionEmptyTranscan.cs\" />","path":"src/Umbraco.Web/Umbraco.Web.csproj","position":21,"original_position":21,"commit_id":"372f77fde5a16641960fa92b9c9637e9a53b3199","original_commit_id":"372f77fde5a16641960fa92b9c9637e9a53b3199","user":{"login":"warrenbuckley","id":1389894,"node_id":"MDQ6VXNlcjEzODk4OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1389894?v=4","gravatar_id":"","url":"https://api.github.com/users/warrenbuckley","html_url":"https://github.com/warrenbuckley","followers_url":"https://api.github.com/users/warrenbuckley/followers","following_url":"https://api.github.com/users/warrenbuckley/following{/other_user}","gists_url":"https://api.github.com/users/warrenbuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/warrenbuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrenbuckley/subscriptions","organizations_url":"https://api.github.com/users/warrenbuckley/orgs","repos_url":"https://api.github.com/users/warrenbuckley/repos","events_url":"https://api.github.com/users/warrenbuckley/events{/privacy}","received_events_url":"https://api.github.com/users/warrenbuckley/received_events","type":"User","site_admin":false},"body":"Makes sense why they are gone from Shan's previous comments.\r\n\r\nAn Action is no longer 1:1 tied to a menu item like it has previously been in the past. An Action is used to assign permissions & or for notifications","created_at":"2018-10-31T13:33:55Z","updated_at":"2018-10-31T13:33:55Z","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/3479#discussion_r229693788","pull_request_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments/229693788"},"html":{"href":"https://github.com/umbraco/Umbraco-CMS/pull/3479#discussion_r229693788"},"pull_request":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479"}},"in_reply_to_id":229689669},"pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479","id":226540498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTQwNDk4","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/3479","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/3479.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/3479.patch","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3479","number":3479,"state":"open","locked":false,"title":"v8 IAction cleanup","user":{"login":"Shazwazza","id":1742685,"node_id":"MDQ6VXNlcjE3NDI2ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1742685?v=4","gravatar_id":"","url":"https://api.github.com/users/Shazwazza","html_url":"https://github.com/Shazwazza","followers_url":"https://api.github.com/users/Shazwazza/followers","following_url":"https://api.github.com/users/Shazwazza/following{/other_user}","gists_url":"https://api.github.com/users/Shazwazza/gists{/gist_id}","starred_url":"https://api.github.com/users/Shazwazza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shazwazza/subscriptions","organizations_url":"https://api.github.com/users/Shazwazza/orgs","repos_url":"https://api.github.com/users/Shazwazza/repos","events_url":"https://api.github.com/users/Shazwazza/events{/privacy}","received_events_url":"https://api.github.com/users/Shazwazza/received_events","type":"User","site_admin":false},"body":"Big cleanup/refactor of IAction and other old legacy bits and pieces.\r\n\r\n`IAction` should be responsible for only assigning permissions/notifications. MenuItem is how to make menu items and that has also been cleaned up and as much legacy conversion stuff has been removed that we can for now (still more to be done once we convert everything to angular). \r\n\r\nTesting:\r\n\r\n* [ ] Make sure all context menu items work as expected","created_at":"2018-10-29T12:26:16Z","updated_at":"2018-10-31T13:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b798f8dce6c98be7c9405f5d818ac7c9f62fb834","assignee":{"login":"Shazwazza","id":1742685,"node_id":"MDQ6VXNlcjE3NDI2ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1742685?v=4","gravatar_id":"","url":"https://api.github.com/users/Shazwazza","html_url":"https://github.com/Shazwazza","followers_url":"https://api.github.com/users/Shazwazza/followers","following_url":"https://api.github.com/users/Shazwazza/following{/other_user}","gists_url":"https://api.github.com/users/Shazwazza/gists{/gist_id}","starred_url":"https://api.github.com/users/Shazwazza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shazwazza/subscriptions","organizations_url":"https://api.github.com/users/Shazwazza/orgs","repos_url":"https://api.github.com/users/Shazwazza/repos","events_url":"https://api.github.com/users/Shazwazza/events{/privacy}","received_events_url":"https://api.github.com/users/Shazwazza/received_events","type":"User","site_admin":false},"assignees":[{"login":"Shazwazza","id":1742685,"node_id":"MDQ6VXNlcjE3NDI2ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1742685?v=4","gravatar_id":"","url":"https://api.github.com/users/Shazwazza","html_url":"https://github.com/Shazwazza","followers_url":"https://api.github.com/users/Shazwazza/followers","following_url":"https://api.github.com/users/Shazwazza/following{/other_user}","gists_url":"https://api.github.com/users/Shazwazza/gists{/gist_id}","starred_url":"https://api.github.com/users/Shazwazza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shazwazza/subscriptions","organizations_url":"https://api.github.com/users/Shazwazza/orgs","repos_url":"https://api.github.com/users/Shazwazza/repos","events_url":"https://api.github.com/users/Shazwazza/events{/privacy}","received_events_url":"https://api.github.com/users/Shazwazza/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479/commits","review_comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479/comments","review_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3479/comments","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/372f77fde5a16641960fa92b9c9637e9a53b3199","head":{"label":"umbraco:temp8-IAction-cleanup","ref":"temp8-IAction-cleanup","sha":"372f77fde5a16641960fa92b9c9637e9a53b3199","user":{"login":"umbraco","id":1419552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1419552?v=4","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"repo":{"id":10601208,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwMTIwOA==","name":"Umbraco-CMS","full_name":"umbraco/Umbraco-CMS","private":false,"owner":{"login":"umbraco","id":1419552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1419552?v=4","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/umbraco/Umbraco-CMS","description":"The simple, flexible and friendly ASP.NET CMS used by more than 400.000 websites","fork":false,"url":"https://api.github.com/repos/umbraco/Umbraco-CMS","forks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/forks","keys_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/teams","hooks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/hooks","issue_events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/events","assignees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/tags","blobs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/languages","stargazers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/stargazers","contributors_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contributors","subscribers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscribers","subscription_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscription","commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/merges","archive_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/downloads","issues_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/labels{/name}","releases_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/releases{/id}","deployments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/deployments","created_at":"2013-06-10T13:50:46Z","updated_at":"2018-10-31T11:44:31Z","pushed_at":"2018-10-31T13:33:37Z","git_url":"git://github.com/umbraco/Umbraco-CMS.git","ssh_url":"git@github.com:umbraco/Umbraco-CMS.git","clone_url":"https://github.com/umbraco/Umbraco-CMS.git","svn_url":"https://github.com/umbraco/Umbraco-CMS","homepage":"https://umbraco.com","size":167072,"stargazers_count":2190,"watchers_count":2190,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1666,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1666,"open_issues":249,"watchers":2190,"default_branch":"dev-v7"}},"base":{"label":"umbraco:temp8","ref":"temp8","sha":"bc20db5a4649baba273f0afc43be6450374afac3","user":{"login":"umbraco","id":1419552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1419552?v=4","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"repo":{"id":10601208,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwMTIwOA==","name":"Umbraco-CMS","full_name":"umbraco/Umbraco-CMS","private":false,"owner":{"login":"umbraco","id":1419552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTk1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1419552?v=4","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/umbraco/Umbraco-CMS","description":"The simple, flexible and friendly ASP.NET CMS used by more than 400.000 websites","fork":false,"url":"https://api.github.com/repos/umbraco/Umbraco-CMS","forks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/forks","keys_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/teams","hooks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/hooks","issue_events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/events","assignees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/tags","blobs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/languages","stargazers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/stargazers","contributors_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contributors","subscribers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscribers","subscription_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscription","commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/merges","archive_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/downloads","issues_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/labels{/name}","releases_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/releases{/id}","deployments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/deployments","created_at":"2013-06-10T13:50:46Z","updated_at":"2018-10-31T11:44:31Z","pushed_at":"2018-10-31T13:33:37Z","git_url":"git://github.com/umbraco/Umbraco-CMS.git","ssh_url":"git@github.com:umbraco/Umbraco-CMS.git","clone_url":"https://github.com/umbraco/Umbraco-CMS.git","svn_url":"https://github.com/umbraco/Umbraco-CMS","homepage":"https://umbraco.com","size":167072,"stargazers_count":2190,"watchers_count":2190,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1666,"mirror_url":null,"archived":false,"open_issues_count":249,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1666,"open_issues":249,"watchers":2190,"default_branch":"dev-v7"}},"_links":{"self":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479"},"html":{"href":"https://github.com/umbraco/Umbraco-CMS/pull/3479"},"issue":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3479"},"comments":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3479/comments"},"review_comments":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479/comments"},"review_comment":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3479/commits"},"statuses":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/372f77fde5a16641960fa92b9c9637e9a53b3199"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"warrenbuckley"}}