{"action":"closed","number":493,"pull_request":{"url":"https://api.github.com/repos/sbt/zinc/pulls/493","id":170346544,"html_url":"https://github.com/sbt/zinc/pull/493","diff_url":"https://github.com/sbt/zinc/pull/493.diff","patch_url":"https://github.com/sbt/zinc/pull/493.patch","issue_url":"https://api.github.com/repos/sbt/zinc/issues/493","number":493,"state":"closed","locked":false,"title":"Address #349: Partially resolve deprecated warnings","user":{"login":"exoego","id":127635,"avatar_url":"https://avatars2.githubusercontent.com/u/127635?v=4","gravatar_id":"","url":"https://api.github.com/users/exoego","html_url":"https://github.com/exoego","followers_url":"https://api.github.com/users/exoego/followers","following_url":"https://api.github.com/users/exoego/following{/other_user}","gists_url":"https://api.github.com/users/exoego/gists{/gist_id}","starred_url":"https://api.github.com/users/exoego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exoego/subscriptions","organizations_url":"https://api.github.com/users/exoego/orgs","repos_url":"https://api.github.com/users/exoego/repos","events_url":"https://api.github.com/users/exoego/events{/privacy}","received_events_url":"https://api.github.com/users/exoego/received_events","type":"User","site_admin":false},"body":"This PR address https://github.com/sbt/zinc/issues/349 by partially resolving `deprecated` warnings.\r\n\r\nThe deprecated codes are simply removed or rewriten, in accordance with the instruction in deprecation warning.\r\n\r\n\r\n\r\n# Before (3c12aba4193b28fd16767c28a1cf8a1c3bbf91b8)\r\n\r\n## Total\r\n\r\n```sh\r\n$ sbt -warn \";clean;compile\" | grep \"deprecated\" | wc -l\r\n15\r\n```\r\n\r\n```sh\r\n$ sbt -warn \";clean;compile\" | grep \"deprecated\"        \r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-classpath/src/main/scala/sbt/internal/inc/classpath/ClassLoaders.scala:98:21: object WrapAsJava in package convert is deprecated (since 2.12.0): use JavaConverters or consider ImplicitConversionsToJava\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-classpath/src/main/scala/sbt/internal/inc/classpath/ClassLoaders.scala:98:26: object WrapAsScala in package convert is deprecated (since 2.12.0): use JavaConverters or consider ImplicitConversionsToScala\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-classpath/src/main/scala/sbt/internal/inc/classpath/ClasspathUtilities.scala:116:24: object JavaConversions in package collection is deprecated (since 2.12.0): use JavaConverters\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/API.scala:82:12: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/Analyzer.scala:51:41: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/CallbackGlobal.scala:169:10: trait RangePositions in package interactive is deprecated (since 2.11.0): Use scala.reflect.internal.Positions\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ClassName.scala:94:33: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala_2.11-12/xsbt/ConsoleInterface.scala:52:16: method setContextClassLoader in class IMain is deprecated (since 2.12.0): The thread context classloader is now set and restored around execution of REPL line, this method is now a no-op.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/AnalyzingCompiler.scala:347:56: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:72:67: method compilerJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:73:65: method otherJars in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:98:37: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:141:27: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/javac/JavaCompiler.scala:105:43: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/zinc-compile/src/main/scala/sbt/inc/Doc.scala:37:19: type :*: in object LList is deprecated (since 0.8.0): Switch to the type alias in the sjsonnew root package\r\n```\r\n\r\n# This PR\r\n```bash\r\n$ sbt -warn \";clean;compile\" | grep \"deprecated\" | wc -l\r\n9\r\n```\r\n\r\n```bash\r\n$ sbt -warn \";clean;compile\" | grep \"deprecated\"\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/API.scala:82:12: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/Analyzer.scala:51:41: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ClassName.scala:94:33: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/AnalyzingCompiler.scala:347:56: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:72:67: method compilerJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:73:65: method otherJars in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:98:37: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:141:27: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/javac/JavaCompiler.scala:105:43: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.\r\n```\r\n\r\nThe above 9 `deprecated` warnings are kept.\r\n\r\n* `Symbol.isImplClass` is needed for Scala 2.11.\r\n* How to migrate some members of `ScalaInstance` is not clear for me.\r\n\r\nMaybe those should be addressed as a legit issue?","created_at":"2018-02-21T00:23:40Z","updated_at":"2018-02-21T18:38:55Z","closed_at":"2018-02-21T18:38:54Z","merged_at":"2018-02-21T18:38:54Z","merge_commit_sha":"ad46221ca148629df111dbc1561ac348d2b15c9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":543119240,"url":"https://api.github.com/repos/sbt/zinc/labels/community","name":"community","color":"1d76db","default":false},{"id":405257274,"url":"https://api.github.com/repos/sbt/zinc/labels/in%20progress","name":"in progress","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sbt/zinc/pulls/493/commits","review_comments_url":"https://api.github.com/repos/sbt/zinc/pulls/493/comments","review_comment_url":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/zinc/issues/493/comments","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/fef48dd51b7fed25327c0a1765df567da77d50e9","head":{"label":"exoego:1.x-replace-deprecations","ref":"1.x-replace-deprecations","sha":"fef48dd51b7fed25327c0a1765df567da77d50e9","user":{"login":"exoego","id":127635,"avatar_url":"https://avatars2.githubusercontent.com/u/127635?v=4","gravatar_id":"","url":"https://api.github.com/users/exoego","html_url":"https://github.com/exoego","followers_url":"https://api.github.com/users/exoego/followers","following_url":"https://api.github.com/users/exoego/following{/other_user}","gists_url":"https://api.github.com/users/exoego/gists{/gist_id}","starred_url":"https://api.github.com/users/exoego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exoego/subscriptions","organizations_url":"https://api.github.com/users/exoego/orgs","repos_url":"https://api.github.com/users/exoego/repos","events_url":"https://api.github.com/users/exoego/events{/privacy}","received_events_url":"https://api.github.com/users/exoego/received_events","type":"User","site_admin":false},"repo":{"id":121069547,"name":"zinc","full_name":"exoego/zinc","owner":{"login":"exoego","id":127635,"avatar_url":"https://avatars2.githubusercontent.com/u/127635?v=4","gravatar_id":"","url":"https://api.github.com/users/exoego","html_url":"https://github.com/exoego","followers_url":"https://api.github.com/users/exoego/followers","following_url":"https://api.github.com/users/exoego/following{/other_user}","gists_url":"https://api.github.com/users/exoego/gists{/gist_id}","starred_url":"https://api.github.com/users/exoego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exoego/subscriptions","organizations_url":"https://api.github.com/users/exoego/orgs","repos_url":"https://api.github.com/users/exoego/repos","events_url":"https://api.github.com/users/exoego/events{/privacy}","received_events_url":"https://api.github.com/users/exoego/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/exoego/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":true,"url":"https://api.github.com/repos/exoego/zinc","forks_url":"https://api.github.com/repos/exoego/zinc/forks","keys_url":"https://api.github.com/repos/exoego/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exoego/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exoego/zinc/teams","hooks_url":"https://api.github.com/repos/exoego/zinc/hooks","issue_events_url":"https://api.github.com/repos/exoego/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/exoego/zinc/events","assignees_url":"https://api.github.com/repos/exoego/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/exoego/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/exoego/zinc/tags","blobs_url":"https://api.github.com/repos/exoego/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exoego/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exoego/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/exoego/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exoego/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/exoego/zinc/languages","stargazers_url":"https://api.github.com/repos/exoego/zinc/stargazers","contributors_url":"https://api.github.com/repos/exoego/zinc/contributors","subscribers_url":"https://api.github.com/repos/exoego/zinc/subscribers","subscription_url":"https://api.github.com/repos/exoego/zinc/subscription","commits_url":"https://api.github.com/repos/exoego/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/exoego/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/exoego/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/exoego/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/exoego/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/exoego/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exoego/zinc/merges","archive_url":"https://api.github.com/repos/exoego/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exoego/zinc/downloads","issues_url":"https://api.github.com/repos/exoego/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/exoego/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/exoego/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/exoego/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exoego/zinc/labels{/name}","releases_url":"https://api.github.com/repos/exoego/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/exoego/zinc/deployments","created_at":"2018-02-11T01:06:55Z","updated_at":"2018-02-11T01:06:58Z","pushed_at":"2018-02-21T18:25:07Z","git_url":"git://github.com/exoego/zinc.git","ssh_url":"git@github.com:exoego/zinc.git","clone_url":"https://github.com/exoego/zinc.git","svn_url":"https://github.com/exoego/zinc","homepage":"","size":11078,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"sbt:1.x","ref":"1.x","sha":"342a122cb08788fafbb0d7653cc9975a0cc3317c","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":40210247,"name":"zinc","full_name":"sbt/zinc","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":false,"url":"https://api.github.com/repos/sbt/zinc","forks_url":"https://api.github.com/repos/sbt/zinc/forks","keys_url":"https://api.github.com/repos/sbt/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/zinc/teams","hooks_url":"https://api.github.com/repos/sbt/zinc/hooks","issue_events_url":"https://api.github.com/repos/sbt/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/zinc/events","assignees_url":"https://api.github.com/repos/sbt/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/zinc/tags","blobs_url":"https://api.github.com/repos/sbt/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/zinc/languages","stargazers_url":"https://api.github.com/repos/sbt/zinc/stargazers","contributors_url":"https://api.github.com/repos/sbt/zinc/contributors","subscribers_url":"https://api.github.com/repos/sbt/zinc/subscribers","subscription_url":"https://api.github.com/repos/sbt/zinc/subscription","commits_url":"https://api.github.com/repos/sbt/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/zinc/merges","archive_url":"https://api.github.com/repos/sbt/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/zinc/downloads","issues_url":"https://api.github.com/repos/sbt/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/zinc/labels{/name}","releases_url":"https://api.github.com/repos/sbt/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/sbt/zinc/deployments","created_at":"2015-08-04T21:32:58Z","updated_at":"2018-02-21T11:08:48Z","pushed_at":"2018-02-21T18:38:54Z","git_url":"git://github.com/sbt/zinc.git","ssh_url":"git@github.com:sbt/zinc.git","clone_url":"https://github.com/sbt/zinc.git","svn_url":"https://github.com/sbt/zinc","homepage":"","size":11093,"stargazers_count":134,"watchers_count":134,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":58,"open_issues":70,"watchers":134,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/zinc/pulls/493"},"html":{"href":"https://github.com/sbt/zinc/pull/493"},"issue":{"href":"https://api.github.com/repos/sbt/zinc/issues/493"},"comments":{"href":"https://api.github.com/repos/sbt/zinc/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/zinc/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/zinc/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/zinc/statuses/fef48dd51b7fed25327c0a1765df567da77d50e9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jvican","id":2462974,"avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":5,"additions":6,"deletions":9,"changed_files":5}}
{"actor":{"display_login":"jvican"}}