{"action":"opened","issue":{"url":"https://api.github.com/repos/random-forests/tutorials/issues/10","repository_url":"https://api.github.com/repos/random-forests/tutorials","labels_url":"https://api.github.com/repos/random-forests/tutorials/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/random-forests/tutorials/issues/10/comments","events_url":"https://api.github.com/repos/random-forests/tutorials/issues/10/events","html_url":"https://github.com/random-forests/tutorials/issues/10","id":320561185,"number":10,"title":"A suggestion on is_numeric function ","user":{"login":"riversxiao","id":11560699,"avatar_url":"https://avatars2.githubusercontent.com/u/11560699?v=4","gravatar_id":"","url":"https://api.github.com/users/riversxiao","html_url":"https://github.com/riversxiao","followers_url":"https://api.github.com/users/riversxiao/followers","following_url":"https://api.github.com/users/riversxiao/following{/other_user}","gists_url":"https://api.github.com/users/riversxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/riversxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversxiao/subscriptions","organizations_url":"https://api.github.com/users/riversxiao/orgs","repos_url":"https://api.github.com/users/riversxiao/repos","events_url":"https://api.github.com/users/riversxiao/events{/privacy}","received_events_url":"https://api.github.com/users/riversxiao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-06T04:13:25Z","updated_at":"2018-05-06T04:13:25Z","closed_at":null,"author_association":"NONE","body":"Hi, Josh Gordon\r\nThanks for your great sharing, it helped me get a much better understanding of  decision tree.\r\nI have a suggestion on the function ''is_numeric''\r\n In your example, there is no bool column in the training data, so 'is_numeric' function works fine, yet if i add a bool column in the dataset, is_numeric(True) will be true\r\nso i suggest change the \r\nfunction into the following to take bool value into account \r\n`\r\ndef is_numeric(value):\r\n    return type(value) in (float,int)\r\n `\r\nthanks~"}}
{"actor":{"display_login":"riversxiao"}}