{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/182956717","pull_request_review_id":113862018,"id":182956717,"diff_hunk":"@@ -73,18 +74,9 @@ case class PreAggregateTableHelper(\n       Seq()\n     }\n     // Generate child table partition columns in the same order as the parent table.\n-    val partitionerFields = fieldRelationMap.collect {\n-      case (field, dataMapField) if parentPartitionColumns\n-        .exists(parentCol =>\n-          /* For count(*) while Pre-Aggregate table creation,columnTableRelationList was null */\n-          dataMapField.columnTableRelationList.getOrElse(Seq()).nonEmpty &&\n-            parentCol.equals(dataMapField.columnTableRelationList.get.head.parentColumnName) &&\n-          dataMapField.aggregateFunction.isEmpty) =>\n-        (PartitionerField(field.name.get,\n-          field.dataType,\n-          field.columnComment), parentPartitionColumns\n-          .indexOf(dataMapField.columnTableRelationList.get.head.parentColumnName))\n-    }.toSeq.sortBy(_._2).map(_._1)\n+    val partitionerFields =\n+      PartitionUtils.getPartitionerFields(parentPartitionColumns, fieldRelationMap)","path":"integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala","position":25,"original_position":25,"commit_id":"9685aed1a85d00455b7043e130374142d9d4c417","original_commit_id":"fea8e5f60624334d1bbd482779dd0015ebba06b4","user":{"login":"KanakaKumar","id":30794714,"avatar_url":"https://avatars3.githubusercontent.com/u/30794714?v=4","gravatar_id":"","url":"https://api.github.com/users/KanakaKumar","html_url":"https://github.com/KanakaKumar","followers_url":"https://api.github.com/users/KanakaKumar/followers","following_url":"https://api.github.com/users/KanakaKumar/following{/other_user}","gists_url":"https://api.github.com/users/KanakaKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/KanakaKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanakaKumar/subscriptions","organizations_url":"https://api.github.com/users/KanakaKumar/orgs","repos_url":"https://api.github.com/users/KanakaKumar/repos","events_url":"https://api.github.com/users/KanakaKumar/events{/privacy}","received_events_url":"https://api.github.com/users/KanakaKumar/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-04-20T06:35:32Z","updated_at":"2018-04-20T06:35:32Z","html_url":"https://github.com/apache/carbondata/pull/2172#discussion_r182956717","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/182956717"},"html":{"href":"https://github.com/apache/carbondata/pull/2172#discussion_r182956717"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2172"}},"in_reply_to_id":182136155},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2172","id":181464925,"html_url":"https://github.com/apache/carbondata/pull/2172","diff_url":"https://github.com/apache/carbondata/pull/2172.diff","patch_url":"https://github.com/apache/carbondata/pull/2172.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2172","number":2172,"state":"open","locked":false,"title":"[CARBONDATA-2333] Block insert overwrite if all partition columns are not present in an…","user":{"login":"kunal642","id":11694130,"avatar_url":"https://avatars3.githubusercontent.com/u/11694130?v=4","gravatar_id":"","url":"https://api.github.com/users/kunal642","html_url":"https://github.com/kunal642","followers_url":"https://api.github.com/users/kunal642/followers","following_url":"https://api.github.com/users/kunal642/following{/other_user}","gists_url":"https://api.github.com/users/kunal642/gists{/gist_id}","starred_url":"https://api.github.com/users/kunal642/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunal642/subscriptions","organizations_url":"https://api.github.com/users/kunal642/orgs","repos_url":"https://api.github.com/users/kunal642/repos","events_url":"https://api.github.com/users/kunal642/events{/privacy}","received_events_url":"https://api.github.com/users/kunal642/received_events","type":"User","site_admin":false},"body":"…y one of the datamaps\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed?\r\n \r\n - [ ] Any backward compatibility impacted?\r\n \r\n - [ ] Document update required?\r\n\r\n - [ ] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n       \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n\r\n","created_at":"2018-04-13T11:48:52Z","updated_at":"2018-04-20T06:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4173b059d7e98cd589d118aad960f6680b58e09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2172/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2172/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2172/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/9685aed1a85d00455b7043e130374142d9d4c417","head":{"label":"kunal642:preagg_partition_fix","ref":"preagg_partition_fix","sha":"9685aed1a85d00455b7043e130374142d9d4c417","user":{"login":"kunal642","id":11694130,"avatar_url":"https://avatars3.githubusercontent.com/u/11694130?v=4","gravatar_id":"","url":"https://api.github.com/users/kunal642","html_url":"https://github.com/kunal642","followers_url":"https://api.github.com/users/kunal642/followers","following_url":"https://api.github.com/users/kunal642/following{/other_user}","gists_url":"https://api.github.com/users/kunal642/gists{/gist_id}","starred_url":"https://api.github.com/users/kunal642/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunal642/subscriptions","organizations_url":"https://api.github.com/users/kunal642/orgs","repos_url":"https://api.github.com/users/kunal642/repos","events_url":"https://api.github.com/users/kunal642/events{/privacy}","received_events_url":"https://api.github.com/users/kunal642/received_events","type":"User","site_admin":false},"repo":{"id":71335992,"name":"carbondata","full_name":"kunal642/carbondata","owner":{"login":"kunal642","id":11694130,"avatar_url":"https://avatars3.githubusercontent.com/u/11694130?v=4","gravatar_id":"","url":"https://api.github.com/users/kunal642","html_url":"https://github.com/kunal642","followers_url":"https://api.github.com/users/kunal642/followers","following_url":"https://api.github.com/users/kunal642/following{/other_user}","gists_url":"https://api.github.com/users/kunal642/gists{/gist_id}","starred_url":"https://api.github.com/users/kunal642/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunal642/subscriptions","organizations_url":"https://api.github.com/users/kunal642/orgs","repos_url":"https://api.github.com/users/kunal642/repos","events_url":"https://api.github.com/users/kunal642/events{/privacy}","received_events_url":"https://api.github.com/users/kunal642/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kunal642/carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":true,"url":"https://api.github.com/repos/kunal642/carbondata","forks_url":"https://api.github.com/repos/kunal642/carbondata/forks","keys_url":"https://api.github.com/repos/kunal642/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kunal642/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kunal642/carbondata/teams","hooks_url":"https://api.github.com/repos/kunal642/carbondata/hooks","issue_events_url":"https://api.github.com/repos/kunal642/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/kunal642/carbondata/events","assignees_url":"https://api.github.com/repos/kunal642/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/kunal642/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/kunal642/carbondata/tags","blobs_url":"https://api.github.com/repos/kunal642/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kunal642/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kunal642/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/kunal642/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kunal642/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/kunal642/carbondata/languages","stargazers_url":"https://api.github.com/repos/kunal642/carbondata/stargazers","contributors_url":"https://api.github.com/repos/kunal642/carbondata/contributors","subscribers_url":"https://api.github.com/repos/kunal642/carbondata/subscribers","subscription_url":"https://api.github.com/repos/kunal642/carbondata/subscription","commits_url":"https://api.github.com/repos/kunal642/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/kunal642/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/kunal642/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/kunal642/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/kunal642/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/kunal642/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kunal642/carbondata/merges","archive_url":"https://api.github.com/repos/kunal642/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kunal642/carbondata/downloads","issues_url":"https://api.github.com/repos/kunal642/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/kunal642/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/kunal642/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/kunal642/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kunal642/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/kunal642/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/kunal642/carbondata/deployments","created_at":"2016-10-19T08:34:07Z","updated_at":"2017-06-08T08:47:55Z","pushed_at":"2018-04-20T06:34:55Z","git_url":"git://github.com/kunal642/carbondata.git","ssh_url":"git@github.com:kunal642/carbondata.git","clone_url":"https://github.com/kunal642/carbondata.git","svn_url":"https://github.com/kunal642/carbondata","homepage":null,"size":55978,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8999a8affc0966e293a1f6cb3e4dfcf34c207e0e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-04-19T16:26:39Z","pushed_at":"2018-04-20T06:34:56Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":56679,"stargazers_count":644,"watchers_count":644,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":405,"open_issues":105,"watchers":644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2172"},"html":{"href":"https://github.com/apache/carbondata/pull/2172"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2172"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2172/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2172/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2172/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/9685aed1a85d00455b7043e130374142d9d4c417"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KanakaKumar"}}