{"action":"created","comment":{"url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/comments/211596625","pull_request_review_id":148044801,"id":211596625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU5NjYyNQ==","diff_hunk":"@@ -306,6 +315,15 @@ class LArMCParticleHelper\n      *  @return The hits that are found in both hitListA and hitListB\n      */\n     static pandora::CaloHitList GetSharedHits(const pandora::CaloHitList &hitListA, const pandora::CaloHitList &hitListB);\n+\n+    /**\n+     *  @brief  Get the MCParticle weight map for a set of CaloHits","path":"larpandoracontent/LArHelpers/LArMCParticleHelper.h","position":22,"original_position":22,"commit_id":"b43b801054f01a654a8ef6ed0ad8a656c8b251e5","original_commit_id":"b43b801054f01a654a8ef6ed0ad8a656c8b251e5","user":{"login":"PandoraPFA","id":13437413,"node_id":"MDQ6VXNlcjEzNDM3NDEz","avatar_url":"https://avatars2.githubusercontent.com/u/13437413?v=4","gravatar_id":"","url":"https://api.github.com/users/PandoraPFA","html_url":"https://github.com/PandoraPFA","followers_url":"https://api.github.com/users/PandoraPFA/followers","following_url":"https://api.github.com/users/PandoraPFA/following{/other_user}","gists_url":"https://api.github.com/users/PandoraPFA/gists{/gist_id}","starred_url":"https://api.github.com/users/PandoraPFA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandoraPFA/subscriptions","organizations_url":"https://api.github.com/users/PandoraPFA/orgs","repos_url":"https://api.github.com/users/PandoraPFA/repos","events_url":"https://api.github.com/users/PandoraPFA/events{/privacy}","received_events_url":"https://api.github.com/users/PandoraPFA/received_events","type":"User","site_admin":false},"body":"set vs. list?","created_at":"2018-08-21T13:05:08Z","updated_at":"2018-08-21T13:05:36Z","html_url":"https://github.com/PandoraPFA/LArContent/pull/71#discussion_r211596625","pull_request_url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/comments/211596625"},"html":{"href":"https://github.com/PandoraPFA/LArContent/pull/71#discussion_r211596625"},"pull_request":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71","id":209234094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjM0MDk0","html_url":"https://github.com/PandoraPFA/LArContent/pull/71","diff_url":"https://github.com/PandoraPFA/LArContent/pull/71.diff","patch_url":"https://github.com/PandoraPFA/LArContent/pull/71.patch","issue_url":"https://api.github.com/repos/PandoraPFA/LArContent/issues/71","number":71,"state":"open","locked":false,"title":"Added method to get the MCParticle best matched to a PFO","user":{"login":"jackanth","id":14259600,"node_id":"MDQ6VXNlcjE0MjU5NjAw","avatar_url":"https://avatars2.githubusercontent.com/u/14259600?v=4","gravatar_id":"","url":"https://api.github.com/users/jackanth","html_url":"https://github.com/jackanth","followers_url":"https://api.github.com/users/jackanth/followers","following_url":"https://api.github.com/users/jackanth/following{/other_user}","gists_url":"https://api.github.com/users/jackanth/gists{/gist_id}","starred_url":"https://api.github.com/users/jackanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackanth/subscriptions","organizations_url":"https://api.github.com/users/jackanth/orgs","repos_url":"https://api.github.com/users/jackanth/repos","events_url":"https://api.github.com/users/jackanth/events{/privacy}","received_events_url":"https://api.github.com/users/jackanth/received_events","type":"User","site_admin":false},"body":"Unlike `LArMCParticleHelper::GetMainMCParticle`, there's no need for agreement in multiple views. Every 2D hit in each view votes with a float between 0 and 1 (from their MC particle weight map), then the MC particle with the highest weight is chosen. The method should return `nullptr` iff the MC particle weight map is empty for every considered hit.\r\n\r\nA variation on this could be weighting each hit's vote by its energy.\r\n\r\nThis is simplified from similar logic in my `LArPhysicsContent` repo.","created_at":"2018-08-17T19:12:26Z","updated_at":"2018-08-21T13:05:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2612fffdca480313701cee45d533ebcb6017d2d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71/commits","review_comments_url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71/comments","review_comment_url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PandoraPFA/LArContent/issues/71/comments","statuses_url":"https://api.github.com/repos/PandoraPFA/LArContent/statuses/b43b801054f01a654a8ef6ed0ad8a656c8b251e5","head":{"label":"jackanth:GetBestMCParticle","ref":"GetBestMCParticle","sha":"b43b801054f01a654a8ef6ed0ad8a656c8b251e5","user":{"login":"jackanth","id":14259600,"node_id":"MDQ6VXNlcjE0MjU5NjAw","avatar_url":"https://avatars2.githubusercontent.com/u/14259600?v=4","gravatar_id":"","url":"https://api.github.com/users/jackanth","html_url":"https://github.com/jackanth","followers_url":"https://api.github.com/users/jackanth/followers","following_url":"https://api.github.com/users/jackanth/following{/other_user}","gists_url":"https://api.github.com/users/jackanth/gists{/gist_id}","starred_url":"https://api.github.com/users/jackanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackanth/subscriptions","organizations_url":"https://api.github.com/users/jackanth/orgs","repos_url":"https://api.github.com/users/jackanth/repos","events_url":"https://api.github.com/users/jackanth/events{/privacy}","received_events_url":"https://api.github.com/users/jackanth/received_events","type":"User","site_admin":false},"repo":{"id":118002445,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMDI0NDU=","name":"LArContent","full_name":"jackanth/LArContent","owner":{"login":"jackanth","id":14259600,"node_id":"MDQ6VXNlcjE0MjU5NjAw","avatar_url":"https://avatars2.githubusercontent.com/u/14259600?v=4","gravatar_id":"","url":"https://api.github.com/users/jackanth","html_url":"https://github.com/jackanth","followers_url":"https://api.github.com/users/jackanth/followers","following_url":"https://api.github.com/users/jackanth/following{/other_user}","gists_url":"https://api.github.com/users/jackanth/gists{/gist_id}","starred_url":"https://api.github.com/users/jackanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackanth/subscriptions","organizations_url":"https://api.github.com/users/jackanth/orgs","repos_url":"https://api.github.com/users/jackanth/repos","events_url":"https://api.github.com/users/jackanth/events{/privacy}","received_events_url":"https://api.github.com/users/jackanth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackanth/LArContent","description":"Algorithms and tools for LAr TPC event reconstruction","fork":true,"url":"https://api.github.com/repos/jackanth/LArContent","forks_url":"https://api.github.com/repos/jackanth/LArContent/forks","keys_url":"https://api.github.com/repos/jackanth/LArContent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackanth/LArContent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackanth/LArContent/teams","hooks_url":"https://api.github.com/repos/jackanth/LArContent/hooks","issue_events_url":"https://api.github.com/repos/jackanth/LArContent/issues/events{/number}","events_url":"https://api.github.com/repos/jackanth/LArContent/events","assignees_url":"https://api.github.com/repos/jackanth/LArContent/assignees{/user}","branches_url":"https://api.github.com/repos/jackanth/LArContent/branches{/branch}","tags_url":"https://api.github.com/repos/jackanth/LArContent/tags","blobs_url":"https://api.github.com/repos/jackanth/LArContent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackanth/LArContent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackanth/LArContent/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackanth/LArContent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackanth/LArContent/statuses/{sha}","languages_url":"https://api.github.com/repos/jackanth/LArContent/languages","stargazers_url":"https://api.github.com/repos/jackanth/LArContent/stargazers","contributors_url":"https://api.github.com/repos/jackanth/LArContent/contributors","subscribers_url":"https://api.github.com/repos/jackanth/LArContent/subscribers","subscription_url":"https://api.github.com/repos/jackanth/LArContent/subscription","commits_url":"https://api.github.com/repos/jackanth/LArContent/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackanth/LArContent/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackanth/LArContent/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackanth/LArContent/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackanth/LArContent/contents/{+path}","compare_url":"https://api.github.com/repos/jackanth/LArContent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackanth/LArContent/merges","archive_url":"https://api.github.com/repos/jackanth/LArContent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackanth/LArContent/downloads","issues_url":"https://api.github.com/repos/jackanth/LArContent/issues{/number}","pulls_url":"https://api.github.com/repos/jackanth/LArContent/pulls{/number}","milestones_url":"https://api.github.com/repos/jackanth/LArContent/milestones{/number}","notifications_url":"https://api.github.com/repos/jackanth/LArContent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackanth/LArContent/labels{/name}","releases_url":"https://api.github.com/repos/jackanth/LArContent/releases{/id}","deployments_url":"https://api.github.com/repos/jackanth/LArContent/deployments","created_at":"2018-01-18T15:41:17Z","updated_at":"2018-01-18T15:41:20Z","pushed_at":"2018-08-17T19:05:38Z","git_url":"git://github.com/jackanth/LArContent.git","ssh_url":"git@github.com:jackanth/LArContent.git","clone_url":"https://github.com/jackanth/LArContent.git","svn_url":"https://github.com/jackanth/LArContent","homepage":"","size":24016,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PandoraPFA:master","ref":"master","sha":"b099203fcd39a7ea8e7188fc881162c6720e058b","user":{"login":"PandoraPFA","id":13437413,"node_id":"MDQ6VXNlcjEzNDM3NDEz","avatar_url":"https://avatars2.githubusercontent.com/u/13437413?v=4","gravatar_id":"","url":"https://api.github.com/users/PandoraPFA","html_url":"https://github.com/PandoraPFA","followers_url":"https://api.github.com/users/PandoraPFA/followers","following_url":"https://api.github.com/users/PandoraPFA/following{/other_user}","gists_url":"https://api.github.com/users/PandoraPFA/gists{/gist_id}","starred_url":"https://api.github.com/users/PandoraPFA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandoraPFA/subscriptions","organizations_url":"https://api.github.com/users/PandoraPFA/orgs","repos_url":"https://api.github.com/users/PandoraPFA/repos","events_url":"https://api.github.com/users/PandoraPFA/events{/privacy}","received_events_url":"https://api.github.com/users/PandoraPFA/received_events","type":"User","site_admin":false},"repo":{"id":43431205,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQzMTIwNQ==","name":"LArContent","full_name":"PandoraPFA/LArContent","owner":{"login":"PandoraPFA","id":13437413,"node_id":"MDQ6VXNlcjEzNDM3NDEz","avatar_url":"https://avatars2.githubusercontent.com/u/13437413?v=4","gravatar_id":"","url":"https://api.github.com/users/PandoraPFA","html_url":"https://github.com/PandoraPFA","followers_url":"https://api.github.com/users/PandoraPFA/followers","following_url":"https://api.github.com/users/PandoraPFA/following{/other_user}","gists_url":"https://api.github.com/users/PandoraPFA/gists{/gist_id}","starred_url":"https://api.github.com/users/PandoraPFA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandoraPFA/subscriptions","organizations_url":"https://api.github.com/users/PandoraPFA/orgs","repos_url":"https://api.github.com/users/PandoraPFA/repos","events_url":"https://api.github.com/users/PandoraPFA/events{/privacy}","received_events_url":"https://api.github.com/users/PandoraPFA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PandoraPFA/LArContent","description":"Algorithms and tools for LAr TPC event reconstruction","fork":false,"url":"https://api.github.com/repos/PandoraPFA/LArContent","forks_url":"https://api.github.com/repos/PandoraPFA/LArContent/forks","keys_url":"https://api.github.com/repos/PandoraPFA/LArContent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PandoraPFA/LArContent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PandoraPFA/LArContent/teams","hooks_url":"https://api.github.com/repos/PandoraPFA/LArContent/hooks","issue_events_url":"https://api.github.com/repos/PandoraPFA/LArContent/issues/events{/number}","events_url":"https://api.github.com/repos/PandoraPFA/LArContent/events","assignees_url":"https://api.github.com/repos/PandoraPFA/LArContent/assignees{/user}","branches_url":"https://api.github.com/repos/PandoraPFA/LArContent/branches{/branch}","tags_url":"https://api.github.com/repos/PandoraPFA/LArContent/tags","blobs_url":"https://api.github.com/repos/PandoraPFA/LArContent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PandoraPFA/LArContent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PandoraPFA/LArContent/git/refs{/sha}","trees_url":"https://api.github.com/repos/PandoraPFA/LArContent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PandoraPFA/LArContent/statuses/{sha}","languages_url":"https://api.github.com/repos/PandoraPFA/LArContent/languages","stargazers_url":"https://api.github.com/repos/PandoraPFA/LArContent/stargazers","contributors_url":"https://api.github.com/repos/PandoraPFA/LArContent/contributors","subscribers_url":"https://api.github.com/repos/PandoraPFA/LArContent/subscribers","subscription_url":"https://api.github.com/repos/PandoraPFA/LArContent/subscription","commits_url":"https://api.github.com/repos/PandoraPFA/LArContent/commits{/sha}","git_commits_url":"https://api.github.com/repos/PandoraPFA/LArContent/git/commits{/sha}","comments_url":"https://api.github.com/repos/PandoraPFA/LArContent/comments{/number}","issue_comment_url":"https://api.github.com/repos/PandoraPFA/LArContent/issues/comments{/number}","contents_url":"https://api.github.com/repos/PandoraPFA/LArContent/contents/{+path}","compare_url":"https://api.github.com/repos/PandoraPFA/LArContent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PandoraPFA/LArContent/merges","archive_url":"https://api.github.com/repos/PandoraPFA/LArContent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PandoraPFA/LArContent/downloads","issues_url":"https://api.github.com/repos/PandoraPFA/LArContent/issues{/number}","pulls_url":"https://api.github.com/repos/PandoraPFA/LArContent/pulls{/number}","milestones_url":"https://api.github.com/repos/PandoraPFA/LArContent/milestones{/number}","notifications_url":"https://api.github.com/repos/PandoraPFA/LArContent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PandoraPFA/LArContent/labels{/name}","releases_url":"https://api.github.com/repos/PandoraPFA/LArContent/releases{/id}","deployments_url":"https://api.github.com/repos/PandoraPFA/LArContent/deployments","created_at":"2015-09-30T12:19:46Z","updated_at":"2018-08-02T11:17:39Z","pushed_at":"2018-08-17T19:12:27Z","git_url":"git://github.com/PandoraPFA/LArContent.git","ssh_url":"git@github.com:PandoraPFA/LArContent.git","clone_url":"https://github.com/PandoraPFA/LArContent.git","svn_url":"https://github.com/PandoraPFA/LArContent","homepage":"","size":23972,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":9,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71"},"html":{"href":"https://github.com/PandoraPFA/LArContent/pull/71"},"issue":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/issues/71"},"comments":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/PandoraPFA/LArContent/statuses/b43b801054f01a654a8ef6ed0ad8a656c8b251e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PandoraPFA"}}