{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/180776873","pull_request_review_id":111257569,"id":180776873,"diff_hunk":"@@ -294,7 +294,12 @@ def change_devel_request_dialog\n   end\n \n   def change_devel_request\n-    required_parameters :devel_project, :package, :project\n+    unless params[:devel_project]","path":"src/api/app/controllers/webui/request_controller.rb","position":64,"original_position":5,"commit_id":"72b8dd3355bb47a587b8caff59006fc32048a316","original_commit_id":"ddce96e798768ee21f913aeb30f60b91cfb926ab","user":{"login":"eduardoj","id":24919,"avatar_url":"https://avatars1.githubusercontent.com/u/24919?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardoj","html_url":"https://github.com/eduardoj","followers_url":"https://api.github.com/users/eduardoj/followers","following_url":"https://api.github.com/users/eduardoj/following{/other_user}","gists_url":"https://api.github.com/users/eduardoj/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoj/subscriptions","organizations_url":"https://api.github.com/users/eduardoj/orgs","repos_url":"https://api.github.com/users/eduardoj/repos","events_url":"https://api.github.com/users/eduardoj/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoj/received_events","type":"User","site_admin":false},"body":"Added a `required` attribute to  `devel_project` input. Also checked that without value an exception is thrown.","created_at":"2018-04-11T14:35:24Z","updated_at":"2018-04-11T14:35:25Z","html_url":"https://github.com/openSUSE/open-build-service/pull/4668#discussion_r180776873","pull_request_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/180776873"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/4668#discussion_r180776873"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668"}},"in_reply_to_id":177564738},"pull_request":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668","id":175334390,"html_url":"https://github.com/openSUSE/open-build-service/pull/4668","diff_url":"https://github.com/openSUSE/open-build-service/pull/4668.diff","patch_url":"https://github.com/openSUSE/open-build-service/pull/4668.patch","issue_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/4668","number":4668,"state":"open","locked":false,"title":"Refactor Webui controller, part 5","user":{"login":"eduardoj","id":24919,"avatar_url":"https://avatars1.githubusercontent.com/u/24919?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardoj","html_url":"https://github.com/eduardoj","followers_url":"https://api.github.com/users/eduardoj/followers","following_url":"https://api.github.com/users/eduardoj/following{/other_user}","gists_url":"https://api.github.com/users/eduardoj/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoj/subscriptions","organizations_url":"https://api.github.com/users/eduardoj/orgs","repos_url":"https://api.github.com/users/eduardoj/repos","events_url":"https://api.github.com/users/eduardoj/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoj/received_events","type":"User","site_admin":false},"body":"Remove  `required_parameters` callbacks from the following controllers: `Webui::RequestController`, `Webui::UserController`.\r\n\r\nThis will allow us to remove the following class in the future:\r\n``class MissingParameterError < RuntimeError; end``.","created_at":"2018-03-15T18:04:18Z","updated_at":"2018-04-11T14:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fae37ff7cf483792ac4adb8e35bea33bcd67c229","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":21922370,"url":"https://api.github.com/repos/openSUSE/open-build-service/labels/Frontend%20%F0%9F%91%BB","name":"Frontend 👻","color":"c7def8","default":false},{"id":433543039,"url":"https://api.github.com/repos/openSUSE/open-build-service/labels/Refactoring%20:factory:","name":"Refactoring :factory:","color":"CAFF70","default":false},{"id":895764128,"url":"https://api.github.com/repos/openSUSE/open-build-service/labels/review-app","name":"review-app","color":"93f486","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668/commits","review_comments_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668/comments","review_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/4668/comments","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/72b8dd3355bb47a587b8caff59006fc32048a316","head":{"label":"eduardoj:refactor-webui-controller-part5","ref":"refactor-webui-controller-part5","sha":"72b8dd3355bb47a587b8caff59006fc32048a316","user":{"login":"eduardoj","id":24919,"avatar_url":"https://avatars1.githubusercontent.com/u/24919?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardoj","html_url":"https://github.com/eduardoj","followers_url":"https://api.github.com/users/eduardoj/followers","following_url":"https://api.github.com/users/eduardoj/following{/other_user}","gists_url":"https://api.github.com/users/eduardoj/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoj/subscriptions","organizations_url":"https://api.github.com/users/eduardoj/orgs","repos_url":"https://api.github.com/users/eduardoj/repos","events_url":"https://api.github.com/users/eduardoj/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoj/received_events","type":"User","site_admin":false},"repo":{"id":55292766,"name":"open-build-service","full_name":"eduardoj/open-build-service","owner":{"login":"eduardoj","id":24919,"avatar_url":"https://avatars1.githubusercontent.com/u/24919?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardoj","html_url":"https://github.com/eduardoj","followers_url":"https://api.github.com/users/eduardoj/followers","following_url":"https://api.github.com/users/eduardoj/following{/other_user}","gists_url":"https://api.github.com/users/eduardoj/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoj/subscriptions","organizations_url":"https://api.github.com/users/eduardoj/orgs","repos_url":"https://api.github.com/users/eduardoj/repos","events_url":"https://api.github.com/users/eduardoj/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eduardoj/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":true,"url":"https://api.github.com/repos/eduardoj/open-build-service","forks_url":"https://api.github.com/repos/eduardoj/open-build-service/forks","keys_url":"https://api.github.com/repos/eduardoj/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eduardoj/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eduardoj/open-build-service/teams","hooks_url":"https://api.github.com/repos/eduardoj/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/eduardoj/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/eduardoj/open-build-service/events","assignees_url":"https://api.github.com/repos/eduardoj/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/eduardoj/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/eduardoj/open-build-service/tags","blobs_url":"https://api.github.com/repos/eduardoj/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eduardoj/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eduardoj/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/eduardoj/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eduardoj/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/eduardoj/open-build-service/languages","stargazers_url":"https://api.github.com/repos/eduardoj/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/eduardoj/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/eduardoj/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/eduardoj/open-build-service/subscription","commits_url":"https://api.github.com/repos/eduardoj/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/eduardoj/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/eduardoj/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/eduardoj/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/eduardoj/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/eduardoj/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eduardoj/open-build-service/merges","archive_url":"https://api.github.com/repos/eduardoj/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eduardoj/open-build-service/downloads","issues_url":"https://api.github.com/repos/eduardoj/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/eduardoj/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/eduardoj/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/eduardoj/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eduardoj/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/eduardoj/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/eduardoj/open-build-service/deployments","created_at":"2016-04-02T12:13:53Z","updated_at":"2016-04-02T12:13:57Z","pushed_at":"2018-04-11T11:52:48Z","git_url":"git://github.com/eduardoj/open-build-service.git","ssh_url":"git@github.com:eduardoj/open-build-service.git","clone_url":"https://github.com/eduardoj/open-build-service.git","svn_url":"https://github.com/eduardoj/open-build-service","homepage":"http://openbuildservice.org/","size":57824,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"9b913ddd288a237b64fd7e97e34904006057537f","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":2046192,"name":"open-build-service","full_name":"openSUSE/open-build-service","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":false,"url":"https://api.github.com/repos/openSUSE/open-build-service","forks_url":"https://api.github.com/repos/openSUSE/open-build-service/forks","keys_url":"https://api.github.com/repos/openSUSE/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/open-build-service/teams","hooks_url":"https://api.github.com/repos/openSUSE/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/open-build-service/events","assignees_url":"https://api.github.com/repos/openSUSE/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/open-build-service/tags","blobs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/open-build-service/languages","stargazers_url":"https://api.github.com/repos/openSUSE/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/open-build-service/subscription","commits_url":"https://api.github.com/repos/openSUSE/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/open-build-service/merges","archive_url":"https://api.github.com/repos/openSUSE/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/open-build-service/downloads","issues_url":"https://api.github.com/repos/openSUSE/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/open-build-service/deployments","created_at":"2011-07-14T06:52:57Z","updated_at":"2018-04-11T13:15:01Z","pushed_at":"2018-04-11T14:04:47Z","git_url":"git://github.com/openSUSE/open-build-service.git","ssh_url":"git@github.com:openSUSE/open-build-service.git","clone_url":"https://github.com/openSUSE/open-build-service.git","svn_url":"https://github.com/openSUSE/open-build-service","homepage":"http://openbuildservice.org/","size":58480,"stargazers_count":340,"watchers_count":340,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"open_issues_count":482,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":230,"open_issues":482,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/4668"},"issue":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/4668"},"comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/4668/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/4668/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/open-build-service/statuses/72b8dd3355bb47a587b8caff59006fc32048a316"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eduardoj"}}