{"action":"created","comment":{"url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/comments/169882138","pull_request_review_id":98478095,"id":169882138,"diff_hunk":"@@ -47,7 +47,7 @@ def _test_pipeline(self, configuration_path, processor_creator, input_dir, expec\n     def __read_expected_result(expected_result_file):\n         with open(expected_result_file) as json_file:\n             lines = filter(\n-                lambda json_line: json_line.strip() != \"\",\n+                lambda json_line: (json_line.strip() != \"\") & ~(json_line.strip().startswith(\"//\")),","path":"src/test/it/core/base_spark_test_case.py","position":5,"original_position":5,"commit_id":"be8e5f0e776b53e1f851888ce8506f34c4c2b9a6","original_commit_id":"be8e5f0e776b53e1f851888ce8506f34c4c2b9a6","user":{"login":"chermenin","id":5195455,"avatar_url":"https://avatars0.githubusercontent.com/u/5195455?v=4","gravatar_id":"","url":"https://api.github.com/users/chermenin","html_url":"https://github.com/chermenin","followers_url":"https://api.github.com/users/chermenin/followers","following_url":"https://api.github.com/users/chermenin/following{/other_user}","gists_url":"https://api.github.com/users/chermenin/gists{/gist_id}","starred_url":"https://api.github.com/users/chermenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chermenin/subscriptions","organizations_url":"https://api.github.com/users/chermenin/orgs","repos_url":"https://api.github.com/users/chermenin/repos","events_url":"https://api.github.com/users/chermenin/events{/privacy}","received_events_url":"https://api.github.com/users/chermenin/received_events","type":"User","site_admin":false},"body":"why not `json_line.strip() != \"\" and not json_line.strip().startswith(\"//\")` ?","created_at":"2018-02-22T08:23:45Z","updated_at":"2018-02-22T08:25:37Z","html_url":"https://github.com/maximofalves/odh-python-pipelines/pull/87#discussion_r169882138","pull_request_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/comments/169882138"},"html":{"href":"https://github.com/maximofalves/odh-python-pipelines/pull/87#discussion_r169882138"},"pull_request":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87","id":170682498,"html_url":"https://github.com/maximofalves/odh-python-pipelines/pull/87","diff_url":"https://github.com/maximofalves/odh-python-pipelines/pull/87.diff","patch_url":"https://github.com/maximofalves/odh-python-pipelines/pull/87.patch","issue_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/87","number":87,"state":"open","locked":false,"title":"ODH-1813: Updated logic of BA job.","user":{"login":"ltv12","id":13897259,"avatar_url":"https://avatars3.githubusercontent.com/u/13897259?v=4","gravatar_id":"","url":"https://api.github.com/users/ltv12","html_url":"https://github.com/ltv12","followers_url":"https://api.github.com/users/ltv12/followers","following_url":"https://api.github.com/users/ltv12/following{/other_user}","gists_url":"https://api.github.com/users/ltv12/gists{/gist_id}","starred_url":"https://api.github.com/users/ltv12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltv12/subscriptions","organizations_url":"https://api.github.com/users/ltv12/orgs","repos_url":"https://api.github.com/users/ltv12/repos","events_url":"https://api.github.com/users/ltv12/events{/privacy}","received_events_url":"https://api.github.com/users/ltv12/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-22T08:18:31Z","updated_at":"2018-02-22T08:25:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10d18c5f4179e0b58b5e32632dd1e6ad171d4b4b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sermolaev1986","id":3391364,"avatar_url":"https://avatars0.githubusercontent.com/u/3391364?v=4","gravatar_id":"","url":"https://api.github.com/users/sermolaev1986","html_url":"https://github.com/sermolaev1986","followers_url":"https://api.github.com/users/sermolaev1986/followers","following_url":"https://api.github.com/users/sermolaev1986/following{/other_user}","gists_url":"https://api.github.com/users/sermolaev1986/gists{/gist_id}","starred_url":"https://api.github.com/users/sermolaev1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sermolaev1986/subscriptions","organizations_url":"https://api.github.com/users/sermolaev1986/orgs","repos_url":"https://api.github.com/users/sermolaev1986/repos","events_url":"https://api.github.com/users/sermolaev1986/events{/privacy}","received_events_url":"https://api.github.com/users/sermolaev1986/received_events","type":"User","site_admin":false},{"login":"halfwhite","id":10629464,"avatar_url":"https://avatars3.githubusercontent.com/u/10629464?v=4","gravatar_id":"","url":"https://api.github.com/users/halfwhite","html_url":"https://github.com/halfwhite","followers_url":"https://api.github.com/users/halfwhite/followers","following_url":"https://api.github.com/users/halfwhite/following{/other_user}","gists_url":"https://api.github.com/users/halfwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/halfwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfwhite/subscriptions","organizations_url":"https://api.github.com/users/halfwhite/orgs","repos_url":"https://api.github.com/users/halfwhite/repos","events_url":"https://api.github.com/users/halfwhite/events{/privacy}","received_events_url":"https://api.github.com/users/halfwhite/received_events","type":"User","site_admin":false},{"login":"vunder-kind","id":24622282,"avatar_url":"https://avatars1.githubusercontent.com/u/24622282?v=4","gravatar_id":"","url":"https://api.github.com/users/vunder-kind","html_url":"https://github.com/vunder-kind","followers_url":"https://api.github.com/users/vunder-kind/followers","following_url":"https://api.github.com/users/vunder-kind/following{/other_user}","gists_url":"https://api.github.com/users/vunder-kind/gists{/gist_id}","starred_url":"https://api.github.com/users/vunder-kind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vunder-kind/subscriptions","organizations_url":"https://api.github.com/users/vunder-kind/orgs","repos_url":"https://api.github.com/users/vunder-kind/repos","events_url":"https://api.github.com/users/vunder-kind/events{/privacy}","received_events_url":"https://api.github.com/users/vunder-kind/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87/commits","review_comments_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87/comments","review_comment_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/87/comments","statuses_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/statuses/be8e5f0e776b53e1f851888ce8506f34c4c2b9a6","head":{"label":"maximofalves:ODH_1813_prodis_ba_updates","ref":"ODH_1813_prodis_ba_updates","sha":"be8e5f0e776b53e1f851888ce8506f34c4c2b9a6","user":{"login":"maximofalves","id":8713930,"avatar_url":"https://avatars2.githubusercontent.com/u/8713930?v=4","gravatar_id":"","url":"https://api.github.com/users/maximofalves","html_url":"https://github.com/maximofalves","followers_url":"https://api.github.com/users/maximofalves/followers","following_url":"https://api.github.com/users/maximofalves/following{/other_user}","gists_url":"https://api.github.com/users/maximofalves/gists{/gist_id}","starred_url":"https://api.github.com/users/maximofalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximofalves/subscriptions","organizations_url":"https://api.github.com/users/maximofalves/orgs","repos_url":"https://api.github.com/users/maximofalves/repos","events_url":"https://api.github.com/users/maximofalves/events{/privacy}","received_events_url":"https://api.github.com/users/maximofalves/received_events","type":"User","site_admin":false},"repo":{"id":110665659,"name":"odh-python-pipelines","full_name":"maximofalves/odh-python-pipelines","owner":{"login":"maximofalves","id":8713930,"avatar_url":"https://avatars2.githubusercontent.com/u/8713930?v=4","gravatar_id":"","url":"https://api.github.com/users/maximofalves","html_url":"https://github.com/maximofalves","followers_url":"https://api.github.com/users/maximofalves/followers","following_url":"https://api.github.com/users/maximofalves/following{/other_user}","gists_url":"https://api.github.com/users/maximofalves/gists{/gist_id}","starred_url":"https://api.github.com/users/maximofalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximofalves/subscriptions","organizations_url":"https://api.github.com/users/maximofalves/orgs","repos_url":"https://api.github.com/users/maximofalves/repos","events_url":"https://api.github.com/users/maximofalves/events{/privacy}","received_events_url":"https://api.github.com/users/maximofalves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maximofalves/odh-python-pipelines","description":null,"fork":false,"url":"https://api.github.com/repos/maximofalves/odh-python-pipelines","forks_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/forks","keys_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/teams","hooks_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/hooks","issue_events_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/events","assignees_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/tags","blobs_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/languages","stargazers_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/stargazers","contributors_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/contributors","subscribers_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/subscribers","subscription_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/subscription","commits_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/merges","archive_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/downloads","issues_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/labels{/name}","releases_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/deployments","created_at":"2017-11-14T09:00:27Z","updated_at":"2018-01-29T15:03:45Z","pushed_at":"2018-02-22T08:18:31Z","git_url":"git://github.com/maximofalves/odh-python-pipelines.git","ssh_url":"git@github.com:maximofalves/odh-python-pipelines.git","clone_url":"https://github.com/maximofalves/odh-python-pipelines.git","svn_url":"https://github.com/maximofalves/odh-python-pipelines","homepage":null,"size":3022,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"maximofalves:master","ref":"master","sha":"15ebd1d9e77ea3dccc40198bd0cfe035415dec21","user":{"login":"maximofalves","id":8713930,"avatar_url":"https://avatars2.githubusercontent.com/u/8713930?v=4","gravatar_id":"","url":"https://api.github.com/users/maximofalves","html_url":"https://github.com/maximofalves","followers_url":"https://api.github.com/users/maximofalves/followers","following_url":"https://api.github.com/users/maximofalves/following{/other_user}","gists_url":"https://api.github.com/users/maximofalves/gists{/gist_id}","starred_url":"https://api.github.com/users/maximofalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximofalves/subscriptions","organizations_url":"https://api.github.com/users/maximofalves/orgs","repos_url":"https://api.github.com/users/maximofalves/repos","events_url":"https://api.github.com/users/maximofalves/events{/privacy}","received_events_url":"https://api.github.com/users/maximofalves/received_events","type":"User","site_admin":false},"repo":{"id":110665659,"name":"odh-python-pipelines","full_name":"maximofalves/odh-python-pipelines","owner":{"login":"maximofalves","id":8713930,"avatar_url":"https://avatars2.githubusercontent.com/u/8713930?v=4","gravatar_id":"","url":"https://api.github.com/users/maximofalves","html_url":"https://github.com/maximofalves","followers_url":"https://api.github.com/users/maximofalves/followers","following_url":"https://api.github.com/users/maximofalves/following{/other_user}","gists_url":"https://api.github.com/users/maximofalves/gists{/gist_id}","starred_url":"https://api.github.com/users/maximofalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximofalves/subscriptions","organizations_url":"https://api.github.com/users/maximofalves/orgs","repos_url":"https://api.github.com/users/maximofalves/repos","events_url":"https://api.github.com/users/maximofalves/events{/privacy}","received_events_url":"https://api.github.com/users/maximofalves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maximofalves/odh-python-pipelines","description":null,"fork":false,"url":"https://api.github.com/repos/maximofalves/odh-python-pipelines","forks_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/forks","keys_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/teams","hooks_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/hooks","issue_events_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/events","assignees_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/tags","blobs_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/languages","stargazers_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/stargazers","contributors_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/contributors","subscribers_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/subscribers","subscription_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/subscription","commits_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/merges","archive_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/downloads","issues_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/labels{/name}","releases_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/maximofalves/odh-python-pipelines/deployments","created_at":"2017-11-14T09:00:27Z","updated_at":"2018-01-29T15:03:45Z","pushed_at":"2018-02-22T08:18:31Z","git_url":"git://github.com/maximofalves/odh-python-pipelines.git","ssh_url":"git@github.com:maximofalves/odh-python-pipelines.git","clone_url":"https://github.com/maximofalves/odh-python-pipelines.git","svn_url":"https://github.com/maximofalves/odh-python-pipelines","homepage":null,"size":3022,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87"},"html":{"href":"https://github.com/maximofalves/odh-python-pipelines/pull/87"},"issue":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/87"},"comments":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/maximofalves/odh-python-pipelines/statuses/be8e5f0e776b53e1f851888ce8506f34c4c2b9a6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chermenin"}}