{"action":"closed","number":224,"pull_request":{"url":"https://api.github.com/repos/BBC-News/psammead/pulls/224","id":239207332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjA3MzMy","html_url":"https://github.com/BBC-News/psammead/pull/224","diff_url":"https://github.com/BBC-News/psammead/pull/224.diff","patch_url":"https://github.com/BBC-News/psammead/pull/224.patch","issue_url":"https://api.github.com/repos/BBC-News/psammead/issues/224","number":224,"state":"closed","locked":false,"title":"POC: Increase utilities test coverage","user":{"login":"pjlee11","id":7791726,"node_id":"MDQ6VXNlcjc3OTE3MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7791726?v=4","gravatar_id":"","url":"https://api.github.com/users/pjlee11","html_url":"https://github.com/pjlee11","followers_url":"https://api.github.com/users/pjlee11/followers","following_url":"https://api.github.com/users/pjlee11/following{/other_user}","gists_url":"https://api.github.com/users/pjlee11/gists{/gist_id}","starred_url":"https://api.github.com/users/pjlee11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjlee11/subscriptions","organizations_url":"https://api.github.com/users/pjlee11/orgs","repos_url":"https://api.github.com/users/pjlee11/repos","events_url":"https://api.github.com/users/pjlee11/events{/privacy}","received_events_url":"https://api.github.com/users/pjlee11/received_events","type":"User","site_admin":false},"body":"Resolves #156\r\n\r\n- Adds a test helper method that takes an actual import and validates it has all the exported values it is expected to have. This can then be used to simplifying testing the utility packages exports\r\n- Has error handling logic for both new files (EG: `font.js`) and for exported files within those files when:\r\n  1) The actual import has additional exports when compared to the expected values. This is needed so that we do not forget to change the expectations when adding a new export.\r\n  2) The expected value has additional exports as compared to the actual exports. This is needed in the case of a breaking change when an export is to be removed. This is very useful at catching regressions in the utility packages. \r\n\r\n- [x] I have assigned myself to this PR and the corresponding issues\r\n- [x] Tests added for new features\r\n- [ ] Test engineer approval\r\n\r\nTo get this work merged in I'll have to split out the changes in `psammead-test-helpers` and then bump the version and publish to npm before then using the new test helper version in the other packages. \r\n\r\nThat said, this PR can be tested locally by checking out this branch, then copy and paste the following command, which locally links all the necessary packages that once split out will in the future depend on `psammead-test-helpers`:\r\n```\r\ncd packages/utilities/gel-foundations &&\r\n  npm install && npm link ../psammead-test-helpers &&\r\n  cd ../psammead-assets &&\r\n  npm install && npm link ../psammead-test-helpers &&\r\n  cd ../psammead-styles &&\r\n  npm install && npm link ../psammead-test-helpers &&\r\n  cd ../../../ &&\r\n  npm run build && npm run test\r\n```\r\n\r\nFinally, see the test coverage for the whole repo increase from something in the 50's% to over 89% 🎉 ","created_at":"2018-12-17T16:32:39Z","updated_at":"2019-01-04T14:14:38Z","closed_at":"2019-01-04T14:14:37Z","merged_at":null,"merge_commit_sha":"3392105bf2c051519275c606b8a8816f66d96197","assignee":{"login":"pjlee11","id":7791726,"node_id":"MDQ6VXNlcjc3OTE3MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7791726?v=4","gravatar_id":"","url":"https://api.github.com/users/pjlee11","html_url":"https://github.com/pjlee11","followers_url":"https://api.github.com/users/pjlee11/followers","following_url":"https://api.github.com/users/pjlee11/following{/other_user}","gists_url":"https://api.github.com/users/pjlee11/gists{/gist_id}","starred_url":"https://api.github.com/users/pjlee11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjlee11/subscriptions","organizations_url":"https://api.github.com/users/pjlee11/orgs","repos_url":"https://api.github.com/users/pjlee11/repos","events_url":"https://api.github.com/users/pjlee11/events{/privacy}","received_events_url":"https://api.github.com/users/pjlee11/received_events","type":"User","site_admin":false},"assignees":[{"login":"pjlee11","id":7791726,"node_id":"MDQ6VXNlcjc3OTE3MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7791726?v=4","gravatar_id":"","url":"https://api.github.com/users/pjlee11","html_url":"https://github.com/pjlee11","followers_url":"https://api.github.com/users/pjlee11/followers","following_url":"https://api.github.com/users/pjlee11/following{/other_user}","gists_url":"https://api.github.com/users/pjlee11/gists{/gist_id}","starred_url":"https://api.github.com/users/pjlee11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjlee11/subscriptions","organizations_url":"https://api.github.com/users/pjlee11/orgs","repos_url":"https://api.github.com/users/pjlee11/repos","events_url":"https://api.github.com/users/pjlee11/events{/privacy}","received_events_url":"https://api.github.com/users/pjlee11/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1136481721,"node_id":"MDU6TGFiZWwxMTM2NDgxNzIx","url":"https://api.github.com/repos/BBC-News/psammead/labels/alpha-2","name":"alpha-2","color":"8ddb51","default":false},{"id":1144350944,"node_id":"MDU6TGFiZWwxMTQ0MzUwOTQ0","url":"https://api.github.com/repos/BBC-News/psammead/labels/could","name":"could","color":"c1ffad","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BBC-News/psammead/pulls/224/commits","review_comments_url":"https://api.github.com/repos/BBC-News/psammead/pulls/224/comments","review_comment_url":"https://api.github.com/repos/BBC-News/psammead/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BBC-News/psammead/issues/224/comments","statuses_url":"https://api.github.com/repos/BBC-News/psammead/statuses/3e3366c98fd77e67a61aa6ff4b6a5072c077dc52","head":{"label":"BBC-News:increase-utilities-test-coverage","ref":"increase-utilities-test-coverage","sha":"3e3366c98fd77e67a61aa6ff4b6a5072c077dc52","user":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"repo":{"id":148457207,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0NTcyMDc=","name":"psammead","full_name":"BBC-News/psammead","private":false,"owner":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BBC-News/psammead","description":"React component library for BBC Articles and more","fork":false,"url":"https://api.github.com/repos/BBC-News/psammead","forks_url":"https://api.github.com/repos/BBC-News/psammead/forks","keys_url":"https://api.github.com/repos/BBC-News/psammead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBC-News/psammead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBC-News/psammead/teams","hooks_url":"https://api.github.com/repos/BBC-News/psammead/hooks","issue_events_url":"https://api.github.com/repos/BBC-News/psammead/issues/events{/number}","events_url":"https://api.github.com/repos/BBC-News/psammead/events","assignees_url":"https://api.github.com/repos/BBC-News/psammead/assignees{/user}","branches_url":"https://api.github.com/repos/BBC-News/psammead/branches{/branch}","tags_url":"https://api.github.com/repos/BBC-News/psammead/tags","blobs_url":"https://api.github.com/repos/BBC-News/psammead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBC-News/psammead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBC-News/psammead/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBC-News/psammead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBC-News/psammead/statuses/{sha}","languages_url":"https://api.github.com/repos/BBC-News/psammead/languages","stargazers_url":"https://api.github.com/repos/BBC-News/psammead/stargazers","contributors_url":"https://api.github.com/repos/BBC-News/psammead/contributors","subscribers_url":"https://api.github.com/repos/BBC-News/psammead/subscribers","subscription_url":"https://api.github.com/repos/BBC-News/psammead/subscription","commits_url":"https://api.github.com/repos/BBC-News/psammead/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBC-News/psammead/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBC-News/psammead/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBC-News/psammead/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBC-News/psammead/contents/{+path}","compare_url":"https://api.github.com/repos/BBC-News/psammead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBC-News/psammead/merges","archive_url":"https://api.github.com/repos/BBC-News/psammead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBC-News/psammead/downloads","issues_url":"https://api.github.com/repos/BBC-News/psammead/issues{/number}","pulls_url":"https://api.github.com/repos/BBC-News/psammead/pulls{/number}","milestones_url":"https://api.github.com/repos/BBC-News/psammead/milestones{/number}","notifications_url":"https://api.github.com/repos/BBC-News/psammead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBC-News/psammead/labels{/name}","releases_url":"https://api.github.com/repos/BBC-News/psammead/releases{/id}","deployments_url":"https://api.github.com/repos/BBC-News/psammead/deployments","created_at":"2018-09-12T09:41:04Z","updated_at":"2019-01-04T11:38:23Z","pushed_at":"2019-01-04T14:13:43Z","git_url":"git://github.com/BBC-News/psammead.git","ssh_url":"git@github.com:BBC-News/psammead.git","clone_url":"https://github.com/BBC-News/psammead.git","svn_url":"https://github.com/BBC-News/psammead","homepage":"https://bbc-news.github.io/psammead/","size":6164,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":36,"watchers":50,"default_branch":"latest"}},"base":{"label":"BBC-News:latest","ref":"latest","sha":"fc55cdc72f6cc2eb12a646c555925462d71ba857","user":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"repo":{"id":148457207,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0NTcyMDc=","name":"psammead","full_name":"BBC-News/psammead","private":false,"owner":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BBC-News/psammead","description":"React component library for BBC Articles and more","fork":false,"url":"https://api.github.com/repos/BBC-News/psammead","forks_url":"https://api.github.com/repos/BBC-News/psammead/forks","keys_url":"https://api.github.com/repos/BBC-News/psammead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBC-News/psammead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBC-News/psammead/teams","hooks_url":"https://api.github.com/repos/BBC-News/psammead/hooks","issue_events_url":"https://api.github.com/repos/BBC-News/psammead/issues/events{/number}","events_url":"https://api.github.com/repos/BBC-News/psammead/events","assignees_url":"https://api.github.com/repos/BBC-News/psammead/assignees{/user}","branches_url":"https://api.github.com/repos/BBC-News/psammead/branches{/branch}","tags_url":"https://api.github.com/repos/BBC-News/psammead/tags","blobs_url":"https://api.github.com/repos/BBC-News/psammead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBC-News/psammead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBC-News/psammead/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBC-News/psammead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBC-News/psammead/statuses/{sha}","languages_url":"https://api.github.com/repos/BBC-News/psammead/languages","stargazers_url":"https://api.github.com/repos/BBC-News/psammead/stargazers","contributors_url":"https://api.github.com/repos/BBC-News/psammead/contributors","subscribers_url":"https://api.github.com/repos/BBC-News/psammead/subscribers","subscription_url":"https://api.github.com/repos/BBC-News/psammead/subscription","commits_url":"https://api.github.com/repos/BBC-News/psammead/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBC-News/psammead/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBC-News/psammead/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBC-News/psammead/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBC-News/psammead/contents/{+path}","compare_url":"https://api.github.com/repos/BBC-News/psammead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBC-News/psammead/merges","archive_url":"https://api.github.com/repos/BBC-News/psammead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBC-News/psammead/downloads","issues_url":"https://api.github.com/repos/BBC-News/psammead/issues{/number}","pulls_url":"https://api.github.com/repos/BBC-News/psammead/pulls{/number}","milestones_url":"https://api.github.com/repos/BBC-News/psammead/milestones{/number}","notifications_url":"https://api.github.com/repos/BBC-News/psammead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBC-News/psammead/labels{/name}","releases_url":"https://api.github.com/repos/BBC-News/psammead/releases{/id}","deployments_url":"https://api.github.com/repos/BBC-News/psammead/deployments","created_at":"2018-09-12T09:41:04Z","updated_at":"2019-01-04T11:38:23Z","pushed_at":"2019-01-04T14:13:43Z","git_url":"git://github.com/BBC-News/psammead.git","ssh_url":"git@github.com:BBC-News/psammead.git","clone_url":"https://github.com/BBC-News/psammead.git","svn_url":"https://github.com/BBC-News/psammead","homepage":"https://bbc-news.github.io/psammead/","size":6164,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":36,"watchers":50,"default_branch":"latest"}},"_links":{"self":{"href":"https://api.github.com/repos/BBC-News/psammead/pulls/224"},"html":{"href":"https://github.com/BBC-News/psammead/pull/224"},"issue":{"href":"https://api.github.com/repos/BBC-News/psammead/issues/224"},"comments":{"href":"https://api.github.com/repos/BBC-News/psammead/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/BBC-News/psammead/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/BBC-News/psammead/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BBC-News/psammead/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/BBC-News/psammead/statuses/3e3366c98fd77e67a61aa6ff4b6a5072c077dc52"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":47,"maintainer_can_modify":false,"commits":39,"additions":1063,"deletions":230,"changed_files":22}}
{"actor":{"display_login":"pjlee11"}}