{"action":"closed","issue":{"url":"https://api.github.com/repos/lantonov/asmFish/issues/102","repository_url":"https://api.github.com/repos/lantonov/asmFish","labels_url":"https://api.github.com/repos/lantonov/asmFish/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/lantonov/asmFish/issues/102/comments","events_url":"https://api.github.com/repos/lantonov/asmFish/issues/102/events","html_url":"https://github.com/lantonov/asmFish/issues/102","id":291181062,"number":102,"title":"Support for Bin Books larger than 262MB","user":{"login":"Counterply","id":35758505,"avatar_url":"https://avatars2.githubusercontent.com/u/35758505?v=4","gravatar_id":"","url":"https://api.github.com/users/Counterply","html_url":"https://github.com/Counterply","followers_url":"https://api.github.com/users/Counterply/followers","following_url":"https://api.github.com/users/Counterply/following{/other_user}","gists_url":"https://api.github.com/users/Counterply/gists{/gist_id}","starred_url":"https://api.github.com/users/Counterply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Counterply/subscriptions","organizations_url":"https://api.github.com/users/Counterply/orgs","repos_url":"https://api.github.com/users/Counterply/repos","events_url":"https://api.github.com/users/Counterply/events{/privacy}","received_events_url":"https://api.github.com/users/Counterply/received_events","type":"User","site_admin":false},"labels":[{"id":483361982,"url":"https://api.github.com/repos/lantonov/asmFish/labels/suggestion","name":"suggestion","color":"cccccc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-24T11:52:24Z","updated_at":"2018-02-22T14:46:38Z","closed_at":"2018-02-22T14:46:38Z","author_association":"COLLABORATOR","body":"There appears to be an issue with loading relatively large .bin books -- specifically, those which exceed 262 MB in size. As far as I know, this is a bug unique to asmFishW, and is not present in other SF ports.\r\n\r\nHere is a picture demonstrating the result after loading of a 250 MB book and a 300 MB book on both CFish and asmFishW (CFish successfully loads both books, but asmFishW fails to load the larger book):\r\n\r\n![image](https://user-images.githubusercontent.com/35758505/35318949-515a95a4-00a3-11e8-9160-2ad8926c5fb9.png)\r\n\r\nThrough further testing, I was able to determine the point at which asmFishW \"breaks\" to be approximately 262 MB:\r\n\r\n![image](https://user-images.githubusercontent.com/35758505/35328778-19d18d20-00c3-11e8-880a-458de74ce983.png)\r\n\r\nWhat exactly is causing this? Could this error possibly be due to the usage of the `dword` operand in the following portion of book.asm?\r\n\r\n![image](https://user-images.githubusercontent.com/35758505/35330688-fcf3e96c-00c9-11e8-9622-ceeb2b8453a2.png)\r\n\r\nIt is interesting to note that the definition of a `qword` according to Intel [(2^16) * 4 = 262,144] is also exactly the point at which .bin file loading seem to break. Moreover, after decompiling Cfish, it appears that the use of `qword` is more abundant in the `pb_probe` and `polyhash` sections, but it is still unclear to me how (or if) this is preferable syntax for this fasmg port.\r\n\r\nI realize that Mohammed is busy with other projects these days, but any thoughts from anyone on how to go about fixing this bug would be greatly appreciated."}}
{"actor":{"display_login":"lantonov"}}