{"action":"created","issue":{"url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/135","repository_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions","labels_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/135/comments","events_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/135/events","html_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/135","id":323218055,"number":135,"title":"Master ssl","user":{"login":"lisberPontes","id":20478619,"avatar_url":"https://avatars3.githubusercontent.com/u/20478619?v=4","gravatar_id":"","url":"https://api.github.com/users/lisberPontes","html_url":"https://github.com/lisberPontes","followers_url":"https://api.github.com/users/lisberPontes/followers","following_url":"https://api.github.com/users/lisberPontes/following{/other_user}","gists_url":"https://api.github.com/users/lisberPontes/gists{/gist_id}","starred_url":"https://api.github.com/users/lisberPontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisberPontes/subscriptions","organizations_url":"https://api.github.com/users/lisberPontes/orgs","repos_url":"https://api.github.com/users/lisberPontes/repos","events_url":"https://api.github.com/users/lisberPontes/events{/privacy}","received_events_url":"https://api.github.com/users/lisberPontes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-15T13:28:37Z","updated_at":"2018-05-16T07:10:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/pulls/135","html_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/135","diff_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/135.diff","patch_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/135.patch"},"body":"Solve problem within SSL, described here:\r\n\r\nhttps://github.com/StackExchange/StackExchange.Redis/issues/766#issuecomment-357506555\r\n"},"comment":{"url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/comments/389418077","html_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/135#issuecomment-389418077","issue_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/135","id":389418077,"user":{"login":"imperugo","id":758620,"avatar_url":"https://avatars1.githubusercontent.com/u/758620?v=4","gravatar_id":"","url":"https://api.github.com/users/imperugo","html_url":"https://github.com/imperugo","followers_url":"https://api.github.com/users/imperugo/followers","following_url":"https://api.github.com/users/imperugo/following{/other_user}","gists_url":"https://api.github.com/users/imperugo/gists{/gist_id}","starred_url":"https://api.github.com/users/imperugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imperugo/subscriptions","organizations_url":"https://api.github.com/users/imperugo/orgs","repos_url":"https://api.github.com/users/imperugo/repos","events_url":"https://api.github.com/users/imperugo/events{/privacy}","received_events_url":"https://api.github.com/users/imperugo/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T07:10:51Z","updated_at":"2018-05-16T07:10:51Z","author_association":"OWNER","body":"Hi @lisberPontes \r\nthe proposal solution doesn't look good to me.\r\n\r\nLooking [here](https://github.com/lisberPontes/StackExchange.Redis.Extensions/blob/6284be81febf25eb355e6136a82b7fdd0a3c9250/src/StackExchange.Redis.Extensions.Core/Configuration/RedisConfiguration.cs#L83) you are overriding the SSL certificate check for all the people who are using this library.\r\n\r\nYou solution must be an option, not a must have.\r\nMy suggestion is to allow the user to specify a callback into the configuration and than all the security part about SSL is on his hands.\r\n\r\nThanks\r\n\r\n"}}
{"actor":{"display_login":"imperugo"}}