{"action":"created","comment":{"url":"https://api.github.com/repos/HadoukenIO/core/pulls/comments/220237454","pull_request_review_id":158599094,"id":220237454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDIzNzQ1NA==","diff_hunk":"@@ -1,7 +1,21 @@\n import { EmitterMap } from './emitter_map';\n import { createHash } from 'crypto';\n-import { connect, Identity, Fin } from 'hadouken-js-adapter';\n+import { Identity, Fin } from 'hadouken-js-adapter';\n import { EventEmitter } from 'events';\n+import * as path from 'path';\n+\n+/*\n+    Try loading local dev js-adapter, if failed, resort to","path":"src/browser/runtime_p2p/peer_connection_manager.ts","position":9,"original_position":9,"commit_id":"31123b76c4e0e8c187951e6bff46265b52bcd79b","original_commit_id":"31123b76c4e0e8c187951e6bff46265b52bcd79b","user":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"body":"We do the [same thing in the renderer](https://github.com/HadoukenIO/core/blob/develop/src/renderer/main.js#L29)","created_at":"2018-09-25T15:19:34Z","updated_at":"2018-09-25T15:19:34Z","html_url":"https://github.com/HadoukenIO/core/pull/559#discussion_r220237454","pull_request_url":"https://api.github.com/repos/HadoukenIO/core/pulls/559","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/comments/220237454"},"html":{"href":"https://github.com/HadoukenIO/core/pull/559#discussion_r220237454"},"pull_request":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/559"}}},"pull_request":{"url":"https://api.github.com/repos/HadoukenIO/core/pulls/559","id":218020510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDIwNTEw","html_url":"https://github.com/HadoukenIO/core/pull/559","diff_url":"https://github.com/HadoukenIO/core/pull/559.diff","patch_url":"https://github.com/HadoukenIO/core/pull/559.patch","issue_url":"https://api.github.com/repos/HadoukenIO/core/issues/559","number":559,"state":"open","locked":false,"title":"RUN-4641 support loading local dev js-adapter","user":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"body":"ℹ️ **About**\r\nThis change adds the support for loading local dev js-adapter in the core/browser process.\r\nWe do the [same thing in the renderer](https://github.com/HadoukenIO/core/blob/develop/src/renderer/main.js#L29), so why not in the browser process?\r\n\r\n🚥 **Automated test results**\r\n✅ [Windows 7](https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5baa4f8ccb360141a7dfcf59)\r\n✅ [Windows 10](https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5baa5072cb360141a7dfcf5a)","created_at":"2018-09-25T15:18:16Z","updated_at":"2018-09-25T15:19:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ede8ec0ca1116f00e2b61fccc380a0382e0db1ad","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rdepena","id":3679449,"node_id":"MDQ6VXNlcjM2Nzk0NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3679449?v=4","gravatar_id":"","url":"https://api.github.com/users/rdepena","html_url":"https://github.com/rdepena","followers_url":"https://api.github.com/users/rdepena/followers","following_url":"https://api.github.com/users/rdepena/following{/other_user}","gists_url":"https://api.github.com/users/rdepena/gists{/gist_id}","starred_url":"https://api.github.com/users/rdepena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdepena/subscriptions","organizations_url":"https://api.github.com/users/rdepena/orgs","repos_url":"https://api.github.com/users/rdepena/repos","events_url":"https://api.github.com/users/rdepena/events{/privacy}","received_events_url":"https://api.github.com/users/rdepena/received_events","type":"User","site_admin":false},{"login":"licui3936","id":5138885,"node_id":"MDQ6VXNlcjUxMzg4ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/5138885?v=4","gravatar_id":"","url":"https://api.github.com/users/licui3936","html_url":"https://github.com/licui3936","followers_url":"https://api.github.com/users/licui3936/followers","following_url":"https://api.github.com/users/licui3936/following{/other_user}","gists_url":"https://api.github.com/users/licui3936/gists{/gist_id}","starred_url":"https://api.github.com/users/licui3936/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/licui3936/subscriptions","organizations_url":"https://api.github.com/users/licui3936/orgs","repos_url":"https://api.github.com/users/licui3936/repos","events_url":"https://api.github.com/users/licui3936/events{/privacy}","received_events_url":"https://api.github.com/users/licui3936/received_events","type":"User","site_admin":false},{"login":"pbaize","id":19243207,"node_id":"MDQ6VXNlcjE5MjQzMjA3","avatar_url":"https://avatars1.githubusercontent.com/u/19243207?v=4","gravatar_id":"","url":"https://api.github.com/users/pbaize","html_url":"https://github.com/pbaize","followers_url":"https://api.github.com/users/pbaize/followers","following_url":"https://api.github.com/users/pbaize/following{/other_user}","gists_url":"https://api.github.com/users/pbaize/gists{/gist_id}","starred_url":"https://api.github.com/users/pbaize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbaize/subscriptions","organizations_url":"https://api.github.com/users/pbaize/orgs","repos_url":"https://api.github.com/users/pbaize/repos","events_url":"https://api.github.com/users/pbaize/events{/privacy}","received_events_url":"https://api.github.com/users/pbaize/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":940152182,"node_id":"MDU6TGFiZWw5NDAxNTIxODI=","url":"https://api.github.com/repos/HadoukenIO/core/labels/cla-present","name":"cla-present","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HadoukenIO/core/pulls/559/commits","review_comments_url":"https://api.github.com/repos/HadoukenIO/core/pulls/559/comments","review_comment_url":"https://api.github.com/repos/HadoukenIO/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HadoukenIO/core/issues/559/comments","statuses_url":"https://api.github.com/repos/HadoukenIO/core/statuses/31123b76c4e0e8c187951e6bff46265b52bcd79b","head":{"label":"whyn07m3:RUN-4641_require_js-adapter","ref":"RUN-4641_require_js-adapter","sha":"31123b76c4e0e8c187951e6bff46265b52bcd79b","user":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"repo":{"id":90658340,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY1ODM0MA==","name":"core","full_name":"whyn07m3/core","private":false,"owner":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/whyn07m3/core","description":"Hadouken is an open-source runtime for building web applications with desktop experience. The OpenFin Core is the  reference implementation Javascript API for the Hadouken runtime.","fork":true,"url":"https://api.github.com/repos/whyn07m3/core","forks_url":"https://api.github.com/repos/whyn07m3/core/forks","keys_url":"https://api.github.com/repos/whyn07m3/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whyn07m3/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whyn07m3/core/teams","hooks_url":"https://api.github.com/repos/whyn07m3/core/hooks","issue_events_url":"https://api.github.com/repos/whyn07m3/core/issues/events{/number}","events_url":"https://api.github.com/repos/whyn07m3/core/events","assignees_url":"https://api.github.com/repos/whyn07m3/core/assignees{/user}","branches_url":"https://api.github.com/repos/whyn07m3/core/branches{/branch}","tags_url":"https://api.github.com/repos/whyn07m3/core/tags","blobs_url":"https://api.github.com/repos/whyn07m3/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whyn07m3/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whyn07m3/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/whyn07m3/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whyn07m3/core/statuses/{sha}","languages_url":"https://api.github.com/repos/whyn07m3/core/languages","stargazers_url":"https://api.github.com/repos/whyn07m3/core/stargazers","contributors_url":"https://api.github.com/repos/whyn07m3/core/contributors","subscribers_url":"https://api.github.com/repos/whyn07m3/core/subscribers","subscription_url":"https://api.github.com/repos/whyn07m3/core/subscription","commits_url":"https://api.github.com/repos/whyn07m3/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/whyn07m3/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/whyn07m3/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/whyn07m3/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/whyn07m3/core/contents/{+path}","compare_url":"https://api.github.com/repos/whyn07m3/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whyn07m3/core/merges","archive_url":"https://api.github.com/repos/whyn07m3/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whyn07m3/core/downloads","issues_url":"https://api.github.com/repos/whyn07m3/core/issues{/number}","pulls_url":"https://api.github.com/repos/whyn07m3/core/pulls{/number}","milestones_url":"https://api.github.com/repos/whyn07m3/core/milestones{/number}","notifications_url":"https://api.github.com/repos/whyn07m3/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whyn07m3/core/labels{/name}","releases_url":"https://api.github.com/repos/whyn07m3/core/releases{/id}","deployments_url":"https://api.github.com/repos/whyn07m3/core/deployments","created_at":"2017-05-08T18:10:38Z","updated_at":"2018-09-24T15:11:14Z","pushed_at":"2018-09-25T15:04:01Z","git_url":"git://github.com/whyn07m3/core.git","ssh_url":"git@github.com:whyn07m3/core.git","clone_url":"https://github.com/whyn07m3/core.git","svn_url":"https://github.com/whyn07m3/core","homepage":"http://hadouken.io/","size":1955,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HadoukenIO:develop","ref":"develop","sha":"fda854861d5681751c8ef8b2969f5790ad920d20","user":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"repo":{"id":90180083,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE4MDA4Mw==","name":"core","full_name":"HadoukenIO/core","private":false,"owner":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HadoukenIO/core","description":"Hadouken is an open-source platform for creating web applications with native desktop experience.  Hadouken is the base project used to build OpenFin OS, a desktop operating layer used by 45+ major banks, buy-side and vendors to deploy hundreds of apps to over 400 financial firms.","fork":false,"url":"https://api.github.com/repos/HadoukenIO/core","forks_url":"https://api.github.com/repos/HadoukenIO/core/forks","keys_url":"https://api.github.com/repos/HadoukenIO/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HadoukenIO/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HadoukenIO/core/teams","hooks_url":"https://api.github.com/repos/HadoukenIO/core/hooks","issue_events_url":"https://api.github.com/repos/HadoukenIO/core/issues/events{/number}","events_url":"https://api.github.com/repos/HadoukenIO/core/events","assignees_url":"https://api.github.com/repos/HadoukenIO/core/assignees{/user}","branches_url":"https://api.github.com/repos/HadoukenIO/core/branches{/branch}","tags_url":"https://api.github.com/repos/HadoukenIO/core/tags","blobs_url":"https://api.github.com/repos/HadoukenIO/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HadoukenIO/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HadoukenIO/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/HadoukenIO/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HadoukenIO/core/statuses/{sha}","languages_url":"https://api.github.com/repos/HadoukenIO/core/languages","stargazers_url":"https://api.github.com/repos/HadoukenIO/core/stargazers","contributors_url":"https://api.github.com/repos/HadoukenIO/core/contributors","subscribers_url":"https://api.github.com/repos/HadoukenIO/core/subscribers","subscription_url":"https://api.github.com/repos/HadoukenIO/core/subscription","commits_url":"https://api.github.com/repos/HadoukenIO/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/HadoukenIO/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/HadoukenIO/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/HadoukenIO/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/HadoukenIO/core/contents/{+path}","compare_url":"https://api.github.com/repos/HadoukenIO/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HadoukenIO/core/merges","archive_url":"https://api.github.com/repos/HadoukenIO/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HadoukenIO/core/downloads","issues_url":"https://api.github.com/repos/HadoukenIO/core/issues{/number}","pulls_url":"https://api.github.com/repos/HadoukenIO/core/pulls{/number}","milestones_url":"https://api.github.com/repos/HadoukenIO/core/milestones{/number}","notifications_url":"https://api.github.com/repos/HadoukenIO/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HadoukenIO/core/labels{/name}","releases_url":"https://api.github.com/repos/HadoukenIO/core/releases{/id}","deployments_url":"https://api.github.com/repos/HadoukenIO/core/deployments","created_at":"2017-05-03T18:21:22Z","updated_at":"2018-09-25T02:33:39Z","pushed_at":"2018-09-25T15:18:17Z","git_url":"git://github.com/HadoukenIO/core.git","ssh_url":"git@github.com:HadoukenIO/core.git","clone_url":"https://github.com/HadoukenIO/core.git","svn_url":"https://github.com/HadoukenIO/core","homepage":"http://hadouken.io/","size":2053,"stargazers_count":70,"watchers_count":70,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":14,"watchers":70,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/559"},"html":{"href":"https://github.com/HadoukenIO/core/pull/559"},"issue":{"href":"https://api.github.com/repos/HadoukenIO/core/issues/559"},"comments":{"href":"https://api.github.com/repos/HadoukenIO/core/issues/559/comments"},"review_comments":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/559/comments"},"review_comment":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/559/commits"},"statuses":{"href":"https://api.github.com/repos/HadoukenIO/core/statuses/31123b76c4e0e8c187951e6bff46265b52bcd79b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"whyn07m3"}}