{"action":"created","comment":{"url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/comments/203763385","pull_request_review_id":138717328,"id":203763385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzc2MzM4NQ==","diff_hunk":"@@ -779,34 +779,38 @@ public function insertMulti($tableName, array $multiInsertData, array $dataKeys\n         // only auto-commit our inserts, if no transaction is currently running\n         $autoCommit = (isset($this->_transaction_in_progress) ? !$this->_transaction_in_progress : true);\n         $ids = array();\n-\n+        $options = [\n+            '_queryOptions' => $this->_queryOptions,\n+            '_nestJoin' => $this->_nestJoin,\n+            '_forUpdate' => $this->_forUpdate,\n+            '_lockInShareMode' => $this->_lockInShareMode\n+        ];\n         if($autoCommit) {\n             $this->startTransaction();\n         }\n-\n         foreach ($multiInsertData as $insertData) {\n             if($dataKeys !== null) {\n                 // apply column-names if given, else assume they're already given in the data\n                 $insertData = array_combine($dataKeys, $insertData);\n             }\n-\n+            foreach ($options as $k => $v) {\n+                $this->${'k'} = $v;\n+            }\n             $id = $this->insert($tableName, $insertData);\n-            if(!$id) {\n-                if($autoCommit) {\n+            if(!$id ) {\n+                if($autoCommit &&  !in_array('IGNORE', $options['_queryOptions'])) {\n                     $this->rollback();\n                 }\n-                return false;\n+                $id = false;","path":"MysqliDb.php","position":32,"original_position":32,"commit_id":"a955cf7775b7a4231b7f909a4665e33f1d3a00dd","original_commit_id":"a955cf7775b7a4231b7f909a4665e33f1d3a00dd","user":{"login":"avbdr","id":3286514,"node_id":"MDQ6VXNlcjMyODY1MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3286514?v=4","gravatar_id":"","url":"https://api.github.com/users/avbdr","html_url":"https://github.com/avbdr","followers_url":"https://api.github.com/users/avbdr/followers","following_url":"https://api.github.com/users/avbdr/following{/other_user}","gists_url":"https://api.github.com/users/avbdr/gists{/gist_id}","starred_url":"https://api.github.com/users/avbdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avbdr/subscriptions","organizations_url":"https://api.github.com/users/avbdr/orgs","repos_url":"https://api.github.com/users/avbdr/repos","events_url":"https://api.github.com/users/avbdr/events{/privacy}","received_events_url":"https://api.github.com/users/avbdr/received_events","type":"User","site_admin":false},"body":"this still should be return false; plus previous comments are not addressed ","created_at":"2018-07-19T15:06:23Z","updated_at":"2018-07-19T15:06:33Z","html_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/775#discussion_r203763385","pull_request_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/comments/203763385"},"html":{"href":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/775#discussion_r203763385"},"pull_request":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775"}}},"pull_request":{"url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775","id":202572869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTcyODY5","html_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/775","diff_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/775.diff","patch_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/775.patch","issue_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues/775","number":775,"state":"open","locked":false,"title":"Updated insertMulti","user":{"login":"LunarDevelopment","id":10709555,"node_id":"MDQ6VXNlcjEwNzA5NTU1","avatar_url":"https://avatars1.githubusercontent.com/u/10709555?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarDevelopment","html_url":"https://github.com/LunarDevelopment","followers_url":"https://api.github.com/users/LunarDevelopment/followers","following_url":"https://api.github.com/users/LunarDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/LunarDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarDevelopment/subscriptions","organizations_url":"https://api.github.com/users/LunarDevelopment/orgs","repos_url":"https://api.github.com/users/LunarDevelopment/repos","events_url":"https://api.github.com/users/LunarDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/LunarDevelopment/received_events","type":"User","site_admin":false},"body":"Complete with fix for k warning.","created_at":"2018-07-19T14:10:56Z","updated_at":"2018-07-19T15:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8a235dc4d696e310b1bfd22490b5ba1acfbce8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775/commits","review_comments_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775/comments","review_comment_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues/775/comments","statuses_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/statuses/a955cf7775b7a4231b7f909a4665e33f1d3a00dd","head":{"label":"LunarDevelopment:patch-1","ref":"patch-1","sha":"a955cf7775b7a4231b7f909a4665e33f1d3a00dd","user":{"login":"LunarDevelopment","id":10709555,"node_id":"MDQ6VXNlcjEwNzA5NTU1","avatar_url":"https://avatars1.githubusercontent.com/u/10709555?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarDevelopment","html_url":"https://github.com/LunarDevelopment","followers_url":"https://api.github.com/users/LunarDevelopment/followers","following_url":"https://api.github.com/users/LunarDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/LunarDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarDevelopment/subscriptions","organizations_url":"https://api.github.com/users/LunarDevelopment/orgs","repos_url":"https://api.github.com/users/LunarDevelopment/repos","events_url":"https://api.github.com/users/LunarDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/LunarDevelopment/received_events","type":"User","site_admin":false},"repo":{"id":141588561,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1ODg1NjE=","name":"PHP-MySQLi-Database-Class","full_name":"LunarDevelopment/PHP-MySQLi-Database-Class","owner":{"login":"LunarDevelopment","id":10709555,"node_id":"MDQ6VXNlcjEwNzA5NTU1","avatar_url":"https://avatars1.githubusercontent.com/u/10709555?v=4","gravatar_id":"","url":"https://api.github.com/users/LunarDevelopment","html_url":"https://github.com/LunarDevelopment","followers_url":"https://api.github.com/users/LunarDevelopment/followers","following_url":"https://api.github.com/users/LunarDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/LunarDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/LunarDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunarDevelopment/subscriptions","organizations_url":"https://api.github.com/users/LunarDevelopment/orgs","repos_url":"https://api.github.com/users/LunarDevelopment/repos","events_url":"https://api.github.com/users/LunarDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/LunarDevelopment/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LunarDevelopment/PHP-MySQLi-Database-Class","description":"Wrapper for a PHP MySQL class, which utilizes MySQLi and prepared statements. ","fork":true,"url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class","forks_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/forks","keys_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/teams","hooks_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/hooks","issue_events_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/issues/events{/number}","events_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/events","assignees_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/assignees{/user}","branches_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/branches{/branch}","tags_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/tags","blobs_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/git/refs{/sha}","trees_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/statuses/{sha}","languages_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/languages","stargazers_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/stargazers","contributors_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/contributors","subscribers_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/subscribers","subscription_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/subscription","commits_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/commits{/sha}","git_commits_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/git/commits{/sha}","comments_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/comments{/number}","issue_comment_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/issues/comments{/number}","contents_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/contents/{+path}","compare_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/merges","archive_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/downloads","issues_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/issues{/number}","pulls_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/pulls{/number}","milestones_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/milestones{/number}","notifications_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/labels{/name}","releases_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/releases{/id}","deployments_url":"https://api.github.com/repos/LunarDevelopment/PHP-MySQLi-Database-Class/deployments","created_at":"2018-07-19T14:07:21Z","updated_at":"2018-07-19T14:07:24Z","pushed_at":"2018-07-19T14:36:44Z","git_url":"git://github.com/LunarDevelopment/PHP-MySQLi-Database-Class.git","ssh_url":"git@github.com:LunarDevelopment/PHP-MySQLi-Database-Class.git","clone_url":"https://github.com/LunarDevelopment/PHP-MySQLi-Database-Class.git","svn_url":"https://github.com/LunarDevelopment/PHP-MySQLi-Database-Class","homepage":"","size":536,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ThingEngineer:master","ref":"master","sha":"db53256e86743e19c67f2c5dfa1b80557ecbd3f6","user":{"login":"ThingEngineer","id":418426,"node_id":"MDQ6VXNlcjQxODQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/418426?v=4","gravatar_id":"","url":"https://api.github.com/users/ThingEngineer","html_url":"https://github.com/ThingEngineer","followers_url":"https://api.github.com/users/ThingEngineer/followers","following_url":"https://api.github.com/users/ThingEngineer/following{/other_user}","gists_url":"https://api.github.com/users/ThingEngineer/gists{/gist_id}","starred_url":"https://api.github.com/users/ThingEngineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThingEngineer/subscriptions","organizations_url":"https://api.github.com/users/ThingEngineer/orgs","repos_url":"https://api.github.com/users/ThingEngineer/repos","events_url":"https://api.github.com/users/ThingEngineer/events{/privacy}","received_events_url":"https://api.github.com/users/ThingEngineer/received_events","type":"User","site_admin":false},"repo":{"id":1017748,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3NzQ4","name":"PHP-MySQLi-Database-Class","full_name":"ThingEngineer/PHP-MySQLi-Database-Class","owner":{"login":"ThingEngineer","id":418426,"node_id":"MDQ6VXNlcjQxODQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/418426?v=4","gravatar_id":"","url":"https://api.github.com/users/ThingEngineer","html_url":"https://github.com/ThingEngineer","followers_url":"https://api.github.com/users/ThingEngineer/followers","following_url":"https://api.github.com/users/ThingEngineer/following{/other_user}","gists_url":"https://api.github.com/users/ThingEngineer/gists{/gist_id}","starred_url":"https://api.github.com/users/ThingEngineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThingEngineer/subscriptions","organizations_url":"https://api.github.com/users/ThingEngineer/orgs","repos_url":"https://api.github.com/users/ThingEngineer/repos","events_url":"https://api.github.com/users/ThingEngineer/events{/privacy}","received_events_url":"https://api.github.com/users/ThingEngineer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class","description":"Wrapper for a PHP MySQL class, which utilizes MySQLi and prepared statements. ","fork":false,"url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class","forks_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/forks","keys_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/teams","hooks_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/hooks","issue_events_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues/events{/number}","events_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/events","assignees_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/assignees{/user}","branches_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/branches{/branch}","tags_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/tags","blobs_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/statuses/{sha}","languages_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/languages","stargazers_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/stargazers","contributors_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/contributors","subscribers_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/subscribers","subscription_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/subscription","commits_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/contents/{+path}","compare_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/merges","archive_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/downloads","issues_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues{/number}","pulls_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls{/number}","milestones_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/milestones{/number}","notifications_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/labels{/name}","releases_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/releases{/id}","deployments_url":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/deployments","created_at":"2010-10-23T15:19:38Z","updated_at":"2018-07-17T12:05:51Z","pushed_at":"2018-07-19T14:36:45Z","git_url":"git://github.com/ThingEngineer/PHP-MySQLi-Database-Class.git","ssh_url":"git@github.com:ThingEngineer/PHP-MySQLi-Database-Class.git","clone_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class.git","svn_url":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class","homepage":"","size":536,"stargazers_count":2144,"watchers_count":2144,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1010,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1010,"open_issues":102,"watchers":2144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775"},"html":{"href":"https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/775"},"issue":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues/775"},"comments":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/ThingEngineer/PHP-MySQLi-Database-Class/statuses/a955cf7775b7a4231b7f909a4665e33f1d3a00dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"avbdr"}}