{"action":"closed","issue":{"url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/344","repository_url":"https://api.github.com/repos/Eloston/ungoogled-chromium","labels_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/344/comments","events_url":"https://api.github.com/repos/Eloston/ungoogled-chromium/issues/344/events","html_url":"https://github.com/Eloston/ungoogled-chromium/issues/344","id":301861402,"number":344,"title":"gtk2 compile error","user":{"login":"zaza42","id":16356124,"avatar_url":"https://avatars0.githubusercontent.com/u/16356124?v=4","gravatar_id":"","url":"https://api.github.com/users/zaza42","html_url":"https://github.com/zaza42","followers_url":"https://api.github.com/users/zaza42/followers","following_url":"https://api.github.com/users/zaza42/following{/other_user}","gists_url":"https://api.github.com/users/zaza42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaza42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaza42/subscriptions","organizations_url":"https://api.github.com/users/zaza42/orgs","repos_url":"https://api.github.com/users/zaza42/repos","events_url":"https://api.github.com/users/zaza42/events{/privacy}","received_events_url":"https://api.github.com/users/zaza42/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-02T18:29:13Z","updated_at":"2018-03-03T08:12:13Z","closed_at":"2018-03-03T08:12:13Z","author_association":"NONE","body":"I've tried to compile ungoogled-chromium for gtk2 with `use_gtk3=false` on Debian Stretch.\r\n```\r\n[17927/23629] CXX obj/chrome/browser/ui/libgtkui/libgtk2ui/gtk_ui.o\r\nFAILED: obj/chrome/browser/ui/libgtkui/libgtk2ui/gtk_ui.o \r\n../../../../../../../../../lib/llvm-5.0/bin/clang++ -MMD -MF obj/chrome/browser/ui/libgtkui/libgtk2ui/gtk_ui.o.d -DLIBGTKUI_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -DCR_CLANG_REVISION=\\\"318667-1\\\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_CUPS -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_IPC_FUZZER -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DLEVELDB_PLATFORM_CHROMIUM=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -I../.. -Igen -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Igen/shim_headers/libevent_shim -Igen/shim_headers/libpng_shim -Igen/shim_headers/icuuc_shim -Igen/shim_headers/zlib_shim -Igen/shim_headers/libdrm_shim -Igen/shim_headers/icui18n_shim -I../../third_party/khronos -I../../gpu -Igen/shim_headers/ffmpeg_shim -Igen/shim_headers/libvpx_shim -Igen/shim_headers/re2_shim -Igen/shim_headers/snappy_shim -Igen/shim_headers/opus_shim -Igen/shim_headers/minizip_shim -Igen/shim_headers/flac_shim -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/freetype2 -I../../third_party/ced/src -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I/usr/include/nss -I/usr/include/nspr -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/libwebm/source -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I/usr/include/freetype2 -I../../third_party/harfbuzz-ng/src -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -no-canonical-prefixes -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-header-guard -std=gnu++14 -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../chrome/browser/ui/libgtkui/gtk_ui.cc -o obj/chrome/browser/ui/libgtkui/libgtk2ui/gtk_ui.o\r\nwarning: unknown warning option '-Wno-enum-compare-switch'; did you mean '-Wno-enum-compare'? [-Wunknown-warning-option]\r\nwarning: unknown warning option '-Wno-tautological-unsigned-zero-compare' [-Wunknown-warning-option]\r\nwarning: unknown warning option '-Wno-null-pointer-arithmetic'; did you mean '-Wno-null-arithmetic'? [-Wunknown-warning-option]\r\nwarning: unknown warning option '-Wno-tautological-constant-compare'; did you mean '-Wno-tautological-pointer-compare'? [-Wunknown-warning-option]\r\nIn file included from ../../chrome/browser/ui/libgtkui/gtk_ui.cc:5:\r\nIn file included from ../../chrome/browser/ui/libgtkui/gtk_ui.h:9:\r\nIn file included from /usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/memory:81:\r\n/usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/unique_ptr.h:74:16: error: invalid application of 'sizeof' to an incomplete type 'libgtkui::NavButtonLayoutManager'\r\n        static_assert(sizeof(_Tp)>0,\r\n                      ^~~~~~~~~~~\r\n/usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/unique_ptr.h:239:4: note: in instantiation of member function 'std::default_delete<libgtkui::NavButtonLayoutManager>::operator()' requested here\r\n          get_deleter()(__ptr);\r\n          ^\r\n/usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/unique_ptr.h:204:50: note: in instantiation of member function 'std::unique_ptr<libgtkui::NavButtonLayoutManager, std::default_delete<libgtkui::NavButtonLayoutManager> >::~unique_ptr' requested here\r\n      constexpr unique_ptr(nullptr_t) noexcept : unique_ptr() { }\r\n                                                 ^\r\n../../chrome/browser/ui/libgtkui/gtk_ui.h:29:7: note: forward declaration of 'libgtkui::NavButtonLayoutManager'\r\nclass NavButtonLayoutManager;\r\n      ^\r\n4 warnings and 1 error generated.\r\n\r\n```\r\n\r\ni think this [patch](https://gist.github.com/lahwaacz/faaccdd0988be2ca25fd7c816e3794f1) should fix the problem. Can you include this in patches?"}}
{"actor":{"display_login":"Eloston"}}