{"action":"closed","number":14657,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/14657","id":219647171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjQ3MTcx","html_url":"https://github.com/spring-projects/spring-boot/pull/14657","diff_url":"https://github.com/spring-projects/spring-boot/pull/14657.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/14657.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14657","number":14657,"state":"closed","locked":false,"title":"Use non-reflective APIs to inject converters","user":{"login":"dsyer","id":124075,"node_id":"MDQ6VXNlcjEyNDA3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/124075?v=4","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"body":"The `@Qualifier` APIs are a bit limited in Spring still, so we might\r\nwant to use this to pursue additional convenience methods before\r\nmerging. See [SPR-8891](https://jira.spring.io/browse/SPR-8891).","created_at":"2018-10-02T09:56:52Z","updated_at":"2018-10-14T13:12:07Z","closed_at":"2018-10-14T13:12:07Z","merged_at":null,"merge_commit_sha":"9143f01617c6aca5dc8645f098df2d360e6b8cd4","assignee":{"login":"wilkinsona","id":914682,"node_id":"MDQ6VXNlcjkxNDY4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"assignees":[{"login":"wilkinsona","id":914682,"node_id":"MDQ6VXNlcjkxNDY4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":69230488,"node_id":"MDU6TGFiZWw2OTIzMDQ4OA==","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/type:%20task","name":"type: task","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/106","html_url":"https://github.com/spring-projects/spring-boot/milestone/106","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/106/labels","id":3206354,"node_id":"MDk6TWlsZXN0b25lMzIwNjM1NA==","number":106,"title":"2.1.x","description":"Issues that we want to solve in the 2.1.x line.\r\n\r\n","creator":{"login":"philwebb","id":519772,"node_id":"MDQ6VXNlcjUxOTc3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/519772?v=4","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2018-03-21T14:09:08Z","updated_at":"2018-10-14T13:12:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/14657/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/14657/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14657/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/9ea051dec3ef54888c51df9384b8ff432d716d3c","head":{"label":"dsyer:converters","ref":"converters","sha":"9ea051dec3ef54888c51df9384b8ff432d716d3c","user":{"login":"dsyer","id":124075,"node_id":"MDQ6VXNlcjEyNDA3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/124075?v=4","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"repo":{"id":6437522,"node_id":"MDEwOlJlcG9zaXRvcnk2NDM3NTIy","name":"spring-boot","full_name":"dsyer/spring-boot","private":false,"owner":{"login":"dsyer","id":124075,"node_id":"MDQ6VXNlcjEyNDA3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/124075?v=4","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dsyer/spring-boot","description":"Fork of Spring Boot","fork":true,"url":"https://api.github.com/repos/dsyer/spring-boot","forks_url":"https://api.github.com/repos/dsyer/spring-boot/forks","keys_url":"https://api.github.com/repos/dsyer/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsyer/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsyer/spring-boot/teams","hooks_url":"https://api.github.com/repos/dsyer/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/dsyer/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/dsyer/spring-boot/events","assignees_url":"https://api.github.com/repos/dsyer/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/dsyer/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/dsyer/spring-boot/tags","blobs_url":"https://api.github.com/repos/dsyer/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsyer/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsyer/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsyer/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsyer/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/dsyer/spring-boot/languages","stargazers_url":"https://api.github.com/repos/dsyer/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/dsyer/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/dsyer/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/dsyer/spring-boot/subscription","commits_url":"https://api.github.com/repos/dsyer/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsyer/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsyer/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsyer/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsyer/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/dsyer/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsyer/spring-boot/merges","archive_url":"https://api.github.com/repos/dsyer/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsyer/spring-boot/downloads","issues_url":"https://api.github.com/repos/dsyer/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/dsyer/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/dsyer/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/dsyer/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsyer/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/dsyer/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/dsyer/spring-boot/deployments","created_at":"2012-10-29T08:41:41Z","updated_at":"2017-12-21T14:57:20Z","pushed_at":"2018-10-14T09:11:16Z","git_url":"git://github.com/dsyer/spring-boot.git","ssh_url":"git@github.com:dsyer/spring-boot.git","clone_url":"https://github.com/dsyer/spring-boot.git","svn_url":"https://github.com/dsyer/spring-boot","homepage":"","size":77347,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"a0bbb98b51d55771567185464a9a678316b2c253","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":6296790,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk2Nzkw","name":"spring-boot","full_name":"spring-projects/spring-boot","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-boot","description":"Spring Boot","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-boot","forks_url":"https://api.github.com/repos/spring-projects/spring-boot/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-boot/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-boot/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-boot/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-boot/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-boot/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-boot/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-boot/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-boot/deployments","created_at":"2012-10-19T15:02:57Z","updated_at":"2018-10-14T12:37:43Z","pushed_at":"2018-10-14T13:11:59Z","git_url":"git://github.com/spring-projects/spring-boot.git","ssh_url":"git@github.com:spring-projects/spring-boot.git","clone_url":"https://github.com/spring-projects/spring-boot.git","svn_url":"https://github.com/spring-projects/spring-boot","homepage":"https://spring.io/projects/spring-boot","size":81875,"stargazers_count":29832,"watchers_count":29832,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20940,"mirror_url":null,"archived":false,"open_issues_count":350,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20940,"open_issues":350,"watchers":29832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/14657"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/14657"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/14657"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/14657/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/14657/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/14657/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-boot/statuses/9ea051dec3ef54888c51df9384b8ff432d716d3c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":33,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"wilkinsona"}}