{"action":"created","comment":{"url":"https://api.github.com/repos/duct-framework/core/pulls/comments/191272686","pull_request_review_id":123811326,"id":191272686,"diff_hunk":"@@ -0,0 +1,20 @@\n+(ns duct.env-test\n+  (:require [clojure.test :refer :all]\n+            [duct.core.env :as env])\n+  (:import (clojure.lang ExceptionInfo)))\n+\n+(deftest coerce\n+  (are [a b c] (= (env/coerce a b) c)\n+    \"a\"    'Str  \"a\"\n+    12     'Str  \"12\"\n+    \"123\"  'Int  123\n+    \"true\" 'Bool true\n+    \"TruE\" 'Bool true\n+    \"t\"    'Bool true\n+    \"\"     'Bool false\n+    \"no\"   'Bool false\n+    nil    'Bool false)\n+  (is (thrown? IllegalArgumentException\n+               (env/coerce \"abc\" 'Int)))\n+  (is (thrown? ExceptionInfo\n+               (env/coerce \"tru\" 'Bool))))","path":"test/duct/env_test.clj","position":20,"original_position":20,"commit_id":"679e0678b2f17241592ae59bbe230920bfcff6bb","original_commit_id":"c806d8dfab2af084d5d25891df7ddbb8d0c37a38","user":{"login":"dlebrero","id":2147539,"avatar_url":"https://avatars1.githubusercontent.com/u/2147539?v=4","gravatar_id":"","url":"https://api.github.com/users/dlebrero","html_url":"https://github.com/dlebrero","followers_url":"https://api.github.com/users/dlebrero/followers","following_url":"https://api.github.com/users/dlebrero/following{/other_user}","gists_url":"https://api.github.com/users/dlebrero/gists{/gist_id}","starred_url":"https://api.github.com/users/dlebrero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlebrero/subscriptions","organizations_url":"https://api.github.com/users/dlebrero/orgs","repos_url":"https://api.github.com/users/dlebrero/repos","events_url":"https://api.github.com/users/dlebrero/events{/privacy}","received_events_url":"https://api.github.com/users/dlebrero/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-05-28T21:15:15Z","updated_at":"2018-05-28T21:15:15Z","html_url":"https://github.com/duct-framework/core/pull/9#discussion_r191272686","pull_request_url":"https://api.github.com/repos/duct-framework/core/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/duct-framework/core/pulls/comments/191272686"},"html":{"href":"https://github.com/duct-framework/core/pull/9#discussion_r191272686"},"pull_request":{"href":"https://api.github.com/repos/duct-framework/core/pulls/9"}},"in_reply_to_id":191257029},"pull_request":{"url":"https://api.github.com/repos/duct-framework/core/pulls/9","id":158946850,"html_url":"https://github.com/duct-framework/core/pull/9","diff_url":"https://github.com/duct-framework/core/pull/9.diff","patch_url":"https://github.com/duct-framework/core/pull/9.patch","issue_url":"https://api.github.com/repos/duct-framework/core/issues/9","number":9,"state":"open","locked":false,"title":"Support to coercion of env vars to boolean","user":{"login":"dlebrero","id":2147539,"avatar_url":"https://avatars1.githubusercontent.com/u/2147539?v=4","gravatar_id":"","url":"https://api.github.com/users/dlebrero","html_url":"https://github.com/dlebrero","followers_url":"https://api.github.com/users/dlebrero/followers","following_url":"https://api.github.com/users/dlebrero/following{/other_user}","gists_url":"https://api.github.com/users/dlebrero/gists{/gist_id}","starred_url":"https://api.github.com/users/dlebrero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlebrero/subscriptions","organizations_url":"https://api.github.com/users/dlebrero/orgs","repos_url":"https://api.github.com/users/dlebrero/repos","events_url":"https://api.github.com/users/dlebrero/events{/privacy}","received_events_url":"https://api.github.com/users/dlebrero/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-18T15:44:24Z","updated_at":"2018-05-28T21:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a463fd1a70433bc5d828632c69854486983c4f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/duct-framework/core/pulls/9/commits","review_comments_url":"https://api.github.com/repos/duct-framework/core/pulls/9/comments","review_comment_url":"https://api.github.com/repos/duct-framework/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duct-framework/core/issues/9/comments","statuses_url":"https://api.github.com/repos/duct-framework/core/statuses/679e0678b2f17241592ae59bbe230920bfcff6bb","head":{"label":"akvo:master","ref":"master","sha":"679e0678b2f17241592ae59bbe230920bfcff6bb","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars0.githubusercontent.com/u/159843?v=4","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":114657790,"name":"core","full_name":"akvo/core","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars0.githubusercontent.com/u/159843?v=4","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/core","description":"The core library of the Duct framework","fork":true,"url":"https://api.github.com/repos/akvo/core","forks_url":"https://api.github.com/repos/akvo/core/forks","keys_url":"https://api.github.com/repos/akvo/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/core/teams","hooks_url":"https://api.github.com/repos/akvo/core/hooks","issue_events_url":"https://api.github.com/repos/akvo/core/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/core/events","assignees_url":"https://api.github.com/repos/akvo/core/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/core/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/core/tags","blobs_url":"https://api.github.com/repos/akvo/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/core/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/core/languages","stargazers_url":"https://api.github.com/repos/akvo/core/stargazers","contributors_url":"https://api.github.com/repos/akvo/core/contributors","subscribers_url":"https://api.github.com/repos/akvo/core/subscribers","subscription_url":"https://api.github.com/repos/akvo/core/subscription","commits_url":"https://api.github.com/repos/akvo/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/core/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/core/merges","archive_url":"https://api.github.com/repos/akvo/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/core/downloads","issues_url":"https://api.github.com/repos/akvo/core/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/core/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/core/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/core/labels{/name}","releases_url":"https://api.github.com/repos/akvo/core/releases{/id}","deployments_url":"https://api.github.com/repos/akvo/core/deployments","created_at":"2017-12-18T15:36:46Z","updated_at":"2018-05-28T20:58:29Z","pushed_at":"2018-05-28T20:58:27Z","git_url":"git://github.com/akvo/core.git","ssh_url":"git@github.com:akvo/core.git","clone_url":"https://github.com/akvo/core.git","svn_url":"https://github.com/akvo/core","homepage":"","size":118,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"duct-framework:master","ref":"master","sha":"3964492d8d4be266ba7614d29263488e03482112","user":{"login":"duct-framework","id":19802181,"avatar_url":"https://avatars2.githubusercontent.com/u/19802181?v=4","gravatar_id":"","url":"https://api.github.com/users/duct-framework","html_url":"https://github.com/duct-framework","followers_url":"https://api.github.com/users/duct-framework/followers","following_url":"https://api.github.com/users/duct-framework/following{/other_user}","gists_url":"https://api.github.com/users/duct-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/duct-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duct-framework/subscriptions","organizations_url":"https://api.github.com/users/duct-framework/orgs","repos_url":"https://api.github.com/users/duct-framework/repos","events_url":"https://api.github.com/users/duct-framework/events{/privacy}","received_events_url":"https://api.github.com/users/duct-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":87817288,"name":"core","full_name":"duct-framework/core","owner":{"login":"duct-framework","id":19802181,"avatar_url":"https://avatars2.githubusercontent.com/u/19802181?v=4","gravatar_id":"","url":"https://api.github.com/users/duct-framework","html_url":"https://github.com/duct-framework","followers_url":"https://api.github.com/users/duct-framework/followers","following_url":"https://api.github.com/users/duct-framework/following{/other_user}","gists_url":"https://api.github.com/users/duct-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/duct-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duct-framework/subscriptions","organizations_url":"https://api.github.com/users/duct-framework/orgs","repos_url":"https://api.github.com/users/duct-framework/repos","events_url":"https://api.github.com/users/duct-framework/events{/privacy}","received_events_url":"https://api.github.com/users/duct-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duct-framework/core","description":"The core library of the Duct framework","fork":false,"url":"https://api.github.com/repos/duct-framework/core","forks_url":"https://api.github.com/repos/duct-framework/core/forks","keys_url":"https://api.github.com/repos/duct-framework/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duct-framework/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duct-framework/core/teams","hooks_url":"https://api.github.com/repos/duct-framework/core/hooks","issue_events_url":"https://api.github.com/repos/duct-framework/core/issues/events{/number}","events_url":"https://api.github.com/repos/duct-framework/core/events","assignees_url":"https://api.github.com/repos/duct-framework/core/assignees{/user}","branches_url":"https://api.github.com/repos/duct-framework/core/branches{/branch}","tags_url":"https://api.github.com/repos/duct-framework/core/tags","blobs_url":"https://api.github.com/repos/duct-framework/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duct-framework/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duct-framework/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/duct-framework/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duct-framework/core/statuses/{sha}","languages_url":"https://api.github.com/repos/duct-framework/core/languages","stargazers_url":"https://api.github.com/repos/duct-framework/core/stargazers","contributors_url":"https://api.github.com/repos/duct-framework/core/contributors","subscribers_url":"https://api.github.com/repos/duct-framework/core/subscribers","subscription_url":"https://api.github.com/repos/duct-framework/core/subscription","commits_url":"https://api.github.com/repos/duct-framework/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/duct-framework/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/duct-framework/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/duct-framework/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/duct-framework/core/contents/{+path}","compare_url":"https://api.github.com/repos/duct-framework/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duct-framework/core/merges","archive_url":"https://api.github.com/repos/duct-framework/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duct-framework/core/downloads","issues_url":"https://api.github.com/repos/duct-framework/core/issues{/number}","pulls_url":"https://api.github.com/repos/duct-framework/core/pulls{/number}","milestones_url":"https://api.github.com/repos/duct-framework/core/milestones{/number}","notifications_url":"https://api.github.com/repos/duct-framework/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duct-framework/core/labels{/name}","releases_url":"https://api.github.com/repos/duct-framework/core/releases{/id}","deployments_url":"https://api.github.com/repos/duct-framework/core/deployments","created_at":"2017-04-10T13:59:27Z","updated_at":"2018-05-01T05:10:06Z","pushed_at":"2018-05-28T20:58:28Z","git_url":"git://github.com/duct-framework/core.git","ssh_url":"git@github.com:duct-framework/core.git","clone_url":"https://github.com/duct-framework/core.git","svn_url":"https://github.com/duct-framework/core","homepage":"","size":128,"stargazers_count":30,"watchers_count":30,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":8,"open_issues":6,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duct-framework/core/pulls/9"},"html":{"href":"https://github.com/duct-framework/core/pull/9"},"issue":{"href":"https://api.github.com/repos/duct-framework/core/issues/9"},"comments":{"href":"https://api.github.com/repos/duct-framework/core/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/duct-framework/core/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/duct-framework/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duct-framework/core/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/duct-framework/core/statuses/679e0678b2f17241592ae59bbe230920bfcff6bb"}},"author_association":"NONE"}}
{"actor":{"display_login":"dlebrero"}}