{"action":"created","issue":{"url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090","repository_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl","labels_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090/labels{/name}","comments_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090/comments","events_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090/events","html_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090","id":290448837,"number":1090,"title":"DataFrames 0.11+ compat via IndirectArrays","user":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars3.githubusercontent.com/u/505001?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-01-22T12:28:37Z","updated_at":"2018-02-08T14:32:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/pulls/1090","html_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090","diff_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090.diff","patch_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090.patch"},"body":"@tlnagy Here is my version of the DataFrame 0.11+ compatible version. This version passes locally (see caveat below) with [this version of IndirectArrays](https://github.com/JuliaArrays/IndirectArrays.jl/pull/12). I decided that the wrapping behavior of CategoricalArrays was too inconvenient to get working with the current setup because it is implicitly assumed in most functions that \"categorical\" arrays return the same kand of values as non-categorical arrays. Maybe by restructuring the code to rely more on dispatch to smaller specialized methods it might be possible to use CategoricalArrays internally, but I'm not sure it is worth it. Basically, I don't think it is useful to have the `pool` handy for the use cases here in Gadfly.\r\n\r\nAlthough the tests pass, it requires that Julia runs with `--compilecache=no`. Otherwise, it triggers what appears to be completely spurious ambiguity errors that we'd need @vtjnash or @JeffBezanson to comment on. It is hard for me to narrow down the issue but it could be related to `module`/`using`/`include`. E.g. I can trigger/detrigger the issue by including a file where all lines are commented. I've also been able to trigger/detrigger it with a `foo() = 1` definition in the middle of the `statistics.jl` file."},"comment":{"url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/comments/364129042","html_url":"https://github.com/GiovineItalia/Gadfly.jl/pull/1090#issuecomment-364129042","issue_url":"https://api.github.com/repos/GiovineItalia/Gadfly.jl/issues/1090","id":364129042,"user":{"login":"kleinschmidt","id":135920,"avatar_url":"https://avatars0.githubusercontent.com/u/135920?v=4","gravatar_id":"","url":"https://api.github.com/users/kleinschmidt","html_url":"https://github.com/kleinschmidt","followers_url":"https://api.github.com/users/kleinschmidt/followers","following_url":"https://api.github.com/users/kleinschmidt/following{/other_user}","gists_url":"https://api.github.com/users/kleinschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinschmidt/subscriptions","organizations_url":"https://api.github.com/users/kleinschmidt/orgs","repos_url":"https://api.github.com/users/kleinschmidt/repos","events_url":"https://api.github.com/users/kleinschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/kleinschmidt/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T14:32:23Z","updated_at":"2018-02-08T14:32:23Z","author_association":"CONTRIBUTOR","body":"@nalimilan the problem with the figure I showed is that the labels on the facets (\\alpha=0.01, 0.1, 1, 10) are wrong.  with the PR they've been circshifted by one, while the facets are still plotted in the same order (just the labels have changed).  The values that are used to group the facets are a data frame column that's an `Array{String}`.\r\n\r\nI will look into this more later and figure out a minimal example but don't have time right at the moment."}}
{"actor":{"display_login":"kleinschmidt"}}