{"action":"created","comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/228016019","pull_request_review_id":168186959,"id":228016019,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODAxNjAxOQ==","diff_hunk":"@@ -1867,6 +1879,7 @@\n   [feature = 'man_made_storage_tank'][zoom >= 18],\n   [feature = 'man_made_silo'][zoom >= 18],\n   [feature = 'man_made_communications_tower'][zoom >= 17],\n+  [feature = 'man_made_telescope'][\"telescope:type\" = 'radio'][zoom >= 17],","path":"amenity-points.mss","position":23,"original_position":23,"commit_id":"32161b99665ed5e53fd77fbd55a555caa010d2a7","original_commit_id":"32161b99665ed5e53fd77fbd55a555caa010d2a7","user":{"login":"kocio-pl","id":5439713,"node_id":"MDQ6VXNlcjU0Mzk3MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"body":"I think you may make it safely z16+.","created_at":"2018-10-25T02:17:32Z","updated_at":"2018-10-25T02:17:56Z","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3473#discussion_r228016019","pull_request_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/228016019"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/3473#discussion_r228016019"},"pull_request":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473"}}},"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473","id":224692325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjkyMzI1","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3473","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3473.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3473.patch","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3473","number":3473,"state":"open","locked":false,"title":"Render man_made=telescope telescope:type=radio","user":{"login":"jeisenbe","id":42757252,"node_id":"MDQ6VXNlcjQyNzU3MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/42757252?v=4","gravatar_id":"","url":"https://api.github.com/users/jeisenbe","html_url":"https://github.com/jeisenbe","followers_url":"https://api.github.com/users/jeisenbe/followers","following_url":"https://api.github.com/users/jeisenbe/following{/other_user}","gists_url":"https://api.github.com/users/jeisenbe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeisenbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeisenbe/subscriptions","organizations_url":"https://api.github.com/users/jeisenbe/orgs","repos_url":"https://api.github.com/users/jeisenbe/repos","events_url":"https://api.github.com/users/jeisenbe/events{/privacy}","received_events_url":"https://api.github.com/users/jeisenbe/received_events","type":"User","site_admin":false},"body":"Related to #3389\r\n\r\n_Changes proposed in this pull request:_\r\n- Add rendering of radio telescopes:\r\n- Render man_made=telescope when telescope:type=radio with a radio telescope dish icon in man_made-gray color. \r\n\r\n_Test rendering with links to the example places:_\r\n\r\n**Mauna Kea, Hawaii at z17; nodes** [https://www.openstreetmap.org/#map=18/19.82366/-155.47612](https://www.openstreetmap.org/#map=17/19.82366/-155.47612)\r\n\r\n_Before_ \r\n![hawai-telescopes-before-z17](https://user-images.githubusercontent.com/42757252/47293956-9d4e2880-d646-11e8-8886-2b2d9b5eb28d.png)\r\n\r\n_After_ \r\n![](https://user-images.githubusercontent.com/42757252/47292455-fb2c4180-d641-11e8-9c92-e6668f86bb0e.png)\r\n\r\n\r\n**LOFAR Radio telescopes in Germany, closed ways, z17**\r\nhttps://www.openstreetmap.org/way/132557743\r\nhttps://www.openstreetmap.org/#map=17/50.8976057/6.4233260\r\n_Before_ \r\n![lofar-before](https://user-images.githubusercontent.com/42757252/47294547-6711a880-d648-11e8-9804-d7fdd397213c.png)\r\n\r\n_After_\r\n![](https://user-images.githubusercontent.com/42757252/47263800-8672dd80-d543-11e8-9006-3b4569499a04.png)\r\n\r\n\r\n**Radio telescopes in Cambridge, England; closed ways, z17:**\r\nhttps://www.openstreetmap.org/way/32733809\r\nhttps://www.openstreetmap.org/#map=17/52.1645763/0.0309299\r\n\r\n_Before_ \r\n![mrao-before](https://user-images.githubusercontent.com/42757252/47295242-27e45700-d64a-11e8-9e5a-8e0220cda686.png)\r\n\r\n_After_\r\n![](https://user-images.githubusercontent.com/42757252/47263773-eb7a0380-d542-11e8-8349-6a210c142a18.png)\r\n\r\nQuestions: \r\n1) Should initial zoom level be constant, or should it depend on telescope:diameter and waypixels?\r\n2) Should optical telescopes be included in this PR?","created_at":"2018-10-22T14:06:30Z","updated_at":"2018-10-25T02:17:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcd63ecceb3490d97273cbef836d839a01dc71fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473/commits","review_comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473/comments","review_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3473/comments","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/32161b99665ed5e53fd77fbd55a555caa010d2a7","head":{"label":"jeisenbe:telescope","ref":"telescope","sha":"32161b99665ed5e53fd77fbd55a555caa010d2a7","user":{"login":"jeisenbe","id":42757252,"node_id":"MDQ6VXNlcjQyNzU3MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/42757252?v=4","gravatar_id":"","url":"https://api.github.com/users/jeisenbe","html_url":"https://github.com/jeisenbe","followers_url":"https://api.github.com/users/jeisenbe/followers","following_url":"https://api.github.com/users/jeisenbe/following{/other_user}","gists_url":"https://api.github.com/users/jeisenbe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeisenbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeisenbe/subscriptions","organizations_url":"https://api.github.com/users/jeisenbe/orgs","repos_url":"https://api.github.com/users/jeisenbe/repos","events_url":"https://api.github.com/users/jeisenbe/events{/privacy}","received_events_url":"https://api.github.com/users/jeisenbe/received_events","type":"User","site_admin":false},"repo":{"id":148287701,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyODc3MDE=","name":"openstreetmap-carto","full_name":"jeisenbe/openstreetmap-carto","private":false,"owner":{"login":"jeisenbe","id":42757252,"node_id":"MDQ6VXNlcjQyNzU3MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/42757252?v=4","gravatar_id":"","url":"https://api.github.com/users/jeisenbe","html_url":"https://github.com/jeisenbe","followers_url":"https://api.github.com/users/jeisenbe/followers","following_url":"https://api.github.com/users/jeisenbe/following{/other_user}","gists_url":"https://api.github.com/users/jeisenbe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeisenbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeisenbe/subscriptions","organizations_url":"https://api.github.com/users/jeisenbe/orgs","repos_url":"https://api.github.com/users/jeisenbe/repos","events_url":"https://api.github.com/users/jeisenbe/events{/privacy}","received_events_url":"https://api.github.com/users/jeisenbe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeisenbe/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":true,"url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto","forks_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/deployments","created_at":"2018-09-11T08:46:23Z","updated_at":"2018-10-22T14:29:21Z","pushed_at":"2018-10-25T02:04:46Z","git_url":"git://github.com/jeisenbe/openstreetmap-carto.git","ssh_url":"git@github.com:jeisenbe/openstreetmap-carto.git","clone_url":"https://github.com/jeisenbe/openstreetmap-carto.git","svn_url":"https://github.com/jeisenbe/openstreetmap-carto","homepage":"","size":11969,"stargazers_count":0,"watchers_count":0,"language":"CartoCSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gravitystorm:master","ref":"master","sha":"7255fe71f704319b78f93f417c84838f69e8d311","user":{"login":"gravitystorm","id":360803,"node_id":"MDQ6VXNlcjM2MDgwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":6707453,"node_id":"MDEwOlJlcG9zaXRvcnk2NzA3NDUz","name":"openstreetmap-carto","full_name":"gravitystorm/openstreetmap-carto","private":false,"owner":{"login":"gravitystorm","id":360803,"node_id":"MDQ6VXNlcjM2MDgwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gravitystorm/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":false,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/deployments","created_at":"2012-11-15T16:06:16Z","updated_at":"2018-10-23T14:40:12Z","pushed_at":"2018-10-25T02:04:48Z","git_url":"git://github.com/gravitystorm/openstreetmap-carto.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-carto.git","clone_url":"https://github.com/gravitystorm/openstreetmap-carto.git","svn_url":"https://github.com/gravitystorm/openstreetmap-carto","homepage":"","size":11935,"stargazers_count":726,"watchers_count":726,"language":"CartoCSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":405,"open_issues":369,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/3473"},"issue":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3473"},"comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3473/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3473/commits"},"statuses":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/32161b99665ed5e53fd77fbd55a555caa010d2a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kocio-pl"}}