{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic-ui/pulls/comments/170298944","pull_request_review_id":98970163,"id":170298944,"diff_hunk":"@@ -1,103 +1,79 @@\n-# After any change to this file you MUST re-sign and checkin the .drone.yml.sig\n-# When you are ready to submit a pull request, you must regenerate .drone.yml.sig for the vmware/vic repo:\n-# $ export DRONE_SERVER=https://ci.vcna.io\n-# $ export DRONE_TOKEN=<token>\n-# $ drone sign vmware/vic-ui\n-# The secrets file is in our local git repo.  Ask mhagen for access.\n-\n----\n workspace:\n+\n   base: /go\n   path: src/github.com/vmware/vic-ui\n-\n pipeline:\n+\n   clone:\n     image: plugins/git\n     tags: true\n-    # dont clone submodules\n     recursive: false\n \n   vic-ui:\n-    image: gcr.io/eminent-nation-87317/vic-integration-test:1.36\n+    image: 'gcr.io/eminent-nation-87317/vic-integration-test:1.36'\n     pull: true\n     environment:\n-      BUILD_NUMBER: ${DRONE_BUILD_NUMBER}\n       BIN: bin\n-      GS_PROJECT_ID: ${GS_PROJECT_ID}\n-      GS_CLIENT_EMAIL: ${GS_CLIENT_EMAIL}\n-      GS_PRIVATE_KEY: ${GS_PRIVATE_KEY}\n+    secrets:\n+      - gs_client_email\n+      - gs_private_key\n+      - gs_project_id\n     commands:\n-      - make vic-ui-plugins\n+      - 'export BUILD_NUMBER=${DRONE_BUILD_NUMBER}'\n+      - 'make vic-ui-plugins'\n     when:\n       repo: vmware/vic-ui\n-      branch: [ master, releases/*, refs/tags/* ]\n+      branch: [master, 'releases/*', 'refs/tags/*']\n \n   bundle:\n-    image: gcr.io/eminent-nation-87317/vic-integration-test:1.36\n+    image: 'gcr.io/eminent-nation-87317/vic-integration-test:1.36'\n     pull: true\n     environment:\n       BIN: bin\n       GOPATH: /go\n       SHELL: /bin/bash\n     commands:\n-      - mkdir -p $BIN/ui\n-      - tar -czvf $BIN/vic_ui_${DRONE_BUILD_NUMBER}.tar.gz $BIN/ui\n-      - mkdir bundle\n-      - mkdir bundle-release\n-      - cp $BIN/vic_ui_${DRONE_BUILD_NUMBER}.tar.gz bundle\n-      - cp $BIN/vic_ui_${DRONE_BUILD_NUMBER}.tar.gz bundle-release/vic_ui_`git describe --tags $(git rev-list --tags --max-count=1)`.tar.gz\n-      - rm -rf $BIN\n-      - ls -la bundle\n+      - 'mkdir -p $BIN/ui'\n+      - 'tar -czvf $BIN/vic_ui_${DRONE_BUILD_NUMBER}.tar.gz $BIN/ui'\n+      - 'mkdir bundle'\n+      - 'mkdir bundle-release'\n+      - 'cp $BIN/vic_ui_${DRONE_BUILD_NUMBER}.tar.gz bundle'\n+      - 'cp $BIN/vic_ui_${DRONE_BUILD_NUMBER}.tar.gz bundle-release/vic_ui_`git describe --tags $(git rev-list --tags --max-count=1)`.tar.gz'\n+      - 'rm -rf $BIN'\n+      - 'ls -la bundle'\n     when:\n       repo: vmware/vic-ui\n-      event: [ push, tag ]\n-      branch: [ master, releases/*, refs/tags/* ]\n+      event: [push, tag]\n+      branch: [master, 'releases/*', 'refs/tags/*']\n \n   publish-gcs-builds-on-pass:\n-    image: maplain/drone-gcs:latest\n+    image: 'maplain/drone-gcs:latest'\n     pull: true\n     source: bundle\n     target: vic-ui-builds\n     acl:\n-      - allUsers:READER\n-    cache_control: public,max-age=3600\n+      - 'allUsers:READER'\n+    cache_control: 'public,max-age=3600'\n     when:\n       repo: vmware/vic-ui\n-      event: [ push ]\n-      branch: [ master, releases/* ]\n+      event: [push]\n+      branch: [master, 'releases/*']\n       status: success\n \n   publish-gcs-releases:\n-    image: maplain/drone-gcs:latest\n+    image: 'maplain/drone-gcs:latest'\n     pull: true\n     source: bundle-release\n     target: vic-ui-releases\n     acl:\n-      - allUsers:READER\n-    cache_control: public,max-age=3600\n+      - 'allUsers:READER'\n+    cache_control: 'public,max-age=3600'\n     when:\n       repo: vmware/vic-ui\n-      event: [ push, tag ]\n-      branch: [ refs/tags/* ]\n+      event: [push, tag]\n+      branch: ['refs/tags/*']\n       status: success\n \n-  report-coverage:","path":".drone.yml","position":115,"original_position":115,"commit_id":"b8121ba93446ff6ba7df7474748befb38523a78c","original_commit_id":"b8121ba93446ff6ba7df7474748befb38523a78c","user":{"login":"mdharamadas1","id":30418983,"avatar_url":"https://avatars2.githubusercontent.com/u/30418983?v=4","gravatar_id":"","url":"https://api.github.com/users/mdharamadas1","html_url":"https://github.com/mdharamadas1","followers_url":"https://api.github.com/users/mdharamadas1/followers","following_url":"https://api.github.com/users/mdharamadas1/following{/other_user}","gists_url":"https://api.github.com/users/mdharamadas1/gists{/gist_id}","starred_url":"https://api.github.com/users/mdharamadas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdharamadas1/subscriptions","organizations_url":"https://api.github.com/users/mdharamadas1/orgs","repos_url":"https://api.github.com/users/mdharamadas1/repos","events_url":"https://api.github.com/users/mdharamadas1/events{/privacy}","received_events_url":"https://api.github.com/users/mdharamadas1/received_events","type":"User","site_admin":false},"body":"That seems like a mistake, I will add it back.","created_at":"2018-02-23T16:30:54Z","updated_at":"2018-02-23T16:30:54Z","html_url":"https://github.com/vmware/vic-ui/pull/373#discussion_r170298944","pull_request_url":"https://api.github.com/repos/vmware/vic-ui/pulls/373","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic-ui/pulls/comments/170298944"},"html":{"href":"https://github.com/vmware/vic-ui/pull/373#discussion_r170298944"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic-ui/pulls/373"}},"in_reply_to_id":170297333},"pull_request":{"url":"https://api.github.com/repos/vmware/vic-ui/pulls/373","id":170847167,"html_url":"https://github.com/vmware/vic-ui/pull/373","diff_url":"https://github.com/vmware/vic-ui/pull/373.diff","patch_url":"https://github.com/vmware/vic-ui/pull/373.patch","issue_url":"https://api.github.com/repos/vmware/vic-ui/issues/373","number":373,"state":"open","locked":false,"title":"Drone 08 changes","user":{"login":"mdharamadas1","id":30418983,"avatar_url":"https://avatars2.githubusercontent.com/u/30418983?v=4","gravatar_id":"","url":"https://api.github.com/users/mdharamadas1","html_url":"https://github.com/mdharamadas1","followers_url":"https://api.github.com/users/mdharamadas1/followers","following_url":"https://api.github.com/users/mdharamadas1/following{/other_user}","gists_url":"https://api.github.com/users/mdharamadas1/gists{/gist_id}","starred_url":"https://api.github.com/users/mdharamadas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdharamadas1/subscriptions","organizations_url":"https://api.github.com/users/mdharamadas1/orgs","repos_url":"https://api.github.com/users/mdharamadas1/repos","events_url":"https://api.github.com/users/mdharamadas1/events{/privacy}","received_events_url":"https://api.github.com/users/mdharamadas1/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/vmware/vic-ui/issues/356\r\n\r\nThis will be merged only after new drone is active.","created_at":"2018-02-22T19:43:41Z","updated_at":"2018-02-23T16:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbe74ee4b3f53189187cbdbc2efad938227d2a7e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jooskim","id":3834071,"avatar_url":"https://avatars1.githubusercontent.com/u/3834071?v=4","gravatar_id":"","url":"https://api.github.com/users/jooskim","html_url":"https://github.com/jooskim","followers_url":"https://api.github.com/users/jooskim/followers","following_url":"https://api.github.com/users/jooskim/following{/other_user}","gists_url":"https://api.github.com/users/jooskim/gists{/gist_id}","starred_url":"https://api.github.com/users/jooskim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooskim/subscriptions","organizations_url":"https://api.github.com/users/jooskim/orgs","repos_url":"https://api.github.com/users/jooskim/repos","events_url":"https://api.github.com/users/jooskim/events{/privacy}","received_events_url":"https://api.github.com/users/jooskim/received_events","type":"User","site_admin":false},{"login":"mhagen-vmware","id":19393273,"avatar_url":"https://avatars0.githubusercontent.com/u/19393273?v=4","gravatar_id":"","url":"https://api.github.com/users/mhagen-vmware","html_url":"https://github.com/mhagen-vmware","followers_url":"https://api.github.com/users/mhagen-vmware/followers","following_url":"https://api.github.com/users/mhagen-vmware/following{/other_user}","gists_url":"https://api.github.com/users/mhagen-vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/mhagen-vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhagen-vmware/subscriptions","organizations_url":"https://api.github.com/users/mhagen-vmware/orgs","repos_url":"https://api.github.com/users/mhagen-vmware/repos","events_url":"https://api.github.com/users/mhagen-vmware/events{/privacy}","received_events_url":"https://api.github.com/users/mhagen-vmware/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":711710575,"url":"https://api.github.com/repos/vmware/vic-ui/labels/cla-not-required","name":"cla-not-required","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic-ui/pulls/373/commits","review_comments_url":"https://api.github.com/repos/vmware/vic-ui/pulls/373/comments","review_comment_url":"https://api.github.com/repos/vmware/vic-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic-ui/issues/373/comments","statuses_url":"https://api.github.com/repos/vmware/vic-ui/statuses/b8121ba93446ff6ba7df7474748befb38523a78c","head":{"label":"mdharamadas1:feature/drone-haas-updates","ref":"feature/drone-haas-updates","sha":"b8121ba93446ff6ba7df7474748befb38523a78c","user":{"login":"mdharamadas1","id":30418983,"avatar_url":"https://avatars2.githubusercontent.com/u/30418983?v=4","gravatar_id":"","url":"https://api.github.com/users/mdharamadas1","html_url":"https://github.com/mdharamadas1","followers_url":"https://api.github.com/users/mdharamadas1/followers","following_url":"https://api.github.com/users/mdharamadas1/following{/other_user}","gists_url":"https://api.github.com/users/mdharamadas1/gists{/gist_id}","starred_url":"https://api.github.com/users/mdharamadas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdharamadas1/subscriptions","organizations_url":"https://api.github.com/users/mdharamadas1/orgs","repos_url":"https://api.github.com/users/mdharamadas1/repos","events_url":"https://api.github.com/users/mdharamadas1/events{/privacy}","received_events_url":"https://api.github.com/users/mdharamadas1/received_events","type":"User","site_admin":false},"repo":{"id":105923228,"name":"vic-ui","full_name":"mdharamadas1/vic-ui","owner":{"login":"mdharamadas1","id":30418983,"avatar_url":"https://avatars2.githubusercontent.com/u/30418983?v=4","gravatar_id":"","url":"https://api.github.com/users/mdharamadas1","html_url":"https://github.com/mdharamadas1","followers_url":"https://api.github.com/users/mdharamadas1/followers","following_url":"https://api.github.com/users/mdharamadas1/following{/other_user}","gists_url":"https://api.github.com/users/mdharamadas1/gists{/gist_id}","starred_url":"https://api.github.com/users/mdharamadas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdharamadas1/subscriptions","organizations_url":"https://api.github.com/users/mdharamadas1/orgs","repos_url":"https://api.github.com/users/mdharamadas1/repos","events_url":"https://api.github.com/users/mdharamadas1/events{/privacy}","received_events_url":"https://api.github.com/users/mdharamadas1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdharamadas1/vic-ui","description":"Integrated containers UI for vSphere","fork":true,"url":"https://api.github.com/repos/mdharamadas1/vic-ui","forks_url":"https://api.github.com/repos/mdharamadas1/vic-ui/forks","keys_url":"https://api.github.com/repos/mdharamadas1/vic-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdharamadas1/vic-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdharamadas1/vic-ui/teams","hooks_url":"https://api.github.com/repos/mdharamadas1/vic-ui/hooks","issue_events_url":"https://api.github.com/repos/mdharamadas1/vic-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mdharamadas1/vic-ui/events","assignees_url":"https://api.github.com/repos/mdharamadas1/vic-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mdharamadas1/vic-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mdharamadas1/vic-ui/tags","blobs_url":"https://api.github.com/repos/mdharamadas1/vic-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdharamadas1/vic-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdharamadas1/vic-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdharamadas1/vic-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdharamadas1/vic-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mdharamadas1/vic-ui/languages","stargazers_url":"https://api.github.com/repos/mdharamadas1/vic-ui/stargazers","contributors_url":"https://api.github.com/repos/mdharamadas1/vic-ui/contributors","subscribers_url":"https://api.github.com/repos/mdharamadas1/vic-ui/subscribers","subscription_url":"https://api.github.com/repos/mdharamadas1/vic-ui/subscription","commits_url":"https://api.github.com/repos/mdharamadas1/vic-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdharamadas1/vic-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdharamadas1/vic-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdharamadas1/vic-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdharamadas1/vic-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mdharamadas1/vic-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdharamadas1/vic-ui/merges","archive_url":"https://api.github.com/repos/mdharamadas1/vic-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdharamadas1/vic-ui/downloads","issues_url":"https://api.github.com/repos/mdharamadas1/vic-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mdharamadas1/vic-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mdharamadas1/vic-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mdharamadas1/vic-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdharamadas1/vic-ui/labels{/name}","releases_url":"https://api.github.com/repos/mdharamadas1/vic-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mdharamadas1/vic-ui/deployments","created_at":"2017-10-05T18:06:03Z","updated_at":"2017-10-05T18:06:06Z","pushed_at":"2018-02-22T19:41:33Z","git_url":"git://github.com/mdharamadas1/vic-ui.git","ssh_url":"git@github.com:mdharamadas1/vic-ui.git","clone_url":"https://github.com/mdharamadas1/vic-ui.git","svn_url":"https://github.com/mdharamadas1/vic-ui","homepage":null,"size":58449,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"85e5bed849fd9b22ea95e556f04db14e45600c2c","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":105315732,"name":"vic-ui","full_name":"vmware/vic-ui","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic-ui","description":"Integrated containers UI for vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic-ui","forks_url":"https://api.github.com/repos/vmware/vic-ui/forks","keys_url":"https://api.github.com/repos/vmware/vic-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic-ui/teams","hooks_url":"https://api.github.com/repos/vmware/vic-ui/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic-ui/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic-ui/events","assignees_url":"https://api.github.com/repos/vmware/vic-ui/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic-ui/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic-ui/tags","blobs_url":"https://api.github.com/repos/vmware/vic-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic-ui/languages","stargazers_url":"https://api.github.com/repos/vmware/vic-ui/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic-ui/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic-ui/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic-ui/subscription","commits_url":"https://api.github.com/repos/vmware/vic-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic-ui/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic-ui/merges","archive_url":"https://api.github.com/repos/vmware/vic-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic-ui/downloads","issues_url":"https://api.github.com/repos/vmware/vic-ui/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic-ui/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic-ui/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic-ui/deployments","created_at":"2017-09-29T20:46:59Z","updated_at":"2018-02-22T21:42:53Z","pushed_at":"2018-02-22T23:07:51Z","git_url":"git://github.com/vmware/vic-ui.git","ssh_url":"git@github.com:vmware/vic-ui.git","clone_url":"https://github.com/vmware/vic-ui.git","svn_url":"https://github.com/vmware/vic-ui","homepage":null,"size":58630,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":59,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic-ui/pulls/373"},"html":{"href":"https://github.com/vmware/vic-ui/pull/373"},"issue":{"href":"https://api.github.com/repos/vmware/vic-ui/issues/373"},"comments":{"href":"https://api.github.com/repos/vmware/vic-ui/issues/373/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic-ui/pulls/373/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic-ui/pulls/373/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic-ui/statuses/b8121ba93446ff6ba7df7474748befb38523a78c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mdharamadas1"}}