{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/235222140","pull_request_review_id":177036553,"id":235222140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTIyMjE0MA==","diff_hunk":"@@ -31,7 +31,13 @@ buildScan {\n     licenseAgree = 'yes'\n }\n \n-String hailVersion = \"0.2\"\n+// Hail has three notions of version:\n+//  - hail short version: MAJOR.MINOR\n+//  - hail pip version: MAJOR.MINOR.PATCH\n+//  - hail version: MAJOR.MINOR.PATCH-GIT_SHA, calculated by generateBuildInfo\n+String hailShortVersion = \"0.2\"\n+// By default pip hides versions ending in \".devN\". Use these for testing.\n+String hailPipVersion = hailShortVersion + \".4\" + System.getProperty(\"hail.pip-version-suffix\", \"\")","path":"hail/build.gradle","position":11,"original_position":11,"commit_id":"0141847027c0c9f2e6d3b209e3b0e75533960cbd","original_commit_id":"0141847027c0c9f2e6d3b209e3b0e75533960cbd","user":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"I don't like calling it \"pip version\". This is the full Major.Minor.Patch version of Hail, whether we deploy it to pip or conda or wherever.","created_at":"2018-11-21T00:53:29Z","updated_at":"2018-11-21T00:59:07Z","html_url":"https://github.com/hail-is/hail/pull/4812#discussion_r235222140","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/4812","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/235222140"},"html":{"href":"https://github.com/hail-is/hail/pull/4812#discussion_r235222140"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4812"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/4812","id":232463824,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDYzODI0","html_url":"https://github.com/hail-is/hail/pull/4812","diff_url":"https://github.com/hail-is/hail/pull/4812.diff","patch_url":"https://github.com/hail-is/hail/pull/4812.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/4812","number":4812,"state":"open","locked":false,"title":"[hail] make Hail PyPI deployment robust","user":{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"body":"Changes\r\n---\r\n - introduce consistent naming of the three types of hail versions (see\r\n   build.gradle comment)\r\n\r\n - add `hail_pip_version` to `_generated_version_info.py` which is used by\r\n   `setup.py`\r\n\r\n - add `hail/python/deploy.sh` which should not be called directly but handles\r\n   generated PYPI compatible packages and uploading to PYPI\r\n\r\n - `generate-build-info.sh` is now the *only* authoritative source on hail\r\n   versioning (it generates *exactly* two files, one for JARs and one for the\r\n   python library)\r\n\r\n - fix: actually activate the anonymous conda env in `hail-ci-build.sh`'s \r\n   pip test\r\n\r\nJanitorial\r\n---\r\n - ignore python/hail.egg-info\r\n\r\n - sort lines in hail/.gitignore\r\n\r\n - add `hail/python/hail/docs/__init__.py` so that we can use relative imports\r\n   in `conf.py`\r\n\r\n - remove commented out code in makeDocs.sh\r\n\r\n - makeDocs.sh now has `set -x`\r\n\r\nNotes\r\n---\r\n\r\nYou can test deployment locally with:\r\n\r\n```\r\nHAIL_TWINE_CREDS_FOLDER=/path/to/twine/creds ./gradlew deploy -D hail.pip-version-suffix=.devN\r\n```\r\nwhere `.devN` is some currently unused dev version suffix. You can check these by running `python hail/list_pypi_versions.py hail`. These dev versions are not visible to end users.","created_at":"2018-11-20T21:24:53Z","updated_at":"2018-11-21T00:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b64e5fa87cf2427cef39478851526bf99e6fff12","assignee":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"assignees":[{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/4812/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/4812/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/4812/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/0141847027c0c9f2e6d3b209e3b0e75533960cbd","head":{"label":"danking:robust-deployment","ref":"robust-deployment","sha":"0141847027c0c9f2e6d3b209e3b0e75533960cbd","user":{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"repo":{"id":64700952,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwMDk1Mg==","name":"hail","full_name":"danking/hail","private":false,"owner":{"login":"danking","id":106194,"node_id":"MDQ6VXNlcjEwNjE5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danking/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/danking/hail","forks_url":"https://api.github.com/repos/danking/hail/forks","keys_url":"https://api.github.com/repos/danking/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danking/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danking/hail/teams","hooks_url":"https://api.github.com/repos/danking/hail/hooks","issue_events_url":"https://api.github.com/repos/danking/hail/issues/events{/number}","events_url":"https://api.github.com/repos/danking/hail/events","assignees_url":"https://api.github.com/repos/danking/hail/assignees{/user}","branches_url":"https://api.github.com/repos/danking/hail/branches{/branch}","tags_url":"https://api.github.com/repos/danking/hail/tags","blobs_url":"https://api.github.com/repos/danking/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danking/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danking/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/danking/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danking/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/danking/hail/languages","stargazers_url":"https://api.github.com/repos/danking/hail/stargazers","contributors_url":"https://api.github.com/repos/danking/hail/contributors","subscribers_url":"https://api.github.com/repos/danking/hail/subscribers","subscription_url":"https://api.github.com/repos/danking/hail/subscription","commits_url":"https://api.github.com/repos/danking/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/danking/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/danking/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/danking/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/danking/hail/contents/{+path}","compare_url":"https://api.github.com/repos/danking/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danking/hail/merges","archive_url":"https://api.github.com/repos/danking/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danking/hail/downloads","issues_url":"https://api.github.com/repos/danking/hail/issues{/number}","pulls_url":"https://api.github.com/repos/danking/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/danking/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/danking/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danking/hail/labels{/name}","releases_url":"https://api.github.com/repos/danking/hail/releases{/id}","deployments_url":"https://api.github.com/repos/danking/hail/deployments","created_at":"2016-08-01T20:55:06Z","updated_at":"2018-09-27T19:23:31Z","pushed_at":"2018-11-21T00:10:15Z","git_url":"git://github.com/danking/hail.git","ssh_url":"git@github.com:danking/hail.git","clone_url":"https://github.com/danking/hail.git","svn_url":"https://github.com/danking/hail","homepage":"","size":50422,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"c61cc02df9e21ccf9460c40ed5de097f7ef5f683","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-11-20T23:58:39Z","pushed_at":"2018-11-21T00:25:55Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":46132,"stargazers_count":404,"watchers_count":404,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":115,"open_issues":149,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4812"},"html":{"href":"https://github.com/hail-is/hail/pull/4812"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/4812"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/4812/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4812/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4812/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/0141847027c0c9f2e6d3b209e3b0e75533960cbd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tpoterba"}}