{"action":"created","comment":{"url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/comments/174117909","pull_request_review_id":103414749,"id":174117909,"diff_hunk":"@@ -256,11 +256,9 @@ def instantiate_store(addresses = nil)\n \n     def with_notifications\n       @events = [ ]\n-      ActiveSupport::Cache::FaultTolerantRedisStore.instrument = true\n       ActiveSupport::Notifications.subscribe(/^cache_(.*)\\.active_support$/) do |*args|\n         @events << ActiveSupport::Notifications::Event.new(*args)\n       end\n       yield\n-      ActiveSupport::Cache::FaultTolerantRedisStore.instrument = false","path":"test/active_support/cache/redis_store_test.rb","position":9,"original_position":9,"commit_id":"5b2559ea9018c33608b5f1785ee3291ee98b1d9d","original_commit_id":"5b2559ea9018c33608b5f1785ee3291ee98b1d9d","user":{"login":"romansklenar","id":153201,"avatar_url":"https://avatars0.githubusercontent.com/u/153201?v=4","gravatar_id":"","url":"https://api.github.com/users/romansklenar","html_url":"https://github.com/romansklenar","followers_url":"https://api.github.com/users/romansklenar/followers","following_url":"https://api.github.com/users/romansklenar/following{/other_user}","gists_url":"https://api.github.com/users/romansklenar/gists{/gist_id}","starred_url":"https://api.github.com/users/romansklenar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansklenar/subscriptions","organizations_url":"https://api.github.com/users/romansklenar/orgs","repos_url":"https://api.github.com/users/romansklenar/repos","events_url":"https://api.github.com/users/romansklenar/events{/privacy}","received_events_url":"https://api.github.com/users/romansklenar/received_events","type":"User","site_admin":false},"body":"Gets rid of\r\n```\r\nDEPRECATION WARNING: ActiveSupport::Cache.instrument= is deprecated and will be removed in Rails 5. Instrumentation is now always on so you can safely stop using it. (called from with_notifications at /Users/roman/Projects/gwi/redis-activesupport/test/active_support/cache/redis_store_test.rb:259)\r\nDEPRECATION WARNING: ActiveSupport::Cache.instrument= is deprecated and will be removed in Rails 5. Instrumentation is now always on so you can safely stop using it. (called from with_notifications at /Users/roman/Projects/gwi/redis-activesupport/test/active_support/cache/redis_store_test.rb:264)\r\n```","created_at":"2018-03-13T12:56:21Z","updated_at":"2018-03-13T12:56:21Z","html_url":"https://github.com/GlobalWebIndex/redis-activesupport/pull/3#discussion_r174117909","pull_request_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/comments/174117909"},"html":{"href":"https://github.com/GlobalWebIndex/redis-activesupport/pull/3#discussion_r174117909"},"pull_request":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3","id":174649125,"html_url":"https://github.com/GlobalWebIndex/redis-activesupport/pull/3","diff_url":"https://github.com/GlobalWebIndex/redis-activesupport/pull/3.diff","patch_url":"https://github.com/GlobalWebIndex/redis-activesupport/pull/3.patch","issue_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues/3","number":3,"state":"open","locked":false,"title":"Fix vulnerability in redis-store dependency","user":{"login":"romansklenar","id":153201,"avatar_url":"https://avatars0.githubusercontent.com/u/153201?v=4","gravatar_id":"","url":"https://api.github.com/users/romansklenar","html_url":"https://github.com/romansklenar","followers_url":"https://api.github.com/users/romansklenar/followers","following_url":"https://api.github.com/users/romansklenar/following{/other_user}","gists_url":"https://api.github.com/users/romansklenar/gists{/gist_id}","starred_url":"https://api.github.com/users/romansklenar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansklenar/subscriptions","organizations_url":"https://api.github.com/users/romansklenar/orgs","repos_url":"https://api.github.com/users/romansklenar/repos","events_url":"https://api.github.com/users/romansklenar/events{/privacy}","received_events_url":"https://api.github.com/users/romansklenar/received_events","type":"User","site_admin":false},"body":"![screen shot 2018-03-13 at 13 47 54](https://user-images.githubusercontent.com/153201/37342542-2755bfac-26c5-11e8-8a6a-1f8a98005aaa.png)\r\n\r\nSee details: https://nvd.nist.gov/vuln/detail/CVE-2017-1000248","created_at":"2018-03-13T12:48:38Z","updated_at":"2018-03-13T12:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71e64bc9916d5dd7fbb7d785b409032a6c77b76f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3/commits","review_comments_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3/comments","review_comment_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues/3/comments","statuses_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/statuses/5b2559ea9018c33608b5f1785ee3291ee98b1d9d","head":{"label":"romansklenar:fix/vulnerability-in-redis-store","ref":"fix/vulnerability-in-redis-store","sha":"5b2559ea9018c33608b5f1785ee3291ee98b1d9d","user":{"login":"romansklenar","id":153201,"avatar_url":"https://avatars0.githubusercontent.com/u/153201?v=4","gravatar_id":"","url":"https://api.github.com/users/romansklenar","html_url":"https://github.com/romansklenar","followers_url":"https://api.github.com/users/romansklenar/followers","following_url":"https://api.github.com/users/romansklenar/following{/other_user}","gists_url":"https://api.github.com/users/romansklenar/gists{/gist_id}","starred_url":"https://api.github.com/users/romansklenar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansklenar/subscriptions","organizations_url":"https://api.github.com/users/romansklenar/orgs","repos_url":"https://api.github.com/users/romansklenar/repos","events_url":"https://api.github.com/users/romansklenar/events{/privacy}","received_events_url":"https://api.github.com/users/romansklenar/received_events","type":"User","site_admin":false},"repo":{"id":111712144,"name":"redis-activesupport","full_name":"romansklenar/redis-activesupport","owner":{"login":"romansklenar","id":153201,"avatar_url":"https://avatars0.githubusercontent.com/u/153201?v=4","gravatar_id":"","url":"https://api.github.com/users/romansklenar","html_url":"https://github.com/romansklenar","followers_url":"https://api.github.com/users/romansklenar/followers","following_url":"https://api.github.com/users/romansklenar/following{/other_user}","gists_url":"https://api.github.com/users/romansklenar/gists{/gist_id}","starred_url":"https://api.github.com/users/romansklenar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansklenar/subscriptions","organizations_url":"https://api.github.com/users/romansklenar/orgs","repos_url":"https://api.github.com/users/romansklenar/repos","events_url":"https://api.github.com/users/romansklenar/events{/privacy}","received_events_url":"https://api.github.com/users/romansklenar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romansklenar/redis-activesupport","description":"Redis stores for ActiveSupport","fork":true,"url":"https://api.github.com/repos/romansklenar/redis-activesupport","forks_url":"https://api.github.com/repos/romansklenar/redis-activesupport/forks","keys_url":"https://api.github.com/repos/romansklenar/redis-activesupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romansklenar/redis-activesupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romansklenar/redis-activesupport/teams","hooks_url":"https://api.github.com/repos/romansklenar/redis-activesupport/hooks","issue_events_url":"https://api.github.com/repos/romansklenar/redis-activesupport/issues/events{/number}","events_url":"https://api.github.com/repos/romansklenar/redis-activesupport/events","assignees_url":"https://api.github.com/repos/romansklenar/redis-activesupport/assignees{/user}","branches_url":"https://api.github.com/repos/romansklenar/redis-activesupport/branches{/branch}","tags_url":"https://api.github.com/repos/romansklenar/redis-activesupport/tags","blobs_url":"https://api.github.com/repos/romansklenar/redis-activesupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romansklenar/redis-activesupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romansklenar/redis-activesupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/romansklenar/redis-activesupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romansklenar/redis-activesupport/statuses/{sha}","languages_url":"https://api.github.com/repos/romansklenar/redis-activesupport/languages","stargazers_url":"https://api.github.com/repos/romansklenar/redis-activesupport/stargazers","contributors_url":"https://api.github.com/repos/romansklenar/redis-activesupport/contributors","subscribers_url":"https://api.github.com/repos/romansklenar/redis-activesupport/subscribers","subscription_url":"https://api.github.com/repos/romansklenar/redis-activesupport/subscription","commits_url":"https://api.github.com/repos/romansklenar/redis-activesupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/romansklenar/redis-activesupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/romansklenar/redis-activesupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/romansklenar/redis-activesupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/romansklenar/redis-activesupport/contents/{+path}","compare_url":"https://api.github.com/repos/romansklenar/redis-activesupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romansklenar/redis-activesupport/merges","archive_url":"https://api.github.com/repos/romansklenar/redis-activesupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romansklenar/redis-activesupport/downloads","issues_url":"https://api.github.com/repos/romansklenar/redis-activesupport/issues{/number}","pulls_url":"https://api.github.com/repos/romansklenar/redis-activesupport/pulls{/number}","milestones_url":"https://api.github.com/repos/romansklenar/redis-activesupport/milestones{/number}","notifications_url":"https://api.github.com/repos/romansklenar/redis-activesupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romansklenar/redis-activesupport/labels{/name}","releases_url":"https://api.github.com/repos/romansklenar/redis-activesupport/releases{/id}","deployments_url":"https://api.github.com/repos/romansklenar/redis-activesupport/deployments","created_at":"2017-11-22T17:13:52Z","updated_at":"2017-11-22T17:13:54Z","pushed_at":"2018-03-13T12:55:56Z","git_url":"git://github.com/romansklenar/redis-activesupport.git","ssh_url":"git@github.com:romansklenar/redis-activesupport.git","clone_url":"https://github.com/romansklenar/redis-activesupport.git","svn_url":"https://github.com/romansklenar/redis-activesupport","homepage":"http://redis-store.org/redis-activesupport","size":77,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GlobalWebIndex:master","ref":"master","sha":"db9916a6a422b12afcc331dcec5c779ce80cb940","user":{"login":"GlobalWebIndex","id":6952372,"avatar_url":"https://avatars1.githubusercontent.com/u/6952372?v=4","gravatar_id":"","url":"https://api.github.com/users/GlobalWebIndex","html_url":"https://github.com/GlobalWebIndex","followers_url":"https://api.github.com/users/GlobalWebIndex/followers","following_url":"https://api.github.com/users/GlobalWebIndex/following{/other_user}","gists_url":"https://api.github.com/users/GlobalWebIndex/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalWebIndex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalWebIndex/subscriptions","organizations_url":"https://api.github.com/users/GlobalWebIndex/orgs","repos_url":"https://api.github.com/users/GlobalWebIndex/repos","events_url":"https://api.github.com/users/GlobalWebIndex/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalWebIndex/received_events","type":"Organization","site_admin":false},"repo":{"id":46267362,"name":"redis-activesupport","full_name":"GlobalWebIndex/redis-activesupport","owner":{"login":"GlobalWebIndex","id":6952372,"avatar_url":"https://avatars1.githubusercontent.com/u/6952372?v=4","gravatar_id":"","url":"https://api.github.com/users/GlobalWebIndex","html_url":"https://github.com/GlobalWebIndex","followers_url":"https://api.github.com/users/GlobalWebIndex/followers","following_url":"https://api.github.com/users/GlobalWebIndex/following{/other_user}","gists_url":"https://api.github.com/users/GlobalWebIndex/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalWebIndex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalWebIndex/subscriptions","organizations_url":"https://api.github.com/users/GlobalWebIndex/orgs","repos_url":"https://api.github.com/users/GlobalWebIndex/repos","events_url":"https://api.github.com/users/GlobalWebIndex/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalWebIndex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GlobalWebIndex/redis-activesupport","description":"Redis stores for ActiveSupport","fork":true,"url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport","forks_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/forks","keys_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/teams","hooks_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/hooks","issue_events_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues/events{/number}","events_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/events","assignees_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/assignees{/user}","branches_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/branches{/branch}","tags_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/tags","blobs_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/statuses/{sha}","languages_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/languages","stargazers_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/stargazers","contributors_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/contributors","subscribers_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/subscribers","subscription_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/subscription","commits_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/contents/{+path}","compare_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/merges","archive_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/downloads","issues_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues{/number}","pulls_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls{/number}","milestones_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/milestones{/number}","notifications_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/labels{/name}","releases_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/releases{/id}","deployments_url":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/deployments","created_at":"2015-11-16T10:18:40Z","updated_at":"2017-11-22T17:42:36Z","pushed_at":"2018-03-13T12:55:57Z","git_url":"git://github.com/GlobalWebIndex/redis-activesupport.git","ssh_url":"git@github.com:GlobalWebIndex/redis-activesupport.git","clone_url":"https://github.com/GlobalWebIndex/redis-activesupport.git","svn_url":"https://github.com/GlobalWebIndex/redis-activesupport","homepage":"http://redis-store.org/redis-activesupport","size":81,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3"},"html":{"href":"https://github.com/GlobalWebIndex/redis-activesupport/pull/3"},"issue":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues/3"},"comments":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/GlobalWebIndex/redis-activesupport/statuses/5b2559ea9018c33608b5f1785ee3291ee98b1d9d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"romansklenar"}}