{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/wwylele/teakra/pulls/21","id":237285011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Mjg1MDEx","html_url":"https://github.com/wwylele/teakra/pull/21","diff_url":"https://github.com/wwylele/teakra/pull/21.diff","patch_url":"https://github.com/wwylele/teakra/pull/21.patch","issue_url":"https://api.github.com/repos/wwylele/teakra/issues/21","number":21,"state":"closed","locked":false,"title":"test_generator: Remove unused std::random_device instance in GenerateRandomState()","user":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"This is unused, but given it's static (and non-trivial), a compiler cannot remove this instance through dead-code elimination, so this was potentially still opening another file descriptor on the system.","created_at":"2018-12-10T11:24:15Z","updated_at":"2018-12-10T14:46:40Z","closed_at":"2018-12-10T14:46:40Z","merged_at":"2018-12-10T14:46:40Z","merge_commit_sha":"3a531748f4fee4c3d8261bc3c2bb28b60227e40d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wwylele/teakra/pulls/21/commits","review_comments_url":"https://api.github.com/repos/wwylele/teakra/pulls/21/comments","review_comment_url":"https://api.github.com/repos/wwylele/teakra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wwylele/teakra/issues/21/comments","statuses_url":"https://api.github.com/repos/wwylele/teakra/statuses/6653a3a43258bc7142778b1ed61d919429bd14c2","head":{"label":"lioncash:unused","ref":"unused","sha":"6653a3a43258bc7142778b1ed61d919429bd14c2","user":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"repo":{"id":119696330,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2OTYzMzA=","name":"teakra","full_name":"lioncash/teakra","private":false,"owner":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lioncash/teakra","description":"My playground of 3DS DSP","fork":true,"url":"https://api.github.com/repos/lioncash/teakra","forks_url":"https://api.github.com/repos/lioncash/teakra/forks","keys_url":"https://api.github.com/repos/lioncash/teakra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lioncash/teakra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lioncash/teakra/teams","hooks_url":"https://api.github.com/repos/lioncash/teakra/hooks","issue_events_url":"https://api.github.com/repos/lioncash/teakra/issues/events{/number}","events_url":"https://api.github.com/repos/lioncash/teakra/events","assignees_url":"https://api.github.com/repos/lioncash/teakra/assignees{/user}","branches_url":"https://api.github.com/repos/lioncash/teakra/branches{/branch}","tags_url":"https://api.github.com/repos/lioncash/teakra/tags","blobs_url":"https://api.github.com/repos/lioncash/teakra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lioncash/teakra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lioncash/teakra/git/refs{/sha}","trees_url":"https://api.github.com/repos/lioncash/teakra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lioncash/teakra/statuses/{sha}","languages_url":"https://api.github.com/repos/lioncash/teakra/languages","stargazers_url":"https://api.github.com/repos/lioncash/teakra/stargazers","contributors_url":"https://api.github.com/repos/lioncash/teakra/contributors","subscribers_url":"https://api.github.com/repos/lioncash/teakra/subscribers","subscription_url":"https://api.github.com/repos/lioncash/teakra/subscription","commits_url":"https://api.github.com/repos/lioncash/teakra/commits{/sha}","git_commits_url":"https://api.github.com/repos/lioncash/teakra/git/commits{/sha}","comments_url":"https://api.github.com/repos/lioncash/teakra/comments{/number}","issue_comment_url":"https://api.github.com/repos/lioncash/teakra/issues/comments{/number}","contents_url":"https://api.github.com/repos/lioncash/teakra/contents/{+path}","compare_url":"https://api.github.com/repos/lioncash/teakra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lioncash/teakra/merges","archive_url":"https://api.github.com/repos/lioncash/teakra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lioncash/teakra/downloads","issues_url":"https://api.github.com/repos/lioncash/teakra/issues{/number}","pulls_url":"https://api.github.com/repos/lioncash/teakra/pulls{/number}","milestones_url":"https://api.github.com/repos/lioncash/teakra/milestones{/number}","notifications_url":"https://api.github.com/repos/lioncash/teakra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lioncash/teakra/labels{/name}","releases_url":"https://api.github.com/repos/lioncash/teakra/releases{/id}","deployments_url":"https://api.github.com/repos/lioncash/teakra/deployments","created_at":"2018-01-31T14:15:15Z","updated_at":"2018-12-10T10:41:30Z","pushed_at":"2018-12-10T11:28:49Z","git_url":"git://github.com/lioncash/teakra.git","ssh_url":"git@github.com:lioncash/teakra.git","clone_url":"https://github.com/lioncash/teakra.git","svn_url":"https://github.com/lioncash/teakra","homepage":null,"size":603,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wwylele:master","ref":"master","sha":"e2da4bc18d4f7d4848228e1c149aed10de9d7938","user":{"login":"wwylele","id":4592895,"node_id":"MDQ6VXNlcjQ1OTI4OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4592895?v=4","gravatar_id":"","url":"https://api.github.com/users/wwylele","html_url":"https://github.com/wwylele","followers_url":"https://api.github.com/users/wwylele/followers","following_url":"https://api.github.com/users/wwylele/following{/other_user}","gists_url":"https://api.github.com/users/wwylele/gists{/gist_id}","starred_url":"https://api.github.com/users/wwylele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwylele/subscriptions","organizations_url":"https://api.github.com/users/wwylele/orgs","repos_url":"https://api.github.com/users/wwylele/repos","events_url":"https://api.github.com/users/wwylele/events{/privacy}","received_events_url":"https://api.github.com/users/wwylele/received_events","type":"User","site_admin":false},"repo":{"id":119041479,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkwNDE0Nzk=","name":"teakra","full_name":"wwylele/teakra","private":false,"owner":{"login":"wwylele","id":4592895,"node_id":"MDQ6VXNlcjQ1OTI4OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4592895?v=4","gravatar_id":"","url":"https://api.github.com/users/wwylele","html_url":"https://github.com/wwylele","followers_url":"https://api.github.com/users/wwylele/followers","following_url":"https://api.github.com/users/wwylele/following{/other_user}","gists_url":"https://api.github.com/users/wwylele/gists{/gist_id}","starred_url":"https://api.github.com/users/wwylele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwylele/subscriptions","organizations_url":"https://api.github.com/users/wwylele/orgs","repos_url":"https://api.github.com/users/wwylele/repos","events_url":"https://api.github.com/users/wwylele/events{/privacy}","received_events_url":"https://api.github.com/users/wwylele/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wwylele/teakra","description":"DSi/3DS DSP emulator, disassembler, assembler, and tester","fork":false,"url":"https://api.github.com/repos/wwylele/teakra","forks_url":"https://api.github.com/repos/wwylele/teakra/forks","keys_url":"https://api.github.com/repos/wwylele/teakra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwylele/teakra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwylele/teakra/teams","hooks_url":"https://api.github.com/repos/wwylele/teakra/hooks","issue_events_url":"https://api.github.com/repos/wwylele/teakra/issues/events{/number}","events_url":"https://api.github.com/repos/wwylele/teakra/events","assignees_url":"https://api.github.com/repos/wwylele/teakra/assignees{/user}","branches_url":"https://api.github.com/repos/wwylele/teakra/branches{/branch}","tags_url":"https://api.github.com/repos/wwylele/teakra/tags","blobs_url":"https://api.github.com/repos/wwylele/teakra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwylele/teakra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwylele/teakra/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwylele/teakra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwylele/teakra/statuses/{sha}","languages_url":"https://api.github.com/repos/wwylele/teakra/languages","stargazers_url":"https://api.github.com/repos/wwylele/teakra/stargazers","contributors_url":"https://api.github.com/repos/wwylele/teakra/contributors","subscribers_url":"https://api.github.com/repos/wwylele/teakra/subscribers","subscription_url":"https://api.github.com/repos/wwylele/teakra/subscription","commits_url":"https://api.github.com/repos/wwylele/teakra/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwylele/teakra/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwylele/teakra/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwylele/teakra/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwylele/teakra/contents/{+path}","compare_url":"https://api.github.com/repos/wwylele/teakra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwylele/teakra/merges","archive_url":"https://api.github.com/repos/wwylele/teakra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwylele/teakra/downloads","issues_url":"https://api.github.com/repos/wwylele/teakra/issues{/number}","pulls_url":"https://api.github.com/repos/wwylele/teakra/pulls{/number}","milestones_url":"https://api.github.com/repos/wwylele/teakra/milestones{/number}","notifications_url":"https://api.github.com/repos/wwylele/teakra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwylele/teakra/labels{/name}","releases_url":"https://api.github.com/repos/wwylele/teakra/releases{/id}","deployments_url":"https://api.github.com/repos/wwylele/teakra/deployments","created_at":"2018-01-26T10:57:39Z","updated_at":"2018-12-10T14:46:10Z","pushed_at":"2018-12-10T14:46:40Z","git_url":"git://github.com/wwylele/teakra.git","ssh_url":"git@github.com:wwylele/teakra.git","clone_url":"https://github.com/wwylele/teakra.git","svn_url":"https://github.com/wwylele/teakra","homepage":"","size":595,"stargazers_count":32,"watchers_count":32,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":6,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wwylele/teakra/pulls/21"},"html":{"href":"https://github.com/wwylele/teakra/pull/21"},"issue":{"href":"https://api.github.com/repos/wwylele/teakra/issues/21"},"comments":{"href":"https://api.github.com/repos/wwylele/teakra/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/wwylele/teakra/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/wwylele/teakra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wwylele/teakra/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/wwylele/teakra/statuses/6653a3a43258bc7142778b1ed61d919429bd14c2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wwylele","id":4592895,"node_id":"MDQ6VXNlcjQ1OTI4OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4592895?v=4","gravatar_id":"","url":"https://api.github.com/users/wwylele","html_url":"https://github.com/wwylele","followers_url":"https://api.github.com/users/wwylele/followers","following_url":"https://api.github.com/users/wwylele/following{/other_user}","gists_url":"https://api.github.com/users/wwylele/gists{/gist_id}","starred_url":"https://api.github.com/users/wwylele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwylele/subscriptions","organizations_url":"https://api.github.com/users/wwylele/orgs","repos_url":"https://api.github.com/users/wwylele/repos","events_url":"https://api.github.com/users/wwylele/events{/privacy}","received_events_url":"https://api.github.com/users/wwylele/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"wwylele"}}