{"action":"created","issue":{"url":"https://api.github.com/repos/vitiral/artifact/issues/236","repository_url":"https://api.github.com/repos/vitiral/artifact","labels_url":"https://api.github.com/repos/vitiral/artifact/issues/236/labels{/name}","comments_url":"https://api.github.com/repos/vitiral/artifact/issues/236/comments","events_url":"https://api.github.com/repos/vitiral/artifact/issues/236/events","html_url":"https://github.com/vitiral/artifact/issues/236","id":343344877,"node_id":"MDU6SXNzdWUzNDMzNDQ4Nzc=","number":236,"title":"Build fails on nightly (12ed235ad 2018-07-18)","user":{"login":"zmitchell","id":10246891,"node_id":"MDQ6VXNlcjEwMjQ2ODkx","avatar_url":"https://avatars2.githubusercontent.com/u/10246891?v=4","gravatar_id":"","url":"https://api.github.com/users/zmitchell","html_url":"https://github.com/zmitchell","followers_url":"https://api.github.com/users/zmitchell/followers","following_url":"https://api.github.com/users/zmitchell/following{/other_user}","gists_url":"https://api.github.com/users/zmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/zmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmitchell/subscriptions","organizations_url":"https://api.github.com/users/zmitchell/orgs","repos_url":"https://api.github.com/users/zmitchell/repos","events_url":"https://api.github.com/users/zmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/zmitchell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-21T18:09:44Z","updated_at":"2018-08-05T04:28:37Z","closed_at":null,"author_association":"NONE","body":"I'm on macOS 10.13.5, and I'm building `artifact` from source since there's no macOS binary (yet). Building from source gives me a number of errors, some of which I can fix.\r\n\r\nEdit: I should add that I'm using the source code from the release page.\r\n\r\n## Missing `cargo-web` dependency\r\nThe first seems to be that `cargo-web` is required:\r\n```\r\n--- stdout\r\nBuild Script Started\r\nBuilding artifact-frontend\r\n\r\n--- stderr\r\nerror: no such subcommand: `web`\r\n\r\n\tDid you mean `new`?\r\n\r\nthread 'main' panicked at 'artifact-frontend failed to build', build.rs:56:5\r\nnote: Run with `RUST_BACKTRACE=1` for a backtrace.\r\n```\r\nI installed `cargo-web` separately via `cargo install cargo-web` and things progressed.\r\n\r\n## Bug in `stdweb < 0.4.8`\r\nThis is a known issue (see [here](https://github.com/koute/stdweb/issues/252)), and has already been fixed in `stdweb`. All I needed to do was update `Cargo.toml` for `artifact-frontend`.\r\n\r\n## Incorrect paths used during build\r\nI started running `cargo check` to speed things up, and I got this error message:\r\n```\r\nartifact-2.0.0!$ RUST_BACKTRACE=1 cargo check                                                                                  2m4s ~/Projects/artifact-2.0.0\r\n   Compiling artifact-app v2.0.0 (file:///Users/zmitchell/Projects/artifact-2.0.0)\r\nerror: failed to run custom build command for `artifact-app v2.0.0 (file:///Users/zmitchell/Projects/artifact-2.0.0)`\r\nprocess didn't exit successfully: `/Users/zmitchell/Projects/artifact-2.0.0/target/debug/build/artifact-app-7def9eec474743ad/build-script-build` (exit code: 101)\r\n--- stdout\r\nBuild Script Started\r\nBuilding artifact-frontend\r\nBuilding the book\r\n\r\n--- stderr\r\n    Finished release [optimized] target(s) in 0.16s\r\n    Garbage collecting \"artifact-frontend.wasm\"...\r\n    Processing \"artifact-frontend.wasm\"...\r\n    Finished processing of \"artifact-frontend.wasm\"!\r\nThe `artifact-frontend` was deployed to \"/Users/zmitchell/Projects/artifact-2.0.0/artifact-frontend/target/deploy\"!\r\nthread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: \"No such file or directory\" }', libcore/result.rs:945:5\r\nstack backtrace:\r\n   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace\r\n             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49\r\n   1: std::sys_common::backtrace::print\r\n             at libstd/sys_common/backtrace.rs:71\r\n             at libstd/sys_common/backtrace.rs:59\r\n   2: std::panicking::default_hook::{{closure}}\r\n             at libstd/panicking.rs:211\r\n   3: std::panicking::default_hook\r\n             at libstd/panicking.rs:227\r\n   4: <std::panicking::begin_panic::PanicPayload<A> as core::panic::BoxMeUp>::get\r\n             at libstd/panicking.rs:475\r\n   5: std::panicking::continue_panic_fmt\r\n             at libstd/panicking.rs:390\r\n   6: std::panicking::try::do_call\r\n             at libstd/panicking.rs:325\r\n   7: core::ptr::drop_in_place\r\n             at libcore/panicking.rs:77\r\n   8: core::alloc::Layout::align\r\n             at /Users/travis/build/rust-lang/rust/src/libcore/macros.rs:26\r\n   9: <core::result::Result<T, E>>::unwrap\r\n             at /Users/travis/build/rust-lang/rust/src/libcore/result.rs:782\r\n  10: build_script_build::build_mdbook\r\n             at ./build.rs:23\r\n  11: build_script_build::main\r\n             at ./build.rs:9\r\n  12: std::rt::lang_start::{{closure}}\r\n             at /Users/travis/build/rust-lang/rust/src/libstd/rt.rs:74\r\n  13: std::panicking::try::do_call\r\n             at libstd/rt.rs:59\r\n             at libstd/panicking.rs:310\r\n  14: panic_unwind::dwarf::eh::read_encoded_pointer\r\n             at libpanic_unwind/lib.rs:106\r\n  15: <std::sync::mutex::Mutex<T>>::new\r\n             at libstd/panicking.rs:289\r\n             at libstd/panic.rs:392\r\n             at libstd/rt.rs:58\r\n  16: std::rt::lang_start\r\n             at /Users/travis/build/rust-lang/rust/src/libstd/rt.rs:74\r\n  17: <build_script_build::FRONTEND_DEPLOY as core::ops::deref::Deref>::deref\r\n```\r\nAs you can see, the panic is caused by unwrapping an error which is caused by a file/directory not being found. If you look at the backtrace, you'll see that the path `/Users/travis/...` is being used. I suspect that some CI stuff is leaking through to user installs, but I did verify that there's no `travis` user on my computer using `dscl . list /Users | grep -v '^_'`. I'm not sure where the `travis` part is leaking through though."},"comment":{"url":"https://api.github.com/repos/vitiral/artifact/issues/comments/410494988","html_url":"https://github.com/vitiral/artifact/issues/236#issuecomment-410494988","issue_url":"https://api.github.com/repos/vitiral/artifact/issues/236","id":410494988,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ5NDk4OA==","user":{"login":"vitiral","id":5587659,"node_id":"MDQ6VXNlcjU1ODc2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5587659?v=4","gravatar_id":"","url":"https://api.github.com/users/vitiral","html_url":"https://github.com/vitiral","followers_url":"https://api.github.com/users/vitiral/followers","following_url":"https://api.github.com/users/vitiral/following{/other_user}","gists_url":"https://api.github.com/users/vitiral/gists{/gist_id}","starred_url":"https://api.github.com/users/vitiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitiral/subscriptions","organizations_url":"https://api.github.com/users/vitiral/orgs","repos_url":"https://api.github.com/users/vitiral/repos","events_url":"https://api.github.com/users/vitiral/events{/privacy}","received_events_url":"https://api.github.com/users/vitiral/received_events","type":"User","site_admin":false},"created_at":"2018-08-05T04:28:37Z","updated_at":"2018-08-05T04:28:37Z","author_association":"OWNER","body":"Thanks for the detailed bug reports everyone!\r\n\r\nI've done what @zmitchell suggested, as well as add checks in `build.rs` for the dependencies with a better error message. I hope to have better build/release mechanisms in the next few months... but as I just started a new job it's going to be a while without contributor help.\r\n\r\nThis goes a long way. If anyone is interested in becoming a contributor to spearhead getting this building+releasing on multiple platforms I would be very interested!"}}
{"actor":{"display_login":"vitiral"}}