{"action":"created","comment":{"url":"https://api.github.com/repos/gocd/gocd/pulls/comments/200082764","pull_request_review_id":134326455,"id":200082764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA4Mjc2NA==","diff_hunk":"@@ -0,0 +1,35 @@\n+/*\n+ * Copyright 2018 ThoughtWorks, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+const AjaxHelper = require('helpers/ajax_helper');\n+const Stream                          = require('mithril/stream');\n+\n+const DataSharingNotificationPermission = function (permission) {\n+    const self = this;\n+    this.shouldAllow = Stream(permission.allow);\n+};\n+DataSharingNotificationPermission.API_VERSION = 'v1';\n+\n+DataSharingNotificationPermission.get = () => {\n+    return AjaxHelper.GET({\n+        url:        \"/go/api/data_sharing/settings/notification\",","path":"server/webapp/WEB-INF/rails.new/webpack/models/notifications/data_sharing_notification_permissions.js","position":27,"original_position":28,"commit_id":"a5fe5143faf00f76e07e91c015d8ff0d61121f76","original_commit_id":"f1cbba895fe468c1b76f03d00763268aa5cc9e22","user":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"body":"I thought `SparkRoute` was some fancy way of accessing the spark URLs, so I was trying to figure out how does it work. Was disappointed to see that its just hard-coded urls in there. Didn't see any use for it, so ditched that. ","created_at":"2018-07-04T10:33:22Z","updated_at":"2018-07-04T10:33:22Z","html_url":"https://github.com/gocd/gocd/pull/4914#discussion_r200082764","pull_request_url":"https://api.github.com/repos/gocd/gocd/pulls/4914","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/200082764"},"html":{"href":"https://github.com/gocd/gocd/pull/4914#discussion_r200082764"},"pull_request":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4914"}},"in_reply_to_id":200077877},"pull_request":{"url":"https://api.github.com/repos/gocd/gocd/pulls/4914","id":199188087,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTg4MDg3","html_url":"https://github.com/gocd/gocd/pull/4914","diff_url":"https://github.com/gocd/gocd/pull/4914.diff","patch_url":"https://github.com/gocd/gocd/pull/4914.patch","issue_url":"https://api.github.com/repos/gocd/gocd/issues/4914","number":4914,"state":"open","locked":false,"title":"Data sharing additional parameters to report","user":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"body":"Data that would be sent would look like this now:\r\n``` json\r\n{\r\n  \"server_id\" : \"651d81bd-8bf8-4a37-a7b1-6f4f826e5ef1\",\r\n  \"message_version\" : 1,\r\n  \"data\" : {\r\n    \"pipeline_count\" : 1,\r\n    \"agent_count\" : 0,\r\n    \"oldest_pipeline_execution_time\" : 1530680632695,\r\n    \"gocd_version\" : \"18.7.0\"\r\n  }\r\n}\r\n```\r\n\r\nThe data sharing notification is shown to admins alone.","created_at":"2018-07-04T09:20:34Z","updated_at":"2018-07-04T10:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acd4fef26c2e126b79774dc446931a9b45571098","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/gocd/gocd/milestones/44","html_url":"https://github.com/gocd/gocd/milestone/44","labels_url":"https://api.github.com/repos/gocd/gocd/milestones/44/labels","id":3338925,"node_id":"MDk6TWlsZXN0b25lMzMzODkyNQ==","number":44,"title":"Release 18.7","description":"","creator":{"login":"ketan","id":10598,"node_id":"MDQ6VXNlcjEwNTk4","avatar_url":"https://avatars3.githubusercontent.com/u/10598?v=4","gravatar_id":"","url":"https://api.github.com/users/ketan","html_url":"https://github.com/ketan","followers_url":"https://api.github.com/users/ketan/followers","following_url":"https://api.github.com/users/ketan/following{/other_user}","gists_url":"https://api.github.com/users/ketan/gists{/gist_id}","starred_url":"https://api.github.com/users/ketan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ketan/subscriptions","organizations_url":"https://api.github.com/users/ketan/orgs","repos_url":"https://api.github.com/users/ketan/repos","events_url":"https://api.github.com/users/ketan/events{/privacy}","received_events_url":"https://api.github.com/users/ketan/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":45,"state":"open","created_at":"2018-05-11T11:32:21Z","updated_at":"2018-07-04T09:20:34Z","due_on":"2018-07-18T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gocd/gocd/pulls/4914/commits","review_comments_url":"https://api.github.com/repos/gocd/gocd/pulls/4914/comments","review_comment_url":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gocd/gocd/issues/4914/comments","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/a5fe5143faf00f76e07e91c015d8ff0d61121f76","head":{"label":"jyotisingh:data_sharing_additional_parameters_to_report","ref":"data_sharing_additional_parameters_to_report","sha":"a5fe5143faf00f76e07e91c015d8ff0d61121f76","user":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"repo":{"id":21679740,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY3OTc0MA==","name":"gocd","full_name":"jyotisingh/gocd","owner":{"login":"jyotisingh","id":1046342,"node_id":"MDQ6VXNlcjEwNDYzNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1046342?v=4","gravatar_id":"","url":"https://api.github.com/users/jyotisingh","html_url":"https://github.com/jyotisingh","followers_url":"https://api.github.com/users/jyotisingh/followers","following_url":"https://api.github.com/users/jyotisingh/following{/other_user}","gists_url":"https://api.github.com/users/jyotisingh/gists{/gist_id}","starred_url":"https://api.github.com/users/jyotisingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyotisingh/subscriptions","organizations_url":"https://api.github.com/users/jyotisingh/orgs","repos_url":"https://api.github.com/users/jyotisingh/repos","events_url":"https://api.github.com/users/jyotisingh/events{/privacy}","received_events_url":"https://api.github.com/users/jyotisingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jyotisingh/gocd","description":"Main repository for Go Continuous Delivery","fork":true,"url":"https://api.github.com/repos/jyotisingh/gocd","forks_url":"https://api.github.com/repos/jyotisingh/gocd/forks","keys_url":"https://api.github.com/repos/jyotisingh/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jyotisingh/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jyotisingh/gocd/teams","hooks_url":"https://api.github.com/repos/jyotisingh/gocd/hooks","issue_events_url":"https://api.github.com/repos/jyotisingh/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/jyotisingh/gocd/events","assignees_url":"https://api.github.com/repos/jyotisingh/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/jyotisingh/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/jyotisingh/gocd/tags","blobs_url":"https://api.github.com/repos/jyotisingh/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jyotisingh/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jyotisingh/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jyotisingh/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jyotisingh/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/jyotisingh/gocd/languages","stargazers_url":"https://api.github.com/repos/jyotisingh/gocd/stargazers","contributors_url":"https://api.github.com/repos/jyotisingh/gocd/contributors","subscribers_url":"https://api.github.com/repos/jyotisingh/gocd/subscribers","subscription_url":"https://api.github.com/repos/jyotisingh/gocd/subscription","commits_url":"https://api.github.com/repos/jyotisingh/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jyotisingh/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jyotisingh/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jyotisingh/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/jyotisingh/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/jyotisingh/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jyotisingh/gocd/merges","archive_url":"https://api.github.com/repos/jyotisingh/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jyotisingh/gocd/downloads","issues_url":"https://api.github.com/repos/jyotisingh/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/jyotisingh/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/jyotisingh/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/jyotisingh/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jyotisingh/gocd/labels{/name}","releases_url":"https://api.github.com/repos/jyotisingh/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/jyotisingh/gocd/deployments","created_at":"2014-07-10T04:52:59Z","updated_at":"2018-07-03T11:57:37Z","pushed_at":"2018-07-04T10:22:25Z","git_url":"git://github.com/jyotisingh/gocd.git","ssh_url":"git@github.com:jyotisingh/gocd.git","clone_url":"https://github.com/jyotisingh/gocd.git","svn_url":"https://github.com/jyotisingh/gocd","homepage":null,"size":266144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gocd:master","ref":"master","sha":"c8e5c7bd5fa2795370e1c90bb7b0a3af16687d75","user":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":15155534,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1NTUzNA==","name":"gocd","full_name":"gocd/gocd","owner":{"login":"gocd","id":6099846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTk4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6099846?v=4","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gocd/gocd","description":"Main repository for GoCD - Continuous Delivery server","fork":false,"url":"https://api.github.com/repos/gocd/gocd","forks_url":"https://api.github.com/repos/gocd/gocd/forks","keys_url":"https://api.github.com/repos/gocd/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/gocd/teams","hooks_url":"https://api.github.com/repos/gocd/gocd/hooks","issue_events_url":"https://api.github.com/repos/gocd/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/gocd/events","assignees_url":"https://api.github.com/repos/gocd/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/gocd/tags","blobs_url":"https://api.github.com/repos/gocd/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/gocd/languages","stargazers_url":"https://api.github.com/repos/gocd/gocd/stargazers","contributors_url":"https://api.github.com/repos/gocd/gocd/contributors","subscribers_url":"https://api.github.com/repos/gocd/gocd/subscribers","subscription_url":"https://api.github.com/repos/gocd/gocd/subscription","commits_url":"https://api.github.com/repos/gocd/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gocd/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/gocd/merges","archive_url":"https://api.github.com/repos/gocd/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/gocd/downloads","issues_url":"https://api.github.com/repos/gocd/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/gocd/labels{/name}","releases_url":"https://api.github.com/repos/gocd/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/gocd/gocd/deployments","created_at":"2013-12-13T05:26:16Z","updated_at":"2018-07-04T07:32:38Z","pushed_at":"2018-07-04T10:30:29Z","git_url":"git://github.com/gocd/gocd.git","ssh_url":"git@github.com:gocd/gocd.git","clone_url":"https://github.com/gocd/gocd.git","svn_url":"https://github.com/gocd/gocd","homepage":"https://www.gocd.org","size":265841,"stargazers_count":4233,"watchers_count":4233,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":717,"mirror_url":null,"archived":false,"open_issues_count":841,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":717,"open_issues":841,"watchers":4233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4914"},"html":{"href":"https://github.com/gocd/gocd/pull/4914"},"issue":{"href":"https://api.github.com/repos/gocd/gocd/issues/4914"},"comments":{"href":"https://api.github.com/repos/gocd/gocd/issues/4914/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4914/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gocd/gocd/pulls/4914/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/gocd/statuses/a5fe5143faf00f76e07e91c015d8ff0d61121f76"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jyotisingh"}}