{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments/171039876","pull_request_review_id":99822960,"id":171039876,"diff_hunk":"@@ -6,11 +6,9 @@ import * as React from 'react';\n import BaseIcon from '../BaseIcon';\n \n export default class ${name} extends BaseIcon {\n-  render() {\n+  renderPath() {\n     return (\n-      <svg viewBox=\"0 0 240 240\" className={this.getClassName()} style={this.getStyle()}>\n-        ${jsx}\n-      </svg>\n+      ${jsx}","path":"config/icons/iconTemplate.ejs","position":10,"original_position":10,"commit_id":"e41118daee2ce6d76f45452c93cee89d7bdc1e06","original_commit_id":"e41118daee2ce6d76f45452c93cee89d7bdc1e06","user":{"login":"BrendanMcK","id":1754373,"avatar_url":"https://avatars2.githubusercontent.com/u/1754373?v=4","gravatar_id":"","url":"https://api.github.com/users/BrendanMcK","html_url":"https://github.com/BrendanMcK","followers_url":"https://api.github.com/users/BrendanMcK/followers","following_url":"https://api.github.com/users/BrendanMcK/following{/other_user}","gists_url":"https://api.github.com/users/BrendanMcK/gists{/gist_id}","starred_url":"https://api.github.com/users/BrendanMcK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrendanMcK/subscriptions","organizations_url":"https://api.github.com/users/BrendanMcK/orgs","repos_url":"https://api.github.com/users/BrendanMcK/repos","events_url":"https://api.github.com/users/BrendanMcK/events{/privacy}","received_events_url":"https://api.github.com/users/BrendanMcK/received_events","type":"User","site_admin":false},"body":"Good point about potential invalid items. Given that multiple paths are perfectly legit, I'll revert to the more verbose version; can revisit and use fragments when we're using React 16. Otherwise it's an obscure build error waiting to happen should someone add an icon with two paths in future.","created_at":"2018-02-27T19:30:33Z","updated_at":"2018-02-27T19:30:33Z","html_url":"https://github.com/Microsoft/YamUI/pull/257#discussion_r171039876","pull_request_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/257","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments/171039876"},"html":{"href":"https://github.com/Microsoft/YamUI/pull/257#discussion_r171039876"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/257"}},"in_reply_to_id":170833267},"pull_request":{"url":"https://api.github.com/repos/Microsoft/YamUI/pulls/257","id":171579981,"html_url":"https://github.com/Microsoft/YamUI/pull/257","diff_url":"https://github.com/Microsoft/YamUI/pull/257.diff","patch_url":"https://github.com/Microsoft/YamUI/pull/257.patch","issue_url":"https://api.github.com/repos/Microsoft/YamUI/issues/257","number":257,"state":"open","locked":false,"title":"Add tabindex=-1 and aria-hidden=\"true\" to icons","user":{"login":"BrendanMcK","id":1754373,"avatar_url":"https://avatars2.githubusercontent.com/u/1754373?v=4","gravatar_id":"","url":"https://api.github.com/users/BrendanMcK","html_url":"https://github.com/BrendanMcK","followers_url":"https://api.github.com/users/BrendanMcK/followers","following_url":"https://api.github.com/users/BrendanMcK/following{/other_user}","gists_url":"https://api.github.com/users/BrendanMcK/gists{/gist_id}","starred_url":"https://api.github.com/users/BrendanMcK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrendanMcK/subscriptions","organizations_url":"https://api.github.com/users/BrendanMcK/orgs","repos_url":"https://api.github.com/users/BrendanMcK/repos","events_url":"https://api.github.com/users/BrendanMcK/events{/privacy}","received_events_url":"https://api.github.com/users/BrendanMcK/received_events","type":"User","site_admin":false},"body":"*Describe the change you are making*\r\n\r\n## Pull request checklist\r\n\r\n* [ ] Component `README.md` file is up-to-date.\r\n* [ ] Component is unit tested.\r\n","created_at":"2018-02-27T07:08:34Z","updated_at":"2018-02-27T19:30:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0932914068ad8d3594d95bf6792f1eb7029cbbe9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mamuso","id":3992,"avatar_url":"https://avatars1.githubusercontent.com/u/3992?v=4","gravatar_id":"","url":"https://api.github.com/users/mamuso","html_url":"https://github.com/mamuso","followers_url":"https://api.github.com/users/mamuso/followers","following_url":"https://api.github.com/users/mamuso/following{/other_user}","gists_url":"https://api.github.com/users/mamuso/gists{/gist_id}","starred_url":"https://api.github.com/users/mamuso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamuso/subscriptions","organizations_url":"https://api.github.com/users/mamuso/orgs","repos_url":"https://api.github.com/users/mamuso/repos","events_url":"https://api.github.com/users/mamuso/events{/privacy}","received_events_url":"https://api.github.com/users/mamuso/received_events","type":"User","site_admin":false},{"login":"swese44","id":471731,"avatar_url":"https://avatars2.githubusercontent.com/u/471731?v=4","gravatar_id":"","url":"https://api.github.com/users/swese44","html_url":"https://github.com/swese44","followers_url":"https://api.github.com/users/swese44/followers","following_url":"https://api.github.com/users/swese44/following{/other_user}","gists_url":"https://api.github.com/users/swese44/gists{/gist_id}","starred_url":"https://api.github.com/users/swese44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swese44/subscriptions","organizations_url":"https://api.github.com/users/swese44/orgs","repos_url":"https://api.github.com/users/swese44/repos","events_url":"https://api.github.com/users/swese44/events{/privacy}","received_events_url":"https://api.github.com/users/swese44/received_events","type":"User","site_admin":false},{"login":"adrianmg","id":589285,"avatar_url":"https://avatars0.githubusercontent.com/u/589285?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianmg","html_url":"https://github.com/adrianmg","followers_url":"https://api.github.com/users/adrianmg/followers","following_url":"https://api.github.com/users/adrianmg/following{/other_user}","gists_url":"https://api.github.com/users/adrianmg/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianmg/subscriptions","organizations_url":"https://api.github.com/users/adrianmg/orgs","repos_url":"https://api.github.com/users/adrianmg/repos","events_url":"https://api.github.com/users/adrianmg/events{/privacy}","received_events_url":"https://api.github.com/users/adrianmg/received_events","type":"User","site_admin":false},{"login":"richardtagger","id":692240,"avatar_url":"https://avatars1.githubusercontent.com/u/692240?v=4","gravatar_id":"","url":"https://api.github.com/users/richardtagger","html_url":"https://github.com/richardtagger","followers_url":"https://api.github.com/users/richardtagger/followers","following_url":"https://api.github.com/users/richardtagger/following{/other_user}","gists_url":"https://api.github.com/users/richardtagger/gists{/gist_id}","starred_url":"https://api.github.com/users/richardtagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardtagger/subscriptions","organizations_url":"https://api.github.com/users/richardtagger/orgs","repos_url":"https://api.github.com/users/richardtagger/repos","events_url":"https://api.github.com/users/richardtagger/events{/privacy}","received_events_url":"https://api.github.com/users/richardtagger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/257/commits","review_comments_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/257/comments","review_comment_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/issues/257/comments","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/e41118daee2ce6d76f45452c93cee89d7bdc1e06","head":{"label":"Microsoft:bmckeon-icon-a11y-fix","ref":"bmckeon-icon-a11y-fix","sha":"e41118daee2ce6d76f45452c93cee89d7bdc1e06","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97036342,"name":"YamUI","full_name":"Microsoft/YamUI","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/YamUI","description":"Reusable component framework for Yammer.com","fork":false,"url":"https://api.github.com/repos/Microsoft/YamUI","forks_url":"https://api.github.com/repos/Microsoft/YamUI/forks","keys_url":"https://api.github.com/repos/Microsoft/YamUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/YamUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/YamUI/teams","hooks_url":"https://api.github.com/repos/Microsoft/YamUI/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/YamUI/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/YamUI/events","assignees_url":"https://api.github.com/repos/Microsoft/YamUI/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/YamUI/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/YamUI/tags","blobs_url":"https://api.github.com/repos/Microsoft/YamUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/YamUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/YamUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/YamUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/YamUI/languages","stargazers_url":"https://api.github.com/repos/Microsoft/YamUI/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/YamUI/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/YamUI/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/YamUI/subscription","commits_url":"https://api.github.com/repos/Microsoft/YamUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/YamUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/YamUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/YamUI/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/YamUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/YamUI/merges","archive_url":"https://api.github.com/repos/Microsoft/YamUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/YamUI/downloads","issues_url":"https://api.github.com/repos/Microsoft/YamUI/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/YamUI/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/YamUI/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/YamUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/YamUI/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/YamUI/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/YamUI/deployments","created_at":"2017-07-12T17:43:12Z","updated_at":"2018-02-22T00:59:38Z","pushed_at":"2018-02-27T18:44:19Z","git_url":"git://github.com/Microsoft/YamUI.git","ssh_url":"git@github.com:Microsoft/YamUI.git","clone_url":"https://github.com/Microsoft/YamUI.git","svn_url":"https://github.com/Microsoft/YamUI","homepage":"https://microsoft.github.io/YamUI/","size":30292,"stargazers_count":355,"watchers_count":355,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":27,"open_issues":50,"watchers":355,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"6c5073a2657fcd59aa4204c0ce28783008c86df1","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97036342,"name":"YamUI","full_name":"Microsoft/YamUI","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/YamUI","description":"Reusable component framework for Yammer.com","fork":false,"url":"https://api.github.com/repos/Microsoft/YamUI","forks_url":"https://api.github.com/repos/Microsoft/YamUI/forks","keys_url":"https://api.github.com/repos/Microsoft/YamUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/YamUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/YamUI/teams","hooks_url":"https://api.github.com/repos/Microsoft/YamUI/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/YamUI/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/YamUI/events","assignees_url":"https://api.github.com/repos/Microsoft/YamUI/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/YamUI/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/YamUI/tags","blobs_url":"https://api.github.com/repos/Microsoft/YamUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/YamUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/YamUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/YamUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/YamUI/languages","stargazers_url":"https://api.github.com/repos/Microsoft/YamUI/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/YamUI/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/YamUI/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/YamUI/subscription","commits_url":"https://api.github.com/repos/Microsoft/YamUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/YamUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/YamUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/YamUI/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/YamUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/YamUI/merges","archive_url":"https://api.github.com/repos/Microsoft/YamUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/YamUI/downloads","issues_url":"https://api.github.com/repos/Microsoft/YamUI/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/YamUI/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/YamUI/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/YamUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/YamUI/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/YamUI/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/YamUI/deployments","created_at":"2017-07-12T17:43:12Z","updated_at":"2018-02-22T00:59:38Z","pushed_at":"2018-02-27T18:44:19Z","git_url":"git://github.com/Microsoft/YamUI.git","ssh_url":"git@github.com:Microsoft/YamUI.git","clone_url":"https://github.com/Microsoft/YamUI.git","svn_url":"https://github.com/Microsoft/YamUI","homepage":"https://microsoft.github.io/YamUI/","size":30292,"stargazers_count":355,"watchers_count":355,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":27,"open_issues":50,"watchers":355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/257"},"html":{"href":"https://github.com/Microsoft/YamUI/pull/257"},"issue":{"href":"https://api.github.com/repos/Microsoft/YamUI/issues/257"},"comments":{"href":"https://api.github.com/repos/Microsoft/YamUI/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/YamUI/statuses/e41118daee2ce6d76f45452c93cee89d7bdc1e06"}},"author_association":"NONE"}}
{"actor":{"display_login":"BrendanMcK"}}