{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/forklift/pulls/comments/179816401","pull_request_review_id":110135346,"id":179816401,"diff_hunk":"@@ -3,7 +3,7 @@\n   shell: >\n       {{ foreman_installer_command }} {{ (foreman_installer_verbose == True) | ternary(\"-v\", \"\") }}\n       --scenario \"{{ foreman_installer_scenario }}\"\n-      {{ foreman_installer_options }}\n+      {{ foreman_installer_options | join(\" \") }}","path":"roles/foreman_installer/tasks/install.yml","position":5,"original_position":5,"commit_id":"a82551f1132b606b9e7a5ef7c2ed2c06d409cd03","original_commit_id":"cb7bca4e34a67c0a60edb9ada4002dc6ca4fcac4","user":{"login":"akofink","id":761923,"avatar_url":"https://avatars2.githubusercontent.com/u/761923?v=4","gravatar_id":"","url":"https://api.github.com/users/akofink","html_url":"https://github.com/akofink","followers_url":"https://api.github.com/users/akofink/followers","following_url":"https://api.github.com/users/akofink/following{/other_user}","gists_url":"https://api.github.com/users/akofink/gists{/gist_id}","starred_url":"https://api.github.com/users/akofink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akofink/subscriptions","organizations_url":"https://api.github.com/users/akofink/orgs","repos_url":"https://api.github.com/users/akofink/repos","events_url":"https://api.github.com/users/akofink/events{/privacy}","received_events_url":"https://api.github.com/users/akofink/received_events","type":"User","site_admin":false},"body":"I'd vote to put this in a separate PR (I like the change to using an array of stings vs. one big ole string). We'd need to change any places in forklift that are using the string of options.","created_at":"2018-04-06T16:55:30Z","updated_at":"2018-04-06T16:55:30Z","html_url":"https://github.com/theforeman/forklift/pull/623#discussion_r179816401","pull_request_url":"https://api.github.com/repos/theforeman/forklift/pulls/623","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/theforeman/forklift/pulls/comments/179816401"},"html":{"href":"https://github.com/theforeman/forklift/pull/623#discussion_r179816401"},"pull_request":{"href":"https://api.github.com/repos/theforeman/forklift/pulls/623"}},"in_reply_to_id":169270718},"pull_request":{"url":"https://api.github.com/repos/theforeman/forklift/pulls/623","id":170052936,"html_url":"https://github.com/theforeman/forklift/pull/623","diff_url":"https://github.com/theforeman/forklift/pull/623.diff","patch_url":"https://github.com/theforeman/forklift/pull/623.patch","issue_url":"https://api.github.com/repos/theforeman/forklift/issues/623","number":623,"state":"open","locked":false,"title":"Add devel box that configures multiple plugins","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"This does not currently work due to (https://community.theforeman.org/t/rename-foreman-docker-git-repository-to-foreman-docker/8391). That will either have to get resolved, or we will have to add special code in puppet-katello_devel that handles the special case of foreman_docker.\r\n\r\nYou might ask yourself why is this named \"charon\". Well, it sounded better than \"foreman_with_a_bunch_of_plugins\" and was short and to the point. Charon is a moon or natural satellite of the dwarf Planet pluto. ","created_at":"2018-02-19T21:09:45Z","updated_at":"2018-04-06T16:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65944a465ff79970a921520685a470a14e7016a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/forklift/pulls/623/commits","review_comments_url":"https://api.github.com/repos/theforeman/forklift/pulls/623/comments","review_comment_url":"https://api.github.com/repos/theforeman/forklift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/forklift/issues/623/comments","statuses_url":"https://api.github.com/repos/theforeman/forklift/statuses/a82551f1132b606b9e7a5ef7c2ed2c06d409cd03","head":{"label":"ehelms:charon","ref":"charon","sha":"a82551f1132b606b9e7a5ef7c2ed2c06d409cd03","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":16161762,"name":"forklift","full_name":"ehelms/forklift","owner":{"login":"ehelms","id":293363,"avatar_url":"https://avatars2.githubusercontent.com/u/293363?v=4","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/forklift","description":"Helpful deployment scripts for Katello","fork":true,"url":"https://api.github.com/repos/ehelms/forklift","forks_url":"https://api.github.com/repos/ehelms/forklift/forks","keys_url":"https://api.github.com/repos/ehelms/forklift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/forklift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/forklift/teams","hooks_url":"https://api.github.com/repos/ehelms/forklift/hooks","issue_events_url":"https://api.github.com/repos/ehelms/forklift/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/forklift/events","assignees_url":"https://api.github.com/repos/ehelms/forklift/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/forklift/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/forklift/tags","blobs_url":"https://api.github.com/repos/ehelms/forklift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/forklift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/forklift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/forklift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/forklift/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/forklift/languages","stargazers_url":"https://api.github.com/repos/ehelms/forklift/stargazers","contributors_url":"https://api.github.com/repos/ehelms/forklift/contributors","subscribers_url":"https://api.github.com/repos/ehelms/forklift/subscribers","subscription_url":"https://api.github.com/repos/ehelms/forklift/subscription","commits_url":"https://api.github.com/repos/ehelms/forklift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/forklift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/forklift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/forklift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/forklift/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/forklift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/forklift/merges","archive_url":"https://api.github.com/repos/ehelms/forklift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/forklift/downloads","issues_url":"https://api.github.com/repos/ehelms/forklift/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/forklift/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/forklift/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/forklift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/forklift/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/forklift/releases{/id}","deployments_url":"https://api.github.com/repos/ehelms/forklift/deployments","created_at":"2014-01-23T03:58:16Z","updated_at":"2018-03-19T14:22:11Z","pushed_at":"2018-04-05T01:42:43Z","git_url":"git://github.com/ehelms/forklift.git","ssh_url":"git@github.com:ehelms/forklift.git","clone_url":"https://github.com/ehelms/forklift.git","svn_url":"https://github.com/ehelms/forklift","homepage":null,"size":1892,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"756d8f24f9d403694df06c8fa96a3abc6382c111","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":16148652,"name":"forklift","full_name":"theforeman/forklift","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/forklift","description":"Helpful deployment scripts for Foreman and Katello","fork":false,"url":"https://api.github.com/repos/theforeman/forklift","forks_url":"https://api.github.com/repos/theforeman/forklift/forks","keys_url":"https://api.github.com/repos/theforeman/forklift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/forklift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/forklift/teams","hooks_url":"https://api.github.com/repos/theforeman/forklift/hooks","issue_events_url":"https://api.github.com/repos/theforeman/forklift/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/forklift/events","assignees_url":"https://api.github.com/repos/theforeman/forklift/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/forklift/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/forklift/tags","blobs_url":"https://api.github.com/repos/theforeman/forklift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/forklift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/forklift/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/forklift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/forklift/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/forklift/languages","stargazers_url":"https://api.github.com/repos/theforeman/forklift/stargazers","contributors_url":"https://api.github.com/repos/theforeman/forklift/contributors","subscribers_url":"https://api.github.com/repos/theforeman/forklift/subscribers","subscription_url":"https://api.github.com/repos/theforeman/forklift/subscription","commits_url":"https://api.github.com/repos/theforeman/forklift/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/forklift/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/forklift/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/forklift/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/forklift/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/forklift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/forklift/merges","archive_url":"https://api.github.com/repos/theforeman/forklift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/forklift/downloads","issues_url":"https://api.github.com/repos/theforeman/forklift/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/forklift/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/forklift/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/forklift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/forklift/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/forklift/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/forklift/deployments","created_at":"2014-01-22T18:44:49Z","updated_at":"2018-04-06T16:13:09Z","pushed_at":"2018-04-06T16:13:05Z","git_url":"git://github.com/theforeman/forklift.git","ssh_url":"git@github.com:theforeman/forklift.git","clone_url":"https://github.com/theforeman/forklift.git","svn_url":"https://github.com/theforeman/forklift","homepage":"","size":1248,"stargazers_count":70,"watchers_count":70,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":109,"open_issues":55,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/forklift/pulls/623"},"html":{"href":"https://github.com/theforeman/forklift/pull/623"},"issue":{"href":"https://api.github.com/repos/theforeman/forklift/issues/623"},"comments":{"href":"https://api.github.com/repos/theforeman/forklift/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/forklift/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/forklift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/forklift/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/forklift/statuses/a82551f1132b606b9e7a5ef7c2ed2c06d409cd03"}},"author_association":"OWNER"}}
{"actor":{"display_login":"akofink"}}