{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/pip/pulls/comments/211641689","pull_request_review_id":148106112,"id":211641689,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY0MTY4OQ==","diff_hunk":"@@ -115,6 +115,20 @@ def format(self, record):\n \n         return msg\n \n+    def flush(self):\n+        \"\"\"Ignore `BrokenPipeErrors` on `flush()`.\"\"\"\n+        try:\n+            self.flush()","path":"src/pip/_internal/utils/logging.py","position":15,"original_position":7,"commit_id":"efc5c512294f252159b09473c464e89e05f3e838","original_commit_id":"8afa21abf0e829a5a1d393647c48ab9f890de13e","user":{"login":"pradyunsg","id":3275593,"node_id":"MDQ6VXNlcjMyNzU1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3275593?v=4","gravatar_id":"","url":"https://api.github.com/users/pradyunsg","html_url":"https://github.com/pradyunsg","followers_url":"https://api.github.com/users/pradyunsg/followers","following_url":"https://api.github.com/users/pradyunsg/following{/other_user}","gists_url":"https://api.github.com/users/pradyunsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pradyunsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradyunsg/subscriptions","organizations_url":"https://api.github.com/users/pradyunsg/orgs","repos_url":"https://api.github.com/users/pradyunsg/repos","events_url":"https://api.github.com/users/pradyunsg/events{/privacy}","received_events_url":"https://api.github.com/users/pradyunsg/received_events","type":"User","site_admin":false},"body":"This should be `super(..., self).flush()`.","created_at":"2018-08-21T15:04:15Z","updated_at":"2018-08-21T15:05:37Z","html_url":"https://github.com/pypa/pip/pull/5721#discussion_r211641689","pull_request_url":"https://api.github.com/repos/pypa/pip/pulls/5721","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments/211641689"},"html":{"href":"https://github.com/pypa/pip/pull/5721#discussion_r211641689"},"pull_request":{"href":"https://api.github.com/repos/pypa/pip/pulls/5721"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/5721","id":209850337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODUwMzM3","html_url":"https://github.com/pypa/pip/pull/5721","diff_url":"https://github.com/pypa/pip/pull/5721.diff","patch_url":"https://github.com/pypa/pip/pull/5721.patch","issue_url":"https://api.github.com/repos/pypa/pip/issues/5721","number":5721,"state":"open","locked":false,"title":"[WIP] Teach log-handler to stay calm on broken-pipes eg.  `pip | head`","user":{"login":"ankostis","id":501585,"node_id":"MDQ6VXNlcjUwMTU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/501585?v=4","gravatar_id":"","url":"https://api.github.com/users/ankostis","html_url":"https://github.com/ankostis","followers_url":"https://api.github.com/users/ankostis/followers","following_url":"https://api.github.com/users/ankostis/following{/other_user}","gists_url":"https://api.github.com/users/ankostis/gists{/gist_id}","starred_url":"https://api.github.com/users/ankostis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankostis/subscriptions","organizations_url":"https://api.github.com/users/ankostis/orgs","repos_url":"https://api.github.com/users/ankostis/repos","events_url":"https://api.github.com/users/ankostis/events{/privacy}","received_events_url":"https://api.github.com/users/ankostis/received_events","type":"User","site_admin":false},"body":"Fix #4170: Override `ColorizedStreamHandler.flush()` to ignore `BrokenPipeError` exceptions.\r\n\r\nNote, it would be hard to make a test-case for it, no?","created_at":"2018-08-21T14:41:00Z","updated_at":"2018-08-21T15:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee0359056a11ebb6e2953232f58eb34021fef2ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":634466632,"node_id":"MDU6TGFiZWw2MzQ0NjY2MzI=","url":"https://api.github.com/repos/pypa/pip/labels/S:%20discussion%20needed","name":"S: discussion needed","color":"cc317c","default":false},{"id":929574639,"node_id":"MDU6TGFiZWw5Mjk1NzQ2Mzk=","url":"https://api.github.com/repos/pypa/pip/labels/T:%20bugfix","name":"T: bugfix","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/pip/pulls/5721/commits","review_comments_url":"https://api.github.com/repos/pypa/pip/pulls/5721/comments","review_comment_url":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/pip/issues/5721/comments","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/efc5c512294f252159b09473c464e89e05f3e838","head":{"label":"ankostis:fix_logging_broken_pipes","ref":"fix_logging_broken_pipes","sha":"efc5c512294f252159b09473c464e89e05f3e838","user":{"login":"ankostis","id":501585,"node_id":"MDQ6VXNlcjUwMTU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/501585?v=4","gravatar_id":"","url":"https://api.github.com/users/ankostis","html_url":"https://github.com/ankostis","followers_url":"https://api.github.com/users/ankostis/followers","following_url":"https://api.github.com/users/ankostis/following{/other_user}","gists_url":"https://api.github.com/users/ankostis/gists{/gist_id}","starred_url":"https://api.github.com/users/ankostis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankostis/subscriptions","organizations_url":"https://api.github.com/users/ankostis/orgs","repos_url":"https://api.github.com/users/ankostis/repos","events_url":"https://api.github.com/users/ankostis/events{/privacy}","received_events_url":"https://api.github.com/users/ankostis/received_events","type":"User","site_admin":false},"repo":{"id":145572302,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1NzIzMDI=","name":"pip","full_name":"ankostis/pip","owner":{"login":"ankostis","id":501585,"node_id":"MDQ6VXNlcjUwMTU4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/501585?v=4","gravatar_id":"","url":"https://api.github.com/users/ankostis","html_url":"https://github.com/ankostis","followers_url":"https://api.github.com/users/ankostis/followers","following_url":"https://api.github.com/users/ankostis/following{/other_user}","gists_url":"https://api.github.com/users/ankostis/gists{/gist_id}","starred_url":"https://api.github.com/users/ankostis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankostis/subscriptions","organizations_url":"https://api.github.com/users/ankostis/orgs","repos_url":"https://api.github.com/users/ankostis/repos","events_url":"https://api.github.com/users/ankostis/events{/privacy}","received_events_url":"https://api.github.com/users/ankostis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ankostis/pip","description":"The PyPA recommended tool for installing Python packages","fork":true,"url":"https://api.github.com/repos/ankostis/pip","forks_url":"https://api.github.com/repos/ankostis/pip/forks","keys_url":"https://api.github.com/repos/ankostis/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ankostis/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ankostis/pip/teams","hooks_url":"https://api.github.com/repos/ankostis/pip/hooks","issue_events_url":"https://api.github.com/repos/ankostis/pip/issues/events{/number}","events_url":"https://api.github.com/repos/ankostis/pip/events","assignees_url":"https://api.github.com/repos/ankostis/pip/assignees{/user}","branches_url":"https://api.github.com/repos/ankostis/pip/branches{/branch}","tags_url":"https://api.github.com/repos/ankostis/pip/tags","blobs_url":"https://api.github.com/repos/ankostis/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ankostis/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ankostis/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ankostis/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ankostis/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/ankostis/pip/languages","stargazers_url":"https://api.github.com/repos/ankostis/pip/stargazers","contributors_url":"https://api.github.com/repos/ankostis/pip/contributors","subscribers_url":"https://api.github.com/repos/ankostis/pip/subscribers","subscription_url":"https://api.github.com/repos/ankostis/pip/subscription","commits_url":"https://api.github.com/repos/ankostis/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ankostis/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ankostis/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ankostis/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ankostis/pip/contents/{+path}","compare_url":"https://api.github.com/repos/ankostis/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ankostis/pip/merges","archive_url":"https://api.github.com/repos/ankostis/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ankostis/pip/downloads","issues_url":"https://api.github.com/repos/ankostis/pip/issues{/number}","pulls_url":"https://api.github.com/repos/ankostis/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/ankostis/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/ankostis/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ankostis/pip/labels{/name}","releases_url":"https://api.github.com/repos/ankostis/pip/releases{/id}","deployments_url":"https://api.github.com/repos/ankostis/pip/deployments","created_at":"2018-08-21T14:03:55Z","updated_at":"2018-08-21T14:03:59Z","pushed_at":"2018-08-21T15:05:10Z","git_url":"git://github.com/ankostis/pip.git","ssh_url":"git@github.com:ankostis/pip.git","clone_url":"https://github.com/ankostis/pip.git","svn_url":"https://github.com/ankostis/pip","homepage":"https://pip.pypa.io/","size":51824,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"fc4ce3da2a60ca99c955bc7f5c7fb16b516ce2b3","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446467,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NDY3","name":"pip","full_name":"pypa/pip","owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/pip","description":"The PyPA recommended tool for installing Python packages","fork":false,"url":"https://api.github.com/repos/pypa/pip","forks_url":"https://api.github.com/repos/pypa/pip/forks","keys_url":"https://api.github.com/repos/pypa/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pip/teams","hooks_url":"https://api.github.com/repos/pypa/pip/hooks","issue_events_url":"https://api.github.com/repos/pypa/pip/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pip/events","assignees_url":"https://api.github.com/repos/pypa/pip/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pip/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pip/tags","blobs_url":"https://api.github.com/repos/pypa/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pip/languages","stargazers_url":"https://api.github.com/repos/pypa/pip/stargazers","contributors_url":"https://api.github.com/repos/pypa/pip/contributors","subscribers_url":"https://api.github.com/repos/pypa/pip/subscribers","subscription_url":"https://api.github.com/repos/pypa/pip/subscription","commits_url":"https://api.github.com/repos/pypa/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/pip/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pip/merges","archive_url":"https://api.github.com/repos/pypa/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pip/downloads","issues_url":"https://api.github.com/repos/pypa/pip/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pip/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pip/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/pip/deployments","created_at":"2011-03-06T14:30:46Z","updated_at":"2018-08-21T14:47:45Z","pushed_at":"2018-08-21T15:05:12Z","git_url":"git://github.com/pypa/pip.git","ssh_url":"git@github.com:pypa/pip.git","clone_url":"https://github.com/pypa/pip.git","svn_url":"https://github.com/pypa/pip","homepage":"https://pip.pypa.io/","size":51824,"stargazers_count":4706,"watchers_count":4706,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1590,"mirror_url":null,"archived":false,"open_issues_count":521,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1590,"open_issues":521,"watchers":4706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/5721"},"html":{"href":"https://github.com/pypa/pip/pull/5721"},"issue":{"href":"https://api.github.com/repos/pypa/pip/issues/5721"},"comments":{"href":"https://api.github.com/repos/pypa/pip/issues/5721/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/pip/pulls/5721/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/pip/pulls/5721/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/pip/statuses/efc5c512294f252159b09473c464e89e05f3e838"}},"author_association":"NONE"}}
{"actor":{"display_login":"pradyunsg"}}