{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/223475746","pull_request_review_id":162611915,"id":223475746,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQ3NTc0Ng==","diff_hunk":"@@ -149,6 +149,19 @@ public Task RemoveRootViewAsync(int rootViewTag)\n             }\n         }\n \n+        /// <summary>\n+        /// Refreshes RTL/LTR direction on all root views.\n+        /// </summary>\n+        public void UpdateLayoutDirection()\n+        {\n+            // RTL/LTR is implemented through Xaml FlowDirection, so we keep Yoga oblivious of this.\n+            _operationsQueue.UpdateRootViewNodesDirection();\n+            if (_operationsQueue.IsEmpty())","path":"ReactWindows/ReactNative.Shared/UIManager/UIImplementation.cs","position":11,"original_position":11,"commit_id":"8bac650f1c6cc4ce3a61c73139d79e8b8c1a3275","original_commit_id":"8bac650f1c6cc4ce3a61c73139d79e8b8c1a3275","user":{"login":"rozele","id":1106239,"node_id":"MDQ6VXNlcjExMDYyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1106239?v=4","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"What is the purpose of calling `DispatchViewUpdates` if `_operationsQueue.IsEmpty()`?","created_at":"2018-10-08T19:38:35Z","updated_at":"2018-10-08T19:38:35Z","html_url":"https://github.com/Microsoft/react-native-windows/pull/1994#discussion_r223475746","pull_request_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/223475746"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1994#discussion_r223475746"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994","id":221003130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDAzMTMw","html_url":"https://github.com/Microsoft/react-native-windows/pull/1994","diff_url":"https://github.com/Microsoft/react-native-windows/pull/1994.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/1994.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1994","number":1994,"state":"open","locked":false,"title":"Fixed RTL support","user":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"body":"We rely on Xaml FlowDirection rather than on the Yoga based flipping.\r\nWe also support changing the direction on the fly.\r\nVarious peculiarities/details can be found in the comments throughout the PR.","created_at":"2018-10-08T04:49:21Z","updated_at":"2018-10-08T19:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69469f2c5a3aa9f082682d11d488dfa9d023a60e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1994/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/8bac650f1c6cc4ce3a61c73139d79e8b8c1a3275","head":{"label":"reseul:rtl_play","ref":"rtl_play","sha":"8bac650f1c6cc4ce3a61c73139d79e8b8c1a3275","user":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"repo":{"id":113353887,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNTM4ODc=","name":"react-native-windows","full_name":"reseul/react-native-windows","private":false,"owner":{"login":"reseul","id":11672053,"node_id":"MDQ6VXNlcjExNjcyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/11672053?v=4","gravatar_id":"","url":"https://api.github.com/users/reseul","html_url":"https://github.com/reseul","followers_url":"https://api.github.com/users/reseul/followers","following_url":"https://api.github.com/users/reseul/following{/other_user}","gists_url":"https://api.github.com/users/reseul/gists{/gist_id}","starred_url":"https://api.github.com/users/reseul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reseul/subscriptions","organizations_url":"https://api.github.com/users/reseul/orgs","repos_url":"https://api.github.com/users/reseul/repos","events_url":"https://api.github.com/users/reseul/events{/privacy}","received_events_url":"https://api.github.com/users/reseul/received_events","type":"User","site_admin":false},"html_url":"https://github.com/reseul/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":true,"url":"https://api.github.com/repos/reseul/react-native-windows","forks_url":"https://api.github.com/repos/reseul/react-native-windows/forks","keys_url":"https://api.github.com/repos/reseul/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reseul/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reseul/react-native-windows/teams","hooks_url":"https://api.github.com/repos/reseul/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/reseul/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/reseul/react-native-windows/events","assignees_url":"https://api.github.com/repos/reseul/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/reseul/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/reseul/react-native-windows/tags","blobs_url":"https://api.github.com/repos/reseul/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reseul/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reseul/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/reseul/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reseul/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/reseul/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/reseul/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/reseul/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/reseul/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/reseul/react-native-windows/subscription","commits_url":"https://api.github.com/repos/reseul/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/reseul/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/reseul/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/reseul/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/reseul/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/reseul/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reseul/react-native-windows/merges","archive_url":"https://api.github.com/repos/reseul/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reseul/react-native-windows/downloads","issues_url":"https://api.github.com/repos/reseul/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/reseul/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/reseul/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/reseul/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reseul/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/reseul/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/reseul/react-native-windows/deployments","created_at":"2017-12-06T18:40:10Z","updated_at":"2018-10-08T05:39:17Z","pushed_at":"2018-10-08T05:39:15Z","git_url":"git://github.com/reseul/react-native-windows.git","ssh_url":"git@github.com:reseul/react-native-windows.git","clone_url":"https://github.com/reseul/react-native-windows.git","svn_url":"https://github.com/reseul/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":22118,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0b776449ac410e83f6cdb1a2c35da53425f79580","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"node_id":"MDEwOlJlcG9zaXRvcnk0ODAwOTIxNA==","name":"react-native-windows","full_name":"Microsoft/react-native-windows","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2018-10-08T14:13:07Z","pushed_at":"2018-10-08T04:49:21Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"git@github.com:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":160865,"stargazers_count":5458,"watchers_count":5458,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":440,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":440,"open_issues":190,"watchers":5458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1994"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1994"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1994/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1994/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/8bac650f1c6cc4ce3a61c73139d79e8b8c1a3275"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rozele"}}