{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/comments/206808657","pull_request_review_id":142290947,"id":206808657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjgwODY1Nw==","diff_hunk":"@@ -23,6 +30,23 @@ services:\n       POSTGRES_DB: cla_backend\n \n   # applications\n+  cla_public:\n+    image: ${ECR_ENDPOINT}/cla_public:develop","path":"docker-compose.yaml","position":22,"original_position":22,"commit_id":"c480fd8b431c708161c25ebb9395ba93aa2131fa","original_commit_id":"c480fd8b431c708161c25ebb9395ba93aa2131fa","user":{"login":"sldblog","id":1526295,"node_id":"MDQ6VXNlcjE1MjYyOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1526295?v=4","gravatar_id":"","url":"https://api.github.com/users/sldblog","html_url":"https://github.com/sldblog","followers_url":"https://api.github.com/users/sldblog/followers","following_url":"https://api.github.com/users/sldblog/following{/other_user}","gists_url":"https://api.github.com/users/sldblog/gists{/gist_id}","starred_url":"https://api.github.com/users/sldblog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sldblog/subscriptions","organizations_url":"https://api.github.com/users/sldblog/orgs","repos_url":"https://api.github.com/users/sldblog/repos","events_url":"https://api.github.com/users/sldblog/events{/privacy}","received_events_url":"https://api.github.com/users/sldblog/received_events","type":"User","site_admin":false},"body":"💭 I recently got confused by this while looking at `cla_public`'s build job which got me thinking: it's probably better to expose this URL as it's a bit cryptic like this.","created_at":"2018-08-01T09:17:02Z","updated_at":"2018-08-01T09:17:02Z","html_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests/pull/6#discussion_r206808657","pull_request_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/comments/206808657"},"html":{"href":"https://github.com/ministryofjustice/laa-cla-e2e-tests/pull/6#discussion_r206808657"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6","id":205177530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTc3NTMw","html_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests/pull/6","diff_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests/pull/6.diff","patch_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests/pull/6.patch","issue_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/6","number":6,"state":"open","locked":false,"title":" Start the \"check legal aid\" service during setup","user":{"login":"sldblog","id":1526295,"node_id":"MDQ6VXNlcjE1MjYyOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1526295?v=4","gravatar_id":"","url":"https://api.github.com/users/sldblog","html_url":"https://github.com/sldblog","followers_url":"https://api.github.com/users/sldblog/followers","following_url":"https://api.github.com/users/sldblog/following{/other_user}","gists_url":"https://api.github.com/users/sldblog/gists{/gist_id}","starred_url":"https://api.github.com/users/sldblog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sldblog/subscriptions","organizations_url":"https://api.github.com/users/sldblog/orgs","repos_url":"https://api.github.com/users/sldblog/repos","events_url":"https://api.github.com/users/sldblog/events{/privacy}","received_events_url":"https://api.github.com/users/sldblog/received_events","type":"User","site_admin":false},"body":"## What does this pull request do?\r\n\r\nExtends the `bin/setup` behaviour so http://localhost:5000 becomes available as the \"check legal aid\" ([`cla_public`](https://github.com/ministryofjustice/cla_public)) application.\r\n\r\n## Any other changes which would benefit highlighting?\r\n\r\n### Domain names\r\n💡 During testing we had to make sure the domain names used internally were RFC 1034/1035 compliant, meaning they cannot contain underscores.\r\n\r\nWe settled on using `BACKEND_BASE_URI: http://cla-backend:80` and the `external_links` feature in the end, as it makes this conversion explicit.\r\n\r\n### Application logs\r\n😕 Unfortunately, our applications do not log to stdout or stderr, which makes it inconvenient to follow through `docker-compose logs --follow`.\r\n\r\nIn the interim of fixing that, `bin/tail_cla_backend_logs` and `bin/tail_cla_public_logs` scripts were added.","created_at":"2018-07-31T16:52:35Z","updated_at":"2018-08-01T09:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68ad7da6fa8b110d333ec78f29990dd0b1843bb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/6/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/statuses/c480fd8b431c708161c25ebb9395ba93aa2131fa","head":{"label":"ministryofjustice:add-public","ref":"add-public","sha":"c480fd8b431c708161c25ebb9395ba93aa2131fa","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":139612501,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MTI1MDE=","name":"laa-cla-e2e-tests","full_name":"ministryofjustice/laa-cla-e2e-tests","owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests","description":null,"fork":false,"url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests","forks_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/forks","keys_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/events","assignees_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/merges","archive_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/deployments","created_at":"2018-07-03T16:50:45Z","updated_at":"2018-08-01T08:55:03Z","pushed_at":"2018-08-01T09:14:23Z","git_url":"git://github.com/ministryofjustice/laa-cla-e2e-tests.git","ssh_url":"git@github.com:ministryofjustice/laa-cla-e2e-tests.git","clone_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests.git","svn_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests","homepage":null,"size":76,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"c5029ac92e5a4f3293d3676bb40ebff39cd51852","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":139612501,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MTI1MDE=","name":"laa-cla-e2e-tests","full_name":"ministryofjustice/laa-cla-e2e-tests","owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests","description":null,"fork":false,"url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests","forks_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/forks","keys_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/events","assignees_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/merges","archive_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/deployments","created_at":"2018-07-03T16:50:45Z","updated_at":"2018-08-01T08:55:03Z","pushed_at":"2018-08-01T09:14:23Z","git_url":"git://github.com/ministryofjustice/laa-cla-e2e-tests.git","ssh_url":"git@github.com:ministryofjustice/laa-cla-e2e-tests.git","clone_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests.git","svn_url":"https://github.com/ministryofjustice/laa-cla-e2e-tests","homepage":null,"size":76,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6"},"html":{"href":"https://github.com/ministryofjustice/laa-cla-e2e-tests/pull/6"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/6"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/laa-cla-e2e-tests/statuses/c480fd8b431c708161c25ebb9395ba93aa2131fa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sldblog"}}