{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/23289","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23289/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23289/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23289/events","html_url":"https://github.com/joomla/joomla-cms/pull/23289","id":391484437,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTc3MDQz","number":23289,"title":"[4.0] Admin modules: Cannot select or filter by position","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-16T16:47:41Z","updated_at":"2018-12-18T07:32:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/23289","html_url":"https://github.com/joomla/joomla-cms/pull/23289","diff_url":"https://github.com/joomla/joomla-cms/pull/23289.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/23289.patch"},"body":"https://github.com/joomla/joomla-cms/pull/22263 forgot admin modules\r\n\r\n### Summary of Changes\r\nChange type of the position field for admin modules.\r\nSetting the correct client id.\r\n\r\n### Testing Instructions\r\nInstall j4 from 4.0-dev or nightly.\r\nDisplay Administrator Modules Manager\r\nCreate or edit one these modules.\r\n\r\nNote: there are other errors \r\n### Expected result\r\nThe `Position` field should be similar to the one used for Site Modules, i.e. letting clear, select, set to None the position.\r\nFiltering by position should display the administrator template positions\r\n\r\n\r\n### Actual result\r\nFor the manager, positions are sometimes the ones from the frontend template in the filter\r\n<img width=\"1386\" alt=\"screen shot 2018-12-16 at 17 36 51\" src=\"https://user-images.githubusercontent.com/869724/50056204-59b10000-0159-11e9-868c-14c172064ed9.png\">\r\n\r\nEditing the admin module displays a simple field\r\n<img width=\"1375\" alt=\"screen shot 2018-12-16 at 17 37 09\" src=\"https://user-images.githubusercontent.com/869724/50056219-85cc8100-0159-11e9-9045-6edeaaeb622f.png\">\r\n\r\n### After patch\r\n\r\n<img width=\"1391\" alt=\"screen shot 2018-12-16 at 17 26 51\" src=\"https://user-images.githubusercontent.com/869724/50056160-a34d1b00-0158-11e9-8428-cc52f4c48d7d.png\">\r\n\r\n<img width=\"1366\" alt=\"screen shot 2018-12-16 at 17 27 13\" src=\"https://user-images.githubusercontent.com/869724/50056166-acd68300-0158-11e9-9507-a701ad224d55.png\">\r\n\r\n### Note\r\nThere are other errors, not only related to admin modules.\r\n1. The calendar icons are showing over the position dropdown (see image above)\r\n2. After filtering in the manager by anything else than Select and clicking anywhere on the page, the filter fields are displayed horizontally on the page, hiding some items.\r\n<img width=\"1403\" alt=\"screen shot 2018-12-16 at 17 40 57\" src=\"https://user-images.githubusercontent.com/869724/50056248-ce843a00-0159-11e9-89b7-93de2b30ae79.png\">\r\n\r\n### General Comment\r\nThe decision to take off from the Modules Manager the Site/Admin filter is at the origin of some issues concerning `userstate` and filters specially when a user switches from one to the other via the menu or System CPanel.\r\n\r\n@Fedik "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/448123684","html_url":"https://github.com/joomla/joomla-cms/pull/23289#issuecomment-448123684","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23289","id":448123684,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODEyMzY4NA==","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T07:32:00Z","updated_at":"2018-12-18T07:32:00Z","author_association":"MEMBER","body":"Modified to use `getUserState`\r\nPlease test."}}
{"actor":{"display_login":"infograf768"}}