{"action":"created","issue":{"url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers/issues/110","repository_url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers","labels_url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers/issues/110/comments","events_url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers/issues/110/events","html_url":"https://github.com/DIGImend/digimend-kernel-drivers/issues/110","id":289181373,"number":110,"title":"Add support for GAOMON PD1560","user":{"login":"loentar","id":4038431,"avatar_url":"https://avatars0.githubusercontent.com/u/4038431?v=4","gravatar_id":"","url":"https://api.github.com/users/loentar","html_url":"https://github.com/loentar","followers_url":"https://api.github.com/users/loentar/followers","following_url":"https://api.github.com/users/loentar/following{/other_user}","gists_url":"https://api.github.com/users/loentar/gists{/gist_id}","starred_url":"https://api.github.com/users/loentar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loentar/subscriptions","organizations_url":"https://api.github.com/users/loentar/orgs","repos_url":"https://api.github.com/users/loentar/repos","events_url":"https://api.github.com/users/loentar/events{/privacy}","received_events_url":"https://api.github.com/users/loentar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2018-01-17T08:35:17Z","updated_at":"2018-05-08T10:18:35Z","closed_at":null,"author_association":"NONE","body":"pd1560 is an high-precision pen display produced by Gaomon company.\r\n\r\nThis pen display is recognized by this driver as HUION tablet and partially works in compatibility mode. Pressure sensor is not fully working (cropped at 2047 but max is 8191) as well as the last button is cannot be bound with `xsetwacom` because it is recognized as X axis.\r\n\r\nWith the pull request https://github.com/DIGImend/digimend-kernel-drivers/pull/114 which enables high-precision mode for HUION tablets issues with pressure and buttons are fixed. But it introduces another issue. This tablet has maximum X = 68834 which cause 16-bit overflow and it's not usable on the very right side (cursor jumps back to the left side after x> 65535).\r\n\r\nAs temporary fix I applied this code in `uclogic_raw_event`:\r\n\r\n```\r\nif (data[0] == 0x08 && (data[1] & 0xFE) == 0x80 && drvdata->is_hires && size >= 12) {\r\n    // fix tablet\r\n    u16 *data16 = (u16*)data;\r\n    data16[1] = ((data16[1] >> 1) & 0x7FFF) | (data16[4] << 15);\r\n    data16[2] = ((data16[2] >> 1) & 0x7FFF) | (data16[5] << 15);\r\n    data16[4] = 0;\r\n    data16[5] = 0;\r\n}\r\n```\r\n\r\nAs @anpaza mentioned in that pull request, 32-bit mode is the correct way to work with this tablet. But it needs to detect this model and re-mix the bytes to make the event HID-compliant.\r\n\r\nThe string 0x79 is not actually string and contains value 0x03. Also there is another string number 0xC9 which looks like some OEM id: \r\n```\r\n c9 |      Unknown string #1: OEM02_M177_170831\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers/issues/comments/387355936","html_url":"https://github.com/DIGImend/digimend-kernel-drivers/issues/110#issuecomment-387355936","issue_url":"https://api.github.com/repos/DIGImend/digimend-kernel-drivers/issues/110","id":387355936,"user":{"login":"veryprofessionaldodo","id":22790704,"avatar_url":"https://avatars2.githubusercontent.com/u/22790704?v=4","gravatar_id":"","url":"https://api.github.com/users/veryprofessionaldodo","html_url":"https://github.com/veryprofessionaldodo","followers_url":"https://api.github.com/users/veryprofessionaldodo/followers","following_url":"https://api.github.com/users/veryprofessionaldodo/following{/other_user}","gists_url":"https://api.github.com/users/veryprofessionaldodo/gists{/gist_id}","starred_url":"https://api.github.com/users/veryprofessionaldodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veryprofessionaldodo/subscriptions","organizations_url":"https://api.github.com/users/veryprofessionaldodo/orgs","repos_url":"https://api.github.com/users/veryprofessionaldodo/repos","events_url":"https://api.github.com/users/veryprofessionaldodo/events{/privacy}","received_events_url":"https://api.github.com/users/veryprofessionaldodo/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T10:18:35Z","updated_at":"2018-05-08T10:18:35Z","author_association":"NONE","body":"I had installed it from the AUR, but it looks like it isn't that up to date. I uninstalled my previous version, installed directly from the repository, and now I get these results.\r\n\r\n[probe.txt](https://github.com/DIGImend/digimend-kernel-drivers/files/1983402/probe.txt)\r\n\r\n\r\n"}}
{"actor":{"display_login":"veryprofessionaldodo"}}