{"push_id":2799127014,"size":61,"distinct_size":10,"ref":"refs/heads/use_utf8mb4","head":"817d1b16f61d552dffd3c89360a80e11e584e12f","before":"3cad54b7d92cbfea1c5fa99bfb6b2f3bf357cf5f","commits":[{"sha":"2e5cb980a448e7f4ab00df6e9ad4c1cc456616aa","author":{"name":"Bogdan Gusiev","email":"008a54eb6d71a5859627c196c2a3ca841721862c@gmail.com"},"message":"Fix AM::Serializers::JSON#as_json method for timestamps\n\nAccording to doc the method should return\nnon-json compatible types as strings.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/2e5cb980a448e7f4ab00df6e9ad4c1cc456616aa"},{"sha":"c3787494eda85d42d62f74c22e56e56e1263ea60","author":{"name":"gingerlime","email":"5d2e33f2c005733405d84da249995e6fe1b8bfe9@gingerlime.com"},"message":"fixes #27157 CSRF protection documentation\n\n* removed reference to GET requests where it applies also to other HTTP verbs\r\n* updated documentation to try and better explain how CSRF protection\r\n   works with XHR, and the potential exposure with CORS","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/c3787494eda85d42d62f74c22e56e56e1263ea60"},{"sha":"d2a91a7f90584dd3552430740c549d8c9257a588","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Factor out some common bundler mocking logic","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/d2a91a7f90584dd3552430740c549d8c9257a588"},{"sha":"3b0c1ef9c4b4a255d5069316f05338e404d5bd96","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Improve readability of some specs","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/3b0c1ef9c4b4a255d5069316f05338e404d5bd96"},{"sha":"ee8d7850fd38b4602dc1d40323addc3448b60947","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Generate bundler-compatible bundler binstub","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/ee8d7850fd38b4602dc1d40323addc3448b60947"},{"sha":"4a2d5efa949695ba2d62a05efd0c5822017855d3","author":{"name":"Olivier Lacan","email":"c22b5f9178342609428d6f51b2c5af4c0bde6a42@olivierlacan.com"},"message":"Document best practices with old migrations\n\nThe copy here is of course up for discussion but it feels like we need\nto address the issue of old migrations in the Migration guide because\nother than mentioning the canonical nature of schema.rb/structure.sql\nor the actual database compared to migration files, it seems like more\nguidance would help.\n\nHere's a sample of the kinds of question people seem to often ask about\nold Rails migrations:\n\n- https://stackoverflow.com/questions/20119391/delete-old-migrations-files-in-a-rails-app\n- https://www.reddit.com/r/rails/comments/4ayosd/compacting_migrations_files_or_delete_them/\n- https://stackoverflow.com/questions/4248682/is-it-a-good-idea-to-purge-old-rails-migration-files\n- https://stackoverflow.com/questions/707013/is-it-a-good-idea-to-collapse-old-rails-migrations\n- https://stackoverflow.com/questions/1981777/rails-remove-old-models-with-migrations\n- https://stackoverflow.com/questions/3343534/rebase-rails-migrations-in-a-long-running-project\n\nThe common theme seems to be: \"I've got old migrations, should I keep\nthem around on an old project?\".\n\nMy personal stance is that as long as migrations run and don't take too long do\nso, you should keep them around since it allows people working on the Rails\nproject with you to seamlessly upgrade their local development database\nwithout having to do a `db:drop db:schema:load` and lose all their seed data.\n\nWhile writing down this suggested new section it felt like I was describing a\nvery cumbersome process that could be address with a rake task like:\n\n```bash\nrails db:migrate:remove VERSION=20121201123456\n```\n\nIt rollback to the version just before `20121201123456`, delete the migration\nfile, and run `db:migrate` to get back to the latest migration.\n\nThis of course doesn't address a situation when someone would want to delete or\nmerge all migrations prior to a certain date, which is addressed by\n[squasher](https://github.com/jalkoby/squasher).\n\nI'm not sure this is something we want to encourage people to do. Although I\nfeel like with more and more production Rails apps over 5-years old, it's\ndefinitely a concern we should address.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/4a2d5efa949695ba2d62a05efd0c5822017855d3"},{"sha":"d0edc9c7ae9a7fbb945f34b75cc0be342196708d","author":{"name":"bogdanvlviv","email":"0432f6e91c72b299590585bdcfd70d05278d8041@gmail.com"},"message":"Ensure that running tests in parallel doesn't display schema load output\n\nhttps://github.com/rails/rails/pull/33479 changed `#load_schema` to\nprevent displaying schema load on running tests in parallel.\nWe should test this in order to prevent any regression in the future.\n\nContext https://github.com/rails/rails/pull/33479#discussion_r206870727","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/d0edc9c7ae9a7fbb945f34b75cc0be342196708d"},{"sha":"847e6915268e1ff1a1aeb5c48c7d9af01e2ff383","author":{"name":"Lukas Zapletal","email":"c17001c3b23efd97e9bd40fd0b0c6b005045e51d@redhat.com"},"message":"ActiveRecord Guide - sqlite3 foreign keys note","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/847e6915268e1ff1a1aeb5c48c7d9af01e2ff383"},{"sha":"697f4a93ad386f9fb7795f0ba68f815f16ebad0f","author":{"name":"George Claghorn","email":"f8b057b45279f5cf5e056a79e479e4c5c7e6ce59@gmail.com"},"message":"Extract transformers","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/697f4a93ad386f9fb7795f0ba68f815f16ebad0f"},{"sha":"5f9f39eb9c99475706a322e368274a48dd15a1ff","author":{"name":"Richard Schneeman","email":"d1820088e1cf067a2bc370052c48f5b3c46c3f57@gmail.com"},"message":"Merge pull request #31640 from gingerlime/patch-1\n\nfixes #27157 CSRF protection documentation","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/5f9f39eb9c99475706a322e368274a48dd15a1ff"},{"sha":"77c239e2c92309f96fe7f97b2cadeac2c4994ae0","author":{"name":"Dillon Welch","email":"dbb514a198f3d52bf511a8f1ac3e9d79e4200130@gmail.com"},"message":"Use strings instead of symbols on calls to decorate_matching_attribute_types\n\nThe first thing this method does is run  on the argument. This change passes\nin a string so we don't allocate a bunch of unnecessary extra strings by\ncalling to_s on a symbol over and over.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/77c239e2c92309f96fe7f97b2cadeac2c4994ae0"},{"sha":"18425b837149bc0d50f8d5349e1091a623762d6b","author":{"name":"George Claghorn","email":"f8b057b45279f5cf5e056a79e479e4c5c7e6ce59@gmail.com"},"message":"Add a generic base class for Active Storage exceptions\n\nCloses #33292.\n\n[Andrei Makarov & George Claghorn]","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/18425b837149bc0d50f8d5349e1091a623762d6b"},{"sha":"2d3a28b949f2e8a0b755afdb52cbcd55e5ac0d98","author":{"name":"George Claghorn","email":"f8b057b45279f5cf5e056a79e479e4c5c7e6ce59@gmail.com"},"message":"Document all Active Storage error classes [ci skip]","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/2d3a28b949f2e8a0b755afdb52cbcd55e5ac0d98"},{"sha":"2cb87e3b31e3152475347c667d0b8a05a93d8918","author":{"name":"Eileen M. Uchitelle","email":"7a0559213618bb59f33e95efd260811728549345@users.noreply.github.com"},"message":"Merge pull request #33553 from bogdanvlviv/ensure-load_schema-does_not-output-in-parallel-tests-execution\n\nEnsure that running tests in parallel doesn't display schema load output","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/2cb87e3b31e3152475347c667d0b8a05a93d8918"},{"sha":"920c9195e0e27077af003973e45d0146a30e51b4","author":{"name":"Eileen M. Uchitelle","email":"7a0559213618bb59f33e95efd260811728549345@users.noreply.github.com"},"message":"Merge pull request #33202 from deivid-rodriguez/bundler_binstubs\n\nBundler binstubs","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/920c9195e0e27077af003973e45d0146a30e51b4"},{"sha":"09e1452eeba395ce475b087070273e4765dc2fd4","author":{"name":"Eileen M. Uchitelle","email":"7a0559213618bb59f33e95efd260811728549345@users.noreply.github.com"},"message":"Merge pull request #31503 from bogdan/timestamp-as-json\n\nFix AM::Serializers::JSON#as_json method for timestamps","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/09e1452eeba395ce475b087070273e4765dc2fd4"},{"sha":"a486210c982f0e8ce4dd5ea70d1acd5e488c6bd6","author":{"name":"Vinicius Stock","email":"94e670838b0deeed8d6883d9d095e48be7cc12b5@outlook.com"},"message":"Make active job name prefix static since Rails.env will always be the same","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/a486210c982f0e8ce4dd5ea70d1acd5e488c6bd6"},{"sha":"2c667814c8ea47a5e73b60a2bd846bd31fef3a32","author":{"name":"bogdanvlviv","email":"0432f6e91c72b299590585bdcfd70d05278d8041@gmail.com"},"message":"`bundle binstubs bundler` should be executed after `bundle install`\n\nFixes:\n\n`bundle binstubs bundler` doesn't generate `bin/bundle` for newly\ngenerated Rails app.\n\n```\n...\n(snip)\nrun  bundle binstubs bundler\nThe git source https://github.com/rails/web-console.git is not yet checked out.\nPlease run `bundle install` before trying to start your application\nrun  bundle install\nFetching https://github.com/rails/web-console.git\n(snip)\n...\n```\n\nRelated to #33202","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/2c667814c8ea47a5e73b60a2bd846bd31fef3a32"},{"sha":"c3e17bbad88326bd0cb1fcd775c2b2a2929ce59e","author":{"name":"George Claghorn","email":"f8b057b45279f5cf5e056a79e479e4c5c7e6ce59@gmail.com"},"message":"Merge pull request #33586 from vinistock/make_active_job_name_prefix_static\n\nMake active job name prefix static since Rails.env will always be the same","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/c3e17bbad88326bd0cb1fcd775c2b2a2929ce59e"},{"sha":"3a0a8cf60406b53c865e80017daaea3d280030c5","author":{"name":"bogdanvlviv","email":"0432f6e91c72b299590585bdcfd70d05278d8041@gmail.com"},"message":"Fix test failure\n\n```\n...\n(snip)\n............F\nFailure:\nJsonSerializationTest#test_as_json_should_return_a_hash_if_include_root_\nin_json_is_true [/home/travis/build/rails/rails/activemodel/test/cases/serializers/json_serialization_test.rb:145]:\nExpected: 2006-08-01 00:00:00 UTC\n  Actual: \"2006-08-01T00:00:00.000Z\"\nrails test home/travis/build/rails/rails/activemodel/test/cases/serializers/json_serialization_test.rb:136\n(snip)\n...\n```\n\nRelated to #31503","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/3a0a8cf60406b53c865e80017daaea3d280030c5"}]}
{"actor":{"display_login":"yahonda"}}