{"action":"opened","number":69,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/69","id":221224899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjI0ODk5","html_url":"https://github.com/theforeman/foreman_bootdisk/pull/69","diff_url":"https://github.com/theforeman/foreman_bootdisk/pull/69.diff","patch_url":"https://github.com/theforeman/foreman_bootdisk/pull/69.patch","issue_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues/69","number":69,"state":"open","locked":false,"title":"fixes #25120 - use medium provider interface","user":{"login":"timogoebel","id":4107560,"node_id":"MDQ6VXNlcjQxMDc1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4107560?v=4","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"body":"This commit makes use of the new medium provider interface to build the full host image as the old way of calling the methods is deprecated and will be removed in 1.22.\r\nThe embedded PXElinux template is now rendered in it's own template scope (yay, new renderer!) so we can avoid ugly `gsub` string replacement hacks.\r\n\r\nThis also prepares foreman_bootdisk for frozen strings.\r\n\r\nAnd all of this removes this loop, which is very hard to digest:\r\n\r\nhttps://github.com/theforeman/foreman_bootdisk/blob/15ed6d9a84eb2920abced036691a8ccc2c3f0f13/app/services/foreman_bootdisk/iso_generator.rb#L23-L31","created_at":"2018-10-08T19:50:26Z","updated_at":"2018-10-08T19:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/69/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/69/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues/69/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/statuses/ba7b268c7765e07f6ed8b807b42a95a04e1186d2","head":{"label":"timogoebel:25120-medium-provider-interface","ref":"25120-medium-provider-interface","sha":"ba7b268c7765e07f6ed8b807b42a95a04e1186d2","user":{"login":"timogoebel","id":4107560,"node_id":"MDQ6VXNlcjQxMDc1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4107560?v=4","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"repo":{"id":46972587,"node_id":"MDEwOlJlcG9zaXRvcnk0Njk3MjU4Nw==","name":"foreman_bootdisk","full_name":"timogoebel/foreman_bootdisk","private":false,"owner":{"login":"timogoebel","id":4107560,"node_id":"MDQ6VXNlcjQxMDc1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4107560?v=4","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/timogoebel/foreman_bootdisk","description":"ISO and USB boot disk support for Foreman","fork":true,"url":"https://api.github.com/repos/timogoebel/foreman_bootdisk","forks_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/forks","keys_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/teams","hooks_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/hooks","issue_events_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/issues/events{/number}","events_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/events","assignees_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/assignees{/user}","branches_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/branches{/branch}","tags_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/tags","blobs_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/statuses/{sha}","languages_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/languages","stargazers_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/stargazers","contributors_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/contributors","subscribers_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/subscribers","subscription_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/subscription","commits_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/contents/{+path}","compare_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/merges","archive_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/downloads","issues_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/issues{/number}","pulls_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/pulls{/number}","milestones_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/milestones{/number}","notifications_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/labels{/name}","releases_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/releases{/id}","deployments_url":"https://api.github.com/repos/timogoebel/foreman_bootdisk/deployments","created_at":"2015-11-27T09:50:27Z","updated_at":"2015-11-27T09:50:28Z","pushed_at":"2018-10-08T19:42:18Z","git_url":"git://github.com/timogoebel/foreman_bootdisk.git","ssh_url":"git@github.com:timogoebel/foreman_bootdisk.git","clone_url":"https://github.com/timogoebel/foreman_bootdisk.git","svn_url":"https://github.com/timogoebel/foreman_bootdisk","homepage":null,"size":559,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"15ed6d9a84eb2920abced036691a8ccc2c3f0f13","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":12843042,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MzA0Mg==","name":"foreman_bootdisk","full_name":"theforeman/foreman_bootdisk","private":false,"owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theforeman/foreman_bootdisk","description":"ISO and USB boot disk support for Foreman","fork":false,"url":"https://api.github.com/repos/theforeman/foreman_bootdisk","forks_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/forks","keys_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/events","assignees_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/merges","archive_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman_bootdisk/deployments","created_at":"2013-09-15T09:10:13Z","updated_at":"2018-10-04T10:52:33Z","pushed_at":"2018-10-04T10:52:31Z","git_url":"git://github.com/theforeman/foreman_bootdisk.git","ssh_url":"git@github.com:theforeman/foreman_bootdisk.git","clone_url":"https://github.com/theforeman/foreman_bootdisk.git","svn_url":"https://github.com/theforeman/foreman_bootdisk","homepage":null,"size":568,"stargazers_count":46,"watchers_count":46,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":52,"open_issues":7,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/69"},"html":{"href":"https://github.com/theforeman/foreman_bootdisk/pull/69"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues/69"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman_bootdisk/statuses/ba7b268c7765e07f6ed8b807b42a95a04e1186d2"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":100,"deletions":59,"changed_files":6}}
{"actor":{"display_login":"timogoebel"}}