{"action":"created","issue":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/970","repository_url":"https://api.github.com/repos/sxs-collaboration/spectre","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/970/labels{/name}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/970/comments","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/970/events","html_url":"https://github.com/sxs-collaboration/spectre/pull/970","id":361892127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzQ4NDY4","number":970,"title":"Implement ComplexDataVector","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"labels":[{"id":858685544,"node_id":"MDU6TGFiZWw4NTg2ODU1NDQ=","url":"https://api.github.com/repos/sxs-collaboration/spectre/labels/dependent","name":"dependent","color":"006b75","default":false},{"id":1143756812,"node_id":"MDU6TGFiZWwxMTQzNzU2ODEy","url":"https://api.github.com/repos/sxs-collaboration/spectre/labels/updated","name":"updated","color":"f711a3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-19T19:22:05Z","updated_at":"2018-12-21T00:41:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/970","html_url":"https://github.com/sxs-collaboration/spectre/pull/970","diff_url":"https://github.com/sxs-collaboration/spectre/pull/970.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/970.patch"},"body":"## Proposed changes\r\n\r\nAdd the class `ComplexDataVector`, along with all attendant specializations\r\nappropriate for a spectre Vector storing complex variables.\r\n\r\n- defined a specialization of\r\n`VectorImpl<std::complex<double>,ComplexDataVector>`\r\n- ComplexDataVectors have arithmetic operations defined for DataVectors and\r\ndoubles just as `std::complex<double>`s have arithmetic operations with\r\ndoubles\r\n- some math functions do not work on ComplexDataVectors, but imag, abs, and\r\nreal return DataVectors (real values)\r\n- tests take heavily from `Test_DataVector.cpp`, but include tests of math\r\noperations between ComplexDataVector and real types\r\n\r\n### Types of changes:\r\n\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n- [ ] Depends on #1247"},"comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments/449188993","html_url":"https://github.com/sxs-collaboration/spectre/pull/970#issuecomment-449188993","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/970","id":449188993,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTE4ODk5Mw==","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T00:41:55Z","updated_at":"2018-12-21T00:41:55Z","author_association":"CONTRIBUTOR","body":"Rebased and made several adjustments from the VectorImpl changes. I think I've also addressed all of the current comments on the code.\r\nCheers!"}}
{"actor":{"display_login":"moxcodes"}}