{"action":"created","comment":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/217970947","pull_request_review_id":155805209,"id":217970947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzk3MDk0Nw==","diff_hunk":"@@ -52,10 +53,17 @@\n   /** Caller must pre-seek the provided {@link IndexInput} to the index location that {@link BKDWriter#finish} returned */\n   public BKDReader(IndexInput in) throws IOException {\n     version = CodecUtil.checkHeader(in, BKDWriter.CODEC_NAME, BKDWriter.VERSION_START, BKDWriter.VERSION_CURRENT);\n-    numDims = in.readVInt();\n+    int packedDims = in.readVInt();\n+    if (version >= BKDWriter.VERSION_LEAF_STORES_BOUNDS) {\n+      numDataDims = packedDims & 0x0000FFFF;\n+      numIndexDims = packedDims >>> 16;\n+    } else {\n+      numDataDims = packedDims;\n+      numIndexDims = numDataDims;\n+    }","path":"lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java","position":22,"original_position":22,"commit_id":"fd0d8e65a62754315b9f5a03a28172fdb3166e2c","original_commit_id":"fd0d8e65a62754315b9f5a03a28172fdb3166e2c","user":{"login":"iverase","id":29038686,"node_id":"MDQ6VXNlcjI5MDM4Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/29038686?v=4","gravatar_id":"","url":"https://api.github.com/users/iverase","html_url":"https://github.com/iverase","followers_url":"https://api.github.com/users/iverase/followers","following_url":"https://api.github.com/users/iverase/following{/other_user}","gists_url":"https://api.github.com/users/iverase/gists{/gist_id}","starred_url":"https://api.github.com/users/iverase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iverase/subscriptions","organizations_url":"https://api.github.com/users/iverase/orgs","repos_url":"https://api.github.com/users/iverase/repos","events_url":"https://api.github.com/users/iverase/events{/privacy}","received_events_url":"https://api.github.com/users/iverase/received_events","type":"User","site_admin":false},"body":"Should we create a new version of the tree for this change and not mix it up with VERSION_LEAF_STORES_BOUNDS? ","created_at":"2018-09-17T07:36:32Z","updated_at":"2018-09-17T07:46:11Z","html_url":"https://github.com/apache/lucene-solr/pull/451#discussion_r217970947","pull_request_url":"https://api.github.com/repos/apache/lucene-solr/pulls/451","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/217970947"},"html":{"href":"https://github.com/apache/lucene-solr/pull/451#discussion_r217970947"},"pull_request":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/451","id":215680950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjgwOTUw","html_url":"https://github.com/apache/lucene-solr/pull/451","diff_url":"https://github.com/apache/lucene-solr/pull/451.diff","patch_url":"https://github.com/apache/lucene-solr/pull/451.patch","issue_url":"https://api.github.com/repos/apache/lucene-solr/issues/451","number":451,"state":"open","locked":false,"title":"LUCENE-8496: Add selective indexing to BKD/POINTS codec","user":{"login":"nknize","id":830187,"node_id":"MDQ6VXNlcjgzMDE4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/830187?v=4","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"body":"PR for [LUCENE-8496](https://issues.apache.org/jira/browse/LUCENE-8496) enabling fields to use the first `numIndexDimensions` from `numDataDimensions` while creating the BKD index.","created_at":"2018-09-14T18:51:18Z","updated_at":"2018-09-17T07:46:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e4fe06e71f145dd24fdd00687d320597d9ab60c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/lucene-solr/pulls/451/commits","review_comments_url":"https://api.github.com/repos/apache/lucene-solr/pulls/451/comments","review_comment_url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/lucene-solr/issues/451/comments","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/fd0d8e65a62754315b9f5a03a28172fdb3166e2c","head":{"label":"nknize:selectiveIndexing","ref":"selectiveIndexing","sha":"fd0d8e65a62754315b9f5a03a28172fdb3166e2c","user":{"login":"nknize","id":830187,"node_id":"MDQ6VXNlcjgzMDE4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/830187?v=4","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"repo":{"id":140608299,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2MDgyOTk=","name":"lucene-solr","full_name":"nknize/lucene-solr","private":false,"owner":{"login":"nknize","id":830187,"node_id":"MDQ6VXNlcjgzMDE4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/830187?v=4","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nknize/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/nknize/lucene-solr","forks_url":"https://api.github.com/repos/nknize/lucene-solr/forks","keys_url":"https://api.github.com/repos/nknize/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nknize/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nknize/lucene-solr/teams","hooks_url":"https://api.github.com/repos/nknize/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/nknize/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/nknize/lucene-solr/events","assignees_url":"https://api.github.com/repos/nknize/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/nknize/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/nknize/lucene-solr/tags","blobs_url":"https://api.github.com/repos/nknize/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nknize/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nknize/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/nknize/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nknize/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/nknize/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/nknize/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/nknize/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/nknize/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/nknize/lucene-solr/subscription","commits_url":"https://api.github.com/repos/nknize/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/nknize/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/nknize/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/nknize/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/nknize/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/nknize/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nknize/lucene-solr/merges","archive_url":"https://api.github.com/repos/nknize/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nknize/lucene-solr/downloads","issues_url":"https://api.github.com/repos/nknize/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/nknize/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/nknize/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/nknize/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nknize/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/nknize/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/nknize/lucene-solr/deployments","created_at":"2018-07-11T17:29:01Z","updated_at":"2018-08-08T20:20:50Z","pushed_at":"2018-09-14T20:00:16Z","git_url":"git://github.com/nknize/lucene-solr.git","ssh_url":"git@github.com:nknize/lucene-solr.git","clone_url":"https://github.com/nknize/lucene-solr.git","svn_url":"https://github.com/nknize/lucene-solr","homepage":null,"size":361079,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"39733cbf5ff9d8587d418007bd13087a434a1aa2","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50229487,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIyOTQ4Nw==","name":"lucene-solr","full_name":"apache/lucene-solr","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":false,"url":"https://api.github.com/repos/apache/lucene-solr","forks_url":"https://api.github.com/repos/apache/lucene-solr/forks","keys_url":"https://api.github.com/repos/apache/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/lucene-solr/teams","hooks_url":"https://api.github.com/repos/apache/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/apache/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/lucene-solr/events","assignees_url":"https://api.github.com/repos/apache/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/lucene-solr/tags","blobs_url":"https://api.github.com/repos/apache/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/apache/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/apache/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/apache/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/apache/lucene-solr/subscription","commits_url":"https://api.github.com/repos/apache/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/lucene-solr/merges","archive_url":"https://api.github.com/repos/apache/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/lucene-solr/downloads","issues_url":"https://api.github.com/repos/apache/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/apache/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/lucene-solr/deployments","created_at":"2016-01-23T08:00:06Z","updated_at":"2018-09-17T02:29:57Z","pushed_at":"2018-09-16T17:39:33Z","git_url":"git://github.com/apache/lucene-solr.git","ssh_url":"git@github.com:apache/lucene-solr.git","clone_url":"https://github.com/apache/lucene-solr.git","svn_url":"https://github.com/apache/lucene-solr","homepage":null,"size":364573,"stargazers_count":1941,"watchers_count":1941,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1518,"mirror_url":null,"archived":false,"open_issues_count":236,"license":null,"forks":1518,"open_issues":236,"watchers":1941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/451"},"html":{"href":"https://github.com/apache/lucene-solr/pull/451"},"issue":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/451"},"comments":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/apache/lucene-solr/statuses/fd0d8e65a62754315b9f5a03a28172fdb3166e2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"iverase"}}