{"action":"created","issue":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/5936","repository_url":"https://api.github.com/repos/pantsbuild/pants","labels_url":"https://api.github.com/repos/pantsbuild/pants/issues/5936/labels{/name}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/5936/comments","events_url":"https://api.github.com/repos/pantsbuild/pants/issues/5936/events","html_url":"https://github.com/pantsbuild/pants/pull/5936","id":330570042,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTQ1Nzg0","number":5936,"title":"use liblzma.dylib for xz on osx and add platform-specific testing to the rust osx shard","user":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-08T08:42:14Z","updated_at":"2018-06-08T09:47:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/5936","html_url":"https://github.com/pantsbuild/pants/pull/5936","diff_url":"https://github.com/pantsbuild/pants/pull/5936.diff","patch_url":"https://github.com/pantsbuild/pants/pull/5936.patch"},"body":"### Problem\r\n\r\nSee #5928. The `xz` archiver wasn't tested on osx at all, and failed to find `liblzma.so` on osx (it should have been `liblzma.dylib`). There were additional errors with library search paths reported in that PR which I was not immediately able to repro. This PR hopefully fixes all of those errors, and ensures they won't happen again with the addition of platform-specific testing (see previous issue at #5920).\r\n\r\n### Solution\r\n\r\n- Introduce `_liblzma_shared_lib_filename(cls)` to `XZCompressedTarArchiver` to get the platform-specific shared library filename (with a TODO left for after #5815).\r\n- Fix the incorrect key `'darwin'` in the platform dictionary in the `LLVM` subsystem (to `'mac'`).\r\n- Add the tag `platform_specific_behavior` to the new python target `tests/python/pants_test/backend/python/tasks:python_native_code_testing`, which covers the production of `python_dist()`s with native code.\r\n- Add the `-z` argument to `build-support/bin/ci.sh` to run all tests with the `platform_specific_behavior` tag. Also clean up old unused options in the getopts call, and convert echo statements to a simpler heredoc.\r\n- Change the name of the \"Rust Tests OSX\" shard to \"Rust + Platform-specific Tests OSX\", and add the `-z` switch to the `ci.sh` invocation.\r\n\r\n**Note:** the tests in `tests/python/pants_test/backend/native/subsystems` are going to be removed in #5815, otherwise they would be tagged similarly.\r\n\r\n### Result\r\n\r\n`./pants test tests/python/pants_test/backend/python/tasks:python_native_code_testing` now passes on osx, and this fact is now being tested in an osx shard in travis."},"comment":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/comments/395710572","html_url":"https://github.com/pantsbuild/pants/pull/5936#issuecomment-395710572","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/5936","id":395710572,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTcxMDU3Mg==","user":{"login":"illicitonion","id":1131704,"node_id":"MDQ6VXNlcjExMzE3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1131704?v=4","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T09:47:37Z","updated_at":"2018-06-08T09:47:37Z","author_association":"CONTRIBUTOR","body":"Also, the new CI shard is failing with:\r\n`/build-support/bin/ci.sh: line 235: ./pants.pex: No such file or directory`"}}
{"actor":{"display_login":"illicitonion"}}