{"action":"closed","number":403,"pull_request":{"url":"https://api.github.com/repos/pricelinelabs/design-system/pulls/403","id":227969249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTY5MjQ5","html_url":"https://github.com/pricelinelabs/design-system/pull/403","diff_url":"https://github.com/pricelinelabs/design-system/pull/403.diff","patch_url":"https://github.com/pricelinelabs/design-system/pull/403.patch","issue_url":"https://api.github.com/repos/pricelinelabs/design-system/issues/403","number":403,"state":"closed","locked":false,"title":"Use SVGR for icon build setup","user":{"login":"jxnblk","id":3451712,"node_id":"MDQ6VXNlcjM0NTE3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3451712?v=4","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"body":"This PR uses [SVGR](https://github.com/smooth-code/svgr) (instead of [Pixo](https://github.com/c8r/pixo)) for the icon build configuration, which is a better-maintained library that converts SVGs to React components. It also adds an `isIcon` static property to each icon component to work with the changes in #361.\r\n\r\nBecause SVGR has different configuration options, this PR also:\r\n- Adds a `create-index.js` script to generate the `src/index.js` file\r\n- Adds a wrapping `Svg` component for styled-components/styled-system\r\n- Adds an `svgr.config.js` file to configure SVGR and use a custom template\r\n\r\nNote: the `<svg>` element is nested in the rendered output. This is valid syntax and is due to a limitation with how SVGR can be configured","created_at":"2018-11-02T15:15:21Z","updated_at":"2018-12-17T20:22:32Z","closed_at":"2018-12-17T20:22:32Z","merged_at":"2018-12-17T20:22:32Z","merge_commit_sha":"e95349737f56eb7fe5f0c3ebbeab4db512822f28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":781997320,"node_id":"MDU6TGFiZWw3ODE5OTczMjA=","url":"https://api.github.com/repos/pricelinelabs/design-system/labels/2.0.0","name":"2.0.0","color":"2386ef","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pricelinelabs/design-system/pulls/403/commits","review_comments_url":"https://api.github.com/repos/pricelinelabs/design-system/pulls/403/comments","review_comment_url":"https://api.github.com/repos/pricelinelabs/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pricelinelabs/design-system/issues/403/comments","statuses_url":"https://api.github.com/repos/pricelinelabs/design-system/statuses/49577b1b62dba4d8b4515cbcc7fea9f3aa958c8d","head":{"label":"pricelinelabs:icons-svgr","ref":"icons-svgr","sha":"49577b1b62dba4d8b4515cbcc7fea9f3aa958c8d","user":{"login":"pricelinelabs","id":6863750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjM3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6863750?v=4","gravatar_id":"","url":"https://api.github.com/users/pricelinelabs","html_url":"https://github.com/pricelinelabs","followers_url":"https://api.github.com/users/pricelinelabs/followers","following_url":"https://api.github.com/users/pricelinelabs/following{/other_user}","gists_url":"https://api.github.com/users/pricelinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/pricelinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pricelinelabs/subscriptions","organizations_url":"https://api.github.com/users/pricelinelabs/orgs","repos_url":"https://api.github.com/users/pricelinelabs/repos","events_url":"https://api.github.com/users/pricelinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/pricelinelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":97530717,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUzMDcxNw==","name":"design-system","full_name":"pricelinelabs/design-system","private":false,"owner":{"login":"pricelinelabs","id":6863750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjM3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6863750?v=4","gravatar_id":"","url":"https://api.github.com/users/pricelinelabs","html_url":"https://github.com/pricelinelabs","followers_url":"https://api.github.com/users/pricelinelabs/followers","following_url":"https://api.github.com/users/pricelinelabs/following{/other_user}","gists_url":"https://api.github.com/users/pricelinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/pricelinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pricelinelabs/subscriptions","organizations_url":"https://api.github.com/users/pricelinelabs/orgs","repos_url":"https://api.github.com/users/pricelinelabs/repos","events_url":"https://api.github.com/users/pricelinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/pricelinelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pricelinelabs/design-system","description":"Priceline.com Design System","fork":false,"url":"https://api.github.com/repos/pricelinelabs/design-system","forks_url":"https://api.github.com/repos/pricelinelabs/design-system/forks","keys_url":"https://api.github.com/repos/pricelinelabs/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pricelinelabs/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pricelinelabs/design-system/teams","hooks_url":"https://api.github.com/repos/pricelinelabs/design-system/hooks","issue_events_url":"https://api.github.com/repos/pricelinelabs/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/pricelinelabs/design-system/events","assignees_url":"https://api.github.com/repos/pricelinelabs/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/pricelinelabs/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/pricelinelabs/design-system/tags","blobs_url":"https://api.github.com/repos/pricelinelabs/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pricelinelabs/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pricelinelabs/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/pricelinelabs/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pricelinelabs/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/pricelinelabs/design-system/languages","stargazers_url":"https://api.github.com/repos/pricelinelabs/design-system/stargazers","contributors_url":"https://api.github.com/repos/pricelinelabs/design-system/contributors","subscribers_url":"https://api.github.com/repos/pricelinelabs/design-system/subscribers","subscription_url":"https://api.github.com/repos/pricelinelabs/design-system/subscription","commits_url":"https://api.github.com/repos/pricelinelabs/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/pricelinelabs/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/pricelinelabs/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/pricelinelabs/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/pricelinelabs/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/pricelinelabs/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pricelinelabs/design-system/merges","archive_url":"https://api.github.com/repos/pricelinelabs/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pricelinelabs/design-system/downloads","issues_url":"https://api.github.com/repos/pricelinelabs/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/pricelinelabs/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/pricelinelabs/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/pricelinelabs/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pricelinelabs/design-system/labels{/name}","releases_url":"https://api.github.com/repos/pricelinelabs/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/pricelinelabs/design-system/deployments","created_at":"2017-07-17T23:21:25Z","updated_at":"2018-12-15T18:44:35Z","pushed_at":"2018-12-17T20:22:32Z","git_url":"git://github.com/pricelinelabs/design-system.git","ssh_url":"git@github.com:pricelinelabs/design-system.git","clone_url":"https://github.com/pricelinelabs/design-system.git","svn_url":"https://github.com/pricelinelabs/design-system","homepage":"https://pricelinelabs.github.io/design-system/","size":10770,"stargazers_count":304,"watchers_count":304,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":54,"open_issues":58,"watchers":304,"default_branch":"master"}},"base":{"label":"pricelinelabs:next","ref":"next","sha":"6356542027628654c5a5da241c3fce79731a9272","user":{"login":"pricelinelabs","id":6863750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjM3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6863750?v=4","gravatar_id":"","url":"https://api.github.com/users/pricelinelabs","html_url":"https://github.com/pricelinelabs","followers_url":"https://api.github.com/users/pricelinelabs/followers","following_url":"https://api.github.com/users/pricelinelabs/following{/other_user}","gists_url":"https://api.github.com/users/pricelinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/pricelinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pricelinelabs/subscriptions","organizations_url":"https://api.github.com/users/pricelinelabs/orgs","repos_url":"https://api.github.com/users/pricelinelabs/repos","events_url":"https://api.github.com/users/pricelinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/pricelinelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":97530717,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUzMDcxNw==","name":"design-system","full_name":"pricelinelabs/design-system","private":false,"owner":{"login":"pricelinelabs","id":6863750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjM3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6863750?v=4","gravatar_id":"","url":"https://api.github.com/users/pricelinelabs","html_url":"https://github.com/pricelinelabs","followers_url":"https://api.github.com/users/pricelinelabs/followers","following_url":"https://api.github.com/users/pricelinelabs/following{/other_user}","gists_url":"https://api.github.com/users/pricelinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/pricelinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pricelinelabs/subscriptions","organizations_url":"https://api.github.com/users/pricelinelabs/orgs","repos_url":"https://api.github.com/users/pricelinelabs/repos","events_url":"https://api.github.com/users/pricelinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/pricelinelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pricelinelabs/design-system","description":"Priceline.com Design System","fork":false,"url":"https://api.github.com/repos/pricelinelabs/design-system","forks_url":"https://api.github.com/repos/pricelinelabs/design-system/forks","keys_url":"https://api.github.com/repos/pricelinelabs/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pricelinelabs/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pricelinelabs/design-system/teams","hooks_url":"https://api.github.com/repos/pricelinelabs/design-system/hooks","issue_events_url":"https://api.github.com/repos/pricelinelabs/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/pricelinelabs/design-system/events","assignees_url":"https://api.github.com/repos/pricelinelabs/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/pricelinelabs/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/pricelinelabs/design-system/tags","blobs_url":"https://api.github.com/repos/pricelinelabs/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pricelinelabs/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pricelinelabs/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/pricelinelabs/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pricelinelabs/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/pricelinelabs/design-system/languages","stargazers_url":"https://api.github.com/repos/pricelinelabs/design-system/stargazers","contributors_url":"https://api.github.com/repos/pricelinelabs/design-system/contributors","subscribers_url":"https://api.github.com/repos/pricelinelabs/design-system/subscribers","subscription_url":"https://api.github.com/repos/pricelinelabs/design-system/subscription","commits_url":"https://api.github.com/repos/pricelinelabs/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/pricelinelabs/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/pricelinelabs/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/pricelinelabs/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/pricelinelabs/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/pricelinelabs/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pricelinelabs/design-system/merges","archive_url":"https://api.github.com/repos/pricelinelabs/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pricelinelabs/design-system/downloads","issues_url":"https://api.github.com/repos/pricelinelabs/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/pricelinelabs/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/pricelinelabs/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/pricelinelabs/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pricelinelabs/design-system/labels{/name}","releases_url":"https://api.github.com/repos/pricelinelabs/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/pricelinelabs/design-system/deployments","created_at":"2017-07-17T23:21:25Z","updated_at":"2018-12-15T18:44:35Z","pushed_at":"2018-12-17T20:22:32Z","git_url":"git://github.com/pricelinelabs/design-system.git","ssh_url":"git@github.com:pricelinelabs/design-system.git","clone_url":"https://github.com/pricelinelabs/design-system.git","svn_url":"https://github.com/pricelinelabs/design-system","homepage":"https://pricelinelabs.github.io/design-system/","size":10770,"stargazers_count":304,"watchers_count":304,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":54,"open_issues":58,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pricelinelabs/design-system/pulls/403"},"html":{"href":"https://github.com/pricelinelabs/design-system/pull/403"},"issue":{"href":"https://api.github.com/repos/pricelinelabs/design-system/issues/403"},"comments":{"href":"https://api.github.com/repos/pricelinelabs/design-system/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/pricelinelabs/design-system/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/pricelinelabs/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pricelinelabs/design-system/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/pricelinelabs/design-system/statuses/49577b1b62dba4d8b4515cbcc7fea9f3aa958c8d"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jxnblk","id":3451712,"node_id":"MDQ6VXNlcjM0NTE3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3451712?v=4","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":13,"additions":1365,"deletions":1254,"changed_files":18}}
{"actor":{"display_login":"jxnblk"}}