{"action":"created","comment":{"url":"https://api.github.com/repos/evergreen-ci/sink/pulls/comments/235172079","pull_request_review_id":176978225,"id":235172079,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE3MjA3OQ==","diff_hunk":"@@ -89,23 +90,42 @@ message MetricsCounters {\n \n message MetricsTimers {\n   google.protobuf.Duration duration = 1;\n-  google.protobuf.Duration waiting = 2;\n+  google.protobuf.Duration total = 2;\n }\n \n-message MetricsState {\n-  bool failed = 1;\n+message MetricsGuages {\n+  int64 state = 1;\n   int64 workers = 2;\n+  bool failed = 3;\n }\n \n message MetricsEvent {\n   string id = 1;\n   repeated MetricsPoint Event = 3;\n }\n \n+message RollupValue {\n+  string name = 1;\n+  oneof value {\n+    int64 int = 2;\n+    float fl = 3;\n+  }\n+  int64 version = 4;\n+}\n+\n+message Rollups {\n+  repeated RollupValue default_stats = 1;\n+  repeated RollupValue user_stats = 2;\n+  google.protobuf.Timestamp processed_at = 3;\n+  int64 count = 4;\n+  bool valid = 5;\n+}\n+\n service SinkPerformanceMetrics {\n   rpc CreateMetricSeries(ResultData) returns (MetricsResponse);\n   rpc AttachResultData(ResultData) returns (MetricsResponse);\n   rpc AttachAuxilaryData(ResultData) returns (MetricsResponse);\n+  rpc AttachRollups(ResultData) returns (MetricsResponse);","path":"perf.proto","position":60,"original_position":59,"commit_id":"7eae9ab0435c75522243401b60749e57747829e3","original_commit_id":"b7f43947435857150461fd24b12c059e2cda92c0","user":{"login":"tychoish","id":17534,"node_id":"MDQ6VXNlcjE3NTM0","avatar_url":"https://avatars1.githubusercontent.com/u/17534?v=4","gravatar_id":"","url":"https://api.github.com/users/tychoish","html_url":"https://github.com/tychoish","followers_url":"https://api.github.com/users/tychoish/followers","following_url":"https://api.github.com/users/tychoish/following{/other_user}","gists_url":"https://api.github.com/users/tychoish/gists{/gist_id}","starred_url":"https://api.github.com/users/tychoish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tychoish/subscriptions","organizations_url":"https://api.github.com/users/tychoish/orgs","repos_url":"https://api.github.com/users/tychoish/repos","events_url":"https://api.github.com/users/tychoish/events{/privacy}","received_events_url":"https://api.github.com/users/tychoish/received_events","type":"User","site_admin":false},"body":"yes probably. ","created_at":"2018-11-20T21:17:07Z","updated_at":"2018-11-20T21:17:07Z","html_url":"https://github.com/evergreen-ci/sink/pull/22#discussion_r235172079","pull_request_url":"https://api.github.com/repos/evergreen-ci/sink/pulls/22","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/evergreen-ci/sink/pulls/comments/235172079"},"html":{"href":"https://github.com/evergreen-ci/sink/pull/22#discussion_r235172079"},"pull_request":{"href":"https://api.github.com/repos/evergreen-ci/sink/pulls/22"}},"in_reply_to_id":235128078},"pull_request":{"url":"https://api.github.com/repos/evergreen-ci/sink/pulls/22","id":232131839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTMxODM5","html_url":"https://github.com/evergreen-ci/sink/pull/22","diff_url":"https://github.com/evergreen-ci/sink/pull/22.diff","patch_url":"https://github.com/evergreen-ci/sink/pull/22.patch","issue_url":"https://api.github.com/repos/evergreen-ci/sink/issues/22","number":22,"state":"open","locked":false,"title":"MAKE-511: add grpc method to have user-submitted rollups","user":{"login":"julianedwards","id":16562432,"node_id":"MDQ6VXNlcjE2NTYyNDMy","avatar_url":"https://avatars2.githubusercontent.com/u/16562432?v=4","gravatar_id":"","url":"https://api.github.com/users/julianedwards","html_url":"https://github.com/julianedwards","followers_url":"https://api.github.com/users/julianedwards/followers","following_url":"https://api.github.com/users/julianedwards/following{/other_user}","gists_url":"https://api.github.com/users/julianedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/julianedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianedwards/subscriptions","organizations_url":"https://api.github.com/users/julianedwards/orgs","repos_url":"https://api.github.com/users/julianedwards/repos","events_url":"https://api.github.com/users/julianedwards/events{/privacy}","received_events_url":"https://api.github.com/users/julianedwards/received_events","type":"User","site_admin":false},"body":"also added testing for other existing grpc methods ","created_at":"2018-11-19T22:25:30Z","updated_at":"2018-11-20T21:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c384594b3c53ac6963d72bde63f405e7eb5b069","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/evergreen-ci/sink/pulls/22/commits","review_comments_url":"https://api.github.com/repos/evergreen-ci/sink/pulls/22/comments","review_comment_url":"https://api.github.com/repos/evergreen-ci/sink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evergreen-ci/sink/issues/22/comments","statuses_url":"https://api.github.com/repos/evergreen-ci/sink/statuses/7eae9ab0435c75522243401b60749e57747829e3","head":{"label":"julianedwards:MAKE-511","ref":"MAKE-511","sha":"7eae9ab0435c75522243401b60749e57747829e3","user":{"login":"julianedwards","id":16562432,"node_id":"MDQ6VXNlcjE2NTYyNDMy","avatar_url":"https://avatars2.githubusercontent.com/u/16562432?v=4","gravatar_id":"","url":"https://api.github.com/users/julianedwards","html_url":"https://github.com/julianedwards","followers_url":"https://api.github.com/users/julianedwards/followers","following_url":"https://api.github.com/users/julianedwards/following{/other_user}","gists_url":"https://api.github.com/users/julianedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/julianedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianedwards/subscriptions","organizations_url":"https://api.github.com/users/julianedwards/orgs","repos_url":"https://api.github.com/users/julianedwards/repos","events_url":"https://api.github.com/users/julianedwards/events{/privacy}","received_events_url":"https://api.github.com/users/julianedwards/received_events","type":"User","site_admin":false},"repo":{"id":148829579,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4Mjk1Nzk=","name":"sink","full_name":"julianedwards/sink","private":false,"owner":{"login":"julianedwards","id":16562432,"node_id":"MDQ6VXNlcjE2NTYyNDMy","avatar_url":"https://avatars2.githubusercontent.com/u/16562432?v=4","gravatar_id":"","url":"https://api.github.com/users/julianedwards","html_url":"https://github.com/julianedwards","followers_url":"https://api.github.com/users/julianedwards/followers","following_url":"https://api.github.com/users/julianedwards/following{/other_user}","gists_url":"https://api.github.com/users/julianedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/julianedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianedwards/subscriptions","organizations_url":"https://api.github.com/users/julianedwards/orgs","repos_url":"https://api.github.com/users/julianedwards/repos","events_url":"https://api.github.com/users/julianedwards/events{/privacy}","received_events_url":"https://api.github.com/users/julianedwards/received_events","type":"User","site_admin":false},"html_url":"https://github.com/julianedwards/sink","description":"data sink service ","fork":true,"url":"https://api.github.com/repos/julianedwards/sink","forks_url":"https://api.github.com/repos/julianedwards/sink/forks","keys_url":"https://api.github.com/repos/julianedwards/sink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julianedwards/sink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julianedwards/sink/teams","hooks_url":"https://api.github.com/repos/julianedwards/sink/hooks","issue_events_url":"https://api.github.com/repos/julianedwards/sink/issues/events{/number}","events_url":"https://api.github.com/repos/julianedwards/sink/events","assignees_url":"https://api.github.com/repos/julianedwards/sink/assignees{/user}","branches_url":"https://api.github.com/repos/julianedwards/sink/branches{/branch}","tags_url":"https://api.github.com/repos/julianedwards/sink/tags","blobs_url":"https://api.github.com/repos/julianedwards/sink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julianedwards/sink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julianedwards/sink/git/refs{/sha}","trees_url":"https://api.github.com/repos/julianedwards/sink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julianedwards/sink/statuses/{sha}","languages_url":"https://api.github.com/repos/julianedwards/sink/languages","stargazers_url":"https://api.github.com/repos/julianedwards/sink/stargazers","contributors_url":"https://api.github.com/repos/julianedwards/sink/contributors","subscribers_url":"https://api.github.com/repos/julianedwards/sink/subscribers","subscription_url":"https://api.github.com/repos/julianedwards/sink/subscription","commits_url":"https://api.github.com/repos/julianedwards/sink/commits{/sha}","git_commits_url":"https://api.github.com/repos/julianedwards/sink/git/commits{/sha}","comments_url":"https://api.github.com/repos/julianedwards/sink/comments{/number}","issue_comment_url":"https://api.github.com/repos/julianedwards/sink/issues/comments{/number}","contents_url":"https://api.github.com/repos/julianedwards/sink/contents/{+path}","compare_url":"https://api.github.com/repos/julianedwards/sink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julianedwards/sink/merges","archive_url":"https://api.github.com/repos/julianedwards/sink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julianedwards/sink/downloads","issues_url":"https://api.github.com/repos/julianedwards/sink/issues{/number}","pulls_url":"https://api.github.com/repos/julianedwards/sink/pulls{/number}","milestones_url":"https://api.github.com/repos/julianedwards/sink/milestones{/number}","notifications_url":"https://api.github.com/repos/julianedwards/sink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julianedwards/sink/labels{/name}","releases_url":"https://api.github.com/repos/julianedwards/sink/releases{/id}","deployments_url":"https://api.github.com/repos/julianedwards/sink/deployments","created_at":"2018-09-14T18:51:48Z","updated_at":"2018-09-19T21:21:12Z","pushed_at":"2018-11-20T20:15:19Z","git_url":"git://github.com/julianedwards/sink.git","ssh_url":"git@github.com:julianedwards/sink.git","clone_url":"https://github.com/julianedwards/sink.git","svn_url":"https://github.com/julianedwards/sink","homepage":null,"size":29241,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"evergreen-ci:master","ref":"master","sha":"73538d951c7b6a33cc0dde441b05b47c20f1a2e1","user":{"login":"evergreen-ci","id":10089490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDg5NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/10089490?v=4","gravatar_id":"","url":"https://api.github.com/users/evergreen-ci","html_url":"https://github.com/evergreen-ci","followers_url":"https://api.github.com/users/evergreen-ci/followers","following_url":"https://api.github.com/users/evergreen-ci/following{/other_user}","gists_url":"https://api.github.com/users/evergreen-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/evergreen-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evergreen-ci/subscriptions","organizations_url":"https://api.github.com/users/evergreen-ci/orgs","repos_url":"https://api.github.com/users/evergreen-ci/repos","events_url":"https://api.github.com/users/evergreen-ci/events{/privacy}","received_events_url":"https://api.github.com/users/evergreen-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":81266425,"node_id":"MDEwOlJlcG9zaXRvcnk4MTI2NjQyNQ==","name":"sink","full_name":"evergreen-ci/sink","private":false,"owner":{"login":"evergreen-ci","id":10089490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDg5NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/10089490?v=4","gravatar_id":"","url":"https://api.github.com/users/evergreen-ci","html_url":"https://github.com/evergreen-ci","followers_url":"https://api.github.com/users/evergreen-ci/followers","following_url":"https://api.github.com/users/evergreen-ci/following{/other_user}","gists_url":"https://api.github.com/users/evergreen-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/evergreen-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evergreen-ci/subscriptions","organizations_url":"https://api.github.com/users/evergreen-ci/orgs","repos_url":"https://api.github.com/users/evergreen-ci/repos","events_url":"https://api.github.com/users/evergreen-ci/events{/privacy}","received_events_url":"https://api.github.com/users/evergreen-ci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/evergreen-ci/sink","description":"data sink service ","fork":false,"url":"https://api.github.com/repos/evergreen-ci/sink","forks_url":"https://api.github.com/repos/evergreen-ci/sink/forks","keys_url":"https://api.github.com/repos/evergreen-ci/sink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evergreen-ci/sink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evergreen-ci/sink/teams","hooks_url":"https://api.github.com/repos/evergreen-ci/sink/hooks","issue_events_url":"https://api.github.com/repos/evergreen-ci/sink/issues/events{/number}","events_url":"https://api.github.com/repos/evergreen-ci/sink/events","assignees_url":"https://api.github.com/repos/evergreen-ci/sink/assignees{/user}","branches_url":"https://api.github.com/repos/evergreen-ci/sink/branches{/branch}","tags_url":"https://api.github.com/repos/evergreen-ci/sink/tags","blobs_url":"https://api.github.com/repos/evergreen-ci/sink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evergreen-ci/sink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evergreen-ci/sink/git/refs{/sha}","trees_url":"https://api.github.com/repos/evergreen-ci/sink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evergreen-ci/sink/statuses/{sha}","languages_url":"https://api.github.com/repos/evergreen-ci/sink/languages","stargazers_url":"https://api.github.com/repos/evergreen-ci/sink/stargazers","contributors_url":"https://api.github.com/repos/evergreen-ci/sink/contributors","subscribers_url":"https://api.github.com/repos/evergreen-ci/sink/subscribers","subscription_url":"https://api.github.com/repos/evergreen-ci/sink/subscription","commits_url":"https://api.github.com/repos/evergreen-ci/sink/commits{/sha}","git_commits_url":"https://api.github.com/repos/evergreen-ci/sink/git/commits{/sha}","comments_url":"https://api.github.com/repos/evergreen-ci/sink/comments{/number}","issue_comment_url":"https://api.github.com/repos/evergreen-ci/sink/issues/comments{/number}","contents_url":"https://api.github.com/repos/evergreen-ci/sink/contents/{+path}","compare_url":"https://api.github.com/repos/evergreen-ci/sink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evergreen-ci/sink/merges","archive_url":"https://api.github.com/repos/evergreen-ci/sink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evergreen-ci/sink/downloads","issues_url":"https://api.github.com/repos/evergreen-ci/sink/issues{/number}","pulls_url":"https://api.github.com/repos/evergreen-ci/sink/pulls{/number}","milestones_url":"https://api.github.com/repos/evergreen-ci/sink/milestones{/number}","notifications_url":"https://api.github.com/repos/evergreen-ci/sink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evergreen-ci/sink/labels{/name}","releases_url":"https://api.github.com/repos/evergreen-ci/sink/releases{/id}","deployments_url":"https://api.github.com/repos/evergreen-ci/sink/deployments","created_at":"2017-02-07T23:41:37Z","updated_at":"2018-11-20T20:18:04Z","pushed_at":"2018-11-20T20:18:02Z","git_url":"git://github.com/evergreen-ci/sink.git","ssh_url":"git@github.com:evergreen-ci/sink.git","clone_url":"https://github.com/evergreen-ci/sink.git","svn_url":"https://github.com/evergreen-ci/sink","homepage":null,"size":29226,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evergreen-ci/sink/pulls/22"},"html":{"href":"https://github.com/evergreen-ci/sink/pull/22"},"issue":{"href":"https://api.github.com/repos/evergreen-ci/sink/issues/22"},"comments":{"href":"https://api.github.com/repos/evergreen-ci/sink/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/evergreen-ci/sink/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/evergreen-ci/sink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evergreen-ci/sink/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/evergreen-ci/sink/statuses/7eae9ab0435c75522243401b60749e57747829e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tychoish"}}