{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72275","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72275/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72275/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72275/events","html_url":"https://github.com/kubernetes/kubernetes/pull/72275","id":393422027,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDQ0Mjg0","number":72275,"title":"[WIP] Using size ranges for e2e storage drivers and tests","user":{"login":"srmocher","id":11073043,"node_id":"MDQ6VXNlcjExMDczMDQz","avatar_url":"https://avatars3.githubusercontent.com/u/11073043?v=4","gravatar_id":"","url":"https://api.github.com/users/srmocher","html_url":"https://github.com/srmocher","followers_url":"https://api.github.com/users/srmocher/followers","following_url":"https://api.github.com/users/srmocher/following{/other_user}","gists_url":"https://api.github.com/users/srmocher/gists{/gist_id}","starred_url":"https://api.github.com/users/srmocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srmocher/subscriptions","organizations_url":"https://api.github.com/users/srmocher/orgs","repos_url":"https://api.github.com/users/srmocher/repos","events_url":"https://api.github.com/users/srmocher/events{/privacy}","received_events_url":"https://api.github.com/users/srmocher/received_events","type":"User","site_admin":false},"labels":[{"id":477397085,"node_id":"MDU6TGFiZWw0NzczOTcwODU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":1086787260,"node_id":"MDU6TGFiZWwxMDg2Nzg3MjYw","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-21T11:15:07Z","updated_at":"2018-12-23T06:33:53Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/72275","html_url":"https://github.com/kubernetes/kubernetes/pull/72275","diff_url":"https://github.com/kubernetes/kubernetes/pull/72275.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/72275.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n**What type of PR is this?**\r\n/kind feature\r\n/sig storage\r\n\r\n**What this PR does / why we need it**:\r\nRemoves hardcoded sizes for volumes in tests and unifies the way sizes (or rather ranges) are defined for both the storage test drivers and the tests themselves. Both components specify a range of size to test (or in the case of the driver define what size range it supports). Test shall be skipped if the size specified by it does not fit with the driver's range. Otherwise, the intersection of the two ranges (the test and the driver's) are taken and the minimum of the result is chosen as the resource claim size.\r\n\r\nStill a work-in-progress as this is my first PR and as I become more familiar with the codebase.\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!-- \r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #72080 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\nNONE\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/449617597","html_url":"https://github.com/kubernetes/kubernetes/pull/72275#issuecomment-449617597","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72275","id":449617597,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTYxNzU5Nw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-23T06:33:53Z","updated_at":"2018-12-23T06:33:53Z","author_association":"CONTRIBUTOR","body":"@srmocher: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-build | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-bazel-build/68136/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-bazel-test | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-bazel-test/70823/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-e2e-kops-aws/117448/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-e2e-gce/63303/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-e2e-gce-device-plugin-gpu/55825/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-node-e2e | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-node-e2e/114631/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-e2e-gce-100-performance | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-e2e-gce-100-performance/29971/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-kubemark-e2e-gce-big | 0faa06b2ca557ce48ddb1956dc5c4884ff2c09f3 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72275/pull-kubernetes-kubemark-e2e-gce-big/32621/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://gubernator.k8s.io/pr/72275). [Your PR dashboard](https://gubernator.k8s.io/pr/srmocher). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}