{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35292","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35292/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35292/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35292/events","html_url":"https://github.com/NixOS/nixpkgs/pull/35292","id":299114583,"number":35292,"title":"Pulseaudio by default, if sound is enabled","user":{"login":"aristidb","id":30712,"avatar_url":"https://avatars0.githubusercontent.com/u/30712?v=4","gravatar_id":"","url":"https://api.github.com/users/aristidb","html_url":"https://github.com/aristidb","followers_url":"https://api.github.com/users/aristidb/followers","following_url":"https://api.github.com/users/aristidb/following{/other_user}","gists_url":"https://api.github.com/users/aristidb/gists{/gist_id}","starred_url":"https://api.github.com/users/aristidb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aristidb/subscriptions","organizations_url":"https://api.github.com/users/aristidb/orgs","repos_url":"https://api.github.com/users/aristidb/repos","events_url":"https://api.github.com/users/aristidb/events{/privacy}","received_events_url":"https://api.github.com/users/aristidb/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-02-21T20:21:06Z","updated_at":"2018-02-22T19:13:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35292","html_url":"https://github.com/NixOS/nixpkgs/pull/35292","diff_url":"https://github.com/NixOS/nixpkgs/pull/35292.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/35292.patch"},"body":"###### Motivation for this change\r\n\r\nMajor applications like Firefox no longer support a bare-alsa setup, the justification being that only a very small percentage of Linux users does not use pulseaudio.\r\n\r\nThis pull request still allows people who really want to to disable pulseaudio, but makes it the default on systems with sound enabled. I think it will make it easier for people to get started with NixOS if their sound works out of the box.\r\n\r\nMinimal headless systems will also be unaffected, because they should already have sound disabled.\r\n\r\nPrevious discussion in  #29250, which was closed by me due to lack of consensus, but at the time, Firefox did not yet require PulseAudio.\r\n\r\nEDIT: I misunderstood a bit, Firefox will still apparently run with Alsa, but it's not maintained and if there's bugs with the Alsa support, there's no guarantee anybody will fix it. The thing that triggered nixpkgs to build Firefox with Pulseaudio is that some playback quality is clipped in some scenarios.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [N/A] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/367788494","html_url":"https://github.com/NixOS/nixpkgs/pull/35292#issuecomment-367788494","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35292","id":367788494,"user":{"login":"grahamc","id":76716,"avatar_url":"https://avatars3.githubusercontent.com/u/76716?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T19:13:06Z","updated_at":"2018-02-22T19:13:06Z","author_association":"MEMBER","body":"That is fine, it wasn't for you -- but for oxij's assertion that nobody uses stateVersion."}}
{"actor":{"display_login":"grahamc"}}