{"action":"created","issue":{"url":"https://api.github.com/repos/docker/cli/issues/1130","repository_url":"https://api.github.com/repos/docker/cli","labels_url":"https://api.github.com/repos/docker/cli/issues/1130/labels{/name}","comments_url":"https://api.github.com/repos/docker/cli/issues/1130/comments","events_url":"https://api.github.com/repos/docker/cli/issues/1130/events","html_url":"https://github.com/docker/cli/pull/1130","id":333243441,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTA0OTY1","number":1130,"title":"cli: add a separate --domainname flag","user":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"id":585916070,"node_id":"MDU6TGFiZWw1ODU5MTYwNzA=","url":"https://api.github.com/repos/docker/cli/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-18T12:11:48Z","updated_at":"2018-08-16T00:01:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/1130","html_url":"https://github.com/docker/cli/pull/1130","diff_url":"https://github.com/docker/cli/pull/1130.diff","patch_url":"https://github.com/docker/cli/pull/1130.patch"},"body":"A while ago, Docker split the \"Domainname\" field out from the \"Hostname\"\r\nfield for the container configuration. There was no real user-visible\r\nchange associated with this (and under the hood \"Domainname\" was mostly\r\nleft unused from the command-line point of view). We now add this flag\r\nin order to match other proposed changes to allow for setting the NIS\r\ndomainname of a container.\r\n\r\n[![Cute cat by .:I&#x27;m-a-kitty-cat!:.](https://farm4.staticflickr.com/3483/3274624318_95433914e3_b.jpg)](https://flic.kr/p/5ZniHY)\r\n\r\n###### [Cute cat](https://flic.kr/p/5ZniHY) by [.:I&#x27;m-a-kitty-cat!:.](https://www.flickr.com/photos/tiina93/)\r\n\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>"},"comment":{"url":"https://api.github.com/repos/docker/cli/issues/comments/413377664","html_url":"https://github.com/docker/cli/pull/1130#issuecomment-413377664","issue_url":"https://api.github.com/repos/docker/cli/issues/1130","id":413377664,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzM3NzY2NA==","user":{"login":"cyphar","id":2888411,"node_id":"MDQ6VXNlcjI4ODg0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2888411?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T00:01:50Z","updated_at":"2018-08-16T00:01:50Z","author_association":"CONTRIBUTOR","body":"Alright, I've fixed the build by removing the Swarm changes -- it looks like Swarm doesn't have a Domainname field in the API so we can't really add a switch for it.\r\n\r\n/ping @vdemeester @thaJeztah "}}
{"actor":{"display_login":"cyphar"}}