{"action":"created","comment":{"url":"https://api.github.com/repos/r-lib/vctrs/pulls/comments/223183204","pull_request_review_id":162258034,"id":223183204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE4MzIwNA==","diff_hunk":"@@ -209,6 +209,11 @@ vec_cast.POSIXt.Date <- function(x, to) {\n   as.POSIXct(as.character(x), tz = tzone(to))\n }\n #' @export\n+#' @method vec_cast.POSIXt POSIXlt\n+vec_cast.POSIXt.POSIXlt <- function(x, to) {","path":"R/type-date-time.R","position":5,"original_position":5,"commit_id":"89309370ba0a7cd7a32002b547aefc923ed8ec01","original_commit_id":"89309370ba0a7cd7a32002b547aefc923ed8ec01","user":{"login":"hadley","id":4196,"node_id":"MDQ6VXNlcjQxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4196?v=4","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"body":"I think this (and the method below), should be `vec_cast.POSIXct`. Would you mind fixing?","created_at":"2018-10-06T14:07:37Z","updated_at":"2018-10-06T14:07:54Z","html_url":"https://github.com/r-lib/vctrs/pull/112#discussion_r223183204","pull_request_url":"https://api.github.com/repos/r-lib/vctrs/pulls/112","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/r-lib/vctrs/pulls/comments/223183204"},"html":{"href":"https://github.com/r-lib/vctrs/pull/112#discussion_r223183204"},"pull_request":{"href":"https://api.github.com/repos/r-lib/vctrs/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/r-lib/vctrs/pulls/112","id":220880984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODgwOTg0","html_url":"https://github.com/r-lib/vctrs/pull/112","diff_url":"https://github.com/r-lib/vctrs/pull/112.diff","patch_url":"https://github.com/r-lib/vctrs/pull/112.patch","issue_url":"https://api.github.com/repos/r-lib/vctrs/issues/112","number":112,"state":"open","locked":false,"title":"vec_c handles POSIXlt by converting to POSIXct.","user":{"login":"romainfrancois","id":2625526,"node_id":"MDQ6VXNlcjI2MjU1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2625526?v=4","gravatar_id":"","url":"https://api.github.com/users/romainfrancois","html_url":"https://github.com/romainfrancois","followers_url":"https://api.github.com/users/romainfrancois/followers","following_url":"https://api.github.com/users/romainfrancois/following{/other_user}","gists_url":"https://api.github.com/users/romainfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/romainfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainfrancois/subscriptions","organizations_url":"https://api.github.com/users/romainfrancois/orgs","repos_url":"https://api.github.com/users/romainfrancois/repos","events_url":"https://api.github.com/users/romainfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/romainfrancois/received_events","type":"User","site_admin":false},"body":"As I'm looking for dates and times in arrow, would be useful if `vec_c` would convert POSIXlt to POSIXct, e.g.: \r\n\r\n```r\r\ntest_that(\"vec_c handles POSIXlt (#130)\", {\r\n  ct <- Sys.time() + 1:10\r\n  lt <- as.POSIXlt(ct)\r\n  vec <- vec_c(lt)\r\n  expect_equal(vec, ct)\r\n})\r\n```\r\n\r\nThis currently aborts in `master` \r\n","created_at":"2018-10-06T11:27:59Z","updated_at":"2018-10-06T14:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2008cda955b0edaa4963ad7de048aca4d2c68374","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/r-lib/vctrs/pulls/112/commits","review_comments_url":"https://api.github.com/repos/r-lib/vctrs/pulls/112/comments","review_comment_url":"https://api.github.com/repos/r-lib/vctrs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/r-lib/vctrs/issues/112/comments","statuses_url":"https://api.github.com/repos/r-lib/vctrs/statuses/89309370ba0a7cd7a32002b547aefc923ed8ec01","head":{"label":"romainfrancois:feature/130-POSIXlt","ref":"feature/130-POSIXlt","sha":"89309370ba0a7cd7a32002b547aefc923ed8ec01","user":{"login":"romainfrancois","id":2625526,"node_id":"MDQ6VXNlcjI2MjU1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2625526?v=4","gravatar_id":"","url":"https://api.github.com/users/romainfrancois","html_url":"https://github.com/romainfrancois","followers_url":"https://api.github.com/users/romainfrancois/followers","following_url":"https://api.github.com/users/romainfrancois/following{/other_user}","gists_url":"https://api.github.com/users/romainfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/romainfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainfrancois/subscriptions","organizations_url":"https://api.github.com/users/romainfrancois/orgs","repos_url":"https://api.github.com/users/romainfrancois/repos","events_url":"https://api.github.com/users/romainfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/romainfrancois/received_events","type":"User","site_admin":false},"repo":{"id":151705023,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MDUwMjM=","name":"vctrs","full_name":"romainfrancois/vctrs","private":false,"owner":{"login":"romainfrancois","id":2625526,"node_id":"MDQ6VXNlcjI2MjU1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2625526?v=4","gravatar_id":"","url":"https://api.github.com/users/romainfrancois","html_url":"https://github.com/romainfrancois","followers_url":"https://api.github.com/users/romainfrancois/followers","following_url":"https://api.github.com/users/romainfrancois/following{/other_user}","gists_url":"https://api.github.com/users/romainfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/romainfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainfrancois/subscriptions","organizations_url":"https://api.github.com/users/romainfrancois/orgs","repos_url":"https://api.github.com/users/romainfrancois/repos","events_url":"https://api.github.com/users/romainfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/romainfrancois/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romainfrancois/vctrs","description":"Vector types","fork":true,"url":"https://api.github.com/repos/romainfrancois/vctrs","forks_url":"https://api.github.com/repos/romainfrancois/vctrs/forks","keys_url":"https://api.github.com/repos/romainfrancois/vctrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romainfrancois/vctrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romainfrancois/vctrs/teams","hooks_url":"https://api.github.com/repos/romainfrancois/vctrs/hooks","issue_events_url":"https://api.github.com/repos/romainfrancois/vctrs/issues/events{/number}","events_url":"https://api.github.com/repos/romainfrancois/vctrs/events","assignees_url":"https://api.github.com/repos/romainfrancois/vctrs/assignees{/user}","branches_url":"https://api.github.com/repos/romainfrancois/vctrs/branches{/branch}","tags_url":"https://api.github.com/repos/romainfrancois/vctrs/tags","blobs_url":"https://api.github.com/repos/romainfrancois/vctrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romainfrancois/vctrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romainfrancois/vctrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/romainfrancois/vctrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romainfrancois/vctrs/statuses/{sha}","languages_url":"https://api.github.com/repos/romainfrancois/vctrs/languages","stargazers_url":"https://api.github.com/repos/romainfrancois/vctrs/stargazers","contributors_url":"https://api.github.com/repos/romainfrancois/vctrs/contributors","subscribers_url":"https://api.github.com/repos/romainfrancois/vctrs/subscribers","subscription_url":"https://api.github.com/repos/romainfrancois/vctrs/subscription","commits_url":"https://api.github.com/repos/romainfrancois/vctrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/romainfrancois/vctrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/romainfrancois/vctrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/romainfrancois/vctrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/romainfrancois/vctrs/contents/{+path}","compare_url":"https://api.github.com/repos/romainfrancois/vctrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romainfrancois/vctrs/merges","archive_url":"https://api.github.com/repos/romainfrancois/vctrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romainfrancois/vctrs/downloads","issues_url":"https://api.github.com/repos/romainfrancois/vctrs/issues{/number}","pulls_url":"https://api.github.com/repos/romainfrancois/vctrs/pulls{/number}","milestones_url":"https://api.github.com/repos/romainfrancois/vctrs/milestones{/number}","notifications_url":"https://api.github.com/repos/romainfrancois/vctrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romainfrancois/vctrs/labels{/name}","releases_url":"https://api.github.com/repos/romainfrancois/vctrs/releases{/id}","deployments_url":"https://api.github.com/repos/romainfrancois/vctrs/deployments","created_at":"2018-10-05T10:29:36Z","updated_at":"2018-10-06T11:05:03Z","pushed_at":"2018-10-06T11:31:28Z","git_url":"git://github.com/romainfrancois/vctrs.git","ssh_url":"git@github.com:romainfrancois/vctrs.git","clone_url":"https://github.com/romainfrancois/vctrs.git","svn_url":"https://github.com/romainfrancois/vctrs","homepage":"https://vctrs.r-lib.org","size":2071,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"r-lib:master","ref":"master","sha":"57420d92ce63cc617c3171ae03a940178763380c","user":{"login":"r-lib","id":22618716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE4NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"repo":{"id":67548397,"node_id":"MDEwOlJlcG9zaXRvcnk2NzU0ODM5Nw==","name":"vctrs","full_name":"r-lib/vctrs","private":false,"owner":{"login":"r-lib","id":22618716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE4NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/r-lib/vctrs","description":"Vector types","fork":false,"url":"https://api.github.com/repos/r-lib/vctrs","forks_url":"https://api.github.com/repos/r-lib/vctrs/forks","keys_url":"https://api.github.com/repos/r-lib/vctrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r-lib/vctrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r-lib/vctrs/teams","hooks_url":"https://api.github.com/repos/r-lib/vctrs/hooks","issue_events_url":"https://api.github.com/repos/r-lib/vctrs/issues/events{/number}","events_url":"https://api.github.com/repos/r-lib/vctrs/events","assignees_url":"https://api.github.com/repos/r-lib/vctrs/assignees{/user}","branches_url":"https://api.github.com/repos/r-lib/vctrs/branches{/branch}","tags_url":"https://api.github.com/repos/r-lib/vctrs/tags","blobs_url":"https://api.github.com/repos/r-lib/vctrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r-lib/vctrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r-lib/vctrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/r-lib/vctrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r-lib/vctrs/statuses/{sha}","languages_url":"https://api.github.com/repos/r-lib/vctrs/languages","stargazers_url":"https://api.github.com/repos/r-lib/vctrs/stargazers","contributors_url":"https://api.github.com/repos/r-lib/vctrs/contributors","subscribers_url":"https://api.github.com/repos/r-lib/vctrs/subscribers","subscription_url":"https://api.github.com/repos/r-lib/vctrs/subscription","commits_url":"https://api.github.com/repos/r-lib/vctrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/r-lib/vctrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/r-lib/vctrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/r-lib/vctrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/r-lib/vctrs/contents/{+path}","compare_url":"https://api.github.com/repos/r-lib/vctrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r-lib/vctrs/merges","archive_url":"https://api.github.com/repos/r-lib/vctrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r-lib/vctrs/downloads","issues_url":"https://api.github.com/repos/r-lib/vctrs/issues{/number}","pulls_url":"https://api.github.com/repos/r-lib/vctrs/pulls{/number}","milestones_url":"https://api.github.com/repos/r-lib/vctrs/milestones{/number}","notifications_url":"https://api.github.com/repos/r-lib/vctrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r-lib/vctrs/labels{/name}","releases_url":"https://api.github.com/repos/r-lib/vctrs/releases{/id}","deployments_url":"https://api.github.com/repos/r-lib/vctrs/deployments","created_at":"2016-09-06T21:32:53Z","updated_at":"2018-10-05T22:00:40Z","pushed_at":"2018-10-06T11:31:29Z","git_url":"git://github.com/r-lib/vctrs.git","ssh_url":"git@github.com:r-lib/vctrs.git","clone_url":"https://github.com/r-lib/vctrs.git","svn_url":"https://github.com/r-lib/vctrs","homepage":"https://vctrs.r-lib.org","size":2065,"stargazers_count":80,"watchers_count":80,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":11,"open_issues":40,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/r-lib/vctrs/pulls/112"},"html":{"href":"https://github.com/r-lib/vctrs/pull/112"},"issue":{"href":"https://api.github.com/repos/r-lib/vctrs/issues/112"},"comments":{"href":"https://api.github.com/repos/r-lib/vctrs/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/r-lib/vctrs/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/r-lib/vctrs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/r-lib/vctrs/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/r-lib/vctrs/statuses/89309370ba0a7cd7a32002b547aefc923ed8ec01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hadley"}}