{"action":"created","comment":{"url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/comments/185034359","pull_request_review_id":116345283,"id":185034359,"diff_hunk":"@@ -56,8 +64,18 @@ class ElasticsearchSenderHTTP(\n   private val httpClientConfigCallback =\n     if (awsSigning) new SignedHttpClientConfigCallback(credentialsProvider, region)\n     else NoOpHttpClientConfigCallback\n-  private val client = HttpClient(uri,\n-    httpClientConfigCallback = httpClientConfigCallback)\n+\n+  private val formedHost = new HttpHost(endpoint, port,if (uri.options.getOrElse(\"ssl\", \"false\") == \"true\") \"https\" else \"http\")","path":"http/src/main/scala/com.snowplowanalytics.snowplow.storage.kinesis.elasticsearch/clients/ElasticsearchSenderHTTP.scala","position":null,"original_position":29,"commit_id":"d544ebd6e20e3dadb6abe7791d991f326c9f0e40","original_commit_id":"e5d16e5a733da7ce132efa44e99fa47c004f4119","user":{"login":"szareiangm","id":36857305,"avatar_url":"https://avatars0.githubusercontent.com/u/36857305?v=4","gravatar_id":"","url":"https://api.github.com/users/szareiangm","html_url":"https://github.com/szareiangm","followers_url":"https://api.github.com/users/szareiangm/followers","following_url":"https://api.github.com/users/szareiangm/following{/other_user}","gists_url":"https://api.github.com/users/szareiangm/gists{/gist_id}","starred_url":"https://api.github.com/users/szareiangm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szareiangm/subscriptions","organizations_url":"https://api.github.com/users/szareiangm/orgs","repos_url":"https://api.github.com/users/szareiangm/repos","events_url":"https://api.github.com/users/szareiangm/events{/privacy}","received_events_url":"https://api.github.com/users/szareiangm/received_events","type":"User","site_admin":false},"body":"addressed. was in my commits but I missed to push. sorry about it.","created_at":"2018-04-30T16:14:21Z","updated_at":"2018-04-30T16:14:22Z","html_url":"https://github.com/snowplow/snowplow-elasticsearch-loader/pull/79#discussion_r185034359","pull_request_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/comments/185034359"},"html":{"href":"https://github.com/snowplow/snowplow-elasticsearch-loader/pull/79#discussion_r185034359"},"pull_request":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79"}},"in_reply_to_id":184937653},"pull_request":{"url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79","id":184726300,"html_url":"https://github.com/snowplow/snowplow-elasticsearch-loader/pull/79","diff_url":"https://github.com/snowplow/snowplow-elasticsearch-loader/pull/79.diff","patch_url":"https://github.com/snowplow/snowplow-elasticsearch-loader/pull/79.patch","issue_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues/79","number":79,"state":"open","locked":false,"title":"HTTP Basic Auth","user":{"login":"szareiangm","id":36857305,"avatar_url":"https://avatars0.githubusercontent.com/u/36857305?v=4","gravatar_id":"","url":"https://api.github.com/users/szareiangm","html_url":"https://github.com/szareiangm","followers_url":"https://api.github.com/users/szareiangm/followers","following_url":"https://api.github.com/users/szareiangm/following{/other_user}","gists_url":"https://api.github.com/users/szareiangm/gists{/gist_id}","starred_url":"https://api.github.com/users/szareiangm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szareiangm/subscriptions","organizations_url":"https://api.github.com/users/szareiangm/orgs","repos_url":"https://api.github.com/users/szareiangm/repos","events_url":"https://api.github.com/users/szareiangm/events{/privacy}","received_events_url":"https://api.github.com/users/szareiangm/received_events","type":"User","site_admin":false},"body":"Hello team,\r\n\r\nI noticed that HTTP basic auth is becoming a more popular option for Elasticsearch specially with their free offering of x-pack free license. So, I made this contribution. Hope that it helps","created_at":"2018-04-27T20:58:15Z","updated_at":"2018-04-30T16:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8cc3c0c39be8c275e431c73687161d8a73059b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79/commits","review_comments_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79/comments","review_comment_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues/79/comments","statuses_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/statuses/d544ebd6e20e3dadb6abe7791d991f326c9f0e40","head":{"label":"globeandmail:master","ref":"master","sha":"d544ebd6e20e3dadb6abe7791d991f326c9f0e40","user":{"login":"globeandmail","id":1828083,"avatar_url":"https://avatars1.githubusercontent.com/u/1828083?v=4","gravatar_id":"","url":"https://api.github.com/users/globeandmail","html_url":"https://github.com/globeandmail","followers_url":"https://api.github.com/users/globeandmail/followers","following_url":"https://api.github.com/users/globeandmail/following{/other_user}","gists_url":"https://api.github.com/users/globeandmail/gists{/gist_id}","starred_url":"https://api.github.com/users/globeandmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globeandmail/subscriptions","organizations_url":"https://api.github.com/users/globeandmail/orgs","repos_url":"https://api.github.com/users/globeandmail/repos","events_url":"https://api.github.com/users/globeandmail/events{/privacy}","received_events_url":"https://api.github.com/users/globeandmail/received_events","type":"Organization","site_admin":false},"repo":{"id":131184017,"name":"snowplow-stream-loader","full_name":"globeandmail/snowplow-stream-loader","owner":{"login":"globeandmail","id":1828083,"avatar_url":"https://avatars1.githubusercontent.com/u/1828083?v=4","gravatar_id":"","url":"https://api.github.com/users/globeandmail","html_url":"https://github.com/globeandmail","followers_url":"https://api.github.com/users/globeandmail/followers","following_url":"https://api.github.com/users/globeandmail/following{/other_user}","gists_url":"https://api.github.com/users/globeandmail/gists{/gist_id}","starred_url":"https://api.github.com/users/globeandmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globeandmail/subscriptions","organizations_url":"https://api.github.com/users/globeandmail/orgs","repos_url":"https://api.github.com/users/globeandmail/repos","events_url":"https://api.github.com/users/globeandmail/events{/privacy}","received_events_url":"https://api.github.com/users/globeandmail/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/globeandmail/snowplow-stream-loader","description":"Writes Snowplow enriched events from Kinesis to Elasticsearch","fork":true,"url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader","forks_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/forks","keys_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/teams","hooks_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/hooks","issue_events_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/issues/events{/number}","events_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/events","assignees_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/assignees{/user}","branches_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/branches{/branch}","tags_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/tags","blobs_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/languages","stargazers_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/stargazers","contributors_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/contributors","subscribers_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/subscribers","subscription_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/subscription","commits_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/contents/{+path}","compare_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/merges","archive_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/downloads","issues_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/issues{/number}","pulls_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/labels{/name}","releases_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/releases{/id}","deployments_url":"https://api.github.com/repos/globeandmail/snowplow-stream-loader/deployments","created_at":"2018-04-26T16:39:55Z","updated_at":"2018-04-30T16:14:02Z","pushed_at":"2018-04-30T16:14:01Z","git_url":"git://github.com/globeandmail/snowplow-stream-loader.git","ssh_url":"git@github.com:globeandmail/snowplow-stream-loader.git","clone_url":"https://github.com/globeandmail/snowplow-stream-loader.git","svn_url":"https://github.com/globeandmail/snowplow-stream-loader","homepage":"http://snowplowanalytics.com/","size":350,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snowplow:master","ref":"master","sha":"b14cc1b1b61a390d69ba0d93dcbf041e025af504","user":{"login":"snowplow","id":1476001,"avatar_url":"https://avatars3.githubusercontent.com/u/1476001?v=4","gravatar_id":"","url":"https://api.github.com/users/snowplow","html_url":"https://github.com/snowplow","followers_url":"https://api.github.com/users/snowplow/followers","following_url":"https://api.github.com/users/snowplow/following{/other_user}","gists_url":"https://api.github.com/users/snowplow/gists{/gist_id}","starred_url":"https://api.github.com/users/snowplow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowplow/subscriptions","organizations_url":"https://api.github.com/users/snowplow/orgs","repos_url":"https://api.github.com/users/snowplow/repos","events_url":"https://api.github.com/users/snowplow/events{/privacy}","received_events_url":"https://api.github.com/users/snowplow/received_events","type":"Organization","site_admin":false},"repo":{"id":95968485,"name":"snowplow-elasticsearch-loader","full_name":"snowplow/snowplow-elasticsearch-loader","owner":{"login":"snowplow","id":1476001,"avatar_url":"https://avatars3.githubusercontent.com/u/1476001?v=4","gravatar_id":"","url":"https://api.github.com/users/snowplow","html_url":"https://github.com/snowplow","followers_url":"https://api.github.com/users/snowplow/followers","following_url":"https://api.github.com/users/snowplow/following{/other_user}","gists_url":"https://api.github.com/users/snowplow/gists{/gist_id}","starred_url":"https://api.github.com/users/snowplow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowplow/subscriptions","organizations_url":"https://api.github.com/users/snowplow/orgs","repos_url":"https://api.github.com/users/snowplow/repos","events_url":"https://api.github.com/users/snowplow/events{/privacy}","received_events_url":"https://api.github.com/users/snowplow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snowplow/snowplow-elasticsearch-loader","description":"Writes Snowplow enriched events from Kinesis to Elasticsearch","fork":false,"url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader","forks_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/forks","keys_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/teams","hooks_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/hooks","issue_events_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues/events{/number}","events_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/events","assignees_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/assignees{/user}","branches_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/branches{/branch}","tags_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/tags","blobs_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/languages","stargazers_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/stargazers","contributors_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/contributors","subscribers_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/subscribers","subscription_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/subscription","commits_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/contents/{+path}","compare_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/merges","archive_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/downloads","issues_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues{/number}","pulls_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/labels{/name}","releases_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/releases{/id}","deployments_url":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/deployments","created_at":"2017-07-01T14:18:30Z","updated_at":"2018-03-21T09:49:35Z","pushed_at":"2018-04-30T16:14:02Z","git_url":"git://github.com/snowplow/snowplow-elasticsearch-loader.git","ssh_url":"git@github.com:snowplow/snowplow-elasticsearch-loader.git","clone_url":"https://github.com/snowplow/snowplow-elasticsearch-loader.git","svn_url":"https://github.com/snowplow/snowplow-elasticsearch-loader","homepage":"http://snowplowanalytics.com/","size":310,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79"},"html":{"href":"https://github.com/snowplow/snowplow-elasticsearch-loader/pull/79"},"issue":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues/79"},"comments":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/snowplow/snowplow-elasticsearch-loader/statuses/d544ebd6e20e3dadb6abe7791d991f326c9f0e40"}},"author_association":"NONE"}}
{"actor":{"display_login":"szareiangm"}}