{"action":"created","issue":{"url":"https://api.github.com/repos/emotiq/emotiq/issues/180","repository_url":"https://api.github.com/repos/emotiq/emotiq","labels_url":"https://api.github.com/repos/emotiq/emotiq/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/emotiq/emotiq/issues/180/comments","events_url":"https://api.github.com/repos/emotiq/emotiq/issues/180/events","html_url":"https://github.com/emotiq/emotiq/pull/180","id":327469326,"number":180,"title":"bitcoin-style base58-check p2pkh addresses","user":{"login":"markhdavid","id":6209504,"avatar_url":"https://avatars1.githubusercontent.com/u/6209504?v=4","gravatar_id":"","url":"https://api.github.com/users/markhdavid","html_url":"https://github.com/markhdavid","followers_url":"https://api.github.com/users/markhdavid/followers","following_url":"https://api.github.com/users/markhdavid/following{/other_user}","gists_url":"https://api.github.com/users/markhdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/markhdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhdavid/subscriptions","organizations_url":"https://api.github.com/users/markhdavid/orgs","repos_url":"https://api.github.com/users/markhdavid/repos","events_url":"https://api.github.com/users/markhdavid/events{/privacy}","received_events_url":"https://api.github.com/users/markhdavid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-29T20:09:37Z","updated_at":"2018-05-29T21:19:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/emotiq/emotiq/pulls/180","html_url":"https://github.com/emotiq/emotiq/pull/180","diff_url":"https://github.com/emotiq/emotiq/pull/180.diff","patch_url":"https://github.com/emotiq/emotiq/pull/180.patch"},"body":"bitcoin-style base58-check p2pkh addresses\r\n\r\n- vec-repr:base58 method now left-pads with encoded 0's in vector case\r\n- added base58 encoding unit tests (lifted from bitcoin's)\r\n  test with: (asdf:test-system :crypto-pairings/t)\r\n  notice: Base58-test\r\n- added new hashes: hash/ripemd/160 and has/sha2/256\r\n- added new module address.lisp which exports public-key-to-address\r\n- created new unit tests file address-tests.lisp\r\n  test with (asdf:test-system :cosi-bls-tests)\r\n  notice: \"Public Key to Key Hash as Address Test (Base58Check Encoding)\""},"comment":{"url":"https://api.github.com/repos/emotiq/emotiq/issues/comments/392948857","html_url":"https://github.com/emotiq/emotiq/pull/180#issuecomment-392948857","issue_url":"https://api.github.com/repos/emotiq/emotiq/issues/180","id":392948857,"user":{"login":"markhdavid","id":6209504,"avatar_url":"https://avatars1.githubusercontent.com/u/6209504?v=4","gravatar_id":"","url":"https://api.github.com/users/markhdavid","html_url":"https://github.com/markhdavid","followers_url":"https://api.github.com/users/markhdavid/followers","following_url":"https://api.github.com/users/markhdavid/following{/other_user}","gists_url":"https://api.github.com/users/markhdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/markhdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhdavid/subscriptions","organizations_url":"https://api.github.com/users/markhdavid/orgs","repos_url":"https://api.github.com/users/markhdavid/repos","events_url":"https://api.github.com/users/markhdavid/events{/privacy}","received_events_url":"https://api.github.com/users/markhdavid/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T21:19:30Z","updated_at":"2018-05-29T21:19:30Z","author_association":"COLLABORATOR","body":"Regarding integer encoding vs. vector encoding, we simply need a vector encoding.  There's no known use in our software for the integer encoding, nor for the decoding, but we have (and the world has) the vector encoding case very strongly, and it's being used about 2 million times a day for bitcoin address generation, so if you want, we can just use my simple function I wrote 2 days ago to generate it from a vector if you want to leave your code pure.  This is bumming me out."}}
{"actor":{"display_login":"markhdavid"}}