{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/211807927","pull_request_review_id":148307306,"id":211807927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTgwNzkyNw==","diff_hunk":"@@ -45,6 +46,95 @@ extern \"C\" {\n  * Maximum schedule group name length in chars including null char\n  */\n \n+/**\n+ * Schedule configuration options\n+ */\n+typedef struct odp_schedule_config_t {\n+\n+\t/* Number of flows per queue to be supported\n+\t * Only valid when scheduler is configured as flow_aware mode\n+\t *\n+\t * Flows are lightweight entities and packets can be assigned to specific\n+\t * flows by the application using odp_event_flow_hash_set() before\n+\t * enqueuing the packet into the scheduler.\n+\t * This value is valid only when scheduler is configured in flow aware\n+\t * mode.\n+\t * Depening on the implementation this number might be rounded-off to\n+\t * nearest supported value (e.g power of 2)\n+\t * This number should be less than maximum flow supported by the\n+\t * implementation.\n+\t * @see odp_schedule_capability_t\n+\t */\n+\tuint32_t flow_count;\n+\n+\t/* Maximum number of schedule queues to be supported\n+\t * Application configures the maximum number of schedule queues to be\n+\t * supported by the implementation.\n+\t * @see odp_queue_capability_t\n+\t */\n+\tuint32_t queue_count;\n+\n+\t/* Maximum number of events required to be stored simultaneously in\n+\t * schedule queue. This number should be less than 'max_queue_size'\n+\t * supported by the implementation.\n+\t */\n+\tuint32_t queue_size;\n+} odp_schedule_config_t;\n+\n+typedef struct odp_schedule_capability_t {\n+\n+\t/* Maximum supported flows per queue\n+\t * Specifies the maximum number of flows per queue supported by the\n+\t * implementation.\n+\t * A value of 0 indicates flow aware mode is not supported.\n+\t */\n+\tuint32_t max_flow_count;\n+\n+\t/* Maximum supported queues\n+\t * Specifies the maximum number of queues supported by the\n+\t * implementation.\n+\t */\n+\tuint32_t max_queue_count;\n+\n+\t/* Maximum number of events a schedule queue can store simultaneoulsy.\n+\t * A value of 0 indicates the implementation does not restrict the\n+\t * queue size\n+\t */\n+\tuint32_t max_queue_size;\n+} odp_schedule_capability_t;\n+\n+/**\n+ * Start scheduler operation\n+ *\n+ * Activate scheduler module to schedule packets across different schedule\n+ * queues. The scheduler module should be started before creating any odp\n+ * queues. The scheduler module can be stopped usinig odp_schedule_stop().\n+ *\n+ * The initialization sequeunce should be,\n+ * odp_schedule_capability()\n+ * odp_schedule_config_init()\n+ * odp_schedule_config()\n+ * odp_schedule_start()\n+ * odp_schedule()\n+ *\n+ * @retval 0 on success\n+ * @retval <0 on failure\n+ *\n+ * @odp_schedule_stop()\n+ */\n+int odp_schedule_start();","path":"include/odp/api/spec/schedule.h","position":88,"original_position":88,"commit_id":"62edf25a36e374e48cb1f51ddbdfe2f36dc48276","original_commit_id":"62edf25a36e374e48cb1f51ddbdfe2f36dc48276","user":{"login":"Bill-Fischofer-Linaro","id":13422322,"node_id":"MDQ6VXNlcjEzNDIyMzIy","avatar_url":"https://avatars1.githubusercontent.com/u/13422322?v=4","gravatar_id":"","url":"https://api.github.com/users/Bill-Fischofer-Linaro","html_url":"https://github.com/Bill-Fischofer-Linaro","followers_url":"https://api.github.com/users/Bill-Fischofer-Linaro/followers","following_url":"https://api.github.com/users/Bill-Fischofer-Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Bill-Fischofer-Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Bill-Fischofer-Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bill-Fischofer-Linaro/subscriptions","organizations_url":"https://api.github.com/users/Bill-Fischofer-Linaro/orgs","repos_url":"https://api.github.com/users/Bill-Fischofer-Linaro/repos","events_url":"https://api.github.com/users/Bill-Fischofer-Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Bill-Fischofer-Linaro/received_events","type":"User","site_admin":false},"body":"needs to be `int odp_schedule_start(void);` here.","created_at":"2018-08-22T01:37:06Z","updated_at":"2018-08-22T01:42:21Z","html_url":"https://github.com/Linaro/odp/pull/665#discussion_r211807927","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/665","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/211807927"},"html":{"href":"https://github.com/Linaro/odp/pull/665#discussion_r211807927"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/665"}}},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/665","id":206714922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzE0OTIy","html_url":"https://github.com/Linaro/odp/pull/665","diff_url":"https://github.com/Linaro/odp/pull/665.diff","patch_url":"https://github.com/Linaro/odp/pull/665.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/665","number":665,"state":"open","locked":false,"title":"[PATCH API-NEXT v2] api: schedule: add scheduler flow aware mode","user":{"login":"bala-manoharan","id":25454254,"node_id":"MDQ6VXNlcjI1NDU0MjU0","avatar_url":"https://avatars0.githubusercontent.com/u/25454254?v=4","gravatar_id":"","url":"https://api.github.com/users/bala-manoharan","html_url":"https://github.com/bala-manoharan","followers_url":"https://api.github.com/users/bala-manoharan/followers","following_url":"https://api.github.com/users/bala-manoharan/following{/other_user}","gists_url":"https://api.github.com/users/bala-manoharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bala-manoharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bala-manoharan/subscriptions","organizations_url":"https://api.github.com/users/bala-manoharan/orgs","repos_url":"https://api.github.com/users/bala-manoharan/repos","events_url":"https://api.github.com/users/bala-manoharan/events{/privacy}","received_events_url":"https://api.github.com/users/bala-manoharan/received_events","type":"User","site_admin":false},"body":"ODP scheduler configuration to support flow aware mode\r\n\r\nSigned-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>","created_at":"2018-08-07T14:20:27Z","updated_at":"2018-08-22T01:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd567b03bbf050c03e9d0899bed4fcc23d1e6157","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":577854052,"node_id":"MDU6TGFiZWw1Nzc4NTQwNTI=","url":"https://api.github.com/repos/Linaro/odp/labels/Email_sent","name":"Email_sent","color":"ededed","default":false},{"id":666131932,"node_id":"MDU6TGFiZWw2NjYxMzE5MzI=","url":"https://api.github.com/repos/Linaro/odp/labels/checkpatch","name":"checkpatch","color":"0000ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/665/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/665/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/665/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/62edf25a36e374e48cb1f51ddbdfe2f36dc48276","head":{"label":"bala-manoharan:sched_flow_aware","ref":"sched_flow_aware","sha":"62edf25a36e374e48cb1f51ddbdfe2f36dc48276","user":{"login":"bala-manoharan","id":25454254,"node_id":"MDQ6VXNlcjI1NDU0MjU0","avatar_url":"https://avatars0.githubusercontent.com/u/25454254?v=4","gravatar_id":"","url":"https://api.github.com/users/bala-manoharan","html_url":"https://github.com/bala-manoharan","followers_url":"https://api.github.com/users/bala-manoharan/followers","following_url":"https://api.github.com/users/bala-manoharan/following{/other_user}","gists_url":"https://api.github.com/users/bala-manoharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bala-manoharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bala-manoharan/subscriptions","organizations_url":"https://api.github.com/users/bala-manoharan/orgs","repos_url":"https://api.github.com/users/bala-manoharan/repos","events_url":"https://api.github.com/users/bala-manoharan/events{/privacy}","received_events_url":"https://api.github.com/users/bala-manoharan/received_events","type":"User","site_admin":false},"repo":{"id":90684593,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY4NDU5Mw==","name":"odp","full_name":"bala-manoharan/odp","owner":{"login":"bala-manoharan","id":25454254,"node_id":"MDQ6VXNlcjI1NDU0MjU0","avatar_url":"https://avatars0.githubusercontent.com/u/25454254?v=4","gravatar_id":"","url":"https://api.github.com/users/bala-manoharan","html_url":"https://github.com/bala-manoharan","followers_url":"https://api.github.com/users/bala-manoharan/followers","following_url":"https://api.github.com/users/bala-manoharan/following{/other_user}","gists_url":"https://api.github.com/users/bala-manoharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bala-manoharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bala-manoharan/subscriptions","organizations_url":"https://api.github.com/users/bala-manoharan/orgs","repos_url":"https://api.github.com/users/bala-manoharan/repos","events_url":"https://api.github.com/users/bala-manoharan/events{/privacy}","received_events_url":"https://api.github.com/users/bala-manoharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bala-manoharan/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/bala-manoharan/odp","forks_url":"https://api.github.com/repos/bala-manoharan/odp/forks","keys_url":"https://api.github.com/repos/bala-manoharan/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bala-manoharan/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bala-manoharan/odp/teams","hooks_url":"https://api.github.com/repos/bala-manoharan/odp/hooks","issue_events_url":"https://api.github.com/repos/bala-manoharan/odp/issues/events{/number}","events_url":"https://api.github.com/repos/bala-manoharan/odp/events","assignees_url":"https://api.github.com/repos/bala-manoharan/odp/assignees{/user}","branches_url":"https://api.github.com/repos/bala-manoharan/odp/branches{/branch}","tags_url":"https://api.github.com/repos/bala-manoharan/odp/tags","blobs_url":"https://api.github.com/repos/bala-manoharan/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bala-manoharan/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bala-manoharan/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bala-manoharan/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bala-manoharan/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/bala-manoharan/odp/languages","stargazers_url":"https://api.github.com/repos/bala-manoharan/odp/stargazers","contributors_url":"https://api.github.com/repos/bala-manoharan/odp/contributors","subscribers_url":"https://api.github.com/repos/bala-manoharan/odp/subscribers","subscription_url":"https://api.github.com/repos/bala-manoharan/odp/subscription","commits_url":"https://api.github.com/repos/bala-manoharan/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bala-manoharan/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bala-manoharan/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bala-manoharan/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bala-manoharan/odp/contents/{+path}","compare_url":"https://api.github.com/repos/bala-manoharan/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bala-manoharan/odp/merges","archive_url":"https://api.github.com/repos/bala-manoharan/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bala-manoharan/odp/downloads","issues_url":"https://api.github.com/repos/bala-manoharan/odp/issues{/number}","pulls_url":"https://api.github.com/repos/bala-manoharan/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/bala-manoharan/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/bala-manoharan/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bala-manoharan/odp/labels{/name}","releases_url":"https://api.github.com/repos/bala-manoharan/odp/releases{/id}","deployments_url":"https://api.github.com/repos/bala-manoharan/odp/deployments","created_at":"2017-05-09T00:27:18Z","updated_at":"2018-07-25T08:42:38Z","pushed_at":"2018-08-21T15:02:25Z","git_url":"git://github.com/bala-manoharan/odp.git","ssh_url":"git@github.com:bala-manoharan/odp.git","clone_url":"https://github.com/bala-manoharan/odp.git","svn_url":"https://github.com/bala-manoharan/odp","homepage":"http://www.opendataplane.org/","size":10727,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:api-next","ref":"api-next","sha":"d42ef2c5a01d29a9877e0b487694f66e40c43624","user":{"login":"Linaro","id":1180626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODA2MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzMDIxNQ==","name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODA2MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2018-08-21T15:13:17Z","pushed_at":"2018-08-21T16:28:31Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":11689,"stargazers_count":51,"watchers_count":51,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":53,"open_issues":10,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/665"},"html":{"href":"https://github.com/Linaro/odp/pull/665"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/665"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/62edf25a36e374e48cb1f51ddbdfe2f36dc48276"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Bill-Fischofer-Linaro"}}