{"action":"closed","number":821,"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/821","id":201430120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDMwMTIw","html_url":"https://github.com/sxs-collaboration/spectre/pull/821","diff_url":"https://github.com/sxs-collaboration/spectre/pull/821.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/821.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/821","number":821,"state":"closed","locked":false,"title":"Fix compilation with AppleClang 9.1.0.9020039","user":{"login":"kidder","id":1264082,"node_id":"MDQ6VXNlcjEyNjQwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"body":"Need to explicitly specify template parameter for ThermodynamicDim.\r\nOtherwise, check_impl template is ignored with:\r\ncould not match '__make_integer_seq' against 'integer_sequence'\r\nfor the first argument of check_impl\r\n\r\n## Proposed changes\r\n\r\n<!--\r\nAt a high level, describe what this PR does.\r\n-->\r\n\r\n### Types of changes:\r\n\r\n- [x] Bugfix\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc...\r\n-->\r\n","created_at":"2018-07-14T01:48:27Z","updated_at":"2018-07-14T20:04:06Z","closed_at":"2018-07-14T20:04:06Z","merged_at":"2018-07-14T20:04:06Z","merge_commit_sha":"f28e276e5bbb805f5d71e7bdcc5baea606d20698","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/821/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/821/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/821/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/efc52b753fc3c71072f196cd184e7002c8016869","head":{"label":"kidder:fix/mac_bug","ref":"fix/mac_bug","sha":"efc52b753fc3c71072f196cd184e7002c8016869","user":{"login":"kidder","id":1264082,"node_id":"MDQ6VXNlcjEyNjQwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"repo":{"id":87580754,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU4MDc1NA==","name":"spectre","full_name":"kidder/spectre","owner":{"login":"kidder","id":1264082,"node_id":"MDQ6VXNlcjEyNjQwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kidder/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/kidder/spectre","forks_url":"https://api.github.com/repos/kidder/spectre/forks","keys_url":"https://api.github.com/repos/kidder/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kidder/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kidder/spectre/teams","hooks_url":"https://api.github.com/repos/kidder/spectre/hooks","issue_events_url":"https://api.github.com/repos/kidder/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/kidder/spectre/events","assignees_url":"https://api.github.com/repos/kidder/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/kidder/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/kidder/spectre/tags","blobs_url":"https://api.github.com/repos/kidder/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kidder/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kidder/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/kidder/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kidder/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/kidder/spectre/languages","stargazers_url":"https://api.github.com/repos/kidder/spectre/stargazers","contributors_url":"https://api.github.com/repos/kidder/spectre/contributors","subscribers_url":"https://api.github.com/repos/kidder/spectre/subscribers","subscription_url":"https://api.github.com/repos/kidder/spectre/subscription","commits_url":"https://api.github.com/repos/kidder/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/kidder/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/kidder/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/kidder/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/kidder/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/kidder/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kidder/spectre/merges","archive_url":"https://api.github.com/repos/kidder/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kidder/spectre/downloads","issues_url":"https://api.github.com/repos/kidder/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/kidder/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/kidder/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/kidder/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kidder/spectre/labels{/name}","releases_url":"https://api.github.com/repos/kidder/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/kidder/spectre/deployments","created_at":"2017-04-07T19:36:39Z","updated_at":"2018-07-13T20:14:14Z","pushed_at":"2018-07-13T22:47:10Z","git_url":"git://github.com/kidder/spectre.git","ssh_url":"git@github.com:kidder/spectre.git","clone_url":"https://github.com/kidder/spectre.git","svn_url":"https://github.com/kidder/spectre","homepage":null,"size":5608,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"e9f7025741697e7f93d5cc820928665e89a94d5c","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-07-14T02:39:27Z","pushed_at":"2018-07-14T20:04:06Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":12218,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":98,"watchers":26,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/821"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/821"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/821"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/efc52b753fc3c71072f196cd184e7002c8016869"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"wthrowe"}}