{"action":"opened","number":941,"pull_request":{"url":"https://api.github.com/repos/MegaMek/megamek/pulls/941","id":176072826,"html_url":"https://github.com/MegaMek/megamek/pull/941","diff_url":"https://github.com/MegaMek/megamek/pull/941.diff","patch_url":"https://github.com/MegaMek/megamek/pull/941.patch","issue_url":"https://api.github.com/repos/MegaMek/megamek/issues/941","number":941,"state":"open","locked":false,"title":"Unload Stranded Bug fix and Voluntary Infantry Unloading Implementation","user":{"login":"NickAragua","id":29387808,"avatar_url":"https://avatars2.githubusercontent.com/u/29387808?v=4","gravatar_id":"","url":"https://api.github.com/users/NickAragua","html_url":"https://github.com/NickAragua","followers_url":"https://api.github.com/users/NickAragua/followers","following_url":"https://api.github.com/users/NickAragua/following{/other_user}","gists_url":"https://api.github.com/users/NickAragua/gists{/gist_id}","starred_url":"https://api.github.com/users/NickAragua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickAragua/subscriptions","organizations_url":"https://api.github.com/users/NickAragua/orgs","repos_url":"https://api.github.com/users/NickAragua/repos","events_url":"https://api.github.com/users/NickAragua/events{/privacy}","received_events_url":"https://api.github.com/users/NickAragua/received_events","type":"User","site_admin":false},"body":"The changes to BotClient and Server.java are intended to address the issue of Princess throwing NPEs in the situation where there's a deployment phase while she has units stranded in transports. \r\n\r\nIt also prevents her from unloading stranded units into lava or vacuum if they wouldn't survive there.\r\n\r\nIt also happens to address an (undocumented) issue that I've observed where, if a player has stranded units in transports during a deployment phase, the player is prompted to deploy those units!\r\n\r\nI also got bored, so I coded up some fairly primitive logic to allow Princess to voluntarily unload units from transports. She will do so when it's a legal move and when the unit being unloaded is within reasonable distance (defined as 1 + max weapons range) of the nearest enemy unit.","created_at":"2018-03-20T02:20:54Z","updated_at":"2018-03-20T02:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MegaMek/megamek/pulls/941/commits","review_comments_url":"https://api.github.com/repos/MegaMek/megamek/pulls/941/comments","review_comment_url":"https://api.github.com/repos/MegaMek/megamek/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MegaMek/megamek/issues/941/comments","statuses_url":"https://api.github.com/repos/MegaMek/megamek/statuses/9e428cb891abee3c6142ee30ee1c75129a05b771","head":{"label":"NickAragua:voluntary_infantry_unload_implementation","ref":"voluntary_infantry_unload_implementation","sha":"9e428cb891abee3c6142ee30ee1c75129a05b771","user":{"login":"NickAragua","id":29387808,"avatar_url":"https://avatars2.githubusercontent.com/u/29387808?v=4","gravatar_id":"","url":"https://api.github.com/users/NickAragua","html_url":"https://github.com/NickAragua","followers_url":"https://api.github.com/users/NickAragua/followers","following_url":"https://api.github.com/users/NickAragua/following{/other_user}","gists_url":"https://api.github.com/users/NickAragua/gists{/gist_id}","starred_url":"https://api.github.com/users/NickAragua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickAragua/subscriptions","organizations_url":"https://api.github.com/users/NickAragua/orgs","repos_url":"https://api.github.com/users/NickAragua/repos","events_url":"https://api.github.com/users/NickAragua/events{/privacy}","received_events_url":"https://api.github.com/users/NickAragua/received_events","type":"User","site_admin":false},"repo":{"id":98764379,"name":"megamek","full_name":"NickAragua/megamek","owner":{"login":"NickAragua","id":29387808,"avatar_url":"https://avatars2.githubusercontent.com/u/29387808?v=4","gravatar_id":"","url":"https://api.github.com/users/NickAragua","html_url":"https://github.com/NickAragua","followers_url":"https://api.github.com/users/NickAragua/followers","following_url":"https://api.github.com/users/NickAragua/following{/other_user}","gists_url":"https://api.github.com/users/NickAragua/gists{/gist_id}","starred_url":"https://api.github.com/users/NickAragua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickAragua/subscriptions","organizations_url":"https://api.github.com/users/NickAragua/orgs","repos_url":"https://api.github.com/users/NickAragua/repos","events_url":"https://api.github.com/users/NickAragua/events{/privacy}","received_events_url":"https://api.github.com/users/NickAragua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NickAragua/megamek","description":"MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.","fork":true,"url":"https://api.github.com/repos/NickAragua/megamek","forks_url":"https://api.github.com/repos/NickAragua/megamek/forks","keys_url":"https://api.github.com/repos/NickAragua/megamek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NickAragua/megamek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NickAragua/megamek/teams","hooks_url":"https://api.github.com/repos/NickAragua/megamek/hooks","issue_events_url":"https://api.github.com/repos/NickAragua/megamek/issues/events{/number}","events_url":"https://api.github.com/repos/NickAragua/megamek/events","assignees_url":"https://api.github.com/repos/NickAragua/megamek/assignees{/user}","branches_url":"https://api.github.com/repos/NickAragua/megamek/branches{/branch}","tags_url":"https://api.github.com/repos/NickAragua/megamek/tags","blobs_url":"https://api.github.com/repos/NickAragua/megamek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NickAragua/megamek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NickAragua/megamek/git/refs{/sha}","trees_url":"https://api.github.com/repos/NickAragua/megamek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NickAragua/megamek/statuses/{sha}","languages_url":"https://api.github.com/repos/NickAragua/megamek/languages","stargazers_url":"https://api.github.com/repos/NickAragua/megamek/stargazers","contributors_url":"https://api.github.com/repos/NickAragua/megamek/contributors","subscribers_url":"https://api.github.com/repos/NickAragua/megamek/subscribers","subscription_url":"https://api.github.com/repos/NickAragua/megamek/subscription","commits_url":"https://api.github.com/repos/NickAragua/megamek/commits{/sha}","git_commits_url":"https://api.github.com/repos/NickAragua/megamek/git/commits{/sha}","comments_url":"https://api.github.com/repos/NickAragua/megamek/comments{/number}","issue_comment_url":"https://api.github.com/repos/NickAragua/megamek/issues/comments{/number}","contents_url":"https://api.github.com/repos/NickAragua/megamek/contents/{+path}","compare_url":"https://api.github.com/repos/NickAragua/megamek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NickAragua/megamek/merges","archive_url":"https://api.github.com/repos/NickAragua/megamek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NickAragua/megamek/downloads","issues_url":"https://api.github.com/repos/NickAragua/megamek/issues{/number}","pulls_url":"https://api.github.com/repos/NickAragua/megamek/pulls{/number}","milestones_url":"https://api.github.com/repos/NickAragua/megamek/milestones{/number}","notifications_url":"https://api.github.com/repos/NickAragua/megamek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NickAragua/megamek/labels{/name}","releases_url":"https://api.github.com/repos/NickAragua/megamek/releases{/id}","deployments_url":"https://api.github.com/repos/NickAragua/megamek/deployments","created_at":"2017-07-29T23:41:25Z","updated_at":"2017-07-29T23:41:56Z","pushed_at":"2018-03-20T02:14:48Z","git_url":"git://github.com/NickAragua/megamek.git","ssh_url":"git@github.com:NickAragua/megamek.git","clone_url":"https://github.com/NickAragua/megamek.git","svn_url":"https://github.com/NickAragua/megamek","homepage":"http://www.megamek.info","size":379188,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MegaMek:master","ref":"master","sha":"d0c8ab330ffb645f47e7ad1817f7bb1d3b079079","user":{"login":"MegaMek","id":13810529,"avatar_url":"https://avatars0.githubusercontent.com/u/13810529?v=4","gravatar_id":"","url":"https://api.github.com/users/MegaMek","html_url":"https://github.com/MegaMek","followers_url":"https://api.github.com/users/MegaMek/followers","following_url":"https://api.github.com/users/MegaMek/following{/other_user}","gists_url":"https://api.github.com/users/MegaMek/gists{/gist_id}","starred_url":"https://api.github.com/users/MegaMek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MegaMek/subscriptions","organizations_url":"https://api.github.com/users/MegaMek/orgs","repos_url":"https://api.github.com/users/MegaMek/repos","events_url":"https://api.github.com/users/MegaMek/events{/privacy}","received_events_url":"https://api.github.com/users/MegaMek/received_events","type":"Organization","site_admin":false},"repo":{"id":40765298,"name":"megamek","full_name":"MegaMek/megamek","owner":{"login":"MegaMek","id":13810529,"avatar_url":"https://avatars0.githubusercontent.com/u/13810529?v=4","gravatar_id":"","url":"https://api.github.com/users/MegaMek","html_url":"https://github.com/MegaMek","followers_url":"https://api.github.com/users/MegaMek/followers","following_url":"https://api.github.com/users/MegaMek/following{/other_user}","gists_url":"https://api.github.com/users/MegaMek/gists{/gist_id}","starred_url":"https://api.github.com/users/MegaMek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MegaMek/subscriptions","organizations_url":"https://api.github.com/users/MegaMek/orgs","repos_url":"https://api.github.com/users/MegaMek/repos","events_url":"https://api.github.com/users/MegaMek/events{/privacy}","received_events_url":"https://api.github.com/users/MegaMek/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MegaMek/megamek","description":"MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.","fork":false,"url":"https://api.github.com/repos/MegaMek/megamek","forks_url":"https://api.github.com/repos/MegaMek/megamek/forks","keys_url":"https://api.github.com/repos/MegaMek/megamek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MegaMek/megamek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MegaMek/megamek/teams","hooks_url":"https://api.github.com/repos/MegaMek/megamek/hooks","issue_events_url":"https://api.github.com/repos/MegaMek/megamek/issues/events{/number}","events_url":"https://api.github.com/repos/MegaMek/megamek/events","assignees_url":"https://api.github.com/repos/MegaMek/megamek/assignees{/user}","branches_url":"https://api.github.com/repos/MegaMek/megamek/branches{/branch}","tags_url":"https://api.github.com/repos/MegaMek/megamek/tags","blobs_url":"https://api.github.com/repos/MegaMek/megamek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MegaMek/megamek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MegaMek/megamek/git/refs{/sha}","trees_url":"https://api.github.com/repos/MegaMek/megamek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MegaMek/megamek/statuses/{sha}","languages_url":"https://api.github.com/repos/MegaMek/megamek/languages","stargazers_url":"https://api.github.com/repos/MegaMek/megamek/stargazers","contributors_url":"https://api.github.com/repos/MegaMek/megamek/contributors","subscribers_url":"https://api.github.com/repos/MegaMek/megamek/subscribers","subscription_url":"https://api.github.com/repos/MegaMek/megamek/subscription","commits_url":"https://api.github.com/repos/MegaMek/megamek/commits{/sha}","git_commits_url":"https://api.github.com/repos/MegaMek/megamek/git/commits{/sha}","comments_url":"https://api.github.com/repos/MegaMek/megamek/comments{/number}","issue_comment_url":"https://api.github.com/repos/MegaMek/megamek/issues/comments{/number}","contents_url":"https://api.github.com/repos/MegaMek/megamek/contents/{+path}","compare_url":"https://api.github.com/repos/MegaMek/megamek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MegaMek/megamek/merges","archive_url":"https://api.github.com/repos/MegaMek/megamek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MegaMek/megamek/downloads","issues_url":"https://api.github.com/repos/MegaMek/megamek/issues{/number}","pulls_url":"https://api.github.com/repos/MegaMek/megamek/pulls{/number}","milestones_url":"https://api.github.com/repos/MegaMek/megamek/milestones{/number}","notifications_url":"https://api.github.com/repos/MegaMek/megamek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MegaMek/megamek/labels{/name}","releases_url":"https://api.github.com/repos/MegaMek/megamek/releases{/id}","deployments_url":"https://api.github.com/repos/MegaMek/megamek/deployments","created_at":"2015-08-15T14:47:29Z","updated_at":"2018-03-19T13:10:30Z","pushed_at":"2018-03-19T13:10:28Z","git_url":"git://github.com/MegaMek/megamek.git","ssh_url":"git@github.com:MegaMek/megamek.git","clone_url":"https://github.com/MegaMek/megamek.git","svn_url":"https://github.com/MegaMek/megamek","homepage":"http://www.megamek.org","size":474052,"stargazers_count":80,"watchers_count":80,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":163,"license":null,"forks":38,"open_issues":163,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MegaMek/megamek/pulls/941"},"html":{"href":"https://github.com/MegaMek/megamek/pull/941"},"issue":{"href":"https://api.github.com/repos/MegaMek/megamek/issues/941"},"comments":{"href":"https://api.github.com/repos/MegaMek/megamek/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/MegaMek/megamek/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/MegaMek/megamek/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MegaMek/megamek/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/MegaMek/megamek/statuses/9e428cb891abee3c6142ee30ee1c75129a05b771"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":100,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"NickAragua"}}