{"action":"created","comment":{"url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/comments/240377556","pull_request_review_id":183395492,"id":240377556,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDM3NzU1Ng==","diff_hunk":"@@ -420,13 +422,13 @@ void TestPoseStamped(std::mt19937_64& generator)\n                       << bytes_written << \" \" << deserialized.second;\n             assert(bytes_written == deserialized.second);\n         }\n-        if (!Equal(pose, deserialized.first))\n+        if (pose == deserialized.first)","path":"src/test_ros_serialization.cpp","position":null,"original_position":124,"commit_id":"ed071962db83e6234ded81e37110c68180e45a1f","original_commit_id":"b81ded4ba2d5d07b033b744e86362af2c89c7041","user":{"login":"dmcconachie","id":8689721,"node_id":"MDQ6VXNlcjg2ODk3MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8689721?v=4","gravatar_id":"","url":"https://api.github.com/users/dmcconachie","html_url":"https://github.com/dmcconachie","followers_url":"https://api.github.com/users/dmcconachie/followers","following_url":"https://api.github.com/users/dmcconachie/following{/other_user}","gists_url":"https://api.github.com/users/dmcconachie/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcconachie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcconachie/subscriptions","organizations_url":"https://api.github.com/users/dmcconachie/orgs","repos_url":"https://api.github.com/users/dmcconachie/repos","events_url":"https://api.github.com/users/dmcconachie/events{/privacy}","received_events_url":"https://api.github.com/users/dmcconachie/received_events","type":"User","site_admin":false},"body":"Yup.","created_at":"2018-12-10T20:59:02Z","updated_at":"2018-12-10T20:59:02Z","html_url":"https://github.com/UM-ARM-Lab/arc_utilities/pull/54#discussion_r240377556","pull_request_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/comments/240377556"},"html":{"href":"https://github.com/UM-ARM-Lab/arc_utilities/pull/54#discussion_r240377556"},"pull_request":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54"}},"in_reply_to_id":240376344},"pull_request":{"url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54","id":237447428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDQ3NDI4","html_url":"https://github.com/UM-ARM-Lab/arc_utilities/pull/54","diff_url":"https://github.com/UM-ARM-Lab/arc_utilities/pull/54.diff","patch_url":"https://github.com/UM-ARM-Lab/arc_utilities/pull/54.patch","issue_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/54","number":54,"state":"open","locked":false,"title":"[Feature] Serialization wrapper for generic ROS messages","user":{"login":"dmcconachie","id":8689721,"node_id":"MDQ6VXNlcjg2ODk3MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8689721?v=4","gravatar_id":"","url":"https://api.github.com/users/dmcconachie","html_url":"https://github.com/dmcconachie","followers_url":"https://api.github.com/users/dmcconachie/followers","following_url":"https://api.github.com/users/dmcconachie/following{/other_user}","gists_url":"https://api.github.com/users/dmcconachie/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcconachie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcconachie/subscriptions","organizations_url":"https://api.github.com/users/dmcconachie/orgs","repos_url":"https://api.github.com/users/dmcconachie/repos","events_url":"https://api.github.com/users/dmcconachie/events{/privacy}","received_events_url":"https://api.github.com/users/dmcconachie/received_events","type":"User","site_admin":false},"body":"Adds an interface consistent with other serialization methods in arc_utilities for generic ROS messages.\r\n\r\nTested on `visualization_msgs::Marker`, `geometry_msgs::PoseStamped`, and `geometery_msgs::TransformStamped`.","created_at":"2018-12-10T19:59:20Z","updated_at":"2018-12-10T20:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2ecc3ddc2d7a86672d42c9a7f8970433c08f9ec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bsaund","id":7277089,"node_id":"MDQ6VXNlcjcyNzcwODk=","avatar_url":"https://avatars1.githubusercontent.com/u/7277089?v=4","gravatar_id":"","url":"https://api.github.com/users/bsaund","html_url":"https://github.com/bsaund","followers_url":"https://api.github.com/users/bsaund/followers","following_url":"https://api.github.com/users/bsaund/following{/other_user}","gists_url":"https://api.github.com/users/bsaund/gists{/gist_id}","starred_url":"https://api.github.com/users/bsaund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsaund/subscriptions","organizations_url":"https://api.github.com/users/bsaund/orgs","repos_url":"https://api.github.com/users/bsaund/repos","events_url":"https://api.github.com/users/bsaund/events{/privacy}","received_events_url":"https://api.github.com/users/bsaund/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54/commits","review_comments_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54/comments","review_comment_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/54/comments","statuses_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/statuses/ed071962db83e6234ded81e37110c68180e45a1f","head":{"label":"UM-ARM-Lab:RosSerialization","ref":"RosSerialization","sha":"ed071962db83e6234ded81e37110c68180e45a1f","user":{"login":"UM-ARM-Lab","id":22779897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzc5ODk3","avatar_url":"https://avatars2.githubusercontent.com/u/22779897?v=4","gravatar_id":"","url":"https://api.github.com/users/UM-ARM-Lab","html_url":"https://github.com/UM-ARM-Lab","followers_url":"https://api.github.com/users/UM-ARM-Lab/followers","following_url":"https://api.github.com/users/UM-ARM-Lab/following{/other_user}","gists_url":"https://api.github.com/users/UM-ARM-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-ARM-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-ARM-Lab/subscriptions","organizations_url":"https://api.github.com/users/UM-ARM-Lab/orgs","repos_url":"https://api.github.com/users/UM-ARM-Lab/repos","events_url":"https://api.github.com/users/UM-ARM-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-ARM-Lab/received_events","type":"Organization","site_admin":false},"repo":{"id":36543559,"node_id":"MDEwOlJlcG9zaXRvcnkzNjU0MzU1OQ==","name":"arc_utilities","full_name":"UM-ARM-Lab/arc_utilities","private":false,"owner":{"login":"UM-ARM-Lab","id":22779897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzc5ODk3","avatar_url":"https://avatars2.githubusercontent.com/u/22779897?v=4","gravatar_id":"","url":"https://api.github.com/users/UM-ARM-Lab","html_url":"https://github.com/UM-ARM-Lab","followers_url":"https://api.github.com/users/UM-ARM-Lab/followers","following_url":"https://api.github.com/users/UM-ARM-Lab/following{/other_user}","gists_url":"https://api.github.com/users/UM-ARM-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-ARM-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-ARM-Lab/subscriptions","organizations_url":"https://api.github.com/users/UM-ARM-Lab/orgs","repos_url":"https://api.github.com/users/UM-ARM-Lab/repos","events_url":"https://api.github.com/users/UM-ARM-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-ARM-Lab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UM-ARM-Lab/arc_utilities","description":"C++ and Python utilities used in lab projects","fork":false,"url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities","forks_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/forks","keys_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/teams","hooks_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/hooks","issue_events_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/events{/number}","events_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/events","assignees_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/assignees{/user}","branches_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/branches{/branch}","tags_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/tags","blobs_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/languages","stargazers_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/stargazers","contributors_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/contributors","subscribers_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/subscribers","subscription_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/subscription","commits_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/contents/{+path}","compare_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/merges","archive_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/downloads","issues_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues{/number}","pulls_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/labels{/name}","releases_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/releases{/id}","deployments_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/deployments","created_at":"2015-05-30T04:45:06Z","updated_at":"2018-11-14T20:03:34Z","pushed_at":"2018-12-10T20:58:39Z","git_url":"git://github.com/UM-ARM-Lab/arc_utilities.git","ssh_url":"git@github.com:UM-ARM-Lab/arc_utilities.git","clone_url":"https://github.com/UM-ARM-Lab/arc_utilities.git","svn_url":"https://github.com/UM-ARM-Lab/arc_utilities","homepage":null,"size":621,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":4,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"UM-ARM-Lab:master","ref":"master","sha":"08d57176a45450e0f273a8786087d13d62e1a174","user":{"login":"UM-ARM-Lab","id":22779897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzc5ODk3","avatar_url":"https://avatars2.githubusercontent.com/u/22779897?v=4","gravatar_id":"","url":"https://api.github.com/users/UM-ARM-Lab","html_url":"https://github.com/UM-ARM-Lab","followers_url":"https://api.github.com/users/UM-ARM-Lab/followers","following_url":"https://api.github.com/users/UM-ARM-Lab/following{/other_user}","gists_url":"https://api.github.com/users/UM-ARM-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-ARM-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-ARM-Lab/subscriptions","organizations_url":"https://api.github.com/users/UM-ARM-Lab/orgs","repos_url":"https://api.github.com/users/UM-ARM-Lab/repos","events_url":"https://api.github.com/users/UM-ARM-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-ARM-Lab/received_events","type":"Organization","site_admin":false},"repo":{"id":36543559,"node_id":"MDEwOlJlcG9zaXRvcnkzNjU0MzU1OQ==","name":"arc_utilities","full_name":"UM-ARM-Lab/arc_utilities","private":false,"owner":{"login":"UM-ARM-Lab","id":22779897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzc5ODk3","avatar_url":"https://avatars2.githubusercontent.com/u/22779897?v=4","gravatar_id":"","url":"https://api.github.com/users/UM-ARM-Lab","html_url":"https://github.com/UM-ARM-Lab","followers_url":"https://api.github.com/users/UM-ARM-Lab/followers","following_url":"https://api.github.com/users/UM-ARM-Lab/following{/other_user}","gists_url":"https://api.github.com/users/UM-ARM-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-ARM-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-ARM-Lab/subscriptions","organizations_url":"https://api.github.com/users/UM-ARM-Lab/orgs","repos_url":"https://api.github.com/users/UM-ARM-Lab/repos","events_url":"https://api.github.com/users/UM-ARM-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-ARM-Lab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UM-ARM-Lab/arc_utilities","description":"C++ and Python utilities used in lab projects","fork":false,"url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities","forks_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/forks","keys_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/teams","hooks_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/hooks","issue_events_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/events{/number}","events_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/events","assignees_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/assignees{/user}","branches_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/branches{/branch}","tags_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/tags","blobs_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/languages","stargazers_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/stargazers","contributors_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/contributors","subscribers_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/subscribers","subscription_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/subscription","commits_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/contents/{+path}","compare_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/merges","archive_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/downloads","issues_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues{/number}","pulls_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/labels{/name}","releases_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/releases{/id}","deployments_url":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/deployments","created_at":"2015-05-30T04:45:06Z","updated_at":"2018-11-14T20:03:34Z","pushed_at":"2018-12-10T20:58:39Z","git_url":"git://github.com/UM-ARM-Lab/arc_utilities.git","ssh_url":"git@github.com:UM-ARM-Lab/arc_utilities.git","clone_url":"https://github.com/UM-ARM-Lab/arc_utilities.git","svn_url":"https://github.com/UM-ARM-Lab/arc_utilities","homepage":null,"size":621,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":4,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54"},"html":{"href":"https://github.com/UM-ARM-Lab/arc_utilities/pull/54"},"issue":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/54"},"comments":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/UM-ARM-Lab/arc_utilities/statuses/ed071962db83e6234ded81e37110c68180e45a1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmcconachie"}}