{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22914","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22914/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22914/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22914/events","html_url":"https://github.com/cms-sw/cmssw/pull/22914","id":312859023,"number":22914,"title":"Simplify jet constituent access in MiniAOD","user":{"login":"ahinzmann","id":4518137,"avatar_url":"https://avatars1.githubusercontent.com/u/4518137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahinzmann","html_url":"https://github.com/ahinzmann","followers_url":"https://api.github.com/users/ahinzmann/followers","following_url":"https://api.github.com/users/ahinzmann/following{/other_user}","gists_url":"https://api.github.com/users/ahinzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ahinzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahinzmann/subscriptions","organizations_url":"https://api.github.com/users/ahinzmann/orgs","repos_url":"https://api.github.com/users/ahinzmann/repos","events_url":"https://api.github.com/users/ahinzmann/events{/privacy}","received_events_url":"https://api.github.com/users/ahinzmann/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":164,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-04-18T17:11:13Z","due_on":null,"closed_at":null},"comments":52,"created_at":"2018-04-10T10:14:57Z","updated_at":"2018-04-19T00:06:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22914","html_url":"https://github.com/cms-sw/cmssw/pull/22914","diff_url":"https://github.com/cms-sw/cmssw/pull/22914.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22914.patch"},"body":"The slimmedJetsAK8 in MiniAOD are produced with the JetSubstructurePacker.cc. To save space the jet daughters are used to store both subjets and jet constituents. In order to compute e.g. jet ID or substructure observables, the jet constituents are needed, which can currently be obtained by collecting the constituents of all subjet daughters of the jet plus the non-subjet daughters of the jet.\r\nTo make this much simpler for the user, propose to adapt the pat jet interface to perform this operation automatically.\r\nThe user can the consistently obtain subjets via the member function subjets() and constituent particles via the member function daughter().\r\nThis does not change any content of RECO or MiniAOD, it only changes the interface to jets with subjets.\r\n@arizzi @gpetruc @rappoccio Please have a look.\r\nSuggest to backport this to all analysis releases if agreed."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/382567192","html_url":"https://github.com/cms-sw/cmssw/pull/22914#issuecomment-382567192","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22914","id":382567192,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T00:06:28Z","updated_at":"2018-04-19T00:06:28Z","author_association":"CONTRIBUTOR","body":"TTree::Draw apparently does not consistently support proper initialization of the AtomicPtrCache.\r\nI conclude this from seeing ``` patJets_slimmedJetsAK8__PAT.obj.numberOfDaughters()``` showing up as zero until eventually there is a non-zero value, which is never reset and repeats for neighboring jets.\r\n\r\n@Dr15Jones is there a way to get methods using AtomicPtrCache to actually work in plain fwlite with TTree::Draw?\r\n"}}
{"actor":{"display_login":"slava77"}}