{"action":"closed","number":346,"pull_request":{"url":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/346","id":187670202,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NjcwMjAy","html_url":"https://github.com/jeromeetienne/AR.js/pull/346","diff_url":"https://github.com/jeromeetienne/AR.js/pull/346.diff","patch_url":"https://github.com/jeromeetienne/AR.js/pull/346.patch","issue_url":"https://api.github.com/repos/jeromeetienne/AR.js/issues/346","number":346,"state":"closed","locked":false,"title":"Added deviceId parameter to the scene - it will set what camera to us…","user":{"login":"alfallouji","id":80544,"node_id":"MDQ6VXNlcjgwNTQ0","avatar_url":"https://avatars3.githubusercontent.com/u/80544?v=4","gravatar_id":"","url":"https://api.github.com/users/alfallouji","html_url":"https://github.com/alfallouji","followers_url":"https://api.github.com/users/alfallouji/followers","following_url":"https://api.github.com/users/alfallouji/following{/other_user}","gists_url":"https://api.github.com/users/alfallouji/gists{/gist_id}","starred_url":"https://api.github.com/users/alfallouji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfallouji/subscriptions","organizations_url":"https://api.github.com/users/alfallouji/orgs","repos_url":"https://api.github.com/users/alfallouji/repos","events_url":"https://api.github.com/users/alfallouji/events{/privacy}","received_events_url":"https://api.github.com/users/alfallouji/received_events","type":"User","site_admin":false},"body":"…e based on its deviceId\r\n\r\n<!-- Please don't delete this template or we'll close your issue -->\r\n<!-- All PRs should be done versus 'dev' branch -->\r\n**What kind of change does this PR introduce?**\r\n<!-- Can be a new feature, a bugfix, or refactoring, etc -->\r\nThis is a new feature - allows to define the deviceId to use for the camera.\r\n\r\n** Can it be referenced to an Issue? If so what is the issue # ?**\r\nMight be useful for this issue : #178 \r\n\r\n**How can we test it?**\r\n<!-- All information can be found about our tests in https://github.com/jeromeetienne/AR.js/blob/master/test/TODO.md -->\r\n<!-- At the moment we don't explicitly require tests, because it's not streamlined yet -->\r\n\r\nYou can use this feature by defining the deviceid as a parameter in the scene, like this :\r\n ` <a-scene embedded arjs=\"detectionMode: mono_and_matrix; matrixCodeType: 3x3; sourceType: webcam; trackingMethod: best; debugUIEnabled: false; deviceId: 10d9f755ccab290ef5dbd4a1bb27cca11e61677ab0b4356f302e098ef6144813;\" antialias=\"true\">`\r\n\r\nIn order to get the deviceId, you can use getUserMedia.\r\n\r\n**Summary**\r\n<!-- State here what problem the PR solves and what is the proposed solution -->\r\n**Does this PR introduce a breaking change?**\r\nIt doesn't. The previous behaviour to select what camera to pick up is the default one. The deviceId parameter is optional.\r\n\r\n**Other information**\r\n","created_at":"2018-05-13T13:31:14Z","updated_at":"2018-09-21T18:43:22Z","closed_at":"2018-09-21T18:43:22Z","merged_at":"2018-09-21T18:43:22Z","merge_commit_sha":"fefefb2ffbc277ddfbc4bf88fb58cbc22e97930e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":989277267,"node_id":"MDU6TGFiZWw5ODkyNzcyNjc=","url":"https://api.github.com/repos/jeromeetienne/AR.js/labels/need%20tests","name":"need tests","color":"de67e0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/346/commits","review_comments_url":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/346/comments","review_comment_url":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeromeetienne/AR.js/issues/346/comments","statuses_url":"https://api.github.com/repos/jeromeetienne/AR.js/statuses/57431cb6b7529fa5acb95d9adb89ad82ba7a768a","head":{"label":"alfallouji:multi-webcams","ref":"multi-webcams","sha":"57431cb6b7529fa5acb95d9adb89ad82ba7a768a","user":{"login":"alfallouji","id":80544,"node_id":"MDQ6VXNlcjgwNTQ0","avatar_url":"https://avatars3.githubusercontent.com/u/80544?v=4","gravatar_id":"","url":"https://api.github.com/users/alfallouji","html_url":"https://github.com/alfallouji","followers_url":"https://api.github.com/users/alfallouji/followers","following_url":"https://api.github.com/users/alfallouji/following{/other_user}","gists_url":"https://api.github.com/users/alfallouji/gists{/gist_id}","starred_url":"https://api.github.com/users/alfallouji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfallouji/subscriptions","organizations_url":"https://api.github.com/users/alfallouji/orgs","repos_url":"https://api.github.com/users/alfallouji/repos","events_url":"https://api.github.com/users/alfallouji/events{/privacy}","received_events_url":"https://api.github.com/users/alfallouji/received_events","type":"User","site_admin":false},"repo":{"id":133236063,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyMzYwNjM=","name":"AR.js","full_name":"alfallouji/AR.js","private":false,"owner":{"login":"alfallouji","id":80544,"node_id":"MDQ6VXNlcjgwNTQ0","avatar_url":"https://avatars3.githubusercontent.com/u/80544?v=4","gravatar_id":"","url":"https://api.github.com/users/alfallouji","html_url":"https://github.com/alfallouji","followers_url":"https://api.github.com/users/alfallouji/followers","following_url":"https://api.github.com/users/alfallouji/following{/other_user}","gists_url":"https://api.github.com/users/alfallouji/gists{/gist_id}","starred_url":"https://api.github.com/users/alfallouji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfallouji/subscriptions","organizations_url":"https://api.github.com/users/alfallouji/orgs","repos_url":"https://api.github.com/users/alfallouji/repos","events_url":"https://api.github.com/users/alfallouji/events{/privacy}","received_events_url":"https://api.github.com/users/alfallouji/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alfallouji/AR.js","description":"Efficient Augmented Reality for the Web - 60fps on mobile!","fork":true,"url":"https://api.github.com/repos/alfallouji/AR.js","forks_url":"https://api.github.com/repos/alfallouji/AR.js/forks","keys_url":"https://api.github.com/repos/alfallouji/AR.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfallouji/AR.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfallouji/AR.js/teams","hooks_url":"https://api.github.com/repos/alfallouji/AR.js/hooks","issue_events_url":"https://api.github.com/repos/alfallouji/AR.js/issues/events{/number}","events_url":"https://api.github.com/repos/alfallouji/AR.js/events","assignees_url":"https://api.github.com/repos/alfallouji/AR.js/assignees{/user}","branches_url":"https://api.github.com/repos/alfallouji/AR.js/branches{/branch}","tags_url":"https://api.github.com/repos/alfallouji/AR.js/tags","blobs_url":"https://api.github.com/repos/alfallouji/AR.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfallouji/AR.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfallouji/AR.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfallouji/AR.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfallouji/AR.js/statuses/{sha}","languages_url":"https://api.github.com/repos/alfallouji/AR.js/languages","stargazers_url":"https://api.github.com/repos/alfallouji/AR.js/stargazers","contributors_url":"https://api.github.com/repos/alfallouji/AR.js/contributors","subscribers_url":"https://api.github.com/repos/alfallouji/AR.js/subscribers","subscription_url":"https://api.github.com/repos/alfallouji/AR.js/subscription","commits_url":"https://api.github.com/repos/alfallouji/AR.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfallouji/AR.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfallouji/AR.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfallouji/AR.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfallouji/AR.js/contents/{+path}","compare_url":"https://api.github.com/repos/alfallouji/AR.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfallouji/AR.js/merges","archive_url":"https://api.github.com/repos/alfallouji/AR.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfallouji/AR.js/downloads","issues_url":"https://api.github.com/repos/alfallouji/AR.js/issues{/number}","pulls_url":"https://api.github.com/repos/alfallouji/AR.js/pulls{/number}","milestones_url":"https://api.github.com/repos/alfallouji/AR.js/milestones{/number}","notifications_url":"https://api.github.com/repos/alfallouji/AR.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfallouji/AR.js/labels{/name}","releases_url":"https://api.github.com/repos/alfallouji/AR.js/releases{/id}","deployments_url":"https://api.github.com/repos/alfallouji/AR.js/deployments","created_at":"2018-05-13T12:42:48Z","updated_at":"2018-09-05T02:31:13Z","pushed_at":"2018-05-13T13:23:08Z","git_url":"git://github.com/alfallouji/AR.js.git","ssh_url":"git@github.com:alfallouji/AR.js.git","clone_url":"https://github.com/alfallouji/AR.js.git","svn_url":"https://github.com/alfallouji/AR.js","homepage":"","size":323035,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jeromeetienne:dev","ref":"dev","sha":"0694b4149054a92e0785271bab875612c0a7990d","user":{"login":"jeromeetienne","id":252962,"node_id":"MDQ6VXNlcjI1Mjk2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/252962?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromeetienne","html_url":"https://github.com/jeromeetienne","followers_url":"https://api.github.com/users/jeromeetienne/followers","following_url":"https://api.github.com/users/jeromeetienne/following{/other_user}","gists_url":"https://api.github.com/users/jeromeetienne/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromeetienne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromeetienne/subscriptions","organizations_url":"https://api.github.com/users/jeromeetienne/orgs","repos_url":"https://api.github.com/users/jeromeetienne/repos","events_url":"https://api.github.com/users/jeromeetienne/events{/privacy}","received_events_url":"https://api.github.com/users/jeromeetienne/received_events","type":"User","site_admin":false},"repo":{"id":82285884,"node_id":"MDEwOlJlcG9zaXRvcnk4MjI4NTg4NA==","name":"AR.js","full_name":"jeromeetienne/AR.js","private":false,"owner":{"login":"jeromeetienne","id":252962,"node_id":"MDQ6VXNlcjI1Mjk2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/252962?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromeetienne","html_url":"https://github.com/jeromeetienne","followers_url":"https://api.github.com/users/jeromeetienne/followers","following_url":"https://api.github.com/users/jeromeetienne/following{/other_user}","gists_url":"https://api.github.com/users/jeromeetienne/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromeetienne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromeetienne/subscriptions","organizations_url":"https://api.github.com/users/jeromeetienne/orgs","repos_url":"https://api.github.com/users/jeromeetienne/repos","events_url":"https://api.github.com/users/jeromeetienne/events{/privacy}","received_events_url":"https://api.github.com/users/jeromeetienne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeromeetienne/AR.js","description":"Efficient Augmented Reality for the Web - 60fps on mobile!","fork":false,"url":"https://api.github.com/repos/jeromeetienne/AR.js","forks_url":"https://api.github.com/repos/jeromeetienne/AR.js/forks","keys_url":"https://api.github.com/repos/jeromeetienne/AR.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeromeetienne/AR.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeromeetienne/AR.js/teams","hooks_url":"https://api.github.com/repos/jeromeetienne/AR.js/hooks","issue_events_url":"https://api.github.com/repos/jeromeetienne/AR.js/issues/events{/number}","events_url":"https://api.github.com/repos/jeromeetienne/AR.js/events","assignees_url":"https://api.github.com/repos/jeromeetienne/AR.js/assignees{/user}","branches_url":"https://api.github.com/repos/jeromeetienne/AR.js/branches{/branch}","tags_url":"https://api.github.com/repos/jeromeetienne/AR.js/tags","blobs_url":"https://api.github.com/repos/jeromeetienne/AR.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeromeetienne/AR.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeromeetienne/AR.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeromeetienne/AR.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeromeetienne/AR.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jeromeetienne/AR.js/languages","stargazers_url":"https://api.github.com/repos/jeromeetienne/AR.js/stargazers","contributors_url":"https://api.github.com/repos/jeromeetienne/AR.js/contributors","subscribers_url":"https://api.github.com/repos/jeromeetienne/AR.js/subscribers","subscription_url":"https://api.github.com/repos/jeromeetienne/AR.js/subscription","commits_url":"https://api.github.com/repos/jeromeetienne/AR.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeromeetienne/AR.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeromeetienne/AR.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeromeetienne/AR.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeromeetienne/AR.js/contents/{+path}","compare_url":"https://api.github.com/repos/jeromeetienne/AR.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeromeetienne/AR.js/merges","archive_url":"https://api.github.com/repos/jeromeetienne/AR.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeromeetienne/AR.js/downloads","issues_url":"https://api.github.com/repos/jeromeetienne/AR.js/issues{/number}","pulls_url":"https://api.github.com/repos/jeromeetienne/AR.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jeromeetienne/AR.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jeromeetienne/AR.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeromeetienne/AR.js/labels{/name}","releases_url":"https://api.github.com/repos/jeromeetienne/AR.js/releases{/id}","deployments_url":"https://api.github.com/repos/jeromeetienne/AR.js/deployments","created_at":"2017-02-17T10:27:59Z","updated_at":"2018-09-21T18:06:52Z","pushed_at":"2018-09-21T18:43:22Z","git_url":"git://github.com/jeromeetienne/AR.js.git","ssh_url":"git@github.com:jeromeetienne/AR.js.git","clone_url":"https://github.com/jeromeetienne/AR.js.git","svn_url":"https://github.com/jeromeetienne/AR.js","homepage":"","size":323074,"stargazers_count":11385,"watchers_count":11385,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1274,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1274,"open_issues":134,"watchers":11385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/346"},"html":{"href":"https://github.com/jeromeetienne/AR.js/pull/346"},"issue":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/issues/346"},"comments":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/jeromeetienne/AR.js/statuses/57431cb6b7529fa5acb95d9adb89ad82ba7a768a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nicolocarpignoli","id":22395670,"node_id":"MDQ6VXNlcjIyMzk1Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/22395670?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolocarpignoli","html_url":"https://github.com/nicolocarpignoli","followers_url":"https://api.github.com/users/nicolocarpignoli/followers","following_url":"https://api.github.com/users/nicolocarpignoli/following{/other_user}","gists_url":"https://api.github.com/users/nicolocarpignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolocarpignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolocarpignoli/subscriptions","organizations_url":"https://api.github.com/users/nicolocarpignoli/orgs","repos_url":"https://api.github.com/users/nicolocarpignoli/repos","events_url":"https://api.github.com/users/nicolocarpignoli/events{/privacy}","received_events_url":"https://api.github.com/users/nicolocarpignoli/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":58,"deletions":8,"changed_files":5}}
{"actor":{"display_login":"nicolocarpignoli"}}