{"action":"created","issue":{"url":"https://api.github.com/repos/jbenden/aircrack-ng/issues/1012","repository_url":"https://api.github.com/repos/jbenden/aircrack-ng","labels_url":"https://api.github.com/repos/jbenden/aircrack-ng/issues/1012/labels{/name}","comments_url":"https://api.github.com/repos/jbenden/aircrack-ng/issues/1012/comments","events_url":"https://api.github.com/repos/jbenden/aircrack-ng/issues/1012/events","html_url":"https://github.com/jbenden/aircrack-ng/issues/1012","id":294173089,"number":1012,"title":"Add support for alternative crypto library (Libgcrypt + sha1-git) and unittests","user":{"login":"jbenden","id":73767,"avatar_url":"https://avatars3.githubusercontent.com/u/73767?v=4","gravatar_id":"","url":"https://api.github.com/users/jbenden","html_url":"https://github.com/jbenden","followers_url":"https://api.github.com/users/jbenden/followers","following_url":"https://api.github.com/users/jbenden/following{/other_user}","gists_url":"https://api.github.com/users/jbenden/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenden/subscriptions","organizations_url":"https://api.github.com/users/jbenden/orgs","repos_url":"https://api.github.com/users/jbenden/repos","events_url":"https://api.github.com/users/jbenden/events{/privacy}","received_events_url":"https://api.github.com/users/jbenden/received_events","type":"User","site_admin":false},"labels":[{"id":825869378,"url":"https://api.github.com/repos/jbenden/aircrack-ng/labels/%23general","name":"#general","color":"0000aa","default":false},{"id":825870382,"url":"https://api.github.com/repos/jbenden/aircrack-ng/labels/@medium","name":"@medium","color":"ffaaaa","default":false},{"id":825867140,"url":"https://api.github.com/repos/jbenden/aircrack-ng/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jbenden/aircrack-ng/milestones/9","html_url":"https://github.com/jbenden/aircrack-ng/milestone/9","labels_url":"https://api.github.com/repos/jbenden/aircrack-ng/milestones/9/labels","id":3085881,"number":9,"title":"1.2","description":"  * ~~Improve cracking speed~~\r\n  * ~~Phase out old airmon-ng in favor of airmon-zc~~\r\n  * ~~Support recent version of GPSd (with JSON)~~\r\n  * ~~Improve building code and testing~~\r\n  * ~~Support libnl~~\r\n  * ~~Radiotap fixes (causing wrong channel displayed)~~\r\n  * ~~Airbase-ng fixes and improvements~~\r\n  * Autotools\r\n  * Hashcat output (HCCAPx)","creator":{"login":"jbenden","id":73767,"avatar_url":"https://avatars3.githubusercontent.com/u/73767?v=4","gravatar_id":"","url":"https://api.github.com/users/jbenden","html_url":"https://github.com/jbenden","followers_url":"https://api.github.com/users/jbenden/followers","following_url":"https://api.github.com/users/jbenden/following{/other_user}","gists_url":"https://api.github.com/users/jbenden/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenden/subscriptions","organizations_url":"https://api.github.com/users/jbenden/orgs","repos_url":"https://api.github.com/users/jbenden/repos","events_url":"https://api.github.com/users/jbenden/events{/privacy}","received_events_url":"https://api.github.com/users/jbenden/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":95,"state":"open","created_at":"2018-02-03T15:37:18Z","updated_at":"2018-02-04T05:58:44Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-02-04T05:58:44Z","updated_at":"2018-02-04T06:00:05Z","closed_at":null,"author_association":"OWNER","body":"**Reported by clopez on 16 Jul 2012 11:47 UTC**\n\n----------------------------------\n\nA bit of context:\n\nThe attached patch is the fixed version of the GnuTLS one attached on #953\n\nThe previous patch added support for replacing OpenSSL with GnuTLS and Libgcrypt. Because of some problems found http://bugs.debian.org/680414 this patch was rewrote and now it not longer uses any function from GnuTLS, but instead the GIT SHA1 implementation was borrowed and integrated with aircrack-ng\n\n----------------------------------\n\nAbout the patch itself:\n\nIt adds a wrapper that translates the OpenSSL functions used on aircrack-ng to the Libgcrypt counterparts.\n\nFor the SHA1 functions instead of relying on Libgcrypt it uses an internal SHA1 Implementation that was borrowed from GIT. This is done because the SHA1 Libgcrypt implementation is slow and the GIT SHA1 Implementation is faster than any other.\n\nIf you compare the speed cracking a wpa key with this patch (make gcrypt=true) and without it, you will find that it performs almost at the same speed.\n\nWhen cracking a WPA key, on SSE2 enabled CPUs aircrack-ng will perform like a ~4% faster with OpenSSL, and on the rest of CPUs (including non-x86 archs) aircrack-ng will perform like a ~3% faster with this patch.\n\nThe explanation for this is:\n\n  * The sha1-git implementation (which is only used on non-SSE2 archs) is faster than the OpenSSL one.\n  * OpenSSL is faster than Libgcrypt.\n  * The sha1-git code is only used on the function (crypto.c:calc_pmk). However when running on a SSE2 CPU this code is not loaded, and instead a SSE2 optimized version is prefered (sha1-se2.h:calc_4pmk).\n   * So, on a non-SSE2 CPU the performance gain of using the sha1-git implementation overweights the performance loss that is caused by the slowest HMAC() implementation of Libgcrypt.\n   * Meanwhile on a SSE2 CPU the sha1-git code is not used, therefore the performance loss of Libgcrypt is noticeable.\n\nAll functions of aircrack-ng were OpenSSL code was used (1) were tested to perform exactly the same (same input=>same output) when running with OpenSSL than with this patch (Libgcrypt+SHA1-git)\n\n (1) crypto.c:{encrypt_wep,calc_pmk,calc_mic,calc_ptk}\n     sha1-see2.h:calc_4pmk\n\n\nMigrated-From: https://trac.aircrack-ng.org/ticket/1012"},"comment":{"url":"https://api.github.com/repos/jbenden/aircrack-ng/issues/comments/362883311","html_url":"https://github.com/jbenden/aircrack-ng/issues/1012#issuecomment-362883311","issue_url":"https://api.github.com/repos/jbenden/aircrack-ng/issues/1012","id":362883311,"user":{"login":"jbenden","id":73767,"avatar_url":"https://avatars3.githubusercontent.com/u/73767?v=4","gravatar_id":"","url":"https://api.github.com/users/jbenden","html_url":"https://github.com/jbenden","followers_url":"https://api.github.com/users/jbenden/followers","following_url":"https://api.github.com/users/jbenden/following{/other_user}","gists_url":"https://api.github.com/users/jbenden/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenden/subscriptions","organizations_url":"https://api.github.com/users/jbenden/orgs","repos_url":"https://api.github.com/users/jbenden/repos","events_url":"https://api.github.com/users/jbenden/events{/privacy}","received_events_url":"https://api.github.com/users/jbenden/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T06:00:05Z","updated_at":"2018-02-04T06:00:05Z","author_association":"OWNER","body":"**Comment by clopez on 16 Jul 2012 11:47 UTC**\n\nNo... there isn't any.\n\nIf you think it is a good idea I can make the target \"check\" of Makefile to also call \"sslcheck\" so this tests are also run as part of the usual \"make && make check\""}}
{"actor":{"display_login":"jbenden"}}