{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/comments/215341702","pull_request_review_id":152581780,"id":215341702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM0MTcwMg==","diff_hunk":"@@ -213,11 +211,16 @@ def build_ssl_params\n     return nil unless @ssl\n \n     ssl_builder = nil\n-    verify_mode_string = nil\n+    verify_mode_string = \"none\"\n+\n+    if original_params.key?(\"verify_mode\")\n+      verify_mode_string = @verify_mode.upcase \n+    elsif original_params.key?(\"ssl_verify_mode\")\n+      verify_mode_string = @ssl_verify_mode.upcase\n+    end","path":"lib/logstash/inputs/http.rb","position":23,"original_position":23,"commit_id":"81b0e48ec6738259e62c73f45c52c7aec1855e49","original_commit_id":"81b0e48ec6738259e62c73f45c52c7aec1855e49","user":{"login":"robbavey","id":4061337,"node_id":"MDQ6VXNlcjQwNjEzMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/4061337?v=4","gravatar_id":"","url":"https://api.github.com/users/robbavey","html_url":"https://github.com/robbavey","followers_url":"https://api.github.com/users/robbavey/followers","following_url":"https://api.github.com/users/robbavey/following{/other_user}","gists_url":"https://api.github.com/users/robbavey/gists{/gist_id}","starred_url":"https://api.github.com/users/robbavey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbavey/subscriptions","organizations_url":"https://api.github.com/users/robbavey/orgs","repos_url":"https://api.github.com/users/robbavey/repos","events_url":"https://api.github.com/users/robbavey/events{/privacy}","received_events_url":"https://api.github.com/users/robbavey/received_events","type":"User","site_admin":false},"body":"Does it make sense to put this value into an instance variable to avoid having to check both `ssl_verify_mode` and `verify_mode` in `require_certificate_authorities`?","created_at":"2018-09-05T16:32:53Z","updated_at":"2018-09-05T16:34:01Z","html_url":"https://github.com/logstash-plugins/logstash-input-http/pull/95#discussion_r215341702","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/comments/215341702"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-http/pull/95#discussion_r215341702"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95","id":213270782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjcwNzgy","html_url":"https://github.com/logstash-plugins/logstash-input-http/pull/95","diff_url":"https://github.com/logstash-plugins/logstash-input-http/pull/95.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-http/pull/95.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues/95","number":95,"state":"open","locked":false,"title":"fix some verify_mode edge cases","user":{"login":"jsvd","id":31809,"node_id":"MDQ6VXNlcjMxODA5","avatar_url":"https://avatars3.githubusercontent.com/u/31809?v=4","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"body":"ssl_verify_mode and verify_mode have some bugs:\r\n\r\n- setting ssl_verify_mode to none causes NPE\r\n- setting verify_mode to none defaulted to verify_peer\r\n- setting ssl_certificate_authorites and `ssl_verify_mode` to peer/force_peer would still raise exception\r\n\r\nThe cases are now handled correctly and tested","created_at":"2018-09-05T12:11:05Z","updated_at":"2018-09-05T16:34:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a4393071b3899af96bef50497e8f8aaa581c486","assignee":{"login":"elasticsearch-bot","id":9386276,"node_id":"MDQ6VXNlcjkzODYyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9386276?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticsearch-bot","html_url":"https://github.com/elasticsearch-bot","followers_url":"https://api.github.com/users/elasticsearch-bot/followers","following_url":"https://api.github.com/users/elasticsearch-bot/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch-bot/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch-bot/orgs","repos_url":"https://api.github.com/users/elasticsearch-bot/repos","events_url":"https://api.github.com/users/elasticsearch-bot/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch-bot/received_events","type":"User","site_admin":false},"assignees":[{"login":"elasticsearch-bot","id":9386276,"node_id":"MDQ6VXNlcjkzODYyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9386276?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticsearch-bot","html_url":"https://github.com/elasticsearch-bot","followers_url":"https://api.github.com/users/elasticsearch-bot/followers","following_url":"https://api.github.com/users/elasticsearch-bot/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch-bot/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch-bot/orgs","repos_url":"https://api.github.com/users/elasticsearch-bot/repos","events_url":"https://api.github.com/users/elasticsearch-bot/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch-bot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues/95/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/statuses/81b0e48ec6738259e62c73f45c52c7aec1855e49","head":{"label":"jsvd:fix_verify_mode_edge_cases","ref":"fix_verify_mode_edge_cases","sha":"81b0e48ec6738259e62c73f45c52c7aec1855e49","user":{"login":"jsvd","id":31809,"node_id":"MDQ6VXNlcjMxODA5","avatar_url":"https://avatars3.githubusercontent.com/u/31809?v=4","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"repo":{"id":35686949,"node_id":"MDEwOlJlcG9zaXRvcnkzNTY4Njk0OQ==","name":"logstash-input-http","full_name":"jsvd/logstash-input-http","owner":{"login":"jsvd","id":31809,"node_id":"MDQ6VXNlcjMxODA5","avatar_url":"https://avatars3.githubusercontent.com/u/31809?v=4","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsvd/logstash-input-http","description":null,"fork":true,"url":"https://api.github.com/repos/jsvd/logstash-input-http","forks_url":"https://api.github.com/repos/jsvd/logstash-input-http/forks","keys_url":"https://api.github.com/repos/jsvd/logstash-input-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsvd/logstash-input-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsvd/logstash-input-http/teams","hooks_url":"https://api.github.com/repos/jsvd/logstash-input-http/hooks","issue_events_url":"https://api.github.com/repos/jsvd/logstash-input-http/issues/events{/number}","events_url":"https://api.github.com/repos/jsvd/logstash-input-http/events","assignees_url":"https://api.github.com/repos/jsvd/logstash-input-http/assignees{/user}","branches_url":"https://api.github.com/repos/jsvd/logstash-input-http/branches{/branch}","tags_url":"https://api.github.com/repos/jsvd/logstash-input-http/tags","blobs_url":"https://api.github.com/repos/jsvd/logstash-input-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsvd/logstash-input-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsvd/logstash-input-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsvd/logstash-input-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsvd/logstash-input-http/statuses/{sha}","languages_url":"https://api.github.com/repos/jsvd/logstash-input-http/languages","stargazers_url":"https://api.github.com/repos/jsvd/logstash-input-http/stargazers","contributors_url":"https://api.github.com/repos/jsvd/logstash-input-http/contributors","subscribers_url":"https://api.github.com/repos/jsvd/logstash-input-http/subscribers","subscription_url":"https://api.github.com/repos/jsvd/logstash-input-http/subscription","commits_url":"https://api.github.com/repos/jsvd/logstash-input-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsvd/logstash-input-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsvd/logstash-input-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsvd/logstash-input-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsvd/logstash-input-http/contents/{+path}","compare_url":"https://api.github.com/repos/jsvd/logstash-input-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsvd/logstash-input-http/merges","archive_url":"https://api.github.com/repos/jsvd/logstash-input-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsvd/logstash-input-http/downloads","issues_url":"https://api.github.com/repos/jsvd/logstash-input-http/issues{/number}","pulls_url":"https://api.github.com/repos/jsvd/logstash-input-http/pulls{/number}","milestones_url":"https://api.github.com/repos/jsvd/logstash-input-http/milestones{/number}","notifications_url":"https://api.github.com/repos/jsvd/logstash-input-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsvd/logstash-input-http/labels{/name}","releases_url":"https://api.github.com/repos/jsvd/logstash-input-http/releases{/id}","deployments_url":"https://api.github.com/repos/jsvd/logstash-input-http/deployments","created_at":"2015-05-15T17:22:45Z","updated_at":"2018-01-12T13:03:44Z","pushed_at":"2018-09-05T12:06:57Z","git_url":"git://github.com/jsvd/logstash-input-http.git","ssh_url":"git@github.com:jsvd/logstash-input-http.git","clone_url":"https://github.com/jsvd/logstash-input-http.git","svn_url":"https://github.com/jsvd/logstash-input-http","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"143abf6bbf7bf29b3f41383d96221d63b62fcde3","user":{"login":"logstash-plugins","id":8961934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NjE5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8961934?v=4","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":35051395,"node_id":"MDEwOlJlcG9zaXRvcnkzNTA1MTM5NQ==","name":"logstash-input-http","full_name":"logstash-plugins/logstash-input-http","owner":{"login":"logstash-plugins","id":8961934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NjE5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8961934?v=4","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-http","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-http","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-http/deployments","created_at":"2015-05-04T18:19:00Z","updated_at":"2018-08-31T11:28:18Z","pushed_at":"2018-09-05T12:11:06Z","git_url":"git://github.com/logstash-plugins/logstash-input-http.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-http.git","clone_url":"https://github.com/logstash-plugins/logstash-input-http.git","svn_url":"https://github.com/logstash-plugins/logstash-input-http","homepage":null,"size":173,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":15,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-http/pull/95"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues/95"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-http/statuses/81b0e48ec6738259e62c73f45c52c7aec1855e49"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robbavey"}}