{"action":"created","issue":{"url":"https://api.github.com/repos/AugurProject/augur/issues/1141","repository_url":"https://api.github.com/repos/AugurProject/augur","labels_url":"https://api.github.com/repos/AugurProject/augur/issues/1141/labels{/name}","comments_url":"https://api.github.com/repos/AugurProject/augur/issues/1141/comments","events_url":"https://api.github.com/repos/AugurProject/augur/issues/1141/events","html_url":"https://github.com/AugurProject/augur/pull/1141","id":297783092,"number":1141,"title":"Removing all code related to the Account:Export view.","user":{"login":"sharkcrayon","id":4355755,"avatar_url":"https://avatars0.githubusercontent.com/u/4355755?v=4","gravatar_id":"","url":"https://api.github.com/users/sharkcrayon","html_url":"https://github.com/sharkcrayon","followers_url":"https://api.github.com/users/sharkcrayon/followers","following_url":"https://api.github.com/users/sharkcrayon/following{/other_user}","gists_url":"https://api.github.com/users/sharkcrayon/gists{/gist_id}","starred_url":"https://api.github.com/users/sharkcrayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharkcrayon/subscriptions","organizations_url":"https://api.github.com/users/sharkcrayon/orgs","repos_url":"https://api.github.com/users/sharkcrayon/repos","events_url":"https://api.github.com/users/sharkcrayon/events{/privacy}","received_events_url":"https://api.github.com/users/sharkcrayon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-16T13:21:52Z","updated_at":"2018-02-16T14:08:05Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/AugurProject/augur/pulls/1141","html_url":"https://github.com/AugurProject/augur/pull/1141","diff_url":"https://github.com/AugurProject/augur/pull/1141.diff","patch_url":"https://github.com/AugurProject/augur/pull/1141.patch"},"body":"A couple of important notes:\r\n\r\nI wasn't able to thoroughly test the result of removing this code. \r\n- While I can log into the site locally with MetaMask and there are no errors showing there as a result of removing Export-related code, I'm not sure that that's relevant because the Export view wasn't present in the Account subnav when logging in with Metamask to begin with (previous to these changes).\r\n- The Export view _is_ present when logging in with Airbitz on the *dev* site, which makes me want to test these changes when logged in with Airbitz locally to make sure no errors are thrown. However, I'm not currently able to do that (should I be able to with our current dev environment?).\r\n\r\nAlso, I'm questioning my original assumption (that I doubled check with Jack) that we don't need the Export view because we no longer have Keystore. Is that correct? Should it be possible to export the private key when logged in through Airbitz? If so, this PR/branch should be thrown out."},"comment":{"url":"https://api.github.com/repos/AugurProject/augur/issues/comments/366244475","html_url":"https://github.com/AugurProject/augur/pull/1141#issuecomment-366244475","issue_url":"https://api.github.com/repos/AugurProject/augur/issues/1141","id":366244475,"user":{"login":"stephensprinkle","id":287003,"avatar_url":"https://avatars3.githubusercontent.com/u/287003?v=4","gravatar_id":"","url":"https://api.github.com/users/stephensprinkle","html_url":"https://github.com/stephensprinkle","followers_url":"https://api.github.com/users/stephensprinkle/followers","following_url":"https://api.github.com/users/stephensprinkle/following{/other_user}","gists_url":"https://api.github.com/users/stephensprinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/stephensprinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephensprinkle/subscriptions","organizations_url":"https://api.github.com/users/stephensprinkle/orgs","repos_url":"https://api.github.com/users/stephensprinkle/repos","events_url":"https://api.github.com/users/stephensprinkle/events{/privacy}","received_events_url":"https://api.github.com/users/stephensprinkle/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T14:08:05Z","updated_at":"2018-02-16T14:08:05Z","author_association":"MEMBER","body":"RE: \r\nMM — We don’t get access to the private key, so that’s correct that there is no export displayed.\r\nAirbitz — Currently, the app only runs on the `Rinkeby` network, so you’ll need to connect to the Rinkeby hosted nodes to test that.  Airbitz login _should_ still be working.\r\n\r\nWe’re still going to allow users to login w/ a local hosted node, but IMO we still shouldn’t expose the ability to export in the UI (They already have the ability to export via their ETH client).  "}}
{"actor":{"display_login":"stephensprinkle"}}