{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66066","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66066/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66066/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66066/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66066","id":340198100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjY2MTg5","number":66066,"title":"Cleanup the Admission Webhook E2E code","user":{"login":"jasonrichardsmith","id":1245554,"node_id":"MDQ6VXNlcjEyNDU1NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1245554?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrichardsmith","html_url":"https://github.com/jasonrichardsmith","followers_url":"https://api.github.com/users/jasonrichardsmith/followers","following_url":"https://api.github.com/users/jasonrichardsmith/following{/other_user}","gists_url":"https://api.github.com/users/jasonrichardsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrichardsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrichardsmith/subscriptions","organizations_url":"https://api.github.com/users/jasonrichardsmith/orgs","repos_url":"https://api.github.com/users/jasonrichardsmith/repos","events_url":"https://api.github.com/users/jasonrichardsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrichardsmith/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"caesarxuchao","id":2823529,"node_id":"MDQ6VXNlcjI4MjM1Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"assignees":[{"login":"caesarxuchao","id":2823529,"node_id":"MDQ6VXNlcjI4MjM1Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-07-11T11:16:23Z","updated_at":"2018-07-30T20:58:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66066","html_url":"https://github.com/kubernetes/kubernetes/pull/66066","diff_url":"https://github.com/kubernetes/kubernetes/pull/66066.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66066.patch"},"body":"\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThe current documentation for Admission Webhooks points to the e2e tests as an example.\r\nThe code appears to have some legacy configuration left behind.  The variables are confusingly named and it lacked comments developers could follow.  This is an attempt to clean up some code and make the code more readable to make webhook development easier.\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNone\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/409008055","html_url":"https://github.com/kubernetes/kubernetes/pull/66066#issuecomment-409008055","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66066","id":409008055,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTAwODA1NQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T20:58:20Z","updated_at":"2018-07-30T20:58:20Z","author_association":"COLLABORATOR","body":"@jasonrichardsmith: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce | 1ae092abea10d5c0d3aa2d9cd84b8a489dac6b00 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66066/pull-kubernetes-e2e-gce/46096/) | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/66066). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/jasonrichardsmith). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}