{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/240438154","pull_request_review_id":183469242,"id":240438154,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDQzODE1NA==","diff_hunk":"@@ -70,6 +70,10 @@ public class SetAzureSqlDatabaseBackupLongTermRetentionPolicy : AzureSqlDatabase\n         /// <summary>\n         /// Gets or sets the name of the backup long term retention policy\n         /// </summary>\n+        /// <remarks>\n+        /// The upcoming breaking change will need some logic changes of how the ResourceId is handled. Contact adeal or pixia for assistance.\n+        /// </remarks>\n+        [CmdletParameterBreakingChange(\"ResourceId\", \"ResourceId will no longer refer to RecoveryServicesBackupPolicyResourceId as it is no longer needed. Instead, it will refer to the ResourceId of the long term retention policy being set.\")]","path":"src/ResourceManager/Sql/Commands.Sql/Database Backup/Cmdlet/SetAzureSqlDatabaseBackupLongTermRetentionPolicy.cs","position":16,"original_position":16,"commit_id":"3f3102ca25118de4049e89e811fa56a19883b43d","original_commit_id":"3f3102ca25118de4049e89e811fa56a19883b43d","user":{"login":"dealaus","id":9124650,"node_id":"MDQ6VXNlcjkxMjQ2NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9124650?v=4","gravatar_id":"","url":"https://api.github.com/users/dealaus","html_url":"https://github.com/dealaus","followers_url":"https://api.github.com/users/dealaus/followers","following_url":"https://api.github.com/users/dealaus/following{/other_user}","gists_url":"https://api.github.com/users/dealaus/gists{/gist_id}","starred_url":"https://api.github.com/users/dealaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealaus/subscriptions","organizations_url":"https://api.github.com/users/dealaus/orgs","repos_url":"https://api.github.com/users/dealaus/repos","events_url":"https://api.github.com/users/dealaus/events{/privacy}","received_events_url":"https://api.github.com/users/dealaus/received_events","type":"User","site_admin":false},"body":"As discussed, plan is to remove this parameter for now and we will re-add it to have behavior that references correct resourceId (rather than deprecated RecoveryServicesBackupPolicyResourceId)","created_at":"2018-12-11T00:52:11Z","updated_at":"2018-12-11T00:52:11Z","html_url":"https://github.com/Azure/azure-powershell/pull/7056#discussion_r240438154","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/240438154"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7056#discussion_r240438154"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056","id":211195990,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTk1OTkw","html_url":"https://github.com/Azure/azure-powershell/pull/7056","diff_url":"https://github.com/Azure/azure-powershell/pull/7056.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/7056.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7056","number":7056,"state":"closed","locked":false,"title":"[SQL] More breaking changes for LongTermRetention cmdlets","user":{"login":"dealaus","id":9124650,"node_id":"MDQ6VXNlcjkxMjQ2NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9124650?v=4","gravatar_id":"","url":"https://api.github.com/users/dealaus","html_url":"https://github.com/dealaus","followers_url":"https://api.github.com/users/dealaus/followers","following_url":"https://api.github.com/users/dealaus/following{/other_user}","gists_url":"https://api.github.com/users/dealaus/gists{/gist_id}","starred_url":"https://api.github.com/users/dealaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealaus/subscriptions","organizations_url":"https://api.github.com/users/dealaus/orgs","repos_url":"https://api.github.com/users/dealaus/repos","events_url":"https://api.github.com/users/dealaus/events{/privacy}","received_events_url":"https://api.github.com/users/dealaus/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\nNew breaking changes:\r\n- Set-AzureRmSqlDatabaseBackupLongTermRetentionPolicy -ResourceId\r\n   - This param will no longer refer to RecoveryServicesBackupPolicyResourceId, but instead the resource id of the policy being set.\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [x] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [ ] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [ ] If applicable, the changes made in the PR have proper test coverage\r\n- [ ] For public API changes to cmdlets:\r\n    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr)\r\n    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-08-27T18:48:33Z","updated_at":"2018-12-11T00:52:11Z","closed_at":"2018-08-27T23:35:53Z","merged_at":"2018-08-27T23:35:53Z","merge_commit_sha":"cee1f950db8e199b6861c82edeb44c64d3f43310","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":881473189,"node_id":"MDU6TGFiZWw4ODE0NzMxODk=","url":"https://api.github.com/repos/Azure/azure-powershell/labels/Waiting%20for%20CI%20:shipit:","name":"Waiting for CI :shipit:","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7056/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/3f3102ca25118de4049e89e811fa56a19883b43d","head":{"label":"dealaus:preview","ref":"preview","sha":"3f3102ca25118de4049e89e811fa56a19883b43d","user":{"login":"dealaus","id":9124650,"node_id":"MDQ6VXNlcjkxMjQ2NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9124650?v=4","gravatar_id":"","url":"https://api.github.com/users/dealaus","html_url":"https://github.com/dealaus","followers_url":"https://api.github.com/users/dealaus/followers","following_url":"https://api.github.com/users/dealaus/following{/other_user}","gists_url":"https://api.github.com/users/dealaus/gists{/gist_id}","starred_url":"https://api.github.com/users/dealaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealaus/subscriptions","organizations_url":"https://api.github.com/users/dealaus/orgs","repos_url":"https://api.github.com/users/dealaus/repos","events_url":"https://api.github.com/users/dealaus/events{/privacy}","received_events_url":"https://api.github.com/users/dealaus/received_events","type":"User","site_admin":false},"repo":{"id":134488126,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0ODgxMjY=","name":"azure-powershell","full_name":"dealaus/azure-powershell","private":false,"owner":{"login":"dealaus","id":9124650,"node_id":"MDQ6VXNlcjkxMjQ2NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/9124650?v=4","gravatar_id":"","url":"https://api.github.com/users/dealaus","html_url":"https://github.com/dealaus","followers_url":"https://api.github.com/users/dealaus/followers","following_url":"https://api.github.com/users/dealaus/following{/other_user}","gists_url":"https://api.github.com/users/dealaus/gists{/gist_id}","starred_url":"https://api.github.com/users/dealaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealaus/subscriptions","organizations_url":"https://api.github.com/users/dealaus/orgs","repos_url":"https://api.github.com/users/dealaus/repos","events_url":"https://api.github.com/users/dealaus/events{/privacy}","received_events_url":"https://api.github.com/users/dealaus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dealaus/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/dealaus/azure-powershell","forks_url":"https://api.github.com/repos/dealaus/azure-powershell/forks","keys_url":"https://api.github.com/repos/dealaus/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealaus/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealaus/azure-powershell/teams","hooks_url":"https://api.github.com/repos/dealaus/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/dealaus/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/dealaus/azure-powershell/events","assignees_url":"https://api.github.com/repos/dealaus/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/dealaus/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/dealaus/azure-powershell/tags","blobs_url":"https://api.github.com/repos/dealaus/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealaus/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealaus/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealaus/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealaus/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/dealaus/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/dealaus/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/dealaus/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/dealaus/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/dealaus/azure-powershell/subscription","commits_url":"https://api.github.com/repos/dealaus/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealaus/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealaus/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealaus/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealaus/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/dealaus/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealaus/azure-powershell/merges","archive_url":"https://api.github.com/repos/dealaus/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealaus/azure-powershell/downloads","issues_url":"https://api.github.com/repos/dealaus/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/dealaus/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/dealaus/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/dealaus/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealaus/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/dealaus/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/dealaus/azure-powershell/deployments","created_at":"2018-05-22T23:51:53Z","updated_at":"2018-09-21T17:03:27Z","pushed_at":"2018-09-28T05:23:56Z","git_url":"git://github.com/dealaus/azure-powershell.git","ssh_url":"git@github.com:dealaus/azure-powershell.git","clone_url":"https://github.com/dealaus/azure-powershell.git","svn_url":"https://github.com/dealaus/azure-powershell","homepage":null,"size":614495,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:preview","ref":"preview","sha":"30c4452d6dd37d85fd556fae4c2d61083ab47764","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTE5NA==","name":"azure-powershell","full_name":"Azure/azure-powershell","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-12-10T23:46:25Z","pushed_at":"2018-12-11T00:46:58Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":811092,"stargazers_count":1244,"watchers_count":1244,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1308,"mirror_url":null,"archived":false,"open_issues_count":754,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1308,"open_issues":754,"watchers":1244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7056"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7056"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7056/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7056/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/3f3102ca25118de4049e89e811fa56a19883b43d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dealaus"}}