{"action":"created","issue":{"url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/issues/365","repository_url":"https://api.github.com/repos/QISKit/qiskit-sdk-py","labels_url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/issues/365/labels{/name}","comments_url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/issues/365/comments","events_url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/issues/365/events","html_url":"https://github.com/QISKit/qiskit-sdk-py/pull/365","id":308310297,"number":365,"title":"Fix cmake for Mac","user":{"login":"ajavadia","id":8622381,"avatar_url":"https://avatars2.githubusercontent.com/u/8622381?v=4","gravatar_id":"","url":"https://api.github.com/users/ajavadia","html_url":"https://github.com/ajavadia","followers_url":"https://api.github.com/users/ajavadia/followers","following_url":"https://api.github.com/users/ajavadia/following{/other_user}","gists_url":"https://api.github.com/users/ajavadia/gists{/gist_id}","starred_url":"https://api.github.com/users/ajavadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajavadia/subscriptions","organizations_url":"https://api.github.com/users/ajavadia/orgs","repos_url":"https://api.github.com/users/ajavadia/repos","events_url":"https://api.github.com/users/ajavadia/events{/privacy}","received_events_url":"https://api.github.com/users/ajavadia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-25T00:16:00Z","updated_at":"2018-03-25T18:14:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/pulls/365","html_url":"https://github.com/QISKit/qiskit-sdk-py/pull/365","diff_url":"https://github.com/QISKit/qiskit-sdk-py/pull/365.diff","patch_url":"https://github.com/QISKit/qiskit-sdk-py/pull/365.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nOne line about static linking in the CMake does not work on mac. I have received a couple messages about this, so submitting this patch. I know that this may break cross-platform compatibility, but that is fine since this is used for local build only. The PIP build should use a different CMakeLists.txt\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/issues/comments/375991166","html_url":"https://github.com/QISKit/qiskit-sdk-py/pull/365#issuecomment-375991166","issue_url":"https://api.github.com/repos/QISKit/qiskit-sdk-py/issues/365","id":375991166,"user":{"login":"atilag","id":1304071,"avatar_url":"https://avatars2.githubusercontent.com/u/1304071?v=4","gravatar_id":"","url":"https://api.github.com/users/atilag","html_url":"https://github.com/atilag","followers_url":"https://api.github.com/users/atilag/followers","following_url":"https://api.github.com/users/atilag/following{/other_user}","gists_url":"https://api.github.com/users/atilag/gists{/gist_id}","starred_url":"https://api.github.com/users/atilag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atilag/subscriptions","organizations_url":"https://api.github.com/users/atilag/orgs","repos_url":"https://api.github.com/users/atilag/repos","events_url":"https://api.github.com/users/atilag/events{/privacy}","received_events_url":"https://api.github.com/users/atilag/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T18:14:16Z","updated_at":"2018-03-25T18:14:16Z","author_association":"MEMBER","body":"Yeah, there seems to be a version of gcc that may not work with this static flag (don't know exactly which one), the problem is that we need this flag to build our cross-platform wheel package as you said. So, for users who wants to build the Simulator by themselves, there exist a flag that could be set to disable static linking: \r\n` cmake -DSTATIC_LINKING=False .. `\r\n\r\nLet me know if that works for you!"}}
{"actor":{"display_login":"atilag"}}