{"action":"created","comment":{"url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments/241660913","pull_request_review_id":184989484,"id":241660913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY2MDkxMw==","diff_hunk":"@@ -319,6 +319,7 @@ impl Tendermint {\n                     if let Some(header) = c.block_header(&BlockId::Hash(*hash)) {\n                         *self.proposal.write() = Some(*hash);\n                         *self.proposal_parent.write() = header.parent_hash();\n+                        self.to_step(Step::Prevote);","path":"core/src/consensus/tendermint/mod.rs","position":16,"original_position":4,"commit_id":"9fa70126f761928711587f507e8f4d3be785bfb6","original_commit_id":"9fa70126f761928711587f507e8f4d3be785bfb6","user":{"login":"sgkim126","id":1138402,"node_id":"MDQ6VXNlcjExMzg0MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1138402?v=4","gravatar_id":"","url":"https://api.github.com/users/sgkim126","html_url":"https://github.com/sgkim126","followers_url":"https://api.github.com/users/sgkim126/followers","following_url":"https://api.github.com/users/sgkim126/following{/other_user}","gists_url":"https://api.github.com/users/sgkim126/gists{/gist_id}","starred_url":"https://api.github.com/users/sgkim126/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgkim126/subscriptions","organizations_url":"https://api.github.com/users/sgkim126/orgs","repos_url":"https://api.github.com/users/sgkim126/repos","events_url":"https://api.github.com/users/sgkim126/events{/privacy}","received_events_url":"https://api.github.com/users/sgkim126/received_events","type":"User","site_admin":false},"body":"Why do we call it here?\r\nWe already change the current step in `on_imported_proposal` and `proposal_generated`.","created_at":"2018-12-14T07:15:24Z","updated_at":"2018-12-14T07:15:24Z","html_url":"https://github.com/CodeChain-io/codechain/pull/977#discussion_r241660913","pull_request_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments/241660913"},"html":{"href":"https://github.com/CodeChain-io/codechain/pull/977#discussion_r241660913"},"pull_request":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977"}}},"pull_request":{"url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977","id":238628108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjI4MTA4","html_url":"https://github.com/CodeChain-io/codechain/pull/977","diff_url":"https://github.com/CodeChain-io/codechain/pull/977.diff","patch_url":"https://github.com/CodeChain-io/codechain/pull/977.patch","issue_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/977","number":977,"state":"open","locked":false,"title":"Go to Prevote step when proposal block arrive","user":{"login":"jhs7jhs","id":5892860,"node_id":"MDQ6VXNlcjU4OTI4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5892860?v=4","gravatar_id":"","url":"https://api.github.com/users/jhs7jhs","html_url":"https://github.com/jhs7jhs","followers_url":"https://api.github.com/users/jhs7jhs/followers","following_url":"https://api.github.com/users/jhs7jhs/following{/other_user}","gists_url":"https://api.github.com/users/jhs7jhs/gists{/gist_id}","starred_url":"https://api.github.com/users/jhs7jhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhs7jhs/subscriptions","organizations_url":"https://api.github.com/users/jhs7jhs/orgs","repos_url":"https://api.github.com/users/jhs7jhs/repos","events_url":"https://api.github.com/users/jhs7jhs/events{/privacy}","received_events_url":"https://api.github.com/users/jhs7jhs/received_events","type":"User","site_admin":false},"body":"Should be merged after #975 \r\nI'm not really sure about this logic because there are too many parts related to proposal.","created_at":"2018-12-14T07:02:04Z","updated_at":"2018-12-14T07:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14526719c60d2260b748281281bee0f9f0560330","assignee":null,"assignees":[],"requested_reviewers":[{"login":"majecty","id":709900,"node_id":"MDQ6VXNlcjcwOTkwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/709900?v=4","gravatar_id":"","url":"https://api.github.com/users/majecty","html_url":"https://github.com/majecty","followers_url":"https://api.github.com/users/majecty/followers","following_url":"https://api.github.com/users/majecty/following{/other_user}","gists_url":"https://api.github.com/users/majecty/gists{/gist_id}","starred_url":"https://api.github.com/users/majecty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majecty/subscriptions","organizations_url":"https://api.github.com/users/majecty/orgs","repos_url":"https://api.github.com/users/majecty/repos","events_url":"https://api.github.com/users/majecty/events{/privacy}","received_events_url":"https://api.github.com/users/majecty/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":913433000,"node_id":"MDU6TGFiZWw5MTM0MzMwMDA=","url":"https://api.github.com/repos/CodeChain-io/codechain/labels/consensus","name":"consensus","color":"f29e91","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977/commits","review_comments_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977/comments","review_comment_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/977/comments","statuses_url":"https://api.github.com/repos/CodeChain-io/codechain/statuses/9fa70126f761928711587f507e8f4d3be785bfb6","head":{"label":"jhs7jhs:tendermint-proposal-block-to-prevote","ref":"tendermint-proposal-block-to-prevote","sha":"9fa70126f761928711587f507e8f4d3be785bfb6","user":{"login":"jhs7jhs","id":5892860,"node_id":"MDQ6VXNlcjU4OTI4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5892860?v=4","gravatar_id":"","url":"https://api.github.com/users/jhs7jhs","html_url":"https://github.com/jhs7jhs","followers_url":"https://api.github.com/users/jhs7jhs/followers","following_url":"https://api.github.com/users/jhs7jhs/following{/other_user}","gists_url":"https://api.github.com/users/jhs7jhs/gists{/gist_id}","starred_url":"https://api.github.com/users/jhs7jhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhs7jhs/subscriptions","organizations_url":"https://api.github.com/users/jhs7jhs/orgs","repos_url":"https://api.github.com/users/jhs7jhs/repos","events_url":"https://api.github.com/users/jhs7jhs/events{/privacy}","received_events_url":"https://api.github.com/users/jhs7jhs/received_events","type":"User","site_admin":false},"repo":{"id":145508286,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1MDgyODY=","name":"codechain","full_name":"jhs7jhs/codechain","private":false,"owner":{"login":"jhs7jhs","id":5892860,"node_id":"MDQ6VXNlcjU4OTI4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5892860?v=4","gravatar_id":"","url":"https://api.github.com/users/jhs7jhs","html_url":"https://github.com/jhs7jhs","followers_url":"https://api.github.com/users/jhs7jhs/followers","following_url":"https://api.github.com/users/jhs7jhs/following{/other_user}","gists_url":"https://api.github.com/users/jhs7jhs/gists{/gist_id}","starred_url":"https://api.github.com/users/jhs7jhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhs7jhs/subscriptions","organizations_url":"https://api.github.com/users/jhs7jhs/orgs","repos_url":"https://api.github.com/users/jhs7jhs/repos","events_url":"https://api.github.com/users/jhs7jhs/events{/privacy}","received_events_url":"https://api.github.com/users/jhs7jhs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jhs7jhs/codechain","description":"Programmable multi-asset chain","fork":true,"url":"https://api.github.com/repos/jhs7jhs/codechain","forks_url":"https://api.github.com/repos/jhs7jhs/codechain/forks","keys_url":"https://api.github.com/repos/jhs7jhs/codechain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhs7jhs/codechain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhs7jhs/codechain/teams","hooks_url":"https://api.github.com/repos/jhs7jhs/codechain/hooks","issue_events_url":"https://api.github.com/repos/jhs7jhs/codechain/issues/events{/number}","events_url":"https://api.github.com/repos/jhs7jhs/codechain/events","assignees_url":"https://api.github.com/repos/jhs7jhs/codechain/assignees{/user}","branches_url":"https://api.github.com/repos/jhs7jhs/codechain/branches{/branch}","tags_url":"https://api.github.com/repos/jhs7jhs/codechain/tags","blobs_url":"https://api.github.com/repos/jhs7jhs/codechain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhs7jhs/codechain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhs7jhs/codechain/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhs7jhs/codechain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhs7jhs/codechain/statuses/{sha}","languages_url":"https://api.github.com/repos/jhs7jhs/codechain/languages","stargazers_url":"https://api.github.com/repos/jhs7jhs/codechain/stargazers","contributors_url":"https://api.github.com/repos/jhs7jhs/codechain/contributors","subscribers_url":"https://api.github.com/repos/jhs7jhs/codechain/subscribers","subscription_url":"https://api.github.com/repos/jhs7jhs/codechain/subscription","commits_url":"https://api.github.com/repos/jhs7jhs/codechain/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhs7jhs/codechain/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhs7jhs/codechain/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhs7jhs/codechain/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhs7jhs/codechain/contents/{+path}","compare_url":"https://api.github.com/repos/jhs7jhs/codechain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhs7jhs/codechain/merges","archive_url":"https://api.github.com/repos/jhs7jhs/codechain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhs7jhs/codechain/downloads","issues_url":"https://api.github.com/repos/jhs7jhs/codechain/issues{/number}","pulls_url":"https://api.github.com/repos/jhs7jhs/codechain/pulls{/number}","milestones_url":"https://api.github.com/repos/jhs7jhs/codechain/milestones{/number}","notifications_url":"https://api.github.com/repos/jhs7jhs/codechain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhs7jhs/codechain/labels{/name}","releases_url":"https://api.github.com/repos/jhs7jhs/codechain/releases{/id}","deployments_url":"https://api.github.com/repos/jhs7jhs/codechain/deployments","created_at":"2018-08-21T04:54:29Z","updated_at":"2018-12-12T01:45:52Z","pushed_at":"2018-12-14T07:01:09Z","git_url":"git://github.com/jhs7jhs/codechain.git","ssh_url":"git@github.com:jhs7jhs/codechain.git","clone_url":"https://github.com/jhs7jhs/codechain.git","svn_url":"https://github.com/jhs7jhs/codechain","homepage":"https://codechain.io/","size":7068,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeChain-io:master","ref":"master","sha":"a9957f982b2ddf4f284eaad77546aacd4460d7c2","user":{"login":"CodeChain-io","id":32665109,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/32665109?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeChain-io","html_url":"https://github.com/CodeChain-io","followers_url":"https://api.github.com/users/CodeChain-io/followers","following_url":"https://api.github.com/users/CodeChain-io/following{/other_user}","gists_url":"https://api.github.com/users/CodeChain-io/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeChain-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeChain-io/subscriptions","organizations_url":"https://api.github.com/users/CodeChain-io/orgs","repos_url":"https://api.github.com/users/CodeChain-io/repos","events_url":"https://api.github.com/users/CodeChain-io/events{/privacy}","received_events_url":"https://api.github.com/users/CodeChain-io/received_events","type":"Organization","site_admin":false},"repo":{"id":118557921,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1NTc5MjE=","name":"codechain","full_name":"CodeChain-io/codechain","private":false,"owner":{"login":"CodeChain-io","id":32665109,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/32665109?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeChain-io","html_url":"https://github.com/CodeChain-io","followers_url":"https://api.github.com/users/CodeChain-io/followers","following_url":"https://api.github.com/users/CodeChain-io/following{/other_user}","gists_url":"https://api.github.com/users/CodeChain-io/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeChain-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeChain-io/subscriptions","organizations_url":"https://api.github.com/users/CodeChain-io/orgs","repos_url":"https://api.github.com/users/CodeChain-io/repos","events_url":"https://api.github.com/users/CodeChain-io/events{/privacy}","received_events_url":"https://api.github.com/users/CodeChain-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CodeChain-io/codechain","description":"Programmable multi-asset chain","fork":false,"url":"https://api.github.com/repos/CodeChain-io/codechain","forks_url":"https://api.github.com/repos/CodeChain-io/codechain/forks","keys_url":"https://api.github.com/repos/CodeChain-io/codechain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeChain-io/codechain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeChain-io/codechain/teams","hooks_url":"https://api.github.com/repos/CodeChain-io/codechain/hooks","issue_events_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/events{/number}","events_url":"https://api.github.com/repos/CodeChain-io/codechain/events","assignees_url":"https://api.github.com/repos/CodeChain-io/codechain/assignees{/user}","branches_url":"https://api.github.com/repos/CodeChain-io/codechain/branches{/branch}","tags_url":"https://api.github.com/repos/CodeChain-io/codechain/tags","blobs_url":"https://api.github.com/repos/CodeChain-io/codechain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeChain-io/codechain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeChain-io/codechain/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeChain-io/codechain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeChain-io/codechain/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeChain-io/codechain/languages","stargazers_url":"https://api.github.com/repos/CodeChain-io/codechain/stargazers","contributors_url":"https://api.github.com/repos/CodeChain-io/codechain/contributors","subscribers_url":"https://api.github.com/repos/CodeChain-io/codechain/subscribers","subscription_url":"https://api.github.com/repos/CodeChain-io/codechain/subscription","commits_url":"https://api.github.com/repos/CodeChain-io/codechain/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeChain-io/codechain/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeChain-io/codechain/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeChain-io/codechain/contents/{+path}","compare_url":"https://api.github.com/repos/CodeChain-io/codechain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeChain-io/codechain/merges","archive_url":"https://api.github.com/repos/CodeChain-io/codechain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeChain-io/codechain/downloads","issues_url":"https://api.github.com/repos/CodeChain-io/codechain/issues{/number}","pulls_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeChain-io/codechain/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeChain-io/codechain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeChain-io/codechain/labels{/name}","releases_url":"https://api.github.com/repos/CodeChain-io/codechain/releases{/id}","deployments_url":"https://api.github.com/repos/CodeChain-io/codechain/deployments","created_at":"2018-01-23T04:31:56Z","updated_at":"2018-12-14T00:07:03Z","pushed_at":"2018-12-14T07:02:05Z","git_url":"git://github.com/CodeChain-io/codechain.git","ssh_url":"git@github.com:CodeChain-io/codechain.git","clone_url":"https://github.com/CodeChain-io/codechain.git","svn_url":"https://github.com/CodeChain-io/codechain","homepage":"https://codechain.io/","size":7110,"stargazers_count":180,"watchers_count":180,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":39,"open_issues":81,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977"},"html":{"href":"https://github.com/CodeChain-io/codechain/pull/977"},"issue":{"href":"https://api.github.com/repos/CodeChain-io/codechain/issues/977"},"comments":{"href":"https://api.github.com/repos/CodeChain-io/codechain/issues/977/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/977/commits"},"statuses":{"href":"https://api.github.com/repos/CodeChain-io/codechain/statuses/9fa70126f761928711587f507e8f4d3be785bfb6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sgkim126"}}