{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/9617","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/9617/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/9617/comments","events_url":"https://api.github.com/repos/helm/charts/issues/9617/events","html_url":"https://github.com/helm/charts/pull/9617","id":385530054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDgwODIy","number":9617,"title":"RFC: stable/drone: prepare for drone-1.0.0","user":{"login":"flah00","id":477982,"node_id":"MDQ6VXNlcjQ3Nzk4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/477982?v=4","gravatar_id":"","url":"https://api.github.com/users/flah00","html_url":"https://github.com/flah00","followers_url":"https://api.github.com/users/flah00/followers","following_url":"https://api.github.com/users/flah00/following{/other_user}","gists_url":"https://api.github.com/users/flah00/gists{/gist_id}","starred_url":"https://api.github.com/users/flah00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flah00/subscriptions","organizations_url":"https://api.github.com/users/flah00/orgs","repos_url":"https://api.github.com/users/flah00/repos","events_url":"https://api.github.com/users/flah00/events{/privacy}","received_events_url":"https://api.github.com/users/flah00/received_events","type":"User","site_admin":false},"labels":[{"id":678010043,"node_id":"MDU6TGFiZWw2NzgwMTAwNDM=","url":"https://api.github.com/repos/helm/charts/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-11-29T01:37:29Z","updated_at":"2018-12-10T18:58:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/9617","html_url":"https://github.com/helm/charts/pull/9617","diff_url":"https://github.com/helm/charts/pull/9617.diff","patch_url":"https://github.com/helm/charts/pull/9617.patch"},"body":"<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n@christian-roggia \r\n\r\n#### What this PR does / why we need it:\r\nI've been working on getting drone-1.0.0-rc.1 running on my cluster. I thought I'd share what I've got, make sure it makes sense to folks. Brad has made it clear that options may change before the final 1.0.0 version is released, so this is really an RFC. \r\n\r\n#### Special notes for your reviewer:\r\n\r\nVersion 1.0.0 has quite a few breaking changes. I have removed the unused gpr options, the unusable agent probes. and I've added the optional secrets service. There are three different secrets services, aws, kubernetes, and vault. I have only tested k8s, because I do not have the means to test the others. \r\n\r\nIt seems like the prometheus scraping, on port 8000, might be a casualty of v1? Perhaps that also needs to be removed?\r\n\r\nThere's a lot to pore over. \r\n\r\n#### Checklist\r\n\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/445930539","html_url":"https://github.com/helm/charts/pull/9617#issuecomment-445930539","issue_url":"https://api.github.com/repos/helm/charts/issues/9617","id":445930539,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTkzMDUzOQ==","user":{"login":"bradrydzewski","id":817538,"node_id":"MDQ6VXNlcjgxNzUzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/817538?v=4","gravatar_id":"","url":"https://api.github.com/users/bradrydzewski","html_url":"https://github.com/bradrydzewski","followers_url":"https://api.github.com/users/bradrydzewski/followers","following_url":"https://api.github.com/users/bradrydzewski/following{/other_user}","gists_url":"https://api.github.com/users/bradrydzewski/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrydzewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrydzewski/subscriptions","organizations_url":"https://api.github.com/users/bradrydzewski/orgs","repos_url":"https://api.github.com/users/bradrydzewski/repos","events_url":"https://api.github.com/users/bradrydzewski/events{/privacy}","received_events_url":"https://api.github.com/users/bradrydzewski/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T18:58:04Z","updated_at":"2018-12-10T18:58:04Z","author_association":"NONE","body":"@flah00 drone does emit `/metrics` however it requires authentication. In 1.0 we introduced the concept of machine accounts which can be used to authenticate and scrape metrics."}}
{"actor":{"display_login":"bradrydzewski"}}