{"action":"created","comment":{"url":"https://api.github.com/repos/ngVue/ngVue/pulls/comments/176264215","pull_request_review_id":105936864,"id":176264215,"diff_hunk":"@@ -10,8 +10,13 @@ import extractExpressionName from './extractPropName'\n  * @returns {Object|string|null}\n  */\n export function extractExpressions (exprType, attributes) {\n-  const objectExprKey = exprType === 'props' ? 'vprops' : 'vdata'\n-  const objectPropExprRegExp = exprType === 'props' ? /vprops/i : /vdata/i\n+  const exprKeys = {\n+    props: 'vprops',\n+    data: 'vdata',\n+    on: 'vOn'","path":"src/components/props/getExpressions.js","position":9,"original_position":9,"commit_id":"803752a25317edc86b27120ad378817776c049c4","original_commit_id":"803752a25317edc86b27120ad378817776c049c4","user":{"login":"erickwilder","id":607262,"avatar_url":"https://avatars1.githubusercontent.com/u/607262?v=4","gravatar_id":"","url":"https://api.github.com/users/erickwilder","html_url":"https://github.com/erickwilder","followers_url":"https://api.github.com/users/erickwilder/followers","following_url":"https://api.github.com/users/erickwilder/following{/other_user}","gists_url":"https://api.github.com/users/erickwilder/gists{/gist_id}","starred_url":"https://api.github.com/users/erickwilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickwilder/subscriptions","organizations_url":"https://api.github.com/users/erickwilder/orgs","repos_url":"https://api.github.com/users/erickwilder/repos","events_url":"https://api.github.com/users/erickwilder/events{/privacy}","received_events_url":"https://api.github.com/users/erickwilder/received_events","type":"User","site_admin":false},"body":"I like `vprops` as is since it maps nicely to `props: {}` in the Vue component. Changing it to`v-props` would be enough, isn't it?","created_at":"2018-03-21T22:51:23Z","updated_at":"2018-03-21T22:51:23Z","html_url":"https://github.com/ngVue/ngVue/pull/45#discussion_r176264215","pull_request_url":"https://api.github.com/repos/ngVue/ngVue/pulls/45","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ngVue/ngVue/pulls/comments/176264215"},"html":{"href":"https://github.com/ngVue/ngVue/pull/45#discussion_r176264215"},"pull_request":{"href":"https://api.github.com/repos/ngVue/ngVue/pulls/45"}},"in_reply_to_id":175284018},"pull_request":{"url":"https://api.github.com/repos/ngVue/ngVue/pulls/45","id":173388570,"html_url":"https://github.com/ngVue/ngVue/pull/45","diff_url":"https://github.com/ngVue/ngVue/pull/45.diff","patch_url":"https://github.com/ngVue/ngVue/pull/45.patch","issue_url":"https://api.github.com/repos/ngVue/ngVue/issues/45","number":45,"state":"open","locked":false,"title":"[WIP] feat(app): handle events from Vue to AngularJS components","user":{"login":"nicolaspayot","id":463319,"avatar_url":"https://avatars1.githubusercontent.com/u/463319?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolaspayot","html_url":"https://github.com/nicolaspayot","followers_url":"https://api.github.com/users/nicolaspayot/followers","following_url":"https://api.github.com/users/nicolaspayot/following{/other_user}","gists_url":"https://api.github.com/users/nicolaspayot/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaspayot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaspayot/subscriptions","organizations_url":"https://api.github.com/users/nicolaspayot/orgs","repos_url":"https://api.github.com/users/nicolaspayot/repos","events_url":"https://api.github.com/users/nicolaspayot/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaspayot/received_events","type":"User","site_admin":false},"body":"TODO: \r\n\r\n- [ ] Update README\r\n- [ ] Add unit tests","created_at":"2018-03-07T09:00:31Z","updated_at":"2018-03-21T22:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42680ef1964db1abff7ebac8f5042795251af6d4","assignee":{"login":"dorayx","id":1382646,"avatar_url":"https://avatars1.githubusercontent.com/u/1382646?v=4","gravatar_id":"","url":"https://api.github.com/users/dorayx","html_url":"https://github.com/dorayx","followers_url":"https://api.github.com/users/dorayx/followers","following_url":"https://api.github.com/users/dorayx/following{/other_user}","gists_url":"https://api.github.com/users/dorayx/gists{/gist_id}","starred_url":"https://api.github.com/users/dorayx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorayx/subscriptions","organizations_url":"https://api.github.com/users/dorayx/orgs","repos_url":"https://api.github.com/users/dorayx/repos","events_url":"https://api.github.com/users/dorayx/events{/privacy}","received_events_url":"https://api.github.com/users/dorayx/received_events","type":"User","site_admin":false},"assignees":[{"login":"dorayx","id":1382646,"avatar_url":"https://avatars1.githubusercontent.com/u/1382646?v=4","gravatar_id":"","url":"https://api.github.com/users/dorayx","html_url":"https://github.com/dorayx","followers_url":"https://api.github.com/users/dorayx/followers","following_url":"https://api.github.com/users/dorayx/following{/other_user}","gists_url":"https://api.github.com/users/dorayx/gists{/gist_id}","starred_url":"https://api.github.com/users/dorayx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorayx/subscriptions","organizations_url":"https://api.github.com/users/dorayx/orgs","repos_url":"https://api.github.com/users/dorayx/repos","events_url":"https://api.github.com/users/dorayx/events{/privacy}","received_events_url":"https://api.github.com/users/dorayx/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ngVue/ngVue/pulls/45/commits","review_comments_url":"https://api.github.com/repos/ngVue/ngVue/pulls/45/comments","review_comment_url":"https://api.github.com/repos/ngVue/ngVue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ngVue/ngVue/issues/45/comments","statuses_url":"https://api.github.com/repos/ngVue/ngVue/statuses/803752a25317edc86b27120ad378817776c049c4","head":{"label":"nicolaspayot:feat/handle-events","ref":"feat/handle-events","sha":"803752a25317edc86b27120ad378817776c049c4","user":{"login":"nicolaspayot","id":463319,"avatar_url":"https://avatars1.githubusercontent.com/u/463319?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolaspayot","html_url":"https://github.com/nicolaspayot","followers_url":"https://api.github.com/users/nicolaspayot/followers","following_url":"https://api.github.com/users/nicolaspayot/following{/other_user}","gists_url":"https://api.github.com/users/nicolaspayot/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaspayot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaspayot/subscriptions","organizations_url":"https://api.github.com/users/nicolaspayot/orgs","repos_url":"https://api.github.com/users/nicolaspayot/repos","events_url":"https://api.github.com/users/nicolaspayot/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaspayot/received_events","type":"User","site_admin":false},"repo":{"id":76533196,"name":"ngVue","full_name":"nicolaspayot/ngVue","owner":{"login":"nicolaspayot","id":463319,"avatar_url":"https://avatars1.githubusercontent.com/u/463319?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolaspayot","html_url":"https://github.com/nicolaspayot","followers_url":"https://api.github.com/users/nicolaspayot/followers","following_url":"https://api.github.com/users/nicolaspayot/following{/other_user}","gists_url":"https://api.github.com/users/nicolaspayot/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaspayot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaspayot/subscriptions","organizations_url":"https://api.github.com/users/nicolaspayot/orgs","repos_url":"https://api.github.com/users/nicolaspayot/repos","events_url":"https://api.github.com/users/nicolaspayot/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaspayot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolaspayot/ngVue","description":"Use Vue2 components in Angular 1.x","fork":true,"url":"https://api.github.com/repos/nicolaspayot/ngVue","forks_url":"https://api.github.com/repos/nicolaspayot/ngVue/forks","keys_url":"https://api.github.com/repos/nicolaspayot/ngVue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolaspayot/ngVue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolaspayot/ngVue/teams","hooks_url":"https://api.github.com/repos/nicolaspayot/ngVue/hooks","issue_events_url":"https://api.github.com/repos/nicolaspayot/ngVue/issues/events{/number}","events_url":"https://api.github.com/repos/nicolaspayot/ngVue/events","assignees_url":"https://api.github.com/repos/nicolaspayot/ngVue/assignees{/user}","branches_url":"https://api.github.com/repos/nicolaspayot/ngVue/branches{/branch}","tags_url":"https://api.github.com/repos/nicolaspayot/ngVue/tags","blobs_url":"https://api.github.com/repos/nicolaspayot/ngVue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolaspayot/ngVue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolaspayot/ngVue/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolaspayot/ngVue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolaspayot/ngVue/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolaspayot/ngVue/languages","stargazers_url":"https://api.github.com/repos/nicolaspayot/ngVue/stargazers","contributors_url":"https://api.github.com/repos/nicolaspayot/ngVue/contributors","subscribers_url":"https://api.github.com/repos/nicolaspayot/ngVue/subscribers","subscription_url":"https://api.github.com/repos/nicolaspayot/ngVue/subscription","commits_url":"https://api.github.com/repos/nicolaspayot/ngVue/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolaspayot/ngVue/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolaspayot/ngVue/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolaspayot/ngVue/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolaspayot/ngVue/contents/{+path}","compare_url":"https://api.github.com/repos/nicolaspayot/ngVue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolaspayot/ngVue/merges","archive_url":"https://api.github.com/repos/nicolaspayot/ngVue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolaspayot/ngVue/downloads","issues_url":"https://api.github.com/repos/nicolaspayot/ngVue/issues{/number}","pulls_url":"https://api.github.com/repos/nicolaspayot/ngVue/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolaspayot/ngVue/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolaspayot/ngVue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolaspayot/ngVue/labels{/name}","releases_url":"https://api.github.com/repos/nicolaspayot/ngVue/releases{/id}","deployments_url":"https://api.github.com/repos/nicolaspayot/ngVue/deployments","created_at":"2016-12-15T07:06:31Z","updated_at":"2018-03-18T10:03:28Z","pushed_at":"2018-03-18T10:03:27Z","git_url":"git://github.com/nicolaspayot/ngVue.git","ssh_url":"git@github.com:nicolaspayot/ngVue.git","clone_url":"https://github.com/nicolaspayot/ngVue.git","svn_url":"https://github.com/nicolaspayot/ngVue","homepage":"","size":184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ngVue:master","ref":"master","sha":"a100a862ba77540fc892610c03b8744958ed7b9c","user":{"login":"ngVue","id":21006917,"avatar_url":"https://avatars2.githubusercontent.com/u/21006917?v=4","gravatar_id":"","url":"https://api.github.com/users/ngVue","html_url":"https://github.com/ngVue","followers_url":"https://api.github.com/users/ngVue/followers","following_url":"https://api.github.com/users/ngVue/following{/other_user}","gists_url":"https://api.github.com/users/ngVue/gists{/gist_id}","starred_url":"https://api.github.com/users/ngVue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngVue/subscriptions","organizations_url":"https://api.github.com/users/ngVue/orgs","repos_url":"https://api.github.com/users/ngVue/repos","events_url":"https://api.github.com/users/ngVue/events{/privacy}","received_events_url":"https://api.github.com/users/ngVue/received_events","type":"Organization","site_admin":false},"repo":{"id":65618781,"name":"ngVue","full_name":"ngVue/ngVue","owner":{"login":"ngVue","id":21006917,"avatar_url":"https://avatars2.githubusercontent.com/u/21006917?v=4","gravatar_id":"","url":"https://api.github.com/users/ngVue","html_url":"https://github.com/ngVue","followers_url":"https://api.github.com/users/ngVue/followers","following_url":"https://api.github.com/users/ngVue/following{/other_user}","gists_url":"https://api.github.com/users/ngVue/gists{/gist_id}","starred_url":"https://api.github.com/users/ngVue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngVue/subscriptions","organizations_url":"https://api.github.com/users/ngVue/orgs","repos_url":"https://api.github.com/users/ngVue/repos","events_url":"https://api.github.com/users/ngVue/events{/privacy}","received_events_url":"https://api.github.com/users/ngVue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ngVue/ngVue","description":"Use Vue2 components in Angular 1.x","fork":false,"url":"https://api.github.com/repos/ngVue/ngVue","forks_url":"https://api.github.com/repos/ngVue/ngVue/forks","keys_url":"https://api.github.com/repos/ngVue/ngVue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngVue/ngVue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngVue/ngVue/teams","hooks_url":"https://api.github.com/repos/ngVue/ngVue/hooks","issue_events_url":"https://api.github.com/repos/ngVue/ngVue/issues/events{/number}","events_url":"https://api.github.com/repos/ngVue/ngVue/events","assignees_url":"https://api.github.com/repos/ngVue/ngVue/assignees{/user}","branches_url":"https://api.github.com/repos/ngVue/ngVue/branches{/branch}","tags_url":"https://api.github.com/repos/ngVue/ngVue/tags","blobs_url":"https://api.github.com/repos/ngVue/ngVue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngVue/ngVue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngVue/ngVue/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngVue/ngVue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngVue/ngVue/statuses/{sha}","languages_url":"https://api.github.com/repos/ngVue/ngVue/languages","stargazers_url":"https://api.github.com/repos/ngVue/ngVue/stargazers","contributors_url":"https://api.github.com/repos/ngVue/ngVue/contributors","subscribers_url":"https://api.github.com/repos/ngVue/ngVue/subscribers","subscription_url":"https://api.github.com/repos/ngVue/ngVue/subscription","commits_url":"https://api.github.com/repos/ngVue/ngVue/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngVue/ngVue/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngVue/ngVue/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngVue/ngVue/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngVue/ngVue/contents/{+path}","compare_url":"https://api.github.com/repos/ngVue/ngVue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngVue/ngVue/merges","archive_url":"https://api.github.com/repos/ngVue/ngVue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngVue/ngVue/downloads","issues_url":"https://api.github.com/repos/ngVue/ngVue/issues{/number}","pulls_url":"https://api.github.com/repos/ngVue/ngVue/pulls{/number}","milestones_url":"https://api.github.com/repos/ngVue/ngVue/milestones{/number}","notifications_url":"https://api.github.com/repos/ngVue/ngVue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngVue/ngVue/labels{/name}","releases_url":"https://api.github.com/repos/ngVue/ngVue/releases{/id}","deployments_url":"https://api.github.com/repos/ngVue/ngVue/deployments","created_at":"2016-08-13T13:33:28Z","updated_at":"2018-03-18T10:13:51Z","pushed_at":"2018-03-21T22:26:33Z","git_url":"git://github.com/ngVue/ngVue.git","ssh_url":"git@github.com:ngVue/ngVue.git","clone_url":"https://github.com/ngVue/ngVue.git","svn_url":"https://github.com/ngVue/ngVue","homepage":"","size":183,"stargazers_count":133,"watchers_count":133,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":24,"open_issues":3,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ngVue/ngVue/pulls/45"},"html":{"href":"https://github.com/ngVue/ngVue/pull/45"},"issue":{"href":"https://api.github.com/repos/ngVue/ngVue/issues/45"},"comments":{"href":"https://api.github.com/repos/ngVue/ngVue/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/ngVue/ngVue/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/ngVue/ngVue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ngVue/ngVue/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/ngVue/ngVue/statuses/803752a25317edc86b27120ad378817776c049c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"erickwilder"}}