{"action":"opened","number":786,"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/786","id":236044516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDQ0NTE2","html_url":"https://github.com/openshift/installer/pull/786","diff_url":"https://github.com/openshift/installer/pull/786.diff","patch_url":"https://github.com/openshift/installer/pull/786.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/786","number":786,"state":"open","locked":false,"title":"cmd/openshift-install/create: Fatal Kube API wait timeouts","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"Since it landed in 127219f9 (#579), the Kube-API `wait.Until` loop has lacked \"did we timeout?\" error checking.  That means that a hung bootstrap node could lead to logs like:\n\n```\n...\nDEBUG Still waiting for the Kubernetes API: Get https://wking-api.installer.testing:6443/version?timeout=32s: dial tcp 192.168.126.10:6443: connect: connection refused\nINFO Waiting 30m0s for the bootstrap-complete event...\nWARNING Failed to connect events watcher: Get https://wking-api.installer.testing:6443/api/v1/namespaces/kube-system/events?watch=true: dial tcp 192.168.126.10:6443: connect: connection refused\n...\n```\n\nwhere the Kube API never comes up and we waste 30 minutes of failed event-watcher connection attempts anyway.  With this commit, we'll fail if apiContext expires without an API coming up.  From [the `Context.Err` docs][1]:\n\n> If `Done` is not yet closed, `Err` returns `nil`.  If `Done` is closed, `Err` returns a non-nil error explaining why: `Canceled` if the context was canceled or `DeadlineExceeded` if the context's deadline passed.  After `Err` returns a non-nil error, successive calls to `Err` return the same error.\n\n[1]: https://golang.org/pkg/context/#Context","created_at":"2018-12-05T04:40:54Z","updated_at":"2018-12-05T04:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/786/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/786/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/786/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/910e6461ace6331bec3a30a1d3d9369e650922cc","head":{"label":"wking:error-out-if-create-kube-api-wait-fails","ref":"error-out-if-create-kube-api-wait-fails","sha":"910e6461ace6331bec3a30a1d3d9369e650922cc","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":140026813,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMjY4MTM=","name":"openshift-installer","full_name":"wking/openshift-installer","private":false,"owner":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wking/openshift-installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/wking/openshift-installer","forks_url":"https://api.github.com/repos/wking/openshift-installer/forks","keys_url":"https://api.github.com/repos/wking/openshift-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/openshift-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/openshift-installer/teams","hooks_url":"https://api.github.com/repos/wking/openshift-installer/hooks","issue_events_url":"https://api.github.com/repos/wking/openshift-installer/issues/events{/number}","events_url":"https://api.github.com/repos/wking/openshift-installer/events","assignees_url":"https://api.github.com/repos/wking/openshift-installer/assignees{/user}","branches_url":"https://api.github.com/repos/wking/openshift-installer/branches{/branch}","tags_url":"https://api.github.com/repos/wking/openshift-installer/tags","blobs_url":"https://api.github.com/repos/wking/openshift-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/openshift-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/openshift-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/openshift-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/openshift-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/openshift-installer/languages","stargazers_url":"https://api.github.com/repos/wking/openshift-installer/stargazers","contributors_url":"https://api.github.com/repos/wking/openshift-installer/contributors","subscribers_url":"https://api.github.com/repos/wking/openshift-installer/subscribers","subscription_url":"https://api.github.com/repos/wking/openshift-installer/subscription","commits_url":"https://api.github.com/repos/wking/openshift-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/openshift-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/openshift-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/openshift-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/openshift-installer/contents/{+path}","compare_url":"https://api.github.com/repos/wking/openshift-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/openshift-installer/merges","archive_url":"https://api.github.com/repos/wking/openshift-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/openshift-installer/downloads","issues_url":"https://api.github.com/repos/wking/openshift-installer/issues{/number}","pulls_url":"https://api.github.com/repos/wking/openshift-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/openshift-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/openshift-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/openshift-installer/labels{/name}","releases_url":"https://api.github.com/repos/wking/openshift-installer/releases{/id}","deployments_url":"https://api.github.com/repos/wking/openshift-installer/deployments","created_at":"2018-07-06T20:26:48Z","updated_at":"2018-12-05T00:50:42Z","pushed_at":"2018-12-05T04:39:37Z","git_url":"git://github.com/wking/openshift-installer.git","ssh_url":"git@github.com:wking/openshift-installer.git","clone_url":"https://github.com/wking/openshift-installer.git","svn_url":"https://github.com/wking/openshift-installer","homepage":"","size":45504,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"732b5531185599d6285680a2788e7140c898c087","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-12-05T04:32:58Z","pushed_at":"2018-12-05T04:32:52Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":44114,"stargazers_count":123,"watchers_count":123,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":118,"open_issues":90,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/786"},"html":{"href":"https://github.com/openshift/installer/pull/786"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/786"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/786/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/786/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/786/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/910e6461ace6331bec3a30a1d3d9369e650922cc"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"wking"}}