{"action":"created","issue":{"url":"https://api.github.com/repos/INRIA/spoon/issues/1787","repository_url":"https://api.github.com/repos/INRIA/spoon","labels_url":"https://api.github.com/repos/INRIA/spoon/issues/1787/labels{/name}","comments_url":"https://api.github.com/repos/INRIA/spoon/issues/1787/comments","events_url":"https://api.github.com/repos/INRIA/spoon/issues/1787/events","html_url":"https://github.com/INRIA/spoon/pull/1787","id":282860354,"number":1787,"title":"Review: fix order of type members","user":{"login":"pvojtechovsky","id":23107345,"avatar_url":"https://avatars2.githubusercontent.com/u/23107345?v=4","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-12-18T12:21:05Z","updated_at":"2018-02-18T09:38:27Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/1787","html_url":"https://github.com/INRIA/spoon/pull/1787","diff_url":"https://github.com/INRIA/spoon/pull/1787.diff","patch_url":"https://github.com/INRIA/spoon/pull/1787.patch"},"body":"This test shows that order of type members is not the same like they are in source file.\r\n\r\n@tdurieux, @monperrus , @surli , I actually do not know how to fix it - probably an CtTypeImpl#sortTypeMembers() might be called at some good place in SpoonJDTCompiler code ?\r\n\r\ngoal is to fix #1857"},"comment":{"url":"https://api.github.com/repos/INRIA/spoon/issues/comments/366503621","html_url":"https://github.com/INRIA/spoon/pull/1787#issuecomment-366503621","issue_url":"https://api.github.com/repos/INRIA/spoon/issues/1787","id":366503621,"user":{"login":"pvojtechovsky","id":23107345,"avatar_url":"https://avatars2.githubusercontent.com/u/23107345?v=4","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"created_at":"2018-02-18T09:38:27Z","updated_at":"2018-02-18T09:38:27Z","author_association":"COLLABORATOR","body":"```\r\n   /*\r\n     * @return a negative integer, zero, or a positive integer as the\r\n     *         first argument is less than, equal to, or greater than the\r\n     *         second.\r\n     */\r\nint compare(T o1, T o2);\r\n```\r\n`CtLineElementComparator` should return `0` when both values are same. So both old and new implementation is wrong. Is not?"}}
{"actor":{"display_login":"pvojtechovsky"}}