{"action":"created","issue":{"url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/issues/19","repository_url":"https://api.github.com/repos/chairuosen/vue2-ace-editor","labels_url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/issues/19/comments","events_url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/issues/19/events","html_url":"https://github.com/chairuosen/vue2-ace-editor/pull/19","id":298050517,"number":19,"title":"Fix linting, fixed to work with electron-vue","user":{"login":"lcherone","id":3892806,"avatar_url":"https://avatars3.githubusercontent.com/u/3892806?v=4","gravatar_id":"","url":"https://api.github.com/users/lcherone","html_url":"https://github.com/lcherone","followers_url":"https://api.github.com/users/lcherone/followers","following_url":"https://api.github.com/users/lcherone/following{/other_user}","gists_url":"https://api.github.com/users/lcherone/gists{/gist_id}","starred_url":"https://api.github.com/users/lcherone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcherone/subscriptions","organizations_url":"https://api.github.com/users/lcherone/orgs","repos_url":"https://api.github.com/users/lcherone/repos","events_url":"https://api.github.com/users/lcherone/events{/privacy}","received_events_url":"https://api.github.com/users/lcherone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-18T01:17:12Z","updated_at":"2018-02-19T07:32:53Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/pulls/19","html_url":"https://github.com/chairuosen/vue2-ace-editor/pull/19","diff_url":"https://github.com/chairuosen/vue2-ace-editor/pull/19.diff","patch_url":"https://github.com/chairuosen/vue2-ace-editor/pull/19.patch"},"body":"A few changes if you want to accept the PR which fixes some things which prevented me using with electron-vue.\r\n\r\n - Removed all `;`, switched out double quotes for single and fixed strict linting errors which prevents build.\r\n - Changed init emmet to `window.emmet = require('emmet/emmet')`.\r\n - Change `function () {}` to `() => {}` arrow function, so pass `this` scope on and avoid the vm var.\r\n\r\nNow works with electron-vue, presuming it will work for everything else."},"comment":{"url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/issues/comments/366608666","html_url":"https://github.com/chairuosen/vue2-ace-editor/pull/19#issuecomment-366608666","issue_url":"https://api.github.com/repos/chairuosen/vue2-ace-editor/issues/19","id":366608666,"user":{"login":"chairuosen","id":4627867,"avatar_url":"https://avatars3.githubusercontent.com/u/4627867?v=4","gravatar_id":"","url":"https://api.github.com/users/chairuosen","html_url":"https://github.com/chairuosen","followers_url":"https://api.github.com/users/chairuosen/followers","following_url":"https://api.github.com/users/chairuosen/following{/other_user}","gists_url":"https://api.github.com/users/chairuosen/gists{/gist_id}","starred_url":"https://api.github.com/users/chairuosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chairuosen/subscriptions","organizations_url":"https://api.github.com/users/chairuosen/orgs","repos_url":"https://api.github.com/users/chairuosen/repos","events_url":"https://api.github.com/users/chairuosen/events{/privacy}","received_events_url":"https://api.github.com/users/chairuosen/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T07:32:53Z","updated_at":"2018-02-19T07:32:53Z","author_association":"OWNER","body":"Thanks for helping me solve this issue. like what you said in [this issue](https://github.com/SimulatedGREG/electron-vue/issues/537)   `emmet` causes the error.\r\nI'll remove emmet from the code. to solve this.\r\nBut your PR seems not related to it. \r\nChange1 is about coding style. Coding style should be free to choose. but not only one standard. You can pass eslint by adding `node_modules/**` to .eslintignore.\r\nChange2 seem not working for the error by my test.\r\nChange3 will cause error with the user who uses ES5.\r\n"}}
{"actor":{"display_login":"chairuosen"}}