{"action":"created","comment":{"url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments/215858256","pull_request_review_id":153217073,"id":215858256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTg1ODI1Ng==","diff_hunk":"@@ -220,77 +220,6 @@\n     return web.json_response(result)\n \n \n-# async def add_configuration_item(request):","path":"python/foglamp/services/core/api/configuration.py","position":50,"original_position":50,"commit_id":"562f45e1355f1833d28f336feb0178f3a62726db","original_commit_id":"562f45e1355f1833d28f336feb0178f3a62726db","user":{"login":"ashish-jabble","id":27723735,"node_id":"MDQ6VXNlcjI3NzIzNzM1","avatar_url":"https://avatars0.githubusercontent.com/u/27723735?v=4","gravatar_id":"","url":"https://api.github.com/users/ashish-jabble","html_url":"https://github.com/ashish-jabble","followers_url":"https://api.github.com/users/ashish-jabble/followers","following_url":"https://api.github.com/users/ashish-jabble/following{/other_user}","gists_url":"https://api.github.com/users/ashish-jabble/gists{/gist_id}","starred_url":"https://api.github.com/users/ashish-jabble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashish-jabble/subscriptions","organizations_url":"https://api.github.com/users/ashish-jabble/orgs","repos_url":"https://api.github.com/users/ashish-jabble/repos","events_url":"https://api.github.com/users/ashish-jabble/events{/privacy}","received_events_url":"https://api.github.com/users/ashish-jabble/received_events","type":"User","site_admin":false},"body":" We document it as something we support, so we should probably reinstate it. Just because the GUI does not use it does not mean other client do not use it. See [JIRA](https://scaledb.atlassian.net/browse/FOGL-1790). Either remove it completely (i.e from routes.py as well) and move code snippet to mentioned JIRA","created_at":"2018-09-07T06:32:09Z","updated_at":"2018-09-07T06:32:10Z","html_url":"https://github.com/foglamp/FogLAMP/pull/1082#discussion_r215858256","pull_request_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments/215858256"},"html":{"href":"https://github.com/foglamp/FogLAMP/pull/1082#discussion_r215858256"},"pull_request":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082"}}},"pull_request":{"url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082","id":213645165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjQ1MTY1","html_url":"https://github.com/foglamp/FogLAMP/pull/1082","diff_url":"https://github.com/foglamp/FogLAMP/pull/1082.diff","patch_url":"https://github.com/foglamp/FogLAMP/pull/1082.patch","issue_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/1082","number":1082,"state":"open","locked":false,"title":"allow json value to be dict for update (PUT)","user":{"login":"praveen-garg","id":1974003,"node_id":"MDQ6VXNlcjE5NzQwMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1974003?v=4","gravatar_id":"","url":"https://api.github.com/users/praveen-garg","html_url":"https://github.com/praveen-garg","followers_url":"https://api.github.com/users/praveen-garg/followers","following_url":"https://api.github.com/users/praveen-garg/following{/other_user}","gists_url":"https://api.github.com/users/praveen-garg/gists{/gist_id}","starred_url":"https://api.github.com/users/praveen-garg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveen-garg/subscriptions","organizations_url":"https://api.github.com/users/praveen-garg/orgs","repos_url":"https://api.github.com/users/praveen-garg/repos","events_url":"https://api.github.com/users/praveen-garg/events{/privacy}","received_events_url":"https://api.github.com/users/praveen-garg/received_events","type":"User","site_admin":false},"body":"This will be purely valid, when we solve the JSON handling  for type application/json. As of today when only accept string literal it should be acceptable as interim solution","created_at":"2018-09-06T14:46:18Z","updated_at":"2018-09-07T06:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5aa10d9ccf3fcb9f67e112827a8cd20382027a01","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarkRiddoch","id":6051869,"node_id":"MDQ6VXNlcjYwNTE4Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/6051869?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkRiddoch","html_url":"https://github.com/MarkRiddoch","followers_url":"https://api.github.com/users/MarkRiddoch/followers","following_url":"https://api.github.com/users/MarkRiddoch/following{/other_user}","gists_url":"https://api.github.com/users/MarkRiddoch/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkRiddoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkRiddoch/subscriptions","organizations_url":"https://api.github.com/users/MarkRiddoch/orgs","repos_url":"https://api.github.com/users/MarkRiddoch/repos","events_url":"https://api.github.com/users/MarkRiddoch/events{/privacy}","received_events_url":"https://api.github.com/users/MarkRiddoch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/1082/comments","statuses_url":"https://api.github.com/repos/foglamp/FogLAMP/statuses/562f45e1355f1833d28f336feb0178f3a62726db","head":{"label":"foglamp:config-fixes","ref":"config-fixes","sha":"562f45e1355f1833d28f336feb0178f3a62726db","user":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"repo":{"id":88887957,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg4Nzk1Nw==","name":"FogLAMP","full_name":"foglamp/FogLAMP","owner":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foglamp/FogLAMP","description":"An open source platform for the Internet of Things, it acts as an edge gateway between sensor devices and cloud storage systems","fork":false,"url":"https://api.github.com/repos/foglamp/FogLAMP","forks_url":"https://api.github.com/repos/foglamp/FogLAMP/forks","keys_url":"https://api.github.com/repos/foglamp/FogLAMP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foglamp/FogLAMP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foglamp/FogLAMP/teams","hooks_url":"https://api.github.com/repos/foglamp/FogLAMP/hooks","issue_events_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/events{/number}","events_url":"https://api.github.com/repos/foglamp/FogLAMP/events","assignees_url":"https://api.github.com/repos/foglamp/FogLAMP/assignees{/user}","branches_url":"https://api.github.com/repos/foglamp/FogLAMP/branches{/branch}","tags_url":"https://api.github.com/repos/foglamp/FogLAMP/tags","blobs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foglamp/FogLAMP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/refs{/sha}","trees_url":"https://api.github.com/repos/foglamp/FogLAMP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foglamp/FogLAMP/statuses/{sha}","languages_url":"https://api.github.com/repos/foglamp/FogLAMP/languages","stargazers_url":"https://api.github.com/repos/foglamp/FogLAMP/stargazers","contributors_url":"https://api.github.com/repos/foglamp/FogLAMP/contributors","subscribers_url":"https://api.github.com/repos/foglamp/FogLAMP/subscribers","subscription_url":"https://api.github.com/repos/foglamp/FogLAMP/subscription","commits_url":"https://api.github.com/repos/foglamp/FogLAMP/commits{/sha}","git_commits_url":"https://api.github.com/repos/foglamp/FogLAMP/git/commits{/sha}","comments_url":"https://api.github.com/repos/foglamp/FogLAMP/comments{/number}","issue_comment_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/comments{/number}","contents_url":"https://api.github.com/repos/foglamp/FogLAMP/contents/{+path}","compare_url":"https://api.github.com/repos/foglamp/FogLAMP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foglamp/FogLAMP/merges","archive_url":"https://api.github.com/repos/foglamp/FogLAMP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foglamp/FogLAMP/downloads","issues_url":"https://api.github.com/repos/foglamp/FogLAMP/issues{/number}","pulls_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls{/number}","milestones_url":"https://api.github.com/repos/foglamp/FogLAMP/milestones{/number}","notifications_url":"https://api.github.com/repos/foglamp/FogLAMP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foglamp/FogLAMP/labels{/name}","releases_url":"https://api.github.com/repos/foglamp/FogLAMP/releases{/id}","deployments_url":"https://api.github.com/repos/foglamp/FogLAMP/deployments","created_at":"2017-04-20T16:35:27Z","updated_at":"2018-09-06T13:44:04Z","pushed_at":"2018-09-06T15:23:45Z","git_url":"git://github.com/foglamp/FogLAMP.git","ssh_url":"git@github.com:foglamp/FogLAMP.git","clone_url":"https://github.com/foglamp/FogLAMP.git","svn_url":"https://github.com/foglamp/FogLAMP","homepage":"http://foglamp.readthedocs.io/","size":14496,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":11,"watchers":27,"default_branch":"develop"}},"base":{"label":"foglamp:develop","ref":"develop","sha":"b10af170479c1773c1e6566b28c86ce91cb1c9f3","user":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"repo":{"id":88887957,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg4Nzk1Nw==","name":"FogLAMP","full_name":"foglamp/FogLAMP","owner":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foglamp/FogLAMP","description":"An open source platform for the Internet of Things, it acts as an edge gateway between sensor devices and cloud storage systems","fork":false,"url":"https://api.github.com/repos/foglamp/FogLAMP","forks_url":"https://api.github.com/repos/foglamp/FogLAMP/forks","keys_url":"https://api.github.com/repos/foglamp/FogLAMP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foglamp/FogLAMP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foglamp/FogLAMP/teams","hooks_url":"https://api.github.com/repos/foglamp/FogLAMP/hooks","issue_events_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/events{/number}","events_url":"https://api.github.com/repos/foglamp/FogLAMP/events","assignees_url":"https://api.github.com/repos/foglamp/FogLAMP/assignees{/user}","branches_url":"https://api.github.com/repos/foglamp/FogLAMP/branches{/branch}","tags_url":"https://api.github.com/repos/foglamp/FogLAMP/tags","blobs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foglamp/FogLAMP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/refs{/sha}","trees_url":"https://api.github.com/repos/foglamp/FogLAMP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foglamp/FogLAMP/statuses/{sha}","languages_url":"https://api.github.com/repos/foglamp/FogLAMP/languages","stargazers_url":"https://api.github.com/repos/foglamp/FogLAMP/stargazers","contributors_url":"https://api.github.com/repos/foglamp/FogLAMP/contributors","subscribers_url":"https://api.github.com/repos/foglamp/FogLAMP/subscribers","subscription_url":"https://api.github.com/repos/foglamp/FogLAMP/subscription","commits_url":"https://api.github.com/repos/foglamp/FogLAMP/commits{/sha}","git_commits_url":"https://api.github.com/repos/foglamp/FogLAMP/git/commits{/sha}","comments_url":"https://api.github.com/repos/foglamp/FogLAMP/comments{/number}","issue_comment_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/comments{/number}","contents_url":"https://api.github.com/repos/foglamp/FogLAMP/contents/{+path}","compare_url":"https://api.github.com/repos/foglamp/FogLAMP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foglamp/FogLAMP/merges","archive_url":"https://api.github.com/repos/foglamp/FogLAMP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foglamp/FogLAMP/downloads","issues_url":"https://api.github.com/repos/foglamp/FogLAMP/issues{/number}","pulls_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls{/number}","milestones_url":"https://api.github.com/repos/foglamp/FogLAMP/milestones{/number}","notifications_url":"https://api.github.com/repos/foglamp/FogLAMP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foglamp/FogLAMP/labels{/name}","releases_url":"https://api.github.com/repos/foglamp/FogLAMP/releases{/id}","deployments_url":"https://api.github.com/repos/foglamp/FogLAMP/deployments","created_at":"2017-04-20T16:35:27Z","updated_at":"2018-09-06T13:44:04Z","pushed_at":"2018-09-06T15:23:45Z","git_url":"git://github.com/foglamp/FogLAMP.git","ssh_url":"git@github.com:foglamp/FogLAMP.git","clone_url":"https://github.com/foglamp/FogLAMP.git","svn_url":"https://github.com/foglamp/FogLAMP","homepage":"http://foglamp.readthedocs.io/","size":14496,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":11,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082"},"html":{"href":"https://github.com/foglamp/FogLAMP/pull/1082"},"issue":{"href":"https://api.github.com/repos/foglamp/FogLAMP/issues/1082"},"comments":{"href":"https://api.github.com/repos/foglamp/FogLAMP/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/foglamp/FogLAMP/statuses/562f45e1355f1833d28f336feb0178f3a62726db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ashish-jabble"}}