{"action":"created","comment":{"url":"https://api.github.com/repos/containerd/cri-containerd/pulls/comments/172574355","pull_request_review_id":101597709,"id":172574355,"diff_hunk":"@@ -82,6 +83,13 @@ func initCRIService(ic *plugin.InitContext) (interface{}, error) {\n \t\treturn nil, errors.Wrap(err, \"failed to create CRI service\")\n \t}\n \n+\tmeta, err := ic.Get(plugin.MetadataPlugin)","path":"cri.go","position":22,"original_position":12,"commit_id":"d110164803b086c6b7328d12c9561230f216d1e8","original_commit_id":"d110164803b086c6b7328d12c9561230f216d1e8","user":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars0.githubusercontent.com/u/12767641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"body":"should this new block of code setting the contentStore variable be in the go func()?","created_at":"2018-03-06T16:23:35Z","updated_at":"2018-03-06T16:32:58Z","html_url":"https://github.com/containerd/cri-containerd/pull/644#discussion_r172574355","pull_request_url":"https://api.github.com/repos/containerd/cri-containerd/pulls/644","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containerd/cri-containerd/pulls/comments/172574355"},"html":{"href":"https://github.com/containerd/cri-containerd/pull/644#discussion_r172574355"},"pull_request":{"href":"https://api.github.com/repos/containerd/cri-containerd/pulls/644"}}},"pull_request":{"url":"https://api.github.com/repos/containerd/cri-containerd/pulls/644","id":173092045,"html_url":"https://github.com/containerd/cri-containerd/pull/644","diff_url":"https://github.com/containerd/cri-containerd/pull/644.diff","patch_url":"https://github.com/containerd/cri-containerd/pull/644.patch","issue_url":"https://api.github.com/repos/containerd/cri-containerd/issues/644","number":644,"state":"open","locked":false,"title":"[in-process-integration] Start switching to direct function call","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"@crosbymichael @mikebrow Let's start from this PR. Once we are ok with this PR, we can port services one by one without interfering each other.\r\n\r\nThis PR:\r\n1) Added a `Services` interface in `Client.go`. And added grpcServices implementation and also a directServices implementation. Suggestions for naming are welcome.\r\n2) Added `k8s.io` namespace for all contexts in cri plugin. We can also deal with default namespace in containerd client, but without grpc it requires too many changes. It might be easier to let caller handle namespace if direct services are used.\r\n3) Change CRI plugin to use internal content store.\r\n\r\nPlease note that **the internal content store doesn't publish events**. Should we fix it? Or we are ok with it?\r\n/cc @containerd/containerd-maintainers ","created_at":"2018-03-06T08:49:48Z","updated_at":"2018-03-06T16:32:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c97525c34f6d909476953751ad0038d4e94dd85b","assignee":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars1.githubusercontent.com/u/749551?v=4","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"assignees":[{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars1.githubusercontent.com/u/749551?v=4","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars0.githubusercontent.com/u/12767641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":676044890,"url":"https://api.github.com/repos/containerd/cri-containerd/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/containerd/cri-containerd/milestones/8","html_url":"https://github.com/containerd/cri-containerd/milestone/8","labels_url":"https://api.github.com/repos/containerd/cri-containerd/milestones/8/labels","id":2975273,"number":8,"title":"v1.0.0-rc.0","description":"","creator":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":36,"state":"open","created_at":"2017-12-12T19:44:34Z","updated_at":"2018-03-06T09:12:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/containerd/cri-containerd/pulls/644/commits","review_comments_url":"https://api.github.com/repos/containerd/cri-containerd/pulls/644/comments","review_comment_url":"https://api.github.com/repos/containerd/cri-containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containerd/cri-containerd/issues/644/comments","statuses_url":"https://api.github.com/repos/containerd/cri-containerd/statuses/d110164803b086c6b7328d12c9561230f216d1e8","head":{"label":"Random-Liu:switch-to-direct-function-call","ref":"switch-to-direct-function-call","sha":"d110164803b086c6b7328d12c9561230f216d1e8","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"repo":{"id":88243482,"name":"cri-containerd","full_name":"Random-Liu/cri-containerd","owner":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Random-Liu/cri-containerd","description":"Containerd-based implementation of Kubernetes Container Runtime Interface","fork":true,"url":"https://api.github.com/repos/Random-Liu/cri-containerd","forks_url":"https://api.github.com/repos/Random-Liu/cri-containerd/forks","keys_url":"https://api.github.com/repos/Random-Liu/cri-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Random-Liu/cri-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Random-Liu/cri-containerd/teams","hooks_url":"https://api.github.com/repos/Random-Liu/cri-containerd/hooks","issue_events_url":"https://api.github.com/repos/Random-Liu/cri-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/Random-Liu/cri-containerd/events","assignees_url":"https://api.github.com/repos/Random-Liu/cri-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/Random-Liu/cri-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/Random-Liu/cri-containerd/tags","blobs_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Random-Liu/cri-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Random-Liu/cri-containerd/languages","stargazers_url":"https://api.github.com/repos/Random-Liu/cri-containerd/stargazers","contributors_url":"https://api.github.com/repos/Random-Liu/cri-containerd/contributors","subscribers_url":"https://api.github.com/repos/Random-Liu/cri-containerd/subscribers","subscription_url":"https://api.github.com/repos/Random-Liu/cri-containerd/subscription","commits_url":"https://api.github.com/repos/Random-Liu/cri-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Random-Liu/cri-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Random-Liu/cri-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Random-Liu/cri-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/Random-Liu/cri-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Random-Liu/cri-containerd/merges","archive_url":"https://api.github.com/repos/Random-Liu/cri-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Random-Liu/cri-containerd/downloads","issues_url":"https://api.github.com/repos/Random-Liu/cri-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/Random-Liu/cri-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Random-Liu/cri-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Random-Liu/cri-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Random-Liu/cri-containerd/labels{/name}","releases_url":"https://api.github.com/repos/Random-Liu/cri-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/Random-Liu/cri-containerd/deployments","created_at":"2017-04-14T07:18:02Z","updated_at":"2017-08-21T22:30:18Z","pushed_at":"2018-03-06T09:13:58Z","git_url":"git://github.com/Random-Liu/cri-containerd.git","ssh_url":"git@github.com:Random-Liu/cri-containerd.git","clone_url":"https://github.com/Random-Liu/cri-containerd.git","svn_url":"https://github.com/Random-Liu/cri-containerd","homepage":"","size":7834,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containerd:in-process-integration","ref":"in-process-integration","sha":"d3b112a989b409e2a596e45eb222fa77e23e86ab","user":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"repo":{"id":88211060,"name":"cri-containerd","full_name":"containerd/cri-containerd","owner":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containerd/cri-containerd","description":"Containerd-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/containerd/cri-containerd","forks_url":"https://api.github.com/repos/containerd/cri-containerd/forks","keys_url":"https://api.github.com/repos/containerd/cri-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containerd/cri-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containerd/cri-containerd/teams","hooks_url":"https://api.github.com/repos/containerd/cri-containerd/hooks","issue_events_url":"https://api.github.com/repos/containerd/cri-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/containerd/cri-containerd/events","assignees_url":"https://api.github.com/repos/containerd/cri-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/containerd/cri-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/containerd/cri-containerd/tags","blobs_url":"https://api.github.com/repos/containerd/cri-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containerd/cri-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containerd/cri-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/containerd/cri-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containerd/cri-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/containerd/cri-containerd/languages","stargazers_url":"https://api.github.com/repos/containerd/cri-containerd/stargazers","contributors_url":"https://api.github.com/repos/containerd/cri-containerd/contributors","subscribers_url":"https://api.github.com/repos/containerd/cri-containerd/subscribers","subscription_url":"https://api.github.com/repos/containerd/cri-containerd/subscription","commits_url":"https://api.github.com/repos/containerd/cri-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/containerd/cri-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/containerd/cri-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/containerd/cri-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/containerd/cri-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/containerd/cri-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containerd/cri-containerd/merges","archive_url":"https://api.github.com/repos/containerd/cri-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containerd/cri-containerd/downloads","issues_url":"https://api.github.com/repos/containerd/cri-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/containerd/cri-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/containerd/cri-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/containerd/cri-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containerd/cri-containerd/labels{/name}","releases_url":"https://api.github.com/repos/containerd/cri-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/containerd/cri-containerd/deployments","created_at":"2017-04-13T22:20:24Z","updated_at":"2018-03-05T22:58:22Z","pushed_at":"2018-03-06T09:13:59Z","git_url":"git://github.com/containerd/cri-containerd.git","ssh_url":"git@github.com:containerd/cri-containerd.git","clone_url":"https://github.com/containerd/cri-containerd.git","svn_url":"https://github.com/containerd/cri-containerd","homepage":"","size":7796,"stargazers_count":223,"watchers_count":223,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":67,"open_issues":62,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containerd/cri-containerd/pulls/644"},"html":{"href":"https://github.com/containerd/cri-containerd/pull/644"},"issue":{"href":"https://api.github.com/repos/containerd/cri-containerd/issues/644"},"comments":{"href":"https://api.github.com/repos/containerd/cri-containerd/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/containerd/cri-containerd/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/containerd/cri-containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containerd/cri-containerd/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/containerd/cri-containerd/statuses/d110164803b086c6b7328d12c9561230f216d1e8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mikebrow"}}