{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/227100939","pull_request_review_id":167064386,"id":227100939,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzEwMDkzOQ==","diff_hunk":"@@ -83,13 +83,20 @@ impl<'a, 'b:'a, 'c: 'b> ImportResolver<'a, 'b, 'c> {\n         &mut self,\n         span: Span,\n         mut path: Vec<Ident>\n-    ) -> Option<Vec<Ident>> {\n+    ) -> Option<(Vec<Ident>, Option<String>)> {\n         // Replace first ident with `crate` and check if that is valid.\n         path[0].name = keywords::Crate.name();\n         let result = self.resolve_path(None, &path, None, false, span, CrateLint::No);\n         debug!(\"make_missing_crate_suggestion:  path={:?} result={:?}\", path, result);\n         if let PathResult::Module(..) = result {\n-            Some(path)\n+            Some((\n+                path,\n+                Some(\n+                    \"`use` statements changed in Rust 2018; read more at \\\n+                     <https://rust-lang-nursery.github.io/edition-guide/rust-2018/module-\\\n+                     system/path-clarity.html>\".to_string()","path":"src/librustc_resolve/error_reporting.rs","position":42,"original_position":42,"commit_id":"2a5dc5ee1044ea2b1d61da0b43fcfe78f8c77dd5","original_commit_id":"2e5d0aaa6fa4806417b05f08f45abe3fb0f8233b","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"@steveklabnik tells me that they will post a PR to change the URL to <doc.rust-lang.org/edition-guide>","created_at":"2018-10-22T19:12:30Z","updated_at":"2018-10-22T19:12:30Z","html_url":"https://github.com/rust-lang/rust/pull/55185#discussion_r227100939","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/55185","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/227100939"},"html":{"href":"https://github.com/rust-lang/rust/pull/55185#discussion_r227100939"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55185"}},"in_reply_to_id":226391892},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/55185","id":224033534,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDMzNTM0","html_url":"https://github.com/rust-lang/rust/pull/55185","diff_url":"https://github.com/rust-lang/rust/pull/55185.diff","patch_url":"https://github.com/rust-lang/rust/pull/55185.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/55185","number":55185,"state":"open","locked":false,"title":"path suggestions in Rust 2018 should point out the change in semantics ","user":{"login":"davidtwco","id":1295100,"node_id":"MDQ6VXNlcjEyOTUxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1295100?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtwco","html_url":"https://github.com/davidtwco","followers_url":"https://api.github.com/users/davidtwco/followers","following_url":"https://api.github.com/users/davidtwco/following{/other_user}","gists_url":"https://api.github.com/users/davidtwco/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtwco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtwco/subscriptions","organizations_url":"https://api.github.com/users/davidtwco/orgs","repos_url":"https://api.github.com/users/davidtwco/repos","events_url":"https://api.github.com/users/davidtwco/events{/privacy}","received_events_url":"https://api.github.com/users/davidtwco/received_events","type":"User","site_admin":false},"body":"Fixes #55130.\r\n\r\nThis commit extends existing path suggestions to link to documentation\r\non the changed semantics of `use` in Rust 2018.\r\n\r\nr? @nikomatsakis ","created_at":"2018-10-18T17:14:03Z","updated_at":"2018-10-22T19:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13dbe81fb33b5bc84561ac42442998b75506f629","assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/55185/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/55185/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/55185/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/2a5dc5ee1044ea2b1d61da0b43fcfe78f8c77dd5","head":{"label":"davidtwco:issue-55130","ref":"issue-55130","sha":"2a5dc5ee1044ea2b1d61da0b43fcfe78f8c77dd5","user":{"login":"davidtwco","id":1295100,"node_id":"MDQ6VXNlcjEyOTUxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1295100?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtwco","html_url":"https://github.com/davidtwco","followers_url":"https://api.github.com/users/davidtwco/followers","following_url":"https://api.github.com/users/davidtwco/following{/other_user}","gists_url":"https://api.github.com/users/davidtwco/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtwco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtwco/subscriptions","organizations_url":"https://api.github.com/users/davidtwco/orgs","repos_url":"https://api.github.com/users/davidtwco/repos","events_url":"https://api.github.com/users/davidtwco/events{/privacy}","received_events_url":"https://api.github.com/users/davidtwco/received_events","type":"User","site_admin":false},"repo":{"id":114919676,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5MTk2NzY=","name":"rust","full_name":"davidtwco/rust","private":false,"owner":{"login":"davidtwco","id":1295100,"node_id":"MDQ6VXNlcjEyOTUxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1295100?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtwco","html_url":"https://github.com/davidtwco","followers_url":"https://api.github.com/users/davidtwco/followers","following_url":"https://api.github.com/users/davidtwco/following{/other_user}","gists_url":"https://api.github.com/users/davidtwco/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtwco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtwco/subscriptions","organizations_url":"https://api.github.com/users/davidtwco/orgs","repos_url":"https://api.github.com/users/davidtwco/repos","events_url":"https://api.github.com/users/davidtwco/events{/privacy}","received_events_url":"https://api.github.com/users/davidtwco/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidtwco/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/davidtwco/rust","forks_url":"https://api.github.com/repos/davidtwco/rust/forks","keys_url":"https://api.github.com/repos/davidtwco/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidtwco/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidtwco/rust/teams","hooks_url":"https://api.github.com/repos/davidtwco/rust/hooks","issue_events_url":"https://api.github.com/repos/davidtwco/rust/issues/events{/number}","events_url":"https://api.github.com/repos/davidtwco/rust/events","assignees_url":"https://api.github.com/repos/davidtwco/rust/assignees{/user}","branches_url":"https://api.github.com/repos/davidtwco/rust/branches{/branch}","tags_url":"https://api.github.com/repos/davidtwco/rust/tags","blobs_url":"https://api.github.com/repos/davidtwco/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidtwco/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidtwco/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidtwco/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidtwco/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/davidtwco/rust/languages","stargazers_url":"https://api.github.com/repos/davidtwco/rust/stargazers","contributors_url":"https://api.github.com/repos/davidtwco/rust/contributors","subscribers_url":"https://api.github.com/repos/davidtwco/rust/subscribers","subscription_url":"https://api.github.com/repos/davidtwco/rust/subscription","commits_url":"https://api.github.com/repos/davidtwco/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidtwco/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidtwco/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidtwco/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidtwco/rust/contents/{+path}","compare_url":"https://api.github.com/repos/davidtwco/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidtwco/rust/merges","archive_url":"https://api.github.com/repos/davidtwco/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidtwco/rust/downloads","issues_url":"https://api.github.com/repos/davidtwco/rust/issues{/number}","pulls_url":"https://api.github.com/repos/davidtwco/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/davidtwco/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/davidtwco/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidtwco/rust/labels{/name}","releases_url":"https://api.github.com/repos/davidtwco/rust/releases{/id}","deployments_url":"https://api.github.com/repos/davidtwco/rust/deployments","created_at":"2017-12-20T18:43:37Z","updated_at":"2018-10-19T13:56:02Z","pushed_at":"2018-10-21T14:54:48Z","git_url":"git://github.com/davidtwco/rust.git","ssh_url":"git@github.com:davidtwco/rust.git","clone_url":"https://github.com/davidtwco/rust.git","svn_url":"https://github.com/davidtwco/rust","homepage":"https://www.rust-lang.org","size":397251,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"74ff7dcb1388e60a613cd6050bcd372a3cc4998b","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-10-22T17:43:30Z","pushed_at":"2018-10-22T18:36:18Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":399233,"stargazers_count":31256,"watchers_count":31256,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5238,"mirror_url":null,"archived":false,"open_issues_count":4458,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5238,"open_issues":4458,"watchers":31256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55185"},"html":{"href":"https://github.com/rust-lang/rust/pull/55185"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55185"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55185/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55185/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55185/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/2a5dc5ee1044ea2b1d61da0b43fcfe78f8c77dd5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nikomatsakis"}}