{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/181012289","pull_request_review_id":111535902,"id":181012289,"diff_hunk":"@@ -860,4 +856,16 @@ public void addListener(Object listener) {\n       initState(cache, this);\n       return cache;\n    }\n+\n+   private BiFunctionMapper wrapBiFunction(BiFunction<?, ?, ?> biFunction) {","path":"core/src/main/java/org/infinispan/cache/impl/EncoderCache.java","position":41,"original_position":41,"commit_id":"388406df5606da7708e6a64ddb3da634834f1b64","original_commit_id":"c9549069e3ba3270b4346afd07ca4afc48e14d1c","user":{"login":"pruivo","id":1492066,"avatar_url":"https://avatars2.githubusercontent.com/u/1492066?v=4","gravatar_id":"","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User","site_admin":false},"body":"I would like to keep it consistency with the remaining methods (put, replace, etc). The `keyToStorage()` and `valueToStorage()` pass `null` to the superclass too.","created_at":"2018-04-12T09:04:50Z","updated_at":"2018-04-12T09:04:50Z","html_url":"https://github.com/infinispan/infinispan/pull/5899#discussion_r181012289","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5899","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/181012289"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5899#discussion_r181012289"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5899"}},"in_reply_to_id":180375969},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/5899","id":179921411,"html_url":"https://github.com/infinispan/infinispan/pull/5899","diff_url":"https://github.com/infinispan/infinispan/pull/5899.diff","patch_url":"https://github.com/infinispan/infinispan/pull/5899.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/5899","number":5899,"state":"open","locked":false,"title":"ISPN-9025 Transaction leak when API invoked with invalid arguments","user":{"login":"pruivo","id":1492066,"avatar_url":"https://avatars2.githubusercontent.com/u/1492066?v=4","gravatar_id":"","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-9025","created_at":"2018-04-06T11:23:13Z","updated_at":"2018-04-12T09:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa32e12d788a504e35cfe6fd8d0ddde40467b308","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5899/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5899/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/5899/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/388406df5606da7708e6a64ddb3da634834f1b64","head":{"label":"pruivo:t_9025","ref":"t_9025","sha":"388406df5606da7708e6a64ddb3da634834f1b64","user":{"login":"pruivo","id":1492066,"avatar_url":"https://avatars2.githubusercontent.com/u/1492066?v=4","gravatar_id":"","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User","site_admin":false},"repo":{"id":3626075,"name":"infinispan","full_name":"pruivo/infinispan","owner":{"login":"pruivo","id":1492066,"avatar_url":"https://avatars2.githubusercontent.com/u/1492066?v=4","gravatar_id":"","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pruivo/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/pruivo/infinispan","forks_url":"https://api.github.com/repos/pruivo/infinispan/forks","keys_url":"https://api.github.com/repos/pruivo/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pruivo/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pruivo/infinispan/teams","hooks_url":"https://api.github.com/repos/pruivo/infinispan/hooks","issue_events_url":"https://api.github.com/repos/pruivo/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/pruivo/infinispan/events","assignees_url":"https://api.github.com/repos/pruivo/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/pruivo/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/pruivo/infinispan/tags","blobs_url":"https://api.github.com/repos/pruivo/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pruivo/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pruivo/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/pruivo/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pruivo/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/pruivo/infinispan/languages","stargazers_url":"https://api.github.com/repos/pruivo/infinispan/stargazers","contributors_url":"https://api.github.com/repos/pruivo/infinispan/contributors","subscribers_url":"https://api.github.com/repos/pruivo/infinispan/subscribers","subscription_url":"https://api.github.com/repos/pruivo/infinispan/subscription","commits_url":"https://api.github.com/repos/pruivo/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/pruivo/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/pruivo/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/pruivo/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/pruivo/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/pruivo/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pruivo/infinispan/merges","archive_url":"https://api.github.com/repos/pruivo/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pruivo/infinispan/downloads","issues_url":"https://api.github.com/repos/pruivo/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/pruivo/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/pruivo/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/pruivo/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pruivo/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/pruivo/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/pruivo/infinispan/deployments","created_at":"2012-03-05T10:40:21Z","updated_at":"2018-04-05T13:01:00Z","pushed_at":"2018-04-11T14:38:34Z","git_url":"git://github.com/pruivo/infinispan.git","ssh_url":"git@github.com:pruivo/infinispan.git","clone_url":"https://github.com/pruivo/infinispan.git","svn_url":"https://github.com/pruivo/infinispan","homepage":"http://www.infinispan.org","size":109272,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":6,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"59d291ee79d31b2e35cbe41dae4487a73e23fdd9","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2018-04-12T08:38:20Z","pushed_at":"2018-04-12T08:59:31Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":107148,"stargazers_count":650,"watchers_count":650,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":440,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":440,"open_issues":22,"watchers":650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5899"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5899"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5899"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5899/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5899/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5899/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/388406df5606da7708e6a64ddb3da634834f1b64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pruivo"}}