{"action":"created","comment":{"url":"https://api.github.com/repos/Bareflank/hypervisor/pulls/comments/191005962","pull_request_review_id":123508650,"id":191005962,"diff_hunk":"@@ -51,7 +51,7 @@ namespace feature_information\n             inline auto get() noexcept\n             { return get_bits(_cpuid_eax(addr), mask) >> from; }\n \n-            inline auto get(value_type msr) noexcept","path":"bfintrinsics/include/arch/intel_x64/cpuid.h","position":4,"original_position":4,"commit_id":"3ebbec4643d6fcfdc33ee7a60305e1ff27146aeb","original_commit_id":"3ebbec4643d6fcfdc33ee7a60305e1ff27146aeb","user":{"login":"JaredWright","id":13487832,"avatar_url":"https://avatars0.githubusercontent.com/u/13487832?v=4","gravatar_id":"","url":"https://api.github.com/users/JaredWright","html_url":"https://github.com/JaredWright","followers_url":"https://api.github.com/users/JaredWright/followers","following_url":"https://api.github.com/users/JaredWright/following{/other_user}","gists_url":"https://api.github.com/users/JaredWright/gists{/gist_id}","starred_url":"https://api.github.com/users/JaredWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaredWright/subscriptions","organizations_url":"https://api.github.com/users/JaredWright/orgs","repos_url":"https://api.github.com/users/JaredWright/repos","events_url":"https://api.github.com/users/JaredWright/events{/privacy}","received_events_url":"https://api.github.com/users/JaredWright/received_events","type":"User","site_admin":false},"body":"I did notice this as well, and was also wondering what the reason for this was. Probably just copy/paste errors? I'll leave these as is for now, but will keep in mind for the future.","created_at":"2018-05-25T20:46:31Z","updated_at":"2018-05-25T20:46:32Z","html_url":"https://github.com/Bareflank/hypervisor/pull/676#discussion_r191005962","pull_request_url":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Bareflank/hypervisor/pulls/comments/191005962"},"html":{"href":"https://github.com/Bareflank/hypervisor/pull/676#discussion_r191005962"},"pull_request":{"href":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676"}},"in_reply_to_id":190981378},"pull_request":{"url":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676","id":190405230,"html_url":"https://github.com/Bareflank/hypervisor/pull/676","diff_url":"https://github.com/Bareflank/hypervisor/pull/676.diff","patch_url":"https://github.com/Bareflank/hypervisor/pull/676.patch","issue_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/676","number":676,"state":"open","locked":false,"title":"RFC #675","user":{"login":"JaredWright","id":13487832,"avatar_url":"https://avatars0.githubusercontent.com/u/13487832?v=4","gravatar_id":"","url":"https://api.github.com/users/JaredWright","html_url":"https://github.com/JaredWright","followers_url":"https://api.github.com/users/JaredWright/followers","following_url":"https://api.github.com/users/JaredWright/following{/other_user}","gists_url":"https://api.github.com/users/JaredWright/gists{/gist_id}","starred_url":"https://api.github.com/users/JaredWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaredWright/subscriptions","organizations_url":"https://api.github.com/users/JaredWright/orgs","repos_url":"https://api.github.com/users/JaredWright/repos","events_url":"https://api.github.com/users/JaredWright/events{/privacy}","received_events_url":"https://api.github.com/users/JaredWright/received_events","type":"User","site_admin":false},"body":"@connojd @JWZepf I need some serious auditing on this PR. Since you two are the intrinsics experts, I'd really appreciate if you could look through all of the intrinsics to see if you can catch any that I missed (see the RFC for what you should be looking for)","created_at":"2018-05-24T20:06:44Z","updated_at":"2018-05-25T20:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ecbb022e8d1b261b11e7e0e157a727108e0c1a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rianquinn","id":5932003,"avatar_url":"https://avatars3.githubusercontent.com/u/5932003?v=4","gravatar_id":"","url":"https://api.github.com/users/rianquinn","html_url":"https://github.com/rianquinn","followers_url":"https://api.github.com/users/rianquinn/followers","following_url":"https://api.github.com/users/rianquinn/following{/other_user}","gists_url":"https://api.github.com/users/rianquinn/gists{/gist_id}","starred_url":"https://api.github.com/users/rianquinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rianquinn/subscriptions","organizations_url":"https://api.github.com/users/rianquinn/orgs","repos_url":"https://api.github.com/users/rianquinn/repos","events_url":"https://api.github.com/users/rianquinn/events{/privacy}","received_events_url":"https://api.github.com/users/rianquinn/received_events","type":"User","site_admin":false},{"login":"connojd","id":9279947,"avatar_url":"https://avatars0.githubusercontent.com/u/9279947?v=4","gravatar_id":"","url":"https://api.github.com/users/connojd","html_url":"https://github.com/connojd","followers_url":"https://api.github.com/users/connojd/followers","following_url":"https://api.github.com/users/connojd/following{/other_user}","gists_url":"https://api.github.com/users/connojd/gists{/gist_id}","starred_url":"https://api.github.com/users/connojd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connojd/subscriptions","organizations_url":"https://api.github.com/users/connojd/orgs","repos_url":"https://api.github.com/users/connojd/repos","events_url":"https://api.github.com/users/connojd/events{/privacy}","received_events_url":"https://api.github.com/users/connojd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676/commits","review_comments_url":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676/comments","review_comment_url":"https://api.github.com/repos/Bareflank/hypervisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/676/comments","statuses_url":"https://api.github.com/repos/Bareflank/hypervisor/statuses/3ebbec4643d6fcfdc33ee7a60305e1ff27146aeb","head":{"label":"JaredWright:rfc_675","ref":"rfc_675","sha":"3ebbec4643d6fcfdc33ee7a60305e1ff27146aeb","user":{"login":"JaredWright","id":13487832,"avatar_url":"https://avatars0.githubusercontent.com/u/13487832?v=4","gravatar_id":"","url":"https://api.github.com/users/JaredWright","html_url":"https://github.com/JaredWright","followers_url":"https://api.github.com/users/JaredWright/followers","following_url":"https://api.github.com/users/JaredWright/following{/other_user}","gists_url":"https://api.github.com/users/JaredWright/gists{/gist_id}","starred_url":"https://api.github.com/users/JaredWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaredWright/subscriptions","organizations_url":"https://api.github.com/users/JaredWright/orgs","repos_url":"https://api.github.com/users/JaredWright/repos","events_url":"https://api.github.com/users/JaredWright/events{/privacy}","received_events_url":"https://api.github.com/users/JaredWright/received_events","type":"User","site_admin":false},"repo":{"id":104781857,"name":"hypervisor","full_name":"JaredWright/hypervisor","owner":{"login":"JaredWright","id":13487832,"avatar_url":"https://avatars0.githubusercontent.com/u/13487832?v=4","gravatar_id":"","url":"https://api.github.com/users/JaredWright","html_url":"https://github.com/JaredWright","followers_url":"https://api.github.com/users/JaredWright/followers","following_url":"https://api.github.com/users/JaredWright/following{/other_user}","gists_url":"https://api.github.com/users/JaredWright/gists{/gist_id}","starred_url":"https://api.github.com/users/JaredWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaredWright/subscriptions","organizations_url":"https://api.github.com/users/JaredWright/orgs","repos_url":"https://api.github.com/users/JaredWright/repos","events_url":"https://api.github.com/users/JaredWright/events{/privacy}","received_events_url":"https://api.github.com/users/JaredWright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JaredWright/hypervisor","description":"lightweight, extendable hypervisor written in C++ with support for Windows and Linux","fork":true,"url":"https://api.github.com/repos/JaredWright/hypervisor","forks_url":"https://api.github.com/repos/JaredWright/hypervisor/forks","keys_url":"https://api.github.com/repos/JaredWright/hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JaredWright/hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JaredWright/hypervisor/teams","hooks_url":"https://api.github.com/repos/JaredWright/hypervisor/hooks","issue_events_url":"https://api.github.com/repos/JaredWright/hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/JaredWright/hypervisor/events","assignees_url":"https://api.github.com/repos/JaredWright/hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/JaredWright/hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/JaredWright/hypervisor/tags","blobs_url":"https://api.github.com/repos/JaredWright/hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JaredWright/hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JaredWright/hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/JaredWright/hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JaredWright/hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/JaredWright/hypervisor/languages","stargazers_url":"https://api.github.com/repos/JaredWright/hypervisor/stargazers","contributors_url":"https://api.github.com/repos/JaredWright/hypervisor/contributors","subscribers_url":"https://api.github.com/repos/JaredWright/hypervisor/subscribers","subscription_url":"https://api.github.com/repos/JaredWright/hypervisor/subscription","commits_url":"https://api.github.com/repos/JaredWright/hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/JaredWright/hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/JaredWright/hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/JaredWright/hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/JaredWright/hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/JaredWright/hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JaredWright/hypervisor/merges","archive_url":"https://api.github.com/repos/JaredWright/hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JaredWright/hypervisor/downloads","issues_url":"https://api.github.com/repos/JaredWright/hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/JaredWright/hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/JaredWright/hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/JaredWright/hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JaredWright/hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/JaredWright/hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/JaredWright/hypervisor/deployments","created_at":"2017-09-25T17:39:41Z","updated_at":"2017-09-27T16:33:00Z","pushed_at":"2018-05-25T19:24:18Z","git_url":"git://github.com/JaredWright/hypervisor.git","ssh_url":"git@github.com:JaredWright/hypervisor.git","clone_url":"https://github.com/JaredWright/hypervisor.git","svn_url":"https://github.com/JaredWright/hypervisor","homepage":"","size":41429,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bareflank:master","ref":"master","sha":"a6a902599ea3b234a2561f66ed2bc5570955e4dd","user":{"login":"Bareflank","id":15015782,"avatar_url":"https://avatars1.githubusercontent.com/u/15015782?v=4","gravatar_id":"","url":"https://api.github.com/users/Bareflank","html_url":"https://github.com/Bareflank","followers_url":"https://api.github.com/users/Bareflank/followers","following_url":"https://api.github.com/users/Bareflank/following{/other_user}","gists_url":"https://api.github.com/users/Bareflank/gists{/gist_id}","starred_url":"https://api.github.com/users/Bareflank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bareflank/subscriptions","organizations_url":"https://api.github.com/users/Bareflank/orgs","repos_url":"https://api.github.com/users/Bareflank/repos","events_url":"https://api.github.com/users/Bareflank/events{/privacy}","received_events_url":"https://api.github.com/users/Bareflank/received_events","type":"Organization","site_admin":false},"repo":{"id":43819033,"name":"hypervisor","full_name":"Bareflank/hypervisor","owner":{"login":"Bareflank","id":15015782,"avatar_url":"https://avatars1.githubusercontent.com/u/15015782?v=4","gravatar_id":"","url":"https://api.github.com/users/Bareflank","html_url":"https://github.com/Bareflank","followers_url":"https://api.github.com/users/Bareflank/followers","following_url":"https://api.github.com/users/Bareflank/following{/other_user}","gists_url":"https://api.github.com/users/Bareflank/gists{/gist_id}","starred_url":"https://api.github.com/users/Bareflank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bareflank/subscriptions","organizations_url":"https://api.github.com/users/Bareflank/orgs","repos_url":"https://api.github.com/users/Bareflank/repos","events_url":"https://api.github.com/users/Bareflank/events{/privacy}","received_events_url":"https://api.github.com/users/Bareflank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bareflank/hypervisor","description":"lightweight, extendable hypervisor written in C++ with support for Windows and Linux","fork":false,"url":"https://api.github.com/repos/Bareflank/hypervisor","forks_url":"https://api.github.com/repos/Bareflank/hypervisor/forks","keys_url":"https://api.github.com/repos/Bareflank/hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bareflank/hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bareflank/hypervisor/teams","hooks_url":"https://api.github.com/repos/Bareflank/hypervisor/hooks","issue_events_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/Bareflank/hypervisor/events","assignees_url":"https://api.github.com/repos/Bareflank/hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/Bareflank/hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/Bareflank/hypervisor/tags","blobs_url":"https://api.github.com/repos/Bareflank/hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bareflank/hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bareflank/hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bareflank/hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bareflank/hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/Bareflank/hypervisor/languages","stargazers_url":"https://api.github.com/repos/Bareflank/hypervisor/stargazers","contributors_url":"https://api.github.com/repos/Bareflank/hypervisor/contributors","subscribers_url":"https://api.github.com/repos/Bareflank/hypervisor/subscribers","subscription_url":"https://api.github.com/repos/Bareflank/hypervisor/subscription","commits_url":"https://api.github.com/repos/Bareflank/hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bareflank/hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bareflank/hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bareflank/hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/Bareflank/hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bareflank/hypervisor/merges","archive_url":"https://api.github.com/repos/Bareflank/hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bareflank/hypervisor/downloads","issues_url":"https://api.github.com/repos/Bareflank/hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/Bareflank/hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/Bareflank/hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/Bareflank/hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bareflank/hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/Bareflank/hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/Bareflank/hypervisor/deployments","created_at":"2015-10-07T13:53:10Z","updated_at":"2018-05-25T06:40:35Z","pushed_at":"2018-05-24T23:33:33Z","git_url":"git://github.com/Bareflank/hypervisor.git","ssh_url":"git@github.com:Bareflank/hypervisor.git","clone_url":"https://github.com/Bareflank/hypervisor.git","svn_url":"https://github.com/Bareflank/hypervisor","homepage":"","size":41331,"stargazers_count":469,"watchers_count":469,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":91,"open_issues":8,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676"},"html":{"href":"https://github.com/Bareflank/hypervisor/pull/676"},"issue":{"href":"https://api.github.com/repos/Bareflank/hypervisor/issues/676"},"comments":{"href":"https://api.github.com/repos/Bareflank/hypervisor/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/Bareflank/hypervisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bareflank/hypervisor/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/Bareflank/hypervisor/statuses/3ebbec4643d6fcfdc33ee7a60305e1ff27146aeb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JaredWright"}}