{"action":"created","comment":{"url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments/238771477","pull_request_review_id":181393925,"id":238771477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODc3MTQ3Nw==","diff_hunk":"@@ -24,40 +27,35 @@\n {\n     private static final long serialVersionUID = -1184306312148054279L;\n \n+    private final AtlasItem atlasItem;\n     private final String country;\n     private final PolyLine polyLine;\n     private final Map<String, String> properties;\n \n     /**\n      * Default constructor\n      * \n-     * @param object\n-     *            the {@link AtlasObject} to flag\n+     * @param atlasItem\n+     *            the {@link AtlasItem} to flag\n      */\n-    public FlaggedPolyline(final AtlasObject object)\n+    public FlaggedPolyline(final AtlasItem atlasItem)\n     {\n-        if (object instanceof AtlasItem)\n+        this.atlasItem = atlasItem;\n+        if (atlasItem instanceof Area)\n         {\n-            if (object instanceof Area)\n-            {\n-                // An Area's geometry doesn't include the end (same as start) location. To close the\n-                // area boundary, we need to add the end location manually.\n-                final List<Location> geometry = Iterables\n-                        .asList(((AtlasItem) object).getRawGeometry());\n-                geometry.add(geometry.get(0));\n-                this.polyLine = new PolyLine(geometry);\n-            }\n-            else\n-            {\n-                this.polyLine = new PolyLine(((AtlasItem) object).getRawGeometry());\n-            }\n+            // An Area's geometry doesn't include the end (same as start) location. To close the\n+            // area boundary, we need to add the end location manually.\n+            final List<Location> geometry = Iterables\n+                    .asList(((AtlasItem) atlasItem).getRawGeometry());\n+            geometry.add(geometry.get(0));\n+            this.polyLine = new PolyLine(geometry);","path":"src/main/java/org/openstreetmap/atlas/checks/flag/FlaggedPolyline.java","position":59,"original_position":59,"commit_id":"0ec0fb3ace1d49da200d5c39c83b9399c2157170","original_commit_id":"0ec0fb3ace1d49da200d5c39c83b9399c2157170","user":{"login":"jklamer","id":9659948,"node_id":"MDQ6VXNlcjk2NTk5NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9659948?v=4","gravatar_id":"","url":"https://api.github.com/users/jklamer","html_url":"https://github.com/jklamer","followers_url":"https://api.github.com/users/jklamer/followers","following_url":"https://api.github.com/users/jklamer/following{/other_user}","gists_url":"https://api.github.com/users/jklamer/gists{/gist_id}","starred_url":"https://api.github.com/users/jklamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklamer/subscriptions","organizations_url":"https://api.github.com/users/jklamer/orgs","repos_url":"https://api.github.com/users/jklamer/repos","events_url":"https://api.github.com/users/jklamer/events{/privacy}","received_events_url":"https://api.github.com/users/jklamer/received_events","type":"User","site_admin":false},"body":"```this.polyLine= ((Area) atlasItem).asPolygon().closedLoop()```","created_at":"2018-12-04T17:54:00Z","updated_at":"2018-12-04T17:55:35Z","html_url":"https://github.com/osmlab/atlas-checks/pull/101#discussion_r238771477","pull_request_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments/238771477"},"html":{"href":"https://github.com/osmlab/atlas-checks/pull/101#discussion_r238771477"},"pull_request":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101","id":231694820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjk0ODIw","html_url":"https://github.com/osmlab/atlas-checks/pull/101","diff_url":"https://github.com/osmlab/atlas-checks/pull/101.diff","patch_url":"https://github.com/osmlab/atlas-checks/pull/101.patch","issue_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/101","number":101,"state":"open","locked":false,"title":"Tippecanoe Vector Tile Support","user":{"login":"hallahan","id":556367,"node_id":"MDQ6VXNlcjU1NjM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/556367?v=4","gravatar_id":"","url":"https://api.github.com/users/hallahan","html_url":"https://github.com/hallahan","followers_url":"https://api.github.com/users/hallahan/followers","following_url":"https://api.github.com/users/hallahan/following{/other_user}","gists_url":"https://api.github.com/users/hallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/hallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallahan/subscriptions","organizations_url":"https://api.github.com/users/hallahan/orgs","repos_url":"https://api.github.com/users/hallahan/repos","events_url":"https://api.github.com/users/hallahan/events{/privacy}","received_events_url":"https://api.github.com/users/hallahan/received_events","type":"User","site_admin":false},"body":"### Description:\r\n\r\nThis PR provides the ability to output atlas-checks into line-delimited GeoJSON that can be processed by Mapbox's tippecanoe vector tile converter. We have also provided a wrapper CLI that will take that line delimited GeoJSON output and drive tippecanoe to do the conversion for you.\r\n\r\nBefore we merge this PR, we need to do an atlas release with the following PR merged:\r\n\r\nhttps://github.com/osmlab/atlas/pull/275\r\n\r\nThen we need to do a release and update the `dependencies.gradle` for atlas-checks accordingly.\r\n\r\nSee instructions for more details:\r\n\r\nhttps://github.com/hallahan/atlas-checks/blob/tippecanoe/src/main/java/org/openstreetmap/atlas/checks/vectortiles/README.md\r\n\r\n### Potential Impact:\r\n\r\nThis PR will not impact any other parts of atlas-checks. It just adds the ability to easily make vector tiles with atlas check data.\r\n\r\n### Unit Test Approach:\r\n\r\nhttps://github.com/osmlab/atlas-checks/blob/79741af237d3d7556ebcd3295cd839a73cdff06a/src/test/java/org/openstreetmap/atlas/checks/event/CheckFlagTippecanoeProcessorTest.java\r\n\r\nhttps://github.com/osmlab/atlas-checks/blob/79741af237d3d7556ebcd3295cd839a73cdff06a/src/test/java/org/openstreetmap/atlas/checks/flag/CheckFlagTest.java#L102\r\n\r\n### Test Results:\r\n\r\nI've run `IntegrityCheckSparkJob` with the tippecanoe styled line-delimited GeoJSON. Then, I have converted that output into vector tiles with `TippecanoeCheckConverter`.\r\n\r\nAlso, unit tests are passing.\r\n\r\n\r\n","created_at":"2018-11-17T01:03:13Z","updated_at":"2018-12-04T17:55:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2069f32db16db17436cd2e09d9d49e167089bf8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101/commits","review_comments_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101/comments","review_comment_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/101/comments","statuses_url":"https://api.github.com/repos/osmlab/atlas-checks/statuses/0ec0fb3ace1d49da200d5c39c83b9399c2157170","head":{"label":"hallahan:tippecanoe","ref":"tippecanoe","sha":"0ec0fb3ace1d49da200d5c39c83b9399c2157170","user":{"login":"hallahan","id":556367,"node_id":"MDQ6VXNlcjU1NjM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/556367?v=4","gravatar_id":"","url":"https://api.github.com/users/hallahan","html_url":"https://github.com/hallahan","followers_url":"https://api.github.com/users/hallahan/followers","following_url":"https://api.github.com/users/hallahan/following{/other_user}","gists_url":"https://api.github.com/users/hallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/hallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallahan/subscriptions","organizations_url":"https://api.github.com/users/hallahan/orgs","repos_url":"https://api.github.com/users/hallahan/repos","events_url":"https://api.github.com/users/hallahan/events{/privacy}","received_events_url":"https://api.github.com/users/hallahan/received_events","type":"User","site_admin":false},"repo":{"id":132921269,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MjEyNjk=","name":"atlas-checks","full_name":"hallahan/atlas-checks","private":false,"owner":{"login":"hallahan","id":556367,"node_id":"MDQ6VXNlcjU1NjM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/556367?v=4","gravatar_id":"","url":"https://api.github.com/users/hallahan","html_url":"https://github.com/hallahan","followers_url":"https://api.github.com/users/hallahan/followers","following_url":"https://api.github.com/users/hallahan/following{/other_user}","gists_url":"https://api.github.com/users/hallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/hallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallahan/subscriptions","organizations_url":"https://api.github.com/users/hallahan/orgs","repos_url":"https://api.github.com/users/hallahan/repos","events_url":"https://api.github.com/users/hallahan/events{/privacy}","received_events_url":"https://api.github.com/users/hallahan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hallahan/atlas-checks","description":"OSM data integrity checks with Atlas","fork":true,"url":"https://api.github.com/repos/hallahan/atlas-checks","forks_url":"https://api.github.com/repos/hallahan/atlas-checks/forks","keys_url":"https://api.github.com/repos/hallahan/atlas-checks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hallahan/atlas-checks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hallahan/atlas-checks/teams","hooks_url":"https://api.github.com/repos/hallahan/atlas-checks/hooks","issue_events_url":"https://api.github.com/repos/hallahan/atlas-checks/issues/events{/number}","events_url":"https://api.github.com/repos/hallahan/atlas-checks/events","assignees_url":"https://api.github.com/repos/hallahan/atlas-checks/assignees{/user}","branches_url":"https://api.github.com/repos/hallahan/atlas-checks/branches{/branch}","tags_url":"https://api.github.com/repos/hallahan/atlas-checks/tags","blobs_url":"https://api.github.com/repos/hallahan/atlas-checks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hallahan/atlas-checks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hallahan/atlas-checks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hallahan/atlas-checks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hallahan/atlas-checks/statuses/{sha}","languages_url":"https://api.github.com/repos/hallahan/atlas-checks/languages","stargazers_url":"https://api.github.com/repos/hallahan/atlas-checks/stargazers","contributors_url":"https://api.github.com/repos/hallahan/atlas-checks/contributors","subscribers_url":"https://api.github.com/repos/hallahan/atlas-checks/subscribers","subscription_url":"https://api.github.com/repos/hallahan/atlas-checks/subscription","commits_url":"https://api.github.com/repos/hallahan/atlas-checks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hallahan/atlas-checks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hallahan/atlas-checks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hallahan/atlas-checks/issues/comments{/number}","contents_url":"https://api.github.com/repos/hallahan/atlas-checks/contents/{+path}","compare_url":"https://api.github.com/repos/hallahan/atlas-checks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hallahan/atlas-checks/merges","archive_url":"https://api.github.com/repos/hallahan/atlas-checks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hallahan/atlas-checks/downloads","issues_url":"https://api.github.com/repos/hallahan/atlas-checks/issues{/number}","pulls_url":"https://api.github.com/repos/hallahan/atlas-checks/pulls{/number}","milestones_url":"https://api.github.com/repos/hallahan/atlas-checks/milestones{/number}","notifications_url":"https://api.github.com/repos/hallahan/atlas-checks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hallahan/atlas-checks/labels{/name}","releases_url":"https://api.github.com/repos/hallahan/atlas-checks/releases{/id}","deployments_url":"https://api.github.com/repos/hallahan/atlas-checks/deployments","created_at":"2018-05-10T15:41:48Z","updated_at":"2018-05-10T16:26:44Z","pushed_at":"2018-12-04T01:07:50Z","git_url":"git://github.com/hallahan/atlas-checks.git","ssh_url":"git@github.com:hallahan/atlas-checks.git","clone_url":"https://github.com/hallahan/atlas-checks.git","svn_url":"https://github.com/hallahan/atlas-checks","homepage":null,"size":13059,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"osmlab:dev","ref":"dev","sha":"fbfbef8deeb099be64d148da173297f88faed996","user":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":99742504,"node_id":"MDEwOlJlcG9zaXRvcnk5OTc0MjUwNA==","name":"atlas-checks","full_name":"osmlab/atlas-checks","private":false,"owner":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osmlab/atlas-checks","description":"OSM data integrity checks with Atlas","fork":false,"url":"https://api.github.com/repos/osmlab/atlas-checks","forks_url":"https://api.github.com/repos/osmlab/atlas-checks/forks","keys_url":"https://api.github.com/repos/osmlab/atlas-checks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/atlas-checks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/atlas-checks/teams","hooks_url":"https://api.github.com/repos/osmlab/atlas-checks/hooks","issue_events_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/atlas-checks/events","assignees_url":"https://api.github.com/repos/osmlab/atlas-checks/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/atlas-checks/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/atlas-checks/tags","blobs_url":"https://api.github.com/repos/osmlab/atlas-checks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/atlas-checks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/atlas-checks/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/atlas-checks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/atlas-checks/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/atlas-checks/languages","stargazers_url":"https://api.github.com/repos/osmlab/atlas-checks/stargazers","contributors_url":"https://api.github.com/repos/osmlab/atlas-checks/contributors","subscribers_url":"https://api.github.com/repos/osmlab/atlas-checks/subscribers","subscription_url":"https://api.github.com/repos/osmlab/atlas-checks/subscription","commits_url":"https://api.github.com/repos/osmlab/atlas-checks/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/atlas-checks/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/atlas-checks/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/atlas-checks/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/atlas-checks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/atlas-checks/merges","archive_url":"https://api.github.com/repos/osmlab/atlas-checks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/atlas-checks/downloads","issues_url":"https://api.github.com/repos/osmlab/atlas-checks/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/atlas-checks/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/atlas-checks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/atlas-checks/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/atlas-checks/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/atlas-checks/deployments","created_at":"2017-08-08T22:46:46Z","updated_at":"2018-11-28T20:46:47Z","pushed_at":"2018-12-04T01:07:52Z","git_url":"git://github.com/osmlab/atlas-checks.git","ssh_url":"git@github.com:osmlab/atlas-checks.git","clone_url":"https://github.com/osmlab/atlas-checks.git","svn_url":"https://github.com/osmlab/atlas-checks","homepage":null,"size":13013,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":4,"watchers":26,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101"},"html":{"href":"https://github.com/osmlab/atlas-checks/pull/101"},"issue":{"href":"https://api.github.com/repos/osmlab/atlas-checks/issues/101"},"comments":{"href":"https://api.github.com/repos/osmlab/atlas-checks/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/osmlab/atlas-checks/statuses/0ec0fb3ace1d49da200d5c39c83b9399c2157170"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jklamer"}}