{"action":"closed","number":23983,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/23983","id":183552393,"html_url":"https://github.com/laravel/framework/pull/23983","diff_url":"https://github.com/laravel/framework/pull/23983.diff","patch_url":"https://github.com/laravel/framework/pull/23983.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/23983","number":23983,"state":"closed","locked":false,"title":"[5.6] Remove namespace from factory filename when creating using model make command","user":{"login":"guilhermeportela","id":4705823,"avatar_url":"https://avatars0.githubusercontent.com/u/4705823?v=4","gravatar_id":"","url":"https://api.github.com/users/guilhermeportela","html_url":"https://github.com/guilhermeportela","followers_url":"https://api.github.com/users/guilhermeportela/followers","following_url":"https://api.github.com/users/guilhermeportela/following{/other_user}","gists_url":"https://api.github.com/users/guilhermeportela/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermeportela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermeportela/subscriptions","organizations_url":"https://api.github.com/users/guilhermeportela/orgs","repos_url":"https://api.github.com/users/guilhermeportela/repos","events_url":"https://api.github.com/users/guilhermeportela/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermeportela/received_events","type":"User","site_admin":false},"body":"I usually use namespaces for the domain classes when I'm working on large projects, and I've noticed that unlike the controllers generated with the `-c` flag in `make:model`, the factories generated using `-f` do not have the namespace of the model stripped from the filename. This modification intends to correct that behavior, using the controller part from the command class as reference.\r\n\r\nI noticed it has been proposed at least three times (#23881, #23151 and #23521), and it has always been questioned about the same thing: whether people wouldn't want the namespace in the factory filename. Well, I'm the fourth to show that we don't (yes, maybe there's a whole other lot who wants to keep this behavior -- as Chuck Lorre wrote: \"I don't know what my expectations are until they're not met\"). Regardless of that, if it should have the namespace on it, why doesn't that behavior apply to controllers? At least we can agree there's some inconsistency.","created_at":"2018-04-23T20:45:23Z","updated_at":"2018-04-25T14:04:04Z","closed_at":"2018-04-25T14:04:04Z","merged_at":"2018-04-25T14:04:04Z","merge_commit_sha":"9fae4d5c9a07f3bc652e45fe0ffc47b6556357d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/23983/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/23983/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/23983/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/0ea9c3b025ed585b06daaec6e13dd2450b691aa4","head":{"label":"guilhermeportela:5.6","ref":"5.6","sha":"0ea9c3b025ed585b06daaec6e13dd2450b691aa4","user":{"login":"guilhermeportela","id":4705823,"avatar_url":"https://avatars0.githubusercontent.com/u/4705823?v=4","gravatar_id":"","url":"https://api.github.com/users/guilhermeportela","html_url":"https://github.com/guilhermeportela","followers_url":"https://api.github.com/users/guilhermeportela/followers","following_url":"https://api.github.com/users/guilhermeportela/following{/other_user}","gists_url":"https://api.github.com/users/guilhermeportela/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermeportela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermeportela/subscriptions","organizations_url":"https://api.github.com/users/guilhermeportela/orgs","repos_url":"https://api.github.com/users/guilhermeportela/repos","events_url":"https://api.github.com/users/guilhermeportela/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermeportela/received_events","type":"User","site_admin":false},"repo":{"id":130752885,"name":"framework","full_name":"guilhermeportela/framework","owner":{"login":"guilhermeportela","id":4705823,"avatar_url":"https://avatars0.githubusercontent.com/u/4705823?v=4","gravatar_id":"","url":"https://api.github.com/users/guilhermeportela","html_url":"https://github.com/guilhermeportela","followers_url":"https://api.github.com/users/guilhermeportela/followers","following_url":"https://api.github.com/users/guilhermeportela/following{/other_user}","gists_url":"https://api.github.com/users/guilhermeportela/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermeportela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermeportela/subscriptions","organizations_url":"https://api.github.com/users/guilhermeportela/orgs","repos_url":"https://api.github.com/users/guilhermeportela/repos","events_url":"https://api.github.com/users/guilhermeportela/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermeportela/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guilhermeportela/framework","description":null,"fork":true,"url":"https://api.github.com/repos/guilhermeportela/framework","forks_url":"https://api.github.com/repos/guilhermeportela/framework/forks","keys_url":"https://api.github.com/repos/guilhermeportela/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guilhermeportela/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guilhermeportela/framework/teams","hooks_url":"https://api.github.com/repos/guilhermeportela/framework/hooks","issue_events_url":"https://api.github.com/repos/guilhermeportela/framework/issues/events{/number}","events_url":"https://api.github.com/repos/guilhermeportela/framework/events","assignees_url":"https://api.github.com/repos/guilhermeportela/framework/assignees{/user}","branches_url":"https://api.github.com/repos/guilhermeportela/framework/branches{/branch}","tags_url":"https://api.github.com/repos/guilhermeportela/framework/tags","blobs_url":"https://api.github.com/repos/guilhermeportela/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guilhermeportela/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guilhermeportela/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/guilhermeportela/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guilhermeportela/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/guilhermeportela/framework/languages","stargazers_url":"https://api.github.com/repos/guilhermeportela/framework/stargazers","contributors_url":"https://api.github.com/repos/guilhermeportela/framework/contributors","subscribers_url":"https://api.github.com/repos/guilhermeportela/framework/subscribers","subscription_url":"https://api.github.com/repos/guilhermeportela/framework/subscription","commits_url":"https://api.github.com/repos/guilhermeportela/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/guilhermeportela/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/guilhermeportela/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/guilhermeportela/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/guilhermeportela/framework/contents/{+path}","compare_url":"https://api.github.com/repos/guilhermeportela/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guilhermeportela/framework/merges","archive_url":"https://api.github.com/repos/guilhermeportela/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guilhermeportela/framework/downloads","issues_url":"https://api.github.com/repos/guilhermeportela/framework/issues{/number}","pulls_url":"https://api.github.com/repos/guilhermeportela/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/guilhermeportela/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/guilhermeportela/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guilhermeportela/framework/labels{/name}","releases_url":"https://api.github.com/repos/guilhermeportela/framework/releases{/id}","deployments_url":"https://api.github.com/repos/guilhermeportela/framework/deployments","created_at":"2018-04-23T20:28:57Z","updated_at":"2018-04-23T20:39:54Z","pushed_at":"2018-04-23T20:39:48Z","git_url":"git://github.com/guilhermeportela/framework.git","ssh_url":"git@github.com:guilhermeportela/framework.git","clone_url":"https://github.com/guilhermeportela/framework.git","svn_url":"https://github.com/guilhermeportela/framework","homepage":"http://laravel.com","size":33294,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"laravel:5.6","ref":"5.6","sha":"0c6f4740dfa448695b659aae521c6e138c3cf69d","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2018-04-25T14:02:07Z","pushed_at":"2018-04-25T14:04:04Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":33291,"stargazers_count":11951,"watchers_count":11951,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5349,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5349,"open_issues":180,"watchers":11951,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/23983"},"html":{"href":"https://github.com/laravel/framework/pull/23983"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/23983"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/23983/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/23983/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/23983/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/0ea9c3b025ed585b06daaec6e13dd2450b691aa4"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars3.githubusercontent.com/u/463230?v=4","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"taylorotwell"}}