{"action":"opened","number":4687,"pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/4687","id":206157495,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTU3NDk1","html_url":"https://github.com/runelite/runelite/pull/4687","diff_url":"https://github.com/runelite/runelite/pull/4687.diff","patch_url":"https://github.com/runelite/runelite/pull/4687.patch","issue_url":"https://api.github.com/repos/runelite/runelite/issues/4687","number":4687,"state":"open","locked":false,"title":"Add solutions for 3 step cryptic master clues (continued from #3352)","user":{"login":"Nightfirecat","id":2199511,"node_id":"MDQ6VXNlcjIxOTk1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2199511?v=4","gravatar_id":"","url":"https://api.github.com/users/Nightfirecat","html_url":"https://github.com/Nightfirecat","followers_url":"https://api.github.com/users/Nightfirecat/followers","following_url":"https://api.github.com/users/Nightfirecat/following{/other_user}","gists_url":"https://api.github.com/users/Nightfirecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Nightfirecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nightfirecat/subscriptions","organizations_url":"https://api.github.com/users/Nightfirecat/orgs","repos_url":"https://api.github.com/users/Nightfirecat/repos","events_url":"https://api.github.com/users/Nightfirecat/events{/privacy}","received_events_url":"https://api.github.com/users/Nightfirecat/received_events","type":"User","site_admin":false},"body":"This extends the functionality of the clue scroll plugin to include solutions for three step cryptic master clues. The solutions for these clues are already present in the existing CrypticClue class, but before this there was not a way for the clues to be recognized. The ThreeStepCrypticClue class matches the clue scroll text for all three cryptic clues and keeps the matched clue objects as a list, along with their completion status. If a clue has a strikethrough tag when reading the clue, then the plugin will recognize it as complete. The plugin will also detect when a new clue part has been obtained and update the completed status of that clue.\r\n\r\nFixes #2923\r\n\r\nIn action: https://streamable.com/ujaar\r\n\r\nP.S. This is written by @Eadgars-Ruse continued from #3352, with review fixes written by me as requested.","created_at":"2018-08-03T23:11:04Z","updated_at":"2018-08-03T23:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/runelite/runelite/pulls/4687/commits","review_comments_url":"https://api.github.com/repos/runelite/runelite/pulls/4687/comments","review_comment_url":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/4687/comments","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/2eff0c4ca13e80e41776fa19b71388d5749a0695","head":{"label":"Nightfirecat:three-step-cryptic-clue","ref":"three-step-cryptic-clue","sha":"2eff0c4ca13e80e41776fa19b71388d5749a0695","user":{"login":"Nightfirecat","id":2199511,"node_id":"MDQ6VXNlcjIxOTk1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2199511?v=4","gravatar_id":"","url":"https://api.github.com/users/Nightfirecat","html_url":"https://github.com/Nightfirecat","followers_url":"https://api.github.com/users/Nightfirecat/followers","following_url":"https://api.github.com/users/Nightfirecat/following{/other_user}","gists_url":"https://api.github.com/users/Nightfirecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Nightfirecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nightfirecat/subscriptions","organizations_url":"https://api.github.com/users/Nightfirecat/orgs","repos_url":"https://api.github.com/users/Nightfirecat/repos","events_url":"https://api.github.com/users/Nightfirecat/events{/privacy}","received_events_url":"https://api.github.com/users/Nightfirecat/received_events","type":"User","site_admin":false},"repo":{"id":129843820,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDM4MjA=","name":"runelite","full_name":"Nightfirecat/runelite","owner":{"login":"Nightfirecat","id":2199511,"node_id":"MDQ6VXNlcjIxOTk1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2199511?v=4","gravatar_id":"","url":"https://api.github.com/users/Nightfirecat","html_url":"https://github.com/Nightfirecat","followers_url":"https://api.github.com/users/Nightfirecat/followers","following_url":"https://api.github.com/users/Nightfirecat/following{/other_user}","gists_url":"https://api.github.com/users/Nightfirecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Nightfirecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nightfirecat/subscriptions","organizations_url":"https://api.github.com/users/Nightfirecat/orgs","repos_url":"https://api.github.com/users/Nightfirecat/repos","events_url":"https://api.github.com/users/Nightfirecat/events{/privacy}","received_events_url":"https://api.github.com/users/Nightfirecat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nightfirecat/runelite","description":"Open source Old School RuneScape client","fork":true,"url":"https://api.github.com/repos/Nightfirecat/runelite","forks_url":"https://api.github.com/repos/Nightfirecat/runelite/forks","keys_url":"https://api.github.com/repos/Nightfirecat/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nightfirecat/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nightfirecat/runelite/teams","hooks_url":"https://api.github.com/repos/Nightfirecat/runelite/hooks","issue_events_url":"https://api.github.com/repos/Nightfirecat/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/Nightfirecat/runelite/events","assignees_url":"https://api.github.com/repos/Nightfirecat/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/Nightfirecat/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/Nightfirecat/runelite/tags","blobs_url":"https://api.github.com/repos/Nightfirecat/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nightfirecat/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nightfirecat/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nightfirecat/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nightfirecat/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/Nightfirecat/runelite/languages","stargazers_url":"https://api.github.com/repos/Nightfirecat/runelite/stargazers","contributors_url":"https://api.github.com/repos/Nightfirecat/runelite/contributors","subscribers_url":"https://api.github.com/repos/Nightfirecat/runelite/subscribers","subscription_url":"https://api.github.com/repos/Nightfirecat/runelite/subscription","commits_url":"https://api.github.com/repos/Nightfirecat/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nightfirecat/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nightfirecat/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nightfirecat/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nightfirecat/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/Nightfirecat/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nightfirecat/runelite/merges","archive_url":"https://api.github.com/repos/Nightfirecat/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nightfirecat/runelite/downloads","issues_url":"https://api.github.com/repos/Nightfirecat/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/Nightfirecat/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/Nightfirecat/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/Nightfirecat/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nightfirecat/runelite/labels{/name}","releases_url":"https://api.github.com/repos/Nightfirecat/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/Nightfirecat/runelite/deployments","created_at":"2018-04-17T04:00:26Z","updated_at":"2018-08-03T23:07:15Z","pushed_at":"2018-08-03T23:07:07Z","git_url":"git://github.com/Nightfirecat/runelite.git","ssh_url":"git@github.com:Nightfirecat/runelite.git","clone_url":"https://github.com/Nightfirecat/runelite.git","svn_url":"https://github.com/Nightfirecat/runelite","homepage":"https://runelite.net","size":45852,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"runelite:master","ref":"master","sha":"dce0ad56316cb549c5ef3b8619e61d30bc1a5003","user":{"login":"runelite","id":13814776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODE0Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"repo":{"id":57461213,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQ2MTIxMw==","name":"runelite","full_name":"runelite/runelite","owner":{"login":"runelite","id":13814776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODE0Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runelite/runelite","description":"Open source Old School RuneScape client","fork":false,"url":"https://api.github.com/repos/runelite/runelite","forks_url":"https://api.github.com/repos/runelite/runelite/forks","keys_url":"https://api.github.com/repos/runelite/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runelite/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runelite/runelite/teams","hooks_url":"https://api.github.com/repos/runelite/runelite/hooks","issue_events_url":"https://api.github.com/repos/runelite/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/runelite/runelite/events","assignees_url":"https://api.github.com/repos/runelite/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/runelite/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/runelite/runelite/tags","blobs_url":"https://api.github.com/repos/runelite/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runelite/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runelite/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/runelite/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/runelite/runelite/languages","stargazers_url":"https://api.github.com/repos/runelite/runelite/stargazers","contributors_url":"https://api.github.com/repos/runelite/runelite/contributors","subscribers_url":"https://api.github.com/repos/runelite/runelite/subscribers","subscription_url":"https://api.github.com/repos/runelite/runelite/subscription","commits_url":"https://api.github.com/repos/runelite/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/runelite/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/runelite/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/runelite/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/runelite/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/runelite/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runelite/runelite/merges","archive_url":"https://api.github.com/repos/runelite/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runelite/runelite/downloads","issues_url":"https://api.github.com/repos/runelite/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/runelite/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/runelite/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/runelite/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runelite/runelite/labels{/name}","releases_url":"https://api.github.com/repos/runelite/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/runelite/runelite/deployments","created_at":"2016-04-30T20:48:02Z","updated_at":"2018-08-03T20:26:57Z","pushed_at":"2018-08-03T22:23:47Z","git_url":"git://github.com/runelite/runelite.git","ssh_url":"git@github.com:runelite/runelite.git","clone_url":"https://github.com/runelite/runelite.git","svn_url":"https://github.com/runelite/runelite","homepage":"https://runelite.net","size":18101,"stargazers_count":1136,"watchers_count":1136,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1477,"mirror_url":null,"archived":false,"open_issues_count":1168,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1477,"open_issues":1168,"watchers":1136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4687"},"html":{"href":"https://github.com/runelite/runelite/pull/4687"},"issue":{"href":"https://api.github.com/repos/runelite/runelite/issues/4687"},"comments":{"href":"https://api.github.com/repos/runelite/runelite/issues/4687/comments"},"review_comments":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4687/comments"},"review_comment":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runelite/runelite/pulls/4687/commits"},"statuses":{"href":"https://api.github.com/repos/runelite/runelite/statuses/2eff0c4ca13e80e41776fa19b71388d5749a0695"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":307,"deletions":53,"changed_files":10}}
{"actor":{"display_login":"Nightfirecat"}}