{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/20941","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/20941/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20941/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/20941/events","html_url":"https://github.com/openshift/origin/pull/20941","id":359285262,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODEzNTQw","number":20941,"title":"Don't ignore errors reported during Docker push/pull","user":{"login":"mtrmac","id":7052838,"node_id":"MDQ6VXNlcjcwNTI4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7052838?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"labels":[{"id":640548394,"node_id":"MDU6TGFiZWw2NDA1NDgzOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-12T01:50:54Z","updated_at":"2018-10-08T20:45:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20941","html_url":"https://github.com/openshift/origin/pull/20941","diff_url":"https://github.com/openshift/origin/pull/20941.diff","patch_url":"https://github.com/openshift/origin/pull/20941.patch"},"body":"DO NOT MERGE AS IS: This includes a commit which manually patches in **UNMERGED** https://github.com/openshift/imagebuilder/pull/97 ; that probably needs to happen only after that PR is reviewed, and in some other way than this manual patch.\r\n\r\nLonger-lived Docker API operations report only trivial errors (e.g. invalid syntax) as HTTP status codes; the rest is reported in the body of the response, along with other progress messages.\r\n\r\nRight now `openshift/imagebuilder/imageprogress` ignores such errors; https://github.com/openshift/imagebuilder/pull/97 fixes that, and this PR modifies OpenShift to take advantage of this (and, in some cases, to close the `imageprogress` objects and to terminate the associated goroutines).\r\n\r\nFor now **absolutely untested** beyond existing local unit tests; I’ll check whether testing this can be easily incorporated into them."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/427973482","html_url":"https://github.com/openshift/origin/pull/20941#issuecomment-427973482","issue_url":"https://api.github.com/repos/openshift/origin/issues/20941","id":427973482,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzk3MzQ4Mg==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T20:45:55Z","updated_at":"2018-10-08T20:45:55Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/openshift/origin/pull/20941#\" title=\"Author self-approved\">mtrmac</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **bparees**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @bparees` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/build/OWNERS](https://github.com/openshift/origin/blob/master/pkg/build/OWNERS)**\n- **[pkg/oc/clusterup/OWNERS](https://github.com/openshift/origin/blob/master/pkg/oc/clusterup/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"bparees\"]} -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}