{"action":"created","comment":{"url":"https://api.github.com/repos/Adyen/adyen-magento/pulls/comments/225522810","pull_request_review_id":165138548,"id":225522810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUyMjgxMA==","diff_hunk":"@@ -232,7 +232,7 @@ protected function _doRequest(array $request, $storeId)\n             $storeId = $storeId->getId();\n         }\n \n-        $requestUrl = $this->_helper()->getConfigDataDemoMode()\n+        $requestUrl = $this->_helper()->getConfigDataDemoMode($storeId)","path":"app/code/community/Adyen/Payment/Model/Api.php","position":5,"original_position":5,"commit_id":"1c76ffc8b0f4c9ff5421db99a98f906ff8598da0","original_commit_id":"1c76ffc8b0f4c9ff5421db99a98f906ff8598da0","user":{"login":"cyattilakiss","id":42297201,"node_id":"MDQ6VXNlcjQyMjk3MjAx","avatar_url":"https://avatars0.githubusercontent.com/u/42297201?v=4","gravatar_id":"","url":"https://api.github.com/users/cyattilakiss","html_url":"https://github.com/cyattilakiss","followers_url":"https://api.github.com/users/cyattilakiss/followers","following_url":"https://api.github.com/users/cyattilakiss/following{/other_user}","gists_url":"https://api.github.com/users/cyattilakiss/gists{/gist_id}","starred_url":"https://api.github.com/users/cyattilakiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyattilakiss/subscriptions","organizations_url":"https://api.github.com/users/cyattilakiss/orgs","repos_url":"https://api.github.com/users/cyattilakiss/repos","events_url":"https://api.github.com/users/cyattilakiss/events{/privacy}","received_events_url":"https://api.github.com/users/cyattilakiss/received_events","type":"User","site_admin":false},"body":"please use the long version of the if condition to make it more readable","created_at":"2018-10-16T12:47:02Z","updated_at":"2018-10-16T12:47:02Z","html_url":"https://github.com/Adyen/adyen-magento/pull/943#discussion_r225522810","pull_request_url":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Adyen/adyen-magento/pulls/comments/225522810"},"html":{"href":"https://github.com/Adyen/adyen-magento/pull/943#discussion_r225522810"},"pull_request":{"href":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943"}}},"pull_request":{"url":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943","id":222883450,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODgzNDUw","html_url":"https://github.com/Adyen/adyen-magento/pull/943","diff_url":"https://github.com/Adyen/adyen-magento/pull/943.diff","patch_url":"https://github.com/Adyen/adyen-magento/pull/943.patch","issue_url":"https://api.github.com/repos/Adyen/adyen-magento/issues/943","number":943,"state":"open","locked":false,"title":"Use demo/live configuration from store when doing listRecurringDetails","user":{"login":"lancergr","id":1558756,"node_id":"MDQ6VXNlcjE1NTg3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1558756?v=4","gravatar_id":"","url":"https://api.github.com/users/lancergr","html_url":"https://github.com/lancergr","followers_url":"https://api.github.com/users/lancergr/followers","following_url":"https://api.github.com/users/lancergr/following{/other_user}","gists_url":"https://api.github.com/users/lancergr/gists{/gist_id}","starred_url":"https://api.github.com/users/lancergr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancergr/subscriptions","organizations_url":"https://api.github.com/users/lancergr/orgs","repos_url":"https://api.github.com/users/lancergr/repos","events_url":"https://api.github.com/users/lancergr/events{/privacy}","received_events_url":"https://api.github.com/users/lancergr/received_events","type":"User","site_admin":false},"body":"Use demo/live configuration from store when doing listRecurringDetails and creating Billing Agreements\r\n","created_at":"2018-10-15T12:12:16Z","updated_at":"2018-10-16T12:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fcc79b512c28f9258059dfd91cf9d2ab0377fa4","assignee":{"login":"lancergr","id":1558756,"node_id":"MDQ6VXNlcjE1NTg3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1558756?v=4","gravatar_id":"","url":"https://api.github.com/users/lancergr","html_url":"https://github.com/lancergr","followers_url":"https://api.github.com/users/lancergr/followers","following_url":"https://api.github.com/users/lancergr/following{/other_user}","gists_url":"https://api.github.com/users/lancergr/gists{/gist_id}","starred_url":"https://api.github.com/users/lancergr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancergr/subscriptions","organizations_url":"https://api.github.com/users/lancergr/orgs","repos_url":"https://api.github.com/users/lancergr/repos","events_url":"https://api.github.com/users/lancergr/events{/privacy}","received_events_url":"https://api.github.com/users/lancergr/received_events","type":"User","site_admin":false},"assignees":[{"login":"lancergr","id":1558756,"node_id":"MDQ6VXNlcjE1NTg3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1558756?v=4","gravatar_id":"","url":"https://api.github.com/users/lancergr","html_url":"https://github.com/lancergr","followers_url":"https://api.github.com/users/lancergr/followers","following_url":"https://api.github.com/users/lancergr/following{/other_user}","gists_url":"https://api.github.com/users/lancergr/gists{/gist_id}","starred_url":"https://api.github.com/users/lancergr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancergr/subscriptions","organizations_url":"https://api.github.com/users/lancergr/orgs","repos_url":"https://api.github.com/users/lancergr/repos","events_url":"https://api.github.com/users/lancergr/events{/privacy}","received_events_url":"https://api.github.com/users/lancergr/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rkewlani","id":8029729,"node_id":"MDQ6VXNlcjgwMjk3Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/8029729?v=4","gravatar_id":"","url":"https://api.github.com/users/rkewlani","html_url":"https://github.com/rkewlani","followers_url":"https://api.github.com/users/rkewlani/followers","following_url":"https://api.github.com/users/rkewlani/following{/other_user}","gists_url":"https://api.github.com/users/rkewlani/gists{/gist_id}","starred_url":"https://api.github.com/users/rkewlani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkewlani/subscriptions","organizations_url":"https://api.github.com/users/rkewlani/orgs","repos_url":"https://api.github.com/users/rkewlani/repos","events_url":"https://api.github.com/users/rkewlani/events{/privacy}","received_events_url":"https://api.github.com/users/rkewlani/received_events","type":"User","site_admin":false},{"login":"maassenbas","id":28703407,"node_id":"MDQ6VXNlcjI4NzAzNDA3","avatar_url":"https://avatars3.githubusercontent.com/u/28703407?v=4","gravatar_id":"","url":"https://api.github.com/users/maassenbas","html_url":"https://github.com/maassenbas","followers_url":"https://api.github.com/users/maassenbas/followers","following_url":"https://api.github.com/users/maassenbas/following{/other_user}","gists_url":"https://api.github.com/users/maassenbas/gists{/gist_id}","starred_url":"https://api.github.com/users/maassenbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maassenbas/subscriptions","organizations_url":"https://api.github.com/users/maassenbas/orgs","repos_url":"https://api.github.com/users/maassenbas/repos","events_url":"https://api.github.com/users/maassenbas/events{/privacy}","received_events_url":"https://api.github.com/users/maassenbas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943/commits","review_comments_url":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943/comments","review_comment_url":"https://api.github.com/repos/Adyen/adyen-magento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Adyen/adyen-magento/issues/943/comments","statuses_url":"https://api.github.com/repos/Adyen/adyen-magento/statuses/1c76ffc8b0f4c9ff5421db99a98f906ff8598da0","head":{"label":"Adyen:listrecurring-configmode","ref":"listrecurring-configmode","sha":"1c76ffc8b0f4c9ff5421db99a98f906ff8598da0","user":{"login":"Adyen","id":9713612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MTM2MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9713612?v=4","gravatar_id":"","url":"https://api.github.com/users/Adyen","html_url":"https://github.com/Adyen","followers_url":"https://api.github.com/users/Adyen/followers","following_url":"https://api.github.com/users/Adyen/following{/other_user}","gists_url":"https://api.github.com/users/Adyen/gists{/gist_id}","starred_url":"https://api.github.com/users/Adyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adyen/subscriptions","organizations_url":"https://api.github.com/users/Adyen/orgs","repos_url":"https://api.github.com/users/Adyen/repos","events_url":"https://api.github.com/users/Adyen/events{/privacy}","received_events_url":"https://api.github.com/users/Adyen/received_events","type":"Organization","site_admin":false},"repo":{"id":18838035,"node_id":"MDEwOlJlcG9zaXRvcnkxODgzODAzNQ==","name":"adyen-magento","full_name":"Adyen/adyen-magento","private":false,"owner":{"login":"Adyen","id":9713612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MTM2MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9713612?v=4","gravatar_id":"","url":"https://api.github.com/users/Adyen","html_url":"https://github.com/Adyen","followers_url":"https://api.github.com/users/Adyen/followers","following_url":"https://api.github.com/users/Adyen/following{/other_user}","gists_url":"https://api.github.com/users/Adyen/gists{/gist_id}","starred_url":"https://api.github.com/users/Adyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adyen/subscriptions","organizations_url":"https://api.github.com/users/Adyen/orgs","repos_url":"https://api.github.com/users/Adyen/repos","events_url":"https://api.github.com/users/Adyen/events{/privacy}","received_events_url":"https://api.github.com/users/Adyen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Adyen/adyen-magento","description":" Adyen Payment plugin for Magento","fork":false,"url":"https://api.github.com/repos/Adyen/adyen-magento","forks_url":"https://api.github.com/repos/Adyen/adyen-magento/forks","keys_url":"https://api.github.com/repos/Adyen/adyen-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adyen/adyen-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adyen/adyen-magento/teams","hooks_url":"https://api.github.com/repos/Adyen/adyen-magento/hooks","issue_events_url":"https://api.github.com/repos/Adyen/adyen-magento/issues/events{/number}","events_url":"https://api.github.com/repos/Adyen/adyen-magento/events","assignees_url":"https://api.github.com/repos/Adyen/adyen-magento/assignees{/user}","branches_url":"https://api.github.com/repos/Adyen/adyen-magento/branches{/branch}","tags_url":"https://api.github.com/repos/Adyen/adyen-magento/tags","blobs_url":"https://api.github.com/repos/Adyen/adyen-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adyen/adyen-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adyen/adyen-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adyen/adyen-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adyen/adyen-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/Adyen/adyen-magento/languages","stargazers_url":"https://api.github.com/repos/Adyen/adyen-magento/stargazers","contributors_url":"https://api.github.com/repos/Adyen/adyen-magento/contributors","subscribers_url":"https://api.github.com/repos/Adyen/adyen-magento/subscribers","subscription_url":"https://api.github.com/repos/Adyen/adyen-magento/subscription","commits_url":"https://api.github.com/repos/Adyen/adyen-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adyen/adyen-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adyen/adyen-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adyen/adyen-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adyen/adyen-magento/contents/{+path}","compare_url":"https://api.github.com/repos/Adyen/adyen-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adyen/adyen-magento/merges","archive_url":"https://api.github.com/repos/Adyen/adyen-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adyen/adyen-magento/downloads","issues_url":"https://api.github.com/repos/Adyen/adyen-magento/issues{/number}","pulls_url":"https://api.github.com/repos/Adyen/adyen-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/Adyen/adyen-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/Adyen/adyen-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adyen/adyen-magento/labels{/name}","releases_url":"https://api.github.com/repos/Adyen/adyen-magento/releases{/id}","deployments_url":"https://api.github.com/repos/Adyen/adyen-magento/deployments","created_at":"2014-04-16T12:04:35Z","updated_at":"2018-10-10T11:24:27Z","pushed_at":"2018-10-15T12:12:17Z","git_url":"git://github.com/Adyen/adyen-magento.git","ssh_url":"git@github.com:Adyen/adyen-magento.git","clone_url":"https://github.com/Adyen/adyen-magento.git","svn_url":"https://github.com/Adyen/adyen-magento","homepage":null,"size":6684,"stargazers_count":68,"watchers_count":68,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":57,"watchers":68,"default_branch":"develop"}},"base":{"label":"Adyen:develop","ref":"develop","sha":"f2f5301506fe30cdb8374330f4cccefadfbbb0e8","user":{"login":"Adyen","id":9713612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MTM2MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9713612?v=4","gravatar_id":"","url":"https://api.github.com/users/Adyen","html_url":"https://github.com/Adyen","followers_url":"https://api.github.com/users/Adyen/followers","following_url":"https://api.github.com/users/Adyen/following{/other_user}","gists_url":"https://api.github.com/users/Adyen/gists{/gist_id}","starred_url":"https://api.github.com/users/Adyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adyen/subscriptions","organizations_url":"https://api.github.com/users/Adyen/orgs","repos_url":"https://api.github.com/users/Adyen/repos","events_url":"https://api.github.com/users/Adyen/events{/privacy}","received_events_url":"https://api.github.com/users/Adyen/received_events","type":"Organization","site_admin":false},"repo":{"id":18838035,"node_id":"MDEwOlJlcG9zaXRvcnkxODgzODAzNQ==","name":"adyen-magento","full_name":"Adyen/adyen-magento","private":false,"owner":{"login":"Adyen","id":9713612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MTM2MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/9713612?v=4","gravatar_id":"","url":"https://api.github.com/users/Adyen","html_url":"https://github.com/Adyen","followers_url":"https://api.github.com/users/Adyen/followers","following_url":"https://api.github.com/users/Adyen/following{/other_user}","gists_url":"https://api.github.com/users/Adyen/gists{/gist_id}","starred_url":"https://api.github.com/users/Adyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adyen/subscriptions","organizations_url":"https://api.github.com/users/Adyen/orgs","repos_url":"https://api.github.com/users/Adyen/repos","events_url":"https://api.github.com/users/Adyen/events{/privacy}","received_events_url":"https://api.github.com/users/Adyen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Adyen/adyen-magento","description":" Adyen Payment plugin for Magento","fork":false,"url":"https://api.github.com/repos/Adyen/adyen-magento","forks_url":"https://api.github.com/repos/Adyen/adyen-magento/forks","keys_url":"https://api.github.com/repos/Adyen/adyen-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adyen/adyen-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adyen/adyen-magento/teams","hooks_url":"https://api.github.com/repos/Adyen/adyen-magento/hooks","issue_events_url":"https://api.github.com/repos/Adyen/adyen-magento/issues/events{/number}","events_url":"https://api.github.com/repos/Adyen/adyen-magento/events","assignees_url":"https://api.github.com/repos/Adyen/adyen-magento/assignees{/user}","branches_url":"https://api.github.com/repos/Adyen/adyen-magento/branches{/branch}","tags_url":"https://api.github.com/repos/Adyen/adyen-magento/tags","blobs_url":"https://api.github.com/repos/Adyen/adyen-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adyen/adyen-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adyen/adyen-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adyen/adyen-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adyen/adyen-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/Adyen/adyen-magento/languages","stargazers_url":"https://api.github.com/repos/Adyen/adyen-magento/stargazers","contributors_url":"https://api.github.com/repos/Adyen/adyen-magento/contributors","subscribers_url":"https://api.github.com/repos/Adyen/adyen-magento/subscribers","subscription_url":"https://api.github.com/repos/Adyen/adyen-magento/subscription","commits_url":"https://api.github.com/repos/Adyen/adyen-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adyen/adyen-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adyen/adyen-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adyen/adyen-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adyen/adyen-magento/contents/{+path}","compare_url":"https://api.github.com/repos/Adyen/adyen-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adyen/adyen-magento/merges","archive_url":"https://api.github.com/repos/Adyen/adyen-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adyen/adyen-magento/downloads","issues_url":"https://api.github.com/repos/Adyen/adyen-magento/issues{/number}","pulls_url":"https://api.github.com/repos/Adyen/adyen-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/Adyen/adyen-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/Adyen/adyen-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adyen/adyen-magento/labels{/name}","releases_url":"https://api.github.com/repos/Adyen/adyen-magento/releases{/id}","deployments_url":"https://api.github.com/repos/Adyen/adyen-magento/deployments","created_at":"2014-04-16T12:04:35Z","updated_at":"2018-10-10T11:24:27Z","pushed_at":"2018-10-15T12:12:17Z","git_url":"git://github.com/Adyen/adyen-magento.git","ssh_url":"git@github.com:Adyen/adyen-magento.git","clone_url":"https://github.com/Adyen/adyen-magento.git","svn_url":"https://github.com/Adyen/adyen-magento","homepage":null,"size":6684,"stargazers_count":68,"watchers_count":68,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":57,"watchers":68,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943"},"html":{"href":"https://github.com/Adyen/adyen-magento/pull/943"},"issue":{"href":"https://api.github.com/repos/Adyen/adyen-magento/issues/943"},"comments":{"href":"https://api.github.com/repos/Adyen/adyen-magento/issues/943/comments"},"review_comments":{"href":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943/comments"},"review_comment":{"href":"https://api.github.com/repos/Adyen/adyen-magento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Adyen/adyen-magento/pulls/943/commits"},"statuses":{"href":"https://api.github.com/repos/Adyen/adyen-magento/statuses/1c76ffc8b0f4c9ff5421db99a98f906ff8598da0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cyattilakiss"}}