{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/171093824","pull_request_review_id":99887053,"id":171093824,"diff_hunk":"@@ -1,29 +1,114 @@\n default:\n     trainer: ppo\n-    batch_size: 32\n+    batch_size: 1024\n     beta: 5.0e-3\n-    buffer_size: 512\n+    buffer_size: 10000\n     epsilon: 0.2\n     gamma: 0.99\n     hidden_units: 128\n     lambd: 0.95\n     learning_rate: 3.0e-4\n     max_steps: 5.0e4\n-    normalize: true\n+    normalize: false\n     num_epoch: 5\n     num_layers: 2\n     time_horizon: 64\n     sequence_length: 64\n     summary_freq: 1000\n     use_recurrent: false\n \n-Ball3DBrain:\n+BrainWallJumpCC:\n+    max_steps: 2.0e5\n+    num_layers: 2\n+    beta: 5.0e-4\n+    hidden_units: 256\n+    use_recurrent: true\n+    sequence_length: 32\n+    time_horizon: 32\n+    batch_size: 32\n+    buffer_size: 320\n+\n+Ball3DBrainR:\n     summary_freq: 1000\n     normalize: true\n-    batch_size: 1000\n-    buffer_size: 10000 \n+    # batch_size: 1000","path":"python/trainer_config.yaml","position":40,"original_position":40,"commit_id":"dad53a5cf483bc55deb39992625d2a2bbf7d4618","original_commit_id":"dad53a5cf483bc55deb39992625d2a2bbf7d4618","user":{"login":"eshvk","id":807898,"avatar_url":"https://avatars0.githubusercontent.com/u/807898?v=4","gravatar_id":"","url":"https://api.github.com/users/eshvk","html_url":"https://github.com/eshvk","followers_url":"https://api.github.com/users/eshvk/followers","following_url":"https://api.github.com/users/eshvk/following{/other_user}","gists_url":"https://api.github.com/users/eshvk/gists{/gist_id}","starred_url":"https://api.github.com/users/eshvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshvk/subscriptions","organizations_url":"https://api.github.com/users/eshvk/orgs","repos_url":"https://api.github.com/users/eshvk/repos","events_url":"https://api.github.com/users/eshvk/events{/privacy}","received_events_url":"https://api.github.com/users/eshvk/received_events","type":"User","site_admin":false},"body":"delete commented lines","created_at":"2018-02-27T22:50:32Z","updated_at":"2018-02-27T22:52:57Z","html_url":"https://github.com/Unity-Technologies/ml-agents/pull/367#discussion_r171093824","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/171093824"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/367#discussion_r171093824"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367","id":171807062,"html_url":"https://github.com/Unity-Technologies/ml-agents/pull/367","diff_url":"https://github.com/Unity-Technologies/ml-agents/pull/367.diff","patch_url":"https://github.com/Unity-Technologies/ml-agents/pull/367.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/367","number":367,"state":"open","locked":false,"title":"Hallway & LSTM Improvements","user":{"login":"awjuliani","id":9065325,"avatar_url":"https://avatars2.githubusercontent.com/u/9065325?v=4","gravatar_id":"","url":"https://api.github.com/users/awjuliani","html_url":"https://github.com/awjuliani","followers_url":"https://api.github.com/users/awjuliani/followers","following_url":"https://api.github.com/users/awjuliani/following{/other_user}","gists_url":"https://api.github.com/users/awjuliani/gists{/gist_id}","starred_url":"https://api.github.com/users/awjuliani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awjuliani/subscriptions","organizations_url":"https://api.github.com/users/awjuliani/orgs","repos_url":"https://api.github.com/users/awjuliani/repos","events_url":"https://api.github.com/users/awjuliani/events{/privacy}","received_events_url":"https://api.github.com/users/awjuliani/received_events","type":"User","site_admin":false},"body":"* Add `Hallway` example environment to validate LSTM models.\r\n* Properly mask gradient for padded experiences when using `sequence_length > 1`\r\n* Add support for feeding previous action into LSTM models to enable partial meta-learning.","created_at":"2018-02-27T22:45:38Z","updated_at":"2018-02-27T22:52:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cf00a77a54d033e7704094bdce865138cad0fff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/367/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/dad53a5cf483bc55deb39992625d2a2bbf7d4618","head":{"label":"Unity-Technologies:feature/LSTM2","ref":"feature/LSTM2","sha":"dad53a5cf483bc55deb39992625d2a2bbf7d4618","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"name":"ml-agents","full_name":"Unity-Technologies/ml-agents","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2018-02-27T18:42:07Z","pushed_at":"2018-02-27T22:45:39Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":124575,"stargazers_count":2196,"watchers_count":2196,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":422,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":422,"open_issues":116,"watchers":2196,"default_branch":"master"}},"base":{"label":"Unity-Technologies:development-0.3","ref":"development-0.3","sha":"62f424118707330ce0f132c9038546f0e290b5a1","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"name":"ml-agents","full_name":"Unity-Technologies/ml-agents","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2018-02-27T18:42:07Z","pushed_at":"2018-02-27T22:45:39Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":124575,"stargazers_count":2196,"watchers_count":2196,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":422,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":422,"open_issues":116,"watchers":2196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/367"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/367"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/dad53a5cf483bc55deb39992625d2a2bbf7d4618"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"eshvk"}}