{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/79","repository_url":"https://api.github.com/repos/Netflix/fast_jsonapi","labels_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/79/comments","events_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/79/events","html_url":"https://github.com/Netflix/fast_jsonapi/issues/79","id":296821198,"node_id":"MDU6SXNzdWUyOTY4MjExOTg=","number":79,"title":"Serializer Inheritance doesn't copy attributes","user":{"login":"eprothro","id":798287,"node_id":"MDQ6VXNlcjc5ODI4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/798287?v=4","gravatar_id":"","url":"https://api.github.com/users/eprothro","html_url":"https://github.com/eprothro","followers_url":"https://api.github.com/users/eprothro/followers","following_url":"https://api.github.com/users/eprothro/following{/other_user}","gists_url":"https://api.github.com/users/eprothro/gists{/gist_id}","starred_url":"https://api.github.com/users/eprothro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eprothro/subscriptions","organizations_url":"https://api.github.com/users/eprothro/orgs","repos_url":"https://api.github.com/users/eprothro/repos","events_url":"https://api.github.com/users/eprothro/events{/privacy}","received_events_url":"https://api.github.com/users/eprothro/received_events","type":"User","site_admin":false},"labels":[{"id":823103047,"node_id":"MDU6TGFiZWw4MjMxMDMwNDc=","url":"https://api.github.com/repos/Netflix/fast_jsonapi/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-13T17:25:36Z","updated_at":"2018-07-16T05:42:07Z","closed_at":"2018-05-21T00:33:36Z","author_association":"NONE","body":"It's not clear that the following won't work as might be expected:\r\n\r\n```\r\nclass UserSerializer\r\n  include FastJsonapi::ObjectSerializer\r\n\r\n  attribute :first_name\r\n  attribute :last_name\r\nend\r\n```\r\n```\r\nclass FullUserSerializer < UserSerializer\r\n\r\n  attribute :birthday\r\n  attribute :email\r\nend\r\n```\r\n\r\nWorkaround:\r\n\r\n```\r\nclass UserSerializer\r\n  include FastJsonapi::ObjectSerializer\r\n\r\n  def self.inherited(subclass)\r\n    subclass.attributes_to_serialize ||= {}\r\n    subclass.attributes_to_serialize.merge!(attributes_to_serialize)\r\n  end\r\n\r\n  attribute :first_name\r\n  attribute :last_name\r\nend\r\n```"},"comment":{"url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/comments/405153377","html_url":"https://github.com/Netflix/fast_jsonapi/issues/79#issuecomment-405153377","issue_url":"https://api.github.com/repos/Netflix/fast_jsonapi/issues/79","id":405153377,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTE1MzM3Nw==","user":{"login":"manojmj92","id":4034241,"node_id":"MDQ6VXNlcjQwMzQyNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/4034241?v=4","gravatar_id":"","url":"https://api.github.com/users/manojmj92","html_url":"https://github.com/manojmj92","followers_url":"https://api.github.com/users/manojmj92/followers","following_url":"https://api.github.com/users/manojmj92/following{/other_user}","gists_url":"https://api.github.com/users/manojmj92/gists{/gist_id}","starred_url":"https://api.github.com/users/manojmj92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manojmj92/subscriptions","organizations_url":"https://api.github.com/users/manojmj92/orgs","repos_url":"https://api.github.com/users/manojmj92/repos","events_url":"https://api.github.com/users/manojmj92/events{/privacy}","received_events_url":"https://api.github.com/users/manojmj92/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T05:42:07Z","updated_at":"2018-07-16T05:42:07Z","author_association":"NONE","body":"@shishirmk it would be nice if you can make this work for both `set_type` and `set_id`. I can work on this."}}
{"actor":{"display_login":"manojmj92"}}