{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/comments/195304304","pull_request_review_id":128643419,"id":195304304,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTMwNDMwNA==","diff_hunk":"@@ -23,16 +26,59 @@ export class ImputeTransformNode extends DataFlowNode {\n     return {signal: `sequence(${start}, ${stop}, ${step})`};\n   }\n \n-  public assemble(): VgImputeTransform {\n-    const {impute, key, keyvals, method, groupby, value} = this.transform;\n-    return {\n-      type: 'impute',\n-      field: impute,\n-      key,\n-      ...(keyvals ? {keyvals: isImputeSequence(keyvals) ? this.processSequence(keyvals) : keyvals}: {}),\n-      ...(method ? {method}: {}),\n-      ...(groupby ? {groupby}: {}),\n-      ...(value ? {value}: {})\n-    };\n+  public static makeFromTransform(parent: DataFlowNode, imputeTransform: ImputeTransform): ImputeTransformNode {\n+    return new ImputeTransformNode (parent, imputeTransform);\n+  }\n+\n+  public static makeFromEncoding(parent: DataFlowNode, model: UnitModel) {\n+    const transformRepresentation = normalizeimputeProperties(model.encoding);\n+    if (transformRepresentation === undefined) {\n+      return null;\n+    }\n+    return new ImputeTransformNode(parent, transformRepresentation);\n+  }\n+\n+  public assemble(): [VgImputeTransform] | [VgImputeTransform, VgWindowTransform, VgFormulaTransform] {\n+    const {impute, key, keyvals, method, groupby, value, frame} = this.transform;\n+    if (method !== 'value' && frame !== undefined) {\n+      const initialImpute: VgImputeTransform = {","path":"src/compile/data/impute.ts","position":58,"original_position":43,"commit_id":"08844a9f23a0eaa158969ebe538e7a841367de7c","original_commit_id":"08844a9f23a0eaa158969ebe538e7a841367de7c","user":{"login":"kanitw","id":111269,"node_id":"MDQ6VXNlcjExMTI2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/111269?v=4","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"Please confirm if you have played with this in Vega to see if we really need additonal impute. ","created_at":"2018-06-14T05:15:47Z","updated_at":"2018-06-14T06:03:24Z","html_url":"https://github.com/vega/vega-lite/pull/3881#discussion_r195304304","pull_request_url":"https://api.github.com/repos/vega/vega-lite/pulls/3881","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments/195304304"},"html":{"href":"https://github.com/vega/vega-lite/pull/3881#discussion_r195304304"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3881"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/3881","id":194705568,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzA1NTY4","html_url":"https://github.com/vega/vega-lite/pull/3881","diff_url":"https://github.com/vega/vega-lite/pull/3881.diff","patch_url":"https://github.com/vega/vega-lite/pull/3881.patch","issue_url":"https://api.github.com/repos/vega/vega-lite/issues/3881","number":3881,"state":"open","locked":false,"title":"Impute VL-specific features","user":{"login":"invokesus","id":16068737,"node_id":"MDQ6VXNlcjE2MDY4NzM3","avatar_url":"https://avatars3.githubusercontent.com/u/16068737?v=4","gravatar_id":"","url":"https://api.github.com/users/invokesus","html_url":"https://github.com/invokesus","followers_url":"https://api.github.com/users/invokesus/followers","following_url":"https://api.github.com/users/invokesus/following{/other_user}","gists_url":"https://api.github.com/users/invokesus/gists{/gist_id}","starred_url":"https://api.github.com/users/invokesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invokesus/subscriptions","organizations_url":"https://api.github.com/users/invokesus/orgs","repos_url":"https://api.github.com/users/invokesus/repos","events_url":"https://api.github.com/users/invokesus/events{/privacy}","received_events_url":"https://api.github.com/users/invokesus/received_events","type":"User","site_admin":false},"body":"- [X] `sequence` expression as `keyvals`\r\n- [X] `frame` property over which values are imputed\r\n- [X] `impute` property in Encoding.\r\n","created_at":"2018-06-13T20:28:15Z","updated_at":"2018-06-14T06:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"196b4c67f7e0aa0e5f00f21568b0a218aecbfefd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-lite/pulls/3881/commits","review_comments_url":"https://api.github.com/repos/vega/vega-lite/pulls/3881/comments","review_comment_url":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-lite/issues/3881/comments","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/08844a9f23a0eaa158969ebe538e7a841367de7c","head":{"label":"vega:inv/impute-vl-extras","ref":"inv/impute-vl-extras","sha":"08844a9f23a0eaa158969ebe538e7a841367de7c","user":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"node_id":"MDEwOlJlcG9zaXRvcnkyNjkzMTM1OQ==","name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A concise grammar of interactive graphics, built on Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2018-06-14T01:28:11Z","pushed_at":"2018-06-14T01:14:22Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":83638,"stargazers_count":1318,"watchers_count":1318,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":166,"open_issues":211,"watchers":1318,"default_branch":"master"}},"base":{"label":"vega:feature/transform","ref":"feature/transform","sha":"8e3291b41cfab10bd3d9de3098a739e16b7b522d","user":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"node_id":"MDEwOlJlcG9zaXRvcnkyNjkzMTM1OQ==","name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A concise grammar of interactive graphics, built on Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2018-06-14T01:28:11Z","pushed_at":"2018-06-14T01:14:22Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":83638,"stargazers_count":1318,"watchers_count":1318,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":166,"open_issues":211,"watchers":1318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3881"},"html":{"href":"https://github.com/vega/vega-lite/pull/3881"},"issue":{"href":"https://api.github.com/repos/vega/vega-lite/issues/3881"},"comments":{"href":"https://api.github.com/repos/vega/vega-lite/issues/3881/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3881/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3881/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-lite/statuses/08844a9f23a0eaa158969ebe538e7a841367de7c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kanitw"}}