{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/200600400","pull_request_review_id":134948097,"id":200600400,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDYwMDQwMA==","diff_hunk":"@@ -20,7 +20,14 @@ sub run {\n     # console but we never switched away, see\n     # logs_from_installation_system.pm, so we should be safe to ignore this\n     # call\n-    select_console 'installation' unless get_var('REMOTE_CONTROLLER');\n+    if (check_var('BACKEND', 'spvm')) {\n+        # this will only work for serial install\n+        select_console 'novalink-ssh', await_console => 0;\n+        assert_screen 'rebootnow';\n+    }\n+    else {\n+        select_console 'installation' unless get_var('REMOTE_CONTROLLER');","path":"tests/installation/reboot_after_installation.pm","position":11,"original_position":11,"commit_id":"e75961c30db8b20029d355f29dcaf4d7a64a38af","original_commit_id":"e75961c30db8b20029d355f29dcaf4d7a64a38af","user":{"login":"ldevulder","id":25102165,"node_id":"MDQ6VXNlcjI1MTAyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/25102165?v=4","gravatar_id":"","url":"https://api.github.com/users/ldevulder","html_url":"https://github.com/ldevulder","followers_url":"https://api.github.com/users/ldevulder/followers","following_url":"https://api.github.com/users/ldevulder/following{/other_user}","gists_url":"https://api.github.com/users/ldevulder/gists{/gist_id}","starred_url":"https://api.github.com/users/ldevulder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldevulder/subscriptions","organizations_url":"https://api.github.com/users/ldevulder/orgs","repos_url":"https://api.github.com/users/ldevulder/repos","events_url":"https://api.github.com/users/ldevulder/events{/privacy}","received_events_url":"https://api.github.com/users/ldevulder/received_events","type":"User","site_admin":false},"body":"Hmm, the \"bad\" thing here is that we don't use the more \"standard\" `'installation'` console like others backend do. That can lead to other issues in more complex tests.\r\n\r\nI'm partially able to use `'installation'` console on my local dev, but I have issue with the `first_boot'. i will have a look with all your new changes :-)","created_at":"2018-07-06T09:34:00Z","updated_at":"2018-07-06T09:34:08Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5272#discussion_r200600400","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/200600400"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5272#discussion_r200600400"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272","id":196439803,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDM5ODAz","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5272","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5272.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5272.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5272","number":5272,"state":"open","locked":false,"title":"[WIP] Add bootloader to start a novalink installation","user":{"login":"asdil12","id":725608,"node_id":"MDQ6VXNlcjcyNTYwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/725608?v=4","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"body":"See https://github.com/os-autoinst/os-autoinst/pull/979\r\n\r\nNeedles: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/877","created_at":"2018-06-21T12:45:46Z","updated_at":"2018-07-06T09:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2aa8800882f4e661ed4286c1caccfdab811ca813","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5272/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/e75961c30db8b20029d355f29dcaf4d7a64a38af","head":{"label":"asdil12:spvm","ref":"spvm","sha":"e75961c30db8b20029d355f29dcaf4d7a64a38af","user":{"login":"asdil12","id":725608,"node_id":"MDQ6VXNlcjcyNTYwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/725608?v=4","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"repo":{"id":18396178,"node_id":"MDEwOlJlcG9zaXRvcnkxODM5NjE3OA==","name":"os-autoinst-distri-opensuse","full_name":"asdil12/os-autoinst-distri-opensuse","owner":{"login":"asdil12","id":725608,"node_id":"MDQ6VXNlcjcyNTYwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/725608?v=4","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asdil12/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/asdil12/os-autoinst-distri-opensuse/deployments","created_at":"2014-04-03T08:29:47Z","updated_at":"2014-09-09T17:22:40Z","pushed_at":"2018-07-06T08:14:20Z","git_url":"git://github.com/asdil12/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:asdil12/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/asdil12/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/asdil12/os-autoinst-distri-opensuse","homepage":null,"size":90501,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"fa923bc27289ae53ddbb7433fa095e4ee9cba538","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-07-06T09:04:41Z","pushed_at":"2018-07-06T09:24:51Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":90957,"stargazers_count":30,"watchers_count":30,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":135,"open_issues":61,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/5272"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5272"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/5272/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/5272/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/e75961c30db8b20029d355f29dcaf4d7a64a38af"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ldevulder"}}