{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/173619095","pull_request_review_id":102847849,"id":173619095,"diff_hunk":"@@ -0,0 +1,40 @@\n+\n+#include <QObject>\n+#include <QLabel>\n+\n+#include \"Groove.h\"\n+#include \"lmms_basics.h\"\n+#include \"MidiTime.h\"\n+#include \"Note.h\"\n+#include \"Pattern.h\"\n+#include \"Song.h\"\n+\n+Groove::Groove()\n+{\n+}\n+\n+/*\n+ * Default groove is no groove. Not even a wiggle.\n+ * @return 0 or -1\n+ */\n+int Groove::isInTick(MidiTime * _cur_start, fpp_t _frames, f_cnt_t _offset,\n+\t\t\t\t\t\t Note * _n, Pattern * _p ) {\n+\n+\treturn _n->pos().getTicks() == _cur_start->getTicks() ? 0 : -1;","path":"src/core/Groove.cpp","position":23,"original_position":23,"commit_id":"957ec6b611af5abcc7a7822c7bbc3b8f3eec9240","original_commit_id":"957ec6b611af5abcc7a7822c7bbc3b8f3eec9240","user":{"login":"Wallacoloo","id":1210751,"avatar_url":"https://avatars0.githubusercontent.com/u/1210751?v=4","gravatar_id":"","url":"https://api.github.com/users/Wallacoloo","html_url":"https://github.com/Wallacoloo","followers_url":"https://api.github.com/users/Wallacoloo/followers","following_url":"https://api.github.com/users/Wallacoloo/following{/other_user}","gists_url":"https://api.github.com/users/Wallacoloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallacoloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallacoloo/subscriptions","organizations_url":"https://api.github.com/users/Wallacoloo/orgs","repos_url":"https://api.github.com/users/Wallacoloo/repos","events_url":"https://api.github.com/users/Wallacoloo/events{/privacy}","received_events_url":"https://api.github.com/users/Wallacoloo/received_events","type":"User","site_admin":false},"body":"Why return 0 and -1 instead of a bool?","created_at":"2018-03-10T10:56:09Z","updated_at":"2018-03-10T10:56:09Z","html_url":"https://github.com/LMMS/lmms/pull/4232#discussion_r173619095","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/4232","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/173619095"},"html":{"href":"https://github.com/LMMS/lmms/pull/4232#discussion_r173619095"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4232"}}},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/4232","id":174055560,"html_url":"https://github.com/LMMS/lmms/pull/4232","diff_url":"https://github.com/LMMS/lmms/pull/4232.diff","patch_url":"https://github.com/LMMS/lmms/pull/4232.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/4232","number":4232,"state":"open","locked":false,"title":"Global Groove Quantization","user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars0.githubusercontent.com/u/6345473?v=4","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"body":"![groove](https://user-images.githubusercontent.com/25503477/34153162-2cadbcb0-e4c2-11e7-9779-84cc33e766ce.png) ![studio controller](https://user-images.githubusercontent.com/25503477/34069858-90e4446a-e26a-11e7-8246-96e7a4fc5230.png)\r\n\r\nThis supersedes #3296, so there may be some contextual conversations there of importance.\r\n\r\nThis is an effort coded by @teknopaul but due to merge conflicts has been taken over by @Sawuare to make it into the 1.3.0 milestone.\r\n\r\nThis pull request illustrates \"groove quantizing\" the same \"swing\" feature that Hydrogen drum machine has. \r\nCurrently, there is one global swing amount that affects all instruments in a song. The ability to disable groove per track would be useful.\r\n\r\n**TODO**:\r\n- [ ] Complete the `TODO`s and `FIXME`s in the code.\r\n- [ ] Enable/disable groove per instrument track with an `LedCheckBox` in the MISC tab.\r\n- [ ] Move the groove window button near tempo and time signature controls.\r\n- [ ] Update the factory templates.\r\n\r\nCloses #1091.","created_at":"2018-03-09T16:55:42Z","updated_at":"2018-03-10T10:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fabbf477e348d570f06803a3197979a844db0be","assignee":{"login":"Sawuare","id":25503477,"avatar_url":"https://avatars1.githubusercontent.com/u/25503477?v=4","gravatar_id":"","url":"https://api.github.com/users/Sawuare","html_url":"https://github.com/Sawuare","followers_url":"https://api.github.com/users/Sawuare/followers","following_url":"https://api.github.com/users/Sawuare/following{/other_user}","gists_url":"https://api.github.com/users/Sawuare/gists{/gist_id}","starred_url":"https://api.github.com/users/Sawuare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sawuare/subscriptions","organizations_url":"https://api.github.com/users/Sawuare/orgs","repos_url":"https://api.github.com/users/Sawuare/repos","events_url":"https://api.github.com/users/Sawuare/events{/privacy}","received_events_url":"https://api.github.com/users/Sawuare/received_events","type":"User","site_admin":false},"assignees":[{"login":"Sawuare","id":25503477,"avatar_url":"https://avatars1.githubusercontent.com/u/25503477?v=4","gravatar_id":"","url":"https://api.github.com/users/Sawuare","html_url":"https://github.com/Sawuare","followers_url":"https://api.github.com/users/Sawuare/followers","following_url":"https://api.github.com/users/Sawuare/following{/other_user}","gists_url":"https://api.github.com/users/Sawuare/gists{/gist_id}","starred_url":"https://api.github.com/users/Sawuare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sawuare/subscriptions","organizations_url":"https://api.github.com/users/Sawuare/orgs","repos_url":"https://api.github.com/users/Sawuare/repos","events_url":"https://api.github.com/users/Sawuare/events{/privacy}","received_events_url":"https://api.github.com/users/Sawuare/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":74198045,"url":"https://api.github.com/repos/LMMS/lmms/labels/enhancement","name":"enhancement","color":"0052cc","default":true},{"id":322422033,"url":"https://api.github.com/repos/LMMS/lmms/labels/in%20progress","name":"in progress","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/LMMS/lmms/milestones/4","html_url":"https://github.com/LMMS/lmms/milestone/4","labels_url":"https://api.github.com/repos/LMMS/lmms/milestones/4/labels","id":614544,"number":4,"title":"1.3.0","description":"","creator":{"login":"diizy","id":6368868,"avatar_url":"https://avatars3.githubusercontent.com/u/6368868?v=4","gravatar_id":"","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"open_issues":108,"closed_issues":49,"state":"open","created_at":"2014-03-30T19:00:44Z","updated_at":"2018-03-09T16:56:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/4232/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/4232/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/4232/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/957ec6b611af5abcc7a7822c7bbc3b8f3eec9240","head":{"label":"LMMS:groove","ref":"groove","sha":"957ec6b611af5abcc7a7822c7bbc3b8f3eec9240","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars0.githubusercontent.com/u/6363159?v=4","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars0.githubusercontent.com/u/6363159?v=4","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"Cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/LMMS/lmms/deployments","created_at":"2014-01-09T20:43:43Z","updated_at":"2018-03-09T09:27:11Z","pushed_at":"2018-03-10T08:29:24Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"https://lmms.io/","size":78630,"stargazers_count":1779,"watchers_count":1779,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":379,"mirror_url":null,"archived":false,"open_issues_count":743,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":379,"open_issues":743,"watchers":1779,"default_branch":"stable-1.2"}},"base":{"label":"LMMS:master","ref":"master","sha":"d2c370a95396ca47cb200348def9d5f7c6237c08","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars0.githubusercontent.com/u/6363159?v=4","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars0.githubusercontent.com/u/6363159?v=4","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"Cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/LMMS/lmms/deployments","created_at":"2014-01-09T20:43:43Z","updated_at":"2018-03-09T09:27:11Z","pushed_at":"2018-03-10T08:29:24Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"https://lmms.io/","size":78630,"stargazers_count":1779,"watchers_count":1779,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":379,"mirror_url":null,"archived":false,"open_issues_count":743,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":379,"open_issues":743,"watchers":1779,"default_branch":"stable-1.2"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4232"},"html":{"href":"https://github.com/LMMS/lmms/pull/4232"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/4232"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/4232/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4232/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4232/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/957ec6b611af5abcc7a7822c7bbc3b8f3eec9240"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Wallacoloo"}}