{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1704","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1704/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1704/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1704/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1704","id":329637473,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODQ1OTg3","number":1704,"title":"Skins :: hidden waveform cpu fix lp1758660","user":{"login":"ronso0","id":5934199,"node_id":"MDQ6VXNlcjU5MzQxOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5934199?v=4","gravatar_id":"","url":"https://api.github.com/users/ronso0","html_url":"https://github.com/ronso0","followers_url":"https://api.github.com/users/ronso0/followers","following_url":"https://api.github.com/users/ronso0/following{/other_user}","gists_url":"https://api.github.com/users/ronso0/gists{/gist_id}","starred_url":"https://api.github.com/users/ronso0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronso0/subscriptions","organizations_url":"https://api.github.com/users/ronso0/orgs","repos_url":"https://api.github.com/users/ronso0/repos","events_url":"https://api.github.com/users/ronso0/events{/privacy}","received_events_url":"https://api.github.com/users/ronso0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-05T21:48:18Z","updated_at":"2018-06-06T12:36:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1704","html_url":"https://github.com/mixxxdj/mixxx/pull/1704","diff_url":"https://github.com/mixxxdj/mixxx/pull/1704.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1704.patch"},"body":"As noone tried to fix [lp1758660 \"GUI lag with hidden waveforms in Tango & Deere, using integrated Intel graphics \"](https://bugs.launchpad.net/mixxx/+bug/1758660) in C++ so far, I tried a hack in the skins themselves.\r\n\r\n**Deere/LateNight**\r\nWaveforms container can't be collapsed anymore, but minimized to 1px. Waveforms aren't visible/scratchable then, it's just a 1px spacer.\r\n\r\n**Tango**\r\nIf hidden by topbar toggle, the waveforms are positioned at the top-left corner of the skin. Here as well, the actual waveforms aren't visible because they're just 1x1px.\r\n\r\nAt first I posted skin ZIPs in the bug conversation on launchpad, and @sohet confirmed the fixes is working for him in Tango.\r\nI applied similiar fixes to Deere and LateNight.\r\nIf you have an **Intel graphics card**, please test this.\r\n\r\nIf this works it would be nice if it would make it into 2.1.1"},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/395053046","html_url":"https://github.com/mixxxdj/mixxx/pull/1704#issuecomment-395053046","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1704","id":395053046,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTA1MzA0Ng==","user":{"login":"ronso0","id":5934199,"node_id":"MDQ6VXNlcjU5MzQxOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5934199?v=4","gravatar_id":"","url":"https://api.github.com/users/ronso0","html_url":"https://github.com/ronso0","followers_url":"https://api.github.com/users/ronso0/followers","following_url":"https://api.github.com/users/ronso0/following{/other_user}","gists_url":"https://api.github.com/users/ronso0/gists{/gist_id}","starred_url":"https://api.github.com/users/ronso0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronso0/subscriptions","organizations_url":"https://api.github.com/users/ronso0/orgs","repos_url":"https://api.github.com/users/ronso0/repos","events_url":"https://api.github.com/users/ronso0/events{/privacy}","received_events_url":"https://api.github.com/users/ronso0/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T12:36:56Z","updated_at":"2018-06-06T12:36:56Z","author_association":"CONTRIBUTOR","body":"aargh, log spamming from #1512 is back. CPU usage is the same with/without waveforms...\r\n```\r\nWarning [Main]: QPainter::begin: Paint device returned engine == 0, type: 3\r\nWarning [Main]: QPainter::setRenderHint: Painter must be active to set rendering hints\r\nWarning [Main]: QPainter::setMatrixEnabled: Painter not active\r\nWarning [Main]: QPainter::setPen: Painter not active\r\nWarning [Main]: QPainter::setBrush: Painter not active\r\nWarning [Main]: QPainter::setBrush: Painter not active\r\nWarning [Main]: QPainter::setFont: Painter not active\r\nWarning [Main]: QPainter::setPen: Painter not active\r\nWarning [Main]: QPainter::begin: Paint device returned engine == 0, type: 3\r\nWarning [Main]: QPainter::setRenderHint: Painter must be active to set rendering hints\r\n```\r\n\r\nAlso I squashed the previous 6 commits."}}
{"actor":{"display_login":"ronso0"}}