{"action":"created","comment":{"url":"https://api.github.com/repos/skydive-project/skydive/pulls/comments/210582489","pull_request_review_id":146826951,"id":210582489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDU4MjQ4OQ==","diff_hunk":"@@ -78,19 +134,46 @@ func (p *serviceProbe) OnDelete(obj interface{}) {\n \t\tp.graph.Lock()\n \t\tdefer p.graph.Unlock()\n \n-\t\tif nsNode := p.graph.GetNode(serviceUID(srv)); nsNode != nil {\n-\t\t\tp.graph.DelNode(nsNode)\n+\t\tif srvNode := p.graph.GetNode(serviceUID(srv)); srvNode != nil {\n+\t\t\tp.graph.DelNode(srvNode)\n \t\t\tlogging.GetLogger().Debugf(\"Deleted %s\", dumpService(srv))\n \t\t}\n \t}\n }\n \n+func (p *serviceProbe) onNodeUpdated(podNode *graph.Node) {","path":"topology/probes/k8s/service.go","position":120,"original_position":120,"commit_id":"a517d4ba453174eca4e0b22d318cf4ac43d18b0b","original_commit_id":"a517d4ba453174eca4e0b22d318cf4ac43d18b0b","user":{"login":"hunchback","id":2760739,"node_id":"MDQ6VXNlcjI3NjA3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2760739?v=4","gravatar_id":"","url":"https://api.github.com/users/hunchback","html_url":"https://github.com/hunchback","followers_url":"https://api.github.com/users/hunchback/followers","following_url":"https://api.github.com/users/hunchback/following{/other_user}","gists_url":"https://api.github.com/users/hunchback/gists{/gist_id}","starred_url":"https://api.github.com/users/hunchback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunchback/subscriptions","organizations_url":"https://api.github.com/users/hunchback/orgs","repos_url":"https://api.github.com/users/hunchback/repos","events_url":"https://api.github.com/users/hunchback/events{/privacy}","received_events_url":"https://api.github.com/users/hunchback/received_events","type":"User","site_admin":false},"body":"But deletion is handled anyway: https://github.com/skydive-project/skydive/blob/master/topology/graph/graph.go#L1298","created_at":"2018-08-16T12:52:20Z","updated_at":"2018-08-16T12:52:20Z","html_url":"https://github.com/skydive-project/skydive/pull/1251#discussion_r210582489","pull_request_url":"https://api.github.com/repos/skydive-project/skydive/pulls/1251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/comments/210582489"},"html":{"href":"https://github.com/skydive-project/skydive/pull/1251#discussion_r210582489"},"pull_request":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1251"}},"in_reply_to_id":210577776},"pull_request":{"url":"https://api.github.com/repos/skydive-project/skydive/pulls/1251","id":208422498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDIyNDk4","html_url":"https://github.com/skydive-project/skydive/pull/1251","diff_url":"https://github.com/skydive-project/skydive/pull/1251.diff","patch_url":"https://github.com/skydive-project/skydive/pull/1251.patch","issue_url":"https://api.github.com/repos/skydive-project/skydive/issues/1251","number":1251,"state":"open","locked":false,"title":"K8s service links","user":{"login":"hunchback","id":2760739,"node_id":"MDQ6VXNlcjI3NjA3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2760739?v=4","gravatar_id":"","url":"https://api.github.com/users/hunchback","html_url":"https://github.com/hunchback","followers_url":"https://api.github.com/users/hunchback/followers","following_url":"https://api.github.com/users/hunchback/following{/other_user}","gists_url":"https://api.github.com/users/hunchback/gists{/gist_id}","starred_url":"https://api.github.com/users/hunchback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunchback/subscriptions","organizations_url":"https://api.github.com/users/hunchback/orgs","repos_url":"https://api.github.com/users/hunchback/repos","events_url":"https://api.github.com/users/hunchback/events{/privacy}","received_events_url":"https://api.github.com/users/hunchback/received_events","type":"User","site_admin":false},"body":"create links between `service` to `pod`, can be tested running:\r\n\r\n```\r\nkubectl create -f tests/k8s/service-pod.yaml\r\n```\r\n\r\n*NOTE*: depends on https://github.com/skydive-project/skydive/pull/1241","created_at":"2018-08-14T21:58:14Z","updated_at":"2018-08-16T12:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a2a278d396d4fe788c00e30a4f1fe3197a21508","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skydive-project/skydive/pulls/1251/commits","review_comments_url":"https://api.github.com/repos/skydive-project/skydive/pulls/1251/comments","review_comment_url":"https://api.github.com/repos/skydive-project/skydive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skydive-project/skydive/issues/1251/comments","statuses_url":"https://api.github.com/repos/skydive-project/skydive/statuses/a517d4ba453174eca4e0b22d318cf4ac43d18b0b","head":{"label":"hunchback:k8s-service-links","ref":"k8s-service-links","sha":"a517d4ba453174eca4e0b22d318cf4ac43d18b0b","user":{"login":"hunchback","id":2760739,"node_id":"MDQ6VXNlcjI3NjA3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2760739?v=4","gravatar_id":"","url":"https://api.github.com/users/hunchback","html_url":"https://github.com/hunchback","followers_url":"https://api.github.com/users/hunchback/followers","following_url":"https://api.github.com/users/hunchback/following{/other_user}","gists_url":"https://api.github.com/users/hunchback/gists{/gist_id}","starred_url":"https://api.github.com/users/hunchback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunchback/subscriptions","organizations_url":"https://api.github.com/users/hunchback/orgs","repos_url":"https://api.github.com/users/hunchback/repos","events_url":"https://api.github.com/users/hunchback/events{/privacy}","received_events_url":"https://api.github.com/users/hunchback/received_events","type":"User","site_admin":false},"repo":{"id":108723302,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg3MjMzMDI=","name":"skydive","full_name":"hunchback/skydive","owner":{"login":"hunchback","id":2760739,"node_id":"MDQ6VXNlcjI3NjA3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2760739?v=4","gravatar_id":"","url":"https://api.github.com/users/hunchback","html_url":"https://github.com/hunchback","followers_url":"https://api.github.com/users/hunchback/followers","following_url":"https://api.github.com/users/hunchback/following{/other_user}","gists_url":"https://api.github.com/users/hunchback/gists{/gist_id}","starred_url":"https://api.github.com/users/hunchback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunchback/subscriptions","organizations_url":"https://api.github.com/users/hunchback/orgs","repos_url":"https://api.github.com/users/hunchback/repos","events_url":"https://api.github.com/users/hunchback/events{/privacy}","received_events_url":"https://api.github.com/users/hunchback/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hunchback/skydive","description":"An open source real-time network topology and protocols analyzer","fork":true,"url":"https://api.github.com/repos/hunchback/skydive","forks_url":"https://api.github.com/repos/hunchback/skydive/forks","keys_url":"https://api.github.com/repos/hunchback/skydive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hunchback/skydive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hunchback/skydive/teams","hooks_url":"https://api.github.com/repos/hunchback/skydive/hooks","issue_events_url":"https://api.github.com/repos/hunchback/skydive/issues/events{/number}","events_url":"https://api.github.com/repos/hunchback/skydive/events","assignees_url":"https://api.github.com/repos/hunchback/skydive/assignees{/user}","branches_url":"https://api.github.com/repos/hunchback/skydive/branches{/branch}","tags_url":"https://api.github.com/repos/hunchback/skydive/tags","blobs_url":"https://api.github.com/repos/hunchback/skydive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hunchback/skydive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hunchback/skydive/git/refs{/sha}","trees_url":"https://api.github.com/repos/hunchback/skydive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hunchback/skydive/statuses/{sha}","languages_url":"https://api.github.com/repos/hunchback/skydive/languages","stargazers_url":"https://api.github.com/repos/hunchback/skydive/stargazers","contributors_url":"https://api.github.com/repos/hunchback/skydive/contributors","subscribers_url":"https://api.github.com/repos/hunchback/skydive/subscribers","subscription_url":"https://api.github.com/repos/hunchback/skydive/subscription","commits_url":"https://api.github.com/repos/hunchback/skydive/commits{/sha}","git_commits_url":"https://api.github.com/repos/hunchback/skydive/git/commits{/sha}","comments_url":"https://api.github.com/repos/hunchback/skydive/comments{/number}","issue_comment_url":"https://api.github.com/repos/hunchback/skydive/issues/comments{/number}","contents_url":"https://api.github.com/repos/hunchback/skydive/contents/{+path}","compare_url":"https://api.github.com/repos/hunchback/skydive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hunchback/skydive/merges","archive_url":"https://api.github.com/repos/hunchback/skydive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hunchback/skydive/downloads","issues_url":"https://api.github.com/repos/hunchback/skydive/issues{/number}","pulls_url":"https://api.github.com/repos/hunchback/skydive/pulls{/number}","milestones_url":"https://api.github.com/repos/hunchback/skydive/milestones{/number}","notifications_url":"https://api.github.com/repos/hunchback/skydive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hunchback/skydive/labels{/name}","releases_url":"https://api.github.com/repos/hunchback/skydive/releases{/id}","deployments_url":"https://api.github.com/repos/hunchback/skydive/deployments","created_at":"2017-10-29T10:07:17Z","updated_at":"2017-10-29T10:07:19Z","pushed_at":"2018-08-16T07:28:54Z","git_url":"git://github.com/hunchback/skydive.git","ssh_url":"git@github.com:hunchback/skydive.git","clone_url":"https://github.com/hunchback/skydive.git","svn_url":"https://github.com/hunchback/skydive","homepage":"","size":17293,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skydive-project:master","ref":"master","sha":"d1fc318d7a7a04432dbde87f7a7989fdf48cdd6d","user":{"login":"skydive-project","id":19912486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyNDg2","avatar_url":"https://avatars0.githubusercontent.com/u/19912486?v=4","gravatar_id":"","url":"https://api.github.com/users/skydive-project","html_url":"https://github.com/skydive-project","followers_url":"https://api.github.com/users/skydive-project/followers","following_url":"https://api.github.com/users/skydive-project/following{/other_user}","gists_url":"https://api.github.com/users/skydive-project/gists{/gist_id}","starred_url":"https://api.github.com/users/skydive-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skydive-project/subscriptions","organizations_url":"https://api.github.com/users/skydive-project/orgs","repos_url":"https://api.github.com/users/skydive-project/repos","events_url":"https://api.github.com/users/skydive-project/events{/privacy}","received_events_url":"https://api.github.com/users/skydive-project/received_events","type":"Organization","site_admin":false},"repo":{"id":44610195,"node_id":"MDEwOlJlcG9zaXRvcnk0NDYxMDE5NQ==","name":"skydive","full_name":"skydive-project/skydive","owner":{"login":"skydive-project","id":19912486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyNDg2","avatar_url":"https://avatars0.githubusercontent.com/u/19912486?v=4","gravatar_id":"","url":"https://api.github.com/users/skydive-project","html_url":"https://github.com/skydive-project","followers_url":"https://api.github.com/users/skydive-project/followers","following_url":"https://api.github.com/users/skydive-project/following{/other_user}","gists_url":"https://api.github.com/users/skydive-project/gists{/gist_id}","starred_url":"https://api.github.com/users/skydive-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skydive-project/subscriptions","organizations_url":"https://api.github.com/users/skydive-project/orgs","repos_url":"https://api.github.com/users/skydive-project/repos","events_url":"https://api.github.com/users/skydive-project/events{/privacy}","received_events_url":"https://api.github.com/users/skydive-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skydive-project/skydive","description":"An open source real-time network topology and protocols analyzer","fork":false,"url":"https://api.github.com/repos/skydive-project/skydive","forks_url":"https://api.github.com/repos/skydive-project/skydive/forks","keys_url":"https://api.github.com/repos/skydive-project/skydive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skydive-project/skydive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skydive-project/skydive/teams","hooks_url":"https://api.github.com/repos/skydive-project/skydive/hooks","issue_events_url":"https://api.github.com/repos/skydive-project/skydive/issues/events{/number}","events_url":"https://api.github.com/repos/skydive-project/skydive/events","assignees_url":"https://api.github.com/repos/skydive-project/skydive/assignees{/user}","branches_url":"https://api.github.com/repos/skydive-project/skydive/branches{/branch}","tags_url":"https://api.github.com/repos/skydive-project/skydive/tags","blobs_url":"https://api.github.com/repos/skydive-project/skydive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skydive-project/skydive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skydive-project/skydive/git/refs{/sha}","trees_url":"https://api.github.com/repos/skydive-project/skydive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skydive-project/skydive/statuses/{sha}","languages_url":"https://api.github.com/repos/skydive-project/skydive/languages","stargazers_url":"https://api.github.com/repos/skydive-project/skydive/stargazers","contributors_url":"https://api.github.com/repos/skydive-project/skydive/contributors","subscribers_url":"https://api.github.com/repos/skydive-project/skydive/subscribers","subscription_url":"https://api.github.com/repos/skydive-project/skydive/subscription","commits_url":"https://api.github.com/repos/skydive-project/skydive/commits{/sha}","git_commits_url":"https://api.github.com/repos/skydive-project/skydive/git/commits{/sha}","comments_url":"https://api.github.com/repos/skydive-project/skydive/comments{/number}","issue_comment_url":"https://api.github.com/repos/skydive-project/skydive/issues/comments{/number}","contents_url":"https://api.github.com/repos/skydive-project/skydive/contents/{+path}","compare_url":"https://api.github.com/repos/skydive-project/skydive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skydive-project/skydive/merges","archive_url":"https://api.github.com/repos/skydive-project/skydive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skydive-project/skydive/downloads","issues_url":"https://api.github.com/repos/skydive-project/skydive/issues{/number}","pulls_url":"https://api.github.com/repos/skydive-project/skydive/pulls{/number}","milestones_url":"https://api.github.com/repos/skydive-project/skydive/milestones{/number}","notifications_url":"https://api.github.com/repos/skydive-project/skydive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skydive-project/skydive/labels{/name}","releases_url":"https://api.github.com/repos/skydive-project/skydive/releases{/id}","deployments_url":"https://api.github.com/repos/skydive-project/skydive/deployments","created_at":"2015-10-20T14:02:21Z","updated_at":"2018-08-16T12:48:44Z","pushed_at":"2018-08-16T10:22:52Z","git_url":"git://github.com/skydive-project/skydive.git","ssh_url":"git@github.com:skydive-project/skydive.git","clone_url":"https://github.com/skydive-project/skydive.git","svn_url":"https://github.com/skydive-project/skydive","homepage":"","size":37673,"stargazers_count":742,"watchers_count":742,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":159,"open_issues":94,"watchers":742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1251"},"html":{"href":"https://github.com/skydive-project/skydive/pull/1251"},"issue":{"href":"https://api.github.com/repos/skydive-project/skydive/issues/1251"},"comments":{"href":"https://api.github.com/repos/skydive-project/skydive/issues/1251/comments"},"review_comments":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1251/comments"},"review_comment":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skydive-project/skydive/pulls/1251/commits"},"statuses":{"href":"https://api.github.com/repos/skydive-project/skydive/statuses/a517d4ba453174eca4e0b22d318cf4ac43d18b0b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hunchback"}}