{"action":"created","comment":{"url":"https://api.github.com/repos/librecores/librecores-web/pulls/comments/193641149","pull_request_review_id":126651522,"id":193641149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzY0MTE0OQ==","diff_hunk":"@@ -44,12 +46,12 @@ public function newAction(Request $request)\n \n         // construct choices for the owner\n         $username = $this->getUser()->getUsername();\n-        $parentChoices = array($username => 'u_' . $username);\n+        $parentChoices = array($username => 'u_'.$username);\n         foreach ($this->getUser()->getOrganizationMemberships() as $organizationMembership) {\n             if ($organizationMembership->getPermission() === OrganizationMember::PERMISSION_MEMBER or","path":"site/src/Librecores/ProjectRepoBundle/Controller/ProjectController.php","position":17,"original_position":17,"commit_id":"5ed10d9cb5917b0040aa8edcf84803436314660d","original_commit_id":"5ed10d9cb5917b0040aa8edcf84803436314660d","user":{"login":"agathver","id":16816719,"node_id":"MDQ6VXNlcjE2ODE2NzE5","avatar_url":"https://avatars2.githubusercontent.com/u/16816719?v=4","gravatar_id":"","url":"https://api.github.com/users/agathver","html_url":"https://github.com/agathver","followers_url":"https://api.github.com/users/agathver/followers","following_url":"https://api.github.com/users/agathver/following{/other_user}","gists_url":"https://api.github.com/users/agathver/gists{/gist_id}","starred_url":"https://api.github.com/users/agathver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agathver/subscriptions","organizations_url":"https://api.github.com/users/agathver/orgs","repos_url":"https://api.github.com/users/agathver/repos","events_url":"https://api.github.com/users/agathver/events{/privacy}","received_events_url":"https://api.github.com/users/agathver/received_events","type":"User","site_admin":false},"body":"There appears to be a difference between `and`,`or` and `&&',`||`. Let's standardize on what to use.\r\n\r\nhttp://php.net/manual/en/language.operators.logical.php","created_at":"2018-06-07T06:50:33Z","updated_at":"2018-06-07T06:50:33Z","html_url":"https://github.com/librecores/librecores-web/pull/241#discussion_r193641149","pull_request_url":"https://api.github.com/repos/librecores/librecores-web/pulls/241","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/librecores/librecores-web/pulls/comments/193641149"},"html":{"href":"https://github.com/librecores/librecores-web/pull/241#discussion_r193641149"},"pull_request":{"href":"https://api.github.com/repos/librecores/librecores-web/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/librecores/librecores-web/pulls/241","id":193165692,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTY1Njky","html_url":"https://github.com/librecores/librecores-web/pull/241","diff_url":"https://github.com/librecores/librecores-web/pull/241.diff","patch_url":"https://github.com/librecores/librecores-web/pull/241.patch","issue_url":"https://api.github.com/repos/librecores/librecores-web/issues/241","number":241,"state":"open","locked":false,"title":"Php coding style","user":{"login":"imphil","id":1467123,"node_id":"MDQ6VXNlcjE0NjcxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1467123?v=4","gravatar_id":"","url":"https://api.github.com/users/imphil","html_url":"https://github.com/imphil","followers_url":"https://api.github.com/users/imphil/followers","following_url":"https://api.github.com/users/imphil/following{/other_user}","gists_url":"https://api.github.com/users/imphil/gists{/gist_id}","starred_url":"https://api.github.com/users/imphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imphil/subscriptions","organizations_url":"https://api.github.com/users/imphil/orgs","repos_url":"https://api.github.com/users/imphil/repos","events_url":"https://api.github.com/users/imphil/events{/privacy}","received_events_url":"https://api.github.com/users/imphil/received_events","type":"User","site_admin":false},"body":"This adds a phpcs configuration to the Symfony project and configures it with our style. I had to go through a lot of code (some manually, some is auto-fixed) to make sure we have a clean run as a base. I'm not particularly fond of the multi-line string splitting that the Symfony/PSR-2 style enforces, but it#s not ugly enough to care too much about it, so I've fixed the relevant occurrences to conform to the style.\r\n\r\nShould fix #159\r\n\r\n@agathver Could you have a look if you have time? With such an amount of changes it's easy to miss something.","created_at":"2018-06-06T23:15:17Z","updated_at":"2018-06-07T06:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"256d7bca074a02cbd06f95bd727f759a887e0fd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/librecores/librecores-web/pulls/241/commits","review_comments_url":"https://api.github.com/repos/librecores/librecores-web/pulls/241/comments","review_comment_url":"https://api.github.com/repos/librecores/librecores-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librecores/librecores-web/issues/241/comments","statuses_url":"https://api.github.com/repos/librecores/librecores-web/statuses/5ed10d9cb5917b0040aa8edcf84803436314660d","head":{"label":"librecores:php-coding-style","ref":"php-coding-style","sha":"5ed10d9cb5917b0040aa8edcf84803436314660d","user":{"login":"librecores","id":10119298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTE5Mjk4","avatar_url":"https://avatars1.githubusercontent.com/u/10119298?v=4","gravatar_id":"","url":"https://api.github.com/users/librecores","html_url":"https://github.com/librecores","followers_url":"https://api.github.com/users/librecores/followers","following_url":"https://api.github.com/users/librecores/following{/other_user}","gists_url":"https://api.github.com/users/librecores/gists{/gist_id}","starred_url":"https://api.github.com/users/librecores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librecores/subscriptions","organizations_url":"https://api.github.com/users/librecores/orgs","repos_url":"https://api.github.com/users/librecores/repos","events_url":"https://api.github.com/users/librecores/events{/privacy}","received_events_url":"https://api.github.com/users/librecores/received_events","type":"Organization","site_admin":false},"repo":{"id":31414037,"node_id":"MDEwOlJlcG9zaXRvcnkzMTQxNDAzNw==","name":"librecores-web","full_name":"librecores/librecores-web","owner":{"login":"librecores","id":10119298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTE5Mjk4","avatar_url":"https://avatars1.githubusercontent.com/u/10119298?v=4","gravatar_id":"","url":"https://api.github.com/users/librecores","html_url":"https://github.com/librecores","followers_url":"https://api.github.com/users/librecores/followers","following_url":"https://api.github.com/users/librecores/following{/other_user}","gists_url":"https://api.github.com/users/librecores/gists{/gist_id}","starred_url":"https://api.github.com/users/librecores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librecores/subscriptions","organizations_url":"https://api.github.com/users/librecores/orgs","repos_url":"https://api.github.com/users/librecores/repos","events_url":"https://api.github.com/users/librecores/events{/privacy}","received_events_url":"https://api.github.com/users/librecores/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librecores/librecores-web","description":"LibreCores Web Site","fork":false,"url":"https://api.github.com/repos/librecores/librecores-web","forks_url":"https://api.github.com/repos/librecores/librecores-web/forks","keys_url":"https://api.github.com/repos/librecores/librecores-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librecores/librecores-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librecores/librecores-web/teams","hooks_url":"https://api.github.com/repos/librecores/librecores-web/hooks","issue_events_url":"https://api.github.com/repos/librecores/librecores-web/issues/events{/number}","events_url":"https://api.github.com/repos/librecores/librecores-web/events","assignees_url":"https://api.github.com/repos/librecores/librecores-web/assignees{/user}","branches_url":"https://api.github.com/repos/librecores/librecores-web/branches{/branch}","tags_url":"https://api.github.com/repos/librecores/librecores-web/tags","blobs_url":"https://api.github.com/repos/librecores/librecores-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librecores/librecores-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librecores/librecores-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/librecores/librecores-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librecores/librecores-web/statuses/{sha}","languages_url":"https://api.github.com/repos/librecores/librecores-web/languages","stargazers_url":"https://api.github.com/repos/librecores/librecores-web/stargazers","contributors_url":"https://api.github.com/repos/librecores/librecores-web/contributors","subscribers_url":"https://api.github.com/repos/librecores/librecores-web/subscribers","subscription_url":"https://api.github.com/repos/librecores/librecores-web/subscription","commits_url":"https://api.github.com/repos/librecores/librecores-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/librecores/librecores-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/librecores/librecores-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/librecores/librecores-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/librecores/librecores-web/contents/{+path}","compare_url":"https://api.github.com/repos/librecores/librecores-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librecores/librecores-web/merges","archive_url":"https://api.github.com/repos/librecores/librecores-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librecores/librecores-web/downloads","issues_url":"https://api.github.com/repos/librecores/librecores-web/issues{/number}","pulls_url":"https://api.github.com/repos/librecores/librecores-web/pulls{/number}","milestones_url":"https://api.github.com/repos/librecores/librecores-web/milestones{/number}","notifications_url":"https://api.github.com/repos/librecores/librecores-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librecores/librecores-web/labels{/name}","releases_url":"https://api.github.com/repos/librecores/librecores-web/releases{/id}","deployments_url":"https://api.github.com/repos/librecores/librecores-web/deployments","created_at":"2015-02-27T10:16:23Z","updated_at":"2018-05-30T04:52:16Z","pushed_at":"2018-06-06T23:15:17Z","git_url":"git://github.com/librecores/librecores-web.git","ssh_url":"git@github.com:librecores/librecores-web.git","clone_url":"https://github.com/librecores/librecores-web.git","svn_url":"https://github.com/librecores/librecores-web","homepage":"https://www.librecores.org/","size":9045,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":75,"watchers":19,"default_branch":"master"}},"base":{"label":"librecores:master","ref":"master","sha":"252d678ad6e112ee0c3be64c69b35ade245f304f","user":{"login":"librecores","id":10119298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTE5Mjk4","avatar_url":"https://avatars1.githubusercontent.com/u/10119298?v=4","gravatar_id":"","url":"https://api.github.com/users/librecores","html_url":"https://github.com/librecores","followers_url":"https://api.github.com/users/librecores/followers","following_url":"https://api.github.com/users/librecores/following{/other_user}","gists_url":"https://api.github.com/users/librecores/gists{/gist_id}","starred_url":"https://api.github.com/users/librecores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librecores/subscriptions","organizations_url":"https://api.github.com/users/librecores/orgs","repos_url":"https://api.github.com/users/librecores/repos","events_url":"https://api.github.com/users/librecores/events{/privacy}","received_events_url":"https://api.github.com/users/librecores/received_events","type":"Organization","site_admin":false},"repo":{"id":31414037,"node_id":"MDEwOlJlcG9zaXRvcnkzMTQxNDAzNw==","name":"librecores-web","full_name":"librecores/librecores-web","owner":{"login":"librecores","id":10119298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTE5Mjk4","avatar_url":"https://avatars1.githubusercontent.com/u/10119298?v=4","gravatar_id":"","url":"https://api.github.com/users/librecores","html_url":"https://github.com/librecores","followers_url":"https://api.github.com/users/librecores/followers","following_url":"https://api.github.com/users/librecores/following{/other_user}","gists_url":"https://api.github.com/users/librecores/gists{/gist_id}","starred_url":"https://api.github.com/users/librecores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librecores/subscriptions","organizations_url":"https://api.github.com/users/librecores/orgs","repos_url":"https://api.github.com/users/librecores/repos","events_url":"https://api.github.com/users/librecores/events{/privacy}","received_events_url":"https://api.github.com/users/librecores/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librecores/librecores-web","description":"LibreCores Web Site","fork":false,"url":"https://api.github.com/repos/librecores/librecores-web","forks_url":"https://api.github.com/repos/librecores/librecores-web/forks","keys_url":"https://api.github.com/repos/librecores/librecores-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librecores/librecores-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librecores/librecores-web/teams","hooks_url":"https://api.github.com/repos/librecores/librecores-web/hooks","issue_events_url":"https://api.github.com/repos/librecores/librecores-web/issues/events{/number}","events_url":"https://api.github.com/repos/librecores/librecores-web/events","assignees_url":"https://api.github.com/repos/librecores/librecores-web/assignees{/user}","branches_url":"https://api.github.com/repos/librecores/librecores-web/branches{/branch}","tags_url":"https://api.github.com/repos/librecores/librecores-web/tags","blobs_url":"https://api.github.com/repos/librecores/librecores-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librecores/librecores-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librecores/librecores-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/librecores/librecores-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librecores/librecores-web/statuses/{sha}","languages_url":"https://api.github.com/repos/librecores/librecores-web/languages","stargazers_url":"https://api.github.com/repos/librecores/librecores-web/stargazers","contributors_url":"https://api.github.com/repos/librecores/librecores-web/contributors","subscribers_url":"https://api.github.com/repos/librecores/librecores-web/subscribers","subscription_url":"https://api.github.com/repos/librecores/librecores-web/subscription","commits_url":"https://api.github.com/repos/librecores/librecores-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/librecores/librecores-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/librecores/librecores-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/librecores/librecores-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/librecores/librecores-web/contents/{+path}","compare_url":"https://api.github.com/repos/librecores/librecores-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librecores/librecores-web/merges","archive_url":"https://api.github.com/repos/librecores/librecores-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librecores/librecores-web/downloads","issues_url":"https://api.github.com/repos/librecores/librecores-web/issues{/number}","pulls_url":"https://api.github.com/repos/librecores/librecores-web/pulls{/number}","milestones_url":"https://api.github.com/repos/librecores/librecores-web/milestones{/number}","notifications_url":"https://api.github.com/repos/librecores/librecores-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librecores/librecores-web/labels{/name}","releases_url":"https://api.github.com/repos/librecores/librecores-web/releases{/id}","deployments_url":"https://api.github.com/repos/librecores/librecores-web/deployments","created_at":"2015-02-27T10:16:23Z","updated_at":"2018-05-30T04:52:16Z","pushed_at":"2018-06-06T23:15:17Z","git_url":"git://github.com/librecores/librecores-web.git","ssh_url":"git@github.com:librecores/librecores-web.git","clone_url":"https://github.com/librecores/librecores-web.git","svn_url":"https://github.com/librecores/librecores-web","homepage":"https://www.librecores.org/","size":9045,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":75,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librecores/librecores-web/pulls/241"},"html":{"href":"https://github.com/librecores/librecores-web/pull/241"},"issue":{"href":"https://api.github.com/repos/librecores/librecores-web/issues/241"},"comments":{"href":"https://api.github.com/repos/librecores/librecores-web/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/librecores/librecores-web/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/librecores/librecores-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librecores/librecores-web/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/librecores/librecores-web/statuses/5ed10d9cb5917b0040aa8edcf84803436314660d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agathver"}}