{"action":"created","comment":{"url":"https://api.github.com/repos/andrewjstone/amy/pulls/comments/172110602","pull_request_review_id":101071523,"id":172110602,"diff_hunk":"@@ -199,47 +196,72 @@ fn event_from_filter(filter: EventFilter) -> Event {\n // reads and writes on the same socket. We create the proper number of KEvents based on the enum\n // variant in the `event` paramter.\n fn make_changelist(sock_fd: RawFd, event: Event, user_data: UserData) -> Vec<KEvent> {\n-    let mut ev = KEvent {\n-        ident: sock_fd as uintptr_t,\n-        filter: EventFilter::EVFILT_READ,\n-        flags: EV_ADD,\n-        fflags: FilterFlag::empty(),\n-        data: 0,\n-        udata: user_data\n-    };\n+    let mut ev = KEvent::new(\n+        sock_fd as uintptr_t,\n+        EventFilter::EVFILT_READ,\n+        EventFlag::EV_ADD | EventFlag::EV_CLEAR,\n+        FilterFlag::empty(),\n+        0,\n+        user_data\n+    );\n \n     match event {\n         Event::Read => vec![ev],\n         Event::Write => {\n-            ev.filter = EventFilter::EVFILT_WRITE;\n-            vec![ev]\n+            set_filter(&mut ev, EventFilter::EVFILT_WRITE);\n+            vec![KEvent::new(ev.ident(), EventFilter::EVFILT_WRITE, ev.flags(), ev.fflags(), ev.data(), ev.udata())]","path":"src/kqueue.rs","position":168,"original_position":168,"commit_id":"c417264ac015ac09151fd41ec4f822c378eb0b3b","original_commit_id":"c417264ac015ac09151fd41ec4f822c378eb0b3b","user":{"login":"Luminarys","id":8228526,"avatar_url":"https://avatars0.githubusercontent.com/u/8228526?v=4","gravatar_id":"","url":"https://api.github.com/users/Luminarys","html_url":"https://github.com/Luminarys","followers_url":"https://api.github.com/users/Luminarys/followers","following_url":"https://api.github.com/users/Luminarys/following{/other_user}","gists_url":"https://api.github.com/users/Luminarys/gists{/gist_id}","starred_url":"https://api.github.com/users/Luminarys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luminarys/subscriptions","organizations_url":"https://api.github.com/users/Luminarys/orgs","repos_url":"https://api.github.com/users/Luminarys/repos","events_url":"https://api.github.com/users/Luminarys/events{/privacy}","received_events_url":"https://api.github.com/users/Luminarys/received_events","type":"User","site_admin":false},"body":"I think you're right, no need to reconstruct the event there.","created_at":"2018-03-05T08:02:47Z","updated_at":"2018-03-05T08:02:47Z","html_url":"https://github.com/andrewjstone/amy/pull/31#discussion_r172110602","pull_request_url":"https://api.github.com/repos/andrewjstone/amy/pulls/31","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/andrewjstone/amy/pulls/comments/172110602"},"html":{"href":"https://github.com/andrewjstone/amy/pull/31#discussion_r172110602"},"pull_request":{"href":"https://api.github.com/repos/andrewjstone/amy/pulls/31"}},"in_reply_to_id":172108375},"pull_request":{"url":"https://api.github.com/repos/andrewjstone/amy/pulls/31","id":172785898,"html_url":"https://github.com/andrewjstone/amy/pull/31","diff_url":"https://github.com/andrewjstone/amy/pull/31.diff","patch_url":"https://github.com/andrewjstone/amy/pull/31.patch","issue_url":"https://api.github.com/repos/andrewjstone/amy/issues/31","number":31,"state":"open","locked":false,"title":"Updates and Fixes","user":{"login":"Luminarys","id":8228526,"avatar_url":"https://avatars0.githubusercontent.com/u/8228526?v=4","gravatar_id":"","url":"https://api.github.com/users/Luminarys","html_url":"https://github.com/Luminarys","followers_url":"https://api.github.com/users/Luminarys/followers","following_url":"https://api.github.com/users/Luminarys/following{/other_user}","gists_url":"https://api.github.com/users/Luminarys/gists{/gist_id}","starred_url":"https://api.github.com/users/Luminarys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luminarys/subscriptions","organizations_url":"https://api.github.com/users/Luminarys/orgs","repos_url":"https://api.github.com/users/Luminarys/repos","events_url":"https://api.github.com/users/Luminarys/events{/privacy}","received_events_url":"https://api.github.com/users/Luminarys/received_events","type":"User","site_admin":false},"body":"This updates nix to the most recent version (needed for the most recent FreeBSD libc), fixes level triggering on kqueue, and fixes reporting of user events on kqueue.","created_at":"2018-03-05T06:42:49Z","updated_at":"2018-03-05T08:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef1b4850213f561bb4ea3e8cda7feb49091b578c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andrewjstone/amy/pulls/31/commits","review_comments_url":"https://api.github.com/repos/andrewjstone/amy/pulls/31/comments","review_comment_url":"https://api.github.com/repos/andrewjstone/amy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andrewjstone/amy/issues/31/comments","statuses_url":"https://api.github.com/repos/andrewjstone/amy/statuses/c417264ac015ac09151fd41ec4f822c378eb0b3b","head":{"label":"Luminarys:master","ref":"master","sha":"c417264ac015ac09151fd41ec4f822c378eb0b3b","user":{"login":"Luminarys","id":8228526,"avatar_url":"https://avatars0.githubusercontent.com/u/8228526?v=4","gravatar_id":"","url":"https://api.github.com/users/Luminarys","html_url":"https://github.com/Luminarys","followers_url":"https://api.github.com/users/Luminarys/followers","following_url":"https://api.github.com/users/Luminarys/following{/other_user}","gists_url":"https://api.github.com/users/Luminarys/gists{/gist_id}","starred_url":"https://api.github.com/users/Luminarys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luminarys/subscriptions","organizations_url":"https://api.github.com/users/Luminarys/orgs","repos_url":"https://api.github.com/users/Luminarys/repos","events_url":"https://api.github.com/users/Luminarys/events{/privacy}","received_events_url":"https://api.github.com/users/Luminarys/received_events","type":"User","site_admin":false},"repo":{"id":92902240,"name":"amy","full_name":"Luminarys/amy","owner":{"login":"Luminarys","id":8228526,"avatar_url":"https://avatars0.githubusercontent.com/u/8228526?v=4","gravatar_id":"","url":"https://api.github.com/users/Luminarys","html_url":"https://github.com/Luminarys","followers_url":"https://api.github.com/users/Luminarys/followers","following_url":"https://api.github.com/users/Luminarys/following{/other_user}","gists_url":"https://api.github.com/users/Luminarys/gists{/gist_id}","starred_url":"https://api.github.com/users/Luminarys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luminarys/subscriptions","organizations_url":"https://api.github.com/users/Luminarys/orgs","repos_url":"https://api.github.com/users/Luminarys/repos","events_url":"https://api.github.com/users/Luminarys/events{/privacy}","received_events_url":"https://api.github.com/users/Luminarys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Luminarys/amy","description":"Rust wrapper around epoll and kqueue","fork":true,"url":"https://api.github.com/repos/Luminarys/amy","forks_url":"https://api.github.com/repos/Luminarys/amy/forks","keys_url":"https://api.github.com/repos/Luminarys/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Luminarys/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Luminarys/amy/teams","hooks_url":"https://api.github.com/repos/Luminarys/amy/hooks","issue_events_url":"https://api.github.com/repos/Luminarys/amy/issues/events{/number}","events_url":"https://api.github.com/repos/Luminarys/amy/events","assignees_url":"https://api.github.com/repos/Luminarys/amy/assignees{/user}","branches_url":"https://api.github.com/repos/Luminarys/amy/branches{/branch}","tags_url":"https://api.github.com/repos/Luminarys/amy/tags","blobs_url":"https://api.github.com/repos/Luminarys/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Luminarys/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Luminarys/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Luminarys/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Luminarys/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/Luminarys/amy/languages","stargazers_url":"https://api.github.com/repos/Luminarys/amy/stargazers","contributors_url":"https://api.github.com/repos/Luminarys/amy/contributors","subscribers_url":"https://api.github.com/repos/Luminarys/amy/subscribers","subscription_url":"https://api.github.com/repos/Luminarys/amy/subscription","commits_url":"https://api.github.com/repos/Luminarys/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Luminarys/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Luminarys/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Luminarys/amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Luminarys/amy/contents/{+path}","compare_url":"https://api.github.com/repos/Luminarys/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Luminarys/amy/merges","archive_url":"https://api.github.com/repos/Luminarys/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Luminarys/amy/downloads","issues_url":"https://api.github.com/repos/Luminarys/amy/issues{/number}","pulls_url":"https://api.github.com/repos/Luminarys/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/Luminarys/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/Luminarys/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Luminarys/amy/labels{/name}","releases_url":"https://api.github.com/repos/Luminarys/amy/releases{/id}","deployments_url":"https://api.github.com/repos/Luminarys/amy/deployments","created_at":"2017-05-31T03:54:18Z","updated_at":"2017-05-31T03:54:19Z","pushed_at":"2018-02-25T05:49:51Z","git_url":"git://github.com/Luminarys/amy.git","ssh_url":"git@github.com:Luminarys/amy.git","clone_url":"https://github.com/Luminarys/amy.git","svn_url":"https://github.com/Luminarys/amy","homepage":null,"size":111,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andrewjstone:master","ref":"master","sha":"baed6a9d3919c7d9967ba1898197a1099aa51828","user":{"login":"andrewjstone","id":466937,"avatar_url":"https://avatars1.githubusercontent.com/u/466937?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewjstone","html_url":"https://github.com/andrewjstone","followers_url":"https://api.github.com/users/andrewjstone/followers","following_url":"https://api.github.com/users/andrewjstone/following{/other_user}","gists_url":"https://api.github.com/users/andrewjstone/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewjstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewjstone/subscriptions","organizations_url":"https://api.github.com/users/andrewjstone/orgs","repos_url":"https://api.github.com/users/andrewjstone/repos","events_url":"https://api.github.com/users/andrewjstone/events{/privacy}","received_events_url":"https://api.github.com/users/andrewjstone/received_events","type":"User","site_admin":false},"repo":{"id":60055928,"name":"amy","full_name":"andrewjstone/amy","owner":{"login":"andrewjstone","id":466937,"avatar_url":"https://avatars1.githubusercontent.com/u/466937?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewjstone","html_url":"https://github.com/andrewjstone","followers_url":"https://api.github.com/users/andrewjstone/followers","following_url":"https://api.github.com/users/andrewjstone/following{/other_user}","gists_url":"https://api.github.com/users/andrewjstone/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewjstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewjstone/subscriptions","organizations_url":"https://api.github.com/users/andrewjstone/orgs","repos_url":"https://api.github.com/users/andrewjstone/repos","events_url":"https://api.github.com/users/andrewjstone/events{/privacy}","received_events_url":"https://api.github.com/users/andrewjstone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewjstone/amy","description":"Rust wrapper around epoll and kqueue","fork":false,"url":"https://api.github.com/repos/andrewjstone/amy","forks_url":"https://api.github.com/repos/andrewjstone/amy/forks","keys_url":"https://api.github.com/repos/andrewjstone/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewjstone/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewjstone/amy/teams","hooks_url":"https://api.github.com/repos/andrewjstone/amy/hooks","issue_events_url":"https://api.github.com/repos/andrewjstone/amy/issues/events{/number}","events_url":"https://api.github.com/repos/andrewjstone/amy/events","assignees_url":"https://api.github.com/repos/andrewjstone/amy/assignees{/user}","branches_url":"https://api.github.com/repos/andrewjstone/amy/branches{/branch}","tags_url":"https://api.github.com/repos/andrewjstone/amy/tags","blobs_url":"https://api.github.com/repos/andrewjstone/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewjstone/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewjstone/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewjstone/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewjstone/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewjstone/amy/languages","stargazers_url":"https://api.github.com/repos/andrewjstone/amy/stargazers","contributors_url":"https://api.github.com/repos/andrewjstone/amy/contributors","subscribers_url":"https://api.github.com/repos/andrewjstone/amy/subscribers","subscription_url":"https://api.github.com/repos/andrewjstone/amy/subscription","commits_url":"https://api.github.com/repos/andrewjstone/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewjstone/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewjstone/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewjstone/amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewjstone/amy/contents/{+path}","compare_url":"https://api.github.com/repos/andrewjstone/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewjstone/amy/merges","archive_url":"https://api.github.com/repos/andrewjstone/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewjstone/amy/downloads","issues_url":"https://api.github.com/repos/andrewjstone/amy/issues{/number}","pulls_url":"https://api.github.com/repos/andrewjstone/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewjstone/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewjstone/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewjstone/amy/labels{/name}","releases_url":"https://api.github.com/repos/andrewjstone/amy/releases{/id}","deployments_url":"https://api.github.com/repos/andrewjstone/amy/deployments","created_at":"2016-05-31T03:38:13Z","updated_at":"2018-01-26T04:26:11Z","pushed_at":"2018-03-05T07:02:56Z","git_url":"git://github.com/andrewjstone/amy.git","ssh_url":"git@github.com:andrewjstone/amy.git","clone_url":"https://github.com/andrewjstone/amy.git","svn_url":"https://github.com/andrewjstone/amy","homepage":null,"size":111,"stargazers_count":29,"watchers_count":29,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":6,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andrewjstone/amy/pulls/31"},"html":{"href":"https://github.com/andrewjstone/amy/pull/31"},"issue":{"href":"https://api.github.com/repos/andrewjstone/amy/issues/31"},"comments":{"href":"https://api.github.com/repos/andrewjstone/amy/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/andrewjstone/amy/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/andrewjstone/amy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andrewjstone/amy/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/andrewjstone/amy/statuses/c417264ac015ac09151fd41ec4f822c378eb0b3b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Luminarys"}}