{"push_id":2670990449,"size":17,"distinct_size":10,"ref":"refs/heads/feature/UTY-292-codegen-tests","head":"311d5a1ca4111aa660325e44b150f5d2a4513566","before":"da03e6fa2c13d50cef0c4de26538599e88647d5c","commits":[{"sha":"92eb25227bb04b520ed2a3812071e2ee61bef9a9","author":{"name":"Jamie Brynes","email":"cec4040073d71f6ff0516ff04d5c65a7cc55c7da@gmail.com"},"message":"UTY-189: Mutable View API Review (#25)\n\n**Contributions**: We are not currently taking public contributions - see our [contributions](https://github.com/spatialos/UnityGDK/blob/master/CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](https://github.com/spatialos/UnityGDK/blob/master/README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nThis PR makes some changes to the `MutableView` API to clean it up by removing unnecessary methods/fields, making things internal where appropriate, and reorganising the methods such that they go in `public` -> `internal` -> `private` order.\r\n\r\nList of changes:\r\n* Remove all shared component methods on the `MutableView` as they were not used and a relic of the past.\r\n* Remove the connection on the view and the setting of it in the Worker. Systems now access the connection via the worker abstraction.\r\n* Added component pools to world commands, this allowed me to remove `AddCommandResponse<T>(Entity entity, T commandResponse)` and `private void AddReceivedMessageToComponent<TMessagesReceived, TMessage>(Entity entity, TMessage message)`\r\n* Removed one of the `HandleAuthorityChange` methods as one literally just called the other.\r\n* Removed: `T GetOrCreateComponent<T>(Entity entity)` as it was no longer being used.\r\n* Made `CreateEntity` and `RemoveEntity` internal. These should not be publicly available for use as they are meant for ops coming off the wire.\r\n\r\n#### Tests\r\nBuilt and ran locally.\r\n#### Documentation\r\nN/A\r\n#### Primary reviewers\r\nIf your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.\r\n@sami @jessicafalk","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/92eb25227bb04b520ed2a3812071e2ee61bef9a9"},{"sha":"7c542503a6259f7a76cda976763d214866a5b336","author":{"name":"Martin Zlocha","email":"48809371ed62a03b280f4015b3c81b722a8022a4@gmail.com"},"message":"UTY-370: Link world to a monobehaviour. (#26)\n\n* Link world to a monobehaviour.","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/7c542503a6259f7a76cda976763d214866a5b336"},{"sha":"a245c793353ee51e23f60bd88f0cf5ffd22b4b81","author":{"name":"Callum Lawson","email":"e097777470d7ff022e7a6650c3993a2515aab6f9@gmail.com"},"message":"Adding missing link to component docs (#14)\n\n#### Description\r\nAlso reordered doc table of content\r\n#### Tests\r\nChecked link manually.\r\n#### Documentation\r\nThis is documentation.\r\n#### Primary reviewers\r\n@samiwh","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/a245c793353ee51e23f60bd88f0cf5ffd22b4b81"},{"sha":"43e46b5e2ecdb6a17417f070b56c71497d10816f","author":{"name":"Jamie Brynes","email":"cec4040073d71f6ff0516ff04d5c65a7cc55c7da@gmail.com"},"message":"UTY-407: Decouple ISpatialComponentData from IComponentData (#28)\n\n**Contributions**: We are not currently taking public contributions - see our [contributions](https://github.com/spatialos/UnityGDK/blob/master/CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](https://github.com/spatialos/UnityGDK/blob/master/README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nWe have overlooked the fact that all blittable components inherit from `ISpatialComponentData` and non-blittable components have no indication that they are Spatial. \r\n\r\nThis PR corrects that by decoupling `ISpatialComponentData` from `IComponentData` and tweaking the `tt` files to extend two interface(s)/base class. \r\n\r\nThis allows us to test components for \"Spatial-ity\" by checking that it implements `ISpatialComponentData`.\r\n\r\nAlso done a driveby to fix `CustomSendSystem`\r\n#### Tests\r\nTested locally, compiled and ran as expected.\r\n#### Documentation\r\nUpdated `component-data.md` to match the changes.\r\n#### Primary reviewers\r\nIf your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.\r\n@samiwh @ElleEss","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/43e46b5e2ecdb6a17417f070b56c71497d10816f"},{"sha":"ebc2c38eee16f50e15aae4ca126c1e1eeda5f8db","author":{"name":"Oliver Balaam","email":"964f2b0fe43be8465a76b51f97f51468fd3fbc56@improbable.io"},"message":"General cleanup & removal of passive voice. (#27)\n\n* General cleanup and adjustment of sctions that were using the passive voice\r\n\r\n* Remove unused header image.\r\n\r\n* Add a link to /csharpsdk/introduction\r\n\r\n* Reinstate the link to /release-policy#maturity-stages that I erroneously deleted\r\n\r\n* fix typo \"Unty\"\r\n\r\n* Clarify SpatialOSSendSystem behaviour.\r\n\r\n* Clarify CustomSpatialOSSendSystem\r\n\r\n* Remove ToDo\r\n\r\n* change deal to handle\r\n\r\nit's more chill :)\r\n\r\n* Clarify CustomSpatialOSSendSystem behaviour\r\n\r\n* Update custom-replication-system.md","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/ebc2c38eee16f50e15aae4ca126c1e1eeda5f8db"},{"sha":"7170a4611a81c81b3735833e44ef1cd117405538","author":{"name":"Jamie Brynes","email":"cec4040073d71f6ff0516ff04d5c65a7cc55c7da@gmail.com"},"message":"UTY-328: Add Caller Worker Id to Command Requests (#32)\n\n* add caller worker id\r\n\r\n* make readonly","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/7170a4611a81c81b3735833e44ef1cd117405538"},{"sha":"4ded4ac616e8945974d3bbd2619b38d29b39101e","author":{"name":"Laura","email":"c7bb25eec91fb97de7576244bda79d079acfabb9@users.noreply.github.com"},"message":"Updated roadmap and associated files (#34)\n\n* Updated roadmap and associated files\r\n\r\nDescription\r\nRoadmap docs updates:\r\n1. Added title and date.\r\n2. Added definition and date to 'first look'.\r\n3. Added formatting to the first column.\r\n3. Added link to feedback information.\r\n4. Renamed to standard lower-case docs naming convention - used a rename as changing case was confusing GitHub and git.\r\n5. Did not update roadmap text.\r\n6. Typo fix.\r\n\r\nRepo README  and docs/README updates\r\n1. Set a link to the roadmap from the docs readme.\r\n2. Updated the text and link to the roadmap from the repo readme. \r\n3. Updated the email sign-up link.","distinct":false,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/4ded4ac616e8945974d3bbd2619b38d29b39101e"},{"sha":"33edb68ad633e31072e2371f9e18955bf9cbae66","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Initial CodeGenerator End2End Tests, with some simple tests. Currently one test fails on purpose, to verify the tests are being run","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/33edb68ad633e31072e2371f9e18955bf9cbae66"},{"sha":"98f5fe354d43089f1b49377e2da32e37b349136c","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Remove generated files from git","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/98f5fe354d43089f1b49377e2da32e37b349136c"},{"sha":"50b517378653089938a92d56aa3ab1c50c0a4ec7","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Add ImpNuget bootstrap for TeamCity","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/50b517378653089938a92d56aa3ab1c50c0a4ec7"},{"sha":"5d40fcd8a04d2694230293f55781b270effb8ed8","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"ImpNuget Bootsrap and project config for Tests.csproj, also remove nunit deps in Generated","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/5d40fcd8a04d2694230293f55781b270effb8ed8"},{"sha":"06be1d84f868724ff5d6f417c516cdc3ab4cced9","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Added basic tests for non-blittable types","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/06be1d84f868724ff5d6f417c516cdc3ab4cced9"},{"sha":"a0606bcc22cc5d9dddb0c887d6f6555cc059f730","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Exhaustive schema test and blittable subset","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/a0606bcc22cc5d9dddb0c887d6f6555cc059f730"},{"sha":"54283fdbfa71d1378443e2a185ed09eb98d60152","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Example of nested types that currently does not compile","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/54283fdbfa71d1378443e2a185ed09eb98d60152"},{"sha":"43ed0bc0093c92f815ad2ed41927034a80641011","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Rename Tests & namespace to match style","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/43ed0bc0093c92f815ad2ed41927034a80641011"},{"sha":"df0735729192845063f53bf1124c8a7d8dd248f7","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Add tests to check generated components inherit / implement correct things","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/df0735729192845063f53bf1124c8a7d8dd248f7"},{"sha":"311d5a1ca4111aa660325e44b150f5d2a4513566","author":{"name":"Matt Young","email":"3fb45b18912544f3ac50894b19a71066b25c0feb@improbable.io"},"message":"Add commands and events to (Non)Blittable components","distinct":true,"url":"https://api.github.com/repos/spatialos/UnityGDK/commits/311d5a1ca4111aa660325e44b150f5d2a4513566"}]}
{"actor":{"display_login":"mattyoung-improbable"}}