{"action":"closed","number":1780,"pull_request":{"url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/1780","id":201897651,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODk3NjUx","html_url":"https://github.com/rzwitserloot/lombok/pull/1780","diff_url":"https://github.com/rzwitserloot/lombok/pull/1780.diff","patch_url":"https://github.com/rzwitserloot/lombok/pull/1780.patch","issue_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/1780","number":1780,"state":"closed","locked":false,"title":"Allow jitpack to build lombok using JDK 9+","user":{"login":"mmoayyed","id":1205228,"node_id":"MDQ6VXNlcjEyMDUyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1205228?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"body":"## Problem\r\n\r\nLet lombok build on jitpack.io.\r\n\r\nFrom:\r\nhttps://jitpack.io/docs/BUILDING/#build-customization\r\n\r\n> You can create a jitpack.yml file in the root of your repository and override the build commands:\r\n>\r\n> jdk:\r\n>   -openjdk9\r\n\r\n## Current\r\n\r\nA sample failing build:\r\nhttps://jitpack.io/com/github/rzwitserloot/lombok/37434ba0cb/build.log\r\n\r\nWith current failure:\r\n\r\n```\r\n-ensureJdk9:\r\n\r\nBUILD FAILED\r\n/home/jitpack/build/build.xml:176: To compile lombok, you need JDK9 or higher; lombok requires this version because it's rather difficult \r\nto produce lombok builds that are compatible on JDK9 without at least building with JDK9. Sorry about that.\r\n```\r\n\r\n## Why\r\n\r\nThis, once working, should allow access to SNAPSHOT builds of lombok whereby developers can quickly test changes and provided feedback. (Case in point: https://github.com/rzwitserloot/lombok/pull/1718)\r\n\r\n## Caveats\r\n\r\nI ended up switching the java version insufficiency check to use `java.version` rather than `ant.java.version`. This was done to get around jitpack's behavior:\r\n\r\n```\r\n-ensureJdk9:\r\n     [echo] Java version: 1.8\r\n     [echo] Java version: 9.0.4\r\n     [echo] Java version insufficient: true\r\n```\r\n\r\nUsing the above changes, I was able to successfully build lombok. [Here is a build log](https://jitpack.io/com/github/mmoayyed/lombok/-v1.18.0-gbff1237-99/build.log) that shows the build is successful.\r\n\r\n# Usage\r\n\r\nSee: https://jitpack.io/#rzwitserloot/lombok/-SNAPSHOT\r\n\r\n## Maven\r\n\r\n```\r\n<repositories>\r\n\t\t<repository>\r\n\t\t    <id>jitpack.io</id>\r\n\t\t    <url>https://jitpack.io</url>\r\n\t\t</repository>\r\n</repositories>\r\n<dependency>\r\n\t    <groupId>com.github.rzwitserloot</groupId>\r\n\t    <artifactId>lombok</artifactId>\r\n\t    <version>-SNAPSHOT</version>\r\n</dependency>\r\n```\r\n\r\n## Gradle\r\n\r\n```\r\nallprojects {\r\n\t\trepositories {\r\n\t\t\t...\r\n\t\t\tmaven { url 'https://jitpack.io' }\r\n\t\t}\r\n}\r\ndependencies {\r\n\t        implementation 'com.github.rzwitserloot:lombok:-SNAPSHOT'\r\n}\r\n```\r\n","created_at":"2018-07-17T10:38:53Z","updated_at":"2018-08-20T20:03:12Z","closed_at":"2018-08-20T20:03:11Z","merged_at":null,"merge_commit_sha":"1db3c957568e8ba6132532c59a22c7e4dfde59fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/1780/commits","review_comments_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/1780/comments","review_comment_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/1780/comments","statuses_url":"https://api.github.com/repos/rzwitserloot/lombok/statuses/5f83968f2a9e78991c58e2bc09158125fc90d9ad","head":{"label":"mmoayyed:jitpack","ref":"jitpack","sha":"5f83968f2a9e78991c58e2bc09158125fc90d9ad","user":{"login":"mmoayyed","id":1205228,"node_id":"MDQ6VXNlcjEyMDUyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1205228?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"repo":{"id":141274280,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNzQyODA=","name":"lombok","full_name":"mmoayyed/lombok","owner":{"login":"mmoayyed","id":1205228,"node_id":"MDQ6VXNlcjEyMDUyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1205228?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmoayyed/lombok","description":"Very spicy additions to the Java programming language.","fork":true,"url":"https://api.github.com/repos/mmoayyed/lombok","forks_url":"https://api.github.com/repos/mmoayyed/lombok/forks","keys_url":"https://api.github.com/repos/mmoayyed/lombok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmoayyed/lombok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmoayyed/lombok/teams","hooks_url":"https://api.github.com/repos/mmoayyed/lombok/hooks","issue_events_url":"https://api.github.com/repos/mmoayyed/lombok/issues/events{/number}","events_url":"https://api.github.com/repos/mmoayyed/lombok/events","assignees_url":"https://api.github.com/repos/mmoayyed/lombok/assignees{/user}","branches_url":"https://api.github.com/repos/mmoayyed/lombok/branches{/branch}","tags_url":"https://api.github.com/repos/mmoayyed/lombok/tags","blobs_url":"https://api.github.com/repos/mmoayyed/lombok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmoayyed/lombok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmoayyed/lombok/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmoayyed/lombok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmoayyed/lombok/statuses/{sha}","languages_url":"https://api.github.com/repos/mmoayyed/lombok/languages","stargazers_url":"https://api.github.com/repos/mmoayyed/lombok/stargazers","contributors_url":"https://api.github.com/repos/mmoayyed/lombok/contributors","subscribers_url":"https://api.github.com/repos/mmoayyed/lombok/subscribers","subscription_url":"https://api.github.com/repos/mmoayyed/lombok/subscription","commits_url":"https://api.github.com/repos/mmoayyed/lombok/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmoayyed/lombok/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmoayyed/lombok/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmoayyed/lombok/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmoayyed/lombok/contents/{+path}","compare_url":"https://api.github.com/repos/mmoayyed/lombok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmoayyed/lombok/merges","archive_url":"https://api.github.com/repos/mmoayyed/lombok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmoayyed/lombok/downloads","issues_url":"https://api.github.com/repos/mmoayyed/lombok/issues{/number}","pulls_url":"https://api.github.com/repos/mmoayyed/lombok/pulls{/number}","milestones_url":"https://api.github.com/repos/mmoayyed/lombok/milestones{/number}","notifications_url":"https://api.github.com/repos/mmoayyed/lombok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmoayyed/lombok/labels{/name}","releases_url":"https://api.github.com/repos/mmoayyed/lombok/releases{/id}","deployments_url":"https://api.github.com/repos/mmoayyed/lombok/deployments","created_at":"2018-07-17T10:35:05Z","updated_at":"2018-07-17T11:25:49Z","pushed_at":"2018-07-18T05:18:45Z","git_url":"git://github.com/mmoayyed/lombok.git","ssh_url":"git@github.com:mmoayyed/lombok.git","clone_url":"https://github.com/mmoayyed/lombok.git","svn_url":"https://github.com/mmoayyed/lombok","homepage":"https://projectlombok.org/","size":73922,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rzwitserloot:master","ref":"master","sha":"c21adf7f47ed0077c53547a36041b1dba45bdcb8","user":{"login":"rzwitserloot","id":93303,"node_id":"MDQ6VXNlcjkzMzAz","avatar_url":"https://avatars3.githubusercontent.com/u/93303?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwitserloot","html_url":"https://github.com/rzwitserloot","followers_url":"https://api.github.com/users/rzwitserloot/followers","following_url":"https://api.github.com/users/rzwitserloot/following{/other_user}","gists_url":"https://api.github.com/users/rzwitserloot/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwitserloot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwitserloot/subscriptions","organizations_url":"https://api.github.com/users/rzwitserloot/orgs","repos_url":"https://api.github.com/users/rzwitserloot/repos","events_url":"https://api.github.com/users/rzwitserloot/events{/privacy}","received_events_url":"https://api.github.com/users/rzwitserloot/received_events","type":"User","site_admin":false},"repo":{"id":221862,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE4NjI=","name":"lombok","full_name":"rzwitserloot/lombok","owner":{"login":"rzwitserloot","id":93303,"node_id":"MDQ6VXNlcjkzMzAz","avatar_url":"https://avatars3.githubusercontent.com/u/93303?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwitserloot","html_url":"https://github.com/rzwitserloot","followers_url":"https://api.github.com/users/rzwitserloot/followers","following_url":"https://api.github.com/users/rzwitserloot/following{/other_user}","gists_url":"https://api.github.com/users/rzwitserloot/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwitserloot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwitserloot/subscriptions","organizations_url":"https://api.github.com/users/rzwitserloot/orgs","repos_url":"https://api.github.com/users/rzwitserloot/repos","events_url":"https://api.github.com/users/rzwitserloot/events{/privacy}","received_events_url":"https://api.github.com/users/rzwitserloot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rzwitserloot/lombok","description":"Very spicy additions to the Java programming language.","fork":false,"url":"https://api.github.com/repos/rzwitserloot/lombok","forks_url":"https://api.github.com/repos/rzwitserloot/lombok/forks","keys_url":"https://api.github.com/repos/rzwitserloot/lombok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rzwitserloot/lombok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rzwitserloot/lombok/teams","hooks_url":"https://api.github.com/repos/rzwitserloot/lombok/hooks","issue_events_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/events{/number}","events_url":"https://api.github.com/repos/rzwitserloot/lombok/events","assignees_url":"https://api.github.com/repos/rzwitserloot/lombok/assignees{/user}","branches_url":"https://api.github.com/repos/rzwitserloot/lombok/branches{/branch}","tags_url":"https://api.github.com/repos/rzwitserloot/lombok/tags","blobs_url":"https://api.github.com/repos/rzwitserloot/lombok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rzwitserloot/lombok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rzwitserloot/lombok/git/refs{/sha}","trees_url":"https://api.github.com/repos/rzwitserloot/lombok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rzwitserloot/lombok/statuses/{sha}","languages_url":"https://api.github.com/repos/rzwitserloot/lombok/languages","stargazers_url":"https://api.github.com/repos/rzwitserloot/lombok/stargazers","contributors_url":"https://api.github.com/repos/rzwitserloot/lombok/contributors","subscribers_url":"https://api.github.com/repos/rzwitserloot/lombok/subscribers","subscription_url":"https://api.github.com/repos/rzwitserloot/lombok/subscription","commits_url":"https://api.github.com/repos/rzwitserloot/lombok/commits{/sha}","git_commits_url":"https://api.github.com/repos/rzwitserloot/lombok/git/commits{/sha}","comments_url":"https://api.github.com/repos/rzwitserloot/lombok/comments{/number}","issue_comment_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/comments{/number}","contents_url":"https://api.github.com/repos/rzwitserloot/lombok/contents/{+path}","compare_url":"https://api.github.com/repos/rzwitserloot/lombok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rzwitserloot/lombok/merges","archive_url":"https://api.github.com/repos/rzwitserloot/lombok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rzwitserloot/lombok/downloads","issues_url":"https://api.github.com/repos/rzwitserloot/lombok/issues{/number}","pulls_url":"https://api.github.com/repos/rzwitserloot/lombok/pulls{/number}","milestones_url":"https://api.github.com/repos/rzwitserloot/lombok/milestones{/number}","notifications_url":"https://api.github.com/repos/rzwitserloot/lombok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rzwitserloot/lombok/labels{/name}","releases_url":"https://api.github.com/repos/rzwitserloot/lombok/releases{/id}","deployments_url":"https://api.github.com/repos/rzwitserloot/lombok/deployments","created_at":"2009-06-08T19:46:41Z","updated_at":"2018-08-20T19:43:57Z","pushed_at":"2018-08-20T19:43:55Z","git_url":"git://github.com/rzwitserloot/lombok.git","ssh_url":"git@github.com:rzwitserloot/lombok.git","clone_url":"https://github.com/rzwitserloot/lombok.git","svn_url":"https://github.com/rzwitserloot/lombok","homepage":"https://projectlombok.org/","size":73939,"stargazers_count":6627,"watchers_count":6627,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1243,"mirror_url":null,"archived":false,"open_issues_count":593,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1243,"open_issues":593,"watchers":6627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/1780"},"html":{"href":"https://github.com/rzwitserloot/lombok/pull/1780"},"issue":{"href":"https://api.github.com/repos/rzwitserloot/lombok/issues/1780"},"comments":{"href":"https://api.github.com/repos/rzwitserloot/lombok/issues/1780/comments"},"review_comments":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/1780/comments"},"review_comment":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rzwitserloot/lombok/pulls/1780/commits"},"statuses":{"href":"https://api.github.com/repos/rzwitserloot/lombok/statuses/5f83968f2a9e78991c58e2bc09158125fc90d9ad"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":14,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"rspilker"}}