{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/168785915","pull_request_review_id":97166115,"id":168785915,"diff_hunk":"@@ -173,23 +137,12 @@ Object loadFromPersistence(String key) {\n     return values;\n   }\n \n-  private FilenameFilter getFilenameFilter() {\n-    FilenameFilter filter =\n-        new FilenameFilter() {\n-          @Override\n-          public boolean accept(File file, String name) {\n-            return name.toLowerCase(Locale.getDefault()).endsWith(SER);\n-          }\n-        };\n-    return filter;\n-  }\n-\n   @Override\n   public Set<String> loadAllKeys() {\n     Set<String> keys = new HashSet<String>();\n     LOGGER.debug(\"Entering loadAllKeys\");\n \n-    File[] files = new File(getMapStorePath()).listFiles(getFilenameFilter());\n+    File[] files = persistencePath.toFile().listFiles(getFilenameFilter());","path":"catalog/core/catalog-core-standardframework/src/main/java/ddf/catalog/cache/impl/FileSystemPersistenceProvider.java","position":150,"original_position":150,"commit_id":"fd95ec85fe372b0c64bbb8c0b30268a1c38f68c3","original_commit_id":"fd95ec85fe372b0c64bbb8c0b30268a1c38f68c3","user":{"login":"oconnormi","id":3409759,"avatar_url":"https://avatars3.githubusercontent.com/u/3409759?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnormi","html_url":"https://github.com/oconnormi","followers_url":"https://api.github.com/users/oconnormi/followers","following_url":"https://api.github.com/users/oconnormi/following{/other_user}","gists_url":"https://api.github.com/users/oconnormi/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnormi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnormi/subscriptions","organizations_url":"https://api.github.com/users/oconnormi/orgs","repos_url":"https://api.github.com/users/oconnormi/repos","events_url":"https://api.github.com/users/oconnormi/events{/privacy}","received_events_url":"https://api.github.com/users/oconnormi/received_events","type":"User","site_admin":false},"body":"Changed","created_at":"2018-02-16T15:25:01Z","updated_at":"2018-02-16T15:26:29Z","html_url":"https://github.com/codice/ddf/pull/2973#discussion_r168785915","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/2973","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/168785915"},"html":{"href":"https://github.com/codice/ddf/pull/2973#discussion_r168785915"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/2973"}},"in_reply_to_id":168599637},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/2973","id":169460365,"html_url":"https://github.com/codice/ddf/pull/2973","diff_url":"https://github.com/codice/ddf/pull/2973.diff","patch_url":"https://github.com/codice/ddf/pull/2973.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/2973","number":2973,"state":"open","locked":false,"title":"DDF-3632 clean up resource cache and set storage directory in blueprint","user":{"login":"oconnormi","id":3409759,"avatar_url":"https://avatars3.githubusercontent.com/u/3409759?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnormi","html_url":"https://github.com/oconnormi","followers_url":"https://api.github.com/users/oconnormi/followers","following_url":"https://api.github.com/users/oconnormi/following{/other_user}","gists_url":"https://api.github.com/users/oconnormi/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnormi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnormi/subscriptions","organizations_url":"https://api.github.com/users/oconnormi/orgs","repos_url":"https://api.github.com/users/oconnormi/repos","events_url":"https://api.github.com/users/oconnormi/events{/privacy}","received_events_url":"https://api.github.com/users/oconnormi/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\n* Fixes setting product cache directory\r\n* Cleans up tests that were writing to the target directory\r\n* Cleans up usages of system properties in tests and production code\r\n* Stops resource cache from relying on the bundle context in order to get hazelcast configuration\r\n\r\n#### Who is reviewing it? \r\n@peterhuffer @clockard @kcover \r\n\r\n#### Choose 2 committers to review/merge the PR. \r\n@figliold @lessarderic \r\n\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nTest default directory:\r\n1. Start the system, install standard profile.\r\n2. Configure a loopback csw source\r\n3. Upload a file through Intrigue\r\n4. Query loopback source\r\n5. download product\r\n6. check contents of `$DDF_HOME/data/Product_Cache`\r\n\r\nTest alternate directory:\r\n1. In admin console, go to the catalog-app configurations, click `Resource Download Settings`\r\n2. Set `Product Cache Directory` to something other than the default\r\n3. upload new file in intrigue\r\n4. query and retrieve from loopback source\r\n5. verify contents of new cache directory\r\n\r\n#### What are the relevant tickets?\r\n[DDF-3632](https://codice.atlassian.net/browse/DDF-3632)\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-02-15T19:15:57Z","updated_at":"2018-02-16T15:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebe722e075b64485a2a3e3f5e49ac727ac05aa5f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stustison","id":4391679,"avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/2973/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/2973/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/2973/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/fd95ec85fe372b0c64bbb8c0b30268a1c38f68c3","head":{"label":"oconnormi:DDF-3632","ref":"DDF-3632","sha":"fd95ec85fe372b0c64bbb8c0b30268a1c38f68c3","user":{"login":"oconnormi","id":3409759,"avatar_url":"https://avatars3.githubusercontent.com/u/3409759?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnormi","html_url":"https://github.com/oconnormi","followers_url":"https://api.github.com/users/oconnormi/followers","following_url":"https://api.github.com/users/oconnormi/following{/other_user}","gists_url":"https://api.github.com/users/oconnormi/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnormi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnormi/subscriptions","organizations_url":"https://api.github.com/users/oconnormi/orgs","repos_url":"https://api.github.com/users/oconnormi/repos","events_url":"https://api.github.com/users/oconnormi/events{/privacy}","received_events_url":"https://api.github.com/users/oconnormi/received_events","type":"User","site_admin":false},"repo":{"id":40485585,"name":"ddf","full_name":"oconnormi/ddf","owner":{"login":"oconnormi","id":3409759,"avatar_url":"https://avatars3.githubusercontent.com/u/3409759?v=4","gravatar_id":"","url":"https://api.github.com/users/oconnormi","html_url":"https://github.com/oconnormi","followers_url":"https://api.github.com/users/oconnormi/followers","following_url":"https://api.github.com/users/oconnormi/following{/other_user}","gists_url":"https://api.github.com/users/oconnormi/gists{/gist_id}","starred_url":"https://api.github.com/users/oconnormi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconnormi/subscriptions","organizations_url":"https://api.github.com/users/oconnormi/orgs","repos_url":"https://api.github.com/users/oconnormi/repos","events_url":"https://api.github.com/users/oconnormi/events{/privacy}","received_events_url":"https://api.github.com/users/oconnormi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oconnormi/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/oconnormi/ddf","forks_url":"https://api.github.com/repos/oconnormi/ddf/forks","keys_url":"https://api.github.com/repos/oconnormi/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oconnormi/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oconnormi/ddf/teams","hooks_url":"https://api.github.com/repos/oconnormi/ddf/hooks","issue_events_url":"https://api.github.com/repos/oconnormi/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/oconnormi/ddf/events","assignees_url":"https://api.github.com/repos/oconnormi/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/oconnormi/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/oconnormi/ddf/tags","blobs_url":"https://api.github.com/repos/oconnormi/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oconnormi/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oconnormi/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/oconnormi/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oconnormi/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/oconnormi/ddf/languages","stargazers_url":"https://api.github.com/repos/oconnormi/ddf/stargazers","contributors_url":"https://api.github.com/repos/oconnormi/ddf/contributors","subscribers_url":"https://api.github.com/repos/oconnormi/ddf/subscribers","subscription_url":"https://api.github.com/repos/oconnormi/ddf/subscription","commits_url":"https://api.github.com/repos/oconnormi/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/oconnormi/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/oconnormi/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/oconnormi/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/oconnormi/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/oconnormi/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oconnormi/ddf/merges","archive_url":"https://api.github.com/repos/oconnormi/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oconnormi/ddf/downloads","issues_url":"https://api.github.com/repos/oconnormi/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/oconnormi/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/oconnormi/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/oconnormi/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oconnormi/ddf/labels{/name}","releases_url":"https://api.github.com/repos/oconnormi/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/oconnormi/ddf/deployments","created_at":"2015-08-10T14:00:20Z","updated_at":"2016-01-12T15:07:08Z","pushed_at":"2018-02-15T19:01:44Z","git_url":"git://github.com/oconnormi/ddf.git","ssh_url":"git@github.com:oconnormi/ddf.git","clone_url":"https://github.com/oconnormi/ddf.git","svn_url":"https://github.com/oconnormi/ddf","homepage":"","size":193971,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"80d72b66f6d04737bf596edf38f82f798a7cb79d","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-02-13T19:28:35Z","pushed_at":"2018-02-16T13:31:28Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":385622,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":127,"open_issues":35,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/2973"},"html":{"href":"https://github.com/codice/ddf/pull/2973"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/2973"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/2973/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/2973/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/2973/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/fd95ec85fe372b0c64bbb8c0b30268a1c38f68c3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"oconnormi"}}