{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/McTavishLab/physcraper/pulls/32","id":228524599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTI0NTk5","html_url":"https://github.com/McTavishLab/physcraper/pull/32","diff_url":"https://github.com/McTavishLab/physcraper/pull/32.diff","patch_url":"https://github.com/McTavishLab/physcraper/pull/32.patch","issue_url":"https://api.github.com/repos/McTavishLab/physcraper/issues/32","number":32,"state":"closed","locked":false,"title":"Move some of the testing to pytest.","user":{"login":"Carreau","id":335567,"node_id":"MDQ6VXNlcjMzNTU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/335567?v=4","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"body":"pytest has many advantages over creating your own test framework.\r\n 1) it has color: Green OK, Red when failling.\r\n 2) it will automatically show you individual error with parameters, so\r\n you do not have to re-run things. Example:\r\n\r\n         def test_config():\r\n            from physcraper import ConfigObj\r\n            configfi = \"tests/data/localblast.config\"\r\n            conf = ConfigObj(configfi, interactive=False)\r\n    >       assert conf.email == 'ejmctavish@gmail.com'\r\n    E       AssertionError: assert 'bussonniermatthias@gmail.com' == 'ejmctavish@gmail.com'\r\n    E         - bussonniermatthias@gmail.com\r\n    E         + ejmctavish@gmail.com\r\n\r\n 3) when all test are py-testified, it can auto-discover test.\r\n 4) it has options like --lf (last failed) and --ff (failed first). That\r\n speed-up iterative development.\r\n 5) it shows warning for things you should pay attention to but are not\r\n yet errors:\r\n\r\n     tests/test_configread.py::test_config\r\n      /Users/mbussonnier/dev/physcraper/physcraper/__init__.py:143: DeprecationWarning: You passed a bytestring as `filenames`. This will not work on Python 3. Use `cp.read_file()` or switch to using Unicode strings across the board.\r\n        config.read(configfi)\r\n\r\nAs you will see it also simplify testign quite a bit as it takes care of\r\nthe try/except by itself as well. And in general the less you have to\r\nwrite, the easier it is.","created_at":"2018-11-05T23:20:47Z","updated_at":"2018-11-07T01:10:11Z","closed_at":"2018-11-07T01:10:11Z","merged_at":"2018-11-07T01:10:11Z","merge_commit_sha":"224f18e4fe9d058c1f8d75e9cc38b3999e493247","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/McTavishLab/physcraper/pulls/32/commits","review_comments_url":"https://api.github.com/repos/McTavishLab/physcraper/pulls/32/comments","review_comment_url":"https://api.github.com/repos/McTavishLab/physcraper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/McTavishLab/physcraper/issues/32/comments","statuses_url":"https://api.github.com/repos/McTavishLab/physcraper/statuses/875a827bb3e3b9ccdc9eea6f705a3cd75a05e482","head":{"label":"Carreau:pytestify","ref":"pytestify","sha":"875a827bb3e3b9ccdc9eea6f705a3cd75a05e482","user":{"login":"Carreau","id":335567,"node_id":"MDQ6VXNlcjMzNTU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/335567?v=4","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"repo":{"id":155929222,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5MjkyMjI=","name":"physcraper","full_name":"Carreau/physcraper","private":false,"owner":{"login":"Carreau","id":335567,"node_id":"MDQ6VXNlcjMzNTU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/335567?v=4","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Carreau/physcraper","description":"Gene tree updating","fork":true,"url":"https://api.github.com/repos/Carreau/physcraper","forks_url":"https://api.github.com/repos/Carreau/physcraper/forks","keys_url":"https://api.github.com/repos/Carreau/physcraper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carreau/physcraper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carreau/physcraper/teams","hooks_url":"https://api.github.com/repos/Carreau/physcraper/hooks","issue_events_url":"https://api.github.com/repos/Carreau/physcraper/issues/events{/number}","events_url":"https://api.github.com/repos/Carreau/physcraper/events","assignees_url":"https://api.github.com/repos/Carreau/physcraper/assignees{/user}","branches_url":"https://api.github.com/repos/Carreau/physcraper/branches{/branch}","tags_url":"https://api.github.com/repos/Carreau/physcraper/tags","blobs_url":"https://api.github.com/repos/Carreau/physcraper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carreau/physcraper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carreau/physcraper/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carreau/physcraper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carreau/physcraper/statuses/{sha}","languages_url":"https://api.github.com/repos/Carreau/physcraper/languages","stargazers_url":"https://api.github.com/repos/Carreau/physcraper/stargazers","contributors_url":"https://api.github.com/repos/Carreau/physcraper/contributors","subscribers_url":"https://api.github.com/repos/Carreau/physcraper/subscribers","subscription_url":"https://api.github.com/repos/Carreau/physcraper/subscription","commits_url":"https://api.github.com/repos/Carreau/physcraper/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carreau/physcraper/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carreau/physcraper/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carreau/physcraper/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carreau/physcraper/contents/{+path}","compare_url":"https://api.github.com/repos/Carreau/physcraper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carreau/physcraper/merges","archive_url":"https://api.github.com/repos/Carreau/physcraper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carreau/physcraper/downloads","issues_url":"https://api.github.com/repos/Carreau/physcraper/issues{/number}","pulls_url":"https://api.github.com/repos/Carreau/physcraper/pulls{/number}","milestones_url":"https://api.github.com/repos/Carreau/physcraper/milestones{/number}","notifications_url":"https://api.github.com/repos/Carreau/physcraper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carreau/physcraper/labels{/name}","releases_url":"https://api.github.com/repos/Carreau/physcraper/releases{/id}","deployments_url":"https://api.github.com/repos/Carreau/physcraper/deployments","created_at":"2018-11-02T22:47:50Z","updated_at":"2018-11-02T22:47:53Z","pushed_at":"2018-11-07T01:10:02Z","git_url":"git://github.com/Carreau/physcraper.git","ssh_url":"git@github.com:Carreau/physcraper.git","clone_url":"https://github.com/Carreau/physcraper.git","svn_url":"https://github.com/Carreau/physcraper","homepage":null,"size":26461,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"McTavishLab:master","ref":"master","sha":"3355eab3e7fbebce7ed9a9190b13dcc51731511c","user":{"login":"McTavishLab","id":20669363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjY5MzYz","avatar_url":"https://avatars1.githubusercontent.com/u/20669363?v=4","gravatar_id":"","url":"https://api.github.com/users/McTavishLab","html_url":"https://github.com/McTavishLab","followers_url":"https://api.github.com/users/McTavishLab/followers","following_url":"https://api.github.com/users/McTavishLab/following{/other_user}","gists_url":"https://api.github.com/users/McTavishLab/gists{/gist_id}","starred_url":"https://api.github.com/users/McTavishLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McTavishLab/subscriptions","organizations_url":"https://api.github.com/users/McTavishLab/orgs","repos_url":"https://api.github.com/users/McTavishLab/repos","events_url":"https://api.github.com/users/McTavishLab/events{/privacy}","received_events_url":"https://api.github.com/users/McTavishLab/received_events","type":"Organization","site_admin":false},"repo":{"id":41294748,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI5NDc0OA==","name":"physcraper","full_name":"McTavishLab/physcraper","private":false,"owner":{"login":"McTavishLab","id":20669363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjY5MzYz","avatar_url":"https://avatars1.githubusercontent.com/u/20669363?v=4","gravatar_id":"","url":"https://api.github.com/users/McTavishLab","html_url":"https://github.com/McTavishLab","followers_url":"https://api.github.com/users/McTavishLab/followers","following_url":"https://api.github.com/users/McTavishLab/following{/other_user}","gists_url":"https://api.github.com/users/McTavishLab/gists{/gist_id}","starred_url":"https://api.github.com/users/McTavishLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McTavishLab/subscriptions","organizations_url":"https://api.github.com/users/McTavishLab/orgs","repos_url":"https://api.github.com/users/McTavishLab/repos","events_url":"https://api.github.com/users/McTavishLab/events{/privacy}","received_events_url":"https://api.github.com/users/McTavishLab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/McTavishLab/physcraper","description":"Gene tree updating","fork":false,"url":"https://api.github.com/repos/McTavishLab/physcraper","forks_url":"https://api.github.com/repos/McTavishLab/physcraper/forks","keys_url":"https://api.github.com/repos/McTavishLab/physcraper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McTavishLab/physcraper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McTavishLab/physcraper/teams","hooks_url":"https://api.github.com/repos/McTavishLab/physcraper/hooks","issue_events_url":"https://api.github.com/repos/McTavishLab/physcraper/issues/events{/number}","events_url":"https://api.github.com/repos/McTavishLab/physcraper/events","assignees_url":"https://api.github.com/repos/McTavishLab/physcraper/assignees{/user}","branches_url":"https://api.github.com/repos/McTavishLab/physcraper/branches{/branch}","tags_url":"https://api.github.com/repos/McTavishLab/physcraper/tags","blobs_url":"https://api.github.com/repos/McTavishLab/physcraper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McTavishLab/physcraper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McTavishLab/physcraper/git/refs{/sha}","trees_url":"https://api.github.com/repos/McTavishLab/physcraper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McTavishLab/physcraper/statuses/{sha}","languages_url":"https://api.github.com/repos/McTavishLab/physcraper/languages","stargazers_url":"https://api.github.com/repos/McTavishLab/physcraper/stargazers","contributors_url":"https://api.github.com/repos/McTavishLab/physcraper/contributors","subscribers_url":"https://api.github.com/repos/McTavishLab/physcraper/subscribers","subscription_url":"https://api.github.com/repos/McTavishLab/physcraper/subscription","commits_url":"https://api.github.com/repos/McTavishLab/physcraper/commits{/sha}","git_commits_url":"https://api.github.com/repos/McTavishLab/physcraper/git/commits{/sha}","comments_url":"https://api.github.com/repos/McTavishLab/physcraper/comments{/number}","issue_comment_url":"https://api.github.com/repos/McTavishLab/physcraper/issues/comments{/number}","contents_url":"https://api.github.com/repos/McTavishLab/physcraper/contents/{+path}","compare_url":"https://api.github.com/repos/McTavishLab/physcraper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McTavishLab/physcraper/merges","archive_url":"https://api.github.com/repos/McTavishLab/physcraper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McTavishLab/physcraper/downloads","issues_url":"https://api.github.com/repos/McTavishLab/physcraper/issues{/number}","pulls_url":"https://api.github.com/repos/McTavishLab/physcraper/pulls{/number}","milestones_url":"https://api.github.com/repos/McTavishLab/physcraper/milestones{/number}","notifications_url":"https://api.github.com/repos/McTavishLab/physcraper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McTavishLab/physcraper/labels{/name}","releases_url":"https://api.github.com/repos/McTavishLab/physcraper/releases{/id}","deployments_url":"https://api.github.com/repos/McTavishLab/physcraper/deployments","created_at":"2015-08-24T09:34:44Z","updated_at":"2018-11-07T01:02:49Z","pushed_at":"2018-11-07T01:10:11Z","git_url":"git://github.com/McTavishLab/physcraper.git","ssh_url":"git@github.com:McTavishLab/physcraper.git","clone_url":"https://github.com/McTavishLab/physcraper.git","svn_url":"https://github.com/McTavishLab/physcraper","homepage":null,"size":26467,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":2,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/McTavishLab/physcraper/pulls/32"},"html":{"href":"https://github.com/McTavishLab/physcraper/pull/32"},"issue":{"href":"https://api.github.com/repos/McTavishLab/physcraper/issues/32"},"comments":{"href":"https://api.github.com/repos/McTavishLab/physcraper/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/McTavishLab/physcraper/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/McTavishLab/physcraper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/McTavishLab/physcraper/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/McTavishLab/physcraper/statuses/875a827bb3e3b9ccdc9eea6f705a3cd75a05e482"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"blubbundbla","id":16088236,"node_id":"MDQ6VXNlcjE2MDg4MjM2","avatar_url":"https://avatars2.githubusercontent.com/u/16088236?v=4","gravatar_id":"","url":"https://api.github.com/users/blubbundbla","html_url":"https://github.com/blubbundbla","followers_url":"https://api.github.com/users/blubbundbla/followers","following_url":"https://api.github.com/users/blubbundbla/following{/other_user}","gists_url":"https://api.github.com/users/blubbundbla/gists{/gist_id}","starred_url":"https://api.github.com/users/blubbundbla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blubbundbla/subscriptions","organizations_url":"https://api.github.com/users/blubbundbla/orgs","repos_url":"https://api.github.com/users/blubbundbla/repos","events_url":"https://api.github.com/users/blubbundbla/events{/privacy}","received_events_url":"https://api.github.com/users/blubbundbla/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":20,"deletions":31,"changed_files":4}}
{"actor":{"display_login":"blubbundbla"}}