{"action":"closed","number":214,"pull_request":{"url":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/214","id":177797574,"html_url":"https://github.com/PowerShell/DscResource.Tests/pull/214","diff_url":"https://github.com/PowerShell/DscResource.Tests/pull/214.diff","patch_url":"https://github.com/PowerShell/DscResource.Tests/pull/214.patch","issue_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues/214","number":214,"state":"closed","locked":false,"title":"Container testing - Handling of tag for images are now correct","user":{"login":"johlju","id":7189721,"avatar_url":"https://avatars0.githubusercontent.com/u/7189721?v=4","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"body":"- Fix container bugs\r\n  - Handling of tag for images are now correct.\r\n  - Correct message is displayed when downloading an image.\r\n\r\nA bug snuck in during the review that I didn't see until I was updated SqlServerDsc with this. We added 'latest' tag to the image name, didn't realize that it broke evaluation for existing container images, so it ended up pulling the latest image from Docker Hub, which takes \"forever\".\r\nThis PR solves the evaluation so it can handle the tag 'latest'. This fix is needed for the next iteration of container testing as well.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/dscresource.tests/214)\n<!-- Reviewable:end -->\n","created_at":"2018-03-27T16:33:34Z","updated_at":"2018-04-02T07:27:32Z","closed_at":"2018-04-02T07:27:32Z","merged_at":null,"merge_commit_sha":"a6fdd7b47b4231e43a78f058959668abce7f215d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/214/commits","review_comments_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/214/comments","review_comment_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues/214/comments","statuses_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/statuses/2a92aad66ec8882a505a7058e5ceb21a54830d0d","head":{"label":"johlju:fix-container","ref":"fix-container","sha":"2a92aad66ec8882a505a7058e5ceb21a54830d0d","user":{"login":"johlju","id":7189721,"avatar_url":"https://avatars0.githubusercontent.com/u/7189721?v=4","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"repo":{"id":81187750,"name":"DscResource.Tests","full_name":"johlju/DscResource.Tests","owner":{"login":"johlju","id":7189721,"avatar_url":"https://avatars0.githubusercontent.com/u/7189721?v=4","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johlju/DscResource.Tests","description":"Common meta tests for PowerShell DSC resources repositories.","fork":true,"url":"https://api.github.com/repos/johlju/DscResource.Tests","forks_url":"https://api.github.com/repos/johlju/DscResource.Tests/forks","keys_url":"https://api.github.com/repos/johlju/DscResource.Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johlju/DscResource.Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johlju/DscResource.Tests/teams","hooks_url":"https://api.github.com/repos/johlju/DscResource.Tests/hooks","issue_events_url":"https://api.github.com/repos/johlju/DscResource.Tests/issues/events{/number}","events_url":"https://api.github.com/repos/johlju/DscResource.Tests/events","assignees_url":"https://api.github.com/repos/johlju/DscResource.Tests/assignees{/user}","branches_url":"https://api.github.com/repos/johlju/DscResource.Tests/branches{/branch}","tags_url":"https://api.github.com/repos/johlju/DscResource.Tests/tags","blobs_url":"https://api.github.com/repos/johlju/DscResource.Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johlju/DscResource.Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johlju/DscResource.Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/johlju/DscResource.Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johlju/DscResource.Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/johlju/DscResource.Tests/languages","stargazers_url":"https://api.github.com/repos/johlju/DscResource.Tests/stargazers","contributors_url":"https://api.github.com/repos/johlju/DscResource.Tests/contributors","subscribers_url":"https://api.github.com/repos/johlju/DscResource.Tests/subscribers","subscription_url":"https://api.github.com/repos/johlju/DscResource.Tests/subscription","commits_url":"https://api.github.com/repos/johlju/DscResource.Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/johlju/DscResource.Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/johlju/DscResource.Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/johlju/DscResource.Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/johlju/DscResource.Tests/contents/{+path}","compare_url":"https://api.github.com/repos/johlju/DscResource.Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johlju/DscResource.Tests/merges","archive_url":"https://api.github.com/repos/johlju/DscResource.Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johlju/DscResource.Tests/downloads","issues_url":"https://api.github.com/repos/johlju/DscResource.Tests/issues{/number}","pulls_url":"https://api.github.com/repos/johlju/DscResource.Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/johlju/DscResource.Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/johlju/DscResource.Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johlju/DscResource.Tests/labels{/name}","releases_url":"https://api.github.com/repos/johlju/DscResource.Tests/releases{/id}","deployments_url":"https://api.github.com/repos/johlju/DscResource.Tests/deployments","created_at":"2017-02-07T08:59:09Z","updated_at":"2018-03-27T14:12:43Z","pushed_at":"2018-04-02T07:25:40Z","git_url":"git://github.com/johlju/DscResource.Tests.git","ssh_url":"git@github.com:johlju/DscResource.Tests.git","clone_url":"https://github.com/johlju/DscResource.Tests.git","svn_url":"https://github.com/johlju/DscResource.Tests","homepage":null,"size":515,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"PowerShell:dev","ref":"dev","sha":"0cc18de707a9e25e7ddf04916020ef5633ae1d76","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":33632903,"name":"DscResource.Tests","full_name":"PowerShell/DscResource.Tests","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/DscResource.Tests","description":"Common meta tests for PowerShell DSC resources repositories.","fork":false,"url":"https://api.github.com/repos/PowerShell/DscResource.Tests","forks_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/forks","keys_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/teams","hooks_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/events","assignees_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/tags","blobs_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/languages","stargazers_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/subscription","commits_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/merges","archive_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/downloads","issues_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/DscResource.Tests/deployments","created_at":"2015-04-08T21:21:19Z","updated_at":"2018-03-27T23:37:37Z","pushed_at":"2018-03-29T21:17:58Z","git_url":"git://github.com/PowerShell/DscResource.Tests.git","ssh_url":"git@github.com:PowerShell/DscResource.Tests.git","clone_url":"https://github.com/PowerShell/DscResource.Tests.git","svn_url":"https://github.com/PowerShell/DscResource.Tests","homepage":null,"size":657,"stargazers_count":32,"watchers_count":32,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":32,"open_issues":25,"watchers":32,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/214"},"html":{"href":"https://github.com/PowerShell/DscResource.Tests/pull/214"},"issue":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues/214"},"comments":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/DscResource.Tests/statuses/2a92aad66ec8882a505a7058e5ceb21a54830d0d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":29,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"johlju"}}