{"action":"created","issue":{"url":"https://api.github.com/repos/flarum/core/issues/1596","repository_url":"https://api.github.com/repos/flarum/core","labels_url":"https://api.github.com/repos/flarum/core/issues/1596/labels{/name}","comments_url":"https://api.github.com/repos/flarum/core/issues/1596/comments","events_url":"https://api.github.com/repos/flarum/core/issues/1596/events","html_url":"https://github.com/flarum/core/pull/1596","id":367460015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODg4Mjk0","number":1596,"title":"Mark notification as read without visiting discussion","user":{"login":"datitisev","id":6401250,"node_id":"MDQ6VXNlcjY0MDEyNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/6401250?v=4","gravatar_id":"","url":"https://api.github.com/users/datitisev","html_url":"https://github.com/datitisev","followers_url":"https://api.github.com/users/datitisev/followers","following_url":"https://api.github.com/users/datitisev/following{/other_user}","gists_url":"https://api.github.com/users/datitisev/gists{/gist_id}","starred_url":"https://api.github.com/users/datitisev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datitisev/subscriptions","organizations_url":"https://api.github.com/users/datitisev/orgs","repos_url":"https://api.github.com/users/datitisev/repos","events_url":"https://api.github.com/users/datitisev/events{/privacy}","received_events_url":"https://api.github.com/users/datitisev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-06T14:04:25Z","updated_at":"2018-11-03T18:00:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/flarum/core/pulls/1596","html_url":"https://github.com/flarum/core/pull/1596","diff_url":"https://github.com/flarum/core/pull/1596.diff","patch_url":"https://github.com/flarum/core/pull/1596.patch"},"body":"<!--\r\nIMPORTANT: We applaud pull requests, they excite us every single time. As we have an obligation to maintain a healthy code standard and quality, we take sufficient time for reviews. Please do create a separate pull request per change/issue/feature; we will ask you to split bundled pull requests.\r\n-->\r\n\r\n**Fixes #151**\r\n\r\n**Changes proposed in this pull request:**\r\n- `Notification` component now has a checkbox to mark notification as read\r\n\r\n**Reviewers should focus on:**\r\n- Do we really need `slidable` with this? The current structure of notifications made it hard, and I was unable to integrate the `slidable` util... though I have never used it before, so that may be why.\r\n- Is `core.forum.notifications.mark_as_read_tooltip` ok?\r\n\r\n**Screenshot**\r\n![screen recording 2018-10-06 at 10 01 40 am](https://user-images.githubusercontent.com/6401250/46572155-12cfae80-c94f-11e8-983f-cb18f20fce02.gif)\r\n\r\n\r\n**Confirmed**\r\n\r\n- [x] Frontend changes: tested on a local Flarum installation.\r\n- [ ] Backend changes: tests are green (run `php vendor/bin/phpunit`).\r\n\r\n**Required changes:**\r\n\r\n- [ ] Related core extension PRs: `flarum/english` needed, waiting on confirmation for translation key"},"comment":{"url":"https://api.github.com/repos/flarum/core/issues/comments/435608239","html_url":"https://github.com/flarum/core/pull/1596#issuecomment-435608239","issue_url":"https://api.github.com/repos/flarum/core/issues/1596","id":435608239,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTYwODIzOQ==","user":{"login":"matteocontrini","id":2164763,"node_id":"MDQ6VXNlcjIxNjQ3NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2164763?v=4","gravatar_id":"","url":"https://api.github.com/users/matteocontrini","html_url":"https://github.com/matteocontrini","followers_url":"https://api.github.com/users/matteocontrini/followers","following_url":"https://api.github.com/users/matteocontrini/following{/other_user}","gists_url":"https://api.github.com/users/matteocontrini/gists{/gist_id}","starred_url":"https://api.github.com/users/matteocontrini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteocontrini/subscriptions","organizations_url":"https://api.github.com/users/matteocontrini/orgs","repos_url":"https://api.github.com/users/matteocontrini/repos","events_url":"https://api.github.com/users/matteocontrini/events{/privacy}","received_events_url":"https://api.github.com/users/matteocontrini/received_events","type":"User","site_admin":false},"created_at":"2018-11-03T18:00:17Z","updated_at":"2018-11-03T18:00:17Z","author_association":"NONE","body":"Wouldn't it be better to show the tick only when hovering the notification?"}}
{"actor":{"display_login":"matteocontrini"}}