{"action":"opened","issue":{"url":"https://api.github.com/repos/HackSoc/hacksoc.org/issues/66","repository_url":"https://api.github.com/repos/HackSoc/hacksoc.org","labels_url":"https://api.github.com/repos/HackSoc/hacksoc.org/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/HackSoc/hacksoc.org/issues/66/comments","events_url":"https://api.github.com/repos/HackSoc/hacksoc.org/issues/66/events","html_url":"https://github.com/HackSoc/hacksoc.org/issues/66","id":338758396,"node_id":"MDU6SXNzdWUzMzg3NTgzOTY=","number":66,"title":"Minor content issues in site revamp","user":{"login":"JMAlego","id":6897912,"node_id":"MDQ6VXNlcjY4OTc5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6897912?v=4","gravatar_id":"","url":"https://api.github.com/users/JMAlego","html_url":"https://github.com/JMAlego","followers_url":"https://api.github.com/users/JMAlego/followers","following_url":"https://api.github.com/users/JMAlego/following{/other_user}","gists_url":"https://api.github.com/users/JMAlego/gists{/gist_id}","starred_url":"https://api.github.com/users/JMAlego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMAlego/subscriptions","organizations_url":"https://api.github.com/users/JMAlego/orgs","repos_url":"https://api.github.com/users/JMAlego/repos","events_url":"https://api.github.com/users/JMAlego/events{/privacy}","received_events_url":"https://api.github.com/users/JMAlego/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-05T23:33:46Z","updated_at":"2018-07-05T23:33:46Z","closed_at":null,"author_association":"NONE","body":"There are several minor content issues (grammar, style, typos, etc.) on the website, or introduced by the revamp, which should be corrected as part of the website revamp (see PR #65). Some of the issues are up for debate as to whether the suggested changes are needed (mainly issues labeled style).\r\n\r\n(_Warning: the below list is not sorted by type of issue, this may annoy some people._)\r\n\r\n- [ ] Style: In general newer content has paragraphs on all one line, whereas older content has paragraphs broken onto multiple lines. We should pick one style and stick to it. An perfect example of this can be seen in the paragraphs below. https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/irc.html#L16-L20\r\n- [ ] Typo: On the about page the below line should read \"Look out for our posters in the [Computer Science](https://tvtropes.org/pmwiki/pmwiki.php/Main/MeaningfulEcho) department.\" https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/about.html#L29 Though this could be further changed to reflect the digital nature of future \"posters\".\r\n- [ ]  Style: On the about page the below paragraph has inconsistent capitalisation, newer positions [Are in Title Case](https://tvtropes.org/pmwiki/pmwiki.php/Main/SelfDemonstratingArticle), whereas older positions are all lower case. https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/about.html#L56-L59\r\n- [ ] Grammar: On the about page below paragraph should have a comma before the \"such as\" as it is a nonrestrictive use of \"such as\". https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/about.html#L31-L33\r\n- [ ] Grammar: On the IRC page the below line should have a capital \"a\" after the question mark. https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/irc.html#L6\r\n- [ ] Nitpick: Pointless extra newline which ruins the pattern. See below blank newline (because I have [gone mad with the referencing power](https://tvtropes.org/pmwiki/pmwiki.php/Main/DrunkWithPower)). https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/templates/index.handlebars#L23\r\n- [ ] Grammar: On the runciman server page there should be a full stop at the end of the bellow line. https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/servers/runciman.md#L28\r\n- [ ] Grammar: On the IRC page there should be a full stop at the end of the below sentence. https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/irc.html#L10-L11\r\n- [ ] Style: We may consider changing this section so that [Computer Science](https://tvtropes.org/pmwiki/pmwiki.php/Main/SelfDemonstratingArticle) is in title case as [Computer Science](https://tvtropes.org/pmwiki/pmwiki.php/Main/OverusedRunningGag) is regularly in title case elsewhere on the about page.\r\nhttps://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/about.html#L61-L88\r\n- [ ] Style: Slack should be written as a proper noun (with a capital first letter) on the below lines, possibly covered by #64 however I thought it important to list the actual lines.\r\n https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/irc.html#L16 https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/regular/irc.html#L10\r\n- [ ] Typo: Use of \"cannonicalize\" in the below comment should be \"canonicalise\". https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/main.js#L11 We're going [Up To Eleven](https://tvtropes.org/pmwiki/pmwiki.php/Main/UpToEleven) in nitpicking (on line 11, no less) on this one.\r\n\r\nAs a small note: I hope the below lines don't render as strike throughs in the final version as they do on github (I'm currently unable to check due to being in Wales). I assume they don't and it's just me worrying. https://github.com/HackSoc/hacksoc.org/blob/1bbef358249b4fb6821a233a2fcb934c0efef04e/servers/runciman.md#L32\r\n\r\n(I also offer this issue as an example of [this phenomenon](https://tvtropes.org/pmwiki/pmwiki.php/JustForFun/TVTropesWillRuinYourVocabulary).)"}}
{"actor":{"display_login":"JMAlego"}}