{"action":"created","issue":{"url":"https://api.github.com/repos/FluxNotes/flux/issues/515","repository_url":"https://api.github.com/repos/FluxNotes/flux","labels_url":"https://api.github.com/repos/FluxNotes/flux/issues/515/labels{/name}","comments_url":"https://api.github.com/repos/FluxNotes/flux/issues/515/comments","events_url":"https://api.github.com/repos/FluxNotes/flux/issues/515/events","html_url":"https://github.com/FluxNotes/flux/pull/515","id":379162056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjkzOTc1","number":515,"title":"Add remove minimap sections","user":{"login":"jafeltra","id":30803904,"node_id":"MDQ6VXNlcjMwODAzOTA0","avatar_url":"https://avatars0.githubusercontent.com/u/30803904?v=4","gravatar_id":"","url":"https://api.github.com/users/jafeltra","html_url":"https://github.com/jafeltra","followers_url":"https://api.github.com/users/jafeltra/followers","following_url":"https://api.github.com/users/jafeltra/following{/other_user}","gists_url":"https://api.github.com/users/jafeltra/gists{/gist_id}","starred_url":"https://api.github.com/users/jafeltra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafeltra/subscriptions","organizations_url":"https://api.github.com/users/jafeltra/orgs","repos_url":"https://api.github.com/users/jafeltra/repos","events_url":"https://api.github.com/users/jafeltra/events{/privacy}","received_events_url":"https://api.github.com/users/jafeltra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"danlee1025","id":6588796,"node_id":"MDQ6VXNlcjY1ODg3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6588796?v=4","gravatar_id":"","url":"https://api.github.com/users/danlee1025","html_url":"https://github.com/danlee1025","followers_url":"https://api.github.com/users/danlee1025/followers","following_url":"https://api.github.com/users/danlee1025/following{/other_user}","gists_url":"https://api.github.com/users/danlee1025/gists{/gist_id}","starred_url":"https://api.github.com/users/danlee1025/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlee1025/subscriptions","organizations_url":"https://api.github.com/users/danlee1025/orgs","repos_url":"https://api.github.com/users/danlee1025/repos","events_url":"https://api.github.com/users/danlee1025/events{/privacy}","received_events_url":"https://api.github.com/users/danlee1025/received_events","type":"User","site_admin":false},"assignees":[{"login":"danlee1025","id":6588796,"node_id":"MDQ6VXNlcjY1ODg3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6588796?v=4","gravatar_id":"","url":"https://api.github.com/users/danlee1025","html_url":"https://github.com/danlee1025","followers_url":"https://api.github.com/users/danlee1025/followers","following_url":"https://api.github.com/users/danlee1025/following{/other_user}","gists_url":"https://api.github.com/users/danlee1025/gists{/gist_id}","starred_url":"https://api.github.com/users/danlee1025/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlee1025/subscriptions","organizations_url":"https://api.github.com/users/danlee1025/orgs","repos_url":"https://api.github.com/users/danlee1025/repos","events_url":"https://api.github.com/users/danlee1025/events{/privacy}","received_events_url":"https://api.github.com/users/danlee1025/received_events","type":"User","site_admin":false},{"login":"karenzheung","id":15273981,"node_id":"MDQ6VXNlcjE1MjczOTgx","avatar_url":"https://avatars0.githubusercontent.com/u/15273981?v=4","gravatar_id":"","url":"https://api.github.com/users/karenzheung","html_url":"https://github.com/karenzheung","followers_url":"https://api.github.com/users/karenzheung/followers","following_url":"https://api.github.com/users/karenzheung/following{/other_user}","gists_url":"https://api.github.com/users/karenzheung/gists{/gist_id}","starred_url":"https://api.github.com/users/karenzheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenzheung/subscriptions","organizations_url":"https://api.github.com/users/karenzheung/orgs","repos_url":"https://api.github.com/users/karenzheung/repos","events_url":"https://api.github.com/users/karenzheung/events{/privacy}","received_events_url":"https://api.github.com/users/karenzheung/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-09T13:28:57Z","updated_at":"2018-11-09T16:58:31Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/FluxNotes/flux/pulls/515","html_url":"https://github.com/FluxNotes/flux/pull/515","diff_url":"https://github.com/FluxNotes/flux/pull/515.diff","patch_url":"https://github.com/FluxNotes/flux/pull/515.patch"},"body":"_Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (**N/A**) and :white_check_mark:._\r\n\r\nAdds support for adding and removing sections of the minimap. Use the Edit button to make changes to the sections displayed in the minimap. Clicking on sections either removes or adds them back to the minimap, as described in the designs for this feature. Preferences are stored in the preference manager and are specific to each condition. While editing the minimap, the rest of the app is disabled. I'm going to make another jira to make these changes more generic and fork the minimap repository so we can use that rather than our local version in the lib/ directory. If anyone thinks that should be part of this task instead though, just let me know.\r\n\r\n## Submitter:\r\n\r\n**Running the Application**\r\n\r\n- [x] Manually tested in Chrome\r\n- [ ] Manually tested in IE\r\n\r\n**Documentation**\r\n\r\n- [x] This pull request describes why these changes were made\r\n- [x] Recognizes any potential shortcomings/bugs in the description \r\n- [ ] Cheat sheet is updated\r\n- [ ] Demo script is updated \r\n- [ ] Documentation on Wiki has been updated \r\n- [ ] Additional technical components and libraries are documented and added to wiki as needed\r\n\r\n**NoteParser**\r\n\r\n- [ ] Note parser has been updated if structured phrases change\r\n\r\n**Code Quality**\r\n\r\n- [x] 4-space indents - convert any tabs to spaces\r\n- [x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };\r\n- [x] Code is commented\r\n\r\n**Tests**\r\n\r\n- [x] Existing tests passed\r\n- [ ] Added Enzyme-UI tests for slim mode \r\n- [ ] Added Enzyme-UI tests for full mode\r\n- [ ] Added backend tests for new functionality added\r\n- [ ] Added note parser examples to test new functionality\r\n\r\n\r\n## Reviewer 1: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\n\r\n## Reviewer 2: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n"},"comment":{"url":"https://api.github.com/repos/FluxNotes/flux/issues/comments/437423885","html_url":"https://github.com/FluxNotes/flux/pull/515#issuecomment-437423885","issue_url":"https://api.github.com/repos/FluxNotes/flux/issues/515","id":437423885,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzQyMzg4NQ==","user":{"login":"danlee1025","id":6588796,"node_id":"MDQ6VXNlcjY1ODg3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6588796?v=4","gravatar_id":"","url":"https://api.github.com/users/danlee1025","html_url":"https://github.com/danlee1025","followers_url":"https://api.github.com/users/danlee1025/followers","following_url":"https://api.github.com/users/danlee1025/following{/other_user}","gists_url":"https://api.github.com/users/danlee1025/gists{/gist_id}","starred_url":"https://api.github.com/users/danlee1025/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlee1025/subscriptions","organizations_url":"https://api.github.com/users/danlee1025/orgs","repos_url":"https://api.github.com/users/danlee1025/repos","events_url":"https://api.github.com/users/danlee1025/events{/privacy}","received_events_url":"https://api.github.com/users/danlee1025/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T16:58:31Z","updated_at":"2018-11-09T16:58:31Z","author_association":"COLLABORATOR","body":"[DL2]  When I am in POC mode and click the edit button, I can still interact with POC panel, edit note title, and close the note.\r\n[DL3]  Sign note button is clickable when editing sections.\r\n\r\nI don't think these things have huge effects but if we want to disable our whole app when editing we should probably disable these also."}}
{"actor":{"display_login":"danlee1025"}}