{"action":"closed","number":44522,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44522","id":206257639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjU3NjM5","html_url":"https://github.com/NixOS/nixpkgs/pull/44522","diff_url":"https://github.com/NixOS/nixpkgs/pull/44522.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44522.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44522","number":44522,"state":"closed","locked":false,"title":"citrix_receiver: allow custom certs and hooks for the installation","user":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nSometimes it's required to modify some parts of the Citrix build on\r\ntheir own which is why `{pre,post}Install` hooks can be quite helpful.\r\n\r\nAdditionally some corporate clients use their own certificates that\r\naren't stored as trusted ones in the `cacert` package with all of the\r\ntrusted certs by Mozilla.\r\n\r\nNow it's possible to add custom certs like this:\r\n\r\n``` nix\r\nwith import <nixpkgs> { config.allowUnfree = true; };\r\n\r\nlet path = ../../Downloads/custom-corporate-cert.pem; in\r\ncitrix_receiver.override {\r\n  extraCerts = [ path ];\r\n}\r\n```\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-05T21:03:09Z","updated_at":"2018-08-07T00:29:50Z","closed_at":"2018-08-07T00:29:50Z","merged_at":"2018-08-07T00:29:50Z","merge_commit_sha":"893b080e5628af07199b2510ead18c0cf17cbb5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122988,"node_id":"MDU6TGFiZWwyOTAxMjI5ODg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20clean-up","name":"8.has: clean-up","color":"009800","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44522/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44522/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44522/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/3d7b147a2c6381f71cabc5b317fb9747d1e12806","head":{"label":"Ma27:allow-citrix-custom-certs","ref":"allow-citrix-custom-certs","sha":"3d7b147a2c6381f71cabc5b317fb9747d1e12806","user":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"repo":{"id":99414967,"node_id":"MDEwOlJlcG9zaXRvcnk5OTQxNDk2Nw==","name":"nixpkgs","full_name":"Ma27/nixpkgs","owner":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ma27/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Ma27/nixpkgs","forks_url":"https://api.github.com/repos/Ma27/nixpkgs/forks","keys_url":"https://api.github.com/repos/Ma27/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ma27/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ma27/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Ma27/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Ma27/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Ma27/nixpkgs/events","assignees_url":"https://api.github.com/repos/Ma27/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Ma27/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Ma27/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Ma27/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ma27/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ma27/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ma27/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ma27/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Ma27/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Ma27/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Ma27/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Ma27/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Ma27/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Ma27/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ma27/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ma27/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ma27/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ma27/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Ma27/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ma27/nixpkgs/merges","archive_url":"https://api.github.com/repos/Ma27/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ma27/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Ma27/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Ma27/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Ma27/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Ma27/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ma27/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Ma27/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Ma27/nixpkgs/deployments","created_at":"2017-08-05T10:08:19Z","updated_at":"2018-08-06T20:25:27Z","pushed_at":"2018-08-06T20:25:25Z","git_url":"git://github.com/Ma27/nixpkgs.git","ssh_url":"git@github.com:Ma27/nixpkgs.git","clone_url":"https://github.com/Ma27/nixpkgs.git","svn_url":"https://github.com/Ma27/nixpkgs","homepage":null,"size":723803,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"0d7170cb85be83ff803b7f705bcc55bc38cf71ae","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-07T00:29:43Z","pushed_at":"2018-08-07T00:29:50Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":833167,"stargazers_count":2620,"watchers_count":2620,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2928,"mirror_url":null,"archived":false,"open_issues_count":3057,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2928,"open_issues":3057,"watchers":2620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44522"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44522"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44522"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44522/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44522/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44522/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/3d7b147a2c6381f71cabc5b317fb9747d1e12806"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"comments":9,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":46,"deletions":55,"changed_files":3}}
{"actor":{"display_login":"Mic92"}}