{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/14797","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/14797/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/14797/comments","events_url":"https://api.github.com/repos/electron/electron/issues/14797/events","html_url":"https://github.com/electron/electron/pull/14797","id":363517693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3OTM1MzM4","number":14797,"title":"docs: fix dead links and update Windows build instructions","user":{"login":"MartinMa","id":123297,"node_id":"MDQ6VXNlcjEyMzI5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/123297?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinMa","html_url":"https://github.com/MartinMa","followers_url":"https://api.github.com/users/MartinMa/followers","following_url":"https://api.github.com/users/MartinMa/following{/other_user}","gists_url":"https://api.github.com/users/MartinMa/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinMa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinMa/subscriptions","organizations_url":"https://api.github.com/users/MartinMa/orgs","repos_url":"https://api.github.com/users/MartinMa/repos","events_url":"https://api.github.com/users/MartinMa/events{/privacy}","received_events_url":"https://api.github.com/users/MartinMa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-25T10:49:42Z","updated_at":"2018-10-22T08:29:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/14797","html_url":"https://github.com/electron/electron/pull/14797","diff_url":"https://github.com/electron/electron/pull/14797.diff","patch_url":"https://github.com/electron/electron/pull/14797.patch"},"body":"##### Description of Change\r\nFix dead links (to macOS build instructions) and improve instructions for building on Windows 10.\r\n\r\n/cc @nornagon @codebytere @jkleinsc\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n\r\n\r\n##### Release Notes\r\n<!-- Used to describe release notes for future release versions. See https://github.com/electron/clerk/blob/master/README.md for details. -->\r\n\r\nNotes: no-notes"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/431771987","html_url":"https://github.com/electron/electron/pull/14797#issuecomment-431771987","issue_url":"https://api.github.com/repos/electron/electron/issues/14797","id":431771987,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTc3MTk4Nw==","user":{"login":"MartinMa","id":123297,"node_id":"MDQ6VXNlcjEyMzI5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/123297?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinMa","html_url":"https://github.com/MartinMa","followers_url":"https://api.github.com/users/MartinMa/followers","following_url":"https://api.github.com/users/MartinMa/following{/other_user}","gists_url":"https://api.github.com/users/MartinMa/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinMa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinMa/subscriptions","organizations_url":"https://api.github.com/users/MartinMa/orgs","repos_url":"https://api.github.com/users/MartinMa/repos","events_url":"https://api.github.com/users/MartinMa/events{/privacy}","received_events_url":"https://api.github.com/users/MartinMa/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T08:29:14Z","updated_at":"2018-10-22T08:29:14Z","author_association":"NONE","body":"@MarshallOfSound Thanks, I didn't see that. I updated and rebased my fork and resolved all conflicts (see [this commit](https://github.com/MartinMa/electron/commit/3b41118be79decd3417a6e45487dee8a23eca6cb)). Weirdly enough, the changes don't seem to be picked up by GitHub in this PR.\r\n\r\nAny idea on how to resolve this? Maybe create a new PR?"}}
{"actor":{"display_login":"MartinMa"}}