{"action":"closed","number":466,"pull_request":{"url":"https://api.github.com/repos/mzmine/mzmine2/pulls/466","id":209833824,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODMzODI0","html_url":"https://github.com/mzmine/mzmine2/pull/466","diff_url":"https://github.com/mzmine/mzmine2/pull/466.diff","patch_url":"https://github.com/mzmine/mzmine2/pull/466.patch","issue_url":"https://api.github.com/repos/mzmine/mzmine2/issues/466","number":466,"state":"closed","locked":false,"title":"Streams/parallel streams for PeakListRows","user":{"login":"robinschmid","id":10366914,"node_id":"MDQ6VXNlcjEwMzY2OTE0","avatar_url":"https://avatars3.githubusercontent.com/u/10366914?v=4","gravatar_id":"","url":"https://api.github.com/users/robinschmid","html_url":"https://github.com/robinschmid","followers_url":"https://api.github.com/users/robinschmid/followers","following_url":"https://api.github.com/users/robinschmid/following{/other_user}","gists_url":"https://api.github.com/users/robinschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/robinschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinschmid/subscriptions","organizations_url":"https://api.github.com/users/robinschmid/orgs","repos_url":"https://api.github.com/users/robinschmid/repos","events_url":"https://api.github.com/users/robinschmid/events{/privacy}","received_events_url":"https://api.github.com/users/robinschmid/received_events","type":"User","site_admin":false},"body":"Hey Tomas,\r\nHey Ming,\r\n\r\nafter revising my multithreaded PeakFinder and ming’s great changes to the SameRange gap-fill, this pull request adds stream methods `stream` and `parallelStream` to PeakList. Ming’s SameRangeTask is not included. I am going to send you some small ideas/adaptions for the SameRangeTask. \r\n\r\nTo further discuss parallel processing in MZmine, see #465.\r\n\r\n- `peakList.parallelStream().forEach(sourceRow ->`\r\n- Removed locking from MultithreadedPeakFinder\r\n- Changed to ConcurrentHashMap<RawDataFile, Feature>\r\n  - Seems to be faster than Hashtable\r\n- Option to use parallelStream (RawDataFiles) in basic PeakFinder\r\n  - Another option to perform parallel gap fill\r\n\r\n\r\nCheers,\r\nRobin\r\n","created_at":"2018-08-21T13:52:59Z","updated_at":"2018-08-22T10:15:23Z","closed_at":"2018-08-22T10:15:23Z","merged_at":null,"merge_commit_sha":"09bdce8568570e3329b4c45257592c13f71e1e5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mzmine/mzmine2/pulls/466/commits","review_comments_url":"https://api.github.com/repos/mzmine/mzmine2/pulls/466/comments","review_comment_url":"https://api.github.com/repos/mzmine/mzmine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mzmine/mzmine2/issues/466/comments","statuses_url":"https://api.github.com/repos/mzmine/mzmine2/statuses/3d0c146493d824238d4a310fb137b7953985ddb5","head":{"label":"robinschmid:tomasmaster_peaklistrow_streams","ref":"tomasmaster_peaklistrow_streams","sha":"3d0c146493d824238d4a310fb137b7953985ddb5","user":{"login":"robinschmid","id":10366914,"node_id":"MDQ6VXNlcjEwMzY2OTE0","avatar_url":"https://avatars3.githubusercontent.com/u/10366914?v=4","gravatar_id":"","url":"https://api.github.com/users/robinschmid","html_url":"https://github.com/robinschmid","followers_url":"https://api.github.com/users/robinschmid/followers","following_url":"https://api.github.com/users/robinschmid/following{/other_user}","gists_url":"https://api.github.com/users/robinschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/robinschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinschmid/subscriptions","organizations_url":"https://api.github.com/users/robinschmid/orgs","repos_url":"https://api.github.com/users/robinschmid/repos","events_url":"https://api.github.com/users/robinschmid/events{/privacy}","received_events_url":"https://api.github.com/users/robinschmid/received_events","type":"User","site_admin":false},"repo":{"id":64870847,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg3MDg0Nw==","name":"mzmine2","full_name":"robinschmid/mzmine2","owner":{"login":"robinschmid","id":10366914,"node_id":"MDQ6VXNlcjEwMzY2OTE0","avatar_url":"https://avatars3.githubusercontent.com/u/10366914?v=4","gravatar_id":"","url":"https://api.github.com/users/robinschmid","html_url":"https://github.com/robinschmid","followers_url":"https://api.github.com/users/robinschmid/followers","following_url":"https://api.github.com/users/robinschmid/following{/other_user}","gists_url":"https://api.github.com/users/robinschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/robinschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinschmid/subscriptions","organizations_url":"https://api.github.com/users/robinschmid/orgs","repos_url":"https://api.github.com/users/robinschmid/repos","events_url":"https://api.github.com/users/robinschmid/events{/privacy}","received_events_url":"https://api.github.com/users/robinschmid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robinschmid/mzmine2","description":"MZmine 2 source repository","fork":true,"url":"https://api.github.com/repos/robinschmid/mzmine2","forks_url":"https://api.github.com/repos/robinschmid/mzmine2/forks","keys_url":"https://api.github.com/repos/robinschmid/mzmine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robinschmid/mzmine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robinschmid/mzmine2/teams","hooks_url":"https://api.github.com/repos/robinschmid/mzmine2/hooks","issue_events_url":"https://api.github.com/repos/robinschmid/mzmine2/issues/events{/number}","events_url":"https://api.github.com/repos/robinschmid/mzmine2/events","assignees_url":"https://api.github.com/repos/robinschmid/mzmine2/assignees{/user}","branches_url":"https://api.github.com/repos/robinschmid/mzmine2/branches{/branch}","tags_url":"https://api.github.com/repos/robinschmid/mzmine2/tags","blobs_url":"https://api.github.com/repos/robinschmid/mzmine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robinschmid/mzmine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robinschmid/mzmine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/robinschmid/mzmine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robinschmid/mzmine2/statuses/{sha}","languages_url":"https://api.github.com/repos/robinschmid/mzmine2/languages","stargazers_url":"https://api.github.com/repos/robinschmid/mzmine2/stargazers","contributors_url":"https://api.github.com/repos/robinschmid/mzmine2/contributors","subscribers_url":"https://api.github.com/repos/robinschmid/mzmine2/subscribers","subscription_url":"https://api.github.com/repos/robinschmid/mzmine2/subscription","commits_url":"https://api.github.com/repos/robinschmid/mzmine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/robinschmid/mzmine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/robinschmid/mzmine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/robinschmid/mzmine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/robinschmid/mzmine2/contents/{+path}","compare_url":"https://api.github.com/repos/robinschmid/mzmine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robinschmid/mzmine2/merges","archive_url":"https://api.github.com/repos/robinschmid/mzmine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robinschmid/mzmine2/downloads","issues_url":"https://api.github.com/repos/robinschmid/mzmine2/issues{/number}","pulls_url":"https://api.github.com/repos/robinschmid/mzmine2/pulls{/number}","milestones_url":"https://api.github.com/repos/robinschmid/mzmine2/milestones{/number}","notifications_url":"https://api.github.com/repos/robinschmid/mzmine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robinschmid/mzmine2/labels{/name}","releases_url":"https://api.github.com/repos/robinschmid/mzmine2/releases{/id}","deployments_url":"https://api.github.com/repos/robinschmid/mzmine2/deployments","created_at":"2016-08-03T18:44:47Z","updated_at":"2018-08-13T12:44:18Z","pushed_at":"2018-08-21T12:57:59Z","git_url":"git://github.com/robinschmid/mzmine2.git","ssh_url":"git@github.com:robinschmid/mzmine2.git","clone_url":"https://github.com/robinschmid/mzmine2.git","svn_url":"https://github.com/robinschmid/mzmine2","homepage":null,"size":452144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mzmine:master","ref":"master","sha":"3bdb76abdcd98fd8791df1b1f13337229618feb8","user":{"login":"mzmine","id":10829452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODI5NDUy","avatar_url":"https://avatars2.githubusercontent.com/u/10829452?v=4","gravatar_id":"","url":"https://api.github.com/users/mzmine","html_url":"https://github.com/mzmine","followers_url":"https://api.github.com/users/mzmine/followers","following_url":"https://api.github.com/users/mzmine/following{/other_user}","gists_url":"https://api.github.com/users/mzmine/gists{/gist_id}","starred_url":"https://api.github.com/users/mzmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzmine/subscriptions","organizations_url":"https://api.github.com/users/mzmine/orgs","repos_url":"https://api.github.com/users/mzmine/repos","events_url":"https://api.github.com/users/mzmine/events{/privacy}","received_events_url":"https://api.github.com/users/mzmine/received_events","type":"Organization","site_admin":false},"repo":{"id":32782433,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc4MjQzMw==","name":"mzmine2","full_name":"mzmine/mzmine2","owner":{"login":"mzmine","id":10829452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODI5NDUy","avatar_url":"https://avatars2.githubusercontent.com/u/10829452?v=4","gravatar_id":"","url":"https://api.github.com/users/mzmine","html_url":"https://github.com/mzmine","followers_url":"https://api.github.com/users/mzmine/followers","following_url":"https://api.github.com/users/mzmine/following{/other_user}","gists_url":"https://api.github.com/users/mzmine/gists{/gist_id}","starred_url":"https://api.github.com/users/mzmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzmine/subscriptions","organizations_url":"https://api.github.com/users/mzmine/orgs","repos_url":"https://api.github.com/users/mzmine/repos","events_url":"https://api.github.com/users/mzmine/events{/privacy}","received_events_url":"https://api.github.com/users/mzmine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mzmine/mzmine2","description":"MZmine 2 source repository","fork":false,"url":"https://api.github.com/repos/mzmine/mzmine2","forks_url":"https://api.github.com/repos/mzmine/mzmine2/forks","keys_url":"https://api.github.com/repos/mzmine/mzmine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mzmine/mzmine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mzmine/mzmine2/teams","hooks_url":"https://api.github.com/repos/mzmine/mzmine2/hooks","issue_events_url":"https://api.github.com/repos/mzmine/mzmine2/issues/events{/number}","events_url":"https://api.github.com/repos/mzmine/mzmine2/events","assignees_url":"https://api.github.com/repos/mzmine/mzmine2/assignees{/user}","branches_url":"https://api.github.com/repos/mzmine/mzmine2/branches{/branch}","tags_url":"https://api.github.com/repos/mzmine/mzmine2/tags","blobs_url":"https://api.github.com/repos/mzmine/mzmine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mzmine/mzmine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mzmine/mzmine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mzmine/mzmine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mzmine/mzmine2/statuses/{sha}","languages_url":"https://api.github.com/repos/mzmine/mzmine2/languages","stargazers_url":"https://api.github.com/repos/mzmine/mzmine2/stargazers","contributors_url":"https://api.github.com/repos/mzmine/mzmine2/contributors","subscribers_url":"https://api.github.com/repos/mzmine/mzmine2/subscribers","subscription_url":"https://api.github.com/repos/mzmine/mzmine2/subscription","commits_url":"https://api.github.com/repos/mzmine/mzmine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mzmine/mzmine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mzmine/mzmine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mzmine/mzmine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mzmine/mzmine2/contents/{+path}","compare_url":"https://api.github.com/repos/mzmine/mzmine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mzmine/mzmine2/merges","archive_url":"https://api.github.com/repos/mzmine/mzmine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mzmine/mzmine2/downloads","issues_url":"https://api.github.com/repos/mzmine/mzmine2/issues{/number}","pulls_url":"https://api.github.com/repos/mzmine/mzmine2/pulls{/number}","milestones_url":"https://api.github.com/repos/mzmine/mzmine2/milestones{/number}","notifications_url":"https://api.github.com/repos/mzmine/mzmine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mzmine/mzmine2/labels{/name}","releases_url":"https://api.github.com/repos/mzmine/mzmine2/releases{/id}","deployments_url":"https://api.github.com/repos/mzmine/mzmine2/deployments","created_at":"2015-03-24T07:26:14Z","updated_at":"2018-08-20T11:15:23Z","pushed_at":"2018-08-22T00:58:55Z","git_url":"git://github.com/mzmine/mzmine2.git","ssh_url":"git@github.com:mzmine/mzmine2.git","clone_url":"https://github.com/mzmine/mzmine2.git","svn_url":"https://github.com/mzmine/mzmine2","homepage":null,"size":446383,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":76,"open_issues":40,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mzmine/mzmine2/pulls/466"},"html":{"href":"https://github.com/mzmine/mzmine2/pull/466"},"issue":{"href":"https://api.github.com/repos/mzmine/mzmine2/issues/466"},"comments":{"href":"https://api.github.com/repos/mzmine/mzmine2/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/mzmine/mzmine2/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/mzmine/mzmine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mzmine/mzmine2/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/mzmine/mzmine2/statuses/3d0c146493d824238d4a310fb137b7953985ddb5"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":915,"deletions":952,"changed_files":9}}
{"actor":{"display_login":"robinschmid"}}