{"action":"created","issue":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4779","repository_url":"https://api.github.com/repos/reactioncommerce/reaction","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4779/labels{/name}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4779/comments","events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4779/events","html_url":"https://github.com/reactioncommerce/reaction/issues/4779","id":373786950,"node_id":"MDU6SXNzdWUzNzM3ODY5NTA=","number":4779,"title":"Unterminated string constant prevents start","user":{"login":"derBretti","id":6221830,"node_id":"MDQ6VXNlcjYyMjE4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6221830?v=4","gravatar_id":"","url":"https://api.github.com/users/derBretti","html_url":"https://github.com/derBretti","followers_url":"https://api.github.com/users/derBretti/followers","following_url":"https://api.github.com/users/derBretti/following{/other_user}","gists_url":"https://api.github.com/users/derBretti/gists{/gist_id}","starred_url":"https://api.github.com/users/derBretti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derBretti/subscriptions","organizations_url":"https://api.github.com/users/derBretti/orgs","repos_url":"https://api.github.com/users/derBretti/repos","events_url":"https://api.github.com/users/derBretti/events{/privacy}","received_events_url":"https://api.github.com/users/derBretti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-25T06:05:02Z","updated_at":"2018-10-25T15:37:47Z","closed_at":null,"author_association":"NONE","body":"## Issue Description\r\nStarting reaction fails in Windows due to \"Unterminated string constant (1:41)\" error in various files. This happens when running reaction directly, with docker and when using reaction-platform.\r\n\r\n`Errors prevented startup:\r\n\r\nWhile building for web.browser:\r\nimports/plugins/core/graphql/lib/mutations/updateFulfillmentOptionsForGroup.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/createFlatRateFulfillmentMethod.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/updateFlatRateFulfillmentMethod.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/deleteFlatRateFulfillmentMethod.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/placeOrderWithExampleIOUPayment.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/placeOrderWithStripeCardPayment.graphql:1:41: Unterminated string constant (1:41)\r\n\r\nWhile building for web.browser.legacy:\r\nimports/plugins/core/graphql/lib/mutations/updateFulfillmentOptionsForGroup.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/createFlatRateFulfillmentMethod.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/updateFlatRateFulfillmentMethod.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/deleteFlatRateFulfillmentMethod.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/placeOrderWithExampleIOUPayment.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/graphql/lib/mutations/placeOrderWithStripeCardPayment.graphql:1:41: Unterminated string constant (1:41)\r\n\r\nWhile building for os.linux.x86_64:\r\nimports/plugins/core/core/server/no-meteor/schemas/address.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/base.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/currency.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/email.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/metafield.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/node.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/shop.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/core/server/no-meteor/schemas/tag.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/accounts/server/no-meteor/schemas/account.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/accounts/server/no-meteor/schemas/group.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/accounts/server/no-meteor/schemas/role.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/cart/server/no-meteor/schemas/cart.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/cart/server/no-meteor/schemas/checkout.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/catalog/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/orders/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/payments/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/product/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/core/shipping/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/included/marketplace/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/included/payments-example/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/included/payments-stripe/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/included/shipping-rates/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\nimports/plugins/included/sitemap-generator/server/no-meteor/schemas/schema.graphql:1:41: Unterminated string constant (1:41)\r\n\r\nYour application has errors. Waiting for file change.`\r\n\r\n## Steps to Reproduce\r\nEither \r\n\r\ncheckout reaction and run `reaction`\r\n\r\nor\r\n\r\ncheckout reaction and run `docker-compose up -d`\r\n\r\nor\r\n\r\ncheckout reaction-platform and run `make`\r\n\r\n### Versions\r\nWindows 10\r\nNode 8.11.3\r\nnpm 6.4.1\r\nMeteor 1.8\r\nreaction 2.0.0-rc.5\r\n"},"comment":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/comments/433100246","html_url":"https://github.com/reactioncommerce/reaction/issues/4779#issuecomment-433100246","issue_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4779","id":433100246,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzEwMDI0Ng==","user":{"login":"focusaurus","id":482377,"node_id":"MDQ6VXNlcjQ4MjM3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/482377?v=4","gravatar_id":"","url":"https://api.github.com/users/focusaurus","html_url":"https://github.com/focusaurus","followers_url":"https://api.github.com/users/focusaurus/followers","following_url":"https://api.github.com/users/focusaurus/following{/other_user}","gists_url":"https://api.github.com/users/focusaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/focusaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/focusaurus/subscriptions","organizations_url":"https://api.github.com/users/focusaurus/orgs","repos_url":"https://api.github.com/users/focusaurus/repos","events_url":"https://api.github.com/users/focusaurus/events{/privacy}","received_events_url":"https://api.github.com/users/focusaurus/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T15:37:47Z","updated_at":"2018-10-25T15:37:47Z","author_association":"CONTRIBUTOR","body":"My first guess is git for windows automatically converting unix newlines to windows newlines, and that chocking up whatever is parsing those graphql files."}}
{"actor":{"display_login":"focusaurus"}}