{"action":"created","issue":{"url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/issues/361","repository_url":"https://api.github.com/repos/thegazelle-ad/gazelle-server","labels_url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/issues/361/labels{/name}","comments_url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/issues/361/comments","events_url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/issues/361/events","html_url":"https://github.com/thegazelle-ad/gazelle-server/pull/361","id":311528455,"number":361,"title":"Upgrade Falcor to v2","user":{"login":"emilgoldsmith","id":18149242,"avatar_url":"https://avatars0.githubusercontent.com/u/18149242?v=4","gravatar_id":"","url":"https://api.github.com/users/emilgoldsmith","html_url":"https://github.com/emilgoldsmith","followers_url":"https://api.github.com/users/emilgoldsmith/followers","following_url":"https://api.github.com/users/emilgoldsmith/following{/other_user}","gists_url":"https://api.github.com/users/emilgoldsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/emilgoldsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilgoldsmith/subscriptions","organizations_url":"https://api.github.com/users/emilgoldsmith/orgs","repos_url":"https://api.github.com/users/emilgoldsmith/repos","events_url":"https://api.github.com/users/emilgoldsmith/events{/privacy}","received_events_url":"https://api.github.com/users/emilgoldsmith/received_events","type":"User","site_admin":false},"labels":[{"id":878745596,"url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/labels/SWE%20final%20project","name":"SWE final project","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-05T09:06:03Z","updated_at":"2018-04-07T12:59:37Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/pulls/361","html_url":"https://github.com/thegazelle-ad/gazelle-server/pull/361","diff_url":"https://github.com/thegazelle-ad/gazelle-server/pull/361.diff","patch_url":"https://github.com/thegazelle-ad/gazelle-server/pull/361.patch"},"body":"- Upgraded falcor to V2\r\n- Fixed legacy mapping for falcor get as it now returns empty values when it doesn't find something for everything attempted to be fetched\r\n- Deleted the cleanupJsonGraphArg function as it seems to no longer be needed (I actually think it may have been a bug that it was passed atoms beforehand in our specific version, should probably just have updated a patch version earlier)\r\n- Added a helper function to parse falcor pseudo arrays to incentivize no longer using the legacy mapping functions and actually dealing with the falcor objects"},"comment":{"url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/issues/comments/379467620","html_url":"https://github.com/thegazelle-ad/gazelle-server/pull/361#issuecomment-379467620","issue_url":"https://api.github.com/repos/thegazelle-ad/gazelle-server/issues/361","id":379467620,"user":{"login":"emilgoldsmith","id":18149242,"avatar_url":"https://avatars0.githubusercontent.com/u/18149242?v=4","gravatar_id":"","url":"https://api.github.com/users/emilgoldsmith","html_url":"https://github.com/emilgoldsmith","followers_url":"https://api.github.com/users/emilgoldsmith/followers","following_url":"https://api.github.com/users/emilgoldsmith/following{/other_user}","gists_url":"https://api.github.com/users/emilgoldsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/emilgoldsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilgoldsmith/subscriptions","organizations_url":"https://api.github.com/users/emilgoldsmith/orgs","repos_url":"https://api.github.com/users/emilgoldsmith/repos","events_url":"https://api.github.com/users/emilgoldsmith/events{/privacy}","received_events_url":"https://api.github.com/users/emilgoldsmith/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T12:59:37Z","updated_at":"2018-04-07T12:59:37Z","author_association":"OWNER","body":"Yep I think that sounds right, @frederikbrinck. Your desired implementation is also the current implementation, and I added a solid comment describing what it does, as I also don't necessarily think we need the `parseFalcorPseudoArrayWithIndices` at the moment. So shall we just keep it at what it currently is, and then if we find the need for the other one in the future we'll implement that? I think that sounds like a good plan.\r\n\r\nIf you agree you can just approve the changes and then we can merge this in"}}
{"actor":{"display_login":"emilgoldsmith"}}