{"action":"created","issue":{"url":"https://api.github.com/repos/react-navigation/react-navigation/issues/4206","repository_url":"https://api.github.com/repos/react-navigation/react-navigation","labels_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/4206/labels{/name}","comments_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/4206/comments","events_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/4206/events","html_url":"https://github.com/react-navigation/react-navigation/pull/4206","id":322256066,"number":4206,"title":"[Web] Fix header height margin","user":{"login":"Minishlink","id":82368,"avatar_url":"https://avatars2.githubusercontent.com/u/82368?v=4","gravatar_id":"","url":"https://api.github.com/users/Minishlink","html_url":"https://github.com/Minishlink","followers_url":"https://api.github.com/users/Minishlink/followers","following_url":"https://api.github.com/users/Minishlink/following{/other_user}","gists_url":"https://api.github.com/users/Minishlink/gists{/gist_id}","starred_url":"https://api.github.com/users/Minishlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minishlink/subscriptions","organizations_url":"https://api.github.com/users/Minishlink/orgs","repos_url":"https://api.github.com/users/Minishlink/repos","events_url":"https://api.github.com/users/Minishlink/events{/privacy}","received_events_url":"https://api.github.com/users/Minishlink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-11T10:58:42Z","updated_at":"2018-05-25T21:44:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/4206","html_url":"https://github.com/react-navigation/react-navigation/pull/4206","diff_url":"https://github.com/react-navigation/react-navigation/pull/4206.diff","patch_url":"https://github.com/react-navigation/react-navigation/pull/4206.patch"},"body":"Hello, this is a follow-up of this [commit comment](https://github.com/react-navigation/react-navigation/pull/4017#pullrequestreview-119239864): I noticed that on the web the header margin for the StackNavigator was off of several pixels. This is because the [condition](https://github.com/react-navigation/react-navigation/blob/master/src/views/StackView/StackViewLayout.js#L521) to target the platform is inversed compared to the condition for the app bar height [here](https://github.com/react-navigation/react-navigation/blob/master/src/views/Header/Header.js#L27). This may be worth refactoring in a separate PR (although there's no mention of the iPhone X on the latter file), let me know :)\r\n\r\n**Test plan (required)**\r\n\r\n* [Before](https://user-images.githubusercontent.com/82368/39893204-5387d78e-54a3-11e8-93d1-d82583935ba1.png)\r\n* [After](https://user-images.githubusercontent.com/82368/39921360-e2a6117a-551a-11e8-9a02-a63d28f29470.png)\r\n\r\nAlso checked on Android and iOS devices."},"comment":{"url":"https://api.github.com/repos/react-navigation/react-navigation/issues/comments/392195479","html_url":"https://github.com/react-navigation/react-navigation/pull/4206#issuecomment-392195479","issue_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/4206","id":392195479,"user":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars2.githubusercontent.com/u/90494?v=4","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T21:44:43Z","updated_at":"2018-05-25T21:44:43Z","author_association":"MEMBER","body":"thanks!"}}
{"actor":{"display_login":"brentvatne"}}