{"action":"created","comment":{"url":"https://api.github.com/repos/medallia/linkerd/pulls/comments/182498229","pull_request_review_id":113305720,"id":182498229,"diff_hunk":"@@ -0,0 +1,83 @@\n+package com.twitter.finagle.buoyant\n+\n+import java.net.{InetAddress, UnknownHostException}\n+import java.security.cert.X509Certificate\n+\n+import com.twitter.finagle.{Address, SslHostVerificationException}\n+import com.twitter.finagle.ssl.client.{SslClientConfiguration, SslClientSessionVerifier}\n+import com.twitter.util.Try\n+import javax.net.ssl.SSLSession\n+import sun.security.util.HostnameChecker\n+import sun.security.x509.X500Name","path":"finagle/buoyant/src/main/scala/com/twitter/finagle/buoyant/IpSslClientSessionVerifier.scala","position":11,"original_position":11,"commit_id":"1eb26b8a1a7286b4e61f682adec57e1b65764ffe","original_commit_id":"f7990349eb3ee4eab90bf8ea70b04774a4e1abb5","user":{"login":"erdody","id":215270,"avatar_url":"https://avatars0.githubusercontent.com/u/215270?v=4","gravatar_id":"","url":"https://api.github.com/users/erdody","html_url":"https://github.com/erdody","followers_url":"https://api.github.com/users/erdody/followers","following_url":"https://api.github.com/users/erdody/following{/other_user}","gists_url":"https://api.github.com/users/erdody/gists{/gist_id}","starred_url":"https://api.github.com/users/erdody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdody/subscriptions","organizations_url":"https://api.github.com/users/erdody/orgs","repos_url":"https://api.github.com/users/erdody/repos","events_url":"https://api.github.com/users/erdody/events{/privacy}","received_events_url":"https://api.github.com/users/erdody/received_events","type":"User","site_admin":false},"body":"Let's go with the technical debt option. \r\nI just created https://jira.medallia.com/browse/MSF-31 to track it.\r\nThanks.","created_at":"2018-04-18T16:56:13Z","updated_at":"2018-04-18T16:56:13Z","html_url":"https://github.com/medallia/linkerd/pull/25#discussion_r182498229","pull_request_url":"https://api.github.com/repos/medallia/linkerd/pulls/25","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/medallia/linkerd/pulls/comments/182498229"},"html":{"href":"https://github.com/medallia/linkerd/pull/25#discussion_r182498229"},"pull_request":{"href":"https://api.github.com/repos/medallia/linkerd/pulls/25"}},"in_reply_to_id":181608672},"pull_request":{"url":"https://api.github.com/repos/medallia/linkerd/pulls/25","id":179252798,"html_url":"https://github.com/medallia/linkerd/pull/25","diff_url":"https://github.com/medallia/linkerd/pull/25.diff","patch_url":"https://github.com/medallia/linkerd/pull/25.patch","issue_url":"https://api.github.com/repos/medallia/linkerd/issues/25","number":25,"state":"open","locked":false,"title":"MSF-23","user":{"login":"erdody","id":215270,"avatar_url":"https://avatars0.githubusercontent.com/u/215270?v=4","gravatar_id":"","url":"https://api.github.com/users/erdody","html_url":"https://github.com/erdody","followers_url":"https://api.github.com/users/erdody/followers","following_url":"https://api.github.com/users/erdody/following{/other_user}","gists_url":"https://api.github.com/users/erdody/gists{/gist_id}","starred_url":"https://api.github.com/users/erdody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdody/subscriptions","organizations_url":"https://api.github.com/users/erdody/orgs","repos_url":"https://api.github.com/users/erdody/repos","events_url":"https://api.github.com/users/erdody/events{/privacy}","received_events_url":"https://api.github.com/users/erdody/received_events","type":"User","site_admin":false},"body":"Custom hostname verifier to validate resolved IPs (instead of the service name) against the CN or SAN in the certificate.","created_at":"2018-04-04T00:21:16Z","updated_at":"2018-04-18T16:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c3c4d0707d07e66667bcb93c3227224d17ed72b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pardhar","id":20424515,"avatar_url":"https://avatars3.githubusercontent.com/u/20424515?v=4","gravatar_id":"","url":"https://api.github.com/users/pardhar","html_url":"https://github.com/pardhar","followers_url":"https://api.github.com/users/pardhar/followers","following_url":"https://api.github.com/users/pardhar/following{/other_user}","gists_url":"https://api.github.com/users/pardhar/gists{/gist_id}","starred_url":"https://api.github.com/users/pardhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pardhar/subscriptions","organizations_url":"https://api.github.com/users/pardhar/orgs","repos_url":"https://api.github.com/users/pardhar/repos","events_url":"https://api.github.com/users/pardhar/events{/privacy}","received_events_url":"https://api.github.com/users/pardhar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/medallia/linkerd/pulls/25/commits","review_comments_url":"https://api.github.com/repos/medallia/linkerd/pulls/25/comments","review_comment_url":"https://api.github.com/repos/medallia/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/medallia/linkerd/issues/25/comments","statuses_url":"https://api.github.com/repos/medallia/linkerd/statuses/1eb26b8a1a7286b4e61f682adec57e1b65764ffe","head":{"label":"medallia:MSF-23","ref":"MSF-23","sha":"1eb26b8a1a7286b4e61f682adec57e1b65764ffe","user":{"login":"medallia","id":2198222,"avatar_url":"https://avatars0.githubusercontent.com/u/2198222?v=4","gravatar_id":"","url":"https://api.github.com/users/medallia","html_url":"https://github.com/medallia","followers_url":"https://api.github.com/users/medallia/followers","following_url":"https://api.github.com/users/medallia/following{/other_user}","gists_url":"https://api.github.com/users/medallia/gists{/gist_id}","starred_url":"https://api.github.com/users/medallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medallia/subscriptions","organizations_url":"https://api.github.com/users/medallia/orgs","repos_url":"https://api.github.com/users/medallia/repos","events_url":"https://api.github.com/users/medallia/events{/privacy}","received_events_url":"https://api.github.com/users/medallia/received_events","type":"Organization","site_admin":false},"repo":{"id":62833544,"name":"linkerd","full_name":"medallia/linkerd","owner":{"login":"medallia","id":2198222,"avatar_url":"https://avatars0.githubusercontent.com/u/2198222?v=4","gravatar_id":"","url":"https://api.github.com/users/medallia","html_url":"https://github.com/medallia","followers_url":"https://api.github.com/users/medallia/followers","following_url":"https://api.github.com/users/medallia/following{/other_user}","gists_url":"https://api.github.com/users/medallia/gists{/gist_id}","starred_url":"https://api.github.com/users/medallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medallia/subscriptions","organizations_url":"https://api.github.com/users/medallia/orgs","repos_url":"https://api.github.com/users/medallia/repos","events_url":"https://api.github.com/users/medallia/events{/privacy}","received_events_url":"https://api.github.com/users/medallia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/medallia/linkerd","description":"A dynamic linker for microservices.","fork":true,"url":"https://api.github.com/repos/medallia/linkerd","forks_url":"https://api.github.com/repos/medallia/linkerd/forks","keys_url":"https://api.github.com/repos/medallia/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medallia/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medallia/linkerd/teams","hooks_url":"https://api.github.com/repos/medallia/linkerd/hooks","issue_events_url":"https://api.github.com/repos/medallia/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/medallia/linkerd/events","assignees_url":"https://api.github.com/repos/medallia/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/medallia/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/medallia/linkerd/tags","blobs_url":"https://api.github.com/repos/medallia/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medallia/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medallia/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/medallia/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medallia/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/medallia/linkerd/languages","stargazers_url":"https://api.github.com/repos/medallia/linkerd/stargazers","contributors_url":"https://api.github.com/repos/medallia/linkerd/contributors","subscribers_url":"https://api.github.com/repos/medallia/linkerd/subscribers","subscription_url":"https://api.github.com/repos/medallia/linkerd/subscription","commits_url":"https://api.github.com/repos/medallia/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/medallia/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/medallia/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/medallia/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/medallia/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/medallia/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medallia/linkerd/merges","archive_url":"https://api.github.com/repos/medallia/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medallia/linkerd/downloads","issues_url":"https://api.github.com/repos/medallia/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/medallia/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/medallia/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/medallia/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medallia/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/medallia/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/medallia/linkerd/deployments","created_at":"2016-07-07T19:39:32Z","updated_at":"2017-08-22T08:46:48Z","pushed_at":"2018-04-18T16:32:59Z","git_url":"git://github.com/medallia/linkerd.git","ssh_url":"git@github.com:medallia/linkerd.git","clone_url":"https://github.com/medallia/linkerd.git","svn_url":"https://github.com/medallia/linkerd","homepage":"https://linkerd.io","size":5683,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"medallia:1.3.6-medallia-release","ref":"1.3.6-medallia-release","sha":"c127c38f33c101cd4c62541ea2f6358c7bf49def","user":{"login":"medallia","id":2198222,"avatar_url":"https://avatars0.githubusercontent.com/u/2198222?v=4","gravatar_id":"","url":"https://api.github.com/users/medallia","html_url":"https://github.com/medallia","followers_url":"https://api.github.com/users/medallia/followers","following_url":"https://api.github.com/users/medallia/following{/other_user}","gists_url":"https://api.github.com/users/medallia/gists{/gist_id}","starred_url":"https://api.github.com/users/medallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medallia/subscriptions","organizations_url":"https://api.github.com/users/medallia/orgs","repos_url":"https://api.github.com/users/medallia/repos","events_url":"https://api.github.com/users/medallia/events{/privacy}","received_events_url":"https://api.github.com/users/medallia/received_events","type":"Organization","site_admin":false},"repo":{"id":62833544,"name":"linkerd","full_name":"medallia/linkerd","owner":{"login":"medallia","id":2198222,"avatar_url":"https://avatars0.githubusercontent.com/u/2198222?v=4","gravatar_id":"","url":"https://api.github.com/users/medallia","html_url":"https://github.com/medallia","followers_url":"https://api.github.com/users/medallia/followers","following_url":"https://api.github.com/users/medallia/following{/other_user}","gists_url":"https://api.github.com/users/medallia/gists{/gist_id}","starred_url":"https://api.github.com/users/medallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medallia/subscriptions","organizations_url":"https://api.github.com/users/medallia/orgs","repos_url":"https://api.github.com/users/medallia/repos","events_url":"https://api.github.com/users/medallia/events{/privacy}","received_events_url":"https://api.github.com/users/medallia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/medallia/linkerd","description":"A dynamic linker for microservices.","fork":true,"url":"https://api.github.com/repos/medallia/linkerd","forks_url":"https://api.github.com/repos/medallia/linkerd/forks","keys_url":"https://api.github.com/repos/medallia/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medallia/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medallia/linkerd/teams","hooks_url":"https://api.github.com/repos/medallia/linkerd/hooks","issue_events_url":"https://api.github.com/repos/medallia/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/medallia/linkerd/events","assignees_url":"https://api.github.com/repos/medallia/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/medallia/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/medallia/linkerd/tags","blobs_url":"https://api.github.com/repos/medallia/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medallia/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medallia/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/medallia/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medallia/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/medallia/linkerd/languages","stargazers_url":"https://api.github.com/repos/medallia/linkerd/stargazers","contributors_url":"https://api.github.com/repos/medallia/linkerd/contributors","subscribers_url":"https://api.github.com/repos/medallia/linkerd/subscribers","subscription_url":"https://api.github.com/repos/medallia/linkerd/subscription","commits_url":"https://api.github.com/repos/medallia/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/medallia/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/medallia/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/medallia/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/medallia/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/medallia/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medallia/linkerd/merges","archive_url":"https://api.github.com/repos/medallia/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medallia/linkerd/downloads","issues_url":"https://api.github.com/repos/medallia/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/medallia/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/medallia/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/medallia/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medallia/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/medallia/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/medallia/linkerd/deployments","created_at":"2016-07-07T19:39:32Z","updated_at":"2017-08-22T08:46:48Z","pushed_at":"2018-04-18T16:32:59Z","git_url":"git://github.com/medallia/linkerd.git","ssh_url":"git@github.com:medallia/linkerd.git","clone_url":"https://github.com/medallia/linkerd.git","svn_url":"https://github.com/medallia/linkerd","homepage":"https://linkerd.io","size":5683,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/medallia/linkerd/pulls/25"},"html":{"href":"https://github.com/medallia/linkerd/pull/25"},"issue":{"href":"https://api.github.com/repos/medallia/linkerd/issues/25"},"comments":{"href":"https://api.github.com/repos/medallia/linkerd/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/medallia/linkerd/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/medallia/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/medallia/linkerd/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/medallia/linkerd/statuses/1eb26b8a1a7286b4e61f682adec57e1b65764ffe"}},"author_association":"OWNER"}}
{"actor":{"display_login":"erdody"}}