{"action":"created","comment":{"url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/comments/173659704","pull_request_review_id":102886917,"id":173659704,"diff_hunk":"@@ -26,9 +21,7 @@ export function expandPath(path?: string, rootPath?: string): string | undefined\n \t\tpath = path.replace(\"{workspaceFolder}\", <string>rootPath);\n \t}\n \n-\tif (process.platform === \"win32\" && !path.startsWith(\"/\")) {\n-\t\tpath = \"/mnt/\" + path.substr(0, 1).toLowerCase() + path.substr(\"X:\".length).split(\"\\\\\").join(\"/\");\n-\t}\n+\tpath = \"/mnt/\" + path.substr(0, 1).toLowerCase() + path.substr(\"X:\".length).split(\"\\\\\").join(\"/\");","path":"src/expandPath.ts","position":null,"original_position":34,"commit_id":"1f8198e8d1d5083d8d62a893f95487e4336c8a40","original_commit_id":"e33ccf7ac9f440f6fa7c5b62728069634e5b5a3e","user":{"login":"wataash","id":4846670,"avatar_url":"https://avatars0.githubusercontent.com/u/4846670?v=4","gravatar_id":"","url":"https://api.github.com/users/wataash","html_url":"https://github.com/wataash","followers_url":"https://api.github.com/users/wataash/followers","following_url":"https://api.github.com/users/wataash/following{/other_user}","gists_url":"https://api.github.com/users/wataash/gists{/gist_id}","starred_url":"https://api.github.com/users/wataash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wataash/subscriptions","organizations_url":"https://api.github.com/users/wataash/orgs","repos_url":"https://api.github.com/users/wataash/repos","events_url":"https://api.github.com/users/wataash/events{/privacy}","received_events_url":"https://api.github.com/users/wataash/received_events","type":"User","site_admin":false},"body":"Wow, I overlooked `&& !path.startsWith(\"/\")`!\r\nI rewrote commit \"Remove OS dependency from expandPath\".\r\nIs this okay?","created_at":"2018-03-11T16:00:55Z","updated_at":"2018-03-11T16:00:55Z","html_url":"https://github.com/rogalmic/vscode-bash-debug/pull/52#discussion_r173659704","pull_request_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/comments/173659704"},"html":{"href":"https://github.com/rogalmic/vscode-bash-debug/pull/52#discussion_r173659704"},"pull_request":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52"}},"in_reply_to_id":173659133},"pull_request":{"url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52","id":174225631,"html_url":"https://github.com/rogalmic/vscode-bash-debug/pull/52","diff_url":"https://github.com/rogalmic/vscode-bash-debug/pull/52.diff","patch_url":"https://github.com/rogalmic/vscode-bash-debug/pull/52.patch","issue_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/52","number":52,"state":"open","locked":false,"title":"Introduce jsdoctest","user":{"login":"wataash","id":4846670,"avatar_url":"https://avatars0.githubusercontent.com/u/4846670?v=4","gravatar_id":"","url":"https://api.github.com/users/wataash","html_url":"https://github.com/wataash","followers_url":"https://api.github.com/users/wataash/followers","following_url":"https://api.github.com/users/wataash/following{/other_user}","gists_url":"https://api.github.com/users/wataash/gists{/gist_id}","starred_url":"https://api.github.com/users/wataash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wataash/subscriptions","organizations_url":"https://api.github.com/users/wataash/orgs","repos_url":"https://api.github.com/users/wataash/repos","events_url":"https://api.github.com/users/wataash/events{/privacy}","received_events_url":"https://api.github.com/users/wataash/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-11T15:11:05Z","updated_at":"2018-03-11T16:00:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bff8ad1a147c7dfbde0c71cdf636581b68dc0dc","assignee":{"login":"wataash","id":4846670,"avatar_url":"https://avatars0.githubusercontent.com/u/4846670?v=4","gravatar_id":"","url":"https://api.github.com/users/wataash","html_url":"https://github.com/wataash","followers_url":"https://api.github.com/users/wataash/followers","following_url":"https://api.github.com/users/wataash/following{/other_user}","gists_url":"https://api.github.com/users/wataash/gists{/gist_id}","starred_url":"https://api.github.com/users/wataash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wataash/subscriptions","organizations_url":"https://api.github.com/users/wataash/orgs","repos_url":"https://api.github.com/users/wataash/repos","events_url":"https://api.github.com/users/wataash/events{/privacy}","received_events_url":"https://api.github.com/users/wataash/received_events","type":"User","site_admin":false},"assignees":[{"login":"wataash","id":4846670,"avatar_url":"https://avatars0.githubusercontent.com/u/4846670?v=4","gravatar_id":"","url":"https://api.github.com/users/wataash","html_url":"https://github.com/wataash","followers_url":"https://api.github.com/users/wataash/followers","following_url":"https://api.github.com/users/wataash/following{/other_user}","gists_url":"https://api.github.com/users/wataash/gists{/gist_id}","starred_url":"https://api.github.com/users/wataash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wataash/subscriptions","organizations_url":"https://api.github.com/users/wataash/orgs","repos_url":"https://api.github.com/users/wataash/repos","events_url":"https://api.github.com/users/wataash/events{/privacy}","received_events_url":"https://api.github.com/users/wataash/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52/commits","review_comments_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52/comments","review_comment_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/52/comments","statuses_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/statuses/1f8198e8d1d5083d8d62a893f95487e4336c8a40","head":{"label":"rogalmic:feature/jsdoctest","ref":"feature/jsdoctest","sha":"1f8198e8d1d5083d8d62a893f95487e4336c8a40","user":{"login":"rogalmic","id":23117003,"avatar_url":"https://avatars2.githubusercontent.com/u/23117003?v=4","gravatar_id":"","url":"https://api.github.com/users/rogalmic","html_url":"https://github.com/rogalmic","followers_url":"https://api.github.com/users/rogalmic/followers","following_url":"https://api.github.com/users/rogalmic/following{/other_user}","gists_url":"https://api.github.com/users/rogalmic/gists{/gist_id}","starred_url":"https://api.github.com/users/rogalmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogalmic/subscriptions","organizations_url":"https://api.github.com/users/rogalmic/orgs","repos_url":"https://api.github.com/users/rogalmic/repos","events_url":"https://api.github.com/users/rogalmic/events{/privacy}","received_events_url":"https://api.github.com/users/rogalmic/received_events","type":"User","site_admin":false},"repo":{"id":72192306,"name":"vscode-bash-debug","full_name":"rogalmic/vscode-bash-debug","owner":{"login":"rogalmic","id":23117003,"avatar_url":"https://avatars2.githubusercontent.com/u/23117003?v=4","gravatar_id":"","url":"https://api.github.com/users/rogalmic","html_url":"https://github.com/rogalmic","followers_url":"https://api.github.com/users/rogalmic/followers","following_url":"https://api.github.com/users/rogalmic/following{/other_user}","gists_url":"https://api.github.com/users/rogalmic/gists{/gist_id}","starred_url":"https://api.github.com/users/rogalmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogalmic/subscriptions","organizations_url":"https://api.github.com/users/rogalmic/orgs","repos_url":"https://api.github.com/users/rogalmic/repos","events_url":"https://api.github.com/users/rogalmic/events{/privacy}","received_events_url":"https://api.github.com/users/rogalmic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogalmic/vscode-bash-debug","description":"Attempt to create a GUI bash debugger based on bashdb scripts.","fork":false,"url":"https://api.github.com/repos/rogalmic/vscode-bash-debug","forks_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/forks","keys_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/teams","hooks_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/hooks","issue_events_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/events{/number}","events_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/events","assignees_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/assignees{/user}","branches_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/branches{/branch}","tags_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/tags","blobs_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/statuses/{sha}","languages_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/languages","stargazers_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/stargazers","contributors_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/contributors","subscribers_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/subscribers","subscription_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/subscription","commits_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/contents/{+path}","compare_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/merges","archive_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/downloads","issues_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues{/number}","pulls_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls{/number}","milestones_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/milestones{/number}","notifications_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/labels{/name}","releases_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/releases{/id}","deployments_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/deployments","created_at":"2016-10-28T09:08:41Z","updated_at":"2018-01-21T05:57:22Z","pushed_at":"2018-03-11T15:59:26Z","git_url":"git://github.com/rogalmic/vscode-bash-debug.git","ssh_url":"git@github.com:rogalmic/vscode-bash-debug.git","clone_url":"https://github.com/rogalmic/vscode-bash-debug.git","svn_url":"https://github.com/rogalmic/vscode-bash-debug","homepage":"","size":3744,"stargazers_count":14,"watchers_count":14,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":7,"watchers":14,"default_branch":"master"}},"base":{"label":"rogalmic:master","ref":"master","sha":"70e567b2a223f5d05950638719d98d9b4a8de719","user":{"login":"rogalmic","id":23117003,"avatar_url":"https://avatars2.githubusercontent.com/u/23117003?v=4","gravatar_id":"","url":"https://api.github.com/users/rogalmic","html_url":"https://github.com/rogalmic","followers_url":"https://api.github.com/users/rogalmic/followers","following_url":"https://api.github.com/users/rogalmic/following{/other_user}","gists_url":"https://api.github.com/users/rogalmic/gists{/gist_id}","starred_url":"https://api.github.com/users/rogalmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogalmic/subscriptions","organizations_url":"https://api.github.com/users/rogalmic/orgs","repos_url":"https://api.github.com/users/rogalmic/repos","events_url":"https://api.github.com/users/rogalmic/events{/privacy}","received_events_url":"https://api.github.com/users/rogalmic/received_events","type":"User","site_admin":false},"repo":{"id":72192306,"name":"vscode-bash-debug","full_name":"rogalmic/vscode-bash-debug","owner":{"login":"rogalmic","id":23117003,"avatar_url":"https://avatars2.githubusercontent.com/u/23117003?v=4","gravatar_id":"","url":"https://api.github.com/users/rogalmic","html_url":"https://github.com/rogalmic","followers_url":"https://api.github.com/users/rogalmic/followers","following_url":"https://api.github.com/users/rogalmic/following{/other_user}","gists_url":"https://api.github.com/users/rogalmic/gists{/gist_id}","starred_url":"https://api.github.com/users/rogalmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogalmic/subscriptions","organizations_url":"https://api.github.com/users/rogalmic/orgs","repos_url":"https://api.github.com/users/rogalmic/repos","events_url":"https://api.github.com/users/rogalmic/events{/privacy}","received_events_url":"https://api.github.com/users/rogalmic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogalmic/vscode-bash-debug","description":"Attempt to create a GUI bash debugger based on bashdb scripts.","fork":false,"url":"https://api.github.com/repos/rogalmic/vscode-bash-debug","forks_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/forks","keys_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/teams","hooks_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/hooks","issue_events_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/events{/number}","events_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/events","assignees_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/assignees{/user}","branches_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/branches{/branch}","tags_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/tags","blobs_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/statuses/{sha}","languages_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/languages","stargazers_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/stargazers","contributors_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/contributors","subscribers_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/subscribers","subscription_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/subscription","commits_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/contents/{+path}","compare_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/merges","archive_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/downloads","issues_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues{/number}","pulls_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls{/number}","milestones_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/milestones{/number}","notifications_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/labels{/name}","releases_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/releases{/id}","deployments_url":"https://api.github.com/repos/rogalmic/vscode-bash-debug/deployments","created_at":"2016-10-28T09:08:41Z","updated_at":"2018-01-21T05:57:22Z","pushed_at":"2018-03-11T15:59:26Z","git_url":"git://github.com/rogalmic/vscode-bash-debug.git","ssh_url":"git@github.com:rogalmic/vscode-bash-debug.git","clone_url":"https://github.com/rogalmic/vscode-bash-debug.git","svn_url":"https://github.com/rogalmic/vscode-bash-debug","homepage":"","size":3744,"stargazers_count":14,"watchers_count":14,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52"},"html":{"href":"https://github.com/rogalmic/vscode-bash-debug/pull/52"},"issue":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/52"},"comments":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/rogalmic/vscode-bash-debug/statuses/1f8198e8d1d5083d8d62a893f95487e4336c8a40"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wataash"}}