{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/183463944","pull_request_review_id":114467148,"id":183463944,"diff_hunk":"@@ -288,6 +288,7 @@ export class AmpStoryAutoAds extends AMP.BaseElement {\n     const requiredAttrs = {\n       'class': 'i-amphtml-story-ad',\n       'layout': 'fill',\n+      'amp-story': '',","path":"extensions/amp-story-auto-ads/0.1/amp-story-auto-ads.js","position":4,"original_position":4,"commit_id":"42d5b40bc2b14d53414a0469ac6a2f3414d1a5a3","original_commit_id":"42d5b40bc2b14d53414a0469ac6a2f3414d1a5a3","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars3.githubusercontent.com/u/8496897?v=4","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"body":"your call. but might be good to specific so later we are free to introduce more `amp-story` related attributes","created_at":"2018-04-23T16:48:53Z","updated_at":"2018-04-23T16:48:53Z","html_url":"https://github.com/ampproject/amphtml/pull/14786#discussion_r183463944","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14786","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/183463944"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14786#discussion_r183463944"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14786"}},"in_reply_to_id":183181816},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/14786","id":183182136,"html_url":"https://github.com/ampproject/amphtml/pull/14786","diff_url":"https://github.com/ampproject/amphtml/pull/14786.diff","patch_url":"https://github.com/ampproject/amphtml/pull/14786.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/14786","number":14786,"state":"open","locked":false,"title":"Add attribute to amp-story-auto-ad","user":{"login":"calebcordry","id":16087874,"avatar_url":"https://avatars2.githubusercontent.com/u/16087874?v=4","gravatar_id":"","url":"https://api.github.com/users/calebcordry","html_url":"https://github.com/calebcordry","followers_url":"https://api.github.com/users/calebcordry/followers","following_url":"https://api.github.com/users/calebcordry/following{/other_user}","gists_url":"https://api.github.com/users/calebcordry/gists{/gist_id}","starred_url":"https://api.github.com/users/calebcordry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebcordry/subscriptions","organizations_url":"https://api.github.com/users/calebcordry/orgs","repos_url":"https://api.github.com/users/calebcordry/repos","events_url":"https://api.github.com/users/calebcordry/events{/privacy}","received_events_url":"https://api.github.com/users/calebcordry/received_events","type":"User","site_admin":false},"body":"Add attribute named `amp-story` to all ads so that 3p ad-servers know that they are being requested from within a story context.\r\n","created_at":"2018-04-20T22:13:38Z","updated_at":"2018-04-23T16:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf9a21e27a2bb5e1998e4c0599966f1aeaca2d3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14786/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14786/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/14786/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/42d5b40bc2b14d53414a0469ac6a2f3414d1a5a3","head":{"label":"calebcordry:add-attr","ref":"add-attr","sha":"42d5b40bc2b14d53414a0469ac6a2f3414d1a5a3","user":{"login":"calebcordry","id":16087874,"avatar_url":"https://avatars2.githubusercontent.com/u/16087874?v=4","gravatar_id":"","url":"https://api.github.com/users/calebcordry","html_url":"https://github.com/calebcordry","followers_url":"https://api.github.com/users/calebcordry/followers","following_url":"https://api.github.com/users/calebcordry/following{/other_user}","gists_url":"https://api.github.com/users/calebcordry/gists{/gist_id}","starred_url":"https://api.github.com/users/calebcordry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebcordry/subscriptions","organizations_url":"https://api.github.com/users/calebcordry/orgs","repos_url":"https://api.github.com/users/calebcordry/repos","events_url":"https://api.github.com/users/calebcordry/events{/privacy}","received_events_url":"https://api.github.com/users/calebcordry/received_events","type":"User","site_admin":false},"repo":{"id":108027113,"name":"amphtml","full_name":"calebcordry/amphtml","owner":{"login":"calebcordry","id":16087874,"avatar_url":"https://avatars2.githubusercontent.com/u/16087874?v=4","gravatar_id":"","url":"https://api.github.com/users/calebcordry","html_url":"https://github.com/calebcordry","followers_url":"https://api.github.com/users/calebcordry/followers","following_url":"https://api.github.com/users/calebcordry/following{/other_user}","gists_url":"https://api.github.com/users/calebcordry/gists{/gist_id}","starred_url":"https://api.github.com/users/calebcordry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebcordry/subscriptions","organizations_url":"https://api.github.com/users/calebcordry/orgs","repos_url":"https://api.github.com/users/calebcordry/repos","events_url":"https://api.github.com/users/calebcordry/events{/privacy}","received_events_url":"https://api.github.com/users/calebcordry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calebcordry/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/calebcordry/amphtml","forks_url":"https://api.github.com/repos/calebcordry/amphtml/forks","keys_url":"https://api.github.com/repos/calebcordry/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calebcordry/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calebcordry/amphtml/teams","hooks_url":"https://api.github.com/repos/calebcordry/amphtml/hooks","issue_events_url":"https://api.github.com/repos/calebcordry/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/calebcordry/amphtml/events","assignees_url":"https://api.github.com/repos/calebcordry/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/calebcordry/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/calebcordry/amphtml/tags","blobs_url":"https://api.github.com/repos/calebcordry/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calebcordry/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calebcordry/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/calebcordry/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calebcordry/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/calebcordry/amphtml/languages","stargazers_url":"https://api.github.com/repos/calebcordry/amphtml/stargazers","contributors_url":"https://api.github.com/repos/calebcordry/amphtml/contributors","subscribers_url":"https://api.github.com/repos/calebcordry/amphtml/subscribers","subscription_url":"https://api.github.com/repos/calebcordry/amphtml/subscription","commits_url":"https://api.github.com/repos/calebcordry/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/calebcordry/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/calebcordry/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/calebcordry/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/calebcordry/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/calebcordry/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calebcordry/amphtml/merges","archive_url":"https://api.github.com/repos/calebcordry/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calebcordry/amphtml/downloads","issues_url":"https://api.github.com/repos/calebcordry/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/calebcordry/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/calebcordry/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/calebcordry/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calebcordry/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/calebcordry/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/calebcordry/amphtml/deployments","created_at":"2017-10-23T19:07:01Z","updated_at":"2018-04-20T23:04:37Z","pushed_at":"2018-04-20T23:04:36Z","git_url":"git://github.com/calebcordry/amphtml.git","ssh_url":"git@github.com:calebcordry/amphtml.git","clone_url":"https://github.com/calebcordry/amphtml.git","svn_url":"https://github.com/calebcordry/amphtml","homepage":"https://www.ampproject.org","size":417414,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"1cf43b6ce59544d74acef84462addfe535eae305","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-04-23T16:03:36Z","pushed_at":"2018-04-23T16:44:13Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":418466,"stargazers_count":11469,"watchers_count":11469,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2351,"mirror_url":null,"archived":false,"open_issues_count":1300,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2351,"open_issues":1300,"watchers":11469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14786"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14786"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14786"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14786/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14786/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14786/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/42d5b40bc2b14d53414a0469ac6a2f3414d1a5a3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lannka"}}