{"action":"closed","number":248,"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/248","id":230064881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDY0ODgx","html_url":"https://github.com/Azure/sonic-swss-common/pull/248","diff_url":"https://github.com/Azure/sonic-swss-common/pull/248.diff","patch_url":"https://github.com/Azure/sonic-swss-common/pull/248.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/248","number":248,"state":"closed","locked":false,"title":"[ut]: explicit convert is to bool type","user":{"login":"lguohan","id":2293967,"node_id":"MDQ6VXNlcjIyOTM5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/2293967?v=4","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false},"body":"since ios has explicit operator bool, we need to explicitly convert it to bool\r\n\r\nsee compilation error under ubuntu 16.04\r\n```\r\ng++ -DHAVE_CONFIG_H -I. -I.. -I .. -g -DNDEBUG  -ansi -fPIC -std=c++11 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Winvalid-pch -Wlong-long -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wno-write-strings -Wno-missing-format-attribute -Wno-long-long  -I/usr/include/libnl3 -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o tests-redis_state_ut.o `test -f 'redis_state_ut.cpp' || echo './'`redis_state_ut.cpp\r\nIn file included from /usr/include/gtest/gtest.h:58:0,\r\n                 from redis_state_ut.cpp:5:\r\nredis_state_ut.cpp: In function ‘int readNumberAtEOL(const string&)’:\r\nredis_state_ut.cpp:58:5: error: no matching function for call to ‘testing::AssertionResult::AssertionResult(std::istringstream&)’\r\n     EXPECT_TRUE(is);\r\n     ^\r\nIn file included from redis_state_ut.cpp:5:0:\r\n/usr/include/gtest/gtest.h:262:12: note: candidate: testing::AssertionResult::AssertionResult(bool)\r\n   explicit AssertionResult(bool success) : success_(success) {}\r\n            ^\r\n/usr/include/gtest/gtest.h:262:12: note:   no known conversion for argument 1 from ‘std::istringstream {aka std::__cxx11::basic_istringstream<char>}’ to ‘bool’\r\n/usr/include/gtest/gtest.h:260:3: note: candidate: testing::AssertionResult::AssertionResult(const testing::AssertionResult&)\r\n   AssertionResult(const AssertionResult& other);\r\n   ^\r\n/usr/include/gtest/gtest.h:260:3: note:   no known conversion for argument 1 from ‘std::istringstream {aka std::__cxx11::basic_istringstream<char>}’ to ‘const testing::AssertionResult&’\r\nMakefile:510: recipe for target 'tests-redis_state_ut.o' failed\r\n```","created_at":"2018-11-12T09:19:56Z","updated_at":"2018-11-12T20:07:06Z","closed_at":"2018-11-12T20:07:06Z","merged_at":"2018-11-12T20:07:06Z","merge_commit_sha":"bb7fa5b0a322667a7d91ebb58675611be52081e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/248/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/248/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/248/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss-common/statuses/eeba59a6569b5eda392fead7ff6d8f65816f2d14","head":{"label":"lguohan:bool","ref":"bool","sha":"eeba59a6569b5eda392fead7ff6d8f65816f2d14","user":{"login":"lguohan","id":2293967,"node_id":"MDQ6VXNlcjIyOTM5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/2293967?v=4","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false},"repo":{"id":54736743,"node_id":"MDEwOlJlcG9zaXRvcnk1NDczNjc0Mw==","name":"sonic-swss-common","full_name":"lguohan/sonic-swss-common","private":false,"owner":{"login":"lguohan","id":2293967,"node_id":"MDQ6VXNlcjIyOTM5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/2293967?v=4","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lguohan/sonic-swss-common","description":"Common components for SONiC switch state service","fork":true,"url":"https://api.github.com/repos/lguohan/sonic-swss-common","forks_url":"https://api.github.com/repos/lguohan/sonic-swss-common/forks","keys_url":"https://api.github.com/repos/lguohan/sonic-swss-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lguohan/sonic-swss-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lguohan/sonic-swss-common/teams","hooks_url":"https://api.github.com/repos/lguohan/sonic-swss-common/hooks","issue_events_url":"https://api.github.com/repos/lguohan/sonic-swss-common/issues/events{/number}","events_url":"https://api.github.com/repos/lguohan/sonic-swss-common/events","assignees_url":"https://api.github.com/repos/lguohan/sonic-swss-common/assignees{/user}","branches_url":"https://api.github.com/repos/lguohan/sonic-swss-common/branches{/branch}","tags_url":"https://api.github.com/repos/lguohan/sonic-swss-common/tags","blobs_url":"https://api.github.com/repos/lguohan/sonic-swss-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lguohan/sonic-swss-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lguohan/sonic-swss-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/lguohan/sonic-swss-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lguohan/sonic-swss-common/statuses/{sha}","languages_url":"https://api.github.com/repos/lguohan/sonic-swss-common/languages","stargazers_url":"https://api.github.com/repos/lguohan/sonic-swss-common/stargazers","contributors_url":"https://api.github.com/repos/lguohan/sonic-swss-common/contributors","subscribers_url":"https://api.github.com/repos/lguohan/sonic-swss-common/subscribers","subscription_url":"https://api.github.com/repos/lguohan/sonic-swss-common/subscription","commits_url":"https://api.github.com/repos/lguohan/sonic-swss-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/lguohan/sonic-swss-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/lguohan/sonic-swss-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/lguohan/sonic-swss-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/lguohan/sonic-swss-common/contents/{+path}","compare_url":"https://api.github.com/repos/lguohan/sonic-swss-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lguohan/sonic-swss-common/merges","archive_url":"https://api.github.com/repos/lguohan/sonic-swss-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lguohan/sonic-swss-common/downloads","issues_url":"https://api.github.com/repos/lguohan/sonic-swss-common/issues{/number}","pulls_url":"https://api.github.com/repos/lguohan/sonic-swss-common/pulls{/number}","milestones_url":"https://api.github.com/repos/lguohan/sonic-swss-common/milestones{/number}","notifications_url":"https://api.github.com/repos/lguohan/sonic-swss-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lguohan/sonic-swss-common/labels{/name}","releases_url":"https://api.github.com/repos/lguohan/sonic-swss-common/releases{/id}","deployments_url":"https://api.github.com/repos/lguohan/sonic-swss-common/deployments","created_at":"2016-03-25T17:54:16Z","updated_at":"2016-03-25T17:54:16Z","pushed_at":"2018-11-12T09:18:45Z","git_url":"git://github.com/lguohan/sonic-swss-common.git","ssh_url":"git@github.com:lguohan/sonic-swss-common.git","clone_url":"https://github.com/lguohan/sonic-swss-common.git","svn_url":"https://github.com/lguohan/sonic-swss-common","homepage":null,"size":795,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"2a37c5c7c4fdcc607613a534f9d0daedadea1f10","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":54597875,"node_id":"MDEwOlJlcG9zaXRvcnk1NDU5Nzg3NQ==","name":"sonic-swss-common","full_name":"Azure/sonic-swss-common","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-swss-common","description":"Common components for SONiC switch state service","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss-common","forks_url":"https://api.github.com/repos/Azure/sonic-swss-common/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss-common/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss-common/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss-common/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss-common/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss-common/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss-common/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss-common/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss-common/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss-common/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss-common/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss-common/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss-common/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss-common/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss-common/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss-common/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss-common/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss-common/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss-common/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss-common/deployments","created_at":"2016-03-23T22:39:26Z","updated_at":"2018-11-12T17:00:45Z","pushed_at":"2018-11-12T20:07:05Z","git_url":"git://github.com/Azure/sonic-swss-common.git","ssh_url":"git@github.com:Azure/sonic-swss-common.git","clone_url":"https://github.com/Azure/sonic-swss-common.git","svn_url":"https://github.com/Azure/sonic-swss-common","homepage":null,"size":794,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":36,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/248"},"html":{"href":"https://github.com/Azure/sonic-swss-common/pull/248"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/issues/248"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/statuses/eeba59a6569b5eda392fead7ff6d8f65816f2d14"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lguohan","id":2293967,"node_id":"MDQ6VXNlcjIyOTM5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/2293967?v=4","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"lguohan"}}