{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/196300807","pull_request_review_id":129824912,"id":196300807,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjMwMDgwNw==","diff_hunk":"@@ -972,6 +972,7 @@ impl Snapshot for Snap {\n                 let mut file = box_try!(File::open(&cf_file.path));\n                 apply_plain_cf_file(&mut BufReader::new(file), &options, cf_handle)?;\n             } else {\n+                let _timer = INGEST_SST_DURATION_SECONDS.start_coarse_timer();","path":"src/raftstore/store/snap.rs","position":15,"original_position":15,"commit_id":"161929efd75c81499836f296348d9a631887efa5","original_commit_id":"161929efd75c81499836f296348d9a631887efa5","user":{"login":"siddontang","id":1080370,"node_id":"MDQ6VXNlcjEwODAzNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1080370?v=4","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"body":"we will calculate the elapsed time in Drop","created_at":"2018-06-19T05:51:34Z","updated_at":"2018-06-19T05:51:34Z","html_url":"https://github.com/pingcap/tikv/pull/3209#discussion_r196300807","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/3209","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/196300807"},"html":{"href":"https://github.com/pingcap/tikv/pull/3209#discussion_r196300807"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3209"}},"in_reply_to_id":195843573},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/3209","id":195069025,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDY5MDI1","html_url":"https://github.com/pingcap/tikv/pull/3209","diff_url":"https://github.com/pingcap/tikv/pull/3209.diff","patch_url":"https://github.com/pingcap/tikv/pull/3209.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/3209","number":3209,"state":"open","locked":false,"title":"*: add some metrics for rocksdb","user":{"login":"DorianZheng","id":8065637,"node_id":"MDQ6VXNlcjgwNjU2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8065637?v=4","gravatar_id":"","url":"https://api.github.com/users/DorianZheng","html_url":"https://github.com/DorianZheng","followers_url":"https://api.github.com/users/DorianZheng/followers","following_url":"https://api.github.com/users/DorianZheng/following{/other_user}","gists_url":"https://api.github.com/users/DorianZheng/gists{/gist_id}","starred_url":"https://api.github.com/users/DorianZheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DorianZheng/subscriptions","organizations_url":"https://api.github.com/users/DorianZheng/orgs","repos_url":"https://api.github.com/users/DorianZheng/repos","events_url":"https://api.github.com/users/DorianZheng/events{/privacy}","received_events_url":"https://api.github.com/users/DorianZheng/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\nadd metric for ingest sst\r\nadd metric for number of files at each level at each cf\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\nImprovement\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nJust add metric\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nNo\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nYes, I will add it later","created_at":"2018-06-15T03:23:02Z","updated_at":"2018-06-19T05:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2618faaeac4310caab0692f0b36c2c8f0db5acb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/3209/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/3209/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/3209/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/161929efd75c81499836f296348d9a631887efa5","head":{"label":"DorianZheng:master","ref":"master","sha":"161929efd75c81499836f296348d9a631887efa5","user":{"login":"DorianZheng","id":8065637,"node_id":"MDQ6VXNlcjgwNjU2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8065637?v=4","gravatar_id":"","url":"https://api.github.com/users/DorianZheng","html_url":"https://github.com/DorianZheng","followers_url":"https://api.github.com/users/DorianZheng/followers","following_url":"https://api.github.com/users/DorianZheng/following{/other_user}","gists_url":"https://api.github.com/users/DorianZheng/gists{/gist_id}","starred_url":"https://api.github.com/users/DorianZheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DorianZheng/subscriptions","organizations_url":"https://api.github.com/users/DorianZheng/orgs","repos_url":"https://api.github.com/users/DorianZheng/repos","events_url":"https://api.github.com/users/DorianZheng/events{/privacy}","received_events_url":"https://api.github.com/users/DorianZheng/received_events","type":"User","site_admin":false},"repo":{"id":137301031,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMDEwMzE=","name":"tikv","full_name":"DorianZheng/tikv","owner":{"login":"DorianZheng","id":8065637,"node_id":"MDQ6VXNlcjgwNjU2Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8065637?v=4","gravatar_id":"","url":"https://api.github.com/users/DorianZheng","html_url":"https://github.com/DorianZheng","followers_url":"https://api.github.com/users/DorianZheng/followers","following_url":"https://api.github.com/users/DorianZheng/following{/other_user}","gists_url":"https://api.github.com/users/DorianZheng/gists{/gist_id}","starred_url":"https://api.github.com/users/DorianZheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DorianZheng/subscriptions","organizations_url":"https://api.github.com/users/DorianZheng/orgs","repos_url":"https://api.github.com/users/DorianZheng/repos","events_url":"https://api.github.com/users/DorianZheng/events{/privacy}","received_events_url":"https://api.github.com/users/DorianZheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DorianZheng/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/DorianZheng/tikv","forks_url":"https://api.github.com/repos/DorianZheng/tikv/forks","keys_url":"https://api.github.com/repos/DorianZheng/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DorianZheng/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DorianZheng/tikv/teams","hooks_url":"https://api.github.com/repos/DorianZheng/tikv/hooks","issue_events_url":"https://api.github.com/repos/DorianZheng/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/DorianZheng/tikv/events","assignees_url":"https://api.github.com/repos/DorianZheng/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/DorianZheng/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/DorianZheng/tikv/tags","blobs_url":"https://api.github.com/repos/DorianZheng/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DorianZheng/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DorianZheng/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/DorianZheng/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DorianZheng/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/DorianZheng/tikv/languages","stargazers_url":"https://api.github.com/repos/DorianZheng/tikv/stargazers","contributors_url":"https://api.github.com/repos/DorianZheng/tikv/contributors","subscribers_url":"https://api.github.com/repos/DorianZheng/tikv/subscribers","subscription_url":"https://api.github.com/repos/DorianZheng/tikv/subscription","commits_url":"https://api.github.com/repos/DorianZheng/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/DorianZheng/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/DorianZheng/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/DorianZheng/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/DorianZheng/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/DorianZheng/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DorianZheng/tikv/merges","archive_url":"https://api.github.com/repos/DorianZheng/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DorianZheng/tikv/downloads","issues_url":"https://api.github.com/repos/DorianZheng/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/DorianZheng/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/DorianZheng/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/DorianZheng/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DorianZheng/tikv/labels{/name}","releases_url":"https://api.github.com/repos/DorianZheng/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/DorianZheng/tikv/deployments","created_at":"2018-06-14T03:23:52Z","updated_at":"2018-06-15T08:52:26Z","pushed_at":"2018-06-15T08:52:23Z","git_url":"git://github.com/DorianZheng/tikv.git","ssh_url":"git@github.com:DorianZheng/tikv.git","clone_url":"https://github.com/DorianZheng/tikv.git","svn_url":"https://github.com/DorianZheng/tikv","homepage":"https://pingcap.com","size":13970,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"1c4ba5cf817c59da33bb653cbf40fde9282eec79","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-06-19T05:29:53Z","pushed_at":"2018-06-19T03:35:21Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":13995,"stargazers_count":3271,"watchers_count":3271,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":420,"mirror_url":null,"archived":false,"open_issues_count":225,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":420,"open_issues":225,"watchers":3271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3209"},"html":{"href":"https://github.com/pingcap/tikv/pull/3209"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/3209"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/3209/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3209/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3209/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/161929efd75c81499836f296348d9a631887efa5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"siddontang"}}