{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-bids/issues/78","repository_url":"https://api.github.com/repos/mne-tools/mne-bids","labels_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/78/comments","events_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/78/events","html_url":"https://github.com/mne-tools/mne-bids/pull/78","id":358049213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTE0MDIw","number":78,"title":"[MRG] Add bep006 eeg","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"assignees":[{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-09-07T12:34:31Z","updated_at":"2018-09-15T09:06:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-bids/pulls/78","html_url":"https://github.com/mne-tools/mne-bids/pull/78","diff_url":"https://github.com/mne-tools/mne-bids/pull/78.diff","patch_url":"https://github.com/mne-tools/mne-bids/pull/78.patch"},"body":"This will introduce BEP_006 \"EEG\" to MNE-BIDS and close #34 \r\n\r\nCurrent state of the BEP_006: [Google doc](https://docs.google.com/document/d/1ArMZ9Y_quTKXC-jNXZksnedK2VHHoKP3HCeO5HPcgLE)\r\n\r\nBEP_006 Examples: https://github.com/incf/bids-examples/tree/bep006_eeg\r\n\r\nThe bids-validator can already deal with EEG data by including the bep006 flag such as: `bids-validator --bep006 /path/to/dataset`\r\n\r\n# To Do:\r\n- [x] Make MNE-BIDS aware that there are more types of data next to MEG (contingent on #73)\r\n    - for now, keep using `kind`\r\n- [x] Introduce all EEG supported file types and test that they are converted and written correctly\r\n    - BrainVision is a multi-file format: .vhdr, .eeg, .vmrk\r\n    - EEGLAB .set files might be accompanied by a .fdt file\r\n- [x] Make an example for EEG to be posted in the [gallery](https://mne-tools.github.io/mne-bids/auto_examples/index.html)\r\n- [x] skip `coordsystem.json` and `electrodes.tsv` for EEG until the handling of coordinates is resolved in MNE-Python (i.e., no rescaling of the coordinates read from a file: https://github.com/mne-tools/mne-python/pull/5472)\r\n- [x] `scans.tsv` is equal across modalities, write it for all (so far it was only written for meg)\r\n- [x] `events.tsv` has been adjusted already in #55, no changes\r\n- [x] reformat `sidecar.json` to better cover all shared keys. Issue for EEG REQUIRED: `EEGReference` ... make it `n/a` until we find a good way to infer it from mne.raw\r\n- [x] find solution for EDF data\r\n    - for `mne.find_events`, it wants a parameter `initialEvent=True`\r\n    - when being read, it wants `preload=True`\r\n\r\n------------\r\n# General list of things to implement\r\n### Must-haves in the future:\r\n- `coordsystem.json` for EEG\r\n- `electrodes.tsv` for EEG\r\n\r\n### Nice to haves ... but not too important and hard to implement\r\n... for these, I currently do not have an idea how to extract the information automatically. Adding them as optional (None-defaulting) parameters would clutter the API - so I don't work on them for now.\r\n- Several `sidecar.json` fields in decreasing order of importance\r\n    - HardwareFilters\r\n    - ManufacturersModelName\r\n    - CapManufacturer\r\n    - CapManufacturersModelName\r\n\r\n--> as a potential solution, see #47 \r\n"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-bids/issues/comments/421542949","html_url":"https://github.com/mne-tools/mne-bids/pull/78#issuecomment-421542949","issue_url":"https://api.github.com/repos/mne-tools/mne-bids/issues/78","id":421542949,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTU0Mjk0OQ==","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T09:06:11Z","updated_at":"2018-09-15T09:06:11Z","author_association":"COLLABORATOR","body":"There is a new error ... possibly introduced through upstream MNE-Python changes? \r\n\r\n`RuntimeError: By default, MNE does not load data into main memory to conserve resources. adding, dropping, or reordering channels requires raw data to be loaded. Use preload=True (or string) in the constructor or raw.load_data().`"}}
{"actor":{"display_login":"sappelhoff"}}