{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/comments/176255320","pull_request_review_id":105926960,"id":176255320,"diff_hunk":"@@ -10,4 +10,8 @@ def security_groups\n   def load_balancers\n     @load_balancers ||= gather_data_for_this_region(@lbs)\n   end\n+\n+  def network_routers\n+    @network_routers ||= gather_data_for_this_region(@rts)","path":"app/models/manageiq/providers/azure/inventory/collector/network_manager.rb","position":6,"original_position":6,"commit_id":"2f5e7c2e121ccb6c89f0629a6baf4dd6b3ba6d90","original_commit_id":"2f5e7c2e121ccb6c89f0629a6baf4dd6b3ba6d90","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars0.githubusercontent.com/u/1737058?v=4","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"body":"maybe lets not memoize this, if we don't have to","created_at":"2018-03-21T22:13:03Z","updated_at":"2018-03-21T22:13:03Z","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/224#discussion_r176255320","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/comments/176255320"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-azure/pull/224#discussion_r176255320"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224","id":175291497,"html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/224","diff_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/224.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/224.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/224","number":224,"state":"open","locked":false,"title":"[WIP] Add router collection to refresh parser","user":{"login":"djberg96","id":78529,"avatar_url":"https://avatars3.githubusercontent.com/u/78529?v=4","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"body":"This adds router support to the standard refresh parser. It collects router and route information, and sets subnet associations, if any.\r\n\r\nWIP for now because I'll need to add some inventory for testing, which means regenerating the cassettes, and I want to wait until #220 is merged.","created_at":"2018-03-15T15:39:05Z","updated_at":"2018-03-21T22:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8cf3e91b32b83988f5b86088a2bb05bb2540859","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536171837,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/labels/wip","name":"wip","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/224/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/statuses/2f5e7c2e121ccb6c89f0629a6baf4dd6b3ba6d90","head":{"label":"djberg96:routes","ref":"routes","sha":"2f5e7c2e121ccb6c89f0629a6baf4dd6b3ba6d90","user":{"login":"djberg96","id":78529,"avatar_url":"https://avatars3.githubusercontent.com/u/78529?v=4","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"repo":{"id":72789960,"name":"manageiq-providers-azure","full_name":"djberg96/manageiq-providers-azure","owner":{"login":"djberg96","id":78529,"avatar_url":"https://avatars3.githubusercontent.com/u/78529?v=4","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djberg96/manageiq-providers-azure","description":"ManageIQ plugin for the Microsoft Azure provider","fork":true,"url":"https://api.github.com/repos/djberg96/manageiq-providers-azure","forks_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/forks","keys_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/teams","hooks_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/hooks","issue_events_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/issues/events{/number}","events_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/events","assignees_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/assignees{/user}","branches_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/branches{/branch}","tags_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/tags","blobs_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/languages","stargazers_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/stargazers","contributors_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/contributors","subscribers_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/subscribers","subscription_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/subscription","commits_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/contents/{+path}","compare_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/merges","archive_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/downloads","issues_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/issues{/number}","pulls_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/labels{/name}","releases_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/releases{/id}","deployments_url":"https://api.github.com/repos/djberg96/manageiq-providers-azure/deployments","created_at":"2016-11-03T21:48:53Z","updated_at":"2018-03-20T15:13:13Z","pushed_at":"2018-03-21T21:36:21Z","git_url":"git://github.com/djberg96/manageiq-providers-azure.git","ssh_url":"git@github.com:djberg96/manageiq-providers-azure.git","clone_url":"https://github.com/djberg96/manageiq-providers-azure.git","svn_url":"https://github.com/djberg96/manageiq-providers-azure","homepage":"","size":4175,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"44f72639a6f8ef7d4b212a70ac56e12c1968d2d9","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":72784617,"name":"manageiq-providers-azure","full_name":"ManageIQ/manageiq-providers-azure","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-azure","description":"ManageIQ plugin for the Microsoft Azure provider","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/deployments","created_at":"2016-11-03T20:37:06Z","updated_at":"2018-03-20T20:18:41Z","pushed_at":"2018-03-21T21:36:22Z","git_url":"git://github.com/ManageIQ/manageiq-providers-azure.git","ssh_url":"git@github.com:ManageIQ/manageiq-providers-azure.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-azure.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-azure","homepage":"","size":4076,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":39,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-azure/pull/224"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/224"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/statuses/2f5e7c2e121ccb6c89f0629a6baf4dd6b3ba6d90"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Ladas"}}