{"action":"created","comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/165302018","pull_request_review_id":93216659,"id":165302018,"diff_hunk":"@@ -0,0 +1,45 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.activemq.artemis.core.protocol.openwire;\n+\n+import org.apache.activemq.artemis.api.core.ICoreMessage;\n+import org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools;\n+import org.apache.activemq.artemis.spi.core.protocol.MessageConverter;\n+\n+public class OpenWireConverter implements MessageConverter<OpenwireMessage> {\n+\n+   private static final OpenWireConverter theInstance = new OpenWireConverter();\n+   private OpenWireConverter() {\n+   }\n+\n+   public static OpenWireConverter getInstance() {\n+      return theInstance;\n+   }\n+\n+   @Override\n+   public OpenwireMessage fromCore(ICoreMessage coreMessage) throws Exception {","path":"artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java","position":34,"original_position":34,"commit_id":"ac3570be4fd2aca4b9306a7a42ee8d8e8e872c89","original_commit_id":"ac3570be4fd2aca4b9306a7a42ee8d8e8e872c89","user":{"login":"RaiSaurabh","id":22483381,"avatar_url":"https://avatars3.githubusercontent.com/u/22483381?v=4","gravatar_id":"","url":"https://api.github.com/users/RaiSaurabh","html_url":"https://github.com/RaiSaurabh","followers_url":"https://api.github.com/users/RaiSaurabh/followers","following_url":"https://api.github.com/users/RaiSaurabh/following{/other_user}","gists_url":"https://api.github.com/users/RaiSaurabh/gists{/gist_id}","starred_url":"https://api.github.com/users/RaiSaurabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaiSaurabh/subscriptions","organizations_url":"https://api.github.com/users/RaiSaurabh/orgs","repos_url":"https://api.github.com/users/RaiSaurabh/repos","events_url":"https://api.github.com/users/RaiSaurabh/events{/privacy}","received_events_url":"https://api.github.com/users/RaiSaurabh/received_events","type":"User","site_admin":false},"body":"Ok, @michaelandrepearce I will refractor that. Since this was named like this previously I thought not to change it. As after what you suggested this was bugging me too.","created_at":"2018-02-01T09:45:13Z","updated_at":"2018-02-01T09:45:13Z","html_url":"https://github.com/apache/activemq-artemis/pull/1793#discussion_r165302018","pull_request_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/165302018"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/1793#discussion_r165302018"},"pull_request":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793"}},"in_reply_to_id":165287490},"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793","id":163956457,"html_url":"https://github.com/apache/activemq-artemis/pull/1793","diff_url":"https://github.com/apache/activemq-artemis/pull/1793.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/1793.patch","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1793","number":1793,"state":"open","locked":false,"title":"ARTEMIS-1498: Openwire internal headers should not be part of message","user":{"login":"RaiSaurabh","id":22483381,"avatar_url":"https://avatars3.githubusercontent.com/u/22483381?v=4","gravatar_id":"","url":"https://api.github.com/users/RaiSaurabh","html_url":"https://github.com/RaiSaurabh","followers_url":"https://api.github.com/users/RaiSaurabh/followers","following_url":"https://api.github.com/users/RaiSaurabh/following{/other_user}","gists_url":"https://api.github.com/users/RaiSaurabh/gists{/gist_id}","starred_url":"https://api.github.com/users/RaiSaurabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaiSaurabh/subscriptions","organizations_url":"https://api.github.com/users/RaiSaurabh/orgs","repos_url":"https://api.github.com/users/RaiSaurabh/repos","events_url":"https://api.github.com/users/RaiSaurabh/events{/privacy}","received_events_url":"https://api.github.com/users/RaiSaurabh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-19T12:20:27Z","updated_at":"2018-02-01T09:45:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f6dbfd9a2c054b7c3ab35f67f2690228f00d343","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793/commits","review_comments_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793/comments","review_comment_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1793/comments","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/ac3570be4fd2aca4b9306a7a42ee8d8e8e872c89","head":{"label":"RaiSaurabh:openwire","ref":"openwire","sha":"ac3570be4fd2aca4b9306a7a42ee8d8e8e872c89","user":{"login":"RaiSaurabh","id":22483381,"avatar_url":"https://avatars3.githubusercontent.com/u/22483381?v=4","gravatar_id":"","url":"https://api.github.com/users/RaiSaurabh","html_url":"https://github.com/RaiSaurabh","followers_url":"https://api.github.com/users/RaiSaurabh/followers","following_url":"https://api.github.com/users/RaiSaurabh/following{/other_user}","gists_url":"https://api.github.com/users/RaiSaurabh/gists{/gist_id}","starred_url":"https://api.github.com/users/RaiSaurabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaiSaurabh/subscriptions","organizations_url":"https://api.github.com/users/RaiSaurabh/orgs","repos_url":"https://api.github.com/users/RaiSaurabh/repos","events_url":"https://api.github.com/users/RaiSaurabh/events{/privacy}","received_events_url":"https://api.github.com/users/RaiSaurabh/received_events","type":"User","site_admin":false},"repo":{"id":108816145,"name":"activemq-artemis","full_name":"RaiSaurabh/activemq-artemis","owner":{"login":"RaiSaurabh","id":22483381,"avatar_url":"https://avatars3.githubusercontent.com/u/22483381?v=4","gravatar_id":"","url":"https://api.github.com/users/RaiSaurabh","html_url":"https://github.com/RaiSaurabh","followers_url":"https://api.github.com/users/RaiSaurabh/followers","following_url":"https://api.github.com/users/RaiSaurabh/following{/other_user}","gists_url":"https://api.github.com/users/RaiSaurabh/gists{/gist_id}","starred_url":"https://api.github.com/users/RaiSaurabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaiSaurabh/subscriptions","organizations_url":"https://api.github.com/users/RaiSaurabh/orgs","repos_url":"https://api.github.com/users/RaiSaurabh/repos","events_url":"https://api.github.com/users/RaiSaurabh/events{/privacy}","received_events_url":"https://api.github.com/users/RaiSaurabh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaiSaurabh/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":true,"url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis","forks_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/forks","keys_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/events","assignees_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/merges","archive_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/RaiSaurabh/activemq-artemis/deployments","created_at":"2017-10-30T07:27:36Z","updated_at":"2017-10-30T07:27:51Z","pushed_at":"2018-02-01T04:38:51Z","git_url":"git://github.com/RaiSaurabh/activemq-artemis.git","ssh_url":"git@github.com:RaiSaurabh/activemq-artemis.git","clone_url":"https://github.com/RaiSaurabh/activemq-artemis.git","svn_url":"https://github.com/RaiSaurabh/activemq-artemis","homepage":"","size":47856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ce84c0cc1cfdac9c4485045aca4ccdd02a29fba0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36057260,"name":"activemq-artemis","full_name":"apache/activemq-artemis","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":false,"url":"https://api.github.com/repos/apache/activemq-artemis","forks_url":"https://api.github.com/repos/apache/activemq-artemis/forks","keys_url":"https://api.github.com/repos/apache/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/apache/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/activemq-artemis/events","assignees_url":"https://api.github.com/repos/apache/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/apache/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/apache/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/apache/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/apache/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/apache/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/apache/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/activemq-artemis/merges","archive_url":"https://api.github.com/repos/apache/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/apache/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/apache/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/activemq-artemis/deployments","created_at":"2015-05-22T07:00:05Z","updated_at":"2018-01-31T16:24:18Z","pushed_at":"2018-02-01T09:37:32Z","git_url":"git://github.com/apache/activemq-artemis.git","ssh_url":"git@github.com:apache/activemq-artemis.git","clone_url":"https://github.com/apache/activemq-artemis.git","svn_url":"https://github.com/apache/activemq-artemis","homepage":"","size":47789,"stargazers_count":267,"watchers_count":267,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":316,"open_issues":14,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/1793"},"issue":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/1793"},"comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/1793/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1793/commits"},"statuses":{"href":"https://api.github.com/repos/apache/activemq-artemis/statuses/ac3570be4fd2aca4b9306a7a42ee8d8e8e872c89"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RaiSaurabh"}}