{"action":"created","issue":{"url":"https://api.github.com/repos/piuccio/cowsay/issues/40","repository_url":"https://api.github.com/repos/piuccio/cowsay","labels_url":"https://api.github.com/repos/piuccio/cowsay/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/piuccio/cowsay/issues/40/comments","events_url":"https://api.github.com/repos/piuccio/cowsay/issues/40/events","html_url":"https://github.com/piuccio/cowsay/pull/40","id":373397815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzM1Nzgx","number":40,"title":"Newcows","user":{"login":"jasonkhanlar","id":340415,"node_id":"MDQ6VXNlcjM0MDQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/340415?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonkhanlar","html_url":"https://github.com/jasonkhanlar","followers_url":"https://api.github.com/users/jasonkhanlar/followers","following_url":"https://api.github.com/users/jasonkhanlar/following{/other_user}","gists_url":"https://api.github.com/users/jasonkhanlar/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonkhanlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonkhanlar/subscriptions","organizations_url":"https://api.github.com/users/jasonkhanlar/orgs","repos_url":"https://api.github.com/users/jasonkhanlar/repos","events_url":"https://api.github.com/users/jasonkhanlar/events{/privacy}","received_events_url":"https://api.github.com/users/jasonkhanlar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-24T09:50:06Z","updated_at":"2018-11-17T16:03:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/piuccio/cowsay/pulls/40","html_url":"https://github.com/piuccio/cowsay/pull/40","diff_url":"https://github.com/piuccio/cowsay/pull/40.diff","patch_url":"https://github.com/piuccio/cowsay/pull/40.patch"},"body":"Per my comment at https://github.com/piuccio/cowsay/issues/38#issuecomment-432561011\r\nAnd after my previous pull request minutes ago https://github.com/piuccio/cowsay/pull/39\r\nhere are a bunch of additional *.cow files pulled from the other repos listed."},"comment":{"url":"https://api.github.com/repos/piuccio/cowsay/issues/comments/439627637","html_url":"https://github.com/piuccio/cowsay/pull/40#issuecomment-439627637","issue_url":"https://api.github.com/repos/piuccio/cowsay/issues/40","id":439627637,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTYyNzYzNw==","user":{"login":"jasonkhanlar","id":340415,"node_id":"MDQ6VXNlcjM0MDQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/340415?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonkhanlar","html_url":"https://github.com/jasonkhanlar","followers_url":"https://api.github.com/users/jasonkhanlar/followers","following_url":"https://api.github.com/users/jasonkhanlar/following{/other_user}","gists_url":"https://api.github.com/users/jasonkhanlar/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonkhanlar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonkhanlar/subscriptions","organizations_url":"https://api.github.com/users/jasonkhanlar/orgs","repos_url":"https://api.github.com/users/jasonkhanlar/repos","events_url":"https://api.github.com/users/jasonkhanlar/events{/privacy}","received_events_url":"https://api.github.com/users/jasonkhanlar/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T16:03:57Z","updated_at":"2018-11-17T16:03:57Z","author_association":"CONTRIBUTOR","body":"> can you please remove ..... the `EOC` at the bottom of new cows?\r\n\r\nI am not sure if that is a good idea. I notice all the existing cowfiles have `EOC` line at the end\r\n\r\nAlso lib/replacer.js:\r\n```\r\nfunction extractTheCow (cow) {\r\n\tcow = cow.replace(/\\r\\n?|[\\n\\u2028\\u2029]/g, \"\\n\").replace(/^\\uFEFF/, '');\r\n\tvar match = /\\$the_cow\\s*=\\s*<<\"*EOC\"*;*\\n([\\s\\S]+)\\nEOC\\n/.exec(cow);\r\n\r\n\tif (!match) {\r\n\t\tconsole.error(\"Cannot parse cow file\\n\", cow);\r\n\t\treturn cow;\r\n\t} else {\r\n\t\treturn match[1].replace(/\\\\{2}/g, \"\\\\\").replace(/\\\\@/g, \"@\").replace(/\\\\\\$/g, \"$\");\r\n\t}\r\n}\r\n```\r\nThe match variable will evaluate to false without the `EOC` line at end?"}}
{"actor":{"display_login":"jasonkhanlar"}}