{"action":"closed","number":533,"pull_request":{"url":"https://api.github.com/repos/mu-editor/mu/pulls/533","id":200163076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTYzMDc2","html_url":"https://github.com/mu-editor/mu/pull/533","diff_url":"https://github.com/mu-editor/mu/pull/533.diff","patch_url":"https://github.com/mu-editor/mu/pull/533.patch","issue_url":"https://api.github.com/repos/mu-editor/mu/issues/533","number":533,"state":"closed","locked":false,"title":"More styling work","user":{"login":"ZanderBrown","id":17074021,"node_id":"MDQ6VXNlcjE3MDc0MDIx","avatar_url":"https://avatars0.githubusercontent.com/u/17074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ZanderBrown","html_url":"https://github.com/ZanderBrown","followers_url":"https://api.github.com/users/ZanderBrown/followers","following_url":"https://api.github.com/users/ZanderBrown/following{/other_user}","gists_url":"https://api.github.com/users/ZanderBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ZanderBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZanderBrown/subscriptions","organizations_url":"https://api.github.com/users/ZanderBrown/orgs","repos_url":"https://api.github.com/users/ZanderBrown/repos","events_url":"https://api.github.com/users/ZanderBrown/events{/privacy}","received_events_url":"https://api.github.com/users/ZanderBrown/received_events","type":"User","site_admin":false},"body":"This has grown a bit\r\n\r\nOn macOS/Linux/Windows our scrollbars use a Qt fallback which looks *interesting* and is almost invisible in the contrast theme. Similarly masOS/Windows/Some Linux fallback to a grey on grey 9xish design.\r\n\r\nSo visually this PR styles the scrollbar & dialog buttons and adds some borders to text areas in the admin dialog\r\n\r\nSome pictures!\r\n\r\n![mubuttons](https://user-images.githubusercontent.com/17074021/42463738-e3244182-839e-11e8-92e5-5d49dd27d4bf.png)\r\nHaven't included hover states here because reliably screenshotting them was an issue\r\n\r\n![muscroll](https://user-images.githubusercontent.com/17074021/42464233-50b302dc-83a0-11e8-8473-55984ed612fc.png)\r\n\r\nWhole admin dialog for comparison\r\n![screenshot from 2018-07-09 17-51-10](https://user-images.githubusercontent.com/17074021/42464506-25f2a858-83a1-11e8-94bc-99aca6cf7e76.png)\r\n![screenshot from 2018-07-09 17-51-21](https://user-images.githubusercontent.com/17074021/42464510-2a895510-83a1-11e8-855b-140ddc85a886.png)\r\n![screenshot from 2018-07-09 17-51-41](https://user-images.githubusercontent.com/17074021/42464516-2efd19ec-83a1-11e8-9608-d370cf320ad7.png)\r\n\r\nCodewise this sets the stylesheet globally instead of per window/widget. Don't have any metrics but in theory this should be more efficient as it avoids parsing the theme multiple times.\r\n\r\nThis reduces the need to pass the theme around all the time and ensures everything is themed (See unsaved work dialog)\r\n\r\nObviously a lot of this is up for discussion and #530 could help simplify many areas of theme handling","created_at":"2018-07-09T17:04:16Z","updated_at":"2018-07-09T18:15:47Z","closed_at":"2018-07-09T18:15:47Z","merged_at":"2018-07-09T18:15:47Z","merge_commit_sha":"d91180bac017dc35c782cca56d51ea7dd515240d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mu-editor/mu/pulls/533/commits","review_comments_url":"https://api.github.com/repos/mu-editor/mu/pulls/533/comments","review_comment_url":"https://api.github.com/repos/mu-editor/mu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mu-editor/mu/issues/533/comments","statuses_url":"https://api.github.com/repos/mu-editor/mu/statuses/d91180bac017dc35c782cca56d51ea7dd515240d","head":{"label":"ZanderBrown:base/more-styling-work","ref":"base/more-styling-work","sha":"d91180bac017dc35c782cca56d51ea7dd515240d","user":{"login":"ZanderBrown","id":17074021,"node_id":"MDQ6VXNlcjE3MDc0MDIx","avatar_url":"https://avatars0.githubusercontent.com/u/17074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ZanderBrown","html_url":"https://github.com/ZanderBrown","followers_url":"https://api.github.com/users/ZanderBrown/followers","following_url":"https://api.github.com/users/ZanderBrown/following{/other_user}","gists_url":"https://api.github.com/users/ZanderBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ZanderBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZanderBrown/subscriptions","organizations_url":"https://api.github.com/users/ZanderBrown/orgs","repos_url":"https://api.github.com/users/ZanderBrown/repos","events_url":"https://api.github.com/users/ZanderBrown/events{/privacy}","received_events_url":"https://api.github.com/users/ZanderBrown/received_events","type":"User","site_admin":false},"repo":{"id":65050969,"node_id":"MDEwOlJlcG9zaXRvcnk2NTA1MDk2OQ==","name":"mu","full_name":"ZanderBrown/mu","owner":{"login":"ZanderBrown","id":17074021,"node_id":"MDQ6VXNlcjE3MDc0MDIx","avatar_url":"https://avatars0.githubusercontent.com/u/17074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ZanderBrown","html_url":"https://github.com/ZanderBrown","followers_url":"https://api.github.com/users/ZanderBrown/followers","following_url":"https://api.github.com/users/ZanderBrown/following{/other_user}","gists_url":"https://api.github.com/users/ZanderBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ZanderBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZanderBrown/subscriptions","organizations_url":"https://api.github.com/users/ZanderBrown/orgs","repos_url":"https://api.github.com/users/ZanderBrown/repos","events_url":"https://api.github.com/users/ZanderBrown/events{/privacy}","received_events_url":"https://api.github.com/users/ZanderBrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZanderBrown/mu","description":"A \"micro\" editor for MicroPython and the BBC micro:bit. Written in Python and Qt5.","fork":true,"url":"https://api.github.com/repos/ZanderBrown/mu","forks_url":"https://api.github.com/repos/ZanderBrown/mu/forks","keys_url":"https://api.github.com/repos/ZanderBrown/mu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZanderBrown/mu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZanderBrown/mu/teams","hooks_url":"https://api.github.com/repos/ZanderBrown/mu/hooks","issue_events_url":"https://api.github.com/repos/ZanderBrown/mu/issues/events{/number}","events_url":"https://api.github.com/repos/ZanderBrown/mu/events","assignees_url":"https://api.github.com/repos/ZanderBrown/mu/assignees{/user}","branches_url":"https://api.github.com/repos/ZanderBrown/mu/branches{/branch}","tags_url":"https://api.github.com/repos/ZanderBrown/mu/tags","blobs_url":"https://api.github.com/repos/ZanderBrown/mu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZanderBrown/mu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZanderBrown/mu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZanderBrown/mu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZanderBrown/mu/statuses/{sha}","languages_url":"https://api.github.com/repos/ZanderBrown/mu/languages","stargazers_url":"https://api.github.com/repos/ZanderBrown/mu/stargazers","contributors_url":"https://api.github.com/repos/ZanderBrown/mu/contributors","subscribers_url":"https://api.github.com/repos/ZanderBrown/mu/subscribers","subscription_url":"https://api.github.com/repos/ZanderBrown/mu/subscription","commits_url":"https://api.github.com/repos/ZanderBrown/mu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZanderBrown/mu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZanderBrown/mu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZanderBrown/mu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZanderBrown/mu/contents/{+path}","compare_url":"https://api.github.com/repos/ZanderBrown/mu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZanderBrown/mu/merges","archive_url":"https://api.github.com/repos/ZanderBrown/mu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZanderBrown/mu/downloads","issues_url":"https://api.github.com/repos/ZanderBrown/mu/issues{/number}","pulls_url":"https://api.github.com/repos/ZanderBrown/mu/pulls{/number}","milestones_url":"https://api.github.com/repos/ZanderBrown/mu/milestones{/number}","notifications_url":"https://api.github.com/repos/ZanderBrown/mu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZanderBrown/mu/labels{/name}","releases_url":"https://api.github.com/repos/ZanderBrown/mu/releases{/id}","deployments_url":"https://api.github.com/repos/ZanderBrown/mu/deployments","created_at":"2016-08-05T21:44:27Z","updated_at":"2018-04-29T11:54:37Z","pushed_at":"2018-07-09T17:15:15Z","git_url":"git://github.com/ZanderBrown/mu.git","ssh_url":"git@github.com:ZanderBrown/mu.git","clone_url":"https://github.com/ZanderBrown/mu.git","svn_url":"https://github.com/ZanderBrown/mu","homepage":"http://codewith.mu/","size":12018,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mu-editor:master","ref":"master","sha":"97d0307065ba1f915f04c0f5787fcda42996c05d","user":{"login":"mu-editor","id":17850097,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODUwMDk3","avatar_url":"https://avatars3.githubusercontent.com/u/17850097?v=4","gravatar_id":"","url":"https://api.github.com/users/mu-editor","html_url":"https://github.com/mu-editor","followers_url":"https://api.github.com/users/mu-editor/followers","following_url":"https://api.github.com/users/mu-editor/following{/other_user}","gists_url":"https://api.github.com/users/mu-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/mu-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mu-editor/subscriptions","organizations_url":"https://api.github.com/users/mu-editor/orgs","repos_url":"https://api.github.com/users/mu-editor/repos","events_url":"https://api.github.com/users/mu-editor/events{/privacy}","received_events_url":"https://api.github.com/users/mu-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":47607357,"node_id":"MDEwOlJlcG9zaXRvcnk0NzYwNzM1Nw==","name":"mu","full_name":"mu-editor/mu","owner":{"login":"mu-editor","id":17850097,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODUwMDk3","avatar_url":"https://avatars3.githubusercontent.com/u/17850097?v=4","gravatar_id":"","url":"https://api.github.com/users/mu-editor","html_url":"https://github.com/mu-editor","followers_url":"https://api.github.com/users/mu-editor/followers","following_url":"https://api.github.com/users/mu-editor/following{/other_user}","gists_url":"https://api.github.com/users/mu-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/mu-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mu-editor/subscriptions","organizations_url":"https://api.github.com/users/mu-editor/orgs","repos_url":"https://api.github.com/users/mu-editor/repos","events_url":"https://api.github.com/users/mu-editor/events{/privacy}","received_events_url":"https://api.github.com/users/mu-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mu-editor/mu","description":"A small, simple editor for beginner Python programmers. Written in Python and Qt5.","fork":false,"url":"https://api.github.com/repos/mu-editor/mu","forks_url":"https://api.github.com/repos/mu-editor/mu/forks","keys_url":"https://api.github.com/repos/mu-editor/mu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mu-editor/mu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mu-editor/mu/teams","hooks_url":"https://api.github.com/repos/mu-editor/mu/hooks","issue_events_url":"https://api.github.com/repos/mu-editor/mu/issues/events{/number}","events_url":"https://api.github.com/repos/mu-editor/mu/events","assignees_url":"https://api.github.com/repos/mu-editor/mu/assignees{/user}","branches_url":"https://api.github.com/repos/mu-editor/mu/branches{/branch}","tags_url":"https://api.github.com/repos/mu-editor/mu/tags","blobs_url":"https://api.github.com/repos/mu-editor/mu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mu-editor/mu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mu-editor/mu/git/refs{/sha}","trees_url":"https://api.github.com/repos/mu-editor/mu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mu-editor/mu/statuses/{sha}","languages_url":"https://api.github.com/repos/mu-editor/mu/languages","stargazers_url":"https://api.github.com/repos/mu-editor/mu/stargazers","contributors_url":"https://api.github.com/repos/mu-editor/mu/contributors","subscribers_url":"https://api.github.com/repos/mu-editor/mu/subscribers","subscription_url":"https://api.github.com/repos/mu-editor/mu/subscription","commits_url":"https://api.github.com/repos/mu-editor/mu/commits{/sha}","git_commits_url":"https://api.github.com/repos/mu-editor/mu/git/commits{/sha}","comments_url":"https://api.github.com/repos/mu-editor/mu/comments{/number}","issue_comment_url":"https://api.github.com/repos/mu-editor/mu/issues/comments{/number}","contents_url":"https://api.github.com/repos/mu-editor/mu/contents/{+path}","compare_url":"https://api.github.com/repos/mu-editor/mu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mu-editor/mu/merges","archive_url":"https://api.github.com/repos/mu-editor/mu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mu-editor/mu/downloads","issues_url":"https://api.github.com/repos/mu-editor/mu/issues{/number}","pulls_url":"https://api.github.com/repos/mu-editor/mu/pulls{/number}","milestones_url":"https://api.github.com/repos/mu-editor/mu/milestones{/number}","notifications_url":"https://api.github.com/repos/mu-editor/mu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mu-editor/mu/labels{/name}","releases_url":"https://api.github.com/repos/mu-editor/mu/releases{/id}","deployments_url":"https://api.github.com/repos/mu-editor/mu/deployments","created_at":"2015-12-08T07:56:02Z","updated_at":"2018-07-09T16:22:52Z","pushed_at":"2018-07-09T18:15:46Z","git_url":"git://github.com/mu-editor/mu.git","ssh_url":"git@github.com:mu-editor/mu.git","clone_url":"https://github.com/mu-editor/mu.git","svn_url":"https://github.com/mu-editor/mu","homepage":"http://codewith.mu","size":12054,"stargazers_count":261,"watchers_count":261,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":123,"open_issues":49,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/533"},"html":{"href":"https://github.com/mu-editor/mu/pull/533"},"issue":{"href":"https://api.github.com/repos/mu-editor/mu/issues/533"},"comments":{"href":"https://api.github.com/repos/mu-editor/mu/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mu-editor/mu/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/mu-editor/mu/statuses/d91180bac017dc35c782cca56d51ea7dd515240d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ntoll","id":37602,"node_id":"MDQ6VXNlcjM3NjAy","avatar_url":"https://avatars0.githubusercontent.com/u/37602?v=4","gravatar_id":"","url":"https://api.github.com/users/ntoll","html_url":"https://github.com/ntoll","followers_url":"https://api.github.com/users/ntoll/followers","following_url":"https://api.github.com/users/ntoll/following{/other_user}","gists_url":"https://api.github.com/users/ntoll/gists{/gist_id}","starred_url":"https://api.github.com/users/ntoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntoll/subscriptions","organizations_url":"https://api.github.com/users/ntoll/orgs","repos_url":"https://api.github.com/users/ntoll/repos","events_url":"https://api.github.com/users/ntoll/events{/privacy}","received_events_url":"https://api.github.com/users/ntoll/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":15,"additions":433,"deletions":361,"changed_files":16}}
{"actor":{"display_login":"ntoll"}}