{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/ingress/issues/60","repository_url":"https://api.github.com/repos/Shopify/ingress","labels_url":"https://api.github.com/repos/Shopify/ingress/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/ingress/issues/60/comments","events_url":"https://api.github.com/repos/Shopify/ingress/issues/60/events","html_url":"https://github.com/Shopify/ingress/pull/60","id":333377208,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjA0NTIz","number":60,"title":"Add ssl certificate lua directive","user":{"login":"hnrytrn","id":14793715,"node_id":"MDQ6VXNlcjE0NzkzNzE1","avatar_url":"https://avatars3.githubusercontent.com/u/14793715?v=4","gravatar_id":"","url":"https://api.github.com/users/hnrytrn","html_url":"https://github.com/hnrytrn","followers_url":"https://api.github.com/users/hnrytrn/followers","following_url":"https://api.github.com/users/hnrytrn/following{/other_user}","gists_url":"https://api.github.com/users/hnrytrn/gists{/gist_id}","starred_url":"https://api.github.com/users/hnrytrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnrytrn/subscriptions","organizations_url":"https://api.github.com/users/hnrytrn/orgs","repos_url":"https://api.github.com/users/hnrytrn/repos","events_url":"https://api.github.com/users/hnrytrn/events{/privacy}","received_events_url":"https://api.github.com/users/hnrytrn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-18T18:05:59Z","updated_at":"2018-08-20T17:28:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Shopify/ingress/pulls/60","html_url":"https://github.com/Shopify/ingress/pull/60","diff_url":"https://github.com/Shopify/ingress/pull/60.diff","patch_url":"https://github.com/Shopify/ingress/pull/60.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis PR is a part of adding dynamic certificate serving functionality (Shopify/edgescale#515). This adds a Lua directive which serves the SSL Certificate from the shared dictionary.\r\n\r\n@Shopify/edgescale\r\n"},"comment":{"url":"https://api.github.com/repos/Shopify/ingress/issues/comments/414397934","html_url":"https://github.com/Shopify/ingress/pull/60#issuecomment-414397934","issue_url":"https://api.github.com/repos/Shopify/ingress/issues/60","id":414397934,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDM5NzkzNA==","user":{"login":"ElvinEfendi","id":1150042,"node_id":"MDQ6VXNlcjExNTAwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T17:28:28Z","updated_at":"2018-08-20T17:28:28Z","author_association":"NONE","body":"Lua side looks good except the empty certificate handling.\r\n\r\ne2e tests are not satisfactory, it's missing to test one of the two core purposes (skipping reload on only cert changes and serving the cers dynamically from Lua) of this new feature which making sure the cert is served dynamically by Lua."}}
{"actor":{"display_login":"ElvinEfendi"}}