{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/2818","repository_url":"https://api.github.com/repos/nunit/nunit","labels_url":"https://api.github.com/repos/nunit/nunit/issues/2818/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2818/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/2818/events","html_url":"https://github.com/nunit/nunit/pull/2818","id":316465049,"number":2818,"title":"Implemented the ability to await in STA tests 🎉","user":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"labels":[{"id":805814694,"url":"https://api.github.com/repos/nunit/nunit/labels/awaiting:review","name":"awaiting:review","color":"47e86a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-21T05:53:54Z","updated_at":"2018-05-05T01:58:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/2818","html_url":"https://github.com/nunit/nunit/pull/2818","diff_url":"https://github.com/nunit/nunit/pull/2818.diff","patch_url":"https://github.com/nunit/nunit/pull/2818.patch"},"body":"Fixes #1200, re: https://github.com/nunit/nunit/issues/2774\r\n\r\nWhew! This was fun and the collateral was worth doing, but this was a longer time coming than I expected!\r\n\r\nThe heart and soul of this change is the 8th (last) commit. Its motivating tests are the 6th commit.\r\n\r\nThe 7th commit took a lot of thought to get right while keeping the complexity down. It refactors AsyncInvocationRegion—which as I've noticed many times since I arrived at this project, had become neither async, an invocation, nor a region 😆—due to the necessity for it to control the invocation itself rather than being handed the return value from the invocation. I did my best to come up with a descriptive name, `AsyncToSyncAdapter`, since it adapts async execution to synchronous execution.\r\n\r\nThe preceding commits were things which were all in the critical path, so for simplicity they are in the same PR. They should each be viewed separately.\r\n\r\n@rprouse Would it be a good idea for me to do a walkthrough explanation of the 8th commit for posterity, or do #1200 and #2774 explain it well enough?\r\n\r\n/cc @sharwell"},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/386771550","html_url":"https://github.com/nunit/nunit/pull/2818#issuecomment-386771550","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2818","id":386771550,"user":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T01:58:43Z","updated_at":"2018-05-05T01:58:43Z","author_association":"CONTRIBUTOR","body":"> Looks good to me although it is a lot to digest. I've asked a couple of questions, so I am not approving yet. @ChrisMaddock or @mikkelbu are either of you up to a second review? This is a large change, so the more eyes the better.\r\n\r\nI would like a second one. Rob, from your review, do you think it would benefit from me commenting the code?"}}
{"actor":{"display_login":"jnm2"}}