{"action":"created","comment":{"url":"https://api.github.com/repos/onnx/onnx/pulls/comments/221394484","pull_request_review_id":160041136,"id":221394484,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTM5NDQ4NA==","diff_hunk":"@@ -59,10 +59,10 @@ ONNX_OPERATOR_SET_SCHEMA(\n         .Attr(\n             \"dtype\",\n             \"(Optional) The data type for the elements of the output tensor. If not specified,\"\n-            \"the data type of the input tensor T1 is used. If input tensor T1 is also not\" \n-            \"specified, then type defaults to 'float'.\",\n+            \"the data type of the input tensor T1 is used. If input tensor T1 is also not \" \n+            \"specified, then output tensor type defaults to 'float'.\",","path":"onnx/defs/generator/defs.cc","position":7,"original_position":7,"commit_id":"999acbcf438fbf1f181b730842f448688cf8cc59","original_commit_id":"999acbcf438fbf1f181b730842f448688cf8cc59","user":{"login":"spandantiwari","id":23646532,"node_id":"MDQ6VXNlcjIzNjQ2NTMy","avatar_url":"https://avatars3.githubusercontent.com/u/23646532?v=4","gravatar_id":"","url":"https://api.github.com/users/spandantiwari","html_url":"https://github.com/spandantiwari","followers_url":"https://api.github.com/users/spandantiwari/followers","following_url":"https://api.github.com/users/spandantiwari/following{/other_user}","gists_url":"https://api.github.com/users/spandantiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/spandantiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spandantiwari/subscriptions","organizations_url":"https://api.github.com/users/spandantiwari/orgs","repos_url":"https://api.github.com/users/spandantiwari/repos","events_url":"https://api.github.com/users/spandantiwari/events{/privacy}","received_events_url":"https://api.github.com/users/spandantiwari/received_events","type":"User","site_admin":false},"body":"umm, sorry, I am not sure if the description needs to be changed. The lines you are pointing to (62-63) are for the case when both `dtype` and input tensor are not provided, in which case the output tensor type, by default, should be float. \r\n\r\nMaybe I am misunderstanding your comment?","created_at":"2018-09-28T22:20:40Z","updated_at":"2018-09-28T22:20:40Z","html_url":"https://github.com/onnx/onnx/pull/1461#discussion_r221394484","pull_request_url":"https://api.github.com/repos/onnx/onnx/pulls/1461","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments/221394484"},"html":{"href":"https://github.com/onnx/onnx/pull/1461#discussion_r221394484"},"pull_request":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1461"}},"in_reply_to_id":221391827},"pull_request":{"url":"https://api.github.com/repos/onnx/onnx/pulls/1461","id":219096233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDk2MjMz","html_url":"https://github.com/onnx/onnx/pull/1461","diff_url":"https://github.com/onnx/onnx/pull/1461.diff","patch_url":"https://github.com/onnx/onnx/pull/1461.patch","issue_url":"https://api.github.com/repos/onnx/onnx/issues/1461","number":1461,"state":"open","locked":false,"title":"Remove default value for 'dtype' attribute in ConstantLike op.","user":{"login":"spandantiwari","id":23646532,"node_id":"MDQ6VXNlcjIzNjQ2NTMy","avatar_url":"https://avatars3.githubusercontent.com/u/23646532?v=4","gravatar_id":"","url":"https://api.github.com/users/spandantiwari","html_url":"https://github.com/spandantiwari","followers_url":"https://api.github.com/users/spandantiwari/followers","following_url":"https://api.github.com/users/spandantiwari/following{/other_user}","gists_url":"https://api.github.com/users/spandantiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/spandantiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spandantiwari/subscriptions","organizations_url":"https://api.github.com/users/spandantiwari/orgs","repos_url":"https://api.github.com/users/spandantiwari/repos","events_url":"https://api.github.com/users/spandantiwari/events{/privacy}","received_events_url":"https://api.github.com/users/spandantiwari/received_events","type":"User","site_admin":false},"body":"This is a bug in the spec of `ConstantLike` op. The spec says that if `dtype` is not specified then the type of the input tensor should be used as the output tensor type. But currently, with the default value specified for this op, this attribute will always be _present_, and therefore, it is contrary to the spec. With this fix the default value is removed, which will allow the `dtype` attribute to be absent, in which case the input tensor type can be used for output type. \r\n\r\nSince this op was checked in very recently (less than two weeks ago), I am not updating the opset for this change.","created_at":"2018-09-28T22:01:17Z","updated_at":"2018-09-28T22:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7aaea7df71501cc0f094bb231bab6175e83447f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"linkerzhang","id":5194557,"node_id":"MDQ6VXNlcjUxOTQ1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5194557?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerzhang","html_url":"https://github.com/linkerzhang","followers_url":"https://api.github.com/users/linkerzhang/followers","following_url":"https://api.github.com/users/linkerzhang/following{/other_user}","gists_url":"https://api.github.com/users/linkerzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerzhang/subscriptions","organizations_url":"https://api.github.com/users/linkerzhang/orgs","repos_url":"https://api.github.com/users/linkerzhang/repos","events_url":"https://api.github.com/users/linkerzhang/events{/privacy}","received_events_url":"https://api.github.com/users/linkerzhang/received_events","type":"User","site_admin":false},{"login":"ebarsoum","id":6488789,"node_id":"MDQ6VXNlcjY0ODg3ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6488789?v=4","gravatar_id":"","url":"https://api.github.com/users/ebarsoum","html_url":"https://github.com/ebarsoum","followers_url":"https://api.github.com/users/ebarsoum/followers","following_url":"https://api.github.com/users/ebarsoum/following{/other_user}","gists_url":"https://api.github.com/users/ebarsoum/gists{/gist_id}","starred_url":"https://api.github.com/users/ebarsoum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebarsoum/subscriptions","organizations_url":"https://api.github.com/users/ebarsoum/orgs","repos_url":"https://api.github.com/users/ebarsoum/repos","events_url":"https://api.github.com/users/ebarsoum/events{/privacy}","received_events_url":"https://api.github.com/users/ebarsoum/received_events","type":"User","site_admin":false},{"login":"bddppq","id":9300575,"node_id":"MDQ6VXNlcjkzMDA1NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9300575?v=4","gravatar_id":"","url":"https://api.github.com/users/bddppq","html_url":"https://github.com/bddppq","followers_url":"https://api.github.com/users/bddppq/followers","following_url":"https://api.github.com/users/bddppq/following{/other_user}","gists_url":"https://api.github.com/users/bddppq/gists{/gist_id}","starred_url":"https://api.github.com/users/bddppq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bddppq/subscriptions","organizations_url":"https://api.github.com/users/bddppq/orgs","repos_url":"https://api.github.com/users/bddppq/repos","events_url":"https://api.github.com/users/bddppq/events{/privacy}","received_events_url":"https://api.github.com/users/bddppq/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onnx/onnx/pulls/1461/commits","review_comments_url":"https://api.github.com/repos/onnx/onnx/pulls/1461/comments","review_comment_url":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onnx/onnx/issues/1461/comments","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/999acbcf438fbf1f181b730842f448688cf8cc59","head":{"label":"spandantiwari:spandantiwari/fix_constantlike_op_spec","ref":"spandantiwari/fix_constantlike_op_spec","sha":"999acbcf438fbf1f181b730842f448688cf8cc59","user":{"login":"spandantiwari","id":23646532,"node_id":"MDQ6VXNlcjIzNjQ2NTMy","avatar_url":"https://avatars3.githubusercontent.com/u/23646532?v=4","gravatar_id":"","url":"https://api.github.com/users/spandantiwari","html_url":"https://github.com/spandantiwari","followers_url":"https://api.github.com/users/spandantiwari/followers","following_url":"https://api.github.com/users/spandantiwari/following{/other_user}","gists_url":"https://api.github.com/users/spandantiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/spandantiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spandantiwari/subscriptions","organizations_url":"https://api.github.com/users/spandantiwari/orgs","repos_url":"https://api.github.com/users/spandantiwari/repos","events_url":"https://api.github.com/users/spandantiwari/events{/privacy}","received_events_url":"https://api.github.com/users/spandantiwari/received_events","type":"User","site_admin":false},"repo":{"id":149369276,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNjkyNzY=","name":"onnx","full_name":"spandantiwari/onnx","private":false,"owner":{"login":"spandantiwari","id":23646532,"node_id":"MDQ6VXNlcjIzNjQ2NTMy","avatar_url":"https://avatars3.githubusercontent.com/u/23646532?v=4","gravatar_id":"","url":"https://api.github.com/users/spandantiwari","html_url":"https://github.com/spandantiwari","followers_url":"https://api.github.com/users/spandantiwari/followers","following_url":"https://api.github.com/users/spandantiwari/following{/other_user}","gists_url":"https://api.github.com/users/spandantiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/spandantiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spandantiwari/subscriptions","organizations_url":"https://api.github.com/users/spandantiwari/orgs","repos_url":"https://api.github.com/users/spandantiwari/repos","events_url":"https://api.github.com/users/spandantiwari/events{/privacy}","received_events_url":"https://api.github.com/users/spandantiwari/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spandantiwari/onnx","description":"Open Neural Network Exchange","fork":true,"url":"https://api.github.com/repos/spandantiwari/onnx","forks_url":"https://api.github.com/repos/spandantiwari/onnx/forks","keys_url":"https://api.github.com/repos/spandantiwari/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spandantiwari/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spandantiwari/onnx/teams","hooks_url":"https://api.github.com/repos/spandantiwari/onnx/hooks","issue_events_url":"https://api.github.com/repos/spandantiwari/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/spandantiwari/onnx/events","assignees_url":"https://api.github.com/repos/spandantiwari/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/spandantiwari/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/spandantiwari/onnx/tags","blobs_url":"https://api.github.com/repos/spandantiwari/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spandantiwari/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spandantiwari/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/spandantiwari/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spandantiwari/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/spandantiwari/onnx/languages","stargazers_url":"https://api.github.com/repos/spandantiwari/onnx/stargazers","contributors_url":"https://api.github.com/repos/spandantiwari/onnx/contributors","subscribers_url":"https://api.github.com/repos/spandantiwari/onnx/subscribers","subscription_url":"https://api.github.com/repos/spandantiwari/onnx/subscription","commits_url":"https://api.github.com/repos/spandantiwari/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/spandantiwari/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/spandantiwari/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/spandantiwari/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/spandantiwari/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/spandantiwari/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spandantiwari/onnx/merges","archive_url":"https://api.github.com/repos/spandantiwari/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spandantiwari/onnx/downloads","issues_url":"https://api.github.com/repos/spandantiwari/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/spandantiwari/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/spandantiwari/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/spandantiwari/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spandantiwari/onnx/labels{/name}","releases_url":"https://api.github.com/repos/spandantiwari/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/spandantiwari/onnx/deployments","created_at":"2018-09-19T00:35:57Z","updated_at":"2018-09-19T00:36:01Z","pushed_at":"2018-09-28T21:55:32Z","git_url":"git://github.com/spandantiwari/onnx.git","ssh_url":"git@github.com:spandantiwari/onnx.git","clone_url":"https://github.com/spandantiwari/onnx.git","svn_url":"https://github.com/spandantiwari/onnx","homepage":"https://onnx.ai/","size":7135,"stargazers_count":0,"watchers_count":0,"language":"PureBasic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onnx:master","ref":"master","sha":"c52a76c63aade696fe556ce1f4e99ef458ce57d9","user":{"login":"onnx","id":31675368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjc1MzY4","avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"repo":{"id":102692863,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2OTI4NjM=","name":"onnx","full_name":"onnx/onnx","private":false,"owner":{"login":"onnx","id":31675368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjc1MzY4","avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onnx/onnx","description":"Open Neural Network Exchange","fork":false,"url":"https://api.github.com/repos/onnx/onnx","forks_url":"https://api.github.com/repos/onnx/onnx/forks","keys_url":"https://api.github.com/repos/onnx/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onnx/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onnx/onnx/teams","hooks_url":"https://api.github.com/repos/onnx/onnx/hooks","issue_events_url":"https://api.github.com/repos/onnx/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/onnx/onnx/events","assignees_url":"https://api.github.com/repos/onnx/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/onnx/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/onnx/onnx/tags","blobs_url":"https://api.github.com/repos/onnx/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onnx/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onnx/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onnx/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/onnx/onnx/languages","stargazers_url":"https://api.github.com/repos/onnx/onnx/stargazers","contributors_url":"https://api.github.com/repos/onnx/onnx/contributors","subscribers_url":"https://api.github.com/repos/onnx/onnx/subscribers","subscription_url":"https://api.github.com/repos/onnx/onnx/subscription","commits_url":"https://api.github.com/repos/onnx/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onnx/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onnx/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onnx/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onnx/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/onnx/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onnx/onnx/merges","archive_url":"https://api.github.com/repos/onnx/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onnx/onnx/downloads","issues_url":"https://api.github.com/repos/onnx/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/onnx/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/onnx/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/onnx/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onnx/onnx/labels{/name}","releases_url":"https://api.github.com/repos/onnx/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/onnx/onnx/deployments","created_at":"2017-09-07T04:53:45Z","updated_at":"2018-09-28T22:00:25Z","pushed_at":"2018-09-28T22:01:18Z","git_url":"git://github.com/onnx/onnx.git","ssh_url":"git@github.com:onnx/onnx.git","clone_url":"https://github.com/onnx/onnx.git","svn_url":"https://github.com/onnx/onnx","homepage":"https://onnx.ai/","size":7176,"stargazers_count":4361,"watchers_count":4361,"language":"PureBasic","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":612,"mirror_url":null,"archived":false,"open_issues_count":234,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":612,"open_issues":234,"watchers":4361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1461"},"html":{"href":"https://github.com/onnx/onnx/pull/1461"},"issue":{"href":"https://api.github.com/repos/onnx/onnx/issues/1461"},"comments":{"href":"https://api.github.com/repos/onnx/onnx/issues/1461/comments"},"review_comments":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1461/comments"},"review_comment":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1461/commits"},"statuses":{"href":"https://api.github.com/repos/onnx/onnx/statuses/999acbcf438fbf1f181b730842f448688cf8cc59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spandantiwari"}}