{"action":"created","comment":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/comments/169097310","pull_request_review_id":97568520,"id":169097310,"diff_hunk":"@@ -500,9 +500,11 @@ module.exports = class cobinhood extends Exchange {\n         headers = {};\n         if (api === 'private') {\n             this.checkRequiredCredentials ();\n-            headers['device_id'] = this.apiKey;\n+            // headers['device_id'] = this.apiKey;\n             headers['nonce'] = this.nonce ();\n-            headers['Authorization'] = this.jwt (query, this.secret);\n+            // headers['Authorization'] = this.jwt (query, this.secret);\n+            // cobinhood give a new JWT token that must be used into Authorization header","path":"js/cobinhood.js","position":9,"original_position":9,"commit_id":"943d751ce0693c7083f463acf58ea0b2c9e6f521","original_commit_id":"943d751ce0693c7083f463acf58ea0b2c9e6f521","user":{"login":"lfern","id":1374427,"avatar_url":"https://avatars3.githubusercontent.com/u/1374427?v=4","gravatar_id":"","url":"https://api.github.com/users/lfern","html_url":"https://github.com/lfern","followers_url":"https://api.github.com/users/lfern/followers","following_url":"https://api.github.com/users/lfern/following{/other_user}","gists_url":"https://api.github.com/users/lfern/gists{/gist_id}","starred_url":"https://api.github.com/users/lfern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfern/subscriptions","organizations_url":"https://api.github.com/users/lfern/orgs","repos_url":"https://api.github.com/users/lfern/repos","events_url":"https://api.github.com/users/lfern/events{/privacy}","received_events_url":"https://api.github.com/users/lfern/received_events","type":"User","site_admin":false},"body":"Do you mean write a better comment into the code?","created_at":"2018-02-19T14:52:49Z","updated_at":"2018-02-19T14:52:49Z","html_url":"https://github.com/ccxt/ccxt/pull/1957#discussion_r169097310","pull_request_url":"https://api.github.com/repos/ccxt/ccxt/pulls/1957","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/comments/169097310"},"html":{"href":"https://github.com/ccxt/ccxt/pull/1957#discussion_r169097310"},"pull_request":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/1957"}},"in_reply_to_id":169094802},"pull_request":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/1957","id":169959682,"html_url":"https://github.com/ccxt/ccxt/pull/1957","diff_url":"https://github.com/ccxt/ccxt/pull/1957.diff","patch_url":"https://github.com/ccxt/ccxt/pull/1957.patch","issue_url":"https://api.github.com/repos/ccxt/ccxt/issues/1957","number":1957,"state":"open","locked":false,"title":"Update cobinhood.js JWT authorization","user":{"login":"lfern","id":1374427,"avatar_url":"https://avatars3.githubusercontent.com/u/1374427?v=4","gravatar_id":"","url":"https://api.github.com/users/lfern","html_url":"https://github.com/lfern","followers_url":"https://api.github.com/users/lfern/followers","following_url":"https://api.github.com/users/lfern/following{/other_user}","gists_url":"https://api.github.com/users/lfern/gists{/gist_id}","starred_url":"https://api.github.com/users/lfern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfern/subscriptions","organizations_url":"https://api.github.com/users/lfern/orgs","repos_url":"https://api.github.com/users/lfern/repos","events_url":"https://api.github.com/users/lfern/events{/privacy}","received_events_url":"https://api.github.com/users/lfern/received_events","type":"User","site_admin":false},"body":"cobinhood generate new JWT token on web that must be set on Authorization header.","created_at":"2018-02-19T13:25:01Z","updated_at":"2018-02-19T14:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67a99fbc0d59a5c1edad6ae55a5dcaf130f09588","assignee":{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroitor","id":1294454,"avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ccxt/ccxt/pulls/1957/commits","review_comments_url":"https://api.github.com/repos/ccxt/ccxt/pulls/1957/comments","review_comment_url":"https://api.github.com/repos/ccxt/ccxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccxt/ccxt/issues/1957/comments","statuses_url":"https://api.github.com/repos/ccxt/ccxt/statuses/943d751ce0693c7083f463acf58ea0b2c9e6f521","head":{"label":"lfern:master","ref":"master","sha":"943d751ce0693c7083f463acf58ea0b2c9e6f521","user":{"login":"lfern","id":1374427,"avatar_url":"https://avatars3.githubusercontent.com/u/1374427?v=4","gravatar_id":"","url":"https://api.github.com/users/lfern","html_url":"https://github.com/lfern","followers_url":"https://api.github.com/users/lfern/followers","following_url":"https://api.github.com/users/lfern/following{/other_user}","gists_url":"https://api.github.com/users/lfern/gists{/gist_id}","starred_url":"https://api.github.com/users/lfern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfern/subscriptions","organizations_url":"https://api.github.com/users/lfern/orgs","repos_url":"https://api.github.com/users/lfern/repos","events_url":"https://api.github.com/users/lfern/events{/privacy}","received_events_url":"https://api.github.com/users/lfern/received_events","type":"User","site_admin":false},"repo":{"id":122065384,"name":"ccxt","full_name":"lfern/ccxt","owner":{"login":"lfern","id":1374427,"avatar_url":"https://avatars3.githubusercontent.com/u/1374427?v=4","gravatar_id":"","url":"https://api.github.com/users/lfern","html_url":"https://github.com/lfern","followers_url":"https://api.github.com/users/lfern/followers","following_url":"https://api.github.com/users/lfern/following{/other_user}","gists_url":"https://api.github.com/users/lfern/gists{/gist_id}","starred_url":"https://api.github.com/users/lfern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfern/subscriptions","organizations_url":"https://api.github.com/users/lfern/orgs","repos_url":"https://api.github.com/users/lfern/repos","events_url":"https://api.github.com/users/lfern/events{/privacy}","received_events_url":"https://api.github.com/users/lfern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lfern/ccxt","description":"A JavaScript / Python / PHP cryptocurrency trading library with support for more than 90 bitcoin/altcoin exchanges","fork":true,"url":"https://api.github.com/repos/lfern/ccxt","forks_url":"https://api.github.com/repos/lfern/ccxt/forks","keys_url":"https://api.github.com/repos/lfern/ccxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lfern/ccxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lfern/ccxt/teams","hooks_url":"https://api.github.com/repos/lfern/ccxt/hooks","issue_events_url":"https://api.github.com/repos/lfern/ccxt/issues/events{/number}","events_url":"https://api.github.com/repos/lfern/ccxt/events","assignees_url":"https://api.github.com/repos/lfern/ccxt/assignees{/user}","branches_url":"https://api.github.com/repos/lfern/ccxt/branches{/branch}","tags_url":"https://api.github.com/repos/lfern/ccxt/tags","blobs_url":"https://api.github.com/repos/lfern/ccxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lfern/ccxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lfern/ccxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lfern/ccxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lfern/ccxt/statuses/{sha}","languages_url":"https://api.github.com/repos/lfern/ccxt/languages","stargazers_url":"https://api.github.com/repos/lfern/ccxt/stargazers","contributors_url":"https://api.github.com/repos/lfern/ccxt/contributors","subscribers_url":"https://api.github.com/repos/lfern/ccxt/subscribers","subscription_url":"https://api.github.com/repos/lfern/ccxt/subscription","commits_url":"https://api.github.com/repos/lfern/ccxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lfern/ccxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lfern/ccxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lfern/ccxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lfern/ccxt/contents/{+path}","compare_url":"https://api.github.com/repos/lfern/ccxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lfern/ccxt/merges","archive_url":"https://api.github.com/repos/lfern/ccxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lfern/ccxt/downloads","issues_url":"https://api.github.com/repos/lfern/ccxt/issues{/number}","pulls_url":"https://api.github.com/repos/lfern/ccxt/pulls{/number}","milestones_url":"https://api.github.com/repos/lfern/ccxt/milestones{/number}","notifications_url":"https://api.github.com/repos/lfern/ccxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lfern/ccxt/labels{/name}","releases_url":"https://api.github.com/repos/lfern/ccxt/releases{/id}","deployments_url":"https://api.github.com/repos/lfern/ccxt/deployments","created_at":"2018-02-19T13:21:24Z","updated_at":"2018-02-19T13:21:32Z","pushed_at":"2018-02-19T13:23:31Z","git_url":"git://github.com/lfern/ccxt.git","ssh_url":"git@github.com:lfern/ccxt.git","clone_url":"https://github.com/lfern/ccxt.git","svn_url":"https://github.com/lfern/ccxt","homepage":"","size":406510,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ccxt:master","ref":"master","sha":"f2994091125310c64462d46920064ee68facf0cb","user":{"login":"ccxt","id":31901609,"avatar_url":"https://avatars3.githubusercontent.com/u/31901609?v=4","gravatar_id":"","url":"https://api.github.com/users/ccxt","html_url":"https://github.com/ccxt","followers_url":"https://api.github.com/users/ccxt/followers","following_url":"https://api.github.com/users/ccxt/following{/other_user}","gists_url":"https://api.github.com/users/ccxt/gists{/gist_id}","starred_url":"https://api.github.com/users/ccxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccxt/subscriptions","organizations_url":"https://api.github.com/users/ccxt/orgs","repos_url":"https://api.github.com/users/ccxt/repos","events_url":"https://api.github.com/users/ccxt/events{/privacy}","received_events_url":"https://api.github.com/users/ccxt/received_events","type":"Organization","site_admin":false},"repo":{"id":91253698,"name":"ccxt","full_name":"ccxt/ccxt","owner":{"login":"ccxt","id":31901609,"avatar_url":"https://avatars3.githubusercontent.com/u/31901609?v=4","gravatar_id":"","url":"https://api.github.com/users/ccxt","html_url":"https://github.com/ccxt","followers_url":"https://api.github.com/users/ccxt/followers","following_url":"https://api.github.com/users/ccxt/following{/other_user}","gists_url":"https://api.github.com/users/ccxt/gists{/gist_id}","starred_url":"https://api.github.com/users/ccxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccxt/subscriptions","organizations_url":"https://api.github.com/users/ccxt/orgs","repos_url":"https://api.github.com/users/ccxt/repos","events_url":"https://api.github.com/users/ccxt/events{/privacy}","received_events_url":"https://api.github.com/users/ccxt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ccxt/ccxt","description":"A JavaScript / Python / PHP cryptocurrency trading library with support for more than 90 bitcoin/altcoin exchanges","fork":false,"url":"https://api.github.com/repos/ccxt/ccxt","forks_url":"https://api.github.com/repos/ccxt/ccxt/forks","keys_url":"https://api.github.com/repos/ccxt/ccxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccxt/ccxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccxt/ccxt/teams","hooks_url":"https://api.github.com/repos/ccxt/ccxt/hooks","issue_events_url":"https://api.github.com/repos/ccxt/ccxt/issues/events{/number}","events_url":"https://api.github.com/repos/ccxt/ccxt/events","assignees_url":"https://api.github.com/repos/ccxt/ccxt/assignees{/user}","branches_url":"https://api.github.com/repos/ccxt/ccxt/branches{/branch}","tags_url":"https://api.github.com/repos/ccxt/ccxt/tags","blobs_url":"https://api.github.com/repos/ccxt/ccxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccxt/ccxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccxt/ccxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccxt/ccxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccxt/ccxt/statuses/{sha}","languages_url":"https://api.github.com/repos/ccxt/ccxt/languages","stargazers_url":"https://api.github.com/repos/ccxt/ccxt/stargazers","contributors_url":"https://api.github.com/repos/ccxt/ccxt/contributors","subscribers_url":"https://api.github.com/repos/ccxt/ccxt/subscribers","subscription_url":"https://api.github.com/repos/ccxt/ccxt/subscription","commits_url":"https://api.github.com/repos/ccxt/ccxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccxt/ccxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccxt/ccxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccxt/ccxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccxt/ccxt/contents/{+path}","compare_url":"https://api.github.com/repos/ccxt/ccxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccxt/ccxt/merges","archive_url":"https://api.github.com/repos/ccxt/ccxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccxt/ccxt/downloads","issues_url":"https://api.github.com/repos/ccxt/ccxt/issues{/number}","pulls_url":"https://api.github.com/repos/ccxt/ccxt/pulls{/number}","milestones_url":"https://api.github.com/repos/ccxt/ccxt/milestones{/number}","notifications_url":"https://api.github.com/repos/ccxt/ccxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccxt/ccxt/labels{/name}","releases_url":"https://api.github.com/repos/ccxt/ccxt/releases{/id}","deployments_url":"https://api.github.com/repos/ccxt/ccxt/deployments","created_at":"2017-05-14T15:41:56Z","updated_at":"2018-02-19T14:45:27Z","pushed_at":"2018-02-19T14:29:52Z","git_url":"git://github.com/ccxt/ccxt.git","ssh_url":"git@github.com:ccxt/ccxt.git","clone_url":"https://github.com/ccxt/ccxt.git","svn_url":"https://github.com/ccxt/ccxt","homepage":"","size":406563,"stargazers_count":4390,"watchers_count":4390,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1066,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1066,"open_issues":151,"watchers":4390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/1957"},"html":{"href":"https://github.com/ccxt/ccxt/pull/1957"},"issue":{"href":"https://api.github.com/repos/ccxt/ccxt/issues/1957"},"comments":{"href":"https://api.github.com/repos/ccxt/ccxt/issues/1957/comments"},"review_comments":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/1957/comments"},"review_comment":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/1957/commits"},"statuses":{"href":"https://api.github.com/repos/ccxt/ccxt/statuses/943d751ce0693c7083f463acf58ea0b2c9e6f521"}},"author_association":"NONE"}}
{"actor":{"display_login":"lfern"}}