{"action":"created","issue":{"url":"https://api.github.com/repos/touilleMan/godot-python/issues/90","repository_url":"https://api.github.com/repos/touilleMan/godot-python","labels_url":"https://api.github.com/repos/touilleMan/godot-python/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/touilleMan/godot-python/issues/90/comments","events_url":"https://api.github.com/repos/touilleMan/godot-python/issues/90/events","html_url":"https://github.com/touilleMan/godot-python/pull/90","id":316037259,"number":90,"title":"Static binding generation","user":{"login":"prokopst","id":1501810,"avatar_url":"https://avatars3.githubusercontent.com/u/1501810?v=4","gravatar_id":"","url":"https://api.github.com/users/prokopst","html_url":"https://github.com/prokopst","followers_url":"https://api.github.com/users/prokopst/followers","following_url":"https://api.github.com/users/prokopst/following{/other_user}","gists_url":"https://api.github.com/users/prokopst/gists{/gist_id}","starred_url":"https://api.github.com/users/prokopst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prokopst/subscriptions","organizations_url":"https://api.github.com/users/prokopst/orgs","repos_url":"https://api.github.com/users/prokopst/repos","events_url":"https://api.github.com/users/prokopst/events{/privacy}","received_events_url":"https://api.github.com/users/prokopst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-19T20:55:02Z","updated_at":"2018-04-20T16:55:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/touilleMan/godot-python/pulls/90","html_url":"https://github.com/touilleMan/godot-python/pull/90","diff_url":"https://github.com/touilleMan/godot-python/pull/90.diff","patch_url":"https://github.com/touilleMan/godot-python/pull/90.patch"},"body":"* Singleton handling moved to a template. \r\n* Added safe ordering of classes based on inheritance, and added inheritance for classes.\r\n\r\nBtw I noticed that singletons can be inherited, but inherited classes are not singletons.\r\n```\r\n  {\r\n   \"name\": \"IP\",\r\n   \"base_class\": \"Object\",\r\n   \"api_type\": \"core\",\r\n   \"singleton\": true,\r\n   \"instanciable\": false,\r\n   \"is_reference\": false,\r\n...\r\n```\r\n\r\n```\r\n  {\r\n   \"name\": \"IP_Unix\",\r\n   \"base_class\": \"IP\",\r\n   \"api_type\": \"core\",\r\n   \"singleton\": false,\r\n   \"instanciable\": false,\r\n   \"is_reference\": false,\r\n   \"constants\": {},\r\n   \"properties\": [],\r\n   \"signals\": [],\r\n   \"methods\": [],\r\n   \"enums\": []\r\n  },\r\n```"},"comment":{"url":"https://api.github.com/repos/touilleMan/godot-python/issues/comments/383157860","html_url":"https://github.com/touilleMan/godot-python/pull/90#issuecomment-383157860","issue_url":"https://api.github.com/repos/touilleMan/godot-python/issues/90","id":383157860,"user":{"login":"touilleMan","id":3187637,"avatar_url":"https://avatars1.githubusercontent.com/u/3187637?v=4","gravatar_id":"","url":"https://api.github.com/users/touilleMan","html_url":"https://github.com/touilleMan","followers_url":"https://api.github.com/users/touilleMan/followers","following_url":"https://api.github.com/users/touilleMan/following{/other_user}","gists_url":"https://api.github.com/users/touilleMan/gists{/gist_id}","starred_url":"https://api.github.com/users/touilleMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/touilleMan/subscriptions","organizations_url":"https://api.github.com/users/touilleMan/orgs","repos_url":"https://api.github.com/users/touilleMan/repos","events_url":"https://api.github.com/users/touilleMan/events{/privacy}","received_events_url":"https://api.github.com/users/touilleMan/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T16:55:45Z","updated_at":"2018-04-20T16:55:45Z","author_association":"OWNER","body":"> Btw I noticed that singletons can be inherited, but inherited classes are not singletons.\r\n\r\nMy guess is `IP` is both the name of an abstract class and a singleton, singleton which is an instance of `IP_Unix` when running the engine on linux for instance.\r\n\r\nIn the end, I think we should store the class marked as singleton two times: one in the `classes` list that will be used to generate class binding, and a second time in the `singletons` list."}}
{"actor":{"display_login":"touilleMan"}}