{"action":"created","comment":{"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments/212145699","pull_request_review_id":148715177,"id":212145699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjE0NTY5OQ==","diff_hunk":"@@ -606,3 +606,28 @@ def check_basic_env():\n                  JAVA_DIRECTORY = \"/usr/bin/\"\r\n         ''')\r\n         os.kill(os.getpid(), signal.SIGTERM)\r\n+\r\n+\r\n+\r\n+class FileType(object):\r\n+    def __init__(self, file_type, file_name_lower):\r\n+        self.file_type = file_type\r\n+        self.file_name_lower = file_name_lower\r\n+\r\n+    def is_allow_file(self):\r\n+        \"\"\"\r\n+        return bool\r\n+        \"\"\"\r\n+        if self.is_apk() or self.is_zip() or self.is_ipa() or self.is_appx():\r\n+            return True\r\n+        return False\r\n+    \r\n+    def is_apk(self):\r\n+        return ((self.file_type in settings.APK_MIME) and self.file_name_lower.endswith('.apk'))\r","path":"MobSF/utils.py","position":21,"original_position":21,"commit_id":"82abd7b0b0d84dc53b05f3870da17df095ebce0d","original_commit_id":"82abd7b0b0d84dc53b05f3870da17df095ebce0d","user":{"login":"magaofei","id":3363787,"node_id":"MDQ6VXNlcjMzNjM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3363787?v=4","gravatar_id":"","url":"https://api.github.com/users/magaofei","html_url":"https://github.com/magaofei","followers_url":"https://api.github.com/users/magaofei/followers","following_url":"https://api.github.com/users/magaofei/following{/other_user}","gists_url":"https://api.github.com/users/magaofei/gists{/gist_id}","starred_url":"https://api.github.com/users/magaofei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magaofei/subscriptions","organizations_url":"https://api.github.com/users/magaofei/orgs","repos_url":"https://api.github.com/users/magaofei/repos","events_url":"https://api.github.com/users/magaofei/events{/privacy}","received_events_url":"https://api.github.com/users/magaofei/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-08-22T23:51:32Z","updated_at":"2018-08-22T23:51:32Z","html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/693#discussion_r212145699","pull_request_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments/212145699"},"html":{"href":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/693#discussion_r212145699"},"pull_request":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693"}},"in_reply_to_id":212027869},"pull_request":{"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693","id":210038314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDM4MzE0","html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/693","diff_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/693.diff","patch_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/693.patch","issue_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/693","number":693,"state":"open","locked":false,"title":"upload url refactoring","user":{"login":"magaofei","id":3363787,"node_id":"MDQ6VXNlcjMzNjM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3363787?v=4","gravatar_id":"","url":"https://api.github.com/users/magaofei","html_url":"https://github.com/magaofei","followers_url":"https://api.github.com/users/magaofei/followers","following_url":"https://api.github.com/users/magaofei/following{/other_user}","gists_url":"https://api.github.com/users/magaofei/gists{/gist_id}","starred_url":"https://api.github.com/users/magaofei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magaofei/subscriptions","organizations_url":"https://api.github.com/users/magaofei/orgs","repos_url":"https://api.github.com/users/magaofei/repos","events_url":"https://api.github.com/users/magaofei/events{/privacy}","received_events_url":"https://api.github.com/users/magaofei/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for your contribution to MobSF! -->\r\n\r\n### What was a problem?\r\n\r\n```\r\nupload url refactoring\r\nAll test completed\r\n```\r\n\r\n### How this PR fixes the problem?\r\n\r\n```\r\nDESCRIBE HERE\r\n```\r\n\r\n### Check lists (check `x` in `[ ]` of list items)\r\n\r\n- [x] Run MobSF unit tests\r\n- [ ] Tested Working on Linux, Mac, and Windows\r\n- [x] Coding style (indentation, etc)\r\n\r\n### Additional Comments (if any)\r\n\r\n```\r\nDESCRIBE HERE\r\n```\r\n","created_at":"2018-08-22T07:07:47Z","updated_at":"2018-08-22T23:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05686c47852197e0420c87b38a8dbfefaf3ecb62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693/commits","review_comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693/comments","review_comment_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/693/comments","statuses_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/82abd7b0b0d84dc53b05f3870da17df095ebce0d","head":{"label":"magaofei:upload","ref":"upload","sha":"82abd7b0b0d84dc53b05f3870da17df095ebce0d","user":{"login":"magaofei","id":3363787,"node_id":"MDQ6VXNlcjMzNjM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3363787?v=4","gravatar_id":"","url":"https://api.github.com/users/magaofei","html_url":"https://github.com/magaofei","followers_url":"https://api.github.com/users/magaofei/followers","following_url":"https://api.github.com/users/magaofei/following{/other_user}","gists_url":"https://api.github.com/users/magaofei/gists{/gist_id}","starred_url":"https://api.github.com/users/magaofei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magaofei/subscriptions","organizations_url":"https://api.github.com/users/magaofei/orgs","repos_url":"https://api.github.com/users/magaofei/repos","events_url":"https://api.github.com/users/magaofei/events{/privacy}","received_events_url":"https://api.github.com/users/magaofei/received_events","type":"User","site_admin":false},"repo":{"id":144808925,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MDg5MjU=","name":"Mobile-Security-Framework-MobSF","full_name":"magaofei/Mobile-Security-Framework-MobSF","owner":{"login":"magaofei","id":3363787,"node_id":"MDQ6VXNlcjMzNjM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3363787?v=4","gravatar_id":"","url":"https://api.github.com/users/magaofei","html_url":"https://github.com/magaofei","followers_url":"https://api.github.com/users/magaofei/followers","following_url":"https://api.github.com/users/magaofei/following{/other_user}","gists_url":"https://api.github.com/users/magaofei/gists{/gist_id}","starred_url":"https://api.github.com/users/magaofei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magaofei/subscriptions","organizations_url":"https://api.github.com/users/magaofei/orgs","repos_url":"https://api.github.com/users/magaofei/repos","events_url":"https://api.github.com/users/magaofei/events{/privacy}","received_events_url":"https://api.github.com/users/magaofei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magaofei/Mobile-Security-Framework-MobSF","description":"Mobile Security Framework is an automated, all-in-one mobile application (Android/iOS/Windows) pen-testing framework capable of performing static analysis, dynamic analysis, malware analysis and web API testing.","fork":true,"url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF","forks_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/forks","keys_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/teams","hooks_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/hooks","issue_events_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/issues/events{/number}","events_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/events","assignees_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/assignees{/user}","branches_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/branches{/branch}","tags_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/tags","blobs_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/git/refs{/sha}","trees_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/statuses/{sha}","languages_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/languages","stargazers_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/stargazers","contributors_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/contributors","subscribers_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/subscribers","subscription_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/subscription","commits_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/commits{/sha}","git_commits_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/git/commits{/sha}","comments_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/comments{/number}","issue_comment_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/issues/comments{/number}","contents_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/contents/{+path}","compare_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/merges","archive_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/downloads","issues_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/issues{/number}","pulls_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/pulls{/number}","milestones_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/milestones{/number}","notifications_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/labels{/name}","releases_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/releases{/id}","deployments_url":"https://api.github.com/repos/magaofei/Mobile-Security-Framework-MobSF/deployments","created_at":"2018-08-15T05:17:10Z","updated_at":"2018-08-16T09:05:20Z","pushed_at":"2018-08-22T07:06:04Z","git_url":"git://github.com/magaofei/Mobile-Security-Framework-MobSF.git","ssh_url":"git@github.com:magaofei/Mobile-Security-Framework-MobSF.git","clone_url":"https://github.com/magaofei/Mobile-Security-Framework-MobSF.git","svn_url":"https://github.com/magaofei/Mobile-Security-Framework-MobSF","homepage":"https://opensecurity.in","size":240612,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MobSF:master","ref":"master","sha":"d244def15808d414d5a804ae306941b49548130a","user":{"login":"MobSF","id":25052637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDUyNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/25052637?v=4","gravatar_id":"","url":"https://api.github.com/users/MobSF","html_url":"https://github.com/MobSF","followers_url":"https://api.github.com/users/MobSF/followers","following_url":"https://api.github.com/users/MobSF/following{/other_user}","gists_url":"https://api.github.com/users/MobSF/gists{/gist_id}","starred_url":"https://api.github.com/users/MobSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobSF/subscriptions","organizations_url":"https://api.github.com/users/MobSF/orgs","repos_url":"https://api.github.com/users/MobSF/repos","events_url":"https://api.github.com/users/MobSF/events{/privacy}","received_events_url":"https://api.github.com/users/MobSF/received_events","type":"Organization","site_admin":false},"repo":{"id":30102273,"node_id":"MDEwOlJlcG9zaXRvcnkzMDEwMjI3Mw==","name":"Mobile-Security-Framework-MobSF","full_name":"MobSF/Mobile-Security-Framework-MobSF","owner":{"login":"MobSF","id":25052637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDUyNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/25052637?v=4","gravatar_id":"","url":"https://api.github.com/users/MobSF","html_url":"https://github.com/MobSF","followers_url":"https://api.github.com/users/MobSF/followers","following_url":"https://api.github.com/users/MobSF/following{/other_user}","gists_url":"https://api.github.com/users/MobSF/gists{/gist_id}","starred_url":"https://api.github.com/users/MobSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobSF/subscriptions","organizations_url":"https://api.github.com/users/MobSF/orgs","repos_url":"https://api.github.com/users/MobSF/repos","events_url":"https://api.github.com/users/MobSF/events{/privacy}","received_events_url":"https://api.github.com/users/MobSF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF","description":"Mobile Security Framework is an automated, all-in-one mobile application (Android/iOS/Windows) pen-testing framework capable of performing static analysis, dynamic analysis, malware analysis and web API testing.","fork":false,"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF","forks_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/forks","keys_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/teams","hooks_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/hooks","issue_events_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/events{/number}","events_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/events","assignees_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/assignees{/user}","branches_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/branches{/branch}","tags_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/tags","blobs_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/refs{/sha}","trees_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/{sha}","languages_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/languages","stargazers_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/stargazers","contributors_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/contributors","subscribers_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/subscribers","subscription_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/subscription","commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/commits{/sha}","git_commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/commits{/sha}","comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/comments{/number}","issue_comment_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/comments{/number}","contents_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/contents/{+path}","compare_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/merges","archive_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/downloads","issues_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues{/number}","pulls_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls{/number}","milestones_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/milestones{/number}","notifications_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/labels{/name}","releases_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/releases{/id}","deployments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/deployments","created_at":"2015-01-31T04:36:01Z","updated_at":"2018-08-22T22:33:39Z","pushed_at":"2018-08-22T20:16:17Z","git_url":"git://github.com/MobSF/Mobile-Security-Framework-MobSF.git","ssh_url":"git@github.com:MobSF/Mobile-Security-Framework-MobSF.git","clone_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF.git","svn_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF","homepage":"https://opensecurity.in","size":240627,"stargazers_count":3033,"watchers_count":3033,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1013,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1013,"open_issues":11,"watchers":3033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693"},"html":{"href":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/693"},"issue":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/693"},"comments":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/82abd7b0b0d84dc53b05f3870da17df095ebce0d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"magaofei"}}