{"action":"opened","number":102,"pull_request":{"url":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/102","id":212419196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDE5MTk2","html_url":"https://github.com/folio-org/mod-circulation-storage/pull/102","diff_url":"https://github.com/folio-org/mod-circulation-storage/pull/102.diff","patch_url":"https://github.com/folio-org/mod-circulation-storage/pull/102.patch","issue_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/102","number":102,"state":"open","locked":false,"title":"Preparation for CIRCSTORE-71","user":{"login":"marcjohnson-kint","id":30145808,"node_id":"MDQ6VXNlcjMwMTQ1ODA4","avatar_url":"https://avatars0.githubusercontent.com/u/30145808?v=4","gravatar_id":"","url":"https://api.github.com/users/marcjohnson-kint","html_url":"https://github.com/marcjohnson-kint","followers_url":"https://api.github.com/users/marcjohnson-kint/followers","following_url":"https://api.github.com/users/marcjohnson-kint/following{/other_user}","gists_url":"https://api.github.com/users/marcjohnson-kint/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjohnson-kint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjohnson-kint/subscriptions","organizations_url":"https://api.github.com/users/marcjohnson-kint/orgs","repos_url":"https://api.github.com/users/marcjohnson-kint/repos","events_url":"https://api.github.com/users/marcjohnson-kint/events{/privacy}","received_events_url":"https://api.github.com/users/marcjohnson-kint/received_events","type":"User","site_admin":false},"body":"*Purpose*\r\n\r\nTo improve the loans API tests in order to make it easier to add the required behaviour for CIRCSTORE-71\r\n\r\n*Approach*\r\n\r\n* Reduce the noise in the tests by extracting common activities and expectations around those activities, for example, when creating a loan we expect the response to be the created status code\r\n\r\n* Allow a loan request builder to be created from an existing representation, so that it can be used to make changes when replacing records\r\n\r\n*Opportunities*\r\nThe extracted matchers and client should be able to be used in API tests for other kinds of records","created_at":"2018-08-31T15:27:58Z","updated_at":"2018-08-31T15:27:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/102/commits","review_comments_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/102/comments","review_comment_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/102/comments","statuses_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/statuses/9f0e74b7f00eb6ef0150c7b369379cb54c97805a","head":{"label":"folio-org:CIRCSTORE-71-preparation","ref":"CIRCSTORE-71-preparation","sha":"9f0e74b7f00eb6ef0150c7b369379cb54c97805a","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":83340403,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM0MDQwMw==","name":"mod-circulation-storage","full_name":"folio-org/mod-circulation-storage","owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/mod-circulation-storage","description":"FOLIO mod-circulation-storage","fork":false,"url":"https://api.github.com/repos/folio-org/mod-circulation-storage","forks_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/forks","keys_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/teams","hooks_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/hooks","issue_events_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/events","assignees_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/tags","blobs_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/languages","stargazers_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/stargazers","contributors_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/contributors","subscribers_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/subscribers","subscription_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/subscription","commits_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/merges","archive_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/downloads","issues_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/deployments","created_at":"2017-02-27T17:58:40Z","updated_at":"2018-08-29T10:36:01Z","pushed_at":"2018-08-31T15:23:11Z","git_url":"git://github.com/folio-org/mod-circulation-storage.git","ssh_url":"git@github.com:folio-org/mod-circulation-storage.git","clone_url":"https://github.com/folio-org/mod-circulation-storage.git","svn_url":"https://github.com/folio-org/mod-circulation-storage","homepage":"","size":577,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"1edbbdbeafc2b8d1db4bc52c403ea336dd3e1827","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":83340403,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM0MDQwMw==","name":"mod-circulation-storage","full_name":"folio-org/mod-circulation-storage","owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/mod-circulation-storage","description":"FOLIO mod-circulation-storage","fork":false,"url":"https://api.github.com/repos/folio-org/mod-circulation-storage","forks_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/forks","keys_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/teams","hooks_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/hooks","issue_events_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/events","assignees_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/tags","blobs_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/languages","stargazers_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/stargazers","contributors_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/contributors","subscribers_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/subscribers","subscription_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/subscription","commits_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/merges","archive_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/downloads","issues_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/mod-circulation-storage/deployments","created_at":"2017-02-27T17:58:40Z","updated_at":"2018-08-29T10:36:01Z","pushed_at":"2018-08-31T15:23:11Z","git_url":"git://github.com/folio-org/mod-circulation-storage.git","ssh_url":"git@github.com:folio-org/mod-circulation-storage.git","clone_url":"https://github.com/folio-org/mod-circulation-storage.git","svn_url":"https://github.com/folio-org/mod-circulation-storage","homepage":"","size":577,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/102"},"html":{"href":"https://github.com/folio-org/mod-circulation-storage/pull/102"},"issue":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/102"},"comments":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/mod-circulation-storage/statuses/9f0e74b7f00eb6ef0150c7b369379cb54c97805a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":30,"additions":997,"deletions":653,"changed_files":20}}
{"actor":{"display_login":"marcjohnson-kint"}}