{"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/165508973","pull_request_review_id":93462952,"id":165508973,"diff_hunk":"@@ -0,0 +1,95 @@\n+/*\n+ * Copyright 2018 The Cartographer Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#include \"cartographer_grpc/handlers/add_landmark_data_handler.h\"\n+#include \"cartographer_grpc/testing/add_data_handler_test.h\"\n+#include \"cartographer_grpc/testing/test_helpers.h\"\n+#include \"google/protobuf/text_format.h\"\n+#include \"gtest/gtest.h\"\n+\n+namespace cartographer_grpc {\n+namespace handlers {\n+namespace {\n+\n+using ::testing::_;\n+using ::testing::Eq;\n+using ::testing::Pointee;\n+using ::testing::Truly;\n+\n+const std::string kMessage = R\"PROTO(","path":"cartographer_grpc/handlers/add_landmark_data_handler_test.cc","position":32,"original_position":32,"commit_id":"05e4de76118a939f0ae85cef35c6c582284c7b31","original_commit_id":"05e4de76118a939f0ae85cef35c6c582284c7b31","user":{"login":"pifon2a","id":32522095,"avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"body":"in google3 I think we would have \"constexpr char kMessage[] = \", but we are not in google3 :)","created_at":"2018-02-01T22:34:16Z","updated_at":"2018-02-01T22:34:16Z","html_url":"https://github.com/googlecartographer/cartographer/pull/881#discussion_r165508973","pull_request_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/165508973"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/881#discussion_r165508973"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881"}}},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881","id":166666469,"html_url":"https://github.com/googlecartographer/cartographer/pull/881","diff_url":"https://github.com/googlecartographer/cartographer/pull/881.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/881.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/881","number":881,"state":"open","locked":false,"title":"Implement tests for various data adding handlers","user":{"login":"cschuet","id":25035505,"avatar_url":"https://avatars3.githubusercontent.com/u/25035505?v=4","gravatar_id":"","url":"https://api.github.com/users/cschuet","html_url":"https://github.com/cschuet","followers_url":"https://api.github.com/users/cschuet/followers","following_url":"https://api.github.com/users/cschuet/following{/other_user}","gists_url":"https://api.github.com/users/cschuet/gists{/gist_id}","starred_url":"https://api.github.com/users/cschuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschuet/subscriptions","organizations_url":"https://api.github.com/users/cschuet/orgs","repos_url":"https://api.github.com/users/cschuet/repos","events_url":"https://api.github.com/users/cschuet/events{/privacy}","received_events_url":"https://api.github.com/users/cschuet/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-01T22:13:12Z","updated_at":"2018-02-01T22:34:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01d0c803d2f1963c50050bc52f48f69014a6b0c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/881/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/05e4de76118a939f0ae85cef35c6c582284c7b31","head":{"label":"cschuet:handler_tests","ref":"handler_tests","sha":"05e4de76118a939f0ae85cef35c6c582284c7b31","user":{"login":"cschuet","id":25035505,"avatar_url":"https://avatars3.githubusercontent.com/u/25035505?v=4","gravatar_id":"","url":"https://api.github.com/users/cschuet","html_url":"https://github.com/cschuet","followers_url":"https://api.github.com/users/cschuet/followers","following_url":"https://api.github.com/users/cschuet/following{/other_user}","gists_url":"https://api.github.com/users/cschuet/gists{/gist_id}","starred_url":"https://api.github.com/users/cschuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschuet/subscriptions","organizations_url":"https://api.github.com/users/cschuet/orgs","repos_url":"https://api.github.com/users/cschuet/repos","events_url":"https://api.github.com/users/cschuet/events{/privacy}","received_events_url":"https://api.github.com/users/cschuet/received_events","type":"User","site_admin":false},"repo":{"id":101299121,"name":"cartographer","full_name":"cschuet/cartographer","owner":{"login":"cschuet","id":25035505,"avatar_url":"https://avatars3.githubusercontent.com/u/25035505?v=4","gravatar_id":"","url":"https://api.github.com/users/cschuet","html_url":"https://github.com/cschuet","followers_url":"https://api.github.com/users/cschuet/followers","following_url":"https://api.github.com/users/cschuet/following{/other_user}","gists_url":"https://api.github.com/users/cschuet/gists{/gist_id}","starred_url":"https://api.github.com/users/cschuet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschuet/subscriptions","organizations_url":"https://api.github.com/users/cschuet/orgs","repos_url":"https://api.github.com/users/cschuet/repos","events_url":"https://api.github.com/users/cschuet/events{/privacy}","received_events_url":"https://api.github.com/users/cschuet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cschuet/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":true,"url":"https://api.github.com/repos/cschuet/cartographer","forks_url":"https://api.github.com/repos/cschuet/cartographer/forks","keys_url":"https://api.github.com/repos/cschuet/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cschuet/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cschuet/cartographer/teams","hooks_url":"https://api.github.com/repos/cschuet/cartographer/hooks","issue_events_url":"https://api.github.com/repos/cschuet/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/cschuet/cartographer/events","assignees_url":"https://api.github.com/repos/cschuet/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/cschuet/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/cschuet/cartographer/tags","blobs_url":"https://api.github.com/repos/cschuet/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cschuet/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cschuet/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cschuet/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cschuet/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/cschuet/cartographer/languages","stargazers_url":"https://api.github.com/repos/cschuet/cartographer/stargazers","contributors_url":"https://api.github.com/repos/cschuet/cartographer/contributors","subscribers_url":"https://api.github.com/repos/cschuet/cartographer/subscribers","subscription_url":"https://api.github.com/repos/cschuet/cartographer/subscription","commits_url":"https://api.github.com/repos/cschuet/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cschuet/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cschuet/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cschuet/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cschuet/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/cschuet/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cschuet/cartographer/merges","archive_url":"https://api.github.com/repos/cschuet/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cschuet/cartographer/downloads","issues_url":"https://api.github.com/repos/cschuet/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/cschuet/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/cschuet/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/cschuet/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cschuet/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/cschuet/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/cschuet/cartographer/deployments","created_at":"2017-08-24T13:41:15Z","updated_at":"2017-08-24T13:41:18Z","pushed_at":"2018-02-01T22:14:42Z","git_url":"git://github.com/cschuet/cartographer.git","ssh_url":"git@github.com:cschuet/cartographer.git","clone_url":"https://github.com/cschuet/cartographer.git","svn_url":"https://github.com/cschuet/cartographer","homepage":"","size":3530,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"92fa1782f383da45ddcd87aa68a1047ee4c76259","user":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64732358,"name":"cartographer","full_name":"googlecartographer/cartographer","owner":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer","forks_url":"https://api.github.com/repos/googlecartographer/cartographer/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer/deployments","created_at":"2016-08-02T06:55:43Z","updated_at":"2018-02-01T10:42:42Z","pushed_at":"2018-02-01T22:14:43Z","git_url":"git://github.com/googlecartographer/cartographer.git","ssh_url":"git@github.com:googlecartographer/cartographer.git","clone_url":"https://github.com/googlecartographer/cartographer.git","svn_url":"https://github.com/googlecartographer/cartographer","homepage":"","size":3179,"stargazers_count":3145,"watchers_count":3145,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":993,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":993,"open_issues":21,"watchers":3145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/881"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/881"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/881/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/881/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer/statuses/05e4de76118a939f0ae85cef35c6c582284c7b31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pifon2a"}}