{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-go/issues/1978","repository_url":"https://api.github.com/repos/aws/aws-sdk-go","labels_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/1978/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/1978/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/1978/events","html_url":"https://github.com/aws/aws-sdk-go/pull/1978","id":330520378,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTA5NDc1","number":1978,"title":"service/dynamodb/dynamodbattribute: Retain backwards compatibility with ConvertTo","user":{"login":"kalafut","id":211880,"node_id":"MDQ6VXNlcjIxMTg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/211880?v=4","gravatar_id":"","url":"https://api.github.com/users/kalafut","html_url":"https://github.com/kalafut","followers_url":"https://api.github.com/users/kalafut/followers","following_url":"https://api.github.com/users/kalafut/following{/other_user}","gists_url":"https://api.github.com/users/kalafut/gists{/gist_id}","starred_url":"https://api.github.com/users/kalafut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalafut/subscriptions","organizations_url":"https://api.github.com/users/kalafut/orgs","repos_url":"https://api.github.com/users/kalafut/repos","events_url":"https://api.github.com/users/kalafut/events{/privacy}","received_events_url":"https://api.github.com/users/kalafut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-08T05:02:21Z","updated_at":"2018-06-11T16:13:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-go/pulls/1978","html_url":"https://github.com/aws/aws-sdk-go/pull/1978","diff_url":"https://github.com/aws/aws-sdk-go/pull/1978.diff","patch_url":"https://github.com/aws/aws-sdk-go/pull/1978.patch"},"body":"The sdk docs explain how the Convert* functions are deprecated and (Un)marshal should be used instead. But Unmarshalling data originally created with Convert* can have issues which I've not seen mentioned in the docs. We ran into this issue in our most recent Vault release: https://github.com/hashicorp/vault/issues/4721\r\n\r\nThis PR adds special handling if string data is the source for a byte slice field. Previously, an Unmarshalling error would be returned. Now, if the string is valid base64 data--as it would be if it came from Convert*--then it will be decoded as base64 and saved as bytes."},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-go/issues/comments/396299246","html_url":"https://github.com/aws/aws-sdk-go/pull/1978#issuecomment-396299246","issue_url":"https://api.github.com/repos/aws/aws-sdk-go/issues/1978","id":396299246,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjI5OTI0Ng==","user":{"login":"jasdel","id":961963,"node_id":"MDQ6VXNlcjk2MTk2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/961963?v=4","gravatar_id":"","url":"https://api.github.com/users/jasdel","html_url":"https://github.com/jasdel","followers_url":"https://api.github.com/users/jasdel/followers","following_url":"https://api.github.com/users/jasdel/following{/other_user}","gists_url":"https://api.github.com/users/jasdel/gists{/gist_id}","starred_url":"https://api.github.com/users/jasdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasdel/subscriptions","organizations_url":"https://api.github.com/users/jasdel/orgs","repos_url":"https://api.github.com/users/jasdel/repos","events_url":"https://api.github.com/users/jasdel/events{/privacy}","received_events_url":"https://api.github.com/users/jasdel/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T16:13:38Z","updated_at":"2018-06-11T16:13:38Z","author_association":"MEMBER","body":"Thanks for making the updates @kalafut . The changes look good. I'll get this merged in and it will be included in the SDK's next release."}}
{"actor":{"display_login":"jasdel"}}