{"action":"closed","number":151,"pull_request":{"url":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/151","id":225451859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDUxODU5","html_url":"https://github.com/oceanprotocol/pleuston/pull/151","diff_url":"https://github.com/oceanprotocol/pleuston/pull/151.diff","patch_url":"https://github.com/oceanprotocol/pleuston/pull/151.patch","issue_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues/151","number":151,"state":"closed","locked":false,"title":"Samples and links metadata","user":{"login":"kremalicious","id":90316,"node_id":"MDQ6VXNlcjkwMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/90316?v=4","gravatar_id":"","url":"https://api.github.com/users/kremalicious","html_url":"https://github.com/kremalicious","followers_url":"https://api.github.com/users/kremalicious/followers","following_url":"https://api.github.com/users/kremalicious/following{/other_user}","gists_url":"https://api.github.com/users/kremalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/kremalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kremalicious/subscriptions","organizations_url":"https://api.github.com/users/kremalicious/orgs","repos_url":"https://api.github.com/users/kremalicious/repos","events_url":"https://api.github.com/users/kremalicious/events{/privacy}","received_events_url":"https://api.github.com/users/kremalicious/received_events","type":"User","site_admin":false},"body":"**WIP**\r\n\r\n* adds the ability to create one or multiple links for an asset, and output them\r\n* reorganize components used on `/new` screen\r\n* new simplified `FormInput` component usage\r\n* closes #150 \r\n* part of https://github.com/oceanprotocol/ocean/issues/123\r\n\r\n### ToDo\r\n\r\n- [x] `links` is array of link objects\r\n- [x] design and create UI prototype for adding multiple links\r\n- [x] structure link object with `name`, `type`, `url` (following OEP-08 & proposed changes in https://github.com/oceanprotocol/OEPs/pull/82 & https://github.com/oceanprotocol/OEPs/pull/86)\r\n\r\n#### adding flow\r\n\r\n- [x] remove added link\r\n- [x] return when required fields are empty\r\n- [x] form error feedback\r\n- [x] capture all link form values, send along on full form submit\r\n- [ ] save captured data to aquarius\r\n\r\n#### display on AssetFull view\r\n\r\n- [x] output all links on asset full view\r\n\r\n### Showcase\r\n\r\n![untitled](https://user-images.githubusercontent.com/90316/47563298-ac242c00-d921-11e8-8293-a0853aa83787.gif)\r\n\r\n---\r\n\r\nDefault empty state:\r\n\r\n<img width=\"591\" alt=\"screen shot 2018-10-25 at 14 01 46\" src=\"https://user-images.githubusercontent.com/90316/47498775-88e47880-d85e-11e8-8fcf-0d3a51bfa67d.png\">\r\n\r\n---\r\n\r\nList added links, progressive disclosure of form:\r\n\r\n<img width=\"559\" alt=\"screen shot 2018-10-26 at 14 16 39\" src=\"https://user-images.githubusercontent.com/90316/47565735-cd891600-d929-11e8-9fb3-2db846b6ccc2.png\">\r\n\r\n---\r\n\r\n<img width=\"564\" alt=\"screen shot 2018-10-26 at 14 16 47\" src=\"https://user-images.githubusercontent.com/90316/47565739-d0840680-d929-11e8-83f8-ab71b97e5557.png\">\r\n\r\n## Types of changes\r\n\r\n- [x] New feature (non-breaking change which adds functionality)\r\n \r\n## Checklist:\r\n\r\n- [x] Follows the code style of this project.\r\n- [ ] Tests Cover Changes\r\n- [ ] Documentation\r\n\r\n#### Funny gif\r\n\r\n![giphy](https://user-images.githubusercontent.com/90316/47498859-c6e19c80-d85e-11e8-8ae7-0b063d89f9bc.gif)","created_at":"2018-10-24T15:33:48Z","updated_at":"2018-11-19T10:48:50Z","closed_at":"2018-11-19T10:48:50Z","merged_at":"2018-11-19T10:48:50Z","merge_commit_sha":"72ae880b198336f0be162da9091b93641537f9d6","assignee":{"login":"kremalicious","id":90316,"node_id":"MDQ6VXNlcjkwMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/90316?v=4","gravatar_id":"","url":"https://api.github.com/users/kremalicious","html_url":"https://github.com/kremalicious","followers_url":"https://api.github.com/users/kremalicious/followers","following_url":"https://api.github.com/users/kremalicious/following{/other_user}","gists_url":"https://api.github.com/users/kremalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/kremalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kremalicious/subscriptions","organizations_url":"https://api.github.com/users/kremalicious/orgs","repos_url":"https://api.github.com/users/kremalicious/repos","events_url":"https://api.github.com/users/kremalicious/events{/privacy}","received_events_url":"https://api.github.com/users/kremalicious/received_events","type":"User","site_admin":false},"assignees":[{"login":"kremalicious","id":90316,"node_id":"MDQ6VXNlcjkwMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/90316?v=4","gravatar_id":"","url":"https://api.github.com/users/kremalicious","html_url":"https://github.com/kremalicious","followers_url":"https://api.github.com/users/kremalicious/followers","following_url":"https://api.github.com/users/kremalicious/following{/other_user}","gists_url":"https://api.github.com/users/kremalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/kremalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kremalicious/subscriptions","organizations_url":"https://api.github.com/users/kremalicious/orgs","repos_url":"https://api.github.com/users/kremalicious/repos","events_url":"https://api.github.com/users/kremalicious/events{/privacy}","received_events_url":"https://api.github.com/users/kremalicious/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"Maintainers","id":2702044,"node_id":"MDQ6VGVhbTI3MDIwNDQ=","slug":"maintainers","description":"","privacy":"closed","url":"https://api.github.com/teams/2702044","members_url":"https://api.github.com/teams/2702044/members{/member}","repositories_url":"https://api.github.com/teams/2702044/repos","permission":"pull"},{"name":"Core Dev","id":2802356,"node_id":"MDQ6VGVhbTI4MDIzNTY=","slug":"core-dev","description":"Ocean Core Dev","privacy":"closed","url":"https://api.github.com/teams/2802356","members_url":"https://api.github.com/teams/2802356/members{/member}","repositories_url":"https://api.github.com/teams/2802356/repos","permission":"pull"}],"labels":[{"id":1116627877,"node_id":"MDU6TGFiZWwxMTE2NjI3ODc3","url":"https://api.github.com/repos/oceanprotocol/pleuston/labels/status:blocked","name":"status:blocked","color":"984de2","default":false},{"id":1027022778,"node_id":"MDU6TGFiZWwxMDI3MDIyNzc4","url":"https://api.github.com/repos/oceanprotocol/pleuston/labels/status:wip","name":"status:wip","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/151/commits","review_comments_url":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/151/comments","review_comment_url":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues/151/comments","statuses_url":"https://api.github.com/repos/oceanprotocol/pleuston/statuses/5b5989b4f8714a1a6f3692f0f33fd1f7a48e2b0f","head":{"label":"oceanprotocol:feature/links","ref":"feature/links","sha":"5b5989b4f8714a1a6f3692f0f33fd1f7a48e2b0f","user":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":136030275,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzAyNzU=","name":"pleuston","full_name":"oceanprotocol/pleuston","private":false,"owner":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanprotocol/pleuston","description":"🦄 Web app for consumers to explore, download, and publish data assets.","fork":false,"url":"https://api.github.com/repos/oceanprotocol/pleuston","forks_url":"https://api.github.com/repos/oceanprotocol/pleuston/forks","keys_url":"https://api.github.com/repos/oceanprotocol/pleuston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanprotocol/pleuston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanprotocol/pleuston/teams","hooks_url":"https://api.github.com/repos/oceanprotocol/pleuston/hooks","issue_events_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues/events{/number}","events_url":"https://api.github.com/repos/oceanprotocol/pleuston/events","assignees_url":"https://api.github.com/repos/oceanprotocol/pleuston/assignees{/user}","branches_url":"https://api.github.com/repos/oceanprotocol/pleuston/branches{/branch}","tags_url":"https://api.github.com/repos/oceanprotocol/pleuston/tags","blobs_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanprotocol/pleuston/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanprotocol/pleuston/languages","stargazers_url":"https://api.github.com/repos/oceanprotocol/pleuston/stargazers","contributors_url":"https://api.github.com/repos/oceanprotocol/pleuston/contributors","subscribers_url":"https://api.github.com/repos/oceanprotocol/pleuston/subscribers","subscription_url":"https://api.github.com/repos/oceanprotocol/pleuston/subscription","commits_url":"https://api.github.com/repos/oceanprotocol/pleuston/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanprotocol/pleuston/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanprotocol/pleuston/contents/{+path}","compare_url":"https://api.github.com/repos/oceanprotocol/pleuston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanprotocol/pleuston/merges","archive_url":"https://api.github.com/repos/oceanprotocol/pleuston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanprotocol/pleuston/downloads","issues_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues{/number}","pulls_url":"https://api.github.com/repos/oceanprotocol/pleuston/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanprotocol/pleuston/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanprotocol/pleuston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanprotocol/pleuston/labels{/name}","releases_url":"https://api.github.com/repos/oceanprotocol/pleuston/releases{/id}","deployments_url":"https://api.github.com/repos/oceanprotocol/pleuston/deployments","created_at":"2018-06-04T13:35:42Z","updated_at":"2018-11-19T10:36:43Z","pushed_at":"2018-11-19T10:48:50Z","git_url":"git://github.com/oceanprotocol/pleuston.git","ssh_url":"git@github.com:oceanprotocol/pleuston.git","clone_url":"https://github.com/oceanprotocol/pleuston.git","svn_url":"https://github.com/oceanprotocol/pleuston","homepage":"https://oceanprotocol.com","size":4784,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":8,"watchers":12,"default_branch":"develop"}},"base":{"label":"oceanprotocol:develop","ref":"develop","sha":"7452319b1e3c598469b3f4aa46d5d2c5f2f3364a","user":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":136030275,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzAyNzU=","name":"pleuston","full_name":"oceanprotocol/pleuston","private":false,"owner":{"login":"oceanprotocol","id":31523682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTIzNjgy","avatar_url":"https://avatars2.githubusercontent.com/u/31523682?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanprotocol","html_url":"https://github.com/oceanprotocol","followers_url":"https://api.github.com/users/oceanprotocol/followers","following_url":"https://api.github.com/users/oceanprotocol/following{/other_user}","gists_url":"https://api.github.com/users/oceanprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanprotocol/subscriptions","organizations_url":"https://api.github.com/users/oceanprotocol/orgs","repos_url":"https://api.github.com/users/oceanprotocol/repos","events_url":"https://api.github.com/users/oceanprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/oceanprotocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanprotocol/pleuston","description":"🦄 Web app for consumers to explore, download, and publish data assets.","fork":false,"url":"https://api.github.com/repos/oceanprotocol/pleuston","forks_url":"https://api.github.com/repos/oceanprotocol/pleuston/forks","keys_url":"https://api.github.com/repos/oceanprotocol/pleuston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanprotocol/pleuston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanprotocol/pleuston/teams","hooks_url":"https://api.github.com/repos/oceanprotocol/pleuston/hooks","issue_events_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues/events{/number}","events_url":"https://api.github.com/repos/oceanprotocol/pleuston/events","assignees_url":"https://api.github.com/repos/oceanprotocol/pleuston/assignees{/user}","branches_url":"https://api.github.com/repos/oceanprotocol/pleuston/branches{/branch}","tags_url":"https://api.github.com/repos/oceanprotocol/pleuston/tags","blobs_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanprotocol/pleuston/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanprotocol/pleuston/languages","stargazers_url":"https://api.github.com/repos/oceanprotocol/pleuston/stargazers","contributors_url":"https://api.github.com/repos/oceanprotocol/pleuston/contributors","subscribers_url":"https://api.github.com/repos/oceanprotocol/pleuston/subscribers","subscription_url":"https://api.github.com/repos/oceanprotocol/pleuston/subscription","commits_url":"https://api.github.com/repos/oceanprotocol/pleuston/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanprotocol/pleuston/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanprotocol/pleuston/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanprotocol/pleuston/contents/{+path}","compare_url":"https://api.github.com/repos/oceanprotocol/pleuston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanprotocol/pleuston/merges","archive_url":"https://api.github.com/repos/oceanprotocol/pleuston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanprotocol/pleuston/downloads","issues_url":"https://api.github.com/repos/oceanprotocol/pleuston/issues{/number}","pulls_url":"https://api.github.com/repos/oceanprotocol/pleuston/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanprotocol/pleuston/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanprotocol/pleuston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanprotocol/pleuston/labels{/name}","releases_url":"https://api.github.com/repos/oceanprotocol/pleuston/releases{/id}","deployments_url":"https://api.github.com/repos/oceanprotocol/pleuston/deployments","created_at":"2018-06-04T13:35:42Z","updated_at":"2018-11-19T10:36:43Z","pushed_at":"2018-11-19T10:48:50Z","git_url":"git://github.com/oceanprotocol/pleuston.git","ssh_url":"git@github.com:oceanprotocol/pleuston.git","clone_url":"https://github.com/oceanprotocol/pleuston.git","svn_url":"https://github.com/oceanprotocol/pleuston","homepage":"https://oceanprotocol.com","size":4784,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":8,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/151"},"html":{"href":"https://github.com/oceanprotocol/pleuston/pull/151"},"issue":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/issues/151"},"comments":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/oceanprotocol/pleuston/statuses/5b5989b4f8714a1a6f3692f0f33fd1f7a48e2b0f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kremalicious","id":90316,"node_id":"MDQ6VXNlcjkwMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/90316?v=4","gravatar_id":"","url":"https://api.github.com/users/kremalicious","html_url":"https://github.com/kremalicious","followers_url":"https://api.github.com/users/kremalicious/followers","following_url":"https://api.github.com/users/kremalicious/following{/other_user}","gists_url":"https://api.github.com/users/kremalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/kremalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kremalicious/subscriptions","organizations_url":"https://api.github.com/users/kremalicious/orgs","repos_url":"https://api.github.com/users/kremalicious/repos","events_url":"https://api.github.com/users/kremalicious/events{/privacy}","received_events_url":"https://api.github.com/users/kremalicious/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":24,"additions":644,"deletions":196,"changed_files":41}}
{"actor":{"display_login":"kremalicious"}}