{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/iri/pulls/comments/232493949","pull_request_review_id":173704212,"id":232493949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ5Mzk0OQ==","diff_hunk":"@@ -106,6 +179,14 @@\n         return address;\n     }\n \n+    // Signing\n+\n+    /**\n+     * Deterministically Normalize the bundle hash such that {@code sum(bundle) == 0} <br>","path":"src/main/java/com/iota/iri/crypto/ISS.java","position":126,"original_position":126,"commit_id":"21c93dcd9d34148ec77cea43b2495a51b4585c37","original_commit_id":"21c93dcd9d34148ec77cea43b2495a51b4585c37","user":{"login":"GalRogozinski","id":7954839,"node_id":"MDQ6VXNlcjc5NTQ4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7954839?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRogozinski","html_url":"https://github.com/GalRogozinski","followers_url":"https://api.github.com/users/GalRogozinski/followers","following_url":"https://api.github.com/users/GalRogozinski/following{/other_user}","gists_url":"https://api.github.com/users/GalRogozinski/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRogozinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRogozinski/subscriptions","organizations_url":"https://api.github.com/users/GalRogozinski/orgs","repos_url":"https://api.github.com/users/GalRogozinski/repos","events_url":"https://api.github.com/users/GalRogozinski/events{/privacy}","received_events_url":"https://api.github.com/users/GalRogozinski/received_events","type":"User","site_admin":false},"body":"Could you explain more in depth what are you summing up with `sum`?","created_at":"2018-11-11T16:12:21Z","updated_at":"2018-11-11T16:59:55Z","html_url":"https://github.com/iotaledger/iri/pull/1139#discussion_r232493949","pull_request_url":"https://api.github.com/repos/iotaledger/iri/pulls/1139","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/comments/232493949"},"html":{"href":"https://github.com/iotaledger/iri/pull/1139#discussion_r232493949"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1139"}}},"pull_request":{"url":"https://api.github.com/repos/iotaledger/iri/pulls/1139","id":229959576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTU5NTc2","html_url":"https://github.com/iotaledger/iri/pull/1139","diff_url":"https://github.com/iotaledger/iri/pull/1139.diff","patch_url":"https://github.com/iotaledger/iri/pull/1139.patch","issue_url":"https://api.github.com/repos/iotaledger/iri/issues/1139","number":1139,"state":"open","locked":false,"title":"Document crypto package","user":{"login":"alon-e","id":25587995,"node_id":"MDQ6VXNlcjI1NTg3OTk1","avatar_url":"https://avatars3.githubusercontent.com/u/25587995?v=4","gravatar_id":"","url":"https://api.github.com/users/alon-e","html_url":"https://github.com/alon-e","followers_url":"https://api.github.com/users/alon-e/followers","following_url":"https://api.github.com/users/alon-e/following{/other_user}","gists_url":"https://api.github.com/users/alon-e/gists{/gist_id}","starred_url":"https://api.github.com/users/alon-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alon-e/subscriptions","organizations_url":"https://api.github.com/users/alon-e/orgs","repos_url":"https://api.github.com/users/alon-e/repos","events_url":"https://api.github.com/users/alon-e/events{/privacy}","received_events_url":"https://api.github.com/users/alon-e/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nDocument hash functions, PoW calc, and signature scheme.\r\n\r\nFixes #1112 \r\n\r\n## Type of change\r\n- Documentation Fix\r\n\r\n# How Has This Been Tested?\r\n\r\ngenerating JavaDocs locally.","created_at":"2018-11-11T15:40:56Z","updated_at":"2018-11-11T16:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b11c573c538731fcc2787d5db4e9de634a48a824","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jakubcech","id":3016965,"node_id":"MDQ6VXNlcjMwMTY5NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/3016965?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubcech","html_url":"https://github.com/jakubcech","followers_url":"https://api.github.com/users/jakubcech/followers","following_url":"https://api.github.com/users/jakubcech/following{/other_user}","gists_url":"https://api.github.com/users/jakubcech/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubcech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubcech/subscriptions","organizations_url":"https://api.github.com/users/jakubcech/orgs","repos_url":"https://api.github.com/users/jakubcech/repos","events_url":"https://api.github.com/users/jakubcech/events{/privacy}","received_events_url":"https://api.github.com/users/jakubcech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":977932773,"node_id":"MDU6TGFiZWw5Nzc5MzI3NzM=","url":"https://api.github.com/repos/iotaledger/iri/labels/C-Cryptography","name":"C-Cryptography","color":"f296aa","default":false},{"id":910897166,"node_id":"MDU6TGFiZWw5MTA4OTcxNjY=","url":"https://api.github.com/repos/iotaledger/iri/labels/E-Documentation","name":"E-Documentation","color":"34799e","default":false},{"id":910851252,"node_id":"MDU6TGFiZWw5MTA4NTEyNTI=","url":"https://api.github.com/repos/iotaledger/iri/labels/E-Refactor","name":"E-Refactor","color":"f9f25c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/iri/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/iotaledger/iri/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/iotaledger/iri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/iri/issues/1139/comments","statuses_url":"https://api.github.com/repos/iotaledger/iri/statuses/21c93dcd9d34148ec77cea43b2495a51b4585c37","head":{"label":"alon-e:docs/crypto","ref":"docs/crypto","sha":"21c93dcd9d34148ec77cea43b2495a51b4585c37","user":{"login":"alon-e","id":25587995,"node_id":"MDQ6VXNlcjI1NTg3OTk1","avatar_url":"https://avatars3.githubusercontent.com/u/25587995?v=4","gravatar_id":"","url":"https://api.github.com/users/alon-e","html_url":"https://github.com/alon-e","followers_url":"https://api.github.com/users/alon-e/followers","following_url":"https://api.github.com/users/alon-e/following{/other_user}","gists_url":"https://api.github.com/users/alon-e/gists{/gist_id}","starred_url":"https://api.github.com/users/alon-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alon-e/subscriptions","organizations_url":"https://api.github.com/users/alon-e/orgs","repos_url":"https://api.github.com/users/alon-e/repos","events_url":"https://api.github.com/users/alon-e/events{/privacy}","received_events_url":"https://api.github.com/users/alon-e/received_events","type":"User","site_admin":false},"repo":{"id":96702129,"node_id":"MDEwOlJlcG9zaXRvcnk5NjcwMjEyOQ==","name":"iri","full_name":"alon-e/iri","private":false,"owner":{"login":"alon-e","id":25587995,"node_id":"MDQ6VXNlcjI1NTg3OTk1","avatar_url":"https://avatars3.githubusercontent.com/u/25587995?v=4","gravatar_id":"","url":"https://api.github.com/users/alon-e","html_url":"https://github.com/alon-e","followers_url":"https://api.github.com/users/alon-e/followers","following_url":"https://api.github.com/users/alon-e/following{/other_user}","gists_url":"https://api.github.com/users/alon-e/gists{/gist_id}","starred_url":"https://api.github.com/users/alon-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alon-e/subscriptions","organizations_url":"https://api.github.com/users/alon-e/orgs","repos_url":"https://api.github.com/users/alon-e/repos","events_url":"https://api.github.com/users/alon-e/events{/privacy}","received_events_url":"https://api.github.com/users/alon-e/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alon-e/iri","description":"IOTA Reference Implementation","fork":true,"url":"https://api.github.com/repos/alon-e/iri","forks_url":"https://api.github.com/repos/alon-e/iri/forks","keys_url":"https://api.github.com/repos/alon-e/iri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alon-e/iri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alon-e/iri/teams","hooks_url":"https://api.github.com/repos/alon-e/iri/hooks","issue_events_url":"https://api.github.com/repos/alon-e/iri/issues/events{/number}","events_url":"https://api.github.com/repos/alon-e/iri/events","assignees_url":"https://api.github.com/repos/alon-e/iri/assignees{/user}","branches_url":"https://api.github.com/repos/alon-e/iri/branches{/branch}","tags_url":"https://api.github.com/repos/alon-e/iri/tags","blobs_url":"https://api.github.com/repos/alon-e/iri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alon-e/iri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alon-e/iri/git/refs{/sha}","trees_url":"https://api.github.com/repos/alon-e/iri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alon-e/iri/statuses/{sha}","languages_url":"https://api.github.com/repos/alon-e/iri/languages","stargazers_url":"https://api.github.com/repos/alon-e/iri/stargazers","contributors_url":"https://api.github.com/repos/alon-e/iri/contributors","subscribers_url":"https://api.github.com/repos/alon-e/iri/subscribers","subscription_url":"https://api.github.com/repos/alon-e/iri/subscription","commits_url":"https://api.github.com/repos/alon-e/iri/commits{/sha}","git_commits_url":"https://api.github.com/repos/alon-e/iri/git/commits{/sha}","comments_url":"https://api.github.com/repos/alon-e/iri/comments{/number}","issue_comment_url":"https://api.github.com/repos/alon-e/iri/issues/comments{/number}","contents_url":"https://api.github.com/repos/alon-e/iri/contents/{+path}","compare_url":"https://api.github.com/repos/alon-e/iri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alon-e/iri/merges","archive_url":"https://api.github.com/repos/alon-e/iri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alon-e/iri/downloads","issues_url":"https://api.github.com/repos/alon-e/iri/issues{/number}","pulls_url":"https://api.github.com/repos/alon-e/iri/pulls{/number}","milestones_url":"https://api.github.com/repos/alon-e/iri/milestones{/number}","notifications_url":"https://api.github.com/repos/alon-e/iri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alon-e/iri/labels{/name}","releases_url":"https://api.github.com/repos/alon-e/iri/releases{/id}","deployments_url":"https://api.github.com/repos/alon-e/iri/deployments","created_at":"2017-07-09T18:08:14Z","updated_at":"2018-10-21T10:31:22Z","pushed_at":"2018-11-11T15:38:18Z","git_url":"git://github.com/alon-e/iri.git","ssh_url":"git@github.com:alon-e/iri.git","clone_url":"https://github.com/alon-e/iri.git","svn_url":"https://github.com/alon-e/iri","homepage":null,"size":177455,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":4,"watchers":1,"default_branch":"dev"}},"base":{"label":"iotaledger:dev","ref":"dev","sha":"b5c60d285d284222ae6819580d7b80688e0a30ff","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":71836159,"node_id":"MDEwOlJlcG9zaXRvcnk3MTgzNjE1OQ==","name":"iri","full_name":"iotaledger/iri","private":false,"owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotaledger/iri","description":"IOTA Reference Implementation","fork":false,"url":"https://api.github.com/repos/iotaledger/iri","forks_url":"https://api.github.com/repos/iotaledger/iri/forks","keys_url":"https://api.github.com/repos/iotaledger/iri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/iri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/iri/teams","hooks_url":"https://api.github.com/repos/iotaledger/iri/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/iri/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/iri/events","assignees_url":"https://api.github.com/repos/iotaledger/iri/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/iri/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/iri/tags","blobs_url":"https://api.github.com/repos/iotaledger/iri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/iri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/iri/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/iri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/iri/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/iri/languages","stargazers_url":"https://api.github.com/repos/iotaledger/iri/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/iri/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/iri/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/iri/subscription","commits_url":"https://api.github.com/repos/iotaledger/iri/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/iri/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/iri/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/iri/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/iri/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/iri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/iri/merges","archive_url":"https://api.github.com/repos/iotaledger/iri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/iri/downloads","issues_url":"https://api.github.com/repos/iotaledger/iri/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/iri/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/iri/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/iri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/iri/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/iri/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/iri/deployments","created_at":"2016-10-24T22:06:06Z","updated_at":"2018-11-11T15:17:07Z","pushed_at":"2018-11-11T15:48:15Z","git_url":"git://github.com/iotaledger/iri.git","ssh_url":"git@github.com:iotaledger/iri.git","clone_url":"https://github.com/iotaledger/iri.git","svn_url":"https://github.com/iotaledger/iri","homepage":null,"size":177018,"stargazers_count":1064,"watchers_count":1064,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":373,"mirror_url":null,"archived":false,"open_issues_count":279,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":373,"open_issues":279,"watchers":1064,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1139"},"html":{"href":"https://github.com/iotaledger/iri/pull/1139"},"issue":{"href":"https://api.github.com/repos/iotaledger/iri/issues/1139"},"comments":{"href":"https://api.github.com/repos/iotaledger/iri/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/iri/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/iri/statuses/21c93dcd9d34148ec77cea43b2495a51b4585c37"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"GalRogozinski"}}