{"action":"created","issue":{"url":"https://api.github.com/repos/Ultimaker/CuraEngine/issues/843","repository_url":"https://api.github.com/repos/Ultimaker/CuraEngine","labels_url":"https://api.github.com/repos/Ultimaker/CuraEngine/issues/843/labels{/name}","comments_url":"https://api.github.com/repos/Ultimaker/CuraEngine/issues/843/comments","events_url":"https://api.github.com/repos/Ultimaker/CuraEngine/issues/843/events","html_url":"https://github.com/Ultimaker/CuraEngine/pull/843","id":358384129,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTQ4Njg0","number":843,"title":"Fix polygon connector","user":{"login":"BagelOrb","id":8895761,"node_id":"MDQ6VXNlcjg4OTU3NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/8895761?v=4","gravatar_id":"","url":"https://api.github.com/users/BagelOrb","html_url":"https://github.com/BagelOrb","followers_url":"https://api.github.com/users/BagelOrb/followers","following_url":"https://api.github.com/users/BagelOrb/following{/other_user}","gists_url":"https://api.github.com/users/BagelOrb/gists{/gist_id}","starred_url":"https://api.github.com/users/BagelOrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BagelOrb/subscriptions","organizations_url":"https://api.github.com/users/BagelOrb/orgs","repos_url":"https://api.github.com/users/BagelOrb/repos","events_url":"https://api.github.com/users/BagelOrb/events{/privacy}","received_events_url":"https://api.github.com/users/BagelOrb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-09T14:46:58Z","updated_at":"2018-09-27T16:37:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Ultimaker/CuraEngine/pulls/843","html_url":"https://github.com/Ultimaker/CuraEngine/pull/843","diff_url":"https://github.com/Ultimaker/CuraEngine/pull/843.diff","patch_url":"https://github.com/Ultimaker/CuraEngine/pull/843.patch"},"body":"I've fixed some problems with the PolygonConnector and improved performance.\r\n\r\nThe performance improvement should mostly come from the fact that we now use a sparse grid to efficiently lookup where polygons are close enough to each other to be connected.\r\n\r\nI haven't done any performance tests to see whether performance is actually increased, but the tests below certainly show that some bugs are fixed and that the code is improved a lot!\r\n\r\nBefore:\r\n(line dist 0.76)\r\nrandom connection: (happened on roughly 2% of the layers)\r\n![image](https://user-images.githubusercontent.com/8895761/45265664-ebb8b680-b44e-11e8-8618-f6f451d4abb3.png)\r\n\r\n![image](https://user-images.githubusercontent.com/8895761/45265671-fe32f000-b44e-11e8-8a05-06da2cdd6142.png)\r\n\r\nno connection: (happened on roughly 50% of the layers, now on roughly 5%)\r\n![image](https://user-images.githubusercontent.com/8895761/45265678-186cce00-b44f-11e8-9e44-1dd5aad4b2ed.png)\r\n\r\n\r\nAfter:\r\n![image](https://user-images.githubusercontent.com/8895761/45265713-df812900-b44f-11e8-8ddb-c6a8f47a06e1.png)\r\n\r\n![image](https://user-images.githubusercontent.com/8895761/45265709-d1330d00-b44f-11e8-89e8-54c4f808a665.png)\r\n\r\n![image](https://user-images.githubusercontent.com/8895761/45265704-b6609880-b44f-11e8-83ac-ea203351d16f.png)\r\n\r\nProject:\r\n[lil_L_x2__cross_3d.curaproject.3mf.remove_extension.zip](https://github.com/Ultimaker/CuraEngine/files/2364347/lil_L_x2__cross_3d.curaproject.3mf.remove_extension.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/Ultimaker/CuraEngine/issues/comments/425160437","html_url":"https://github.com/Ultimaker/CuraEngine/pull/843#issuecomment-425160437","issue_url":"https://api.github.com/repos/Ultimaker/CuraEngine/issues/843","id":425160437,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE2MDQzNw==","user":{"login":"BagelOrb","id":8895761,"node_id":"MDQ6VXNlcjg4OTU3NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/8895761?v=4","gravatar_id":"","url":"https://api.github.com/users/BagelOrb","html_url":"https://github.com/BagelOrb","followers_url":"https://api.github.com/users/BagelOrb/followers","following_url":"https://api.github.com/users/BagelOrb/following{/other_user}","gists_url":"https://api.github.com/users/BagelOrb/gists{/gist_id}","starred_url":"https://api.github.com/users/BagelOrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BagelOrb/subscriptions","organizations_url":"https://api.github.com/users/BagelOrb/orgs","repos_url":"https://api.github.com/users/BagelOrb/repos","events_url":"https://api.github.com/users/BagelOrb/events{/privacy}","received_events_url":"https://api.github.com/users/BagelOrb/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T16:37:47Z","updated_at":"2018-09-27T16:37:47Z","author_association":"MEMBER","body":"That's unrelated to me PR\n\nOn Thu, 27 Sep 2018, 17:31 alekseisasin, <notifications@github.com> wrote:\n\n> [ 81%] Building CXX object\n> CMakeFiles/ArcusCommunicationTest.dir/tests/arcus/MockSocket.cpp.obj\n>\n> In file included from\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.cpp:4:0:\n>\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.h:23:10:\n> error: 'void cura::MockSocket::connect(const string&, int)' marked\n> 'override', but does not override\n>\n>  void connect(const std::string& address, int port) override;\n>\n>       ^\n>\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.h:24:10:\n> error: 'void cura::MockSocket::listen(const string&, int)' marked\n> 'override', but does not override\n>\n>  void listen(const std::string& address, int port) override;\n>\n>       ^\n>\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.h:25:10:\n> error: 'void cura::MockSocket::close()' marked 'override', but does not\n> override\n>\n>  void close() override;\n>\n>       ^\n>\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.h:26:10:\n> error: 'void cura::MockSocket::reset()' marked 'override', but does not\n> override\n>\n>  void reset() override;\n>\n>       ^\n>\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.h:29:10:\n> error: 'void cura::MockSocket::sendMessage(Arcus::MessagePtr)' marked\n> 'override', but does not override\n>\n>  void sendMessage(Arcus::MessagePtr message) override;\n>\n>       ^\n>\n> C:....\\ngine_fix_polygon_connector-3V6HUP43CQSHTUOXHZEOXJ7DNWOI4QXO74SGWJXTH7SMVB3F7WOA\\tests\\arcus\\MockSocket.h:30:23:\n> error: 'Arcus::MessagePtr cura::MockSocket::takeNextMessage()' marked\n> 'override', but does not override\n>\n>  Arcus::MessagePtr takeNextMessage() override;\n>\n>                    ^\n>\n> CMakeFiles\\ArcusCommunicationTest.dir\\build.make:87: recipe for target\n> 'CMakeFiles/ArcusCommunicationTest.dir/tests/arcus/MockSocket.cpp.obj'\n> failed\n>\n> mingw32-make[2]: ***\n> [CMakeFiles/ArcusCommunicationTest.dir/tests/arcus/MockSocket.cpp.obj]\n> Error 1\n>\n> CMakeFiles\\Makefile2:331: recipe for target\n> 'CMakeFiles/ArcusCommunicationTest.dir/all' failed\n>\n> mingw32-make[1]: *** [CMakeFiles/ArcusCommunicationTest.dir/all] Error 2\n>\n> Makefile:161: recipe for target 'all' failed\n>\n> mingw32-make: *** [all] Error 2\n>\n> script returned exit code 2\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Ultimaker/CuraEngine/pull/843#issuecomment-425137701>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AIe9EZ75i-ewIvypHT8BAkdn978EH8D3ks5ufO9SgaJpZM4WgT-L>\n> .\n>\n"}}
{"actor":{"display_login":"BagelOrb"}}