{"action":"created","comment":{"url":"https://api.github.com/repos/kowala-tech/kcoin/pulls/comments/203052927","pull_request_review_id":137866716,"id":203052927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzA1MjkyNw==","diff_hunk":"@@ -92,6 +92,38 @@ client/contracts/truffle/node_modules:\n client/build/bin/abigen:\n \tcd client; build/env.sh go run build/ci.go install ./cmd/abigen\n \n+go-generate: moq go-bindata stringer gencodec mockery ensure-notifications ensure-wallet-backend\n+\tgo get -u github.com/golang/protobuf/protoc-gen-go\n+\tgo generate ./client/cmd/control/\n+\tgo generate ./client/cmd/faucet/\n+\tgo generate ./client/core/\n+\tgo generate ./client/core/types/\n+\tgo generate ./client/core/vm/\n+\tgo generate ./client/internal/jsre/deps/\n+\tgo generate ./client/knode/\n+\tgo generate ./client/knode/tracers/internal/tracers/\n+\tgo generate ./client/p2p/discv5/\n+\tgo generate ./notifications/blockchain/\n+\tgo generate ./notifications/environment/\n+\tgo generate ./notifications/keyvalue/\n+\tgo generate ./notifications/notifier/\n+\tgo generate ./notifications/protocolbuffer/\n+\tgo generate ./wallet-backend/protocolbuffer/","path":"Makefile","position":19,"original_position":20,"commit_id":"0e0a72ef75995289f8cfa4d7ba117674ee3c9a56","original_commit_id":"34b49e7b21682f9211e61177b2f0d04e5d7e9b26","user":{"login":"jgimeno","id":4056757,"node_id":"MDQ6VXNlcjQwNTY3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4056757?v=4","gravatar_id":"","url":"https://api.github.com/users/jgimeno","html_url":"https://github.com/jgimeno","followers_url":"https://api.github.com/users/jgimeno/followers","following_url":"https://api.github.com/users/jgimeno/following{/other_user}","gists_url":"https://api.github.com/users/jgimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/jgimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgimeno/subscriptions","organizations_url":"https://api.github.com/users/jgimeno/orgs","repos_url":"https://api.github.com/users/jgimeno/repos","events_url":"https://api.github.com/users/jgimeno/events{/privacy}","received_events_url":"https://api.github.com/users/jgimeno/received_events","type":"User","site_admin":false},"body":"go generate fails if bindings dont happen before the other, at least this was what I was getting on the beginning.","created_at":"2018-07-17T14:48:51Z","updated_at":"2018-07-17T14:48:52Z","html_url":"https://github.com/kowala-tech/kcoin/pull/559#discussion_r203052927","pull_request_url":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kowala-tech/kcoin/pulls/comments/203052927"},"html":{"href":"https://github.com/kowala-tech/kcoin/pull/559#discussion_r203052927"},"pull_request":{"href":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559"}},"in_reply_to_id":202958077},"pull_request":{"url":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559","id":201878358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODc4MzU4","html_url":"https://github.com/kowala-tech/kcoin/pull/559","diff_url":"https://github.com/kowala-tech/kcoin/pull/559.diff","patch_url":"https://github.com/kowala-tech/kcoin/pull/559.patch","issue_url":"https://api.github.com/repos/kowala-tech/kcoin/issues/559","number":559,"state":"open","locked":false,"title":"Feature/issue 467 go generate on build","user":{"login":"jgimeno","id":4056757,"node_id":"MDQ6VXNlcjQwNTY3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4056757?v=4","gravatar_id":"","url":"https://api.github.com/users/jgimeno","html_url":"https://github.com/jgimeno","followers_url":"https://api.github.com/users/jgimeno/followers","following_url":"https://api.github.com/users/jgimeno/following{/other_user}","gists_url":"https://api.github.com/users/jgimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/jgimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgimeno/subscriptions","organizations_url":"https://api.github.com/users/jgimeno/orgs","repos_url":"https://api.github.com/users/jgimeno/repos","events_url":"https://api.github.com/users/jgimeno/events{/privacy}","received_events_url":"https://api.github.com/users/jgimeno/received_events","type":"User","site_admin":false},"body":"Now the build checks that the go generated files are up to date, if not it fails.\r\n\r\nCloses #\r\n\r\nhttps://github.com/kowala-tech/kcoin/issues/467\r\n","created_at":"2018-07-17T09:29:55Z","updated_at":"2018-07-17T14:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e43ebca049bb8f5a7790e66edbe3f2d5d2b7701","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rgeraldes","id":26251983,"node_id":"MDQ6VXNlcjI2MjUxOTgz","avatar_url":"https://avatars2.githubusercontent.com/u/26251983?v=4","gravatar_id":"","url":"https://api.github.com/users/rgeraldes","html_url":"https://github.com/rgeraldes","followers_url":"https://api.github.com/users/rgeraldes/followers","following_url":"https://api.github.com/users/rgeraldes/following{/other_user}","gists_url":"https://api.github.com/users/rgeraldes/gists{/gist_id}","starred_url":"https://api.github.com/users/rgeraldes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgeraldes/subscriptions","organizations_url":"https://api.github.com/users/rgeraldes/orgs","repos_url":"https://api.github.com/users/rgeraldes/repos","events_url":"https://api.github.com/users/rgeraldes/events{/privacy}","received_events_url":"https://api.github.com/users/rgeraldes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559/commits","review_comments_url":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559/comments","review_comment_url":"https://api.github.com/repos/kowala-tech/kcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kowala-tech/kcoin/issues/559/comments","statuses_url":"https://api.github.com/repos/kowala-tech/kcoin/statuses/0e0a72ef75995289f8cfa4d7ba117674ee3c9a56","head":{"label":"kowala-tech:feature/issue-467-go-generate-on-build","ref":"feature/issue-467-go-generate-on-build","sha":"0e0a72ef75995289f8cfa4d7ba117674ee3c9a56","user":{"login":"kowala-tech","id":29745494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQ1NDk0","avatar_url":"https://avatars0.githubusercontent.com/u/29745494?v=4","gravatar_id":"","url":"https://api.github.com/users/kowala-tech","html_url":"https://github.com/kowala-tech","followers_url":"https://api.github.com/users/kowala-tech/followers","following_url":"https://api.github.com/users/kowala-tech/following{/other_user}","gists_url":"https://api.github.com/users/kowala-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/kowala-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowala-tech/subscriptions","organizations_url":"https://api.github.com/users/kowala-tech/orgs","repos_url":"https://api.github.com/users/kowala-tech/repos","events_url":"https://api.github.com/users/kowala-tech/events{/privacy}","received_events_url":"https://api.github.com/users/kowala-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":98875571,"node_id":"MDEwOlJlcG9zaXRvcnk5ODg3NTU3MQ==","name":"kcoin","full_name":"kowala-tech/kcoin","owner":{"login":"kowala-tech","id":29745494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQ1NDk0","avatar_url":"https://avatars0.githubusercontent.com/u/29745494?v=4","gravatar_id":"","url":"https://api.github.com/users/kowala-tech","html_url":"https://github.com/kowala-tech","followers_url":"https://api.github.com/users/kowala-tech/followers","following_url":"https://api.github.com/users/kowala-tech/following{/other_user}","gists_url":"https://api.github.com/users/kowala-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/kowala-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowala-tech/subscriptions","organizations_url":"https://api.github.com/users/kowala-tech/orgs","repos_url":"https://api.github.com/users/kowala-tech/repos","events_url":"https://api.github.com/users/kowala-tech/events{/privacy}","received_events_url":"https://api.github.com/users/kowala-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kowala-tech/kcoin","description":"A stable cryptocurrency that algorithmically targets $1 USD using the Kowala Protocol","fork":false,"url":"https://api.github.com/repos/kowala-tech/kcoin","forks_url":"https://api.github.com/repos/kowala-tech/kcoin/forks","keys_url":"https://api.github.com/repos/kowala-tech/kcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kowala-tech/kcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kowala-tech/kcoin/teams","hooks_url":"https://api.github.com/repos/kowala-tech/kcoin/hooks","issue_events_url":"https://api.github.com/repos/kowala-tech/kcoin/issues/events{/number}","events_url":"https://api.github.com/repos/kowala-tech/kcoin/events","assignees_url":"https://api.github.com/repos/kowala-tech/kcoin/assignees{/user}","branches_url":"https://api.github.com/repos/kowala-tech/kcoin/branches{/branch}","tags_url":"https://api.github.com/repos/kowala-tech/kcoin/tags","blobs_url":"https://api.github.com/repos/kowala-tech/kcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kowala-tech/kcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kowala-tech/kcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kowala-tech/kcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kowala-tech/kcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/kowala-tech/kcoin/languages","stargazers_url":"https://api.github.com/repos/kowala-tech/kcoin/stargazers","contributors_url":"https://api.github.com/repos/kowala-tech/kcoin/contributors","subscribers_url":"https://api.github.com/repos/kowala-tech/kcoin/subscribers","subscription_url":"https://api.github.com/repos/kowala-tech/kcoin/subscription","commits_url":"https://api.github.com/repos/kowala-tech/kcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kowala-tech/kcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kowala-tech/kcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kowala-tech/kcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kowala-tech/kcoin/contents/{+path}","compare_url":"https://api.github.com/repos/kowala-tech/kcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kowala-tech/kcoin/merges","archive_url":"https://api.github.com/repos/kowala-tech/kcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kowala-tech/kcoin/downloads","issues_url":"https://api.github.com/repos/kowala-tech/kcoin/issues{/number}","pulls_url":"https://api.github.com/repos/kowala-tech/kcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/kowala-tech/kcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/kowala-tech/kcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kowala-tech/kcoin/labels{/name}","releases_url":"https://api.github.com/repos/kowala-tech/kcoin/releases{/id}","deployments_url":"https://api.github.com/repos/kowala-tech/kcoin/deployments","created_at":"2017-07-31T10:09:03Z","updated_at":"2018-07-17T12:04:24Z","pushed_at":"2018-07-17T14:35:55Z","git_url":"git://github.com/kowala-tech/kcoin.git","ssh_url":"git@github.com:kowala-tech/kcoin.git","clone_url":"https://github.com/kowala-tech/kcoin.git","svn_url":"https://github.com/kowala-tech/kcoin","homepage":"https://www.kowala.tech/","size":79406,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":139,"license":null,"forks":0,"open_issues":139,"watchers":10,"default_branch":"dev"}},"base":{"label":"kowala-tech:dev","ref":"dev","sha":"e84798c40fe0fdcefed9107846168ee64f05eb4a","user":{"login":"kowala-tech","id":29745494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQ1NDk0","avatar_url":"https://avatars0.githubusercontent.com/u/29745494?v=4","gravatar_id":"","url":"https://api.github.com/users/kowala-tech","html_url":"https://github.com/kowala-tech","followers_url":"https://api.github.com/users/kowala-tech/followers","following_url":"https://api.github.com/users/kowala-tech/following{/other_user}","gists_url":"https://api.github.com/users/kowala-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/kowala-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowala-tech/subscriptions","organizations_url":"https://api.github.com/users/kowala-tech/orgs","repos_url":"https://api.github.com/users/kowala-tech/repos","events_url":"https://api.github.com/users/kowala-tech/events{/privacy}","received_events_url":"https://api.github.com/users/kowala-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":98875571,"node_id":"MDEwOlJlcG9zaXRvcnk5ODg3NTU3MQ==","name":"kcoin","full_name":"kowala-tech/kcoin","owner":{"login":"kowala-tech","id":29745494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQ1NDk0","avatar_url":"https://avatars0.githubusercontent.com/u/29745494?v=4","gravatar_id":"","url":"https://api.github.com/users/kowala-tech","html_url":"https://github.com/kowala-tech","followers_url":"https://api.github.com/users/kowala-tech/followers","following_url":"https://api.github.com/users/kowala-tech/following{/other_user}","gists_url":"https://api.github.com/users/kowala-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/kowala-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kowala-tech/subscriptions","organizations_url":"https://api.github.com/users/kowala-tech/orgs","repos_url":"https://api.github.com/users/kowala-tech/repos","events_url":"https://api.github.com/users/kowala-tech/events{/privacy}","received_events_url":"https://api.github.com/users/kowala-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kowala-tech/kcoin","description":"A stable cryptocurrency that algorithmically targets $1 USD using the Kowala Protocol","fork":false,"url":"https://api.github.com/repos/kowala-tech/kcoin","forks_url":"https://api.github.com/repos/kowala-tech/kcoin/forks","keys_url":"https://api.github.com/repos/kowala-tech/kcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kowala-tech/kcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kowala-tech/kcoin/teams","hooks_url":"https://api.github.com/repos/kowala-tech/kcoin/hooks","issue_events_url":"https://api.github.com/repos/kowala-tech/kcoin/issues/events{/number}","events_url":"https://api.github.com/repos/kowala-tech/kcoin/events","assignees_url":"https://api.github.com/repos/kowala-tech/kcoin/assignees{/user}","branches_url":"https://api.github.com/repos/kowala-tech/kcoin/branches{/branch}","tags_url":"https://api.github.com/repos/kowala-tech/kcoin/tags","blobs_url":"https://api.github.com/repos/kowala-tech/kcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kowala-tech/kcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kowala-tech/kcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kowala-tech/kcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kowala-tech/kcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/kowala-tech/kcoin/languages","stargazers_url":"https://api.github.com/repos/kowala-tech/kcoin/stargazers","contributors_url":"https://api.github.com/repos/kowala-tech/kcoin/contributors","subscribers_url":"https://api.github.com/repos/kowala-tech/kcoin/subscribers","subscription_url":"https://api.github.com/repos/kowala-tech/kcoin/subscription","commits_url":"https://api.github.com/repos/kowala-tech/kcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kowala-tech/kcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kowala-tech/kcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kowala-tech/kcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kowala-tech/kcoin/contents/{+path}","compare_url":"https://api.github.com/repos/kowala-tech/kcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kowala-tech/kcoin/merges","archive_url":"https://api.github.com/repos/kowala-tech/kcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kowala-tech/kcoin/downloads","issues_url":"https://api.github.com/repos/kowala-tech/kcoin/issues{/number}","pulls_url":"https://api.github.com/repos/kowala-tech/kcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/kowala-tech/kcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/kowala-tech/kcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kowala-tech/kcoin/labels{/name}","releases_url":"https://api.github.com/repos/kowala-tech/kcoin/releases{/id}","deployments_url":"https://api.github.com/repos/kowala-tech/kcoin/deployments","created_at":"2017-07-31T10:09:03Z","updated_at":"2018-07-17T12:04:24Z","pushed_at":"2018-07-17T14:35:55Z","git_url":"git://github.com/kowala-tech/kcoin.git","ssh_url":"git@github.com:kowala-tech/kcoin.git","clone_url":"https://github.com/kowala-tech/kcoin.git","svn_url":"https://github.com/kowala-tech/kcoin","homepage":"https://www.kowala.tech/","size":79406,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":139,"license":null,"forks":0,"open_issues":139,"watchers":10,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559"},"html":{"href":"https://github.com/kowala-tech/kcoin/pull/559"},"issue":{"href":"https://api.github.com/repos/kowala-tech/kcoin/issues/559"},"comments":{"href":"https://api.github.com/repos/kowala-tech/kcoin/issues/559/comments"},"review_comments":{"href":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559/comments"},"review_comment":{"href":"https://api.github.com/repos/kowala-tech/kcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kowala-tech/kcoin/pulls/559/commits"},"statuses":{"href":"https://api.github.com/repos/kowala-tech/kcoin/statuses/0e0a72ef75995289f8cfa4d7ba117674ee3c9a56"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jgimeno"}}