{"action":"created","comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/182829833","pull_request_review_id":113709315,"id":182829833,"diff_hunk":"@@ -191,139 +220,280 @@ typedef void (*tend_example)(vw& all, void* d, example& ec);\n   { end_pass_fd.func(end_pass_fd.data);\n     if (end_pass_fd.base) end_pass_fd.base->end_pass();\n   }//autorecursive\n-  void set_end_pass(void (*f)(T&))\n-  {end_pass_fd = tuple_dbf(learn_fd.data, learn_fd.base, (tfunc)f);}\n+  void set_end_pass(void (*f)(T&)) {end_pass_fd = tuple_dbf(learn_fd.data, learn_fd.base, (func_data::fn)f);}\n \n   //called after parsing of examples is complete.  Autorecursive.\n   void end_examples()\n   { end_examples_fd.func(end_examples_fd.data);\n     if (end_examples_fd.base) end_examples_fd.base->end_examples();\n   }\n-  void set_end_examples(void (*f)(T&))\n-  {end_examples_fd = tuple_dbf(learn_fd.data,learn_fd.base, (tfunc)f);}\n+  void set_end_examples(void (*f)(T&)) {end_examples_fd = tuple_dbf(learn_fd.data,learn_fd.base, (func_data::fn)f);}\n \n   //Called at the beginning by the driver.  Explicitly not recursive.\n   void init_driver() { init_fd.func(init_fd.data);}\n   void set_init_driver(void (*f)(T&))\n-  { init_fd = tuple_dbf(learn_fd.data,learn_fd.base, (tfunc)f); }\n+  { init_fd = tuple_dbf(learn_fd.data,learn_fd.base, (func_data::fn)f); }\n \n   //called after learn example for each example.  Explicitly not recursive.\n-  inline void finish_example(vw& all, example& ec)\n-  { finish_example_fd.finish_example_f(all, finish_example_fd.data, ec);}\n-  void set_finish_example(void (*f)(vw& all, T&, example&))\n+  inline void finish_example(vw& all, E& ec)\n+  { finish_example_fd.finish_example_f(all, finish_example_fd.data, (void*)&ec);}\n+  //called after learn example for each example.  Explicitly not recursive.\n+  void set_finish_example(void (*f)(vw& all, T&, E&))\n   { finish_example_fd.data = learn_fd.data;\n-    finish_example_fd.finish_example_f = (tend_example)f;\n+    finish_example_fd.finish_example_f = (end_fptr_type)(f);\n+  }\n+  \n+  //called to check if an example is a test example.  Used in creating multiline example\n+  inline bool is_test_example(example& ec)","path":"vowpalwabbit/learner.h","position":304,"original_position":291,"commit_id":"6d4bb6465d236a00787a1a22baef05d9004f9d23","original_commit_id":"9f3df8f03b02c96734441cc080a3d1abe6156f03","user":{"login":"rajan-chari","id":21222554,"avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"body":"Defered to John's upcoming change.","created_at":"2018-04-19T17:45:15Z","updated_at":"2018-04-19T17:45:15Z","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1421#discussion_r182829833","pull_request_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/182829833"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/1421#discussion_r182829833"},"pull_request":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421"}},"in_reply_to_id":182466151},"pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421","id":173186217,"html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1421","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1421.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1421.patch","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1421","number":1421,"state":"open","locked":false,"title":"Multiline example","user":{"login":"rajan-chari","id":21222554,"avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"body":"Preliminary pull request.\r\n\r\nStill need to fix:\r\n\r\na) Python binding tests\r\nb) Cleanup\r\n      1) formatting/stlyle cleanup\r\n      2) check for any missed base.predict() base.learn() calls\r\n","created_at":"2018-03-06T15:10:08Z","updated_at":"2018-04-19T17:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d86bf7ca08076f6827893dc9b8bd1d07bf9ea2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421/commits","review_comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421/comments","review_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1421/comments","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/6d4bb6465d236a00787a1a22baef05d9004f9d23","head":{"label":"rajan-chari:multiline-example","ref":"multiline-example","sha":"6d4bb6465d236a00787a1a22baef05d9004f9d23","user":{"login":"rajan-chari","id":21222554,"avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"repo":{"id":117544274,"name":"vowpal_wabbit","full_name":"rajan-chari/vowpal_wabbit","owner":{"login":"rajan-chari","id":21222554,"avatar_url":"https://avatars1.githubusercontent.com/u/21222554?v=4","gravatar_id":"","url":"https://api.github.com/users/rajan-chari","html_url":"https://github.com/rajan-chari","followers_url":"https://api.github.com/users/rajan-chari/followers","following_url":"https://api.github.com/users/rajan-chari/following{/other_user}","gists_url":"https://api.github.com/users/rajan-chari/gists{/gist_id}","starred_url":"https://api.github.com/users/rajan-chari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajan-chari/subscriptions","organizations_url":"https://api.github.com/users/rajan-chari/orgs","repos_url":"https://api.github.com/users/rajan-chari/repos","events_url":"https://api.github.com/users/rajan-chari/events{/privacy}","received_events_url":"https://api.github.com/users/rajan-chari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajan-chari/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":true,"url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit","forks_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/rajan-chari/vowpal_wabbit/deployments","created_at":"2018-01-15T12:45:02Z","updated_at":"2018-04-10T00:24:21Z","pushed_at":"2018-04-19T17:31:01Z","git_url":"git://github.com/rajan-chari/vowpal_wabbit.git","ssh_url":"git@github.com:rajan-chari/vowpal_wabbit.git","clone_url":"https://github.com/rajan-chari/vowpal_wabbit.git","svn_url":"https://github.com/rajan-chari/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":113210,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JohnLangford:master","ref":"master","sha":"0105bbc11baf24db25490b0a9a808b18a8a846e3","user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars3.githubusercontent.com/u/79590?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"repo":{"id":265995,"name":"vowpal_wabbit","full_name":"JohnLangford/vowpal_wabbit","owner":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars3.githubusercontent.com/u/79590?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnLangford/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":false,"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","forks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/releases{/id}","deployments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/deployments","created_at":"2009-07-31T19:36:58Z","updated_at":"2018-04-19T14:01:05Z","pushed_at":"2018-04-19T17:31:05Z","git_url":"git://github.com/JohnLangford/vowpal_wabbit.git","ssh_url":"git@github.com:JohnLangford/vowpal_wabbit.git","clone_url":"https://github.com/JohnLangford/vowpal_wabbit.git","svn_url":"https://github.com/JohnLangford/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":110353,"stargazers_count":5452,"watchers_count":5452,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1373,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1373,"open_issues":23,"watchers":5452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/1421"},"issue":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1421"},"comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1421/comments"},"review_comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421/comments"},"review_comment":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1421/commits"},"statuses":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/6d4bb6465d236a00787a1a22baef05d9004f9d23"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rajan-chari"}}