{"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/24","id":222623373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjIzMzcz","html_url":"https://github.com/aionnetwork/aion_web3/pull/24","diff_url":"https://github.com/aionnetwork/aion_web3/pull/24.diff","patch_url":"https://github.com/aionnetwork/aion_web3/pull/24.patch","issue_url":"https://api.github.com/repos/aionnetwork/aion_web3/issues/24","number":24,"state":"open","locked":false,"title":"Added address as second argument to eth.signTransaction. To fix #22","user":{"login":"satran004","id":35016438,"node_id":"MDQ6VXNlcjM1MDE2NDM4","avatar_url":"https://avatars2.githubusercontent.com/u/35016438?v=4","gravatar_id":"","url":"https://api.github.com/users/satran004","html_url":"https://github.com/satran004","followers_url":"https://api.github.com/users/satran004/followers","following_url":"https://api.github.com/users/satran004/following{/other_user}","gists_url":"https://api.github.com/users/satran004/gists{/gist_id}","starred_url":"https://api.github.com/users/satran004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satran004/subscriptions","organizations_url":"https://api.github.com/users/satran004/orgs","repos_url":"https://api.github.com/users/satran004/repos","events_url":"https://api.github.com/users/satran004/events{/privacy}","received_events_url":"https://api.github.com/users/satran004/received_events","type":"User","site_admin":false},"body":"In web3 1.0, eth.signTransaction method should take two mandatory arguments,  transaction and address. In current implementation it's expecting only \"transaction\" argument. \r\n\r\nThis pull request adds a second argument of address type.\r\n\r\nweb3 1.0 Spec - https://web3js.readthedocs.io/en/1.0/web3-eth.html#signtransaction\r\n\r\nTo fix #22 \r\n","created_at":"2018-10-13T03:02:39Z","updated_at":"2018-10-13T03:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/24/commits","review_comments_url":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/24/comments","review_comment_url":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aionnetwork/aion_web3/issues/24/comments","statuses_url":"https://api.github.com/repos/aionnetwork/aion_web3/statuses/9b9c20741c8b9b0a7839f05cbf555583bd113612","head":{"label":"satran004:eth_signtxn_fix","ref":"eth_signtxn_fix","sha":"9b9c20741c8b9b0a7839f05cbf555583bd113612","user":{"login":"satran004","id":35016438,"node_id":"MDQ6VXNlcjM1MDE2NDM4","avatar_url":"https://avatars2.githubusercontent.com/u/35016438?v=4","gravatar_id":"","url":"https://api.github.com/users/satran004","html_url":"https://github.com/satran004","followers_url":"https://api.github.com/users/satran004/followers","following_url":"https://api.github.com/users/satran004/following{/other_user}","gists_url":"https://api.github.com/users/satran004/gists{/gist_id}","starred_url":"https://api.github.com/users/satran004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satran004/subscriptions","organizations_url":"https://api.github.com/users/satran004/orgs","repos_url":"https://api.github.com/users/satran004/repos","events_url":"https://api.github.com/users/satran004/events{/privacy}","received_events_url":"https://api.github.com/users/satran004/received_events","type":"User","site_admin":false},"repo":{"id":152826631,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MjY2MzE=","name":"aion_web3","full_name":"satran004/aion_web3","private":false,"owner":{"login":"satran004","id":35016438,"node_id":"MDQ6VXNlcjM1MDE2NDM4","avatar_url":"https://avatars2.githubusercontent.com/u/35016438?v=4","gravatar_id":"","url":"https://api.github.com/users/satran004","html_url":"https://github.com/satran004","followers_url":"https://api.github.com/users/satran004/followers","following_url":"https://api.github.com/users/satran004/following{/other_user}","gists_url":"https://api.github.com/users/satran004/gists{/gist_id}","starred_url":"https://api.github.com/users/satran004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satran004/subscriptions","organizations_url":"https://api.github.com/users/satran004/orgs","repos_url":"https://api.github.com/users/satran004/repos","events_url":"https://api.github.com/users/satran004/events{/privacy}","received_events_url":"https://api.github.com/users/satran004/received_events","type":"User","site_admin":false},"html_url":"https://github.com/satran004/aion_web3","description":"aion web3 api.","fork":true,"url":"https://api.github.com/repos/satran004/aion_web3","forks_url":"https://api.github.com/repos/satran004/aion_web3/forks","keys_url":"https://api.github.com/repos/satran004/aion_web3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satran004/aion_web3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satran004/aion_web3/teams","hooks_url":"https://api.github.com/repos/satran004/aion_web3/hooks","issue_events_url":"https://api.github.com/repos/satran004/aion_web3/issues/events{/number}","events_url":"https://api.github.com/repos/satran004/aion_web3/events","assignees_url":"https://api.github.com/repos/satran004/aion_web3/assignees{/user}","branches_url":"https://api.github.com/repos/satran004/aion_web3/branches{/branch}","tags_url":"https://api.github.com/repos/satran004/aion_web3/tags","blobs_url":"https://api.github.com/repos/satran004/aion_web3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satran004/aion_web3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satran004/aion_web3/git/refs{/sha}","trees_url":"https://api.github.com/repos/satran004/aion_web3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satran004/aion_web3/statuses/{sha}","languages_url":"https://api.github.com/repos/satran004/aion_web3/languages","stargazers_url":"https://api.github.com/repos/satran004/aion_web3/stargazers","contributors_url":"https://api.github.com/repos/satran004/aion_web3/contributors","subscribers_url":"https://api.github.com/repos/satran004/aion_web3/subscribers","subscription_url":"https://api.github.com/repos/satran004/aion_web3/subscription","commits_url":"https://api.github.com/repos/satran004/aion_web3/commits{/sha}","git_commits_url":"https://api.github.com/repos/satran004/aion_web3/git/commits{/sha}","comments_url":"https://api.github.com/repos/satran004/aion_web3/comments{/number}","issue_comment_url":"https://api.github.com/repos/satran004/aion_web3/issues/comments{/number}","contents_url":"https://api.github.com/repos/satran004/aion_web3/contents/{+path}","compare_url":"https://api.github.com/repos/satran004/aion_web3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satran004/aion_web3/merges","archive_url":"https://api.github.com/repos/satran004/aion_web3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satran004/aion_web3/downloads","issues_url":"https://api.github.com/repos/satran004/aion_web3/issues{/number}","pulls_url":"https://api.github.com/repos/satran004/aion_web3/pulls{/number}","milestones_url":"https://api.github.com/repos/satran004/aion_web3/milestones{/number}","notifications_url":"https://api.github.com/repos/satran004/aion_web3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satran004/aion_web3/labels{/name}","releases_url":"https://api.github.com/repos/satran004/aion_web3/releases{/id}","deployments_url":"https://api.github.com/repos/satran004/aion_web3/deployments","created_at":"2018-10-13T02:16:04Z","updated_at":"2018-10-13T02:16:07Z","pushed_at":"2018-10-13T02:57:35Z","git_url":"git://github.com/satran004/aion_web3.git","ssh_url":"git@github.com:satran004/aion_web3.git","clone_url":"https://github.com/satran004/aion_web3.git","svn_url":"https://github.com/satran004/aion_web3","homepage":null,"size":2894,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.0"}},"base":{"label":"aionnetwork:v1.0","ref":"v1.0","sha":"9b3439eea5bcadf8cd90dcbe45a1f2efdda020eb","user":{"login":"aionnetwork","id":35697463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1Njk3NDYz","avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":119875386,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4NzUzODY=","name":"aion_web3","full_name":"aionnetwork/aion_web3","private":false,"owner":{"login":"aionnetwork","id":35697463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1Njk3NDYz","avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aionnetwork/aion_web3","description":"aion web3 api.","fork":false,"url":"https://api.github.com/repos/aionnetwork/aion_web3","forks_url":"https://api.github.com/repos/aionnetwork/aion_web3/forks","keys_url":"https://api.github.com/repos/aionnetwork/aion_web3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aionnetwork/aion_web3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aionnetwork/aion_web3/teams","hooks_url":"https://api.github.com/repos/aionnetwork/aion_web3/hooks","issue_events_url":"https://api.github.com/repos/aionnetwork/aion_web3/issues/events{/number}","events_url":"https://api.github.com/repos/aionnetwork/aion_web3/events","assignees_url":"https://api.github.com/repos/aionnetwork/aion_web3/assignees{/user}","branches_url":"https://api.github.com/repos/aionnetwork/aion_web3/branches{/branch}","tags_url":"https://api.github.com/repos/aionnetwork/aion_web3/tags","blobs_url":"https://api.github.com/repos/aionnetwork/aion_web3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aionnetwork/aion_web3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aionnetwork/aion_web3/git/refs{/sha}","trees_url":"https://api.github.com/repos/aionnetwork/aion_web3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aionnetwork/aion_web3/statuses/{sha}","languages_url":"https://api.github.com/repos/aionnetwork/aion_web3/languages","stargazers_url":"https://api.github.com/repos/aionnetwork/aion_web3/stargazers","contributors_url":"https://api.github.com/repos/aionnetwork/aion_web3/contributors","subscribers_url":"https://api.github.com/repos/aionnetwork/aion_web3/subscribers","subscription_url":"https://api.github.com/repos/aionnetwork/aion_web3/subscription","commits_url":"https://api.github.com/repos/aionnetwork/aion_web3/commits{/sha}","git_commits_url":"https://api.github.com/repos/aionnetwork/aion_web3/git/commits{/sha}","comments_url":"https://api.github.com/repos/aionnetwork/aion_web3/comments{/number}","issue_comment_url":"https://api.github.com/repos/aionnetwork/aion_web3/issues/comments{/number}","contents_url":"https://api.github.com/repos/aionnetwork/aion_web3/contents/{+path}","compare_url":"https://api.github.com/repos/aionnetwork/aion_web3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aionnetwork/aion_web3/merges","archive_url":"https://api.github.com/repos/aionnetwork/aion_web3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aionnetwork/aion_web3/downloads","issues_url":"https://api.github.com/repos/aionnetwork/aion_web3/issues{/number}","pulls_url":"https://api.github.com/repos/aionnetwork/aion_web3/pulls{/number}","milestones_url":"https://api.github.com/repos/aionnetwork/aion_web3/milestones{/number}","notifications_url":"https://api.github.com/repos/aionnetwork/aion_web3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aionnetwork/aion_web3/labels{/name}","releases_url":"https://api.github.com/repos/aionnetwork/aion_web3/releases{/id}","deployments_url":"https://api.github.com/repos/aionnetwork/aion_web3/deployments","created_at":"2018-02-01T18:22:39Z","updated_at":"2018-10-13T02:19:00Z","pushed_at":"2018-10-04T19:26:43Z","git_url":"git://github.com/aionnetwork/aion_web3.git","ssh_url":"git@github.com:aionnetwork/aion_web3.git","clone_url":"https://github.com/aionnetwork/aion_web3.git","svn_url":"https://github.com/aionnetwork/aion_web3","homepage":null,"size":2894,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14,"open_issues":13,"watchers":25,"default_branch":"v1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/24"},"html":{"href":"https://github.com/aionnetwork/aion_web3/pull/24"},"issue":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/issues/24"},"comments":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/aionnetwork/aion_web3/statuses/9b9c20741c8b9b0a7839f05cbf555583bd113612"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"satran004"}}