{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/235338312","pull_request_review_id":177178267,"id":235338312,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTMzODMxMg==","diff_hunk":"@@ -43,7 +43,7 @@ type backendModule interface {\n \n \t// setConfigDummy must configure the backend with dummy configuration\n \t// for testing purposes. This is a replacement for setConfig().\n-\tsetConfigDummy()\n+\tsetConfigDummy(tlsSet bool)","path":"pkg/kvstore/backend.go","position":5,"original_position":5,"commit_id":"3fb89173015e786b9fe12832cba7e328931aff1c","original_commit_id":"3fb89173015e786b9fe12832cba7e328931aff1c","user":{"login":"nirmoy","id":3065605,"node_id":"MDQ6VXNlcjMwNjU2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3065605?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmoy","html_url":"https://github.com/nirmoy","followers_url":"https://api.github.com/users/nirmoy/followers","following_url":"https://api.github.com/users/nirmoy/following{/other_user}","gists_url":"https://api.github.com/users/nirmoy/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmoy/subscriptions","organizations_url":"https://api.github.com/users/nirmoy/orgs","repos_url":"https://api.github.com/users/nirmoy/repos","events_url":"https://api.github.com/users/nirmoy/events{/privacy}","received_events_url":"https://api.github.com/users/nirmoy/received_events","type":"User","site_admin":false},"body":"So I dont really have to change anything in etcd or other tests code, I can add just add tlsSet=true in consul ?","created_at":"2018-11-21T10:48:38Z","updated_at":"2018-11-21T10:48:39Z","html_url":"https://github.com/cilium/cilium/pull/6260#discussion_r235338312","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/6260","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/235338312"},"html":{"href":"https://github.com/cilium/cilium/pull/6260#discussion_r235338312"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6260"}},"in_reply_to_id":235293495},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/6260","id":231571655,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTcxNjU1","html_url":"https://github.com/cilium/cilium/pull/6260","diff_url":"https://github.com/cilium/cilium/pull/6260.diff","patch_url":"https://github.com/cilium/cilium/pull/6260.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/6260","number":6260,"state":"open","locked":false,"title":"[RFC] kvstore: Add TLS support for consul","user":{"login":"nirmoy","id":3065605,"node_id":"MDQ6VXNlcjMwNjU2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3065605?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmoy","html_url":"https://github.com/nirmoy","followers_url":"https://api.github.com/users/nirmoy/followers","following_url":"https://api.github.com/users/nirmoy/following{/other_user}","gists_url":"https://api.github.com/users/nirmoy/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmoy/subscriptions","organizations_url":"https://api.github.com/users/nirmoy/orgs","repos_url":"https://api.github.com/users/nirmoy/repos","events_url":"https://api.github.com/users/nirmoy/events{/privacy}","received_events_url":"https://api.github.com/users/nirmoy/received_events","type":"User","site_admin":false},"body":"Fixes:#5138\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/6260)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-11-16T15:44:50Z","updated_at":"2018-11-21T10:48:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13c72d2d534a9c405c95926a55efd39f30ae1c67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"policy","id":2519786,"node_id":"MDQ6VGVhbTI1MTk3ODY=","slug":"policy","description":"Policy engine","privacy":"closed","url":"https://api.github.com/teams/2519786","members_url":"https://api.github.com/teams/2519786/members{/member}","repositories_url":"https://api.github.com/teams/2519786/repos","permission":"pull"}],"labels":[{"id":721344617,"node_id":"MDU6TGFiZWw3MjEzNDQ2MTc=","url":"https://api.github.com/repos/cilium/cilium/labels/kind/feature","name":"kind/feature","color":"eae781","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":732923415,"node_id":"MDU6TGFiZWw3MzI5MjM0MTU=","url":"https://api.github.com/repos/cilium/cilium/labels/release-note/minor","name":"release-note/minor","color":"c2e0c6","default":false}],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/19","html_url":"https://github.com/cilium/cilium/milestone/19","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/19/labels","id":3736768,"node_id":"MDk6TWlsZXN0b25lMzczNjc2OA==","number":19,"title":"1.4-feature","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":72,"state":"open","created_at":"2018-10-14T10:00:27Z","updated_at":"2018-11-21T08:21:07Z","due_on":"2018-11-26T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/6260/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/6260/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/6260/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/3fb89173015e786b9fe12832cba7e328931aff1c","head":{"label":"nirmoy:consul_tls","ref":"consul_tls","sha":"3fb89173015e786b9fe12832cba7e328931aff1c","user":{"login":"nirmoy","id":3065605,"node_id":"MDQ6VXNlcjMwNjU2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3065605?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmoy","html_url":"https://github.com/nirmoy","followers_url":"https://api.github.com/users/nirmoy/followers","following_url":"https://api.github.com/users/nirmoy/following{/other_user}","gists_url":"https://api.github.com/users/nirmoy/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmoy/subscriptions","organizations_url":"https://api.github.com/users/nirmoy/orgs","repos_url":"https://api.github.com/users/nirmoy/repos","events_url":"https://api.github.com/users/nirmoy/events{/privacy}","received_events_url":"https://api.github.com/users/nirmoy/received_events","type":"User","site_admin":false},"repo":{"id":121361230,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzNjEyMzA=","name":"cilium","full_name":"nirmoy/cilium","private":false,"owner":{"login":"nirmoy","id":3065605,"node_id":"MDQ6VXNlcjMwNjU2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3065605?v=4","gravatar_id":"","url":"https://api.github.com/users/nirmoy","html_url":"https://github.com/nirmoy","followers_url":"https://api.github.com/users/nirmoy/followers","following_url":"https://api.github.com/users/nirmoy/following{/other_user}","gists_url":"https://api.github.com/users/nirmoy/gists{/gist_id}","starred_url":"https://api.github.com/users/nirmoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirmoy/subscriptions","organizations_url":"https://api.github.com/users/nirmoy/orgs","repos_url":"https://api.github.com/users/nirmoy/repos","events_url":"https://api.github.com/users/nirmoy/events{/privacy}","received_events_url":"https://api.github.com/users/nirmoy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nirmoy/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":true,"url":"https://api.github.com/repos/nirmoy/cilium","forks_url":"https://api.github.com/repos/nirmoy/cilium/forks","keys_url":"https://api.github.com/repos/nirmoy/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirmoy/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirmoy/cilium/teams","hooks_url":"https://api.github.com/repos/nirmoy/cilium/hooks","issue_events_url":"https://api.github.com/repos/nirmoy/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/nirmoy/cilium/events","assignees_url":"https://api.github.com/repos/nirmoy/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/nirmoy/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/nirmoy/cilium/tags","blobs_url":"https://api.github.com/repos/nirmoy/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirmoy/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirmoy/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirmoy/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirmoy/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/nirmoy/cilium/languages","stargazers_url":"https://api.github.com/repos/nirmoy/cilium/stargazers","contributors_url":"https://api.github.com/repos/nirmoy/cilium/contributors","subscribers_url":"https://api.github.com/repos/nirmoy/cilium/subscribers","subscription_url":"https://api.github.com/repos/nirmoy/cilium/subscription","commits_url":"https://api.github.com/repos/nirmoy/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirmoy/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirmoy/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirmoy/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/nirmoy/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/nirmoy/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirmoy/cilium/merges","archive_url":"https://api.github.com/repos/nirmoy/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirmoy/cilium/downloads","issues_url":"https://api.github.com/repos/nirmoy/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/nirmoy/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/nirmoy/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/nirmoy/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirmoy/cilium/labels{/name}","releases_url":"https://api.github.com/repos/nirmoy/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/nirmoy/cilium/deployments","created_at":"2018-02-13T09:08:30Z","updated_at":"2018-11-04T16:11:11Z","pushed_at":"2018-11-20T17:31:45Z","git_url":"git://github.com/nirmoy/cilium.git","ssh_url":"git@github.com:nirmoy/cilium.git","clone_url":"https://github.com/nirmoy/cilium.git","svn_url":"https://github.com/nirmoy/cilium","homepage":"","size":62350,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"4b4c4406809be0315cb4b8ba9cb33f8bbde03dd0","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-11-21T08:20:42Z","pushed_at":"2018-11-21T08:20:29Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":75055,"stargazers_count":3101,"watchers_count":3101,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"archived":false,"open_issues_count":539,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":274,"open_issues":539,"watchers":3101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6260"},"html":{"href":"https://github.com/cilium/cilium/pull/6260"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/6260"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/6260/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6260/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6260/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/3fb89173015e786b9fe12832cba7e328931aff1c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nirmoy"}}