{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/issues/3","repository_url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator","labels_url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/issues/3/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/issues/3/events","html_url":"https://github.com/kubernetes-sigs/kube-storage-version-migrator/pull/3","id":360474458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzI2NjA0","number":3,"title":"Adding the core migrator that rewrites objects of a single resource type","user":{"login":"caesarxuchao","id":2823529,"node_id":"MDQ6VXNlcjI4MjM1Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"labels":[{"id":1033730052,"node_id":"MDU6TGFiZWwxMDMzNzMwMDUy","url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1033723328,"node_id":"MDU6TGFiZWwxMDMzNzIzMzI4","url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"yliaog","id":32884155,"node_id":"MDQ6VXNlcjMyODg0MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/32884155?v=4","gravatar_id":"","url":"https://api.github.com/users/yliaog","html_url":"https://github.com/yliaog","followers_url":"https://api.github.com/users/yliaog/followers","following_url":"https://api.github.com/users/yliaog/following{/other_user}","gists_url":"https://api.github.com/users/yliaog/gists{/gist_id}","starred_url":"https://api.github.com/users/yliaog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yliaog/subscriptions","organizations_url":"https://api.github.com/users/yliaog/orgs","repos_url":"https://api.github.com/users/yliaog/repos","events_url":"https://api.github.com/users/yliaog/events{/privacy}","received_events_url":"https://api.github.com/users/yliaog/received_events","type":"User","site_admin":false},"assignees":[{"login":"yliaog","id":32884155,"node_id":"MDQ6VXNlcjMyODg0MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/32884155?v=4","gravatar_id":"","url":"https://api.github.com/users/yliaog","html_url":"https://github.com/yliaog","followers_url":"https://api.github.com/users/yliaog/followers","following_url":"https://api.github.com/users/yliaog/following{/other_user}","gists_url":"https://api.github.com/users/yliaog/gists{/gist_id}","starred_url":"https://api.github.com/users/yliaog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yliaog/subscriptions","organizations_url":"https://api.github.com/users/yliaog/orgs","repos_url":"https://api.github.com/users/yliaog/repos","events_url":"https://api.github.com/users/yliaog/events{/privacy}","received_events_url":"https://api.github.com/users/yliaog/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-09-14T22:34:10Z","updated_at":"2018-09-25T21:07:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/pulls/3","html_url":"https://github.com/kubernetes-sigs/kube-storage-version-migrator/pull/3","diff_url":"https://github.com/kubernetes-sigs/kube-storage-version-migrator/pull/3.diff","patch_url":"https://github.com/kubernetes-sigs/kube-storage-version-migrator/pull/3.patch"},"body":"The core migrator lists a chunk of objects, GET&PUT each of them, then continue with the next chunk.\r\n\r\nThe code more or less resembles the [oc admin migrate storage code](https://github.com/openshift/origin/blob/master/pkg/oc/cli/admin/migrate/storage/storage.go). A small improvement is that the migrator uses the [inconsistent continue token](https://github.com/kubernetes/kubernetes/pull/67284) sent by the apiserver in case the original list is compacted. So the migrator doesn't have to finish migrating a resource type in the etcd compaction window (5 mins by default).\r\n\r\nI see the `oc migrate` command [switched](https://github.com/openshift/origin/pull/20555) to using unstructured client. It saved a GET request per object. But the unstructured client only supports json, which is less efficient than proto. I'm not sure if it's a net-win, so I didn't incorporate the change.\r\n\r\nI removed the dependencies to facilitate code reviews.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/issues/comments/424501837","html_url":"https://github.com/kubernetes-sigs/kube-storage-version-migrator/pull/3#issuecomment-424501837","issue_url":"https://api.github.com/repos/kubernetes-sigs/kube-storage-version-migrator/issues/3","id":424501837,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDUwMTgzNw==","user":{"login":"yliaog","id":32884155,"node_id":"MDQ6VXNlcjMyODg0MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/32884155?v=4","gravatar_id":"","url":"https://api.github.com/users/yliaog","html_url":"https://github.com/yliaog","followers_url":"https://api.github.com/users/yliaog/followers","following_url":"https://api.github.com/users/yliaog/following{/other_user}","gists_url":"https://api.github.com/users/yliaog/gists{/gist_id}","starred_url":"https://api.github.com/users/yliaog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yliaog/subscriptions","organizations_url":"https://api.github.com/users/yliaog/orgs","repos_url":"https://api.github.com/users/yliaog/repos","events_url":"https://api.github.com/users/yliaog/events{/privacy}","received_events_url":"https://api.github.com/users/yliaog/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T21:07:27Z","updated_at":"2018-09-25T21:07:27Z","author_association":"NONE","body":"some import issue:\r\nhttps://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kube-storage-version-migrator/3/pull-kube-storage-version-migrator-test/2"}}
{"actor":{"display_login":"yliaog"}}