{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments/200275859","pull_request_review_id":134557649,"id":200275859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDI3NTg1OQ==","diff_hunk":"@@ -37,22 +37,21 @@ class EthashBlockHeaderValidator(blockchainConfig: BlockchainConfig) extends Blo\n     import scala.collection.JavaConverters._\n \n     def getPowCacheData(epoch: Long): PowCacheData = {\n-      if (epoch == 0) EthashBlockHeaderValidator.epoch0PowCache else\n-        Option(powCaches.get(epoch)) match {\n-          case Some(pcd) => pcd\n-          case None =>\n-            val data = new PowCacheData(\n-              cache = EthashUtils.makeCache(epoch),\n-              dagSize = EthashUtils.dagSize(epoch))\n-\n-            val keys = powCaches.keySet().asScala\n-            val keysToRemove = keys.toSeq.sorted.take(keys.size - MaxPowCaches + 1)\n-            keysToRemove.foreach(powCaches.remove)\n-\n-            powCaches.put(epoch, data)\n-\n-            data\n-        }\n+      Option(powCaches.get(epoch)) match {","path":"src/main/scala/io/iohk/ethereum/consensus/ethash/validators/EthashBlockHeaderValidator.scala","position":20,"original_position":20,"commit_id":"1298f1ab1ce16454d2235145e0555d1d73133ac9","original_commit_id":"1298f1ab1ce16454d2235145e0555d1d73133ac9","user":{"login":"mmrozek","id":2864259,"node_id":"MDQ6VXNlcjI4NjQyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2864259?v=4","gravatar_id":"","url":"https://api.github.com/users/mmrozek","html_url":"https://github.com/mmrozek","followers_url":"https://api.github.com/users/mmrozek/followers","following_url":"https://api.github.com/users/mmrozek/following{/other_user}","gists_url":"https://api.github.com/users/mmrozek/gists{/gist_id}","starred_url":"https://api.github.com/users/mmrozek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmrozek/subscriptions","organizations_url":"https://api.github.com/users/mmrozek/orgs","repos_url":"https://api.github.com/users/mmrozek/repos","events_url":"https://api.github.com/users/mmrozek/events{/privacy}","received_events_url":"https://api.github.com/users/mmrozek/received_events","type":"User","site_admin":false},"body":"I think, it is ok. `Option(null) == None`","created_at":"2018-07-05T08:48:17Z","updated_at":"2018-07-05T08:48:17Z","html_url":"https://github.com/input-output-hk/mantis/pull/520#discussion_r200275859","pull_request_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/520","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments/200275859"},"html":{"href":"https://github.com/input-output-hk/mantis/pull/520#discussion_r200275859"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/520"}},"in_reply_to_id":200265628},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/mantis/pulls/520","id":199379921,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Mzc5OTIx","html_url":"https://github.com/input-output-hk/mantis/pull/520","diff_url":"https://github.com/input-output-hk/mantis/pull/520.diff","patch_url":"https://github.com/input-output-hk/mantis/pull/520.patch","issue_url":"https://api.github.com/repos/input-output-hk/mantis/issues/520","number":520,"state":"open","locked":false,"title":"[EC-331] improve fix for optimising BlockchainSuite","user":{"login":"KonradStaniec","id":10688236,"node_id":"MDQ6VXNlcjEwNjg4MjM2","avatar_url":"https://avatars2.githubusercontent.com/u/10688236?v=4","gravatar_id":"","url":"https://api.github.com/users/KonradStaniec","html_url":"https://github.com/KonradStaniec","followers_url":"https://api.github.com/users/KonradStaniec/followers","following_url":"https://api.github.com/users/KonradStaniec/following{/other_user}","gists_url":"https://api.github.com/users/KonradStaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/KonradStaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KonradStaniec/subscriptions","organizations_url":"https://api.github.com/users/KonradStaniec/orgs","repos_url":"https://api.github.com/users/KonradStaniec/repos","events_url":"https://api.github.com/users/KonradStaniec/events{/privacy}","received_events_url":"https://api.github.com/users/KonradStaniec/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-05T07:25:24Z","updated_at":"2018-07-05T08:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eebb6caab5ac0007f37e9f6247c9d9b6cf78f51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/520/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/520/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/issues/520/comments","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/1298f1ab1ce16454d2235145e0555d1d73133ac9","head":{"label":"input-output-hk:feature/ec_331","ref":"feature/ec_331","sha":"1298f1ab1ce16454d2235145e0555d1d73133ac9","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI1NjExMw==","name":"mantis","full_name":"input-output-hk/mantis","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/mantis","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/mantis","forks_url":"https://api.github.com/repos/input-output-hk/mantis/forks","keys_url":"https://api.github.com/repos/input-output-hk/mantis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/mantis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/mantis/teams","hooks_url":"https://api.github.com/repos/input-output-hk/mantis/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/mantis/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/mantis/events","assignees_url":"https://api.github.com/repos/input-output-hk/mantis/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/mantis/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/mantis/tags","blobs_url":"https://api.github.com/repos/input-output-hk/mantis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/mantis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/mantis/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/mantis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/mantis/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/mantis/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/mantis/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/mantis/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/mantis/subscription","commits_url":"https://api.github.com/repos/input-output-hk/mantis/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/mantis/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/mantis/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/mantis/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/mantis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/mantis/merges","archive_url":"https://api.github.com/repos/input-output-hk/mantis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/mantis/downloads","issues_url":"https://api.github.com/repos/input-output-hk/mantis/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/mantis/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/mantis/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/mantis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/mantis/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/mantis/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/mantis/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2018-06-30T11:16:56Z","pushed_at":"2018-07-05T08:28:53Z","git_url":"git://github.com/input-output-hk/mantis.git","ssh_url":"git@github.com:input-output-hk/mantis.git","clone_url":"https://github.com/input-output-hk/mantis.git","svn_url":"https://github.com/input-output-hk/mantis","homepage":null,"size":15693,"stargazers_count":123,"watchers_count":123,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":42,"open_issues":33,"watchers":123,"default_branch":"master"}},"base":{"label":"input-output-hk:feature/byzantium_fork","ref":"feature/byzantium_fork","sha":"9275e5a6f09076fbd78321e0567ab75be566fe64","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI1NjExMw==","name":"mantis","full_name":"input-output-hk/mantis","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/mantis","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/mantis","forks_url":"https://api.github.com/repos/input-output-hk/mantis/forks","keys_url":"https://api.github.com/repos/input-output-hk/mantis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/mantis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/mantis/teams","hooks_url":"https://api.github.com/repos/input-output-hk/mantis/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/mantis/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/mantis/events","assignees_url":"https://api.github.com/repos/input-output-hk/mantis/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/mantis/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/mantis/tags","blobs_url":"https://api.github.com/repos/input-output-hk/mantis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/mantis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/mantis/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/mantis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/mantis/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/mantis/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/mantis/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/mantis/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/mantis/subscription","commits_url":"https://api.github.com/repos/input-output-hk/mantis/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/mantis/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/mantis/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/mantis/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/mantis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/mantis/merges","archive_url":"https://api.github.com/repos/input-output-hk/mantis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/mantis/downloads","issues_url":"https://api.github.com/repos/input-output-hk/mantis/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/mantis/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/mantis/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/mantis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/mantis/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/mantis/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/mantis/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2018-06-30T11:16:56Z","pushed_at":"2018-07-05T08:28:53Z","git_url":"git://github.com/input-output-hk/mantis.git","ssh_url":"git@github.com:input-output-hk/mantis.git","clone_url":"https://github.com/input-output-hk/mantis.git","svn_url":"https://github.com/input-output-hk/mantis","homepage":null,"size":15693,"stargazers_count":123,"watchers_count":123,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":42,"open_issues":33,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/520"},"html":{"href":"https://github.com/input-output-hk/mantis/pull/520"},"issue":{"href":"https://api.github.com/repos/input-output-hk/mantis/issues/520"},"comments":{"href":"https://api.github.com/repos/input-output-hk/mantis/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/mantis/statuses/1298f1ab1ce16454d2235145e0555d1d73133ac9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mmrozek"}}