{"action":"created","comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/191059527","pull_request_review_id":123567624,"id":191059527,"diff_hunk":"@@ -62,14 +62,6 @@ sed -i -e \"s/visible: root.rightAction/visible: root.rightAction \\&\\& \\!Qt.input\n # https://bugs.kde.org/show_bug.cgi?id=394204\n sed -i -e \"s/width: backgroundRect/enabled: root.enabled;    width: backgroundRect/g\" src/controls/templates/private/PassiveNotification.qml\n \n-# another hack. Do not include the Kirigami resources (on static build). It causes\n-# double defined symbols in our setting. I would like a nicer fix for this\n-# issue, but failed to find one. For example, not adding the resource in\n-# our build causes the qrc file not to be generated. Manual generation\n-# of the resource file (using rcc) introduces the double symbols again. \n-# so it seems some Kirigami weirdness (but their staticcmake example compiles\n-# correctly).\n-sed -i -e \"s/#include <qrc_kirigami.cpp>/\\/\\/#include <qrc_kirigami.cpp>/\" src/kirigamiplugin.cpp","path":"scripts/mobilecomponents.sh","position":null,"original_position":11,"commit_id":"c8527f3b45366bb3fab185544739d047cc64d9ec","original_commit_id":"8c5bc6ba32db321ea7101b9814943b46f68a5301","user":{"login":"mfbernardes","id":30494,"avatar_url":"https://avatars0.githubusercontent.com/u/30494?v=4","gravatar_id":"","url":"https://api.github.com/users/mfbernardes","html_url":"https://github.com/mfbernardes","followers_url":"https://api.github.com/users/mfbernardes/followers","following_url":"https://api.github.com/users/mfbernardes/following{/other_user}","gists_url":"https://api.github.com/users/mfbernardes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfbernardes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfbernardes/subscriptions","organizations_url":"https://api.github.com/users/mfbernardes/orgs","repos_url":"https://api.github.com/users/mfbernardes/repos","events_url":"https://api.github.com/users/mfbernardes/events{/privacy}","received_events_url":"https://api.github.com/users/mfbernardes/received_events","type":"User","site_admin":false},"body":"It was not a problem for iOS, but if it breaks android or mobile on desktop I'll leave it.\r\n\r\nI just removed this commit.","created_at":"2018-05-26T22:07:16Z","updated_at":"2018-05-26T22:07:16Z","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1332#discussion_r191059527","pull_request_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/191059527"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1332#discussion_r191059527"},"pull_request":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332"}},"in_reply_to_id":191059431},"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332","id":190759950,"html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1332","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1332.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1332.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1332","number":1332,"state":"open","locked":false,"title":"mobile: Fix missing icons","user":{"login":"mfbernardes","id":30494,"avatar_url":"https://avatars0.githubusercontent.com/u/30494?v=4","gravatar_id":"","url":"https://api.github.com/users/mfbernardes","html_url":"https://github.com/mfbernardes","followers_url":"https://api.github.com/users/mfbernardes/followers","following_url":"https://api.github.com/users/mfbernardes/following{/other_user}","gists_url":"https://api.github.com/users/mfbernardes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfbernardes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfbernardes/subscriptions","organizations_url":"https://api.github.com/users/mfbernardes/orgs","repos_url":"https://api.github.com/users/mfbernardes/repos","events_url":"https://api.github.com/users/mfbernardes/events{/privacy}","received_events_url":"https://api.github.com/users/mfbernardes/received_events","type":"User","site_admin":false},"body":"<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [x] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\n\r\nIcons on actions of GPS fixes list and dive list were missing.\r\n\r\nApplication header icon was not useful and unaligned, so removed.\r\n\r\nFix #1267\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->","created_at":"2018-05-26T21:31:30Z","updated_at":"2018-05-26T22:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"913906f67977e00a7c1e08a4615efe6ad7bd58e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":701663351,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/bug-fix","name":"bug-fix","color":"b60205","default":false},{"id":925204812,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/needs-maintainer-feedback","name":"needs-maintainer-feedback","color":"fbca04","default":false},{"id":700946722,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/open-discussion","name":"open-discussion","color":"5319e7","default":false},{"id":700898927,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/ui-mobile","name":"ui-mobile","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1332/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/c8527f3b45366bb3fab185544739d047cc64d9ec","head":{"label":"mfbernardes:mobile-icons","ref":"mobile-icons","sha":"c8527f3b45366bb3fab185544739d047cc64d9ec","user":{"login":"mfbernardes","id":30494,"avatar_url":"https://avatars0.githubusercontent.com/u/30494?v=4","gravatar_id":"","url":"https://api.github.com/users/mfbernardes","html_url":"https://github.com/mfbernardes","followers_url":"https://api.github.com/users/mfbernardes/followers","following_url":"https://api.github.com/users/mfbernardes/following{/other_user}","gists_url":"https://api.github.com/users/mfbernardes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfbernardes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfbernardes/subscriptions","organizations_url":"https://api.github.com/users/mfbernardes/orgs","repos_url":"https://api.github.com/users/mfbernardes/repos","events_url":"https://api.github.com/users/mfbernardes/events{/privacy}","received_events_url":"https://api.github.com/users/mfbernardes/received_events","type":"User","site_admin":false},"repo":{"id":112818349,"name":"subsurface","full_name":"mfbernardes/subsurface","owner":{"login":"mfbernardes","id":30494,"avatar_url":"https://avatars0.githubusercontent.com/u/30494?v=4","gravatar_id":"","url":"https://api.github.com/users/mfbernardes","html_url":"https://github.com/mfbernardes","followers_url":"https://api.github.com/users/mfbernardes/followers","following_url":"https://api.github.com/users/mfbernardes/following{/other_user}","gists_url":"https://api.github.com/users/mfbernardes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfbernardes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfbernardes/subscriptions","organizations_url":"https://api.github.com/users/mfbernardes/orgs","repos_url":"https://api.github.com/users/mfbernardes/repos","events_url":"https://api.github.com/users/mfbernardes/events{/privacy}","received_events_url":"https://api.github.com/users/mfbernardes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfbernardes/subsurface","description":"Subsurface divelog","fork":true,"url":"https://api.github.com/repos/mfbernardes/subsurface","forks_url":"https://api.github.com/repos/mfbernardes/subsurface/forks","keys_url":"https://api.github.com/repos/mfbernardes/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfbernardes/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfbernardes/subsurface/teams","hooks_url":"https://api.github.com/repos/mfbernardes/subsurface/hooks","issue_events_url":"https://api.github.com/repos/mfbernardes/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/mfbernardes/subsurface/events","assignees_url":"https://api.github.com/repos/mfbernardes/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/mfbernardes/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/mfbernardes/subsurface/tags","blobs_url":"https://api.github.com/repos/mfbernardes/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfbernardes/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfbernardes/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfbernardes/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfbernardes/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/mfbernardes/subsurface/languages","stargazers_url":"https://api.github.com/repos/mfbernardes/subsurface/stargazers","contributors_url":"https://api.github.com/repos/mfbernardes/subsurface/contributors","subscribers_url":"https://api.github.com/repos/mfbernardes/subsurface/subscribers","subscription_url":"https://api.github.com/repos/mfbernardes/subsurface/subscription","commits_url":"https://api.github.com/repos/mfbernardes/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfbernardes/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfbernardes/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfbernardes/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfbernardes/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/mfbernardes/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfbernardes/subsurface/merges","archive_url":"https://api.github.com/repos/mfbernardes/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfbernardes/subsurface/downloads","issues_url":"https://api.github.com/repos/mfbernardes/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/mfbernardes/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/mfbernardes/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/mfbernardes/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfbernardes/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/mfbernardes/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/mfbernardes/subsurface/deployments","created_at":"2017-12-02T06:21:45Z","updated_at":"2018-05-13T17:14:45Z","pushed_at":"2018-05-26T22:06:04Z","git_url":"git://github.com/mfbernardes/subsurface.git","ssh_url":"git@github.com:mfbernardes/subsurface.git","clone_url":"https://github.com/mfbernardes/subsurface.git","svn_url":"https://github.com/mfbernardes/subsurface","homepage":"https://subsurface-divelog.org","size":89553,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"2d1e5d7a992841bf2b76f5f85d2ab8419e22697f","user":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-05-26T16:26:49Z","pushed_at":"2018-05-26T22:06:05Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":89613,"stargazers_count":1376,"watchers_count":1376,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":349,"open_issues":79,"watchers":1376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1332"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1332"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1332/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1332/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/c8527f3b45366bb3fab185544739d047cc64d9ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mfbernardes"}}