{"action":"created","comment":{"url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/comments/180873371","pull_request_review_id":111373102,"id":180873371,"diff_hunk":"@@ -106,7 +107,13 @@ function inject_resource_adapters_common() {\n       resource_adapter=\"${resource_adapter}<transaction-support>$transaction_support</transaction-support>\"\n     fi\n \n-    resource_adapter=\"${resource_adapter}<connection-definitions><connection-definition class-name=\\\"${ra_class}\\\" jndi-name=\\\"${ra_jndi}\\\" enabled=\\\"true\\\" use-java-context=\\\"true\\\">\"\n+    resource_adapter=\"${resource_adapter}<connection-definitions><connection-definition\"\n+\n+    if [ -n \"${RA_TRACKING}\" ]; then","path":"os-eap-launch/added/launch/resource-adapters-common.sh","position":15,"original_position":15,"commit_id":"4f3588b2b5159b918cda6a7c50d63360561cf360","original_commit_id":"4f3588b2b5159b918cda6a7c50d63360561cf360","user":{"login":"maschmid","id":621069,"avatar_url":"https://avatars0.githubusercontent.com/u/621069?v=4","gravatar_id":"","url":"https://api.github.com/users/maschmid","html_url":"https://github.com/maschmid","followers_url":"https://api.github.com/users/maschmid/followers","following_url":"https://api.github.com/users/maschmid/following{/other_user}","gists_url":"https://api.github.com/users/maschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/maschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maschmid/subscriptions","organizations_url":"https://api.github.com/users/maschmid/orgs","repos_url":"https://api.github.com/users/maschmid/repos","events_url":"https://api.github.com/users/maschmid/events{/privacy}","received_events_url":"https://api.github.com/users/maschmid/received_events","type":"User","site_admin":false},"body":"in this case this is resource-adapter specific, so it should use the ra_prefix_TRACKING ","created_at":"2018-04-11T19:35:45Z","updated_at":"2018-04-11T19:43:02Z","html_url":"https://github.com/jboss-openshift/cct_module/pull/226#discussion_r180873371","pull_request_url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/comments/180873371"},"html":{"href":"https://github.com/jboss-openshift/cct_module/pull/226#discussion_r180873371"},"pull_request":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226","id":180680577,"html_url":"https://github.com/jboss-openshift/cct_module/pull/226","diff_url":"https://github.com/jboss-openshift/cct_module/pull/226.diff","patch_url":"https://github.com/jboss-openshift/cct_module/pull/226.patch","issue_url":"https://api.github.com/repos/jboss-openshift/cct_module/issues/226","number":226,"state":"open","locked":false,"title":"[CLOUD-2455] - [BxMS] ERROR IJ000315: Pool amq-ConnectionFactory has …","user":{"login":"spolti","id":1863987,"avatar_url":"https://avatars0.githubusercontent.com/u/1863987?v=4","gravatar_id":"","url":"https://api.github.com/users/spolti","html_url":"https://github.com/spolti","followers_url":"https://api.github.com/users/spolti/followers","following_url":"https://api.github.com/users/spolti/following{/other_user}","gists_url":"https://api.github.com/users/spolti/gists{/gist_id}","starred_url":"https://api.github.com/users/spolti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spolti/subscriptions","organizations_url":"https://api.github.com/users/spolti/orgs","repos_url":"https://api.github.com/users/spolti/repos","events_url":"https://api.github.com/users/spolti/events{/privacy}","received_events_url":"https://api.github.com/users/spolti/received_events","type":"User","site_admin":false},"body":"…1 active handles\r\n\r\nSigned-off-by: Filippe Spolti <fspolti@redhat.com>\r\n\r\nThanks for submitting your Pull Request!\r\n\r\nPlease make sure your PR meets following requirements:\r\n\r\n- [ ] Pull Request title is properly formatted: `[CLOUD-XYA] Subject`\r\n- [ ] Pull Request contains link to the JIRA issue\r\n- [ ] Pull Request contains description of the issue\r\n- [ ] Pull request does not include fixes for other issues than the main ticket\r\n- [ ] Attached commits represent unit of work and are properly formatted\r\n- [ ] You have read and agreed to the Developer Certificate of Origin (DCO) (see `CONTRIBUTING.md`)\r\n- [ ] Every commit contains `Signed-off-by: Your Name <yourname@redhat.com>` - use `git commit -s`\r\n","created_at":"2018-04-10T17:52:21Z","updated_at":"2018-04-11T19:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea514f36741b9162d9b51b3dad388b2ad881dc84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226/commits","review_comments_url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226/comments","review_comment_url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jboss-openshift/cct_module/issues/226/comments","statuses_url":"https://api.github.com/repos/jboss-openshift/cct_module/statuses/4f3588b2b5159b918cda6a7c50d63360561cf360","head":{"label":"spolti:CLOUD-2455","ref":"CLOUD-2455","sha":"4f3588b2b5159b918cda6a7c50d63360561cf360","user":{"login":"spolti","id":1863987,"avatar_url":"https://avatars0.githubusercontent.com/u/1863987?v=4","gravatar_id":"","url":"https://api.github.com/users/spolti","html_url":"https://github.com/spolti","followers_url":"https://api.github.com/users/spolti/followers","following_url":"https://api.github.com/users/spolti/following{/other_user}","gists_url":"https://api.github.com/users/spolti/gists{/gist_id}","starred_url":"https://api.github.com/users/spolti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spolti/subscriptions","organizations_url":"https://api.github.com/users/spolti/orgs","repos_url":"https://api.github.com/users/spolti/repos","events_url":"https://api.github.com/users/spolti/events{/privacy}","received_events_url":"https://api.github.com/users/spolti/received_events","type":"User","site_admin":false},"repo":{"id":95805859,"name":"cct_module","full_name":"spolti/cct_module","owner":{"login":"spolti","id":1863987,"avatar_url":"https://avatars0.githubusercontent.com/u/1863987?v=4","gravatar_id":"","url":"https://api.github.com/users/spolti","html_url":"https://github.com/spolti","followers_url":"https://api.github.com/users/spolti/followers","following_url":"https://api.github.com/users/spolti/following{/other_user}","gists_url":"https://api.github.com/users/spolti/gists{/gist_id}","starred_url":"https://api.github.com/users/spolti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spolti/subscriptions","organizations_url":"https://api.github.com/users/spolti/orgs","repos_url":"https://api.github.com/users/spolti/repos","events_url":"https://api.github.com/users/spolti/events{/privacy}","received_events_url":"https://api.github.com/users/spolti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spolti/cct_module","description":null,"fork":true,"url":"https://api.github.com/repos/spolti/cct_module","forks_url":"https://api.github.com/repos/spolti/cct_module/forks","keys_url":"https://api.github.com/repos/spolti/cct_module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spolti/cct_module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spolti/cct_module/teams","hooks_url":"https://api.github.com/repos/spolti/cct_module/hooks","issue_events_url":"https://api.github.com/repos/spolti/cct_module/issues/events{/number}","events_url":"https://api.github.com/repos/spolti/cct_module/events","assignees_url":"https://api.github.com/repos/spolti/cct_module/assignees{/user}","branches_url":"https://api.github.com/repos/spolti/cct_module/branches{/branch}","tags_url":"https://api.github.com/repos/spolti/cct_module/tags","blobs_url":"https://api.github.com/repos/spolti/cct_module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spolti/cct_module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spolti/cct_module/git/refs{/sha}","trees_url":"https://api.github.com/repos/spolti/cct_module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spolti/cct_module/statuses/{sha}","languages_url":"https://api.github.com/repos/spolti/cct_module/languages","stargazers_url":"https://api.github.com/repos/spolti/cct_module/stargazers","contributors_url":"https://api.github.com/repos/spolti/cct_module/contributors","subscribers_url":"https://api.github.com/repos/spolti/cct_module/subscribers","subscription_url":"https://api.github.com/repos/spolti/cct_module/subscription","commits_url":"https://api.github.com/repos/spolti/cct_module/commits{/sha}","git_commits_url":"https://api.github.com/repos/spolti/cct_module/git/commits{/sha}","comments_url":"https://api.github.com/repos/spolti/cct_module/comments{/number}","issue_comment_url":"https://api.github.com/repos/spolti/cct_module/issues/comments{/number}","contents_url":"https://api.github.com/repos/spolti/cct_module/contents/{+path}","compare_url":"https://api.github.com/repos/spolti/cct_module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spolti/cct_module/merges","archive_url":"https://api.github.com/repos/spolti/cct_module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spolti/cct_module/downloads","issues_url":"https://api.github.com/repos/spolti/cct_module/issues{/number}","pulls_url":"https://api.github.com/repos/spolti/cct_module/pulls{/number}","milestones_url":"https://api.github.com/repos/spolti/cct_module/milestones{/number}","notifications_url":"https://api.github.com/repos/spolti/cct_module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spolti/cct_module/labels{/name}","releases_url":"https://api.github.com/repos/spolti/cct_module/releases{/id}","deployments_url":"https://api.github.com/repos/spolti/cct_module/deployments","created_at":"2017-06-29T18:09:25Z","updated_at":"2018-04-10T15:13:45Z","pushed_at":"2018-04-11T19:07:12Z","git_url":"git://github.com/spolti/cct_module.git","ssh_url":"git@github.com:spolti/cct_module.git","clone_url":"https://github.com/spolti/cct_module.git","svn_url":"https://github.com/spolti/cct_module","homepage":null,"size":1628,"stargazers_count":0,"watchers_count":0,"language":"Gherkin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jboss-openshift:master","ref":"master","sha":"cb057897294d858108f2dae70fb344ba61df30a6","user":{"login":"jboss-openshift","id":12071709,"avatar_url":"https://avatars2.githubusercontent.com/u/12071709?v=4","gravatar_id":"","url":"https://api.github.com/users/jboss-openshift","html_url":"https://github.com/jboss-openshift","followers_url":"https://api.github.com/users/jboss-openshift/followers","following_url":"https://api.github.com/users/jboss-openshift/following{/other_user}","gists_url":"https://api.github.com/users/jboss-openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-openshift/subscriptions","organizations_url":"https://api.github.com/users/jboss-openshift/orgs","repos_url":"https://api.github.com/users/jboss-openshift/repos","events_url":"https://api.github.com/users/jboss-openshift/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":94754169,"name":"cct_module","full_name":"jboss-openshift/cct_module","owner":{"login":"jboss-openshift","id":12071709,"avatar_url":"https://avatars2.githubusercontent.com/u/12071709?v=4","gravatar_id":"","url":"https://api.github.com/users/jboss-openshift","html_url":"https://github.com/jboss-openshift","followers_url":"https://api.github.com/users/jboss-openshift/followers","following_url":"https://api.github.com/users/jboss-openshift/following{/other_user}","gists_url":"https://api.github.com/users/jboss-openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-openshift/subscriptions","organizations_url":"https://api.github.com/users/jboss-openshift/orgs","repos_url":"https://api.github.com/users/jboss-openshift/repos","events_url":"https://api.github.com/users/jboss-openshift/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jboss-openshift/cct_module","description":null,"fork":false,"url":"https://api.github.com/repos/jboss-openshift/cct_module","forks_url":"https://api.github.com/repos/jboss-openshift/cct_module/forks","keys_url":"https://api.github.com/repos/jboss-openshift/cct_module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jboss-openshift/cct_module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jboss-openshift/cct_module/teams","hooks_url":"https://api.github.com/repos/jboss-openshift/cct_module/hooks","issue_events_url":"https://api.github.com/repos/jboss-openshift/cct_module/issues/events{/number}","events_url":"https://api.github.com/repos/jboss-openshift/cct_module/events","assignees_url":"https://api.github.com/repos/jboss-openshift/cct_module/assignees{/user}","branches_url":"https://api.github.com/repos/jboss-openshift/cct_module/branches{/branch}","tags_url":"https://api.github.com/repos/jboss-openshift/cct_module/tags","blobs_url":"https://api.github.com/repos/jboss-openshift/cct_module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jboss-openshift/cct_module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jboss-openshift/cct_module/git/refs{/sha}","trees_url":"https://api.github.com/repos/jboss-openshift/cct_module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jboss-openshift/cct_module/statuses/{sha}","languages_url":"https://api.github.com/repos/jboss-openshift/cct_module/languages","stargazers_url":"https://api.github.com/repos/jboss-openshift/cct_module/stargazers","contributors_url":"https://api.github.com/repos/jboss-openshift/cct_module/contributors","subscribers_url":"https://api.github.com/repos/jboss-openshift/cct_module/subscribers","subscription_url":"https://api.github.com/repos/jboss-openshift/cct_module/subscription","commits_url":"https://api.github.com/repos/jboss-openshift/cct_module/commits{/sha}","git_commits_url":"https://api.github.com/repos/jboss-openshift/cct_module/git/commits{/sha}","comments_url":"https://api.github.com/repos/jboss-openshift/cct_module/comments{/number}","issue_comment_url":"https://api.github.com/repos/jboss-openshift/cct_module/issues/comments{/number}","contents_url":"https://api.github.com/repos/jboss-openshift/cct_module/contents/{+path}","compare_url":"https://api.github.com/repos/jboss-openshift/cct_module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jboss-openshift/cct_module/merges","archive_url":"https://api.github.com/repos/jboss-openshift/cct_module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jboss-openshift/cct_module/downloads","issues_url":"https://api.github.com/repos/jboss-openshift/cct_module/issues{/number}","pulls_url":"https://api.github.com/repos/jboss-openshift/cct_module/pulls{/number}","milestones_url":"https://api.github.com/repos/jboss-openshift/cct_module/milestones{/number}","notifications_url":"https://api.github.com/repos/jboss-openshift/cct_module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jboss-openshift/cct_module/labels{/name}","releases_url":"https://api.github.com/repos/jboss-openshift/cct_module/releases{/id}","deployments_url":"https://api.github.com/repos/jboss-openshift/cct_module/deployments","created_at":"2017-06-19T08:30:13Z","updated_at":"2018-04-06T15:45:21Z","pushed_at":"2018-04-11T19:07:13Z","git_url":"git://github.com/jboss-openshift/cct_module.git","ssh_url":"git@github.com:jboss-openshift/cct_module.git","clone_url":"https://github.com/jboss-openshift/cct_module.git","svn_url":"https://github.com/jboss-openshift/cct_module","homepage":null,"size":1596,"stargazers_count":16,"watchers_count":16,"language":"Gherkin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":42,"open_issues":28,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226"},"html":{"href":"https://github.com/jboss-openshift/cct_module/pull/226"},"issue":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/issues/226"},"comments":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/jboss-openshift/cct_module/statuses/4f3588b2b5159b918cda6a7c50d63360561cf360"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maschmid"}}