{"action":"created","issue":{"url":"https://api.github.com/repos/isawnyu/isaw.web/issues/342","repository_url":"https://api.github.com/repos/isawnyu/isaw.web","labels_url":"https://api.github.com/repos/isawnyu/isaw.web/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/isawnyu/isaw.web/issues/342/comments","events_url":"https://api.github.com/repos/isawnyu/isaw.web/issues/342/events","html_url":"https://github.com/isawnyu/isaw.web/issues/342","id":366040625,"node_id":"MDU6SXNzdWUzNjYwNDA2MjU=","number":342,"title":"eliminate redundant links in \"events listing\": 2","user":{"login":"paregorios","id":263285,"node_id":"MDQ6VXNlcjI2MzI4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/263285?v=4","gravatar_id":"","url":"https://api.github.com/users/paregorios","html_url":"https://github.com/paregorios","followers_url":"https://api.github.com/users/paregorios/followers","following_url":"https://api.github.com/users/paregorios/following{/other_user}","gists_url":"https://api.github.com/users/paregorios/gists{/gist_id}","starred_url":"https://api.github.com/users/paregorios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paregorios/subscriptions","organizations_url":"https://api.github.com/users/paregorios/orgs","repos_url":"https://api.github.com/users/paregorios/repos","events_url":"https://api.github.com/users/paregorios/events{/privacy}","received_events_url":"https://api.github.com/users/paregorios/received_events","type":"User","site_admin":false},"labels":[{"id":912798629,"node_id":"MDU6TGFiZWw5MTI3OTg2Mjk=","url":"https://api.github.com/repos/isawnyu/isaw.web/labels/WCAG%20A","name":"WCAG A","color":"b60205","default":false},{"id":388923467,"node_id":"MDU6TGFiZWwzODg5MjM0Njc=","url":"https://api.github.com/repos/isawnyu/isaw.web/labels/deploy","name":"deploy","color":"1d76db","default":false},{"id":247087785,"node_id":"MDU6TGFiZWwyNDcwODc3ODU=","url":"https://api.github.com/repos/isawnyu/isaw.web/labels/high%20priority","name":"high priority","color":"eb6420","default":false},{"id":850693849,"node_id":"MDU6TGFiZWw4NTA2OTM4NDk=","url":"https://api.github.com/repos/isawnyu/isaw.web/labels/requirement","name":"requirement","color":"22ad81","default":false}],"state":"open","locked":false,"assignee":{"login":"cguardia","id":324415,"node_id":"MDQ6VXNlcjMyNDQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/324415?v=4","gravatar_id":"","url":"https://api.github.com/users/cguardia","html_url":"https://github.com/cguardia","followers_url":"https://api.github.com/users/cguardia/followers","following_url":"https://api.github.com/users/cguardia/following{/other_user}","gists_url":"https://api.github.com/users/cguardia/gists{/gist_id}","starred_url":"https://api.github.com/users/cguardia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguardia/subscriptions","organizations_url":"https://api.github.com/users/cguardia/orgs","repos_url":"https://api.github.com/users/cguardia/repos","events_url":"https://api.github.com/users/cguardia/events{/privacy}","received_events_url":"https://api.github.com/users/cguardia/received_events","type":"User","site_admin":false},"assignees":[{"login":"cguardia","id":324415,"node_id":"MDQ6VXNlcjMyNDQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/324415?v=4","gravatar_id":"","url":"https://api.github.com/users/cguardia","html_url":"https://github.com/cguardia","followers_url":"https://api.github.com/users/cguardia/followers","following_url":"https://api.github.com/users/cguardia/following{/other_user}","gists_url":"https://api.github.com/users/cguardia/gists{/gist_id}","starred_url":"https://api.github.com/users/cguardia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguardia/subscriptions","organizations_url":"https://api.github.com/users/cguardia/orgs","repos_url":"https://api.github.com/users/cguardia/repos","events_url":"https://api.github.com/users/cguardia/events{/privacy}","received_events_url":"https://api.github.com/users/cguardia/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/isawnyu/isaw.web/milestones/14","html_url":"https://github.com/isawnyu/isaw.web/milestone/14","labels_url":"https://api.github.com/repos/isawnyu/isaw.web/milestones/14/labels","id":3601273,"node_id":"MDk6TWlsZXN0b25lMzYwMTI3Mw==","number":14,"title":"Autumn 2018","description":"Accessibility and usability improvements, fall 2018.","creator":{"login":"paregorios","id":263285,"node_id":"MDQ6VXNlcjI2MzI4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/263285?v=4","gravatar_id":"","url":"https://api.github.com/users/paregorios","html_url":"https://github.com/paregorios","followers_url":"https://api.github.com/users/paregorios/followers","following_url":"https://api.github.com/users/paregorios/following{/other_user}","gists_url":"https://api.github.com/users/paregorios/gists{/gist_id}","starred_url":"https://api.github.com/users/paregorios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paregorios/subscriptions","organizations_url":"https://api.github.com/users/paregorios/orgs","repos_url":"https://api.github.com/users/paregorios/repos","events_url":"https://api.github.com/users/paregorios/events{/privacy}","received_events_url":"https://api.github.com/users/paregorios/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":56,"state":"open","created_at":"2018-08-27T15:24:08Z","updated_at":"2018-10-22T16:27:27Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-10-02T19:14:00Z","updated_at":"2018-10-24T23:32:25Z","closed_at":null,"author_association":"MEMBER","body":"At present, the \"events listing\" creates a link around the event title for each listed event. When there is a lead image associated with an event, it creates a separate link around the image. Like this:\r\n\r\n```html\r\n<div class=\"event-result-detail\">\r\n    <a href=\"http://isaw.nyu.edu/events/object-history\">\r\n        <img src=\"http://isaw.nyu.edu/events/object-history/leadImage_mini\" alt=\"\">\r\n    </a>\r\n    <a href=\"http://isaw.nyu.edu/events/object-history\">\r\n        <h3 class=\"event-title\">Exhibition Gallery Talk: Object Histories</h3>\r\n    </a>\r\n     ᠁\r\n</div>\r\n```\r\n\r\nRedundant links like this are a WCAG violation. As in other templates we've revised for accessibility, we need one and only one link to each event, so something like this would be ideal:\r\n\r\n```html\r\n<div class=\"event-result-detail\">\r\n    <a href=\"http://isaw.nyu.edu/events/object-history\">\r\n        <img src=\"http://isaw.nyu.edu/events/object-history/leadImage_mini\" alt=\"\">\r\n        <h3 class=\"event-title\">Exhibition Gallery Talk: Object Histories</h3>\r\n    </a>\r\n     ᠁\r\n</div>\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/isawnyu/isaw.web/issues/comments/432862716","html_url":"https://github.com/isawnyu/isaw.web/issues/342#issuecomment-432862716","issue_url":"https://api.github.com/repos/isawnyu/isaw.web/issues/342","id":432862716,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjg2MjcxNg==","user":{"login":"cguardia","id":324415,"node_id":"MDQ6VXNlcjMyNDQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/324415?v=4","gravatar_id":"","url":"https://api.github.com/users/cguardia","html_url":"https://github.com/cguardia","followers_url":"https://api.github.com/users/cguardia/followers","following_url":"https://api.github.com/users/cguardia/following{/other_user}","gists_url":"https://api.github.com/users/cguardia/gists{/gist_id}","starred_url":"https://api.github.com/users/cguardia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cguardia/subscriptions","organizations_url":"https://api.github.com/users/cguardia/orgs","repos_url":"https://api.github.com/users/cguardia/repos","events_url":"https://api.github.com/users/cguardia/events{/privacy}","received_events_url":"https://api.github.com/users/cguardia/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T23:32:25Z","updated_at":"2018-10-24T23:32:25Z","author_association":"NONE","body":"Merged to master."}}
{"actor":{"display_login":"cguardia"}}