{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4309","repository_url":"https://api.github.com/repos/FreeRDP/FreeRDP","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4309/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4309/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4309/events","html_url":"https://github.com/FreeRDP/FreeRDP/issues/4309","id":280937742,"node_id":"MDU6SXNzdWUyODA5Mzc3NDI=","number":4309,"title":"[RDPEI] Implement AAC and MP3 encoders","user":{"login":"akallabeth","id":3472254,"node_id":"MDQ6VXNlcjM0NzIyNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3472254?v=4","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"labels":[{"id":162926,"node_id":"MDU6TGFiZWwxNjI5MjY=","url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels/feature","name":"feature","color":"d7e102","default":false},{"id":204739,"node_id":"MDU6TGFiZWwyMDQ3Mzk=","url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels/fixed-waiting-test","name":"fixed-waiting-test","color":"ff6600","default":false},{"id":768884237,"node_id":"MDU6TGFiZWw3Njg4ODQyMzc=","url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels/help-wanted","name":"help-wanted","color":"80f798","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones/10","html_url":"https://github.com/FreeRDP/FreeRDP/milestone/10","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones/10/labels","id":3262235,"node_id":"MDk6TWlsZXN0b25lMzI2MjIzNQ==","number":10,"title":"2.0.0","description":"2.0.0 release","creator":{"login":"bmiklautz","id":195793,"node_id":"MDQ6VXNlcjE5NTc5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/195793?v=4","gravatar_id":"","url":"https://api.github.com/users/bmiklautz","html_url":"https://github.com/bmiklautz","followers_url":"https://api.github.com/users/bmiklautz/followers","following_url":"https://api.github.com/users/bmiklautz/following{/other_user}","gists_url":"https://api.github.com/users/bmiklautz/gists{/gist_id}","starred_url":"https://api.github.com/users/bmiklautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmiklautz/subscriptions","organizations_url":"https://api.github.com/users/bmiklautz/orgs","repos_url":"https://api.github.com/users/bmiklautz/repos","events_url":"https://api.github.com/users/bmiklautz/events{/privacy}","received_events_url":"https://api.github.com/users/bmiklautz/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":38,"state":"open","created_at":"2018-04-12T14:01:12Z","updated_at":"2018-09-05T07:00:55Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2017-12-11T08:52:47Z","updated_at":"2018-09-05T08:39:29Z","closed_at":"2018-08-23T14:48:33Z","author_association":"MEMBER","body":"Like #4165 but for microphone redirection improved format support is desired.\r\n"},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/418648298","html_url":"https://github.com/FreeRDP/FreeRDP/issues/4309#issuecomment-418648298","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4309","id":418648298,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY0ODI5OA==","user":{"login":"stilyan","id":18006122,"node_id":"MDQ6VXNlcjE4MDA2MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/18006122?v=4","gravatar_id":"","url":"https://api.github.com/users/stilyan","html_url":"https://github.com/stilyan","followers_url":"https://api.github.com/users/stilyan/followers","following_url":"https://api.github.com/users/stilyan/following{/other_user}","gists_url":"https://api.github.com/users/stilyan/gists{/gist_id}","starred_url":"https://api.github.com/users/stilyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stilyan/subscriptions","organizations_url":"https://api.github.com/users/stilyan/orgs","repos_url":"https://api.github.com/users/stilyan/repos","events_url":"https://api.github.com/users/stilyan/events{/privacy}","received_events_url":"https://api.github.com/users/stilyan/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T08:39:29Z","updated_at":"2018-09-05T08:39:29Z","author_association":"NONE","body":"@akallabeth \r\nThanks. Installation path is default, yes, /usr/local.\r\nI did remove the ffmpeg libs that were system packages.\r\nDuring configuration I see the following:\r\n`\r\n-- Finding recommended feature FFmpeg for multimedia (multimedia redirection, audio and video playback)\r\n--     Disable feature FFmpeg using \"-DWITH_FFMPEG=OFF\"\r\n-- Checking for module 'libavcodec'\r\n--   Found libavcodec, version 58.27.101\r\n-- Checking for module 'libavutil'\r\n--   Found libavutil, version 56.19.100\r\n-- Checking for module 'libavresample'\r\n--   Found libavresample, version 4.0.0\r\n-- Found FFmpeg: TRUE\r\n`\r\n\r\nSo at this point it acknowledges libavcodec is found and is 58.27.101\r\n\r\nAfterwards I see the following:\r\n`\r\n-- Looking for LIBAVCODEC_VERSION_MAJOR\r\n-- Looking for LIBAVCODEC_VERSION_MAJOR - found\r\n-- Looking for LIBAVCODEC_VERSION_MINOR\r\n-- Looking for LIBAVCODEC_VERSION_MINOR - found\r\n-- Looking for LIBAVCODEC_VERSION_MICRO\r\n-- Looking for LIBAVCODEC_VERSION_MICRO - found\r\nFFmpeg version detected .. is too old. (Require at least 57.48.101 for sound). Deactivating\r\n`\r\n\r\nLooking at CMakeCache.txt I see correct paths:\r\nAVCODEC_INCLUDE_DIR:PATH=/usr/local/include\r\nAVCODEC_LIBRARY:FILEPATH=/usr/local/lib/libavcodec.a\r\n\r\nLooking at the message I find this part disturbing - \".. is too old\"\r\nIt doesn't actually show the version it detects, and from what I see in CMakeLists.txt it should do it.\r\n\r\n`\r\ncheck_symbol_exists(LIBAVCODEC_VERSION_MAJOR \"libavcodec/version.h\" AVCODEC_VERSION_MAJOR)\r\n        check_symbol_exists(LIBAVCODEC_VERSION_MINOR \"libavcodec/version.h\" AVCODEC_VERSION_MINOR)\r\n        check_symbol_exists(LIBAVCODEC_VERSION_MICRO \"libavcodec/version.h\" AVCODEC_VERSION_MICRO)\r\n        if (AVCODEC_VERSION_MAJOR LESS 57 OR AVCODEC_VERSION_MINOR LESS 48 OR AVCODEC_VERSION_MICRO LESS 101)\r\n                message(\"FFmpeg version detected ${}.${}.${} is too old. (Require at least 57.48.101 for sound). Deactivating\")\r\n                set(WITH_DSP_FFMPEG OFF)\r\n        endif()\r\n`\r\n\r\nI really don't know how to get around this except for deleting this validation or changing flag to ON in buildflags.h and trying like that.\r\nAdvices?"}}
{"actor":{"display_login":"stilyan"}}