{"action":"created","issue":{"url":"https://api.github.com/repos/ACINQ/eclair/issues/608","repository_url":"https://api.github.com/repos/ACINQ/eclair","labels_url":"https://api.github.com/repos/ACINQ/eclair/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/ACINQ/eclair/issues/608/comments","events_url":"https://api.github.com/repos/ACINQ/eclair/issues/608/events","html_url":"https://github.com/ACINQ/eclair/pull/608","id":326082278,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMjU4ODU0","number":608,"title":"Set a minimum feerate-per-kw of 253 (fixes #602)","user":{"login":"sstone","id":1573866,"node_id":"MDQ6VXNlcjE1NzM4NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1573866?v=4","gravatar_id":"","url":"https://api.github.com/users/sstone","html_url":"https://github.com/sstone","followers_url":"https://api.github.com/users/sstone/followers","following_url":"https://api.github.com/users/sstone/following{/other_user}","gists_url":"https://api.github.com/users/sstone/gists{/gist_id}","starred_url":"https://api.github.com/users/sstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstone/subscriptions","organizations_url":"https://api.github.com/users/sstone/orgs","repos_url":"https://api.github.com/users/sstone/repos","events_url":"https://api.github.com/users/sstone/events{/privacy}","received_events_url":"https://api.github.com/users/sstone/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-24T11:38:49Z","updated_at":"2018-06-07T17:15:34Z","closed_at":"2018-05-30T11:38:41Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ACINQ/eclair/pulls/608","html_url":"https://github.com/ACINQ/eclair/pull/608","diff_url":"https://github.com/ACINQ/eclair/pull/608.diff","patch_url":"https://github.com/ACINQ/eclair/pull/608.patch"},"body":"We currently use feerate-per-kw = feerate-per-kb / 4, which gives 250 for 1000 sat/kb, which can result in transactions that are below the minimum relay fee of 1000 sat/kb.\r\nThis is because bitcoin core checks minimum relay fees using a transaction's virtual size (and not its actual size in bytes).\r\nSo we want :\r\n    fee > 1000 * virtual size\r\n    feerate-per-kw * weight > 1000 * (3 * weight / 4)\r\n    feerate_per-kw > 250 + 3000 / (4 * weight)\r\n    \r\nWith a conservative minimum weight of 400, we get a minimum feerate_per-kw of 253\r\n"},"comment":{"url":"https://api.github.com/repos/ACINQ/eclair/issues/comments/395497770","html_url":"https://github.com/ACINQ/eclair/pull/608#issuecomment-395497770","issue_url":"https://api.github.com/repos/ACINQ/eclair/issues/608","id":395497770,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTQ5Nzc3MA==","user":{"login":"mautematico","id":1238928,"node_id":"MDQ6VXNlcjEyMzg5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1238928?v=4","gravatar_id":"","url":"https://api.github.com/users/mautematico","html_url":"https://github.com/mautematico","followers_url":"https://api.github.com/users/mautematico/followers","following_url":"https://api.github.com/users/mautematico/following{/other_user}","gists_url":"https://api.github.com/users/mautematico/gists{/gist_id}","starred_url":"https://api.github.com/users/mautematico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautematico/subscriptions","organizations_url":"https://api.github.com/users/mautematico/orgs","repos_url":"https://api.github.com/users/mautematico/repos","events_url":"https://api.github.com/users/mautematico/events{/privacy}","received_events_url":"https://api.github.com/users/mautematico/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T17:15:34Z","updated_at":"2018-06-07T17:15:34Z","author_association":"NONE","body":"Hmm..\r\n\r\nafter this PR, I was unable to `open pubkey amount 0 1`; only after amount+253=total satoshi amount.\r\n\r\nBut again, this tx has a vBsize of 145, so 145 satoshi would be enough to realy it.\r\n\r\n020000000001013661f724efc02582472949e1ce2159ddc49a123d738d083e70ee3952cd41b83900000000171600146c13b99bceb8d6a002e9e6001daa15b0b3257cf9ffffffff018395980000000000220020f56eb1a172556f1efc7744f668952dc1ec42fdf81832d06005797b15d18eac670247304402203e34263e374d037d2a878e199b694b2078f728280c5c18761b9995431963cf5102204a8ac10501d4d5c1f3fa4222e0f547028d349184d4392ca545558574d7af089d012102f1907e2523daa9853c51c0bbd27eb8511dcc744ff387be33c007c02eaf0a832000000000\r\n\r\n\r\nSo I think there is something wrong with calculation at some point.\r\n\r\n\r\nBtw, if the whole issue is the wawy bitcoind checks fees, why don't we do the same (i.e. calculate fees in sat/vbyte)?"}}
{"actor":{"display_login":"mautematico"}}