{"action":"created","issue":{"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1125","repository_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth","labels_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1125/labels{/name}","comments_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1125/comments","events_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1125/events","html_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1125","id":308222453,"number":1125,"title":"Add rubocop","user":{"login":"Evan-M","id":395274,"avatar_url":"https://avatars2.githubusercontent.com/u/395274?v=4","gravatar_id":"","url":"https://api.github.com/users/Evan-M","html_url":"https://github.com/Evan-M","followers_url":"https://api.github.com/users/Evan-M/followers","following_url":"https://api.github.com/users/Evan-M/following{/other_user}","gists_url":"https://api.github.com/users/Evan-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Evan-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evan-M/subscriptions","organizations_url":"https://api.github.com/users/Evan-M/orgs","repos_url":"https://api.github.com/users/Evan-M/repos","events_url":"https://api.github.com/users/Evan-M/events{/privacy}","received_events_url":"https://api.github.com/users/Evan-M/received_events","type":"User","site_admin":false},"labels":[{"id":110441113,"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":821604155,"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/labels/on%20hold","name":"on hold","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-24T02:32:48Z","updated_at":"2018-04-28T17:08:25Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/pulls/1125","html_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1125","diff_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1125.diff","patch_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1125.patch"},"body":"Taking a stab at adding `rubocop` to the repo, as suggested in #1124 \r\n\r\nI've already addressed some of the simpler Cops that can utilize the `--auto-correct` option.\r\n\r\nEach correction for a given cop was made in a separate commit, so to make reviewing easier (I hope).\r\n\r\nThe flow I've used was as follows:\r\n  1) Pick a Cop / set of violations in the `.rubocop_todo.yml`\r\n  2) Create a local branch with the Cop name\r\n  3) Make 1 or more updates to code, or move a todo item into the main `.rubocop.yml` config.\r\n  4) Merge the Cop branch back onto the `add_rubocop` branch with the `--no-ff` option.\r\n\r\nThis PR gets the offenses down to 652, but there is still more work to do!"},"comment":{"url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/comments/385191236","html_url":"https://github.com/lynndylanhurley/devise_token_auth/pull/1125#issuecomment-385191236","issue_url":"https://api.github.com/repos/lynndylanhurley/devise_token_auth/issues/1125","id":385191236,"user":{"login":"Evan-M","id":395274,"avatar_url":"https://avatars2.githubusercontent.com/u/395274?v=4","gravatar_id":"","url":"https://api.github.com/users/Evan-M","html_url":"https://github.com/Evan-M","followers_url":"https://api.github.com/users/Evan-M/followers","following_url":"https://api.github.com/users/Evan-M/following{/other_user}","gists_url":"https://api.github.com/users/Evan-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Evan-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evan-M/subscriptions","organizations_url":"https://api.github.com/users/Evan-M/orgs","repos_url":"https://api.github.com/users/Evan-M/repos","events_url":"https://api.github.com/users/Evan-M/events{/privacy}","received_events_url":"https://api.github.com/users/Evan-M/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T17:08:25Z","updated_at":"2018-04-28T17:08:25Z","author_association":"COLLABORATOR","body":"That happens when there are no inherited settings to merge with from an\r\nincluded file (in this case, there are no `Excludes` for the\r\n`Metrics/BlockLength` nor the\r\n`Metrics/LineLength` cops inherited from `.rubocop_todo.yml`).\r\n\r\nIf you comment out the `inherit_from: .rubocop_todo.yml` at the top of the\r\n`.rubocop.yml` file, you will see more warnings where there is nothing to\r\nmerge."}}
{"actor":{"display_login":"Evan-M"}}