{"action":"closed","number":145,"pull_request":{"url":"https://api.github.com/repos/graphql-rust/juniper/pulls/145","id":169854814,"html_url":"https://github.com/graphql-rust/juniper/pull/145","diff_url":"https://github.com/graphql-rust/juniper/pull/145.diff","patch_url":"https://github.com/graphql-rust/juniper/pull/145.patch","issue_url":"https://api.github.com/repos/graphql-rust/juniper/issues/145","number":145,"state":"closed","locked":false,"title":"Fix merging parallel inline fragments","user":{"login":"carlosdp","id":198739,"avatar_url":"https://avatars2.githubusercontent.com/u/198739?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosdp","html_url":"https://github.com/carlosdp","followers_url":"https://api.github.com/users/carlosdp/followers","following_url":"https://api.github.com/users/carlosdp/following{/other_user}","gists_url":"https://api.github.com/users/carlosdp/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosdp/subscriptions","organizations_url":"https://api.github.com/users/carlosdp/orgs","repos_url":"https://api.github.com/users/carlosdp/repos","events_url":"https://api.github.com/users/carlosdp/events{/privacy}","received_events_url":"https://api.github.com/users/carlosdp/received_events","type":"User","site_admin":false},"body":"Currently, this:\r\n\r\n```\r\nquery Query {\r\n user {\r\n   ... Fragment\r\n }\r\n}\r\n\r\nfragment Fragment {\r\n a\r\n ... on User {\r\n  b\r\n }\r\n}\r\n```\r\n\r\nreturns\r\n\r\n```\r\n{\r\n  \"user\": {\r\n    \"b\": <value>\r\n  }\r\n}\r\n```\r\n\r\noverriding the previous parallel fragment definition. This issue was fixed for pre-defined parallel fragments in https://github.com/graphql-rust/juniper/commit/c5552419780a8d4fccf5c34c5c24bc976829fd4e, the merge logic just hadn't been applied to inline fragments.\r\n\r\nThis adds that logic (a 1 line change) and adds a test.","created_at":"2018-02-18T22:44:08Z","updated_at":"2018-03-05T11:02:23Z","closed_at":"2018-03-05T11:02:23Z","merged_at":"2018-03-05T11:02:23Z","merge_commit_sha":"63d8a3d1a03a28b8b5665907e7c25993db3f48f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphql-rust/juniper/pulls/145/commits","review_comments_url":"https://api.github.com/repos/graphql-rust/juniper/pulls/145/comments","review_comment_url":"https://api.github.com/repos/graphql-rust/juniper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql-rust/juniper/issues/145/comments","statuses_url":"https://api.github.com/repos/graphql-rust/juniper/statuses/a6307fc7855de721558f17f84ca90797b8e92c5d","head":{"label":"carlosdp:fix-merging-parallel-inline-fragments","ref":"fix-merging-parallel-inline-fragments","sha":"a6307fc7855de721558f17f84ca90797b8e92c5d","user":{"login":"carlosdp","id":198739,"avatar_url":"https://avatars2.githubusercontent.com/u/198739?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosdp","html_url":"https://github.com/carlosdp","followers_url":"https://api.github.com/users/carlosdp/followers","following_url":"https://api.github.com/users/carlosdp/following{/other_user}","gists_url":"https://api.github.com/users/carlosdp/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosdp/subscriptions","organizations_url":"https://api.github.com/users/carlosdp/orgs","repos_url":"https://api.github.com/users/carlosdp/repos","events_url":"https://api.github.com/users/carlosdp/events{/privacy}","received_events_url":"https://api.github.com/users/carlosdp/received_events","type":"User","site_admin":false},"repo":{"id":118836678,"name":"juniper","full_name":"carlosdp/juniper","owner":{"login":"carlosdp","id":198739,"avatar_url":"https://avatars2.githubusercontent.com/u/198739?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosdp","html_url":"https://github.com/carlosdp","followers_url":"https://api.github.com/users/carlosdp/followers","following_url":"https://api.github.com/users/carlosdp/following{/other_user}","gists_url":"https://api.github.com/users/carlosdp/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosdp/subscriptions","organizations_url":"https://api.github.com/users/carlosdp/orgs","repos_url":"https://api.github.com/users/carlosdp/repos","events_url":"https://api.github.com/users/carlosdp/events{/privacy}","received_events_url":"https://api.github.com/users/carlosdp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosdp/juniper","description":"GraphQL server library for Rust","fork":true,"url":"https://api.github.com/repos/carlosdp/juniper","forks_url":"https://api.github.com/repos/carlosdp/juniper/forks","keys_url":"https://api.github.com/repos/carlosdp/juniper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosdp/juniper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosdp/juniper/teams","hooks_url":"https://api.github.com/repos/carlosdp/juniper/hooks","issue_events_url":"https://api.github.com/repos/carlosdp/juniper/issues/events{/number}","events_url":"https://api.github.com/repos/carlosdp/juniper/events","assignees_url":"https://api.github.com/repos/carlosdp/juniper/assignees{/user}","branches_url":"https://api.github.com/repos/carlosdp/juniper/branches{/branch}","tags_url":"https://api.github.com/repos/carlosdp/juniper/tags","blobs_url":"https://api.github.com/repos/carlosdp/juniper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosdp/juniper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosdp/juniper/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosdp/juniper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosdp/juniper/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosdp/juniper/languages","stargazers_url":"https://api.github.com/repos/carlosdp/juniper/stargazers","contributors_url":"https://api.github.com/repos/carlosdp/juniper/contributors","subscribers_url":"https://api.github.com/repos/carlosdp/juniper/subscribers","subscription_url":"https://api.github.com/repos/carlosdp/juniper/subscription","commits_url":"https://api.github.com/repos/carlosdp/juniper/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosdp/juniper/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosdp/juniper/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosdp/juniper/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosdp/juniper/contents/{+path}","compare_url":"https://api.github.com/repos/carlosdp/juniper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosdp/juniper/merges","archive_url":"https://api.github.com/repos/carlosdp/juniper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosdp/juniper/downloads","issues_url":"https://api.github.com/repos/carlosdp/juniper/issues{/number}","pulls_url":"https://api.github.com/repos/carlosdp/juniper/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosdp/juniper/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosdp/juniper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosdp/juniper/labels{/name}","releases_url":"https://api.github.com/repos/carlosdp/juniper/releases{/id}","deployments_url":"https://api.github.com/repos/carlosdp/juniper/deployments","created_at":"2018-01-24T23:46:47Z","updated_at":"2018-01-24T23:46:49Z","pushed_at":"2018-02-19T00:45:39Z","git_url":"git://github.com/carlosdp/juniper.git","ssh_url":"git@github.com:carlosdp/juniper.git","clone_url":"https://github.com/carlosdp/juniper.git","svn_url":"https://github.com/carlosdp/juniper","homepage":null,"size":895,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql-rust:master","ref":"master","sha":"47575ef922ec33d509a89d7b712a573d94d34b84","user":{"login":"graphql-rust","id":30779353,"avatar_url":"https://avatars1.githubusercontent.com/u/30779353?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-rust","html_url":"https://github.com/graphql-rust","followers_url":"https://api.github.com/users/graphql-rust/followers","following_url":"https://api.github.com/users/graphql-rust/following{/other_user}","gists_url":"https://api.github.com/users/graphql-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-rust/subscriptions","organizations_url":"https://api.github.com/users/graphql-rust/orgs","repos_url":"https://api.github.com/users/graphql-rust/repos","events_url":"https://api.github.com/users/graphql-rust/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-rust/received_events","type":"Organization","site_admin":false},"repo":{"id":67941656,"name":"juniper","full_name":"graphql-rust/juniper","owner":{"login":"graphql-rust","id":30779353,"avatar_url":"https://avatars1.githubusercontent.com/u/30779353?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-rust","html_url":"https://github.com/graphql-rust","followers_url":"https://api.github.com/users/graphql-rust/followers","following_url":"https://api.github.com/users/graphql-rust/following{/other_user}","gists_url":"https://api.github.com/users/graphql-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-rust/subscriptions","organizations_url":"https://api.github.com/users/graphql-rust/orgs","repos_url":"https://api.github.com/users/graphql-rust/repos","events_url":"https://api.github.com/users/graphql-rust/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-rust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql-rust/juniper","description":"GraphQL server library for Rust","fork":false,"url":"https://api.github.com/repos/graphql-rust/juniper","forks_url":"https://api.github.com/repos/graphql-rust/juniper/forks","keys_url":"https://api.github.com/repos/graphql-rust/juniper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql-rust/juniper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql-rust/juniper/teams","hooks_url":"https://api.github.com/repos/graphql-rust/juniper/hooks","issue_events_url":"https://api.github.com/repos/graphql-rust/juniper/issues/events{/number}","events_url":"https://api.github.com/repos/graphql-rust/juniper/events","assignees_url":"https://api.github.com/repos/graphql-rust/juniper/assignees{/user}","branches_url":"https://api.github.com/repos/graphql-rust/juniper/branches{/branch}","tags_url":"https://api.github.com/repos/graphql-rust/juniper/tags","blobs_url":"https://api.github.com/repos/graphql-rust/juniper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql-rust/juniper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql-rust/juniper/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql-rust/juniper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql-rust/juniper/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql-rust/juniper/languages","stargazers_url":"https://api.github.com/repos/graphql-rust/juniper/stargazers","contributors_url":"https://api.github.com/repos/graphql-rust/juniper/contributors","subscribers_url":"https://api.github.com/repos/graphql-rust/juniper/subscribers","subscription_url":"https://api.github.com/repos/graphql-rust/juniper/subscription","commits_url":"https://api.github.com/repos/graphql-rust/juniper/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql-rust/juniper/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql-rust/juniper/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql-rust/juniper/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql-rust/juniper/contents/{+path}","compare_url":"https://api.github.com/repos/graphql-rust/juniper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql-rust/juniper/merges","archive_url":"https://api.github.com/repos/graphql-rust/juniper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql-rust/juniper/downloads","issues_url":"https://api.github.com/repos/graphql-rust/juniper/issues{/number}","pulls_url":"https://api.github.com/repos/graphql-rust/juniper/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql-rust/juniper/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql-rust/juniper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql-rust/juniper/labels{/name}","releases_url":"https://api.github.com/repos/graphql-rust/juniper/releases{/id}","deployments_url":"https://api.github.com/repos/graphql-rust/juniper/deployments","created_at":"2016-09-11T16:43:19Z","updated_at":"2018-03-03T11:51:55Z","pushed_at":"2018-03-05T11:02:23Z","git_url":"git://github.com/graphql-rust/juniper.git","ssh_url":"git@github.com:graphql-rust/juniper.git","clone_url":"https://github.com/graphql-rust/juniper.git","svn_url":"https://github.com/graphql-rust/juniper","homepage":null,"size":892,"stargazers_count":613,"watchers_count":613,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":52,"open_issues":33,"watchers":613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql-rust/juniper/pulls/145"},"html":{"href":"https://github.com/graphql-rust/juniper/pull/145"},"issue":{"href":"https://api.github.com/repos/graphql-rust/juniper/issues/145"},"comments":{"href":"https://api.github.com/repos/graphql-rust/juniper/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql-rust/juniper/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql-rust/juniper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql-rust/juniper/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/graphql-rust/juniper/statuses/a6307fc7855de721558f17f84ca90797b8e92c5d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"theduke","id":241621,"avatar_url":"https://avatars1.githubusercontent.com/u/241621?v=4","gravatar_id":"","url":"https://api.github.com/users/theduke","html_url":"https://github.com/theduke","followers_url":"https://api.github.com/users/theduke/followers","following_url":"https://api.github.com/users/theduke/following{/other_user}","gists_url":"https://api.github.com/users/theduke/gists{/gist_id}","starred_url":"https://api.github.com/users/theduke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theduke/subscriptions","organizations_url":"https://api.github.com/users/theduke/orgs","repos_url":"https://api.github.com/users/theduke/repos","events_url":"https://api.github.com/users/theduke/events{/privacy}","received_events_url":"https://api.github.com/users/theduke/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":142,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"theduke"}}