{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/195975430","pull_request_review_id":129439884,"id":195975430,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk3NTQzMA==","diff_hunk":"@@ -11,7 +11,7 @@\n \n const userAgent = typeof navigator !== 'undefined' ? navigator.userAgent : \"\";\n \n-export const isIE = (userAgent.indexOf('Trident') >= 0);\n+export const isIE: boolean = (userAgent.indexOf('Trident') >= 0);","path":"packages/core/src/browser/browser.ts","position":5,"original_position":5,"commit_id":"32841259ff064938cedd22b8ee384cf52a7608d9","original_commit_id":"32841259ff064938cedd22b8ee384cf52a7608d9","user":{"login":"svenefftinge","id":372735,"node_id":"MDQ6VXNlcjM3MjczNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/372735?v=4","gravatar_id":"","url":"https://api.github.com/users/svenefftinge","html_url":"https://github.com/svenefftinge","followers_url":"https://api.github.com/users/svenefftinge/followers","following_url":"https://api.github.com/users/svenefftinge/following{/other_user}","gists_url":"https://api.github.com/users/svenefftinge/gists{/gist_id}","starred_url":"https://api.github.com/users/svenefftinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenefftinge/subscriptions","organizations_url":"https://api.github.com/users/svenefftinge/orgs","repos_url":"https://api.github.com/users/svenefftinge/repos","events_url":"https://api.github.com/users/svenefftinge/events{/privacy}","received_events_url":"https://api.github.com/users/svenefftinge/received_events","type":"User","site_admin":false},"body":"Why adding the type here explicitly?","created_at":"2018-06-18T06:39:35Z","updated_at":"2018-06-18T07:00:40Z","html_url":"https://github.com/theia-ide/theia/pull/2118#discussion_r195975430","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/2118","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/195975430"},"html":{"href":"https://github.com/theia-ide/theia/pull/2118#discussion_r195975430"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2118"}}},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/2118","id":195288235,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mjg4MjM1","html_url":"https://github.com/theia-ide/theia/pull/2118","diff_url":"https://github.com/theia-ide/theia/pull/2118.diff","patch_url":"https://github.com/theia-ide/theia/pull/2118.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/2118","number":2118,"state":"open","locked":false,"title":"wip: [monaco-textmate] Added new Syntax Coloring","user":{"login":"marechal-p","id":14182238,"node_id":"MDQ6VXNlcjE0MTgyMjM4","avatar_url":"https://avatars0.githubusercontent.com/u/14182238?v=4","gravatar_id":"","url":"https://api.github.com/users/marechal-p","html_url":"https://github.com/marechal-p","followers_url":"https://api.github.com/users/marechal-p/followers","following_url":"https://api.github.com/users/marechal-p/following{/other_user}","gists_url":"https://api.github.com/users/marechal-p/gists{/gist_id}","starred_url":"https://api.github.com/users/marechal-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marechal-p/subscriptions","organizations_url":"https://api.github.com/users/marechal-p/orgs","repos_url":"https://api.github.com/users/marechal-p/repos","events_url":"https://api.github.com/users/marechal-p/events{/privacy}","received_events_url":"https://api.github.com/users/marechal-p/received_events","type":"User","site_admin":false},"body":"Converted the weird singleton ThemeService to an actual singleton instance managed by inversify.\r\nGood thing is: Now it can be injected with other component, and is better integrated with the rest.\r\nBad thing is: It might not be as fast as before on startup, but the lag is negligeable\r\n   (maybe this will be the opportunity to design a faster pre-init sequence)\r\n\r\nThemeService now also depends on `ThemeProvider`s to provide themes.\r\nIt is asynchronous so that we can load themes from disk in the future.\r\n\r\nThe monaco extension also relies on `MonacoThemeProvider`s now to fetch themes for the `monaco-editor`.\r\nBecause themes work in three steps:\r\n 1. We define a theme for Theia's UI, and we provide the editor theme as a string id.\r\n 2. We apply the editor theme based on the string id.\r\n 3. We trigger the `activate` and `deactivate` callbacks.\r\nThe changes made in monaco are meant to provide the themes assiociated with the id.\r\n\r\nNew extension: `monaco-textmate`, that provides the logic requires for Textmate to work in monaco.\r\nIt also specifies new themes, both for Theia and for the `monaco-editor`.\r\n`monaco-textmate` also wires the Textmate token provider for monaco and the different grammars to parse the source files.\r\n\r\nSigned-off-by: Patrick-Jeffrey Pollo Guilbert <patrick.pollo.guilbert@ericsson.com>\r\nSigned-off-by: Paul Maréchal <paul.marechal@ericsson.com>\r\n\r\n---\r\n\r\nThis PR is a Work In Progress, I pushed this so that I can get feedback on the layout of the feature, knowing I had a few goals in mind:\r\n- Integrate the new Textmate themes with the current theme system\r\n- Allow anyone to register and provide themes, be it for Theia or for Monaco.\r\n\r\nCurrent problems:\r\n1. Textmate token provider is set no matter what, even if it doesn't play well with the default themes from the `monaco-editor` _(I planned on using the `activate` and `deactivate` methods maybe to use or not a token provider, not sure if it's such a great idea yet)._\r\n2. Themes are not working correctly at all on Electron.","created_at":"2018-06-15T21:36:04Z","updated_at":"2018-06-18T07:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c7ae298d41ec534352afc8ee2c9687578bbea00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/2118/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/2118/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/2118/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/32841259ff064938cedd22b8ee384cf52a7608d9","head":{"label":"theia-ide:mp/monaco-textmate-wip","ref":"mp/monaco-textmate-wip","sha":"32841259ff064938cedd22b8ee384cf52a7608d9","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-06-18T06:40:15Z","pushed_at":"2018-06-18T06:51:26Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":121121,"stargazers_count":846,"watchers_count":846,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":462,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":462,"watchers":846,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"7b3e012262bda4968ef43a2b8a39880826e91e6d","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-06-18T06:40:15Z","pushed_at":"2018-06-18T06:51:26Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":121121,"stargazers_count":846,"watchers_count":846,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":462,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":462,"watchers":846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2118"},"html":{"href":"https://github.com/theia-ide/theia/pull/2118"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/2118"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/2118/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2118/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2118/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/32841259ff064938cedd22b8ee384cf52a7608d9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"svenefftinge"}}