{"action":"created","issue":{"url":"https://api.github.com/repos/ncclient/ncclient/issues/265","repository_url":"https://api.github.com/repos/ncclient/ncclient","labels_url":"https://api.github.com/repos/ncclient/ncclient/issues/265/labels{/name}","comments_url":"https://api.github.com/repos/ncclient/ncclient/issues/265/comments","events_url":"https://api.github.com/repos/ncclient/ncclient/issues/265/events","html_url":"https://github.com/ncclient/ncclient/issues/265","id":351588404,"node_id":"MDU6SXNzdWUzNTE1ODg0MDQ=","number":265,"title":"per-byte debugging in _parse11 is excessive","user":{"login":"glennmatthews","id":5603551,"node_id":"MDQ6VXNlcjU2MDM1NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5603551?v=4","gravatar_id":"","url":"https://api.github.com/users/glennmatthews","html_url":"https://github.com/glennmatthews","followers_url":"https://api.github.com/users/glennmatthews/followers","following_url":"https://api.github.com/users/glennmatthews/following{/other_user}","gists_url":"https://api.github.com/users/glennmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/glennmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennmatthews/subscriptions","organizations_url":"https://api.github.com/users/glennmatthews/orgs","repos_url":"https://api.github.com/users/glennmatthews/repos","events_url":"https://api.github.com/users/glennmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/glennmatthews/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-17T13:10:43Z","updated_at":"2018-08-17T13:14:28Z","closed_at":null,"author_association":"NONE","body":"Reading ncclient's debug logs with NETCONF 1.1 is difficult because of the excessive verbosity of logging literally each single byte read from the session:\r\n\r\n```\r\n   ncclient.transport.session: DEBUG: <SSHSession(session, initial daemon)> created: client_capabilities=<dict_keyiterator object at 0x10bed21d8>\r\n   ncclient.transport.ssh: DEBUG: parsing netconf v1.1\r\n   ncclient.transport.ssh: DEBUG: x: b'\\n'\r\n   ncclient.transport.ssh: DEBUG: x: b'#'\r\n   ncclient.transport.ssh: DEBUG: x: b'3'\r\n   ncclient.transport.ssh: DEBUG: x: b'0'\r\n   ncclient.transport.ssh: DEBUG: x: b'\\n'\r\n   ncclient.transport.ssh: DEBUG: response length: 30\r\n   ncclient.transport.ssh: DEBUG: x: b'<'\r\n   ncclient.transport.ssh: DEBUG: x: b'r'\r\n   ncclient.transport.ssh: DEBUG: x: b'p'\r\n   ncclient.transport.ssh: DEBUG: x: b'c'\r\n   ncclient.transport.ssh: DEBUG: x: b'-'\r\n   ncclient.transport.ssh: DEBUG: x: b'r'\r\n   ncclient.transport.ssh: DEBUG: x: b'e'\r\n   ncclient.transport.ssh: DEBUG: x: b'p'\r\n   ncclient.transport.ssh: DEBUG: x: b'l'\r\n   ncclient.transport.ssh: DEBUG: x: b'y'\r\n   ncclient.transport.ssh: DEBUG: x: b' '\r\n   ncclient.transport.ssh: DEBUG: x: b'x'\r\n   ncclient.transport.ssh: DEBUG: x: b'm'\r\n   ncclient.transport.ssh: DEBUG: x: b'l'\r\n   ncclient.transport.ssh: DEBUG: x: b'n'\r\n   ncclient.transport.ssh: DEBUG: x: b's'\r\n   ncclient.transport.ssh: DEBUG: x: b':'\r\n   ncclient.transport.ssh: DEBUG: x: b'j'\r\n   ...\r\n```\r\n\r\nCan we remove the following line, or at least provide an option to disable it while keeping the other debug-level logs available?\r\n\r\n```diff\r\n        while True:\r\n            x = buf.read(1)\r\n            if not x:\r\n                logger.debug('No more data to read')\r\n                # Store the current chunk to the message list\r\n                chunk = b''.join(chunk_list)\r\n                message_list.append(textify(chunk))\r\n                break # done reading\r\n-           logger.debug('x: %s', x)\r\n            if state == idle:\r\n                if x == b'\\n':\r\n                    state = instart\r\n                    inendpos = 1\r\n```"},"comment":{"url":"https://api.github.com/repos/ncclient/ncclient/issues/comments/413861658","html_url":"https://github.com/ncclient/ncclient/issues/265#issuecomment-413861658","issue_url":"https://api.github.com/repos/ncclient/ncclient/issues/265","id":413861658,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzg2MTY1OA==","user":{"login":"glennmatthews","id":5603551,"node_id":"MDQ6VXNlcjU2MDM1NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5603551?v=4","gravatar_id":"","url":"https://api.github.com/users/glennmatthews","html_url":"https://github.com/glennmatthews","followers_url":"https://api.github.com/users/glennmatthews/followers","following_url":"https://api.github.com/users/glennmatthews/following{/other_user}","gists_url":"https://api.github.com/users/glennmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/glennmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennmatthews/subscriptions","organizations_url":"https://api.github.com/users/glennmatthews/orgs","repos_url":"https://api.github.com/users/glennmatthews/repos","events_url":"https://api.github.com/users/glennmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/glennmatthews/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T13:14:28Z","updated_at":"2018-08-17T13:14:28Z","author_association":"NONE","body":"Ah, I see #260 includes this change. Thanks!"}}
{"actor":{"display_login":"glennmatthews"}}