{"action":"created","comment":{"url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/comments/201790948","pull_request_review_id":136359063,"id":201790948,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc5MDk0OA==","diff_hunk":"@@ -129,61 +129,31 @@ \\subsection{Image viewer}\n \n \\assign{Trey}\n \n-As of 2018-06-12 we haven't converged on a solid recommendation here.\n+There are two approaches to doing image visualization.  When a developer is working on a laptop with a\n+small amount of data and viewing image results locally then DS9 or an equivilent desktop application seems\n+to be the best solution.\n \n-Key considerations:\n+In the case where the data is on some remote server then visualization needs to\n+be more advanced. Here we recommend using Firefly web based image visulization. A large Firefly server(s) near the\n+data will allow quicker and simpler visualization. The data is not required to be moved to the laptop to visualize.\n \n+To be effective for QA Firefly should have the following functionallity:\n \\begin{itemize}\n-\n-  \\item{Firefly is the annointed solution being provided by DM to external\n-  stakeholders (commissioning, operations, etc). It feels right to everybody\n-  that we should be dogfooding it, and also benefitting from development being\n-  carried out for those stakeholders.}\n-\n-  \\item{Currently, Firefly is unappealing to developers (primarily, I think,\n-  because of slowness of user interface, and perhaps also due to installation\n-  issues). Can we resolve these issues?}\n-\n-  \\item{We'd want to support visualization in a number of different\n-  environments, for e.g.:\n-\n-    \\begin{itemize}\n-\n-      \\item{Inside a Jupyter notebook;}\n-      \\item{As a standalone tool, \\`a la DS9;}\n-      \\item{Embedded in a \\gls{dashboard}, \\`a la JS9, Aladin-Lite, etc.}\n-\n-    \\end{itemize}\n-  }\n-\n-  \\item{Do we lose flexibility by mandating the use of a backend-agnostic API\n-  (\\texttt{afwDisplay}) rather than going ``all-in'' on e.g. a custom Firefly\n-  interface?}\n-\n-  \\item{We'll need to do full focal plane visualization, which none(?) of the\n-  current tools support well.}\n-\n+  \\item{Work as a standalone tool. }\n+  \\item{Work with the afw.display API.}\n+  \\item{Provide an API that allows a user to acess more advanced features than afw.display provides.\n+  Possibly afw.display API should be enhanced in certain cases.}\n+  \\item{Work as an extension in Jupyter Lab. For example- click on a FITS file and see it show in Firefly.}\n+  \\item{Work as a Jupyter Lab widget.}\n+  \\item{Provide a way to show tabular data on images.}\n+  \\item{Provide HiPS viewing.}\n+  \\item{Work with all major QA use cases and ensure good performance.}\n+  \\item{Implement full focal plane visualization.}\n+  \\item\n \\end{itemize}\n \n-Options include:\n-\n-\\begin{itemize}\n-\n-  \\item{Do nothing; continue as we are, which means most people will use DS9\n-  and a few will drift to Firefly as commissioning ramps up.}\n-\n-  \\item{Issue some sort of edict that pipelines developers have to use\n-  Firefly.}\n-\n-  \\item{Encourage the use of some other tool (Ginga?) instead of or as well as\n-  some of the above.}\n-\n-  \\item{Probably others.}\n-\n-\\end{itemize}\n+What else do we want here?","path":"DMTN-085.tex","position":74,"original_position":74,"commit_id":"9a0806ee3c3ca9d4831efb7c6df49c782014a4b8","original_commit_id":"9a0806ee3c3ca9d4831efb7c6df49c782014a4b8","user":{"login":"xiuqin","id":10054353,"node_id":"MDQ6VXNlcjEwMDU0MzUz","avatar_url":"https://avatars0.githubusercontent.com/u/10054353?v=4","gravatar_id":"","url":"https://api.github.com/users/xiuqin","html_url":"https://github.com/xiuqin","followers_url":"https://api.github.com/users/xiuqin/followers","following_url":"https://api.github.com/users/xiuqin/following{/other_user}","gists_url":"https://api.github.com/users/xiuqin/gists{/gist_id}","starred_url":"https://api.github.com/users/xiuqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiuqin/subscriptions","organizations_url":"https://api.github.com/users/xiuqin/orgs","repos_url":"https://api.github.com/users/xiuqin/repos","events_url":"https://api.github.com/users/xiuqin/events{/privacy}","received_events_url":"https://api.github.com/users/xiuqin/received_events","type":"User","site_admin":false},"body":"To help users gaining experience in using Firefly visualization features, we should provide a few different Docker deployment images for different installation scenarios, for example, one Firefly server on a laptop without need for large memory and computation power, one Firefly for a group to share with adequate memory and computation power, and one as service for large community with ample memory to computation power to share. \r\n","created_at":"2018-07-11T18:11:55Z","updated_at":"2018-07-11T18:12:53Z","html_url":"https://github.com/lsst-dm/dmtn-085/pull/1#discussion_r201790948","pull_request_url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/comments/201790948"},"html":{"href":"https://github.com/lsst-dm/dmtn-085/pull/1#discussion_r201790948"},"pull_request":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1","id":196252038,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjUyMDM4","html_url":"https://github.com/lsst-dm/dmtn-085/pull/1","diff_url":"https://github.com/lsst-dm/dmtn-085/pull/1.diff","patch_url":"https://github.com/lsst-dm/dmtn-085/pull/1.patch","issue_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/1","number":1,"state":"open","locked":false,"title":"Added some requirements and discussion to the Image viewer section","user":{"login":"robyww","id":6730519,"node_id":"MDQ6VXNlcjY3MzA1MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6730519?v=4","gravatar_id":"","url":"https://api.github.com/users/robyww","html_url":"https://github.com/robyww","followers_url":"https://api.github.com/users/robyww/followers","following_url":"https://api.github.com/users/robyww/following{/other_user}","gists_url":"https://api.github.com/users/robyww/gists{/gist_id}","starred_url":"https://api.github.com/users/robyww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robyww/subscriptions","organizations_url":"https://api.github.com/users/robyww/orgs","repos_url":"https://api.github.com/users/robyww/repos","events_url":"https://api.github.com/users/robyww/events{/privacy}","received_events_url":"https://api.github.com/users/robyww/received_events","type":"User","site_admin":false},"body":"I am not sure how much you want here.  We can keep adding, but this is a start.","created_at":"2018-06-20T19:45:20Z","updated_at":"2018-07-11T18:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"443b80b0a133a68e4dd0f6291f521255f2880a89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/1/comments","statuses_url":"https://api.github.com/repos/lsst-dm/dmtn-085/statuses/9a0806ee3c3ca9d4831efb7c6df49c782014a4b8","head":{"label":"lsst-dm:image-vis-trey","ref":"image-vis-trey","sha":"9a0806ee3c3ca9d4831efb7c6df49c782014a4b8","user":{"login":"lsst-dm","id":10968870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTY4ODcw","avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"repo":{"id":137246478,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNDY0Nzg=","name":"dmtn-085","full_name":"lsst-dm/dmtn-085","owner":{"login":"lsst-dm","id":10968870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTY4ODcw","avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-dm/dmtn-085","description":"QA Strategy Working Group Report","fork":false,"url":"https://api.github.com/repos/lsst-dm/dmtn-085","forks_url":"https://api.github.com/repos/lsst-dm/dmtn-085/forks","keys_url":"https://api.github.com/repos/lsst-dm/dmtn-085/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-dm/dmtn-085/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-dm/dmtn-085/teams","hooks_url":"https://api.github.com/repos/lsst-dm/dmtn-085/hooks","issue_events_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-dm/dmtn-085/events","assignees_url":"https://api.github.com/repos/lsst-dm/dmtn-085/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-dm/dmtn-085/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-dm/dmtn-085/tags","blobs_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-dm/dmtn-085/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-dm/dmtn-085/languages","stargazers_url":"https://api.github.com/repos/lsst-dm/dmtn-085/stargazers","contributors_url":"https://api.github.com/repos/lsst-dm/dmtn-085/contributors","subscribers_url":"https://api.github.com/repos/lsst-dm/dmtn-085/subscribers","subscription_url":"https://api.github.com/repos/lsst-dm/dmtn-085/subscription","commits_url":"https://api.github.com/repos/lsst-dm/dmtn-085/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-dm/dmtn-085/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-dm/dmtn-085/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-dm/dmtn-085/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-dm/dmtn-085/merges","archive_url":"https://api.github.com/repos/lsst-dm/dmtn-085/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-dm/dmtn-085/downloads","issues_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-dm/dmtn-085/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-dm/dmtn-085/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-dm/dmtn-085/labels{/name}","releases_url":"https://api.github.com/repos/lsst-dm/dmtn-085/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-dm/dmtn-085/deployments","created_at":"2018-06-13T17:04:06Z","updated_at":"2018-07-11T05:20:25Z","pushed_at":"2018-07-11T05:20:23Z","git_url":"git://github.com/lsst-dm/dmtn-085.git","ssh_url":"git@github.com:lsst-dm/dmtn-085.git","clone_url":"https://github.com/lsst-dm/dmtn-085.git","svn_url":"https://github.com/lsst-dm/dmtn-085","homepage":"https://dmtn-085.lsst.io","size":165,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst-dm:master","ref":"master","sha":"601c1f373f9171bbbddff3abf5b92e3530f76fbe","user":{"login":"lsst-dm","id":10968870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTY4ODcw","avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"repo":{"id":137246478,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNDY0Nzg=","name":"dmtn-085","full_name":"lsst-dm/dmtn-085","owner":{"login":"lsst-dm","id":10968870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTY4ODcw","avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-dm/dmtn-085","description":"QA Strategy Working Group Report","fork":false,"url":"https://api.github.com/repos/lsst-dm/dmtn-085","forks_url":"https://api.github.com/repos/lsst-dm/dmtn-085/forks","keys_url":"https://api.github.com/repos/lsst-dm/dmtn-085/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-dm/dmtn-085/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-dm/dmtn-085/teams","hooks_url":"https://api.github.com/repos/lsst-dm/dmtn-085/hooks","issue_events_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-dm/dmtn-085/events","assignees_url":"https://api.github.com/repos/lsst-dm/dmtn-085/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-dm/dmtn-085/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-dm/dmtn-085/tags","blobs_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-dm/dmtn-085/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-dm/dmtn-085/languages","stargazers_url":"https://api.github.com/repos/lsst-dm/dmtn-085/stargazers","contributors_url":"https://api.github.com/repos/lsst-dm/dmtn-085/contributors","subscribers_url":"https://api.github.com/repos/lsst-dm/dmtn-085/subscribers","subscription_url":"https://api.github.com/repos/lsst-dm/dmtn-085/subscription","commits_url":"https://api.github.com/repos/lsst-dm/dmtn-085/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-dm/dmtn-085/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-dm/dmtn-085/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-dm/dmtn-085/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-dm/dmtn-085/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-dm/dmtn-085/merges","archive_url":"https://api.github.com/repos/lsst-dm/dmtn-085/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-dm/dmtn-085/downloads","issues_url":"https://api.github.com/repos/lsst-dm/dmtn-085/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-dm/dmtn-085/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-dm/dmtn-085/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-dm/dmtn-085/labels{/name}","releases_url":"https://api.github.com/repos/lsst-dm/dmtn-085/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-dm/dmtn-085/deployments","created_at":"2018-06-13T17:04:06Z","updated_at":"2018-07-11T05:20:25Z","pushed_at":"2018-07-11T05:20:23Z","git_url":"git://github.com/lsst-dm/dmtn-085.git","ssh_url":"git@github.com:lsst-dm/dmtn-085.git","clone_url":"https://github.com/lsst-dm/dmtn-085.git","svn_url":"https://github.com/lsst-dm/dmtn-085","homepage":"https://dmtn-085.lsst.io","size":165,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1"},"html":{"href":"https://github.com/lsst-dm/dmtn-085/pull/1"},"issue":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/1"},"comments":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lsst-dm/dmtn-085/statuses/9a0806ee3c3ca9d4831efb7c6df49c782014a4b8"}},"author_association":"NONE"}}
{"actor":{"display_login":"xiuqin"}}