{"action":"opened","number":1924,"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1924","id":224746618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzQ2NjE4","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1924","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/1924.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/1924.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1924","number":1924,"state":"open","locked":false,"title":"[MM-12449] Use separate database and default config.json when running end-to-end testing ","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nThanks @enahum for giving the idea on how to approach the two issues in running end-to-end testing on dev's local machine\r\n1. Database is being reset after end-to-end testing\r\n2. Different failing tests encountered are due to `config.json` not set to default values.\r\n\r\nAbove issues were fixed by  separating database and using default `config.json` when running end-to-end testing on local machine.\r\n\r\nAdded make commands:\r\n- `make e2e` - use this command to run end-to-end testing.\r\n- `make clean-e2e` - use to stop `mattermost-mysql-e2e` docker instance and revert local config.  This can be used to manually restore changes caused by running `make e2e` in case of error (early exit from command)\r\n\r\nOther helper make commands:\r\n- `make test-e2e` - alias for `npm run test:e2e` from npm script\r\n- `make setup-e2e` - use to create or restart `mattermost-mysql-e2e` docker instance, back up local `config.json` and copy `default.json` as `config.json`\r\n\r\nWorkflow:\r\n1. Dev to run `make e2e`.  Script will:\r\n- do `node_modules` (`npm install`)\r\n- do `setup-e2e`\r\n  - create or restart `mattermost-mysql-e2e` database\r\n  - back up local `config.json` as `config-backup.json`\r\n  - copy `default.json` as `config.json`\r\n- do `test-e2e`\r\n  - do `npm run test:e2e`\r\n    - do local setup of selenium (unchange)\r\n    - modify config - using the new database connection\r\n    - stop and start the server (unchange)\r\n    - reset database (unchange)\r\n    - add test users (unchange)\r\n    - run Nightwatch (unchange)\r\n    - stop the server\r\n- do `clean-e2e`\r\n  - stop `mattermost-mysql-e2e` database\r\n  - revert local `config.json` from `config-backup.json`\r\n\r\nNote this is submitted on top of https://github.com/mattermost/mattermost-webapp/pull/1922.  Will rebase once merge (that's after GH/mattermod back to normal operation)\r\n\r\n#### Ticket Link\r\nJira ticket: [MM-12449](https://mattermost.atlassian.net/browse/MM-12449)\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed\r\n","created_at":"2018-10-22T17:04:47Z","updated_at":"2018-10-22T17:04:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":685999255,"node_id":"MDU6TGFiZWw2ODU5OTkyNTU=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1924/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1924/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1924/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/37389e215e511623e43ca0bb52c6c33c198748b1","head":{"label":"saturninoabril:MM-12449-1","ref":"MM-12449-1","sha":"37389e215e511623e43ca0bb52c6c33c198748b1","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"repo":{"id":102709140,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDkxNDA=","name":"mattermost-webapp","full_name":"saturninoabril/mattermost-webapp","private":false,"owner":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"html_url":"https://github.com/saturninoabril/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":true,"url":"https://api.github.com/repos/saturninoabril/mattermost-webapp","forks_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/deployments","created_at":"2017-09-07T08:03:14Z","updated_at":"2018-10-22T06:49:54Z","pushed_at":"2018-10-22T16:41:35Z","git_url":"git://github.com/saturninoabril/mattermost-webapp.git","ssh_url":"git@github.com:saturninoabril/mattermost-webapp.git","clone_url":"https://github.com/saturninoabril/mattermost-webapp.git","svn_url":"https://github.com/saturninoabril/mattermost-webapp","homepage":null,"size":111838,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"f1c8e5bc2812143a583b5b073c9f020355e9df4f","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":102689445,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2ODk0NDU=","name":"mattermost-webapp","full_name":"mattermost/mattermost-webapp","private":false,"owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mattermost/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-webapp","forks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/deployments","created_at":"2017-09-07T04:00:02Z","updated_at":"2018-10-22T16:52:56Z","pushed_at":"2018-10-22T16:52:52Z","git_url":"git://github.com/mattermost/mattermost-webapp.git","ssh_url":"git@github.com:mattermost/mattermost-webapp.git","clone_url":"https://github.com/mattermost/mattermost-webapp.git","svn_url":"https://github.com/mattermost/mattermost-webapp","homepage":null,"size":112420,"stargazers_count":264,"watchers_count":264,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":550,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":550,"open_issues":42,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1924"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/1924"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1924"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1924/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1924/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1924/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/37389e215e511623e43ca0bb52c6c33c198748b1"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":362,"deletions":362,"changed_files":22}}
{"actor":{"display_login":"saturninoabril"}}