{"action":"opened","number":690,"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/690","id":171497547,"html_url":"https://github.com/smartdevicelink/sdl_android/pull/690","diff_url":"https://github.com/smartdevicelink/sdl_android/pull/690.diff","patch_url":"https://github.com/smartdevicelink/sdl_android/pull/690.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/690","number":690,"state":"open","locked":false,"title":"Fix array boundary issue in deployNextRouterService","user":{"login":"bilal-alsharifi","id":599206,"avatar_url":"https://avatars2.githubusercontent.com/u/599206?v=4","gravatar_id":"","url":"https://api.github.com/users/bilal-alsharifi","html_url":"https://github.com/bilal-alsharifi","followers_url":"https://api.github.com/users/bilal-alsharifi/followers","following_url":"https://api.github.com/users/bilal-alsharifi/following{/other_user}","gists_url":"https://api.github.com/users/bilal-alsharifi/gists{/gist_id}","starred_url":"https://api.github.com/users/bilal-alsharifi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilal-alsharifi/subscriptions","organizations_url":"https://api.github.com/users/bilal-alsharifi/orgs","repos_url":"https://api.github.com/users/bilal-alsharifi/repos","events_url":"https://api.github.com/users/bilal-alsharifi/events{/privacy}","received_events_url":"https://api.github.com/users/bilal-alsharifi/received_events","type":"User","site_admin":false},"body":"Fixes #689 \r\n\r\nThis PR is **ready** for review.\r\n\r\n### Risk\r\nThis PR makes **no** API changes.\r\n\r\n### Summary\r\nI just fixed an array boundary issue by subtracting one from the loop counter in function deployNextRouterService in SdlRouterService class\r\n\r\n##### Bug Fixes\r\n* fixes issue #689 \r\n\r\n### CLA\r\n- [x] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)","created_at":"2018-02-26T21:32:17Z","updated_at":"2018-02-26T21:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/690/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/690/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/690/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/09cc45f9dc421109fb5f0463f3855e95c6f54a80","head":{"label":"smartdevicelink:feature/Issue_689","ref":"feature/Issue_689","sha":"09cc45f9dc421109fb5f0463f3855e95c6f54a80","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24610319,"name":"sdl_android","full_name":"smartdevicelink/sdl_android","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_android","description":"SmartDeviceLink mobile library for Android","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_android","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_android/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_android/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_android/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_android/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_android/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_android/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_android/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_android/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/deployments","created_at":"2014-09-29T19:49:09Z","updated_at":"2018-02-21T08:24:08Z","pushed_at":"2018-02-26T21:25:25Z","git_url":"git://github.com/smartdevicelink/sdl_android.git","ssh_url":"git@github.com:smartdevicelink/sdl_android.git","clone_url":"https://github.com/smartdevicelink/sdl_android.git","svn_url":"https://github.com/smartdevicelink/sdl_android","homepage":"","size":6398,"stargazers_count":101,"watchers_count":101,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":79,"open_issues":111,"watchers":101,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"1cadbd8f7ecfdd05b267a27b85746e9c1868412c","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24610319,"name":"sdl_android","full_name":"smartdevicelink/sdl_android","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_android","description":"SmartDeviceLink mobile library for Android","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_android","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_android/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_android/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_android/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_android/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_android/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_android/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_android/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_android/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/deployments","created_at":"2014-09-29T19:49:09Z","updated_at":"2018-02-21T08:24:08Z","pushed_at":"2018-02-26T21:25:25Z","git_url":"git://github.com/smartdevicelink/sdl_android.git","ssh_url":"git@github.com:smartdevicelink/sdl_android.git","clone_url":"https://github.com/smartdevicelink/sdl_android.git","svn_url":"https://github.com/smartdevicelink/sdl_android","homepage":"","size":6398,"stargazers_count":101,"watchers_count":101,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":79,"open_issues":111,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/690"},"html":{"href":"https://github.com/smartdevicelink/sdl_android/pull/690"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/690"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/09cc45f9dc421109fb5f0463f3855e95c6f54a80"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bilal-alsharifi"}}