{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/comments/237801539","pull_request_review_id":180189056,"id":237801539,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgwMTUzOQ==","diff_hunk":"@@ -8,12 +8,14 @@ import BoundServiceRow from './BoundServiceRow';\n describe('BoundServiceRow', () => {","path":"ui/src/components/mobileservices/BoundServiceRow.test.js","position":1,"original_position":1,"commit_id":"babe39df2f0575448abb19c90747b1f827ac1337","original_commit_id":"babe39df2f0575448abb19c90747b1f827ac1337","user":{"login":"ziccardi","id":1125019,"node_id":"MDQ6VXNlcjExMjUwMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1125019?v=4","gravatar_id":"","url":"https://api.github.com/users/ziccardi","html_url":"https://github.com/ziccardi","followers_url":"https://api.github.com/users/ziccardi/followers","following_url":"https://api.github.com/users/ziccardi/following{/other_user}","gists_url":"https://api.github.com/users/ziccardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ziccardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziccardi/subscriptions","organizations_url":"https://api.github.com/users/ziccardi/orgs","repos_url":"https://api.github.com/users/ziccardi/repos","events_url":"https://api.github.com/users/ziccardi/events{/privacy}","received_events_url":"https://api.github.com/users/ziccardi/received_events","type":"User","site_admin":false},"body":"@wei-lee @aliok I made your test work here: https://github.com/ziccardi/mobile-developer-console/blob/23b0c219eff1d88eaa28438dd9ece78f82eabf39/ui/src/components/mobileservices/BoundServiceRow.test.js#L47\r\n\r\nTo be able to access passed in properties, you need to use `mount` since `shallow` only render the result of the `render` method, thus removing the `parent` (the `BoundServiceRow` component) that would contain the parameter.\r\n\r\nHowever, since `mount` renders the whole component, you need to provide a `store` and a `router`.\r\n\r\nFor this and other reasons, we should avoid using `mount`.","created_at":"2018-11-30T09:49:45Z","updated_at":"2018-11-30T09:49:45Z","html_url":"https://github.com/aerogear/mobile-developer-console/pull/143#discussion_r237801539","pull_request_url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/comments/237801539"},"html":{"href":"https://github.com/aerogear/mobile-developer-console/pull/143#discussion_r237801539"},"pull_request":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143"}},"in_reply_to_id":237774216},"pull_request":{"url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143","id":233943184,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTQzMTg0","html_url":"https://github.com/aerogear/mobile-developer-console/pull/143","diff_url":"https://github.com/aerogear/mobile-developer-console/pull/143.diff","patch_url":"https://github.com/aerogear/mobile-developer-console/pull/143.patch","issue_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/143","number":143,"state":"open","locked":false,"title":"AEROGEAR-8137","user":{"login":"aliok","id":376732,"node_id":"MDQ6VXNlcjM3NjczMg==","avatar_url":"https://avatars2.githubusercontent.com/u/376732?v=4","gravatar_id":"","url":"https://api.github.com/users/aliok","html_url":"https://github.com/aliok","followers_url":"https://api.github.com/users/aliok/followers","following_url":"https://api.github.com/users/aliok/following{/other_user}","gists_url":"https://api.github.com/users/aliok/gists{/gist_id}","starred_url":"https://api.github.com/users/aliok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliok/subscriptions","organizations_url":"https://api.github.com/users/aliok/orgs","repos_url":"https://api.github.com/users/aliok/repos","events_url":"https://api.github.com/users/aliok/events{/privacy}","received_events_url":"https://api.github.com/users/aliok/received_events","type":"User","site_admin":false},"body":"How to verify:\r\n- Make sure you have the latest UPS apb. If not, change metadata of UPS apb to https://github.com/aerogearcatalog/unifiedpush-apb/blob/master/apb.yml#L32 via `oc edit clusterserviceplan`\r\n- Start this project, Provision UPS, provision Metrics\r\n- Create a client and bind to UPS\r\n- You will still see the Bind button next to UPS, but not for e.g. Metrics when you bind to Metrics\r\n- Press Bind button next to UPS again\r\n- You will only see the missing platform, Android or IOS, in the platform select box\r\n- Create the binding\r\n- You won't see the Bind button next to UPS anymore\r\n- Also test things like \"Binding in Progress\" status display, etc.\r\n\r\nWhat's missing:\r\n- Delete button adaption for multiple bindings. Will be done separately within a task from https://issues.jboss.org/browse/AEROGEAR-8153","created_at":"2018-11-27T15:00:15Z","updated_at":"2018-11-30T09:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b021a33d9914846b622203bbbd708204814270d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wei-lee","id":912729,"node_id":"MDQ6VXNlcjkxMjcyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912729?v=4","gravatar_id":"","url":"https://api.github.com/users/wei-lee","html_url":"https://github.com/wei-lee","followers_url":"https://api.github.com/users/wei-lee/followers","following_url":"https://api.github.com/users/wei-lee/following{/other_user}","gists_url":"https://api.github.com/users/wei-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/wei-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wei-lee/subscriptions","organizations_url":"https://api.github.com/users/wei-lee/orgs","repos_url":"https://api.github.com/users/wei-lee/repos","events_url":"https://api.github.com/users/wei-lee/events{/privacy}","received_events_url":"https://api.github.com/users/wei-lee/received_events","type":"User","site_admin":false},{"login":"ziccardi","id":1125019,"node_id":"MDQ6VXNlcjExMjUwMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1125019?v=4","gravatar_id":"","url":"https://api.github.com/users/ziccardi","html_url":"https://github.com/ziccardi","followers_url":"https://api.github.com/users/ziccardi/followers","following_url":"https://api.github.com/users/ziccardi/following{/other_user}","gists_url":"https://api.github.com/users/ziccardi/gists{/gist_id}","starred_url":"https://api.github.com/users/ziccardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziccardi/subscriptions","organizations_url":"https://api.github.com/users/ziccardi/orgs","repos_url":"https://api.github.com/users/ziccardi/repos","events_url":"https://api.github.com/users/ziccardi/events{/privacy}","received_events_url":"https://api.github.com/users/ziccardi/received_events","type":"User","site_admin":false},{"login":"psturc","id":4881144,"node_id":"MDQ6VXNlcjQ4ODExNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4881144?v=4","gravatar_id":"","url":"https://api.github.com/users/psturc","html_url":"https://github.com/psturc","followers_url":"https://api.github.com/users/psturc/followers","following_url":"https://api.github.com/users/psturc/following{/other_user}","gists_url":"https://api.github.com/users/psturc/gists{/gist_id}","starred_url":"https://api.github.com/users/psturc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psturc/subscriptions","organizations_url":"https://api.github.com/users/psturc/orgs","repos_url":"https://api.github.com/users/psturc/repos","events_url":"https://api.github.com/users/psturc/events{/privacy}","received_events_url":"https://api.github.com/users/psturc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143/commits","review_comments_url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143/comments","review_comment_url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/143/comments","statuses_url":"https://api.github.com/repos/aerogear/mobile-developer-console/statuses/babe39df2f0575448abb19c90747b1f827ac1337","head":{"label":"aerogear:AEROGEAR-8137","ref":"AEROGEAR-8137","sha":"babe39df2f0575448abb19c90747b1f827ac1337","user":{"login":"aerogear","id":954205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":141608523,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE2MDg1MjM=","name":"mobile-developer-console","full_name":"aerogear/mobile-developer-console","private":false,"owner":{"login":"aerogear","id":954205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aerogear/mobile-developer-console","description":"Mobile Developer Console","fork":false,"url":"https://api.github.com/repos/aerogear/mobile-developer-console","forks_url":"https://api.github.com/repos/aerogear/mobile-developer-console/forks","keys_url":"https://api.github.com/repos/aerogear/mobile-developer-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/mobile-developer-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/mobile-developer-console/teams","hooks_url":"https://api.github.com/repos/aerogear/mobile-developer-console/hooks","issue_events_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/mobile-developer-console/events","assignees_url":"https://api.github.com/repos/aerogear/mobile-developer-console/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/mobile-developer-console/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/mobile-developer-console/tags","blobs_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/mobile-developer-console/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/mobile-developer-console/languages","stargazers_url":"https://api.github.com/repos/aerogear/mobile-developer-console/stargazers","contributors_url":"https://api.github.com/repos/aerogear/mobile-developer-console/contributors","subscribers_url":"https://api.github.com/repos/aerogear/mobile-developer-console/subscribers","subscription_url":"https://api.github.com/repos/aerogear/mobile-developer-console/subscription","commits_url":"https://api.github.com/repos/aerogear/mobile-developer-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/mobile-developer-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/mobile-developer-console/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/mobile-developer-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/mobile-developer-console/merges","archive_url":"https://api.github.com/repos/aerogear/mobile-developer-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/mobile-developer-console/downloads","issues_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/mobile-developer-console/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/mobile-developer-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/mobile-developer-console/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/mobile-developer-console/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/mobile-developer-console/deployments","created_at":"2018-07-19T17:02:21Z","updated_at":"2018-11-28T14:14:52Z","pushed_at":"2018-11-30T07:56:43Z","git_url":"git://github.com/aerogear/mobile-developer-console.git","ssh_url":"git@github.com:aerogear/mobile-developer-console.git","clone_url":"https://github.com/aerogear/mobile-developer-console.git","svn_url":"https://github.com/aerogear/mobile-developer-console","homepage":"","size":2216,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"5f51811cb9c7250eb8572fea7de842d2374d921e","user":{"login":"aerogear","id":954205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":141608523,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE2MDg1MjM=","name":"mobile-developer-console","full_name":"aerogear/mobile-developer-console","private":false,"owner":{"login":"aerogear","id":954205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aerogear/mobile-developer-console","description":"Mobile Developer Console","fork":false,"url":"https://api.github.com/repos/aerogear/mobile-developer-console","forks_url":"https://api.github.com/repos/aerogear/mobile-developer-console/forks","keys_url":"https://api.github.com/repos/aerogear/mobile-developer-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/mobile-developer-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/mobile-developer-console/teams","hooks_url":"https://api.github.com/repos/aerogear/mobile-developer-console/hooks","issue_events_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/mobile-developer-console/events","assignees_url":"https://api.github.com/repos/aerogear/mobile-developer-console/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/mobile-developer-console/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/mobile-developer-console/tags","blobs_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/mobile-developer-console/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/mobile-developer-console/languages","stargazers_url":"https://api.github.com/repos/aerogear/mobile-developer-console/stargazers","contributors_url":"https://api.github.com/repos/aerogear/mobile-developer-console/contributors","subscribers_url":"https://api.github.com/repos/aerogear/mobile-developer-console/subscribers","subscription_url":"https://api.github.com/repos/aerogear/mobile-developer-console/subscription","commits_url":"https://api.github.com/repos/aerogear/mobile-developer-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/mobile-developer-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/mobile-developer-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/mobile-developer-console/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/mobile-developer-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/mobile-developer-console/merges","archive_url":"https://api.github.com/repos/aerogear/mobile-developer-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/mobile-developer-console/downloads","issues_url":"https://api.github.com/repos/aerogear/mobile-developer-console/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/mobile-developer-console/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/mobile-developer-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/mobile-developer-console/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/mobile-developer-console/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/mobile-developer-console/deployments","created_at":"2018-07-19T17:02:21Z","updated_at":"2018-11-28T14:14:52Z","pushed_at":"2018-11-30T07:56:43Z","git_url":"git://github.com/aerogear/mobile-developer-console.git","ssh_url":"git@github.com:aerogear/mobile-developer-console.git","clone_url":"https://github.com/aerogear/mobile-developer-console.git","svn_url":"https://github.com/aerogear/mobile-developer-console","homepage":"","size":2216,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143"},"html":{"href":"https://github.com/aerogear/mobile-developer-console/pull/143"},"issue":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/143"},"comments":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/mobile-developer-console/statuses/babe39df2f0575448abb19c90747b1f827ac1337"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ziccardi"}}