{"action":"created","comment":{"url":"https://api.github.com/repos/untool/untool/pulls/comments/186976302","pull_request_review_id":118658824,"id":186976302,"diff_hunk":"@@ -33,6 +33,25 @@ exports.checkESNext = (target, defaults) => {\n   return check;\n };\n \n+exports.determineExternals = (target, defaults) => {\n+  const resolve = createResolver(exports.getResolveConfig(target, defaults));\n+  const checkESNext = exports.checkESNext(target, defaults);\n+  const isNotExternal = (context, request) => {\n+    try {\n+      return request.startsWith('.') || checkESNext(resolve(context, request));","path":"packages/webpack/lib/utils/helpers.js","position":18,"original_position":18,"commit_id":"d9ea21cf6897e12e336d3fe3b0f12f7a7ffa5c21","original_commit_id":"9efc5cc4cd9426a3736daf6dc447662a4e449687","user":{"login":"ZauberNerd","id":249542,"avatar_url":"https://avatars0.githubusercontent.com/u/249542?v=4","gravatar_id":"","url":"https://api.github.com/users/ZauberNerd","html_url":"https://github.com/ZauberNerd","followers_url":"https://api.github.com/users/ZauberNerd/followers","following_url":"https://api.github.com/users/ZauberNerd/following{/other_user}","gists_url":"https://api.github.com/users/ZauberNerd/gists{/gist_id}","starred_url":"https://api.github.com/users/ZauberNerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZauberNerd/subscriptions","organizations_url":"https://api.github.com/users/ZauberNerd/orgs","repos_url":"https://api.github.com/users/ZauberNerd/repos","events_url":"https://api.github.com/users/ZauberNerd/events{/privacy}","received_events_url":"https://api.github.com/users/ZauberNerd/received_events","type":"User","site_admin":false},"body":"Also: You are now creating a resolver in multiple places. Here in [line 37](https://github.com/untool/untool/pull/25/commits/9efc5cc4cd9426a3736daf6dc447662a4e449687#diff-725bed128020e90199ba7a494eefda14R37) and also inside `checkESNext()` in [line 22](https://github.com/untool/untool/blob/9efc5cc4cd9426a3736daf6dc447662a4e449687/packages/webpack/lib/utils/helpers.js#L22).\r\nMaybe we could change the `checkESNext` function to only accept absolute paths and create the resolver only in one place?","created_at":"2018-05-09T08:59:13Z","updated_at":"2018-05-09T09:01:25Z","html_url":"https://github.com/untool/untool/pull/25#discussion_r186976302","pull_request_url":"https://api.github.com/repos/untool/untool/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/untool/untool/pulls/comments/186976302"},"html":{"href":"https://github.com/untool/untool/pull/25#discussion_r186976302"},"pull_request":{"href":"https://api.github.com/repos/untool/untool/pulls/25"}},"in_reply_to_id":186975470},"pull_request":{"url":"https://api.github.com/repos/untool/untool/pulls/25","id":186773882,"html_url":"https://github.com/untool/untool/pull/25","diff_url":"https://github.com/untool/untool/pull/25.diff","patch_url":"https://github.com/untool/untool/pull/25.patch","issue_url":"https://api.github.com/repos/untool/untool/issues/25","number":25,"state":"open","locked":false,"title":"Fix node_externals mechanism","user":{"login":"dmbch","id":228716,"avatar_url":"https://avatars2.githubusercontent.com/u/228716?v=4","gravatar_id":"","url":"https://api.github.com/users/dmbch","html_url":"https://github.com/dmbch","followers_url":"https://api.github.com/users/dmbch/followers","following_url":"https://api.github.com/users/dmbch/following{/other_user}","gists_url":"https://api.github.com/users/dmbch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmbch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmbch/subscriptions","organizations_url":"https://api.github.com/users/dmbch/orgs","repos_url":"https://api.github.com/users/dmbch/repos","events_url":"https://api.github.com/users/dmbch/events{/privacy}","received_events_url":"https://api.github.com/users/dmbch/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-08T22:34:12Z","updated_at":"2018-05-09T09:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0de4058e67340cd9bed1680f4c9a77ff852c5951","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/untool/untool/pulls/25/commits","review_comments_url":"https://api.github.com/repos/untool/untool/pulls/25/comments","review_comment_url":"https://api.github.com/repos/untool/untool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/untool/untool/issues/25/comments","statuses_url":"https://api.github.com/repos/untool/untool/statuses/d9ea21cf6897e12e336d3fe3b0f12f7a7ffa5c21","head":{"label":"untool:fixternals","ref":"fixternals","sha":"d9ea21cf6897e12e336d3fe3b0f12f7a7ffa5c21","user":{"login":"untool","id":36716786,"avatar_url":"https://avatars1.githubusercontent.com/u/36716786?v=4","gravatar_id":"","url":"https://api.github.com/users/untool","html_url":"https://github.com/untool","followers_url":"https://api.github.com/users/untool/followers","following_url":"https://api.github.com/users/untool/following{/other_user}","gists_url":"https://api.github.com/users/untool/gists{/gist_id}","starred_url":"https://api.github.com/users/untool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untool/subscriptions","organizations_url":"https://api.github.com/users/untool/orgs","repos_url":"https://api.github.com/users/untool/repos","events_url":"https://api.github.com/users/untool/events{/privacy}","received_events_url":"https://api.github.com/users/untool/received_events","type":"Organization","site_admin":false},"repo":{"id":122542942,"name":"untool","full_name":"untool/untool","owner":{"login":"untool","id":36716786,"avatar_url":"https://avatars1.githubusercontent.com/u/36716786?v=4","gravatar_id":"","url":"https://api.github.com/users/untool","html_url":"https://github.com/untool","followers_url":"https://api.github.com/users/untool/followers","following_url":"https://api.github.com/users/untool/following{/other_user}","gists_url":"https://api.github.com/users/untool/gists{/gist_id}","starred_url":"https://api.github.com/users/untool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untool/subscriptions","organizations_url":"https://api.github.com/users/untool/orgs","repos_url":"https://api.github.com/users/untool/repos","events_url":"https://api.github.com/users/untool/events{/privacy}","received_events_url":"https://api.github.com/users/untool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/untool/untool","description":"JavaScript Tooling Platform","fork":false,"url":"https://api.github.com/repos/untool/untool","forks_url":"https://api.github.com/repos/untool/untool/forks","keys_url":"https://api.github.com/repos/untool/untool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/untool/untool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/untool/untool/teams","hooks_url":"https://api.github.com/repos/untool/untool/hooks","issue_events_url":"https://api.github.com/repos/untool/untool/issues/events{/number}","events_url":"https://api.github.com/repos/untool/untool/events","assignees_url":"https://api.github.com/repos/untool/untool/assignees{/user}","branches_url":"https://api.github.com/repos/untool/untool/branches{/branch}","tags_url":"https://api.github.com/repos/untool/untool/tags","blobs_url":"https://api.github.com/repos/untool/untool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/untool/untool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/untool/untool/git/refs{/sha}","trees_url":"https://api.github.com/repos/untool/untool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/untool/untool/statuses/{sha}","languages_url":"https://api.github.com/repos/untool/untool/languages","stargazers_url":"https://api.github.com/repos/untool/untool/stargazers","contributors_url":"https://api.github.com/repos/untool/untool/contributors","subscribers_url":"https://api.github.com/repos/untool/untool/subscribers","subscription_url":"https://api.github.com/repos/untool/untool/subscription","commits_url":"https://api.github.com/repos/untool/untool/commits{/sha}","git_commits_url":"https://api.github.com/repos/untool/untool/git/commits{/sha}","comments_url":"https://api.github.com/repos/untool/untool/comments{/number}","issue_comment_url":"https://api.github.com/repos/untool/untool/issues/comments{/number}","contents_url":"https://api.github.com/repos/untool/untool/contents/{+path}","compare_url":"https://api.github.com/repos/untool/untool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/untool/untool/merges","archive_url":"https://api.github.com/repos/untool/untool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/untool/untool/downloads","issues_url":"https://api.github.com/repos/untool/untool/issues{/number}","pulls_url":"https://api.github.com/repos/untool/untool/pulls{/number}","milestones_url":"https://api.github.com/repos/untool/untool/milestones{/number}","notifications_url":"https://api.github.com/repos/untool/untool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/untool/untool/labels{/name}","releases_url":"https://api.github.com/repos/untool/untool/releases{/id}","deployments_url":"https://api.github.com/repos/untool/untool/deployments","created_at":"2018-02-22T22:27:38Z","updated_at":"2018-05-08T19:35:20Z","pushed_at":"2018-05-08T22:34:12Z","git_url":"git://github.com/untool/untool.git","ssh_url":"git@github.com:untool/untool.git","clone_url":"https://github.com/untool/untool.git","svn_url":"https://github.com/untool/untool","homepage":"","size":3434,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"untool:master","ref":"master","sha":"6e45a91602940c53fabcbce342163e7a9a36ae7f","user":{"login":"untool","id":36716786,"avatar_url":"https://avatars1.githubusercontent.com/u/36716786?v=4","gravatar_id":"","url":"https://api.github.com/users/untool","html_url":"https://github.com/untool","followers_url":"https://api.github.com/users/untool/followers","following_url":"https://api.github.com/users/untool/following{/other_user}","gists_url":"https://api.github.com/users/untool/gists{/gist_id}","starred_url":"https://api.github.com/users/untool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untool/subscriptions","organizations_url":"https://api.github.com/users/untool/orgs","repos_url":"https://api.github.com/users/untool/repos","events_url":"https://api.github.com/users/untool/events{/privacy}","received_events_url":"https://api.github.com/users/untool/received_events","type":"Organization","site_admin":false},"repo":{"id":122542942,"name":"untool","full_name":"untool/untool","owner":{"login":"untool","id":36716786,"avatar_url":"https://avatars1.githubusercontent.com/u/36716786?v=4","gravatar_id":"","url":"https://api.github.com/users/untool","html_url":"https://github.com/untool","followers_url":"https://api.github.com/users/untool/followers","following_url":"https://api.github.com/users/untool/following{/other_user}","gists_url":"https://api.github.com/users/untool/gists{/gist_id}","starred_url":"https://api.github.com/users/untool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untool/subscriptions","organizations_url":"https://api.github.com/users/untool/orgs","repos_url":"https://api.github.com/users/untool/repos","events_url":"https://api.github.com/users/untool/events{/privacy}","received_events_url":"https://api.github.com/users/untool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/untool/untool","description":"JavaScript Tooling Platform","fork":false,"url":"https://api.github.com/repos/untool/untool","forks_url":"https://api.github.com/repos/untool/untool/forks","keys_url":"https://api.github.com/repos/untool/untool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/untool/untool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/untool/untool/teams","hooks_url":"https://api.github.com/repos/untool/untool/hooks","issue_events_url":"https://api.github.com/repos/untool/untool/issues/events{/number}","events_url":"https://api.github.com/repos/untool/untool/events","assignees_url":"https://api.github.com/repos/untool/untool/assignees{/user}","branches_url":"https://api.github.com/repos/untool/untool/branches{/branch}","tags_url":"https://api.github.com/repos/untool/untool/tags","blobs_url":"https://api.github.com/repos/untool/untool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/untool/untool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/untool/untool/git/refs{/sha}","trees_url":"https://api.github.com/repos/untool/untool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/untool/untool/statuses/{sha}","languages_url":"https://api.github.com/repos/untool/untool/languages","stargazers_url":"https://api.github.com/repos/untool/untool/stargazers","contributors_url":"https://api.github.com/repos/untool/untool/contributors","subscribers_url":"https://api.github.com/repos/untool/untool/subscribers","subscription_url":"https://api.github.com/repos/untool/untool/subscription","commits_url":"https://api.github.com/repos/untool/untool/commits{/sha}","git_commits_url":"https://api.github.com/repos/untool/untool/git/commits{/sha}","comments_url":"https://api.github.com/repos/untool/untool/comments{/number}","issue_comment_url":"https://api.github.com/repos/untool/untool/issues/comments{/number}","contents_url":"https://api.github.com/repos/untool/untool/contents/{+path}","compare_url":"https://api.github.com/repos/untool/untool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/untool/untool/merges","archive_url":"https://api.github.com/repos/untool/untool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/untool/untool/downloads","issues_url":"https://api.github.com/repos/untool/untool/issues{/number}","pulls_url":"https://api.github.com/repos/untool/untool/pulls{/number}","milestones_url":"https://api.github.com/repos/untool/untool/milestones{/number}","notifications_url":"https://api.github.com/repos/untool/untool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/untool/untool/labels{/name}","releases_url":"https://api.github.com/repos/untool/untool/releases{/id}","deployments_url":"https://api.github.com/repos/untool/untool/deployments","created_at":"2018-02-22T22:27:38Z","updated_at":"2018-05-08T19:35:20Z","pushed_at":"2018-05-08T22:34:12Z","git_url":"git://github.com/untool/untool.git","ssh_url":"git@github.com:untool/untool.git","clone_url":"https://github.com/untool/untool.git","svn_url":"https://github.com/untool/untool","homepage":"","size":3434,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/untool/untool/pulls/25"},"html":{"href":"https://github.com/untool/untool/pull/25"},"issue":{"href":"https://api.github.com/repos/untool/untool/issues/25"},"comments":{"href":"https://api.github.com/repos/untool/untool/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/untool/untool/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/untool/untool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/untool/untool/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/untool/untool/statuses/d9ea21cf6897e12e336d3fe3b0f12f7a7ffa5c21"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ZauberNerd"}}