{"action":"created","issue":{"url":"https://api.github.com/repos/rickynils/scalacheck/issues/440","repository_url":"https://api.github.com/repos/rickynils/scalacheck","labels_url":"https://api.github.com/repos/rickynils/scalacheck/issues/440/labels{/name}","comments_url":"https://api.github.com/repos/rickynils/scalacheck/issues/440/comments","events_url":"https://api.github.com/repos/rickynils/scalacheck/issues/440/events","html_url":"https://github.com/rickynils/scalacheck/pull/440","id":383928400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjgwNTk2","number":440,"title":"Remove shrinking from gen-based Prop.forAll","user":{"login":"charleso","id":31059,"node_id":"MDQ6VXNlcjMxMDU5","avatar_url":"https://avatars3.githubusercontent.com/u/31059?v=4","gravatar_id":"","url":"https://api.github.com/users/charleso","html_url":"https://github.com/charleso","followers_url":"https://api.github.com/users/charleso/followers","following_url":"https://api.github.com/users/charleso/following{/other_user}","gists_url":"https://api.github.com/users/charleso/gists{/gist_id}","starred_url":"https://api.github.com/users/charleso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleso/subscriptions","organizations_url":"https://api.github.com/users/charleso/orgs","repos_url":"https://api.github.com/users/charleso/repos","events_url":"https://api.github.com/users/charleso/events{/privacy}","received_events_url":"https://api.github.com/users/charleso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-23T21:19:10Z","updated_at":"2018-11-24T00:13:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rickynils/scalacheck/pulls/440","html_url":"https://github.com/rickynils/scalacheck/pull/440","diff_url":"https://github.com/rickynils/scalacheck/pull/440.diff","patch_url":"https://github.com/rickynils/scalacheck/pull/440.patch"},"body":"Shrinking is only safe when used with Arbitrary. Generators can have a smaller range than the global shrinking, which results in invalid shrunken values.\r\n\r\nThis fixes issues like #129, #260, #317 and #370.\r\n\r\nI suspect this is going to be controversial and I completely understand if it's not accepted. I'm opening this to show how I suggest it should be tackled, but it obviously affects people who are currently relying on this behaviour.\r\n\r\nEDIT: Note that Haskell's QuickCheck `forAll` [doesn't shrink in this instance](http://hackage.haskell.org/package/QuickCheck-2.12.4/docs/src/Test.QuickCheck.Property.html#forAll) either"},"comment":{"url":"https://api.github.com/repos/rickynils/scalacheck/issues/comments/441331969","html_url":"https://github.com/rickynils/scalacheck/pull/440#issuecomment-441331969","issue_url":"https://api.github.com/repos/rickynils/scalacheck/issues/440","id":441331969,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTMzMTk2OQ==","user":{"login":"charleso","id":31059,"node_id":"MDQ6VXNlcjMxMDU5","avatar_url":"https://avatars3.githubusercontent.com/u/31059?v=4","gravatar_id":"","url":"https://api.github.com/users/charleso","html_url":"https://github.com/charleso","followers_url":"https://api.github.com/users/charleso/followers","following_url":"https://api.github.com/users/charleso/following{/other_user}","gists_url":"https://api.github.com/users/charleso/gists{/gist_id}","starred_url":"https://api.github.com/users/charleso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleso/subscriptions","organizations_url":"https://api.github.com/users/charleso/orgs","repos_url":"https://api.github.com/users/charleso/repos","events_url":"https://api.github.com/users/charleso/events{/privacy}","received_events_url":"https://api.github.com/users/charleso/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T00:13:49Z","updated_at":"2018-11-24T00:13:49Z","author_association":"NONE","body":"Sorry, that was a clumsy way of saying that I don’t know whether Rickard or others consider this an issue or not. If people are interested I’m very happy to make whatever changes are required. Thanks again."}}
{"actor":{"display_login":"charleso"}}