{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/13662","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/13662/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/13662/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/13662/events","html_url":"https://github.com/fastlane/fastlane/pull/13662","id":378786481,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDA3NjA3","number":13662,"title":"[fastlane_core] Fix project_paths() in project.rb to respect container: references","user":{"login":"svendr","id":29842223,"node_id":"MDQ6VXNlcjI5ODQyMjIz","avatar_url":"https://avatars1.githubusercontent.com/u/29842223?v=4","gravatar_id":"","url":"https://api.github.com/users/svendr","html_url":"https://github.com/svendr","followers_url":"https://api.github.com/users/svendr/followers","following_url":"https://api.github.com/users/svendr/following{/other_user}","gists_url":"https://api.github.com/users/svendr/gists{/gist_id}","starred_url":"https://api.github.com/users/svendr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svendr/subscriptions","organizations_url":"https://api.github.com/users/svendr/orgs","repos_url":"https://api.github.com/users/svendr/repos","events_url":"https://api.github.com/users/svendr/events{/privacy}","received_events_url":"https://api.github.com/users/svendr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-08T15:36:22Z","updated_at":"2018-11-08T15:36:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/13662","html_url":"https://github.com/fastlane/fastlane/pull/13662","diff_url":"https://github.com/fastlane/fastlane/pull/13662.diff","patch_url":"https://github.com/fastlane/fastlane/pull/13662.patch"},"body":"### Checklist\r\n- [x] I've run `bundle exec rspec` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the _fastlane_ code style and run `bundle exec rubocop -a` to ensure the code style is valid\r\n- [x] I've read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I've updated the documentation if necessary.\r\n\r\n### Motivation and Context\r\nAs stated in #13660 and #11034, paths to xcodeprojects can't be resolved, if the projects are referenced `Relative to Workspace`(= `container:`) instead of `Relative to Group` (= `group:`), which results in Gym's CodeSigningMapper not being able to detect the correct provisioning profile mapping.\r\n\r\nThere are other edge cases of project-references to think of:\r\n* types `absolute:` (= `Absolute Path`) and `developer:` (= Relative to Developer Dir): both valid, but should be consider bad practice and therefore not really relevant\r\n* nested, group:-referenced .xccodeproj files: uncommon but possible (a .xcodeproj file inside a folder referenced by group in a workspace)\r\n\r\n### Description\r\nThis PR fixes support for top-level container:- and absolute:-references by switching from Regex-based parsing of the contents.xcworkspacedata file to Xcodeproj-Gem-based parsing (which traverses the XML properly). Xcodproj provides a convenient way to parse all top-level [file-references](https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Workspace#file_references-instance_method) of a workspace. And the workspace-property of FastlaneCore::Project is already a Xcodeproj::Workspace :)\r\n\r\nSo I've updated the `project_paths` method in project.rb accordingly.\r\n\r\n**Tests:** I've updated project_spec.rb to validate the handling of group: and container: references properly. Added some Example-Workspaces for this too.\r\n"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/437039351","html_url":"https://github.com/fastlane/fastlane/pull/13662#issuecomment-437039351","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/13662","id":437039351,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzAzOTM1MQ==","user":{"login":"googlebot","id":5384588,"node_id":"MDQ6VXNlcjUzODQ1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5384588?v=4","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T15:36:27Z","updated_at":"2018-11-08T15:36:27Z","author_association":"NONE","body":"\nThanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\n:memo: **Please visit <https://cla.developers.google.com/> to sign.**\n\nOnce you've signed (or fixed any issues), please reply here (e.g. `I signed it!`) and we'll verify it.\n\n----\n\n#### What to do if you already signed the CLA\n\n##### Individual signers\n\n*   It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n\n##### Corporate signers\n\n*   Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google.com/docs/cla/#troubleshoot)).\n*   The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n*   The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).\n\t\t\n\n<!-- need_sender_cla -->"}}
{"actor":{"display_login":"googlebot"}}