{"action":"closed","number":632,"pull_request":{"url":"https://api.github.com/repos/structuremap/structuremap/pulls/632","id":164786978,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0Nzg2OTc4","html_url":"https://github.com/structuremap/structuremap/pull/632","diff_url":"https://github.com/structuremap/structuremap/pull/632.diff","patch_url":"https://github.com/structuremap/structuremap/pull/632.patch","issue_url":"https://api.github.com/repos/structuremap/structuremap/issues/632","number":632,"state":"closed","locked":false,"title":"Allow to filter assemblies by path during the scan","user":{"login":"chaplin89","id":2357260,"node_id":"MDQ6VXNlcjIzNTcyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2357260?v=4","gravatar_id":"","url":"https://api.github.com/users/chaplin89","html_url":"https://github.com/chaplin89","followers_url":"https://api.github.com/users/chaplin89/followers","following_url":"https://api.github.com/users/chaplin89/following{/other_user}","gists_url":"https://api.github.com/users/chaplin89/gists{/gist_id}","starred_url":"https://api.github.com/users/chaplin89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaplin89/subscriptions","organizations_url":"https://api.github.com/users/chaplin89/orgs","repos_url":"https://api.github.com/users/chaplin89/repos","events_url":"https://api.github.com/users/chaplin89/events{/privacy}","received_events_url":"https://api.github.com/users/chaplin89/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI found very annoying to see in the output of the debugger \"**BadImageFormatException**\"s when using policy like \"**AssembliesAndExecutablesFromApplicationBaseDirectory**\" during the scan.\r\nThis is due to the fact I have some unmanaged assemblies, and structuremap try to load them anyway (and fail). I guess this also slows down the entire scan process.\r\n\r\nSo this little edit is just to enable the use of a Func that is meant to decide whether or not take into account a given assembly in a given path.\r\n\r\nPlease note two things:\r\n\r\n1. I found this overload of the AssemblyFinder method: \r\n`FindAssemblies(Func<Assembly, bool> filter, Action<string> onDirectoryFound = null, bool includeExeFiles=false)` that accept the action \"onDirectoryFound\" but actually ignores that action. I replaced that action with the Func of above.\r\n\r\n2. The following methods: \r\n   - **AssembliesFromApplicationBaseDirectory**\r\n   - **AssembliesAndExecutablesFromApplicationBaseDirectory**\r\n\r\n   Were calling the wrong overload of the \"FindAssembly\" methods. \r\nI guess the right overload to call (seeing the body of the method) was this:\r\n`IEnumerable<Assembly> FindAssemblies(string assemblyPath, Action<string> logFailure, bool includeExeFiles, Func<string, bool> pathFilter = null)`\r\nBut instead they call this:\r\n`FindAssemblies(Func<Assembly, bool> filter, Action<string> onDirectoryFound = null, bool includeExeFiles=false)` (the overload of the point 1)\r\n\r\nThanks","created_at":"2018-01-24T08:46:49Z","updated_at":"2018-07-12T12:39:55Z","closed_at":"2018-07-12T12:39:55Z","merged_at":"2018-07-12T12:39:55Z","merge_commit_sha":"d1f00aff187d967314437134abd2484096d25dd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/structuremap/structuremap/pulls/632/commits","review_comments_url":"https://api.github.com/repos/structuremap/structuremap/pulls/632/comments","review_comment_url":"https://api.github.com/repos/structuremap/structuremap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/structuremap/structuremap/issues/632/comments","statuses_url":"https://api.github.com/repos/structuremap/structuremap/statuses/85895dec16c9879cb913c95c6e1b8e69adf2873a","head":{"label":"chaplin89:master","ref":"master","sha":"85895dec16c9879cb913c95c6e1b8e69adf2873a","user":{"login":"chaplin89","id":2357260,"node_id":"MDQ6VXNlcjIzNTcyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2357260?v=4","gravatar_id":"","url":"https://api.github.com/users/chaplin89","html_url":"https://github.com/chaplin89","followers_url":"https://api.github.com/users/chaplin89/followers","following_url":"https://api.github.com/users/chaplin89/following{/other_user}","gists_url":"https://api.github.com/users/chaplin89/gists{/gist_id}","starred_url":"https://api.github.com/users/chaplin89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaplin89/subscriptions","organizations_url":"https://api.github.com/users/chaplin89/orgs","repos_url":"https://api.github.com/users/chaplin89/repos","events_url":"https://api.github.com/users/chaplin89/events{/privacy}","received_events_url":"https://api.github.com/users/chaplin89/received_events","type":"User","site_admin":false},"repo":{"id":118735588,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg3MzU1ODg=","name":"structuremap","full_name":"chaplin89/structuremap","owner":{"login":"chaplin89","id":2357260,"node_id":"MDQ6VXNlcjIzNTcyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2357260?v=4","gravatar_id":"","url":"https://api.github.com/users/chaplin89","html_url":"https://github.com/chaplin89","followers_url":"https://api.github.com/users/chaplin89/followers","following_url":"https://api.github.com/users/chaplin89/following{/other_user}","gists_url":"https://api.github.com/users/chaplin89/gists{/gist_id}","starred_url":"https://api.github.com/users/chaplin89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaplin89/subscriptions","organizations_url":"https://api.github.com/users/chaplin89/orgs","repos_url":"https://api.github.com/users/chaplin89/repos","events_url":"https://api.github.com/users/chaplin89/events{/privacy}","received_events_url":"https://api.github.com/users/chaplin89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaplin89/structuremap","description":"A Dependency Injection/Inversion of Control tool for .NET","fork":true,"url":"https://api.github.com/repos/chaplin89/structuremap","forks_url":"https://api.github.com/repos/chaplin89/structuremap/forks","keys_url":"https://api.github.com/repos/chaplin89/structuremap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaplin89/structuremap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaplin89/structuremap/teams","hooks_url":"https://api.github.com/repos/chaplin89/structuremap/hooks","issue_events_url":"https://api.github.com/repos/chaplin89/structuremap/issues/events{/number}","events_url":"https://api.github.com/repos/chaplin89/structuremap/events","assignees_url":"https://api.github.com/repos/chaplin89/structuremap/assignees{/user}","branches_url":"https://api.github.com/repos/chaplin89/structuremap/branches{/branch}","tags_url":"https://api.github.com/repos/chaplin89/structuremap/tags","blobs_url":"https://api.github.com/repos/chaplin89/structuremap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaplin89/structuremap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaplin89/structuremap/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaplin89/structuremap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaplin89/structuremap/statuses/{sha}","languages_url":"https://api.github.com/repos/chaplin89/structuremap/languages","stargazers_url":"https://api.github.com/repos/chaplin89/structuremap/stargazers","contributors_url":"https://api.github.com/repos/chaplin89/structuremap/contributors","subscribers_url":"https://api.github.com/repos/chaplin89/structuremap/subscribers","subscription_url":"https://api.github.com/repos/chaplin89/structuremap/subscription","commits_url":"https://api.github.com/repos/chaplin89/structuremap/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaplin89/structuremap/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaplin89/structuremap/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaplin89/structuremap/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaplin89/structuremap/contents/{+path}","compare_url":"https://api.github.com/repos/chaplin89/structuremap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaplin89/structuremap/merges","archive_url":"https://api.github.com/repos/chaplin89/structuremap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaplin89/structuremap/downloads","issues_url":"https://api.github.com/repos/chaplin89/structuremap/issues{/number}","pulls_url":"https://api.github.com/repos/chaplin89/structuremap/pulls{/number}","milestones_url":"https://api.github.com/repos/chaplin89/structuremap/milestones{/number}","notifications_url":"https://api.github.com/repos/chaplin89/structuremap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaplin89/structuremap/labels{/name}","releases_url":"https://api.github.com/repos/chaplin89/structuremap/releases{/id}","deployments_url":"https://api.github.com/repos/chaplin89/structuremap/deployments","created_at":"2018-01-24T08:26:29Z","updated_at":"2018-01-24T08:26:32Z","pushed_at":"2018-01-24T08:30:39Z","git_url":"git://github.com/chaplin89/structuremap.git","ssh_url":"git@github.com:chaplin89/structuremap.git","clone_url":"https://github.com/chaplin89/structuremap.git","svn_url":"https://github.com/chaplin89/structuremap","homepage":"http://structuremap.github.com","size":25127,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"structuremap:master","ref":"master","sha":"b9163e6f29d5561e7823daa0c6eff53825ae6c24","user":{"login":"structuremap","id":200602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDYwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/200602?v=4","gravatar_id":"","url":"https://api.github.com/users/structuremap","html_url":"https://github.com/structuremap","followers_url":"https://api.github.com/users/structuremap/followers","following_url":"https://api.github.com/users/structuremap/following{/other_user}","gists_url":"https://api.github.com/users/structuremap/gists{/gist_id}","starred_url":"https://api.github.com/users/structuremap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/structuremap/subscriptions","organizations_url":"https://api.github.com/users/structuremap/orgs","repos_url":"https://api.github.com/users/structuremap/repos","events_url":"https://api.github.com/users/structuremap/events{/privacy}","received_events_url":"https://api.github.com/users/structuremap/received_events","type":"Organization","site_admin":false},"repo":{"id":518236,"node_id":"MDEwOlJlcG9zaXRvcnk1MTgyMzY=","name":"structuremap","full_name":"structuremap/structuremap","owner":{"login":"structuremap","id":200602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDYwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/200602?v=4","gravatar_id":"","url":"https://api.github.com/users/structuremap","html_url":"https://github.com/structuremap","followers_url":"https://api.github.com/users/structuremap/followers","following_url":"https://api.github.com/users/structuremap/following{/other_user}","gists_url":"https://api.github.com/users/structuremap/gists{/gist_id}","starred_url":"https://api.github.com/users/structuremap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/structuremap/subscriptions","organizations_url":"https://api.github.com/users/structuremap/orgs","repos_url":"https://api.github.com/users/structuremap/repos","events_url":"https://api.github.com/users/structuremap/events{/privacy}","received_events_url":"https://api.github.com/users/structuremap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/structuremap/structuremap","description":"A Dependency Injection/Inversion of Control tool for .NET","fork":false,"url":"https://api.github.com/repos/structuremap/structuremap","forks_url":"https://api.github.com/repos/structuremap/structuremap/forks","keys_url":"https://api.github.com/repos/structuremap/structuremap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/structuremap/structuremap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/structuremap/structuremap/teams","hooks_url":"https://api.github.com/repos/structuremap/structuremap/hooks","issue_events_url":"https://api.github.com/repos/structuremap/structuremap/issues/events{/number}","events_url":"https://api.github.com/repos/structuremap/structuremap/events","assignees_url":"https://api.github.com/repos/structuremap/structuremap/assignees{/user}","branches_url":"https://api.github.com/repos/structuremap/structuremap/branches{/branch}","tags_url":"https://api.github.com/repos/structuremap/structuremap/tags","blobs_url":"https://api.github.com/repos/structuremap/structuremap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/structuremap/structuremap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/structuremap/structuremap/git/refs{/sha}","trees_url":"https://api.github.com/repos/structuremap/structuremap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/structuremap/structuremap/statuses/{sha}","languages_url":"https://api.github.com/repos/structuremap/structuremap/languages","stargazers_url":"https://api.github.com/repos/structuremap/structuremap/stargazers","contributors_url":"https://api.github.com/repos/structuremap/structuremap/contributors","subscribers_url":"https://api.github.com/repos/structuremap/structuremap/subscribers","subscription_url":"https://api.github.com/repos/structuremap/structuremap/subscription","commits_url":"https://api.github.com/repos/structuremap/structuremap/commits{/sha}","git_commits_url":"https://api.github.com/repos/structuremap/structuremap/git/commits{/sha}","comments_url":"https://api.github.com/repos/structuremap/structuremap/comments{/number}","issue_comment_url":"https://api.github.com/repos/structuremap/structuremap/issues/comments{/number}","contents_url":"https://api.github.com/repos/structuremap/structuremap/contents/{+path}","compare_url":"https://api.github.com/repos/structuremap/structuremap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/structuremap/structuremap/merges","archive_url":"https://api.github.com/repos/structuremap/structuremap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/structuremap/structuremap/downloads","issues_url":"https://api.github.com/repos/structuremap/structuremap/issues{/number}","pulls_url":"https://api.github.com/repos/structuremap/structuremap/pulls{/number}","milestones_url":"https://api.github.com/repos/structuremap/structuremap/milestones{/number}","notifications_url":"https://api.github.com/repos/structuremap/structuremap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/structuremap/structuremap/labels{/name}","releases_url":"https://api.github.com/repos/structuremap/structuremap/releases{/id}","deployments_url":"https://api.github.com/repos/structuremap/structuremap/deployments","created_at":"2010-02-15T02:35:57Z","updated_at":"2018-07-12T12:39:15Z","pushed_at":"2018-07-12T12:39:55Z","git_url":"git://github.com/structuremap/structuremap.git","ssh_url":"git@github.com:structuremap/structuremap.git","clone_url":"https://github.com/structuremap/structuremap.git","svn_url":"https://github.com/structuremap/structuremap","homepage":"http://structuremap.github.com","size":26789,"stargazers_count":817,"watchers_count":817,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":281,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":281,"open_issues":36,"watchers":817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/structuremap/structuremap/pulls/632"},"html":{"href":"https://github.com/structuremap/structuremap/pull/632"},"issue":{"href":"https://api.github.com/repos/structuremap/structuremap/issues/632"},"comments":{"href":"https://api.github.com/repos/structuremap/structuremap/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/structuremap/structuremap/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/structuremap/structuremap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/structuremap/structuremap/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/structuremap/structuremap/statuses/85895dec16c9879cb913c95c6e1b8e69adf2873a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jeremydmiller","id":179211,"node_id":"MDQ6VXNlcjE3OTIxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/179211?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremydmiller","html_url":"https://github.com/jeremydmiller","followers_url":"https://api.github.com/users/jeremydmiller/followers","following_url":"https://api.github.com/users/jeremydmiller/following{/other_user}","gists_url":"https://api.github.com/users/jeremydmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremydmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremydmiller/subscriptions","organizations_url":"https://api.github.com/users/jeremydmiller/orgs","repos_url":"https://api.github.com/users/jeremydmiller/repos","events_url":"https://api.github.com/users/jeremydmiller/events{/privacy}","received_events_url":"https://api.github.com/users/jeremydmiller/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":119,"deletions":37,"changed_files":4}}
{"actor":{"display_login":"jeremydmiller"}}