{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/48623","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/48623/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/48623/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/48623/events","html_url":"https://github.com/saltstack/salt/pull/48623","id":341940867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTU4MTM4","number":48623,"title":"Get multiple mines in single mine.get request","user":{"login":"amuhametov","id":652693,"node_id":"MDQ6VXNlcjY1MjY5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/652693?v=4","gravatar_id":"","url":"https://api.github.com/users/amuhametov","html_url":"https://github.com/amuhametov","followers_url":"https://api.github.com/users/amuhametov/followers","following_url":"https://api.github.com/users/amuhametov/following{/other_user}","gists_url":"https://api.github.com/users/amuhametov/gists{/gist_id}","starred_url":"https://api.github.com/users/amuhametov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuhametov/subscriptions","organizations_url":"https://api.github.com/users/amuhametov/orgs","repos_url":"https://api.github.com/users/amuhametov/repos","events_url":"https://api.github.com/users/amuhametov/events{/privacy}","received_events_url":"https://api.github.com/users/amuhametov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-17T14:20:24Z","updated_at":"2018-07-17T15:12:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/48623","html_url":"https://github.com/saltstack/salt/pull/48623","diff_url":"https://github.com/saltstack/salt/pull/48623.diff","patch_url":"https://github.com/saltstack/salt/pull/48623.patch"},"body":"### What does this PR do?\r\nWith more than 10k minons it takes more than 30 seconds to get one mine for '*' target (using consul as cache backend).\r\nThe more mine.get calls I've inside a jinja template, the longer the template executes.\r\n \r\nThis PR allows multiple mines to be returned in a single mine.get request\r\nBackward-compatible, tested with 2017.7\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\nmine.get was able to return single function value only\r\n\r\n### New Behavior\r\nNow you can pass a list as \"fun\" value to mine.get, set \"as_dict=True\" and get a dict as a result\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n### Commits signed with GPG?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/405618334","html_url":"https://github.com/saltstack/salt/pull/48623#issuecomment-405618334","issue_url":"https://api.github.com/repos/saltstack/salt/issues/48623","id":405618334,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTYxODMzNA==","user":{"login":"amuhametov","id":652693,"node_id":"MDQ6VXNlcjY1MjY5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/652693?v=4","gravatar_id":"","url":"https://api.github.com/users/amuhametov","html_url":"https://github.com/amuhametov","followers_url":"https://api.github.com/users/amuhametov/followers","following_url":"https://api.github.com/users/amuhametov/following{/other_user}","gists_url":"https://api.github.com/users/amuhametov/gists{/gist_id}","starred_url":"https://api.github.com/users/amuhametov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuhametov/subscriptions","organizations_url":"https://api.github.com/users/amuhametov/orgs","repos_url":"https://api.github.com/users/amuhametov/repos","events_url":"https://api.github.com/users/amuhametov/events{/privacy}","received_events_url":"https://api.github.com/users/amuhametov/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T15:12:44Z","updated_at":"2018-07-17T15:12:44Z","author_association":"NONE","body":"@gtmanfred \r\nI made it to be close to yumpkg.group_install method.\r\n\r\nWhat if there is a python list of mines I'd get in my code?\r\nJoin them by comma? That seems to be an overhead from the user position for me. Isn't it?\r\n"}}
{"actor":{"display_login":"amuhametov"}}