{"action":"created","issue":{"url":"https://api.github.com/repos/npm/npm/issues/19233","repository_url":"https://api.github.com/repos/npm/npm","labels_url":"https://api.github.com/repos/npm/npm/issues/19233/labels{/name}","comments_url":"https://api.github.com/repos/npm/npm/issues/19233/comments","events_url":"https://api.github.com/repos/npm/npm/issues/19233/events","html_url":"https://github.com/npm/npm/pull/19233","id":276457150,"number":19233,"title":"Stabilize optional shrinkwrapped dependencies.","user":{"login":"jacksonrayhamilton","id":5356588,"avatar_url":"https://avatars1.githubusercontent.com/u/5356588?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksonrayhamilton","html_url":"https://github.com/jacksonrayhamilton","followers_url":"https://api.github.com/users/jacksonrayhamilton/followers","following_url":"https://api.github.com/users/jacksonrayhamilton/following{/other_user}","gists_url":"https://api.github.com/users/jacksonrayhamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksonrayhamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksonrayhamilton/subscriptions","organizations_url":"https://api.github.com/users/jacksonrayhamilton/orgs","repos_url":"https://api.github.com/users/jacksonrayhamilton/repos","events_url":"https://api.github.com/users/jacksonrayhamilton/events{/privacy}","received_events_url":"https://api.github.com/users/jacksonrayhamilton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-23T19:06:00Z","updated_at":"2018-03-06T02:47:01Z","closed_at":"2018-03-06T02:47:01Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/npm/npm/pulls/19233","html_url":"https://github.com/npm/npm/pull/19233","diff_url":"https://github.com/npm/npm/pull/19233.diff","patch_url":"https://github.com/npm/npm/pull/19233.patch"},"body":"Fixes https://github.com/npm/npm/issues/17722, ensuring that optional dependencies from a lockfile which fail to install are not removed from the lockfile.  Example: When `fsevents` is installed on macOS, but later fails to install on GNU/Linux, `fsevents` will not be removed from the lockfile.\r\n\r\nBesides the unit test, I also confirmed that lockfiles remain unchanged on GNU/Linux by running `npm i` in this repo: https://github.com/jacksonrayhamilton/chokidar-test"},"comment":{"url":"https://api.github.com/repos/npm/npm/issues/comments/370643355","html_url":"https://github.com/npm/npm/pull/19233#issuecomment-370643355","issue_url":"https://api.github.com/repos/npm/npm/issues/19233","id":370643355,"user":{"login":"zkat","id":17535,"avatar_url":"https://avatars1.githubusercontent.com/u/17535?v=4","gravatar_id":"","url":"https://api.github.com/users/zkat","html_url":"https://github.com/zkat","followers_url":"https://api.github.com/users/zkat/followers","following_url":"https://api.github.com/users/zkat/following{/other_user}","gists_url":"https://api.github.com/users/zkat/gists{/gist_id}","starred_url":"https://api.github.com/users/zkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkat/subscriptions","organizations_url":"https://api.github.com/users/zkat/orgs","repos_url":"https://api.github.com/users/zkat/repos","events_url":"https://api.github.com/users/zkat/events{/privacy}","received_events_url":"https://api.github.com/users/zkat/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T02:47:01Z","updated_at":"2018-03-06T02:47:01Z","author_association":"OWNER","body":"This should indeed have been overridden by #19054! 👍 "}}
{"actor":{"display_login":"zkat"}}