{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/comments/195179297","pull_request_review_id":128494761,"id":195179297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTE3OTI5Nw==","diff_hunk":"@@ -60,8 +60,13 @@ def self.raw_create_cloud_network(ext_management_system, options)\n   end\n \n   def raw_delete_cloud_network\n-    ext_management_system.with_provider_connection(connection_options(cloud_tenant)) do |service|\n-      service.delete_network(ems_ref)\n+    with_notification(:cloud_network_delete,\n+                      :options => {\n+                        :subject => self,","path":"app/models/manageiq/providers/openstack/network_manager/cloud_network.rb","position":8,"original_position":8,"commit_id":"73b72431cdcbf8592f8f19bb6a2f1565c1f1d3fe","original_commit_id":"73b72431cdcbf8592f8f19bb6a2f1565c1f1d3fe","user":{"login":"mansam","id":628956,"node_id":"MDQ6VXNlcjYyODk1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/628956?v=4","gravatar_id":"","url":"https://api.github.com/users/mansam","html_url":"https://github.com/mansam","followers_url":"https://api.github.com/users/mansam/followers","following_url":"https://api.github.com/users/mansam/following{/other_user}","gists_url":"https://api.github.com/users/mansam/gists{/gist_id}","starred_url":"https://api.github.com/users/mansam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansam/subscriptions","organizations_url":"https://api.github.com/users/mansam/orgs","repos_url":"https://api.github.com/users/mansam/repos","events_url":"https://api.github.com/users/mansam/events{/privacy}","received_events_url":"https://api.github.com/users/mansam/received_events","type":"User","site_admin":false},"body":"When an object is passed as `:subject` like this, does it get translated nicely into a string for the notification message, or does it show up as an object reference?","created_at":"2018-06-13T17:54:52Z","updated_at":"2018-06-13T17:54:52Z","html_url":"https://github.com/ManageIQ/manageiq-providers-openstack/pull/301#discussion_r195179297","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/comments/195179297"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-openstack/pull/301#discussion_r195179297"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301","id":194007183,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDA3MTgz","html_url":"https://github.com/ManageIQ/manageiq-providers-openstack/pull/301","diff_url":"https://github.com/ManageIQ/manageiq-providers-openstack/pull/301.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-openstack/pull/301.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues/301","number":301,"state":"open","locked":false,"title":"Add notifications for Subnets, Networks","user":{"login":"andyvesel","id":8054645,"node_id":"MDQ6VXNlcjgwNTQ2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8054645?v=4","gravatar_id":"","url":"https://api.github.com/users/andyvesel","html_url":"https://github.com/andyvesel","followers_url":"https://api.github.com/users/andyvesel/followers","following_url":"https://api.github.com/users/andyvesel/following{/other_user}","gists_url":"https://api.github.com/users/andyvesel/gists{/gist_id}","starred_url":"https://api.github.com/users/andyvesel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyvesel/subscriptions","organizations_url":"https://api.github.com/users/andyvesel/orgs","repos_url":"https://api.github.com/users/andyvesel/repos","events_url":"https://api.github.com/users/andyvesel/events{/privacy}","received_events_url":"https://api.github.com/users/andyvesel/received_events","type":"User","site_admin":false},"body":"Added notifications for deleting Cloud Network and Cloud Subnet\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1470210\r\nDepends on https://github.com/ManageIQ/manageiq/pull/17556","created_at":"2018-06-11T14:52:07Z","updated_at":"2018-06-13T17:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed49d1567a2046577b89b501fb7ac8e2ce27f0f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues/301/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/statuses/73b72431cdcbf8592f8f19bb6a2f1565c1f1d3fe","head":{"label":"andyvesel:add_notifications_for_subnets_networks","ref":"add_notifications_for_subnets_networks","sha":"73b72431cdcbf8592f8f19bb6a2f1565c1f1d3fe","user":{"login":"andyvesel","id":8054645,"node_id":"MDQ6VXNlcjgwNTQ2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8054645?v=4","gravatar_id":"","url":"https://api.github.com/users/andyvesel","html_url":"https://github.com/andyvesel","followers_url":"https://api.github.com/users/andyvesel/followers","following_url":"https://api.github.com/users/andyvesel/following{/other_user}","gists_url":"https://api.github.com/users/andyvesel/gists{/gist_id}","starred_url":"https://api.github.com/users/andyvesel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyvesel/subscriptions","organizations_url":"https://api.github.com/users/andyvesel/orgs","repos_url":"https://api.github.com/users/andyvesel/repos","events_url":"https://api.github.com/users/andyvesel/events{/privacy}","received_events_url":"https://api.github.com/users/andyvesel/received_events","type":"User","site_admin":false},"repo":{"id":87521942,"node_id":"MDEwOlJlcG9zaXRvcnk4NzUyMTk0Mg==","name":"manageiq-providers-openstack","full_name":"andyvesel/manageiq-providers-openstack","owner":{"login":"andyvesel","id":8054645,"node_id":"MDQ6VXNlcjgwNTQ2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8054645?v=4","gravatar_id":"","url":"https://api.github.com/users/andyvesel","html_url":"https://github.com/andyvesel","followers_url":"https://api.github.com/users/andyvesel/followers","following_url":"https://api.github.com/users/andyvesel/following{/other_user}","gists_url":"https://api.github.com/users/andyvesel/gists{/gist_id}","starred_url":"https://api.github.com/users/andyvesel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyvesel/subscriptions","organizations_url":"https://api.github.com/users/andyvesel/orgs","repos_url":"https://api.github.com/users/andyvesel/repos","events_url":"https://api.github.com/users/andyvesel/events{/privacy}","received_events_url":"https://api.github.com/users/andyvesel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyvesel/manageiq-providers-openstack","description":"ManageIQ plugin for the OpenStack provider","fork":true,"url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack","forks_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/forks","keys_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/teams","hooks_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/hooks","issue_events_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/events","assignees_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/tags","blobs_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/languages","stargazers_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/stargazers","contributors_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/contributors","subscribers_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/subscribers","subscription_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/subscription","commits_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/merges","archive_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/downloads","issues_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/labels{/name}","releases_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/andyvesel/manageiq-providers-openstack/deployments","created_at":"2017-04-07T08:13:58Z","updated_at":"2017-04-07T08:14:00Z","pushed_at":"2018-06-12T08:36:00Z","git_url":"git://github.com/andyvesel/manageiq-providers-openstack.git","ssh_url":"git@github.com:andyvesel/manageiq-providers-openstack.git","clone_url":"https://github.com/andyvesel/manageiq-providers-openstack.git","svn_url":"https://github.com/andyvesel/manageiq-providers-openstack","homepage":null,"size":47753,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a53c2b9a614cc054211ddbdf82f03b00e3bd7101","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":87438492,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQzODQ5Mg==","name":"manageiq-providers-openstack","full_name":"ManageIQ/manageiq-providers-openstack","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-openstack","description":"ManageIQ plugin for the OpenStack provider","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/deployments","created_at":"2017-04-06T14:26:19Z","updated_at":"2018-06-13T14:17:32Z","pushed_at":"2018-06-13T14:17:29Z","git_url":"git://github.com/ManageIQ/manageiq-providers-openstack.git","ssh_url":"git@github.com:ManageIQ/manageiq-providers-openstack.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-openstack.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-openstack","homepage":null,"size":51185,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":50,"open_issues":27,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-openstack/pull/301"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues/301"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-openstack/statuses/73b72431cdcbf8592f8f19bb6a2f1565c1f1d3fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mansam"}}