{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments/208423166","pull_request_review_id":144229429,"id":208423166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQyMzE2Ng==","diff_hunk":"@@ -15,21 +15,29 @@ class ZippedMoabVersion < ApplicationRecord\n   # but queue locking easily prevents duplicates (and the job is idempotent anyway).\n   after_create :replicate!\n \n-  # @note Hash values cannot be modified without migrating any associated persisted data.\n-  # @see [enum docs] http://api.rubyonrails.org/classes/ActiveRecord/Enum.html\n-  enum status: {\n-    'ok' => 0,\n-    'unreplicated' => 1,\n-    'archive_not_found' => 2,\n-    'invalid_checksum' => 3\n-  }\n-\n-  validates :complete_moab, :status, :version, :zip_endpoint, presence: true\n+  validates :complete_moab, :version, :zip_endpoint, presence: true\n \n   scope :by_druid, lambda { |druid|\n     joins(complete_moab: [:preserved_object]).where(preserved_objects: { druid: druid })\n   }\n \n+  # ideally, there should be only one distinct parts_count value among a set of sibbling","path":"app/models/zipped_moab_version.rb","position":20,"original_position":20,"commit_id":"c6a4cf2fe2e32c50c6f7455f1edf7c2a3ae53561","original_commit_id":"c6a4cf2fe2e32c50c6f7455f1edf7c2a3ae53561","user":{"login":"jmartin-sul","id":7741604,"node_id":"MDQ6VXNlcjc3NDE2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7741604?v=4","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"body":"d'oh 🤦‍♂️ ","created_at":"2018-08-08T00:15:21Z","updated_at":"2018-08-08T00:15:21Z","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/1008#discussion_r208423166","pull_request_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments/208423166"},"html":{"href":"https://github.com/sul-dlss/preservation_catalog/pull/1008#discussion_r208423166"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008"}},"in_reply_to_id":208421313},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008","id":203362315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzYyMzE1","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/1008","diff_url":"https://github.com/sul-dlss/preservation_catalog/pull/1008.diff","patch_url":"https://github.com/sul-dlss/preservation_catalog/pull/1008.patch","issue_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/1008","number":1008,"state":"open","locked":false,"title":"re-work ReplicatedFileCheckJob to deal with multi-part zips","user":{"login":"jmartin-sul","id":7741604,"node_id":"MDQ6VXNlcjc3NDE2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7741604?v=4","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"body":"this branch started out as an attempt to address #973 (hence the name).  but it turns out the test code using the deprecated fixtures was testing app code that needed to be re-worked, because the app code predated the model split (#927) and the subsequent implementation of multi-part druid-version zips.\r\n\r\nthis PR will address the deprecated fixtures in the course of re-working the app and test code for the updated data model.\r\n\r\ncloses #973 \r\ncloses #994\r\ncloses #998\r\n","created_at":"2018-07-23T22:32:47Z","updated_at":"2018-08-08T00:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff638217c7a8070dfdb35aeb15d86b5ae55b5c33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":719133329,"node_id":"MDU6TGFiZWw3MTkxMzMzMjk=","url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels/needs%20review","name":"needs review","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/1008/comments","statuses_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/c6a4cf2fe2e32c50c6f7455f1edf7c2a3ae53561","head":{"label":"sul-dlss:remove_deprecated_fixtures","ref":"remove_deprecated_fixtures","sha":"c6a4cf2fe2e32c50c6f7455f1edf7c2a3ae53561","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":100517453,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MTc0NTM=","name":"preservation_catalog","full_name":"sul-dlss/preservation_catalog","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/preservation_catalog","description":"Rails application to track, audit and replicate archival artifacts associated with SDR objects.","fork":false,"url":"https://api.github.com/repos/sul-dlss/preservation_catalog","forks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/forks","keys_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/teams","hooks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/events","assignees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/tags","blobs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscription","commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/merges","archive_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/downloads","issues_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/deployments","created_at":"2017-08-16T17:55:52Z","updated_at":"2018-08-07T23:51:40Z","pushed_at":"2018-08-07T23:51:43Z","git_url":"git://github.com/sul-dlss/preservation_catalog.git","ssh_url":"git@github.com:sul-dlss/preservation_catalog.git","clone_url":"https://github.com/sul-dlss/preservation_catalog.git","svn_url":"https://github.com/sul-dlss/preservation_catalog","homepage":"","size":272383,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":68,"watchers":1,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"06e412d8864eafbf7d644353a75929db0da0eeda","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":100517453,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MTc0NTM=","name":"preservation_catalog","full_name":"sul-dlss/preservation_catalog","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/preservation_catalog","description":"Rails application to track, audit and replicate archival artifacts associated with SDR objects.","fork":false,"url":"https://api.github.com/repos/sul-dlss/preservation_catalog","forks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/forks","keys_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/teams","hooks_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/events","assignees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/tags","blobs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/subscription","commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/merges","archive_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/downloads","issues_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/deployments","created_at":"2017-08-16T17:55:52Z","updated_at":"2018-08-07T23:51:40Z","pushed_at":"2018-08-07T23:51:43Z","git_url":"git://github.com/sul-dlss/preservation_catalog.git","ssh_url":"git@github.com:sul-dlss/preservation_catalog.git","clone_url":"https://github.com/sul-dlss/preservation_catalog.git","svn_url":"https://github.com/sul-dlss/preservation_catalog","homepage":"","size":272383,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":68,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008"},"html":{"href":"https://github.com/sul-dlss/preservation_catalog/pull/1008"},"issue":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/1008"},"comments":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/1008/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/1008/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/preservation_catalog/statuses/c6a4cf2fe2e32c50c6f7455f1edf7c2a3ae53561"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmartin-sul"}}