{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/196092223","pull_request_review_id":129579221,"id":196092223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA5MjIyMw==","diff_hunk":"@@ -535,8 +535,11 @@ func GenerateConfigsForGroup(\n \t\t\tMemRequest:     26214400, // 25MB\n \t\t\tSecretNames:    secretNames,\n \t\t\tConfigMapNames: configMapNames,\n-\t\t\t// Define a label to group every 2 RCs into one service.\n-\t\t\tLabels: map[string]string{svcLabelKey: groupName + \"-\" + strconv.Itoa((i+1)/2)},\n+\t\t}\n+\n+\t\t// Add a label to alternate RCs, to include only half of them in services.\n+\t\tif i%2 == 0 {","path":"test/e2e/scalability/load.go","position":null,"original_position":9,"commit_id":"8e562f69915746a87650d89c566c49505405d9c5","original_commit_id":"3768d8a9a3718d982a38f760e5bde45cc786e747","user":{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"> I want to avoid doing it manually each time I tweak the value :) Also want the cluster logs recorded in gcs.\r\n\r\n>> you can run manual test on 2k-node test with 75pods/node or sth like that\r\n\r\n> That's a good idea. But maybe we shouldn't change other params at the same time (like #watches, master size, #pods/node, etc) to avoid potentially different influences. Wdyt?\r\n\r\nYes - we shouldn't change to many params at the same time in general.\r\nHowever, in this particular case, your goal is to only discover the limits of iptables, and for that particular purpose the smaller cluster we can achieve it with, the better.\r\n\r\nI buy the argument why do you don't want to run it manually. But I also don't think that changing our main (release-blocking) tests for that purpose is the best idea.\r\n\r\nWhat I started thinking about is that:\r\n- we have this \"manual-start\" test-suite (which we are not utilizing at all)\r\n- maybe what we can do is start utilizing it for exactly that purpose\r\n- e.g. experiment would look like:\r\n(a) send a PR to modify this manual test (to do what you want)\r\n(b) manually trigger that job\r\n(c) [optionally] revert that PR\r\n\r\nWhat that would give us is:\r\n- having logs in GCS\r\n- ensuring that exactly one jobs is running at a given time (longer term once we have a cluster loader that should be the mechanism coordinating experiments in my opinion)\r\n- history of what experiments we were doing in the repo :)\r\n\r\nBTW - given that those \"manual\" suites weren't run even once, what I would suggest it switching them into:\r\n- manual-gce\r\n- manual-gke\r\n[without -up and -down]\r\nand starting using them for exactly that purpose\r\n\r\nThoughts?","created_at":"2018-06-18T14:11:10Z","updated_at":"2018-06-18T14:11:10Z","html_url":"https://github.com/kubernetes/kubernetes/pull/65179#discussion_r196092223","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/196092223"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/65179#discussion_r196092223"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179"}},"in_reply_to_id":196070029},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179","id":195517783,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTE3Nzgz","html_url":"https://github.com/kubernetes/kubernetes/pull/65179","diff_url":"https://github.com/kubernetes/kubernetes/pull/65179.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/65179.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65179","number":65179,"state":"open","locked":false,"title":"Half the no. of endpoints in load test","user":{"login":"shyamjvs","id":4333971,"node_id":"MDQ6VXNlcjQzMzM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4333971?v=4","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"body":"Experimenting with https://github.com/kubernetes/kubernetes/issues/48107#issuecomment-398018717\r\n\r\n/cc @wojtek-t \r\n\r\n```release-note\r\nNONE\r\n```\r\n\r\n/kind bug\r\n/sig scalability\r\n/priority important-soon","created_at":"2018-06-18T13:02:38Z","updated_at":"2018-06-18T14:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1486a5f3829dc8ae8d244f51060e155b7762f4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":125010198,"node_id":"MDU6TGFiZWwxMjUwMTAxOTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scalability","name":"sig/scalability","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65179/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8e562f69915746a87650d89c566c49505405d9c5","head":{"label":"shyamjvs:reduce-service-endpoints-in-load-test","ref":"reduce-service-endpoints-in-load-test","sha":"8e562f69915746a87650d89c566c49505405d9c5","user":{"login":"shyamjvs","id":4333971,"node_id":"MDQ6VXNlcjQzMzM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4333971?v=4","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"repo":{"id":74686020,"node_id":"MDEwOlJlcG9zaXRvcnk3NDY4NjAyMA==","name":"kubernetes","full_name":"shyamjvs/kubernetes","owner":{"login":"shyamjvs","id":4333971,"node_id":"MDQ6VXNlcjQzMzM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4333971?v=4","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shyamjvs/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/shyamjvs/kubernetes","forks_url":"https://api.github.com/repos/shyamjvs/kubernetes/forks","keys_url":"https://api.github.com/repos/shyamjvs/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shyamjvs/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shyamjvs/kubernetes/teams","hooks_url":"https://api.github.com/repos/shyamjvs/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/shyamjvs/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/shyamjvs/kubernetes/events","assignees_url":"https://api.github.com/repos/shyamjvs/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/shyamjvs/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/shyamjvs/kubernetes/tags","blobs_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shyamjvs/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/shyamjvs/kubernetes/languages","stargazers_url":"https://api.github.com/repos/shyamjvs/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/shyamjvs/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/shyamjvs/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/shyamjvs/kubernetes/subscription","commits_url":"https://api.github.com/repos/shyamjvs/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/shyamjvs/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/shyamjvs/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/shyamjvs/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/shyamjvs/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/shyamjvs/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shyamjvs/kubernetes/merges","archive_url":"https://api.github.com/repos/shyamjvs/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shyamjvs/kubernetes/downloads","issues_url":"https://api.github.com/repos/shyamjvs/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/shyamjvs/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/shyamjvs/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/shyamjvs/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shyamjvs/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/shyamjvs/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/shyamjvs/kubernetes/deployments","created_at":"2016-11-24T15:40:48Z","updated_at":"2018-04-24T12:34:11Z","pushed_at":"2018-06-18T13:53:17Z","git_url":"git://github.com/shyamjvs/kubernetes.git","ssh_url":"git@github.com:shyamjvs/kubernetes.git","clone_url":"https://github.com/shyamjvs/kubernetes.git","svn_url":"https://github.com/shyamjvs/kubernetes","homepage":"http://kubernetes.io","size":561886,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6d3f5b75f56323888701da27a48bc4c0f52ab106","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-06-18T14:04:08Z","pushed_at":"2018-06-18T13:53:21Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":785721,"stargazers_count":37700,"watchers_count":37700,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13166,"mirror_url":null,"archived":false,"open_issues_count":3230,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13166,"open_issues":3230,"watchers":37700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/65179"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/65179"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/65179/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65179/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8e562f69915746a87650d89c566c49505405d9c5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wojtek-t"}}