{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/9543","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9543/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9543/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9543/events","html_url":"https://github.com/kubernetes/test-infra/pull/9543","id":363273957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzUxODk2","number":9543,"title":"[WIP] Bundle Deck JavaScript using bazel/rollup","user":{"login":"Katharine","id":110792,"node_id":"MDQ6VXNlcjExMDc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/110792?v=4","gravatar_id":"","url":"https://api.github.com/users/Katharine","html_url":"https://github.com/Katharine","followers_url":"https://api.github.com/users/Katharine/followers","following_url":"https://api.github.com/users/Katharine/following{/other_user}","gists_url":"https://api.github.com/users/Katharine/gists{/gist_id}","starred_url":"https://api.github.com/users/Katharine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katharine/subscriptions","organizations_url":"https://api.github.com/users/Katharine/orgs","repos_url":"https://api.github.com/users/Katharine/repos","events_url":"https://api.github.com/users/Katharine/events{/privacy}","received_events_url":"https://api.github.com/users/Katharine/received_events","type":"User","site_admin":false},"labels":[{"id":412127043,"node_id":"MDU6TGFiZWw0MTIxMjcwNDM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":1039749392,"node_id":"MDU6TGFiZWwxMDM5NzQ5Mzky","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow/deck","name":"area/prow/deck","color":"0052cc","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687190615,"node_id":"MDU6TGFiZWw2ODcxOTA2MTU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":954632369,"node_id":"MDU6TGFiZWw5NTQ2MzIzNjk=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":671133413,"node_id":"MDU6TGFiZWw2NzExMzM0MTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-24T18:47:27Z","updated_at":"2018-09-24T23:46:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9543","html_url":"https://github.com/kubernetes/test-infra/pull/9543","diff_url":"https://github.com/kubernetes/test-infra/pull/9543.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/9543.patch"},"body":"Use bazel, rollup and (a less outdated version of) rules_nodejs to build the deck JavaScript using rollup. (Why rollup? because it's what rules_nodejs supports and absolutely no other reason.)\r\n\r\nThis is a first step towards using typescript (because in this world it appears we don't use typescript's own bundling).\r\n\r\nThis PR focuses on making the JavaScript build with minimal changes. It does:\r\n\r\n* remove third-party code that was dropped into `static/`\r\n* maks changes where necessary to make `tsc` (used by rules_nodejs for es5 downlevelling) behave properly.\r\n\r\nA later PR will focus on actual cleanup.\r\n\r\nI also committed the entire node_modules folder, which is fairly gigantic. This is in line with what we do elsewhere  (e.g. in triage, and also akin to vendoring all our go deps), but I don't really like it and it's also now considered deprecated by the rules_nodejs people (who would rather we have a single node_modules and then list out our dependencies in `WORKSPACE`).\r\n\r\nThis PR still supports `./runlocal` properly and should still generate workable images, but those not using bazel to build their prow images will find that they have no JavaScript.\r\n\r\nAlso, I have no idea what I'm doing with bazel. Please point out my stupid mistakes.\r\n\r\n/area prow/deck\r\n/kind cleanup"},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/424161524","html_url":"https://github.com/kubernetes/test-infra/pull/9543#issuecomment-424161524","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9543","id":424161524,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDE2MTUyNA==","user":{"login":"ixdy","id":8061296,"node_id":"MDQ6VXNlcjgwNjEyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8061296?v=4","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T23:46:52Z","updated_at":"2018-09-24T23:46:52Z","author_association":"MEMBER","body":"/lgtm\r\n/hold"}}
{"actor":{"display_login":"ixdy"}}