{"action":"created","comment":{"url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/comments/237970532","pull_request_review_id":180408097,"id":237970532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzk3MDUzMg==","diff_hunk":"@@ -17,6 +17,14 @@ if [[ ! $(kubectl get namespace $NAMESPACE) ]]; then\n   kubectl create namespace $NAMESPACE;\n fi\n \n+# Set tiller_namespace if it isn't already set.\n+# Allows us to use helm even if it's not installed\n+# in kube-system.\n+if [ -z \"$TILLER_NAMESPACE\" ]; then\n+  TILLER_NAMESPACE=\"$(kubectl get deploy -o wide --all-namespaces | grep tiller-deploy | tail -n 1 | cut -d ' ' -f 1 | tr -d ' ')\"","path":"bin/helm-deploy","position":8,"original_position":8,"commit_id":"a7729691a667c46dd1a8bf1aa171282a93aa9c6a","original_commit_id":"a7729691a667c46dd1a8bf1aa171282a93aa9c6a","user":{"login":"robscott","id":419322,"node_id":"MDQ6VXNlcjQxOTMyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/419322?v=4","gravatar_id":"","url":"https://api.github.com/users/robscott","html_url":"https://github.com/robscott","followers_url":"https://api.github.com/users/robscott/followers","following_url":"https://api.github.com/users/robscott/following{/other_user}","gists_url":"https://api.github.com/users/robscott/gists{/gist_id}","starred_url":"https://api.github.com/users/robscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robscott/subscriptions","organizations_url":"https://api.github.com/users/robscott/orgs","repos_url":"https://api.github.com/users/robscott/repos","events_url":"https://api.github.com/users/robscott/events{/privacy}","received_events_url":"https://api.github.com/users/robscott/received_events","type":"User","site_admin":false},"body":"Instead of the first grep, we could use a label selector `kubectl get deploy --all-namespaces -l app=helm,name=tiller`.","created_at":"2018-11-30T19:11:19Z","updated_at":"2018-11-30T19:12:55Z","html_url":"https://github.com/reactiveops/rok8s-scripts/pull/209#discussion_r237970532","pull_request_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/comments/237970532"},"html":{"href":"https://github.com/reactiveops/rok8s-scripts/pull/209#discussion_r237970532"},"pull_request":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209","id":235064776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDY0Nzc2","html_url":"https://github.com/reactiveops/rok8s-scripts/pull/209","diff_url":"https://github.com/reactiveops/rok8s-scripts/pull/209.diff","patch_url":"https://github.com/reactiveops/rok8s-scripts/pull/209.patch","issue_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/209","number":209,"state":"open","locked":false,"title":"Tiller support in non-default namespaces","user":{"login":"mjhuber","id":19253559,"node_id":"MDQ6VXNlcjE5MjUzNTU5","avatar_url":"https://avatars2.githubusercontent.com/u/19253559?v=4","gravatar_id":"","url":"https://api.github.com/users/mjhuber","html_url":"https://github.com/mjhuber","followers_url":"https://api.github.com/users/mjhuber/followers","following_url":"https://api.github.com/users/mjhuber/following{/other_user}","gists_url":"https://api.github.com/users/mjhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhuber/subscriptions","organizations_url":"https://api.github.com/users/mjhuber/orgs","repos_url":"https://api.github.com/users/mjhuber/repos","events_url":"https://api.github.com/users/mjhuber/events{/privacy}","received_events_url":"https://api.github.com/users/mjhuber/received_events","type":"User","site_admin":false},"body":"This PR sets the `TILLER_NAMESPACE` variable if it's not already set.  This allows `helm-deploy` to work if tiller is not installed in `kube-system` and the variable isn't set.","created_at":"2018-11-30T17:42:20Z","updated_at":"2018-11-30T19:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f7c39ac37282c74bd5e0a69c1da59a00aeda65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ejether","id":686540,"node_id":"MDQ6VXNlcjY4NjU0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/686540?v=4","gravatar_id":"","url":"https://api.github.com/users/ejether","html_url":"https://github.com/ejether","followers_url":"https://api.github.com/users/ejether/followers","following_url":"https://api.github.com/users/ejether/following{/other_user}","gists_url":"https://api.github.com/users/ejether/gists{/gist_id}","starred_url":"https://api.github.com/users/ejether/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejether/subscriptions","organizations_url":"https://api.github.com/users/ejether/orgs","repos_url":"https://api.github.com/users/ejether/repos","events_url":"https://api.github.com/users/ejether/events{/privacy}","received_events_url":"https://api.github.com/users/ejether/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209/commits","review_comments_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209/comments","review_comment_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/209/comments","statuses_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/statuses/a7729691a667c46dd1a8bf1aa171282a93aa9c6a","head":{"label":"reactiveops:tiller-namespace","ref":"tiller-namespace","sha":"a7729691a667c46dd1a8bf1aa171282a93aa9c6a","user":{"login":"reactiveops","id":8583528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODM1Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8583528?v=4","gravatar_id":"","url":"https://api.github.com/users/reactiveops","html_url":"https://github.com/reactiveops","followers_url":"https://api.github.com/users/reactiveops/followers","following_url":"https://api.github.com/users/reactiveops/following{/other_user}","gists_url":"https://api.github.com/users/reactiveops/gists{/gist_id}","starred_url":"https://api.github.com/users/reactiveops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactiveops/subscriptions","organizations_url":"https://api.github.com/users/reactiveops/orgs","repos_url":"https://api.github.com/users/reactiveops/repos","events_url":"https://api.github.com/users/reactiveops/events{/privacy}","received_events_url":"https://api.github.com/users/reactiveops/received_events","type":"Organization","site_admin":false},"repo":{"id":67222419,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIyMjQxOQ==","name":"rok8s-scripts","full_name":"reactiveops/rok8s-scripts","private":false,"owner":{"login":"reactiveops","id":8583528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODM1Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8583528?v=4","gravatar_id":"","url":"https://api.github.com/users/reactiveops","html_url":"https://github.com/reactiveops","followers_url":"https://api.github.com/users/reactiveops/followers","following_url":"https://api.github.com/users/reactiveops/following{/other_user}","gists_url":"https://api.github.com/users/reactiveops/gists{/gist_id}","starred_url":"https://api.github.com/users/reactiveops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactiveops/subscriptions","organizations_url":"https://api.github.com/users/reactiveops/orgs","repos_url":"https://api.github.com/users/reactiveops/repos","events_url":"https://api.github.com/users/reactiveops/events{/privacy}","received_events_url":"https://api.github.com/users/reactiveops/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactiveops/rok8s-scripts","description":"Opinionated scripts for managing application deployment lifecycle in Kubernetes","fork":false,"url":"https://api.github.com/repos/reactiveops/rok8s-scripts","forks_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/forks","keys_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/teams","hooks_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/hooks","issue_events_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/events","assignees_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/tags","blobs_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/languages","stargazers_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/stargazers","contributors_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/contributors","subscribers_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/subscribers","subscription_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/subscription","commits_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/merges","archive_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/downloads","issues_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/labels{/name}","releases_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/deployments","created_at":"2016-09-02T12:54:05Z","updated_at":"2018-11-28T07:34:17Z","pushed_at":"2018-11-30T17:42:20Z","git_url":"git://github.com/reactiveops/rok8s-scripts.git","ssh_url":"git@github.com:reactiveops/rok8s-scripts.git","clone_url":"https://github.com/reactiveops/rok8s-scripts.git","svn_url":"https://github.com/reactiveops/rok8s-scripts","homepage":"https://www.reactiveops.com","size":3051,"stargazers_count":104,"watchers_count":104,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":19,"watchers":104,"default_branch":"master"}},"base":{"label":"reactiveops:master","ref":"master","sha":"a797ff381a1a0bd365276cf3a554914d72f2c6ad","user":{"login":"reactiveops","id":8583528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODM1Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8583528?v=4","gravatar_id":"","url":"https://api.github.com/users/reactiveops","html_url":"https://github.com/reactiveops","followers_url":"https://api.github.com/users/reactiveops/followers","following_url":"https://api.github.com/users/reactiveops/following{/other_user}","gists_url":"https://api.github.com/users/reactiveops/gists{/gist_id}","starred_url":"https://api.github.com/users/reactiveops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactiveops/subscriptions","organizations_url":"https://api.github.com/users/reactiveops/orgs","repos_url":"https://api.github.com/users/reactiveops/repos","events_url":"https://api.github.com/users/reactiveops/events{/privacy}","received_events_url":"https://api.github.com/users/reactiveops/received_events","type":"Organization","site_admin":false},"repo":{"id":67222419,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIyMjQxOQ==","name":"rok8s-scripts","full_name":"reactiveops/rok8s-scripts","private":false,"owner":{"login":"reactiveops","id":8583528,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODM1Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8583528?v=4","gravatar_id":"","url":"https://api.github.com/users/reactiveops","html_url":"https://github.com/reactiveops","followers_url":"https://api.github.com/users/reactiveops/followers","following_url":"https://api.github.com/users/reactiveops/following{/other_user}","gists_url":"https://api.github.com/users/reactiveops/gists{/gist_id}","starred_url":"https://api.github.com/users/reactiveops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactiveops/subscriptions","organizations_url":"https://api.github.com/users/reactiveops/orgs","repos_url":"https://api.github.com/users/reactiveops/repos","events_url":"https://api.github.com/users/reactiveops/events{/privacy}","received_events_url":"https://api.github.com/users/reactiveops/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactiveops/rok8s-scripts","description":"Opinionated scripts for managing application deployment lifecycle in Kubernetes","fork":false,"url":"https://api.github.com/repos/reactiveops/rok8s-scripts","forks_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/forks","keys_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/teams","hooks_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/hooks","issue_events_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/events","assignees_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/tags","blobs_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/languages","stargazers_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/stargazers","contributors_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/contributors","subscribers_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/subscribers","subscription_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/subscription","commits_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/merges","archive_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/downloads","issues_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/labels{/name}","releases_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/reactiveops/rok8s-scripts/deployments","created_at":"2016-09-02T12:54:05Z","updated_at":"2018-11-28T07:34:17Z","pushed_at":"2018-11-30T17:42:20Z","git_url":"git://github.com/reactiveops/rok8s-scripts.git","ssh_url":"git@github.com:reactiveops/rok8s-scripts.git","clone_url":"https://github.com/reactiveops/rok8s-scripts.git","svn_url":"https://github.com/reactiveops/rok8s-scripts","homepage":"https://www.reactiveops.com","size":3051,"stargazers_count":104,"watchers_count":104,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":19,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209"},"html":{"href":"https://github.com/reactiveops/rok8s-scripts/pull/209"},"issue":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/209"},"comments":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/reactiveops/rok8s-scripts/statuses/a7729691a667c46dd1a8bf1aa171282a93aa9c6a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robscott"}}