{"action":"created","comment":{"url":"https://api.github.com/repos/mjdenham/and-bible/pulls/comments/211084844","pull_request_review_id":147438079,"id":211084844,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA4NDg0NA==","diff_hunk":"@@ -4,11 +4,12 @@\n       android:installLocation=\"auto\"\n       android:versionName=\"2.11.0.245\" android:versionCode=\"245\">\n \n+    <uses-permission android:name=\"android.permission.READ_EXTERNAL_STORAGE\"/>","path":"and-bible/app/src/main/AndroidManifest.xml","position":4,"original_position":4,"commit_id":"cb69e31ed30351754256466633e9e69756def2a6","original_commit_id":"cb69e31ed30351754256466633e9e69756def2a6","user":{"login":"mjdenham","id":313777,"node_id":"MDQ6VXNlcjMxMzc3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/313777?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenham","html_url":"https://github.com/mjdenham","followers_url":"https://api.github.com/users/mjdenham/followers","following_url":"https://api.github.com/users/mjdenham/following{/other_user}","gists_url":"https://api.github.com/users/mjdenham/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenham/subscriptions","organizations_url":"https://api.github.com/users/mjdenham/orgs","repos_url":"https://api.github.com/users/mjdenham/repos","events_url":"https://api.github.com/users/mjdenham/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenham/received_events","type":"User","site_admin":false},"body":"I think there is a way of declaring that another app can freely access your apps storage, which would be nice to give to other Sword apps like And Bible Addons.  However, I can't find the technique - I will keep looking - unless you find it first.","created_at":"2018-08-18T20:05:16Z","updated_at":"2018-08-18T20:07:10Z","html_url":"https://github.com/mjdenham/and-bible/pull/143#discussion_r211084844","pull_request_url":"https://api.github.com/repos/mjdenham/and-bible/pulls/143","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mjdenham/and-bible/pulls/comments/211084844"},"html":{"href":"https://github.com/mjdenham/and-bible/pull/143#discussion_r211084844"},"pull_request":{"href":"https://api.github.com/repos/mjdenham/and-bible/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/mjdenham/and-bible/pulls/143","id":203041616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDQxNjE2","html_url":"https://github.com/mjdenham/and-bible/pull/143","diff_url":"https://github.com/mjdenham/and-bible/pull/143.diff","patch_url":"https://github.com/mjdenham/and-bible/pull/143.patch","issue_url":"https://api.github.com/repos/mjdenham/and-bible/issues/143","number":143,"state":"open","locked":false,"title":"Sdk target update to 27","user":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"body":"- [x] Upgrade SDK version to 27\r\n- [x] Screen timeout\r\n- [x] Request permission to save/restore backup to external storage\r\n- [x] Check phone state reading permissions (=> no permissions query needed)\r\n- [x] Check permission to access manual install dir (sdcard/jsword)\r\n- [x] Investigate how Andbible addons can install modules => It can do it with by requesting WRITE_EXTERMAL_STORAGE permission. \r\n- [x] Request permission to access manual instal dir (sdcard/jsword)\r\n- [x] Notification for document downloading is broken (fixed)\r\n- [x] Test with different targets in emulator\r\n- [x] Incoming call handling bugs\r\n\r\n## Test results (test made before rebasing changes to development):\r\n\r\n### Search index creation and find:\r\nkitkat 19: OK\r\nlollipop 21:  OK\r\nmarshmallow 23: **NOK**\r\nnougat 25: OK\r\noreo 26: OK\r\nP 28: OK\r\n\r\n### Download:\r\nkitkat 19 OK\r\nlollipop: OK\r\nMarshMallow OK\r\nnougat OK\r\nOreo OK\r\nP: OK\r\n\r\n### Speak and notification: \r\nkitkat OK\r\nlollipop: OK\r\nMarshmallow OK\r\nNougat OK\r\nOreo OK\r\nP: OK\r\n\r\n### Widget:\r\nKitkat OK\r\nLollipop OK\r\nMarshmallow OK\r\nNougat OK\r\nOreo OK\r\nP: OK\r\n\r\n### Stop speaking on phonecall:\r\nKitkat OK\r\nLollipop OK\r\nMarshmallow OK\r\nNougat OK\r\nOreo OK\r\nP: OK\r\n\r\n\r\nUpdated notification:\r\n![screenshot_1531064037](https://user-images.githubusercontent.com/5811789/42421393-8dc0385c-82dd-11e8-8b7d-1ca82f772a4d.png)\r\n","created_at":"2018-07-22T06:04:53Z","updated_at":"2018-08-18T20:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a72832c8021b28f57b6520839960e44a97a06e42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mjdenham/and-bible/pulls/143/commits","review_comments_url":"https://api.github.com/repos/mjdenham/and-bible/pulls/143/comments","review_comment_url":"https://api.github.com/repos/mjdenham/and-bible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjdenham/and-bible/issues/143/comments","statuses_url":"https://api.github.com/repos/mjdenham/and-bible/statuses/cb69e31ed30351754256466633e9e69756def2a6","head":{"label":"tuomas2:feature/sdk-only","ref":"feature/sdk-only","sha":"cb69e31ed30351754256466633e9e69756def2a6","user":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"repo":{"id":37821990,"node_id":"MDEwOlJlcG9zaXRvcnkzNzgyMTk5MA==","name":"and-bible","full_name":"tuomas2/and-bible","owner":{"login":"tuomas2","id":5811789,"node_id":"MDQ6VXNlcjU4MTE3ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5811789?v=4","gravatar_id":"","url":"https://api.github.com/users/tuomas2","html_url":"https://github.com/tuomas2","followers_url":"https://api.github.com/users/tuomas2/followers","following_url":"https://api.github.com/users/tuomas2/following{/other_user}","gists_url":"https://api.github.com/users/tuomas2/gists{/gist_id}","starred_url":"https://api.github.com/users/tuomas2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuomas2/subscriptions","organizations_url":"https://api.github.com/users/tuomas2/orgs","repos_url":"https://api.github.com/users/tuomas2/repos","events_url":"https://api.github.com/users/tuomas2/events{/privacy}","received_events_url":"https://api.github.com/users/tuomas2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuomas2/and-bible","description":"Bible on Android","fork":true,"url":"https://api.github.com/repos/tuomas2/and-bible","forks_url":"https://api.github.com/repos/tuomas2/and-bible/forks","keys_url":"https://api.github.com/repos/tuomas2/and-bible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuomas2/and-bible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuomas2/and-bible/teams","hooks_url":"https://api.github.com/repos/tuomas2/and-bible/hooks","issue_events_url":"https://api.github.com/repos/tuomas2/and-bible/issues/events{/number}","events_url":"https://api.github.com/repos/tuomas2/and-bible/events","assignees_url":"https://api.github.com/repos/tuomas2/and-bible/assignees{/user}","branches_url":"https://api.github.com/repos/tuomas2/and-bible/branches{/branch}","tags_url":"https://api.github.com/repos/tuomas2/and-bible/tags","blobs_url":"https://api.github.com/repos/tuomas2/and-bible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuomas2/and-bible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuomas2/and-bible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuomas2/and-bible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuomas2/and-bible/statuses/{sha}","languages_url":"https://api.github.com/repos/tuomas2/and-bible/languages","stargazers_url":"https://api.github.com/repos/tuomas2/and-bible/stargazers","contributors_url":"https://api.github.com/repos/tuomas2/and-bible/contributors","subscribers_url":"https://api.github.com/repos/tuomas2/and-bible/subscribers","subscription_url":"https://api.github.com/repos/tuomas2/and-bible/subscription","commits_url":"https://api.github.com/repos/tuomas2/and-bible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuomas2/and-bible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuomas2/and-bible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuomas2/and-bible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuomas2/and-bible/contents/{+path}","compare_url":"https://api.github.com/repos/tuomas2/and-bible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuomas2/and-bible/merges","archive_url":"https://api.github.com/repos/tuomas2/and-bible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuomas2/and-bible/downloads","issues_url":"https://api.github.com/repos/tuomas2/and-bible/issues{/number}","pulls_url":"https://api.github.com/repos/tuomas2/and-bible/pulls{/number}","milestones_url":"https://api.github.com/repos/tuomas2/and-bible/milestones{/number}","notifications_url":"https://api.github.com/repos/tuomas2/and-bible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuomas2/and-bible/labels{/name}","releases_url":"https://api.github.com/repos/tuomas2/and-bible/releases{/id}","deployments_url":"https://api.github.com/repos/tuomas2/and-bible/deployments","created_at":"2015-06-21T19:09:47Z","updated_at":"2018-04-19T08:57:04Z","pushed_at":"2018-08-18T10:16:46Z","git_url":"git://github.com/tuomas2/and-bible.git","ssh_url":"git@github.com:tuomas2/and-bible.git","clone_url":"https://github.com/tuomas2/and-bible.git","svn_url":"https://github.com/tuomas2/and-bible","homepage":"http://mjdenham.github.io/and-bible/","size":102887,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"mjdenham:development","ref":"development","sha":"9476b50690f1f320eb7e2916f3ab3d94022646e2","user":{"login":"mjdenham","id":313777,"node_id":"MDQ6VXNlcjMxMzc3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/313777?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenham","html_url":"https://github.com/mjdenham","followers_url":"https://api.github.com/users/mjdenham/followers","following_url":"https://api.github.com/users/mjdenham/following{/other_user}","gists_url":"https://api.github.com/users/mjdenham/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenham/subscriptions","organizations_url":"https://api.github.com/users/mjdenham/orgs","repos_url":"https://api.github.com/users/mjdenham/repos","events_url":"https://api.github.com/users/mjdenham/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenham/received_events","type":"User","site_admin":false},"repo":{"id":2463519,"node_id":"MDEwOlJlcG9zaXRvcnkyNDYzNTE5","name":"and-bible","full_name":"mjdenham/and-bible","owner":{"login":"mjdenham","id":313777,"node_id":"MDQ6VXNlcjMxMzc3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/313777?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenham","html_url":"https://github.com/mjdenham","followers_url":"https://api.github.com/users/mjdenham/followers","following_url":"https://api.github.com/users/mjdenham/following{/other_user}","gists_url":"https://api.github.com/users/mjdenham/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenham/subscriptions","organizations_url":"https://api.github.com/users/mjdenham/orgs","repos_url":"https://api.github.com/users/mjdenham/repos","events_url":"https://api.github.com/users/mjdenham/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjdenham/and-bible","description":"Bible on Android","fork":false,"url":"https://api.github.com/repos/mjdenham/and-bible","forks_url":"https://api.github.com/repos/mjdenham/and-bible/forks","keys_url":"https://api.github.com/repos/mjdenham/and-bible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjdenham/and-bible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjdenham/and-bible/teams","hooks_url":"https://api.github.com/repos/mjdenham/and-bible/hooks","issue_events_url":"https://api.github.com/repos/mjdenham/and-bible/issues/events{/number}","events_url":"https://api.github.com/repos/mjdenham/and-bible/events","assignees_url":"https://api.github.com/repos/mjdenham/and-bible/assignees{/user}","branches_url":"https://api.github.com/repos/mjdenham/and-bible/branches{/branch}","tags_url":"https://api.github.com/repos/mjdenham/and-bible/tags","blobs_url":"https://api.github.com/repos/mjdenham/and-bible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjdenham/and-bible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjdenham/and-bible/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjdenham/and-bible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjdenham/and-bible/statuses/{sha}","languages_url":"https://api.github.com/repos/mjdenham/and-bible/languages","stargazers_url":"https://api.github.com/repos/mjdenham/and-bible/stargazers","contributors_url":"https://api.github.com/repos/mjdenham/and-bible/contributors","subscribers_url":"https://api.github.com/repos/mjdenham/and-bible/subscribers","subscription_url":"https://api.github.com/repos/mjdenham/and-bible/subscription","commits_url":"https://api.github.com/repos/mjdenham/and-bible/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjdenham/and-bible/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjdenham/and-bible/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjdenham/and-bible/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjdenham/and-bible/contents/{+path}","compare_url":"https://api.github.com/repos/mjdenham/and-bible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjdenham/and-bible/merges","archive_url":"https://api.github.com/repos/mjdenham/and-bible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjdenham/and-bible/downloads","issues_url":"https://api.github.com/repos/mjdenham/and-bible/issues{/number}","pulls_url":"https://api.github.com/repos/mjdenham/and-bible/pulls{/number}","milestones_url":"https://api.github.com/repos/mjdenham/and-bible/milestones{/number}","notifications_url":"https://api.github.com/repos/mjdenham/and-bible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjdenham/and-bible/labels{/name}","releases_url":"https://api.github.com/repos/mjdenham/and-bible/releases{/id}","deployments_url":"https://api.github.com/repos/mjdenham/and-bible/deployments","created_at":"2011-09-26T21:24:29Z","updated_at":"2018-08-05T15:55:18Z","pushed_at":"2018-08-18T10:16:46Z","git_url":"git://github.com/mjdenham/and-bible.git","ssh_url":"git@github.com:mjdenham/and-bible.git","clone_url":"https://github.com/mjdenham/and-bible.git","svn_url":"https://github.com/mjdenham/and-bible","homepage":"http://mjdenham.github.io/and-bible/","size":97039,"stargazers_count":156,"watchers_count":156,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":55,"license":null,"forks":101,"open_issues":55,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjdenham/and-bible/pulls/143"},"html":{"href":"https://github.com/mjdenham/and-bible/pull/143"},"issue":{"href":"https://api.github.com/repos/mjdenham/and-bible/issues/143"},"comments":{"href":"https://api.github.com/repos/mjdenham/and-bible/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/mjdenham/and-bible/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/mjdenham/and-bible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjdenham/and-bible/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/mjdenham/and-bible/statuses/cb69e31ed30351754256466633e9e69756def2a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mjdenham"}}