{"action":"created","comment":{"url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/comments/233250060","pull_request_review_id":174619530,"id":233250060,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzI1MDA2MA==","diff_hunk":"@@ -0,0 +1,68 @@\n+---\n+\n+- name: Download custom modules source tar\n+  become: yes\n+  get_url:\n+    url: \"{{ item.source }}\"\n+    dest: \"/opt/{{ item.name }}.tar.gz\"\n+  loop: \"{{ nginx_custom_modules }}\"\n+\n+- name: Extract custom modules\n+  become: yes\n+  unarchive:\n+    src: \"/opt/{{ item.name }}.tar.gz\"\n+    dest: /opt\n+    remote_src: yes\n+  loop: \"{{ nginx_custom_modules }}\"\n+\n+- name: Collect current nginx binary version\n+  shell: \"nginx -v 2>&1 | grep -o '[0-9.]*$'\"\n+  register: nginx_version\n+  failed_when: not nginx_version.stdout\n+  changed_when: false\n+\n+- name: Ensure tmp location exists for download\n+  file:\n+    path: /tmp/nginx","path":"tasks/custom.yml","position":26,"original_position":26,"commit_id":"e734b9438a6aefabc41aa9920925e578ec360ae2","original_commit_id":"e734b9438a6aefabc41aa9920925e578ec360ae2","user":{"login":"aedmonds","id":1418491,"node_id":"MDQ6VXNlcjE0MTg0OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1418491?v=4","gravatar_id":"","url":"https://api.github.com/users/aedmonds","html_url":"https://github.com/aedmonds","followers_url":"https://api.github.com/users/aedmonds/followers","following_url":"https://api.github.com/users/aedmonds/following{/other_user}","gists_url":"https://api.github.com/users/aedmonds/gists{/gist_id}","starred_url":"https://api.github.com/users/aedmonds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aedmonds/subscriptions","organizations_url":"https://api.github.com/users/aedmonds/orgs","repos_url":"https://api.github.com/users/aedmonds/repos","events_url":"https://api.github.com/users/aedmonds/events{/privacy}","received_events_url":"https://api.github.com/users/aedmonds/received_events","type":"User","site_admin":false},"body":"I think it would make sense for this to be moved to the `/opt` directory like the custom modules.","created_at":"2018-11-13T22:36:24Z","updated_at":"2018-11-13T22:45:52Z","html_url":"https://github.com/ergontech-ansible-roles/nginx/pull/1#discussion_r233250060","pull_request_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/comments/233250060"},"html":{"href":"https://github.com/ergontech-ansible-roles/nginx/pull/1#discussion_r233250060"},"pull_request":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1","id":230628597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjI4NTk3","html_url":"https://github.com/ergontech-ansible-roles/nginx/pull/1","diff_url":"https://github.com/ergontech-ansible-roles/nginx/pull/1.diff","patch_url":"https://github.com/ergontech-ansible-roles/nginx/pull/1.patch","issue_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/1","number":1,"state":"open","locked":false,"title":"HI-67 add option to build nginx from source","user":{"login":"lvampa","id":11276144,"node_id":"MDQ6VXNlcjExMjc2MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/11276144?v=4","gravatar_id":"","url":"https://api.github.com/users/lvampa","html_url":"https://github.com/lvampa","followers_url":"https://api.github.com/users/lvampa/followers","following_url":"https://api.github.com/users/lvampa/following{/other_user}","gists_url":"https://api.github.com/users/lvampa/gists{/gist_id}","starred_url":"https://api.github.com/users/lvampa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvampa/subscriptions","organizations_url":"https://api.github.com/users/lvampa/orgs","repos_url":"https://api.github.com/users/lvampa/repos","events_url":"https://api.github.com/users/lvampa/events{/privacy}","received_events_url":"https://api.github.com/users/lvampa/received_events","type":"User","site_admin":false},"body":"This PR will:\r\n\r\n- [x] update `nginx.conf` file to load any custom modules\r\n- [x] build nginx from source if custom modules are set to be installed\r\n- [x] refactor tags to allow for more specific use of the role\r\n- [x] change handler to use `systemd`\r\n- [x] conditional check in `x-whom.conf.j2`\r\n\r\nTests:\r\n✅ Idempotent role\r\n✅ `sudo nginx -t` successful\r\n\r\nNotes -\r\n- nginx source is set to match the version already installed by `apt`\r\n- not all of the modules which are build into the binary downloaded from `apt` are included in the new build.","created_at":"2018-11-13T21:19:59Z","updated_at":"2018-11-13T22:45:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"455f0d7e717002afcea3d31de88e01e559a3a84c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/1/comments","statuses_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/statuses/e734b9438a6aefabc41aa9920925e578ec360ae2","head":{"label":"ergontech-ansible-roles:feature/HI-67_install-geoip-module","ref":"feature/HI-67_install-geoip-module","sha":"e734b9438a6aefabc41aa9920925e578ec360ae2","user":{"login":"ergontech-ansible-roles","id":28798180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzk4MTgw","avatar_url":"https://avatars0.githubusercontent.com/u/28798180?v=4","gravatar_id":"","url":"https://api.github.com/users/ergontech-ansible-roles","html_url":"https://github.com/ergontech-ansible-roles","followers_url":"https://api.github.com/users/ergontech-ansible-roles/followers","following_url":"https://api.github.com/users/ergontech-ansible-roles/following{/other_user}","gists_url":"https://api.github.com/users/ergontech-ansible-roles/gists{/gist_id}","starred_url":"https://api.github.com/users/ergontech-ansible-roles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergontech-ansible-roles/subscriptions","organizations_url":"https://api.github.com/users/ergontech-ansible-roles/orgs","repos_url":"https://api.github.com/users/ergontech-ansible-roles/repos","events_url":"https://api.github.com/users/ergontech-ansible-roles/events{/privacy}","received_events_url":"https://api.github.com/users/ergontech-ansible-roles/received_events","type":"Organization","site_admin":false},"repo":{"id":136387927,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzODc5Mjc=","name":"nginx","full_name":"ergontech-ansible-roles/nginx","private":false,"owner":{"login":"ergontech-ansible-roles","id":28798180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzk4MTgw","avatar_url":"https://avatars0.githubusercontent.com/u/28798180?v=4","gravatar_id":"","url":"https://api.github.com/users/ergontech-ansible-roles","html_url":"https://github.com/ergontech-ansible-roles","followers_url":"https://api.github.com/users/ergontech-ansible-roles/followers","following_url":"https://api.github.com/users/ergontech-ansible-roles/following{/other_user}","gists_url":"https://api.github.com/users/ergontech-ansible-roles/gists{/gist_id}","starred_url":"https://api.github.com/users/ergontech-ansible-roles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergontech-ansible-roles/subscriptions","organizations_url":"https://api.github.com/users/ergontech-ansible-roles/orgs","repos_url":"https://api.github.com/users/ergontech-ansible-roles/repos","events_url":"https://api.github.com/users/ergontech-ansible-roles/events{/privacy}","received_events_url":"https://api.github.com/users/ergontech-ansible-roles/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ergontech-ansible-roles/nginx","description":"Install and configure nginx server","fork":false,"url":"https://api.github.com/repos/ergontech-ansible-roles/nginx","forks_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/forks","keys_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/teams","hooks_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/hooks","issue_events_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/events{/number}","events_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/events","assignees_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/assignees{/user}","branches_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/branches{/branch}","tags_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/tags","blobs_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/languages","stargazers_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/stargazers","contributors_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/contributors","subscribers_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/subscribers","subscription_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/subscription","commits_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/contents/{+path}","compare_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/merges","archive_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/downloads","issues_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues{/number}","pulls_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/labels{/name}","releases_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/releases{/id}","deployments_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/deployments","created_at":"2018-06-06T21:26:48Z","updated_at":"2018-06-26T19:44:14Z","pushed_at":"2018-11-13T21:27:12Z","git_url":"git://github.com/ergontech-ansible-roles/nginx.git","ssh_url":"git@github.com:ergontech-ansible-roles/nginx.git","clone_url":"https://github.com/ergontech-ansible-roles/nginx.git","svn_url":"https://github.com/ergontech-ansible-roles/nginx","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ergontech-ansible-roles:master","ref":"master","sha":"b854dd31d0a73db2e8ff68efc0effa0a7447b1e1","user":{"login":"ergontech-ansible-roles","id":28798180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzk4MTgw","avatar_url":"https://avatars0.githubusercontent.com/u/28798180?v=4","gravatar_id":"","url":"https://api.github.com/users/ergontech-ansible-roles","html_url":"https://github.com/ergontech-ansible-roles","followers_url":"https://api.github.com/users/ergontech-ansible-roles/followers","following_url":"https://api.github.com/users/ergontech-ansible-roles/following{/other_user}","gists_url":"https://api.github.com/users/ergontech-ansible-roles/gists{/gist_id}","starred_url":"https://api.github.com/users/ergontech-ansible-roles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergontech-ansible-roles/subscriptions","organizations_url":"https://api.github.com/users/ergontech-ansible-roles/orgs","repos_url":"https://api.github.com/users/ergontech-ansible-roles/repos","events_url":"https://api.github.com/users/ergontech-ansible-roles/events{/privacy}","received_events_url":"https://api.github.com/users/ergontech-ansible-roles/received_events","type":"Organization","site_admin":false},"repo":{"id":136387927,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzODc5Mjc=","name":"nginx","full_name":"ergontech-ansible-roles/nginx","private":false,"owner":{"login":"ergontech-ansible-roles","id":28798180,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzk4MTgw","avatar_url":"https://avatars0.githubusercontent.com/u/28798180?v=4","gravatar_id":"","url":"https://api.github.com/users/ergontech-ansible-roles","html_url":"https://github.com/ergontech-ansible-roles","followers_url":"https://api.github.com/users/ergontech-ansible-roles/followers","following_url":"https://api.github.com/users/ergontech-ansible-roles/following{/other_user}","gists_url":"https://api.github.com/users/ergontech-ansible-roles/gists{/gist_id}","starred_url":"https://api.github.com/users/ergontech-ansible-roles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergontech-ansible-roles/subscriptions","organizations_url":"https://api.github.com/users/ergontech-ansible-roles/orgs","repos_url":"https://api.github.com/users/ergontech-ansible-roles/repos","events_url":"https://api.github.com/users/ergontech-ansible-roles/events{/privacy}","received_events_url":"https://api.github.com/users/ergontech-ansible-roles/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ergontech-ansible-roles/nginx","description":"Install and configure nginx server","fork":false,"url":"https://api.github.com/repos/ergontech-ansible-roles/nginx","forks_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/forks","keys_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/teams","hooks_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/hooks","issue_events_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/events{/number}","events_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/events","assignees_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/assignees{/user}","branches_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/branches{/branch}","tags_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/tags","blobs_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/languages","stargazers_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/stargazers","contributors_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/contributors","subscribers_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/subscribers","subscription_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/subscription","commits_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/contents/{+path}","compare_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/merges","archive_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/downloads","issues_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues{/number}","pulls_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/labels{/name}","releases_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/releases{/id}","deployments_url":"https://api.github.com/repos/ergontech-ansible-roles/nginx/deployments","created_at":"2018-06-06T21:26:48Z","updated_at":"2018-06-26T19:44:14Z","pushed_at":"2018-11-13T21:27:12Z","git_url":"git://github.com/ergontech-ansible-roles/nginx.git","ssh_url":"git@github.com:ergontech-ansible-roles/nginx.git","clone_url":"https://github.com/ergontech-ansible-roles/nginx.git","svn_url":"https://github.com/ergontech-ansible-roles/nginx","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1"},"html":{"href":"https://github.com/ergontech-ansible-roles/nginx/pull/1"},"issue":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/1"},"comments":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ergontech-ansible-roles/nginx/statuses/e734b9438a6aefabc41aa9920925e578ec360ae2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aedmonds"}}