{"action":"created","issue":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2334","repository_url":"https://api.github.com/repos/easybuilders/easybuild-framework","labels_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2334/labels{/name}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2334/comments","events_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2334/events","html_url":"https://github.com/easybuilders/easybuild-framework/issues/2334","id":269044120,"number":2334,"title":"new/update-pr fails in extended dry run mode when adding a patch file","user":{"login":"migueldiascosta","id":7159063,"avatar_url":"https://avatars3.githubusercontent.com/u/7159063?v=4","gravatar_id":"","url":"https://api.github.com/users/migueldiascosta","html_url":"https://github.com/migueldiascosta","followers_url":"https://api.github.com/users/migueldiascosta/followers","following_url":"https://api.github.com/users/migueldiascosta/following{/other_user}","gists_url":"https://api.github.com/users/migueldiascosta/gists{/gist_id}","starred_url":"https://api.github.com/users/migueldiascosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migueldiascosta/subscriptions","organizations_url":"https://api.github.com/users/migueldiascosta/orgs","repos_url":"https://api.github.com/users/migueldiascosta/repos","events_url":"https://api.github.com/users/migueldiascosta/events{/privacy}","received_events_url":"https://api.github.com/users/migueldiascosta/received_events","type":"User","site_admin":false},"labels":[{"id":989295,"url":"https://api.github.com/repos/easybuilders/easybuild-framework/labels/bug%20report","name":"bug report","color":"dd0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones/54","html_url":"https://github.com/easybuilders/easybuild-framework/milestone/54","labels_url":"https://api.github.com/repos/easybuilders/easybuild-framework/milestones/54/labels","id":3137238,"number":54,"title":"3.6.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":6,"state":"open","created_at":"2018-02-22T19:46:25Z","updated_at":"2018-03-13T18:01:35Z","due_on":"2018-04-18T07:00:00Z","closed_at":null},"comments":1,"created_at":"2017-10-27T09:31:50Z","updated_at":"2018-03-14T08:41:08Z","closed_at":null,"author_association":"MEMBER","body":"When running `--update-pr -x` and adding a new patch file, it fails saying it cannot find the patch file, which should have been copied to the temp dir. But the actual `--update-pr` works, so `-x` must be disabling the copy?\r\n\r\nAdditionally, doing the same to submit changes to a patch, dry run mode doesn't show the changes to the patch file, although the actual `--update-pr` does submit them."},"comment":{"url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/comments/372944315","html_url":"https://github.com/easybuilders/easybuild-framework/issues/2334#issuecomment-372944315","issue_url":"https://api.github.com/repos/easybuilders/easybuild-framework/issues/2334","id":372944315,"user":{"login":"migueldiascosta","id":7159063,"avatar_url":"https://avatars3.githubusercontent.com/u/7159063?v=4","gravatar_id":"","url":"https://api.github.com/users/migueldiascosta","html_url":"https://github.com/migueldiascosta","followers_url":"https://api.github.com/users/migueldiascosta/followers","following_url":"https://api.github.com/users/migueldiascosta/following{/other_user}","gists_url":"https://api.github.com/users/migueldiascosta/gists{/gist_id}","starred_url":"https://api.github.com/users/migueldiascosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migueldiascosta/subscriptions","organizations_url":"https://api.github.com/users/migueldiascosta/orgs","repos_url":"https://api.github.com/users/migueldiascosta/repos","events_url":"https://api.github.com/users/migueldiascosta/events{/privacy}","received_events_url":"https://api.github.com/users/migueldiascosta/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T08:41:08Z","updated_at":"2018-03-14T08:41:08Z","author_association":"MEMBER","body":"I can submit a PR for this, but I see two alternatives:\r\n\r\n1) skip staging the patch in `_easyconfigs_pr_common` (fixes the crash but will still not show the patch)\r\n\r\n2) add `force_in_dry_run=True` to `copy_file` in `copy_patch_files` (not sure if it will affect anything else)"}}
{"actor":{"display_login":"migueldiascosta"}}