{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/3958","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3958/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3958/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3958/events","html_url":"https://github.com/apache/incubator-airflow/pull/3958","id":364251246,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDg0MTQ0","number":3958,"title":"[AIRFLOW-3124] Fix RBAC webserver debug mode","user":{"login":"akosel","id":5097634,"node_id":"MDQ6VXNlcjUwOTc2MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5097634?v=4","gravatar_id":"","url":"https://api.github.com/users/akosel","html_url":"https://github.com/akosel","followers_url":"https://api.github.com/users/akosel/followers","following_url":"https://api.github.com/users/akosel/following{/other_user}","gists_url":"https://api.github.com/users/akosel/gists{/gist_id}","starred_url":"https://api.github.com/users/akosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosel/subscriptions","organizations_url":"https://api.github.com/users/akosel/orgs","repos_url":"https://api.github.com/users/akosel/repos","events_url":"https://api.github.com/users/akosel/events{/privacy}","received_events_url":"https://api.github.com/users/akosel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-26T23:33:54Z","updated_at":"2018-09-28T11:51:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3958","html_url":"https://github.com/apache/incubator-airflow/pull/3958","diff_url":"https://github.com/apache/incubator-airflow/pull/3958.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3958.patch"},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3124) issues and references them in the PR title.\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\nThe command `airflow webserver -d` crashes when `settings.RBAC == True`. This is because `create_app` currently returns `app, appbuilder`, which causes the app to crash with an `AttributeError`. As a side comment, it might not be ideal for the two `create_app`'s to have a difference interface, so wondering if the more proper fix is have `create_app` only return the flask application and then update the tests that rely on this to retrieve the appbuilder from the `cached_appbuilder` function. I can do that if it seems worthwhile, but figured I'd wait for feedback before doing that larger change.\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests\r\n\r\nI set up the CLI to pass in the `unit_test_mode` setting to the flask app so we can disable the werkzeug reloader when running tests. If the reloader runs, there is an extra monitoring process left running after killing the main webserver process. This causes conflicts if multiple tests rely on being able to start a webserver (as the process will not be able to bind to the default socket). \r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/425411512","html_url":"https://github.com/apache/incubator-airflow/pull/3958#issuecomment-425411512","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3958","id":425411512,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTQxMTUxMg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T11:51:43Z","updated_at":"2018-09-28T11:51:43Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=h1) Report\n> Merging [#3958](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-airflow/commit/f4f8027cbf61ce2ed6a9989facf6c99dffb12f66?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-airflow/pull/3958/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master   #3958      +/-   ##\n=========================================\n+ Coverage   74.88%   74.9%   +0.02%     \n=========================================\n  Files         200     200              \n  Lines       15974   15976       +2     \n=========================================\n+ Hits        11962   11967       +5     \n+ Misses       4012    4009       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [airflow/bin/cli.py](https://codecov.io/gh/apache/incubator-airflow/pull/3958/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `64.43% <0%> (-0.16%)` | :arrow_down: |\n| [airflow/www\\_rbac/views.py](https://codecov.io/gh/apache/incubator-airflow/pull/3958/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy92aWV3cy5weQ==) | `72.04% <0%> (+0.07%)` | :arrow_up: |\n| [airflow/configuration.py](https://codecov.io/gh/apache/incubator-airflow/pull/3958/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `89.25% <0%> (+0.74%)` | :arrow_up: |\n| [airflow/www\\_rbac/app.py](https://codecov.io/gh/apache/incubator-airflow/pull/3958/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3dfcmJhYy9hcHAucHk=) | `97.77% <0%> (+2.22%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=footer). Last update [f4f8027...90686be](https://codecov.io/gh/apache/incubator-airflow/pull/3958?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}