{"action":"created","issue":{"url":"https://api.github.com/repos/cokelaer/spectrum/issues/54","repository_url":"https://api.github.com/repos/cokelaer/spectrum","labels_url":"https://api.github.com/repos/cokelaer/spectrum/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/cokelaer/spectrum/issues/54/comments","events_url":"https://api.github.com/repos/cokelaer/spectrum/issues/54/events","html_url":"https://github.com/cokelaer/spectrum/issues/54","id":385142556,"node_id":"MDU6SXNzdWUzODUxNDI1NTY=","number":54,"title":"Real datatype, appending last value not always required","user":{"login":"alfredo-f","id":22865959,"node_id":"MDQ6VXNlcjIyODY1OTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22865959?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredo-f","html_url":"https://github.com/alfredo-f","followers_url":"https://api.github.com/users/alfredo-f/followers","following_url":"https://api.github.com/users/alfredo-f/following{/other_user}","gists_url":"https://api.github.com/users/alfredo-f/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredo-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredo-f/subscriptions","organizations_url":"https://api.github.com/users/alfredo-f/orgs","repos_url":"https://api.github.com/users/alfredo-f/repos","events_url":"https://api.github.com/users/alfredo-f/events{/privacy}","received_events_url":"https://api.github.com/users/alfredo-f/received_events","type":"User","site_admin":false},"labels":[{"id":126068058,"node_id":"MDU6TGFiZWwxMjYwNjgwNTg=","url":"https://api.github.com/repos/cokelaer/spectrum/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-28T07:52:33Z","updated_at":"2018-12-20T23:03:25Z","closed_at":null,"author_association":"NONE","body":"TODO comment left at burg.py:145 was right\r\n`# TODO: check the last value is correct or required ?`\r\nin case `int(self.NFFT//2)` is odd, appending last value is not required because the length is already odd.\r\n\r\nFor example,\r\n`self.NFFT = 1189` —> `int(self.NFFT//2) = **594**` —> append... is **needed** to get length 595\r\n`self.NFFT = 1186` —> `int(self.NFFT//2) = **593**` —> append... is **not needed**, length already odd\r\n\r\nIn attach, explanation from MATLAB implementation help\r\n![screen shot 2018-11-28 at 08 44 11](https://user-images.githubusercontent.com/22865959/49136734-d84d1700-f2ea-11e8-9507-515b1a48a310.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/cokelaer/spectrum/issues/comments/449164018","html_url":"https://github.com/cokelaer/spectrum/issues/54#issuecomment-449164018","issue_url":"https://api.github.com/repos/cokelaer/spectrum/issues/54","id":449164018,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTE2NDAxOA==","user":{"login":"cokelaer","id":778821,"node_id":"MDQ6VXNlcjc3ODgyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/778821?v=4","gravatar_id":"","url":"https://api.github.com/users/cokelaer","html_url":"https://github.com/cokelaer","followers_url":"https://api.github.com/users/cokelaer/followers","following_url":"https://api.github.com/users/cokelaer/following{/other_user}","gists_url":"https://api.github.com/users/cokelaer/gists{/gist_id}","starred_url":"https://api.github.com/users/cokelaer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cokelaer/subscriptions","organizations_url":"https://api.github.com/users/cokelaer/orgs","repos_url":"https://api.github.com/users/cokelaer/repos","events_url":"https://api.github.com/users/cokelaer/events{/privacy}","received_events_url":"https://api.github.com/users/cokelaer/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T23:03:25Z","updated_at":"2018-12-20T23:03:25Z","author_association":"OWNER","body":"Thanks for reporting this. Indeed in test, 8//2 or 9//2 is identical (4) but for larger values this is not the case. I will need to correct this in a few other places indeed. will be incorporated in the next release."}}
{"actor":{"display_login":"cokelaer"}}