{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/221705935","pull_request_review_id":160420444,"id":221705935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTcwNTkzNQ==","diff_hunk":"@@ -1,18 +1,22 @@\n {{#> alert alert--modifier=\"pf-m-danger\" alert--attribute='aria-label=\"Danger Notification\"'}}\n   {{#> alert-icon alert-icon--danger=\"true\"}}\n   {{/alert-icon}}\n-    {{#> alert-body alert-HasDescription=\"true\"}}\n-      {{#> alert-title}}\n+  {{#> alert-body alert-body--attribute='role=\"alert\"'}}\n+    {{#> alert-title}}\n       {{#> accessibility accessibility--type=\"sr-only\"}}Danger: {{/accessibility}}\n         Danger notification title\n-      {{/alert-title}}\n+    {{/alert-title}}\n+    {{#> alert-description}}\n+\t\t\tDanger notification description.\n+      <a>This is a link.</a>","path":"src/patternfly/components/Alert/examples/alert-danger-example.hbs","position":14,"original_position":14,"commit_id":"39913365f1883ea22c66cb6c293a62583434952e","original_commit_id":"39913365f1883ea22c66cb6c293a62583434952e","user":{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"body":"Oh, good catch! I would have expected the aXe tooling to flag that. 😕 ","created_at":"2018-10-01T18:14:01Z","updated_at":"2018-10-01T18:14:01Z","html_url":"https://github.com/patternfly/patternfly-next/pull/735#discussion_r221705935","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/221705935"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/735#discussion_r221705935"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735"}},"in_reply_to_id":221705133},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735","id":216077962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDc3OTYy","html_url":"https://github.com/patternfly/patternfly-next/pull/735","diff_url":"https://github.com/patternfly/patternfly-next/pull/735.diff","patch_url":"https://github.com/patternfly/patternfly-next/pull/735.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/735","number":735,"state":"open","locked":false,"title":"Alert Migration Examples","user":{"login":"christiemolloy","id":20118816,"node_id":"MDQ6VXNlcjIwMTE4ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/20118816?v=4","gravatar_id":"","url":"https://api.github.com/users/christiemolloy","html_url":"https://github.com/christiemolloy","followers_url":"https://api.github.com/users/christiemolloy/followers","following_url":"https://api.github.com/users/christiemolloy/following{/other_user}","gists_url":"https://api.github.com/users/christiemolloy/gists{/gist_id}","starred_url":"https://api.github.com/users/christiemolloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiemolloy/subscriptions","organizations_url":"https://api.github.com/users/christiemolloy/orgs","repos_url":"https://api.github.com/users/christiemolloy/repos","events_url":"https://api.github.com/users/christiemolloy/events{/privacy}","received_events_url":"https://api.github.com/users/christiemolloy/received_events","type":"User","site_admin":false},"body":"This PR closes  #410 \r\n\r\nThis is the Alert upgrade example. It demonstrates the Notification and Alert components from pf3 and then the Alert component from pf4 (which combines notification and alert). ","created_at":"2018-09-17T18:46:27Z","updated_at":"2018-10-01T18:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8381645b4b980c386678aafc4f2bbf2c7ad4dac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},{"login":"dgutride","id":7306953,"node_id":"MDQ6VXNlcjczMDY5NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/7306953?v=4","gravatar_id":"","url":"https://api.github.com/users/dgutride","html_url":"https://github.com/dgutride","followers_url":"https://api.github.com/users/dgutride/followers","following_url":"https://api.github.com/users/dgutride/following{/other_user}","gists_url":"https://api.github.com/users/dgutride/gists{/gist_id}","starred_url":"https://api.github.com/users/dgutride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgutride/subscriptions","organizations_url":"https://api.github.com/users/dgutride/orgs","repos_url":"https://api.github.com/users/dgutride/repos","events_url":"https://api.github.com/users/dgutride/events{/privacy}","received_events_url":"https://api.github.com/users/dgutride/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/735/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/39913365f1883ea22c66cb6c293a62583434952e","head":{"label":"christiemolloy:upgradealert","ref":"upgradealert","sha":"39913365f1883ea22c66cb6c293a62583434952e","user":{"login":"christiemolloy","id":20118816,"node_id":"MDQ6VXNlcjIwMTE4ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/20118816?v=4","gravatar_id":"","url":"https://api.github.com/users/christiemolloy","html_url":"https://github.com/christiemolloy","followers_url":"https://api.github.com/users/christiemolloy/followers","following_url":"https://api.github.com/users/christiemolloy/following{/other_user}","gists_url":"https://api.github.com/users/christiemolloy/gists{/gist_id}","starred_url":"https://api.github.com/users/christiemolloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiemolloy/subscriptions","organizations_url":"https://api.github.com/users/christiemolloy/orgs","repos_url":"https://api.github.com/users/christiemolloy/repos","events_url":"https://api.github.com/users/christiemolloy/events{/privacy}","received_events_url":"https://api.github.com/users/christiemolloy/received_events","type":"User","site_admin":false},"repo":{"id":144307212,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzMDcyMTI=","name":"patternfly-next","full_name":"christiemolloy/patternfly-next","private":false,"owner":{"login":"christiemolloy","id":20118816,"node_id":"MDQ6VXNlcjIwMTE4ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/20118816?v=4","gravatar_id":"","url":"https://api.github.com/users/christiemolloy","html_url":"https://github.com/christiemolloy","followers_url":"https://api.github.com/users/christiemolloy/followers","following_url":"https://api.github.com/users/christiemolloy/following{/other_user}","gists_url":"https://api.github.com/users/christiemolloy/gists{/gist_id}","starred_url":"https://api.github.com/users/christiemolloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiemolloy/subscriptions","organizations_url":"https://api.github.com/users/christiemolloy/orgs","repos_url":"https://api.github.com/users/christiemolloy/repos","events_url":"https://api.github.com/users/christiemolloy/events{/privacy}","received_events_url":"https://api.github.com/users/christiemolloy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/christiemolloy/patternfly-next","description":"Working repo for PatternFly 4","fork":true,"url":"https://api.github.com/repos/christiemolloy/patternfly-next","forks_url":"https://api.github.com/repos/christiemolloy/patternfly-next/forks","keys_url":"https://api.github.com/repos/christiemolloy/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christiemolloy/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christiemolloy/patternfly-next/teams","hooks_url":"https://api.github.com/repos/christiemolloy/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/christiemolloy/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/christiemolloy/patternfly-next/events","assignees_url":"https://api.github.com/repos/christiemolloy/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/christiemolloy/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/christiemolloy/patternfly-next/tags","blobs_url":"https://api.github.com/repos/christiemolloy/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christiemolloy/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christiemolloy/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/christiemolloy/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christiemolloy/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/christiemolloy/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/christiemolloy/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/christiemolloy/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/christiemolloy/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/christiemolloy/patternfly-next/subscription","commits_url":"https://api.github.com/repos/christiemolloy/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/christiemolloy/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/christiemolloy/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/christiemolloy/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/christiemolloy/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/christiemolloy/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christiemolloy/patternfly-next/merges","archive_url":"https://api.github.com/repos/christiemolloy/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christiemolloy/patternfly-next/downloads","issues_url":"https://api.github.com/repos/christiemolloy/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/christiemolloy/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/christiemolloy/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/christiemolloy/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christiemolloy/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/christiemolloy/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/christiemolloy/patternfly-next/deployments","created_at":"2018-08-10T16:04:51Z","updated_at":"2018-10-01T13:17:54Z","pushed_at":"2018-10-01T15:44:12Z","git_url":"git://github.com/christiemolloy/patternfly-next.git","ssh_url":"git@github.com:christiemolloy/patternfly-next.git","clone_url":"https://github.com/christiemolloy/patternfly-next.git","svn_url":"https://github.com/christiemolloy/patternfly-next","homepage":"","size":33598,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"b7d0a1bac16aa7e88cc4b18a316c806285f078cc","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":122507459,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MDc0NTk=","name":"patternfly-next","full_name":"patternfly/patternfly-next","private":false,"owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/patternfly/patternfly-next","description":"Working repo for PatternFly 4","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-next","forks_url":"https://api.github.com/repos/patternfly/patternfly-next/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-next/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-next/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-next/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-next/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-next/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-next/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-next/deployments","created_at":"2018-02-22T16:52:59Z","updated_at":"2018-10-01T18:01:32Z","pushed_at":"2018-10-01T18:13:01Z","git_url":"git://github.com/patternfly/patternfly-next.git","ssh_url":"git@github.com:patternfly/patternfly-next.git","clone_url":"https://github.com/patternfly/patternfly-next.git","svn_url":"https://github.com/patternfly/patternfly-next","homepage":"","size":47363,"stargazers_count":52,"watchers_count":52,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":196,"license":null,"forks":41,"open_issues":196,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/735"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/735"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/735/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/735/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-next/statuses/39913365f1883ea22c66cb6c293a62583434952e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jgiardino"}}