{"action":"created","issue":{"url":"https://api.github.com/repos/fsharp/FAKE/issues/1890","repository_url":"https://api.github.com/repos/fsharp/FAKE","labels_url":"https://api.github.com/repos/fsharp/FAKE/issues/1890/labels{/name}","comments_url":"https://api.github.com/repos/fsharp/FAKE/issues/1890/comments","events_url":"https://api.github.com/repos/fsharp/FAKE/issues/1890/events","html_url":"https://github.com/fsharp/FAKE/pull/1890","id":318191869,"number":1890,"title":"WIP: Fake 5 InnoSetup Module","user":{"login":"kblohm","id":38011792,"avatar_url":"https://avatars2.githubusercontent.com/u/38011792?v=4","gravatar_id":"","url":"https://api.github.com/users/kblohm","html_url":"https://github.com/kblohm","followers_url":"https://api.github.com/users/kblohm/followers","following_url":"https://api.github.com/users/kblohm/following{/other_user}","gists_url":"https://api.github.com/users/kblohm/gists{/gist_id}","starred_url":"https://api.github.com/users/kblohm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblohm/subscriptions","organizations_url":"https://api.github.com/users/kblohm/orgs","repos_url":"https://api.github.com/users/kblohm/repos","events_url":"https://api.github.com/users/kblohm/events{/privacy}","received_events_url":"https://api.github.com/users/kblohm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-26T20:50:37Z","updated_at":"2018-04-27T20:59:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fsharp/FAKE/pulls/1890","html_url":"https://github.com/fsharp/FAKE/pull/1890","diff_url":"https://github.com/fsharp/FAKE/pull/1890.diff","patch_url":"https://github.com/fsharp/FAKE/pull/1890.patch"},"body":"Hi,\r\ni created a module to support [Inno Setup](http://www.jrsoftware.org/isinfo.php), a tool to build installers for windows. \r\nSince there are other installer tools not yet ported i put the module under Fake.Installer.\r\nIf u want to use that namespace for an actual Fake-Installer, i can also put it under Fake.InstallerTools or something similair.\r\n\r\nI also have a few questions:\r\n* should new modules still be added into FakeLib.fsproj?\r\n* if not, the build script probably needs to be modified. GenerateDocs docs only looks into the \"./build\" folder and as far as i can see FAKE.sln is only used to generate nuget packages. At least i suppose thats why i do not get any documentation generated :)\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/fsharp/FAKE/issues/comments/385092633","html_url":"https://github.com/fsharp/FAKE/pull/1890#issuecomment-385092633","issue_url":"https://api.github.com/repos/fsharp/FAKE/issues/1890","id":385092633,"user":{"login":"matthid","id":1866463,"avatar_url":"https://avatars0.githubusercontent.com/u/1866463?v=4","gravatar_id":"","url":"https://api.github.com/users/matthid","html_url":"https://github.com/matthid","followers_url":"https://api.github.com/users/matthid/followers","following_url":"https://api.github.com/users/matthid/following{/other_user}","gists_url":"https://api.github.com/users/matthid/gists{/gist_id}","starred_url":"https://api.github.com/users/matthid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthid/subscriptions","organizations_url":"https://api.github.com/users/matthid/orgs","repos_url":"https://api.github.com/users/matthid/repos","events_url":"https://api.github.com/users/matthid/events{/privacy}","received_events_url":"https://api.github.com/users/matthid/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T20:59:18Z","updated_at":"2018-04-27T20:59:18Z","author_association":"COLLABORATOR","body":"Hi, yes I think this is ready (I actually already changed to rc_9 in order to release this) you just slightly missed the release window ;)"}}
{"actor":{"display_login":"matthid"}}