{"action":"closed","number":191,"pull_request":{"url":"https://api.github.com/repos/smaccm/smaccm/pulls/191","id":228199358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTk5MzU4","html_url":"https://github.com/smaccm/smaccm/pull/191","diff_url":"https://github.com/smaccm/smaccm/pull/191.diff","patch_url":"https://github.com/smaccm/smaccm/pull/191.patch","issue_url":"https://api.github.com/repos/smaccm/smaccm/issues/191","number":191,"state":"closed","locked":false,"title":"Bugfix to ensure text selection returns correct EObject","user":{"login":"iamundson","id":36237616,"node_id":"MDQ6VXNlcjM2MjM3NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/36237616?v=4","gravatar_id":"","url":"https://api.github.com/users/iamundson","html_url":"https://github.com/iamundson","followers_url":"https://api.github.com/users/iamundson/followers","following_url":"https://api.github.com/users/iamundson/following{/other_user}","gists_url":"https://api.github.com/users/iamundson/gists{/gist_id}","starred_url":"https://api.github.com/users/iamundson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamundson/subscriptions","organizations_url":"https://api.github.com/users/iamundson/orgs","repos_url":"https://api.github.com/users/iamundson/repos","events_url":"https://api.github.com/users/iamundson/events{/privacy}","received_events_url":"https://api.github.com/users/iamundson/received_events","type":"User","site_admin":false},"body":"When AGREE is launched from the popup menu in the text editor, or from the toolbar or main menu when the text editor is the active pane, the selected object in the text editor is resolved via the following call (in `AadlHandler`):\r\n\r\n`EObject eObj = EObjectAtOffsetHelper().resolveContainedElementAt(resource, ts.getOffset());`\r\n\r\nHowever, this returns an `EObject` that's an instance of `Realization`, which is NOT a `NamedElement`.  For verifying single layers in AGREE, this is not a problem and AGREE runs fine. However, when verifying all layers, this is a problem because in `VerifyHandler`, there is an attempt to cast the `EObject` to a `NamedElement`, which throws an exception.\r\n\r\nThis commit is a simple fix, which adds the following to `AadlHandler` to check if the `EObject` is a `Realization`, and if so, instead grab the `EObject`'s container, which is what should be returned (as is the case when AGREE is launched from the outline pane):\r\n\r\n```\r\nif (e instanceof Realization) {\r\n\te = e.eContainer();\r\n}\r\n```","created_at":"2018-11-04T20:08:58Z","updated_at":"2018-11-12T15:37:24Z","closed_at":"2018-11-12T15:37:24Z","merged_at":"2018-11-12T15:37:24Z","merge_commit_sha":"d075a09c6263cb340af3e885b16a9f687ed53a22","assignee":{"login":"iamundson","id":36237616,"node_id":"MDQ6VXNlcjM2MjM3NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/36237616?v=4","gravatar_id":"","url":"https://api.github.com/users/iamundson","html_url":"https://github.com/iamundson","followers_url":"https://api.github.com/users/iamundson/followers","following_url":"https://api.github.com/users/iamundson/following{/other_user}","gists_url":"https://api.github.com/users/iamundson/gists{/gist_id}","starred_url":"https://api.github.com/users/iamundson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamundson/subscriptions","organizations_url":"https://api.github.com/users/iamundson/orgs","repos_url":"https://api.github.com/users/iamundson/repos","events_url":"https://api.github.com/users/iamundson/events{/privacy}","received_events_url":"https://api.github.com/users/iamundson/received_events","type":"User","site_admin":false},"assignees":[{"login":"iamundson","id":36237616,"node_id":"MDQ6VXNlcjM2MjM3NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/36237616?v=4","gravatar_id":"","url":"https://api.github.com/users/iamundson","html_url":"https://github.com/iamundson","followers_url":"https://api.github.com/users/iamundson/followers","following_url":"https://api.github.com/users/iamundson/following{/other_user}","gists_url":"https://api.github.com/users/iamundson/gists{/gist_id}","starred_url":"https://api.github.com/users/iamundson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamundson/subscriptions","organizations_url":"https://api.github.com/users/iamundson/orgs","repos_url":"https://api.github.com/users/iamundson/repos","events_url":"https://api.github.com/users/iamundson/events{/privacy}","received_events_url":"https://api.github.com/users/iamundson/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tlogan","id":1215556,"node_id":"MDQ6VXNlcjEyMTU1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1215556?v=4","gravatar_id":"","url":"https://api.github.com/users/tlogan","html_url":"https://github.com/tlogan","followers_url":"https://api.github.com/users/tlogan/followers","following_url":"https://api.github.com/users/tlogan/following{/other_user}","gists_url":"https://api.github.com/users/tlogan/gists{/gist_id}","starred_url":"https://api.github.com/users/tlogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlogan/subscriptions","organizations_url":"https://api.github.com/users/tlogan/orgs","repos_url":"https://api.github.com/users/tlogan/repos","events_url":"https://api.github.com/users/tlogan/events{/privacy}","received_events_url":"https://api.github.com/users/tlogan/received_events","type":"User","site_admin":false},{"login":"kfhoech","id":5089344,"node_id":"MDQ6VXNlcjUwODkzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5089344?v=4","gravatar_id":"","url":"https://api.github.com/users/kfhoech","html_url":"https://github.com/kfhoech","followers_url":"https://api.github.com/users/kfhoech/followers","following_url":"https://api.github.com/users/kfhoech/following{/other_user}","gists_url":"https://api.github.com/users/kfhoech/gists{/gist_id}","starred_url":"https://api.github.com/users/kfhoech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfhoech/subscriptions","organizations_url":"https://api.github.com/users/kfhoech/orgs","repos_url":"https://api.github.com/users/kfhoech/repos","events_url":"https://api.github.com/users/kfhoech/events{/privacy}","received_events_url":"https://api.github.com/users/kfhoech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smaccm/smaccm/pulls/191/commits","review_comments_url":"https://api.github.com/repos/smaccm/smaccm/pulls/191/comments","review_comment_url":"https://api.github.com/repos/smaccm/smaccm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smaccm/smaccm/issues/191/comments","statuses_url":"https://api.github.com/repos/smaccm/smaccm/statuses/9a1bcfd349fce0e2487323b4b98e5339dfab7b8b","head":{"label":"smaccm:agree-textselection-bugfix","ref":"agree-textselection-bugfix","sha":"9a1bcfd349fce0e2487323b4b98e5339dfab7b8b","user":{"login":"smaccm","id":5216944,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMTY5NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5216944?v=4","gravatar_id":"","url":"https://api.github.com/users/smaccm","html_url":"https://github.com/smaccm","followers_url":"https://api.github.com/users/smaccm/followers","following_url":"https://api.github.com/users/smaccm/following{/other_user}","gists_url":"https://api.github.com/users/smaccm/gists{/gist_id}","starred_url":"https://api.github.com/users/smaccm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaccm/subscriptions","organizations_url":"https://api.github.com/users/smaccm/orgs","repos_url":"https://api.github.com/users/smaccm/repos","events_url":"https://api.github.com/users/smaccm/events{/privacy}","received_events_url":"https://api.github.com/users/smaccm/received_events","type":"Organization","site_admin":false},"repo":{"id":12084628,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4NDYyOA==","name":"smaccm","full_name":"smaccm/smaccm","private":false,"owner":{"login":"smaccm","id":5216944,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMTY5NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5216944?v=4","gravatar_id":"","url":"https://api.github.com/users/smaccm","html_url":"https://github.com/smaccm","followers_url":"https://api.github.com/users/smaccm/followers","following_url":"https://api.github.com/users/smaccm/following{/other_user}","gists_url":"https://api.github.com/users/smaccm/gists{/gist_id}","starred_url":"https://api.github.com/users/smaccm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaccm/subscriptions","organizations_url":"https://api.github.com/users/smaccm/orgs","repos_url":"https://api.github.com/users/smaccm/repos","events_url":"https://api.github.com/users/smaccm/events{/privacy}","received_events_url":"https://api.github.com/users/smaccm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smaccm/smaccm","description":null,"fork":false,"url":"https://api.github.com/repos/smaccm/smaccm","forks_url":"https://api.github.com/repos/smaccm/smaccm/forks","keys_url":"https://api.github.com/repos/smaccm/smaccm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smaccm/smaccm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smaccm/smaccm/teams","hooks_url":"https://api.github.com/repos/smaccm/smaccm/hooks","issue_events_url":"https://api.github.com/repos/smaccm/smaccm/issues/events{/number}","events_url":"https://api.github.com/repos/smaccm/smaccm/events","assignees_url":"https://api.github.com/repos/smaccm/smaccm/assignees{/user}","branches_url":"https://api.github.com/repos/smaccm/smaccm/branches{/branch}","tags_url":"https://api.github.com/repos/smaccm/smaccm/tags","blobs_url":"https://api.github.com/repos/smaccm/smaccm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smaccm/smaccm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smaccm/smaccm/git/refs{/sha}","trees_url":"https://api.github.com/repos/smaccm/smaccm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smaccm/smaccm/statuses/{sha}","languages_url":"https://api.github.com/repos/smaccm/smaccm/languages","stargazers_url":"https://api.github.com/repos/smaccm/smaccm/stargazers","contributors_url":"https://api.github.com/repos/smaccm/smaccm/contributors","subscribers_url":"https://api.github.com/repos/smaccm/smaccm/subscribers","subscription_url":"https://api.github.com/repos/smaccm/smaccm/subscription","commits_url":"https://api.github.com/repos/smaccm/smaccm/commits{/sha}","git_commits_url":"https://api.github.com/repos/smaccm/smaccm/git/commits{/sha}","comments_url":"https://api.github.com/repos/smaccm/smaccm/comments{/number}","issue_comment_url":"https://api.github.com/repos/smaccm/smaccm/issues/comments{/number}","contents_url":"https://api.github.com/repos/smaccm/smaccm/contents/{+path}","compare_url":"https://api.github.com/repos/smaccm/smaccm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smaccm/smaccm/merges","archive_url":"https://api.github.com/repos/smaccm/smaccm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smaccm/smaccm/downloads","issues_url":"https://api.github.com/repos/smaccm/smaccm/issues{/number}","pulls_url":"https://api.github.com/repos/smaccm/smaccm/pulls{/number}","milestones_url":"https://api.github.com/repos/smaccm/smaccm/milestones{/number}","notifications_url":"https://api.github.com/repos/smaccm/smaccm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smaccm/smaccm/labels{/name}","releases_url":"https://api.github.com/repos/smaccm/smaccm/releases{/id}","deployments_url":"https://api.github.com/repos/smaccm/smaccm/deployments","created_at":"2013-08-13T14:59:47Z","updated_at":"2018-10-18T13:43:00Z","pushed_at":"2018-11-12T15:37:24Z","git_url":"git://github.com/smaccm/smaccm.git","ssh_url":"git@github.com:smaccm/smaccm.git","clone_url":"https://github.com/smaccm/smaccm.git","svn_url":"https://github.com/smaccm/smaccm","homepage":null,"size":302407,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":17,"open_issues":29,"watchers":27,"default_branch":"master"}},"base":{"label":"smaccm:develop","ref":"develop","sha":"8945a6f42055f2d79bbcb5dee03205237e80bf37","user":{"login":"smaccm","id":5216944,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMTY5NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5216944?v=4","gravatar_id":"","url":"https://api.github.com/users/smaccm","html_url":"https://github.com/smaccm","followers_url":"https://api.github.com/users/smaccm/followers","following_url":"https://api.github.com/users/smaccm/following{/other_user}","gists_url":"https://api.github.com/users/smaccm/gists{/gist_id}","starred_url":"https://api.github.com/users/smaccm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaccm/subscriptions","organizations_url":"https://api.github.com/users/smaccm/orgs","repos_url":"https://api.github.com/users/smaccm/repos","events_url":"https://api.github.com/users/smaccm/events{/privacy}","received_events_url":"https://api.github.com/users/smaccm/received_events","type":"Organization","site_admin":false},"repo":{"id":12084628,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4NDYyOA==","name":"smaccm","full_name":"smaccm/smaccm","private":false,"owner":{"login":"smaccm","id":5216944,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMTY5NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5216944?v=4","gravatar_id":"","url":"https://api.github.com/users/smaccm","html_url":"https://github.com/smaccm","followers_url":"https://api.github.com/users/smaccm/followers","following_url":"https://api.github.com/users/smaccm/following{/other_user}","gists_url":"https://api.github.com/users/smaccm/gists{/gist_id}","starred_url":"https://api.github.com/users/smaccm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaccm/subscriptions","organizations_url":"https://api.github.com/users/smaccm/orgs","repos_url":"https://api.github.com/users/smaccm/repos","events_url":"https://api.github.com/users/smaccm/events{/privacy}","received_events_url":"https://api.github.com/users/smaccm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smaccm/smaccm","description":null,"fork":false,"url":"https://api.github.com/repos/smaccm/smaccm","forks_url":"https://api.github.com/repos/smaccm/smaccm/forks","keys_url":"https://api.github.com/repos/smaccm/smaccm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smaccm/smaccm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smaccm/smaccm/teams","hooks_url":"https://api.github.com/repos/smaccm/smaccm/hooks","issue_events_url":"https://api.github.com/repos/smaccm/smaccm/issues/events{/number}","events_url":"https://api.github.com/repos/smaccm/smaccm/events","assignees_url":"https://api.github.com/repos/smaccm/smaccm/assignees{/user}","branches_url":"https://api.github.com/repos/smaccm/smaccm/branches{/branch}","tags_url":"https://api.github.com/repos/smaccm/smaccm/tags","blobs_url":"https://api.github.com/repos/smaccm/smaccm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smaccm/smaccm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smaccm/smaccm/git/refs{/sha}","trees_url":"https://api.github.com/repos/smaccm/smaccm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smaccm/smaccm/statuses/{sha}","languages_url":"https://api.github.com/repos/smaccm/smaccm/languages","stargazers_url":"https://api.github.com/repos/smaccm/smaccm/stargazers","contributors_url":"https://api.github.com/repos/smaccm/smaccm/contributors","subscribers_url":"https://api.github.com/repos/smaccm/smaccm/subscribers","subscription_url":"https://api.github.com/repos/smaccm/smaccm/subscription","commits_url":"https://api.github.com/repos/smaccm/smaccm/commits{/sha}","git_commits_url":"https://api.github.com/repos/smaccm/smaccm/git/commits{/sha}","comments_url":"https://api.github.com/repos/smaccm/smaccm/comments{/number}","issue_comment_url":"https://api.github.com/repos/smaccm/smaccm/issues/comments{/number}","contents_url":"https://api.github.com/repos/smaccm/smaccm/contents/{+path}","compare_url":"https://api.github.com/repos/smaccm/smaccm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smaccm/smaccm/merges","archive_url":"https://api.github.com/repos/smaccm/smaccm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smaccm/smaccm/downloads","issues_url":"https://api.github.com/repos/smaccm/smaccm/issues{/number}","pulls_url":"https://api.github.com/repos/smaccm/smaccm/pulls{/number}","milestones_url":"https://api.github.com/repos/smaccm/smaccm/milestones{/number}","notifications_url":"https://api.github.com/repos/smaccm/smaccm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smaccm/smaccm/labels{/name}","releases_url":"https://api.github.com/repos/smaccm/smaccm/releases{/id}","deployments_url":"https://api.github.com/repos/smaccm/smaccm/deployments","created_at":"2013-08-13T14:59:47Z","updated_at":"2018-10-18T13:43:00Z","pushed_at":"2018-11-12T15:37:24Z","git_url":"git://github.com/smaccm/smaccm.git","ssh_url":"git@github.com:smaccm/smaccm.git","clone_url":"https://github.com/smaccm/smaccm.git","svn_url":"https://github.com/smaccm/smaccm","homepage":null,"size":302407,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":17,"open_issues":29,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smaccm/smaccm/pulls/191"},"html":{"href":"https://github.com/smaccm/smaccm/pull/191"},"issue":{"href":"https://api.github.com/repos/smaccm/smaccm/issues/191"},"comments":{"href":"https://api.github.com/repos/smaccm/smaccm/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/smaccm/smaccm/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/smaccm/smaccm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smaccm/smaccm/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/smaccm/smaccm/statuses/9a1bcfd349fce0e2487323b4b98e5339dfab7b8b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"iamundson","id":36237616,"node_id":"MDQ6VXNlcjM2MjM3NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/36237616?v=4","gravatar_id":"","url":"https://api.github.com/users/iamundson","html_url":"https://github.com/iamundson","followers_url":"https://api.github.com/users/iamundson/followers","following_url":"https://api.github.com/users/iamundson/following{/other_user}","gists_url":"https://api.github.com/users/iamundson/gists{/gist_id}","starred_url":"https://api.github.com/users/iamundson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamundson/subscriptions","organizations_url":"https://api.github.com/users/iamundson/orgs","repos_url":"https://api.github.com/users/iamundson/repos","events_url":"https://api.github.com/users/iamundson/events{/privacy}","received_events_url":"https://api.github.com/users/iamundson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"iamundson"}}