{"action":"created","issue":{"url":"https://api.github.com/repos/HarryR/ethsnarks/issues/18","repository_url":"https://api.github.com/repos/HarryR/ethsnarks","labels_url":"https://api.github.com/repos/HarryR/ethsnarks/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/HarryR/ethsnarks/issues/18/comments","events_url":"https://api.github.com/repos/HarryR/ethsnarks/issues/18/events","html_url":"https://github.com/HarryR/ethsnarks/issues/18","id":352629600,"node_id":"MDU6SXNzdWUzNTI2Mjk2MDA=","number":18,"title":"C++ coding standards and code quality suggestions","user":{"login":"HarryR","id":303926,"node_id":"MDQ6VXNlcjMwMzkyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/303926?v=4","gravatar_id":"","url":"https://api.github.com/users/HarryR","html_url":"https://github.com/HarryR","followers_url":"https://api.github.com/users/HarryR/followers","following_url":"https://api.github.com/users/HarryR/following{/other_user}","gists_url":"https://api.github.com/users/HarryR/gists{/gist_id}","starred_url":"https://api.github.com/users/HarryR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarryR/subscriptions","organizations_url":"https://api.github.com/users/HarryR/orgs","repos_url":"https://api.github.com/users/HarryR/repos","events_url":"https://api.github.com/users/HarryR/events{/privacy}","received_events_url":"https://api.github.com/users/HarryR/received_events","type":"User","site_admin":false},"labels":[{"id":991949845,"node_id":"MDU6TGFiZWw5OTE5NDk4NDU=","url":"https://api.github.com/repos/HarryR/ethsnarks/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true},{"id":991949844,"node_id":"MDU6TGFiZWw5OTE5NDk4NDQ=","url":"https://api.github.com/repos/HarryR/ethsnarks/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-21T17:01:25Z","updated_at":"2018-08-22T10:13:10Z","closed_at":null,"author_association":"OWNER","body":"We need to slowly improve the quality of the C++ code used in the ethsnarks project.\r\n\r\nAny insight from skilled C++ practitioners is welcome, especially if it provides an example of before & after, and how this improves code quality etc.\r\n\r\nFor example:\r\n\r\n  * namespaces aren't used for ethsnarks code, but should be\r\n  * CMake files could be cleaner\r\n  * common patterns could be made into composable units/templates\r\n  * anti-patterns and unnecessary duplication\r\n  * C++11 functionality which can be taken advantage of\r\n  * reducing memory usage, avoiding copy constructors\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/HarryR/ethsnarks/issues/comments/414983320","html_url":"https://github.com/HarryR/ethsnarks/issues/18#issuecomment-414983320","issue_url":"https://api.github.com/repos/HarryR/ethsnarks/issues/18","id":414983320,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDk4MzMyMA==","user":{"login":"HarryR","id":303926,"node_id":"MDQ6VXNlcjMwMzkyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/303926?v=4","gravatar_id":"","url":"https://api.github.com/users/HarryR","html_url":"https://github.com/HarryR","followers_url":"https://api.github.com/users/HarryR/followers","following_url":"https://api.github.com/users/HarryR/following{/other_user}","gists_url":"https://api.github.com/users/HarryR/gists{/gist_id}","starred_url":"https://api.github.com/users/HarryR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarryR/subscriptions","organizations_url":"https://api.github.com/users/HarryR/orgs","repos_url":"https://api.github.com/users/HarryR/repos","events_url":"https://api.github.com/users/HarryR/events{/privacy}","received_events_url":"https://api.github.com/users/HarryR/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T10:13:10Z","updated_at":"2018-08-22T10:13:10Z","author_association":"OWNER","body":"I've added three automated code quality checkers:\r\n\r\n * https://app.codacy.com/project/HarryR/ethsnarks/dashboard\r\n * https://bettercodehub.com/results/HarryR/ethsnarks\r\n * https://www.codefactor.io/repository/github/harryr/ethsnarks"}}
{"actor":{"display_login":"HarryR"}}