{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4987","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4987/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4987/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4987/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4987","id":369566656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDc4MTU5","number":4987,"title":"Fix the gold standard checkbox","user":{"login":"eatyourgreens","id":59547,"node_id":"MDQ6VXNlcjU5NTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/59547?v=4","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"wgranger","id":14099077,"node_id":"MDQ6VXNlcjE0MDk5MDc3","avatar_url":"https://avatars1.githubusercontent.com/u/14099077?v=4","gravatar_id":"","url":"https://api.github.com/users/wgranger","html_url":"https://github.com/wgranger","followers_url":"https://api.github.com/users/wgranger/followers","following_url":"https://api.github.com/users/wgranger/following{/other_user}","gists_url":"https://api.github.com/users/wgranger/gists{/gist_id}","starred_url":"https://api.github.com/users/wgranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgranger/subscriptions","organizations_url":"https://api.github.com/users/wgranger/orgs","repos_url":"https://api.github.com/users/wgranger/repos","events_url":"https://api.github.com/users/wgranger/events{/privacy}","received_events_url":"https://api.github.com/users/wgranger/received_events","type":"User","site_admin":false},"assignees":[{"login":"wgranger","id":14099077,"node_id":"MDQ6VXNlcjE0MDk5MDc3","avatar_url":"https://avatars1.githubusercontent.com/u/14099077?v=4","gravatar_id":"","url":"https://api.github.com/users/wgranger","html_url":"https://github.com/wgranger","followers_url":"https://api.github.com/users/wgranger/followers","following_url":"https://api.github.com/users/wgranger/following{/other_user}","gists_url":"https://api.github.com/users/wgranger/gists{/gist_id}","starred_url":"https://api.github.com/users/wgranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgranger/subscriptions","organizations_url":"https://api.github.com/users/wgranger/orgs","repos_url":"https://api.github.com/users/wgranger/repos","events_url":"https://api.github.com/users/wgranger/events{/privacy}","received_events_url":"https://api.github.com/users/wgranger/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-10-12T14:05:41Z","updated_at":"2018-10-15T15:30:39Z","closed_at":"2018-10-15T15:30:08Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/4987","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4987","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4987.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4987.patch"},"body":"Staging branch URL: https://gold-standard.pfe-preview.zooniverse.org/\r\n\r\nFixes #4984.\r\nFixes #4564.\r\n\r\nAdds an action to toggle `classification.gold_standard` and binds the gold standard checkbox to that action.\r\n\r\n# Required Manual Testing\r\n\r\n- [ ] Does the non-logged in home page render correctly?\r\n- [ ] Does the logged in home page render correctly?\r\n- [ ] Does the projects page render correctly?\r\n- [ ] Can you load project home pages?\r\n- [ ] Can you load the classification page?\r\n- [ ] Can you submit a classification?\r\n- [ ] Does talk load correctly?\r\n- [ ] Can you post a talk comment?\r\n\r\n# Review Checklist\r\n\r\n- [ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [ ] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?\r\n- [ ] Are the tests passing locally and on Travis?\r\n\r\n# Optional\r\n\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you [resized and compressed](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/image-optimization) any image you've added?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?\r\n- [ ] Have you followed the [Springer guidelines for commit messages](https://github.com/springernature/frontend-playbook/blob/master/git/git.md#commit-messages)?\r\n"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/429901513","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4987#issuecomment-429901513","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4987","id":429901513,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkwMTUxMw==","user":{"login":"yshish","id":7211888,"node_id":"MDQ6VXNlcjcyMTE4ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7211888?v=4","gravatar_id":"","url":"https://api.github.com/users/yshish","html_url":"https://github.com/yshish","followers_url":"https://api.github.com/users/yshish/followers","following_url":"https://api.github.com/users/yshish/following{/other_user}","gists_url":"https://api.github.com/users/yshish/gists{/gist_id}","starred_url":"https://api.github.com/users/yshish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yshish/subscriptions","organizations_url":"https://api.github.com/users/yshish/orgs","repos_url":"https://api.github.com/users/yshish/repos","events_url":"https://api.github.com/users/yshish/events{/privacy}","received_events_url":"https://api.github.com/users/yshish/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T15:30:39Z","updated_at":"2018-10-15T15:30:39Z","author_association":"NONE","body":"> I think this code looks sound and I can confirm it fixes the bug experienced. I find it a bit odd that gold standard mode would be turned off after each classification, but maybe there is a reason for this.\r\n\r\nYes, doing the gold standards is pretty annoying, especially when I use it for most of my classification. as well as the need to first click on the 'cog button' to see a pop-up with the check-box. I did suggested some changes about that for the new design to Becky about two days ago.\r\n\r\nHere is what I suggested her:\r\n\r\n1. Make possible to have the Gold standard mode set ON for all classification in a row with an easy way to set it OFF for the few cases when we aren't confident enough to make it gold standard.\r\n\r\n2. Make the process of setting the Gold standard mode easier by just a single click. For example, you could add the check-box just next to the Done button (without the necessity to click on the cog button first to see the pop-up).\r\n\r\n3. Or you could make more 'Done' button choices: one regular and one with the 'star' symbol for Gold standard on it like we have somewhere 'Done' and 'Done&Talk' option next to each other. But that would mean having 4 Done buttons in those projects where you have also Done&Talk. (But that would be probably to much to have: \"Done\" and \"Done&Talk\" and \"Done*\" and \"Done*&Talk\" all at once).\r\n\r\n(Or whatever you can think of that would make the gold standard classifications less painful and less time consuming would be very welcome.)\r\n\r\nAny chance some of that could be realized? Thanks, guys!"}}
{"actor":{"display_login":"yshish"}}