{"action":"created","issue":{"url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/issues/6","repository_url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh","labels_url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/issues/6/comments","events_url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/issues/6/events","html_url":"https://github.com/YunoHost-Apps/shellinabox_ynh/pull/6","id":303302170,"number":6,"title":"Stretch fix","user":{"login":"maniackcrudelis","id":8302225,"avatar_url":"https://avatars2.githubusercontent.com/u/8302225?v=4","gravatar_id":"","url":"https://api.github.com/users/maniackcrudelis","html_url":"https://github.com/maniackcrudelis","followers_url":"https://api.github.com/users/maniackcrudelis/followers","following_url":"https://api.github.com/users/maniackcrudelis/following{/other_user}","gists_url":"https://api.github.com/users/maniackcrudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/maniackcrudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniackcrudelis/subscriptions","organizations_url":"https://api.github.com/users/maniackcrudelis/orgs","repos_url":"https://api.github.com/users/maniackcrudelis/repos","events_url":"https://api.github.com/users/maniackcrudelis/events{/privacy}","received_events_url":"https://api.github.com/users/maniackcrudelis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-07T23:43:01Z","updated_at":"2018-03-25T10:03:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/pulls/6","html_url":"https://github.com/YunoHost-Apps/shellinabox_ynh/pull/6","diff_url":"https://github.com/YunoHost-Apps/shellinabox_ynh/pull/6.diff","patch_url":"https://github.com/YunoHost-Apps/shellinabox_ynh/pull/6.patch"},"body":"## Problem\r\n- *Shellinabox doesn't work on stretch, error 502*\r\n\r\n## Solution\r\n- *Add the argument `disable-ssl` to prevent an error with the reverse-proxy which use http. [Official doc](https://github.com/shellinabox/shellinabox/blob/e6c25e84bc662797c7382500f136bb74874c2500/shellinabox/shellinaboxd.man.in#L638-L641)*\r\n- *Allow eval in nginx header, otherwise shellinabox will be stuck with a blank page and nothing else.*\r\n- *Remove this fucking `--quiet` in the sysvinit script, because trying to debug without a log isn't really easy...*\r\n\r\n## PR Status\r\nWork finished. Package_check, basic tests and upgrade from last version OK.  \r\nCould be reviewed and tested.\r\n\r\n## Validation\r\n---\r\n*Minor decision*\r\n- [ ] **Upgrade previous version** : \r\n- [ ] **Code review** : \r\n- [ ] **Approval (LGTM)** : \r\n- [ ] **Approval (LGTM)** : \r\n- [x] **CI succeeded** : [![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/shellinabox_ynh%20stretch_fix%20(Official)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/shellinabox_ynh%20stretch_fix%20(Official)/)  \r\nWhen the PR is mark as ready to merge, you have to wait for 3 days before really merge it."},"comment":{"url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/issues/comments/375958710","html_url":"https://github.com/YunoHost-Apps/shellinabox_ynh/pull/6#issuecomment-375958710","issue_url":"https://api.github.com/repos/YunoHost-Apps/shellinabox_ynh/issues/6","id":375958710,"user":{"login":"Josue-T","id":7387681,"avatar_url":"https://avatars1.githubusercontent.com/u/7387681?v=4","gravatar_id":"","url":"https://api.github.com/users/Josue-T","html_url":"https://github.com/Josue-T","followers_url":"https://api.github.com/users/Josue-T/followers","following_url":"https://api.github.com/users/Josue-T/following{/other_user}","gists_url":"https://api.github.com/users/Josue-T/gists{/gist_id}","starred_url":"https://api.github.com/users/Josue-T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josue-T/subscriptions","organizations_url":"https://api.github.com/users/Josue-T/orgs","repos_url":"https://api.github.com/users/Josue-T/repos","events_url":"https://api.github.com/users/Josue-T/events{/privacy}","received_events_url":"https://api.github.com/users/Josue-T/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T10:03:30Z","updated_at":"2018-03-25T10:03:30Z","author_association":"NONE","body":"I would say that I had some issue on stretch with some apps (riot, seafile, horde, pgadmin). Adding the rule `add_header Content-Security-Policy-Report-Only \"script-src https: 'unsafe-eval'\";` in nginx fixed my issue. So in my case it's more than 50% of apps that I need to patch.\r\n\r\nI think so that we might have the same problem on a lots of apps.\r\n"}}
{"actor":{"display_login":"Josue-T"}}