{"action":"created","comment":{"url":"https://api.github.com/repos/tocco/tocco-client/pulls/comments/186631299","pull_request_review_id":118244886,"id":186631299,"diff_hunk":"@@ -0,0 +1,51 @@\n+import PropTypes from 'prop-types'\n+import React from 'react'\n+import styled from 'styled-components'\n+\n+import {stylingLook} from '../utilStyles'\n+\n+const StyledMenu = styled.ul`\n+  && {","path":"packages/tocco-ui/src/Menu/Menu.js","position":8,"original_position":8,"commit_id":"317485b479db6af04a02ecf30fbeab5206aaf9c7","original_commit_id":"317485b479db6af04a02ecf30fbeab5206aaf9c7","user":{"login":"niklaushug","id":7427303,"avatar_url":"https://avatars0.githubusercontent.com/u/7427303?v=4","gravatar_id":"","url":"https://api.github.com/users/niklaushug","html_url":"https://github.com/niklaushug","followers_url":"https://api.github.com/users/niklaushug/followers","following_url":"https://api.github.com/users/niklaushug/following{/other_user}","gists_url":"https://api.github.com/users/niklaushug/gists{/gist_id}","starred_url":"https://api.github.com/users/niklaushug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklaushug/subscriptions","organizations_url":"https://api.github.com/users/niklaushug/orgs","repos_url":"https://api.github.com/users/niklaushug/repos","events_url":"https://api.github.com/users/niklaushug/events{/privacy}","received_events_url":"https://api.github.com/users/niklaushug/received_events","type":"User","site_admin":false},"body":"\"&&\" doubles css class hash in stylesheet to increase specificity (e.g. \".abcd.abcd {}\"). Amount of ampersanda is multiplication factor for hash.\r\n\r\nsee also https://www.styled-components.com/docs/faqs#how-can-i-override-styles-with-higher-specificity\r\n\r\nAs long as tocco-theme is active we need that to ensure correct styling (due line 7 in packages/tocco-theme/src/ToccoTheme/theme.scss and the fact that loading order can not be guaranteed). \r\n\r\nIf our flows goes implemented in third party website, it is advisable to have a certain level of specifity to ensure tocco-client styling. E.g. an agency integrates a flow in Bootstrap Panel. Without increaseing specifity those style would leak into our flows. It is not yet sure what the best factor is.\r\n","created_at":"2018-05-08T06:50:57Z","updated_at":"2018-05-08T06:50:57Z","html_url":"https://github.com/tocco/tocco-client/pull/420#discussion_r186631299","pull_request_url":"https://api.github.com/repos/tocco/tocco-client/pulls/420","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tocco/tocco-client/pulls/comments/186631299"},"html":{"href":"https://github.com/tocco/tocco-client/pull/420#discussion_r186631299"},"pull_request":{"href":"https://api.github.com/repos/tocco/tocco-client/pulls/420"}},"in_reply_to_id":184933368},"pull_request":{"url":"https://api.github.com/repos/tocco/tocco-client/pulls/420","id":182485774,"html_url":"https://github.com/tocco/tocco-client/pull/420","diff_url":"https://github.com/tocco/tocco-client/pull/420.diff","patch_url":"https://github.com/tocco/tocco-client/pull/420.patch","issue_url":"https://api.github.com/repos/tocco/tocco-client/issues/420","number":420,"state":"open","locked":false,"title":"feat(tocco-ui): establish Menu components","user":{"login":"niklaushug","id":7427303,"avatar_url":"https://avatars0.githubusercontent.com/u/7427303?v=4","gravatar_id":"","url":"https://api.github.com/users/niklaushug","html_url":"https://github.com/niklaushug","followers_url":"https://api.github.com/users/niklaushug/followers","following_url":"https://api.github.com/users/niklaushug/following{/other_user}","gists_url":"https://api.github.com/users/niklaushug/gists{/gist_id}","starred_url":"https://api.github.com/users/niklaushug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklaushug/subscriptions","organizations_url":"https://api.github.com/users/niklaushug/orgs","repos_url":"https://api.github.com/users/niklaushug/repos","events_url":"https://api.github.com/users/niklaushug/events{/privacy}","received_events_url":"https://api.github.com/users/niklaushug/received_events","type":"User","site_admin":false},"body":"- facilitate arbitrary elements for hierarchically menus (preferable Button and ButtonLink)\r\n- provide three types of menus (MenuBar, MenuButton, MenuStack)\r\n- provide three types of items (Item, ItemAccordion, ItemFlyout)\r\n- allow to set if items are toggable and initially opened","created_at":"2018-04-18T13:50:22Z","updated_at":"2018-05-08T06:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbb19c0f953bf9f2f36e62d608ed9c69043f9f61","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SoaPatrick","id":23744675,"avatar_url":"https://avatars3.githubusercontent.com/u/23744675?v=4","gravatar_id":"","url":"https://api.github.com/users/SoaPatrick","html_url":"https://github.com/SoaPatrick","followers_url":"https://api.github.com/users/SoaPatrick/followers","following_url":"https://api.github.com/users/SoaPatrick/following{/other_user}","gists_url":"https://api.github.com/users/SoaPatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/SoaPatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoaPatrick/subscriptions","organizations_url":"https://api.github.com/users/SoaPatrick/orgs","repos_url":"https://api.github.com/users/SoaPatrick/repos","events_url":"https://api.github.com/users/SoaPatrick/events{/privacy}","received_events_url":"https://api.github.com/users/SoaPatrick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tocco/tocco-client/pulls/420/commits","review_comments_url":"https://api.github.com/repos/tocco/tocco-client/pulls/420/comments","review_comment_url":"https://api.github.com/repos/tocco/tocco-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tocco/tocco-client/issues/420/comments","statuses_url":"https://api.github.com/repos/tocco/tocco-client/statuses/317485b479db6af04a02ecf30fbeab5206aaf9c7","head":{"label":"tocco:styled-components-menu","ref":"styled-components-menu","sha":"317485b479db6af04a02ecf30fbeab5206aaf9c7","user":{"login":"tocco","id":4924049,"avatar_url":"https://avatars0.githubusercontent.com/u/4924049?v=4","gravatar_id":"","url":"https://api.github.com/users/tocco","html_url":"https://github.com/tocco","followers_url":"https://api.github.com/users/tocco/followers","following_url":"https://api.github.com/users/tocco/following{/other_user}","gists_url":"https://api.github.com/users/tocco/gists{/gist_id}","starred_url":"https://api.github.com/users/tocco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tocco/subscriptions","organizations_url":"https://api.github.com/users/tocco/orgs","repos_url":"https://api.github.com/users/tocco/repos","events_url":"https://api.github.com/users/tocco/events{/privacy}","received_events_url":"https://api.github.com/users/tocco/received_events","type":"Organization","site_admin":false},"repo":{"id":69003818,"name":"tocco-client","full_name":"tocco/tocco-client","owner":{"login":"tocco","id":4924049,"avatar_url":"https://avatars0.githubusercontent.com/u/4924049?v=4","gravatar_id":"","url":"https://api.github.com/users/tocco","html_url":"https://github.com/tocco","followers_url":"https://api.github.com/users/tocco/followers","following_url":"https://api.github.com/users/tocco/following{/other_user}","gists_url":"https://api.github.com/users/tocco/gists{/gist_id}","starred_url":"https://api.github.com/users/tocco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tocco/subscriptions","organizations_url":"https://api.github.com/users/tocco/orgs","repos_url":"https://api.github.com/users/tocco/repos","events_url":"https://api.github.com/users/tocco/events{/privacy}","received_events_url":"https://api.github.com/users/tocco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tocco/tocco-client","description":"Web Client for the Tocco Business Framework","fork":false,"url":"https://api.github.com/repos/tocco/tocco-client","forks_url":"https://api.github.com/repos/tocco/tocco-client/forks","keys_url":"https://api.github.com/repos/tocco/tocco-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tocco/tocco-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tocco/tocco-client/teams","hooks_url":"https://api.github.com/repos/tocco/tocco-client/hooks","issue_events_url":"https://api.github.com/repos/tocco/tocco-client/issues/events{/number}","events_url":"https://api.github.com/repos/tocco/tocco-client/events","assignees_url":"https://api.github.com/repos/tocco/tocco-client/assignees{/user}","branches_url":"https://api.github.com/repos/tocco/tocco-client/branches{/branch}","tags_url":"https://api.github.com/repos/tocco/tocco-client/tags","blobs_url":"https://api.github.com/repos/tocco/tocco-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tocco/tocco-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tocco/tocco-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/tocco/tocco-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tocco/tocco-client/statuses/{sha}","languages_url":"https://api.github.com/repos/tocco/tocco-client/languages","stargazers_url":"https://api.github.com/repos/tocco/tocco-client/stargazers","contributors_url":"https://api.github.com/repos/tocco/tocco-client/contributors","subscribers_url":"https://api.github.com/repos/tocco/tocco-client/subscribers","subscription_url":"https://api.github.com/repos/tocco/tocco-client/subscription","commits_url":"https://api.github.com/repos/tocco/tocco-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/tocco/tocco-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/tocco/tocco-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/tocco/tocco-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/tocco/tocco-client/contents/{+path}","compare_url":"https://api.github.com/repos/tocco/tocco-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tocco/tocco-client/merges","archive_url":"https://api.github.com/repos/tocco/tocco-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tocco/tocco-client/downloads","issues_url":"https://api.github.com/repos/tocco/tocco-client/issues{/number}","pulls_url":"https://api.github.com/repos/tocco/tocco-client/pulls{/number}","milestones_url":"https://api.github.com/repos/tocco/tocco-client/milestones{/number}","notifications_url":"https://api.github.com/repos/tocco/tocco-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tocco/tocco-client/labels{/name}","releases_url":"https://api.github.com/repos/tocco/tocco-client/releases{/id}","deployments_url":"https://api.github.com/repos/tocco/tocco-client/deployments","created_at":"2016-09-23T08:09:33Z","updated_at":"2018-05-04T08:57:19Z","pushed_at":"2018-05-07T10:53:51Z","git_url":"git://github.com/tocco/tocco-client.git","ssh_url":"git@github.com:tocco/tocco-client.git","clone_url":"https://github.com/tocco/tocco-client.git","svn_url":"https://github.com/tocco/tocco-client","homepage":"https://www.tocco.ch","size":24411,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":4,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"tocco:styled-components","ref":"styled-components","sha":"b9104b47adb26e1d737a7c545cd4de466b15d108","user":{"login":"tocco","id":4924049,"avatar_url":"https://avatars0.githubusercontent.com/u/4924049?v=4","gravatar_id":"","url":"https://api.github.com/users/tocco","html_url":"https://github.com/tocco","followers_url":"https://api.github.com/users/tocco/followers","following_url":"https://api.github.com/users/tocco/following{/other_user}","gists_url":"https://api.github.com/users/tocco/gists{/gist_id}","starred_url":"https://api.github.com/users/tocco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tocco/subscriptions","organizations_url":"https://api.github.com/users/tocco/orgs","repos_url":"https://api.github.com/users/tocco/repos","events_url":"https://api.github.com/users/tocco/events{/privacy}","received_events_url":"https://api.github.com/users/tocco/received_events","type":"Organization","site_admin":false},"repo":{"id":69003818,"name":"tocco-client","full_name":"tocco/tocco-client","owner":{"login":"tocco","id":4924049,"avatar_url":"https://avatars0.githubusercontent.com/u/4924049?v=4","gravatar_id":"","url":"https://api.github.com/users/tocco","html_url":"https://github.com/tocco","followers_url":"https://api.github.com/users/tocco/followers","following_url":"https://api.github.com/users/tocco/following{/other_user}","gists_url":"https://api.github.com/users/tocco/gists{/gist_id}","starred_url":"https://api.github.com/users/tocco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tocco/subscriptions","organizations_url":"https://api.github.com/users/tocco/orgs","repos_url":"https://api.github.com/users/tocco/repos","events_url":"https://api.github.com/users/tocco/events{/privacy}","received_events_url":"https://api.github.com/users/tocco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tocco/tocco-client","description":"Web Client for the Tocco Business Framework","fork":false,"url":"https://api.github.com/repos/tocco/tocco-client","forks_url":"https://api.github.com/repos/tocco/tocco-client/forks","keys_url":"https://api.github.com/repos/tocco/tocco-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tocco/tocco-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tocco/tocco-client/teams","hooks_url":"https://api.github.com/repos/tocco/tocco-client/hooks","issue_events_url":"https://api.github.com/repos/tocco/tocco-client/issues/events{/number}","events_url":"https://api.github.com/repos/tocco/tocco-client/events","assignees_url":"https://api.github.com/repos/tocco/tocco-client/assignees{/user}","branches_url":"https://api.github.com/repos/tocco/tocco-client/branches{/branch}","tags_url":"https://api.github.com/repos/tocco/tocco-client/tags","blobs_url":"https://api.github.com/repos/tocco/tocco-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tocco/tocco-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tocco/tocco-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/tocco/tocco-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tocco/tocco-client/statuses/{sha}","languages_url":"https://api.github.com/repos/tocco/tocco-client/languages","stargazers_url":"https://api.github.com/repos/tocco/tocco-client/stargazers","contributors_url":"https://api.github.com/repos/tocco/tocco-client/contributors","subscribers_url":"https://api.github.com/repos/tocco/tocco-client/subscribers","subscription_url":"https://api.github.com/repos/tocco/tocco-client/subscription","commits_url":"https://api.github.com/repos/tocco/tocco-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/tocco/tocco-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/tocco/tocco-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/tocco/tocco-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/tocco/tocco-client/contents/{+path}","compare_url":"https://api.github.com/repos/tocco/tocco-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tocco/tocco-client/merges","archive_url":"https://api.github.com/repos/tocco/tocco-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tocco/tocco-client/downloads","issues_url":"https://api.github.com/repos/tocco/tocco-client/issues{/number}","pulls_url":"https://api.github.com/repos/tocco/tocco-client/pulls{/number}","milestones_url":"https://api.github.com/repos/tocco/tocco-client/milestones{/number}","notifications_url":"https://api.github.com/repos/tocco/tocco-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tocco/tocco-client/labels{/name}","releases_url":"https://api.github.com/repos/tocco/tocco-client/releases{/id}","deployments_url":"https://api.github.com/repos/tocco/tocco-client/deployments","created_at":"2016-09-23T08:09:33Z","updated_at":"2018-05-04T08:57:19Z","pushed_at":"2018-05-07T10:53:51Z","git_url":"git://github.com/tocco/tocco-client.git","ssh_url":"git@github.com:tocco/tocco-client.git","clone_url":"https://github.com/tocco/tocco-client.git","svn_url":"https://github.com/tocco/tocco-client","homepage":"https://www.tocco.ch","size":24411,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":4,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tocco/tocco-client/pulls/420"},"html":{"href":"https://github.com/tocco/tocco-client/pull/420"},"issue":{"href":"https://api.github.com/repos/tocco/tocco-client/issues/420"},"comments":{"href":"https://api.github.com/repos/tocco/tocco-client/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/tocco/tocco-client/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/tocco/tocco-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tocco/tocco-client/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/tocco/tocco-client/statuses/317485b479db6af04a02ecf30fbeab5206aaf9c7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"niklaushug"}}