{"action":"created","comment":{"url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/comments/195365193","pull_request_review_id":128718245,"id":195365193,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTM2NTE5Mw==","diff_hunk":"@@ -16,12 +16,14 @@\n     public function doAction(CustomerReposiotry customer)\n     {\n \t// What kind of problem can we have when using global variables?\n+//Concurrency issues//Testing and Confinement ","path":"ApiController.php","position":null,"original_position":13,"commit_id":"700a8f4a3ff96989b35d3e8c7a73e5b2cf92d941","original_commit_id":"700a8f4a3ff96989b35d3e8c7a73e5b2cf92d941","user":{"login":"nguyenjay90","id":18069401,"node_id":"MDQ6VXNlcjE4MDY5NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18069401?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenjay90","html_url":"https://github.com/nguyenjay90","followers_url":"https://api.github.com/users/nguyenjay90/followers","following_url":"https://api.github.com/users/nguyenjay90/following{/other_user}","gists_url":"https://api.github.com/users/nguyenjay90/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenjay90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenjay90/subscriptions","organizations_url":"https://api.github.com/users/nguyenjay90/orgs","repos_url":"https://api.github.com/users/nguyenjay90/repos","events_url":"https://api.github.com/users/nguyenjay90/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenjay90/received_events","type":"User","site_admin":false},"body":" Yes Concurrency issues .If using  globals variable can be access by multiple threads of execution, synchronization is necessary. When dynamically linking modules with globals, the composed system might not be thread-safe even if the two independent modules tested in dozens of different contexts were safe.","created_at":"2018-06-14T09:57:46Z","updated_at":"2018-06-14T09:57:46Z","html_url":"https://github.com/nguyenjay90/RefactorCode/pull/1#discussion_r195365193","pull_request_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/comments/195365193"},"html":{"href":"https://github.com/nguyenjay90/RefactorCode/pull/1#discussion_r195365193"},"pull_request":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1"}},"in_reply_to_id":195359001},"pull_request":{"url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1","id":194550265,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTUwMjY1","html_url":"https://github.com/nguyenjay90/RefactorCode/pull/1","diff_url":"https://github.com/nguyenjay90/RefactorCode/pull/1.diff","patch_url":"https://github.com/nguyenjay90/RefactorCode/pull/1.patch","issue_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues/1","number":1,"state":"closed","locked":false,"title":"Questions about your refactoring","user":{"login":"JeremyZr","id":25215507,"node_id":"MDQ6VXNlcjI1MjE1NTA3","avatar_url":"https://avatars0.githubusercontent.com/u/25215507?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyZr","html_url":"https://github.com/JeremyZr","followers_url":"https://api.github.com/users/JeremyZr/followers","following_url":"https://api.github.com/users/JeremyZr/following{/other_user}","gists_url":"https://api.github.com/users/JeremyZr/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyZr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyZr/subscriptions","organizations_url":"https://api.github.com/users/JeremyZr/orgs","repos_url":"https://api.github.com/users/JeremyZr/repos","events_url":"https://api.github.com/users/JeremyZr/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyZr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-13T11:10:01Z","updated_at":"2018-06-14T09:57:46Z","closed_at":"2018-06-13T12:09:51Z","merged_at":"2018-06-13T12:09:50Z","merge_commit_sha":"0c7b1edad5beabbca1110180763c783d52c5a3c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues/1/comments","statuses_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/statuses/700a8f4a3ff96989b35d3e8c7a73e5b2cf92d941","head":{"label":"JeremyZr:patch-1","ref":"patch-1","sha":"700a8f4a3ff96989b35d3e8c7a73e5b2cf92d941","user":{"login":"JeremyZr","id":25215507,"node_id":"MDQ6VXNlcjI1MjE1NTA3","avatar_url":"https://avatars0.githubusercontent.com/u/25215507?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyZr","html_url":"https://github.com/JeremyZr","followers_url":"https://api.github.com/users/JeremyZr/followers","following_url":"https://api.github.com/users/JeremyZr/following{/other_user}","gists_url":"https://api.github.com/users/JeremyZr/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyZr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyZr/subscriptions","organizations_url":"https://api.github.com/users/JeremyZr/orgs","repos_url":"https://api.github.com/users/JeremyZr/repos","events_url":"https://api.github.com/users/JeremyZr/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyZr/received_events","type":"User","site_admin":false},"repo":{"id":137204195,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMDQxOTU=","name":"RefactorCode","full_name":"JeremyZr/RefactorCode","owner":{"login":"JeremyZr","id":25215507,"node_id":"MDQ6VXNlcjI1MjE1NTA3","avatar_url":"https://avatars0.githubusercontent.com/u/25215507?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyZr","html_url":"https://github.com/JeremyZr","followers_url":"https://api.github.com/users/JeremyZr/followers","following_url":"https://api.github.com/users/JeremyZr/following{/other_user}","gists_url":"https://api.github.com/users/JeremyZr/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyZr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyZr/subscriptions","organizations_url":"https://api.github.com/users/JeremyZr/orgs","repos_url":"https://api.github.com/users/JeremyZr/repos","events_url":"https://api.github.com/users/JeremyZr/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyZr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JeremyZr/RefactorCode","description":null,"fork":true,"url":"https://api.github.com/repos/JeremyZr/RefactorCode","forks_url":"https://api.github.com/repos/JeremyZr/RefactorCode/forks","keys_url":"https://api.github.com/repos/JeremyZr/RefactorCode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeremyZr/RefactorCode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeremyZr/RefactorCode/teams","hooks_url":"https://api.github.com/repos/JeremyZr/RefactorCode/hooks","issue_events_url":"https://api.github.com/repos/JeremyZr/RefactorCode/issues/events{/number}","events_url":"https://api.github.com/repos/JeremyZr/RefactorCode/events","assignees_url":"https://api.github.com/repos/JeremyZr/RefactorCode/assignees{/user}","branches_url":"https://api.github.com/repos/JeremyZr/RefactorCode/branches{/branch}","tags_url":"https://api.github.com/repos/JeremyZr/RefactorCode/tags","blobs_url":"https://api.github.com/repos/JeremyZr/RefactorCode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeremyZr/RefactorCode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeremyZr/RefactorCode/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeremyZr/RefactorCode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeremyZr/RefactorCode/statuses/{sha}","languages_url":"https://api.github.com/repos/JeremyZr/RefactorCode/languages","stargazers_url":"https://api.github.com/repos/JeremyZr/RefactorCode/stargazers","contributors_url":"https://api.github.com/repos/JeremyZr/RefactorCode/contributors","subscribers_url":"https://api.github.com/repos/JeremyZr/RefactorCode/subscribers","subscription_url":"https://api.github.com/repos/JeremyZr/RefactorCode/subscription","commits_url":"https://api.github.com/repos/JeremyZr/RefactorCode/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeremyZr/RefactorCode/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeremyZr/RefactorCode/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeremyZr/RefactorCode/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeremyZr/RefactorCode/contents/{+path}","compare_url":"https://api.github.com/repos/JeremyZr/RefactorCode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeremyZr/RefactorCode/merges","archive_url":"https://api.github.com/repos/JeremyZr/RefactorCode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeremyZr/RefactorCode/downloads","issues_url":"https://api.github.com/repos/JeremyZr/RefactorCode/issues{/number}","pulls_url":"https://api.github.com/repos/JeremyZr/RefactorCode/pulls{/number}","milestones_url":"https://api.github.com/repos/JeremyZr/RefactorCode/milestones{/number}","notifications_url":"https://api.github.com/repos/JeremyZr/RefactorCode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeremyZr/RefactorCode/labels{/name}","releases_url":"https://api.github.com/repos/JeremyZr/RefactorCode/releases{/id}","deployments_url":"https://api.github.com/repos/JeremyZr/RefactorCode/deployments","created_at":"2018-06-13T11:06:35Z","updated_at":"2018-06-13T11:06:37Z","pushed_at":"2018-06-13T12:07:22Z","git_url":"git://github.com/JeremyZr/RefactorCode.git","ssh_url":"git@github.com:JeremyZr/RefactorCode.git","clone_url":"https://github.com/JeremyZr/RefactorCode.git","svn_url":"https://github.com/JeremyZr/RefactorCode","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nguyenjay90:master","ref":"master","sha":"04ee67807bc1a5e569f057f59aeaab31878aa685","user":{"login":"nguyenjay90","id":18069401,"node_id":"MDQ6VXNlcjE4MDY5NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18069401?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenjay90","html_url":"https://github.com/nguyenjay90","followers_url":"https://api.github.com/users/nguyenjay90/followers","following_url":"https://api.github.com/users/nguyenjay90/following{/other_user}","gists_url":"https://api.github.com/users/nguyenjay90/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenjay90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenjay90/subscriptions","organizations_url":"https://api.github.com/users/nguyenjay90/orgs","repos_url":"https://api.github.com/users/nguyenjay90/repos","events_url":"https://api.github.com/users/nguyenjay90/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenjay90/received_events","type":"User","site_admin":false},"repo":{"id":137201338,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMDEzMzg=","name":"RefactorCode","full_name":"nguyenjay90/RefactorCode","owner":{"login":"nguyenjay90","id":18069401,"node_id":"MDQ6VXNlcjE4MDY5NDAx","avatar_url":"https://avatars0.githubusercontent.com/u/18069401?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenjay90","html_url":"https://github.com/nguyenjay90","followers_url":"https://api.github.com/users/nguyenjay90/followers","following_url":"https://api.github.com/users/nguyenjay90/following{/other_user}","gists_url":"https://api.github.com/users/nguyenjay90/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenjay90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenjay90/subscriptions","organizations_url":"https://api.github.com/users/nguyenjay90/orgs","repos_url":"https://api.github.com/users/nguyenjay90/repos","events_url":"https://api.github.com/users/nguyenjay90/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenjay90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nguyenjay90/RefactorCode","description":null,"fork":false,"url":"https://api.github.com/repos/nguyenjay90/RefactorCode","forks_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/forks","keys_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/teams","hooks_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/hooks","issue_events_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues/events{/number}","events_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/events","assignees_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/assignees{/user}","branches_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/branches{/branch}","tags_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/tags","blobs_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/git/refs{/sha}","trees_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/statuses/{sha}","languages_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/languages","stargazers_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/stargazers","contributors_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/contributors","subscribers_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/subscribers","subscription_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/subscription","commits_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/commits{/sha}","git_commits_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/git/commits{/sha}","comments_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/comments{/number}","issue_comment_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues/comments{/number}","contents_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/contents/{+path}","compare_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/merges","archive_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/downloads","issues_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues{/number}","pulls_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls{/number}","milestones_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/milestones{/number}","notifications_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/labels{/name}","releases_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/releases{/id}","deployments_url":"https://api.github.com/repos/nguyenjay90/RefactorCode/deployments","created_at":"2018-06-13T10:37:31Z","updated_at":"2018-06-13T12:09:52Z","pushed_at":"2018-06-13T12:09:51Z","git_url":"git://github.com/nguyenjay90/RefactorCode.git","ssh_url":"git@github.com:nguyenjay90/RefactorCode.git","clone_url":"https://github.com/nguyenjay90/RefactorCode.git","svn_url":"https://github.com/nguyenjay90/RefactorCode","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1"},"html":{"href":"https://github.com/nguyenjay90/RefactorCode/pull/1"},"issue":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues/1"},"comments":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nguyenjay90/RefactorCode/statuses/700a8f4a3ff96989b35d3e8c7a73e5b2cf92d941"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nguyenjay90"}}