{"action":"created","comment":{"url":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments/167178039","pull_request_review_id":95359622,"id":167178039,"diff_hunk":"@@ -42,21 +42,37 @@ first one to start |                    |     |                   |    |\n \n - a major addition to the worker process is fstack-handling：ff_init();ff_run(worker_process_cycle); worker_process_cycle(handle channel/host/fstack event).\n \n-- a new directive `kernel_network_stack` :\n+## What's Different?\n+### New directives:\n+All the directives below are available only when ```NGX_HAVE_FSTACK``` is defined.\n ```\n     Syntax: kernel_network_stack on | off;\n     Default: kernel_network_stack off;\n     Context: http, server\n-    This directive is available only when ```NGX_HAVE_FSTACK``` is defined.\n+\n     Determines whether server should run on kernel network stack or fstack.\n ```\n \n-Note that:\n+```\n+    Syntax: proxy_kernel_network_stack on | off;\n+    Default: kernel_network_stack off;\n+    Context: http, stream, mail, server\n+\n+    Determines whether proxy should go through kernel network stack or fstack.\n+```\n \n-- the `reload` is not graceful, service will still be unavailable during the process of reloading.\n+```\n+    Syntax: schedule_timeout time;\n+    Default: schedule_timeout 30m;","path":"doc/F-Stack_Nginx_APP_Guide.md","position":29,"original_position":29,"commit_id":"38120bf0aa4fcda9a173dd3f857bbefacfd33018","original_commit_id":"38120bf0aa4fcda9a173dd3f857bbefacfd33018","user":{"login":"whl739","id":5668899,"avatar_url":"https://avatars3.githubusercontent.com/u/5668899?v=4","gravatar_id":"","url":"https://api.github.com/users/whl739","html_url":"https://github.com/whl739","followers_url":"https://api.github.com/users/whl739/followers","following_url":"https://api.github.com/users/whl739/following{/other_user}","gists_url":"https://api.github.com/users/whl739/gists{/gist_id}","starred_url":"https://api.github.com/users/whl739/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whl739/subscriptions","organizations_url":"https://api.github.com/users/whl739/orgs","repos_url":"https://api.github.com/users/whl739/repos","events_url":"https://api.github.com/users/whl739/events{/privacy}","received_events_url":"https://api.github.com/users/whl739/received_events","type":"User","site_admin":false},"body":"Should this be `30` or `30ms`?","created_at":"2018-02-09T09:32:42Z","updated_at":"2018-02-09T09:32:42Z","html_url":"https://github.com/F-Stack/f-stack/pull/161#discussion_r167178039","pull_request_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/161","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments/167178039"},"html":{"href":"https://github.com/F-Stack/f-stack/pull/161#discussion_r167178039"},"pull_request":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/F-Stack/f-stack/pulls/161","id":168179873,"html_url":"https://github.com/F-Stack/f-stack/pull/161","diff_url":"https://github.com/F-Stack/f-stack/pull/161.diff","patch_url":"https://github.com/F-Stack/f-stack/pull/161.patch","issue_url":"https://api.github.com/repos/F-Stack/f-stack/issues/161","number":161,"state":"open","locked":false,"title":"Nginx : directive proxy_kernel_network_stack","user":{"login":"chadwill","id":29646906,"avatar_url":"https://avatars1.githubusercontent.com/u/29646906?v=4","gravatar_id":"","url":"https://api.github.com/users/chadwill","html_url":"https://github.com/chadwill","followers_url":"https://api.github.com/users/chadwill/followers","following_url":"https://api.github.com/users/chadwill/following{/other_user}","gists_url":"https://api.github.com/users/chadwill/gists{/gist_id}","starred_url":"https://api.github.com/users/chadwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadwill/subscriptions","organizations_url":"https://api.github.com/users/chadwill/orgs","repos_url":"https://api.github.com/users/chadwill/repos","events_url":"https://api.github.com/users/chadwill/events{/privacy}","received_events_url":"https://api.github.com/users/chadwill/received_events","type":"User","site_admin":false},"body":"1. Add a new directive ```proxy_kernel_network_stack``` :\r\n```\r\nSyntax: \tproxy_kernel_network_stack on | off;\r\nDefault: \tproxy_kernel_network_stack off;\r\nContext: \thttp, stream, mail, server\r\n```\r\nThis directive is available only when ```NGX_HAVE_FF_STACK``` is defined.\r\nDetermines whether proxy should go throught kernel network stack or fstack.\r\n2. Update F-Stack_Nginx_APP_Guide.md","created_at":"2018-02-09T08:32:09Z","updated_at":"2018-02-09T09:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebed71aee5e32447ecf627396758ad3dc40153b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/161/commits","review_comments_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/161/comments","review_comment_url":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F-Stack/f-stack/issues/161/comments","statuses_url":"https://api.github.com/repos/F-Stack/f-stack/statuses/38120bf0aa4fcda9a173dd3f857bbefacfd33018","head":{"label":"chadwill:master","ref":"master","sha":"38120bf0aa4fcda9a173dd3f857bbefacfd33018","user":{"login":"chadwill","id":29646906,"avatar_url":"https://avatars1.githubusercontent.com/u/29646906?v=4","gravatar_id":"","url":"https://api.github.com/users/chadwill","html_url":"https://github.com/chadwill","followers_url":"https://api.github.com/users/chadwill/followers","following_url":"https://api.github.com/users/chadwill/following{/other_user}","gists_url":"https://api.github.com/users/chadwill/gists{/gist_id}","starred_url":"https://api.github.com/users/chadwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadwill/subscriptions","organizations_url":"https://api.github.com/users/chadwill/orgs","repos_url":"https://api.github.com/users/chadwill/repos","events_url":"https://api.github.com/users/chadwill/events{/privacy}","received_events_url":"https://api.github.com/users/chadwill/received_events","type":"User","site_admin":false},"repo":{"id":119543412,"name":"f-stack","full_name":"chadwill/f-stack","owner":{"login":"chadwill","id":29646906,"avatar_url":"https://avatars1.githubusercontent.com/u/29646906?v=4","gravatar_id":"","url":"https://api.github.com/users/chadwill","html_url":"https://github.com/chadwill","followers_url":"https://api.github.com/users/chadwill/followers","following_url":"https://api.github.com/users/chadwill/following{/other_user}","gists_url":"https://api.github.com/users/chadwill/gists{/gist_id}","starred_url":"https://api.github.com/users/chadwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadwill/subscriptions","organizations_url":"https://api.github.com/users/chadwill/orgs","repos_url":"https://api.github.com/users/chadwill/repos","events_url":"https://api.github.com/users/chadwill/events{/privacy}","received_events_url":"https://api.github.com/users/chadwill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadwill/f-stack","description":"F-Stack is an user space  network development kit with high performance based on DPDK, FreeBSD TCP/IP stack and coroutine API.","fork":true,"url":"https://api.github.com/repos/chadwill/f-stack","forks_url":"https://api.github.com/repos/chadwill/f-stack/forks","keys_url":"https://api.github.com/repos/chadwill/f-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadwill/f-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadwill/f-stack/teams","hooks_url":"https://api.github.com/repos/chadwill/f-stack/hooks","issue_events_url":"https://api.github.com/repos/chadwill/f-stack/issues/events{/number}","events_url":"https://api.github.com/repos/chadwill/f-stack/events","assignees_url":"https://api.github.com/repos/chadwill/f-stack/assignees{/user}","branches_url":"https://api.github.com/repos/chadwill/f-stack/branches{/branch}","tags_url":"https://api.github.com/repos/chadwill/f-stack/tags","blobs_url":"https://api.github.com/repos/chadwill/f-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadwill/f-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadwill/f-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadwill/f-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadwill/f-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/chadwill/f-stack/languages","stargazers_url":"https://api.github.com/repos/chadwill/f-stack/stargazers","contributors_url":"https://api.github.com/repos/chadwill/f-stack/contributors","subscribers_url":"https://api.github.com/repos/chadwill/f-stack/subscribers","subscription_url":"https://api.github.com/repos/chadwill/f-stack/subscription","commits_url":"https://api.github.com/repos/chadwill/f-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadwill/f-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadwill/f-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadwill/f-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadwill/f-stack/contents/{+path}","compare_url":"https://api.github.com/repos/chadwill/f-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadwill/f-stack/merges","archive_url":"https://api.github.com/repos/chadwill/f-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadwill/f-stack/downloads","issues_url":"https://api.github.com/repos/chadwill/f-stack/issues{/number}","pulls_url":"https://api.github.com/repos/chadwill/f-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/chadwill/f-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/chadwill/f-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadwill/f-stack/labels{/name}","releases_url":"https://api.github.com/repos/chadwill/f-stack/releases{/id}","deployments_url":"https://api.github.com/repos/chadwill/f-stack/deployments","created_at":"2018-01-30T13:58:35Z","updated_at":"2018-01-30T13:59:13Z","pushed_at":"2018-02-06T07:56:25Z","git_url":"git://github.com/chadwill/f-stack.git","ssh_url":"git@github.com:chadwill/f-stack.git","clone_url":"https://github.com/chadwill/f-stack.git","svn_url":"https://github.com/chadwill/f-stack","homepage":"http://www.f-stack.org","size":42929,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F-Stack:master","ref":"master","sha":"80b2d7d52b5b4e361ed005bf168740428dff2d2e","user":{"login":"F-Stack","id":26062241,"avatar_url":"https://avatars0.githubusercontent.com/u/26062241?v=4","gravatar_id":"","url":"https://api.github.com/users/F-Stack","html_url":"https://github.com/F-Stack","followers_url":"https://api.github.com/users/F-Stack/followers","following_url":"https://api.github.com/users/F-Stack/following{/other_user}","gists_url":"https://api.github.com/users/F-Stack/gists{/gist_id}","starred_url":"https://api.github.com/users/F-Stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F-Stack/subscriptions","organizations_url":"https://api.github.com/users/F-Stack/orgs","repos_url":"https://api.github.com/users/F-Stack/repos","events_url":"https://api.github.com/users/F-Stack/events{/privacy}","received_events_url":"https://api.github.com/users/F-Stack/received_events","type":"Organization","site_admin":false},"repo":{"id":88224621,"name":"f-stack","full_name":"F-Stack/f-stack","owner":{"login":"F-Stack","id":26062241,"avatar_url":"https://avatars0.githubusercontent.com/u/26062241?v=4","gravatar_id":"","url":"https://api.github.com/users/F-Stack","html_url":"https://github.com/F-Stack","followers_url":"https://api.github.com/users/F-Stack/followers","following_url":"https://api.github.com/users/F-Stack/following{/other_user}","gists_url":"https://api.github.com/users/F-Stack/gists{/gist_id}","starred_url":"https://api.github.com/users/F-Stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F-Stack/subscriptions","organizations_url":"https://api.github.com/users/F-Stack/orgs","repos_url":"https://api.github.com/users/F-Stack/repos","events_url":"https://api.github.com/users/F-Stack/events{/privacy}","received_events_url":"https://api.github.com/users/F-Stack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F-Stack/f-stack","description":"F-Stack is an user space  network development kit with high performance based on DPDK, FreeBSD TCP/IP stack and coroutine API.","fork":false,"url":"https://api.github.com/repos/F-Stack/f-stack","forks_url":"https://api.github.com/repos/F-Stack/f-stack/forks","keys_url":"https://api.github.com/repos/F-Stack/f-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F-Stack/f-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F-Stack/f-stack/teams","hooks_url":"https://api.github.com/repos/F-Stack/f-stack/hooks","issue_events_url":"https://api.github.com/repos/F-Stack/f-stack/issues/events{/number}","events_url":"https://api.github.com/repos/F-Stack/f-stack/events","assignees_url":"https://api.github.com/repos/F-Stack/f-stack/assignees{/user}","branches_url":"https://api.github.com/repos/F-Stack/f-stack/branches{/branch}","tags_url":"https://api.github.com/repos/F-Stack/f-stack/tags","blobs_url":"https://api.github.com/repos/F-Stack/f-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F-Stack/f-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F-Stack/f-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/F-Stack/f-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F-Stack/f-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/F-Stack/f-stack/languages","stargazers_url":"https://api.github.com/repos/F-Stack/f-stack/stargazers","contributors_url":"https://api.github.com/repos/F-Stack/f-stack/contributors","subscribers_url":"https://api.github.com/repos/F-Stack/f-stack/subscribers","subscription_url":"https://api.github.com/repos/F-Stack/f-stack/subscription","commits_url":"https://api.github.com/repos/F-Stack/f-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/F-Stack/f-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/F-Stack/f-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/F-Stack/f-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/F-Stack/f-stack/contents/{+path}","compare_url":"https://api.github.com/repos/F-Stack/f-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F-Stack/f-stack/merges","archive_url":"https://api.github.com/repos/F-Stack/f-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F-Stack/f-stack/downloads","issues_url":"https://api.github.com/repos/F-Stack/f-stack/issues{/number}","pulls_url":"https://api.github.com/repos/F-Stack/f-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/F-Stack/f-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/F-Stack/f-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F-Stack/f-stack/labels{/name}","releases_url":"https://api.github.com/repos/F-Stack/f-stack/releases{/id}","deployments_url":"https://api.github.com/repos/F-Stack/f-stack/deployments","created_at":"2017-04-14T02:25:12Z","updated_at":"2018-02-08T10:31:14Z","pushed_at":"2018-02-09T08:32:10Z","git_url":"git://github.com/F-Stack/f-stack.git","ssh_url":"git@github.com:F-Stack/f-stack.git","clone_url":"https://github.com/F-Stack/f-stack.git","svn_url":"https://github.com/F-Stack/f-stack","homepage":"http://www.f-stack.org","size":42911,"stargazers_count":1284,"watchers_count":1284,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":260,"open_issues":23,"watchers":1284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/161"},"html":{"href":"https://github.com/F-Stack/f-stack/pull/161"},"issue":{"href":"https://api.github.com/repos/F-Stack/f-stack/issues/161"},"comments":{"href":"https://api.github.com/repos/F-Stack/f-stack/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F-Stack/f-stack/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/F-Stack/f-stack/statuses/38120bf0aa4fcda9a173dd3f857bbefacfd33018"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"whl739"}}