{"action":"created","comment":{"url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/comments/180938271","pull_request_review_id":111449361,"id":180938271,"diff_hunk":"@@ -18,10 +18,19 @@ class SignupViewController: UIViewController, UITextFieldDelegate {\n     @IBOutlet weak var passwordTextField: UITextField!\n     @IBOutlet weak var confirmPasswordTextField: UITextField!\n     @IBOutlet weak var phoneNumberTextField: UITextField!\n-    \n+    @IBOutlet weak var firstNameTextField: UITextField!\n+    @IBOutlet weak var lastNameTextField: UITextField!\n+\n+    @IBOutlet weak var textFieldsStackView: UIStackView!\n+\n     override func viewDidLoad() {\n         super.viewDidLoad()\n         view.backgroundColor = .thPrimaryPurple\n+        textFieldsStackView.arrangedSubviews.forEach { view in\n+            guard view is UITextField else { return }\n+            view.keyboardDistanceFromTextField = 24","path":"Thirty/Thirty/View Controllers/Signup/SignupViewController.swift","position":15,"original_position":15,"commit_id":"dff2aabf8cb81152473c7cd22ef74298317fa590","original_commit_id":"dff2aabf8cb81152473c7cd22ef74298317fa590","user":{"login":"alanscarpa","id":8715611,"avatar_url":"https://avatars3.githubusercontent.com/u/8715611?v=4","gravatar_id":"","url":"https://api.github.com/users/alanscarpa","html_url":"https://github.com/alanscarpa","followers_url":"https://api.github.com/users/alanscarpa/followers","following_url":"https://api.github.com/users/alanscarpa/following{/other_user}","gists_url":"https://api.github.com/users/alanscarpa/gists{/gist_id}","starred_url":"https://api.github.com/users/alanscarpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanscarpa/subscriptions","organizations_url":"https://api.github.com/users/alanscarpa/orgs","repos_url":"https://api.github.com/users/alanscarpa/repos","events_url":"https://api.github.com/users/alanscarpa/events{/privacy}","received_events_url":"https://api.github.com/users/alanscarpa/received_events","type":"User","site_admin":false},"body":"sweet","created_at":"2018-04-12T00:48:08Z","updated_at":"2018-04-12T00:48:14Z","html_url":"https://github.com/alanscarpa/thirty-sinch/pull/11#discussion_r180938271","pull_request_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/comments/180938271"},"html":{"href":"https://github.com/alanscarpa/thirty-sinch/pull/11#discussion_r180938271"},"pull_request":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11","id":180186555,"html_url":"https://github.com/alanscarpa/thirty-sinch/pull/11","diff_url":"https://github.com/alanscarpa/thirty-sinch/pull/11.diff","patch_url":"https://github.com/alanscarpa/thirty-sinch/pull/11.patch","issue_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/11","number":11,"state":"open","locked":false,"title":"(WIP) First / Last Name Updates","user":{"login":"tomalley104","id":9475035,"avatar_url":"https://avatars3.githubusercontent.com/u/9475035?v=4","gravatar_id":"","url":"https://api.github.com/users/tomalley104","html_url":"https://github.com/tomalley104","followers_url":"https://api.github.com/users/tomalley104/followers","following_url":"https://api.github.com/users/tomalley104/following{/other_user}","gists_url":"https://api.github.com/users/tomalley104/gists{/gist_id}","starred_url":"https://api.github.com/users/tomalley104/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomalley104/subscriptions","organizations_url":"https://api.github.com/users/tomalley104/orgs","repos_url":"https://api.github.com/users/tomalley104/repos","events_url":"https://api.github.com/users/tomalley104/events{/privacy}","received_events_url":"https://api.github.com/users/tomalley104/received_events","type":"User","site_admin":false},"body":"Commits should be self explanatory for where we're at right now, overall goals for this PR are:\r\n\r\n- ~add first/last name to User model~\r\n- ~load first/last name when fetching Users~\r\n- ~save first/last name on user sign up~\r\n- ~update signup screen to have first/last name fields~\r\n-  update friends list to display first/last name (have to discuss UI w/ @alanscarpa)\r\n- update anywhere else in app we want to display first/last name (also discuss w/ @alanscarpa)\r\n\r\nFuture TODO:\r\n- allow user to add/edit their first/last name on [currently non-existant] user profile page","created_at":"2018-04-08T23:25:50Z","updated_at":"2018-04-12T00:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6241aa2488a8a9281f33f99dc4376d43ec02d3a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11/commits","review_comments_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11/comments","review_comment_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/11/comments","statuses_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/statuses/dff2aabf8cb81152473c7cd22ef74298317fa590","head":{"label":"alanscarpa:tom/firstNameLastName","ref":"tom/firstNameLastName","sha":"dff2aabf8cb81152473c7cd22ef74298317fa590","user":{"login":"alanscarpa","id":8715611,"avatar_url":"https://avatars3.githubusercontent.com/u/8715611?v=4","gravatar_id":"","url":"https://api.github.com/users/alanscarpa","html_url":"https://github.com/alanscarpa","followers_url":"https://api.github.com/users/alanscarpa/followers","following_url":"https://api.github.com/users/alanscarpa/following{/other_user}","gists_url":"https://api.github.com/users/alanscarpa/gists{/gist_id}","starred_url":"https://api.github.com/users/alanscarpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanscarpa/subscriptions","organizations_url":"https://api.github.com/users/alanscarpa/orgs","repos_url":"https://api.github.com/users/alanscarpa/repos","events_url":"https://api.github.com/users/alanscarpa/events{/privacy}","received_events_url":"https://api.github.com/users/alanscarpa/received_events","type":"User","site_admin":false},"repo":{"id":81385829,"name":"thirty-sinch","full_name":"alanscarpa/thirty-sinch","owner":{"login":"alanscarpa","id":8715611,"avatar_url":"https://avatars3.githubusercontent.com/u/8715611?v=4","gravatar_id":"","url":"https://api.github.com/users/alanscarpa","html_url":"https://github.com/alanscarpa","followers_url":"https://api.github.com/users/alanscarpa/followers","following_url":"https://api.github.com/users/alanscarpa/following{/other_user}","gists_url":"https://api.github.com/users/alanscarpa/gists{/gist_id}","starred_url":"https://api.github.com/users/alanscarpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanscarpa/subscriptions","organizations_url":"https://api.github.com/users/alanscarpa/orgs","repos_url":"https://api.github.com/users/alanscarpa/repos","events_url":"https://api.github.com/users/alanscarpa/events{/privacy}","received_events_url":"https://api.github.com/users/alanscarpa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanscarpa/thirty-sinch","description":"30 second video chats with friends","fork":false,"url":"https://api.github.com/repos/alanscarpa/thirty-sinch","forks_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/forks","keys_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/teams","hooks_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/hooks","issue_events_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/events{/number}","events_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/events","assignees_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/assignees{/user}","branches_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/branches{/branch}","tags_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/tags","blobs_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/statuses/{sha}","languages_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/languages","stargazers_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/stargazers","contributors_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/contributors","subscribers_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/subscribers","subscription_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/subscription","commits_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/contents/{+path}","compare_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/merges","archive_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/downloads","issues_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues{/number}","pulls_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls{/number}","milestones_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/milestones{/number}","notifications_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/labels{/name}","releases_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/releases{/id}","deployments_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/deployments","created_at":"2017-02-08T23:13:01Z","updated_at":"2018-04-01T22:09:50Z","pushed_at":"2018-04-08T23:25:51Z","git_url":"git://github.com/alanscarpa/thirty-sinch.git","ssh_url":"git@github.com:alanscarpa/thirty-sinch.git","clone_url":"https://github.com/alanscarpa/thirty-sinch.git","svn_url":"https://github.com/alanscarpa/thirty-sinch","homepage":null,"size":14241,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alanscarpa:master","ref":"master","sha":"f8105bf1bc634eb30c9ca3dfab0971287bd7306a","user":{"login":"alanscarpa","id":8715611,"avatar_url":"https://avatars3.githubusercontent.com/u/8715611?v=4","gravatar_id":"","url":"https://api.github.com/users/alanscarpa","html_url":"https://github.com/alanscarpa","followers_url":"https://api.github.com/users/alanscarpa/followers","following_url":"https://api.github.com/users/alanscarpa/following{/other_user}","gists_url":"https://api.github.com/users/alanscarpa/gists{/gist_id}","starred_url":"https://api.github.com/users/alanscarpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanscarpa/subscriptions","organizations_url":"https://api.github.com/users/alanscarpa/orgs","repos_url":"https://api.github.com/users/alanscarpa/repos","events_url":"https://api.github.com/users/alanscarpa/events{/privacy}","received_events_url":"https://api.github.com/users/alanscarpa/received_events","type":"User","site_admin":false},"repo":{"id":81385829,"name":"thirty-sinch","full_name":"alanscarpa/thirty-sinch","owner":{"login":"alanscarpa","id":8715611,"avatar_url":"https://avatars3.githubusercontent.com/u/8715611?v=4","gravatar_id":"","url":"https://api.github.com/users/alanscarpa","html_url":"https://github.com/alanscarpa","followers_url":"https://api.github.com/users/alanscarpa/followers","following_url":"https://api.github.com/users/alanscarpa/following{/other_user}","gists_url":"https://api.github.com/users/alanscarpa/gists{/gist_id}","starred_url":"https://api.github.com/users/alanscarpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanscarpa/subscriptions","organizations_url":"https://api.github.com/users/alanscarpa/orgs","repos_url":"https://api.github.com/users/alanscarpa/repos","events_url":"https://api.github.com/users/alanscarpa/events{/privacy}","received_events_url":"https://api.github.com/users/alanscarpa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanscarpa/thirty-sinch","description":"30 second video chats with friends","fork":false,"url":"https://api.github.com/repos/alanscarpa/thirty-sinch","forks_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/forks","keys_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/teams","hooks_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/hooks","issue_events_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/events{/number}","events_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/events","assignees_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/assignees{/user}","branches_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/branches{/branch}","tags_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/tags","blobs_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/statuses/{sha}","languages_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/languages","stargazers_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/stargazers","contributors_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/contributors","subscribers_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/subscribers","subscription_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/subscription","commits_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/contents/{+path}","compare_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/merges","archive_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/downloads","issues_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues{/number}","pulls_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls{/number}","milestones_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/milestones{/number}","notifications_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/labels{/name}","releases_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/releases{/id}","deployments_url":"https://api.github.com/repos/alanscarpa/thirty-sinch/deployments","created_at":"2017-02-08T23:13:01Z","updated_at":"2018-04-01T22:09:50Z","pushed_at":"2018-04-08T23:25:51Z","git_url":"git://github.com/alanscarpa/thirty-sinch.git","ssh_url":"git@github.com:alanscarpa/thirty-sinch.git","clone_url":"https://github.com/alanscarpa/thirty-sinch.git","svn_url":"https://github.com/alanscarpa/thirty-sinch","homepage":null,"size":14241,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11"},"html":{"href":"https://github.com/alanscarpa/thirty-sinch/pull/11"},"issue":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/11"},"comments":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/alanscarpa/thirty-sinch/statuses/dff2aabf8cb81152473c7cd22ef74298317fa590"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alanscarpa"}}