{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2068","repository_url":"https://api.github.com/repos/Microsoft/vscode-python","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2068/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2068/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2068/events","html_url":"https://github.com/Microsoft/vscode-python/issues/2068","id":336545327,"node_id":"MDU6SXNzdWUzMzY1NDUzMjc=","number":2068,"title":"Don't trigger keyboard shortcuts while searching","user":{"login":"fiendish","id":201996,"node_id":"MDQ6VXNlcjIwMTk5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/201996?v=4","gravatar_id":"","url":"https://api.github.com/users/fiendish","html_url":"https://github.com/fiendish","followers_url":"https://api.github.com/users/fiendish/followers","following_url":"https://api.github.com/users/fiendish/following{/other_user}","gists_url":"https://api.github.com/users/fiendish/gists{/gist_id}","starred_url":"https://api.github.com/users/fiendish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiendish/subscriptions","organizations_url":"https://api.github.com/users/fiendish/orgs","repos_url":"https://api.github.com/users/fiendish/repos","events_url":"https://api.github.com/users/fiendish/events{/privacy}","received_events_url":"https://api.github.com/users/fiendish/received_events","type":"User","site_admin":false},"labels":[{"id":750537413,"node_id":"MDU6TGFiZWw3NTA1Mzc0MTM=","url":"https://api.github.com/repos/Microsoft/vscode-python/labels/feature-code%20navigation","name":"feature-code navigation","color":"006b75","default":false},{"id":717071474,"node_id":"MDU6TGFiZWw3MTcwNzE0NzQ=","url":"https://api.github.com/repos/Microsoft/vscode-python/labels/needs%20PR","name":"needs PR","color":"fbca04","default":false},{"id":716013197,"node_id":"MDU6TGFiZWw3MTYwMTMxOTc=","url":"https://api.github.com/repos/Microsoft/vscode-python/labels/type-bug","name":"type-bug","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":{"login":"d3r3kk","id":11466735,"node_id":"MDQ6VXNlcjExNDY2NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/11466735?v=4","gravatar_id":"","url":"https://api.github.com/users/d3r3kk","html_url":"https://github.com/d3r3kk","followers_url":"https://api.github.com/users/d3r3kk/followers","following_url":"https://api.github.com/users/d3r3kk/following{/other_user}","gists_url":"https://api.github.com/users/d3r3kk/gists{/gist_id}","starred_url":"https://api.github.com/users/d3r3kk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3r3kk/subscriptions","organizations_url":"https://api.github.com/users/d3r3kk/orgs","repos_url":"https://api.github.com/users/d3r3kk/repos","events_url":"https://api.github.com/users/d3r3kk/events{/privacy}","received_events_url":"https://api.github.com/users/d3r3kk/received_events","type":"User","site_admin":false},"assignees":[{"login":"d3r3kk","id":11466735,"node_id":"MDQ6VXNlcjExNDY2NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/11466735?v=4","gravatar_id":"","url":"https://api.github.com/users/d3r3kk","html_url":"https://github.com/d3r3kk","followers_url":"https://api.github.com/users/d3r3kk/followers","following_url":"https://api.github.com/users/d3r3kk/following{/other_user}","gists_url":"https://api.github.com/users/d3r3kk/gists{/gist_id}","starred_url":"https://api.github.com/users/d3r3kk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3r3kk/subscriptions","organizations_url":"https://api.github.com/users/d3r3kk/orgs","repos_url":"https://api.github.com/users/d3r3kk/repos","events_url":"https://api.github.com/users/d3r3kk/events{/privacy}","received_events_url":"https://api.github.com/users/d3r3kk/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode-python/milestones/8","html_url":"https://github.com/Microsoft/vscode-python/milestone/8","labels_url":"https://api.github.com/repos/Microsoft/vscode-python/milestones/8/labels","id":3402950,"node_id":"MDk6TWlsZXN0b25lMzQwMjk1MA==","number":8,"title":"Jul 2018","description":"","creator":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":9,"state":"open","created_at":"2018-06-05T18:36:32Z","updated_at":"2018-06-29T16:46:31Z","due_on":"2018-07-16T07:00:00Z","closed_at":null},"comments":9,"created_at":"2018-06-28T09:34:01Z","updated_at":"2018-07-02T17:31:05Z","closed_at":null,"author_association":"NONE","body":"Issue Type: <b>Bug</b>\r\nThe \"Run Selection/Line in Python Terminal\" keyboard shortcut added by the extension activates (it defaults to Shift+Enter) while searching (shift+enter is the standard for finding the previous match), which is bad.\r\n\r\n1. Open a Python file.\r\n2. Select something in the file.\r\n3. Press Cmd+F or Ctrl+F to start searching.\r\n4. Press Shift+Enter to find the previous match.\r\n5. Watch the Terminal pop up, probably with some garbage NameErrors about whatever you selected not being defined.\r\n\r\nThis is because Shift+Enter is the default keyboard shortcut for \"Run Selection/Line in Python Terminal\", but that shouldn't be firing during a search.\r\n\r\nVS Code version: Code 1.24.1 (24f62626b222e9a8313213fb64b10d741a326288, 2018-06-13T17:41:50.128Z)\r\nOS version: Darwin x64 17.6.0\r\n\r\n<details>\r\n<summary>System Info</summary>\r\n\r\n|Item|Value|\r\n|---|---|\r\n|CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)|\r\n|GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: enabled<br>rasterization: enabled<br>video_decode: enabled<br>video_encode: enabled<br>vpx_decode: enabled<br>webgl: enabled<br>webgl2: enabled|\r\n|Load (avg)|2, 2, 2|\r\n|Memory (System)|16.00GB (2.34GB free)|\r\n|Process Argv|/Applications/Visual Studio Code.app/Contents/MacOS/Electron .|\r\n|Screen Reader|no|\r\n|VM|0%|\r\n\r\n</details><details><summary>Extensions (10)</summary>\r\n\r\nExtension|Author (truncated)|Version\r\n---|---|---\r\nbracket-pair-colorizer|Coe|1.0.58\r\nmarkdown-preview-github-styles|bie|0.1.2\r\nvscode-markdownlint|Dav|0.18.0\r\njupyter|don|1.1.4\r\ngc-excelviewer|Gra|2.1.24\r\nrainbow-csv|mec|0.4.2\r\npython|ms-|2018.6.0\r\nrewrap|stk|1.9.1\r\npython-extended-snippets|tus|0.0.1\r\nmarkdown-all-in-one|yzh|1.5.0\r\n\r\n\r\n</details>\r\n<!-- generated by issue reporter -->\r\n\r\n\r\n\r\nOriginally posted at https://github.com/Microsoft/vscode/issues/53151 and moved here."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-python/issues/comments/401877840","html_url":"https://github.com/Microsoft/vscode-python/issues/2068#issuecomment-401877840","issue_url":"https://api.github.com/repos/Microsoft/vscode-python/issues/2068","id":401877840,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTg3Nzg0MA==","user":{"login":"amoghe","id":1750664,"node_id":"MDQ6VXNlcjE3NTA2NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1750664?v=4","gravatar_id":"","url":"https://api.github.com/users/amoghe","html_url":"https://github.com/amoghe","followers_url":"https://api.github.com/users/amoghe/followers","following_url":"https://api.github.com/users/amoghe/following{/other_user}","gists_url":"https://api.github.com/users/amoghe/gists{/gist_id}","starred_url":"https://api.github.com/users/amoghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amoghe/subscriptions","organizations_url":"https://api.github.com/users/amoghe/orgs","repos_url":"https://api.github.com/users/amoghe/repos","events_url":"https://api.github.com/users/amoghe/events{/privacy}","received_events_url":"https://api.github.com/users/amoghe/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T17:31:05Z","updated_at":"2018-07-02T17:31:05Z","author_association":"NONE","body":"Hmm, so here's something else I ran into:\r\n\r\n- have 2 tabs open (1 python and 1 makefile)\r\n- search backwards forwards in makefile using (`Ctrl+F` and then `Enter` & `Shift+Enter`)\r\n- search backwards forwards in python file using a different set of keys !!!\r\n\r\nDeviating from how the \"rest of the editor works\" results in an inconsistent user experience."}}
{"actor":{"display_login":"amoghe"}}