{"action":"created","issue":{"url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/665","repository_url":"https://api.github.com/repos/bhauman/lein-figwheel","labels_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/665/labels{/name}","comments_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/665/comments","events_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/665/events","html_url":"https://github.com/bhauman/lein-figwheel/issues/665","id":303816846,"number":665,"title":"Client configs with cljs 1.10 break","user":{"login":"yannvanhalewyn","id":11170603,"avatar_url":"https://avatars2.githubusercontent.com/u/11170603?v=4","gravatar_id":"","url":"https://api.github.com/users/yannvanhalewyn","html_url":"https://github.com/yannvanhalewyn","followers_url":"https://api.github.com/users/yannvanhalewyn/followers","following_url":"https://api.github.com/users/yannvanhalewyn/following{/other_user}","gists_url":"https://api.github.com/users/yannvanhalewyn/gists{/gist_id}","starred_url":"https://api.github.com/users/yannvanhalewyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannvanhalewyn/subscriptions","organizations_url":"https://api.github.com/users/yannvanhalewyn/orgs","repos_url":"https://api.github.com/users/yannvanhalewyn/repos","events_url":"https://api.github.com/users/yannvanhalewyn/events{/privacy}","received_events_url":"https://api.github.com/users/yannvanhalewyn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-09T11:52:53Z","updated_at":"2018-03-09T12:01:34Z","closed_at":null,"author_association":"NONE","body":"It looks like cljs 1.10 breaks the ability to have multiple figwheel builds, even across projects. It seems that cljs 1.10 caches compiled dependencies, and after building figwheel the first time the config for that specific build sticks. This read-config macro: https://github.com/bhauman/lein-figwheel/blob/master/support/src/figwheel/connect.cljs#L9 effectively only runs the first time any figwheel resources are compiled.\r\n\r\n## Reproduction:\r\n\r\n- `lein new figwheel my-project`\r\n- `:dependencies [org.clojure/clojurescript \"1.10.145\"]`\r\n- Add a second build, without on-jsload hook for example, for testing purpouses.\r\n\r\nRun both builds, and checkout both `resources/public/js/compiled/{out1|out2}/figwheel/connect.js` and confirm the `var config =` statement is always the same (even when previously built in another project). They now either both have the on-jsload hook, or neither.\r\n\r\n## Consequences\r\n\r\nNo need to elaborate, but issues with js-load hooks not being configured, repl's not connecting because the build id doesn't match, ...\r\n\r\nI'm not entirely sure if I should post this here or at cljs, what do you think @bhauman?"},"comment":{"url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/comments/371794389","html_url":"https://github.com/bhauman/lein-figwheel/issues/665#issuecomment-371794389","issue_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/665","id":371794389,"user":{"login":"yannvanhalewyn","id":11170603,"avatar_url":"https://avatars2.githubusercontent.com/u/11170603?v=4","gravatar_id":"","url":"https://api.github.com/users/yannvanhalewyn","html_url":"https://github.com/yannvanhalewyn","followers_url":"https://api.github.com/users/yannvanhalewyn/followers","following_url":"https://api.github.com/users/yannvanhalewyn/following{/other_user}","gists_url":"https://api.github.com/users/yannvanhalewyn/gists{/gist_id}","starred_url":"https://api.github.com/users/yannvanhalewyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannvanhalewyn/subscriptions","organizations_url":"https://api.github.com/users/yannvanhalewyn/orgs","repos_url":"https://api.github.com/users/yannvanhalewyn/repos","events_url":"https://api.github.com/users/yannvanhalewyn/events{/privacy}","received_events_url":"https://api.github.com/users/yannvanhalewyn/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T12:01:34Z","updated_at":"2018-03-09T12:01:34Z","author_association":"NONE","body":"Not all too familiar with the figwheel codebase or the closure compiler, but a solution might be to pass in the config to `connect.start` in the generated `output.js`:\r\n\r\n``` javascript\r\ndocument.write(\"<script>figwheel.connect.start(config);</script>\");\r\n```\r\n\r\nif that's achievable."}}
{"actor":{"display_login":"yannvanhalewyn"}}