{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20759","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20759/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20759/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20759/events","html_url":"https://github.com/nodejs/node/pull/20759","id":323419843,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MjgzNDk0","number":20759,"title":"src: add addon entry point symbol cache","user":{"login":"gabrielschulhof","id":976081,"node_id":"MDQ6VXNlcjk3NjA4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/976081?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-05-15T23:35:34Z","updated_at":"2018-06-29T16:29:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20759","html_url":"https://github.com/nodejs/node/pull/20759","diff_url":"https://github.com/nodejs/node/pull/20759.diff","patch_url":"https://github.com/nodejs/node/pull/20759.patch"},"body":"Determine whether the dlopen() of a certain addon is the first load of\r\nsaid addon, or if the addon had previously been loaded. This is\r\naccomplished by storing the addon's entry point in a set. If, upon a\r\nsubsequent load, after determining the addon's entry point, it is found\r\nto already be present in the cache, then the handle returned by the\r\nsubsequent dlopen() is closed.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/401406177","html_url":"https://github.com/nodejs/node/pull/20759#issuecomment-401406177","issue_url":"https://api.github.com/repos/nodejs/node/issues/20759","id":401406177,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQwNjE3Nw==","user":{"login":"gabrielschulhof","id":976081,"node_id":"MDQ6VXNlcjk3NjA4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/976081?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T16:29:02Z","updated_at":"2018-06-29T16:29:02Z","author_association":"CONTRIBUTOR","body":"@addaleax @bnoordhuis could you please take another look?"}}
{"actor":{"display_login":"gabrielschulhof"}}