{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2864","repository_url":"https://api.github.com/repos/kubernetes/ingress-nginx","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2864/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2864/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2864/events","html_url":"https://github.com/kubernetes/ingress-nginx/issues/2864","id":345427500,"node_id":"MDU6SXNzdWUzNDU0Mjc1MDA=","number":2864,"title":"Discuss rename of permanent-redirect and temporal-redirect annotation","user":{"login":"Stono","id":1486729,"node_id":"MDQ6VXNlcjE0ODY3Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1486729?v=4","gravatar_id":"","url":"https://api.github.com/users/Stono","html_url":"https://github.com/Stono","followers_url":"https://api.github.com/users/Stono/followers","following_url":"https://api.github.com/users/Stono/following{/other_user}","gists_url":"https://api.github.com/users/Stono/gists{/gist_id}","starred_url":"https://api.github.com/users/Stono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stono/subscriptions","organizations_url":"https://api.github.com/users/Stono/orgs","repos_url":"https://api.github.com/users/Stono/repos","events_url":"https://api.github.com/users/Stono/events{/privacy}","received_events_url":"https://api.github.com/users/Stono/received_events","type":"User","site_admin":false},"labels":[{"id":778120598,"node_id":"MDU6TGFiZWw3NzgxMjA1OTg=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-28T07:35:20Z","updated_at":"2018-12-25T20:33:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hey, \r\nThe work I did in https://github.com/kubernetes/ingress-nginx/pull/2834 allows you to control the status code used for permanent-redirects as there are a couple of valid options (301, 308 etc).\r\n\r\nHowever the annotation we ended up using was called `http-redirect-code` which implies it could also be used to set short term redirects too (eg 302).  \r\n\r\nWhilst digging in that code, I also noticed there is another undocumented annotation `temporal-redirect` which appears to `302`.\r\n\r\nIt's all getting a bit confusing, so I propose simply two annotations: `http-redirect` and `http-redirect-code` and getting rid of `permanent-redirect` and `temporal-redirect` which would then just allow people to use whichever of the 5 valid redirect codes they chose (301, 302, 303, 307, 308). \r\n\r\nNaturally however this would be a breaking change so this issue is to talk about that..."},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments/449872427","html_url":"https://github.com/kubernetes/ingress-nginx/issues/2864#issuecomment-449872427","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2864","id":449872427,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTg3MjQyNw==","user":{"login":"fejta-bot","id":30488982,"node_id":"MDQ6VXNlcjMwNDg4OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/30488982?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta-bot","html_url":"https://github.com/fejta-bot","followers_url":"https://api.github.com/users/fejta-bot/followers","following_url":"https://api.github.com/users/fejta-bot/following{/other_user}","gists_url":"https://api.github.com/users/fejta-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta-bot/subscriptions","organizations_url":"https://api.github.com/users/fejta-bot/orgs","repos_url":"https://api.github.com/users/fejta-bot/repos","events_url":"https://api.github.com/users/fejta-bot/events{/privacy}","received_events_url":"https://api.github.com/users/fejta-bot/received_events","type":"User","site_admin":false},"created_at":"2018-12-25T20:33:19Z","updated_at":"2018-12-25T20:33:19Z","author_association":"NONE","body":"Rotten issues close after 30d of inactivity.\nReopen the issue with `/reopen`.\nMark the issue as fresh with `/remove-lifecycle rotten`.\n\nSend feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta).\n/close"}}
{"actor":{"display_login":"fejta-bot"}}