{"action":"created","comment":{"url":"https://api.github.com/repos/vapor/crypto/pulls/comments/184250554","pull_request_review_id":115407428,"id":184250554,"diff_hunk":"@@ -20,6 +21,10 @@ class BCryptTests: XCTestCase {\n         let res = try BCrypt.verify(\"bar\", created: digest)\n         XCTAssertEqual(res, false)\n     }\n+    \n+    func testHashPassword() throws {\n+        XCTAssertNoThrow(try BCrypt.hash(\"password\", cost: 2))","path":"Tests/CryptoTests/BCryptTests.swift","position":14,"original_position":14,"commit_id":"13740fdbd29ef3a2a971086ff6a9a13326f2c473","original_commit_id":"13740fdbd29ef3a2a971086ff6a9a13326f2c473","user":{"login":"bre7","id":3183848,"avatar_url":"https://avatars3.githubusercontent.com/u/3183848?v=4","gravatar_id":"","url":"https://api.github.com/users/bre7","html_url":"https://github.com/bre7","followers_url":"https://api.github.com/users/bre7/followers","following_url":"https://api.github.com/users/bre7/following{/other_user}","gists_url":"https://api.github.com/users/bre7/gists{/gist_id}","starred_url":"https://api.github.com/users/bre7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bre7/subscriptions","organizations_url":"https://api.github.com/users/bre7/orgs","repos_url":"https://api.github.com/users/bre7/repos","events_url":"https://api.github.com/users/bre7/events{/privacy}","received_events_url":"https://api.github.com/users/bre7/received_events","type":"User","site_admin":false},"body":"Use XCTAssertThrowsError instead ;) Thanks for the catch btw","created_at":"2018-04-26T01:38:46Z","updated_at":"2018-04-26T01:38:46Z","html_url":"https://github.com/vapor/crypto/pull/57#discussion_r184250554","pull_request_url":"https://api.github.com/repos/vapor/crypto/pulls/57","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vapor/crypto/pulls/comments/184250554"},"html":{"href":"https://github.com/vapor/crypto/pull/57#discussion_r184250554"},"pull_request":{"href":"https://api.github.com/repos/vapor/crypto/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/vapor/crypto/pulls/57","id":184199811,"html_url":"https://github.com/vapor/crypto/pull/57","diff_url":"https://github.com/vapor/crypto/pull/57.diff","patch_url":"https://github.com/vapor/crypto/pull/57.patch","issue_url":"https://api.github.com/repos/vapor/crypto/issues/57","number":57,"state":"open","locked":false,"title":"Failing \"password\" test","user":{"login":"mcdappdev","id":11842593,"avatar_url":"https://avatars1.githubusercontent.com/u/11842593?v=4","gravatar_id":"","url":"https://api.github.com/users/mcdappdev","html_url":"https://github.com/mcdappdev","followers_url":"https://api.github.com/users/mcdappdev/followers","following_url":"https://api.github.com/users/mcdappdev/following{/other_user}","gists_url":"https://api.github.com/users/mcdappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/mcdappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcdappdev/subscriptions","organizations_url":"https://api.github.com/users/mcdappdev/orgs","repos_url":"https://api.github.com/users/mcdappdev/repos","events_url":"https://api.github.com/users/mcdappdev/events{/privacy}","received_events_url":"https://api.github.com/users/mcdappdev/received_events","type":"User","site_admin":false},"body":"Add's a failing test case because for some reason hashing \"password\" at a cost of 2 fails","created_at":"2018-04-26T00:53:53Z","updated_at":"2018-04-26T01:38:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bb6ceaf4bd5a4f0afe0bcc517a46379d48d875d","assignee":{"login":"tanner0101","id":1342803,"avatar_url":"https://avatars2.githubusercontent.com/u/1342803?v=4","gravatar_id":"","url":"https://api.github.com/users/tanner0101","html_url":"https://github.com/tanner0101","followers_url":"https://api.github.com/users/tanner0101/followers","following_url":"https://api.github.com/users/tanner0101/following{/other_user}","gists_url":"https://api.github.com/users/tanner0101/gists{/gist_id}","starred_url":"https://api.github.com/users/tanner0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanner0101/subscriptions","organizations_url":"https://api.github.com/users/tanner0101/orgs","repos_url":"https://api.github.com/users/tanner0101/repos","events_url":"https://api.github.com/users/tanner0101/events{/privacy}","received_events_url":"https://api.github.com/users/tanner0101/received_events","type":"User","site_admin":false},"assignees":[{"login":"tanner0101","id":1342803,"avatar_url":"https://avatars2.githubusercontent.com/u/1342803?v=4","gravatar_id":"","url":"https://api.github.com/users/tanner0101","html_url":"https://github.com/tanner0101","followers_url":"https://api.github.com/users/tanner0101/followers","following_url":"https://api.github.com/users/tanner0101/following{/other_user}","gists_url":"https://api.github.com/users/tanner0101/gists{/gist_id}","starred_url":"https://api.github.com/users/tanner0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanner0101/subscriptions","organizations_url":"https://api.github.com/users/tanner0101/orgs","repos_url":"https://api.github.com/users/tanner0101/repos","events_url":"https://api.github.com/users/tanner0101/events{/privacy}","received_events_url":"https://api.github.com/users/tanner0101/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":420261244,"url":"https://api.github.com/repos/vapor/crypto/labels/bug","name":"bug","color":"d93f0b","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/vapor/crypto/pulls/57/commits","review_comments_url":"https://api.github.com/repos/vapor/crypto/pulls/57/comments","review_comment_url":"https://api.github.com/repos/vapor/crypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vapor/crypto/issues/57/comments","statuses_url":"https://api.github.com/repos/vapor/crypto/statuses/13740fdbd29ef3a2a971086ff6a9a13326f2c473","head":{"label":"mcdappdev:master","ref":"master","sha":"13740fdbd29ef3a2a971086ff6a9a13326f2c473","user":{"login":"mcdappdev","id":11842593,"avatar_url":"https://avatars1.githubusercontent.com/u/11842593?v=4","gravatar_id":"","url":"https://api.github.com/users/mcdappdev","html_url":"https://github.com/mcdappdev","followers_url":"https://api.github.com/users/mcdappdev/followers","following_url":"https://api.github.com/users/mcdappdev/following{/other_user}","gists_url":"https://api.github.com/users/mcdappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/mcdappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcdappdev/subscriptions","organizations_url":"https://api.github.com/users/mcdappdev/orgs","repos_url":"https://api.github.com/users/mcdappdev/repos","events_url":"https://api.github.com/users/mcdappdev/events{/privacy}","received_events_url":"https://api.github.com/users/mcdappdev/received_events","type":"User","site_admin":false},"repo":{"id":131079849,"name":"crypto","full_name":"mcdappdev/crypto","owner":{"login":"mcdappdev","id":11842593,"avatar_url":"https://avatars1.githubusercontent.com/u/11842593?v=4","gravatar_id":"","url":"https://api.github.com/users/mcdappdev","html_url":"https://github.com/mcdappdev","followers_url":"https://api.github.com/users/mcdappdev/followers","following_url":"https://api.github.com/users/mcdappdev/following{/other_user}","gists_url":"https://api.github.com/users/mcdappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/mcdappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcdappdev/subscriptions","organizations_url":"https://api.github.com/users/mcdappdev/orgs","repos_url":"https://api.github.com/users/mcdappdev/repos","events_url":"https://api.github.com/users/mcdappdev/events{/privacy}","received_events_url":"https://api.github.com/users/mcdappdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcdappdev/crypto","description":"🔑 Hashing (BCrypt, SHA2, HMAC), encryption (AES), public-key (RSA), and random data generation.","fork":true,"url":"https://api.github.com/repos/mcdappdev/crypto","forks_url":"https://api.github.com/repos/mcdappdev/crypto/forks","keys_url":"https://api.github.com/repos/mcdappdev/crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcdappdev/crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcdappdev/crypto/teams","hooks_url":"https://api.github.com/repos/mcdappdev/crypto/hooks","issue_events_url":"https://api.github.com/repos/mcdappdev/crypto/issues/events{/number}","events_url":"https://api.github.com/repos/mcdappdev/crypto/events","assignees_url":"https://api.github.com/repos/mcdappdev/crypto/assignees{/user}","branches_url":"https://api.github.com/repos/mcdappdev/crypto/branches{/branch}","tags_url":"https://api.github.com/repos/mcdappdev/crypto/tags","blobs_url":"https://api.github.com/repos/mcdappdev/crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcdappdev/crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcdappdev/crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcdappdev/crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcdappdev/crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/mcdappdev/crypto/languages","stargazers_url":"https://api.github.com/repos/mcdappdev/crypto/stargazers","contributors_url":"https://api.github.com/repos/mcdappdev/crypto/contributors","subscribers_url":"https://api.github.com/repos/mcdappdev/crypto/subscribers","subscription_url":"https://api.github.com/repos/mcdappdev/crypto/subscription","commits_url":"https://api.github.com/repos/mcdappdev/crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcdappdev/crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcdappdev/crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcdappdev/crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcdappdev/crypto/contents/{+path}","compare_url":"https://api.github.com/repos/mcdappdev/crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcdappdev/crypto/merges","archive_url":"https://api.github.com/repos/mcdappdev/crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcdappdev/crypto/downloads","issues_url":"https://api.github.com/repos/mcdappdev/crypto/issues{/number}","pulls_url":"https://api.github.com/repos/mcdappdev/crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/mcdappdev/crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/mcdappdev/crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcdappdev/crypto/labels{/name}","releases_url":"https://api.github.com/repos/mcdappdev/crypto/releases{/id}","deployments_url":"https://api.github.com/repos/mcdappdev/crypto/deployments","created_at":"2018-04-26T00:47:22Z","updated_at":"2018-04-26T00:53:17Z","pushed_at":"2018-04-26T00:53:15Z","git_url":"git://github.com/mcdappdev/crypto.git","ssh_url":"git@github.com:mcdappdev/crypto.git","clone_url":"https://github.com/mcdappdev/crypto.git","svn_url":"https://github.com/mcdappdev/crypto","homepage":"","size":359,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vapor:master","ref":"master","sha":"e7b51ee4d46723734891ca904a4ab6b5f9e26959","user":{"login":"vapor","id":17364220,"avatar_url":"https://avatars1.githubusercontent.com/u/17364220?v=4","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"repo":{"id":65051723,"name":"crypto","full_name":"vapor/crypto","owner":{"login":"vapor","id":17364220,"avatar_url":"https://avatars1.githubusercontent.com/u/17364220?v=4","gravatar_id":"","url":"https://api.github.com/users/vapor","html_url":"https://github.com/vapor","followers_url":"https://api.github.com/users/vapor/followers","following_url":"https://api.github.com/users/vapor/following{/other_user}","gists_url":"https://api.github.com/users/vapor/gists{/gist_id}","starred_url":"https://api.github.com/users/vapor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapor/subscriptions","organizations_url":"https://api.github.com/users/vapor/orgs","repos_url":"https://api.github.com/users/vapor/repos","events_url":"https://api.github.com/users/vapor/events{/privacy}","received_events_url":"https://api.github.com/users/vapor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vapor/crypto","description":"🔑 Hashing (BCrypt, SHA2, HMAC), encryption (AES), public-key (RSA), and random data generation.","fork":false,"url":"https://api.github.com/repos/vapor/crypto","forks_url":"https://api.github.com/repos/vapor/crypto/forks","keys_url":"https://api.github.com/repos/vapor/crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vapor/crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vapor/crypto/teams","hooks_url":"https://api.github.com/repos/vapor/crypto/hooks","issue_events_url":"https://api.github.com/repos/vapor/crypto/issues/events{/number}","events_url":"https://api.github.com/repos/vapor/crypto/events","assignees_url":"https://api.github.com/repos/vapor/crypto/assignees{/user}","branches_url":"https://api.github.com/repos/vapor/crypto/branches{/branch}","tags_url":"https://api.github.com/repos/vapor/crypto/tags","blobs_url":"https://api.github.com/repos/vapor/crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vapor/crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vapor/crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/vapor/crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vapor/crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/vapor/crypto/languages","stargazers_url":"https://api.github.com/repos/vapor/crypto/stargazers","contributors_url":"https://api.github.com/repos/vapor/crypto/contributors","subscribers_url":"https://api.github.com/repos/vapor/crypto/subscribers","subscription_url":"https://api.github.com/repos/vapor/crypto/subscription","commits_url":"https://api.github.com/repos/vapor/crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/vapor/crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/vapor/crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/vapor/crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/vapor/crypto/contents/{+path}","compare_url":"https://api.github.com/repos/vapor/crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vapor/crypto/merges","archive_url":"https://api.github.com/repos/vapor/crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vapor/crypto/downloads","issues_url":"https://api.github.com/repos/vapor/crypto/issues{/number}","pulls_url":"https://api.github.com/repos/vapor/crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/vapor/crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/vapor/crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vapor/crypto/labels{/name}","releases_url":"https://api.github.com/repos/vapor/crypto/releases{/id}","deployments_url":"https://api.github.com/repos/vapor/crypto/deployments","created_at":"2016-08-05T22:00:21Z","updated_at":"2018-04-20T22:43:36Z","pushed_at":"2018-04-26T01:36:51Z","git_url":"git://github.com/vapor/crypto.git","ssh_url":"git@github.com:vapor/crypto.git","clone_url":"https://github.com/vapor/crypto.git","svn_url":"https://github.com/vapor/crypto","homepage":"","size":359,"stargazers_count":49,"watchers_count":49,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15,"open_issues":6,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vapor/crypto/pulls/57"},"html":{"href":"https://github.com/vapor/crypto/pull/57"},"issue":{"href":"https://api.github.com/repos/vapor/crypto/issues/57"},"comments":{"href":"https://api.github.com/repos/vapor/crypto/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/vapor/crypto/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/vapor/crypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vapor/crypto/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/vapor/crypto/statuses/13740fdbd29ef3a2a971086ff6a9a13326f2c473"}},"author_association":"NONE"}}
{"actor":{"display_login":"bre7"}}