{"action":"created","comment":{"url":"https://api.github.com/repos/apache/any23/pulls/comments/210858026","pull_request_review_id":147161745,"id":210858026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg1ODAyNg==","diff_hunk":"@@ -35,7 +35,7 @@\n  */\n public abstract class RDFWriterTripleHandler implements FormatWriter, TripleHandler {\n \n-    private final RDFWriter writer;\n+    protected final RDFWriter writer;\n ","path":"core/src/main/java/org/apache/any23/writer/RDFWriterTripleHandler.java","position":6,"original_position":6,"commit_id":"8f08a3e65eda4e3d22182347fde1bab16d125711","original_commit_id":"8f08a3e65eda4e3d22182347fde1bab16d125711","user":{"login":"jgrzebyta","id":6738268,"node_id":"MDQ6VXNlcjY3MzgyNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6738268?v=4","gravatar_id":"","url":"https://api.github.com/users/jgrzebyta","html_url":"https://github.com/jgrzebyta","followers_url":"https://api.github.com/users/jgrzebyta/followers","following_url":"https://api.github.com/users/jgrzebyta/following{/other_user}","gists_url":"https://api.github.com/users/jgrzebyta/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrzebyta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrzebyta/subscriptions","organizations_url":"https://api.github.com/users/jgrzebyta/orgs","repos_url":"https://api.github.com/users/jgrzebyta/repos","events_url":"https://api.github.com/users/jgrzebyta/events{/privacy}","received_events_url":"https://api.github.com/users/jgrzebyta/received_events","type":"User","site_admin":false},"body":"@HansBrende There is no reason. It is only the coding style.\r\n\r\nBut if user will override constructor in her/his custom class will call `super(someWriter)` anyway. In that case constructor is a setter for the writer.","created_at":"2018-08-17T09:44:11Z","updated_at":"2018-08-17T09:44:11Z","html_url":"https://github.com/apache/any23/pull/116#discussion_r210858026","pull_request_url":"https://api.github.com/repos/apache/any23/pulls/116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/any23/pulls/comments/210858026"},"html":{"href":"https://github.com/apache/any23/pull/116#discussion_r210858026"},"pull_request":{"href":"https://api.github.com/repos/apache/any23/pulls/116"}},"in_reply_to_id":210723497},"pull_request":{"url":"https://api.github.com/repos/apache/any23/pulls/116","id":208919406,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTE5NDA2","html_url":"https://github.com/apache/any23/pull/116","diff_url":"https://github.com/apache/any23/pull/116.diff","patch_url":"https://github.com/apache/any23/pull/116.patch","issue_url":"https://api.github.com/repos/apache/any23/issues/116","number":116,"state":"open","locked":false,"title":"Any23 388","user":{"login":"larsgsvensson","id":4930956,"node_id":"MDQ6VXNlcjQ5MzA5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4930956?v=4","gravatar_id":"","url":"https://api.github.com/users/larsgsvensson","html_url":"https://github.com/larsgsvensson","followers_url":"https://api.github.com/users/larsgsvensson/followers","following_url":"https://api.github.com/users/larsgsvensson/following{/other_user}","gists_url":"https://api.github.com/users/larsgsvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgsvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgsvensson/subscriptions","organizations_url":"https://api.github.com/users/larsgsvensson/orgs","repos_url":"https://api.github.com/users/larsgsvensson/repos","events_url":"https://api.github.com/users/larsgsvensson/events{/privacy}","received_events_url":"https://api.github.com/users/larsgsvensson/received_events","type":"User","site_admin":false},"body":"Making the constructor of `RDFWriterTripleHandler` and its `writer` field protected, as [discussed](https://issues.apache.org/jira/browse/ANY23-388?focusedCommentId=16580679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16580679) by me, @lewismc and @HansBrende ","created_at":"2018-08-16T16:43:13Z","updated_at":"2018-08-17T09:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5701f3201303e9805c2d5672ae40b3281acd996","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/any23/pulls/116/commits","review_comments_url":"https://api.github.com/repos/apache/any23/pulls/116/comments","review_comment_url":"https://api.github.com/repos/apache/any23/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/any23/issues/116/comments","statuses_url":"https://api.github.com/repos/apache/any23/statuses/8f08a3e65eda4e3d22182347fde1bab16d125711","head":{"label":"larsgsvensson:ANY23-388","ref":"ANY23-388","sha":"8f08a3e65eda4e3d22182347fde1bab16d125711","user":{"login":"larsgsvensson","id":4930956,"node_id":"MDQ6VXNlcjQ5MzA5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4930956?v=4","gravatar_id":"","url":"https://api.github.com/users/larsgsvensson","html_url":"https://github.com/larsgsvensson","followers_url":"https://api.github.com/users/larsgsvensson/followers","following_url":"https://api.github.com/users/larsgsvensson/following{/other_user}","gists_url":"https://api.github.com/users/larsgsvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgsvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgsvensson/subscriptions","organizations_url":"https://api.github.com/users/larsgsvensson/orgs","repos_url":"https://api.github.com/users/larsgsvensson/repos","events_url":"https://api.github.com/users/larsgsvensson/events{/privacy}","received_events_url":"https://api.github.com/users/larsgsvensson/received_events","type":"User","site_admin":false},"repo":{"id":73817334,"node_id":"MDEwOlJlcG9zaXRvcnk3MzgxNzMzNA==","name":"any23","full_name":"larsgsvensson/any23","owner":{"login":"larsgsvensson","id":4930956,"node_id":"MDQ6VXNlcjQ5MzA5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4930956?v=4","gravatar_id":"","url":"https://api.github.com/users/larsgsvensson","html_url":"https://github.com/larsgsvensson","followers_url":"https://api.github.com/users/larsgsvensson/followers","following_url":"https://api.github.com/users/larsgsvensson/following{/other_user}","gists_url":"https://api.github.com/users/larsgsvensson/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgsvensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgsvensson/subscriptions","organizations_url":"https://api.github.com/users/larsgsvensson/orgs","repos_url":"https://api.github.com/users/larsgsvensson/repos","events_url":"https://api.github.com/users/larsgsvensson/events{/privacy}","received_events_url":"https://api.github.com/users/larsgsvensson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larsgsvensson/any23","description":"Mirror of Apache Any23","fork":true,"url":"https://api.github.com/repos/larsgsvensson/any23","forks_url":"https://api.github.com/repos/larsgsvensson/any23/forks","keys_url":"https://api.github.com/repos/larsgsvensson/any23/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsgsvensson/any23/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsgsvensson/any23/teams","hooks_url":"https://api.github.com/repos/larsgsvensson/any23/hooks","issue_events_url":"https://api.github.com/repos/larsgsvensson/any23/issues/events{/number}","events_url":"https://api.github.com/repos/larsgsvensson/any23/events","assignees_url":"https://api.github.com/repos/larsgsvensson/any23/assignees{/user}","branches_url":"https://api.github.com/repos/larsgsvensson/any23/branches{/branch}","tags_url":"https://api.github.com/repos/larsgsvensson/any23/tags","blobs_url":"https://api.github.com/repos/larsgsvensson/any23/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsgsvensson/any23/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsgsvensson/any23/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsgsvensson/any23/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsgsvensson/any23/statuses/{sha}","languages_url":"https://api.github.com/repos/larsgsvensson/any23/languages","stargazers_url":"https://api.github.com/repos/larsgsvensson/any23/stargazers","contributors_url":"https://api.github.com/repos/larsgsvensson/any23/contributors","subscribers_url":"https://api.github.com/repos/larsgsvensson/any23/subscribers","subscription_url":"https://api.github.com/repos/larsgsvensson/any23/subscription","commits_url":"https://api.github.com/repos/larsgsvensson/any23/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsgsvensson/any23/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsgsvensson/any23/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsgsvensson/any23/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsgsvensson/any23/contents/{+path}","compare_url":"https://api.github.com/repos/larsgsvensson/any23/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsgsvensson/any23/merges","archive_url":"https://api.github.com/repos/larsgsvensson/any23/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsgsvensson/any23/downloads","issues_url":"https://api.github.com/repos/larsgsvensson/any23/issues{/number}","pulls_url":"https://api.github.com/repos/larsgsvensson/any23/pulls{/number}","milestones_url":"https://api.github.com/repos/larsgsvensson/any23/milestones{/number}","notifications_url":"https://api.github.com/repos/larsgsvensson/any23/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsgsvensson/any23/labels{/name}","releases_url":"https://api.github.com/repos/larsgsvensson/any23/releases{/id}","deployments_url":"https://api.github.com/repos/larsgsvensson/any23/deployments","created_at":"2016-11-15T13:42:33Z","updated_at":"2018-08-09T15:01:37Z","pushed_at":"2018-08-16T16:38:34Z","git_url":"git://github.com/larsgsvensson/any23.git","ssh_url":"git@github.com:larsgsvensson/any23.git","clone_url":"https://github.com/larsgsvensson/any23.git","svn_url":"https://github.com/larsgsvensson/any23","homepage":null,"size":38721,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9f7ba688d30adb5648b4295c755aefa1ff20cf4c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":4544260,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQ0MjYw","name":"any23","full_name":"apache/any23","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/any23","description":"Mirror of Apache Any23","fork":false,"url":"https://api.github.com/repos/apache/any23","forks_url":"https://api.github.com/repos/apache/any23/forks","keys_url":"https://api.github.com/repos/apache/any23/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/any23/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/any23/teams","hooks_url":"https://api.github.com/repos/apache/any23/hooks","issue_events_url":"https://api.github.com/repos/apache/any23/issues/events{/number}","events_url":"https://api.github.com/repos/apache/any23/events","assignees_url":"https://api.github.com/repos/apache/any23/assignees{/user}","branches_url":"https://api.github.com/repos/apache/any23/branches{/branch}","tags_url":"https://api.github.com/repos/apache/any23/tags","blobs_url":"https://api.github.com/repos/apache/any23/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/any23/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/any23/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/any23/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/any23/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/any23/languages","stargazers_url":"https://api.github.com/repos/apache/any23/stargazers","contributors_url":"https://api.github.com/repos/apache/any23/contributors","subscribers_url":"https://api.github.com/repos/apache/any23/subscribers","subscription_url":"https://api.github.com/repos/apache/any23/subscription","commits_url":"https://api.github.com/repos/apache/any23/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/any23/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/any23/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/any23/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/any23/contents/{+path}","compare_url":"https://api.github.com/repos/apache/any23/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/any23/merges","archive_url":"https://api.github.com/repos/apache/any23/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/any23/downloads","issues_url":"https://api.github.com/repos/apache/any23/issues{/number}","pulls_url":"https://api.github.com/repos/apache/any23/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/any23/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/any23/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/any23/labels{/name}","releases_url":"https://api.github.com/repos/apache/any23/releases{/id}","deployments_url":"https://api.github.com/repos/apache/any23/deployments","created_at":"2012-06-04T07:00:25Z","updated_at":"2018-08-08T23:48:03Z","pushed_at":"2018-08-16T16:43:13Z","git_url":"git://github.com/apache/any23.git","ssh_url":"git@github.com:apache/any23.git","clone_url":"https://github.com/apache/any23.git","svn_url":"https://github.com/apache/any23","homepage":null,"size":38711,"stargazers_count":59,"watchers_count":59,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":2,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/any23/pulls/116"},"html":{"href":"https://github.com/apache/any23/pull/116"},"issue":{"href":"https://api.github.com/repos/apache/any23/issues/116"},"comments":{"href":"https://api.github.com/repos/apache/any23/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/any23/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/any23/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/any23/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/apache/any23/statuses/8f08a3e65eda4e3d22182347fde1bab16d125711"}},"author_association":"NONE"}}
{"actor":{"display_login":"jgrzebyta"}}