{"action":"created","comment":{"url":"https://api.github.com/repos/juju/charm/pulls/comments/198463039","pull_request_review_id":132396059,"id":198463039,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ2MzAzOQ==","diff_hunk":"@@ -172,10 +174,15 @@ func resolveSymlinkedRoot(rootPath string) (string, error) {\n // ArchiveTo creates a charm file from the charm expanded in dir.\n // By convention a charm archive should have a \".charm\" suffix.\n func (dir *CharmDir) ArchiveTo(w io.Writer) error {\n-\treturn writeArchive(w, dir.Path, dir.revision, dir.Meta().Hooks())\n+\tversionString, err := MaybeGenerateVersionString(dir.Path)\n+\tif err != nil {\n+\t\tlogger.Debugf(\"version file creation/overwrite failed : %v\", err)\n+\t\tversionString = \"\"","path":"charmdir.go","position":17,"original_position":17,"commit_id":"11b2a06260b871ca80f47e85732355acddff3ac1","original_commit_id":"11b2a06260b871ca80f47e85732355acddff3ac1","user":{"login":"wallyworld","id":5808968,"node_id":"MDQ6VXNlcjU4MDg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"no need to set to \"\" here as it will be returned as \"\" if error","created_at":"2018-06-27T11:45:56Z","updated_at":"2018-06-27T11:45:56Z","html_url":"https://github.com/juju/charm/pull/248#discussion_r198463039","pull_request_url":"https://api.github.com/repos/juju/charm/pulls/248","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/charm/pulls/comments/198463039"},"html":{"href":"https://github.com/juju/charm/pull/248#discussion_r198463039"},"pull_request":{"href":"https://api.github.com/repos/juju/charm/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/juju/charm/pulls/248","id":197702350,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzAyMzUw","html_url":"https://github.com/juju/charm/pull/248","diff_url":"https://github.com/juju/charm/pull/248.diff","patch_url":"https://github.com/juju/charm/pull/248.patch","issue_url":"https://api.github.com/repos/juju/charm/issues/248","number":248,"state":"open","locked":false,"title":"Charmversion feature refactor","user":{"login":"vinu2003","id":31263558,"node_id":"MDQ6VXNlcjMxMjYzNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/31263558?v=4","gravatar_id":"","url":"https://api.github.com/users/vinu2003","html_url":"https://github.com/vinu2003","followers_url":"https://api.github.com/users/vinu2003/followers","following_url":"https://api.github.com/users/vinu2003/following{/other_user}","gists_url":"https://api.github.com/users/vinu2003/gists{/gist_id}","starred_url":"https://api.github.com/users/vinu2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinu2003/subscriptions","organizations_url":"https://api.github.com/users/vinu2003/orgs","repos_url":"https://api.github.com/users/vinu2003/repos","events_url":"https://api.github.com/users/vinu2003/events{/privacy}","received_events_url":"https://api.github.com/users/vinu2003/received_events","type":"User","site_admin":false},"body":"This PR is refactoring the changes related to charm feature that eliminates the redundant\r\ncode for charm push and also it generates charm version and writes in to the zip.","created_at":"2018-06-27T11:34:19Z","updated_at":"2018-06-27T11:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9893b310778a855f85f262e6e89e0b6de7e7313a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/charm/pulls/248/commits","review_comments_url":"https://api.github.com/repos/juju/charm/pulls/248/comments","review_comment_url":"https://api.github.com/repos/juju/charm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/charm/issues/248/comments","statuses_url":"https://api.github.com/repos/juju/charm/statuses/11b2a06260b871ca80f47e85732355acddff3ac1","head":{"label":"vinu2003:juju_refactor_charmversion","ref":"juju_refactor_charmversion","sha":"11b2a06260b871ca80f47e85732355acddff3ac1","user":{"login":"vinu2003","id":31263558,"node_id":"MDQ6VXNlcjMxMjYzNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/31263558?v=4","gravatar_id":"","url":"https://api.github.com/users/vinu2003","html_url":"https://github.com/vinu2003","followers_url":"https://api.github.com/users/vinu2003/followers","following_url":"https://api.github.com/users/vinu2003/following{/other_user}","gists_url":"https://api.github.com/users/vinu2003/gists{/gist_id}","starred_url":"https://api.github.com/users/vinu2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinu2003/subscriptions","organizations_url":"https://api.github.com/users/vinu2003/orgs","repos_url":"https://api.github.com/users/vinu2003/repos","events_url":"https://api.github.com/users/vinu2003/events{/privacy}","received_events_url":"https://api.github.com/users/vinu2003/received_events","type":"User","site_admin":false},"repo":{"id":138130177,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMzAxNzc=","name":"charm","full_name":"vinu2003/charm","owner":{"login":"vinu2003","id":31263558,"node_id":"MDQ6VXNlcjMxMjYzNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/31263558?v=4","gravatar_id":"","url":"https://api.github.com/users/vinu2003","html_url":"https://github.com/vinu2003","followers_url":"https://api.github.com/users/vinu2003/followers","following_url":"https://api.github.com/users/vinu2003/following{/other_user}","gists_url":"https://api.github.com/users/vinu2003/gists{/gist_id}","starred_url":"https://api.github.com/users/vinu2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinu2003/subscriptions","organizations_url":"https://api.github.com/users/vinu2003/orgs","repos_url":"https://api.github.com/users/vinu2003/repos","events_url":"https://api.github.com/users/vinu2003/events{/privacy}","received_events_url":"https://api.github.com/users/vinu2003/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinu2003/charm","description":"Parsing and testing Juju charms","fork":true,"url":"https://api.github.com/repos/vinu2003/charm","forks_url":"https://api.github.com/repos/vinu2003/charm/forks","keys_url":"https://api.github.com/repos/vinu2003/charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinu2003/charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinu2003/charm/teams","hooks_url":"https://api.github.com/repos/vinu2003/charm/hooks","issue_events_url":"https://api.github.com/repos/vinu2003/charm/issues/events{/number}","events_url":"https://api.github.com/repos/vinu2003/charm/events","assignees_url":"https://api.github.com/repos/vinu2003/charm/assignees{/user}","branches_url":"https://api.github.com/repos/vinu2003/charm/branches{/branch}","tags_url":"https://api.github.com/repos/vinu2003/charm/tags","blobs_url":"https://api.github.com/repos/vinu2003/charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinu2003/charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinu2003/charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinu2003/charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinu2003/charm/statuses/{sha}","languages_url":"https://api.github.com/repos/vinu2003/charm/languages","stargazers_url":"https://api.github.com/repos/vinu2003/charm/stargazers","contributors_url":"https://api.github.com/repos/vinu2003/charm/contributors","subscribers_url":"https://api.github.com/repos/vinu2003/charm/subscribers","subscription_url":"https://api.github.com/repos/vinu2003/charm/subscription","commits_url":"https://api.github.com/repos/vinu2003/charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinu2003/charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinu2003/charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinu2003/charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinu2003/charm/contents/{+path}","compare_url":"https://api.github.com/repos/vinu2003/charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinu2003/charm/merges","archive_url":"https://api.github.com/repos/vinu2003/charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinu2003/charm/downloads","issues_url":"https://api.github.com/repos/vinu2003/charm/issues{/number}","pulls_url":"https://api.github.com/repos/vinu2003/charm/pulls{/number}","milestones_url":"https://api.github.com/repos/vinu2003/charm/milestones{/number}","notifications_url":"https://api.github.com/repos/vinu2003/charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinu2003/charm/labels{/name}","releases_url":"https://api.github.com/repos/vinu2003/charm/releases{/id}","deployments_url":"https://api.github.com/repos/vinu2003/charm/deployments","created_at":"2018-06-21T06:43:12Z","updated_at":"2018-06-21T06:43:14Z","pushed_at":"2018-06-27T11:35:45Z","git_url":"git://github.com/vinu2003/charm.git","ssh_url":"git@github.com:vinu2003/charm.git","clone_url":"https://github.com/vinu2003/charm.git","svn_url":"https://github.com/vinu2003/charm","homepage":null,"size":1435,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v6"}},"base":{"label":"juju:v6","ref":"v6","sha":"b38325e23176f6d201c7ad6970f99ddbe2645f97","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20692246,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY5MjI0Ng==","name":"charm","full_name":"juju/charm","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/charm","description":"Parsing and testing Juju charms","fork":false,"url":"https://api.github.com/repos/juju/charm","forks_url":"https://api.github.com/repos/juju/charm/forks","keys_url":"https://api.github.com/repos/juju/charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/charm/teams","hooks_url":"https://api.github.com/repos/juju/charm/hooks","issue_events_url":"https://api.github.com/repos/juju/charm/issues/events{/number}","events_url":"https://api.github.com/repos/juju/charm/events","assignees_url":"https://api.github.com/repos/juju/charm/assignees{/user}","branches_url":"https://api.github.com/repos/juju/charm/branches{/branch}","tags_url":"https://api.github.com/repos/juju/charm/tags","blobs_url":"https://api.github.com/repos/juju/charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/charm/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/charm/languages","stargazers_url":"https://api.github.com/repos/juju/charm/stargazers","contributors_url":"https://api.github.com/repos/juju/charm/contributors","subscribers_url":"https://api.github.com/repos/juju/charm/subscribers","subscription_url":"https://api.github.com/repos/juju/charm/subscription","commits_url":"https://api.github.com/repos/juju/charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/charm/contents/{+path}","compare_url":"https://api.github.com/repos/juju/charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/charm/merges","archive_url":"https://api.github.com/repos/juju/charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/charm/downloads","issues_url":"https://api.github.com/repos/juju/charm/issues{/number}","pulls_url":"https://api.github.com/repos/juju/charm/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/charm/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/charm/labels{/name}","releases_url":"https://api.github.com/repos/juju/charm/releases{/id}","deployments_url":"https://api.github.com/repos/juju/charm/deployments","created_at":"2014-06-10T16:11:32Z","updated_at":"2018-06-25T06:14:08Z","pushed_at":"2018-06-27T11:35:46Z","git_url":"git://github.com/juju/charm.git","ssh_url":"git@github.com:juju/charm.git","clone_url":"https://github.com/juju/charm.git","svn_url":"https://github.com/juju/charm","homepage":null,"size":1433,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":39,"open_issues":10,"watchers":3,"default_branch":"v6"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/charm/pulls/248"},"html":{"href":"https://github.com/juju/charm/pull/248"},"issue":{"href":"https://api.github.com/repos/juju/charm/issues/248"},"comments":{"href":"https://api.github.com/repos/juju/charm/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/charm/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/charm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/charm/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/juju/charm/statuses/11b2a06260b871ca80f47e85732355acddff3ac1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wallyworld"}}