{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/comments/188927904","pull_request_review_id":121002901,"id":188927904,"diff_hunk":"@@ -0,0 +1,65 @@\n+describe('Header', function() {\n+  'use strict';\n+\n+  beforeEach(function(done) {\n+    var self = this;\n+\n+    fixture.setBase('spec/javascripts/fixtures');\n+\n+    requirejs(\n+      ['jquery', 'Header'],\n+      function($, Header) {\n+        fixture.load('Header.html');\n+\n+        self.$header = $(fixture.el).find('[data-dough-component=\"Header\"]');\n+        self.obj = new Header(self.$header);\n+\n+\n+        self.activeClass = 'mobile-header__search-active';\n+        self.$header = $(document).find('[data-site-header]');\n+        self.$mobileSearchButton = self.$header.find('[data-mobile-search-button]');\n+\n+        var $openText = $(fixture.el).find('[data-mobile-search-text]');\n+        self.expected = {\n+          openText: \"Open Search\",\n+          closeText: \"Close Search\",\n+          openTextFromDiv: $openText.html(),\n+          closeTextFromDiv: $openText.attr(\"data-mobile-search-text-close\")\n+        }\n+\n+        done();\n+      }, done);\n+  });\n+\n+  afterEach(function() {\n+    fixture.cleanup();\n+  });\n+\n+  describe('Search Bar Initialise', function() {\n+    it('Checks the open search text is correct', function() {\n+      this.obj.init();\n+      expect(this.obj.openText).to.be.equal(this.expected.openText);\n+      expect(this.obj.openText).to.be.equal(this.expected.openTextFromDiv);\n+    });\n+    it('Checks the close search text is correct', function() {\n+      this.obj.init();\n+      expect(this.obj.closeText).to.be.equal(this.expected.closeText);\n+      expect(this.obj.closeText).to.be.equal(this.expected.closeTextFromDiv);\n+    });\n+  });\n+\n+  describe('Search Bar Toggle', function() {\n+    it('Checks the header gets its class set on click', function() {\n+      this.obj.init();    \n+      this.$mobileSearchButton.trigger('click');\n+      expect(this.$header.hasClass(this.activeClass)).to.be.true;\n+    });\n+    it('Checks the header gets its class removed on second click', function() {\n+      this.obj.init();    \n+      this.$mobileSearchButton.trigger('click');\n+      this.$mobileSearchButton.trigger('click');\n+      expect(this.$header.hasClass(this.activeClass)).to.be.false;\n+    });\n+  });\n+","path":"spec/javascripts/tests/Header_spec.js","position":64,"original_position":64,"commit_id":"869c3c01ccf13672ab45c56b39afbda580bbfb61","original_commit_id":"869c3c01ccf13672ab45c56b39afbda580bbfb61","user":{"login":"rhianwatkins1","id":3898629,"avatar_url":"https://avatars0.githubusercontent.com/u/3898629?v=4","gravatar_id":"","url":"https://api.github.com/users/rhianwatkins1","html_url":"https://github.com/rhianwatkins1","followers_url":"https://api.github.com/users/rhianwatkins1/followers","following_url":"https://api.github.com/users/rhianwatkins1/following{/other_user}","gists_url":"https://api.github.com/users/rhianwatkins1/gists{/gist_id}","starred_url":"https://api.github.com/users/rhianwatkins1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhianwatkins1/subscriptions","organizations_url":"https://api.github.com/users/rhianwatkins1/orgs","repos_url":"https://api.github.com/users/rhianwatkins1/repos","events_url":"https://api.github.com/users/rhianwatkins1/events{/privacy}","received_events_url":"https://api.github.com/users/rhianwatkins1/received_events","type":"User","site_admin":false},"body":"config change b87229d breaks tests, removed all tests 60ba64d","created_at":"2018-05-17T11:40:58Z","updated_at":"2018-05-17T11:40:58Z","html_url":"https://github.com/moneyadviceservice/fin_cap/pull/115#discussion_r188927904","pull_request_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/comments/188927904"},"html":{"href":"https://github.com/moneyadviceservice/fin_cap/pull/115#discussion_r188927904"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115"}},"in_reply_to_id":187906436},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115","id":187483095,"html_url":"https://github.com/moneyadviceservice/fin_cap/pull/115","diff_url":"https://github.com/moneyadviceservice/fin_cap/pull/115.diff","patch_url":"https://github.com/moneyadviceservice/fin_cap/pull/115.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/115","number":115,"state":"open","locked":false,"title":"[WIP] 9182 header","user":{"login":"rhianwatkins1","id":3898629,"avatar_url":"https://avatars0.githubusercontent.com/u/3898629?v=4","gravatar_id":"","url":"https://api.github.com/users/rhianwatkins1","html_url":"https://github.com/rhianwatkins1","followers_url":"https://api.github.com/users/rhianwatkins1/followers","following_url":"https://api.github.com/users/rhianwatkins1/following{/other_user}","gists_url":"https://api.github.com/users/rhianwatkins1/gists{/gist_id}","starred_url":"https://api.github.com/users/rhianwatkins1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhianwatkins1/subscriptions","organizations_url":"https://api.github.com/users/rhianwatkins1/orgs","repos_url":"https://api.github.com/users/rhianwatkins1/repos","events_url":"https://api.github.com/users/rhianwatkins1/events{/privacy}","received_events_url":"https://api.github.com/users/rhianwatkins1/received_events","type":"User","site_admin":false},"body":"# 9182 Header\r\n[TP9182](https://moneyadviceservice.tpondemand.com/entity/9182-fincap-header)\r\n\r\nThis PR adds the styling for the header:\r\n- Logo: added & styled\r\n- Desktop\r\n  - Contact link: added & styled\r\n  - Get involved link: added & styled\r\n- Mobile\r\n  - Menu button: styled\r\n  - Search button: added & styled & js to open/close search bar\r\n  - Search bar: added & styled\r\n\r\nJS Tests were also added for the new header JS\r\n\r\nA few other changes were made elsewhere:\r\n- Nav: styling updated due to above changes \r\n- Search bar: markup & styling updated due to new changes (svg icons), and to fix a little bug with the padding right on the search inputs\r\n- Visually Hidden: styling updated as it caused a bug on firefox, now consistent with MAS site\r\n\r\n---\r\n**Before - Desktop**\r\n<img width=\"973\" alt=\"screen shot 2018-05-11 at 15 31 08\" src=\"https://user-images.githubusercontent.com/3898629/39929713-af9ab310-5530-11e8-9710-ac05addb69d9.png\">\r\n**After - Desktop**\r\n<img width=\"974\" alt=\"screen shot 2018-05-11 at 15 31 29\" src=\"https://user-images.githubusercontent.com/3898629/39929714-afb0f878-5530-11e8-8cc7-878d7aa0dd8b.png\">\r\n\r\n\r\n**Before - Mobile**\r\n<img width=\"367\" alt=\"screen shot 2018-05-11 at 15 30 46\" src=\"https://user-images.githubusercontent.com/3898629/39929711-af68e8a8-5530-11e8-95fc-8f078a178f75.png\">\r\n**After - Mobile**\r\n<img width=\"366\" alt=\"screen shot 2018-05-11 at 15 30 31\" src=\"https://user-images.githubusercontent.com/3898629/39929710-af5314ec-5530-11e8-9495-034f537f1641.png\">\r\n**After - Mobile, Search Open**\r\n<img width=\"367\" alt=\"screen shot 2018-05-11 at 15 30 10\" src=\"https://user-images.githubusercontent.com/3898629/39929709-af32c2e6-5530-11e8-9f21-2565fc604773.png\">\r\n\r\n\r\n","created_at":"2018-05-11T14:39:47Z","updated_at":"2018-05-17T11:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60616b6a082b6524a38bfc756e91e958dee694dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/115/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/statuses/869c3c01ccf13672ab45c56b39afbda580bbfb61","head":{"label":"moneyadviceservice:9182_header","ref":"9182_header","sha":"869c3c01ccf13672ab45c56b39afbda580bbfb61","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":120340294,"name":"fin_cap","full_name":"moneyadviceservice/fin_cap","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/fin_cap","description":"All the things for the Financial Capability site","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/fin_cap","forks_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/deployments","created_at":"2018-02-05T17:51:00Z","updated_at":"2018-05-17T10:18:00Z","pushed_at":"2018-05-17T11:03:24Z","git_url":"git://github.com/moneyadviceservice/fin_cap.git","ssh_url":"git@github.com:moneyadviceservice/fin_cap.git","clone_url":"https://github.com/moneyadviceservice/fin_cap.git","svn_url":"https://github.com/moneyadviceservice/fin_cap","homepage":null,"size":1207,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"79f95919593d8732661323f6280f83248455013a","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":120340294,"name":"fin_cap","full_name":"moneyadviceservice/fin_cap","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/fin_cap","description":"All the things for the Financial Capability site","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/fin_cap","forks_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/fin_cap/deployments","created_at":"2018-02-05T17:51:00Z","updated_at":"2018-05-17T10:18:00Z","pushed_at":"2018-05-17T11:03:24Z","git_url":"git://github.com/moneyadviceservice/fin_cap.git","ssh_url":"git@github.com:moneyadviceservice/fin_cap.git","clone_url":"https://github.com/moneyadviceservice/fin_cap.git","svn_url":"https://github.com/moneyadviceservice/fin_cap","homepage":null,"size":1207,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115"},"html":{"href":"https://github.com/moneyadviceservice/fin_cap/pull/115"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/115"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/fin_cap/statuses/869c3c01ccf13672ab45c56b39afbda580bbfb61"}},"author_association":"NONE"}}
{"actor":{"display_login":"rhianwatkins1"}}