{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack/pulls/comments/198086388","pull_request_review_id":131949536,"id":198086388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA4NjM4OA==","diff_hunk":"@@ -105,8 +105,8 @@ module.exports = class SplitChunksPlugin {\n \t\t\t),\n \t\t\tminSize: options.minSize || 0,\n \t\t\tminChunks: options.minChunks || 1,\n-\t\t\tmaxAsyncRequests: options.maxAsyncRequests || 1,\n-\t\t\tmaxInitialRequests: options.maxInitialRequests || 1,\n+\t\t\tmaxAsyncRequests: options.maxAsyncRequests || 6,\n+\t\t\tmaxInitialRequests: options.maxInitialRequests || 4,","path":"lib/optimize/SplitChunksPlugin.js","position":7,"original_position":7,"commit_id":"1fd67d6ddcb539628ca9c962d77e694812a9b552","original_commit_id":"1fd67d6ddcb539628ca9c962d77e694812a9b552","user":{"login":"byzyk","id":1867692,"node_id":"MDQ6VXNlcjE4Njc2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1867692?v=4","gravatar_id":"","url":"https://api.github.com/users/byzyk","html_url":"https://github.com/byzyk","followers_url":"https://api.github.com/users/byzyk/followers","following_url":"https://api.github.com/users/byzyk/following{/other_user}","gists_url":"https://api.github.com/users/byzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/byzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byzyk/subscriptions","organizations_url":"https://api.github.com/users/byzyk/orgs","repos_url":"https://api.github.com/users/byzyk/repos","events_url":"https://api.github.com/users/byzyk/events{/privacy}","received_events_url":"https://api.github.com/users/byzyk/received_events","type":"User","site_admin":false},"body":"Not sure if the above changes are needed since we already do that in `WebpackOptionsDefaulter`.\r\n\r\n/cc @ooflorent ","created_at":"2018-06-26T10:03:42Z","updated_at":"2018-06-26T10:03:43Z","html_url":"https://github.com/webpack/webpack/pull/7599#discussion_r198086388","pull_request_url":"https://api.github.com/repos/webpack/webpack/pulls/7599","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/198086388"},"html":{"href":"https://github.com/webpack/webpack/pull/7599#discussion_r198086388"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7599"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/7599","id":197367701,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzY3NzAx","html_url":"https://github.com/webpack/webpack/pull/7599","diff_url":"https://github.com/webpack/webpack/pull/7599.diff","patch_url":"https://github.com/webpack/webpack/pull/7599.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/7599","number":7599,"state":"open","locked":false,"title":"chore(SplitChunksPlugin): update defaults","user":{"login":"byzyk","id":1867692,"node_id":"MDQ6VXNlcjE4Njc2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1867692?v=4","gravatar_id":"","url":"https://api.github.com/users/byzyk","html_url":"https://github.com/byzyk","followers_url":"https://api.github.com/users/byzyk/followers","following_url":"https://api.github.com/users/byzyk/following{/other_user}","gists_url":"https://api.github.com/users/byzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/byzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byzyk/subscriptions","organizations_url":"https://api.github.com/users/byzyk/orgs","repos_url":"https://api.github.com/users/byzyk/repos","events_url":"https://api.github.com/users/byzyk/events{/privacy}","received_events_url":"https://api.github.com/users/byzyk/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\nAs per [card](https://github.com/webpack/webpack/projects/5#card-10750335), bumping defaults for `SplitChunksPlugin`\r\n\r\n<!-- In addition to that please answer these questions: -->\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\n\r\nfeature\r\n\r\n**Did you add tests for your changes?**\r\n\r\nN/A\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nYes\r\n\r\n**What needs to be documented once your changes are merged?**\r\n\r\nDefault values are not mentioned in docs.\r\n","created_at":"2018-06-26T10:02:49Z","updated_at":"2018-06-26T10:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c65d2a2211c277911f1e4f093e6d09371aa94eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":689140390,"node_id":"MDU6TGFiZWw2ODkxNDAzOTA=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20next","name":"PR: next","color":"fbca04","default":false},{"id":572817354,"node_id":"MDU6TGFiZWw1NzI4MTczNTQ=","url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/7599/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/7599/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/7599/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/1fd67d6ddcb539628ca9c962d77e694812a9b552","head":{"label":"byzyk:split-chunks/defaults","ref":"split-chunks/defaults","sha":"1fd67d6ddcb539628ca9c962d77e694812a9b552","user":{"login":"byzyk","id":1867692,"node_id":"MDQ6VXNlcjE4Njc2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1867692?v=4","gravatar_id":"","url":"https://api.github.com/users/byzyk","html_url":"https://github.com/byzyk","followers_url":"https://api.github.com/users/byzyk/followers","following_url":"https://api.github.com/users/byzyk/following{/other_user}","gists_url":"https://api.github.com/users/byzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/byzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byzyk/subscriptions","organizations_url":"https://api.github.com/users/byzyk/orgs","repos_url":"https://api.github.com/users/byzyk/repos","events_url":"https://api.github.com/users/byzyk/events{/privacy}","received_events_url":"https://api.github.com/users/byzyk/received_events","type":"User","site_admin":false},"repo":{"id":125025828,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwMjU4Mjg=","name":"webpack","full_name":"byzyk/webpack","owner":{"login":"byzyk","id":1867692,"node_id":"MDQ6VXNlcjE4Njc2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1867692?v=4","gravatar_id":"","url":"https://api.github.com/users/byzyk","html_url":"https://github.com/byzyk","followers_url":"https://api.github.com/users/byzyk/followers","following_url":"https://api.github.com/users/byzyk/following{/other_user}","gists_url":"https://api.github.com/users/byzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/byzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byzyk/subscriptions","organizations_url":"https://api.github.com/users/byzyk/orgs","repos_url":"https://api.github.com/users/byzyk/repos","events_url":"https://api.github.com/users/byzyk/events{/privacy}","received_events_url":"https://api.github.com/users/byzyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/byzyk/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":true,"url":"https://api.github.com/repos/byzyk/webpack","forks_url":"https://api.github.com/repos/byzyk/webpack/forks","keys_url":"https://api.github.com/repos/byzyk/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/byzyk/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/byzyk/webpack/teams","hooks_url":"https://api.github.com/repos/byzyk/webpack/hooks","issue_events_url":"https://api.github.com/repos/byzyk/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/byzyk/webpack/events","assignees_url":"https://api.github.com/repos/byzyk/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/byzyk/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/byzyk/webpack/tags","blobs_url":"https://api.github.com/repos/byzyk/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/byzyk/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/byzyk/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/byzyk/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/byzyk/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/byzyk/webpack/languages","stargazers_url":"https://api.github.com/repos/byzyk/webpack/stargazers","contributors_url":"https://api.github.com/repos/byzyk/webpack/contributors","subscribers_url":"https://api.github.com/repos/byzyk/webpack/subscribers","subscription_url":"https://api.github.com/repos/byzyk/webpack/subscription","commits_url":"https://api.github.com/repos/byzyk/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/byzyk/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/byzyk/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/byzyk/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/byzyk/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/byzyk/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/byzyk/webpack/merges","archive_url":"https://api.github.com/repos/byzyk/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/byzyk/webpack/downloads","issues_url":"https://api.github.com/repos/byzyk/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/byzyk/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/byzyk/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/byzyk/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/byzyk/webpack/labels{/name}","releases_url":"https://api.github.com/repos/byzyk/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/byzyk/webpack/deployments","created_at":"2018-03-13T09:29:44Z","updated_at":"2018-06-24T13:12:04Z","pushed_at":"2018-06-26T10:00:55Z","git_url":"git://github.com/byzyk/webpack.git","ssh_url":"git@github.com:byzyk/webpack.git","clone_url":"https://github.com/byzyk/webpack.git","svn_url":"https://github.com/byzyk/webpack","homepage":"https://webpack.js.org","size":14877,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:next","ref":"next","sha":"8a7597aa6eb2eef66a8f9db3a0c49bcb96022a94","user":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc4NzMx","name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-06-26T09:19:27Z","pushed_at":"2018-06-26T10:02:50Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":15334,"stargazers_count":41979,"watchers_count":41979,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5267,"mirror_url":null,"archived":false,"open_issues_count":492,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5267,"open_issues":492,"watchers":41979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7599"},"html":{"href":"https://github.com/webpack/webpack/pull/7599"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/7599"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/7599/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7599/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7599/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/1fd67d6ddcb539628ca9c962d77e694812a9b552"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"byzyk"}}