{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments/166068929","pull_request_review_id":94095184,"id":166068929,"diff_hunk":"@@ -587,17 +587,20 @@\n             },\n \n             /**\n-             * Default column width if not defined, eg. '100px'\n+             * Default column width if not defined, eg. '100px'. Notice that with not\n+             * zero flex values this value behaves more as minimum width. See\n+             * defaultColumnFlexGrow property.\n              */\n             defaultColumnWidth: {\n               type: String,\n               value: '100px'\n             },\n \n             /**\n-             * Default column flex if not defined, eg. 1\n+             * Default column flex if not defined, eg. 1. Equialent to the CSS flex-grow\n+             * property.\n              */\n-            defaultColumnFlex: {\n+            defaultColumnFlexGrow: {\n               type: Number,\n               value: 1","path":"px-data-grid.html","position":22,"original_position":22,"commit_id":"bbd3c4ad0cc990d220155753802224db8500127b","original_commit_id":"bbd3c4ad0cc990d220155753802224db8500127b","user":{"login":"alump","id":1378660,"avatar_url":"https://avatars3.githubusercontent.com/u/1378660?v=4","gravatar_id":"","url":"https://api.github.com/users/alump","html_url":"https://github.com/alump","followers_url":"https://api.github.com/users/alump/followers","following_url":"https://api.github.com/users/alump/following{/other_user}","gists_url":"https://api.github.com/users/alump/gists{/gist_id}","starred_url":"https://api.github.com/users/alump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alump/subscriptions","organizations_url":"https://api.github.com/users/alump/orgs","repos_url":"https://api.github.com/users/alump/repos","events_url":"https://api.github.com/users/alump/events{/privacy}","received_events_url":"https://api.github.com/users/alump/received_events","type":"User","site_admin":false},"body":"Ups, I jumped files. px-data-grid-paginated is using two way binding, so it can just use the default from px-data-grid.","created_at":"2018-02-05T18:35:18Z","updated_at":"2018-02-05T18:35:18Z","html_url":"https://github.com/vaadin/px-data-grid/pull/583#discussion_r166068929","pull_request_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments/166068929"},"html":{"href":"https://github.com/vaadin/px-data-grid/pull/583#discussion_r166068929"},"pull_request":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583"}},"in_reply_to_id":166064365},"pull_request":{"url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583","id":166889496,"html_url":"https://github.com/vaadin/px-data-grid/pull/583","diff_url":"https://github.com/vaadin/px-data-grid/pull/583.diff","patch_url":"https://github.com/vaadin/px-data-grid/pull/583.patch","issue_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/583","number":583,"state":"closed","locked":false,"title":"Improve documentation of defaultColumn Width and FlexGrow","user":{"login":"alump","id":1378660,"avatar_url":"https://avatars3.githubusercontent.com/u/1378660?v=4","gravatar_id":"","url":"https://api.github.com/users/alump","html_url":"https://github.com/alump","followers_url":"https://api.github.com/users/alump/followers","following_url":"https://api.github.com/users/alump/following{/other_user}","gists_url":"https://api.github.com/users/alump/gists{/gist_id}","starred_url":"https://api.github.com/users/alump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alump/subscriptions","organizations_url":"https://api.github.com/users/alump/orgs","repos_url":"https://api.github.com/users/alump/repos","events_url":"https://api.github.com/users/alump/events{/privacy}","received_events_url":"https://api.github.com/users/alump/received_events","type":"User","site_admin":false},"body":"API change, renamed defaultColumnFlex to defaultColumnFlexGrow.\r\nAdded missing mapping of these values from px-data-grid-paginated\\\r\nto px-data-grid.\r\n\r\nFixes #530","created_at":"2018-02-02T19:54:13Z","updated_at":"2018-02-05T18:35:18Z","closed_at":"2018-02-05T18:32:51Z","merged_at":"2018-02-05T18:32:51Z","merge_commit_sha":"d904ce81830324c7dbea0a60aeb34f968bb00cd8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583/commits","review_comments_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583/comments","review_comment_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/583/comments","statuses_url":"https://api.github.com/repos/vaadin/px-data-grid/statuses/bbd3c4ad0cc990d220155753802224db8500127b","head":{"label":"vaadin:fix/530","ref":"fix/530","sha":"bbd3c4ad0cc990d220155753802224db8500127b","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":109969268,"name":"px-data-grid","full_name":"vaadin/px-data-grid","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/px-data-grid","description":"Predix UI component which defines a data grid","fork":false,"url":"https://api.github.com/repos/vaadin/px-data-grid","forks_url":"https://api.github.com/repos/vaadin/px-data-grid/forks","keys_url":"https://api.github.com/repos/vaadin/px-data-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/px-data-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/px-data-grid/teams","hooks_url":"https://api.github.com/repos/vaadin/px-data-grid/hooks","issue_events_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/px-data-grid/events","assignees_url":"https://api.github.com/repos/vaadin/px-data-grid/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/px-data-grid/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/px-data-grid/tags","blobs_url":"https://api.github.com/repos/vaadin/px-data-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/px-data-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/px-data-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/px-data-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/px-data-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/px-data-grid/languages","stargazers_url":"https://api.github.com/repos/vaadin/px-data-grid/stargazers","contributors_url":"https://api.github.com/repos/vaadin/px-data-grid/contributors","subscribers_url":"https://api.github.com/repos/vaadin/px-data-grid/subscribers","subscription_url":"https://api.github.com/repos/vaadin/px-data-grid/subscription","commits_url":"https://api.github.com/repos/vaadin/px-data-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/px-data-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/px-data-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/px-data-grid/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/px-data-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/px-data-grid/merges","archive_url":"https://api.github.com/repos/vaadin/px-data-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/px-data-grid/downloads","issues_url":"https://api.github.com/repos/vaadin/px-data-grid/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/px-data-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/px-data-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/px-data-grid/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/px-data-grid/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/px-data-grid/deployments","created_at":"2017-11-08T11:50:20Z","updated_at":"2018-01-31T21:52:06Z","pushed_at":"2018-02-05T18:32:54Z","git_url":"git://github.com/vaadin/px-data-grid.git","ssh_url":"git@github.com:vaadin/px-data-grid.git","clone_url":"https://github.com/vaadin/px-data-grid.git","svn_url":"https://github.com/vaadin/px-data-grid","homepage":"","size":1914,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":53,"watchers":0,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"5a2c6562907968157698920ac1ed524df07d4001","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":109969268,"name":"px-data-grid","full_name":"vaadin/px-data-grid","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/px-data-grid","description":"Predix UI component which defines a data grid","fork":false,"url":"https://api.github.com/repos/vaadin/px-data-grid","forks_url":"https://api.github.com/repos/vaadin/px-data-grid/forks","keys_url":"https://api.github.com/repos/vaadin/px-data-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/px-data-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/px-data-grid/teams","hooks_url":"https://api.github.com/repos/vaadin/px-data-grid/hooks","issue_events_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/px-data-grid/events","assignees_url":"https://api.github.com/repos/vaadin/px-data-grid/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/px-data-grid/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/px-data-grid/tags","blobs_url":"https://api.github.com/repos/vaadin/px-data-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/px-data-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/px-data-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/px-data-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/px-data-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/px-data-grid/languages","stargazers_url":"https://api.github.com/repos/vaadin/px-data-grid/stargazers","contributors_url":"https://api.github.com/repos/vaadin/px-data-grid/contributors","subscribers_url":"https://api.github.com/repos/vaadin/px-data-grid/subscribers","subscription_url":"https://api.github.com/repos/vaadin/px-data-grid/subscription","commits_url":"https://api.github.com/repos/vaadin/px-data-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/px-data-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/px-data-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/px-data-grid/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/px-data-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/px-data-grid/merges","archive_url":"https://api.github.com/repos/vaadin/px-data-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/px-data-grid/downloads","issues_url":"https://api.github.com/repos/vaadin/px-data-grid/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/px-data-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/px-data-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/px-data-grid/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/px-data-grid/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/px-data-grid/deployments","created_at":"2017-11-08T11:50:20Z","updated_at":"2018-01-31T21:52:06Z","pushed_at":"2018-02-05T18:32:54Z","git_url":"git://github.com/vaadin/px-data-grid.git","ssh_url":"git@github.com:vaadin/px-data-grid.git","clone_url":"https://github.com/vaadin/px-data-grid.git","svn_url":"https://github.com/vaadin/px-data-grid","homepage":"","size":1914,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":53,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583"},"html":{"href":"https://github.com/vaadin/px-data-grid/pull/583"},"issue":{"href":"https://api.github.com/repos/vaadin/px-data-grid/issues/583"},"comments":{"href":"https://api.github.com/repos/vaadin/px-data-grid/issues/583/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/583/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/px-data-grid/statuses/bbd3c4ad0cc990d220155753802224db8500127b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alump"}}