{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/240432116","pull_request_review_id":183461864,"id":240432116,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDQzMjExNg==","diff_hunk":"@@ -1,16 +1,32 @@\n ﻿<Project ToolsVersion=\"15.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n-\t<PropertyGroup>\n-\t\t<LibraryRoot>$(MSBuildThisFileDirectory)</LibraryRoot>\n-\t\t<LibraryToolsFolder>$(LibraryRoot)tools</LibraryToolsFolder>\n-\t\t<BuildAssetsDir>$(LibraryToolsFolder)\\BuildAssets</BuildAssetsDir>\n-\t\t<SdkBuildToolsDir>$(LibraryToolsFolder)\\SdkBuildTools</SdkBuildToolsDir>\n-\t</PropertyGroup>\n-\t<PropertyGroup>\n-\t\t<NetSdkBuildTargetsDir Condition=\" Exists('$(BuildAssetsDir)') \">$(BuildAssetsDir)\\targets</NetSdkBuildTargetsDir>\n-\t\t<NetSdkBuildTargetsDir Condition=\" Exists('$(SdkBuildToolsDir)') AND '$(NetSdkBuildTargetsDir)' == '' \">$(SdkBuildToolsDir)\\targets</NetSdkBuildTargetsDir>\t\t\n-\t\t<NetSdkBuildToolsDir Condition=\" Exists('$(BuildAssetsDir)') \">$(BuildAssetsDir)</NetSdkBuildToolsDir>\n-\t\t<NetSdkBuildToolsDir Condition=\" Exists('$(SdkBuildToolsDir)') AND '$(NetSdkBuildToolsDir)' == '' \">$(SdkBuildToolsDir)</NetSdkBuildToolsDir>\n-\t</PropertyGroup>\n-  \n-\t<Import Project=\"$(NetSdkBuildTargetsDir)\\core\\_Directory.Build.props\" Condition=\" Exists('$(NetSdkBuildTargetsDir)\\core\\_Directory.Build.props') \"/>\n+  <PropertyGroup>\n+    <LibraryRoot>$(MSBuildThisFileDirectory)</LibraryRoot>\n+    <LibraryToolsFolder>$(LibraryRoot)tools</LibraryToolsFolder>\n+    <BuildAssetsDir>$(LibraryToolsFolder)\\BuildAssets</BuildAssetsDir>\n+    <SdkBuildToolsDir>$(LibraryToolsFolder)\\SdkBuildTools</SdkBuildToolsDir>\n+  </PropertyGroup>\n+  <PropertyGroup>\n+    <NetSdkBuildTargetsDir Condition=\" Exists('$(BuildAssetsDir)') \">$(BuildAssetsDir)\\targets</NetSdkBuildTargetsDir>\n+    <NetSdkBuildTargetsDir Condition=\" Exists('$(SdkBuildToolsDir)') AND '$(NetSdkBuildTargetsDir)' == '' \">$(SdkBuildToolsDir)\\targets</NetSdkBuildTargetsDir>\n+    <NetSdkBuildToolsDir Condition=\" Exists('$(BuildAssetsDir)') \">$(BuildAssetsDir)</NetSdkBuildToolsDir>\n+    <NetSdkBuildToolsDir Condition=\" Exists('$(SdkBuildToolsDir)') AND '$(NetSdkBuildToolsDir)' == '' \">$(SdkBuildToolsDir)</NetSdkBuildToolsDir>\n+  </PropertyGroup>\n+\n+  <Import Project=\"$(NetSdkBuildTargetsDir)\\core\\_Directory.Build.props\" Condition=\" Exists('$(NetSdkBuildTargetsDir)\\core\\_Directory.Build.props') \"/>","path":"Directory.Build.props","position":29,"original_position":29,"commit_id":"f8517454dda4eb38edec59b9fe9569bcb9939f9f","original_commit_id":"f8517454dda4eb38edec59b9fe9569bcb9939f9f","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":">But correct me if I am wrong @weshaggard, even the route you have opted for will get overwritten by the behavior for $(DefaultPathTokenToIgnore) in common.Build.props (unless I fail to understand this change)\r\n\r\nNo it wouldn't because it happens after the property is set in common.Build.props.\r\n\r\n>Another alternative is to simply initialize $(IgnorePathTokens) with the paths that we want to ignore and no need to create a new ItemGroup.\r\n\r\nWe cannot reuse IgnorePathTokens property and keep that working if you pass it as a command line parameter. Properties passed as command line parameters to msbuild cannot be mutated in props/targets files. So we would need to create another item group if we want both the command line parameter and the props to work together.\r\n\r\nI think https://github.com/Azure/azure-sdk-for-net/pull/5075 will enable the scenario we want and still allow us to set the properties before the props file import.\r\n","created_at":"2018-12-11T00:18:58Z","updated_at":"2018-12-11T00:18:59Z","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/5074#discussion_r240432116","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/240432116"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/5074#discussion_r240432116"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074"}},"in_reply_to_id":240405929},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074","id":237464596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDY0NTk2","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/5074","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/5074.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/5074.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5074","number":5074,"state":"open","locked":false,"title":"Add ignore scopes to props file for local builds","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Today the ignore scopes are only passed in via our build definitions\r\nbut that make it hard to keep updated as well as makes it difficult to\r\nreproduce the same builds locally. To help with that we are committing\r\nthe list to a props file in the repo.\r\n\r\ncc @shahabhijeet @kurtzeborn ","created_at":"2018-12-10T21:00:41Z","updated_at":"2018-12-11T00:18:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85bd6d83c59d28a6f6cac41839d4f10c2b4502f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":495008110,"node_id":"MDU6TGFiZWw0OTUwMDgxMTA=","url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels/Changes%20Requested","name":"Changes Requested","color":"c12d9f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5074/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/f8517454dda4eb38edec59b9fe9569bcb9939f9f","head":{"label":"weshaggard:CommitIgnoreScopes","ref":"CommitIgnoreScopes","sha":"f8517454dda4eb38edec59b9fe9569bcb9939f9f","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"repo":{"id":160737577,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3Mzc1Nzc=","name":"azure-sdk-for-net","full_name":"weshaggard/azure-sdk-for-net","private":false,"owner":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weshaggard/azure-sdk-for-net","description":".NET Libraries for Azure","fork":true,"url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net","forks_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/weshaggard/azure-sdk-for-net/deployments","created_at":"2018-12-06T21:58:37Z","updated_at":"2018-12-11T00:15:22Z","pushed_at":"2018-12-11T00:15:19Z","git_url":"git://github.com/weshaggard/azure-sdk-for-net.git","ssh_url":"git@github.com:weshaggard/azure-sdk-for-net.git","clone_url":"https://github.com/weshaggard/azure-sdk-for-net.git","svn_url":"https://github.com/weshaggard/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":269002,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"psSdkJson6"}},"base":{"label":"Azure:psSdkJson6","ref":"psSdkJson6","sha":"f1e38463ceae0f3c1f20afd4ff717d44f86625b2","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4OTQ0","name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-net","description":".NET Libraries for Azure","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2018-12-10T22:30:48Z","pushed_at":"2018-12-11T00:16:15Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"git@github.com:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":269117,"stargazers_count":1241,"watchers_count":1241,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1253,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1253,"open_issues":309,"watchers":1241,"default_branch":"psSdkJson6"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/5074"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5074"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5074/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5074/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/f8517454dda4eb38edec59b9fe9569bcb9939f9f"}},"author_association":"NONE"}}
{"actor":{"display_login":"weshaggard"}}