{"action":"created","comment":{"url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/comments/236632935","pull_request_review_id":178744195,"id":236632935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjYzMjkzNQ==","diff_hunk":"@@ -67,8 +71,12 @@ public void testGetValueNoCookies() throws Exception {\n     };\n \n     CookieProcessor processor = createProcessor(\"c1\", String.class);\n-    Object value = processor.getValue(request);\n-    Assert.assertNull(value);\n+    try {\n+      processor.getValue(request);","path":"common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java","position":20,"original_position":20,"commit_id":"91a8bbc14f3a71aa9e5314269064d7f592aa0d38","original_commit_id":"91a8bbc14f3a71aa9e5314269064d7f592aa0d38","user":{"login":"liubao68","id":29354209,"node_id":"MDQ6VXNlcjI5MzU0MjA5","avatar_url":"https://avatars0.githubusercontent.com/u/29354209?v=4","gravatar_id":"","url":"https://api.github.com/users/liubao68","html_url":"https://github.com/liubao68","followers_url":"https://api.github.com/users/liubao68/followers","following_url":"https://api.github.com/users/liubao68/following{/other_user}","gists_url":"https://api.github.com/users/liubao68/gists{/gist_id}","starred_url":"https://api.github.com/users/liubao68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liubao68/subscriptions","organizations_url":"https://api.github.com/users/liubao68/orgs","repos_url":"https://api.github.com/users/liubao68/repos","events_url":"https://api.github.com/users/liubao68/events{/privacy}","received_events_url":"https://api.github.com/users/liubao68/received_events","type":"User","site_admin":false},"body":"This is a behavior change. And it's better to add a new test case which have the same meaning as the old test case. \r\nCookieProcessor processor = createProcessor(\"c1\", String.class, null, false);","created_at":"2018-11-27T12:01:28Z","updated_at":"2018-11-27T12:01:28Z","html_url":"https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236632935","pull_request_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/comments/236632935"},"html":{"href":"https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236632935"},"pull_request":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004"}}},"pull_request":{"url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004","id":233114946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTE0OTQ2","html_url":"https://github.com/apache/servicecomb-java-chassis/pull/1004","diff_url":"https://github.com/apache/servicecomb-java-chassis/pull/1004.diff","patch_url":"https://github.com/apache/servicecomb-java-chassis/pull/1004.patch","issue_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues/1004","number":1004,"state":"open","locked":false,"title":"[SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired","user":{"login":"weichao666","id":30716999,"node_id":"MDQ6VXNlcjMwNzE2OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/30716999?v=4","gravatar_id":"","url":"https://api.github.com/users/weichao666","html_url":"https://github.com/weichao666","followers_url":"https://api.github.com/users/weichao666/followers","following_url":"https://api.github.com/users/weichao666/following{/other_user}","gists_url":"https://api.github.com/users/weichao666/gists{/gist_id}","starred_url":"https://api.github.com/users/weichao666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weichao666/subscriptions","organizations_url":"https://api.github.com/users/weichao666/orgs","repos_url":"https://api.github.com/users/weichao666/repos","events_url":"https://api.github.com/users/weichao666/events{/privacy}","received_events_url":"https://api.github.com/users/weichao666/received_events","type":"User","site_admin":false},"body":"…\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.\r\n - [x] Each commit in the pull request should have a meaningful subject line and body.\r\n - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.\r\n - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\n---\r\n","created_at":"2018-11-23T06:28:00Z","updated_at":"2018-11-27T12:01:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82d537c6ae33e39fe7f9a5e7889789e002a59017","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004/commits","review_comments_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004/comments","review_comment_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues/1004/comments","statuses_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/statuses/91a8bbc14f3a71aa9e5314269064d7f592aa0d38","head":{"label":"weichao666:defaultvaluenew","ref":"defaultvaluenew","sha":"91a8bbc14f3a71aa9e5314269064d7f592aa0d38","user":{"login":"weichao666","id":30716999,"node_id":"MDQ6VXNlcjMwNzE2OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/30716999?v=4","gravatar_id":"","url":"https://api.github.com/users/weichao666","html_url":"https://github.com/weichao666","followers_url":"https://api.github.com/users/weichao666/followers","following_url":"https://api.github.com/users/weichao666/following{/other_user}","gists_url":"https://api.github.com/users/weichao666/gists{/gist_id}","starred_url":"https://api.github.com/users/weichao666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weichao666/subscriptions","organizations_url":"https://api.github.com/users/weichao666/orgs","repos_url":"https://api.github.com/users/weichao666/repos","events_url":"https://api.github.com/users/weichao666/events{/privacy}","received_events_url":"https://api.github.com/users/weichao666/received_events","type":"User","site_admin":false},"repo":{"id":141512361,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1MTIzNjE=","name":"servicecomb-java-chassis","full_name":"weichao666/servicecomb-java-chassis","private":false,"owner":{"login":"weichao666","id":30716999,"node_id":"MDQ6VXNlcjMwNzE2OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/30716999?v=4","gravatar_id":"","url":"https://api.github.com/users/weichao666","html_url":"https://github.com/weichao666","followers_url":"https://api.github.com/users/weichao666/followers","following_url":"https://api.github.com/users/weichao666/following{/other_user}","gists_url":"https://api.github.com/users/weichao666/gists{/gist_id}","starred_url":"https://api.github.com/users/weichao666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weichao666/subscriptions","organizations_url":"https://api.github.com/users/weichao666/orgs","repos_url":"https://api.github.com/users/weichao666/repos","events_url":"https://api.github.com/users/weichao666/events{/privacy}","received_events_url":"https://api.github.com/users/weichao666/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weichao666/servicecomb-java-chassis","description":"ServiceComb Java Chassis is a Software Development Kit (SDK) for rapid development of microservices in Java, providing service registration, service discovery, dynamic routing, and service management features","fork":true,"url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis","forks_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/forks","keys_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/teams","hooks_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/hooks","issue_events_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/issues/events{/number}","events_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/events","assignees_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/assignees{/user}","branches_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/branches{/branch}","tags_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/tags","blobs_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/git/refs{/sha}","trees_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/statuses/{sha}","languages_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/languages","stargazers_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/stargazers","contributors_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/contributors","subscribers_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/subscribers","subscription_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/subscription","commits_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/commits{/sha}","git_commits_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/git/commits{/sha}","comments_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/comments{/number}","issue_comment_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/issues/comments{/number}","contents_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/contents/{+path}","compare_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/merges","archive_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/downloads","issues_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/issues{/number}","pulls_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/pulls{/number}","milestones_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/milestones{/number}","notifications_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/labels{/name}","releases_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/releases{/id}","deployments_url":"https://api.github.com/repos/weichao666/servicecomb-java-chassis/deployments","created_at":"2018-07-19T02:09:13Z","updated_at":"2018-11-16T02:00:31Z","pushed_at":"2018-11-27T07:44:30Z","git_url":"git://github.com/weichao666/servicecomb-java-chassis.git","ssh_url":"git@github.com:weichao666/servicecomb-java-chassis.git","clone_url":"https://github.com/weichao666/servicecomb-java-chassis.git","svn_url":"https://github.com/weichao666/servicecomb-java-chassis","homepage":null,"size":13614,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"47d4773f3db7444e07fa2bb5bf87ac0a0387855f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":91674936,"node_id":"MDEwOlJlcG9zaXRvcnk5MTY3NDkzNg==","name":"servicecomb-java-chassis","full_name":"apache/servicecomb-java-chassis","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/servicecomb-java-chassis","description":"ServiceComb Java Chassis is a Software Development Kit (SDK) for rapid development of microservices in Java, providing service registration, service discovery, dynamic routing, and service management features","fork":false,"url":"https://api.github.com/repos/apache/servicecomb-java-chassis","forks_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/forks","keys_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/teams","hooks_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/hooks","issue_events_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/events","assignees_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/tags","blobs_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/languages","stargazers_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/stargazers","contributors_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/contributors","subscribers_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/subscribers","subscription_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/subscription","commits_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/merges","archive_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/downloads","issues_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/labels{/name}","releases_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/servicecomb-java-chassis/deployments","created_at":"2017-05-18T09:29:30Z","updated_at":"2018-11-27T09:40:48Z","pushed_at":"2018-11-27T11:26:30Z","git_url":"git://github.com/apache/servicecomb-java-chassis.git","ssh_url":"git@github.com:apache/servicecomb-java-chassis.git","clone_url":"https://github.com/apache/servicecomb-java-chassis.git","svn_url":"https://github.com/apache/servicecomb-java-chassis","homepage":null,"size":13639,"stargazers_count":699,"watchers_count":699,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":360,"open_issues":36,"watchers":699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004"},"html":{"href":"https://github.com/apache/servicecomb-java-chassis/pull/1004"},"issue":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues/1004"},"comments":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/issues/1004/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/pulls/1004/commits"},"statuses":{"href":"https://api.github.com/repos/apache/servicecomb-java-chassis/statuses/91a8bbc14f3a71aa9e5314269064d7f592aa0d38"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liubao68"}}