{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/comments/231559106","pull_request_review_id":172555270,"id":231559106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTU1OTEwNg==","diff_hunk":"@@ -396,6 +403,31 @@ public function getMaxResults()\n         return $this->maxResults;\n     }\n \n+    /**\n+     * Sets the flag to only retrieve distinct results\n+     *\n+     * @param bool $isDistinct Set true to add the distinct flag, set to false to remove it\n+     *\n+     * @return $this This QueryBuilder instance.\n+     */\n+    public function distinct($isDistinct = true)","path":"lib/Doctrine/DBAL/Query/QueryBuilder.php","position":25,"original_position":25,"commit_id":"40a39aab837aa35c8174a411858e3f3bea55980f","original_commit_id":"40a39aab837aa35c8174a411858e3f3bea55980f","user":{"login":"morozov","id":59683,"node_id":"MDQ6VXNlcjU5Njgz","avatar_url":"https://avatars1.githubusercontent.com/u/59683?v=4","gravatar_id":"","url":"https://api.github.com/users/morozov","html_url":"https://github.com/morozov","followers_url":"https://api.github.com/users/morozov/followers","following_url":"https://api.github.com/users/morozov/following{/other_user}","gists_url":"https://api.github.com/users/morozov/gists{/gist_id}","starred_url":"https://api.github.com/users/morozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morozov/subscriptions","organizations_url":"https://api.github.com/users/morozov/orgs","repos_url":"https://api.github.com/users/morozov/repos","events_url":"https://api.github.com/users/morozov/events{/privacy}","received_events_url":"https://api.github.com/users/morozov/received_events","type":"User","site_admin":false},"body":"The API would be cleaner if instead of `distinct(false)`, a developer could call `nonDistinct()`. Otherwise, it looks sort of asymmetric: `distinct()` ↔ `distinct(false)`.","created_at":"2018-11-07T15:46:44Z","updated_at":"2018-11-07T15:48:23Z","html_url":"https://github.com/doctrine/dbal/pull/3340#discussion_r231559106","pull_request_url":"https://api.github.com/repos/doctrine/dbal/pulls/3340","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments/231559106"},"html":{"href":"https://github.com/doctrine/dbal/pull/3340#discussion_r231559106"},"pull_request":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3340"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/3340","id":229000199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDAwMTk5","html_url":"https://github.com/doctrine/dbal/pull/3340","diff_url":"https://github.com/doctrine/dbal/pull/3340.diff","patch_url":"https://github.com/doctrine/dbal/pull/3340.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/3340","number":3340,"state":"open","locked":false,"title":"Distinct in the QueryBuilder","user":{"login":"michaelcullum","id":211740,"node_id":"MDQ6VXNlcjIxMTc0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/211740?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelcullum","html_url":"https://github.com/michaelcullum","followers_url":"https://api.github.com/users/michaelcullum/followers","following_url":"https://api.github.com/users/michaelcullum/following{/other_user}","gists_url":"https://api.github.com/users/michaelcullum/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcullum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcullum/subscriptions","organizations_url":"https://api.github.com/users/michaelcullum/orgs","repos_url":"https://api.github.com/users/michaelcullum/repos","events_url":"https://api.github.com/users/michaelcullum/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcullum/received_events","type":"User","site_admin":false},"body":"|      Q       |   A\r\n|------------- | -----------\r\n| Type         | feature\r\n| BC Break     | no\r\n\r\n#### Summary\r\n\r\nAdd functionality to generate distinct queries using the DBAL query builder\r\n","created_at":"2018-11-07T11:40:09Z","updated_at":"2018-11-07T15:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eba68fa913192d99e832cd9d28dab71a46b94db3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/3340/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/3340/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/3340/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/40a39aab837aa35c8174a411858e3f3bea55980f","head":{"label":"michaelcullum:qb-distinct","ref":"qb-distinct","sha":"40a39aab837aa35c8174a411858e3f3bea55980f","user":{"login":"michaelcullum","id":211740,"node_id":"MDQ6VXNlcjIxMTc0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/211740?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelcullum","html_url":"https://github.com/michaelcullum","followers_url":"https://api.github.com/users/michaelcullum/followers","following_url":"https://api.github.com/users/michaelcullum/following{/other_user}","gists_url":"https://api.github.com/users/michaelcullum/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcullum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcullum/subscriptions","organizations_url":"https://api.github.com/users/michaelcullum/orgs","repos_url":"https://api.github.com/users/michaelcullum/repos","events_url":"https://api.github.com/users/michaelcullum/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcullum/received_events","type":"User","site_admin":false},"repo":{"id":154696345,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2OTYzNDU=","name":"dbal","full_name":"michaelcullum/dbal","private":false,"owner":{"login":"michaelcullum","id":211740,"node_id":"MDQ6VXNlcjIxMTc0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/211740?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelcullum","html_url":"https://github.com/michaelcullum","followers_url":"https://api.github.com/users/michaelcullum/followers","following_url":"https://api.github.com/users/michaelcullum/following{/other_user}","gists_url":"https://api.github.com/users/michaelcullum/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcullum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcullum/subscriptions","organizations_url":"https://api.github.com/users/michaelcullum/orgs","repos_url":"https://api.github.com/users/michaelcullum/repos","events_url":"https://api.github.com/users/michaelcullum/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcullum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michaelcullum/dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/michaelcullum/dbal","forks_url":"https://api.github.com/repos/michaelcullum/dbal/forks","keys_url":"https://api.github.com/repos/michaelcullum/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelcullum/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelcullum/dbal/teams","hooks_url":"https://api.github.com/repos/michaelcullum/dbal/hooks","issue_events_url":"https://api.github.com/repos/michaelcullum/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/michaelcullum/dbal/events","assignees_url":"https://api.github.com/repos/michaelcullum/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/michaelcullum/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/michaelcullum/dbal/tags","blobs_url":"https://api.github.com/repos/michaelcullum/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelcullum/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelcullum/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelcullum/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelcullum/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelcullum/dbal/languages","stargazers_url":"https://api.github.com/repos/michaelcullum/dbal/stargazers","contributors_url":"https://api.github.com/repos/michaelcullum/dbal/contributors","subscribers_url":"https://api.github.com/repos/michaelcullum/dbal/subscribers","subscription_url":"https://api.github.com/repos/michaelcullum/dbal/subscription","commits_url":"https://api.github.com/repos/michaelcullum/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelcullum/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelcullum/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelcullum/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelcullum/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/michaelcullum/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelcullum/dbal/merges","archive_url":"https://api.github.com/repos/michaelcullum/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelcullum/dbal/downloads","issues_url":"https://api.github.com/repos/michaelcullum/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/michaelcullum/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelcullum/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelcullum/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelcullum/dbal/labels{/name}","releases_url":"https://api.github.com/repos/michaelcullum/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/michaelcullum/dbal/deployments","created_at":"2018-10-25T15:40:20Z","updated_at":"2018-10-25T15:40:24Z","pushed_at":"2018-11-07T14:17:12Z","git_url":"git://github.com/michaelcullum/dbal.git","ssh_url":"git@github.com:michaelcullum/dbal.git","clone_url":"https://github.com/michaelcullum/dbal.git","svn_url":"https://github.com/michaelcullum/dbal","homepage":"https://www.doctrine-project.org/projects/dbal.html","size":25575,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"88b80bf35068e3f29cbe0e03c351bd9320ca0728","user":{"login":"doctrine","id":209254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTI1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc0NjQ=","name":"dbal","full_name":"doctrine/dbal","private":false,"owner":{"login":"doctrine","id":209254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTI1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2018-11-07T15:05:44Z","pushed_at":"2018-11-07T14:17:13Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"https://www.doctrine-project.org/projects/dbal.html","size":25584,"stargazers_count":3646,"watchers_count":3646,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":917,"mirror_url":null,"archived":false,"open_issues_count":446,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":917,"open_issues":446,"watchers":3646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3340"},"html":{"href":"https://github.com/doctrine/dbal/pull/3340"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3340"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3340/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3340/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3340/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/40a39aab837aa35c8174a411858e3f3bea55980f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"morozov"}}