{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/17651","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/17651/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/17651/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/17651/events","html_url":"https://github.com/magento/magento2/pull/17651","id":351323791,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTQ5ODM4","number":17651,"title":"Update time12h javascript validation rule to be compatible with js minify","user":{"login":"markoshust","id":437029,"node_id":"MDQ6VXNlcjQzNzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/437029?v=4","gravatar_id":"","url":"https://api.github.com/users/markoshust","html_url":"https://github.com/markoshust","followers_url":"https://api.github.com/users/markoshust/followers","following_url":"https://api.github.com/users/markoshust/following{/other_user}","gists_url":"https://api.github.com/users/markoshust/gists{/gist_id}","starred_url":"https://api.github.com/users/markoshust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markoshust/subscriptions","organizations_url":"https://api.github.com/users/markoshust/orgs","repos_url":"https://api.github.com/users/markoshust/repos","events_url":"https://api.github.com/users/markoshust/events{/privacy}","received_events_url":"https://api.github.com/users/markoshust/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-16T18:45:25Z","updated_at":"2018-08-16T18:45:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/17651","html_url":"https://github.com/magento/magento2/pull/17651","diff_url":"https://github.com/magento/magento2/pull/17651.diff","patch_url":"https://github.com/magento/magento2/pull/17651.patch"},"body":"Update time12h javascript validation rule to be compatible with js minify\r\n\r\nFix for issue https://github.com/magento/magento2/issues/17648\r\n\r\n### Description\r\nThe space in the validation rule causes this rule to not work correctly when js minify is enabled, as it strips the space out of the validation rule regex.\r\n\r\n### Fixed Issues (if relevant)\r\n1. magento/magento2#17648: UI validation rule for valid time am/pm doesn't work when js is minified\r\n\r\n### Manual testing scenarios\r\n1. Validation rule with space doesn't work if js minify is enabled\r\n\r\n### Contribution checklist\r\n - [ x ] Pull request has a meaningful description of its purpose\r\n - [ x ] All commits are accompanied by meaningful commit messages\r\n - [ x ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ x ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/413646440","html_url":"https://github.com/magento/magento2/pull/17651#issuecomment-413646440","issue_url":"https://api.github.com/repos/magento/magento2/issues/17651","id":413646440,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzY0NjQ0MA==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T18:45:26Z","updated_at":"2018-08-16T18:45:26Z","author_association":"CONTRIBUTOR","body":"Hi @markoshust\n\nUnfortunately, we cannot accept Pull Requests from branches created in `magento2` repository.\nPlease use your own fork as a base for this Pull Request.\n\nThank you."}}
{"actor":{"display_login":"magento-engcom-team"}}