{"action":"created","issue":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/120","repository_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/120/comments","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/120/events","html_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/120","id":382209890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTY5MTg1","number":120,"title":"C51-341: Implement getdetailscount api endpoint on the front end","user":{"login":"reneolivo","id":1642119,"node_id":"MDQ6VXNlcjE2NDIxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1642119?v=4","gravatar_id":"","url":"https://api.github.com/users/reneolivo","html_url":"https://github.com/reneolivo","followers_url":"https://api.github.com/users/reneolivo/followers","following_url":"https://api.github.com/users/reneolivo/following{/other_user}","gists_url":"https://api.github.com/users/reneolivo/gists{/gist_id}","starred_url":"https://api.github.com/users/reneolivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneolivo/subscriptions","organizations_url":"https://api.github.com/users/reneolivo/orgs","repos_url":"https://api.github.com/users/reneolivo/repos","events_url":"https://api.github.com/users/reneolivo/events{/privacy}","received_events_url":"https://api.github.com/users/reneolivo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T13:16:20Z","updated_at":"2018-11-20T06:33:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/120","html_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/120","diff_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/120.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/120.patch"},"body":"## Overview\r\n\r\nThis PR replaces the `getcount` api endpoint with the new `getdetailscount` introduced in https://github.com/compucorp/uk.co.compucorp.civicase/pull/117\r\n\r\nThis new endpoint allows for properly counting the results for cases filtered by their manager or contacts involved in the case.\r\n\r\n## Before\r\n<img width=\"1264\" alt=\"screen shot 2018-11-19 at 8 59 38 am\" src=\"https://user-images.githubusercontent.com/1642119/48709166-15265900-ebdb-11e8-81c0-547941f3cd41.png\">\r\n\r\nNotice these two things:\r\n* The \"My Cases\" search filter, and\r\n* The pagination list\r\n\r\nThe contact only has 1 case assigned to them, but the pagination displays more records than what it should.\r\n\r\n## After\r\n<img width=\"1267\" alt=\"screen shot 2018-11-19 at 9 14 07 am\" src=\"https://user-images.githubusercontent.com/1642119/48709322-8108c180-ebdb-11e8-9a79-2ce05fd18da0.png\">\r\nThe pagination now works properly. When there's only 1 page, the pagination is not displayed.\r\n\r\n\r\n## Technical details\r\n\r\n* `Case.getcount` was replaced with `Case.getdetailscount`.\r\n* Code that was added as a temporary fix for C51-277 was removed.\r\n* Code that was commented out as a temporary fix for C51-277 was added back."},"comment":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/comments/440160363","html_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/120#issuecomment-440160363","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/120","id":440160363,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDE2MDM2Mw==","user":{"login":"swastikpareek","id":3340537,"node_id":"MDQ6VXNlcjMzNDA1Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3340537?v=4","gravatar_id":"","url":"https://api.github.com/users/swastikpareek","html_url":"https://github.com/swastikpareek","followers_url":"https://api.github.com/users/swastikpareek/followers","following_url":"https://api.github.com/users/swastikpareek/following{/other_user}","gists_url":"https://api.github.com/users/swastikpareek/gists{/gist_id}","starred_url":"https://api.github.com/users/swastikpareek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swastikpareek/subscriptions","organizations_url":"https://api.github.com/users/swastikpareek/orgs","repos_url":"https://api.github.com/users/swastikpareek/repos","events_url":"https://api.github.com/users/swastikpareek/events{/privacy}","received_events_url":"https://api.github.com/users/swastikpareek/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T06:33:37Z","updated_at":"2018-11-20T06:33:37Z","author_association":"NONE","body":"PR looks good. But did we check the `Other cases where I am involved in` under `Contact Tab Case tab` that the load more button is working fine ?\r\nAlso, did we check if `Dashboard page` works fine ? \r\nWhy I am saying that is because I can only see the screenshots for the case list page and not other pages.\r\n"}}
{"actor":{"display_login":"swastikpareek"}}