{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/230503943","pull_request_review_id":171265838,"id":230503943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUwMzk0Mw==","diff_hunk":"@@ -125,66 +125,66 @@ class IOSValidator extends DoctorValidator {\n       }\n     }\n \n-    // brew installed\n-    if (hasHomebrew) {\n-      brewStatus = ValidationType.installed;\n+    if (!iMobileDevice.isInstalled) {\n+      packageManagerStatus = ValidationType.partial;\n+      messages.add(ValidationMessage.error(\n+        'libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:\\n'\n+        '  brew install --HEAD libimobiledevice\\n'\n+        '  brew install ideviceinstaller'\n+      ));\n+    } else if (!await iMobileDevice.isWorking) {\n+      packageManagerStatus = ValidationType.partial;\n+      messages.add(ValidationMessage.error(\n+        'Verify that all connected devices have been paired with this computer in Xcode.\\n'\n+        'If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.\\n'\n+        'To update with Brew, run:\\n'\n+        '  brew uninstall --ignore-dependencies libimobiledevice\\n'\n+        '  brew install --HEAD libimobiledevice\\n'\n+        '  brew install ideviceinstaller'\n+      ));\n+    } else if (!await hasIDeviceInstaller) {\n+      packageManagerStatus = ValidationType.partial;\n+      messages.add(ValidationMessage.error(\n+        'ideviceinstaller is not installed; this is used to discover connected iOS devices.\\n'\n+        'To install with Brew, run:\\n'\n+        '  brew install --HEAD libimobiledevice\\n'\n+        '  brew install ideviceinstaller'\n+      ));\n+    }\n \n-      if (!iMobileDevice.isInstalled) {\n-        brewStatus = ValidationType.partial;\n-        messages.add(ValidationMessage.error(\n-            'libimobiledevice and ideviceinstaller are not installed. To install, run:\\n'\n-            '  brew install --HEAD libimobiledevice\\n'\n-            '  brew install ideviceinstaller'\n-        ));\n-      } else if (!await iMobileDevice.isWorking) {\n-        brewStatus = ValidationType.partial;\n+    final bool iHasIosDeploy = await hasIosDeploy;\n+\n+    // Check ios-deploy is installed at meets version requirements.\n+    if (iHasIosDeploy) {\n+      messages.add(\n+        ValidationMessage('ios-deploy ${await iosDeployVersionText}'));\n+    }\n+    if (!await _iosDeployIsInstalledAndMeetsVersionCheck) {\n+      packageManagerStatus = ValidationType.partial;\n+      if (iHasIosDeploy) {\n         messages.add(ValidationMessage.error(\n-            'Verify that all connected devices have been paired with this computer in Xcode.\\n'\n-            'If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.\\n'\n-            'To update, run:\\n'\n-            '  brew uninstall --ignore-dependencies libimobiledevice\\n'\n-            '  brew install --HEAD libimobiledevice\\n'\n-            '  brew install ideviceinstaller'\n+          'ios-deploy out of date ($iosDeployMinimumVersion is required). To upgrade with Brew:\\n'\n+          '  brew upgrade ios-deploy'\n         ));\n-      } else if (!await hasIDeviceInstaller) {\n-        brewStatus = ValidationType.partial;\n+      } else {\n         messages.add(ValidationMessage.error(\n-          'ideviceinstaller is not installed; this is used to discover connected iOS devices.\\n'\n-          'To install, run:\\n'\n-          '  brew install --HEAD libimobiledevice\\n'\n-          '  brew install ideviceinstaller'\n+          'ios-deploy not installed. To install with Brew:\\n'\n+          '  brew install ios-deploy'\n         ));\n       }\n-\n-      // Check ios-deploy is installed at meets version requirements.\n-      if (await hasIosDeploy) {\n-        messages.add(ValidationMessage('ios-deploy ${await iosDeployVersionText}'));\n-      }\n-      if (!await _iosDeployIsInstalledAndMeetsVersionCheck) {\n-        brewStatus = ValidationType.partial;\n-        if (await hasIosDeploy) {\n-          messages.add(ValidationMessage.error(\n-            'ios-deploy out of date ($iosDeployMinimumVersion is required). To upgrade:\\n'\n-            '  brew upgrade ios-deploy'\n-          ));\n-        } else {\n-          messages.add(ValidationMessage.error(\n-            'ios-deploy not installed. To install:\\n'\n-            '  brew install ios-deploy'\n-          ));\n-        }\n-      }\n-\n-    } else {\n-      brewStatus = ValidationType.missing;\n+    }\n+    // If one of the checks for the packages failed, we need brew so that we can install\n+    // the necessary packages. If they're all there, however, we don't even need brew.\n+    if (packageManagerStatus == ValidationType.partial && !hasHomebrew) {\n+      packageManagerStatus = ValidationType.missing;","path":"packages/flutter_tools/lib/src/ios/ios_workflow.dart","position":110,"original_position":110,"commit_id":"da1c1725697ef54acec5430ae1130202483692e8","original_commit_id":"da1c1725697ef54acec5430ae1130202483692e8","user":{"login":"jslavitz","id":7806031,"node_id":"MDQ6VXNlcjc4MDYwMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7806031?v=4","gravatar_id":"","url":"https://api.github.com/users/jslavitz","html_url":"https://github.com/jslavitz","followers_url":"https://api.github.com/users/jslavitz/followers","following_url":"https://api.github.com/users/jslavitz/following{/other_user}","gists_url":"https://api.github.com/users/jslavitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jslavitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslavitz/subscriptions","organizations_url":"https://api.github.com/users/jslavitz/orgs","repos_url":"https://api.github.com/users/jslavitz/repos","events_url":"https://api.github.com/users/jslavitz/events{/privacy}","received_events_url":"https://api.github.com/users/jslavitz/received_events","type":"User","site_admin":false},"body":"Unless they're all missing? But yah, I guess it could be missing or partial here.","created_at":"2018-11-02T20:48:00Z","updated_at":"2018-11-02T20:48:00Z","html_url":"https://github.com/flutter/flutter/pull/23844#discussion_r230503943","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/23844","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/230503943"},"html":{"href":"https://github.com/flutter/flutter/pull/23844#discussion_r230503943"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23844"}},"in_reply_to_id":230502916},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/23844","id":227768434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzY4NDM0","html_url":"https://github.com/flutter/flutter/pull/23844","diff_url":"https://github.com/flutter/flutter/pull/23844.diff","patch_url":"https://github.com/flutter/flutter/pull/23844.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/23844","number":23844,"state":"open","locked":false,"title":"Removes check for Homebrew if all necessary packages are present.","user":{"login":"jslavitz","id":7806031,"node_id":"MDQ6VXNlcjc4MDYwMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7806031?v=4","gravatar_id":"","url":"https://api.github.com/users/jslavitz","html_url":"https://github.com/jslavitz","followers_url":"https://api.github.com/users/jslavitz/followers","following_url":"https://api.github.com/users/jslavitz/following{/other_user}","gists_url":"https://api.github.com/users/jslavitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jslavitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslavitz/subscriptions","organizations_url":"https://api.github.com/users/jslavitz/orgs","repos_url":"https://api.github.com/users/jslavitz/repos","events_url":"https://api.github.com/users/jslavitz/events{/privacy}","received_events_url":"https://api.github.com/users/jslavitz/received_events","type":"User","site_admin":false},"body":"Fixes #16458 and #16461. The edited test now tests the the new situation – where all the packages required are present, but homebrew is not installed. ","created_at":"2018-11-01T21:40:02Z","updated_at":"2018-11-02T20:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c14744bf1048131f40dbcbcbf1c3fe95e63580a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/23844/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/23844/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/23844/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/da1c1725697ef54acec5430ae1130202483692e8","head":{"label":"jslavitz:homebrew","ref":"homebrew","sha":"da1c1725697ef54acec5430ae1130202483692e8","user":{"login":"jslavitz","id":7806031,"node_id":"MDQ6VXNlcjc4MDYwMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7806031?v=4","gravatar_id":"","url":"https://api.github.com/users/jslavitz","html_url":"https://github.com/jslavitz","followers_url":"https://api.github.com/users/jslavitz/followers","following_url":"https://api.github.com/users/jslavitz/following{/other_user}","gists_url":"https://api.github.com/users/jslavitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jslavitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslavitz/subscriptions","organizations_url":"https://api.github.com/users/jslavitz/orgs","repos_url":"https://api.github.com/users/jslavitz/repos","events_url":"https://api.github.com/users/jslavitz/events{/privacy}","received_events_url":"https://api.github.com/users/jslavitz/received_events","type":"User","site_admin":false},"repo":{"id":139490213,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0OTAyMTM=","name":"flutter","full_name":"jslavitz/flutter","private":false,"owner":{"login":"jslavitz","id":7806031,"node_id":"MDQ6VXNlcjc4MDYwMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7806031?v=4","gravatar_id":"","url":"https://api.github.com/users/jslavitz","html_url":"https://github.com/jslavitz","followers_url":"https://api.github.com/users/jslavitz/followers","following_url":"https://api.github.com/users/jslavitz/following{/other_user}","gists_url":"https://api.github.com/users/jslavitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jslavitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslavitz/subscriptions","organizations_url":"https://api.github.com/users/jslavitz/orgs","repos_url":"https://api.github.com/users/jslavitz/repos","events_url":"https://api.github.com/users/jslavitz/events{/privacy}","received_events_url":"https://api.github.com/users/jslavitz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jslavitz/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/jslavitz/flutter","forks_url":"https://api.github.com/repos/jslavitz/flutter/forks","keys_url":"https://api.github.com/repos/jslavitz/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jslavitz/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jslavitz/flutter/teams","hooks_url":"https://api.github.com/repos/jslavitz/flutter/hooks","issue_events_url":"https://api.github.com/repos/jslavitz/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jslavitz/flutter/events","assignees_url":"https://api.github.com/repos/jslavitz/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jslavitz/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jslavitz/flutter/tags","blobs_url":"https://api.github.com/repos/jslavitz/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jslavitz/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jslavitz/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jslavitz/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jslavitz/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jslavitz/flutter/languages","stargazers_url":"https://api.github.com/repos/jslavitz/flutter/stargazers","contributors_url":"https://api.github.com/repos/jslavitz/flutter/contributors","subscribers_url":"https://api.github.com/repos/jslavitz/flutter/subscribers","subscription_url":"https://api.github.com/repos/jslavitz/flutter/subscription","commits_url":"https://api.github.com/repos/jslavitz/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jslavitz/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jslavitz/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jslavitz/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jslavitz/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jslavitz/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jslavitz/flutter/merges","archive_url":"https://api.github.com/repos/jslavitz/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jslavitz/flutter/downloads","issues_url":"https://api.github.com/repos/jslavitz/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jslavitz/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jslavitz/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jslavitz/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jslavitz/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jslavitz/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jslavitz/flutter/deployments","created_at":"2018-07-02T20:20:09Z","updated_at":"2018-10-19T16:52:04Z","pushed_at":"2018-11-02T19:52:38Z","git_url":"git://github.com/jslavitz/flutter.git","ssh_url":"git@github.com:jslavitz/flutter.git","clone_url":"https://github.com/jslavitz/flutter.git","svn_url":"https://github.com/jslavitz/flutter","homepage":"https://flutter.io","size":50618,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"3aa104fe60df4b647cc9c6bc319788db54207117","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-11-02T20:42:09Z","pushed_at":"2018-11-02T20:38:55Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":49772,"stargazers_count":40419,"watchers_count":40419,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3994,"mirror_url":null,"archived":false,"open_issues_count":4225,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3994,"open_issues":4225,"watchers":40419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23844"},"html":{"href":"https://github.com/flutter/flutter/pull/23844"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/23844"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/23844/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23844/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23844/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/da1c1725697ef54acec5430ae1130202483692e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jslavitz"}}