{"action":"created","comment":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments/224248835","pull_request_review_id":163570519,"id":224248835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI0ODgzNQ==","diff_hunk":"@@ -492,6 +505,22 @@ private void deleteAllJobs() throws Exception {\n \t\t}\n \t}\n \n+\tprivate void uninitializeExecutors() throws MalformedObjectNameException {\n+\t\tthis.uninitializeExecutors(queryExecutorRepository);\n+\t\tthis.uninitializeExecutors(resultExecutorRepository);\n+\t}\n+\n+\tprivate void uninitializeExecutors(ExecutorRepository executorRepository) {\n+\t\texecutorRepository.clear();\n+\t}\n+\n+\tprivate void restartSystem() throws Exception {\n+\t\tthis.deleteAllJobs();","path":"jmxtrans-core/src/main/java/com/googlecode/jmxtrans/JmxTransformer.java","position":34,"original_position":34,"commit_id":"072c9eb80cd15f0b7921c363739ee5782bef405d","original_commit_id":"072c9eb80cd15f0b7921c363739ee5782bef405d","user":{"login":"gehel","id":1415765,"node_id":"MDQ6VXNlcjE0MTU3NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1415765?v=4","gravatar_id":"","url":"https://api.github.com/users/gehel","html_url":"https://github.com/gehel","followers_url":"https://api.github.com/users/gehel/followers","following_url":"https://api.github.com/users/gehel/following{/other_user}","gists_url":"https://api.github.com/users/gehel/gists{/gist_id}","starred_url":"https://api.github.com/users/gehel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gehel/subscriptions","organizations_url":"https://api.github.com/users/gehel/orgs","repos_url":"https://api.github.com/users/gehel/repos","events_url":"https://api.github.com/users/gehel/events{/privacy}","received_events_url":"https://api.github.com/users/gehel/received_events","type":"User","site_admin":false},"body":"I'm surprised by all those explicit `this.`. It looks somewhat coherent with the rest of the code in this class, but this is (I hope) not how all the code in this project looks. (Very minor comment, feel free to ignore it).","created_at":"2018-10-10T21:30:55Z","updated_at":"2018-10-10T21:30:55Z","html_url":"https://github.com/jmxtrans/jmxtrans/pull/709#discussion_r224248835","pull_request_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments/224248835"},"html":{"href":"https://github.com/jmxtrans/jmxtrans/pull/709#discussion_r224248835"},"pull_request":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709"}}},"pull_request":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709","id":221874916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODc0OTE2","html_url":"https://github.com/jmxtrans/jmxtrans/pull/709","diff_url":"https://github.com/jmxtrans/jmxtrans/pull/709.diff","patch_url":"https://github.com/jmxtrans/jmxtrans/pull/709.patch","issue_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/709","number":709,"state":"open","locked":false,"title":"Terminate jmxtrans when it runs into an exception","user":{"login":"afn","id":2779422,"node_id":"MDQ6VXNlcjI3Nzk0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2779422?v=4","gravatar_id":"","url":"https://api.github.com/users/afn","html_url":"https://github.com/afn","followers_url":"https://api.github.com/users/afn/followers","following_url":"https://api.github.com/users/afn/following{/other_user}","gists_url":"https://api.github.com/users/afn/gists{/gist_id}","starred_url":"https://api.github.com/users/afn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afn/subscriptions","organizations_url":"https://api.github.com/users/afn/orgs","repos_url":"https://api.github.com/users/afn/repos","events_url":"https://api.github.com/users/afn/events{/privacy}","received_events_url":"https://api.github.com/users/afn/received_events","type":"User","site_admin":false},"body":"Address one common cause of uncaught exceptions, and also register an uncaught exception handler to cause jmxtrans to exit with a non-zero status rather than getting stuck in an inconsistent state.\r\n\r\nFixes #685.","created_at":"2018-10-10T17:39:44Z","updated_at":"2018-10-10T21:30:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88338cdd1bf3adc54142630461665b2249f0f548","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709/commits","review_comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709/comments","review_comment_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/709/comments","statuses_url":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/072c9eb80cd15f0b7921c363739ee5782bef405d","head":{"label":"afn:crash-on-uncaught-exception","ref":"crash-on-uncaught-exception","sha":"072c9eb80cd15f0b7921c363739ee5782bef405d","user":{"login":"afn","id":2779422,"node_id":"MDQ6VXNlcjI3Nzk0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2779422?v=4","gravatar_id":"","url":"https://api.github.com/users/afn","html_url":"https://github.com/afn","followers_url":"https://api.github.com/users/afn/followers","following_url":"https://api.github.com/users/afn/following{/other_user}","gists_url":"https://api.github.com/users/afn/gists{/gist_id}","starred_url":"https://api.github.com/users/afn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afn/subscriptions","organizations_url":"https://api.github.com/users/afn/orgs","repos_url":"https://api.github.com/users/afn/repos","events_url":"https://api.github.com/users/afn/events{/privacy}","received_events_url":"https://api.github.com/users/afn/received_events","type":"User","site_admin":false},"repo":{"id":152464182,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0NjQxODI=","name":"jmxtrans","full_name":"afn/jmxtrans","private":false,"owner":{"login":"afn","id":2779422,"node_id":"MDQ6VXNlcjI3Nzk0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2779422?v=4","gravatar_id":"","url":"https://api.github.com/users/afn","html_url":"https://github.com/afn","followers_url":"https://api.github.com/users/afn/followers","following_url":"https://api.github.com/users/afn/following{/other_user}","gists_url":"https://api.github.com/users/afn/gists{/gist_id}","starred_url":"https://api.github.com/users/afn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afn/subscriptions","organizations_url":"https://api.github.com/users/afn/orgs","repos_url":"https://api.github.com/users/afn/repos","events_url":"https://api.github.com/users/afn/events{/privacy}","received_events_url":"https://api.github.com/users/afn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/afn/jmxtrans","description":"jmxtrans","fork":true,"url":"https://api.github.com/repos/afn/jmxtrans","forks_url":"https://api.github.com/repos/afn/jmxtrans/forks","keys_url":"https://api.github.com/repos/afn/jmxtrans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afn/jmxtrans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afn/jmxtrans/teams","hooks_url":"https://api.github.com/repos/afn/jmxtrans/hooks","issue_events_url":"https://api.github.com/repos/afn/jmxtrans/issues/events{/number}","events_url":"https://api.github.com/repos/afn/jmxtrans/events","assignees_url":"https://api.github.com/repos/afn/jmxtrans/assignees{/user}","branches_url":"https://api.github.com/repos/afn/jmxtrans/branches{/branch}","tags_url":"https://api.github.com/repos/afn/jmxtrans/tags","blobs_url":"https://api.github.com/repos/afn/jmxtrans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afn/jmxtrans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afn/jmxtrans/git/refs{/sha}","trees_url":"https://api.github.com/repos/afn/jmxtrans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afn/jmxtrans/statuses/{sha}","languages_url":"https://api.github.com/repos/afn/jmxtrans/languages","stargazers_url":"https://api.github.com/repos/afn/jmxtrans/stargazers","contributors_url":"https://api.github.com/repos/afn/jmxtrans/contributors","subscribers_url":"https://api.github.com/repos/afn/jmxtrans/subscribers","subscription_url":"https://api.github.com/repos/afn/jmxtrans/subscription","commits_url":"https://api.github.com/repos/afn/jmxtrans/commits{/sha}","git_commits_url":"https://api.github.com/repos/afn/jmxtrans/git/commits{/sha}","comments_url":"https://api.github.com/repos/afn/jmxtrans/comments{/number}","issue_comment_url":"https://api.github.com/repos/afn/jmxtrans/issues/comments{/number}","contents_url":"https://api.github.com/repos/afn/jmxtrans/contents/{+path}","compare_url":"https://api.github.com/repos/afn/jmxtrans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afn/jmxtrans/merges","archive_url":"https://api.github.com/repos/afn/jmxtrans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afn/jmxtrans/downloads","issues_url":"https://api.github.com/repos/afn/jmxtrans/issues{/number}","pulls_url":"https://api.github.com/repos/afn/jmxtrans/pulls{/number}","milestones_url":"https://api.github.com/repos/afn/jmxtrans/milestones{/number}","notifications_url":"https://api.github.com/repos/afn/jmxtrans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afn/jmxtrans/labels{/name}","releases_url":"https://api.github.com/repos/afn/jmxtrans/releases{/id}","deployments_url":"https://api.github.com/repos/afn/jmxtrans/deployments","created_at":"2018-10-10T17:38:19Z","updated_at":"2018-10-10T18:30:57Z","pushed_at":"2018-10-10T18:30:55Z","git_url":"git://github.com/afn/jmxtrans.git","ssh_url":"git@github.com:afn/jmxtrans.git","clone_url":"https://github.com/afn/jmxtrans.git","svn_url":"https://github.com/afn/jmxtrans","homepage":"","size":69715,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmxtrans:master","ref":"master","sha":"600de3580ba10ba79e67d771112b9ed00f643e23","user":{"login":"jmxtrans","id":3198433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTg0MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/3198433?v=4","gravatar_id":"","url":"https://api.github.com/users/jmxtrans","html_url":"https://github.com/jmxtrans","followers_url":"https://api.github.com/users/jmxtrans/followers","following_url":"https://api.github.com/users/jmxtrans/following{/other_user}","gists_url":"https://api.github.com/users/jmxtrans/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxtrans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxtrans/subscriptions","organizations_url":"https://api.github.com/users/jmxtrans/orgs","repos_url":"https://api.github.com/users/jmxtrans/repos","events_url":"https://api.github.com/users/jmxtrans/events{/privacy}","received_events_url":"https://api.github.com/users/jmxtrans/received_events","type":"Organization","site_admin":false},"repo":{"id":2934254,"node_id":"MDEwOlJlcG9zaXRvcnkyOTM0MjU0","name":"jmxtrans","full_name":"jmxtrans/jmxtrans","private":false,"owner":{"login":"jmxtrans","id":3198433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTg0MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/3198433?v=4","gravatar_id":"","url":"https://api.github.com/users/jmxtrans","html_url":"https://github.com/jmxtrans","followers_url":"https://api.github.com/users/jmxtrans/followers","following_url":"https://api.github.com/users/jmxtrans/following{/other_user}","gists_url":"https://api.github.com/users/jmxtrans/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxtrans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxtrans/subscriptions","organizations_url":"https://api.github.com/users/jmxtrans/orgs","repos_url":"https://api.github.com/users/jmxtrans/repos","events_url":"https://api.github.com/users/jmxtrans/events{/privacy}","received_events_url":"https://api.github.com/users/jmxtrans/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jmxtrans/jmxtrans","description":"jmxtrans","fork":false,"url":"https://api.github.com/repos/jmxtrans/jmxtrans","forks_url":"https://api.github.com/repos/jmxtrans/jmxtrans/forks","keys_url":"https://api.github.com/repos/jmxtrans/jmxtrans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmxtrans/jmxtrans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmxtrans/jmxtrans/teams","hooks_url":"https://api.github.com/repos/jmxtrans/jmxtrans/hooks","issue_events_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/events{/number}","events_url":"https://api.github.com/repos/jmxtrans/jmxtrans/events","assignees_url":"https://api.github.com/repos/jmxtrans/jmxtrans/assignees{/user}","branches_url":"https://api.github.com/repos/jmxtrans/jmxtrans/branches{/branch}","tags_url":"https://api.github.com/repos/jmxtrans/jmxtrans/tags","blobs_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/{sha}","languages_url":"https://api.github.com/repos/jmxtrans/jmxtrans/languages","stargazers_url":"https://api.github.com/repos/jmxtrans/jmxtrans/stargazers","contributors_url":"https://api.github.com/repos/jmxtrans/jmxtrans/contributors","subscribers_url":"https://api.github.com/repos/jmxtrans/jmxtrans/subscribers","subscription_url":"https://api.github.com/repos/jmxtrans/jmxtrans/subscription","commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmxtrans/jmxtrans/contents/{+path}","compare_url":"https://api.github.com/repos/jmxtrans/jmxtrans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmxtrans/jmxtrans/merges","archive_url":"https://api.github.com/repos/jmxtrans/jmxtrans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmxtrans/jmxtrans/downloads","issues_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues{/number}","pulls_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls{/number}","milestones_url":"https://api.github.com/repos/jmxtrans/jmxtrans/milestones{/number}","notifications_url":"https://api.github.com/repos/jmxtrans/jmxtrans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmxtrans/jmxtrans/labels{/name}","releases_url":"https://api.github.com/repos/jmxtrans/jmxtrans/releases{/id}","deployments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/deployments","created_at":"2011-12-07T17:24:36Z","updated_at":"2018-10-10T21:25:01Z","pushed_at":"2018-10-10T21:24:53Z","git_url":"git://github.com/jmxtrans/jmxtrans.git","ssh_url":"git@github.com:jmxtrans/jmxtrans.git","clone_url":"https://github.com/jmxtrans/jmxtrans.git","svn_url":"https://github.com/jmxtrans/jmxtrans","homepage":"","size":69705,"stargazers_count":1414,"watchers_count":1414,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":455,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":455,"open_issues":111,"watchers":1414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709"},"html":{"href":"https://github.com/jmxtrans/jmxtrans/pull/709"},"issue":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/709"},"comments":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/072c9eb80cd15f0b7921c363739ee5782bef405d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gehel"}}