{"action":"created","comment":{"url":"https://api.github.com/repos/oasp/oasp4j/pulls/comments/169028417","pull_request_review_id":97479938,"id":169028417,"diff_hunk":"@@ -0,0 +1,512 @@\n+package io.oasp.module.jpa.dataaccess.api;","path":"modules/jpa/src/main/java/io/oasp/module/jpa/dataaccess/api/QueryDslHelper.java","position":1,"original_position":1,"commit_id":"2fe1d69736fc62ed5e91ef5e6845587e8f7e654d","original_commit_id":"2fe1d69736fc62ed5e91ef5e6845587e8f7e654d","user":{"login":"maybeec","id":1427255,"avatar_url":"https://avatars0.githubusercontent.com/u/1427255?v=4","gravatar_id":"","url":"https://api.github.com/users/maybeec","html_url":"https://github.com/maybeec","followers_url":"https://api.github.com/users/maybeec/followers","following_url":"https://api.github.com/users/maybeec/following{/other_user}","gists_url":"https://api.github.com/users/maybeec/gists{/gist_id}","starred_url":"https://api.github.com/users/maybeec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maybeec/subscriptions","organizations_url":"https://api.github.com/users/maybeec/orgs","repos_url":"https://api.github.com/users/maybeec/repos","events_url":"https://api.github.com/users/maybeec/events{/privacy}","received_events_url":"https://api.github.com/users/maybeec/received_events","type":"User","site_admin":false},"body":"I think we should extract the search pattern query support to a seperate util to also document in the class javadocs, that this is not for general use, but the newXClause functions come with a special use case.\r\nOtherwise, you will end up in users writing their queries just which this provided functions, which would end up in a code mess, which cannot be understood easily as you cannot trace the query construction anymore.","created_at":"2018-02-19T09:59:34Z","updated_at":"2018-02-19T10:01:49Z","html_url":"https://github.com/oasp/oasp4j/pull/627#discussion_r169028417","pull_request_url":"https://api.github.com/repos/oasp/oasp4j/pulls/627","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/comments/169028417"},"html":{"href":"https://github.com/oasp/oasp4j/pull/627#discussion_r169028417"},"pull_request":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/627"}}},"pull_request":{"url":"https://api.github.com/repos/oasp/oasp4j/pulls/627","id":164033940,"html_url":"https://github.com/oasp/oasp4j/pull/627","diff_url":"https://github.com/oasp/oasp4j/pull/627.diff","patch_url":"https://github.com/oasp/oasp4j/pull/627.patch","issue_url":"https://api.github.com/repos/oasp/oasp4j/issues/627","number":627,"state":"open","locked":false,"title":"spring-data and more","user":{"login":"hohwille","id":1923119,"avatar_url":"https://avatars0.githubusercontent.com/u/1923119?v=4","gravatar_id":"","url":"https://api.github.com/users/hohwille","html_url":"https://github.com/hohwille","followers_url":"https://api.github.com/users/hohwille/followers","following_url":"https://api.github.com/users/hohwille/following{/other_user}","gists_url":"https://api.github.com/users/hohwille/gists{/gist_id}","starred_url":"https://api.github.com/users/hohwille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohwille/subscriptions","organizations_url":"https://api.github.com/users/hohwille/orgs","repos_url":"https://api.github.com/users/hohwille/repos","events_url":"https://api.github.com/users/hohwille/events{/privacy}","received_events_url":"https://api.github.com/users/hohwille/received_events","type":"User","site_admin":false},"body":"Here is a great PR with the following features:\r\n* #614: updated and migrated to com.querydsl\r\n* #616: moved DAO stuff to new module\r\n* #626: added spring-data support\r\n\r\nHave fun. \r\n\r\nQuestions:\r\n* IMHO we actually made a design flaw by putting the SearchCriteria stuff into jpa module and jpa specific package even though it is pretty generic and can also be used for NoSQL DBs. Should have be placed in `oasp4j-basic`. Should we do anything about it?\r\n* Further, spring(-data) has its own support for paging. Should we also align something here?","created_at":"2018-01-19T18:09:57Z","updated_at":"2018-02-19T10:01:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b190b9fcca91d1a5d56eeeb509aa3114a1a79b55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":104703462,"url":"https://api.github.com/repos/oasp/oasp4j/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":130957424,"url":"https://api.github.com/repos/oasp/oasp4j/labels/persistence","name":"persistence","color":"d4c5f9","default":false},{"id":291488503,"url":"https://api.github.com/repos/oasp/oasp4j/labels/spring-boot","name":"spring-boot","color":"111111","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oasp/oasp4j/pulls/627/commits","review_comments_url":"https://api.github.com/repos/oasp/oasp4j/pulls/627/comments","review_comment_url":"https://api.github.com/repos/oasp/oasp4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oasp/oasp4j/issues/627/comments","statuses_url":"https://api.github.com/repos/oasp/oasp4j/statuses/2fe1d69736fc62ed5e91ef5e6845587e8f7e654d","head":{"label":"hohwille:feature-spring-data","ref":"feature-spring-data","sha":"2fe1d69736fc62ed5e91ef5e6845587e8f7e654d","user":{"login":"hohwille","id":1923119,"avatar_url":"https://avatars0.githubusercontent.com/u/1923119?v=4","gravatar_id":"","url":"https://api.github.com/users/hohwille","html_url":"https://github.com/hohwille","followers_url":"https://api.github.com/users/hohwille/followers","following_url":"https://api.github.com/users/hohwille/following{/other_user}","gists_url":"https://api.github.com/users/hohwille/gists{/gist_id}","starred_url":"https://api.github.com/users/hohwille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohwille/subscriptions","organizations_url":"https://api.github.com/users/hohwille/orgs","repos_url":"https://api.github.com/users/hohwille/repos","events_url":"https://api.github.com/users/hohwille/events{/privacy}","received_events_url":"https://api.github.com/users/hohwille/received_events","type":"User","site_admin":false},"repo":{"id":68960261,"name":"oasp4j","full_name":"hohwille/oasp4j","owner":{"login":"hohwille","id":1923119,"avatar_url":"https://avatars0.githubusercontent.com/u/1923119?v=4","gravatar_id":"","url":"https://api.github.com/users/hohwille","html_url":"https://github.com/hohwille","followers_url":"https://api.github.com/users/hohwille/followers","following_url":"https://api.github.com/users/hohwille/following{/other_user}","gists_url":"https://api.github.com/users/hohwille/gists{/gist_id}","starred_url":"https://api.github.com/users/hohwille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohwille/subscriptions","organizations_url":"https://api.github.com/users/hohwille/orgs","repos_url":"https://api.github.com/users/hohwille/repos","events_url":"https://api.github.com/users/hohwille/events{/privacy}","received_events_url":"https://api.github.com/users/hohwille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hohwille/oasp4j","description":"The Open Application Standard Platform for Java","fork":true,"url":"https://api.github.com/repos/hohwille/oasp4j","forks_url":"https://api.github.com/repos/hohwille/oasp4j/forks","keys_url":"https://api.github.com/repos/hohwille/oasp4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hohwille/oasp4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hohwille/oasp4j/teams","hooks_url":"https://api.github.com/repos/hohwille/oasp4j/hooks","issue_events_url":"https://api.github.com/repos/hohwille/oasp4j/issues/events{/number}","events_url":"https://api.github.com/repos/hohwille/oasp4j/events","assignees_url":"https://api.github.com/repos/hohwille/oasp4j/assignees{/user}","branches_url":"https://api.github.com/repos/hohwille/oasp4j/branches{/branch}","tags_url":"https://api.github.com/repos/hohwille/oasp4j/tags","blobs_url":"https://api.github.com/repos/hohwille/oasp4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hohwille/oasp4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hohwille/oasp4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/hohwille/oasp4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hohwille/oasp4j/statuses/{sha}","languages_url":"https://api.github.com/repos/hohwille/oasp4j/languages","stargazers_url":"https://api.github.com/repos/hohwille/oasp4j/stargazers","contributors_url":"https://api.github.com/repos/hohwille/oasp4j/contributors","subscribers_url":"https://api.github.com/repos/hohwille/oasp4j/subscribers","subscription_url":"https://api.github.com/repos/hohwille/oasp4j/subscription","commits_url":"https://api.github.com/repos/hohwille/oasp4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/hohwille/oasp4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/hohwille/oasp4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/hohwille/oasp4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/hohwille/oasp4j/contents/{+path}","compare_url":"https://api.github.com/repos/hohwille/oasp4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hohwille/oasp4j/merges","archive_url":"https://api.github.com/repos/hohwille/oasp4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hohwille/oasp4j/downloads","issues_url":"https://api.github.com/repos/hohwille/oasp4j/issues{/number}","pulls_url":"https://api.github.com/repos/hohwille/oasp4j/pulls{/number}","milestones_url":"https://api.github.com/repos/hohwille/oasp4j/milestones{/number}","notifications_url":"https://api.github.com/repos/hohwille/oasp4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hohwille/oasp4j/labels{/name}","releases_url":"https://api.github.com/repos/hohwille/oasp4j/releases{/id}","deployments_url":"https://api.github.com/repos/hohwille/oasp4j/deployments","created_at":"2016-09-22T20:37:20Z","updated_at":"2016-09-22T20:37:22Z","pushed_at":"2018-02-02T16:38:25Z","git_url":"git://github.com/hohwille/oasp4j.git","ssh_url":"git@github.com:hohwille/oasp4j.git","clone_url":"https://github.com/hohwille/oasp4j.git","svn_url":"https://github.com/hohwille/oasp4j","homepage":null,"size":2906,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oasp:develop","ref":"develop","sha":"d8eea78991fea88eca3a1d76ae99896b6654df4b","user":{"login":"oasp","id":9847033,"avatar_url":"https://avatars1.githubusercontent.com/u/9847033?v=4","gravatar_id":"","url":"https://api.github.com/users/oasp","html_url":"https://github.com/oasp","followers_url":"https://api.github.com/users/oasp/followers","following_url":"https://api.github.com/users/oasp/following{/other_user}","gists_url":"https://api.github.com/users/oasp/gists{/gist_id}","starred_url":"https://api.github.com/users/oasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasp/subscriptions","organizations_url":"https://api.github.com/users/oasp/orgs","repos_url":"https://api.github.com/users/oasp/repos","events_url":"https://api.github.com/users/oasp/events{/privacy}","received_events_url":"https://api.github.com/users/oasp/received_events","type":"Organization","site_admin":false},"repo":{"id":20517345,"name":"oasp4j","full_name":"oasp/oasp4j","owner":{"login":"oasp","id":9847033,"avatar_url":"https://avatars1.githubusercontent.com/u/9847033?v=4","gravatar_id":"","url":"https://api.github.com/users/oasp","html_url":"https://github.com/oasp","followers_url":"https://api.github.com/users/oasp/followers","following_url":"https://api.github.com/users/oasp/following{/other_user}","gists_url":"https://api.github.com/users/oasp/gists{/gist_id}","starred_url":"https://api.github.com/users/oasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasp/subscriptions","organizations_url":"https://api.github.com/users/oasp/orgs","repos_url":"https://api.github.com/users/oasp/repos","events_url":"https://api.github.com/users/oasp/events{/privacy}","received_events_url":"https://api.github.com/users/oasp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oasp/oasp4j","description":"The Open Application Standard Platform for Java","fork":false,"url":"https://api.github.com/repos/oasp/oasp4j","forks_url":"https://api.github.com/repos/oasp/oasp4j/forks","keys_url":"https://api.github.com/repos/oasp/oasp4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasp/oasp4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasp/oasp4j/teams","hooks_url":"https://api.github.com/repos/oasp/oasp4j/hooks","issue_events_url":"https://api.github.com/repos/oasp/oasp4j/issues/events{/number}","events_url":"https://api.github.com/repos/oasp/oasp4j/events","assignees_url":"https://api.github.com/repos/oasp/oasp4j/assignees{/user}","branches_url":"https://api.github.com/repos/oasp/oasp4j/branches{/branch}","tags_url":"https://api.github.com/repos/oasp/oasp4j/tags","blobs_url":"https://api.github.com/repos/oasp/oasp4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasp/oasp4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasp/oasp4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasp/oasp4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasp/oasp4j/statuses/{sha}","languages_url":"https://api.github.com/repos/oasp/oasp4j/languages","stargazers_url":"https://api.github.com/repos/oasp/oasp4j/stargazers","contributors_url":"https://api.github.com/repos/oasp/oasp4j/contributors","subscribers_url":"https://api.github.com/repos/oasp/oasp4j/subscribers","subscription_url":"https://api.github.com/repos/oasp/oasp4j/subscription","commits_url":"https://api.github.com/repos/oasp/oasp4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasp/oasp4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasp/oasp4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasp/oasp4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasp/oasp4j/contents/{+path}","compare_url":"https://api.github.com/repos/oasp/oasp4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasp/oasp4j/merges","archive_url":"https://api.github.com/repos/oasp/oasp4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasp/oasp4j/downloads","issues_url":"https://api.github.com/repos/oasp/oasp4j/issues{/number}","pulls_url":"https://api.github.com/repos/oasp/oasp4j/pulls{/number}","milestones_url":"https://api.github.com/repos/oasp/oasp4j/milestones{/number}","notifications_url":"https://api.github.com/repos/oasp/oasp4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasp/oasp4j/labels{/name}","releases_url":"https://api.github.com/repos/oasp/oasp4j/releases{/id}","deployments_url":"https://api.github.com/repos/oasp/oasp4j/deployments","created_at":"2014-06-05T08:20:28Z","updated_at":"2018-02-18T07:24:14Z","pushed_at":"2018-02-02T16:38:27Z","git_url":"git://github.com/oasp/oasp4j.git","ssh_url":"git@github.com:oasp/oasp4j.git","clone_url":"https://github.com/oasp/oasp4j.git","svn_url":"https://github.com/oasp/oasp4j","homepage":null,"size":3422,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":302,"open_issues":99,"watchers":51,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/627"},"html":{"href":"https://github.com/oasp/oasp4j/pull/627"},"issue":{"href":"https://api.github.com/repos/oasp/oasp4j/issues/627"},"comments":{"href":"https://api.github.com/repos/oasp/oasp4j/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oasp/oasp4j/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/oasp/oasp4j/statuses/2fe1d69736fc62ed5e91ef5e6845587e8f7e654d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"maybeec"}}