{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/237490443","pull_request_review_id":179799767,"id":237490443,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ5MDQ0Mw==","diff_hunk":"@@ -6385,7 +6383,7 @@ public class net.corda.testing.node.MockServices extends java.lang.Object implem\n   @NotNull\n   public net.corda.core.node.services.NetworkMapCache getNetworkMapCache()\n   @NotNull\n-  public final net.corda.core.node.NetworkParameters getNetworkParameters()\n+  public net.corda.core.node.NetworkParameters getNetworkParameters()","path":".ci/api-current.txt","position":14,"original_position":14,"commit_id":"d2c005bebbc0cc883e91195bd3c25de1f6c27cb2","original_commit_id":"d2c005bebbc0cc883e91195bd3c25de1f6c27cb2","user":{"login":"adagys","id":2355284,"node_id":"MDQ6VXNlcjIzNTUyODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2355284?v=4","gravatar_id":"","url":"https://api.github.com/users/adagys","html_url":"https://github.com/adagys","followers_url":"https://api.github.com/users/adagys/followers","following_url":"https://api.github.com/users/adagys/following{/other_user}","gists_url":"https://api.github.com/users/adagys/gists{/gist_id}","starred_url":"https://api.github.com/users/adagys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagys/subscriptions","organizations_url":"https://api.github.com/users/adagys/orgs","repos_url":"https://api.github.com/users/adagys/repos","events_url":"https://api.github.com/users/adagys/events{/privacy}","received_events_url":"https://api.github.com/users/adagys/received_events","type":"User","site_admin":false},"body":"yes, instead of being passed to the constructor, it's not a separate val:\r\n```\r\n  override val networkParameters: NetworkParameters\r\n        get() = networkParametersStorage.run { lookup(currentHash)!! }\r\n```","created_at":"2018-11-29T13:43:38Z","updated_at":"2018-11-29T13:43:38Z","html_url":"https://github.com/corda/corda/pull/4293#discussion_r237490443","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/4293","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/237490443"},"html":{"href":"https://github.com/corda/corda/pull/4293#discussion_r237490443"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/4293"}},"in_reply_to_id":237484455},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/4293","id":233534519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTM0NTE5","html_url":"https://github.com/corda/corda/pull/4293","diff_url":"https://github.com/corda/corda/pull/4293.diff","patch_url":"https://github.com/corda/corda/pull/4293.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/4293","number":4293,"state":"open","locked":false,"title":"CORDA-2115: Notary whitelist verification changes","user":{"login":"adagys","id":2355284,"node_id":"MDQ6VXNlcjIzNTUyODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2355284?v=4","gravatar_id":"","url":"https://api.github.com/users/adagys","html_url":"https://github.com/adagys","followers_url":"https://api.github.com/users/adagys/followers","following_url":"https://api.github.com/users/adagys/following{/other_user}","gists_url":"https://api.github.com/users/adagys/gists{/gist_id}","starred_url":"https://api.github.com/users/adagys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adagys/subscriptions","organizations_url":"https://api.github.com/users/adagys/orgs","repos_url":"https://api.github.com/users/adagys/repos","events_url":"https://api.github.com/users/adagys/events{/privacy}","received_events_url":"https://api.github.com/users/adagys/received_events","type":"User","site_admin":false},"body":"- For regular and contract upgrade transactions: check that the notary is in the network parameter whitelist\r\n- For notary change transactions: check the the new notary is in the network parameter whitelist. This enabled support for network merging: the old notary doesn't have to be in the current network's notary whitelist for re-pointing old states to another notary.\r\n\r\nThese checks are done during transaction construction/verification and also by the non-validating notary.\r\n\r\n(Raising a PR against Kasia's branch but will rebase against master later).","created_at":"2018-11-26T12:06:00Z","updated_at":"2018-11-29T13:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2b8ca7b3caead335af402f1093cc765419ed9d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":879858219,"node_id":"MDU6TGFiZWw4Nzk4NTgyMTk=","url":"https://api.github.com/repos/corda/corda/labels/work%20in%20progress","name":"work in progress","color":"a01429","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/4293/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/4293/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/4293/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/d2c005bebbc0cc883e91195bd3c25de1f6c27cb2","head":{"label":"corda:andrius/CORDA-2115-rebased","ref":"andrius/CORDA-2115-rebased","sha":"d2c005bebbc0cc883e91195bd3c25de1f6c27cb2","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-11-29T13:20:34Z","pushed_at":"2018-11-29T13:23:22Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":167765,"stargazers_count":2527,"watchers_count":2527,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":642,"open_issues":90,"watchers":2527,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"68145e16de2cbcd4b9268259992912953f88d6a3","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-11-29T13:20:34Z","pushed_at":"2018-11-29T13:23:22Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":167765,"stargazers_count":2527,"watchers_count":2527,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":642,"open_issues":90,"watchers":2527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/4293"},"html":{"href":"https://github.com/corda/corda/pull/4293"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/4293"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/4293/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/4293/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/4293/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/d2c005bebbc0cc883e91195bd3c25de1f6c27cb2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adagys"}}