{"action":"created","issue":{"url":"https://api.github.com/repos/Lafudoci/moneriote-python/issues/1","repository_url":"https://api.github.com/repos/Lafudoci/moneriote-python","labels_url":"https://api.github.com/repos/Lafudoci/moneriote-python/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Lafudoci/moneriote-python/issues/1/comments","events_url":"https://api.github.com/repos/Lafudoci/moneriote-python/issues/1/events","html_url":"https://github.com/Lafudoci/moneriote-python/issues/1","id":356603770,"node_id":"MDU6SXNzdWUzNTY2MDM3NzA=","number":1,"title":"Some questions","user":{"login":"skftn","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/skftn","html_url":"https://github.com/skftn","followers_url":"https://api.github.com/users/skftn/followers","following_url":"https://api.github.com/users/skftn/following{/other_user}","gists_url":"https://api.github.com/users/skftn/gists{/gist_id}","starred_url":"https://api.github.com/users/skftn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skftn/subscriptions","organizations_url":"https://api.github.com/users/skftn/orgs","repos_url":"https://api.github.com/users/skftn/repos","events_url":"https://api.github.com/users/skftn/events{/privacy}","received_events_url":"https://api.github.com/users/skftn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-03T21:48:12Z","updated_at":"2018-09-03T21:58:06Z","closed_at":null,"author_association":"NONE","body":"Some questions:\r\n\r\n#### 1. Unknown commands\r\nhttps://github.com/Lafudoci/moneriote-python/blob/5d1a271d5b08a6c35c582e16f98038883e07a778/moneriote.py#L121-L130\r\n\r\nThis opens `monerod` with the rpc server enabled, esentially doing:\r\n```\r\n./monerod --rpc-bind-ip 127.0.0.1 --rpc-bind-port 1337 print_pl\r\n```\r\n\r\nBut `print_pl` is not an argument. `monerod` will error with `Unknown command: print_pl`. I fail to understand how this ever worked?\r\n\r\n#### 2. Process cleanup\r\n\r\nhttps://github.com/Lafudoci/moneriote-python/blob/5d1a271d5b08a6c35c582e16f98038883e07a778/moneriote.py#L119-L143\r\n\r\nWhy is the process not killed/cleaned up afterwards?\r\n\r\n#### 3. RPC\r\n\r\nWhy is the RPC started when we're not using the RPC at all? `print_pl` is a `monerod` command, not a RPC method."},"comment":{"url":"https://api.github.com/repos/Lafudoci/moneriote-python/issues/comments/418197842","html_url":"https://github.com/Lafudoci/moneriote-python/issues/1#issuecomment-418197842","issue_url":"https://api.github.com/repos/Lafudoci/moneriote-python/issues/1","id":418197842,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODE5Nzg0Mg==","user":{"login":"skftn","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/skftn","html_url":"https://github.com/skftn","followers_url":"https://api.github.com/users/skftn/followers","following_url":"https://api.github.com/users/skftn/following{/other_user}","gists_url":"https://api.github.com/users/skftn/gists{/gist_id}","starred_url":"https://api.github.com/users/skftn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skftn/subscriptions","organizations_url":"https://api.github.com/users/skftn/orgs","repos_url":"https://api.github.com/users/skftn/repos","events_url":"https://api.github.com/users/skftn/events{/privacy}","received_events_url":"https://api.github.com/users/skftn/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T21:58:06Z","updated_at":"2018-09-03T21:58:06Z","author_association":"NONE","body":"I see this code is taken from https://github.com/connorw600/moneriote/blob/opennodes-python/start.py "}}
{"actor":{"display_login":"skftn"}}