{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/173783036","pull_request_review_id":103026470,"id":173783036,"diff_hunk":"@@ -74,10 +82,15 @@ public function __construct(MigrationRepositoryInterface $repository,\n      *\n      * @param  array|string  $paths\n      * @param  array  $options\n+     * @params Symfony\\Component\\Console\\Output\\OutputInterface $output\n      * @return array\n      */\n-    public function run($paths = [], array $options = [])\n+    public function run($paths = [], array $options = [], OutputInterface $output = null)","path":"src/Illuminate/Database/Migrations/Migrator.php","position":30,"original_position":30,"commit_id":"f56fc32bff12850a7ec752d915004149f5e888a2","original_commit_id":"f56fc32bff12850a7ec752d915004149f5e888a2","user":{"login":"mohamed-aiman","id":14019247,"avatar_url":"https://avatars2.githubusercontent.com/u/14019247?v=4","gravatar_id":"","url":"https://api.github.com/users/mohamed-aiman","html_url":"https://github.com/mohamed-aiman","followers_url":"https://api.github.com/users/mohamed-aiman/followers","following_url":"https://api.github.com/users/mohamed-aiman/following{/other_user}","gists_url":"https://api.github.com/users/mohamed-aiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mohamed-aiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohamed-aiman/subscriptions","organizations_url":"https://api.github.com/users/mohamed-aiman/orgs","repos_url":"https://api.github.com/users/mohamed-aiman/repos","events_url":"https://api.github.com/users/mohamed-aiman/events{/privacy}","received_events_url":"https://api.github.com/users/mohamed-aiman/received_events","type":"User","site_admin":false},"body":"existing installations doesn't break with these changes and the end result is same. Anyways third parameter is nullable and it would work same as before if the third parameter is not passed.","created_at":"2018-03-12T12:46:29Z","updated_at":"2018-03-12T12:46:29Z","html_url":"https://github.com/laravel/framework/pull/23497#discussion_r173783036","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/23497","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/173783036"},"html":{"href":"https://github.com/laravel/framework/pull/23497#discussion_r173783036"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/23497"}},"in_reply_to_id":173700093},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/23497","id":174236769,"html_url":"https://github.com/laravel/framework/pull/23497","diff_url":"https://github.com/laravel/framework/pull/23497.diff","patch_url":"https://github.com/laravel/framework/pull/23497.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/23497","number":23497,"state":"open","locked":false,"title":"[5.6] Features/database migrator print realtime","user":{"login":"mohamed-aiman","id":14019247,"avatar_url":"https://avatars2.githubusercontent.com/u/14019247?v=4","gravatar_id":"","url":"https://api.github.com/users/mohamed-aiman","html_url":"https://github.com/mohamed-aiman","followers_url":"https://api.github.com/users/mohamed-aiman/followers","following_url":"https://api.github.com/users/mohamed-aiman/following{/other_user}","gists_url":"https://api.github.com/users/mohamed-aiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mohamed-aiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohamed-aiman/subscriptions","organizations_url":"https://api.github.com/users/mohamed-aiman/orgs","repos_url":"https://api.github.com/users/mohamed-aiman/repos","events_url":"https://api.github.com/users/mohamed-aiman/events{/privacy}","received_events_url":"https://api.github.com/users/mohamed-aiman/received_events","type":"User","site_admin":false},"body":"Database Migrator modified to print action outputs to the terminal as soon as each process is finished.\r\nAdditionally, now that we are passing the OutputInterface of the callee to the migrator we will be able to use the Migrator independently or in other words, we can call from within other commands and expect the output to be printed to the terminal.","created_at":"2018-03-11T19:09:25Z","updated_at":"2018-03-12T12:46:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b608cceeb90884d795def88eb01ac01790771998","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/23497/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/23497/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/23497/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/f56fc32bff12850a7ec752d915004149f5e888a2","head":{"label":"mohamed-aiman:features/database-migrator-print-realtime","ref":"features/database-migrator-print-realtime","sha":"f56fc32bff12850a7ec752d915004149f5e888a2","user":{"login":"mohamed-aiman","id":14019247,"avatar_url":"https://avatars2.githubusercontent.com/u/14019247?v=4","gravatar_id":"","url":"https://api.github.com/users/mohamed-aiman","html_url":"https://github.com/mohamed-aiman","followers_url":"https://api.github.com/users/mohamed-aiman/followers","following_url":"https://api.github.com/users/mohamed-aiman/following{/other_user}","gists_url":"https://api.github.com/users/mohamed-aiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mohamed-aiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohamed-aiman/subscriptions","organizations_url":"https://api.github.com/users/mohamed-aiman/orgs","repos_url":"https://api.github.com/users/mohamed-aiman/repos","events_url":"https://api.github.com/users/mohamed-aiman/events{/privacy}","received_events_url":"https://api.github.com/users/mohamed-aiman/received_events","type":"User","site_admin":false},"repo":{"id":124594575,"name":"framework","full_name":"mohamed-aiman/framework","owner":{"login":"mohamed-aiman","id":14019247,"avatar_url":"https://avatars2.githubusercontent.com/u/14019247?v=4","gravatar_id":"","url":"https://api.github.com/users/mohamed-aiman","html_url":"https://github.com/mohamed-aiman","followers_url":"https://api.github.com/users/mohamed-aiman/followers","following_url":"https://api.github.com/users/mohamed-aiman/following{/other_user}","gists_url":"https://api.github.com/users/mohamed-aiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mohamed-aiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohamed-aiman/subscriptions","organizations_url":"https://api.github.com/users/mohamed-aiman/orgs","repos_url":"https://api.github.com/users/mohamed-aiman/repos","events_url":"https://api.github.com/users/mohamed-aiman/events{/privacy}","received_events_url":"https://api.github.com/users/mohamed-aiman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mohamed-aiman/framework","description":null,"fork":true,"url":"https://api.github.com/repos/mohamed-aiman/framework","forks_url":"https://api.github.com/repos/mohamed-aiman/framework/forks","keys_url":"https://api.github.com/repos/mohamed-aiman/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mohamed-aiman/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mohamed-aiman/framework/teams","hooks_url":"https://api.github.com/repos/mohamed-aiman/framework/hooks","issue_events_url":"https://api.github.com/repos/mohamed-aiman/framework/issues/events{/number}","events_url":"https://api.github.com/repos/mohamed-aiman/framework/events","assignees_url":"https://api.github.com/repos/mohamed-aiman/framework/assignees{/user}","branches_url":"https://api.github.com/repos/mohamed-aiman/framework/branches{/branch}","tags_url":"https://api.github.com/repos/mohamed-aiman/framework/tags","blobs_url":"https://api.github.com/repos/mohamed-aiman/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mohamed-aiman/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mohamed-aiman/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mohamed-aiman/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mohamed-aiman/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/mohamed-aiman/framework/languages","stargazers_url":"https://api.github.com/repos/mohamed-aiman/framework/stargazers","contributors_url":"https://api.github.com/repos/mohamed-aiman/framework/contributors","subscribers_url":"https://api.github.com/repos/mohamed-aiman/framework/subscribers","subscription_url":"https://api.github.com/repos/mohamed-aiman/framework/subscription","commits_url":"https://api.github.com/repos/mohamed-aiman/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mohamed-aiman/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mohamed-aiman/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mohamed-aiman/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mohamed-aiman/framework/contents/{+path}","compare_url":"https://api.github.com/repos/mohamed-aiman/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mohamed-aiman/framework/merges","archive_url":"https://api.github.com/repos/mohamed-aiman/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mohamed-aiman/framework/downloads","issues_url":"https://api.github.com/repos/mohamed-aiman/framework/issues{/number}","pulls_url":"https://api.github.com/repos/mohamed-aiman/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/mohamed-aiman/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/mohamed-aiman/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mohamed-aiman/framework/labels{/name}","releases_url":"https://api.github.com/repos/mohamed-aiman/framework/releases{/id}","deployments_url":"https://api.github.com/repos/mohamed-aiman/framework/deployments","created_at":"2018-03-09T21:21:19Z","updated_at":"2018-03-09T21:21:27Z","pushed_at":"2018-03-11T19:11:14Z","git_url":"git://github.com/mohamed-aiman/framework.git","ssh_url":"git@github.com:mohamed-aiman/framework.git","clone_url":"https://github.com/mohamed-aiman/framework.git","svn_url":"https://github.com/mohamed-aiman/framework","homepage":"http://laravel.com","size":32845,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"laravel:5.6","ref":"5.6","sha":"19080684fb06fd09cd0882e3b19f7847c660cec1","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2018-03-12T11:10:04Z","pushed_at":"2018-03-12T03:23:09Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":32854,"stargazers_count":11104,"watchers_count":11104,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5220,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5220,"open_issues":226,"watchers":11104,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/23497"},"html":{"href":"https://github.com/laravel/framework/pull/23497"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/23497"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/23497/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/23497/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/23497/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/f56fc32bff12850a7ec752d915004149f5e888a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mohamed-aiman"}}