{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/170108766","pull_request_review_id":98746487,"id":170108766,"diff_hunk":"@@ -330,9 +336,13 @@ func (u *update) Run(ctx context.Context) (ret bool) {\n \thQuit := make(chan struct{})\n \tdefer close(hQuit)\n \twatchDelay := 1 * time.Second\n-\tgo u.hcheck.WatchService(string(newFields.Manifest.ID()), hChecks, hErrs, hQuit, watchDelay)\n+\tconfig := newFields.Manifest.GetConfig()\n+\tuseHealthService, _ := config[\"use_health_service\"].(bool)","path":"pkg/roll/run_update.go","position":28,"original_position":28,"commit_id":"c6d068f65ac589b3620ed818f7719095df17af37","original_commit_id":"c6d068f65ac589b3620ed818f7719095df17af37","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars3.githubusercontent.com/u/1444855?v=4","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"body":"ah okay, I'm just out of the loop","created_at":"2018-02-22T22:07:17Z","updated_at":"2018-02-22T22:07:17Z","html_url":"https://github.com/square/p2/pull/1011#discussion_r170108766","pull_request_url":"https://api.github.com/repos/square/p2/pulls/1011","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/170108766"},"html":{"href":"https://github.com/square/p2/pull/1011#discussion_r170108766"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/1011"}},"in_reply_to_id":170069878},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/1011","id":165844731,"html_url":"https://github.com/square/p2/pull/1011","diff_url":"https://github.com/square/p2/pull/1011.diff","patch_url":"https://github.com/square/p2/pull/1011.patch","issue_url":"https://api.github.com/repos/square/p2/issues/1011","number":1011,"state":"open","locked":false,"title":"use new health service with rolling updates","user":{"login":"esuen","id":343604,"avatar_url":"https://avatars1.githubusercontent.com/u/343604?v=4","gravatar_id":"","url":"https://api.github.com/users/esuen","html_url":"https://github.com/esuen","followers_url":"https://api.github.com/users/esuen/followers","following_url":"https://api.github.com/users/esuen/following{/other_user}","gists_url":"https://api.github.com/users/esuen/gists{/gist_id}","starred_url":"https://api.github.com/users/esuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esuen/subscriptions","organizations_url":"https://api.github.com/users/esuen/orgs","repos_url":"https://api.github.com/users/esuen/repos","events_url":"https://api.github.com/users/esuen/events{/privacy}","received_events_url":"https://api.github.com/users/esuen/received_events","type":"User","site_admin":false},"body":"Changes required for rolling updates to use the health service client for health checks while still using the consul health tree in parallel. These changes will test reliability of health service client.\r\n- Created a separate healthChecker type in checker.go called ShadowTrafficHealthChecker that will utilize both the health service client and old consul tree checking code\r\n- Old health checker was renamed from ConsulHealthChecker to HealthChecker so that in the future when the health service client is deemed reliable we can rename ShadowTrafficHealthChecker to HealthChecker\r\n- WatchService and Service functions defined for new HealthChecker to be used by rolling updates\r\n- WatchService uses both health service client and consul health tree\r\n- Service uses either consul or health service client","created_at":"2018-01-29T23:13:46Z","updated_at":"2018-02-22T22:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bea6a9e65ae6565c98867b3ca2a7fb95c45c44b5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"spenceral","id":10701033,"avatar_url":"https://avatars2.githubusercontent.com/u/10701033?v=4","gravatar_id":"","url":"https://api.github.com/users/spenceral","html_url":"https://github.com/spenceral","followers_url":"https://api.github.com/users/spenceral/followers","following_url":"https://api.github.com/users/spenceral/following{/other_user}","gists_url":"https://api.github.com/users/spenceral/gists{/gist_id}","starred_url":"https://api.github.com/users/spenceral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spenceral/subscriptions","organizations_url":"https://api.github.com/users/spenceral/orgs","repos_url":"https://api.github.com/users/spenceral/repos","events_url":"https://api.github.com/users/spenceral/events{/privacy}","received_events_url":"https://api.github.com/users/spenceral/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/1011/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/1011/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/1011/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/c6d068f65ac589b3620ed818f7719095df17af37","head":{"label":"esuen:health-service-into-rolling-updates","ref":"health-service-into-rolling-updates","sha":"c6d068f65ac589b3620ed818f7719095df17af37","user":{"login":"esuen","id":343604,"avatar_url":"https://avatars1.githubusercontent.com/u/343604?v=4","gravatar_id":"","url":"https://api.github.com/users/esuen","html_url":"https://github.com/esuen","followers_url":"https://api.github.com/users/esuen/followers","following_url":"https://api.github.com/users/esuen/following{/other_user}","gists_url":"https://api.github.com/users/esuen/gists{/gist_id}","starred_url":"https://api.github.com/users/esuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esuen/subscriptions","organizations_url":"https://api.github.com/users/esuen/orgs","repos_url":"https://api.github.com/users/esuen/repos","events_url":"https://api.github.com/users/esuen/events{/privacy}","received_events_url":"https://api.github.com/users/esuen/received_events","type":"User","site_admin":false},"repo":{"id":113511065,"name":"p2","full_name":"esuen/p2","owner":{"login":"esuen","id":343604,"avatar_url":"https://avatars1.githubusercontent.com/u/343604?v=4","gravatar_id":"","url":"https://api.github.com/users/esuen","html_url":"https://github.com/esuen","followers_url":"https://api.github.com/users/esuen/followers","following_url":"https://api.github.com/users/esuen/following{/other_user}","gists_url":"https://api.github.com/users/esuen/gists{/gist_id}","starred_url":"https://api.github.com/users/esuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esuen/subscriptions","organizations_url":"https://api.github.com/users/esuen/orgs","repos_url":"https://api.github.com/users/esuen/repos","events_url":"https://api.github.com/users/esuen/events{/privacy}","received_events_url":"https://api.github.com/users/esuen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esuen/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/esuen/p2","forks_url":"https://api.github.com/repos/esuen/p2/forks","keys_url":"https://api.github.com/repos/esuen/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esuen/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esuen/p2/teams","hooks_url":"https://api.github.com/repos/esuen/p2/hooks","issue_events_url":"https://api.github.com/repos/esuen/p2/issues/events{/number}","events_url":"https://api.github.com/repos/esuen/p2/events","assignees_url":"https://api.github.com/repos/esuen/p2/assignees{/user}","branches_url":"https://api.github.com/repos/esuen/p2/branches{/branch}","tags_url":"https://api.github.com/repos/esuen/p2/tags","blobs_url":"https://api.github.com/repos/esuen/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esuen/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esuen/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/esuen/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esuen/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/esuen/p2/languages","stargazers_url":"https://api.github.com/repos/esuen/p2/stargazers","contributors_url":"https://api.github.com/repos/esuen/p2/contributors","subscribers_url":"https://api.github.com/repos/esuen/p2/subscribers","subscription_url":"https://api.github.com/repos/esuen/p2/subscription","commits_url":"https://api.github.com/repos/esuen/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/esuen/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/esuen/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/esuen/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/esuen/p2/contents/{+path}","compare_url":"https://api.github.com/repos/esuen/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esuen/p2/merges","archive_url":"https://api.github.com/repos/esuen/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esuen/p2/downloads","issues_url":"https://api.github.com/repos/esuen/p2/issues{/number}","pulls_url":"https://api.github.com/repos/esuen/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/esuen/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/esuen/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esuen/p2/labels{/name}","releases_url":"https://api.github.com/repos/esuen/p2/releases{/id}","deployments_url":"https://api.github.com/repos/esuen/p2/deployments","created_at":"2017-12-08T00:04:54Z","updated_at":"2017-12-08T00:04:57Z","pushed_at":"2018-02-22T01:51:07Z","git_url":"git://github.com/esuen/p2.git","ssh_url":"git@github.com:esuen/p2.git","clone_url":"https://github.com/esuen/p2.git","svn_url":"https://github.com/esuen/p2","homepage":"","size":50591,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"c003f466097762262b46e9f9234a6a86b6acc513","user":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","deployments_url":"https://api.github.com/repos/square/p2/deployments","created_at":"2014-10-16T20:31:12Z","updated_at":"2018-02-16T03:11:20Z","pushed_at":"2018-02-22T21:28:09Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":50567,"stargazers_count":171,"watchers_count":171,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":40,"open_issues":9,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/1011"},"html":{"href":"https://github.com/square/p2/pull/1011"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/1011"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/1011/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/1011/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/1011/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/c6d068f65ac589b3620ed818f7719095df17af37"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mpuncel"}}