{"action":"created","issue":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1596","repository_url":"https://api.github.com/repos/pyfa-org/Pyfa","labels_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1596/labels{/name}","comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1596/comments","events_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1596/events","html_url":"https://github.com/pyfa-org/Pyfa/issues/1596","id":324727158,"number":1596,"title":"Abysmal Space Environments","user":{"login":"blitzmann","id":3904767,"avatar_url":"https://avatars1.githubusercontent.com/u/3904767?v=4","gravatar_id":"","url":"https://api.github.com/users/blitzmann","html_url":"https://github.com/blitzmann","followers_url":"https://api.github.com/users/blitzmann/followers","following_url":"https://api.github.com/users/blitzmann/following{/other_user}","gists_url":"https://api.github.com/users/blitzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/blitzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blitzmann/subscriptions","organizations_url":"https://api.github.com/users/blitzmann/orgs","repos_url":"https://api.github.com/users/blitzmann/repos","events_url":"https://api.github.com/users/blitzmann/events{/privacy}","received_events_url":"https://api.github.com/users/blitzmann/received_events","type":"User","site_admin":false},"labels":[{"id":393494077,"url":"https://api.github.com/repos/pyfa-org/Pyfa/labels/In%20Progress","name":"In Progress","color":"c2e0c6","default":false},{"id":939102761,"url":"https://api.github.com/repos/pyfa-org/Pyfa/labels/expansion","name":"expansion","color":"90ed76","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-20T17:43:20Z","updated_at":"2018-05-23T05:07:50Z","closed_at":null,"author_association":"COLLABORATOR","body":"This ticket is to track current progress and notes on the environment buffs for abysmal space. Initial discussion can be found here: #1530\r\n\r\nWhat I've gathered so far: abysmal space has two main environmental effects. It has a \"system-wide\" effect, which is determined by the Filament that you use to access the space. Then you have the \"localized\" effects, which are similar to the system-wide effect, only local (AoE that is applied by navigating into the activation radius of a cloud within the abyss).\r\n\r\nThese effects, like similar effects (wormholes, incursions), are actually items that have effects and attributes that apply to the ship. The curveball here is that these effects are the same kind as command bursts. I assume it's due to the fact that you may have a system effect and a local effect applied at the same time, with one overriding the other . normal effects can't do that, but command effects can (eg: two boosters that apply both 15% and 20% boost to ship resists - the 20% one is going to be the effective bonus as it's better).\r\n\r\nAdditionally\r\n\r\n![image](https://user-images.githubusercontent.com/3904767/40281566-8269a312-5c31-11e8-8079-7a2ca0a01c2e.png)\r\n\r\nThis screen shows that this filament goes to the Plasma Firestorm system environment. However, there's actually two different items that represent this. \r\n\r\n![image](https://user-images.githubusercontent.com/3904767/40281580-be4d5afe-5c31-11e8-96bd-faf39f07c362.png)\r\n\r\nFrom my testing, the environment that is actually applied is random, and they have different stats.\r\n\r\n`infernal_weather_1`:\r\n![image](https://user-images.githubusercontent.com/3904767/40281595-f04a2adc-5c31-11e8-9796-537e05116f0f.png)\r\n\r\n`infernal_weather_2`:\r\n\r\n![image](https://user-images.githubusercontent.com/3904767/40281602-fc72f7a8-5c31-11e8-9878-443a8a6cf8d6.png)\r\n\r\n(there's also a `infernal_weather_3`, I'm not 100% sure what this is yet and haven't looked into it. it's group `1882` (\"MassiveEnvironments\") whereas the others are group `1975` (\"Non-Interactable Object\"), I assume this is used for the more advances and difficult spaces)\r\n\r\nSo this needs to be kept in mind to allow the user to select which config they wish. Still not sure how to really do this other than give them and \"config 1\" and \"config 2\" :/\r\n\r\nI have a branch that I'm currently working on for this feature: https://github.com/pyfa-org/Pyfa/tree/abysmal_weather\r\n\r\nSome of the couple unknowns right now is the fact that these effects aren't in a single invgroup. They're actually scattered around quite a bit throughout multiple groups. This makes it a bit difficult getting these for display in the system projector. I'm still going to need to work this out a bit.\r\n\r\nThe working idea is that I can take the filaments and look up the item based on it's Environment attribute. From there (I think), I can get the different config items for that environment... Hopefully."},"comment":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/comments/391221798","html_url":"https://github.com/pyfa-org/Pyfa/issues/1596#issuecomment-391221798","issue_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1596","id":391221798,"user":{"login":"blitzmann","id":3904767,"avatar_url":"https://avatars1.githubusercontent.com/u/3904767?v=4","gravatar_id":"","url":"https://api.github.com/users/blitzmann","html_url":"https://github.com/blitzmann","followers_url":"https://api.github.com/users/blitzmann/followers","following_url":"https://api.github.com/users/blitzmann/following{/other_user}","gists_url":"https://api.github.com/users/blitzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/blitzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blitzmann/subscriptions","organizations_url":"https://api.github.com/users/blitzmann/orgs","repos_url":"https://api.github.com/users/blitzmann/repos","events_url":"https://api.github.com/users/blitzmann/events{/privacy}","received_events_url":"https://api.github.com/users/blitzmann/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T05:07:50Z","updated_at":"2018-05-23T05:07:50Z","author_association":"COLLABORATOR","body":"Messed with the context menu tonight, looks like this now:\r\n\r\n![image](https://user-images.githubusercontent.com/3904767/40404252-d3632136-5e24-11e8-9e6c-6452074bfcb3.png)\r\n\r\nHad to implement a hardcoded mapping from environment to effects since that information isn't in the data. :/"}}
{"actor":{"display_login":"blitzmann"}}