{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/issues/40","repository_url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt","labels_url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/issues/40/comments","events_url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/issues/40/events","html_url":"https://github.com/openshift/cluster-api-provider-libvirt/pull/40","id":367447323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODgwMTM0","number":40,"title":"Initialize rand.Seed to generate random MAC addresses","user":{"login":"ingvagabund","id":8055242,"node_id":"MDQ6VXNlcjgwNTUyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8055242?v=4","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"labels":[{"id":1040170021,"node_id":"MDU6TGFiZWwxMDQwMTcwMDIx","url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1040165507,"node_id":"MDU6TGFiZWwxMDQwMTY1NTA3","url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1040167061,"node_id":"MDU6TGFiZWwxMDQwMTY3MDYx","url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"assignees":[{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-06T11:05:42Z","updated_at":"2018-10-08T08:36:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/pulls/40","html_url":"https://github.com/openshift/cluster-api-provider-libvirt/pull/40","diff_url":"https://github.com/openshift/cluster-api-provider-libvirt/pull/40.diff","patch_url":"https://github.com/openshift/cluster-api-provider-libvirt/pull/40.patch"},"body":"Once build, the actuator always generate the same MAC address for all machines.\r\n\r\nThus, the seed needs to be set to a value that produces different random sequence no matter when the MAC address is generated.\r\n\r\nBased on https://stackoverflow.com/questions/12321133/golang-random-number-generator-how-to-seed-properly"},"comment":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/issues/comments/427757891","html_url":"https://github.com/openshift/cluster-api-provider-libvirt/pull/40#issuecomment-427757891","issue_url":"https://api.github.com/repos/openshift/cluster-api-provider-libvirt/issues/40","id":427757891,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzc1Nzg5MQ==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T08:36:07Z","updated_at":"2018-10-08T08:36:07Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/openshift/cluster-api-provider-libvirt/pull/40#issuecomment-427757857\" title=\"LGTM\">enxebre</a>*, *<a href=\"https://github.com/openshift/cluster-api-provider-libvirt/pull/40#\" title=\"Author self-approved\">ingvagabund</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)~~ [enxebre,ingvagabund]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}