{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/18990","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/18990/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18990/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/18990/events","html_url":"https://github.com/nodejs/node/pull/18990","id":300065013,"number":18990,"title":"process: doc-only deprecate non-string env value","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":491152610,"url":"https://api.github.com/repos/nodejs/node/labels/notable-change","name":"notable-change","color":"f9d0c4","default":false},{"id":207521371,"url":"https://api.github.com/repos/nodejs/node/labels/process","name":"process","color":"00aaff","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-25T21:51:36Z","updated_at":"2018-03-07T18:44:24Z","closed_at":"2018-03-07T18:44:24Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18990","html_url":"https://github.com/nodejs/node/pull/18990","diff_url":"https://github.com/nodejs/node/pull/18990.diff","patch_url":"https://github.com/nodejs/node/pull/18990.patch"},"body":"This PR provides an alternative approach to #18158 by deprecating the problematic behavior of `process.env` when a non-string is assigned to a property. I would like this deprecation to become Runtime in Node.js v11.\r\n\r\nRefs: https://github.com/nodejs/node/pull/15089\r\nRefs: https://github.com/nodejs/node/pull/18158\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nprocess"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/371241300","html_url":"https://github.com/nodejs/node/pull/18990#issuecomment-371241300","issue_url":"https://api.github.com/repos/nodejs/node/issues/18990","id":371241300,"user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T18:44:24Z","updated_at":"2018-03-07T18:44:24Z","author_association":"MEMBER","body":"Landed in 5826fe4e79e96fe5ba47ec349790af107b9d10bb."}}
{"actor":{"display_login":"TimothyGu"}}