{"action":"created","comment":{"url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/comments/223575412","pull_request_review_id":162733877,"id":223575412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzU3NTQxMg==","diff_hunk":"@@ -172,49 +172,23 @@ bool Executive::call(CallParameters const& _p, u256 const& _gasPrice, Address co\n     }\n \n     m_savepoint = m_s.savepoint();\n-    /*\n-        if (m_sealEngine.isPrecompiled(_p.codeAddress, m_envInfo.number()))\n-        {\n-            bigint g = m_sealEngine.costOfPrecompiled(_p.codeAddress, _p.data, m_envInfo.number());\n-            if (_p.gas < g)\n-            {\n-                m_excepted = TransactionException::OutOfGasBase;\n-                // Bail from exception.\n-\n-                // Empty precompiled contracts need to be deleted even in case of OOG\n-                // because the bug in both Geth and Parity led to deleting RIPEMD precompiled in\n-       this\n-                // case see\n-                //\n-       https://github.com/ethereum/go-ethereum/pull/3341/files#diff-2433aa143ee4772026454b8abd76b9dd\n-                // We mark the account as touched here, so that is can be removed among other\n-       touched\n-                // empty accounts (after tx finalization)\n-                // if (m_envInfo.number() >= m_sealEngine.chainParams().EIP158ForkBlock)\n-                m_s.addBalance(_p.codeAddress, 0);\n-\n-                return true;  // true actually means \"all finished - nothing more to be done\n-       regarding\n-                              // go().\n-            }\n-            else\n-            {\n-                m_gas = (u256)(_p.gas - g);\n-                bytes output;\n-                bool success;\n-                tie(success, output) =\n-                    m_sealEngine.executePrecompiled(_p.codeAddress, _p.data, m_envInfo.number());\n-                size_t outputSize = output.size();\n-                m_output = owning_bytes_ref{std::move(output), 0, outputSize};\n-                if (!success)\n-                {\n-                    m_gas = 0;\n-                    m_excepted = TransactionException::OutOfGas;\n-                    return true;  // true means no need to run go().\n-                }\n-            }\n-        }\n-        else//*/\n+    /* if (m_envInfo.precompiledEngine()->isOrginPrecompiled(_p.codeAddress))","path":"libexecutivecontext/Executive.cpp","position":47,"original_position":47,"commit_id":"dea90fc138fde51777637b89f5254eecf3972949","original_commit_id":"942bf5573edd7d7df9b02bc1664c42ab5d7bbe5a","user":{"login":"mingzhenliu","id":26218813,"node_id":"MDQ6VXNlcjI2MjE4ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/26218813?v=4","gravatar_id":"","url":"https://api.github.com/users/mingzhenliu","html_url":"https://github.com/mingzhenliu","followers_url":"https://api.github.com/users/mingzhenliu/followers","following_url":"https://api.github.com/users/mingzhenliu/following{/other_user}","gists_url":"https://api.github.com/users/mingzhenliu/gists{/gist_id}","starred_url":"https://api.github.com/users/mingzhenliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingzhenliu/subscriptions","organizations_url":"https://api.github.com/users/mingzhenliu/orgs","repos_url":"https://api.github.com/users/mingzhenliu/repos","events_url":"https://api.github.com/users/mingzhenliu/events{/privacy}","received_events_url":"https://api.github.com/users/mingzhenliu/received_events","type":"User","site_admin":false},"body":"\r\nWill be implemented later","created_at":"2018-10-09T06:38:05Z","updated_at":"2018-10-09T06:38:05Z","html_url":"https://github.com/FISCO-BCOS/lab-bcos/pull/78#discussion_r223575412","pull_request_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/comments/223575412"},"html":{"href":"https://github.com/FISCO-BCOS/lab-bcos/pull/78#discussion_r223575412"},"pull_request":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78"}},"in_reply_to_id":221526947},"pull_request":{"url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78","id":219139300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTM5MzAw","html_url":"https://github.com/FISCO-BCOS/lab-bcos/pull/78","diff_url":"https://github.com/FISCO-BCOS/lab-bcos/pull/78.diff","patch_url":"https://github.com/FISCO-BCOS/lab-bcos/pull/78.patch","issue_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues/78","number":78,"state":"open","locked":false,"title":"add PrecompiledError","user":{"login":"mingzhenliu","id":26218813,"node_id":"MDQ6VXNlcjI2MjE4ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/26218813?v=4","gravatar_id":"","url":"https://api.github.com/users/mingzhenliu","html_url":"https://github.com/mingzhenliu","followers_url":"https://api.github.com/users/mingzhenliu/followers","following_url":"https://api.github.com/users/mingzhenliu/following{/other_user}","gists_url":"https://api.github.com/users/mingzhenliu/gists{/gist_id}","starred_url":"https://api.github.com/users/mingzhenliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingzhenliu/subscriptions","organizations_url":"https://api.github.com/users/mingzhenliu/orgs","repos_url":"https://api.github.com/users/mingzhenliu/repos","events_url":"https://api.github.com/users/mingzhenliu/events{/privacy}","received_events_url":"https://api.github.com/users/mingzhenliu/received_events","type":"User","site_admin":false},"body":"1、add PrecompiledError\r\n2、change namespace\r\n3、fix bug","created_at":"2018-09-29T10:05:21Z","updated_at":"2018-10-09T06:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2949c6841261846523766cfa22f7a3aa1a7f6ef9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78/commits","review_comments_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78/comments","review_comment_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues/78/comments","statuses_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/statuses/dea90fc138fde51777637b89f5254eecf3972949","head":{"label":"mingzhenliu:dev","ref":"dev","sha":"dea90fc138fde51777637b89f5254eecf3972949","user":{"login":"mingzhenliu","id":26218813,"node_id":"MDQ6VXNlcjI2MjE4ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/26218813?v=4","gravatar_id":"","url":"https://api.github.com/users/mingzhenliu","html_url":"https://github.com/mingzhenliu","followers_url":"https://api.github.com/users/mingzhenliu/followers","following_url":"https://api.github.com/users/mingzhenliu/following{/other_user}","gists_url":"https://api.github.com/users/mingzhenliu/gists{/gist_id}","starred_url":"https://api.github.com/users/mingzhenliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingzhenliu/subscriptions","organizations_url":"https://api.github.com/users/mingzhenliu/orgs","repos_url":"https://api.github.com/users/mingzhenliu/repos","events_url":"https://api.github.com/users/mingzhenliu/events{/privacy}","received_events_url":"https://api.github.com/users/mingzhenliu/received_events","type":"User","site_admin":false},"repo":{"id":150197964,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxOTc5NjQ=","name":"lab-bcos","full_name":"mingzhenliu/lab-bcos","private":false,"owner":{"login":"mingzhenliu","id":26218813,"node_id":"MDQ6VXNlcjI2MjE4ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/26218813?v=4","gravatar_id":"","url":"https://api.github.com/users/mingzhenliu","html_url":"https://github.com/mingzhenliu","followers_url":"https://api.github.com/users/mingzhenliu/followers","following_url":"https://api.github.com/users/mingzhenliu/following{/other_user}","gists_url":"https://api.github.com/users/mingzhenliu/gists{/gist_id}","starred_url":"https://api.github.com/users/mingzhenliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingzhenliu/subscriptions","organizations_url":"https://api.github.com/users/mingzhenliu/orgs","repos_url":"https://api.github.com/users/mingzhenliu/repos","events_url":"https://api.github.com/users/mingzhenliu/events{/privacy}","received_events_url":"https://api.github.com/users/mingzhenliu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mingzhenliu/lab-bcos","description":"A lab version of fisco bcos for research","fork":true,"url":"https://api.github.com/repos/mingzhenliu/lab-bcos","forks_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/forks","keys_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/teams","hooks_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/hooks","issue_events_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/issues/events{/number}","events_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/events","assignees_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/assignees{/user}","branches_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/branches{/branch}","tags_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/tags","blobs_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/languages","stargazers_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/stargazers","contributors_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/contributors","subscribers_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/subscribers","subscription_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/subscription","commits_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/contents/{+path}","compare_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/merges","archive_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/downloads","issues_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/issues{/number}","pulls_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/labels{/name}","releases_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/releases{/id}","deployments_url":"https://api.github.com/repos/mingzhenliu/lab-bcos/deployments","created_at":"2018-09-25T02:44:37Z","updated_at":"2018-09-29T03:15:34Z","pushed_at":"2018-10-09T01:37:58Z","git_url":"git://github.com/mingzhenliu/lab-bcos.git","ssh_url":"git@github.com:mingzhenliu/lab-bcos.git","clone_url":"https://github.com/mingzhenliu/lab-bcos.git","svn_url":"https://github.com/mingzhenliu/lab-bcos","homepage":null,"size":95725,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FISCO-BCOS:dev","ref":"dev","sha":"f6d9fb595b492a14e65646cced50d1ea3db467bf","user":{"login":"FISCO-BCOS","id":33925507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTI1NTA3","avatar_url":"https://avatars2.githubusercontent.com/u/33925507?v=4","gravatar_id":"","url":"https://api.github.com/users/FISCO-BCOS","html_url":"https://github.com/FISCO-BCOS","followers_url":"https://api.github.com/users/FISCO-BCOS/followers","following_url":"https://api.github.com/users/FISCO-BCOS/following{/other_user}","gists_url":"https://api.github.com/users/FISCO-BCOS/gists{/gist_id}","starred_url":"https://api.github.com/users/FISCO-BCOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FISCO-BCOS/subscriptions","organizations_url":"https://api.github.com/users/FISCO-BCOS/orgs","repos_url":"https://api.github.com/users/FISCO-BCOS/repos","events_url":"https://api.github.com/users/FISCO-BCOS/events{/privacy}","received_events_url":"https://api.github.com/users/FISCO-BCOS/received_events","type":"Organization","site_admin":false},"repo":{"id":145492562,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0OTI1NjI=","name":"lab-bcos","full_name":"FISCO-BCOS/lab-bcos","private":false,"owner":{"login":"FISCO-BCOS","id":33925507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTI1NTA3","avatar_url":"https://avatars2.githubusercontent.com/u/33925507?v=4","gravatar_id":"","url":"https://api.github.com/users/FISCO-BCOS","html_url":"https://github.com/FISCO-BCOS","followers_url":"https://api.github.com/users/FISCO-BCOS/followers","following_url":"https://api.github.com/users/FISCO-BCOS/following{/other_user}","gists_url":"https://api.github.com/users/FISCO-BCOS/gists{/gist_id}","starred_url":"https://api.github.com/users/FISCO-BCOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FISCO-BCOS/subscriptions","organizations_url":"https://api.github.com/users/FISCO-BCOS/orgs","repos_url":"https://api.github.com/users/FISCO-BCOS/repos","events_url":"https://api.github.com/users/FISCO-BCOS/events{/privacy}","received_events_url":"https://api.github.com/users/FISCO-BCOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FISCO-BCOS/lab-bcos","description":"A lab version of fisco bcos for research","fork":false,"url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos","forks_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/forks","keys_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/teams","hooks_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/hooks","issue_events_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues/events{/number}","events_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/events","assignees_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/assignees{/user}","branches_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/branches{/branch}","tags_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/tags","blobs_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/statuses/{sha}","languages_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/languages","stargazers_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/stargazers","contributors_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/contributors","subscribers_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/subscribers","subscription_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/subscription","commits_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/contents/{+path}","compare_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/merges","archive_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/downloads","issues_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues{/number}","pulls_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls{/number}","milestones_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/milestones{/number}","notifications_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/labels{/name}","releases_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/releases{/id}","deployments_url":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/deployments","created_at":"2018-08-21T02:01:27Z","updated_at":"2018-09-30T02:29:20Z","pushed_at":"2018-10-09T04:01:38Z","git_url":"git://github.com/FISCO-BCOS/lab-bcos.git","ssh_url":"git@github.com:FISCO-BCOS/lab-bcos.git","clone_url":"https://github.com/FISCO-BCOS/lab-bcos.git","svn_url":"https://github.com/FISCO-BCOS/lab-bcos","homepage":null,"size":95786,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":9,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78"},"html":{"href":"https://github.com/FISCO-BCOS/lab-bcos/pull/78"},"issue":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues/78"},"comments":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/FISCO-BCOS/lab-bcos/statuses/dea90fc138fde51777637b89f5254eecf3972949"}},"author_association":"NONE"}}
{"actor":{"display_login":"mingzhenliu"}}