{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/205675488","pull_request_review_id":140993342,"id":205675488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTY3NTQ4OA==","diff_hunk":"@@ -1,3 +1,12 @@\n [flake8]\n-max-line-length = 120\n-ignore = E501\n+# The following are ignored:","path":".flake8","position":4,"original_position":4,"commit_id":"53ca37fdc250e2d2f81317ca72f04249cfab9e34","original_commit_id":"53ca37fdc250e2d2f81317ca72f04249cfab9e34","user":{"login":"porridge","id":489420,"node_id":"MDQ6VXNlcjQ4OTQyMA==","avatar_url":"https://avatars2.githubusercontent.com/u/489420?v=4","gravatar_id":"","url":"https://api.github.com/users/porridge","html_url":"https://github.com/porridge","followers_url":"https://api.github.com/users/porridge/followers","following_url":"https://api.github.com/users/porridge/following{/other_user}","gists_url":"https://api.github.com/users/porridge/gists{/gist_id}","starred_url":"https://api.github.com/users/porridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porridge/subscriptions","organizations_url":"https://api.github.com/users/porridge/orgs","repos_url":"https://api.github.com/users/porridge/repos","events_url":"https://api.github.com/users/porridge/events{/privacy}","received_events_url":"https://api.github.com/users/porridge/received_events","type":"User","site_admin":false},"body":"It's not obvious right away why are these settings in `[flake8]` section but the links in comments point to `black`. Perhaps add ` to work better with \"black\"` before the colon.","created_at":"2018-07-27T06:04:00Z","updated_at":"2018-07-27T06:13:25Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/2597#discussion_r205675488","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/205675488"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2597#discussion_r205675488"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597","id":203004470,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDA0NDcw","html_url":"https://github.com/mesosphere/dcos-commons/pull/2597","diff_url":"https://github.com/mesosphere/dcos-commons/pull/2597.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/2597.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2597","number":2597,"state":"open","locked":false,"title":"Enable black formatting checks in code checks","user":{"login":"elezar","id":931393,"node_id":"MDQ6VXNlcjkzMTM5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/931393?v=4","gravatar_id":"","url":"https://api.github.com/users/elezar","html_url":"https://github.com/elezar","followers_url":"https://api.github.com/users/elezar/followers","following_url":"https://api.github.com/users/elezar/following{/other_user}","gists_url":"https://api.github.com/users/elezar/gists{/gist_id}","starred_url":"https://api.github.com/users/elezar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elezar/subscriptions","organizations_url":"https://api.github.com/users/elezar/orgs","repos_url":"https://api.github.com/users/elezar/repos","events_url":"https://api.github.com/users/elezar/events{/privacy}","received_events_url":"https://api.github.com/users/elezar/received_events","type":"User","site_admin":false},"body":"This PR updates the code checks as follows:\r\n\r\n* Adds black formatting checks (and adds the relevant flake8 config)\r\n* Moves the checks to pre-commit instead of running these in individual docker steps for better portability.\r\n\r\nTODO:\r\n- [x] Add docs on adding the pre-commit hooks\r\n- [x] Add docs on running black","created_at":"2018-07-21T10:36:14Z","updated_at":"2018-07-27T06:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c09cebb57ddbed4ce357046c91c71179a219304d","assignee":{"login":"elezar","id":931393,"node_id":"MDQ6VXNlcjkzMTM5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/931393?v=4","gravatar_id":"","url":"https://api.github.com/users/elezar","html_url":"https://github.com/elezar","followers_url":"https://api.github.com/users/elezar/followers","following_url":"https://api.github.com/users/elezar/following{/other_user}","gists_url":"https://api.github.com/users/elezar/gists{/gist_id}","starred_url":"https://api.github.com/users/elezar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elezar/subscriptions","organizations_url":"https://api.github.com/users/elezar/orgs","repos_url":"https://api.github.com/users/elezar/repos","events_url":"https://api.github.com/users/elezar/events{/privacy}","received_events_url":"https://api.github.com/users/elezar/received_events","type":"User","site_admin":false},"assignees":[{"login":"elezar","id":931393,"node_id":"MDQ6VXNlcjkzMTM5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/931393?v=4","gravatar_id":"","url":"https://api.github.com/users/elezar","html_url":"https://github.com/elezar","followers_url":"https://api.github.com/users/elezar/followers","following_url":"https://api.github.com/users/elezar/following{/other_user}","gists_url":"https://api.github.com/users/elezar/gists{/gist_id}","starred_url":"https://api.github.com/users/elezar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elezar/subscriptions","organizations_url":"https://api.github.com/users/elezar/orgs","repos_url":"https://api.github.com/users/elezar/repos","events_url":"https://api.github.com/users/elezar/events{/privacy}","received_events_url":"https://api.github.com/users/elezar/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mpereira","id":112426,"node_id":"MDQ6VXNlcjExMjQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/112426?v=4","gravatar_id":"","url":"https://api.github.com/users/mpereira","html_url":"https://github.com/mpereira","followers_url":"https://api.github.com/users/mpereira/followers","following_url":"https://api.github.com/users/mpereira/following{/other_user}","gists_url":"https://api.github.com/users/mpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/mpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpereira/subscriptions","organizations_url":"https://api.github.com/users/mpereira/orgs","repos_url":"https://api.github.com/users/mpereira/repos","events_url":"https://api.github.com/users/mpereira/events{/privacy}","received_events_url":"https://api.github.com/users/mpereira/received_events","type":"User","site_admin":false},{"login":"samvantran","id":4225547,"node_id":"MDQ6VXNlcjQyMjU1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4225547?v=4","gravatar_id":"","url":"https://api.github.com/users/samvantran","html_url":"https://github.com/samvantran","followers_url":"https://api.github.com/users/samvantran/followers","following_url":"https://api.github.com/users/samvantran/following{/other_user}","gists_url":"https://api.github.com/users/samvantran/gists{/gist_id}","starred_url":"https://api.github.com/users/samvantran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvantran/subscriptions","organizations_url":"https://api.github.com/users/samvantran/orgs","repos_url":"https://api.github.com/users/samvantran/repos","events_url":"https://api.github.com/users/samvantran/events{/privacy}","received_events_url":"https://api.github.com/users/samvantran/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":649058275,"node_id":"MDU6TGFiZWw2NDkwNTgyNzU=","url":"https://api.github.com/repos/mesosphere/dcos-commons/labels/ready%20for%20review","name":"ready for review","color":"1d76db","default":false},{"id":541307607,"node_id":"MDU6TGFiZWw1NDEzMDc2MDc=","url":"https://api.github.com/repos/mesosphere/dcos-commons/labels/tools","name":"tools","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2597/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/53ca37fdc250e2d2f81317ca72f04249cfab9e34","head":{"label":"mesosphere:enable-black-formatting","ref":"enable-black-formatting","sha":"53ca37fdc250e2d2f81317ca72f04249cfab9e34","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NjQ5Nw==","name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-07-26T23:35:39Z","pushed_at":"2018-07-27T00:52:37Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":62893,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":144,"open_issues":70,"watchers":129,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"77f8c8eed519068a3cdcd66662aa093f8bdc27ae","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NjQ5Nw==","name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-07-26T23:35:39Z","pushed_at":"2018-07-27T00:52:37Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":62893,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":144,"open_issues":70,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2597"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2597"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2597/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2597/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/53ca37fdc250e2d2f81317ca72f04249cfab9e34"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"porridge"}}