{"action":"created","issue":{"url":"https://api.github.com/repos/onivim/oni/issues/2554","repository_url":"https://api.github.com/repos/onivim/oni","labels_url":"https://api.github.com/repos/onivim/oni/issues/2554/labels{/name}","comments_url":"https://api.github.com/repos/onivim/oni/issues/2554/comments","events_url":"https://api.github.com/repos/onivim/oni/issues/2554/events","html_url":"https://github.com/onivim/oni/pull/2554","id":357765267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzAyOTgz","number":2554,"title":"Feature/add bookmarks menu","user":{"login":"Akin909","id":22454918,"node_id":"MDQ6VXNlcjIyNDU0OTE4","avatar_url":"https://avatars2.githubusercontent.com/u/22454918?v=4","gravatar_id":"","url":"https://api.github.com/users/Akin909","html_url":"https://github.com/Akin909","followers_url":"https://api.github.com/users/Akin909/followers","following_url":"https://api.github.com/users/Akin909/following{/other_user}","gists_url":"https://api.github.com/users/Akin909/gists{/gist_id}","starred_url":"https://api.github.com/users/Akin909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akin909/subscriptions","organizations_url":"https://api.github.com/users/Akin909/orgs","repos_url":"https://api.github.com/users/Akin909/repos","events_url":"https://api.github.com/users/Akin909/events{/privacy}","received_events_url":"https://api.github.com/users/Akin909/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-06T18:04:00Z","updated_at":"2018-09-08T22:41:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/onivim/oni/pulls/2554","html_url":"https://github.com/onivim/oni/pull/2554","diff_url":"https://github.com/onivim/oni/pull/2554.diff","patch_url":"https://github.com/onivim/oni/pull/2554.patch"},"body":"This is largely inspired by perusing @CrossR's dotfiles a while ago and by the fact that FZF broke for me recently 😆, it uses the `oni.bookmarks` to generate a menu with submenus the idea being, the first menu represents the contents of `oni.bookmarks` e.g.\r\n```ts\r\n// folders are relative to the home directory or a users configured `oni.bookmarks.baseDirectory`\r\n\r\n\"oni.bookmarks\": [\".dotfiles\", \"Desktop/stuff\"]\r\n ```\r\nThe first menu will have two items, hitting enter on any will go into the directory and render its content of files and folders, this can be repeated over and over *for folders*, if a user selects a file it will open it.\r\n\r\nThere is also a command (`oni.bookmarks.setFolderOrOpenFile`)  that can be bound to set *a folder* to the active workspace so if a user e.g. was currently on `.dotfiles/vim` and hit the bound key it would make the folder the active workspace."},"comment":{"url":"https://api.github.com/repos/onivim/oni/issues/comments/419677541","html_url":"https://github.com/onivim/oni/pull/2554#issuecomment-419677541","issue_url":"https://api.github.com/repos/onivim/oni/issues/2554","id":419677541,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTY3NzU0MQ==","user":{"login":"Akin909","id":22454918,"node_id":"MDQ6VXNlcjIyNDU0OTE4","avatar_url":"https://avatars2.githubusercontent.com/u/22454918?v=4","gravatar_id":"","url":"https://api.github.com/users/Akin909","html_url":"https://github.com/Akin909","followers_url":"https://api.github.com/users/Akin909/followers","following_url":"https://api.github.com/users/Akin909/following{/other_user}","gists_url":"https://api.github.com/users/Akin909/gists{/gist_id}","starred_url":"https://api.github.com/users/Akin909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akin909/subscriptions","organizations_url":"https://api.github.com/users/Akin909/orgs","repos_url":"https://api.github.com/users/Akin909/repos","events_url":"https://api.github.com/users/Akin909/events{/privacy}","received_events_url":"https://api.github.com/users/Akin909/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T22:41:29Z","updated_at":"2018-09-08T22:41:29Z","author_association":"COLLABORATOR","body":"Had a look and seems I've definitely done a bit of duplication 🤣 I'll switch to using our implementation in `quickopen` but seems it needs some beefing up anyway so not a complete loss"}}
{"actor":{"display_login":"Akin909"}}