{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/229471136","pull_request_review_id":169981341,"id":229471136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ3MTEzNg==","diff_hunk":"@@ -1007,23 +1026,64 @@ void HGCalGeomParameters::loadWaferHexagon8(HGCalParameters& php) {\n \t++lpos;\n #ifdef EDM_ML_DEBUG\n \tindtypes.emplace_back(kndx);\n+\tint  corners[6];","path":"Geometry/HGCalCommonData/src/HGCalGeomParameters.cc","position":103,"original_position":103,"commit_id":"cbe4e2d80fc4f169b73ce1cc8bd202c49e3b8390","original_commit_id":"cbe4e2d80fc4f169b73ce1cc8bd202c49e3b8390","user":{"login":"cvuosalo","id":5736159,"node_id":"MDQ6VXNlcjU3MzYxNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5736159?v=4","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"body":"It looks to me like the size of \"corners\" should be HGCalParameters::k_CornerSize, because that value governs the limit of the index \"k\". If HGCalParameters::k_CornerSize is ever greater than 6, this code will overwrite memory when compiled for debugging.","created_at":"2018-10-30T20:21:57Z","updated_at":"2018-10-30T20:21:58Z","html_url":"https://github.com/cms-sw/cmssw/pull/25021#discussion_r229471136","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/229471136"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/25021#discussion_r229471136"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021","id":226114757,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTE0NzU3","html_url":"https://github.com/cms-sw/cmssw/pull/25021","diff_url":"https://github.com/cms-sw/cmssw/pull/25021.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25021.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25021","number":25021,"state":"open","locked":false,"title":"Phase2-hgx166 Bug fix to geometry and provision to mask parts of virtual wafer","user":{"login":"bsunanda","id":5033146,"node_id":"MDQ6VXNlcjUwMzMxNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/5033146?v=4","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"body":"Defines triangular, pentagonal and half wafers ","created_at":"2018-10-26T14:17:37Z","updated_at":"2018-10-30T20:21:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57cfa962291c339caeaf1a8f261a27a2937ed22f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"node_id":"MDU6TGFiZWw4ODY0NTQ3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52881721,"node_id":"MDU6TGFiZWw1Mjg4MTcyMQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131195,"node_id":"MDU6TGFiZWw1NjEzMTE5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false},{"id":530723804,"node_id":"MDU6TGFiZWw1MzA3MjM4MDQ=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-approved","name":"upgrade-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78","html_url":"https://github.com/cms-sw/cmssw/milestone/78","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78/labels","id":3727036,"node_id":"MDk6TWlsZXN0b25lMzcyNzAzNg==","number":78,"title":"CMSSW_10_4_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":151,"state":"open","created_at":"2018-10-10T09:27:21Z","updated_at":"2018-10-30T18:52:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25021/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/cbe4e2d80fc4f169b73ce1cc8bd202c49e3b8390","head":{"label":"bsunanda:Phase2-hgx166","ref":"Phase2-hgx166","sha":"cbe4e2d80fc4f169b73ce1cc8bd202c49e3b8390","user":{"login":"bsunanda","id":5033146,"node_id":"MDQ6VXNlcjUwMzMxNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/5033146?v=4","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"repo":{"id":11500018,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwMDAxOA==","name":"cmssw","full_name":"bsunanda/cmssw","private":false,"owner":{"login":"bsunanda","id":5033146,"node_id":"MDQ6VXNlcjUwMzMxNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/5033146?v=4","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bsunanda/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/bsunanda/cmssw","forks_url":"https://api.github.com/repos/bsunanda/cmssw/forks","keys_url":"https://api.github.com/repos/bsunanda/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsunanda/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsunanda/cmssw/teams","hooks_url":"https://api.github.com/repos/bsunanda/cmssw/hooks","issue_events_url":"https://api.github.com/repos/bsunanda/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/bsunanda/cmssw/events","assignees_url":"https://api.github.com/repos/bsunanda/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/bsunanda/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/bsunanda/cmssw/tags","blobs_url":"https://api.github.com/repos/bsunanda/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsunanda/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsunanda/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsunanda/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsunanda/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/bsunanda/cmssw/languages","stargazers_url":"https://api.github.com/repos/bsunanda/cmssw/stargazers","contributors_url":"https://api.github.com/repos/bsunanda/cmssw/contributors","subscribers_url":"https://api.github.com/repos/bsunanda/cmssw/subscribers","subscription_url":"https://api.github.com/repos/bsunanda/cmssw/subscription","commits_url":"https://api.github.com/repos/bsunanda/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsunanda/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsunanda/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsunanda/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsunanda/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/bsunanda/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsunanda/cmssw/merges","archive_url":"https://api.github.com/repos/bsunanda/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsunanda/cmssw/downloads","issues_url":"https://api.github.com/repos/bsunanda/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/bsunanda/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/bsunanda/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/bsunanda/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsunanda/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/bsunanda/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/bsunanda/cmssw/deployments","created_at":"2013-07-18T10:17:16Z","updated_at":"2014-06-25T09:42:43Z","pushed_at":"2018-10-30T00:34:48Z","git_url":"git://github.com/bsunanda/cmssw.git","ssh_url":"git@github.com:bsunanda/cmssw.git","clone_url":"https://github.com/bsunanda/cmssw.git","svn_url":"https://github.com/bsunanda/cmssw","homepage":"cms-sw.github.io/cmssw","size":1007948,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"b6fe21ab697250140fd51b545db3451219a5b7b5","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","private":false,"owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-10-30T17:27:42Z","pushed_at":"2018-10-30T18:52:01Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1034908,"stargazers_count":589,"watchers_count":589,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2735,"mirror_url":null,"archived":false,"open_issues_count":453,"license":null,"forks":2735,"open_issues":453,"watchers":589,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/25021"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/25021"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/25021/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25021/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/cbe4e2d80fc4f169b73ce1cc8bd202c49e3b8390"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cvuosalo"}}