{"action":"created","issue":{"url":"https://api.github.com/repos/TwinePlatform/DataPower/issues/402","repository_url":"https://api.github.com/repos/TwinePlatform/DataPower","labels_url":"https://api.github.com/repos/TwinePlatform/DataPower/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/TwinePlatform/DataPower/issues/402/comments","events_url":"https://api.github.com/repos/TwinePlatform/DataPower/issues/402/events","html_url":"https://github.com/TwinePlatform/DataPower/pull/402","id":318961007,"number":402,"title":"Config update","user":{"login":"eliascodes","id":12719553,"avatar_url":"https://avatars3.githubusercontent.com/u/12719553?v=4","gravatar_id":"","url":"https://api.github.com/users/eliascodes","html_url":"https://github.com/eliascodes","followers_url":"https://api.github.com/users/eliascodes/followers","following_url":"https://api.github.com/users/eliascodes/following{/other_user}","gists_url":"https://api.github.com/users/eliascodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eliascodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliascodes/subscriptions","organizations_url":"https://api.github.com/users/eliascodes/orgs","repos_url":"https://api.github.com/users/eliascodes/repos","events_url":"https://api.github.com/users/eliascodes/events{/privacy}","received_events_url":"https://api.github.com/users/eliascodes/received_events","type":"User","site_admin":false},"labels":[{"id":705584912,"url":"https://api.github.com/repos/TwinePlatform/DataPower/labels/awaiting-review","name":"awaiting-review","color":"f39c12","default":false}],"state":"open","locked":false,"assignee":{"login":"astroash","id":14337958,"avatar_url":"https://avatars3.githubusercontent.com/u/14337958?v=4","gravatar_id":"","url":"https://api.github.com/users/astroash","html_url":"https://github.com/astroash","followers_url":"https://api.github.com/users/astroash/followers","following_url":"https://api.github.com/users/astroash/following{/other_user}","gists_url":"https://api.github.com/users/astroash/gists{/gist_id}","starred_url":"https://api.github.com/users/astroash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroash/subscriptions","organizations_url":"https://api.github.com/users/astroash/orgs","repos_url":"https://api.github.com/users/astroash/repos","events_url":"https://api.github.com/users/astroash/events{/privacy}","received_events_url":"https://api.github.com/users/astroash/received_events","type":"User","site_admin":false},"assignees":[{"login":"astroash","id":14337958,"avatar_url":"https://avatars3.githubusercontent.com/u/14337958?v=4","gravatar_id":"","url":"https://api.github.com/users/astroash","html_url":"https://github.com/astroash","followers_url":"https://api.github.com/users/astroash/followers","following_url":"https://api.github.com/users/astroash/following{/other_user}","gists_url":"https://api.github.com/users/astroash/gists{/gist_id}","starred_url":"https://api.github.com/users/astroash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroash/subscriptions","organizations_url":"https://api.github.com/users/astroash/orgs","repos_url":"https://api.github.com/users/astroash/repos","events_url":"https://api.github.com/users/astroash/events{/privacy}","received_events_url":"https://api.github.com/users/astroash/received_events","type":"User","site_admin":false},{"login":"RogeredBacon","id":25391768,"avatar_url":"https://avatars1.githubusercontent.com/u/25391768?v=4","gravatar_id":"","url":"https://api.github.com/users/RogeredBacon","html_url":"https://github.com/RogeredBacon","followers_url":"https://api.github.com/users/RogeredBacon/followers","following_url":"https://api.github.com/users/RogeredBacon/following{/other_user}","gists_url":"https://api.github.com/users/RogeredBacon/gists{/gist_id}","starred_url":"https://api.github.com/users/RogeredBacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RogeredBacon/subscriptions","organizations_url":"https://api.github.com/users/RogeredBacon/orgs","repos_url":"https://api.github.com/users/RogeredBacon/repos","events_url":"https://api.github.com/users/RogeredBacon/events{/privacy}","received_events_url":"https://api.github.com/users/RogeredBacon/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/TwinePlatform/DataPower/milestones/8","html_url":"https://github.com/TwinePlatform/DataPower/milestone/8","labels_url":"https://api.github.com/repos/TwinePlatform/DataPower/milestones/8/labels","id":3252090,"number":8,"title":"Phase 4","description":"","creator":{"login":"eliascodes","id":12719553,"avatar_url":"https://avatars3.githubusercontent.com/u/12719553?v=4","gravatar_id":"","url":"https://api.github.com/users/eliascodes","html_url":"https://github.com/eliascodes","followers_url":"https://api.github.com/users/eliascodes/followers","following_url":"https://api.github.com/users/eliascodes/following{/other_user}","gists_url":"https://api.github.com/users/eliascodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eliascodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliascodes/subscriptions","organizations_url":"https://api.github.com/users/eliascodes/orgs","repos_url":"https://api.github.com/users/eliascodes/repos","events_url":"https://api.github.com/users/eliascodes/events{/privacy}","received_events_url":"https://api.github.com/users/eliascodes/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":25,"state":"open","created_at":"2018-04-09T10:55:16Z","updated_at":"2018-04-30T16:57:22Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-04-30T16:57:21Z","updated_at":"2018-04-30T17:25:38Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/TwinePlatform/DataPower/pulls/402","html_url":"https://github.com/TwinePlatform/DataPower/pull/402","diff_url":"https://github.com/TwinePlatform/DataPower/pull/402.diff","patch_url":"https://github.com/TwinePlatform/DataPower/pull/402.patch"},"body":"**MERGE #397 FIRST**\r\n\r\nFixes #400 \r\n\r\n#### Changes\r\n* Use environment constants instead of hardcoded strings\r\n* Standardise the strings to `development`, `testing` and `production` instead of abbreviated `dev`, `test`, `prod`.\r\n\r\n\r\n#### Checklist\r\n##### Updating Existing Features\r\n* [x] Have I manually tested my changes?\r\n* [x] Have I added/removed/updated the test suite for this feature appropriately?\r\n"},"comment":{"url":"https://api.github.com/repos/TwinePlatform/DataPower/issues/comments/385468694","html_url":"https://github.com/TwinePlatform/DataPower/pull/402#issuecomment-385468694","issue_url":"https://api.github.com/repos/TwinePlatform/DataPower/issues/402","id":385468694,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T17:25:38Z","updated_at":"2018-04-30T17:25:38Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=h1) Report\n> Merging [#402](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=desc) into [master](https://codecov.io/gh/TwinePlatform/DataPower/commit/596ad86978022586f6a5e7b3404b006d38013922?src=pr&el=desc) will **increase** coverage by `1.75%`.\n> The diff coverage is `89.47%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/graphs/tree.svg?token=gp81qEmrUf&src=pr&width=650&height=150)](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #402      +/-   ##\n==========================================\n+ Coverage   81.49%   83.24%   +1.75%     \n==========================================\n  Files          78       79       +1     \n  Lines         989      997       +8     \n==========================================\n+ Hits          806      830      +24     \n+ Misses        183      167      -16\n```\n\n\n| [Impacted Files](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [server/routes/qr\\_user\\_send.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-c2VydmVyL3JvdXRlcy9xcl91c2VyX3NlbmQuanM=) | `43.75% <0%> (ø)` | :arrow_up: |\n| [server/routes/user\\_details.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-c2VydmVyL3JvdXRlcy91c2VyX2RldGFpbHMuanM=) | `62.5% <0%> (ø)` | :arrow_up: |\n| [config/config.schema.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZy5zY2hlbWEuanM=) | `100% <100%> (ø)` | :arrow_up: |\n| [server/shared/middleware/error.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-c2VydmVyL3NoYXJlZC9taWRkbGV3YXJlL2Vycm9yLmpz) | `55.55% <100%> (+11.8%)` | :arrow_up: |\n| [config/config.defaults.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZy5kZWZhdWx0cy5qcw==) | `100% <100%> (ø)` | :arrow_up: |\n| [config/environments.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-Y29uZmlnL2Vudmlyb25tZW50cy5qcw==) | `100% <100%> (ø)` | |\n| [server/functions/pdfgenerator.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-c2VydmVyL2Z1bmN0aW9ucy9wZGZnZW5lcmF0b3IuanM=) | `100% <100%> (+42.3%)` | :arrow_up: |\n| [config/index.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-Y29uZmlnL2luZGV4Lmpz) | `88.46% <100%> (+0.46%)` | :arrow_up: |\n| [server/functions/qr\\_send.js](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree#diff-c2VydmVyL2Z1bmN0aW9ucy9xcl9zZW5kLmpz) | `90% <0%> (ø)` | :arrow_up: |\n| ... and [2 more](https://codecov.io/gh/TwinePlatform/DataPower/pull/402/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=footer). Last update [596ad86...d5a962e](https://codecov.io/gh/TwinePlatform/DataPower/pull/402?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}