{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/220687269","pull_request_review_id":159153358,"id":220687269,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDY4NzI2OQ==","diff_hunk":"@@ -101,13 +101,13 @@ func TestHandleInterfaceEmptySuccess(t *testing.T) {\n \thandler := jsonHandler{reader: ifaceEmptyReader{}, handler: reflect.ValueOf(h)}\n \n \treqBuf := yarpc.NewBufferString(`[\"a\", \"b\", \"c\"]`)\n-\t_, _, err := handler.Handle(context.Background(), &yarpc.Request{\n+\t_, respBuf, err := handler.Handle(context.Background(), &yarpc.Request{","path":"v2/yarpcjson/inbound_test.go","position":null,"original_position":5,"commit_id":"c7580cb620c22e69a41ccc3087759eb23978e1fe","original_commit_id":"6c0d839d32d0f017b4076fea323648d413c15271","user":{"login":"AlexAPB","id":3745201,"node_id":"MDQ6VXNlcjM3NDUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3745201?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexAPB","html_url":"https://github.com/AlexAPB","followers_url":"https://api.github.com/users/AlexAPB/followers","following_url":"https://api.github.com/users/AlexAPB/following{/other_user}","gists_url":"https://api.github.com/users/AlexAPB/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAPB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAPB/subscriptions","organizations_url":"https://api.github.com/users/AlexAPB/orgs","repos_url":"https://api.github.com/users/AlexAPB/repos","events_url":"https://api.github.com/users/AlexAPB/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAPB/received_events","type":"User","site_admin":false},"body":"Updated this for consistency on `req`/`res`","created_at":"2018-09-26T19:06:46Z","updated_at":"2018-09-26T19:06:47Z","html_url":"https://github.com/yarpc/yarpc-go/pull/1574#discussion_r220687269","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/220687269"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/1574#discussion_r220687269"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574"}},"in_reply_to_id":220346439},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574","id":218107913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTA3OTEz","html_url":"https://github.com/yarpc/yarpc-go/pull/1574","diff_url":"https://github.com/yarpc/yarpc-go/pull/1574.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/1574.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/1574","number":1574,"state":"open","locked":false,"title":"[spring] Fix JSON encoding test","user":{"login":"AlexAPB","id":3745201,"node_id":"MDQ6VXNlcjM3NDUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3745201?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexAPB","html_url":"https://github.com/AlexAPB","followers_url":"https://api.github.com/users/AlexAPB/followers","following_url":"https://api.github.com/users/AlexAPB/following{/other_user}","gists_url":"https://api.github.com/users/AlexAPB/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAPB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAPB/subscriptions","organizations_url":"https://api.github.com/users/AlexAPB/orgs","repos_url":"https://api.github.com/users/AlexAPB/repos","events_url":"https://api.github.com/users/AlexAPB/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAPB/received_events","type":"User","site_admin":false},"body":"This tiny change fixes up a test from #1567.\r\n\r\nOnce this and #1573 land, the entire `spring` branch, except for\r\nthe `yarpcroundrobin` package will be buildable and testable.","created_at":"2018-09-25T20:25:15Z","updated_at":"2018-09-26T19:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6b350c41b23ba2a4527058b60cf67775ece5bcd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/1574/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/c7580cb620c22e69a41ccc3087759eb23978e1fe","head":{"label":"yarpc:apb/spring/json-fix","ref":"apb/spring/json-fix","sha":"c7580cb620c22e69a41ccc3087759eb23978e1fe","user":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"node_id":"MDEwOlJlcG9zaXRvcnk1MDM5MDExMQ==","name":"yarpc-go","full_name":"yarpc/yarpc-go","private":false,"owner":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarpc/yarpc-go","description":"A message passing platform for Go","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2018-09-26T17:43:11Z","pushed_at":"2018-09-26T19:06:31Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":11538,"stargazers_count":161,"watchers_count":161,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":17,"watchers":161,"default_branch":"dev"}},"base":{"label":"yarpc:spring","ref":"spring","sha":"fdaa6e9824c8edc8699abc84359e2736a11d3d06","user":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"node_id":"MDEwOlJlcG9zaXRvcnk1MDM5MDExMQ==","name":"yarpc-go","full_name":"yarpc/yarpc-go","private":false,"owner":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarpc/yarpc-go","description":"A message passing platform for Go","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2018-09-26T17:43:11Z","pushed_at":"2018-09-26T19:06:31Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":11538,"stargazers_count":161,"watchers_count":161,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":17,"watchers":161,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/1574"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/1574"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/1574/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1574/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-go/statuses/c7580cb620c22e69a41ccc3087759eb23978e1fe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AlexAPB"}}