{"action":"created","comment":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/comments/212706215","pull_request_review_id":149399828,"id":212706215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjcwNjIxNQ==","diff_hunk":"@@ -1370,7 +1370,7 @@ impl ChainListener for ChannelManager {\n \t\t\t\t\t\tOk(res) => res,\n \t\t\t\t\t\tErr(e) => {\n \t\t\t\t\t\t\tlog_error!(self, \"Got error handling message: {}!\", e.err);\n-\t\t\t\t\t\t\t//TODO: push e on events and blow up the channel (it has bad keys)\n+\t\t\t\t\t\t\t//TODO: handle WaitNewState or IgnoreMessage","path":"src/ln/channelmanager.rs","position":14,"original_position":14,"commit_id":"23468e086af2e048d6860209d7331284e3616c8b","original_commit_id":"23468e086af2e048d6860209d7331284e3616c8b","user":{"login":"TheBlueMatt","id":649246,"node_id":"MDQ6VXNlcjY0OTI0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"I dont think WaitNewState makes sense - maybe there's some confusion here but if you see a \"bad key\" from something the remote generated they are clearly misbehaving - if you could randomly hit bad keys on accident it'd be a sign that the underlying ECC crypto were broken, so we should treat it as any other clearly-misbehaving node.","created_at":"2018-08-24T17:52:12Z","updated_at":"2018-08-24T17:52:12Z","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/99#discussion_r212706215","pull_request_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/comments/212706215"},"html":{"href":"https://github.com/rust-bitcoin/rust-lightning/pull/99#discussion_r212706215"},"pull_request":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99"}},"in_reply_to_id":212520404},"pull_request":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99","id":204660476,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjYwNDc2","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/99","diff_url":"https://github.com/rust-bitcoin/rust-lightning/pull/99.diff","patch_url":"https://github.com/rust-bitcoin/rust-lightning/pull/99.patch","issue_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/99","number":99,"state":"open","locked":false,"title":"Implement KeyError for bad key in channel announcement process","user":{"login":"ariard","id":23310655,"node_id":"MDQ6VXNlcjIzMzEwNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/23310655?v=4","gravatar_id":"","url":"https://api.github.com/users/ariard","html_url":"https://github.com/ariard","followers_url":"https://api.github.com/users/ariard/followers","following_url":"https://api.github.com/users/ariard/following{/other_user}","gists_url":"https://api.github.com/users/ariard/gists{/gist_id}","starred_url":"https://api.github.com/users/ariard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariard/subscriptions","organizations_url":"https://api.github.com/users/ariard/orgs","repos_url":"https://api.github.com/users/ariard/repos","events_url":"https://api.github.com/users/ariard/events{/privacy}","received_events_url":"https://api.github.com/users/ariard/received_events","type":"User","site_admin":false},"body":"Implement a KeyError for case which we have a secp failure. In this case of block_connected, the error is internal so we disconnect the remote peer to avoid further interactions with a defectuous key material (maybe add a message \"Internal bad keys management\" but could incite to exploitation if we share others channels, so staying mute seems better).","created_at":"2018-07-29T20:43:11Z","updated_at":"2018-08-24T17:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ca7c726fbc4b766b6c1b2efb864b395717692b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99/commits","review_comments_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99/comments","review_comment_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/99/comments","statuses_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/statuses/23468e086af2e048d6860209d7331284e3616c8b","head":{"label":"ariard:block_connected_bad_keys","ref":"block_connected_bad_keys","sha":"23468e086af2e048d6860209d7331284e3616c8b","user":{"login":"ariard","id":23310655,"node_id":"MDQ6VXNlcjIzMzEwNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/23310655?v=4","gravatar_id":"","url":"https://api.github.com/users/ariard","html_url":"https://github.com/ariard","followers_url":"https://api.github.com/users/ariard/followers","following_url":"https://api.github.com/users/ariard/following{/other_user}","gists_url":"https://api.github.com/users/ariard/gists{/gist_id}","starred_url":"https://api.github.com/users/ariard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariard/subscriptions","organizations_url":"https://api.github.com/users/ariard/orgs","repos_url":"https://api.github.com/users/ariard/repos","events_url":"https://api.github.com/users/ariard/events{/privacy}","received_events_url":"https://api.github.com/users/ariard/received_events","type":"User","site_admin":false},"repo":{"id":128682687,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2ODI2ODc=","name":"rust-lightning","full_name":"ariard/rust-lightning","owner":{"login":"ariard","id":23310655,"node_id":"MDQ6VXNlcjIzMzEwNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/23310655?v=4","gravatar_id":"","url":"https://api.github.com/users/ariard","html_url":"https://github.com/ariard","followers_url":"https://api.github.com/users/ariard/followers","following_url":"https://api.github.com/users/ariard/following{/other_user}","gists_url":"https://api.github.com/users/ariard/gists{/gist_id}","starred_url":"https://api.github.com/users/ariard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariard/subscriptions","organizations_url":"https://api.github.com/users/ariard/orgs","repos_url":"https://api.github.com/users/ariard/repos","events_url":"https://api.github.com/users/ariard/events{/privacy}","received_events_url":"https://api.github.com/users/ariard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariard/rust-lightning","description":"Rust-Lightning, not Rusty's Lightning","fork":true,"url":"https://api.github.com/repos/ariard/rust-lightning","forks_url":"https://api.github.com/repos/ariard/rust-lightning/forks","keys_url":"https://api.github.com/repos/ariard/rust-lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariard/rust-lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariard/rust-lightning/teams","hooks_url":"https://api.github.com/repos/ariard/rust-lightning/hooks","issue_events_url":"https://api.github.com/repos/ariard/rust-lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ariard/rust-lightning/events","assignees_url":"https://api.github.com/repos/ariard/rust-lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ariard/rust-lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ariard/rust-lightning/tags","blobs_url":"https://api.github.com/repos/ariard/rust-lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariard/rust-lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariard/rust-lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariard/rust-lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariard/rust-lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ariard/rust-lightning/languages","stargazers_url":"https://api.github.com/repos/ariard/rust-lightning/stargazers","contributors_url":"https://api.github.com/repos/ariard/rust-lightning/contributors","subscribers_url":"https://api.github.com/repos/ariard/rust-lightning/subscribers","subscription_url":"https://api.github.com/repos/ariard/rust-lightning/subscription","commits_url":"https://api.github.com/repos/ariard/rust-lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariard/rust-lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariard/rust-lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariard/rust-lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariard/rust-lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ariard/rust-lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariard/rust-lightning/merges","archive_url":"https://api.github.com/repos/ariard/rust-lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariard/rust-lightning/downloads","issues_url":"https://api.github.com/repos/ariard/rust-lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ariard/rust-lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ariard/rust-lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ariard/rust-lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariard/rust-lightning/labels{/name}","releases_url":"https://api.github.com/repos/ariard/rust-lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ariard/rust-lightning/deployments","created_at":"2018-04-08T21:17:27Z","updated_at":"2018-08-17T01:48:16Z","pushed_at":"2018-08-24T04:39:44Z","git_url":"git://github.com/ariard/rust-lightning.git","ssh_url":"git@github.com:ariard/rust-lightning.git","clone_url":"https://github.com/ariard/rust-lightning.git","svn_url":"https://github.com/ariard/rust-lightning","homepage":null,"size":853,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-bitcoin:master","ref":"master","sha":"a66e597e958584b7fbfff8f5891d656010cd58fa","user":{"login":"rust-bitcoin","id":37084147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/37084147?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-bitcoin","html_url":"https://github.com/rust-bitcoin","followers_url":"https://api.github.com/users/rust-bitcoin/followers","following_url":"https://api.github.com/users/rust-bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/rust-bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-bitcoin/subscriptions","organizations_url":"https://api.github.com/users/rust-bitcoin/orgs","repos_url":"https://api.github.com/users/rust-bitcoin/repos","events_url":"https://api.github.com/users/rust-bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/rust-bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":121809370,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4MDkzNzA=","name":"rust-lightning","full_name":"rust-bitcoin/rust-lightning","owner":{"login":"rust-bitcoin","id":37084147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg0MTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/37084147?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-bitcoin","html_url":"https://github.com/rust-bitcoin","followers_url":"https://api.github.com/users/rust-bitcoin/followers","following_url":"https://api.github.com/users/rust-bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/rust-bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-bitcoin/subscriptions","organizations_url":"https://api.github.com/users/rust-bitcoin/orgs","repos_url":"https://api.github.com/users/rust-bitcoin/repos","events_url":"https://api.github.com/users/rust-bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/rust-bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-bitcoin/rust-lightning","description":"Rust-Lightning, not Rusty's Lightning","fork":false,"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning","forks_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/forks","keys_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/teams","hooks_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/hooks","issue_events_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/events{/number}","events_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/events","assignees_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/assignees{/user}","branches_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/branches{/branch}","tags_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/tags","blobs_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/languages","stargazers_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/stargazers","contributors_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/contributors","subscribers_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/subscribers","subscription_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/subscription","commits_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/contents/{+path}","compare_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/merges","archive_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/downloads","issues_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues{/number}","pulls_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/labels{/name}","releases_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/releases{/id}","deployments_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/deployments","created_at":"2018-02-16T22:50:53Z","updated_at":"2018-08-24T11:49:16Z","pushed_at":"2018-08-24T04:39:45Z","git_url":"git://github.com/rust-bitcoin/rust-lightning.git","ssh_url":"git@github.com:rust-bitcoin/rust-lightning.git","clone_url":"https://github.com/rust-bitcoin/rust-lightning.git","svn_url":"https://github.com/rust-bitcoin/rust-lightning","homepage":null,"size":977,"stargazers_count":116,"watchers_count":116,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":19,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99"},"html":{"href":"https://github.com/rust-bitcoin/rust-lightning/pull/99"},"issue":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/99"},"comments":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/rust-bitcoin/rust-lightning/statuses/23468e086af2e048d6860209d7331284e3616c8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TheBlueMatt"}}