{"action":"created","issue":{"url":"https://api.github.com/repos/auth0/docs/issues/6426","repository_url":"https://api.github.com/repos/auth0/docs","labels_url":"https://api.github.com/repos/auth0/docs/issues/6426/labels{/name}","comments_url":"https://api.github.com/repos/auth0/docs/issues/6426/comments","events_url":"https://api.github.com/repos/auth0/docs/issues/6426/events","html_url":"https://github.com/auth0/docs/pull/6426","id":344537201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTA5MzQz","number":6426,"title":"Quickstarts / Webapp / Node-js: Merge profile and user login + general improvements","user":{"login":"albertoperdomo","id":24216,"node_id":"MDQ6VXNlcjI0MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/24216?v=4","gravatar_id":"","url":"https://api.github.com/users/albertoperdomo","html_url":"https://github.com/albertoperdomo","followers_url":"https://api.github.com/users/albertoperdomo/followers","following_url":"https://api.github.com/users/albertoperdomo/following{/other_user}","gists_url":"https://api.github.com/users/albertoperdomo/gists{/gist_id}","starred_url":"https://api.github.com/users/albertoperdomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertoperdomo/subscriptions","organizations_url":"https://api.github.com/users/albertoperdomo/orgs","repos_url":"https://api.github.com/users/albertoperdomo/repos","events_url":"https://api.github.com/users/albertoperdomo/events{/privacy}","received_events_url":"https://api.github.com/users/albertoperdomo/received_events","type":"User","site_admin":false},"labels":[{"id":418359580,"node_id":"MDU6TGFiZWw0MTgzNTk1ODA=","url":"https://api.github.com/repos/auth0/docs/labels/quickstart","name":"quickstart","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-25T17:29:25Z","updated_at":"2018-08-07T19:52:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/auth0/docs/pulls/6426","html_url":"https://github.com/auth0/docs/pull/6426","diff_url":"https://github.com/auth0/docs/pull/6426.diff","patch_url":"https://github.com/auth0/docs/pull/6426.patch"},"body":"* Merge user profile and login into one single step\r\n* Explain which middleware modules need to be installed and what they are used for\r\n* Remove unnecessary code\r\n* Explain how `ensureLoggedIn` middleware is used\r\n* Clean up includes\r\n"},"comment":{"url":"https://api.github.com/repos/auth0/docs/issues/comments/411180594","html_url":"https://github.com/auth0/docs/pull/6426#issuecomment-411180594","issue_url":"https://api.github.com/repos/auth0/docs/issues/6426","id":411180594,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTE4MDU5NA==","user":{"login":"albertoperdomo","id":24216,"node_id":"MDQ6VXNlcjI0MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/24216?v=4","gravatar_id":"","url":"https://api.github.com/users/albertoperdomo","html_url":"https://github.com/albertoperdomo","followers_url":"https://api.github.com/users/albertoperdomo/followers","following_url":"https://api.github.com/users/albertoperdomo/following{/other_user}","gists_url":"https://api.github.com/users/albertoperdomo/gists{/gist_id}","starred_url":"https://api.github.com/users/albertoperdomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertoperdomo/subscriptions","organizations_url":"https://api.github.com/users/albertoperdomo/orgs","repos_url":"https://api.github.com/users/albertoperdomo/repos","events_url":"https://api.github.com/users/albertoperdomo/events{/privacy}","received_events_url":"https://api.github.com/users/albertoperdomo/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T19:52:59Z","updated_at":"2018-08-07T19:52:59Z","author_association":"CONTRIBUTOR","body":">>### Install and load the Dependencies\r\n>I think \"dependencies\" should go in lowercase\r\n\r\nThe capital letter came from the title in the Rails Quickstart, which I just copied.\r\nThere, titles are capitalized. For now it seems that it is inconsistent, so don't know how much effort to put into that.\r\n\r\n>Maybe 'install and instantiate' instead of Load? 'install and configure'?\r\nWill go for _Install the Dependencies_, which is accurate and shorter.\r\n\r\n>we say 'an Express' middleware and then 'a middleware'. We should use the same term in both.\r\nI am not experienced with Node.js. I know that `express-session` is a middleware specific to the `Express` framework. With `connect-ensure-login`, the description states is a middleware, so I am not sure if this would be usable with other Node.js frameworks?\r\n\r\nI think I'll address it by removing the mention of Express. It will still work and it will be consistent.\r\n\r\n>Maybe this comment can be above the clientSecret line\r\nSo, you prefer that comment in the code block, instead of in the text?\r\nExample:\r\n\r\n```\r\n//passport-auth0\r\nvar strategy = new Auth0Strategy({\r\n  domain: '${account.namespace}',\r\n  clientID: '${account.clientId}',\r\n  // Please use the client secret from the application settings in your Auth0 dashboard.\r\n  clientSecret: 'YOUR_CLIENT_SECRET',\r\n  callbackURL: 'http://localhost:3000/callback'\r\n },\r\n```\r\n\r\n>'this new router' should be 'this new route'\r\nI think in this case it's a router. It is a file defining multiple routes using the router framework.\r\nIn fact, the variable for each imported file is also named `somethingRouter`, see:\r\n\r\n```\r\nvar indexRouter = require('./routes/index');\r\nvar authRouter = require('./routes/auth');\r\n```"}}
{"actor":{"display_login":"albertoperdomo"}}