{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/231067145","pull_request_review_id":171946731,"id":231067145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA2NzE0NQ==","diff_hunk":"@@ -297,7 +297,7 @@ export interface DataFactory {\n      * @see Triple\n      * @see DefaultGraph\n      */\n-    triple<Q_In extends BaseQuad = Quad,  Q_Out extends BaseQuad = Quad>(subject: Q_In['subject'], predicate: Q_In['predicate'], object: Q_In['object']): Q_Out;\n+    triple<Q extends BaseQuad = Quad>(subject: Q['subject'], predicate: Q['predicate'], object: Q['object']): Q;","path":"types/rdf-js/index.d.ts","position":5,"original_position":5,"commit_id":"e4eeaf874062b5b13b6dab14d79a2c760b364c73","original_commit_id":"e4eeaf874062b5b13b6dab14d79a2c760b364c73","user":{"login":"rubensworks","id":440384,"node_id":"MDQ6VXNlcjQ0MDM4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/440384?v=4","gravatar_id":"","url":"https://api.github.com/users/rubensworks","html_url":"https://github.com/rubensworks","followers_url":"https://api.github.com/users/rubensworks/followers","following_url":"https://api.github.com/users/rubensworks/following{/other_user}","gists_url":"https://api.github.com/users/rubensworks/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensworks/subscriptions","organizations_url":"https://api.github.com/users/rubensworks/orgs","repos_url":"https://api.github.com/users/rubensworks/repos","events_url":"https://api.github.com/users/rubensworks/events{/privacy}","received_events_url":"https://api.github.com/users/rubensworks/received_events","type":"User","site_admin":false},"body":"> If so, what is the recommended solution?\r\n\r\nI think @DanielRosenwasser just means that `no-unnecessary-generics` should be set to true by removing the line from `tslint.json`.\r\n\r\n> We're not using it once right? We're using if for 3 arguments and the return type.\r\n\r\nIndeed, it should be fine here. But I guess there's nothing wrong in double-checking and making the compiler settings a bit more restrictive :-)","created_at":"2018-11-06T10:18:23Z","updated_at":"2018-11-06T10:18:23Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30164#discussion_r231067145","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/231067145"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30164#discussion_r231067145"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164"}},"in_reply_to_id":230132343},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164","id":227303216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzAzMjE2","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30164","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30164.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30164.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30164","number":30164,"state":"open","locked":false,"title":"rdf-js: Use single generic for I/O types of datafactory functions","user":{"login":"LaurensRietveld","id":988347,"node_id":"MDQ6VXNlcjk4ODM0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/988347?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurensRietveld","html_url":"https://github.com/LaurensRietveld","followers_url":"https://api.github.com/users/LaurensRietveld/followers","following_url":"https://api.github.com/users/LaurensRietveld/following{/other_user}","gists_url":"https://api.github.com/users/LaurensRietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurensRietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurensRietveld/subscriptions","organizations_url":"https://api.github.com/users/LaurensRietveld/orgs","repos_url":"https://api.github.com/users/LaurensRietveld/repos","events_url":"https://api.github.com/users/LaurensRietveld/events{/privacy}","received_events_url":"https://api.github.com/users/LaurensRietveld/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [X] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [X] Test the change in your own code. (Compile and run.)\r\n- [X] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [X] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [X] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [X] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [X] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29836#issuecomment-434702390\r\n- [X] Increase the version number in the header if appropriate.\r\n- [X] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-10-31T14:17:16Z","updated_at":"2018-11-06T10:18:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fde8688f4821735c9a466d6d2637e476210bfc3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":798737478,"node_id":"MDU6TGFiZWw3OTg3Mzc0Nzg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Author%20is%20Owner","name":"Author is Owner","color":"6fede0","default":false},{"id":644095236,"node_id":"MDU6TGFiZWw2NDQwOTUyMzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:Express","name":"Merge:Express","color":"00AA00","default":false},{"id":905334095,"node_id":"MDU6TGFiZWw5MDUzMzQwOTU=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Owner%20Approved","name":"Owner Approved","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30164/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/e4eeaf874062b5b13b6dab14d79a2c760b364c73","head":{"label":"LaurensRietveld:rdfjs-single-generic","ref":"rdfjs-single-generic","sha":"e4eeaf874062b5b13b6dab14d79a2c760b364c73","user":{"login":"LaurensRietveld","id":988347,"node_id":"MDQ6VXNlcjk4ODM0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/988347?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurensRietveld","html_url":"https://github.com/LaurensRietveld","followers_url":"https://api.github.com/users/LaurensRietveld/followers","following_url":"https://api.github.com/users/LaurensRietveld/following{/other_user}","gists_url":"https://api.github.com/users/LaurensRietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurensRietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurensRietveld/subscriptions","organizations_url":"https://api.github.com/users/LaurensRietveld/orgs","repos_url":"https://api.github.com/users/LaurensRietveld/repos","events_url":"https://api.github.com/users/LaurensRietveld/events{/privacy}","received_events_url":"https://api.github.com/users/LaurensRietveld/received_events","type":"User","site_admin":false},"repo":{"id":53040296,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA0MDI5Ng==","name":"DefinitelyTyped","full_name":"LaurensRietveld/DefinitelyTyped","private":false,"owner":{"login":"LaurensRietveld","id":988347,"node_id":"MDQ6VXNlcjk4ODM0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/988347?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurensRietveld","html_url":"https://github.com/LaurensRietveld","followers_url":"https://api.github.com/users/LaurensRietveld/followers","following_url":"https://api.github.com/users/LaurensRietveld/following{/other_user}","gists_url":"https://api.github.com/users/LaurensRietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurensRietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurensRietveld/subscriptions","organizations_url":"https://api.github.com/users/LaurensRietveld/orgs","repos_url":"https://api.github.com/users/LaurensRietveld/repos","events_url":"https://api.github.com/users/LaurensRietveld/events{/privacy}","received_events_url":"https://api.github.com/users/LaurensRietveld/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LaurensRietveld/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped","forks_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/LaurensRietveld/DefinitelyTyped/deployments","created_at":"2016-03-03T10:03:36Z","updated_at":"2018-11-06T10:01:19Z","pushed_at":"2018-11-06T10:00:40Z","git_url":"git://github.com/LaurensRietveld/DefinitelyTyped.git","ssh_url":"git@github.com:LaurensRietveld/DefinitelyTyped.git","clone_url":"https://github.com/LaurensRietveld/DefinitelyTyped.git","svn_url":"https://github.com/LaurensRietveld/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":365113,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"3db545b2e2ec38fc3f6dce1dc8fcd5f386b864e6","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-11-06T08:24:44Z","pushed_at":"2018-11-06T10:09:12Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":377537,"stargazers_count":18361,"watchers_count":18361,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15246,"mirror_url":null,"archived":false,"open_issues_count":2477,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15246,"open_issues":2477,"watchers":18361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30164"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30164"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30164/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30164/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/e4eeaf874062b5b13b6dab14d79a2c760b364c73"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rubensworks"}}