{"action":"created","issue":{"url":"https://api.github.com/repos/askmike/gekko/issues/1968","repository_url":"https://api.github.com/repos/askmike/gekko","labels_url":"https://api.github.com/repos/askmike/gekko/issues/1968/labels{/name}","comments_url":"https://api.github.com/repos/askmike/gekko/issues/1968/comments","events_url":"https://api.github.com/repos/askmike/gekko/issues/1968/events","html_url":"https://github.com/askmike/gekko/pull/1968","id":299945451,"number":1968,"title":"Introduce Trade Class","user":{"login":"ansonphong","id":4825055,"avatar_url":"https://avatars0.githubusercontent.com/u/4825055?v=4","gravatar_id":"","url":"https://api.github.com/users/ansonphong","html_url":"https://github.com/ansonphong","followers_url":"https://api.github.com/users/ansonphong/followers","following_url":"https://api.github.com/users/ansonphong/following{/other_user}","gists_url":"https://api.github.com/users/ansonphong/gists{/gist_id}","starred_url":"https://api.github.com/users/ansonphong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansonphong/subscriptions","organizations_url":"https://api.github.com/users/ansonphong/orgs","repos_url":"https://api.github.com/users/ansonphong/repos","events_url":"https://api.github.com/users/ansonphong/events{/privacy}","received_events_url":"https://api.github.com/users/ansonphong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-24T14:38:35Z","updated_at":"2018-03-01T14:03:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/askmike/gekko/pulls/1968","html_url":"https://github.com/askmike/gekko/pull/1968","diff_url":"https://github.com/askmike/gekko/pull/1968.diff","patch_url":"https://github.com/askmike/gekko/pull/1968.patch"},"body":"* **What kind of change does this PR introduce?** \r\nA new class that is responsible for doing a single trade.\r\nRelated to discussion in Issue https://github.com/askmike/gekko/issues/1942\r\n\r\n* **What is the current behavior?** \r\nCurrently all the trade and order functionality is mashed into the portfolio manager, making it  impossible to deploy different trade and order execution strategies, as everything is hard-coded to one specific type of trade execution which is a single limit order for the full balance amount right across from the spread.\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\nThis PR strictly breaks out the trade specific functionality (as-is) into a separate Trade class, with minimal modification and no refactoring. \r\n\r\n* **Other information**:\r\nThis is an initial proposal for the Trade class. I have tested it on the live market and it works as expected without any errors so far. I'm curious to see others kick the tires and try to shoot holes in it and see how it works in different circumstances, and see if I missed anything.\r\n\r\nThis PR is far from ideal as a final implementation, and is part of an incremental series of PRs which will see a total refactor of the `Portfolio Manager`, this `Trade` class, and the introduction of a more robust `Order` model. Refer to the Issue https://github.com/askmike/gekko/issues/1942 for further discussion.\r\n"},"comment":{"url":"https://api.github.com/repos/askmike/gekko/issues/comments/369600910","html_url":"https://github.com/askmike/gekko/pull/1968#issuecomment-369600910","issue_url":"https://api.github.com/repos/askmike/gekko/issues/1968","id":369600910,"user":{"login":"ansonphong","id":4825055,"avatar_url":"https://avatars0.githubusercontent.com/u/4825055?v=4","gravatar_id":"","url":"https://api.github.com/users/ansonphong","html_url":"https://github.com/ansonphong","followers_url":"https://api.github.com/users/ansonphong/followers","following_url":"https://api.github.com/users/ansonphong/following{/other_user}","gists_url":"https://api.github.com/users/ansonphong/gists{/gist_id}","starred_url":"https://api.github.com/users/ansonphong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansonphong/subscriptions","organizations_url":"https://api.github.com/users/ansonphong/orgs","repos_url":"https://api.github.com/users/ansonphong/repos","events_url":"https://api.github.com/users/ansonphong/events{/privacy}","received_events_url":"https://api.github.com/users/ansonphong/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T14:03:50Z","updated_at":"2018-03-01T14:03:50Z","author_association":"CONTRIBUTOR","body":"@askmike Yes, I'm open to go through a Node upgrade process whatever is required, I think it's important to be progressive with adopting new standards."}}
{"actor":{"display_login":"ansonphong"}}