{"action":"created","issue":{"url":"https://api.github.com/repos/lmfit/lmfit-py/issues/508","repository_url":"https://api.github.com/repos/lmfit/lmfit-py","labels_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/508/labels{/name}","comments_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/508/comments","events_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/508/events","html_url":"https://github.com/lmfit/lmfit-py/pull/508","id":368889551,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTU5OTk2","number":508,"title":"Small fixes","user":{"login":"newville","id":304251,"node_id":"MDQ6VXNlcjMwNDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/304251?v=4","gravatar_id":"","url":"https://api.github.com/users/newville","html_url":"https://github.com/newville","followers_url":"https://api.github.com/users/newville/followers","following_url":"https://api.github.com/users/newville/following{/other_user}","gists_url":"https://api.github.com/users/newville/gists{/gist_id}","starred_url":"https://api.github.com/users/newville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newville/subscriptions","organizations_url":"https://api.github.com/users/newville/orgs","repos_url":"https://api.github.com/users/newville/repos","events_url":"https://api.github.com/users/newville/events{/privacy}","received_events_url":"https://api.github.com/users/newville/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-10T23:06:27Z","updated_at":"2018-10-11T03:20:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/lmfit/lmfit-py/pulls/508","html_url":"https://github.com/lmfit/lmfit-py/pull/508","diff_url":"https://github.com/lmfit/lmfit-py/pull/508.diff","patch_url":"https://github.com/lmfit/lmfit-py/pull/508.patch"},"body":"replace #505, addressing a few small, unrelated but probably not-controversial issues:\r\n\r\n1. allow a model's independent variable to be an object, addressing #492. Here, lists or tuples are automatically converted to ndarrays, but other objects are not. (To be clear panda Series work without being converted). A test is added using a non-trivial object. Nothing is changed about checking for NaNs - I think we cannot detect if a users object contains or generates NaNs.\r\n\r\n2. remove nose from tests completely, and switch to pytest, addressing #504.\r\n\r\n3. make sure that ModelResult.eval() does not overwrite the userkws dict, addressing #499."},"comment":{"url":"https://api.github.com/repos/lmfit/lmfit-py/issues/comments/428806702","html_url":"https://github.com/lmfit/lmfit-py/pull/508#issuecomment-428806702","issue_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/508","id":428806702,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODgwNjcwMg==","user":{"login":"reneeotten","id":12177696,"node_id":"MDQ6VXNlcjEyMTc3Njk2","avatar_url":"https://avatars2.githubusercontent.com/u/12177696?v=4","gravatar_id":"","url":"https://api.github.com/users/reneeotten","html_url":"https://github.com/reneeotten","followers_url":"https://api.github.com/users/reneeotten/followers","following_url":"https://api.github.com/users/reneeotten/following{/other_user}","gists_url":"https://api.github.com/users/reneeotten/gists{/gist_id}","starred_url":"https://api.github.com/users/reneeotten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneeotten/subscriptions","organizations_url":"https://api.github.com/users/reneeotten/orgs","repos_url":"https://api.github.com/users/reneeotten/repos","events_url":"https://api.github.com/users/reneeotten/events{/privacy}","received_events_url":"https://api.github.com/users/reneeotten/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T03:20:27Z","updated_at":"2018-10-11T03:20:27Z","author_association":"CONTRIBUTOR","body":"I am a bit confused.. why did you force-push to ```master```? That should ideally never happen... it looks like you now lost the last commit with the changes from PR #503 (compare with the master branch in my fork: https://github.com/reneeotten/lmfit-py/commits/master).\r\n\r\nIn this PR, the last commit is also a bit weird now - it contains changes with respect to emcee from the PR that was already merged (and the commit message is a bit weird since you're actually changing np.testing.assert_raises with pytest.raises). But that's besides the point; let's figure out how to get back to the correct state of the master branch and then just merge in whatever way you feel comfortable!"}}
{"actor":{"display_login":"reneeotten"}}