{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/224619207","pull_request_review_id":164034525,"id":224619207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDYxOTIwNw==","diff_hunk":"@@ -0,0 +1,202 @@\n+const fs = require('fs-extra');\n+const models = require('../../models');\n+const fsLib = require('../../lib/fs');\n+const common = require('../../lib/common');\n+\n+const subscribers = {\n+    docName: 'subscribers',\n+    browse: {\n+        options: [\n+            'page',\n+            'limit',\n+            'fields',\n+            'filter',\n+            'order',\n+            'debug'\n+        ],\n+        permissions: true,\n+        query(frame) {\n+            return models.Subscriber.findPage(frame.options);\n+        }\n+    },\n+\n+    read: {\n+        headers: {},\n+        data: [\n+            'id',\n+            'email'\n+        ],\n+        permissions: true,\n+        query(frame) {\n+            return models.Subscriber.findOne(frame.data);\n+        }\n+    },\n+\n+    add: {\n+        statusCode: 201,\n+        headers: {},\n+        permissions: true,\n+        query(frame) {\n+            return models.Subscriber.getByEmail(frame.data.subscribers[0].email)","path":"core/server/api/v2/subscribers.js","position":40,"original_position":40,"commit_id":"7dbe477690cc9fe8afe26ea66e357b4a94dc6d74","original_commit_id":"7dbe477690cc9fe8afe26ea66e357b4a94dc6d74","user":{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"My PR #9988 now supports resource validation (currently in shared, so the structure would be for all api versions the same, but i don't think it will change soon). \r\n\r\n```\r\nvalidation\r\n  data\r\n     email\r\n        required: true\r\n```\r\n\r\nWe could also change it to\r\n\r\n```\r\nvalidation\r\n  data\r\n     subscribers.0.email\r\n        required: true\r\n```\r\n\r\nBuuut i was not sure about it. Can still change in the future, if multiple api versions have different input formats.\r\n\r\n","created_at":"2018-10-11T22:06:58Z","updated_at":"2018-10-11T22:06:59Z","html_url":"https://github.com/TryGhost/Ghost/pull/9989#discussion_r224619207","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/224619207"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9989#discussion_r224619207"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989"}}},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989","id":222196685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTk2Njg1","html_url":"https://github.com/TryGhost/Ghost/pull/9989","diff_url":"https://github.com/TryGhost/Ghost/pull/9989.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/9989.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9989","number":9989,"state":"open","locked":false,"title":"[HOLD] Added v2 controller for subscribers ","user":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"body":"refs #9866","created_at":"2018-10-11T16:11:08Z","updated_at":"2018-10-11T22:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceefca41970bd2eb96a317de2fdc31dd0aad730e","assignee":{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"assignees":[{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9989/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/7dbe477690cc9fe8afe26ea66e357b4a94dc6d74","head":{"label":"gargol:ctrl-move-subscribers","ref":"ctrl-move-subscribers","sha":"7dbe477690cc9fe8afe26ea66e357b4a94dc6d74","user":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"repo":{"id":22947893,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk0Nzg5Mw==","name":"Ghost","full_name":"gargol/Ghost","private":false,"owner":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gargol/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/gargol/Ghost","forks_url":"https://api.github.com/repos/gargol/Ghost/forks","keys_url":"https://api.github.com/repos/gargol/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gargol/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gargol/Ghost/teams","hooks_url":"https://api.github.com/repos/gargol/Ghost/hooks","issue_events_url":"https://api.github.com/repos/gargol/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/gargol/Ghost/events","assignees_url":"https://api.github.com/repos/gargol/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/gargol/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/gargol/Ghost/tags","blobs_url":"https://api.github.com/repos/gargol/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gargol/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gargol/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/gargol/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gargol/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/gargol/Ghost/languages","stargazers_url":"https://api.github.com/repos/gargol/Ghost/stargazers","contributors_url":"https://api.github.com/repos/gargol/Ghost/contributors","subscribers_url":"https://api.github.com/repos/gargol/Ghost/subscribers","subscription_url":"https://api.github.com/repos/gargol/Ghost/subscription","commits_url":"https://api.github.com/repos/gargol/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/gargol/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/gargol/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/gargol/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/gargol/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/gargol/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gargol/Ghost/merges","archive_url":"https://api.github.com/repos/gargol/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gargol/Ghost/downloads","issues_url":"https://api.github.com/repos/gargol/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/gargol/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/gargol/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/gargol/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gargol/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/gargol/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/gargol/Ghost/deployments","created_at":"2014-08-14T09:07:42Z","updated_at":"2018-10-01T17:22:27Z","pushed_at":"2018-10-11T16:36:00Z","git_url":"git://github.com/gargol/Ghost.git","ssh_url":"git@github.com:gargol/Ghost.git","clone_url":"https://github.com/gargol/Ghost.git","svn_url":"https://github.com/gargol/Ghost","homepage":"https://ghost.org","size":26934,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"df4ef18410c492bc57281bb710a4945d765b38bd","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUyOTE4","name":"Ghost","full_name":"TryGhost/Ghost","private":false,"owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TryGhost/Ghost","description":"The platform for professional publishers","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2018-10-11T18:36:01Z","pushed_at":"2018-10-11T21:55:43Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":33631,"stargazers_count":27606,"watchers_count":27606,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5927,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5927,"open_issues":150,"watchers":27606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9989"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9989"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9989/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9989/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/7dbe477690cc9fe8afe26ea66e357b4a94dc6d74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kirrg001"}}