{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jigasi/pulls/comments/213406194","pull_request_review_id":150236112,"id":213406194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzQwNjE5NA==","diff_hunk":"@@ -1332,13 +1333,26 @@ private void inviteFocus(final EntityBareJid roomIdentifier)\n             this.errorLog = errorLog;\n         }\n \n+        /**\n+         * Whether the timeout had been scheduled.\n+         * @return <tt>true</tt> if timeout had been scheduled,\n+         * <tt>false</tt> otherwise.\n+         */\n+        boolean isScheduled()\n+        {\n+            synchronized (syncRoot)\n+            {\n+                return timeoutThread != null;","path":"src/main/java/org/jitsi/jigasi/JvbConference.java","position":null,"original_position":23,"commit_id":"7714dc8415e041219a52437f572f557dacce9402","original_commit_id":"ff45bb237beecfe6cd71f5990f3cb7799451fb48","user":{"login":"damencho","id":3263098,"node_id":"MDQ6VXNlcjMyNjMwOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3263098?v=4","gravatar_id":"","url":"https://api.github.com/users/damencho","html_url":"https://github.com/damencho","followers_url":"https://api.github.com/users/damencho/followers","following_url":"https://api.github.com/users/damencho/following{/other_user}","gists_url":"https://api.github.com/users/damencho/gists{/gist_id}","starred_url":"https://api.github.com/users/damencho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damencho/subscriptions","organizations_url":"https://api.github.com/users/damencho/orgs","repos_url":"https://api.github.com/users/damencho/repos","events_url":"https://api.github.com/users/damencho/events{/privacy}","received_events_url":"https://api.github.com/users/damencho/received_events","type":"User","site_admin":false},"body":"Does it look better now?","created_at":"2018-08-28T17:34:54Z","updated_at":"2018-08-28T17:34:55Z","html_url":"https://github.com/jitsi/jigasi/pull/136#discussion_r213406194","pull_request_url":"https://api.github.com/repos/jitsi/jigasi/pulls/136","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/comments/213406194"},"html":{"href":"https://github.com/jitsi/jigasi/pull/136#discussion_r213406194"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/136"}},"in_reply_to_id":213388308},"pull_request":{"url":"https://api.github.com/repos/jitsi/jigasi/pulls/136","id":211303052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzAzMDUy","html_url":"https://github.com/jitsi/jigasi/pull/136","diff_url":"https://github.com/jitsi/jigasi/pull/136.diff","patch_url":"https://github.com/jitsi/jigasi/pull/136.patch","issue_url":"https://api.github.com/repos/jitsi/jigasi/issues/136","number":136,"state":"open","locked":false,"title":"Few improvements.","user":{"login":"damencho","id":3263098,"node_id":"MDQ6VXNlcjMyNjMwOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3263098?v=4","gravatar_id":"","url":"https://api.github.com/users/damencho","html_url":"https://github.com/damencho","followers_url":"https://api.github.com/users/damencho/followers","following_url":"https://api.github.com/users/damencho/following{/other_user}","gists_url":"https://api.github.com/users/damencho/gists{/gist_id}","starred_url":"https://api.github.com/users/damencho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damencho/subscriptions","organizations_url":"https://api.github.com/users/damencho/orgs","repos_url":"https://api.github.com/users/damencho/repos","events_url":"https://api.github.com/users/damencho/events{/privacy}","received_events_url":"https://api.github.com/users/damencho/received_events","type":"User","site_admin":false},"body":"Few fixes for exceptions I saw during testing.\r\n\r\nFixes memory leak, leaking and not disconnecting bosh connections. I still see the nginx server timeout, but it is very rear and I still see it on the muc control connection, which reconnects maybe some timing need to be tuned.\r\n\r\nI was reproducing 10-20% of the times not working transcription, moving the setConference call earlier (before answering the call) fixes it for me.\r\n\r\nSometimes I was seeing the conference to timeout, and this was because kick of the transcription participant was not detected in the code. Sometimes the listener for the kick is invoked and sometimes the participant leave one by one and we were not detecting correctly that the focus has left.","created_at":"2018-08-28T05:11:40Z","updated_at":"2018-08-28T17:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45f3a1a6535b6264d17ab1702d79e88a7a2d3ebe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jigasi/pulls/136/commits","review_comments_url":"https://api.github.com/repos/jitsi/jigasi/pulls/136/comments","review_comment_url":"https://api.github.com/repos/jitsi/jigasi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jigasi/issues/136/comments","statuses_url":"https://api.github.com/repos/jitsi/jigasi/statuses/7714dc8415e041219a52437f572f557dacce9402","head":{"label":"jitsi:impr","ref":"impr","sha":"7714dc8415e041219a52437f572f557dacce9402","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":22720188,"node_id":"MDEwOlJlcG9zaXRvcnkyMjcyMDE4OA==","name":"jigasi","full_name":"jitsi/jigasi","owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jigasi","description":"JItsi GAteway to SIP : a server-side application that links allows regular SIP clients to join JitMeet conferences hosted by Jitsi Videobridge.","fork":false,"url":"https://api.github.com/repos/jitsi/jigasi","forks_url":"https://api.github.com/repos/jitsi/jigasi/forks","keys_url":"https://api.github.com/repos/jitsi/jigasi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jigasi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jigasi/teams","hooks_url":"https://api.github.com/repos/jitsi/jigasi/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jigasi/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jigasi/events","assignees_url":"https://api.github.com/repos/jitsi/jigasi/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jigasi/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jigasi/tags","blobs_url":"https://api.github.com/repos/jitsi/jigasi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jigasi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jigasi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jigasi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jigasi/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jigasi/languages","stargazers_url":"https://api.github.com/repos/jitsi/jigasi/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jigasi/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jigasi/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jigasi/subscription","commits_url":"https://api.github.com/repos/jitsi/jigasi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jigasi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jigasi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jigasi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jigasi/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jigasi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jigasi/merges","archive_url":"https://api.github.com/repos/jitsi/jigasi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jigasi/downloads","issues_url":"https://api.github.com/repos/jitsi/jigasi/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jigasi/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jigasi/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jigasi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jigasi/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jigasi/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jigasi/deployments","created_at":"2014-08-07T12:20:09Z","updated_at":"2018-08-27T16:54:37Z","pushed_at":"2018-08-28T17:33:59Z","git_url":"git://github.com/jitsi/jigasi.git","ssh_url":"git@github.com:jitsi/jigasi.git","clone_url":"https://github.com/jitsi/jigasi.git","svn_url":"https://github.com/jitsi/jigasi","homepage":null,"size":111787,"stargazers_count":80,"watchers_count":80,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":28,"watchers":80,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"1c26db344c0ea8fb3741353ee293677923575962","user":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":22720188,"node_id":"MDEwOlJlcG9zaXRvcnkyMjcyMDE4OA==","name":"jigasi","full_name":"jitsi/jigasi","owner":{"login":"jitsi","id":3671647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzE2NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jigasi","description":"JItsi GAteway to SIP : a server-side application that links allows regular SIP clients to join JitMeet conferences hosted by Jitsi Videobridge.","fork":false,"url":"https://api.github.com/repos/jitsi/jigasi","forks_url":"https://api.github.com/repos/jitsi/jigasi/forks","keys_url":"https://api.github.com/repos/jitsi/jigasi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jigasi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jigasi/teams","hooks_url":"https://api.github.com/repos/jitsi/jigasi/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jigasi/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jigasi/events","assignees_url":"https://api.github.com/repos/jitsi/jigasi/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jigasi/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jigasi/tags","blobs_url":"https://api.github.com/repos/jitsi/jigasi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jigasi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jigasi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jigasi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jigasi/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jigasi/languages","stargazers_url":"https://api.github.com/repos/jitsi/jigasi/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jigasi/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jigasi/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jigasi/subscription","commits_url":"https://api.github.com/repos/jitsi/jigasi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jigasi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jigasi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jigasi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jigasi/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jigasi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jigasi/merges","archive_url":"https://api.github.com/repos/jitsi/jigasi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jigasi/downloads","issues_url":"https://api.github.com/repos/jitsi/jigasi/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jigasi/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jigasi/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jigasi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jigasi/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jigasi/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jigasi/deployments","created_at":"2014-08-07T12:20:09Z","updated_at":"2018-08-27T16:54:37Z","pushed_at":"2018-08-28T17:33:59Z","git_url":"git://github.com/jitsi/jigasi.git","ssh_url":"git@github.com:jitsi/jigasi.git","clone_url":"https://github.com/jitsi/jigasi.git","svn_url":"https://github.com/jitsi/jigasi","homepage":null,"size":111787,"stargazers_count":80,"watchers_count":80,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":28,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/136"},"html":{"href":"https://github.com/jitsi/jigasi/pull/136"},"issue":{"href":"https://api.github.com/repos/jitsi/jigasi/issues/136"},"comments":{"href":"https://api.github.com/repos/jitsi/jigasi/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jigasi/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jigasi/statuses/7714dc8415e041219a52437f572f557dacce9402"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"damencho"}}