{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/33417","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/33417/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/33417/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/33417/events","html_url":"https://github.com/NixOS/nixpkgs/issues/33417","id":285952279,"number":33417,"title":"EBS root volume resizing doesn't work on m5.* instances","user":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars0.githubusercontent.com/u/1148549?v=4","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"labels":[{"id":436938058,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/0.kind:%20regression","name":"0.kind: regression","color":"84b6eb","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars0.githubusercontent.com/u/1148549?v=4","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"assignees":[{"login":"edolstra","id":1148549,"avatar_url":"https://avatars0.githubusercontent.com/u/1148549?v=4","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-01-04T11:15:15Z","updated_at":"2018-03-09T22:51:48Z","closed_at":null,"author_association":"OWNER","body":"## Issue description\r\n\r\nAfter deploying a NixOS machine with\r\n```\r\n      deployment.ec2.instanceType = \"m5.large\";\r\n      deployment.ec2.ebsInitialRootDiskSize = 30;\r\n```\r\nthe root filesystem is only 2 GB:\r\n```\r\n/dev/disk/by-label/nixos  2.0G  765M  1.1G  42% /\r\n```\r\nthough the disk has the correct size:\r\n```\r\n# cat /proc/partitions \r\n...\r\n 259        0   31457280 nvme0n1\r\n 259        1    2096128 nvme0n1p1\r\n```\r\n\r\nNixOS 17.09.2356.cb751f9b1c3, AMI ID ami-d40185ad.\r\n\r\nThe probable fix is that we need to point `grow-partition.nix` at the right device. From the boot log:\r\n```\r\nJan 04 11:06:48 localhost stage-1-init: skipping unknown device type /dev/xvd[abcde]*\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/371968133","html_url":"https://github.com/NixOS/nixpkgs/issues/33417#issuecomment-371968133","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/33417","id":371968133,"user":{"login":"copumpkin","id":2623,"avatar_url":"https://avatars1.githubusercontent.com/u/2623?v=4","gravatar_id":"","url":"https://api.github.com/users/copumpkin","html_url":"https://github.com/copumpkin","followers_url":"https://api.github.com/users/copumpkin/followers","following_url":"https://api.github.com/users/copumpkin/following{/other_user}","gists_url":"https://api.github.com/users/copumpkin/gists{/gist_id}","starred_url":"https://api.github.com/users/copumpkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copumpkin/subscriptions","organizations_url":"https://api.github.com/users/copumpkin/orgs","repos_url":"https://api.github.com/users/copumpkin/repos","events_url":"https://api.github.com/users/copumpkin/events{/privacy}","received_events_url":"https://api.github.com/users/copumpkin/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T22:51:48Z","updated_at":"2018-03-09T22:51:48Z","author_association":"MEMBER","body":"@edolstra a little confused at what's going on. If I look at the code that produces the message you pasted, it's definitely wrong and needs to be updated to support the NVME devices, but also isn't responsible for resizing partitions:\r\n\r\nhttps://github.com/NixOS/nixpkgs/blob/eddf30cc93e1b778b6bc10d0eb1bb175385d034f/nixos/modules/virtualisation/amazon-image.nix#L94-L109\r\n\r\nOn the other hand, the partition resizing code seems fairly innocent:\r\n\r\nhttps://github.com/NixOS/nixpkgs/blob/eddf30cc93e1b778b6bc10d0eb1bb175385d034f/nixos/modules/system/boot/grow-partition.nix#L31-L39\r\n\r\nMeaning that it looks up the disk by label and resizes whatever that ends up being.\r\n\r\nI did also spot this other place that needs updating for grub in particular, but that doesn't seem like it would prevent disk resizing:\r\n\r\nhttps://github.com/NixOS/nixpkgs/blob/eddf30cc93e1b778b6bc10d0eb1bb175385d034f/nixos/modules/virtualisation/amazon-image.nix#L47\r\n\r\n"}}
{"actor":{"display_login":"copumpkin"}}