{"action":"created","comment":{"url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments/196917113","pull_request_review_id":130558052,"id":196917113,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkxNzExMw==","diff_hunk":"@@ -128,12 +128,12 @@ forward)\n     # PCR8 holds the hashes of the other critical components of OpenXT's boot:\n     #  openxt.cfg, the initrd and the XSM policy.\n     # If PCR8 is all 0 we were not booting with UEFI\n-    if [ \"${tpm2}\" -ne 0 ]; then\n+    if [ \"${tpm2}\" -eq 0 ]; then\n         pcr8=$(tpm2_listpcrs | grep PCR_08 | cut -f2 -d: | tr -d ' ' | tail -n1)\n         pcr17=$(tpm2_listpcrs | grep PCR_17 | cut -f2 -d: | tr -d ' ' | tail -n1)\n     else\n-        pcr8=$(grep PCR-08 ${TPM_DEV}/device/pcrs | cut -f2 -d: | tr -d ' ')\n-        pcr17=$(grep PCR-17 ${TPM_DEV}/device/pcrs | cut -f2 -d: | tr -d ' ' | tr '[:upper:]' '[:lower:]')\n+        pcr8=$(grep PCR-08 ${TPM_DEV}/pcrs | cut -f2 -d: | tr -d ' ')\n+        pcr17=$(grep PCR-17 ${TPM_DEV}/pcrs | cut -f2 -d: | tr -d ' ' | tr '[:upper:]' '[:lower:]')","path":"recipes-openxt/openxt/openxt-measuredlaunch/seal-system","position":null,"original_position":12,"commit_id":"8cc87910ff2fde8db220c70eac07631207dde6ae","original_commit_id":"8cc87910ff2fde8db220c70eac07631207dde6ae","user":{"login":"eric-ch","id":8698568,"node_id":"MDQ6VXNlcjg2OTg1Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/8698568?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-ch","html_url":"https://github.com/eric-ch","followers_url":"https://api.github.com/users/eric-ch/followers","following_url":"https://api.github.com/users/eric-ch/following{/other_user}","gists_url":"https://api.github.com/users/eric-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-ch/subscriptions","organizations_url":"https://api.github.com/users/eric-ch/orgs","repos_url":"https://api.github.com/users/eric-ch/repos","events_url":"https://api.github.com/users/eric-ch/events{/privacy}","received_events_url":"https://api.github.com/users/eric-ch/received_events","type":"User","site_admin":false},"body":"These two chunks should be PR'ed against stable-8 to fix the forward sealing. Would you mind sending a PR with that commit cherry-picked?","created_at":"2018-06-20T19:38:11Z","updated_at":"2018-06-20T19:38:12Z","html_url":"https://github.com/OpenXT/xenclient-oe/pull/890#discussion_r196917113","pull_request_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments/196917113"},"html":{"href":"https://github.com/OpenXT/xenclient-oe/pull/890#discussion_r196917113"},"pull_request":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890"}}},"pull_request":{"url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890","id":185825472,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1ODI1NDcy","html_url":"https://github.com/OpenXT/xenclient-oe/pull/890","diff_url":"https://github.com/OpenXT/xenclient-oe/pull/890.diff","patch_url":"https://github.com/OpenXT/xenclient-oe/pull/890.patch","issue_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/890","number":890,"state":"open","locked":false,"title":"OXT-1318: Launch tboot from Xen.efi","user":{"login":"tklengyel","id":3172829,"node_id":"MDQ6VXNlcjMxNzI4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3172829?v=4","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"body":"Add Xen patches to enable launching tboot from xen.efi\r\n\r\nSigned-off-by: Tamas K Lengyel <lengyelt@ainfosec.com>","created_at":"2018-05-03T20:14:19Z","updated_at":"2018-06-20T19:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47218637e933b3955ad87ba8ab17c00217eafbd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890/commits","review_comments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890/comments","review_comment_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/890/comments","statuses_url":"https://api.github.com/repos/OpenXT/xenclient-oe/statuses/8cc87910ff2fde8db220c70eac07631207dde6ae","head":{"label":"tklengyel:srtm_drtm","ref":"srtm_drtm","sha":"8cc87910ff2fde8db220c70eac07631207dde6ae","user":{"login":"tklengyel","id":3172829,"node_id":"MDQ6VXNlcjMxNzI4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3172829?v=4","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"repo":{"id":131217806,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyMTc4MDY=","name":"xenclient-oe","full_name":"tklengyel/xenclient-oe","owner":{"login":"tklengyel","id":3172829,"node_id":"MDQ6VXNlcjMxNzI4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3172829?v=4","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tklengyel/xenclient-oe","description":null,"fork":true,"url":"https://api.github.com/repos/tklengyel/xenclient-oe","forks_url":"https://api.github.com/repos/tklengyel/xenclient-oe/forks","keys_url":"https://api.github.com/repos/tklengyel/xenclient-oe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tklengyel/xenclient-oe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tklengyel/xenclient-oe/teams","hooks_url":"https://api.github.com/repos/tklengyel/xenclient-oe/hooks","issue_events_url":"https://api.github.com/repos/tklengyel/xenclient-oe/issues/events{/number}","events_url":"https://api.github.com/repos/tklengyel/xenclient-oe/events","assignees_url":"https://api.github.com/repos/tklengyel/xenclient-oe/assignees{/user}","branches_url":"https://api.github.com/repos/tklengyel/xenclient-oe/branches{/branch}","tags_url":"https://api.github.com/repos/tklengyel/xenclient-oe/tags","blobs_url":"https://api.github.com/repos/tklengyel/xenclient-oe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tklengyel/xenclient-oe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tklengyel/xenclient-oe/git/refs{/sha}","trees_url":"https://api.github.com/repos/tklengyel/xenclient-oe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tklengyel/xenclient-oe/statuses/{sha}","languages_url":"https://api.github.com/repos/tklengyel/xenclient-oe/languages","stargazers_url":"https://api.github.com/repos/tklengyel/xenclient-oe/stargazers","contributors_url":"https://api.github.com/repos/tklengyel/xenclient-oe/contributors","subscribers_url":"https://api.github.com/repos/tklengyel/xenclient-oe/subscribers","subscription_url":"https://api.github.com/repos/tklengyel/xenclient-oe/subscription","commits_url":"https://api.github.com/repos/tklengyel/xenclient-oe/commits{/sha}","git_commits_url":"https://api.github.com/repos/tklengyel/xenclient-oe/git/commits{/sha}","comments_url":"https://api.github.com/repos/tklengyel/xenclient-oe/comments{/number}","issue_comment_url":"https://api.github.com/repos/tklengyel/xenclient-oe/issues/comments{/number}","contents_url":"https://api.github.com/repos/tklengyel/xenclient-oe/contents/{+path}","compare_url":"https://api.github.com/repos/tklengyel/xenclient-oe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tklengyel/xenclient-oe/merges","archive_url":"https://api.github.com/repos/tklengyel/xenclient-oe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tklengyel/xenclient-oe/downloads","issues_url":"https://api.github.com/repos/tklengyel/xenclient-oe/issues{/number}","pulls_url":"https://api.github.com/repos/tklengyel/xenclient-oe/pulls{/number}","milestones_url":"https://api.github.com/repos/tklengyel/xenclient-oe/milestones{/number}","notifications_url":"https://api.github.com/repos/tklengyel/xenclient-oe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tklengyel/xenclient-oe/labels{/name}","releases_url":"https://api.github.com/repos/tklengyel/xenclient-oe/releases{/id}","deployments_url":"https://api.github.com/repos/tklengyel/xenclient-oe/deployments","created_at":"2018-04-26T22:39:12Z","updated_at":"2018-04-26T22:39:17Z","pushed_at":"2018-06-20T18:38:49Z","git_url":"git://github.com/tklengyel/xenclient-oe.git","ssh_url":"git@github.com:tklengyel/xenclient-oe.git","clone_url":"https://github.com/tklengyel/xenclient-oe.git","svn_url":"https://github.com/tklengyel/xenclient-oe","homepage":null,"size":12525,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenXT:master","ref":"master","sha":"e8ab0b3bc4e66c7c56a8cca2dfa7ac6ac5da2b61","user":{"login":"OpenXT","id":7283187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyODMxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7283187?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"repo":{"id":20779371,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3OTM3MQ==","name":"xenclient-oe","full_name":"OpenXT/xenclient-oe","owner":{"login":"OpenXT","id":7283187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyODMxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7283187?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenXT/xenclient-oe","description":null,"fork":false,"url":"https://api.github.com/repos/OpenXT/xenclient-oe","forks_url":"https://api.github.com/repos/OpenXT/xenclient-oe/forks","keys_url":"https://api.github.com/repos/OpenXT/xenclient-oe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenXT/xenclient-oe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenXT/xenclient-oe/teams","hooks_url":"https://api.github.com/repos/OpenXT/xenclient-oe/hooks","issue_events_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/events{/number}","events_url":"https://api.github.com/repos/OpenXT/xenclient-oe/events","assignees_url":"https://api.github.com/repos/OpenXT/xenclient-oe/assignees{/user}","branches_url":"https://api.github.com/repos/OpenXT/xenclient-oe/branches{/branch}","tags_url":"https://api.github.com/repos/OpenXT/xenclient-oe/tags","blobs_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenXT/xenclient-oe/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenXT/xenclient-oe/languages","stargazers_url":"https://api.github.com/repos/OpenXT/xenclient-oe/stargazers","contributors_url":"https://api.github.com/repos/OpenXT/xenclient-oe/contributors","subscribers_url":"https://api.github.com/repos/OpenXT/xenclient-oe/subscribers","subscription_url":"https://api.github.com/repos/OpenXT/xenclient-oe/subscription","commits_url":"https://api.github.com/repos/OpenXT/xenclient-oe/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenXT/xenclient-oe/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenXT/xenclient-oe/contents/{+path}","compare_url":"https://api.github.com/repos/OpenXT/xenclient-oe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenXT/xenclient-oe/merges","archive_url":"https://api.github.com/repos/OpenXT/xenclient-oe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenXT/xenclient-oe/downloads","issues_url":"https://api.github.com/repos/OpenXT/xenclient-oe/issues{/number}","pulls_url":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenXT/xenclient-oe/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenXT/xenclient-oe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenXT/xenclient-oe/labels{/name}","releases_url":"https://api.github.com/repos/OpenXT/xenclient-oe/releases{/id}","deployments_url":"https://api.github.com/repos/OpenXT/xenclient-oe/deployments","created_at":"2014-06-12T19:00:56Z","updated_at":"2018-06-20T13:50:56Z","pushed_at":"2018-06-20T18:38:51Z","git_url":"git://github.com/OpenXT/xenclient-oe.git","ssh_url":"git@github.com:OpenXT/xenclient-oe.git","clone_url":"https://github.com/OpenXT/xenclient-oe.git","svn_url":"https://github.com/OpenXT/xenclient-oe","homepage":null,"size":12606,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":39,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890"},"html":{"href":"https://github.com/OpenXT/xenclient-oe/pull/890"},"issue":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/890"},"comments":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/OpenXT/xenclient-oe/statuses/8cc87910ff2fde8db220c70eac07631207dde6ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eric-ch"}}