{"action":"opened","number":5458,"pull_request":{"url":"https://api.github.com/repos/handsontable/handsontable/pulls/5458","id":220728522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzI4NTIy","html_url":"https://github.com/handsontable/handsontable/pull/5458","diff_url":"https://github.com/handsontable/handsontable/pull/5458.diff","patch_url":"https://github.com/handsontable/handsontable/pull/5458.patch","issue_url":"https://api.github.com/repos/handsontable/handsontable/issues/5458","number":5458,"state":"open","locked":false,"title":"The `ColumnSorting` plugin expose common parts to the `MultiColumnSorting` plugin","user":{"login":"wszymanski","id":141330,"node_id":"MDQ6VXNlcjE0MTMzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/141330?v=4","gravatar_id":"","url":"https://api.github.com/users/wszymanski","html_url":"https://github.com/wszymanski","followers_url":"https://api.github.com/users/wszymanski/followers","following_url":"https://api.github.com/users/wszymanski/following{/other_user}","gists_url":"https://api.github.com/users/wszymanski/gists{/gist_id}","starred_url":"https://api.github.com/users/wszymanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wszymanski/subscriptions","organizations_url":"https://api.github.com/users/wszymanski/orgs","repos_url":"https://api.github.com/users/wszymanski/repos","events_url":"https://api.github.com/users/wszymanski/events{/privacy}","received_events_url":"https://api.github.com/users/wszymanski/received_events","type":"User","site_admin":false},"body":"### Context\r\nChanges made to the `ColumnSorting` plugin:\r\n\r\n- added private `pluginKey` and `mainSortComparator` properties and refactored code according to this change\r\n- added checking `pluginKey` inside `ColumnSorting` plugin for purpose of doing some actions only for the plugin, but not for inheriting classes\r\n\r\n```\r\n// Warn just from one plugin.\r\n    if (this.pluginKey === PLUGIN_KEY...\r\n```\r\n\r\n- changed comparators to be more generic, **but** using checks for both `columnSorting` and `multiColumnSorting` keys.\r\n\r\n### How has this been tested?\r\n<!--- Please describe in detail how you tested your changes (doesn't apply to translations). -->\r\nManual tests.\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature or improvement (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Additional language file or change to the existing one (translations)\r\n\r\n### Related issue(s):\r\n1. #5457 \r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project,\r\n- [ ] My change requires a change to the documentation.\r\n","created_at":"2018-10-05T14:51:52Z","updated_at":"2018-10-05T14:51:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"wszymanski","id":141330,"node_id":"MDQ6VXNlcjE0MTMzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/141330?v=4","gravatar_id":"","url":"https://api.github.com/users/wszymanski","html_url":"https://github.com/wszymanski","followers_url":"https://api.github.com/users/wszymanski/followers","following_url":"https://api.github.com/users/wszymanski/following{/other_user}","gists_url":"https://api.github.com/users/wszymanski/gists{/gist_id}","starred_url":"https://api.github.com/users/wszymanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wszymanski/subscriptions","organizations_url":"https://api.github.com/users/wszymanski/orgs","repos_url":"https://api.github.com/users/wszymanski/repos","events_url":"https://api.github.com/users/wszymanski/events{/privacy}","received_events_url":"https://api.github.com/users/wszymanski/received_events","type":"User","site_admin":false},"assignees":[{"login":"wszymanski","id":141330,"node_id":"MDQ6VXNlcjE0MTMzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/141330?v=4","gravatar_id":"","url":"https://api.github.com/users/wszymanski","html_url":"https://github.com/wszymanski","followers_url":"https://api.github.com/users/wszymanski/followers","following_url":"https://api.github.com/users/wszymanski/following{/other_user}","gists_url":"https://api.github.com/users/wszymanski/gists{/gist_id}","starred_url":"https://api.github.com/users/wszymanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wszymanski/subscriptions","organizations_url":"https://api.github.com/users/wszymanski/orgs","repos_url":"https://api.github.com/users/wszymanski/repos","events_url":"https://api.github.com/users/wszymanski/events{/privacy}","received_events_url":"https://api.github.com/users/wszymanski/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/handsontable/handsontable/milestones/104","html_url":"https://github.com/handsontable/handsontable/milestone/104","labels_url":"https://api.github.com/repos/handsontable/handsontable/milestones/104/labels","id":3462180,"node_id":"MDk6TWlsZXN0b25lMzQ2MjE4MA==","number":104,"title":"October 2018","description":"","creator":{"login":"wojciechczerniak","id":4718998,"node_id":"MDQ6VXNlcjQ3MTg5OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4718998?v=4","gravatar_id":"","url":"https://api.github.com/users/wojciechczerniak","html_url":"https://github.com/wojciechczerniak","followers_url":"https://api.github.com/users/wojciechczerniak/followers","following_url":"https://api.github.com/users/wojciechczerniak/following{/other_user}","gists_url":"https://api.github.com/users/wojciechczerniak/gists{/gist_id}","starred_url":"https://api.github.com/users/wojciechczerniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojciechczerniak/subscriptions","organizations_url":"https://api.github.com/users/wojciechczerniak/orgs","repos_url":"https://api.github.com/users/wojciechczerniak/repos","events_url":"https://api.github.com/users/wojciechczerniak/events{/privacy}","received_events_url":"https://api.github.com/users/wojciechczerniak/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":14,"state":"open","created_at":"2018-06-29T10:00:41Z","updated_at":"2018-10-05T14:51:52Z","due_on":"2018-10-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/handsontable/handsontable/pulls/5458/commits","review_comments_url":"https://api.github.com/repos/handsontable/handsontable/pulls/5458/comments","review_comment_url":"https://api.github.com/repos/handsontable/handsontable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/handsontable/handsontable/issues/5458/comments","statuses_url":"https://api.github.com/repos/handsontable/handsontable/statuses/e021be0456fde98f983c3190a24017df831990cf","head":{"label":"handsontable:feature/issue-5457","ref":"feature/issue-5457","sha":"e021be0456fde98f983c3190a24017df831990cf","user":{"login":"handsontable","id":8068250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNjgyNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"repo":{"id":1790564,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNTY0","name":"handsontable","full_name":"handsontable/handsontable","private":false,"owner":{"login":"handsontable","id":8068250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNjgyNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/handsontable/handsontable","description":"JavaScript/HTML5 UI Spreadsheet library for web apps. Available for React, Vue and Angular.","fork":false,"url":"https://api.github.com/repos/handsontable/handsontable","forks_url":"https://api.github.com/repos/handsontable/handsontable/forks","keys_url":"https://api.github.com/repos/handsontable/handsontable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/handsontable/handsontable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/handsontable/handsontable/teams","hooks_url":"https://api.github.com/repos/handsontable/handsontable/hooks","issue_events_url":"https://api.github.com/repos/handsontable/handsontable/issues/events{/number}","events_url":"https://api.github.com/repos/handsontable/handsontable/events","assignees_url":"https://api.github.com/repos/handsontable/handsontable/assignees{/user}","branches_url":"https://api.github.com/repos/handsontable/handsontable/branches{/branch}","tags_url":"https://api.github.com/repos/handsontable/handsontable/tags","blobs_url":"https://api.github.com/repos/handsontable/handsontable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/handsontable/handsontable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/handsontable/handsontable/git/refs{/sha}","trees_url":"https://api.github.com/repos/handsontable/handsontable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/handsontable/handsontable/statuses/{sha}","languages_url":"https://api.github.com/repos/handsontable/handsontable/languages","stargazers_url":"https://api.github.com/repos/handsontable/handsontable/stargazers","contributors_url":"https://api.github.com/repos/handsontable/handsontable/contributors","subscribers_url":"https://api.github.com/repos/handsontable/handsontable/subscribers","subscription_url":"https://api.github.com/repos/handsontable/handsontable/subscription","commits_url":"https://api.github.com/repos/handsontable/handsontable/commits{/sha}","git_commits_url":"https://api.github.com/repos/handsontable/handsontable/git/commits{/sha}","comments_url":"https://api.github.com/repos/handsontable/handsontable/comments{/number}","issue_comment_url":"https://api.github.com/repos/handsontable/handsontable/issues/comments{/number}","contents_url":"https://api.github.com/repos/handsontable/handsontable/contents/{+path}","compare_url":"https://api.github.com/repos/handsontable/handsontable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/handsontable/handsontable/merges","archive_url":"https://api.github.com/repos/handsontable/handsontable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/handsontable/handsontable/downloads","issues_url":"https://api.github.com/repos/handsontable/handsontable/issues{/number}","pulls_url":"https://api.github.com/repos/handsontable/handsontable/pulls{/number}","milestones_url":"https://api.github.com/repos/handsontable/handsontable/milestones{/number}","notifications_url":"https://api.github.com/repos/handsontable/handsontable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/handsontable/handsontable/labels{/name}","releases_url":"https://api.github.com/repos/handsontable/handsontable/releases{/id}","deployments_url":"https://api.github.com/repos/handsontable/handsontable/deployments","created_at":"2011-05-23T22:38:58Z","updated_at":"2018-10-05T13:53:29Z","pushed_at":"2018-10-05T14:17:58Z","git_url":"git://github.com/handsontable/handsontable.git","ssh_url":"git@github.com:handsontable/handsontable.git","clone_url":"https://github.com/handsontable/handsontable.git","svn_url":"https://github.com/handsontable/handsontable","homepage":"https://handsontable.com/examples","size":59069,"stargazers_count":10629,"watchers_count":10629,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2082,"mirror_url":null,"archived":false,"open_issues_count":538,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2082,"open_issues":538,"watchers":10629,"default_branch":"master"}},"base":{"label":"handsontable:develop","ref":"develop","sha":"a9bdde3d6bcf6a5f3159c4a76ef097f6a136bb19","user":{"login":"handsontable","id":8068250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNjgyNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"repo":{"id":1790564,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNTY0","name":"handsontable","full_name":"handsontable/handsontable","private":false,"owner":{"login":"handsontable","id":8068250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNjgyNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/handsontable/handsontable","description":"JavaScript/HTML5 UI Spreadsheet library for web apps. Available for React, Vue and Angular.","fork":false,"url":"https://api.github.com/repos/handsontable/handsontable","forks_url":"https://api.github.com/repos/handsontable/handsontable/forks","keys_url":"https://api.github.com/repos/handsontable/handsontable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/handsontable/handsontable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/handsontable/handsontable/teams","hooks_url":"https://api.github.com/repos/handsontable/handsontable/hooks","issue_events_url":"https://api.github.com/repos/handsontable/handsontable/issues/events{/number}","events_url":"https://api.github.com/repos/handsontable/handsontable/events","assignees_url":"https://api.github.com/repos/handsontable/handsontable/assignees{/user}","branches_url":"https://api.github.com/repos/handsontable/handsontable/branches{/branch}","tags_url":"https://api.github.com/repos/handsontable/handsontable/tags","blobs_url":"https://api.github.com/repos/handsontable/handsontable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/handsontable/handsontable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/handsontable/handsontable/git/refs{/sha}","trees_url":"https://api.github.com/repos/handsontable/handsontable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/handsontable/handsontable/statuses/{sha}","languages_url":"https://api.github.com/repos/handsontable/handsontable/languages","stargazers_url":"https://api.github.com/repos/handsontable/handsontable/stargazers","contributors_url":"https://api.github.com/repos/handsontable/handsontable/contributors","subscribers_url":"https://api.github.com/repos/handsontable/handsontable/subscribers","subscription_url":"https://api.github.com/repos/handsontable/handsontable/subscription","commits_url":"https://api.github.com/repos/handsontable/handsontable/commits{/sha}","git_commits_url":"https://api.github.com/repos/handsontable/handsontable/git/commits{/sha}","comments_url":"https://api.github.com/repos/handsontable/handsontable/comments{/number}","issue_comment_url":"https://api.github.com/repos/handsontable/handsontable/issues/comments{/number}","contents_url":"https://api.github.com/repos/handsontable/handsontable/contents/{+path}","compare_url":"https://api.github.com/repos/handsontable/handsontable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/handsontable/handsontable/merges","archive_url":"https://api.github.com/repos/handsontable/handsontable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/handsontable/handsontable/downloads","issues_url":"https://api.github.com/repos/handsontable/handsontable/issues{/number}","pulls_url":"https://api.github.com/repos/handsontable/handsontable/pulls{/number}","milestones_url":"https://api.github.com/repos/handsontable/handsontable/milestones{/number}","notifications_url":"https://api.github.com/repos/handsontable/handsontable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/handsontable/handsontable/labels{/name}","releases_url":"https://api.github.com/repos/handsontable/handsontable/releases{/id}","deployments_url":"https://api.github.com/repos/handsontable/handsontable/deployments","created_at":"2011-05-23T22:38:58Z","updated_at":"2018-10-05T13:53:29Z","pushed_at":"2018-10-05T14:17:58Z","git_url":"git://github.com/handsontable/handsontable.git","ssh_url":"git@github.com:handsontable/handsontable.git","clone_url":"https://github.com/handsontable/handsontable.git","svn_url":"https://github.com/handsontable/handsontable","homepage":"https://handsontable.com/examples","size":59069,"stargazers_count":10629,"watchers_count":10629,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2082,"mirror_url":null,"archived":false,"open_issues_count":538,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2082,"open_issues":538,"watchers":10629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/5458"},"html":{"href":"https://github.com/handsontable/handsontable/pull/5458"},"issue":{"href":"https://api.github.com/repos/handsontable/handsontable/issues/5458"},"comments":{"href":"https://api.github.com/repos/handsontable/handsontable/issues/5458/comments"},"review_comments":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/5458/comments"},"review_comment":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/5458/commits"},"statuses":{"href":"https://api.github.com/repos/handsontable/handsontable/statuses/e021be0456fde98f983c3190a24017df831990cf"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":62,"deletions":41,"changed_files":8}}
{"actor":{"display_login":"wszymanski"}}