{"action":"created","comment":{"url":"https://api.github.com/repos/ewasm/hera/pulls/comments/238334995","pull_request_review_id":180850560,"id":238334995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODMzNDk5NQ==","diff_hunk":"@@ -71,10 +77,16 @@ unique_ptr<WasmEngine> WavmEngine::create()\n   return unique_ptr<WasmEngine>{new WavmEngine};\n }\n \n+\n namespace wavm_host_module {\n+\n   // first the ethereum interface(s), the top of the stack is used in host functions\n   stack<WavmEthereumInterface*> interface;\n \n+  // set up for re-throwing exceptions, this is not clean, but Hera and WAVM are incompatible without some awkwardness \n+  std::exception_ptr my_exception_ptr;\n+  bool VMTrapFlag;","path":"src/wavm.cpp","position":39,"original_position":39,"commit_id":"9c58a610f43f9f4af257672d7f13666af7f16bf5","original_commit_id":"9c58a610f43f9f4af257672d7f13666af7f16bf5","user":{"login":"chfast","id":573380,"node_id":"MDQ6VXNlcjU3MzM4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/573380?v=4","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"Init to `false`.","created_at":"2018-12-03T16:17:27Z","updated_at":"2018-12-03T16:19:08Z","html_url":"https://github.com/ewasm/hera/pull/433#discussion_r238334995","pull_request_url":"https://api.github.com/repos/ewasm/hera/pulls/433","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ewasm/hera/pulls/comments/238334995"},"html":{"href":"https://github.com/ewasm/hera/pull/433#discussion_r238334995"},"pull_request":{"href":"https://api.github.com/repos/ewasm/hera/pulls/433"}}},"pull_request":{"url":"https://api.github.com/repos/ewasm/hera/pulls/433","id":220125396,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTI1Mzk2","html_url":"https://github.com/ewasm/hera/pull/433","diff_url":"https://github.com/ewasm/hera/pull/433.diff","patch_url":"https://github.com/ewasm/hera/pull/433.patch","issue_url":"https://api.github.com/repos/ewasm/hera/issues/433","number":433,"state":"open","locked":false,"title":"Wavm rethrow exceptions","user":{"login":"poemm","id":36397285,"node_id":"MDQ6VXNlcjM2Mzk3Mjg1","avatar_url":"https://avatars2.githubusercontent.com/u/36397285?v=4","gravatar_id":"","url":"https://api.github.com/users/poemm","html_url":"https://github.com/poemm","followers_url":"https://api.github.com/users/poemm/followers","following_url":"https://api.github.com/users/poemm/following{/other_user}","gists_url":"https://api.github.com/users/poemm/gists{/gist_id}","starred_url":"https://api.github.com/users/poemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poemm/subscriptions","organizations_url":"https://api.github.com/users/poemm/orgs","repos_url":"https://api.github.com/users/poemm/repos","events_url":"https://api.github.com/users/poemm/events{/privacy}","received_events_url":"https://api.github.com/users/poemm/received_events","type":"User","site_admin":false},"body":"Passes the following tests `useGas`, `getCallDataSize`, `callDataCopy`, `callDataCopy256`, `revert`, `returnPredefinedData`, `revertVeryLong`, and `returnVeryLong`.\r\n\r\nEach host function which can throw a hera exception has a try-catch to catch and record this exception, trigger a WAVM trap so that it can clean up. Once WAVM returns, we re-throw the original hera exception.\r\n\r\nDon't know if this is what you wanted. If not, I will close.","created_at":"2018-10-03T17:53:44Z","updated_at":"2018-12-03T16:19:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dcd06b375c27ed142f367120674d1715b50af6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ewasm/hera/pulls/433/commits","review_comments_url":"https://api.github.com/repos/ewasm/hera/pulls/433/comments","review_comment_url":"https://api.github.com/repos/ewasm/hera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ewasm/hera/issues/433/comments","statuses_url":"https://api.github.com/repos/ewasm/hera/statuses/9c58a610f43f9f4af257672d7f13666af7f16bf5","head":{"label":"poemm:wavm_rethrow_exceptions","ref":"wavm_rethrow_exceptions","sha":"9c58a610f43f9f4af257672d7f13666af7f16bf5","user":{"login":"poemm","id":36397285,"node_id":"MDQ6VXNlcjM2Mzk3Mjg1","avatar_url":"https://avatars2.githubusercontent.com/u/36397285?v=4","gravatar_id":"","url":"https://api.github.com/users/poemm","html_url":"https://github.com/poemm","followers_url":"https://api.github.com/users/poemm/followers","following_url":"https://api.github.com/users/poemm/following{/other_user}","gists_url":"https://api.github.com/users/poemm/gists{/gist_id}","starred_url":"https://api.github.com/users/poemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poemm/subscriptions","organizations_url":"https://api.github.com/users/poemm/orgs","repos_url":"https://api.github.com/users/poemm/repos","events_url":"https://api.github.com/users/poemm/events{/privacy}","received_events_url":"https://api.github.com/users/poemm/received_events","type":"User","site_admin":false},"repo":{"id":146809637,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4MDk2Mzc=","name":"hera","full_name":"poemm/hera","private":false,"owner":{"login":"poemm","id":36397285,"node_id":"MDQ6VXNlcjM2Mzk3Mjg1","avatar_url":"https://avatars2.githubusercontent.com/u/36397285?v=4","gravatar_id":"","url":"https://api.github.com/users/poemm","html_url":"https://github.com/poemm","followers_url":"https://api.github.com/users/poemm/followers","following_url":"https://api.github.com/users/poemm/following{/other_user}","gists_url":"https://api.github.com/users/poemm/gists{/gist_id}","starred_url":"https://api.github.com/users/poemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poemm/subscriptions","organizations_url":"https://api.github.com/users/poemm/orgs","repos_url":"https://api.github.com/users/poemm/repos","events_url":"https://api.github.com/users/poemm/events{/privacy}","received_events_url":"https://api.github.com/users/poemm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/poemm/hera","description":"Hera: ewasm virtual machine conforming to the EVMC API","fork":true,"url":"https://api.github.com/repos/poemm/hera","forks_url":"https://api.github.com/repos/poemm/hera/forks","keys_url":"https://api.github.com/repos/poemm/hera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poemm/hera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poemm/hera/teams","hooks_url":"https://api.github.com/repos/poemm/hera/hooks","issue_events_url":"https://api.github.com/repos/poemm/hera/issues/events{/number}","events_url":"https://api.github.com/repos/poemm/hera/events","assignees_url":"https://api.github.com/repos/poemm/hera/assignees{/user}","branches_url":"https://api.github.com/repos/poemm/hera/branches{/branch}","tags_url":"https://api.github.com/repos/poemm/hera/tags","blobs_url":"https://api.github.com/repos/poemm/hera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poemm/hera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poemm/hera/git/refs{/sha}","trees_url":"https://api.github.com/repos/poemm/hera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poemm/hera/statuses/{sha}","languages_url":"https://api.github.com/repos/poemm/hera/languages","stargazers_url":"https://api.github.com/repos/poemm/hera/stargazers","contributors_url":"https://api.github.com/repos/poemm/hera/contributors","subscribers_url":"https://api.github.com/repos/poemm/hera/subscribers","subscription_url":"https://api.github.com/repos/poemm/hera/subscription","commits_url":"https://api.github.com/repos/poemm/hera/commits{/sha}","git_commits_url":"https://api.github.com/repos/poemm/hera/git/commits{/sha}","comments_url":"https://api.github.com/repos/poemm/hera/comments{/number}","issue_comment_url":"https://api.github.com/repos/poemm/hera/issues/comments{/number}","contents_url":"https://api.github.com/repos/poemm/hera/contents/{+path}","compare_url":"https://api.github.com/repos/poemm/hera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poemm/hera/merges","archive_url":"https://api.github.com/repos/poemm/hera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poemm/hera/downloads","issues_url":"https://api.github.com/repos/poemm/hera/issues{/number}","pulls_url":"https://api.github.com/repos/poemm/hera/pulls{/number}","milestones_url":"https://api.github.com/repos/poemm/hera/milestones{/number}","notifications_url":"https://api.github.com/repos/poemm/hera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poemm/hera/labels{/name}","releases_url":"https://api.github.com/repos/poemm/hera/releases{/id}","deployments_url":"https://api.github.com/repos/poemm/hera/deployments","created_at":"2018-08-30T21:42:25Z","updated_at":"2018-09-28T03:57:32Z","pushed_at":"2018-12-02T23:42:05Z","git_url":"git://github.com/poemm/hera.git","ssh_url":"git@github.com:poemm/hera.git","clone_url":"https://github.com/poemm/hera.git","svn_url":"https://github.com/poemm/hera","homepage":"","size":782,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ewasm:master","ref":"master","sha":"6482478b228858c905275ffefda473ae8998d4c3","user":{"login":"ewasm","id":20602854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjAyODU0","avatar_url":"https://avatars1.githubusercontent.com/u/20602854?v=4","gravatar_id":"","url":"https://api.github.com/users/ewasm","html_url":"https://github.com/ewasm","followers_url":"https://api.github.com/users/ewasm/followers","following_url":"https://api.github.com/users/ewasm/following{/other_user}","gists_url":"https://api.github.com/users/ewasm/gists{/gist_id}","starred_url":"https://api.github.com/users/ewasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewasm/subscriptions","organizations_url":"https://api.github.com/users/ewasm/orgs","repos_url":"https://api.github.com/users/ewasm/repos","events_url":"https://api.github.com/users/ewasm/events{/privacy}","received_events_url":"https://api.github.com/users/ewasm/received_events","type":"Organization","site_admin":false},"repo":{"id":66198886,"node_id":"MDEwOlJlcG9zaXRvcnk2NjE5ODg4Ng==","name":"hera","full_name":"ewasm/hera","private":false,"owner":{"login":"ewasm","id":20602854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjAyODU0","avatar_url":"https://avatars1.githubusercontent.com/u/20602854?v=4","gravatar_id":"","url":"https://api.github.com/users/ewasm","html_url":"https://github.com/ewasm","followers_url":"https://api.github.com/users/ewasm/followers","following_url":"https://api.github.com/users/ewasm/following{/other_user}","gists_url":"https://api.github.com/users/ewasm/gists{/gist_id}","starred_url":"https://api.github.com/users/ewasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewasm/subscriptions","organizations_url":"https://api.github.com/users/ewasm/orgs","repos_url":"https://api.github.com/users/ewasm/repos","events_url":"https://api.github.com/users/ewasm/events{/privacy}","received_events_url":"https://api.github.com/users/ewasm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ewasm/hera","description":"Hera: ewasm virtual machine conforming to the EVMC API","fork":false,"url":"https://api.github.com/repos/ewasm/hera","forks_url":"https://api.github.com/repos/ewasm/hera/forks","keys_url":"https://api.github.com/repos/ewasm/hera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewasm/hera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewasm/hera/teams","hooks_url":"https://api.github.com/repos/ewasm/hera/hooks","issue_events_url":"https://api.github.com/repos/ewasm/hera/issues/events{/number}","events_url":"https://api.github.com/repos/ewasm/hera/events","assignees_url":"https://api.github.com/repos/ewasm/hera/assignees{/user}","branches_url":"https://api.github.com/repos/ewasm/hera/branches{/branch}","tags_url":"https://api.github.com/repos/ewasm/hera/tags","blobs_url":"https://api.github.com/repos/ewasm/hera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewasm/hera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewasm/hera/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewasm/hera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewasm/hera/statuses/{sha}","languages_url":"https://api.github.com/repos/ewasm/hera/languages","stargazers_url":"https://api.github.com/repos/ewasm/hera/stargazers","contributors_url":"https://api.github.com/repos/ewasm/hera/contributors","subscribers_url":"https://api.github.com/repos/ewasm/hera/subscribers","subscription_url":"https://api.github.com/repos/ewasm/hera/subscription","commits_url":"https://api.github.com/repos/ewasm/hera/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewasm/hera/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewasm/hera/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewasm/hera/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewasm/hera/contents/{+path}","compare_url":"https://api.github.com/repos/ewasm/hera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewasm/hera/merges","archive_url":"https://api.github.com/repos/ewasm/hera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewasm/hera/downloads","issues_url":"https://api.github.com/repos/ewasm/hera/issues{/number}","pulls_url":"https://api.github.com/repos/ewasm/hera/pulls{/number}","milestones_url":"https://api.github.com/repos/ewasm/hera/milestones{/number}","notifications_url":"https://api.github.com/repos/ewasm/hera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewasm/hera/labels{/name}","releases_url":"https://api.github.com/repos/ewasm/hera/releases{/id}","deployments_url":"https://api.github.com/repos/ewasm/hera/deployments","created_at":"2016-08-21T12:58:03Z","updated_at":"2018-11-29T10:59:05Z","pushed_at":"2018-12-02T23:42:07Z","git_url":"git://github.com/ewasm/hera.git","ssh_url":"git@github.com:ewasm/hera.git","clone_url":"https://github.com/ewasm/hera.git","svn_url":"https://github.com/ewasm/hera","homepage":"","size":775,"stargazers_count":89,"watchers_count":89,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":23,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ewasm/hera/pulls/433"},"html":{"href":"https://github.com/ewasm/hera/pull/433"},"issue":{"href":"https://api.github.com/repos/ewasm/hera/issues/433"},"comments":{"href":"https://api.github.com/repos/ewasm/hera/issues/433/comments"},"review_comments":{"href":"https://api.github.com/repos/ewasm/hera/pulls/433/comments"},"review_comment":{"href":"https://api.github.com/repos/ewasm/hera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ewasm/hera/pulls/433/commits"},"statuses":{"href":"https://api.github.com/repos/ewasm/hera/statuses/9c58a610f43f9f4af257672d7f13666af7f16bf5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chfast"}}