{"action":"created","comment":{"url":"https://api.github.com/repos/edx/xblock-sdk/pulls/comments/168318639","pull_request_review_id":96665039,"id":168318639,"diff_hunk":"@@ -26,17 +26,11 @@ $(SQLITE_DB): var\n \n .PHONY: test\n test:\n-\tpython manage.py test\n+\ttox\n \n .PHONY: quality\n quality:\n-\tpep8\n-\tpylint workbench/ sample_xblocks/ setup.py\n-\n-.PHONY: cover\n-cover:\n-\tcoverage run manage.py test\n-\tcoverage report","path":"Makefile","position":15,"original_position":15,"commit_id":"22d55095981795cd83876fec0480f2d424213473","original_commit_id":"22d55095981795cd83876fec0480f2d424213473","user":{"login":"jmbowman","id":1005375,"avatar_url":"https://avatars2.githubusercontent.com/u/1005375?v=4","gravatar_id":"","url":"https://api.github.com/users/jmbowman","html_url":"https://github.com/jmbowman","followers_url":"https://api.github.com/users/jmbowman/followers","following_url":"https://api.github.com/users/jmbowman/following{/other_user}","gists_url":"https://api.github.com/users/jmbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/jmbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmbowman/subscriptions","organizations_url":"https://api.github.com/users/jmbowman/orgs","repos_url":"https://api.github.com/users/jmbowman/repos","events_url":"https://api.github.com/users/jmbowman/events{/privacy}","received_events_url":"https://api.github.com/users/jmbowman/received_events","type":"User","site_admin":false},"body":"Do we want to keep a target for generating the coverage report?  The cookiecutter has one that launches the HTML report in a browser window.","created_at":"2018-02-14T21:41:25Z","updated_at":"2018-02-14T22:03:58Z","html_url":"https://github.com/edx/xblock-sdk/pull/123#discussion_r168318639","pull_request_url":"https://api.github.com/repos/edx/xblock-sdk/pulls/123","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/xblock-sdk/pulls/comments/168318639"},"html":{"href":"https://github.com/edx/xblock-sdk/pull/123#discussion_r168318639"},"pull_request":{"href":"https://api.github.com/repos/edx/xblock-sdk/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/edx/xblock-sdk/pulls/123","id":168944023,"html_url":"https://github.com/edx/xblock-sdk/pull/123","diff_url":"https://github.com/edx/xblock-sdk/pull/123.diff","patch_url":"https://github.com/edx/xblock-sdk/pull/123.patch","issue_url":"https://api.github.com/repos/edx/xblock-sdk/issues/123","number":123,"state":"open","locked":false,"title":"Testing and quality upgrades","user":{"login":"bmedx","id":24231382,"avatar_url":"https://avatars3.githubusercontent.com/u/24231382?v=4","gravatar_id":"","url":"https://api.github.com/users/bmedx","html_url":"https://github.com/bmedx","followers_url":"https://api.github.com/users/bmedx/followers","following_url":"https://api.github.com/users/bmedx/following{/other_user}","gists_url":"https://api.github.com/users/bmedx/gists{/gist_id}","starred_url":"https://api.github.com/users/bmedx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmedx/subscriptions","organizations_url":"https://api.github.com/users/bmedx/orgs","repos_url":"https://api.github.com/users/bmedx/repos","events_url":"https://api.github.com/users/bmedx/events{/privacy}","received_events_url":"https://api.github.com/users/bmedx/received_events","type":"User","site_admin":false},"body":"- Move to pytest\r\n- Move to pycodestyle\r\n- Move to codecov\r\n- Use edx-pylint\r\n- Fixup for associated issues\r\n\r\nStill to do: Clean up requirements, implement pip-compile","created_at":"2018-02-13T20:10:53Z","updated_at":"2018-02-14T22:03:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d2f29447be09261cd92b7b07f1cc02f6eeac798","assignee":null,"assignees":[],"requested_reviewers":[{"login":"doctoryes","id":7285237,"avatar_url":"https://avatars2.githubusercontent.com/u/7285237?v=4","gravatar_id":"","url":"https://api.github.com/users/doctoryes","html_url":"https://github.com/doctoryes","followers_url":"https://api.github.com/users/doctoryes/followers","following_url":"https://api.github.com/users/doctoryes/following{/other_user}","gists_url":"https://api.github.com/users/doctoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/doctoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctoryes/subscriptions","organizations_url":"https://api.github.com/users/doctoryes/orgs","repos_url":"https://api.github.com/users/doctoryes/repos","events_url":"https://api.github.com/users/doctoryes/events{/privacy}","received_events_url":"https://api.github.com/users/doctoryes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/xblock-sdk/pulls/123/commits","review_comments_url":"https://api.github.com/repos/edx/xblock-sdk/pulls/123/comments","review_comment_url":"https://api.github.com/repos/edx/xblock-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/xblock-sdk/issues/123/comments","statuses_url":"https://api.github.com/repos/edx/xblock-sdk/statuses/22d55095981795cd83876fec0480f2d424213473","head":{"label":"edx:bmedx/test_and_quality_upgrades","ref":"bmedx/test_and_quality_upgrades","sha":"22d55095981795cd83876fec0480f2d424213473","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":17491768,"name":"xblock-sdk","full_name":"edx/xblock-sdk","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/xblock-sdk","description":"Workbench and example xblocks","fork":false,"url":"https://api.github.com/repos/edx/xblock-sdk","forks_url":"https://api.github.com/repos/edx/xblock-sdk/forks","keys_url":"https://api.github.com/repos/edx/xblock-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/xblock-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/xblock-sdk/teams","hooks_url":"https://api.github.com/repos/edx/xblock-sdk/hooks","issue_events_url":"https://api.github.com/repos/edx/xblock-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/edx/xblock-sdk/events","assignees_url":"https://api.github.com/repos/edx/xblock-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/edx/xblock-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/edx/xblock-sdk/tags","blobs_url":"https://api.github.com/repos/edx/xblock-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/xblock-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/xblock-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/xblock-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/xblock-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/xblock-sdk/languages","stargazers_url":"https://api.github.com/repos/edx/xblock-sdk/stargazers","contributors_url":"https://api.github.com/repos/edx/xblock-sdk/contributors","subscribers_url":"https://api.github.com/repos/edx/xblock-sdk/subscribers","subscription_url":"https://api.github.com/repos/edx/xblock-sdk/subscription","commits_url":"https://api.github.com/repos/edx/xblock-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/xblock-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/xblock-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/xblock-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/xblock-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/edx/xblock-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/xblock-sdk/merges","archive_url":"https://api.github.com/repos/edx/xblock-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/xblock-sdk/downloads","issues_url":"https://api.github.com/repos/edx/xblock-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/edx/xblock-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/xblock-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/xblock-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/xblock-sdk/labels{/name}","releases_url":"https://api.github.com/repos/edx/xblock-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/edx/xblock-sdk/deployments","created_at":"2014-03-06T20:34:41Z","updated_at":"2018-01-30T07:05:34Z","pushed_at":"2018-02-14T21:08:51Z","git_url":"git://github.com/edx/xblock-sdk.git","ssh_url":"git@github.com:edx/xblock-sdk.git","clone_url":"https://github.com/edx/xblock-sdk.git","svn_url":"https://github.com/edx/xblock-sdk","homepage":"","size":1248,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":72,"open_issues":8,"watchers":35,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"38a539638633a4d067e5c0936b9ba7fb5b68e5fc","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":17491768,"name":"xblock-sdk","full_name":"edx/xblock-sdk","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/xblock-sdk","description":"Workbench and example xblocks","fork":false,"url":"https://api.github.com/repos/edx/xblock-sdk","forks_url":"https://api.github.com/repos/edx/xblock-sdk/forks","keys_url":"https://api.github.com/repos/edx/xblock-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/xblock-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/xblock-sdk/teams","hooks_url":"https://api.github.com/repos/edx/xblock-sdk/hooks","issue_events_url":"https://api.github.com/repos/edx/xblock-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/edx/xblock-sdk/events","assignees_url":"https://api.github.com/repos/edx/xblock-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/edx/xblock-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/edx/xblock-sdk/tags","blobs_url":"https://api.github.com/repos/edx/xblock-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/xblock-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/xblock-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/xblock-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/xblock-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/xblock-sdk/languages","stargazers_url":"https://api.github.com/repos/edx/xblock-sdk/stargazers","contributors_url":"https://api.github.com/repos/edx/xblock-sdk/contributors","subscribers_url":"https://api.github.com/repos/edx/xblock-sdk/subscribers","subscription_url":"https://api.github.com/repos/edx/xblock-sdk/subscription","commits_url":"https://api.github.com/repos/edx/xblock-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/xblock-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/xblock-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/xblock-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/xblock-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/edx/xblock-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/xblock-sdk/merges","archive_url":"https://api.github.com/repos/edx/xblock-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/xblock-sdk/downloads","issues_url":"https://api.github.com/repos/edx/xblock-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/edx/xblock-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/xblock-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/xblock-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/xblock-sdk/labels{/name}","releases_url":"https://api.github.com/repos/edx/xblock-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/edx/xblock-sdk/deployments","created_at":"2014-03-06T20:34:41Z","updated_at":"2018-01-30T07:05:34Z","pushed_at":"2018-02-14T21:08:51Z","git_url":"git://github.com/edx/xblock-sdk.git","ssh_url":"git@github.com:edx/xblock-sdk.git","clone_url":"https://github.com/edx/xblock-sdk.git","svn_url":"https://github.com/edx/xblock-sdk","homepage":"","size":1248,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":72,"open_issues":8,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/xblock-sdk/pulls/123"},"html":{"href":"https://github.com/edx/xblock-sdk/pull/123"},"issue":{"href":"https://api.github.com/repos/edx/xblock-sdk/issues/123"},"comments":{"href":"https://api.github.com/repos/edx/xblock-sdk/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/xblock-sdk/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/xblock-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/xblock-sdk/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/edx/xblock-sdk/statuses/22d55095981795cd83876fec0480f2d424213473"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmbowman"}}