{"action":"created","comment":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/186447873","pull_request_review_id":118026442,"id":186447873,"diff_hunk":"@@ -56,7 +55,7 @@ public Instant deserialize(\n         ) throws IOException {\n             final String value = jp.readValueAs(String.class);\n             try {\n-                return STD_DATE_FORMAT.parse(value).toInstant();\n+                return StdDateFormat.instance.clone().parse(value).toInstant();","path":"izettle-jackson/src/main/java/com/izettle/jackson/module/InstantRFC3339Module.java","position":13,"original_position":13,"commit_id":"f1cfb64146948a6d848f83e26ec4f9eb03883437","original_commit_id":"f1cfb64146948a6d848f83e26ec4f9eb03883437","user":{"login":"xiaodong-izettle","id":3328119,"avatar_url":"https://avatars2.githubusercontent.com/u/3328119?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaodong-izettle","html_url":"https://github.com/xiaodong-izettle","followers_url":"https://api.github.com/users/xiaodong-izettle/followers","following_url":"https://api.github.com/users/xiaodong-izettle/following{/other_user}","gists_url":"https://api.github.com/users/xiaodong-izettle/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaodong-izettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaodong-izettle/subscriptions","organizations_url":"https://api.github.com/users/xiaodong-izettle/orgs","repos_url":"https://api.github.com/users/xiaodong-izettle/repos","events_url":"https://api.github.com/users/xiaodong-izettle/events{/privacy}","received_events_url":"https://api.github.com/users/xiaodong-izettle/received_events","type":"User","site_admin":false},"body":"May I ask how you tried this, @joaxand? \r\n\r\n> True, but it doesn't matter how optimized it is when someone calls StdDateFormat.instance.setTimeZone(null);.\r\n\r\nI hope there is good reason for someone doing that. 😄 \r\n\r\nAlso @adamvoncorswant, sorry for the misunderstanding first. By `I think the library user could do all kinds of optimisations further on for clone`, I actually meant `I think the library author could do all kinds of optimisations further on for clone`. 😄 Such a lethal typo....\r\n\r\nI do not have that strong opinion on this either. I just would like to follow how the library author uses this method. I think the author should have some reason here. I'll do a small micro-benchmark later, to see if there is any performance gain, that could justify using `clone` here, @adamvoncorswant. \r\n\r\n> I'm not aware of any other place in our codebases where we create one phony instance that we call clone upon, just to create new identical objects\r\n\r\n2 examples: \r\n\r\nhttps://github.com/iZettle/sun/blob/master/izettle-ejb/src/main/java/com/izettle/ejb/bean/UserFacade.java#L535-L536\r\n\r\nhttps://github.com/iZettle/sun/blob/master/izettle-ejb/src/main/java/com/izettle/ejb/bean/cashregister/CashRegisterApplicationManager.java#L856\r\n\r\nAnd there are a few in `crypto` and elsewhere. 🙂 ","created_at":"2018-05-07T14:52:28Z","updated_at":"2018-05-07T14:52:28Z","html_url":"https://github.com/iZettle/izettle-toolbox/pull/269#discussion_r186447873","pull_request_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/186447873"},"html":{"href":"https://github.com/iZettle/izettle-toolbox/pull/269#discussion_r186447873"},"pull_request":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269"}},"in_reply_to_id":186378067},"pull_request":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269","id":186299550,"html_url":"https://github.com/iZettle/izettle-toolbox/pull/269","diff_url":"https://github.com/iZettle/izettle-toolbox/pull/269.diff","patch_url":"https://github.com/iZettle/izettle-toolbox/pull/269.patch","issue_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/269","number":269,"state":"open","locked":false,"title":"Fix usage of StdDateFormat.","user":{"login":"xiaodong-izettle","id":3328119,"avatar_url":"https://avatars2.githubusercontent.com/u/3328119?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaodong-izettle","html_url":"https://github.com/xiaodong-izettle","followers_url":"https://api.github.com/users/xiaodong-izettle/followers","following_url":"https://api.github.com/users/xiaodong-izettle/following{/other_user}","gists_url":"https://api.github.com/users/xiaodong-izettle/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaodong-izettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaodong-izettle/subscriptions","organizations_url":"https://api.github.com/users/xiaodong-izettle/orgs","repos_url":"https://api.github.com/users/xiaodong-izettle/repos","events_url":"https://api.github.com/users/xiaodong-izettle/events{/privacy}","received_events_url":"https://api.github.com/users/xiaodong-izettle/received_events","type":"User","site_admin":false},"body":"Ping @joaxand. Thanks for spotting this, and sorry for any inconveniences. 😄 👍 ","created_at":"2018-05-07T09:25:13Z","updated_at":"2018-05-07T14:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d48460346f453004ec161323f9c30857a6f90a08","assignee":{"login":"joaxand","id":24279145,"avatar_url":"https://avatars0.githubusercontent.com/u/24279145?v=4","gravatar_id":"","url":"https://api.github.com/users/joaxand","html_url":"https://github.com/joaxand","followers_url":"https://api.github.com/users/joaxand/followers","following_url":"https://api.github.com/users/joaxand/following{/other_user}","gists_url":"https://api.github.com/users/joaxand/gists{/gist_id}","starred_url":"https://api.github.com/users/joaxand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaxand/subscriptions","organizations_url":"https://api.github.com/users/joaxand/orgs","repos_url":"https://api.github.com/users/joaxand/repos","events_url":"https://api.github.com/users/joaxand/events{/privacy}","received_events_url":"https://api.github.com/users/joaxand/received_events","type":"User","site_admin":false},"assignees":[{"login":"joaxand","id":24279145,"avatar_url":"https://avatars0.githubusercontent.com/u/24279145?v=4","gravatar_id":"","url":"https://api.github.com/users/joaxand","html_url":"https://github.com/joaxand","followers_url":"https://api.github.com/users/joaxand/followers","following_url":"https://api.github.com/users/joaxand/following{/other_user}","gists_url":"https://api.github.com/users/joaxand/gists{/gist_id}","starred_url":"https://api.github.com/users/joaxand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaxand/subscriptions","organizations_url":"https://api.github.com/users/joaxand/orgs","repos_url":"https://api.github.com/users/joaxand/repos","events_url":"https://api.github.com/users/joaxand/events{/privacy}","received_events_url":"https://api.github.com/users/joaxand/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":813853647,"url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels/Technical%20Design","name":"Technical Design","color":"17b21e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269/commits","review_comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269/comments","review_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/269/comments","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/f1cfb64146948a6d848f83e26ec4f9eb03883437","head":{"label":"iZettle:correct-usage-of-StdDateFormat","ref":"correct-usage-of-StdDateFormat","sha":"f1cfb64146948a6d848f83e26ec4f9eb03883437","user":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars2.githubusercontent.com/u/1272526?v=4","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"repo":{"id":13087671,"name":"izettle-toolbox","full_name":"iZettle/izettle-toolbox","owner":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars2.githubusercontent.com/u/1272526?v=4","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iZettle/izettle-toolbox","description":null,"fork":false,"url":"https://api.github.com/repos/iZettle/izettle-toolbox","forks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/forks","keys_url":"https://api.github.com/repos/iZettle/izettle-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iZettle/izettle-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iZettle/izettle-toolbox/teams","hooks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/hooks","issue_events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/events","assignees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/iZettle/izettle-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/tags","blobs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/iZettle/izettle-toolbox/languages","stargazers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/stargazers","contributors_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contributors","subscribers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscribers","subscription_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscription","commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/iZettle/izettle-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iZettle/izettle-toolbox/merges","archive_url":"https://api.github.com/repos/iZettle/izettle-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iZettle/izettle-toolbox/downloads","issues_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/iZettle/izettle-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/iZettle/izettle-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/iZettle/izettle-toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/deployments","created_at":"2013-09-25T08:01:29Z","updated_at":"2018-04-26T21:43:07Z","pushed_at":"2018-05-07T09:26:17Z","git_url":"git://github.com/iZettle/izettle-toolbox.git","ssh_url":"git@github.com:iZettle/izettle-toolbox.git","clone_url":"https://github.com/iZettle/izettle-toolbox.git","svn_url":"https://github.com/iZettle/izettle-toolbox","homepage":null,"size":1233,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"iZettle:master","ref":"master","sha":"96d5e824a95d85df59fc23f173f3b4a0ff694e03","user":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars2.githubusercontent.com/u/1272526?v=4","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"repo":{"id":13087671,"name":"izettle-toolbox","full_name":"iZettle/izettle-toolbox","owner":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars2.githubusercontent.com/u/1272526?v=4","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iZettle/izettle-toolbox","description":null,"fork":false,"url":"https://api.github.com/repos/iZettle/izettle-toolbox","forks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/forks","keys_url":"https://api.github.com/repos/iZettle/izettle-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iZettle/izettle-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iZettle/izettle-toolbox/teams","hooks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/hooks","issue_events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/events","assignees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/iZettle/izettle-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/tags","blobs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/iZettle/izettle-toolbox/languages","stargazers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/stargazers","contributors_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contributors","subscribers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscribers","subscription_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscription","commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/iZettle/izettle-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iZettle/izettle-toolbox/merges","archive_url":"https://api.github.com/repos/iZettle/izettle-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iZettle/izettle-toolbox/downloads","issues_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/iZettle/izettle-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/iZettle/izettle-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/iZettle/izettle-toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/deployments","created_at":"2013-09-25T08:01:29Z","updated_at":"2018-04-26T21:43:07Z","pushed_at":"2018-05-07T09:26:17Z","git_url":"git://github.com/iZettle/izettle-toolbox.git","ssh_url":"git@github.com:iZettle/izettle-toolbox.git","clone_url":"https://github.com/iZettle/izettle-toolbox.git","svn_url":"https://github.com/iZettle/izettle-toolbox","homepage":null,"size":1233,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269"},"html":{"href":"https://github.com/iZettle/izettle-toolbox/pull/269"},"issue":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/269"},"comments":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/f1cfb64146948a6d848f83e26ec4f9eb03883437"}},"author_association":"OWNER"}}
{"actor":{"display_login":"xiaodong-izettle"}}