{"action":"created","issue":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/issues/98","repository_url":"https://api.github.com/repos/ckeditor/ckeditor5-heading","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/issues/98/comments","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/issues/98/events","html_url":"https://github.com/ckeditor/ckeditor5-heading/issues/98","id":302221501,"node_id":"MDU6SXNzdWUzMDIyMjE1MDE=","number":98,"title":"Handle h1 even if editor is configured to support h2+","user":{"login":"Reinmar","id":156149,"node_id":"MDQ6VXNlcjE1NjE0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/156149?v=4","gravatar_id":"","url":"https://api.github.com/users/Reinmar","html_url":"https://github.com/Reinmar","followers_url":"https://api.github.com/users/Reinmar/followers","following_url":"https://api.github.com/users/Reinmar/following{/other_user}","gists_url":"https://api.github.com/users/Reinmar/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinmar/subscriptions","organizations_url":"https://api.github.com/users/Reinmar/orgs","repos_url":"https://api.github.com/users/Reinmar/repos","events_url":"https://api.github.com/users/Reinmar/events{/privacy}","received_events_url":"https://api.github.com/users/Reinmar/received_events","type":"User","site_admin":false},"labels":[{"id":383420981,"node_id":"MDU6TGFiZWwzODM0MjA5ODE=","url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/labels/status:confirmed","name":"status:confirmed","color":"e6e6e6","default":false},{"id":383420998,"node_id":"MDU6TGFiZWwzODM0MjA5OTg=","url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/labels/type:enhancement","name":"type:enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-05T09:15:03Z","updated_at":"2018-06-09T05:53:39Z","closed_at":null,"author_association":"MEMBER","body":"I think we discussed it somewhere but I can't find it reported.\r\n\r\nBasically, the idea is that, since the editor is by default configured to support h2+, when you paste a h1, it gets converted into a paragraph. A more useful behaviour would be if h1 was converted to h2 (and heading1 in the model, to be precise) at that point.\r\n\r\nAlso, when working on an answer to https://stackoverflow.com/questions/49052613/is-it-possible-to-attach-an-inline-editor-to-an-h1-in-ckeditor5 I realised that if we made this behaviour (h1 -> h2) available for `setData()` as well, there might be a new kind of confusion among developers. Suddenly, the h1 elements won't be dropped but they will become h2s. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/issues/comments/395942642","html_url":"https://github.com/ckeditor/ckeditor5-heading/issues/98#issuecomment-395942642","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-heading/issues/98","id":395942642,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTk0MjY0Mg==","user":{"login":"archonic","id":588846,"node_id":"MDQ6VXNlcjU4ODg0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/588846?v=4","gravatar_id":"","url":"https://api.github.com/users/archonic","html_url":"https://github.com/archonic","followers_url":"https://api.github.com/users/archonic/followers","following_url":"https://api.github.com/users/archonic/following{/other_user}","gists_url":"https://api.github.com/users/archonic/gists{/gist_id}","starred_url":"https://api.github.com/users/archonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archonic/subscriptions","organizations_url":"https://api.github.com/users/archonic/orgs","repos_url":"https://api.github.com/users/archonic/repos","events_url":"https://api.github.com/users/archonic/events{/privacy}","received_events_url":"https://api.github.com/users/archonic/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T05:53:39Z","updated_at":"2018-06-09T05:53:39Z","author_association":"NONE","body":"There's some debate about whether more than one H1 tag per document is valid HTML5, but let's say I wanted to allow it. I have this in my build config:\r\n\r\n```\r\nheading: {\r\n  options: [\r\n    { model: 'paragraph', title: 'Paragraph', class: 'ck-heading_paragraph' },\r\n    { model: 'heading1', view: 'h1', title: 'Heading 1', class: 'ck-heading_heading1' },\r\n    { model: 'heading2', view: 'h2', title: 'Heading 2', class: 'ck-heading_heading2' },\r\n    { model: 'heading3', view: 'h3', title: 'Heading 3', class: 'ck-heading_heading3' },\r\n    { model: 'heading4', view: 'h4', title: 'Heading 4', class: 'ck-heading_heading4' },\r\n    { model: 'heading5', view: 'h5', title: 'Heading 5', class: 'ck-heading_heading5' },\r\n    { model: 'heading6', view: 'h6', title: 'Heading 6', class: 'ck-heading_heading6' }\r\n  ]\r\n}\r\n```\r\n\r\nH1 elements are still being converted to p elements. Is that behaviour configurable?"}}
{"actor":{"display_login":"archonic"}}