{"push_id":2405663582,"size":5,"distinct_size":3,"ref":"refs/heads/sortout-expires","head":"ef0aff28ac967a2debf580115c674ed68e24705d","before":"72936858e938ccbed734bb2b3eaa0e8d0d3518a4","commits":[{"sha":"85ff38e611b84d2c201f248ccc98d6eb67d36a9d","author":{"name":"Jesus Laiz","email":"7d4a3c969c33907a9d97ebb248ea231957850364@users.noreply.github.com"},"message":"Do not rely on `HEROKU_APP_NAME` env var\n\nThis env var is only set if a specific plugin is enabled on Heroku. If we ever move out of Heroku this will not make sense. Better to have a specific.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/c100-application/commits/85ff38e611b84d2c201f248ccc98d6eb67d36a9d"},{"sha":"4f638458d32d177aad0e683d6992d35ea5859aef","author":{"name":"Jesus Laiz","email":"7d4a3c969c33907a9d97ebb248ea231957850364@users.noreply.github.com"},"message":"Merge pull request #284 from ministryofjustice/basic-auth\n\nDo not rely on `HEROKU_APP_NAME` env var","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/c100-application/commits/4f638458d32d177aad0e683d6992d35ea5859aef"},{"sha":"6cc5b371df6f779c9692ecceffc127445d5749c9","author":{"name":"Jesus Laiz","email":"7d4a3c969c33907a9d97ebb248ea231957850364@users.noreply.github.com"},"message":"Make session expire when browser closes","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/c100-application/commits/6cc5b371df6f779c9692ecceffc127445d5749c9"},{"sha":"2f41f497ba8038fec6e65e6cafec9a0c8d354cf3","author":{"name":"Jesus Laiz","email":"7d4a3c969c33907a9d97ebb248ea231957850364@users.noreply.github.com"},"message":"Add missing asset","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/c100-application/commits/2f41f497ba8038fec6e65e6cafec9a0c8d354cf3"},{"sha":"ef0aff28ac967a2debf580115c674ed68e24705d","author":{"name":"Jesus Laiz","email":"7d4a3c969c33907a9d97ebb248ea231957850364@users.noreply.github.com"},"message":"Applications expire after 28 days\n\nAnd do not using ENV variables for these expires, because there is some code, like the reminders, that rely on specific dates to trigger, and also tests that would fail.\n\nThis can be improved of course but I don't think is worth it as these numbers are not suppose to be changing every week, once we pick ones we will stick to them.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/c100-application/commits/ef0aff28ac967a2debf580115c674ed68e24705d"}]}
{"actor":{"display_login":"zheileman"}}