{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/202546144","pull_request_review_id":137270133,"id":202546144,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU0NjE0NA==","diff_hunk":"@@ -790,17 +790,66 @@ In the following example, k is deprecated and renamed to n_clusters::\n \n     import warnings\n \n-    def example_function(n_clusters=8, k=None):\n-        if k is not None:\n+    def example_function(n_clusters=8, k='deprecated'):\n+        if k != 'deprecated':\n             warnings.warn(\"'k' was renamed to n_clusters in version 0.13 and \"\n                           \"will be removed in 0.15.\", DeprecationWarning)\n             n_clusters = k\n \n+When the change is in a class, we conduct validate and raise warning in ``fit``::\n+\n+  import warnings\n+\n+  class ExampleEstimator:","path":"doc/developers/contributing.rst","position":16,"original_position":16,"commit_id":"36fa05dbde310e42b27e869c9c259c15effb6d41","original_commit_id":"36fa05dbde310e42b27e869c9c259c15effb6d41","user":{"login":"amueller","id":449558,"node_id":"MDQ6VXNlcjQ0OTU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/449558?v=4","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"body":"inherit from BaseEstimator maybe? I mean not necessary but why not?","created_at":"2018-07-15T15:32:37Z","updated_at":"2018-07-15T15:36:12Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11469#discussion_r202546144","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/202546144"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11469#discussion_r202546144"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469","id":200422230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDIyMjMw","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11469","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11469.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11469.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11469","number":11469,"state":"open","locked":false,"title":"[MRG] DOC Instructions for changing default value of a certain parameter","user":{"login":"qinhanmin2014","id":12003569,"node_id":"MDQ6VXNlcjEyMDAzNTY5","avatar_url":"https://avatars2.githubusercontent.com/u/12003569?v=4","gravatar_id":"","url":"https://api.github.com/users/qinhanmin2014","html_url":"https://github.com/qinhanmin2014","followers_url":"https://api.github.com/users/qinhanmin2014/followers","following_url":"https://api.github.com/users/qinhanmin2014/following{/other_user}","gists_url":"https://api.github.com/users/qinhanmin2014/gists{/gist_id}","starred_url":"https://api.github.com/users/qinhanmin2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinhanmin2014/subscriptions","organizations_url":"https://api.github.com/users/qinhanmin2014/orgs","repos_url":"https://api.github.com/users/qinhanmin2014/repos","events_url":"https://api.github.com/users/qinhanmin2014/events{/privacy}","received_events_url":"https://api.github.com/users/qinhanmin2014/received_events","type":"User","site_admin":false},"body":"Closes #11219 Closes #11283 \r\nWe have several PRs (marked as blocker) which aim to change the default value of a certain parameter, but seems that contributors don't know our way of doing these things.\r\nCurrently, I only write down our consensus (I think). Whether we should take care of tests/examples when changing the default value of a parameter is still unclear.\r\nSee https://github.com/scikit-learn/scikit-learn/pull/11043#issuecomment-403730846\r\ncc @jnothman ","created_at":"2018-07-10T14:46:44Z","updated_at":"2018-07-15T15:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02f69ce02855070d9c9d4b64356bf7dc771f2474","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":12995770,"node_id":"MDU6TGFiZWwxMjk5NTc3MA==","url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Documentation","name":"Documentation","color":"0b02e1","default":false}],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/24","html_url":"https://github.com/scikit-learn/scikit-learn/milestone/24","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/24/labels","id":2577444,"node_id":"MDk6TWlsZXN0b25lMjU3NzQ0NA==","number":24,"title":"0.20","description":"","creator":{"login":"jnothman","id":78827,"node_id":"MDQ6VXNlcjc4ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":63,"state":"open","created_at":"2017-06-12T11:07:06Z","updated_at":"2018-07-14T20:14:03Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11469/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/36fa05dbde310e42b27e869c9c259c15effb6d41","head":{"label":"qinhanmin2014:change-default-guide","ref":"change-default-guide","sha":"36fa05dbde310e42b27e869c9c259c15effb6d41","user":{"login":"qinhanmin2014","id":12003569,"node_id":"MDQ6VXNlcjEyMDAzNTY5","avatar_url":"https://avatars2.githubusercontent.com/u/12003569?v=4","gravatar_id":"","url":"https://api.github.com/users/qinhanmin2014","html_url":"https://github.com/qinhanmin2014","followers_url":"https://api.github.com/users/qinhanmin2014/followers","following_url":"https://api.github.com/users/qinhanmin2014/following{/other_user}","gists_url":"https://api.github.com/users/qinhanmin2014/gists{/gist_id}","starred_url":"https://api.github.com/users/qinhanmin2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinhanmin2014/subscriptions","organizations_url":"https://api.github.com/users/qinhanmin2014/orgs","repos_url":"https://api.github.com/users/qinhanmin2014/repos","events_url":"https://api.github.com/users/qinhanmin2014/events{/privacy}","received_events_url":"https://api.github.com/users/qinhanmin2014/received_events","type":"User","site_admin":false},"repo":{"id":99676558,"node_id":"MDEwOlJlcG9zaXRvcnk5OTY3NjU1OA==","name":"scikit-learn","full_name":"qinhanmin2014/scikit-learn","owner":{"login":"qinhanmin2014","id":12003569,"node_id":"MDQ6VXNlcjEyMDAzNTY5","avatar_url":"https://avatars2.githubusercontent.com/u/12003569?v=4","gravatar_id":"","url":"https://api.github.com/users/qinhanmin2014","html_url":"https://github.com/qinhanmin2014","followers_url":"https://api.github.com/users/qinhanmin2014/followers","following_url":"https://api.github.com/users/qinhanmin2014/following{/other_user}","gists_url":"https://api.github.com/users/qinhanmin2014/gists{/gist_id}","starred_url":"https://api.github.com/users/qinhanmin2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinhanmin2014/subscriptions","organizations_url":"https://api.github.com/users/qinhanmin2014/orgs","repos_url":"https://api.github.com/users/qinhanmin2014/repos","events_url":"https://api.github.com/users/qinhanmin2014/events{/privacy}","received_events_url":"https://api.github.com/users/qinhanmin2014/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qinhanmin2014/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/qinhanmin2014/scikit-learn","forks_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/forks","keys_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/teams","hooks_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/events","assignees_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/tags","blobs_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/subscription","commits_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/merges","archive_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/downloads","issues_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/qinhanmin2014/scikit-learn/deployments","created_at":"2017-08-08T09:40:39Z","updated_at":"2018-07-12T03:48:02Z","pushed_at":"2018-07-15T08:44:32Z","git_url":"git://github.com/qinhanmin2014/scikit-learn.git","ssh_url":"git@github.com:qinhanmin2014/scikit-learn.git","clone_url":"https://github.com/qinhanmin2014/scikit-learn.git","svn_url":"https://github.com/qinhanmin2014/scikit-learn","homepage":"http://scikit-learn.org","size":90751,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"a2b56453e2817cc496f7bcf23a2cd883c82cb30d","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-07-15T14:07:06Z","pushed_at":"2018-07-15T15:35:58Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":91451,"stargazers_count":29327,"watchers_count":29327,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14558,"mirror_url":null,"archived":false,"open_issues_count":1676,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14558,"open_issues":1676,"watchers":29327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11469"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11469"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11469/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11469/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/36fa05dbde310e42b27e869c9c259c15effb6d41"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"amueller"}}