{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14021","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14021/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14021/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14021/events","html_url":"https://github.com/bitcoin/bitcoin/pull/14021","id":352788911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDEwNjMx","number":14021,"title":"Import key origin data through descriptors in importmulti","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"labels":[{"id":98279177,"node_id":"MDU6TGFiZWw5ODI3OTE3Nw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/RPC/REST/ZMQ","name":"RPC/REST/ZMQ","color":"0052cc","default":false},{"id":149424,"node_id":"MDU6TGFiZWwxNDk0MjQ=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"08a781","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-08-22T03:23:16Z","updated_at":"2018-11-08T21:59:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14021","html_url":"https://github.com/bitcoin/bitcoin/pull/14021","diff_url":"https://github.com/bitcoin/bitcoin/pull/14021.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14021.patch"},"body":"This PR allows for key origin data as defined by the descriptors document to be imported to the wallet when importing a descriptor using `importmulti`. This allows the `walletprocesspsbt` to include the BIP 32 derivation paths for keys that it is watching that are from a different HD wallet.\r\n\r\nIn order to make this easier to use, the `hdmasterkeyid` field in `getaddressinfo` has been changed to actually give the HD master key id instead of the seed id. I think that this API change is fine since it was going to be removed in 0.18 anyways. Additionally, `CKeyMetadata` has been extended to store the HD master key id to facilitate this.\r\n\r\nBased on top of #14491 "},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/437171488","html_url":"https://github.com/bitcoin/bitcoin/pull/14021#issuecomment-437171488","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14021","id":437171488,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzE3MTQ4OA==","user":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars2.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T21:59:59Z","updated_at":"2018-11-08T21:59:59Z","author_association":"CONTRIBUTOR","body":"<!--e57a25ab6845829454e8d69fc972939a-->\n\nThe following sections might be updated with supplementary metadata relevant to reviewers and maintainers.\n\n<!--174a7506f384e20aa4161008e828411d-->\n### Conflicts\nReviewers, this pull request conflicts with the following ones:\n\n* [#14679](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14679.html) (importmulti: Don't add internal addresses to address book by instagibbs)\n* [#14565](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14565.html) (Overhaul importmulti logic by sipa)\n* [#14530](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14530.html) (Use RPCHelpMan to generate RPC doc strings by MarcoFalke)\n* [#14491](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14491.html) (Allow descriptor imports with importmulti by MeshCollider)\n* [#14459](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14459.html) (More RPC help description fixes by ch4ot1c)\n* [#14411](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14411.html) ([wallet] Restore ability to list incoming transactions by label by ryanofsky)\n* [#14075](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/14075.html) (Import watch only pubkeys to the keypool if private keys are disabled by achow101)\n* [#10973](https://drahtbot.github.io/bitcoin_core_issue_redirect/r/10973.html) (Refactor: separate wallet from node by ryanofsky)\n\nIf you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first."}}
{"actor":{"display_login":"DrahtBot"}}