{"push_id":2868249508,"size":661,"distinct_size":3,"ref":"refs/heads/staging","head":"3db122def2f2faba9a3b4fdd568ef200e79bb5d3","before":"7ab5493ab10d515228e6c80e1866f49ad545e028","commits":[{"sha":"583cc941255514b9e51a33d45cef41779cb711ac","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: discard a unworthwhile merge TODO\n\nThis TODO suggested removing maybeWatchForMerge by teaching the LHS\nreplica to reach into the RHS replica after a merge committed to unblock\nrequests. It failed to consider that we'd need to do the same if the\nmerge aborted. We don't presently have an abort trigger, so this is\nexcessively difficult. Simply discard the TODO; the status quo is fine.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/583cc941255514b9e51a33d45cef41779cb711ac"},{"sha":"0cfe12d8e88d06918822f2850a674537a4566e9f","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: update variable names in Store.SplitRange\n\nStore.SplitRange was still using the old term \"range\" to refer to\nreplicas. Also use \"left\" and \"right\" instead of \"orig\" and \"new\" for\nconsistency with Store.MergeRange.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/0cfe12d8e88d06918822f2850a674537a4566e9f"},{"sha":"2d1bf4e07c1bd6538c341a09a4bcb49ec3b7de73","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: update state using trigger's desc during splits/merges\n\nIt is important that the in-memory copy of a replica's range descriptor\nexactly match the on-disk copy. Previously, during splits/merges, we\nwould reconstruct the updates to the in-memory descriptor piecemeal.\nThis is dangerous, especially in mixed version clusters, where nodes can\ndisagree about what updates to the descriptor to perform. Notably,\nsplits only update the generation counter in v2.1.\n\nInstead of trying to reconstruct the updates piecemeal during a split\nor merge, simply adopt the updated descriptor from the split/merge\ntrigger wholesale.\n\nWe'd ideally adjust replica changes to operate the same way.\nUnfortunately the updated descriptor is not currently included in the\nChangeReplicasTrigger, so the migration is rather involved.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/2d1bf4e07c1bd6538c341a09a4bcb49ec3b7de73"},{"sha":"2483548e122a5e79de3b289b938c92e09abfe6f6","author":{"name":"Masha Schneider","email":"9a19271f701eeb7a4e6dffa6a484ec27a6e51a66@cockroachlabs.com"},"message":"sql/distsqlrun: nodedialer: removing \"connection established\" log spam\n\nBefore we spun up multiple instances of a node dialer which led to\nspammy logs.\n\nNow we create one instance per node.\n\ncloses #28165\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/2483548e122a5e79de3b289b938c92e09abfe6f6"},{"sha":"1c8a752864831b5069eae8f4ba24d88bc6717188","author":{"name":"Andrei Matei","email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com"},"message":"kv: remove unused test arg\n\nWe used to check an \"abandoned\" metric for transactions, but that\ndoesn't exist any more. One doesn't simply abandon a transaction.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/1c8a752864831b5069eae8f4ba24d88bc6717188"},{"sha":"434657edbcedee0e6b92a8286a494e29ee891982","author":{"name":"Peter Mattis","email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com"},"message":"storage: place replicas in purgatory when the range is below quorum\n\nWhen the replicate queue cannot process a replica because the range is\nbelow quorum, place the replica in purgatory so that it will be\nprocessed quickly upon a change in liveness. Failure to do this was\ncausing rare slowness to up-replicate a new cluster if a replica was\nprocessed before liveness had marked a node as live. Previously this\nfailure was masked by the scanner rapidly re-scanning replicas on test\nclusters, but this was changed in #27441 so that the scanner has a\nmin-idle-time between scanning replicas to avoid burning cpu.\n\nAlso fixes test flakiness that was a side effect of the slow\nup-replication. The \"had X ranges at startup, expected 22\" seems to be\ncaused by splits taking longer than expected on an overly stressed\ncluster (note that up-replication in the failed test is not a factor\nbecause the error here occurs when there is only a single node in the\ntest cluster). When test clusters up-replicate quicker there is less stress on\nthe system when running tests concurrently.\n\nFixes #28395\nFixes #28746\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/434657edbcedee0e6b92a8286a494e29ee891982"},{"sha":"4004c1e37f6bf9dcd1024cff7f00ed606e771f44","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #28874\n\n28874: kv: remove unused test arg r=andreimatei a=andreimatei\n\nWe used to check an \"abandoned\" metric for transactions, but that\r\ndoesn't exist any more. One doesn't simply abandon a transaction.\r\n\r\nRelease note: None\n\nCo-authored-by: Andrei Matei <andrei@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/4004c1e37f6bf9dcd1024cff7f00ed606e771f44"},{"sha":"98f4ac6e8758efa7804d53902c62200ab21fd059","author":{"name":"Daniel Harrison","email":"3a2f0da2a0c450062f2df795b8346ad513a9734a@gmail.com"},"message":"changefeedccl,roachtest: more changefeed introspection for debugging\n\nFix up the roachtests to use the high-water timestamp in\ncrdb_internal.jobs, now that it exists. Also length the roachtest to get\na better sense of how variable the latencies are over a longer period.\n\nAdd a couple more metrics (changefeed.emit_nanos and changefeed.flushes)\nthat are helpful in debugging performance problems with the sink.\nTimeseries storage is expensive, is this too many metrics?\n\nRelease note (enterprise change): Added additional monitoring metrics\nfor changefeeds.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/98f4ac6e8758efa7804d53902c62200ab21fd059"},{"sha":"785566346fb2173e27f84c0ca85c28d5950809e6","author":{"name":"Radu Berinde","email":"8cd32adbfdfb986a6f0d684f7a16030a20d97029@cockroachlabs.com"},"message":"opt: add disable flag to opttester\n\nAdd a flag to norm/opt that disables specific rules.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/785566346fb2173e27f84c0ca85c28d5950809e6"},{"sha":"e1401e97b644fa201a319e8d56e3f727db1f2e66","author":{"name":"Radu Berinde","email":"8cd32adbfdfb986a6f0d684f7a16030a20d97029@cockroachlabs.com"},"message":"opt: add testcases showing stats problem\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/e1401e97b644fa201a319e8d56e3f727db1f2e66"},{"sha":"188431ba0bd092afb8054557686a13e0d04eea50","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: gate merges behind a cluster setting\n\nMerges will explode if used in a mixed-version cluster. Gate them behind\na cluster setting.\n\nFor extra safety, also gate increments of the new generation counter in\nthe range descriptor behind the same cluster setting. It's not clear\nexactly what would go wrong, if anything, if mixed-version clusters\nincremented the generation counter, but better to be extra cautious.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/188431ba0bd092afb8054557686a13e0d04eea50"},{"sha":"4c0d19f8e7af1a693277b4fca5008b141c90523f","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #28877\n\n28877: storage: place replicas in purgatory when the range is below quorum r=benesch,tschottdorf a=petermattis\n\nWhen the replicate queue cannot process a replica because the range is\r\nbelow quorum, place the replica in purgatory so that it will be\r\nprocessed quickly upon a change in liveness. Failure to do this was\r\ncausing rare slowness to up-replicate a new cluster if a replica was\r\nprocessed before liveness had marked a node as live. Previously this\r\nfailure was masked by the scanner rapidly re-scanning replicas on test\r\nclusters, but this was changed in #27441 so that the scanner has a\r\nmin-idle-time between scanning replicas to avoid burning cpu.\r\n\r\nAlso fixes test flakiness that was a side effect of the slow\r\nup-replication. The \"had X ranges at startup, expected 22\" seems to be\r\ncaused by splits taking longer than expected on an overly stressed\r\nmachine (note that up-replication in the failed test is not a factor\r\nbecause the error here occurs when there is only a single node in the\r\ntest cluster). When test clusters up-replicate quicker there is less stress on\r\nthe system when running tests concurrently.\r\n\r\nFixes #28395\r\nFixes #28746\r\n\r\nRelease note: None\n\nCo-authored-by: Peter Mattis <petermattis@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/4c0d19f8e7af1a693277b4fca5008b141c90523f"},{"sha":"4cbb4d537ac1aaae80ccddc5596ca8d472732198","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #28885\n\n28885: storage: discard a unworthwhile merge TODO r=tschottdorf a=benesch\n\nThis TODO suggested removing maybeWatchForMerge by teaching the LHS\r\nreplica to reach into the RHS replica after a merge committed to unblock\r\nrequests. It failed to consider that we'd need to do the same if the\r\nmerge aborted. We don't presently have an abort trigger, so this is\r\nexcessively difficult. Simply discard the TODO; the status quo is fine.\r\n\r\nRelease note: None\n\nCo-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/4cbb4d537ac1aaae80ccddc5596ca8d472732198"},{"sha":"2fa4ef152bbc8c2adb26627db9e4e318f3a0dd29","author":{"name":"Peter Mattis","email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com"},"message":"storage: update comment about purgatory\n\nForgot to push this in a previous commit.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/2fa4ef152bbc8c2adb26627db9e4e318f3a0dd29"},{"sha":"d942714ea69956c12786ba3871a492186fdf978c","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #28865\n\n28865: storage: gate merges behind a cluster setting  r=tschottdorf a=benesch\n\nThe big commit:\r\n\r\n> storage: gate merges behind a cluster setting \r\n>\r\n> Merges will explode if used in a mixed-version cluster. Gate them behind\r\n> a cluster setting.\r\n>\r\n> For extra safety, also gate increments of the new generation counter in\r\n> the range descriptor behind the same cluster setting. It's not clear\r\n> exactly what would go wrong, if anything, if mixed-version clusters\r\n> incremented the generation counter, but better to be extra cautious.\r\n\r\nThe early commits are cleanup to make the last commit less painful.\n\nCo-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d942714ea69956c12786ba3871a492186fdf978c"},{"sha":"55fbd4fff6a7e686beb43dc41a8d23aa290ff03c","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #28853 #28893\n\n28853: changefeedccl,roachtest: more changefeed introspection for debugging r=mrtracy a=danhhz\n\nFix up the roachtests to use the high-water timestamp in\r\ncrdb_internal.jobs, now that it exists. Also length the roachtest to get\r\na better sense of how variable the latencies are over a longer period.\r\n\r\nAdd a couple more metrics (changefeed.emit_nanos and changefeed.flushes)\r\nthat are helpful in debugging performance problems with the sink.\r\nTimeseries storage is expensive, is this too many metrics?\r\n\r\nRelease note (enterprise change): Added additional monitoring metrics\r\nfor changefeeds.\n\n28893: storage: update comment about purgatory r=tschottdorf,benesch a=petermattis\n\nForgot to push this in a previous commit.\n\nRelease note: None\n\nCo-authored-by: Daniel Harrison <daniel.harrison@gmail.com>\nCo-authored-by: Peter Mattis <petermattis@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/55fbd4fff6a7e686beb43dc41a8d23aa290ff03c"},{"sha":"6318e9a93391454e00f897e44cce618276be01f0","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #28871\n\n28871: sql/distsqlrun: nodedialer: removing \"connection established\" log spam r=m-schneider a=m-schneider\n\nBefore we spun up multiple instances of a node dialer which led to\r\nspammy logs.\r\n\r\nNow we create one instance per node.\r\n\r\ncloses #28165\r\n\r\nRelease note: None\n\nCo-authored-by: Masha Schneider <masha@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/6318e9a93391454e00f897e44cce618276be01f0"},{"sha":"c0ff732fc5740602d2fdf29440d14212ea1f5917","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: avoid stopping twice in merge test\n\nTestStoreRangeMergeDuringShutdown shuts down the multiTestContext when\nit applies a lease for the RHS. In rare cases, the lease application can\nget replayed, which previously caused the multiTestContext to get\nshutdown twice, which panics. Add additional state to prevent this case.\n\nFix #28894.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c0ff732fc5740602d2fdf29440d14212ea1f5917"},{"sha":"8aea353991fdfb131e169aa691a70d907e54fb71","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: update the tscache appropriately after a merge\n\nWhen applying a merge, teach the leaseholder of the LHS range to update\nits timestamp cache for the keyspace previously owned by the RHS range\nappropriately.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/8aea353991fdfb131e169aa691a70d907e54fb71"},{"sha":"ffa957fa6d422b6fc74167e07922f1fad9f73365","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"closedts/transport: avoid race when using stopper.RunWorker\n\nStopper.RunWorker cannot be called in code which can run concurrently\nwith Stopper.Stop. Use Stopper.RunAsyncTask instead.\n\nFix #28755.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ffa957fa6d422b6fc74167e07922f1fad9f73365"}]}
{"actor":{"display_login":"craig"}}