{"action":"opened","number":305,"pull_request":{"url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/305","id":207083396,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDgzMzk2","html_url":"https://github.com/virtual-kubelet/virtual-kubelet/pull/305","diff_url":"https://github.com/virtual-kubelet/virtual-kubelet/pull/305.diff","patch_url":"https://github.com/virtual-kubelet/virtual-kubelet/pull/305.patch","issue_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues/305","number":305,"state":"open","locked":false,"title":"[WIP] Provide default \"provider\" taint and support configuration of taint effect","user":{"login":"jlegrone","id":6752382,"node_id":"MDQ6VXNlcjY3NTIzODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6752382?v=4","gravatar_id":"","url":"https://api.github.com/users/jlegrone","html_url":"https://github.com/jlegrone","followers_url":"https://api.github.com/users/jlegrone/followers","following_url":"https://api.github.com/users/jlegrone/following{/other_user}","gists_url":"https://api.github.com/users/jlegrone/gists{/gist_id}","starred_url":"https://api.github.com/users/jlegrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlegrone/subscriptions","organizations_url":"https://api.github.com/users/jlegrone/orgs","repos_url":"https://api.github.com/users/jlegrone/repos","events_url":"https://api.github.com/users/jlegrone/events{/privacy}","received_events_url":"https://api.github.com/users/jlegrone/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/virtual-kubelet/virtual-kubelet/issues/259\r\n\r\nI'm opening this PR as a straw-man proposal to get feedback on the design and requirements.  There are several things I think should be validated:\r\n\r\n1. Is `virtual-kubelet.github.io` the right prefix for us to use for things like taints, labels, and annotations long term? Updating this prefix in the future would be a breaking change.\r\n1. Is this the right level of configuration?\r\n    1. The provider taint can be disabled\r\n    1. The user can specify a custom taint to be used in addition to the default provider taint\r\n    1. The user cannot specify a value for their custom taint\r\n    1. The provider taint and a user specified taint inherit the same taint effect, which is configurable via an environment variable\r\n1. Is the breaking change of adding a provider taint by default acceptable?\r\n1. Is the breaking change of removing the `azure.com/aci` taint in the helm chart acceptable?\r\n\r\nThese changes have not been tested (and probably break something) so I'll only remove the WIP tag from this PR after I've done more validation.","created_at":"2018-08-08T17:35:04Z","updated_at":"2018-08-08T17:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/305/commits","review_comments_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/305/comments","review_comment_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues/305/comments","statuses_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/statuses/a0c8a83273ee273d66cf00490ea3ed8597499146","head":{"label":"jlegrone:feature/provider-taint","ref":"feature/provider-taint","sha":"a0c8a83273ee273d66cf00490ea3ed8597499146","user":{"login":"jlegrone","id":6752382,"node_id":"MDQ6VXNlcjY3NTIzODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6752382?v=4","gravatar_id":"","url":"https://api.github.com/users/jlegrone","html_url":"https://github.com/jlegrone","followers_url":"https://api.github.com/users/jlegrone/followers","following_url":"https://api.github.com/users/jlegrone/following{/other_user}","gists_url":"https://api.github.com/users/jlegrone/gists{/gist_id}","starred_url":"https://api.github.com/users/jlegrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlegrone/subscriptions","organizations_url":"https://api.github.com/users/jlegrone/orgs","repos_url":"https://api.github.com/users/jlegrone/repos","events_url":"https://api.github.com/users/jlegrone/events{/privacy}","received_events_url":"https://api.github.com/users/jlegrone/received_events","type":"User","site_admin":false},"repo":{"id":140505180,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1MDUxODA=","name":"virtual-kubelet","full_name":"jlegrone/virtual-kubelet","owner":{"login":"jlegrone","id":6752382,"node_id":"MDQ6VXNlcjY3NTIzODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6752382?v=4","gravatar_id":"","url":"https://api.github.com/users/jlegrone","html_url":"https://github.com/jlegrone","followers_url":"https://api.github.com/users/jlegrone/followers","following_url":"https://api.github.com/users/jlegrone/following{/other_user}","gists_url":"https://api.github.com/users/jlegrone/gists{/gist_id}","starred_url":"https://api.github.com/users/jlegrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlegrone/subscriptions","organizations_url":"https://api.github.com/users/jlegrone/orgs","repos_url":"https://api.github.com/users/jlegrone/repos","events_url":"https://api.github.com/users/jlegrone/events{/privacy}","received_events_url":"https://api.github.com/users/jlegrone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlegrone/virtual-kubelet","description":"Virtual Kubelet is an open source Kubernetes kubelet implementation.","fork":true,"url":"https://api.github.com/repos/jlegrone/virtual-kubelet","forks_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/forks","keys_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/teams","hooks_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/hooks","issue_events_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/issues/events{/number}","events_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/events","assignees_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/assignees{/user}","branches_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/branches{/branch}","tags_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/tags","blobs_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/statuses/{sha}","languages_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/languages","stargazers_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/stargazers","contributors_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/contributors","subscribers_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/subscribers","subscription_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/subscription","commits_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/contents/{+path}","compare_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/merges","archive_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/downloads","issues_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/issues{/number}","pulls_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/pulls{/number}","milestones_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/milestones{/number}","notifications_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/labels{/name}","releases_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/releases{/id}","deployments_url":"https://api.github.com/repos/jlegrone/virtual-kubelet/deployments","created_at":"2018-07-11T01:22:50Z","updated_at":"2018-08-06T16:03:30Z","pushed_at":"2018-08-08T17:17:57Z","git_url":"git://github.com/jlegrone/virtual-kubelet.git","ssh_url":"git@github.com:jlegrone/virtual-kubelet.git","clone_url":"https://github.com/jlegrone/virtual-kubelet.git","svn_url":"https://github.com/jlegrone/virtual-kubelet","homepage":"","size":53777,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"virtual-kubelet:master","ref":"master","sha":"a00a88818b4aeeb2955c9681a8cff3cf5f6ea777","user":{"login":"virtual-kubelet","id":34250142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjUwMTQy","avatar_url":"https://avatars2.githubusercontent.com/u/34250142?v=4","gravatar_id":"","url":"https://api.github.com/users/virtual-kubelet","html_url":"https://github.com/virtual-kubelet","followers_url":"https://api.github.com/users/virtual-kubelet/followers","following_url":"https://api.github.com/users/virtual-kubelet/following{/other_user}","gists_url":"https://api.github.com/users/virtual-kubelet/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-kubelet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-kubelet/subscriptions","organizations_url":"https://api.github.com/users/virtual-kubelet/orgs","repos_url":"https://api.github.com/users/virtual-kubelet/repos","events_url":"https://api.github.com/users/virtual-kubelet/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-kubelet/received_events","type":"Organization","site_admin":false},"repo":{"id":113086028,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwODYwMjg=","name":"virtual-kubelet","full_name":"virtual-kubelet/virtual-kubelet","owner":{"login":"virtual-kubelet","id":34250142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjUwMTQy","avatar_url":"https://avatars2.githubusercontent.com/u/34250142?v=4","gravatar_id":"","url":"https://api.github.com/users/virtual-kubelet","html_url":"https://github.com/virtual-kubelet","followers_url":"https://api.github.com/users/virtual-kubelet/followers","following_url":"https://api.github.com/users/virtual-kubelet/following{/other_user}","gists_url":"https://api.github.com/users/virtual-kubelet/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-kubelet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-kubelet/subscriptions","organizations_url":"https://api.github.com/users/virtual-kubelet/orgs","repos_url":"https://api.github.com/users/virtual-kubelet/repos","events_url":"https://api.github.com/users/virtual-kubelet/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-kubelet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-kubelet/virtual-kubelet","description":"Virtual Kubelet is an open source Kubernetes kubelet implementation.","fork":false,"url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet","forks_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/forks","keys_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/teams","hooks_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/hooks","issue_events_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/events","assignees_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/tags","blobs_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/languages","stargazers_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/stargazers","contributors_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/contributors","subscribers_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/subscribers","subscription_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/subscription","commits_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues/comments{/number}","contents_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/merges","archive_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/downloads","issues_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/labels{/name}","releases_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/releases{/id}","deployments_url":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/deployments","created_at":"2017-12-04T19:32:57Z","updated_at":"2018-08-07T22:17:05Z","pushed_at":"2018-08-08T01:10:09Z","git_url":"git://github.com/virtual-kubelet/virtual-kubelet.git","ssh_url":"git@github.com:virtual-kubelet/virtual-kubelet.git","clone_url":"https://github.com/virtual-kubelet/virtual-kubelet.git","svn_url":"https://github.com/virtual-kubelet/virtual-kubelet","homepage":"","size":53965,"stargazers_count":1076,"watchers_count":1076,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":76,"watchers":1076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/305"},"html":{"href":"https://github.com/virtual-kubelet/virtual-kubelet/pull/305"},"issue":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues/305"},"comments":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-kubelet/virtual-kubelet/statuses/a0c8a83273ee273d66cf00490ea3ed8597499146"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":68,"deletions":21,"changed_files":6}}
{"actor":{"display_login":"jlegrone"}}