{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2106","repository_url":"https://api.github.com/repos/coreos/prometheus-operator","labels_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2106/labels{/name}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2106/comments","events_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2106/events","html_url":"https://github.com/coreos/prometheus-operator/issues/2106","id":378442711,"node_id":"MDU6SXNzdWUzNzg0NDI3MTE=","number":2106,"title":"[Question] why setting different livenessProbeInitialDelaySeconds for different versions","user":{"login":"christine-gong","id":38263789,"node_id":"MDQ6VXNlcjM4MjYzNzg5","avatar_url":"https://avatars3.githubusercontent.com/u/38263789?v=4","gravatar_id":"","url":"https://api.github.com/users/christine-gong","html_url":"https://github.com/christine-gong","followers_url":"https://api.github.com/users/christine-gong/followers","following_url":"https://api.github.com/users/christine-gong/following{/other_user}","gists_url":"https://api.github.com/users/christine-gong/gists{/gist_id}","starred_url":"https://api.github.com/users/christine-gong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christine-gong/subscriptions","organizations_url":"https://api.github.com/users/christine-gong/orgs","repos_url":"https://api.github.com/users/christine-gong/repos","events_url":"https://api.github.com/users/christine-gong/events{/privacy}","received_events_url":"https://api.github.com/users/christine-gong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-07T19:49:16Z","updated_at":"2018-11-09T07:29:20Z","closed_at":null,"author_association":"NONE","body":"I checked the master branch and release 0.18 branch, they both treated the livenessProbeInitialDelaySeconds (0.18) or livenessFailureThreshold (master) differently.\r\n\r\nThe version >= 1.8 or 2+ always gets much less time for liveness probe check.\r\ne.g. master https://github.com/coreos/prometheus-operator/blob/master/pkg/prometheus/statefulset.go#L519-L561\r\n\r\nrelease 0.18\r\nhttps://github.com/coreos/prometheus-operator/blob/release-0.18/pkg/prometheus/statefulset.go#L492-L538\r\n\r\nMay I know why? We are using prometheus operator version 0.18 and prometheus 2.2. And we saw some issues on our side, and thought it could be not enough time to get ready and get restarted by failing the liveness and readiness check\r\n\r\nAnd I checked the previous issues, looks like there is no way to configure those values from user side? \r\n"},"comment":{"url":"https://api.github.com/repos/coreos/prometheus-operator/issues/comments/437273957","html_url":"https://github.com/coreos/prometheus-operator/issues/2106#issuecomment-437273957","issue_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/2106","id":437273957,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzI3Mzk1Nw==","user":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T07:29:20Z","updated_at":"2018-11-09T07:29:20Z","author_association":"MEMBER","body":"I’d prefer to keep config options to a minimum. Could you do some experiments and figure out what time-outs would work for you? (You can set the Prometheus object to “paused: true” and then you can modify the underlying StatefulSet) With the data you gather we can look at whether we should really make it configurable or just bump the value to something more reasonable. What do you think? :)"}}
{"actor":{"display_login":"brancz"}}