{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/220515109","pull_request_review_id":158937419,"id":220515109,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDUxNTEwOQ==","diff_hunk":"@@ -717,19 +712,19 @@ ghostBookshelf.Model = ghostBookshelf.Model.extend({\n         }\n \n         return itemCollection.fetchPage(options).then(function formatResponse(response) {\n-            var data = {},\n-                models;\n+            const data = {};\n+            data.meta = {pagination: response.pagination};\n \n-            options.columns = requestedColumns;\n-            models = response.collection.toJSON(options);\n+            // Filtering attributes here so they are not leaked to api layer\n+            // where models are serialized to json and do not do more filtering\n+            data[tableName] = response.collection.models.map((model) => {\n+                if (requestedColumns) {\n+                    model.attributes = _.pick(model.attributes, requestedColumns);","path":"core/server/models/base/index.js","position":56,"original_position":27,"commit_id":"0cc31bdb87e7e367e346be2d6e1d97f11dce663a","original_commit_id":"957f9f4b02646d0385983eeadb3c326c2d3e5de0","user":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"body":"@allouis  This is an intended change. Before filtering was done in `toJSON` method with options being passed in. The filtering is meant to stay in this layer, but without calling `toJSON` there is no other good way to do it.","created_at":"2018-09-26T10:52:24Z","updated_at":"2018-09-26T10:52:24Z","html_url":"https://github.com/TryGhost/Ghost/pull/9899#discussion_r220515109","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/220515109"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9899#discussion_r220515109"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899"}},"in_reply_to_id":220472064},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899","id":217335038,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzM1MDM4","html_url":"https://github.com/TryGhost/Ghost/pull/9899","diff_url":"https://github.com/TryGhost/Ghost/pull/9899.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/9899.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9899","number":9899,"state":"open","locked":false,"title":"Removed toJSON serialization in findPage method","user":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"body":"[this](https://github.com/TryGhost/Ghost/blob/master/core/server/models/base/index.js#L668-L671) is hopefully gone forever :tada: \r\n\r\nrefs #9866\r\n\r\n- Removed toJSON call in findPage\r\n- Added JSON serialization on API layer\r\n- Corrected test suites to serialize fetched models to JSON","created_at":"2018-09-21T16:18:08Z","updated_at":"2018-09-26T10:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2685bbb6843c0414f11e6409437939891c32c02b","assignee":{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"assignees":[{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9899/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/0cc31bdb87e7e367e346be2d6e1d97f11dce663a","head":{"label":"gargol:no-json-post-find-page","ref":"no-json-post-find-page","sha":"0cc31bdb87e7e367e346be2d6e1d97f11dce663a","user":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"repo":{"id":22947893,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk0Nzg5Mw==","name":"Ghost","full_name":"gargol/Ghost","private":false,"owner":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gargol/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/gargol/Ghost","forks_url":"https://api.github.com/repos/gargol/Ghost/forks","keys_url":"https://api.github.com/repos/gargol/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gargol/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gargol/Ghost/teams","hooks_url":"https://api.github.com/repos/gargol/Ghost/hooks","issue_events_url":"https://api.github.com/repos/gargol/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/gargol/Ghost/events","assignees_url":"https://api.github.com/repos/gargol/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/gargol/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/gargol/Ghost/tags","blobs_url":"https://api.github.com/repos/gargol/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gargol/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gargol/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/gargol/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gargol/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/gargol/Ghost/languages","stargazers_url":"https://api.github.com/repos/gargol/Ghost/stargazers","contributors_url":"https://api.github.com/repos/gargol/Ghost/contributors","subscribers_url":"https://api.github.com/repos/gargol/Ghost/subscribers","subscription_url":"https://api.github.com/repos/gargol/Ghost/subscription","commits_url":"https://api.github.com/repos/gargol/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/gargol/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/gargol/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/gargol/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/gargol/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/gargol/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gargol/Ghost/merges","archive_url":"https://api.github.com/repos/gargol/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gargol/Ghost/downloads","issues_url":"https://api.github.com/repos/gargol/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/gargol/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/gargol/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/gargol/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gargol/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/gargol/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/gargol/Ghost/deployments","created_at":"2014-08-14T09:07:42Z","updated_at":"2018-09-04T16:30:49Z","pushed_at":"2018-09-26T10:47:21Z","git_url":"git://github.com/gargol/Ghost.git","ssh_url":"git@github.com:gargol/Ghost.git","clone_url":"https://github.com/gargol/Ghost.git","svn_url":"https://github.com/gargol/Ghost","homepage":"https://ghost.org","size":26500,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"7b950f63825adb1622266863891f14060b95a58a","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUyOTE4","name":"Ghost","full_name":"TryGhost/Ghost","private":false,"owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TryGhost/Ghost","description":"The platform for professional publishers","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2018-09-26T10:16:18Z","pushed_at":"2018-09-26T10:47:29Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":33243,"stargazers_count":27461,"watchers_count":27461,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5909,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5909,"open_issues":140,"watchers":27461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9899"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9899"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9899/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9899/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/0cc31bdb87e7e367e346be2d6e1d97f11dce663a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gargol"}}