{"action":"created","comment":{"url":"https://api.github.com/repos/iTowns/itowns/pulls/comments/169264842","pull_request_review_id":97760676,"id":169264842,"diff_hunk":"@@ -79,6 +87,44 @@ function View(crs, viewerDiv, options = {}) {\n     if (__DEBUG__) {\n         this.isDebugMode = true;\n     }\n+\n+    if (options.loadingScreen !== false) {","path":"src/Core/View.js","position":33,"original_position":33,"commit_id":"13cc51fb33ada139811bf1febceba7d69f467327","original_commit_id":"13cc51fb33ada139811bf1febceba7d69f467327","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars3.githubusercontent.com/u/2198295?v=4","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"body":"I don't think so.\r\nA default loading screen doesn't cost us much and provide a nicer default experience (see https://github.com/iTowns/itowns/pull/636#issuecomment-363471759 for a more elaborate answer).","created_at":"2018-02-20T09:51:37Z","updated_at":"2018-02-20T09:51:37Z","html_url":"https://github.com/iTowns/itowns/pull/636#discussion_r169264842","pull_request_url":"https://api.github.com/repos/iTowns/itowns/pulls/636","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns/pulls/comments/169264842"},"html":{"href":"https://github.com/iTowns/itowns/pull/636#discussion_r169264842"},"pull_request":{"href":"https://api.github.com/repos/iTowns/itowns/pulls/636"}},"in_reply_to_id":169263600},"pull_request":{"url":"https://api.github.com/repos/iTowns/itowns/pulls/636","id":166814845,"html_url":"https://github.com/iTowns/itowns/pull/636","diff_url":"https://github.com/iTowns/itowns/pull/636.diff","patch_url":"https://github.com/iTowns/itowns/pull/636.patch","issue_url":"https://api.github.com/repos/iTowns/itowns/issues/636","number":636,"state":"open","locked":false,"title":"feat(core): add a loading screen","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars3.githubusercontent.com/u/2198295?v=4","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"body":"This PR adds a simple feature: a loading screen displaying an animated\r\nitowns logo while waiting for the View to be ready to display.\r\n\r\nThe loading screen is also dismissed after 3 sec as well.\r\n\r\nThis feature can be disabled, using the disableLoadingScreen View option.\r\n\r\nLoading screen logo :\r\n\r\n![capture d ecran de 2018-02-02 15-20-44](https://user-images.githubusercontent.com/2198295/35737876-4e86177c-082d-11e8-8b6e-ffe04ce54385.png)\r\n","created_at":"2018-02-02T14:25:49Z","updated_at":"2018-02-20T09:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85c37f83ce179f93ca223f4b014b6f9e4f655c88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iTowns/itowns/pulls/636/commits","review_comments_url":"https://api.github.com/repos/iTowns/itowns/pulls/636/comments","review_comment_url":"https://api.github.com/repos/iTowns/itowns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iTowns/itowns/issues/636/comments","statuses_url":"https://api.github.com/repos/iTowns/itowns/statuses/13cc51fb33ada139811bf1febceba7d69f467327","head":{"label":"iTowns:loading_screen","ref":"loading_screen","sha":"13cc51fb33ada139811bf1febceba7d69f467327","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars2.githubusercontent.com/u/14266889?v=4","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns","full_name":"iTowns/itowns","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars2.githubusercontent.com/u/14266889?v=4","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns","description":"A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data","fork":false,"url":"https://api.github.com/repos/iTowns/itowns","forks_url":"https://api.github.com/repos/iTowns/itowns/forks","keys_url":"https://api.github.com/repos/iTowns/itowns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns/events","assignees_url":"https://api.github.com/repos/iTowns/itowns/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns/merges","archive_url":"https://api.github.com/repos/iTowns/itowns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2018-02-19T15:01:26Z","pushed_at":"2018-02-20T09:40:42Z","git_url":"git://github.com/iTowns/itowns.git","ssh_url":"git@github.com:iTowns/itowns.git","clone_url":"https://github.com/iTowns/itowns.git","svn_url":"https://github.com/iTowns/itowns","homepage":"http://www.itowns-project.org","size":5993,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":50,"open_issues":84,"watchers":83,"default_branch":"master"}},"base":{"label":"iTowns:master","ref":"master","sha":"861114c68bc6a20c442aab3cf182a37f7ee4f31d","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars2.githubusercontent.com/u/14266889?v=4","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns","full_name":"iTowns/itowns","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars2.githubusercontent.com/u/14266889?v=4","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns","description":"A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data","fork":false,"url":"https://api.github.com/repos/iTowns/itowns","forks_url":"https://api.github.com/repos/iTowns/itowns/forks","keys_url":"https://api.github.com/repos/iTowns/itowns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns/events","assignees_url":"https://api.github.com/repos/iTowns/itowns/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns/merges","archive_url":"https://api.github.com/repos/iTowns/itowns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2018-02-19T15:01:26Z","pushed_at":"2018-02-20T09:40:42Z","git_url":"git://github.com/iTowns/itowns.git","ssh_url":"git@github.com:iTowns/itowns.git","clone_url":"https://github.com/iTowns/itowns.git","svn_url":"https://github.com/iTowns/itowns","homepage":"http://www.itowns-project.org","size":5993,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":50,"open_issues":84,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns/pulls/636"},"html":{"href":"https://github.com/iTowns/itowns/pull/636"},"issue":{"href":"https://api.github.com/repos/iTowns/itowns/issues/636"},"comments":{"href":"https://api.github.com/repos/iTowns/itowns/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/iTowns/itowns/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/iTowns/itowns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iTowns/itowns/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/iTowns/itowns/statuses/13cc51fb33ada139811bf1febceba7d69f467327"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"peppsac"}}