{"action":"closed","number":295,"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/295","id":209658730,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjU4NzMw","html_url":"https://github.com/GoogleContainerTools/kaniko/pull/295","diff_url":"https://github.com/GoogleContainerTools/kaniko/pull/295.diff","patch_url":"https://github.com/GoogleContainerTools/kaniko/pull/295.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/295","number":295,"state":"closed","locked":false,"title":"Fix bug in SaveStage function for multistage builds","user":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"body":"This change should fix the bug in #294, where kaniko wasn't recognizing\r\nthat a stage would be used in a later build and so wasn't saving it as a\r\ntarball.\r\n\r\nEach stage of the Dockerfile has a Name and a BaseName (FROM BaseName as\r\nName), but if a Name isn't specified then it's set to the same value as\r\nBaseName. Our test cases weren't complete enough to catch this\r\ndistinction, which is why this bug occurred.\r\n\r\nI added more test cases to the unit tests to make sure this fix works.","created_at":"2018-08-20T22:15:57Z","updated_at":"2018-08-21T20:15:11Z","closed_at":"2018-08-21T20:15:11Z","merged_at":"2018-08-21T20:15:11Z","merge_commit_sha":"8f71b7fb260cd08f1acd9b7854df9a82a444382c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/295/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/295/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/295/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/statuses/5e5623e5a495bd502d8bc00f5ca5f78f814958d6","head":{"label":"priyawadhwa:multistage","ref":"multistage","sha":"5e5623e5a495bd502d8bc00f5ca5f78f814958d6","user":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"repo":{"id":129780332,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3ODAzMzI=","name":"kaniko","full_name":"priyawadhwa/kaniko","owner":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priyawadhwa/kaniko","description":null,"fork":true,"url":"https://api.github.com/repos/priyawadhwa/kaniko","forks_url":"https://api.github.com/repos/priyawadhwa/kaniko/forks","keys_url":"https://api.github.com/repos/priyawadhwa/kaniko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priyawadhwa/kaniko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priyawadhwa/kaniko/teams","hooks_url":"https://api.github.com/repos/priyawadhwa/kaniko/hooks","issue_events_url":"https://api.github.com/repos/priyawadhwa/kaniko/issues/events{/number}","events_url":"https://api.github.com/repos/priyawadhwa/kaniko/events","assignees_url":"https://api.github.com/repos/priyawadhwa/kaniko/assignees{/user}","branches_url":"https://api.github.com/repos/priyawadhwa/kaniko/branches{/branch}","tags_url":"https://api.github.com/repos/priyawadhwa/kaniko/tags","blobs_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/refs{/sha}","trees_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priyawadhwa/kaniko/statuses/{sha}","languages_url":"https://api.github.com/repos/priyawadhwa/kaniko/languages","stargazers_url":"https://api.github.com/repos/priyawadhwa/kaniko/stargazers","contributors_url":"https://api.github.com/repos/priyawadhwa/kaniko/contributors","subscribers_url":"https://api.github.com/repos/priyawadhwa/kaniko/subscribers","subscription_url":"https://api.github.com/repos/priyawadhwa/kaniko/subscription","commits_url":"https://api.github.com/repos/priyawadhwa/kaniko/commits{/sha}","git_commits_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/commits{/sha}","comments_url":"https://api.github.com/repos/priyawadhwa/kaniko/comments{/number}","issue_comment_url":"https://api.github.com/repos/priyawadhwa/kaniko/issues/comments{/number}","contents_url":"https://api.github.com/repos/priyawadhwa/kaniko/contents/{+path}","compare_url":"https://api.github.com/repos/priyawadhwa/kaniko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priyawadhwa/kaniko/merges","archive_url":"https://api.github.com/repos/priyawadhwa/kaniko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priyawadhwa/kaniko/downloads","issues_url":"https://api.github.com/repos/priyawadhwa/kaniko/issues{/number}","pulls_url":"https://api.github.com/repos/priyawadhwa/kaniko/pulls{/number}","milestones_url":"https://api.github.com/repos/priyawadhwa/kaniko/milestones{/number}","notifications_url":"https://api.github.com/repos/priyawadhwa/kaniko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priyawadhwa/kaniko/labels{/name}","releases_url":"https://api.github.com/repos/priyawadhwa/kaniko/releases{/id}","deployments_url":"https://api.github.com/repos/priyawadhwa/kaniko/deployments","created_at":"2018-04-16T17:23:28Z","updated_at":"2018-08-20T21:10:33Z","pushed_at":"2018-08-20T22:15:15Z","git_url":"git://github.com/priyawadhwa/kaniko.git","ssh_url":"git@github.com:priyawadhwa/kaniko.git","clone_url":"https://github.com/priyawadhwa/kaniko.git","svn_url":"https://github.com/priyawadhwa/kaniko","homepage":null,"size":18066,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"8bc81fd1acfff4780391c9cdb659117709b4a337","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":119419195,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MTkxOTU=","name":"kaniko","full_name":"GoogleContainerTools/kaniko","owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleContainerTools/kaniko","description":"Build Container Images In Kubernetes","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/kaniko","forks_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/deployments","created_at":"2018-01-29T17:53:54Z","updated_at":"2018-08-21T19:11:46Z","pushed_at":"2018-08-21T20:15:11Z","git_url":"git://github.com/GoogleContainerTools/kaniko.git","ssh_url":"git@github.com:GoogleContainerTools/kaniko.git","clone_url":"https://github.com/GoogleContainerTools/kaniko.git","svn_url":"https://github.com/GoogleContainerTools/kaniko","homepage":"","size":15368,"stargazers_count":1957,"watchers_count":1957,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":106,"open_issues":36,"watchers":1957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/295"},"html":{"href":"https://github.com/GoogleContainerTools/kaniko/pull/295"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/295"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/statuses/5e5623e5a495bd502d8bc00f5ca5f78f814958d6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":32,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"priyawadhwa"}}