{"action":"closed","issue":{"url":"https://api.github.com/repos/crs4/pydoop/issues/246","repository_url":"https://api.github.com/repos/crs4/pydoop","labels_url":"https://api.github.com/repos/crs4/pydoop/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/crs4/pydoop/issues/246/comments","events_url":"https://api.github.com/repos/crs4/pydoop/issues/246/events","html_url":"https://github.com/crs4/pydoop/issues/246","id":277439567,"number":246,"title":"Review simulator example","user":{"login":"simleo","id":1183171,"avatar_url":"https://avatars2.githubusercontent.com/u/1183171?v=4","gravatar_id":"","url":"https://api.github.com/users/simleo","html_url":"https://github.com/simleo","followers_url":"https://api.github.com/users/simleo/followers","following_url":"https://api.github.com/users/simleo/following{/other_user}","gists_url":"https://api.github.com/users/simleo/gists{/gist_id}","starred_url":"https://api.github.com/users/simleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simleo/subscriptions","organizations_url":"https://api.github.com/users/simleo/orgs","repos_url":"https://api.github.com/users/simleo/repos","events_url":"https://api.github.com/users/simleo/events{/privacy}","received_events_url":"https://api.github.com/users/simleo/received_events","type":"User","site_admin":false},"labels":[{"id":42168318,"url":"https://api.github.com/repos/crs4/pydoop/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"simleo","id":1183171,"avatar_url":"https://avatars2.githubusercontent.com/u/1183171?v=4","gravatar_id":"","url":"https://api.github.com/users/simleo","html_url":"https://github.com/simleo","followers_url":"https://api.github.com/users/simleo/followers","following_url":"https://api.github.com/users/simleo/following{/other_user}","gists_url":"https://api.github.com/users/simleo/gists{/gist_id}","starred_url":"https://api.github.com/users/simleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simleo/subscriptions","organizations_url":"https://api.github.com/users/simleo/orgs","repos_url":"https://api.github.com/users/simleo/repos","events_url":"https://api.github.com/users/simleo/events{/privacy}","received_events_url":"https://api.github.com/users/simleo/received_events","type":"User","site_admin":false},"assignees":[{"login":"simleo","id":1183171,"avatar_url":"https://avatars2.githubusercontent.com/u/1183171?v=4","gravatar_id":"","url":"https://api.github.com/users/simleo","html_url":"https://github.com/simleo","followers_url":"https://api.github.com/users/simleo/followers","following_url":"https://api.github.com/users/simleo/following{/other_user}","gists_url":"https://api.github.com/users/simleo/gists{/gist_id}","starred_url":"https://api.github.com/users/simleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simleo/subscriptions","organizations_url":"https://api.github.com/users/simleo/orgs","repos_url":"https://api.github.com/users/simleo/repos","events_url":"https://api.github.com/users/simleo/events{/privacy}","received_events_url":"https://api.github.com/users/simleo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-11-28T16:02:41Z","updated_at":"2018-02-07T19:20:00Z","closed_at":"2018-02-07T19:20:00Z","author_association":"OWNER","body":"* Errors do not cause an error exit (e.g., https://travis-ci.org/crs4/pydoop/jobs/307809214#L3681).\r\n* There's [an unconditional return](https://github.com/crs4/pydoop/blob/368e3d7d6010765c64b48636c8a49b47e120de53/examples/simulator/run.py#L252) after the first two tests, likely a leftover from a debugging session.\r\n* Some tests assume a specific output file name pattern, i.e., the old Hadoop default of `'part-\\d{5}'`. The current default is actually `part-[mr]-\\d{5}`, but record writers are free to use a different scheme.\r\n* `DATA_OUT` should use the `tempfile` module instead of hardcoding `/tmp`."}}
{"actor":{"display_login":"elzaggo"}}