{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/222092310","pull_request_review_id":160898274,"id":222092310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjA5MjMxMA==","diff_hunk":"@@ -68,14 +68,33 @@ public boolean hasNoWorker(String modelName) {\n         return worker.isEmpty();\n     }\n \n+    public boolean getWorkerStatus(String modelName) {\n+        boolean status = true;\n+        List<WorkerThread> threads = workers.getOrDefault(modelName, null);\n+\n+        if (threads == null) {\n+            return true;\n+        }\n+\n+        for (WorkerThread thread : threads) {\n+            if ((thread.getState() == WorkerState.WORKER_STOPPED)\n+                    || (thread.getState() == WorkerState.WORKER_ERROR)) {\n+                status = false;\n+                break;\n+            }\n+        }\n+\n+        return status;\n+    }\n+\n     public CompletableFuture<Boolean> modelChanged(Model model) {\n         synchronized (model.getModelName()) {\n+            CompletableFuture<Boolean> future = new CompletableFuture<>();","path":"frontend/server/src/main/java/com/amazonaws/ml/mms/wlm/WorkLoadManager.java","position":25,"original_position":25,"commit_id":"2eccbaced3fae02f9d9db1bb5feb05365fa41f67","original_commit_id":"2eccbaced3fae02f9d9db1bb5feb05365fa41f67","user":{"login":"frankfliu","id":24425551,"node_id":"MDQ6VXNlcjI0NDI1NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/24425551?v=4","gravatar_id":"","url":"https://api.github.com/users/frankfliu","html_url":"https://github.com/frankfliu","followers_url":"https://api.github.com/users/frankfliu/followers","following_url":"https://api.github.com/users/frankfliu/following{/other_user}","gists_url":"https://api.github.com/users/frankfliu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankfliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankfliu/subscriptions","organizations_url":"https://api.github.com/users/frankfliu/orgs","repos_url":"https://api.github.com/users/frankfliu/repos","events_url":"https://api.github.com/users/frankfliu/events{/privacy}","received_events_url":"https://api.github.com/users/frankfliu/received_events","type":"User","site_admin":false},"body":"Thanks for making this change.","created_at":"2018-10-02T20:01:54Z","updated_at":"2018-10-02T20:04:50Z","html_url":"https://github.com/awslabs/mxnet-model-server/pull/558#discussion_r222092310","pull_request_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/222092310"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/558#discussion_r222092310"},"pull_request":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558","id":219543478,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTQzNDc4","html_url":"https://github.com/awslabs/mxnet-model-server/pull/558","diff_url":"https://github.com/awslabs/mxnet-model-server/pull/558.diff","patch_url":"https://github.com/awslabs/mxnet-model-server/pull/558.patch","issue_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/558","number":558,"state":"open","locked":false,"title":"Added better logging for failed sync calls","user":{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\nMade error messages more consistent to reflect current state of the system.\r\n*Description of changes:*\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-10-01T23:16:19Z","updated_at":"2018-10-02T20:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59723c00a5189476225dbdd6427b937dff521b61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558/commits","review_comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558/comments","review_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/558/comments","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/2eccbaced3fae02f9d9db1bb5feb05365fa41f67","head":{"label":"vdantu:sync_scale_error","ref":"sync_scale_error","sha":"2eccbaced3fae02f9d9db1bb5feb05365fa41f67","user":{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"repo":{"id":120691512,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2OTE1MTI=","name":"mxnet-model-server","full_name":"vdantu/mxnet-model-server","private":false,"owner":{"login":"vdantu","id":36211508,"node_id":"MDQ6VXNlcjM2MjExNTA4","avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vdantu/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for deploying neural net models for inference","fork":true,"url":"https://api.github.com/repos/vdantu/mxnet-model-server","forks_url":"https://api.github.com/repos/vdantu/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/vdantu/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdantu/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdantu/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/vdantu/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/vdantu/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/vdantu/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/vdantu/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/vdantu/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdantu/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vdantu/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/vdantu/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/vdantu/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/vdantu/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/vdantu/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/vdantu/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdantu/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdantu/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/vdantu/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdantu/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/vdantu/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdantu/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/vdantu/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vdantu/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vdantu/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdantu/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/vdantu/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/vdantu/mxnet-model-server/deployments","created_at":"2018-02-08T00:55:11Z","updated_at":"2018-08-05T20:17:45Z","pushed_at":"2018-10-02T19:48:52Z","git_url":"git://github.com/vdantu/mxnet-model-server.git","ssh_url":"git@github.com:vdantu/mxnet-model-server.git","clone_url":"https://github.com/vdantu/mxnet-model-server.git","svn_url":"https://github.com/vdantu/mxnet-model-server","homepage":"","size":36617,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"awslabs:netty","ref":"netty","sha":"2f069d6c7c9017e5edcaa8e224d4ca4fcf36ff94","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105830539,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MzA1Mzk=","name":"mxnet-model-server","full_name":"awslabs/mxnet-model-server","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for serving neural net models for inference","fork":false,"url":"https://api.github.com/repos/awslabs/mxnet-model-server","forks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/awslabs/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/awslabs/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/deployments","created_at":"2017-10-04T23:41:07Z","updated_at":"2018-10-01T11:16:43Z","pushed_at":"2018-10-02T19:55:06Z","git_url":"git://github.com/awslabs/mxnet-model-server.git","ssh_url":"git@github.com:awslabs/mxnet-model-server.git","clone_url":"https://github.com/awslabs/mxnet-model-server.git","svn_url":"https://github.com/awslabs/mxnet-model-server","homepage":"","size":36578,"stargazers_count":316,"watchers_count":316,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":69,"open_issues":55,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/558"},"issue":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/558"},"comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/2eccbaced3fae02f9d9db1bb5feb05365fa41f67"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"frankfliu"}}