{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/2743","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/2743/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2743/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/2743/events","html_url":"https://github.com/apache/cloudstack/pull/2743","id":341058573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzIxOTc3","number":2743,"title":"CLOUDSTACK-10380: Fix startvm giving another pw after pw reset","user":{"login":"smeetsr","id":26001362,"node_id":"MDQ6VXNlcjI2MDAxMzYy","avatar_url":"https://avatars2.githubusercontent.com/u/26001362?v=4","gravatar_id":"","url":"https://api.github.com/users/smeetsr","html_url":"https://github.com/smeetsr","followers_url":"https://api.github.com/users/smeetsr/followers","following_url":"https://api.github.com/users/smeetsr/following{/other_user}","gists_url":"https://api.github.com/users/smeetsr/gists{/gist_id}","starred_url":"https://api.github.com/users/smeetsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smeetsr/subscriptions","organizations_url":"https://api.github.com/users/smeetsr/orgs","repos_url":"https://api.github.com/users/smeetsr/repos","events_url":"https://api.github.com/users/smeetsr/events{/privacy}","received_events_url":"https://api.github.com/users/smeetsr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-13T15:16:40Z","updated_at":"2018-07-30T10:05:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2743","html_url":"https://github.com/apache/cloudstack/pull/2743","diff_url":"https://github.com/apache/cloudstack/pull/2743.diff","patch_url":"https://github.com/apache/cloudstack/pull/2743.patch"},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\n* When password reset is called, and VR accepts it, set vm updateParameters to false.\r\n* When password reset is called, and SSH key is set, make sure the password isn't removed again.\r\n* Fix Marvin tests\r\n* Make sure saveDetails keeps the display value of the existing details.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (improves an existing feature and functionality)\r\n- [x] Cleanup (Code refactoring and cleanup, that may add test cases)\r\n\r\n## How Has This Been Tested?\r\n - Manual \r\n - automated marvin pugins nuagevsp tests on ACS + NuageVsp\r\n - automated marvin component test for config drive\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\nTesting\r\n- [x] I have added tests to cover my changes.\r\n- [ ] All relevant new and existing integration tests have passed.\r\n- [ ] A full integration testsuite with all test that can run on my environment has passed."},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/408813363","html_url":"https://github.com/apache/cloudstack/pull/2743#issuecomment-408813363","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2743","id":408813363,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODgxMzM2Mw==","user":{"login":"fmaximus","id":2563216,"node_id":"MDQ6VXNlcjI1NjMyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2563216?v=4","gravatar_id":"","url":"https://api.github.com/users/fmaximus","html_url":"https://github.com/fmaximus","followers_url":"https://api.github.com/users/fmaximus/followers","following_url":"https://api.github.com/users/fmaximus/following{/other_user}","gists_url":"https://api.github.com/users/fmaximus/gists{/gist_id}","starred_url":"https://api.github.com/users/fmaximus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmaximus/subscriptions","organizations_url":"https://api.github.com/users/fmaximus/orgs","repos_url":"https://api.github.com/users/fmaximus/repos","events_url":"https://api.github.com/users/fmaximus/events{/privacy}","received_events_url":"https://api.github.com/users/fmaximus/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T10:05:23Z","updated_at":"2018-07-30T10:05:23Z","author_association":"CONTRIBUTOR","body":"@borisstoyanov The Marvin test failures you mention seem to refer to an older version of `test_configdrive`. Also even though the import says `retry` the library is named `retries` (there are about 5 retry libraries around). "}}
{"actor":{"display_login":"fmaximus"}}