{"action":"closed","number":60,"pull_request":{"url":"https://api.github.com/repos/enjoy-digital/litex/pulls/60","id":164460368,"html_url":"https://github.com/enjoy-digital/litex/pull/60","diff_url":"https://github.com/enjoy-digital/litex/pull/60.diff","patch_url":"https://github.com/enjoy-digital/litex/pull/60.patch","issue_url":"https://api.github.com/repos/enjoy-digital/litex/issues/60","number":60,"state":"closed","locked":false,"title":"Top module selection (for Verilator and Diamond)","user":{"login":"q3k","id":315234,"avatar_url":"https://avatars0.githubusercontent.com/u/315234?v=4","gravatar_id":"","url":"https://api.github.com/users/q3k","html_url":"https://github.com/q3k","followers_url":"https://api.github.com/users/q3k/followers","following_url":"https://api.github.com/users/q3k/following{/other_user}","gists_url":"https://api.github.com/users/q3k/gists{/gist_id}","starred_url":"https://api.github.com/users/q3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/q3k/subscriptions","organizations_url":"https://api.github.com/users/q3k/orgs","repos_url":"https://api.github.com/users/q3k/repos","events_url":"https://api.github.com/users/q3k/events{/privacy}","received_events_url":"https://api.github.com/users/q3k/received_events","type":"User","site_admin":false},"body":"When dealing with multiple Verilog sources in a design we must explicitly state which module is the top of the design. This change ensures such a selection is made when building designs using Verilator and Lattice Diamond.\r\n\r\nWhile the changes have been tested to work, I am not sure if this is the right way to go about this. Please review carefully.","created_at":"2018-01-23T01:24:00Z","updated_at":"2018-02-19T11:27:25Z","closed_at":"2018-02-19T11:27:25Z","merged_at":"2018-02-19T11:27:25Z","merge_commit_sha":"55fc9d2d6bdc343f569ded3ab3415f260f2a96ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enjoy-digital/litex/pulls/60/commits","review_comments_url":"https://api.github.com/repos/enjoy-digital/litex/pulls/60/comments","review_comment_url":"https://api.github.com/repos/enjoy-digital/litex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enjoy-digital/litex/issues/60/comments","statuses_url":"https://api.github.com/repos/enjoy-digital/litex/statuses/ef511e7edcddf7b13c56a5e41c08042801bee9ff","head":{"label":"q3k:for-upstream/top-level-module-selection","ref":"for-upstream/top-level-module-selection","sha":"ef511e7edcddf7b13c56a5e41c08042801bee9ff","user":{"login":"q3k","id":315234,"avatar_url":"https://avatars0.githubusercontent.com/u/315234?v=4","gravatar_id":"","url":"https://api.github.com/users/q3k","html_url":"https://github.com/q3k","followers_url":"https://api.github.com/users/q3k/followers","following_url":"https://api.github.com/users/q3k/following{/other_user}","gists_url":"https://api.github.com/users/q3k/gists{/gist_id}","starred_url":"https://api.github.com/users/q3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/q3k/subscriptions","organizations_url":"https://api.github.com/users/q3k/orgs","repos_url":"https://api.github.com/users/q3k/repos","events_url":"https://api.github.com/users/q3k/events{/privacy}","received_events_url":"https://api.github.com/users/q3k/received_events","type":"User","site_admin":false},"repo":{"id":96211602,"name":"litex","full_name":"q3k/litex","owner":{"login":"q3k","id":315234,"avatar_url":"https://avatars0.githubusercontent.com/u/315234?v=4","gravatar_id":"","url":"https://api.github.com/users/q3k","html_url":"https://github.com/q3k","followers_url":"https://api.github.com/users/q3k/followers","following_url":"https://api.github.com/users/q3k/following{/other_user}","gists_url":"https://api.github.com/users/q3k/gists{/gist_id}","starred_url":"https://api.github.com/users/q3k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/q3k/subscriptions","organizations_url":"https://api.github.com/users/q3k/orgs","repos_url":"https://api.github.com/users/q3k/repos","events_url":"https://api.github.com/users/q3k/events{/privacy}","received_events_url":"https://api.github.com/users/q3k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/q3k/litex","description":"Build your hardware, easily!","fork":true,"url":"https://api.github.com/repos/q3k/litex","forks_url":"https://api.github.com/repos/q3k/litex/forks","keys_url":"https://api.github.com/repos/q3k/litex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/q3k/litex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/q3k/litex/teams","hooks_url":"https://api.github.com/repos/q3k/litex/hooks","issue_events_url":"https://api.github.com/repos/q3k/litex/issues/events{/number}","events_url":"https://api.github.com/repos/q3k/litex/events","assignees_url":"https://api.github.com/repos/q3k/litex/assignees{/user}","branches_url":"https://api.github.com/repos/q3k/litex/branches{/branch}","tags_url":"https://api.github.com/repos/q3k/litex/tags","blobs_url":"https://api.github.com/repos/q3k/litex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/q3k/litex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/q3k/litex/git/refs{/sha}","trees_url":"https://api.github.com/repos/q3k/litex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/q3k/litex/statuses/{sha}","languages_url":"https://api.github.com/repos/q3k/litex/languages","stargazers_url":"https://api.github.com/repos/q3k/litex/stargazers","contributors_url":"https://api.github.com/repos/q3k/litex/contributors","subscribers_url":"https://api.github.com/repos/q3k/litex/subscribers","subscription_url":"https://api.github.com/repos/q3k/litex/subscription","commits_url":"https://api.github.com/repos/q3k/litex/commits{/sha}","git_commits_url":"https://api.github.com/repos/q3k/litex/git/commits{/sha}","comments_url":"https://api.github.com/repos/q3k/litex/comments{/number}","issue_comment_url":"https://api.github.com/repos/q3k/litex/issues/comments{/number}","contents_url":"https://api.github.com/repos/q3k/litex/contents/{+path}","compare_url":"https://api.github.com/repos/q3k/litex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/q3k/litex/merges","archive_url":"https://api.github.com/repos/q3k/litex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/q3k/litex/downloads","issues_url":"https://api.github.com/repos/q3k/litex/issues{/number}","pulls_url":"https://api.github.com/repos/q3k/litex/pulls{/number}","milestones_url":"https://api.github.com/repos/q3k/litex/milestones{/number}","notifications_url":"https://api.github.com/repos/q3k/litex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/q3k/litex/labels{/name}","releases_url":"https://api.github.com/repos/q3k/litex/releases{/id}","deployments_url":"https://api.github.com/repos/q3k/litex/deployments","created_at":"2017-07-04T11:38:07Z","updated_at":"2017-07-04T11:38:10Z","pushed_at":"2018-01-23T01:18:31Z","git_url":"git://github.com/q3k/litex.git","ssh_url":"git@github.com:q3k/litex.git","clone_url":"https://github.com/q3k/litex.git","svn_url":"https://github.com/q3k/litex","homepage":"","size":7209,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"enjoy-digital:master","ref":"master","sha":"a385143779d355ee856c570bdc5fdd72c088db45","user":{"login":"enjoy-digital","id":1450143,"avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"repo":{"id":45734719,"name":"litex","full_name":"enjoy-digital/litex","owner":{"login":"enjoy-digital","id":1450143,"avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enjoy-digital/litex","description":"Build your hardware, easily!","fork":false,"url":"https://api.github.com/repos/enjoy-digital/litex","forks_url":"https://api.github.com/repos/enjoy-digital/litex/forks","keys_url":"https://api.github.com/repos/enjoy-digital/litex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enjoy-digital/litex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enjoy-digital/litex/teams","hooks_url":"https://api.github.com/repos/enjoy-digital/litex/hooks","issue_events_url":"https://api.github.com/repos/enjoy-digital/litex/issues/events{/number}","events_url":"https://api.github.com/repos/enjoy-digital/litex/events","assignees_url":"https://api.github.com/repos/enjoy-digital/litex/assignees{/user}","branches_url":"https://api.github.com/repos/enjoy-digital/litex/branches{/branch}","tags_url":"https://api.github.com/repos/enjoy-digital/litex/tags","blobs_url":"https://api.github.com/repos/enjoy-digital/litex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enjoy-digital/litex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enjoy-digital/litex/git/refs{/sha}","trees_url":"https://api.github.com/repos/enjoy-digital/litex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enjoy-digital/litex/statuses/{sha}","languages_url":"https://api.github.com/repos/enjoy-digital/litex/languages","stargazers_url":"https://api.github.com/repos/enjoy-digital/litex/stargazers","contributors_url":"https://api.github.com/repos/enjoy-digital/litex/contributors","subscribers_url":"https://api.github.com/repos/enjoy-digital/litex/subscribers","subscription_url":"https://api.github.com/repos/enjoy-digital/litex/subscription","commits_url":"https://api.github.com/repos/enjoy-digital/litex/commits{/sha}","git_commits_url":"https://api.github.com/repos/enjoy-digital/litex/git/commits{/sha}","comments_url":"https://api.github.com/repos/enjoy-digital/litex/comments{/number}","issue_comment_url":"https://api.github.com/repos/enjoy-digital/litex/issues/comments{/number}","contents_url":"https://api.github.com/repos/enjoy-digital/litex/contents/{+path}","compare_url":"https://api.github.com/repos/enjoy-digital/litex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enjoy-digital/litex/merges","archive_url":"https://api.github.com/repos/enjoy-digital/litex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enjoy-digital/litex/downloads","issues_url":"https://api.github.com/repos/enjoy-digital/litex/issues{/number}","pulls_url":"https://api.github.com/repos/enjoy-digital/litex/pulls{/number}","milestones_url":"https://api.github.com/repos/enjoy-digital/litex/milestones{/number}","notifications_url":"https://api.github.com/repos/enjoy-digital/litex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enjoy-digital/litex/labels{/name}","releases_url":"https://api.github.com/repos/enjoy-digital/litex/releases{/id}","deployments_url":"https://api.github.com/repos/enjoy-digital/litex/deployments","created_at":"2015-11-07T12:02:12Z","updated_at":"2018-02-05T05:17:02Z","pushed_at":"2018-02-19T11:27:25Z","git_url":"git://github.com/enjoy-digital/litex.git","ssh_url":"git@github.com:enjoy-digital/litex.git","clone_url":"https://github.com/enjoy-digital/litex.git","svn_url":"https://github.com/enjoy-digital/litex","homepage":"","size":7213,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":25,"open_issues":5,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enjoy-digital/litex/pulls/60"},"html":{"href":"https://github.com/enjoy-digital/litex/pull/60"},"issue":{"href":"https://api.github.com/repos/enjoy-digital/litex/issues/60"},"comments":{"href":"https://api.github.com/repos/enjoy-digital/litex/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/enjoy-digital/litex/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/enjoy-digital/litex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enjoy-digital/litex/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/enjoy-digital/litex/statuses/ef511e7edcddf7b13c56a5e41c08042801bee9ff"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"enjoy-digital","id":1450143,"avatar_url":"https://avatars0.githubusercontent.com/u/1450143?v=4","gravatar_id":"","url":"https://api.github.com/users/enjoy-digital","html_url":"https://github.com/enjoy-digital","followers_url":"https://api.github.com/users/enjoy-digital/followers","following_url":"https://api.github.com/users/enjoy-digital/following{/other_user}","gists_url":"https://api.github.com/users/enjoy-digital/gists{/gist_id}","starred_url":"https://api.github.com/users/enjoy-digital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enjoy-digital/subscriptions","organizations_url":"https://api.github.com/users/enjoy-digital/orgs","repos_url":"https://api.github.com/users/enjoy-digital/repos","events_url":"https://api.github.com/users/enjoy-digital/events{/privacy}","received_events_url":"https://api.github.com/users/enjoy-digital/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"enjoy-digital"}}