{"action":"created","comment":{"url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/comments/210423655","pull_request_review_id":146637088,"id":210423655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQyMzY1NQ==","diff_hunk":"@@ -1,6 +1,6 @@\n ﻿using System;\n \n-namespace Ledger.Net\n+namespace Ledger.Net.Requests","path":"src/Ledger.Net/Requests/Abstract/RequestBase.cs","position":4,"original_position":4,"commit_id":"a29447486283a205b00688199a699292fb4cc9ba","original_commit_id":"a29447486283a205b00688199a699292fb4cc9ba","user":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"body":"Nice","created_at":"2018-08-15T22:01:16Z","updated_at":"2018-08-15T22:01:17Z","html_url":"https://github.com/MelbourneDeveloper/Ledger.Net/pull/3#discussion_r210423655","pull_request_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/comments/210423655"},"html":{"href":"https://github.com/MelbourneDeveloper/Ledger.Net/pull/3#discussion_r210423655"},"pull_request":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3","id":208675437,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Njc1NDM3","html_url":"https://github.com/MelbourneDeveloper/Ledger.Net/pull/3","diff_url":"https://github.com/MelbourneDeveloper/Ledger.Net/pull/3.diff","patch_url":"https://github.com/MelbourneDeveloper/Ledger.Net/pull/3.patch","issue_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues/3","number":3,"state":"open","locked":false,"title":"Fixed Ethereum address retrieval and refactored small parts of some classes/methods/folders","user":{"login":"ThatSlyGuy","id":19557547,"node_id":"MDQ6VXNlcjE5NTU3NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19557547?v=4","gravatar_id":"","url":"https://api.github.com/users/ThatSlyGuy","html_url":"https://github.com/ThatSlyGuy","followers_url":"https://api.github.com/users/ThatSlyGuy/followers","following_url":"https://api.github.com/users/ThatSlyGuy/following{/other_user}","gists_url":"https://api.github.com/users/ThatSlyGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatSlyGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatSlyGuy/subscriptions","organizations_url":"https://api.github.com/users/ThatSlyGuy/orgs","repos_url":"https://api.github.com/users/ThatSlyGuy/repos","events_url":"https://api.github.com/users/ThatSlyGuy/events{/privacy}","received_events_url":"https://api.github.com/users/ThatSlyGuy/received_events","type":"User","site_admin":false},"body":"Refer to commit change log for more details. \r\n\r\nI didn't want to change the way the RequestBase worked, so I used an intermediate class between RequestBase and EthereumAppGetPublicKeyRequest which is the GetPublicKeyRequestBase which makes a call to the PublicKeyHelpers class for the derivation path byte[] data.\r\n\r\nThere are probably way better ways of doing this but it was a quick solution that allowed me to clean up the GetAddressAsync methods in the LedgerManager which seemed worth it to me. ","created_at":"2018-08-15T20:41:44Z","updated_at":"2018-08-15T22:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a542486b45d0795e2c92f05ad0dca62d411652f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3/commits","review_comments_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3/comments","review_comment_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues/3/comments","statuses_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/statuses/a29447486283a205b00688199a699292fb4cc9ba","head":{"label":"ThatSlyGuy:master","ref":"master","sha":"a29447486283a205b00688199a699292fb4cc9ba","user":{"login":"ThatSlyGuy","id":19557547,"node_id":"MDQ6VXNlcjE5NTU3NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19557547?v=4","gravatar_id":"","url":"https://api.github.com/users/ThatSlyGuy","html_url":"https://github.com/ThatSlyGuy","followers_url":"https://api.github.com/users/ThatSlyGuy/followers","following_url":"https://api.github.com/users/ThatSlyGuy/following{/other_user}","gists_url":"https://api.github.com/users/ThatSlyGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatSlyGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatSlyGuy/subscriptions","organizations_url":"https://api.github.com/users/ThatSlyGuy/orgs","repos_url":"https://api.github.com/users/ThatSlyGuy/repos","events_url":"https://api.github.com/users/ThatSlyGuy/events{/privacy}","received_events_url":"https://api.github.com/users/ThatSlyGuy/received_events","type":"User","site_admin":false},"repo":{"id":144875663,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4NzU2NjM=","name":"Ledger.Net","full_name":"ThatSlyGuy/Ledger.Net","owner":{"login":"ThatSlyGuy","id":19557547,"node_id":"MDQ6VXNlcjE5NTU3NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19557547?v=4","gravatar_id":"","url":"https://api.github.com/users/ThatSlyGuy","html_url":"https://github.com/ThatSlyGuy","followers_url":"https://api.github.com/users/ThatSlyGuy/followers","following_url":"https://api.github.com/users/ThatSlyGuy/following{/other_user}","gists_url":"https://api.github.com/users/ThatSlyGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/ThatSlyGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThatSlyGuy/subscriptions","organizations_url":"https://api.github.com/users/ThatSlyGuy/orgs","repos_url":"https://api.github.com/users/ThatSlyGuy/repos","events_url":"https://api.github.com/users/ThatSlyGuy/events{/privacy}","received_events_url":"https://api.github.com/users/ThatSlyGuy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThatSlyGuy/Ledger.Net","description":"Cross Platform C# Library For Ledger Hardware Wallet","fork":true,"url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net","forks_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/forks","keys_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/teams","hooks_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/hooks","issue_events_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/issues/events{/number}","events_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/events","assignees_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/assignees{/user}","branches_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/branches{/branch}","tags_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/tags","blobs_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/statuses/{sha}","languages_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/languages","stargazers_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/stargazers","contributors_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/contributors","subscribers_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/subscribers","subscription_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/subscription","commits_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/contents/{+path}","compare_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/merges","archive_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/downloads","issues_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/issues{/number}","pulls_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/pulls{/number}","milestones_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/milestones{/number}","notifications_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/labels{/name}","releases_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/releases{/id}","deployments_url":"https://api.github.com/repos/ThatSlyGuy/Ledger.Net/deployments","created_at":"2018-08-15T16:14:43Z","updated_at":"2018-08-15T20:36:45Z","pushed_at":"2018-08-15T20:36:43Z","git_url":"git://github.com/ThatSlyGuy/Ledger.Net.git","ssh_url":"git@github.com:ThatSlyGuy/Ledger.Net.git","clone_url":"https://github.com/ThatSlyGuy/Ledger.Net.git","svn_url":"https://github.com/ThatSlyGuy/Ledger.Net","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MelbourneDeveloper:master","ref":"master","sha":"7e55b4fad0e72846d65cea10a1d81f2362feccbf","user":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"repo":{"id":143648108,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2NDgxMDg=","name":"Ledger.Net","full_name":"MelbourneDeveloper/Ledger.Net","owner":{"login":"MelbourneDeveloper","id":16697547,"node_id":"MDQ6VXNlcjE2Njk3NTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/16697547?v=4","gravatar_id":"","url":"https://api.github.com/users/MelbourneDeveloper","html_url":"https://github.com/MelbourneDeveloper","followers_url":"https://api.github.com/users/MelbourneDeveloper/followers","following_url":"https://api.github.com/users/MelbourneDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/MelbourneDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/MelbourneDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelbourneDeveloper/subscriptions","organizations_url":"https://api.github.com/users/MelbourneDeveloper/orgs","repos_url":"https://api.github.com/users/MelbourneDeveloper/repos","events_url":"https://api.github.com/users/MelbourneDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/MelbourneDeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MelbourneDeveloper/Ledger.Net","description":"Cross Platform C# Library For Ledger Hardware Wallet","fork":false,"url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net","forks_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/forks","keys_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/teams","hooks_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/hooks","issue_events_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues/events{/number}","events_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/events","assignees_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/assignees{/user}","branches_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/branches{/branch}","tags_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/tags","blobs_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/git/refs{/sha}","trees_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/statuses/{sha}","languages_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/languages","stargazers_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/stargazers","contributors_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/contributors","subscribers_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/subscribers","subscription_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/subscription","commits_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/commits{/sha}","git_commits_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/git/commits{/sha}","comments_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/comments{/number}","issue_comment_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues/comments{/number}","contents_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/contents/{+path}","compare_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/merges","archive_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/downloads","issues_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues{/number}","pulls_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls{/number}","milestones_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/milestones{/number}","notifications_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/labels{/name}","releases_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/releases{/id}","deployments_url":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/deployments","created_at":"2018-08-05T21:14:51Z","updated_at":"2018-08-15T12:20:28Z","pushed_at":"2018-08-15T22:00:31Z","git_url":"git://github.com/MelbourneDeveloper/Ledger.Net.git","ssh_url":"git@github.com:MelbourneDeveloper/Ledger.Net.git","clone_url":"https://github.com/MelbourneDeveloper/Ledger.Net.git","svn_url":"https://github.com/MelbourneDeveloper/Ledger.Net","homepage":null,"size":80,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3"},"html":{"href":"https://github.com/MelbourneDeveloper/Ledger.Net/pull/3"},"issue":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues/3"},"comments":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/MelbourneDeveloper/Ledger.Net/statuses/a29447486283a205b00688199a699292fb4cc9ba"}},"author_association":"NONE"}}
{"actor":{"display_login":"MelbourneDeveloper"}}