{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31288","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31288/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31288/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31288/events","html_url":"https://github.com/cockroachdb/cockroach/pull/31288","id":369304715,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjc5Mjk0","number":31288,"title":"importccl: parse zero mysql dates as null","user":{"login":"dt","id":15615,"node_id":"MDQ6VXNlcjE1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/15615?v=4","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-11T21:05:11Z","updated_at":"2018-10-11T21:05:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31288","html_url":"https://github.com/cockroachdb/cockroach/pull/31288","diff_url":"https://github.com/cockroachdb/cockroach/pull/31288.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/31288.patch"},"body":"these nonsense values are permitted by older / less strict mysql versions but have no cockroach counterpart -- a date is either null, or an actual date, which cannot have a zero day or month. Mapping these values to null is the closest we can get them, and in schemas that allow null values, hopefully makes migration easier. In schemas that do not allow nulls these will of course produce errors but we do not really have another option in those cases.\r\n\r\nRelease note: none."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/429118261","html_url":"https://github.com/cockroachdb/cockroach/pull/31288#issuecomment-429118261","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31288","id":429118261,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTExODI2MQ==","user":{"login":"cockroach-teamcity","id":20559710,"node_id":"MDQ6VXNlcjIwNTU5NzEw","avatar_url":"https://avatars0.githubusercontent.com/u/20559710?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroach-teamcity","html_url":"https://github.com/cockroach-teamcity","followers_url":"https://api.github.com/users/cockroach-teamcity/followers","following_url":"https://api.github.com/users/cockroach-teamcity/following{/other_user}","gists_url":"https://api.github.com/users/cockroach-teamcity/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroach-teamcity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroach-teamcity/subscriptions","organizations_url":"https://api.github.com/users/cockroach-teamcity/orgs","repos_url":"https://api.github.com/users/cockroach-teamcity/repos","events_url":"https://api.github.com/users/cockroach-teamcity/events{/privacy}","received_events_url":"https://api.github.com/users/cockroach-teamcity/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T21:05:17Z","updated_at":"2018-10-11T21:05:17Z","author_association":"MEMBER","body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.png\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/31288)\n<!-- Reviewable:end -->\n"}}
{"actor":{"display_login":"cockroach-teamcity"}}