{"action":"closed","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/13580","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/13580/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/13580/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/13580/events","html_url":"https://github.com/fastlane/fastlane/issues/13580","id":373029631,"node_id":"MDU6SXNzdWUzNzMwMjk2MzE=","number":13580,"title":"`commit_version_bump` after setting `automatic_code_signing` to FALSE","user":{"login":"Drwalcore","id":13233783,"node_id":"MDQ6VXNlcjEzMjMzNzgz","avatar_url":"https://avatars2.githubusercontent.com/u/13233783?v=4","gravatar_id":"","url":"https://api.github.com/users/Drwalcore","html_url":"https://github.com/Drwalcore","followers_url":"https://api.github.com/users/Drwalcore/followers","following_url":"https://api.github.com/users/Drwalcore/following{/other_user}","gists_url":"https://api.github.com/users/Drwalcore/gists{/gist_id}","starred_url":"https://api.github.com/users/Drwalcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drwalcore/subscriptions","organizations_url":"https://api.github.com/users/Drwalcore/orgs","repos_url":"https://api.github.com/users/Drwalcore/repos","events_url":"https://api.github.com/users/Drwalcore/events{/privacy}","received_events_url":"https://api.github.com/users/Drwalcore/received_events","type":"User","site_admin":false},"labels":[{"id":389827016,"node_id":"MDU6TGFiZWwzODk4MjcwMTY=","url":"https://api.github.com/repos/fastlane/fastlane/labels/status:%20waiting-for-reply","name":"status: waiting-for-reply","color":"ededed","default":false},{"id":351212709,"node_id":"MDU6TGFiZWwzNTEyMTI3MDk=","url":"https://api.github.com/repos/fastlane/fastlane/labels/tool:%20action","name":"tool: action","color":"d93f0b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-23T14:25:20Z","updated_at":"2018-12-27T17:34:47Z","closed_at":"2018-12-27T17:34:47Z","author_association":"NONE","body":"### Question Checklist\r\n\r\n- [x] Updated fastlane to the latest version\r\n- [x] I read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I read [docs.fastlane.tools](https://docs.fastlane.tools)\r\n- [x] I searched for [existing GitHub issues](https://github.com/fastlane/fastlane/issues)\r\n\r\n### Question Subject\r\n\r\nI'd like to `increment_build_number` and `commit_version_bump` to repository after setting `automatic_code_signing` to *false*.\r\n\r\n#### Question Description\r\n\r\n As I've observed both \r\n`automatic_code_signing(path: \"*.xcodeproj\", use_automatic_signing: false)`\r\nand\r\n`increment_build_number` [following documentation](\r\nhttps://docs.fastlane.tools/actions/commit_version_bump/#commit_version_bump), are touching *.xcodeproj/project.pbxproj* file. \r\n\r\nAs it is potentially allowed because no are no other uncommitted changes in repo, so it will commit `CODE_SIGN_MANUAL = Manual;` and similar changes to the current branch.\r\n Our testflight lane is in `fastlane env`\r\n\r\nMy teammate found **temporary** solution to this just to avoid manual version bumping and avoid AppStore connect problems.\r\n```ruby\r\n    increment_build_number({\r\n      build_number: latest_testflight_build_number(username: username, team_id: team_id, app_identifier: app_identifier) + 1\r\n    })\r\n``` \r\nBut I'd like to have bumped version committed by CI, because that how it should be done to avoid problems with build versions in future.\r\nIs it possible to work around this to commit only bumped build number? I thought about setting back to automatic code signing, but that could crash next steps in my lane because I am exporting provisioning profile. \r\n\r\nWith regards,\r\nDrwalcore\r\n\r\n<details><summary>🚫 fastlane environment 🚫</summary>\r\n\r\n### Stack\r\n\r\n| Key                         | Value                                       |\r\n| --------------------------- | ------------------------------------------- |\r\n| OS                          | 10.13.6                                     |\r\n| Ruby                        | 2.2.3                                       |\r\n| Bundler?                    | false                                       |\r\n| Git                         | git version 2.17.1 (Apple Git-112)          |\r\n| Installation Source         | ~/.rvm/gems/ruby-2.2.3/bin/fastlane         |\r\n| Host                        | Mac OS X 10.13.6 (17G65)                    |\r\n| Ruby Lib Dir                | ~/.rvm/rubies/ruby-2.2.3/lib                |\r\n| OpenSSL Version             | OpenSSL 1.0.2h  3 May 2016                  |\r\n| Is contained                | false                                       |\r\n| Is homebrew                 | false                                       |\r\n| Is installed via Fabric.app | false                                       |\r\n| Xcode Path                  | /Applications/Xcode.app/Contents/Developer/ |\r\n| Xcode Version               | 10.0                                        |\r\n\r\n\r\n### System Locale\r\n\r\n| Error                       |\r\n| --------------------------- |\r\n| No Locale with UTF8 found 🚫 |\r\n\r\n\r\n### fastlane files:\r\n\r\n<details><summary>`./fastlane/Fastfile`</summary>\r\n\r\n```ruby\r\nif !is_ci # To prevent potential updates that would crash CI build after fastlane update.\r\n  update_fastlane\r\nend\r\ndefault_platform(:ios)\r\n\r\nplatform :ios do\r\n\r\n  desc \"Try to recover from build errors\"\r\n  lane :doctor do\r\n    clean_cocoapods_cache\r\n    sh \"cd .. && rm -rf Pods\"\r\n    clear_derived_data\r\n  end\r\n\r\n  desc \"Upload on-demand a new build to Testflight for internal testing.\"\r\n  lane :testflight_release do\r\n\r\n    username = \"*****\"\r\n    team_id = \"*****\"\r\n    app_identifier = \"*****\"\r\n    scheme = \"*****\"\r\n    provisioning_profile_specifier = \"*****\"\r\n    match_git_branch = \"appstore\"\r\n\r\n    xcode_select(\"/Applications/Xcode.app\")\r\n\r\n    automatic_code_signing(path: \"***.xcodeproj\", use_automatic_signing: false)\r\n    match(\r\n     username: username,\r\n     team_id: team_id,\r\n     app_identifier: app_identifier,\r\n     git_branch: match_git_branch,\r\n     force: false,\r\n     readonly: false\r\n     )\r\n\r\n    doctor\r\n    cocoapods\r\n\r\n    #TODO: - commit version bump to repository.\r\n    # build_number = increment_build_number\r\n    # commit_version_bump(message:\"[ci-skip] Version Bump to #{build_number}\")\r\n\r\n    increment_build_number({\r\n      build_number: latest_testflight_build_number(username: username, team_id: team_id, app_identifier: app_identifier) + 1\r\n    })\r\n\r\n    #Explanation: https://github.com/fastlane/fastlane/issues/12849#issuecomment-404978983\r\n\r\n    settings_to_override = {\r\n      :BUNDLE_IDENTIFIER => app_identifier,\r\n      :PROVISIONING_PROFILE_SPECIFIER => provisioning_profile_specifier,\r\n      :DEVELOPMENT_TEAM => team_id\r\n      }\r\n\r\n    gym(\r\n     scheme: scheme,\r\n     clean: true,\r\n     xcargs: settings_to_override,\r\n     export_method: \"app-store\",\r\n     export_options: {\r\n        provisioningProfiles: {\r\n            app_identifier => provisioning_profile_specifier\r\n        }\r\n      }\r\n     )\r\n\r\n    pilot(\r\n     username: username,\r\n     team_id: team_id,\r\n     app_identifier: app_identifier,\r\n     skip_submission: false,\r\n     skip_waiting_for_build_processing: true\r\n     )\r\n\r\n  end\r\nend\r\n\r\nafter_each do |lane|\r\n  if is_ci && ENV[\"SLACK_URL\"]\r\n    payloads = [:test_result, :git_branch, :lane]\r\n    slack(\r\n      message: nil,\r\n      success: true,\r\n      icon_url: ENV[\"SLACK_ICON_URL\"],\r\n      default_payloads: payloads\r\n      )\r\n\r\n    push_to_git_remote(\r\n      remote: \"origin\",\r\n      local_branch: \"HEAD\",\r\n      remote_branch: \"development\",\r\n      force: true,\r\n      tags: true\r\n      )\r\n  end\r\n\r\n  clean_build_artifacts\r\nend\r\n\r\nerror do |lane, exception|\r\n  if is_ci && ENV[\"SLACK_URL\"]\r\n    payloads = [:message, :test_result, :git_branch, :lane]\r\n    slack(\r\n      message: exception.message,\r\n      success: false,\r\n      icon_url: ENV[\"SLACK_ICON_URL\"],\r\n      default_payloads: payloads\r\n      )\r\n  end\r\nend\r\n\r\n```\r\n</details>\r\n\r\n<details><summary>`./fastlane/Appfile`</summary>\r\n\r\n```ruby\r\n# app_identifier(\"[[APP_IDENTIFIER]]\") # The bundle identifier of your app\r\n# apple_id(\"[[APPLE_ID]]\") # Your Apple email address\r\n\r\n\r\n# For more information about the Appfile, see:\r\n#     https://docs.fastlane.tools/advanced/#appfile\r\n\r\n```\r\n</details>\r\n\r\n### fastlane gems\r\n\r\n| Gem      | Version | Update-Status |\r\n| -------- | ------- | ------------- |\r\n| fastlane | 2.107.0 | ✅ Up-To-Date  |\r\n\r\n\r\n### Loaded fastlane plugins:\r\n\r\n**No plugins Loaded**\r\n\r\n\r\n<details><summary><b>Loaded gems</b></summary>\r\n\r\n| Gem                       | Version      |\r\n| ------------------------- | ------------ |\r\n| slack-notifier            | 2.3.2        |\r\n| rouge                     | 2.0.7        |\r\n| xcpretty                  | 0.3.0        |\r\n| multipart-post            | 2.0.0        |\r\n| word_wrap                 | 1.0.0        |\r\n| tty-spinner               | 0.8.0        |\r\n| babosa                    | 1.0.2        |\r\n| colored                   | 1.2          |\r\n| commander-fastlane        | 4.4.6        |\r\n| faraday-cookie_jar        | 0.0.6        |\r\n| gh_inspector              | 1.1.3        |\r\n| mini_magick               | 4.5.1        |\r\n| rubyzip                   | 1.2.2        |\r\n| security                  | 0.1.3        |\r\n| emoji_regex               | 0.1.1        |\r\n| nanaimo                   | 0.2.6        |\r\n| colored2                  | 3.1.2        |\r\n| claide                    | 1.0.2        |\r\n| CFPropertyList            | 3.0.0        |\r\n| atomos                    | 0.1.3        |\r\n| xcodeproj                 | 1.7.0        |\r\n| terminal-notifier         | 1.8.0        |\r\n| unicode-display_width     | 1.4.0        |\r\n| terminal-table            | 1.8.0        |\r\n| plist                     | 3.4.0        |\r\n| public_suffix             | 2.0.5        |\r\n| addressable               | 2.5.2        |\r\n| tty-screen                | 0.6.5        |\r\n| tty-cursor                | 0.6.0        |\r\n| highline                  | 1.7.10       |\r\n| excon                     | 0.62.0       |\r\n| faraday                   | 0.15.3       |\r\n| unf_ext                   | 0.0.7.5      |\r\n| unf                       | 0.1.4        |\r\n| domain_name               | 0.5.20180417 |\r\n| http-cookie               | 1.0.3        |\r\n| fastimage                 | 2.1.4        |\r\n| json                      | 2.1.0        |\r\n| multi_json                | 1.13.1       |\r\n| multi_xml                 | 0.6.0        |\r\n| xcpretty-travis-formatter | 1.0.0        |\r\n| dotenv                    | 2.5.0        |\r\n| bundler                   | 1.16.6       |\r\n| faraday_middleware        | 0.12.2       |\r\n| naturally                 | 2.2.0        |\r\n| simctl                    | 1.6.5        |\r\n| httpclient                | 2.8.3        |\r\n| jwt                       | 2.1.0        |\r\n| signet                    | 0.11.0       |\r\n| os                        | 1.0.0        |\r\n| memoist                   | 0.16.0       |\r\n| googleauth                | 0.6.7        |\r\n| mime-types-data           | 3.2018.0812  |\r\n| mime-types                | 3.2.2        |\r\n| retriable                 | 3.1.2        |\r\n| declarative-option        | 0.1.0        |\r\n| declarative               | 0.0.10       |\r\n| uber                      | 0.1.0        |\r\n| representable             | 3.0.4        |\r\n| google-api-client         | 0.23.9       |\r\n</details>\r\n\r\n\r\n*generated on:* **2018-10-24**\r\n</details>"}}
{"actor":{"display_login":"fastlane-bot"}}