{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/4209","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/4209/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/4209/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/4209/events","html_url":"https://github.com/publiclab/plots2/pull/4209","id":389033694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTM3NTMx","number":4209,"title":"Modals integration","user":{"login":"JonathanXu1","id":22998430,"node_id":"MDQ6VXNlcjIyOTk4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/22998430?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanXu1","html_url":"https://github.com/JonathanXu1","followers_url":"https://api.github.com/users/JonathanXu1/followers","following_url":"https://api.github.com/users/JonathanXu1/following{/other_user}","gists_url":"https://api.github.com/users/JonathanXu1/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanXu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanXu1/subscriptions","organizations_url":"https://api.github.com/users/JonathanXu1/orgs","repos_url":"https://api.github.com/users/JonathanXu1/repos","events_url":"https://api.github.com/users/JonathanXu1/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanXu1/received_events","type":"User","site_admin":false},"labels":[{"id":828958340,"node_id":"MDU6TGFiZWw4Mjg5NTgzNDA=","url":"https://api.github.com/repos/publiclab/plots2/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/publiclab/plots2/milestones/18","html_url":"https://github.com/publiclab/plots2/milestone/18","labels_url":"https://api.github.com/repos/publiclab/plots2/milestones/18/labels","id":3438830,"node_id":"MDk6TWlsZXN0b25lMzQzODgzMA==","number":18,"title":"OAuth","description":"This milestone carries all the issues related to the OAuth Signup/login","creator":{"login":"SidharthBansal","id":20972099,"node_id":"MDQ6VXNlcjIwOTcyMDk5","avatar_url":"https://avatars0.githubusercontent.com/u/20972099?v=4","gravatar_id":"","url":"https://api.github.com/users/SidharthBansal","html_url":"https://github.com/SidharthBansal","followers_url":"https://api.github.com/users/SidharthBansal/followers","following_url":"https://api.github.com/users/SidharthBansal/following{/other_user}","gists_url":"https://api.github.com/users/SidharthBansal/gists{/gist_id}","starred_url":"https://api.github.com/users/SidharthBansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SidharthBansal/subscriptions","organizations_url":"https://api.github.com/users/SidharthBansal/orgs","repos_url":"https://api.github.com/users/SidharthBansal/repos","events_url":"https://api.github.com/users/SidharthBansal/events{/privacy}","received_events_url":"https://api.github.com/users/SidharthBansal/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":84,"state":"open","created_at":"2018-06-20T14:18:49Z","updated_at":"2018-12-09T20:47:03Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2018-12-09T15:28:06Z","updated_at":"2018-12-10T01:14:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/4209","html_url":"https://github.com/publiclab/plots2/pull/4209","diff_url":"https://github.com/publiclab/plots2/pull/4209.diff","patch_url":"https://github.com/publiclab/plots2/pull/4209.patch"},"body":"Fixes #4184\r\nExtension from #4203\r\nMake sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!\r\n\r\n* [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `rake test`\r\n* [x] code is in uniquely-named feature branch and has no merge conflicts\r\n* [x] PR is descriptively titled\r\n* [ ] ask `@publiclab/reviewers` for help, in a comment below\r\n\r\nThis PR will be focusing on connecting the signup and login modals.\r\nTo ensure that the signup modal works, we will need to conduct the following tests:\r\n\r\n- [ ] Sign Up form validations are working fine for incorrect input fields(testing)\r\n- [ ] Sign Up modal validations are working fine for incorrect input fields(testing)\r\n- [ ] Sign Up form signs a user in successfully(testing)\r\n- [ ] Sign Up modal signs in a user successfully(testing)\r\n- [ ] Sign Up works well on all the webpages(testing)\r\n- [ ] Sign Up is redirected to the same page after user signs up(return_to)(testing)\r\n- [ ] Check on the localhost(testing) for all above scenarios discussed.\r\n- [ ] Check on the unstable branch(testing) for all above scenarios discussed.\r\n- [ ] Check functionality of Oauth providers on the unstable branch.(testing)\r\n- [ ] return to works properly\r\n\r\nIn the previous PR @oorjitchowdhary had these results: https://github.com/publiclab/plots2/pull/4203#issuecomment-445540649\r\nAnd I had these results: https://github.com/publiclab/plots2/pull/4203#issuecomment-445544434\r\n* [ ] no recursive interlinking of issues.\r\n\r\n* [ ] Sign Up form validations are working fine for incorrect input fields(testing)\r\n* [ ] Sign Up modal validations are working fine for incorrect input fields(testing)\r\n* [ ] Sign Up form signs a user in successfully(testing)\r\n* [ ] Sign Up modal signs in a user successfully(testing)\r\n* [ ] Sign Up works well on all the webpages(testing)\r\n* [ ] Sign Up is redirected to the same page after user signs up(return_to)(testing)\r\n* [ ] Check on the localhost(testing) for all above scenarios discussed.\r\n* [ ] Check on the unstable branch(testing) for all above scenarios discussed.\r\n* [ ] Check functionality of Oauth providers on the unstable branch.(testing)\r\n## Checks on Unstable\r\n* [ ]  **ERROR** Sign Up form validations are working fine for incorrect input fields(testing) \r\n* [ ]  **ERROR** Sign Up modal validations are working fine for incorrect input fields(testing)\r\n\r\nIf we put incorrect passwords in password field and confirmation password field, it shows this error..\r\nAlso, if you miss filling any field, it shows the same error..\r\nOn both, the modal and form page too..\r\n\r\n![screenshot 77](https://user-images.githubusercontent.com/39333058/49698289-af305e80-fbe7-11e8-9f0e-af7309f889e7.png)\r\n\r\n\r\n* [ ]  **ERROR** Sign Up form signs a user in successfully(testing)\r\n\r\n![signup page error](https://user-images.githubusercontent.com/39333058/49698294-c40cf200-fbe7-11e8-85a4-9a4239a72f70.gif)\r\n\r\nUnable to login after entering every field correctly..\r\nThe same error is shown..\r\n\r\n* [ ]  **ERROR** Sign Up modal signs in a user successfully(testing)\r\n\r\n![signup modal error](https://user-images.githubusercontent.com/39333058/49698295-cec78700-fbe7-11e8-801b-99a22c8dadaf.gif)\r\n\r\nUnable to login after entering every field correctly..\r\nThe same error is shown..\r\n\r\n* [ ]  **ERROR** Sign Up works well on all the webpages(testing)\r\n\r\n* [ ]  Sign Up is redirected to the same page after user signs up(return_to)(testing)\r\nNot working\r\n\r\n* [ ]  Check functionality of Oauth providers on the unstable branch.(testing)\r\nWe're redirected publiclab.org but we're signed in through Oauth on unstable.publiclab.org\r\n\r\n* [ ]  return to works properly\r\nNot working\r\n\r\n## Localhost\r\n* [ ] **WORKING** Sign Up form validations are working fine for incorrect input fields(testing)\r\n\r\n![screenshot 78](https://user-images.githubusercontent.com/39333058/49698328-501f1980-fbe8-11e8-8f1d-92fd99bbf925.png)\r\n\r\n* [ ] Sign Up modal validations are working fine for incorrect input fields(testing)\r\nRedirected to sign up page for showing the error.\r\n\r\n![screenshot 78](https://user-images.githubusercontent.com/39333058/49698328-501f1980-fbe8-11e8-8f1d-92fd99bbf925.png)\r\n\r\n* [ ] **WORKING** Sign Up form signs a user in successfully(testing)\r\n\r\n![screenshot 79](https://user-images.githubusercontent.com/39333058/49698372-ba37be80-fbe8-11e8-9956-072c7287c2c3.png)\r\n\r\n* [ ] **WORKING** Sign Up modal signs in a user successfully(testing)\r\n\r\n![screenshot 79](https://user-images.githubusercontent.com/39333058/49698372-ba37be80-fbe8-11e8-9956-072c7287c2c3.png)\r\n\r\n* [ ] **WORKING** Sign Up works well on all the webpages(testing)\r\n\r\n![screenshot 79](https://user-images.githubusercontent.com/39333058/49698372-ba37be80-fbe8-11e8-9956-072c7287c2c3.png)\r\n\r\n* [ ] **ERROR** Sign Up is redirected to the same page after user signs up(return_to)(testing)\r\nReturn_to not working\r\n- [ ] Sign Up form validations are working fine for incorrect input fields(testing)\r\nPage refreshes, modal closes\r\n- [ ] Sign Up modal validations are working fine for incorrect input fields(testing)\r\nPage refreshes, modal closes\r\n- [ ] Sign Up form signs a user in successfully(testing)\r\nPage refreshes, modal closes\r\n- [x] Sign Up modal signs in a user successfully(testing)\r\nShould work, but unable to verify\r\n- [x] Sign Up works well on all the webpages(testing)\r\nShould work, but unable to verify\r\n- [x] Sign Up is redirected to the same page after user signs up(return_to)(testing)\r\nUrl matches original directory\r\n- [ ] Check on the localhost(testing) for all above scenarios discussed.\r\n@SidharthBansal is this the check for the master branch?\r\n- [x] Check on the unstable branch(testing) for all above scenarios discussed.\r\n1,2,3 ERROR\r\n4,5,6 should work but redirects to https://localhost/register?return_to=/ instead of c9 link\r\n- [x] Check functionality of Oauth providers on the unstable branch.(testing)\r\n![image](https://user-images.githubusercontent.com/22998430/49698931-86cd4380-fb98-11e8-9b8c-3c33ebcf609e.png)\r\n400 error on both modals and respective signup and login pages\r\n- [x] return to works properly\r\n- [ ] change name of form2 to something better\r\n- [ ] extract out edit controller data from the form partial "},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/445609128","html_url":"https://github.com/publiclab/plots2/pull/4209#issuecomment-445609128","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/4209","id":445609128,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTYwOTEyOA==","user":{"login":"JonathanXu1","id":22998430,"node_id":"MDQ6VXNlcjIyOTk4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/22998430?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanXu1","html_url":"https://github.com/JonathanXu1","followers_url":"https://api.github.com/users/JonathanXu1/followers","following_url":"https://api.github.com/users/JonathanXu1/following{/other_user}","gists_url":"https://api.github.com/users/JonathanXu1/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanXu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanXu1/subscriptions","organizations_url":"https://api.github.com/users/JonathanXu1/orgs","repos_url":"https://api.github.com/users/JonathanXu1/repos","events_url":"https://api.github.com/users/JonathanXu1/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanXu1/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T01:14:33Z","updated_at":"2018-12-10T01:14:33Z","author_association":"CONTRIBUTOR","body":"Thanks for offering, @dinaelhanan ! I'm just waiting on this task as well, given that it seems to do everything we need it to. I do think the time zone difference isn't helping. Let me know if you would like help with anything."}}
{"actor":{"display_login":"JonathanXu1"}}