{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44529","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44529/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44529/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44529/events","html_url":"https://github.com/NixOS/nixpkgs/pull/44529","id":347753863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjcxOTI1","number":44529,"title":"Fix gi vte haskell pkg","user":{"login":"cdepillabout","id":64804,"node_id":"MDQ6VXNlcjY0ODA0","avatar_url":"https://avatars1.githubusercontent.com/u/64804?v=4","gravatar_id":"","url":"https://api.github.com/users/cdepillabout","html_url":"https://github.com/cdepillabout","followers_url":"https://api.github.com/users/cdepillabout/followers","following_url":"https://api.github.com/users/cdepillabout/following{/other_user}","gists_url":"https://api.github.com/users/cdepillabout/gists{/gist_id}","starred_url":"https://api.github.com/users/cdepillabout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdepillabout/subscriptions","organizations_url":"https://api.github.com/users/cdepillabout/orgs","repos_url":"https://api.github.com/users/cdepillabout/repos","events_url":"https://api.github.com/users/cdepillabout/events{/privacy}","received_events_url":"https://api.github.com/users/cdepillabout/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":99513706,"node_id":"MDU6TGFiZWw5OTUxMzcwNg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20haskell","name":"6.topic: haskell","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-06T01:55:44Z","updated_at":"2018-08-06T13:25:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44529","html_url":"https://github.com/NixOS/nixpkgs/pull/44529","diff_url":"https://github.com/NixOS/nixpkgs/pull/44529.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44529.patch"},"body":"###### Motivation for this change\r\n\r\nThe [gi-vte](https://hackage.haskell.org/package/gi-vte) Haskell package does not compile in master:\r\n\r\nhttps://hydra.nixos.org/job/nixpkgs/haskell-updates/haskellPackages.gi-vte.x86_64-linux\r\n\r\ngi-vte depends on the gi-gtk Haskell package, as well as the VTE system library.  The gi-gtk Haskell packge depends on the GTK system library.  Currently, gi-gtk is being compiled against the GTK system library from Gnome 3.  However, gi-vte is being compiled against the VTE system library from Gnome 2.\r\n\r\nThis PR does the following three things:\r\n\r\n1. Change the gi-vte package to depend the VTE system library from Gnome 3 in `hackage-packages.nix`.\r\n\r\n2. Add a dependency on the GTK system library for gi-vte.  I'm not sure exactly why this is necessary, but gi-vte wouldn't build without it.\r\n\r\n3. Remove the gi-vte package from `dont-distribute-packages` in `configuration-hackage2nix.yaml`.\r\n\r\nEventually, I'd like to add a new Haskell [package](https://hackage.haskell.org/package/termonad) to nixpkgs that depends on gi-vte, so I would like gi-vte to be compiling in master.  I'd like to get this in before the 18.09 release.\r\n\r\nHowever, I think the `hackage-packages.nix` file (and maybe even the `configuration-hackge2nix.yaml`) is being auto-generated, so please let me know if there is some other file I should actually be editing.  Also, for my future reference, is there an explanation somewhere of how the Haskell-related nixpkg files work?  Like, which files I should edit and send PRs to?\r\n\r\nPinging the nixpkgs Haskell maintainers: @peti @ryantm @basvandijk (please let me know if it is not appropriate to do this)\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"` (**there are currently no packages that depend on gi-vte**)\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`) (**there are no binary files produced by gi-vte**)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/410706850","html_url":"https://github.com/NixOS/nixpkgs/pull/44529#issuecomment-410706850","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44529","id":410706850,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDcwNjg1MA==","user":{"login":"cdepillabout","id":64804,"node_id":"MDQ6VXNlcjY0ODA0","avatar_url":"https://avatars1.githubusercontent.com/u/64804?v=4","gravatar_id":"","url":"https://api.github.com/users/cdepillabout","html_url":"https://github.com/cdepillabout","followers_url":"https://api.github.com/users/cdepillabout/followers","following_url":"https://api.github.com/users/cdepillabout/following{/other_user}","gists_url":"https://api.github.com/users/cdepillabout/gists{/gist_id}","starred_url":"https://api.github.com/users/cdepillabout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdepillabout/subscriptions","organizations_url":"https://api.github.com/users/cdepillabout/orgs","repos_url":"https://api.github.com/users/cdepillabout/repos","events_url":"https://api.github.com/users/cdepillabout/events{/privacy}","received_events_url":"https://api.github.com/users/cdepillabout/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T13:25:39Z","updated_at":"2018-08-06T13:25:39Z","author_association":"CONTRIBUTOR","body":"@peti, after looking around the files under `/pkgs/development/haskell-modules`, it looks like what I actually want to do is update the settings for the gi-vte package in `pkgs/development/haskell-modules/configuration-nix.nix`.\r\n\r\nThat is just what I've done in the most recent commit.  Could you take a look over this and let me know if it looks alright?"}}
{"actor":{"display_login":"cdepillabout"}}