{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/170143942","pull_request_review_id":98787708,"id":170143942,"diff_hunk":"@@ -57,7 +57,11 @@ def safe_import(mod_name, min_version=None):\n         return mod\n     else:\n         import sys\n-        version = getattr(sys.modules[mod_name], '__version__')\n+        try:\n+            version = getattr(sys.modules[mod_name], '__version__')\n+        except AttributeError:","path":"pandas/util/_test_decorators.py","position":7,"original_position":7,"commit_id":"f5bc0baeec1aa926ae9168e928c20a0aca4f75ac","original_commit_id":"f5bc0baeec1aa926ae9168e928c20a0aca4f75ac","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"ugg, really?","created_at":"2018-02-23T01:25:52Z","updated_at":"2018-02-23T01:28:28Z","html_url":"https://github.com/pandas-dev/pandas/pull/19829#discussion_r170143942","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/170143942"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19829#discussion_r170143942"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829","id":170594465,"html_url":"https://github.com/pandas-dev/pandas/pull/19829","diff_url":"https://github.com/pandas-dev/pandas/pull/19829.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/19829.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19829","number":19829,"state":"open","locked":false,"title":"Test Decorators and Better Pytest Integration in 'test_excel'","user":{"login":"WillAyd","id":609873,"avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"body":"- [x] closes #19816 \r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n\r\nOnce I started looking at it, it made sense to make the module more \"pytest compatible\". There was a lot of skipping being done imperatively that seemed better suited to using class-level decorators, so as I moved some of that around I also replaced the setup/teardown mechanism of the \"Excel Writing\" tests with a pytest fixture","created_at":"2018-02-21T21:33:39Z","updated_at":"2018-02-23T01:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a77e3f5741feaa52744047b56ed27ade9e211b74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":49254273,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/IO%20Excel","name":"IO Excel","color":"bfe5bf","default":false},{"id":127685,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19829/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/f5bc0baeec1aa926ae9168e928c20a0aca4f75ac","head":{"label":"WillAyd:excel-skipif-decs","ref":"excel-skipif-decs","sha":"f5bc0baeec1aa926ae9168e928c20a0aca4f75ac","user":{"login":"WillAyd","id":609873,"avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"repo":{"id":65685884,"name":"pandas","full_name":"WillAyd/pandas","owner":{"login":"WillAyd","id":609873,"avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WillAyd/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/WillAyd/pandas","forks_url":"https://api.github.com/repos/WillAyd/pandas/forks","keys_url":"https://api.github.com/repos/WillAyd/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WillAyd/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WillAyd/pandas/teams","hooks_url":"https://api.github.com/repos/WillAyd/pandas/hooks","issue_events_url":"https://api.github.com/repos/WillAyd/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/WillAyd/pandas/events","assignees_url":"https://api.github.com/repos/WillAyd/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/WillAyd/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/WillAyd/pandas/tags","blobs_url":"https://api.github.com/repos/WillAyd/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WillAyd/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WillAyd/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/WillAyd/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WillAyd/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/WillAyd/pandas/languages","stargazers_url":"https://api.github.com/repos/WillAyd/pandas/stargazers","contributors_url":"https://api.github.com/repos/WillAyd/pandas/contributors","subscribers_url":"https://api.github.com/repos/WillAyd/pandas/subscribers","subscription_url":"https://api.github.com/repos/WillAyd/pandas/subscription","commits_url":"https://api.github.com/repos/WillAyd/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/WillAyd/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/WillAyd/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/WillAyd/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/WillAyd/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/WillAyd/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WillAyd/pandas/merges","archive_url":"https://api.github.com/repos/WillAyd/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WillAyd/pandas/downloads","issues_url":"https://api.github.com/repos/WillAyd/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/WillAyd/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/WillAyd/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/WillAyd/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WillAyd/pandas/labels{/name}","releases_url":"https://api.github.com/repos/WillAyd/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/WillAyd/pandas/deployments","created_at":"2016-08-14T20:52:08Z","updated_at":"2016-08-14T20:52:14Z","pushed_at":"2018-02-22T16:37:49Z","git_url":"git://github.com/WillAyd/pandas.git","ssh_url":"git@github.com:WillAyd/pandas.git","clone_url":"https://github.com/WillAyd/pandas.git","svn_url":"https://github.com/WillAyd/pandas","homepage":"http://pandas.pydata.org","size":115288,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"abc4ef9132d8bcc8ad987c18fdd757595fd65d8c","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-02-22T22:52:00Z","pushed_at":"2018-02-23T01:22:35Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":117005,"stargazers_count":12983,"watchers_count":12983,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5033,"mirror_url":null,"archived":false,"open_issues_count":2370,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5033,"open_issues":2370,"watchers":12983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19829"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19829"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19829/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19829/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/f5bc0baeec1aa926ae9168e928c20a0aca4f75ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}