{"action":"created","comment":{"url":"https://api.github.com/repos/openebs/zfs/pulls/comments/177806715","pull_request_review_id":107723363,"id":177806715,"diff_hunk":"@@ -820,6 +870,63 @@ uzfs_zvol_timer_thread(void)\n \t}\n }\n \n+/*\n+ * This func takes care of sending potentially multiple read blocks each\n+ * prefixed by metainfo.\n+ */\n+static int\n+uzfs_send_reads(int fd, zvol_io_cmd_t *zio_cmd)\n+{\n+\tzvol_io_hdr_t \t*hdr = &zio_cmd->hdr;\n+\tstruct zvol_io_rw_hdr read_hdr;\n+\tmetadata_desc_t\t*md;\n+\tsize_t\trel_offset = 0;\n+\tint\trc = 0;\n+\n+\t/* special case for missing metadata */","path":"cmd/zrepl/zrepl.c","position":176,"original_position":176,"commit_id":"df399e8be07052f782264c960c434d2512f0ceef","original_commit_id":"df399e8be07052f782264c960c434d2512f0ceef","user":{"login":"vishnuitta","id":25415415,"avatar_url":"https://avatars2.githubusercontent.com/u/25415415?v=4","gravatar_id":"","url":"https://api.github.com/users/vishnuitta","html_url":"https://github.com/vishnuitta","followers_url":"https://api.github.com/users/vishnuitta/followers","following_url":"https://api.github.com/users/vishnuitta/following{/other_user}","gists_url":"https://api.github.com/users/vishnuitta/gists{/gist_id}","starred_url":"https://api.github.com/users/vishnuitta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishnuitta/subscriptions","organizations_url":"https://api.github.com/users/vishnuitta/orgs","repos_url":"https://api.github.com/users/vishnuitta/repos","events_url":"https://api.github.com/users/vishnuitta/events{/privacy}","received_events_url":"https://api.github.com/users/vishnuitta/received_events","type":"User","site_admin":false},"body":"this seems to be the generic case","created_at":"2018-03-28T16:16:36Z","updated_at":"2018-03-28T16:48:16Z","html_url":"https://github.com/openebs/zfs/pull/18#discussion_r177806715","pull_request_url":"https://api.github.com/repos/openebs/zfs/pulls/18","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openebs/zfs/pulls/comments/177806715"},"html":{"href":"https://github.com/openebs/zfs/pull/18#discussion_r177806715"},"pull_request":{"href":"https://api.github.com/repos/openebs/zfs/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/openebs/zfs/pulls/18","id":176135032,"html_url":"https://github.com/openebs/zfs/pull/18","diff_url":"https://github.com/openebs/zfs/pull/18.diff","patch_url":"https://github.com/openebs/zfs/pull/18.patch","issue_url":"https://api.github.com/repos/openebs/zfs/issues/18","number":18,"state":"open","locked":false,"title":"[cstor#44] Merge replication changes with latest code","user":{"login":"jkryl","id":5690145,"avatar_url":"https://avatars3.githubusercontent.com/u/5690145?v=4","gravatar_id":"","url":"https://api.github.com/users/jkryl","html_url":"https://github.com/jkryl","followers_url":"https://api.github.com/users/jkryl/followers","following_url":"https://api.github.com/users/jkryl/following{/other_user}","gists_url":"https://api.github.com/users/jkryl/gists{/gist_id}","starred_url":"https://api.github.com/users/jkryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkryl/subscriptions","organizations_url":"https://api.github.com/users/jkryl/orgs","repos_url":"https://api.github.com/users/jkryl/repos","events_url":"https://api.github.com/users/jkryl/events{/privacy}","received_events_url":"https://api.github.com/users/jkryl/received_events","type":"User","site_admin":false},"body":"Create zvol meta object and related properties in zvol zap object even when dataset is created using zfs command. So now it is created when using uzfs_create_dataset used in our tests and also in ioctl creating a zvol. Missing path which hasn't been tested is the import path. The code for this path will be added when refcount problem is solved (I have strange problems exporting/importing pools with zrepl as of now).","created_at":"2018-03-20T09:45:50Z","updated_at":"2018-03-28T16:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8ef8aa4a4ee2e01e474645db8267f841c5d86ed","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gila","id":15957973,"avatar_url":"https://avatars2.githubusercontent.com/u/15957973?v=4","gravatar_id":"","url":"https://api.github.com/users/gila","html_url":"https://github.com/gila","followers_url":"https://api.github.com/users/gila/followers","following_url":"https://api.github.com/users/gila/following{/other_user}","gists_url":"https://api.github.com/users/gila/gists{/gist_id}","starred_url":"https://api.github.com/users/gila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gila/subscriptions","organizations_url":"https://api.github.com/users/gila/orgs","repos_url":"https://api.github.com/users/gila/repos","events_url":"https://api.github.com/users/gila/events{/privacy}","received_events_url":"https://api.github.com/users/gila/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/zfs/pulls/18/commits","review_comments_url":"https://api.github.com/repos/openebs/zfs/pulls/18/comments","review_comment_url":"https://api.github.com/repos/openebs/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/zfs/issues/18/comments","statuses_url":"https://api.github.com/repos/openebs/zfs/statuses/df399e8be07052f782264c960c434d2512f0ceef","head":{"label":"openebs:create-meta","ref":"create-meta","sha":"df399e8be07052f782264c960c434d2512f0ceef","user":{"login":"openebs","id":20769039,"avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":122975544,"name":"zfs","full_name":"openebs/zfs","owner":{"login":"openebs","id":20769039,"avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openebs/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/openebs/zfs","forks_url":"https://api.github.com/repos/openebs/zfs/forks","keys_url":"https://api.github.com/repos/openebs/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/zfs/teams","hooks_url":"https://api.github.com/repos/openebs/zfs/hooks","issue_events_url":"https://api.github.com/repos/openebs/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/zfs/events","assignees_url":"https://api.github.com/repos/openebs/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/zfs/tags","blobs_url":"https://api.github.com/repos/openebs/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/zfs/languages","stargazers_url":"https://api.github.com/repos/openebs/zfs/stargazers","contributors_url":"https://api.github.com/repos/openebs/zfs/contributors","subscribers_url":"https://api.github.com/repos/openebs/zfs/subscribers","subscription_url":"https://api.github.com/repos/openebs/zfs/subscription","commits_url":"https://api.github.com/repos/openebs/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/zfs/merges","archive_url":"https://api.github.com/repos/openebs/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/zfs/downloads","issues_url":"https://api.github.com/repos/openebs/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/zfs/labels{/name}","releases_url":"https://api.github.com/repos/openebs/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/zfs/deployments","created_at":"2018-02-26T13:42:31Z","updated_at":"2018-03-26T19:33:44Z","pushed_at":"2018-03-28T15:19:38Z","git_url":"git://github.com/openebs/zfs.git","ssh_url":"git@github.com:openebs/zfs.git","clone_url":"https://github.com/openebs/zfs.git","svn_url":"https://github.com/openebs/zfs","homepage":"http://zfsonlinux.org/","size":45097,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":2,"watchers":4,"default_branch":"zfs-0.7-release"}},"base":{"label":"openebs:zfs-0.7-release","ref":"zfs-0.7-release","sha":"bf4f167653145e29cf4e1b6cb1c2408e597424b6","user":{"login":"openebs","id":20769039,"avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":122975544,"name":"zfs","full_name":"openebs/zfs","owner":{"login":"openebs","id":20769039,"avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openebs/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/openebs/zfs","forks_url":"https://api.github.com/repos/openebs/zfs/forks","keys_url":"https://api.github.com/repos/openebs/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/zfs/teams","hooks_url":"https://api.github.com/repos/openebs/zfs/hooks","issue_events_url":"https://api.github.com/repos/openebs/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/zfs/events","assignees_url":"https://api.github.com/repos/openebs/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/zfs/tags","blobs_url":"https://api.github.com/repos/openebs/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/zfs/languages","stargazers_url":"https://api.github.com/repos/openebs/zfs/stargazers","contributors_url":"https://api.github.com/repos/openebs/zfs/contributors","subscribers_url":"https://api.github.com/repos/openebs/zfs/subscribers","subscription_url":"https://api.github.com/repos/openebs/zfs/subscription","commits_url":"https://api.github.com/repos/openebs/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/zfs/merges","archive_url":"https://api.github.com/repos/openebs/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/zfs/downloads","issues_url":"https://api.github.com/repos/openebs/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/zfs/labels{/name}","releases_url":"https://api.github.com/repos/openebs/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/zfs/deployments","created_at":"2018-02-26T13:42:31Z","updated_at":"2018-03-26T19:33:44Z","pushed_at":"2018-03-28T15:19:38Z","git_url":"git://github.com/openebs/zfs.git","ssh_url":"git@github.com:openebs/zfs.git","clone_url":"https://github.com/openebs/zfs.git","svn_url":"https://github.com/openebs/zfs","homepage":"http://zfsonlinux.org/","size":45097,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":2,"watchers":4,"default_branch":"zfs-0.7-release"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/zfs/pulls/18"},"html":{"href":"https://github.com/openebs/zfs/pull/18"},"issue":{"href":"https://api.github.com/repos/openebs/zfs/issues/18"},"comments":{"href":"https://api.github.com/repos/openebs/zfs/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/zfs/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/zfs/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/zfs/statuses/df399e8be07052f782264c960c434d2512f0ceef"}},"author_association":"NONE"}}
{"actor":{"display_login":"vishnuitta"}}