{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/212099572","pull_request_review_id":148658763,"id":212099572,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA5OTU3Mg==","diff_hunk":"@@ -413,26 +476,68 @@ static int default_dbg_vprintf( const char *format, va_list args )\n \n \n /* default implementation of wine_dbg_vlog */\n-static int default_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_channel *channel,\n-                             const char *file, const char *func, const int line, const char *format, va_list args )\n+/* Wine format */\n+static int winefmt_default_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_channel *channel,\n+                                     const char *file, const int line, const char *func, const char *format, va_list args )\n+{\n+    int ret = 0;\n+\n+    if (TRACE_ON(pid))\n+        ret += wine_dbg_printf( \"%04x:\", HandleToULong(NtCurrentTeb()->ClientId.UniqueProcess) );\n+    ret += wine_dbg_printf( \"%04x:\", HandleToULong(NtCurrentTeb()->ClientId.UniqueThread) );\n+\n+    if (cls < sizeof(debug_classes)/sizeof(debug_classes[0]))\n+        ret += wine_dbg_printf( \"%s:%s:%s \", debug_classes[cls], channel->name, func );\n+    if (format)\n+        ret += funcs.dbg_vprintf( format, args );\n+    return ret;\n+}\n+/* ReactOS format (default) */\n+static int rosfmt_default_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_channel *channel,\n+                                    const char *file, const int line, const char *func, const char *format, va_list args )\n {\n     int ret = 0;\n \n     if (TRACE_ON(tid))\n-        ret += wine_dbg_printf(\"%04x:\", HandleToULong(NtCurrentTeb()->ClientId.UniqueThread));\n+        ret += wine_dbg_printf( \"%04x:\", HandleToULong(NtCurrentTeb()->ClientId.UniqueThread) );","path":"sdk/lib/3rdparty/libwine/debug.c","position":148,"original_position":148,"commit_id":"baff1c97f7f4a904253e96db5eb2091b01690d5c","original_commit_id":"baff1c97f7f4a904253e96db5eb2091b01690d5c","user":{"login":"learn-more","id":610685,"node_id":"MDQ6VXNlcjYxMDY4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/610685?v=4","gravatar_id":"","url":"https://api.github.com/users/learn-more","html_url":"https://github.com/learn-more","followers_url":"https://api.github.com/users/learn-more/followers","following_url":"https://api.github.com/users/learn-more/following{/other_user}","gists_url":"https://api.github.com/users/learn-more/gists{/gist_id}","starred_url":"https://api.github.com/users/learn-more/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learn-more/subscriptions","organizations_url":"https://api.github.com/users/learn-more/orgs","repos_url":"https://api.github.com/users/learn-more/repos","events_url":"https://api.github.com/users/learn-more/events{/privacy}","received_events_url":"https://api.github.com/users/learn-more/received_events","type":"User","site_admin":false},"body":"Why change whitespace?","created_at":"2018-08-22T20:37:55Z","updated_at":"2018-08-22T20:38:20Z","html_url":"https://github.com/reactos/reactos/pull/793#discussion_r212099572","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/793","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/212099572"},"html":{"href":"https://github.com/reactos/reactos/pull/793#discussion_r212099572"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/793"}}},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/793","id":209839005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODM5MDA1","html_url":"https://github.com/reactos/reactos/pull/793","diff_url":"https://github.com/reactos/reactos/pull/793.diff","patch_url":"https://github.com/reactos/reactos/pull/793.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/793","number":793,"state":"open","locked":false,"title":"[REACTOS] Introduce a \"DEBUGFORMAT\" environment variable, that allows to select different debug trace formats. - CORE-12671","user":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"body":"**Supersedes PR #112.**\r\n\r\nJIRA issue: [CORE-12671](https://jira.reactos.org/browse/CORE-12671)\r\n\r\n- The default one (used when nothing is specified) is \"reactos\" or\r\n  \"ros\": this is the one we use by default in ReactOS:\r\n\r\n    <debug_class>:(<file>:<line>) <message>\r\n\r\n  with \"debug_class\" being \"trace\", \"warn\", \"err\".\r\n\r\n- The \"wine\" format is the one used by Wine. It can be used when trying\r\n  to diff-compare traces for a module with the corresponding one\r\n  obtained from a Wine run. It can also be useful because the logging of\r\n  Wine-synced code assumes that the function names are automatically\r\n  added by the helper macros \"FIXME()\", \"TRACE()\", \"WARN()\" or \"ERR()\",\r\n  and not manually inside the logging string given to these macros:\r\n  for example:\r\n\r\n    FIXME(\"(%params) message\\n\", params);\r\n\r\n  displays:\r\n\r\n    fixme:<module>:SomeFunc(params) message\r\n\r\n- The \"extended\" (or \"ext\") format is very noisy and tries to output a\r\n  lot of information; it is a hybrid of the previous two formats:\r\n\r\n    <debug_class>:(<file>:<line>):<channel>:func <message>\r\n\r\nIn addition we add support for displaying the current process ID in\r\naddition to the (already existing support for) thread ID.","created_at":"2018-08-21T14:07:56Z","updated_at":"2018-08-22T20:38:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"051029d6c79624c338a8479421d6d6e4f6133bce","assignee":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"assignees":[{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":730524222,"node_id":"MDU6TGFiZWw3MzA1MjQyMjI=","url":"https://api.github.com/repos/reactos/reactos/labels/WIP","name":"WIP","color":"4169E1","default":false},{"id":709291171,"node_id":"MDU6TGFiZWw3MDkyOTExNzE=","url":"https://api.github.com/repos/reactos/reactos/labels/enhancement","name":"enhancement","color":"59f9ac","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/793/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/793/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/793/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/baff1c97f7f4a904253e96db5eb2091b01690d5c","head":{"label":"HBelusca:debug_traces","ref":"debug_traces","sha":"baff1c97f7f4a904253e96db5eb2091b01690d5c","user":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"repo":{"id":105653436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2NTM0MzY=","name":"reactos","full_name":"HBelusca/reactos","owner":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HBelusca/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/HBelusca/reactos","forks_url":"https://api.github.com/repos/HBelusca/reactos/forks","keys_url":"https://api.github.com/repos/HBelusca/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HBelusca/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HBelusca/reactos/teams","hooks_url":"https://api.github.com/repos/HBelusca/reactos/hooks","issue_events_url":"https://api.github.com/repos/HBelusca/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/HBelusca/reactos/events","assignees_url":"https://api.github.com/repos/HBelusca/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/HBelusca/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/HBelusca/reactos/tags","blobs_url":"https://api.github.com/repos/HBelusca/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HBelusca/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HBelusca/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/HBelusca/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HBelusca/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/HBelusca/reactos/languages","stargazers_url":"https://api.github.com/repos/HBelusca/reactos/stargazers","contributors_url":"https://api.github.com/repos/HBelusca/reactos/contributors","subscribers_url":"https://api.github.com/repos/HBelusca/reactos/subscribers","subscription_url":"https://api.github.com/repos/HBelusca/reactos/subscription","commits_url":"https://api.github.com/repos/HBelusca/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/HBelusca/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/HBelusca/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/HBelusca/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/HBelusca/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/HBelusca/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HBelusca/reactos/merges","archive_url":"https://api.github.com/repos/HBelusca/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HBelusca/reactos/downloads","issues_url":"https://api.github.com/repos/HBelusca/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/HBelusca/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/HBelusca/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/HBelusca/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HBelusca/reactos/labels{/name}","releases_url":"https://api.github.com/repos/HBelusca/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/HBelusca/reactos/deployments","created_at":"2017-10-03T13:12:41Z","updated_at":"2018-08-21T14:16:24Z","pushed_at":"2018-08-22T20:32:13Z","git_url":"git://github.com/HBelusca/reactos.git","ssh_url":"git@github.com:HBelusca/reactos.git","clone_url":"https://github.com/HBelusca/reactos.git","svn_url":"https://github.com/HBelusca/reactos","homepage":null,"size":382886,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"b8e98c4e66ae8b73c06ba323b7536728a267441a","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-08-22T20:35:55Z","pushed_at":"2018-08-22T20:32:15Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":459215,"stargazers_count":4990,"watchers_count":4990,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":393,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":393,"open_issues":55,"watchers":4990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/793"},"html":{"href":"https://github.com/reactos/reactos/pull/793"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/793"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/793/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/793/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/793/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/baff1c97f7f4a904253e96db5eb2091b01690d5c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"learn-more"}}