{"action":"closed","number":10569,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10569","id":181992134,"html_url":"https://github.com/apache/incubator-mxnet/pull/10569","diff_url":"https://github.com/apache/incubator-mxnet/pull/10569.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/10569.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/10569","number":10569,"state":"closed","locked":false,"title":"[MXNET-324] Use default nvcc when configured nvcc not present.","user":{"login":"KellenSunderland","id":7443219,"avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"body":"## Description ##\r\n\r\nThis fixes an issue with the nvcc path resolution logic in the Makefile (#10553).  In prior releases the makefile would use $(USE_CUDA_PATH)/bin/nvcc for nvcc no matter what was specified in config. For some users this was actually a good thing if 'nvcc' was not on the path, as it would specify the binary with an absolute path.  However the behaviour in the prior release caused issues when cross compiling. You may have an arm and x86 cuda path specified, and you need to select the correct nvcc for your platform.\r\n\r\nThis PR checks the configured nvcc to ensure it is actually on the path.  If it isn't it will set the binary to the absolute path.  This should match the behaviour of the prior release for users without nvcc on the path, and also allow for cross-compilation.\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [x] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n## Comments ##\r\n- Note on why this was missed in CI: we do not have any CUDA CI configurations that do not have nvcc on the path.\r\n","created_at":"2018-04-16T21:22:09Z","updated_at":"2018-04-25T20:09:12Z","closed_at":"2018-04-25T20:09:12Z","merged_at":"2018-04-25T20:09:12Z","merge_commit_sha":"9c47098088880ba43681e34d1b2611ab067f4269","assignee":null,"assignees":[],"requested_reviewers":[{"login":"szha","id":2626883,"avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10569/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10569/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/10569/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/4a79af5a57c6247fcc3f76002ac6f90651aac414","head":{"label":"KellenSunderland:nvcc_fix_v1.2.0","ref":"nvcc_fix_v1.2.0","sha":"4a79af5a57c6247fcc3f76002ac6f90651aac414","user":{"login":"KellenSunderland","id":7443219,"avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"repo":{"id":104731717,"name":"incubator-mxnet","full_name":"KellenSunderland/incubator-mxnet","owner":{"login":"KellenSunderland","id":7443219,"avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KellenSunderland/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet","forks_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/deployments","created_at":"2017-09-25T09:44:26Z","updated_at":"2018-02-01T15:49:00Z","pushed_at":"2018-04-16T21:20:50Z","git_url":"git://github.com/KellenSunderland/incubator-mxnet.git","ssh_url":"git@github.com:KellenSunderland/incubator-mxnet.git","clone_url":"https://github.com/KellenSunderland/incubator-mxnet.git","svn_url":"https://github.com/KellenSunderland/incubator-mxnet","homepage":"http://mxnet.io","size":35588,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:v1.2.0","ref":"v1.2.0","sha":"f220ad07bb0cf572e66392f52acf6215ef0d1190","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-04-25T20:05:16Z","pushed_at":"2018-04-25T20:09:12Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"http://mxnet.io","size":35490,"stargazers_count":13770,"watchers_count":13770,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5102,"mirror_url":null,"archived":false,"open_issues_count":874,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5102,"open_issues":874,"watchers":13770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10569"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/10569"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/10569"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/10569/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10569/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10569/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/4a79af5a57c6247fcc3f76002ac6f90651aac414"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars1.githubusercontent.com/u/11234557?v=4","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"cjolivier01"}}