{"action":"created","issue":{"url":"https://api.github.com/repos/samtools/htsjdk/issues/1156","repository_url":"https://api.github.com/repos/samtools/htsjdk","labels_url":"https://api.github.com/repos/samtools/htsjdk/issues/1156/labels{/name}","comments_url":"https://api.github.com/repos/samtools/htsjdk/issues/1156/comments","events_url":"https://api.github.com/repos/samtools/htsjdk/issues/1156/events","html_url":"https://github.com/samtools/htsjdk/pull/1156","id":334604030,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTM1Nzg2","number":1156,"title":"Fixes for CachingBAMFileIndex","user":{"login":"lbergelson","id":4700332,"node_id":"MDQ6VXNlcjQ3MDAzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4700332?v=4","gravatar_id":"","url":"https://api.github.com/users/lbergelson","html_url":"https://github.com/lbergelson","followers_url":"https://api.github.com/users/lbergelson/followers","following_url":"https://api.github.com/users/lbergelson/following{/other_user}","gists_url":"https://api.github.com/users/lbergelson/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergelson/subscriptions","organizations_url":"https://api.github.com/users/lbergelson/orgs","repos_url":"https://api.github.com/users/lbergelson/repos","events_url":"https://api.github.com/users/lbergelson/events{/privacy}","received_events_url":"https://api.github.com/users/lbergelson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"droazen","id":798637,"node_id":"MDQ6VXNlcjc5ODYzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/798637?v=4","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false},"assignees":[{"login":"droazen","id":798637,"node_id":"MDQ6VXNlcjc5ODYzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/798637?v=4","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-21T18:18:41Z","updated_at":"2018-06-25T18:20:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/1156","html_url":"https://github.com/samtools/htsjdk/pull/1156","diff_url":"https://github.com/samtools/htsjdk/pull/1156.diff","patch_url":"https://github.com/samtools/htsjdk/pull/1156.patch"},"body":"* fixing several related bugs in CachingBAMFileIndex\r\n  * fixed an issue where cache hits in contigs with indexes higher than 127 could result in null values being returned incorrectly\r\n  * fixed a memory leak where we never released contigs with indexes 0 -> 127 from the cache\r\n* fixes #1127\r\n\r\nThe underlying issue was confusion over how WeakHashMap interacts with Integer.  \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/samtools/htsjdk/issues/comments/400047587","html_url":"https://github.com/samtools/htsjdk/pull/1156#issuecomment-400047587","issue_url":"https://api.github.com/repos/samtools/htsjdk/issues/1156","id":400047587,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDA0NzU4Nw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T18:20:32Z","updated_at":"2018-06-25T18:20:32Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/samtools/htsjdk/pull/1156?src=pr&el=h1) Report\n> Merging [#1156](https://codecov.io/gh/samtools/htsjdk/pull/1156?src=pr&el=desc) into [master](https://codecov.io/gh/samtools/htsjdk/commit/38a24d550f96bc89366fc54497c44812ef145059?src=pr&el=desc) will **increase** coverage by `0.006%`.\n> The diff coverage is `82.353%`.\n\n\n```diff\n@@               Coverage Diff               @@\n##              master     #1156       +/-   ##\n===============================================\n+ Coverage     68.336%   68.342%   +0.006%     \n- Complexity      8001      8003        +2     \n===============================================\n  Files            541       541               \n  Lines          32681     32684        +3     \n  Branches        5536      5536               \n===============================================\n+ Hits           22333     22337        +4     \n+ Misses          8122      8121        -1     \n  Partials        2226      2226\n```\n\n\n\n\n| [Impacted Files](https://codecov.io/gh/samtools/htsjdk/pull/1156?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...main/java/htsjdk/samtools/CachingBAMFileIndex.java](https://codecov.io/gh/samtools/htsjdk/pull/1156/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9odHNqZGsvc2FtdG9vbHMvQ2FjaGluZ0JBTUZpbGVJbmRleC5qYXZh) | `38.71% <82.353%> (-0.273%)` | `8 <6> (+1)` | |\n| [...samtools/util/AsyncBlockCompressedInputStream.java](https://codecov.io/gh/samtools/htsjdk/pull/1156/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9odHNqZGsvc2FtdG9vbHMvdXRpbC9Bc3luY0Jsb2NrQ29tcHJlc3NlZElucHV0U3RyZWFtLmphdmE=) | `76% <0%> (+4%)` | `13% <0%> (+1%)` | :arrow_up: |\n"}}
{"actor":{"display_login":"codecov-io"}}