{"action":"created","comment":{"url":"https://api.github.com/repos/decidim/decidim/pulls/comments/212936969","pull_request_review_id":149664982,"id":212936969,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjkzNjk2OQ==","diff_hunk":"@@ -0,0 +1,16 @@\n+# frozen_string_literal: true\n+\n+module Decidim\n+  module Attributes\n+    # Custom Virtus value to parse a String representing a Date using\n+    # the app localization format.\n+    class LocalizedDate < Virtus::Attribute\n+      def coerce(value)\n+        return value unless value.is_a?(String)\n+        Date.strptime(value, I18n.t(\"date.formats.decidim_short\"))\n+      rescue ArgumentError\n+        nil","path":"decidim-core/lib/decidim/attributes/localized_date.rb","position":12,"original_position":12,"commit_id":"ea7a7b26e6b3cf7014e5f055764b2ebfa114fed3","original_commit_id":"ea7a7b26e6b3cf7014e5f055764b2ebfa114fed3","user":{"login":"tramuntanal","id":199462,"node_id":"MDQ6VXNlcjE5OTQ2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/199462?v=4","gravatar_id":"","url":"https://api.github.com/users/tramuntanal","html_url":"https://github.com/tramuntanal","followers_url":"https://api.github.com/users/tramuntanal/followers","following_url":"https://api.github.com/users/tramuntanal/following{/other_user}","gists_url":"https://api.github.com/users/tramuntanal/gists{/gist_id}","starred_url":"https://api.github.com/users/tramuntanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tramuntanal/subscriptions","organizations_url":"https://api.github.com/users/tramuntanal/orgs","repos_url":"https://api.github.com/users/tramuntanal/repos","events_url":"https://api.github.com/users/tramuntanal/events{/privacy}","received_events_url":"https://api.github.com/users/tramuntanal/received_events","type":"User","site_admin":false},"body":"Very clever @deivid-rodriguez !\r\nCreating a custom attribute coercer is much better design than overriding coercible.\r\nJust a note, why swallow the `ArgumentError`? This will make parsing errors much more difficult to find, I know that they should not happen in production but still when testing they happened to me and was tedious to bind the cause to the specific line.","created_at":"2018-08-27T10:52:11Z","updated_at":"2018-08-27T10:52:24Z","html_url":"https://github.com/decidim/decidim/pull/3724#discussion_r212936969","pull_request_url":"https://api.github.com/repos/decidim/decidim/pulls/3724","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments/212936969"},"html":{"href":"https://github.com/decidim/decidim/pull/3724#discussion_r212936969"},"pull_request":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3724"}}},"pull_request":{"url":"https://api.github.com/repos/decidim/decidim/pulls/3724","id":197668146,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjY4MTQ2","html_url":"https://github.com/decidim/decidim/pull/3724","diff_url":"https://github.com/decidim/decidim/pull/3724.diff","patch_url":"https://github.com/decidim/decidim/pull/3724.patch","issue_url":"https://api.github.com/repos/decidim/decidim/issues/3724","number":3724,"state":"open","locked":false,"title":"Fix/3574 date field doesnt work when date is entered manually","user":{"login":"tramuntanal","id":199462,"node_id":"MDQ6VXNlcjE5OTQ2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/199462?v=4","gravatar_id":"","url":"https://api.github.com/users/tramuntanal","html_url":"https://github.com/tramuntanal","followers_url":"https://api.github.com/users/tramuntanal/followers","following_url":"https://api.github.com/users/tramuntanal/following{/other_user}","gists_url":"https://api.github.com/users/tramuntanal/gists{/gist_id}","starred_url":"https://api.github.com/users/tramuntanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tramuntanal/subscriptions","organizations_url":"https://api.github.com/users/tramuntanal/orgs","repos_url":"https://api.github.com/users/tramuntanal/repos","events_url":"https://api.github.com/users/tramuntanal/events{/privacy}","received_events_url":"https://api.github.com/users/tramuntanal/received_events","type":"User","site_admin":false},"body":"#### :tophat: What? Why?\r\nRemove the readonly attribute from date fields and add a text help with the localized format to be used by the user to enter the date manually.\r\n\r\n#### :pushpin: Related Issues\r\n- Fixes #3574 \r\n\r\n#### :clipboard: Subtasks\r\n- [x] Add `CHANGELOG` entry\r\n- [-] Add documentation regarding the feature \r\n- [-] Add/modify seeds\r\n- [x] Add tests\r\n\r\n### :camera: Screenshots (optional)\r\n![Description](URL)\r\n","created_at":"2018-06-27T09:21:50Z","updated_at":"2018-08-27T10:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3dfc09bcb4e47b3b38887db765689cf1701e4a8","assignee":{"login":"tramuntanal","id":199462,"node_id":"MDQ6VXNlcjE5OTQ2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/199462?v=4","gravatar_id":"","url":"https://api.github.com/users/tramuntanal","html_url":"https://github.com/tramuntanal","followers_url":"https://api.github.com/users/tramuntanal/followers","following_url":"https://api.github.com/users/tramuntanal/following{/other_user}","gists_url":"https://api.github.com/users/tramuntanal/gists{/gist_id}","starred_url":"https://api.github.com/users/tramuntanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tramuntanal/subscriptions","organizations_url":"https://api.github.com/users/tramuntanal/orgs","repos_url":"https://api.github.com/users/tramuntanal/repos","events_url":"https://api.github.com/users/tramuntanal/events{/privacy}","received_events_url":"https://api.github.com/users/tramuntanal/received_events","type":"User","site_admin":false},"assignees":[{"login":"tramuntanal","id":199462,"node_id":"MDQ6VXNlcjE5OTQ2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/199462?v=4","gravatar_id":"","url":"https://api.github.com/users/tramuntanal","html_url":"https://github.com/tramuntanal","followers_url":"https://api.github.com/users/tramuntanal/followers","following_url":"https://api.github.com/users/tramuntanal/following{/other_user}","gists_url":"https://api.github.com/users/tramuntanal/gists{/gist_id}","starred_url":"https://api.github.com/users/tramuntanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tramuntanal/subscriptions","organizations_url":"https://api.github.com/users/tramuntanal/orgs","repos_url":"https://api.github.com/users/tramuntanal/repos","events_url":"https://api.github.com/users/tramuntanal/events{/privacy}","received_events_url":"https://api.github.com/users/tramuntanal/received_events","type":"User","site_admin":false},{"login":"mrcasals","id":491891,"node_id":"MDQ6VXNlcjQ5MTg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false},{"login":"deivid-rodriguez","id":2887858,"node_id":"MDQ6VXNlcjI4ODc4NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2887858?v=4","gravatar_id":"","url":"https://api.github.com/users/deivid-rodriguez","html_url":"https://github.com/deivid-rodriguez","followers_url":"https://api.github.com/users/deivid-rodriguez/followers","following_url":"https://api.github.com/users/deivid-rodriguez/following{/other_user}","gists_url":"https://api.github.com/users/deivid-rodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/deivid-rodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deivid-rodriguez/subscriptions","organizations_url":"https://api.github.com/users/deivid-rodriguez/orgs","repos_url":"https://api.github.com/users/deivid-rodriguez/repos","events_url":"https://api.github.com/users/deivid-rodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/deivid-rodriguez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":518062863,"node_id":"MDU6TGFiZWw1MTgwNjI4NjM=","url":"https://api.github.com/repos/decidim/decidim/labels/in-review","name":"in-review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/decidim/decidim/pulls/3724/commits","review_comments_url":"https://api.github.com/repos/decidim/decidim/pulls/3724/comments","review_comment_url":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decidim/decidim/issues/3724/comments","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/ea7a7b26e6b3cf7014e5f055764b2ebfa114fed3","head":{"label":"decidim:fix/3574-date_field_doesnt_work_when_date_is_entered_manually","ref":"fix/3574-date_field_doesnt_work_when_date_is_entered_manually","sha":"ea7a7b26e6b3cf7014e5f055764b2ebfa114fed3","user":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"node_id":"MDEwOlJlcG9zaXRvcnk2NTkxNDA4Ng==","name":"decidim","full_name":"decidim/decidim","owner":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2018-08-27T10:20:38Z","pushed_at":"2018-08-27T10:33:18Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":52867,"stargazers_count":231,"watchers_count":231,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":84,"open_issues":202,"watchers":231,"default_branch":"master"}},"base":{"label":"decidim:master","ref":"master","sha":"1380511ffe75b0f88e658407160228ea7bf29cb8","user":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"node_id":"MDEwOlJlcG9zaXRvcnk2NTkxNDA4Ng==","name":"decidim","full_name":"decidim/decidim","owner":{"login":"decidim","id":22474646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc0NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2018-08-27T10:20:38Z","pushed_at":"2018-08-27T10:33:18Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":52867,"stargazers_count":231,"watchers_count":231,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":84,"open_issues":202,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3724"},"html":{"href":"https://github.com/decidim/decidim/pull/3724"},"issue":{"href":"https://api.github.com/repos/decidim/decidim/issues/3724"},"comments":{"href":"https://api.github.com/repos/decidim/decidim/issues/3724/comments"},"review_comments":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3724/comments"},"review_comment":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decidim/decidim/pulls/3724/commits"},"statuses":{"href":"https://api.github.com/repos/decidim/decidim/statuses/ea7a7b26e6b3cf7014e5f055764b2ebfa114fed3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tramuntanal"}}