{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5148","repository_url":"https://api.github.com/repos/pentaho/pentaho-kettle","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5148/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5148/comments","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5148/events","html_url":"https://github.com/pentaho/pentaho-kettle/pull/5148","id":309291052,"number":5148,"title":"[SP-4193][PDI-16891]-Incorrect remainder in division of numbers in Calculator step","user":{"login":"denisprotopopov","id":20943502,"avatar_url":"https://avatars1.githubusercontent.com/u/20943502?v=4","gravatar_id":"","url":"https://api.github.com/users/denisprotopopov","html_url":"https://github.com/denisprotopopov","followers_url":"https://api.github.com/users/denisprotopopov/followers","following_url":"https://api.github.com/users/denisprotopopov/following{/other_user}","gists_url":"https://api.github.com/users/denisprotopopov/gists{/gist_id}","starred_url":"https://api.github.com/users/denisprotopopov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisprotopopov/subscriptions","organizations_url":"https://api.github.com/users/denisprotopopov/orgs","repos_url":"https://api.github.com/users/denisprotopopov/repos","events_url":"https://api.github.com/users/denisprotopopov/events{/privacy}","received_events_url":"https://api.github.com/users/denisprotopopov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-28T09:37:30Z","updated_at":"2018-03-28T10:21:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/5148","html_url":"https://github.com/pentaho/pentaho-kettle/pull/5148","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/5148.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/5148.patch"},"body":" - fixed. now source values convert to the target data type before calculation"},"comment":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments/376836931","html_url":"https://github.com/pentaho/pentaho-kettle/pull/5148#issuecomment-376836931","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5148","id":376836931,"user":{"login":"wingman-pentaho","id":18704365,"avatar_url":"https://avatars1.githubusercontent.com/u/18704365?v=4","gravatar_id":"","url":"https://api.github.com/users/wingman-pentaho","html_url":"https://github.com/wingman-pentaho","followers_url":"https://api.github.com/users/wingman-pentaho/followers","following_url":"https://api.github.com/users/wingman-pentaho/following{/other_user}","gists_url":"https://api.github.com/users/wingman-pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-pentaho/subscriptions","organizations_url":"https://api.github.com/users/wingman-pentaho/orgs","repos_url":"https://api.github.com/users/wingman-pentaho/repos","events_url":"https://api.github.com/users/wingman-pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-pentaho/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T10:21:18Z","updated_at":"2018-03-28T10:21:18Z","author_association":"NONE","body":"### Build Completed\n\n:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.\n\n#### Build Commands\n\n```sh\nant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local\nant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local\n```\n\n#### Cleanup Commands\n```sh\nrm -r ~/.ivy2/local || echo no publish local to remove\n```\n\n#### Changed files\n\n```console\n  core/src/org/pentaho/di/core/row/ValueDataUtil.java\n  engine/src/org/pentaho/di/trans/steps/calculator/Calculator.java\n  engine/test-src/org/pentaho/di/core/row/ValueDataUtilTest.java\n  engine/test-src/org/pentaho/di/trans/steps/calculator/CalculatorUnitTest.java\n```\n\n#### Unit Test Coverage\n\nThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to [Jacoco's documentation](http://eclemma.org/jacoco/trunk/doc/counters.html).\n\n<details>\n<summary>:warning: <b>Coverage Changes</b> (click to expand)</summary>\n\n###### org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet\n * Branch Change: **-0.5%** :small_red_triangle_down:\n * Complexity Change: **-0.5%** :small_red_triangle_down:\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.job.entries.sql.JobEntrySQL\n * Instruction Change: **-3.3%** :small_red_triangle_down:\n * Line Change: **-3.9%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.step.StepMeta\n * Branch Change: **-0.7%** :small_red_triangle_down:\n * Complexity Change: **-0.6%** :small_red_triangle_down:\n * Instruction Change: **-0.2%** :small_red_triangle_down:\n * Line Change: **-0.2%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.checksum.CheckSumMeta\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.dbproc.DBProcMeta\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.groupby.GroupByMeta\n * Branch Change: **-3%** :small_red_triangle_down:\n * Complexity Change: **-3.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.tableoutput.TableOutputMeta\n * Branch Change: **-0.9%** :small_red_triangle_down:\n * Complexity Change: **-0.8%** :small_red_triangle_down:\n\n</details>\n\n#### Checkstyle violations\n\nThe code submitted is not complying with one or more of our guidelines. To perform these checks locally, [please use this tool](https://github.com/pentaho/pentaho-coding-standards).\n\n###### /home/buildguy/project/engine/test-src/org/pentaho/di/core/row/ValueDataUtilTest.java\n\n> :heavy_exclamation_mark: 'if' have incorrect indentation level 6, expected level should be 4. at Line: 797\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 799\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 801\n\n> :heavy_exclamation_mark: 'if' child have incorrect indentation level 8, expected level should be 6. at Line: 802\n\n> :heavy_exclamation_mark: 'member def type' have incorrect indentation level 8, expected level should be 6. at Line: 802\n\n> :heavy_exclamation_mark: 'try' have incorrect indentation level 8, expected level should be 6. at Line: 803\n\n> :heavy_exclamation_mark: 'try rcurly' have incorrect indentation level 8, expected level should be 6. at Line: 805\n\n> :heavy_exclamation_mark: 'catch' child have incorrect indentation level 10, expected level should be 8. at Line: 806\n\n> :heavy_exclamation_mark: 'catch' child have incorrect indentation level 10, expected level should be 8. at Line: 807\n\n> :heavy_exclamation_mark: 'catch rcurly' have incorrect indentation level 8, expected level should be 6. at Line: 808\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 809\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 811\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 813\n\n> :heavy_exclamation_mark: 'if' child have incorrect indentation level 8, expected level should be 6. at Line: 814\n\n> :heavy_exclamation_mark: 'member def type' have incorrect indentation level 8, expected level should be 6. at Line: 814\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 817\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 8, expected level should be 6. at Line: 820\n\n> :heavy_exclamation_mark: 'else rcurly' have incorrect indentation level 8, expected level should be 6. at Line: 822\n\n> :heavy_exclamation_mark: 'if rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 823\n\n> :heavy_exclamation_mark: 'else' child have incorrect indentation level 8, expected level should be 6. at Line: 824\n\n> :heavy_exclamation_mark: 'else' child have incorrect indentation level 8, expected level should be 6. at Line: 825\n\n> :heavy_exclamation_mark: 'else rcurly' have incorrect indentation level 6, expected level should be 4. at Line: 826"}}
{"actor":{"display_login":"wingman-pentaho"}}