{"action":"created","comment":{"url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/comments/168334646","pull_request_review_id":96685468,"id":168334646,"diff_hunk":"@@ -1,19 +1,27 @@\n package com.GeorgesServer.app;\n \n-import java.io.IOException;\n+import java.io.*;\n import java.net.ServerSocket;\n import java.net.Socket;\n+import java.nio.Buffer;\n \n public class EstablishesConnection {\n \n+    private SocketFactory socketFactory;\n+\n+    public EstablishesConnection (SocketFactory socketFactory) {\n+        this.socketFactory = socketFactory;\n+    }\n+\n     public Connections connect(int port) {\n-        try (ServerSocket serverConnection = new ServerSocket(port);\n-             Socket clientConnection = serverConnection.accept()) {\n-             return new Connections(serverConnection, clientConnection);\n-        }\n-        catch (IOException e) {\n-            e.printStackTrace();\n-            return null;\n-        }\n+        ServerSocket serverSocket = socketFactory.createSocket(port);","path":"src/main/java/com/GeorgesServer/app/EstablishesConnection.java","position":26,"original_position":26,"commit_id":"84b19b54097e18678b47b7bf374a94af6d8332e9","original_commit_id":"84b19b54097e18678b47b7bf374a94af6d8332e9","user":{"login":"JeromeGoodrich","id":11762514,"avatar_url":"https://avatars3.githubusercontent.com/u/11762514?v=4","gravatar_id":"","url":"https://api.github.com/users/JeromeGoodrich","html_url":"https://github.com/JeromeGoodrich","followers_url":"https://api.github.com/users/JeromeGoodrich/followers","following_url":"https://api.github.com/users/JeromeGoodrich/following{/other_user}","gists_url":"https://api.github.com/users/JeromeGoodrich/gists{/gist_id}","starred_url":"https://api.github.com/users/JeromeGoodrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeromeGoodrich/subscriptions","organizations_url":"https://api.github.com/users/JeromeGoodrich/orgs","repos_url":"https://api.github.com/users/JeromeGoodrich/repos","events_url":"https://api.github.com/users/JeromeGoodrich/events{/privacy}","received_events_url":"https://api.github.com/users/JeromeGoodrich/received_events","type":"User","site_admin":false},"body":"so much going on here, definitely break it up.","created_at":"2018-02-14T22:44:18Z","updated_at":"2018-02-14T22:44:18Z","html_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever/pull/3#discussion_r168334646","pull_request_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/comments/168334646"},"html":{"href":"https://github.com/GeorgeSmith-Sweeper/HTTPSever/pull/3#discussion_r168334646"},"pull_request":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3","id":169190946,"html_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever/pull/3","diff_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever/pull/3.diff","patch_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever/pull/3.patch","issue_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/3","number":3,"state":"closed","locked":false,"title":"Simple get passes on cobSpec","user":{"login":"GeorgeSmith-Sweeper","id":12597789,"avatar_url":"https://avatars2.githubusercontent.com/u/12597789?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeSmith-Sweeper","html_url":"https://github.com/GeorgeSmith-Sweeper","followers_url":"https://api.github.com/users/GeorgeSmith-Sweeper/followers","following_url":"https://api.github.com/users/GeorgeSmith-Sweeper/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSmith-Sweeper/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSmith-Sweeper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSmith-Sweeper/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSmith-Sweeper/orgs","repos_url":"https://api.github.com/users/GeorgeSmith-Sweeper/repos","events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/received_events","type":"User","site_admin":false},"body":"This PR includes all of my work which was necessary to pass simpleGet on cobSpec.\r\n\r\nFuture PR's will be smaller and more focused.\r\n","created_at":"2018-02-14T18:46:45Z","updated_at":"2018-02-14T22:44:18Z","closed_at":"2018-02-14T18:47:34Z","merged_at":"2018-02-14T18:47:34Z","merge_commit_sha":"a8c7b916354fd74ea659872cd3321e7ded83f3d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3/commits","review_comments_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3/comments","review_comment_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/3/comments","statuses_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/statuses/84b19b54097e18678b47b7bf374a94af6d8332e9","head":{"label":"GeorgeSmith-Sweeper:simpleGet","ref":"simpleGet","sha":"84b19b54097e18678b47b7bf374a94af6d8332e9","user":{"login":"GeorgeSmith-Sweeper","id":12597789,"avatar_url":"https://avatars2.githubusercontent.com/u/12597789?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeSmith-Sweeper","html_url":"https://github.com/GeorgeSmith-Sweeper","followers_url":"https://api.github.com/users/GeorgeSmith-Sweeper/followers","following_url":"https://api.github.com/users/GeorgeSmith-Sweeper/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSmith-Sweeper/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSmith-Sweeper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSmith-Sweeper/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSmith-Sweeper/orgs","repos_url":"https://api.github.com/users/GeorgeSmith-Sweeper/repos","events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/received_events","type":"User","site_admin":false},"repo":{"id":120473703,"name":"HTTPSever","full_name":"GeorgeSmith-Sweeper/HTTPSever","owner":{"login":"GeorgeSmith-Sweeper","id":12597789,"avatar_url":"https://avatars2.githubusercontent.com/u/12597789?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeSmith-Sweeper","html_url":"https://github.com/GeorgeSmith-Sweeper","followers_url":"https://api.github.com/users/GeorgeSmith-Sweeper/followers","following_url":"https://api.github.com/users/GeorgeSmith-Sweeper/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSmith-Sweeper/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSmith-Sweeper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSmith-Sweeper/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSmith-Sweeper/orgs","repos_url":"https://api.github.com/users/GeorgeSmith-Sweeper/repos","events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever","description":null,"fork":false,"url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever","forks_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/forks","keys_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/teams","hooks_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/hooks","issue_events_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/events{/number}","events_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/events","assignees_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/assignees{/user}","branches_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/branches{/branch}","tags_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/tags","blobs_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/statuses/{sha}","languages_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/languages","stargazers_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/stargazers","contributors_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/contributors","subscribers_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/subscribers","subscription_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/subscription","commits_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/contents/{+path}","compare_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/merges","archive_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/downloads","issues_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues{/number}","pulls_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls{/number}","milestones_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/milestones{/number}","notifications_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/labels{/name}","releases_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/releases{/id}","deployments_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/deployments","created_at":"2018-02-06T14:53:48Z","updated_at":"2018-02-06T14:54:26Z","pushed_at":"2018-02-14T18:47:34Z","git_url":"git://github.com/GeorgeSmith-Sweeper/HTTPSever.git","ssh_url":"git@github.com:GeorgeSmith-Sweeper/HTTPSever.git","clone_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever.git","svn_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"GeorgeSmith-Sweeper:master","ref":"master","sha":"12d5fdf3f4987521bf1d0d3fba2c89e3f8ed8f97","user":{"login":"GeorgeSmith-Sweeper","id":12597789,"avatar_url":"https://avatars2.githubusercontent.com/u/12597789?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeSmith-Sweeper","html_url":"https://github.com/GeorgeSmith-Sweeper","followers_url":"https://api.github.com/users/GeorgeSmith-Sweeper/followers","following_url":"https://api.github.com/users/GeorgeSmith-Sweeper/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSmith-Sweeper/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSmith-Sweeper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSmith-Sweeper/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSmith-Sweeper/orgs","repos_url":"https://api.github.com/users/GeorgeSmith-Sweeper/repos","events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/received_events","type":"User","site_admin":false},"repo":{"id":120473703,"name":"HTTPSever","full_name":"GeorgeSmith-Sweeper/HTTPSever","owner":{"login":"GeorgeSmith-Sweeper","id":12597789,"avatar_url":"https://avatars2.githubusercontent.com/u/12597789?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeSmith-Sweeper","html_url":"https://github.com/GeorgeSmith-Sweeper","followers_url":"https://api.github.com/users/GeorgeSmith-Sweeper/followers","following_url":"https://api.github.com/users/GeorgeSmith-Sweeper/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSmith-Sweeper/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSmith-Sweeper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSmith-Sweeper/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSmith-Sweeper/orgs","repos_url":"https://api.github.com/users/GeorgeSmith-Sweeper/repos","events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSmith-Sweeper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever","description":null,"fork":false,"url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever","forks_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/forks","keys_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/teams","hooks_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/hooks","issue_events_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/events{/number}","events_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/events","assignees_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/assignees{/user}","branches_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/branches{/branch}","tags_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/tags","blobs_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/statuses/{sha}","languages_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/languages","stargazers_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/stargazers","contributors_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/contributors","subscribers_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/subscribers","subscription_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/subscription","commits_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/contents/{+path}","compare_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/merges","archive_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/downloads","issues_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues{/number}","pulls_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls{/number}","milestones_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/milestones{/number}","notifications_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/labels{/name}","releases_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/releases{/id}","deployments_url":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/deployments","created_at":"2018-02-06T14:53:48Z","updated_at":"2018-02-06T14:54:26Z","pushed_at":"2018-02-14T18:47:34Z","git_url":"git://github.com/GeorgeSmith-Sweeper/HTTPSever.git","ssh_url":"git@github.com:GeorgeSmith-Sweeper/HTTPSever.git","clone_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever.git","svn_url":"https://github.com/GeorgeSmith-Sweeper/HTTPSever","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3"},"html":{"href":"https://github.com/GeorgeSmith-Sweeper/HTTPSever/pull/3"},"issue":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/3"},"comments":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/GeorgeSmith-Sweeper/HTTPSever/statuses/84b19b54097e18678b47b7bf374a94af6d8332e9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"JeromeGoodrich"}}