{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/207143247","pull_request_review_id":142693254,"id":207143247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE0MzI0Nw==","diff_hunk":"@@ -91,6 +91,29 @@ public static function onSitemapRobotsPageBeforeOutput( WebRequest $request, Use\n \t\treturn true;\n \t}\n \n+\tpublic static function parserUpgradeVignetteUrls( string &$url ) {\n+\t\tif ( preg_match( self::VIGNETTE_IMAGES_HTTP_UPGRADABLE, $url ) && strpos( $url, 'http://' ) === 0 ) {\n+\t\t\t$url = wfHttpToHttps( $url );\n+\t\t}\n+\t}\n+\n+\t/**\n+\t * Make sure any \"external\" links to our own wikis that support HTTPS\n+\t * are protocol-relative on output.\n+\t *\n+\t * @param  string  &$url\n+\t * @param  string  &$text\n+\t * @param  bool    &$link\n+\t * @param  array   &$attribs\n+\t * @return boolean\n+\t */\n+\tpublic static function onLinkerMakeExternalLink( string &$url, string &$text, bool &$link, array &$attribs ): bool {\n+\t\tif ( wfHttpsAllowedForURL( $url ) ) {\n+\t\t\t$url = wfProtocolUrlToRelative( $url );\n+\t\t}\n+\t\treturn true;","path":"extensions/wikia/HTTPSSupport/HTTPSSupportHooks.class.php","position":24,"original_position":24,"commit_id":"ed76c1fd27bb57c6079488b8ca31d7bee89bdbb7","original_commit_id":"ed76c1fd27bb57c6079488b8ca31d7bee89bdbb7","user":{"login":"jmail","id":296900,"node_id":"MDQ6VXNlcjI5NjkwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/296900?v=4","gravatar_id":"","url":"https://api.github.com/users/jmail","html_url":"https://github.com/jmail","followers_url":"https://api.github.com/users/jmail/followers","following_url":"https://api.github.com/users/jmail/following{/other_user}","gists_url":"https://api.github.com/users/jmail/gists{/gist_id}","starred_url":"https://api.github.com/users/jmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmail/subscriptions","organizations_url":"https://api.github.com/users/jmail/orgs","repos_url":"https://api.github.com/users/jmail/repos","events_url":"https://api.github.com/users/jmail/events{/privacy}","received_events_url":"https://api.github.com/users/jmail/received_events","type":"User","site_admin":false},"body":"Right... Then why this functions doesn't have it? https://github.com/Wikia/app/pull/15845/files#diff-fca4065dcdb1fb06adf96c5420beadf6R94","created_at":"2018-08-02T08:34:44Z","updated_at":"2018-08-02T08:34:44Z","html_url":"https://github.com/Wikia/app/pull/15845#discussion_r207143247","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/15845","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/207143247"},"html":{"href":"https://github.com/Wikia/app/pull/15845#discussion_r207143247"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/15845"}},"in_reply_to_id":207137774},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/15845","id":205643341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjQzMzQx","html_url":"https://github.com/Wikia/app/pull/15845","diff_url":"https://github.com/Wikia/app/pull/15845.diff","patch_url":"https://github.com/Wikia/app/pull/15845.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/15845","number":15845,"state":"open","locked":false,"title":"(PLATFORM-3616) Make external links to other wikis protocol-relative","user":{"login":"Grunny","id":230630,"node_id":"MDQ6VXNlcjIzMDYzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/230630?v=4","gravatar_id":"","url":"https://api.github.com/users/Grunny","html_url":"https://github.com/Grunny","followers_url":"https://api.github.com/users/Grunny/followers","following_url":"https://api.github.com/users/Grunny/following{/other_user}","gists_url":"https://api.github.com/users/Grunny/gists{/gist_id}","starred_url":"https://api.github.com/users/Grunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grunny/subscriptions","organizations_url":"https://api.github.com/users/Grunny/orgs","repos_url":"https://api.github.com/users/Grunny/repos","events_url":"https://api.github.com/users/Grunny/events{/privacy}","received_events_url":"https://api.github.com/users/Grunny/received_events","type":"User","site_admin":false},"body":"Make external links to other wikis protocol-relative for URLs to communities\r\nthat support HTTPS. This means we won't need users who paste URLs to other wikis\r\nto update them.\r\n\r\n/cc @Wikia/core-platform-team ","created_at":"2018-08-02T07:34:52Z","updated_at":"2018-08-02T08:34:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2afce3b3733741873265a4870a1cd535abb8e33c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"themech","id":150686,"node_id":"MDQ6VXNlcjE1MDY4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/150686?v=4","gravatar_id":"","url":"https://api.github.com/users/themech","html_url":"https://github.com/themech","followers_url":"https://api.github.com/users/themech/followers","following_url":"https://api.github.com/users/themech/following{/other_user}","gists_url":"https://api.github.com/users/themech/gists{/gist_id}","starred_url":"https://api.github.com/users/themech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themech/subscriptions","organizations_url":"https://api.github.com/users/themech/orgs","repos_url":"https://api.github.com/users/themech/repos","events_url":"https://api.github.com/users/themech/events{/privacy}","received_events_url":"https://api.github.com/users/themech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/15845/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/15845/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/15845/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/ed76c1fd27bb57c6079488b8ca31d7bee89bdbb7","head":{"label":"Wikia:PLATFORM-3616","ref":"PLATFORM-3616","sha":"ed76c1fd27bb57c6079488b8ca31d7bee89bdbb7","user":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"node_id":"MDEwOlJlcG9zaXRvcnk1NTMyMzEz","name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2018-08-02T08:34:22Z","pushed_at":"2018-08-02T08:34:14Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":764622,"stargazers_count":144,"watchers_count":144,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":113,"open_issues":25,"watchers":144,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"2fb524306fd87419475a18ffae02fa2ad4ead57e","user":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"node_id":"MDEwOlJlcG9zaXRvcnk1NTMyMzEz","name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2018-08-02T08:34:22Z","pushed_at":"2018-08-02T08:34:14Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":764622,"stargazers_count":144,"watchers_count":144,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":113,"open_issues":25,"watchers":144,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/15845"},"html":{"href":"https://github.com/Wikia/app/pull/15845"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/15845"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/15845/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/15845/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/15845/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/ed76c1fd27bb57c6079488b8ca31d7bee89bdbb7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jmail"}}