{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments/176966759","pull_request_review_id":106757295,"id":176966759,"diff_hunk":"@@ -43,28 +43,31 @@ git remote add heroku git@heroku.com:appinfive.git\n \n 4. Add ShopifyApp to gemfile\n ----------------------------\n-```\n+```sh\n $ echo \"gem 'shopify_app'\" >> Gemfile\n-\n-bundle install\n+$ bundle install\n ```\n \n Note - its recommended to use the latest released version. Check the git tags to see the latest release and then add it to your Gemfile e.g `gem 'shopify_app', '~> 7.0.0'`\n \n 5. Run the ShopifyApp generator\n -------------------------------\n+```sh\n+# use the keys from your app in the partners area\n+$ rails generate shopify_app --api_key a366cbafaccebd2f615aebdfc932fa1c --secret 8750306a895b3dbc7f4136c2ae2ea293\n+$ git add .\n+$ git commit -m 'generated shopify app'\n ```\n-use the keys from your app in the partners area\n-rails generate shopify_app --api_key a366cbafaccebd2f615aebdfc932fa1c --secret 8750306a895b3dbc7f4136c2ae2ea293\n-git add .\n-git commit -m 'generated shopify app'\n-```\n+\n+If you forget to set your keys or redirect uri above you will find them in the shopify_app initializer at: `/config/initializers/.`\n+\n+We recommend adding a gem or utilizing ENV variables to handle your keys before releasing your app.","path":"docs/Quickstart.md","position":73,"original_position":73,"commit_id":"a647eb6cb42a32498c16aa30142cc62aad238020","original_commit_id":"a647eb6cb42a32498c16aa30142cc62aad238020","user":{"login":"vfonic","id":67437,"avatar_url":"https://avatars0.githubusercontent.com/u/67437?v=4","gravatar_id":"","url":"https://api.github.com/users/vfonic","html_url":"https://github.com/vfonic","followers_url":"https://api.github.com/users/vfonic/followers","following_url":"https://api.github.com/users/vfonic/following{/other_user}","gists_url":"https://api.github.com/users/vfonic/gists{/gist_id}","starred_url":"https://api.github.com/users/vfonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfonic/subscriptions","organizations_url":"https://api.github.com/users/vfonic/orgs","repos_url":"https://api.github.com/users/vfonic/repos","events_url":"https://api.github.com/users/vfonic/events{/privacy}","received_events_url":"https://api.github.com/users/vfonic/received_events","type":"User","site_admin":false},"body":"I'm indifferent. I just know that a lot of people just copy-paste everything so it might be good to use obviously dummy values and point them in the right direction (which might even be pointing them towards gems like [figaro](https://github.com/laserlemon/figaro) or [dotenv](https://github.com/bkeepers/dotenv)","created_at":"2018-03-26T02:10:59Z","updated_at":"2018-03-26T02:10:59Z","html_url":"https://github.com/Shopify/shopify_app/pull/564#discussion_r176966759","pull_request_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments/176966759"},"html":{"href":"https://github.com/Shopify/shopify_app/pull/564#discussion_r176966759"},"pull_request":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/564"}},"in_reply_to_id":176948053},"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify_app/pulls/564","id":177259216,"html_url":"https://github.com/Shopify/shopify_app/pull/564","diff_url":"https://github.com/Shopify/shopify_app/pull/564.diff","patch_url":"https://github.com/Shopify/shopify_app/pull/564.patch","issue_url":"https://api.github.com/repos/Shopify/shopify_app/issues/564","number":564,"state":"open","locked":false,"title":"Quickstart.md: Update snippet MD to shell syntax, add notes on credentials to step 5","user":{"login":"0ptimusrhyme","id":12304900,"avatar_url":"https://avatars0.githubusercontent.com/u/12304900?v=4","gravatar_id":"","url":"https://api.github.com/users/0ptimusrhyme","html_url":"https://github.com/0ptimusrhyme","followers_url":"https://api.github.com/users/0ptimusrhyme/followers","following_url":"https://api.github.com/users/0ptimusrhyme/following{/other_user}","gists_url":"https://api.github.com/users/0ptimusrhyme/gists{/gist_id}","starred_url":"https://api.github.com/users/0ptimusrhyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0ptimusrhyme/subscriptions","organizations_url":"https://api.github.com/users/0ptimusrhyme/orgs","repos_url":"https://api.github.com/users/0ptimusrhyme/repos","events_url":"https://api.github.com/users/0ptimusrhyme/events{/privacy}","received_events_url":"https://api.github.com/users/0ptimusrhyme/received_events","type":"User","site_admin":false},"body":"Finishes #224 and resolves MD snippet nitpicks on Quickstart.md\r\n\r\nCC @jamiemtdwyer for 👀","created_at":"2018-03-24T21:14:22Z","updated_at":"2018-03-26T02:10:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65e8c5f9ae022533323b33dad21d67d3410b18e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/564/commits","review_comments_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/564/comments","review_comment_url":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/issues/564/comments","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/a647eb6cb42a32498c16aa30142cc62aad238020","head":{"label":"Shopify:update_quickstart_md","ref":"update_quickstart_md","sha":"a647eb6cb42a32498c16aa30142cc62aad238020","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61203,"name":"shopify_app","full_name":"Shopify/shopify_app","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_app","description":"A Rails Engine for building Shopify Apps","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_app","forks_url":"https://api.github.com/repos/Shopify/shopify_app/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_app/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_app/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_app/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_app/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_app/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_app/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_app/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_app/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_app/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_app/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_app/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_app/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_app/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_app/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_app/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_app/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_app/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_app/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_app/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_app/deployments","created_at":"2008-10-09T15:10:52Z","updated_at":"2018-03-23T16:05:27Z","pushed_at":"2018-03-24T21:14:22Z","git_url":"git://github.com/Shopify/shopify_app.git","ssh_url":"git@github.com:Shopify/shopify_app.git","clone_url":"https://github.com/Shopify/shopify_app.git","svn_url":"https://github.com/Shopify/shopify_app","homepage":"http://shopify.github.io/shopify_app","size":1030,"stargazers_count":745,"watchers_count":745,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":323,"open_issues":25,"watchers":745,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"8c0868ef36a9c4af8c8925d10feac41f221e8d44","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61203,"name":"shopify_app","full_name":"Shopify/shopify_app","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shopify_app","description":"A Rails Engine for building Shopify Apps","fork":false,"url":"https://api.github.com/repos/Shopify/shopify_app","forks_url":"https://api.github.com/repos/Shopify/shopify_app/forks","keys_url":"https://api.github.com/repos/Shopify/shopify_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shopify_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shopify_app/teams","hooks_url":"https://api.github.com/repos/Shopify/shopify_app/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shopify_app/events","assignees_url":"https://api.github.com/repos/Shopify/shopify_app/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shopify_app/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shopify_app/tags","blobs_url":"https://api.github.com/repos/Shopify/shopify_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shopify_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shopify_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shopify_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shopify_app/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shopify_app/languages","stargazers_url":"https://api.github.com/repos/Shopify/shopify_app/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shopify_app/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shopify_app/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shopify_app/subscription","commits_url":"https://api.github.com/repos/Shopify/shopify_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shopify_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shopify_app/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shopify_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shopify_app/merges","archive_url":"https://api.github.com/repos/Shopify/shopify_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shopify_app/downloads","issues_url":"https://api.github.com/repos/Shopify/shopify_app/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shopify_app/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shopify_app/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shopify_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shopify_app/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shopify_app/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shopify_app/deployments","created_at":"2008-10-09T15:10:52Z","updated_at":"2018-03-23T16:05:27Z","pushed_at":"2018-03-24T21:14:22Z","git_url":"git://github.com/Shopify/shopify_app.git","ssh_url":"git@github.com:Shopify/shopify_app.git","clone_url":"https://github.com/Shopify/shopify_app.git","svn_url":"https://github.com/Shopify/shopify_app","homepage":"http://shopify.github.io/shopify_app","size":1030,"stargazers_count":745,"watchers_count":745,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":323,"open_issues":25,"watchers":745,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/564"},"html":{"href":"https://github.com/Shopify/shopify_app/pull/564"},"issue":{"href":"https://api.github.com/repos/Shopify/shopify_app/issues/564"},"comments":{"href":"https://api.github.com/repos/Shopify/shopify_app/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/shopify_app/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/shopify_app/statuses/a647eb6cb42a32498c16aa30142cc62aad238020"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vfonic"}}