{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59941","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59941/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59941/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59941/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59941","id":297578665,"number":59941,"title":"[GCE] Refactor ExternalLoadBalancer Tests","user":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false},{"id":611767149,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-02-15T20:03:39Z","updated_at":"2018-02-22T00:44:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59941","html_url":"https://github.com/kubernetes/kubernetes/pull/59941","diff_url":"https://github.com/kubernetes/kubernetes/pull/59941.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59941.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n- Refactors the ExternalLoadBalancer tests to use the generated GCE mock instead of FakeCloudAddressService, FakeCloudForwardingRuleService.\r\n- Adds hooks to populate NetworkTier on Alpha resources\r\n- Moves shared code to top of the external loadbalancer test file\r\n- Moves NetworkTier into a constants file at the cloud level, so it is more easily called in subpackages\r\n\r\n**Special notes for your reviewer**:\r\n\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/367528737","html_url":"https://github.com/kubernetes/kubernetes/pull/59941#issuecomment-367528737","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59941","id":367528737,"user":{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T00:44:41Z","updated_at":"2018-02-22T00:44:41Z","author_association":"MEMBER","body":"/approve no-issue\r\nPinging @bowei for final review"}}
{"actor":{"display_login":"nicksardo"}}