{"action":"created","issue":{"url":"https://api.github.com/repos/NeovaHealth/nhclinical/issues/116","repository_url":"https://api.github.com/repos/NeovaHealth/nhclinical","labels_url":"https://api.github.com/repos/NeovaHealth/nhclinical/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/NeovaHealth/nhclinical/issues/116/comments","events_url":"https://api.github.com/repos/NeovaHealth/nhclinical/issues/116/events","html_url":"https://github.com/NeovaHealth/nhclinical/pull/116","id":303186961,"number":116,"title":"Module reorganisation","user":{"login":"moderatemisbehaviour","id":15190231,"avatar_url":"https://avatars3.githubusercontent.com/u/15190231?v=4","gravatar_id":"","url":"https://api.github.com/users/moderatemisbehaviour","html_url":"https://github.com/moderatemisbehaviour","followers_url":"https://api.github.com/users/moderatemisbehaviour/followers","following_url":"https://api.github.com/users/moderatemisbehaviour/following{/other_user}","gists_url":"https://api.github.com/users/moderatemisbehaviour/gists{/gist_id}","starred_url":"https://api.github.com/users/moderatemisbehaviour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderatemisbehaviour/subscriptions","organizations_url":"https://api.github.com/users/moderatemisbehaviour/orgs","repos_url":"https://api.github.com/users/moderatemisbehaviour/repos","events_url":"https://api.github.com/users/moderatemisbehaviour/events{/privacy}","received_events_url":"https://api.github.com/users/moderatemisbehaviour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-07T17:20:13Z","updated_at":"2018-03-09T11:11:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NeovaHealth/nhclinical/pulls/116","html_url":"https://github.com/NeovaHealth/nhclinical/pull/116","diff_url":"https://github.com/NeovaHealth/nhclinical/pull/116.diff","patch_url":"https://github.com/NeovaHealth/nhclinical/pull/116.patch"},"body":"Extracted several modules from nh_clinical which are now part of the openeobs repo:\r\n  - shift_management\r\n  - shift_allocation\r\n  - user_management\r\n\r\nAdded the liveobs_core module that sets up the root menu that these new modules add their menu items to. Other modules can follow this pattern.\r\nThe module also acts as a bundle of the dependencies from the nhclinical repo. The nh_eobs module depends on liveobs_core, eventually I would like to completely remove nh_eobs by extracting its content into sensible modules leaving only a few things in liveobs_core.\r\n\r\n---\r\n\r\nBefore this pull request can be merged the following must be true.\r\n- [ ] Unit tests pass (Travis integration).\r\n- [ ] No code quality issues (Codacy integration).\r\n- [ ] Approval from at least one developer and at least one tester.\r\n\r\nIf you are a BJSS contributor there are some additional conditions.\r\n- [ ] All client module unit tests pass.\r\n- [ ] The *Pull Request* field in the work tab of the JIRA issue is populated.\r\n- [ ] The JIRA issue contains a description of the root cause and the solution in the comments.\r\n- [ ] There are no bugs against the JIRA issues in the current sprint."},"comment":{"url":"https://api.github.com/repos/NeovaHealth/nhclinical/issues/comments/371784374","html_url":"https://github.com/NeovaHealth/nhclinical/pull/116#issuecomment-371784374","issue_url":"https://api.github.com/repos/NeovaHealth/nhclinical/issues/116","id":371784374,"user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T11:11:29Z","updated_at":"2018-03-09T11:11:29Z","author_association":"NONE","body":"\n![Codacy](https://app.codacy.com/assets/images/favicon.png) Here is an overview of what got changed by this pull request:\n\n\n```diff\n\nClones removed\n==============\n+ nh_clinical/tests/res_user/test_check_location_ids_constraint.py  -3\n+ nh_clinical/operations.py  -2\n         \n```\n\n\nSee the complete overview on [Codacy](https://app.codacy.com/app/BJSS/nhclinical/pullRequest?prid=1408035&bid=6727713)\n        "}}
{"actor":{"display_login":"codacy-bot"}}