{"action":"created","comment":{"url":"https://api.github.com/repos/p4lang/p4-applications/pulls/comments/168578604","pull_request_review_id":96970753,"id":168578604,"diff_hunk":"@@ -384,12 +384,36 @@ ignore the designated bit position.)\n * TCP/UDP destination Port field: A port number in layer 4 will be reserved to\n indicate the existence of INT after TCP/UDP. INT source changes the destination\n Port, and sink must restore the original port number.\n+* New Probe Marker fields: arbitrary 64-bit values are inserted after IP TCP/UDP header\n+to indicate the existence of INT after TCP/UDP. These fileds should be interpreted\n+as unsigned integer values, stored in network byte order and are initialized to a \n+configured value.  This Probe marker is a variation of an early IETF draft\n+https://tools.ietf.org/html/draft-lapukhov-dataplane-probe-01 (expired), with existing\n+implemetations.\n \n-The decision to use DSCP or destination port field and the reserved values are\n+INT probe marker for TCP/UDP:\n+\n+    0                   1                   2                   3\n+    0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1\n+   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+   |                         Probe Marker (1)                      |\n+   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+   |                         Probe Marker (2)                      |\n+   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+\n+\n+\n+The decision to use DSCP, destination port field or probe marker, and \n+the reserved or configured values are\n per domain decisions that all INT capable devices should follow. (Note: in\n general, encoding into DSCP field will be less intrusive compared to changing\n the layer 4 port field. The latter may alter ECMP behavior and can complicate\n-ACL and network debugging.)\n+ACL and network debugging. If DSCP field cannot be reseved for INT, and \n+retaining ECMP behavior is desired, adding probe marker fields could be an\n+option. With arbitary values being inserted after TCP/UDP header, the chance\n+to conflict with user traffic in a data center is low, but cannot be completely \n+eliminated. A user could choose to combine port number along with 64-bit marker\n+as an INT indicator to reduce the conflicting even more.) \n+","path":"telemetry/specs/INT.mdk","position":44,"original_position":44,"commit_id":"2f045dc369814ae96c30d71a62e5fa66ca878066","original_commit_id":"2f045dc369814ae96c30d71a62e5fa66ca878066","user":{"login":"heidinet","id":22667337,"avatar_url":"https://avatars1.githubusercontent.com/u/22667337?v=4","gravatar_id":"","url":"https://api.github.com/users/heidinet","html_url":"https://github.com/heidinet","followers_url":"https://api.github.com/users/heidinet/followers","following_url":"https://api.github.com/users/heidinet/following{/other_user}","gists_url":"https://api.github.com/users/heidinet/gists{/gist_id}","starred_url":"https://api.github.com/users/heidinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidinet/subscriptions","organizations_url":"https://api.github.com/users/heidinet/orgs","repos_url":"https://api.github.com/users/heidinet/repos","events_url":"https://api.github.com/users/heidinet/events{/privacy}","received_events_url":"https://api.github.com/users/heidinet/received_events","type":"User","site_admin":false},"body":"This extra \"port\" check applies to only \"probe marker\" option, shouldn't impact non-probe-marker approach. I will re-word it. ","created_at":"2018-02-15T19:13:31Z","updated_at":"2018-02-15T19:13:32Z","html_url":"https://github.com/p4lang/p4-applications/pull/18#discussion_r168578604","pull_request_url":"https://api.github.com/repos/p4lang/p4-applications/pulls/18","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4-applications/pulls/comments/168578604"},"html":{"href":"https://github.com/p4lang/p4-applications/pull/18#discussion_r168578604"},"pull_request":{"href":"https://api.github.com/repos/p4lang/p4-applications/pulls/18"}},"in_reply_to_id":168385605},"pull_request":{"url":"https://api.github.com/repos/p4lang/p4-applications/pulls/18","id":169203679,"html_url":"https://github.com/p4lang/p4-applications/pull/18","diff_url":"https://github.com/p4lang/p4-applications/pull/18.diff","patch_url":"https://github.com/p4lang/p4-applications/pull/18.patch","issue_url":"https://api.github.com/repos/p4lang/p4-applications/issues/18","number":18,"state":"open","locked":false,"title":"Add probe marker option to indicate the existence of INT in IP TCP/UDP packets","user":{"login":"heidinet","id":22667337,"avatar_url":"https://avatars1.githubusercontent.com/u/22667337?v=4","gravatar_id":"","url":"https://api.github.com/users/heidinet","html_url":"https://github.com/heidinet","followers_url":"https://api.github.com/users/heidinet/followers","following_url":"https://api.github.com/users/heidinet/following{/other_user}","gists_url":"https://api.github.com/users/heidinet/gists{/gist_id}","starred_url":"https://api.github.com/users/heidinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidinet/subscriptions","organizations_url":"https://api.github.com/users/heidinet/orgs","repos_url":"https://api.github.com/users/heidinet/repos","events_url":"https://api.github.com/users/heidinet/events{/privacy}","received_events_url":"https://api.github.com/users/heidinet/received_events","type":"User","site_admin":false},"body":"As discussed at P4 application meeting on Jan 18,  a new proposal was presented to satisfy certain deployment scenarios, where DSCP field can't be assigned for INT,  and TCP/UDP ports need to be kept to retain ECMP behavior.   With this proposal, probe marker with arbitrary values are inserted after TCP/UDP header as an indicator of INT existence. This probe marker was originally proposed by IETF draft https://tools.ietf.org/html/draft-lapukhov-dataplane-probe-01 (expired), and has been implemented by ASIC vendors.","created_at":"2018-02-14T19:42:29Z","updated_at":"2018-02-15T19:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4706081bbf75aa80b2643c3c1ff4d08ba697d437","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/p4-applications/pulls/18/commits","review_comments_url":"https://api.github.com/repos/p4lang/p4-applications/pulls/18/comments","review_comment_url":"https://api.github.com/repos/p4lang/p4-applications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/p4-applications/issues/18/comments","statuses_url":"https://api.github.com/repos/p4lang/p4-applications/statuses/2f045dc369814ae96c30d71a62e5fa66ca878066","head":{"label":"heidinet:master","ref":"master","sha":"2f045dc369814ae96c30d71a62e5fa66ca878066","user":{"login":"heidinet","id":22667337,"avatar_url":"https://avatars1.githubusercontent.com/u/22667337?v=4","gravatar_id":"","url":"https://api.github.com/users/heidinet","html_url":"https://github.com/heidinet","followers_url":"https://api.github.com/users/heidinet/followers","following_url":"https://api.github.com/users/heidinet/following{/other_user}","gists_url":"https://api.github.com/users/heidinet/gists{/gist_id}","starred_url":"https://api.github.com/users/heidinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidinet/subscriptions","organizations_url":"https://api.github.com/users/heidinet/orgs","repos_url":"https://api.github.com/users/heidinet/repos","events_url":"https://api.github.com/users/heidinet/events{/privacy}","received_events_url":"https://api.github.com/users/heidinet/received_events","type":"User","site_admin":false},"repo":{"id":121478805,"name":"p4-applications","full_name":"heidinet/p4-applications","owner":{"login":"heidinet","id":22667337,"avatar_url":"https://avatars1.githubusercontent.com/u/22667337?v=4","gravatar_id":"","url":"https://api.github.com/users/heidinet","html_url":"https://github.com/heidinet","followers_url":"https://api.github.com/users/heidinet/followers","following_url":"https://api.github.com/users/heidinet/following{/other_user}","gists_url":"https://api.github.com/users/heidinet/gists{/gist_id}","starred_url":"https://api.github.com/users/heidinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidinet/subscriptions","organizations_url":"https://api.github.com/users/heidinet/orgs","repos_url":"https://api.github.com/users/heidinet/repos","events_url":"https://api.github.com/users/heidinet/events{/privacy}","received_events_url":"https://api.github.com/users/heidinet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heidinet/p4-applications","description":"P4 Applications WG repo","fork":true,"url":"https://api.github.com/repos/heidinet/p4-applications","forks_url":"https://api.github.com/repos/heidinet/p4-applications/forks","keys_url":"https://api.github.com/repos/heidinet/p4-applications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heidinet/p4-applications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heidinet/p4-applications/teams","hooks_url":"https://api.github.com/repos/heidinet/p4-applications/hooks","issue_events_url":"https://api.github.com/repos/heidinet/p4-applications/issues/events{/number}","events_url":"https://api.github.com/repos/heidinet/p4-applications/events","assignees_url":"https://api.github.com/repos/heidinet/p4-applications/assignees{/user}","branches_url":"https://api.github.com/repos/heidinet/p4-applications/branches{/branch}","tags_url":"https://api.github.com/repos/heidinet/p4-applications/tags","blobs_url":"https://api.github.com/repos/heidinet/p4-applications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heidinet/p4-applications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heidinet/p4-applications/git/refs{/sha}","trees_url":"https://api.github.com/repos/heidinet/p4-applications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heidinet/p4-applications/statuses/{sha}","languages_url":"https://api.github.com/repos/heidinet/p4-applications/languages","stargazers_url":"https://api.github.com/repos/heidinet/p4-applications/stargazers","contributors_url":"https://api.github.com/repos/heidinet/p4-applications/contributors","subscribers_url":"https://api.github.com/repos/heidinet/p4-applications/subscribers","subscription_url":"https://api.github.com/repos/heidinet/p4-applications/subscription","commits_url":"https://api.github.com/repos/heidinet/p4-applications/commits{/sha}","git_commits_url":"https://api.github.com/repos/heidinet/p4-applications/git/commits{/sha}","comments_url":"https://api.github.com/repos/heidinet/p4-applications/comments{/number}","issue_comment_url":"https://api.github.com/repos/heidinet/p4-applications/issues/comments{/number}","contents_url":"https://api.github.com/repos/heidinet/p4-applications/contents/{+path}","compare_url":"https://api.github.com/repos/heidinet/p4-applications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heidinet/p4-applications/merges","archive_url":"https://api.github.com/repos/heidinet/p4-applications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heidinet/p4-applications/downloads","issues_url":"https://api.github.com/repos/heidinet/p4-applications/issues{/number}","pulls_url":"https://api.github.com/repos/heidinet/p4-applications/pulls{/number}","milestones_url":"https://api.github.com/repos/heidinet/p4-applications/milestones{/number}","notifications_url":"https://api.github.com/repos/heidinet/p4-applications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heidinet/p4-applications/labels{/name}","releases_url":"https://api.github.com/repos/heidinet/p4-applications/releases{/id}","deployments_url":"https://api.github.com/repos/heidinet/p4-applications/deployments","created_at":"2018-02-14T06:31:02Z","updated_at":"2018-02-14T06:31:03Z","pushed_at":"2018-02-15T00:13:47Z","git_url":"git://github.com/heidinet/p4-applications.git","ssh_url":"git@github.com:heidinet/p4-applications.git","clone_url":"https://github.com/heidinet/p4-applications.git","svn_url":"https://github.com/heidinet/p4-applications","homepage":"","size":3708,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"cf0b7b6ce373415e3ec44de4201557e4b98a8dce","user":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":109347811,"name":"p4-applications","full_name":"p4lang/p4-applications","owner":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4-applications","description":"P4 Applications WG repo","fork":false,"url":"https://api.github.com/repos/p4lang/p4-applications","forks_url":"https://api.github.com/repos/p4lang/p4-applications/forks","keys_url":"https://api.github.com/repos/p4lang/p4-applications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4-applications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4-applications/teams","hooks_url":"https://api.github.com/repos/p4lang/p4-applications/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4-applications/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4-applications/events","assignees_url":"https://api.github.com/repos/p4lang/p4-applications/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4-applications/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4-applications/tags","blobs_url":"https://api.github.com/repos/p4lang/p4-applications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4-applications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4-applications/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4-applications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4-applications/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4-applications/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4-applications/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4-applications/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4-applications/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4-applications/subscription","commits_url":"https://api.github.com/repos/p4lang/p4-applications/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4-applications/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4-applications/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4-applications/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4-applications/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4-applications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4-applications/merges","archive_url":"https://api.github.com/repos/p4lang/p4-applications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4-applications/downloads","issues_url":"https://api.github.com/repos/p4lang/p4-applications/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4-applications/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4-applications/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4-applications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4-applications/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4-applications/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4-applications/deployments","created_at":"2017-11-03T03:28:05Z","updated_at":"2018-01-18T17:18:44Z","pushed_at":"2018-02-15T04:04:36Z","git_url":"git://github.com/p4lang/p4-applications.git","ssh_url":"git@github.com:p4lang/p4-applications.git","clone_url":"https://github.com/p4lang/p4-applications.git","svn_url":"https://github.com/p4lang/p4-applications","homepage":"","size":3706,"stargazers_count":11,"watchers_count":11,"language":"Makefile","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":4,"open_issues":10,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4-applications/pulls/18"},"html":{"href":"https://github.com/p4lang/p4-applications/pull/18"},"issue":{"href":"https://api.github.com/repos/p4lang/p4-applications/issues/18"},"comments":{"href":"https://api.github.com/repos/p4lang/p4-applications/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/p4-applications/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/p4-applications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/p4-applications/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/p4-applications/statuses/2f045dc369814ae96c30d71a62e5fa66ca878066"}},"author_association":"NONE"}}
{"actor":{"display_login":"heidinet"}}