{"action":"opened","issue":{"url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android/issues/351","repository_url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android","labels_url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android/issues/351/labels{/name}","comments_url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android/issues/351/comments","events_url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android/issues/351/events","html_url":"https://github.com/FlowCrypt/flowcrypt-android/issues/351","id":375048204,"node_id":"MDU6SXNzdWUzNzUwNDgyMDQ=","number":351,"title":"change code indentation to two spaces per indent","user":{"login":"tomholub","id":6306961,"node_id":"MDQ6VXNlcjYzMDY5NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6306961?v=4","gravatar_id":"","url":"https://api.github.com/users/tomholub","html_url":"https://github.com/tomholub","followers_url":"https://api.github.com/users/tomholub/followers","following_url":"https://api.github.com/users/tomholub/following{/other_user}","gists_url":"https://api.github.com/users/tomholub/gists{/gist_id}","starred_url":"https://api.github.com/users/tomholub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomholub/subscriptions","organizations_url":"https://api.github.com/users/tomholub/orgs","repos_url":"https://api.github.com/users/tomholub/repos","events_url":"https://api.github.com/users/tomholub/events{/privacy}","received_events_url":"https://api.github.com/users/tomholub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android/milestones/31","html_url":"https://github.com/FlowCrypt/flowcrypt-android/milestone/31","labels_url":"https://api.github.com/repos/FlowCrypt/flowcrypt-android/milestones/31/labels","id":3679957,"node_id":"MDk6TWlsZXN0b25lMzY3OTk1Nw==","number":31,"title":"0.6.8","description":null,"creator":{"login":"DenBond7","id":2863246,"node_id":"MDQ6VXNlcjI4NjMyNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2863246?v=4","gravatar_id":"","url":"https://api.github.com/users/DenBond7","html_url":"https://github.com/DenBond7","followers_url":"https://api.github.com/users/DenBond7/followers","following_url":"https://api.github.com/users/DenBond7/following{/other_user}","gists_url":"https://api.github.com/users/DenBond7/gists{/gist_id}","starred_url":"https://api.github.com/users/DenBond7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenBond7/subscriptions","organizations_url":"https://api.github.com/users/DenBond7/orgs","repos_url":"https://api.github.com/users/DenBond7/repos","events_url":"https://api.github.com/users/DenBond7/events{/privacy}","received_events_url":"https://api.github.com/users/DenBond7/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":12,"state":"open","created_at":"2018-09-22T20:51:52Z","updated_at":"2018-10-29T14:38:59Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-10-29T14:38:59Z","updated_at":"2018-10-29T14:38:59Z","closed_at":null,"author_association":"COLLABORATOR","body":"This is what Google recommends in their guidelines: https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation which I think is sensible. They also recommend to indent with 4 spaces when doing a line-wrap of a long line: https://google.github.io/styleguide/javaguide.html#s4.5.2-line-wrapping-indent\r\n\r\nThis way nested blocks will not take up too much space on the left, allowing us to line-wrap less often. I find aggressively line-wrapped code hard to read:\r\n\r\n```java\r\n                            if (folderOfForwardedMessage == null) {\r\n                                folderOfForwardedMessage = (IMAPFolder) store.getFolder(new ImapLabelsDaoSource()\r\n                                        .getFolderByAlias(context, attachmentInfo.getEmail(),\r\n                                                attachmentInfo.getForwardedFolder()).getServerFullFolderName());\r\n                                folderOfForwardedMessage.open(Folder.READ_ONLY);\r\n                            }\r\n\r\n                            if (forwardedMessage == null) {\r\n                                forwardedMessage = folderOfForwardedMessage\r\n                                        .getMessageByUID(attachmentInfo.getForwardedUid());\r\n                            }\r\n```\r\n\r\nWith a two-space indent and limit of 120, this would become:\r\n```java\r\n              if (folderOfForwardedMessage == null) {\r\n                folderOfForwardedMessage = (IMAPFolder) store.getFolder(new ImapLabelsDaoSource().getFolderByAlias(\r\n                    context, attachmentInfo.getEmail(), attachmentInfo.getForwardedFolder()).getServerFullFolderName());\r\n                folderOfForwardedMessage.open(Folder.READ_ONLY);\r\n              }\r\n\r\n              if (forwardedMessage == null) {\r\n                forwardedMessage = folderOfForwardedMessage.getMessageByUID(attachmentInfo.getForwardedUid());\r\n              }\r\n```\r\nWith I think is better (except in gitbub comments like this, but we don't code in github comments)"}}
{"actor":{"display_login":"tomholub"}}