{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/171432487","pull_request_review_id":100283848,"id":171432487,"diff_hunk":"@@ -107,20 +107,15 @@ final class DFDLSchemaFile(val sset: SchemaSet,\n     // parser throws out of fatalErrors.\n   }\n \n-  private lazy val loader = {\n-    val ldr = new DaffodilXMLLoader(this)\n-    // val shouldValidate = sset.validateDFDLSchemas\n-    // ldr.setValidation(shouldValidate) // TODO: Validation not occurring JIRA DFDL-1473. Fix later.\n-    ldr\n-  }\n-\n   private def loadedNode = LV('loadedNode) {\n     def die(e: Throwable) = {\n       SDE(\"Error loading schema due to %s.\", Misc.getSomeMessage(e).getOrElse(\"an unknown error.\"))\n     }\n     val node = try {\n       log(LogLevel.Resolver, \"Loading %s.\", diagnosticDebugName)\n-      val node = loader.load(schemaSource)\n+      val ldr = new DaffodilXMLLoader(this)\n+      ldr.setValidation(false)","path":"daffodil-core/src/main/scala/org/apache/daffodil/dsom/DFDLSchemaFile.scala","position":null,"original_position":19,"commit_id":"9d700294a5e7e345721dec7fee5db9b62c28eefb","original_commit_id":"f3bcaa0ad13dc4404ca11b50528c977d3259468e","user":{"login":"mbeckerle","id":1524099,"avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"body":"Yes. This resolves DAFFODIL-1473 also.\r\n","created_at":"2018-03-01T00:38:08Z","updated_at":"2018-03-01T00:38:08Z","html_url":"https://github.com/apache/incubator-daffodil/pull/49#discussion_r171432487","pull_request_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/171432487"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/49#discussion_r171432487"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49"}},"in_reply_to_id":171227766},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49","id":171825667,"html_url":"https://github.com/apache/incubator-daffodil/pull/49","diff_url":"https://github.com/apache/incubator-daffodil/pull/49.diff","patch_url":"https://github.com/apache/incubator-daffodil/pull/49.patch","issue_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/49","number":49,"state":"open","locked":false,"title":"Daffodil 1907 non dfdl annotation","user":{"login":"mbeckerle","id":1524099,"avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"body":"Allows import of other XML Schemas for other annotation languages.\r\n    \r\n    Annotation languages (like DFDL) use XSD attribute declarations in the\r\n    annotation language's XML syntax.\r\n    \r\n    DFDL processors like Daffodil need to allow other annotation languages\r\n    to be annotated onto DFDL schemas.\r\n    \r\n    This creates a problem when importing the XSD for another annotation\r\n    language, since that XSD wants to also use things like XSD attribute\r\n    declarations if it validates the imported XSD as a DFDL schema because\r\n    it will refuse to accept the attribute decls. \r\n    \r\n    To allow import of a full-function XML Schema for an annotation\r\n    language, Daffodil looks at schemas for use of the DFDL_NAMESPACE. If\r\n    the root element of the schema uses the DFDL_NAMESPACE (e.g., to define\r\n    the dfdl prefix), then the file is treated as a DFDL schema. If the\r\n    DFDL_NAMESPACE is not used, then the file is not imported. It is\r\n    ignored.\r\n    \r\n    DAFFODIL-1907","created_at":"2018-02-28T00:37:21Z","updated_at":"2018-03-01T00:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2becacf9119a06685a05a590151b070e9ddfc3d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/49/comments","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/9d700294a5e7e345721dec7fee5db9b62c28eefb","head":{"label":"mbeckerle:daffodil-1907-nonDFDL-annotation","ref":"daffodil-1907-nonDFDL-annotation","sha":"9d700294a5e7e345721dec7fee5db9b62c28eefb","user":{"login":"mbeckerle","id":1524099,"avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"repo":{"id":108433914,"name":"incubator-daffodil","full_name":"mbeckerle/incubator-daffodil","owner":{"login":"mbeckerle","id":1524099,"avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbeckerle/incubator-daffodil","description":"Mirror of Apache daffodil (Incubating)","fork":true,"url":"https://api.github.com/repos/mbeckerle/incubator-daffodil","forks_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/deployments","created_at":"2017-10-26T16:00:06Z","updated_at":"2017-10-26T16:00:13Z","pushed_at":"2018-03-01T00:36:52Z","git_url":"git://github.com/mbeckerle/incubator-daffodil.git","ssh_url":"git@github.com:mbeckerle/incubator-daffodil.git","clone_url":"https://github.com/mbeckerle/incubator-daffodil.git","svn_url":"https://github.com/mbeckerle/incubator-daffodil","homepage":null,"size":169170,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"075084f5a825bde3168b8e89a02c7e58404cc325","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":101730006,"name":"incubator-daffodil","full_name":"apache/incubator-daffodil","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-daffodil","description":"Apache Daffodil (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-daffodil","forks_url":"https://api.github.com/repos/apache/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/apache/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/apache/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/apache/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/apache/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/apache/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/apache/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-daffodil/deployments","created_at":"2017-08-29T07:00:10Z","updated_at":"2018-01-09T19:13:54Z","pushed_at":"2018-03-01T00:36:54Z","git_url":"git://github.com/apache/incubator-daffodil.git","ssh_url":"git@github.com:apache/incubator-daffodil.git","clone_url":"https://github.com/apache/incubator-daffodil.git","svn_url":"https://github.com/apache/incubator-daffodil","homepage":"https://daffodil.apache.org/","size":169158,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/49"},"issue":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/49"},"comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-daffodil/statuses/9d700294a5e7e345721dec7fee5db9b62c28eefb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mbeckerle"}}