{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/226939863","pull_request_review_id":166867738,"id":226939863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjkzOTg2Mw==","diff_hunk":"@@ -0,0 +1,97 @@\n+/*\n+ * Copyright (c) 2018, Antonio Niño Díaz. All rights reserved.","path":"plat/meson/gxbb/aarch64/gxbb_helpers.S","position":2,"original_position":2,"commit_id":"14d6a53bc74fadf8df6f166878a125c72be75108","original_commit_id":"35dc6557c5cb0b3bb871633ed20697ff724cf338","user":{"login":"soby-mathew","id":6860836,"node_id":"MDQ6VXNlcjY4NjA4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6860836?v=4","gravatar_id":"","url":"https://api.github.com/users/soby-mathew","html_url":"https://github.com/soby-mathew","followers_url":"https://api.github.com/users/soby-mathew/followers","following_url":"https://api.github.com/users/soby-mathew/following{/other_user}","gists_url":"https://api.github.com/users/soby-mathew/gists{/gist_id}","starred_url":"https://api.github.com/users/soby-mathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soby-mathew/subscriptions","organizations_url":"https://api.github.com/users/soby-mathew/orgs","repos_url":"https://api.github.com/users/soby-mathew/repos","events_url":"https://api.github.com/users/soby-mathew/events{/privacy}","received_events_url":"https://api.github.com/users/soby-mathew/received_events","type":"User","site_admin":false},"body":"Its better to use the standard copyright header as in your other files.","created_at":"2018-10-22T09:14:37Z","updated_at":"2018-10-22T09:14:41Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1616#discussion_r226939863","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/226939863"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1616#discussion_r226939863"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616","id":221169188,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTY5MTg4","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1616","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1616.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1616.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1616","number":1616,"state":"open","locked":false,"title":"Initial port of Amlogic Meson S905 (GXBB)","user":{"login":"antonio-nino-diaz-arm","id":16819896,"node_id":"MDQ6VXNlcjE2ODE5ODk2","avatar_url":"https://avatars3.githubusercontent.com/u/16819896?v=4","gravatar_id":"","url":"https://api.github.com/users/antonio-nino-diaz-arm","html_url":"https://github.com/antonio-nino-diaz-arm","followers_url":"https://api.github.com/users/antonio-nino-diaz-arm/followers","following_url":"https://api.github.com/users/antonio-nino-diaz-arm/following{/other_user}","gists_url":"https://api.github.com/users/antonio-nino-diaz-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/antonio-nino-diaz-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonio-nino-diaz-arm/subscriptions","organizations_url":"https://api.github.com/users/antonio-nino-diaz-arm/orgs","repos_url":"https://api.github.com/users/antonio-nino-diaz-arm/repos","events_url":"https://api.github.com/users/antonio-nino-diaz-arm/events{/privacy}","received_events_url":"https://api.github.com/users/antonio-nino-diaz-arm/received_events","type":"User","site_admin":false},"body":"The Amlogic Meson S905 is a SoC with a quad core Arm Cortex-A53 running at 1.5Ghz. It also contains a Cortex-M3 used as SCP.\r\n\r\nThis port is a minimal implementation of BL31 capable of booting mainline U-Boot and Linux:\r\n- SCPI support.\r\n- Basic PSCI support (CPU_ON, CPU_OFF, SYSTEM_RESET, SYSTEM_OFF). Note that CPU0\r\n  can't be turned off so the firmware emulates it with a ``WFE`` loop.\r\n- GICv2 driver set up.\r\n- Basic SIP services (read efuse data, enable/disable JTAG).\r\n\r\nIn order to build it:\r\n\r\n```\r\nCROSS_COMPILE=aarch64-linux-gnu- make DEBUG=1 PLAT=gxbb bl31\r\n```\r\n\r\nThis port has been tested in a ODROID-C2. After building it, follow the instructions in the [U-Boot repository](https://github.com/u-boot/u-boot/blob/master/board/amlogic/odroid-c2/README), replacing the mentioned **bl31.bin** by the one built from this port.\r\n\r\nAlso, note that the final workaround for the issue with CPU0 will depend on the outcome of https://github.com/ARM-software/arm-trusted-firmware/pull/1613","created_at":"2018-10-08T16:03:46Z","updated_at":"2018-10-22T09:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"644aac89c7478ca18b101bec9882efcc09e021ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1616/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/14d6a53bc74fadf8df6f166878a125c72be75108","head":{"label":"antonio-nino-diaz-arm:an/gxbb","ref":"an/gxbb","sha":"14d6a53bc74fadf8df6f166878a125c72be75108","user":{"login":"antonio-nino-diaz-arm","id":16819896,"node_id":"MDQ6VXNlcjE2ODE5ODk2","avatar_url":"https://avatars3.githubusercontent.com/u/16819896?v=4","gravatar_id":"","url":"https://api.github.com/users/antonio-nino-diaz-arm","html_url":"https://github.com/antonio-nino-diaz-arm","followers_url":"https://api.github.com/users/antonio-nino-diaz-arm/followers","following_url":"https://api.github.com/users/antonio-nino-diaz-arm/following{/other_user}","gists_url":"https://api.github.com/users/antonio-nino-diaz-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/antonio-nino-diaz-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonio-nino-diaz-arm/subscriptions","organizations_url":"https://api.github.com/users/antonio-nino-diaz-arm/orgs","repos_url":"https://api.github.com/users/antonio-nino-diaz-arm/repos","events_url":"https://api.github.com/users/antonio-nino-diaz-arm/events{/privacy}","received_events_url":"https://api.github.com/users/antonio-nino-diaz-arm/received_events","type":"User","site_admin":false},"repo":{"id":50423468,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQyMzQ2OA==","name":"arm-trusted-firmware","full_name":"antonio-nino-diaz-arm/arm-trusted-firmware","private":false,"owner":{"login":"antonio-nino-diaz-arm","id":16819896,"node_id":"MDQ6VXNlcjE2ODE5ODk2","avatar_url":"https://avatars3.githubusercontent.com/u/16819896?v=4","gravatar_id":"","url":"https://api.github.com/users/antonio-nino-diaz-arm","html_url":"https://github.com/antonio-nino-diaz-arm","followers_url":"https://api.github.com/users/antonio-nino-diaz-arm/followers","following_url":"https://api.github.com/users/antonio-nino-diaz-arm/following{/other_user}","gists_url":"https://api.github.com/users/antonio-nino-diaz-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/antonio-nino-diaz-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonio-nino-diaz-arm/subscriptions","organizations_url":"https://api.github.com/users/antonio-nino-diaz-arm/orgs","repos_url":"https://api.github.com/users/antonio-nino-diaz-arm/repos","events_url":"https://api.github.com/users/antonio-nino-diaz-arm/events{/privacy}","received_events_url":"https://api.github.com/users/antonio-nino-diaz-arm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/antonio-nino-diaz-arm/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware","forks_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/antonio-nino-diaz-arm/arm-trusted-firmware/deployments","created_at":"2016-01-26T11:09:02Z","updated_at":"2018-08-13T15:01:20Z","pushed_at":"2018-10-21T22:30:42Z","git_url":"git://github.com/antonio-nino-diaz-arm/arm-trusted-firmware.git","ssh_url":"git@github.com:antonio-nino-diaz-arm/arm-trusted-firmware.git","clone_url":"https://github.com/antonio-nino-diaz-arm/arm-trusted-firmware.git","svn_url":"https://github.com/antonio-nino-diaz-arm/arm-trusted-firmware","homepage":null,"size":15825,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"0595abceba85bee8d6c27e6e122722f816610df7","user":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MDU4OQ==","name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","private":false,"owner":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"Trusted Firmware-A","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2018-10-20T16:25:42Z","pushed_at":"2018-10-21T22:30:44Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":"","size":15771,"stargazers_count":671,"watchers_count":671,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":571,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":571,"open_issues":18,"watchers":671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1616"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1616"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1616/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1616/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/14d6a53bc74fadf8df6f166878a125c72be75108"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"soby-mathew"}}