{"action":"created","comment":{"url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/comments/216439708","pull_request_review_id":153921053,"id":216439708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQzOTcwOA==","diff_hunk":"@@ -32,7 +32,20 @@ using ForwardDiff\n \n                 # test jacobian to a Rotation matrix\n                 R_jac = Rotations.jacobian(Quat, spq)\n-                FD_jac = ForwardDiff.jacobian(x -> (q = Quat(SPQuat(x[1],x[2],x[3]));\n+                FD_jac = ForwardDiff.jacobian(x -> (q = convert(Quat, SPQuat(x[1],x[2],x[3]));","path":"test/derivative_tests.jl","position":5,"original_position":5,"commit_id":"63865fe9f6749db957f763cde807f3f5b04fc4f3","original_commit_id":"63865fe9f6749db957f763cde807f3f5b04fc4f3","user":{"login":"ryanelandt","id":11097341,"node_id":"MDQ6VXNlcjExMDk3MzQx","avatar_url":"https://avatars2.githubusercontent.com/u/11097341?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanelandt","html_url":"https://github.com/ryanelandt","followers_url":"https://api.github.com/users/ryanelandt/followers","following_url":"https://api.github.com/users/ryanelandt/following{/other_user}","gists_url":"https://api.github.com/users/ryanelandt/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanelandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanelandt/subscriptions","organizations_url":"https://api.github.com/users/ryanelandt/orgs","repos_url":"https://api.github.com/users/ryanelandt/repos","events_url":"https://api.github.com/users/ryanelandt/events{/privacy}","received_events_url":"https://api.github.com/users/ryanelandt/received_events","type":"User","site_admin":false},"body":"Thanks for the heads up. I'll work on switching over to that once I get used to the new (and improved) behavior.","created_at":"2018-09-10T19:10:55Z","updated_at":"2018-09-10T19:10:55Z","html_url":"https://github.com/FugroRoames/Rotations.jl/pull/73#discussion_r216439708","pull_request_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/comments/216439708"},"html":{"href":"https://github.com/FugroRoames/Rotations.jl/pull/73#discussion_r216439708"},"pull_request":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73"}},"in_reply_to_id":216332992},"pull_request":{"url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73","id":214104662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTA0NjYy","html_url":"https://github.com/FugroRoames/Rotations.jl/pull/73","diff_url":"https://github.com/FugroRoames/Rotations.jl/pull/73.diff","patch_url":"https://github.com/FugroRoames/Rotations.jl/pull/73.patch","issue_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues/73","number":73,"state":"closed","locked":false,"title":"Fixed bug in dQuat/dSpq jacobian. Added tests relevant to this issue.","user":{"login":"ryanelandt","id":11097341,"node_id":"MDQ6VXNlcjExMDk3MzQx","avatar_url":"https://avatars2.githubusercontent.com/u/11097341?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanelandt","html_url":"https://github.com/ryanelandt","followers_url":"https://api.github.com/users/ryanelandt/followers","following_url":"https://api.github.com/users/ryanelandt/following{/other_user}","gists_url":"https://api.github.com/users/ryanelandt/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanelandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanelandt/subscriptions","organizations_url":"https://api.github.com/users/ryanelandt/orgs","repos_url":"https://api.github.com/users/ryanelandt/repos","events_url":"https://api.github.com/users/ryanelandt/events{/privacy}","received_events_url":"https://api.github.com/users/ryanelandt/received_events","type":"User","site_admin":false},"body":"The jacobian dQuat_dSPQ is a matrix of zeros for things like `Rotations.jacobian(Quat, SPQuat(1.0, 0.0, 0.0))`.\r\n\r\nNote: `SPQuat(1.0, 0.0, 0.0)` is the projection of `Quat(0.0, 1.0, 0.0, 0.0)` which has a non-negative real part.","created_at":"2018-09-08T17:01:50Z","updated_at":"2018-09-10T19:10:55Z","closed_at":"2018-09-10T15:16:38Z","merged_at":"2018-09-10T15:16:38Z","merge_commit_sha":"9ab157e7466ff3a615f497571484a9ab926433cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73/commits","review_comments_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73/comments","review_comment_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues/73/comments","statuses_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/statuses/63865fe9f6749db957f763cde807f3f5b04fc4f3","head":{"label":"ryanelandt:fix_jac_quat_spq","ref":"fix_jac_quat_spq","sha":"63865fe9f6749db957f763cde807f3f5b04fc4f3","user":{"login":"ryanelandt","id":11097341,"node_id":"MDQ6VXNlcjExMDk3MzQx","avatar_url":"https://avatars2.githubusercontent.com/u/11097341?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanelandt","html_url":"https://github.com/ryanelandt","followers_url":"https://api.github.com/users/ryanelandt/followers","following_url":"https://api.github.com/users/ryanelandt/following{/other_user}","gists_url":"https://api.github.com/users/ryanelandt/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanelandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanelandt/subscriptions","organizations_url":"https://api.github.com/users/ryanelandt/orgs","repos_url":"https://api.github.com/users/ryanelandt/repos","events_url":"https://api.github.com/users/ryanelandt/events{/privacy}","received_events_url":"https://api.github.com/users/ryanelandt/received_events","type":"User","site_admin":false},"repo":{"id":106142920,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYxNDI5MjA=","name":"Rotations.jl","full_name":"ryanelandt/Rotations.jl","owner":{"login":"ryanelandt","id":11097341,"node_id":"MDQ6VXNlcjExMDk3MzQx","avatar_url":"https://avatars2.githubusercontent.com/u/11097341?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanelandt","html_url":"https://github.com/ryanelandt","followers_url":"https://api.github.com/users/ryanelandt/followers","following_url":"https://api.github.com/users/ryanelandt/following{/other_user}","gists_url":"https://api.github.com/users/ryanelandt/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanelandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanelandt/subscriptions","organizations_url":"https://api.github.com/users/ryanelandt/orgs","repos_url":"https://api.github.com/users/ryanelandt/repos","events_url":"https://api.github.com/users/ryanelandt/events{/privacy}","received_events_url":"https://api.github.com/users/ryanelandt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanelandt/Rotations.jl","description":"Julia implementations for different rotation parameterisations","fork":true,"url":"https://api.github.com/repos/ryanelandt/Rotations.jl","forks_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/forks","keys_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/teams","hooks_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/hooks","issue_events_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/events","assignees_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/tags","blobs_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/languages","stargazers_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/stargazers","contributors_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/contributors","subscribers_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/subscribers","subscription_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/subscription","commits_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/merges","archive_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/downloads","issues_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/labels{/name}","releases_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/releases{/id}","deployments_url":"https://api.github.com/repos/ryanelandt/Rotations.jl/deployments","created_at":"2017-10-08T01:49:57Z","updated_at":"2018-09-10T15:59:00Z","pushed_at":"2018-09-10T18:51:46Z","git_url":"git://github.com/ryanelandt/Rotations.jl.git","ssh_url":"git@github.com:ryanelandt/Rotations.jl.git","clone_url":"https://github.com/ryanelandt/Rotations.jl.git","svn_url":"https://github.com/ryanelandt/Rotations.jl","homepage":null,"size":295,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FugroRoames:master","ref":"master","sha":"1dd972ccd074ef0cbeabc1f3d44d394a828d1c8a","user":{"login":"FugroRoames","id":7897460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTc0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7897460?v=4","gravatar_id":"","url":"https://api.github.com/users/FugroRoames","html_url":"https://github.com/FugroRoames","followers_url":"https://api.github.com/users/FugroRoames/followers","following_url":"https://api.github.com/users/FugroRoames/following{/other_user}","gists_url":"https://api.github.com/users/FugroRoames/gists{/gist_id}","starred_url":"https://api.github.com/users/FugroRoames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FugroRoames/subscriptions","organizations_url":"https://api.github.com/users/FugroRoames/orgs","repos_url":"https://api.github.com/users/FugroRoames/repos","events_url":"https://api.github.com/users/FugroRoames/events{/privacy}","received_events_url":"https://api.github.com/users/FugroRoames/received_events","type":"Organization","site_admin":false},"repo":{"id":53457088,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ1NzA4OA==","name":"Rotations.jl","full_name":"FugroRoames/Rotations.jl","owner":{"login":"FugroRoames","id":7897460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4OTc0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7897460?v=4","gravatar_id":"","url":"https://api.github.com/users/FugroRoames","html_url":"https://github.com/FugroRoames","followers_url":"https://api.github.com/users/FugroRoames/followers","following_url":"https://api.github.com/users/FugroRoames/following{/other_user}","gists_url":"https://api.github.com/users/FugroRoames/gists{/gist_id}","starred_url":"https://api.github.com/users/FugroRoames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FugroRoames/subscriptions","organizations_url":"https://api.github.com/users/FugroRoames/orgs","repos_url":"https://api.github.com/users/FugroRoames/repos","events_url":"https://api.github.com/users/FugroRoames/events{/privacy}","received_events_url":"https://api.github.com/users/FugroRoames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FugroRoames/Rotations.jl","description":"Julia implementations for different rotation parameterisations","fork":false,"url":"https://api.github.com/repos/FugroRoames/Rotations.jl","forks_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/forks","keys_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/teams","hooks_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/hooks","issue_events_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues/events{/number}","events_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/events","assignees_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/assignees{/user}","branches_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/branches{/branch}","tags_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/tags","blobs_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/languages","stargazers_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/stargazers","contributors_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/contributors","subscribers_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/subscribers","subscription_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/subscription","commits_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/contents/{+path}","compare_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/merges","archive_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/downloads","issues_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues{/number}","pulls_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/labels{/name}","releases_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/releases{/id}","deployments_url":"https://api.github.com/repos/FugroRoames/Rotations.jl/deployments","created_at":"2016-03-09T01:06:18Z","updated_at":"2018-09-10T15:16:42Z","pushed_at":"2018-09-10T16:58:18Z","git_url":"git://github.com/FugroRoames/Rotations.jl.git","ssh_url":"git@github.com:FugroRoames/Rotations.jl.git","clone_url":"https://github.com/FugroRoames/Rotations.jl.git","svn_url":"https://github.com/FugroRoames/Rotations.jl","homepage":null,"size":294,"stargazers_count":28,"watchers_count":28,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":7,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73"},"html":{"href":"https://github.com/FugroRoames/Rotations.jl/pull/73"},"issue":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues/73"},"comments":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/FugroRoames/Rotations.jl/statuses/63865fe9f6749db957f763cde807f3f5b04fc4f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryanelandt"}}