{"action":"created","comment":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/235977521","pull_request_review_id":177972807,"id":235977521,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTk3NzUyMQ==","diff_hunk":"@@ -195,7 +192,6 @@ def main(needsDict=None):\n if __name__ == \"__main__\":\n     needsDict = {}\n     if sys.argv:\n-        for i, dir in enumerate(sys.argv[1::2]):\n+        for i, dir in enumerate(sys.argv[1::2]):  # pylint: disable=redefined-builtin","path":"spacewalk/setup/share/embedded_diskspace_check.py","position":100,"original_position":95,"commit_id":"34edeba2f01be23f9a9a86bfdc34b31630d59f0d","original_commit_id":"7453112e53bf681e4993ed4683e94d151167ba1a","user":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"body":"As discussed, I've created a card to do this refactor on a separated PR: https://github.com/SUSE/salt-board/issues/185","created_at":"2018-11-23T15:48:23Z","updated_at":"2018-11-23T15:48:24Z","html_url":"https://github.com/uyuni-project/uyuni/pull/285#discussion_r235977521","pull_request_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/235977521"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/285#discussion_r235977521"},"pull_request":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285"}},"in_reply_to_id":235371385},"pull_request":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285","id":230132711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTMyNzEx","html_url":"https://github.com/uyuni-project/uyuni/pull/285","diff_url":"https://github.com/uyuni-project/uyuni/pull/285.diff","patch_url":"https://github.com/uyuni-project/uyuni/pull/285.patch","issue_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/285","number":285,"state":"open","locked":false,"title":"Adapt \"spacewalk-setup\" code to be Python 2/3 compatible","user":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"body":"## What does this PR change?\r\n\r\nThis PR makes `spacewalk-setup` code and package compatible with Python 3.\r\n\r\n**NOTE:** This package includes some Perl code that externally calls Python executable, so the spec file is changing the reference to this executable to `python3` in case the package is built for Python 3.\r\n\r\n## Links\r\n\r\nTracks https://github.com/SUSE/salt-board/issues/60\r\n\r\n- [x] **DONE**\r\n","created_at":"2018-11-12T13:23:24Z","updated_at":"2018-11-23T15:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7935caf6bb6ad36e17519a24144e1ebef3ff8c24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285/commits","review_comments_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285/comments","review_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/285/comments","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/34edeba2f01be23f9a9a86bfdc34b31630d59f0d","head":{"label":"meaksh:master-spacewalk-setup-python3","ref":"master-spacewalk-setup-python3","sha":"34edeba2f01be23f9a9a86bfdc34b31630d59f0d","user":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"repo":{"id":145697670,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2OTc2NzA=","name":"uyuni","full_name":"meaksh/uyuni","private":false,"owner":{"login":"meaksh","id":7229203,"node_id":"MDQ6VXNlcjcyMjkyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7229203?v=4","gravatar_id":"","url":"https://api.github.com/users/meaksh","html_url":"https://github.com/meaksh","followers_url":"https://api.github.com/users/meaksh/followers","following_url":"https://api.github.com/users/meaksh/following{/other_user}","gists_url":"https://api.github.com/users/meaksh/gists{/gist_id}","starred_url":"https://api.github.com/users/meaksh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meaksh/subscriptions","organizations_url":"https://api.github.com/users/meaksh/orgs","repos_url":"https://api.github.com/users/meaksh/repos","events_url":"https://api.github.com/users/meaksh/events{/privacy}","received_events_url":"https://api.github.com/users/meaksh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/meaksh/uyuni","description":"Source code for Uyuni","fork":true,"url":"https://api.github.com/repos/meaksh/uyuni","forks_url":"https://api.github.com/repos/meaksh/uyuni/forks","keys_url":"https://api.github.com/repos/meaksh/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meaksh/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meaksh/uyuni/teams","hooks_url":"https://api.github.com/repos/meaksh/uyuni/hooks","issue_events_url":"https://api.github.com/repos/meaksh/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/meaksh/uyuni/events","assignees_url":"https://api.github.com/repos/meaksh/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/meaksh/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/meaksh/uyuni/tags","blobs_url":"https://api.github.com/repos/meaksh/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meaksh/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meaksh/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/meaksh/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meaksh/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/meaksh/uyuni/languages","stargazers_url":"https://api.github.com/repos/meaksh/uyuni/stargazers","contributors_url":"https://api.github.com/repos/meaksh/uyuni/contributors","subscribers_url":"https://api.github.com/repos/meaksh/uyuni/subscribers","subscription_url":"https://api.github.com/repos/meaksh/uyuni/subscription","commits_url":"https://api.github.com/repos/meaksh/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/meaksh/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/meaksh/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/meaksh/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/meaksh/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/meaksh/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meaksh/uyuni/merges","archive_url":"https://api.github.com/repos/meaksh/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meaksh/uyuni/downloads","issues_url":"https://api.github.com/repos/meaksh/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/meaksh/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/meaksh/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/meaksh/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meaksh/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/meaksh/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/meaksh/uyuni/deployments","created_at":"2018-08-22T11:08:44Z","updated_at":"2018-08-22T11:10:03Z","pushed_at":"2018-11-23T13:12:34Z","git_url":"git://github.com/meaksh/uyuni.git","ssh_url":"git@github.com:meaksh/uyuni.git","clone_url":"https://github.com/meaksh/uyuni.git","svn_url":"https://github.com/meaksh/uyuni","homepage":"https://www.uyuni-project.org/","size":791288,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uyuni-project:master","ref":"master","sha":"917f5ffe9dba7ec6321e8314f9f5b459110f8aa7","user":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"repo":{"id":143291989,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTE5ODk=","name":"uyuni","full_name":"uyuni-project/uyuni","private":false,"owner":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uyuni-project/uyuni","description":"Source code for Uyuni","fork":false,"url":"https://api.github.com/repos/uyuni-project/uyuni","forks_url":"https://api.github.com/repos/uyuni-project/uyuni/forks","keys_url":"https://api.github.com/repos/uyuni-project/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uyuni-project/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uyuni-project/uyuni/teams","hooks_url":"https://api.github.com/repos/uyuni-project/uyuni/hooks","issue_events_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/uyuni-project/uyuni/events","assignees_url":"https://api.github.com/repos/uyuni-project/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/uyuni-project/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/uyuni-project/uyuni/tags","blobs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uyuni-project/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/uyuni-project/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/uyuni-project/uyuni/languages","stargazers_url":"https://api.github.com/repos/uyuni-project/uyuni/stargazers","contributors_url":"https://api.github.com/repos/uyuni-project/uyuni/contributors","subscribers_url":"https://api.github.com/repos/uyuni-project/uyuni/subscribers","subscription_url":"https://api.github.com/repos/uyuni-project/uyuni/subscription","commits_url":"https://api.github.com/repos/uyuni-project/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/uyuni-project/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/uyuni-project/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/uyuni-project/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uyuni-project/uyuni/merges","archive_url":"https://api.github.com/repos/uyuni-project/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uyuni-project/uyuni/downloads","issues_url":"https://api.github.com/repos/uyuni-project/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/uyuni-project/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/uyuni-project/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uyuni-project/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/uyuni-project/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/uyuni-project/uyuni/deployments","created_at":"2018-08-02T12:31:20Z","updated_at":"2018-11-23T13:24:32Z","pushed_at":"2018-11-23T15:33:50Z","git_url":"git://github.com/uyuni-project/uyuni.git","ssh_url":"git@github.com:uyuni-project/uyuni.git","clone_url":"https://github.com/uyuni-project/uyuni.git","svn_url":"https://github.com/uyuni-project/uyuni","homepage":"https://www.uyuni-project.org/","size":791328,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":24,"open_issues":30,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/285"},"issue":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/285"},"comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/uyuni-project/uyuni/statuses/34edeba2f01be23f9a9a86bfdc34b31630d59f0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"meaksh"}}