{"action":"closed","number":1933,"pull_request":{"url":"https://api.github.com/repos/kobotoolbox/kpi/pulls/1933","id":208522924,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTIyOTI0","html_url":"https://github.com/kobotoolbox/kpi/pull/1933","diff_url":"https://github.com/kobotoolbox/kpi/pull/1933.diff","patch_url":"https://github.com/kobotoolbox/kpi/pull/1933.patch","issue_url":"https://api.github.com/repos/kobotoolbox/kpi/issues/1933","number":1933,"state":"closed","locked":false,"title":"Bugfix: Simplify and fix fullscreen handling","user":{"login":"magicznyleszek","id":2521888,"node_id":"MDQ6VXNlcjI1MjE4ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/2521888?v=4","gravatar_id":"","url":"https://api.github.com/users/magicznyleszek","html_url":"https://github.com/magicznyleszek","followers_url":"https://api.github.com/users/magicznyleszek/followers","following_url":"https://api.github.com/users/magicznyleszek/following{/other_user}","gists_url":"https://api.github.com/users/magicznyleszek/gists{/gist_id}","starred_url":"https://api.github.com/users/magicznyleszek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicznyleszek/subscriptions","organizations_url":"https://api.github.com/users/magicznyleszek/orgs","repos_url":"https://api.github.com/users/magicznyleszek/repos","events_url":"https://api.github.com/users/magicznyleszek/events{/privacy}","received_events_url":"https://api.github.com/users/magicznyleszek/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nSimplify fullscreen handling for Map, Reports and Table views, by using CSS `position: fixed` instead of hiding layout elements with JS.\r\n\r\nAlso added some better accessibility related styles for sidetabs.\r\n\r\nHint: Use \" Hide whitespace changes\" when reviewing the changes.\r\n\r\n## Related issues\r\n\r\nFixes #1920\r\n\r\n","created_at":"2018-08-15T10:09:14Z","updated_at":"2018-09-04T14:40:27Z","closed_at":"2018-09-04T14:40:27Z","merged_at":"2018-09-04T14:40:26Z","merge_commit_sha":"45c6c64d3568f09d831305805b74f52c957e684f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kobotoolbox/kpi/pulls/1933/commits","review_comments_url":"https://api.github.com/repos/kobotoolbox/kpi/pulls/1933/comments","review_comment_url":"https://api.github.com/repos/kobotoolbox/kpi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kobotoolbox/kpi/issues/1933/comments","statuses_url":"https://api.github.com/repos/kobotoolbox/kpi/statuses/cfbbc076966f226e9575794935a6752babb24b83","head":{"label":"kobotoolbox:issue-1920","ref":"issue-1920","sha":"cfbbc076966f226e9575794935a6752babb24b83","user":{"login":"kobotoolbox","id":5543677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDM2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5543677?v=4","gravatar_id":"","url":"https://api.github.com/users/kobotoolbox","html_url":"https://github.com/kobotoolbox","followers_url":"https://api.github.com/users/kobotoolbox/followers","following_url":"https://api.github.com/users/kobotoolbox/following{/other_user}","gists_url":"https://api.github.com/users/kobotoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/kobotoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobotoolbox/subscriptions","organizations_url":"https://api.github.com/users/kobotoolbox/orgs","repos_url":"https://api.github.com/users/kobotoolbox/repos","events_url":"https://api.github.com/users/kobotoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/kobotoolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":31337353,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMzNzM1Mw==","name":"kpi","full_name":"kobotoolbox/kpi","owner":{"login":"kobotoolbox","id":5543677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDM2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5543677?v=4","gravatar_id":"","url":"https://api.github.com/users/kobotoolbox","html_url":"https://github.com/kobotoolbox","followers_url":"https://api.github.com/users/kobotoolbox/followers","following_url":"https://api.github.com/users/kobotoolbox/following{/other_user}","gists_url":"https://api.github.com/users/kobotoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/kobotoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobotoolbox/subscriptions","organizations_url":"https://api.github.com/users/kobotoolbox/orgs","repos_url":"https://api.github.com/users/kobotoolbox/repos","events_url":"https://api.github.com/users/kobotoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/kobotoolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kobotoolbox/kpi","description":"kpi: kobo-api","fork":false,"url":"https://api.github.com/repos/kobotoolbox/kpi","forks_url":"https://api.github.com/repos/kobotoolbox/kpi/forks","keys_url":"https://api.github.com/repos/kobotoolbox/kpi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kobotoolbox/kpi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kobotoolbox/kpi/teams","hooks_url":"https://api.github.com/repos/kobotoolbox/kpi/hooks","issue_events_url":"https://api.github.com/repos/kobotoolbox/kpi/issues/events{/number}","events_url":"https://api.github.com/repos/kobotoolbox/kpi/events","assignees_url":"https://api.github.com/repos/kobotoolbox/kpi/assignees{/user}","branches_url":"https://api.github.com/repos/kobotoolbox/kpi/branches{/branch}","tags_url":"https://api.github.com/repos/kobotoolbox/kpi/tags","blobs_url":"https://api.github.com/repos/kobotoolbox/kpi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kobotoolbox/kpi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kobotoolbox/kpi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kobotoolbox/kpi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kobotoolbox/kpi/statuses/{sha}","languages_url":"https://api.github.com/repos/kobotoolbox/kpi/languages","stargazers_url":"https://api.github.com/repos/kobotoolbox/kpi/stargazers","contributors_url":"https://api.github.com/repos/kobotoolbox/kpi/contributors","subscribers_url":"https://api.github.com/repos/kobotoolbox/kpi/subscribers","subscription_url":"https://api.github.com/repos/kobotoolbox/kpi/subscription","commits_url":"https://api.github.com/repos/kobotoolbox/kpi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kobotoolbox/kpi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kobotoolbox/kpi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kobotoolbox/kpi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kobotoolbox/kpi/contents/{+path}","compare_url":"https://api.github.com/repos/kobotoolbox/kpi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kobotoolbox/kpi/merges","archive_url":"https://api.github.com/repos/kobotoolbox/kpi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kobotoolbox/kpi/downloads","issues_url":"https://api.github.com/repos/kobotoolbox/kpi/issues{/number}","pulls_url":"https://api.github.com/repos/kobotoolbox/kpi/pulls{/number}","milestones_url":"https://api.github.com/repos/kobotoolbox/kpi/milestones{/number}","notifications_url":"https://api.github.com/repos/kobotoolbox/kpi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kobotoolbox/kpi/labels{/name}","releases_url":"https://api.github.com/repos/kobotoolbox/kpi/releases{/id}","deployments_url":"https://api.github.com/repos/kobotoolbox/kpi/deployments","created_at":"2015-02-25T21:45:33Z","updated_at":"2018-09-04T14:22:36Z","pushed_at":"2018-09-04T14:40:26Z","git_url":"git://github.com/kobotoolbox/kpi.git","ssh_url":"git@github.com:kobotoolbox/kpi.git","clone_url":"https://github.com/kobotoolbox/kpi.git","svn_url":"https://github.com/kobotoolbox/kpi","homepage":"","size":11386,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":43,"open_issues":277,"watchers":19,"default_branch":"master"}},"base":{"label":"kobotoolbox:master","ref":"master","sha":"62a171cdcabaea6e0ab418f5e2ffe90da4f75565","user":{"login":"kobotoolbox","id":5543677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDM2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5543677?v=4","gravatar_id":"","url":"https://api.github.com/users/kobotoolbox","html_url":"https://github.com/kobotoolbox","followers_url":"https://api.github.com/users/kobotoolbox/followers","following_url":"https://api.github.com/users/kobotoolbox/following{/other_user}","gists_url":"https://api.github.com/users/kobotoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/kobotoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobotoolbox/subscriptions","organizations_url":"https://api.github.com/users/kobotoolbox/orgs","repos_url":"https://api.github.com/users/kobotoolbox/repos","events_url":"https://api.github.com/users/kobotoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/kobotoolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":31337353,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMzNzM1Mw==","name":"kpi","full_name":"kobotoolbox/kpi","owner":{"login":"kobotoolbox","id":5543677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDM2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5543677?v=4","gravatar_id":"","url":"https://api.github.com/users/kobotoolbox","html_url":"https://github.com/kobotoolbox","followers_url":"https://api.github.com/users/kobotoolbox/followers","following_url":"https://api.github.com/users/kobotoolbox/following{/other_user}","gists_url":"https://api.github.com/users/kobotoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/kobotoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobotoolbox/subscriptions","organizations_url":"https://api.github.com/users/kobotoolbox/orgs","repos_url":"https://api.github.com/users/kobotoolbox/repos","events_url":"https://api.github.com/users/kobotoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/kobotoolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kobotoolbox/kpi","description":"kpi: kobo-api","fork":false,"url":"https://api.github.com/repos/kobotoolbox/kpi","forks_url":"https://api.github.com/repos/kobotoolbox/kpi/forks","keys_url":"https://api.github.com/repos/kobotoolbox/kpi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kobotoolbox/kpi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kobotoolbox/kpi/teams","hooks_url":"https://api.github.com/repos/kobotoolbox/kpi/hooks","issue_events_url":"https://api.github.com/repos/kobotoolbox/kpi/issues/events{/number}","events_url":"https://api.github.com/repos/kobotoolbox/kpi/events","assignees_url":"https://api.github.com/repos/kobotoolbox/kpi/assignees{/user}","branches_url":"https://api.github.com/repos/kobotoolbox/kpi/branches{/branch}","tags_url":"https://api.github.com/repos/kobotoolbox/kpi/tags","blobs_url":"https://api.github.com/repos/kobotoolbox/kpi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kobotoolbox/kpi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kobotoolbox/kpi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kobotoolbox/kpi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kobotoolbox/kpi/statuses/{sha}","languages_url":"https://api.github.com/repos/kobotoolbox/kpi/languages","stargazers_url":"https://api.github.com/repos/kobotoolbox/kpi/stargazers","contributors_url":"https://api.github.com/repos/kobotoolbox/kpi/contributors","subscribers_url":"https://api.github.com/repos/kobotoolbox/kpi/subscribers","subscription_url":"https://api.github.com/repos/kobotoolbox/kpi/subscription","commits_url":"https://api.github.com/repos/kobotoolbox/kpi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kobotoolbox/kpi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kobotoolbox/kpi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kobotoolbox/kpi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kobotoolbox/kpi/contents/{+path}","compare_url":"https://api.github.com/repos/kobotoolbox/kpi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kobotoolbox/kpi/merges","archive_url":"https://api.github.com/repos/kobotoolbox/kpi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kobotoolbox/kpi/downloads","issues_url":"https://api.github.com/repos/kobotoolbox/kpi/issues{/number}","pulls_url":"https://api.github.com/repos/kobotoolbox/kpi/pulls{/number}","milestones_url":"https://api.github.com/repos/kobotoolbox/kpi/milestones{/number}","notifications_url":"https://api.github.com/repos/kobotoolbox/kpi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kobotoolbox/kpi/labels{/name}","releases_url":"https://api.github.com/repos/kobotoolbox/kpi/releases{/id}","deployments_url":"https://api.github.com/repos/kobotoolbox/kpi/deployments","created_at":"2015-02-25T21:45:33Z","updated_at":"2018-09-04T14:22:36Z","pushed_at":"2018-09-04T14:40:26Z","git_url":"git://github.com/kobotoolbox/kpi.git","ssh_url":"git@github.com:kobotoolbox/kpi.git","clone_url":"https://github.com/kobotoolbox/kpi.git","svn_url":"https://github.com/kobotoolbox/kpi","homepage":"","size":11386,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":43,"open_issues":277,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kobotoolbox/kpi/pulls/1933"},"html":{"href":"https://github.com/kobotoolbox/kpi/pull/1933"},"issue":{"href":"https://api.github.com/repos/kobotoolbox/kpi/issues/1933"},"comments":{"href":"https://api.github.com/repos/kobotoolbox/kpi/issues/1933/comments"},"review_comments":{"href":"https://api.github.com/repos/kobotoolbox/kpi/pulls/1933/comments"},"review_comment":{"href":"https://api.github.com/repos/kobotoolbox/kpi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kobotoolbox/kpi/pulls/1933/commits"},"statuses":{"href":"https://api.github.com/repos/kobotoolbox/kpi/statuses/cfbbc076966f226e9575794935a6752babb24b83"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pmusaraj","id":368961,"node_id":"MDQ6VXNlcjM2ODk2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/368961?v=4","gravatar_id":"","url":"https://api.github.com/users/pmusaraj","html_url":"https://github.com/pmusaraj","followers_url":"https://api.github.com/users/pmusaraj/followers","following_url":"https://api.github.com/users/pmusaraj/following{/other_user}","gists_url":"https://api.github.com/users/pmusaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/pmusaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmusaraj/subscriptions","organizations_url":"https://api.github.com/users/pmusaraj/orgs","repos_url":"https://api.github.com/users/pmusaraj/repos","events_url":"https://api.github.com/users/pmusaraj/events{/privacy}","received_events_url":"https://api.github.com/users/pmusaraj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":126,"deletions":164,"changed_files":8}}
{"actor":{"display_login":"pmusaraj"}}