{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/elk/pulls/comments/192975585","pull_request_review_id":125852646,"id":192975585,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk3NTU4NQ==","diff_hunk":"@@ -80,6 +80,23 @@ public String getColor() {\n             }\n         }\n \n+        public boolean isNorthSouthDummy() {\n+            switch (this) {","path":"plugins/org.eclipse.elk.alg.layered/src/org/eclipse/elk/alg/layered/graph/LNode.java","position":5,"original_position":5,"commit_id":"12ab984e4cddd08acccd75ab417cf2691a69bcaa","original_commit_id":"12ab984e4cddd08acccd75ab417cf2691a69bcaa","user":{"login":"eNBeWe","id":3796429,"node_id":"MDQ6VXNlcjM3OTY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3796429?v=4","gravatar_id":"","url":"https://api.github.com/users/eNBeWe","html_url":"https://github.com/eNBeWe","followers_url":"https://api.github.com/users/eNBeWe/followers","following_url":"https://api.github.com/users/eNBeWe/following{/other_user}","gists_url":"https://api.github.com/users/eNBeWe/gists{/gist_id}","starred_url":"https://api.github.com/users/eNBeWe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eNBeWe/subscriptions","organizations_url":"https://api.github.com/users/eNBeWe/orgs","repos_url":"https://api.github.com/users/eNBeWe/repos","events_url":"https://api.github.com/users/eNBeWe/events{/privacy}","received_events_url":"https://api.github.com/users/eNBeWe/received_events","type":"User","site_admin":false},"body":"Fine with me, just saw the PortConstraints do this the same way.","created_at":"2018-06-05T07:44:21Z","updated_at":"2018-06-05T07:44:22Z","html_url":"https://github.com/eclipse/elk/pull/345#discussion_r192975585","pull_request_url":"https://api.github.com/repos/eclipse/elk/pulls/345","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/elk/pulls/comments/192975585"},"html":{"href":"https://github.com/eclipse/elk/pull/345#discussion_r192975585"},"pull_request":{"href":"https://api.github.com/repos/eclipse/elk/pulls/345"}},"in_reply_to_id":192972143},"pull_request":{"url":"https://api.github.com/repos/eclipse/elk/pulls/345","id":192017441,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDE3NDQx","html_url":"https://github.com/eclipse/elk/pull/345","diff_url":"https://github.com/eclipse/elk/pull/345.diff","patch_url":"https://github.com/eclipse/elk/pull/345.patch","issue_url":"https://api.github.com/repos/eclipse/elk/issues/345","number":345,"state":"open","locked":false,"title":"alg.layered: Implemented predicates for NorthSouth and LongEdge Dummies","user":{"login":"eNBeWe","id":3796429,"node_id":"MDQ6VXNlcjM3OTY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3796429?v=4","gravatar_id":"","url":"https://api.github.com/users/eNBeWe","html_url":"https://github.com/eNBeWe","followers_url":"https://api.github.com/users/eNBeWe/followers","following_url":"https://api.github.com/users/eNBeWe/following{/other_user}","gists_url":"https://api.github.com/users/eNBeWe/gists{/gist_id}","starred_url":"https://api.github.com/users/eNBeWe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eNBeWe/subscriptions","organizations_url":"https://api.github.com/users/eNBeWe/orgs","repos_url":"https://api.github.com/users/eNBeWe/repos","events_url":"https://api.github.com/users/eNBeWe/events{/privacy}","received_events_url":"https://api.github.com/users/eNBeWe/received_events","type":"User","site_admin":false},"body":"As a preliminary step to be able to merge north/south dummies with long\r\nedge dummies (#328), this commit replaces most (not all) checks for the\r\nenum values with the corresponding predicates.\r\nThere are still some places left where the enum values are used\r\ndirectly, primarily in some switch/cases in the crossing minimizer and\r\nin the spacing preparation.\r\n\r\nSigned-off-by: Nis Wechselberg <enbewe@enbewe.de>","created_at":"2018-06-01T12:14:40Z","updated_at":"2018-06-05T07:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d5fa89f3c85bcc1cc9a22d5ae995b7892650bdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/elk/pulls/345/commits","review_comments_url":"https://api.github.com/repos/eclipse/elk/pulls/345/comments","review_comment_url":"https://api.github.com/repos/eclipse/elk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/elk/issues/345/comments","statuses_url":"https://api.github.com/repos/eclipse/elk/statuses/12ab984e4cddd08acccd75ab417cf2691a69bcaa","head":{"label":"eNBeWe:master","ref":"master","sha":"12ab984e4cddd08acccd75ab417cf2691a69bcaa","user":{"login":"eNBeWe","id":3796429,"node_id":"MDQ6VXNlcjM3OTY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3796429?v=4","gravatar_id":"","url":"https://api.github.com/users/eNBeWe","html_url":"https://github.com/eNBeWe","followers_url":"https://api.github.com/users/eNBeWe/followers","following_url":"https://api.github.com/users/eNBeWe/following{/other_user}","gists_url":"https://api.github.com/users/eNBeWe/gists{/gist_id}","starred_url":"https://api.github.com/users/eNBeWe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eNBeWe/subscriptions","organizations_url":"https://api.github.com/users/eNBeWe/orgs","repos_url":"https://api.github.com/users/eNBeWe/repos","events_url":"https://api.github.com/users/eNBeWe/events{/privacy}","received_events_url":"https://api.github.com/users/eNBeWe/received_events","type":"User","site_admin":false},"repo":{"id":52446981,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQ0Njk4MQ==","name":"elk","full_name":"eNBeWe/elk","owner":{"login":"eNBeWe","id":3796429,"node_id":"MDQ6VXNlcjM3OTY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3796429?v=4","gravatar_id":"","url":"https://api.github.com/users/eNBeWe","html_url":"https://github.com/eNBeWe","followers_url":"https://api.github.com/users/eNBeWe/followers","following_url":"https://api.github.com/users/eNBeWe/following{/other_user}","gists_url":"https://api.github.com/users/eNBeWe/gists{/gist_id}","starred_url":"https://api.github.com/users/eNBeWe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eNBeWe/subscriptions","organizations_url":"https://api.github.com/users/eNBeWe/orgs","repos_url":"https://api.github.com/users/eNBeWe/repos","events_url":"https://api.github.com/users/eNBeWe/events{/privacy}","received_events_url":"https://api.github.com/users/eNBeWe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eNBeWe/elk","description":null,"fork":true,"url":"https://api.github.com/repos/eNBeWe/elk","forks_url":"https://api.github.com/repos/eNBeWe/elk/forks","keys_url":"https://api.github.com/repos/eNBeWe/elk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eNBeWe/elk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eNBeWe/elk/teams","hooks_url":"https://api.github.com/repos/eNBeWe/elk/hooks","issue_events_url":"https://api.github.com/repos/eNBeWe/elk/issues/events{/number}","events_url":"https://api.github.com/repos/eNBeWe/elk/events","assignees_url":"https://api.github.com/repos/eNBeWe/elk/assignees{/user}","branches_url":"https://api.github.com/repos/eNBeWe/elk/branches{/branch}","tags_url":"https://api.github.com/repos/eNBeWe/elk/tags","blobs_url":"https://api.github.com/repos/eNBeWe/elk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eNBeWe/elk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eNBeWe/elk/git/refs{/sha}","trees_url":"https://api.github.com/repos/eNBeWe/elk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eNBeWe/elk/statuses/{sha}","languages_url":"https://api.github.com/repos/eNBeWe/elk/languages","stargazers_url":"https://api.github.com/repos/eNBeWe/elk/stargazers","contributors_url":"https://api.github.com/repos/eNBeWe/elk/contributors","subscribers_url":"https://api.github.com/repos/eNBeWe/elk/subscribers","subscription_url":"https://api.github.com/repos/eNBeWe/elk/subscription","commits_url":"https://api.github.com/repos/eNBeWe/elk/commits{/sha}","git_commits_url":"https://api.github.com/repos/eNBeWe/elk/git/commits{/sha}","comments_url":"https://api.github.com/repos/eNBeWe/elk/comments{/number}","issue_comment_url":"https://api.github.com/repos/eNBeWe/elk/issues/comments{/number}","contents_url":"https://api.github.com/repos/eNBeWe/elk/contents/{+path}","compare_url":"https://api.github.com/repos/eNBeWe/elk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eNBeWe/elk/merges","archive_url":"https://api.github.com/repos/eNBeWe/elk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eNBeWe/elk/downloads","issues_url":"https://api.github.com/repos/eNBeWe/elk/issues{/number}","pulls_url":"https://api.github.com/repos/eNBeWe/elk/pulls{/number}","milestones_url":"https://api.github.com/repos/eNBeWe/elk/milestones{/number}","notifications_url":"https://api.github.com/repos/eNBeWe/elk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eNBeWe/elk/labels{/name}","releases_url":"https://api.github.com/repos/eNBeWe/elk/releases{/id}","deployments_url":"https://api.github.com/repos/eNBeWe/elk/deployments","created_at":"2016-02-24T14:07:16Z","updated_at":"2018-06-01T12:13:49Z","pushed_at":"2018-06-04T11:57:34Z","git_url":"git://github.com/eNBeWe/elk.git","ssh_url":"git@github.com:eNBeWe/elk.git","clone_url":"https://github.com/eNBeWe/elk.git","svn_url":"https://github.com/eNBeWe/elk","homepage":null,"size":14275,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d78c08b6d91e1bbf364050ef6990886a726daf27","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":44551321,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU1MTMyMQ==","name":"elk","full_name":"eclipse/elk","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/elk","description":"Eclipse Layout Kernel - Automatic layout for Java applications.","fork":false,"url":"https://api.github.com/repos/eclipse/elk","forks_url":"https://api.github.com/repos/eclipse/elk/forks","keys_url":"https://api.github.com/repos/eclipse/elk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/elk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/elk/teams","hooks_url":"https://api.github.com/repos/eclipse/elk/hooks","issue_events_url":"https://api.github.com/repos/eclipse/elk/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/elk/events","assignees_url":"https://api.github.com/repos/eclipse/elk/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/elk/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/elk/tags","blobs_url":"https://api.github.com/repos/eclipse/elk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/elk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/elk/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/elk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/elk/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/elk/languages","stargazers_url":"https://api.github.com/repos/eclipse/elk/stargazers","contributors_url":"https://api.github.com/repos/eclipse/elk/contributors","subscribers_url":"https://api.github.com/repos/eclipse/elk/subscribers","subscription_url":"https://api.github.com/repos/eclipse/elk/subscription","commits_url":"https://api.github.com/repos/eclipse/elk/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/elk/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/elk/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/elk/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/elk/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/elk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/elk/merges","archive_url":"https://api.github.com/repos/eclipse/elk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/elk/downloads","issues_url":"https://api.github.com/repos/eclipse/elk/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/elk/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/elk/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/elk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/elk/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/elk/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/elk/deployments","created_at":"2015-10-19T17:25:32Z","updated_at":"2018-06-01T11:48:22Z","pushed_at":"2018-06-04T11:57:35Z","git_url":"git://github.com/eclipse/elk.git","ssh_url":"git@github.com:eclipse/elk.git","clone_url":"https://github.com/eclipse/elk.git","svn_url":"https://github.com/eclipse/elk","homepage":"https://www.eclipse.org/elk/","size":14425,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":23,"open_issues":67,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/elk/pulls/345"},"html":{"href":"https://github.com/eclipse/elk/pull/345"},"issue":{"href":"https://api.github.com/repos/eclipse/elk/issues/345"},"comments":{"href":"https://api.github.com/repos/eclipse/elk/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/elk/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/elk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/elk/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/elk/statuses/12ab984e4cddd08acccd75ab417cf2691a69bcaa"}},"author_association":"NONE"}}
{"actor":{"display_login":"eNBeWe"}}