{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/187301946","pull_request_review_id":119052567,"id":187301946,"diff_hunk":"@@ -54,10 +54,13 @@ type MessagesRequest struct {\n \n func (r *MessagesRequest) setDefaults(now time.Time) {\n \t// set From and To defaults\n-\tif r.From == 0 && r.To == 0 {\n-\t\tr.From = uint32(now.UTC().Add(-24 * time.Hour).Unix())\n+\tif r.To == 0 {\n \t\tr.To = uint32(now.UTC().Unix())\n \t}\n+\n+\tif r.From == 0 {\n+\t\tr.From = r.To - 86400 // -24 hours","path":"services/shhext/api.go","position":11,"original_position":11,"commit_id":"a969a747131f92681fc819b40189e82dd13fecb9","original_commit_id":"f906fe34d3c4760196c1a5853b16fc81f0e640ed","user":{"login":"adambabik","id":277870,"avatar_url":"https://avatars1.githubusercontent.com/u/277870?v=4","gravatar_id":"","url":"https://api.github.com/users/adambabik","html_url":"https://github.com/adambabik","followers_url":"https://api.github.com/users/adambabik/followers","following_url":"https://api.github.com/users/adambabik/following{/other_user}","gists_url":"https://api.github.com/users/adambabik/gists{/gist_id}","starred_url":"https://api.github.com/users/adambabik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambabik/subscriptions","organizations_url":"https://api.github.com/users/adambabik/orgs","repos_url":"https://api.github.com/users/adambabik/repos","events_url":"https://api.github.com/users/adambabik/events{/privacy}","received_events_url":"https://api.github.com/users/adambabik/received_events","type":"User","site_admin":false},"body":"What's gonna happen if `From` is set to `0`? `To` should not be `0` ever.","created_at":"2018-05-10T11:09:14Z","updated_at":"2018-05-10T11:16:36Z","html_url":"https://github.com/status-im/status-go/pull/934#discussion_r187301946","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/934","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/187301946"},"html":{"href":"https://github.com/status-im/status-go/pull/934#discussion_r187301946"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/934"}},"in_reply_to_id":187298904},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/934","id":187160453,"html_url":"https://github.com/status-im/status-go/pull/934","diff_url":"https://github.com/status-im/status-go/pull/934.diff","patch_url":"https://github.com/status-im/status-go/pull/934.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/934","number":934,"state":"open","locked":false,"title":"fix default range value for shhext_requestMessages","user":{"login":"pilu","id":1059,"avatar_url":"https://avatars1.githubusercontent.com/u/1059?v=4","gravatar_id":"","url":"https://api.github.com/users/pilu","html_url":"https://github.com/pilu","followers_url":"https://api.github.com/users/pilu/followers","following_url":"https://api.github.com/users/pilu/following{/other_user}","gists_url":"https://api.github.com/users/pilu/gists{/gist_id}","starred_url":"https://api.github.com/users/pilu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilu/subscriptions","organizations_url":"https://api.github.com/users/pilu/orgs","repos_url":"https://api.github.com/users/pilu/repos","events_url":"https://api.github.com/users/pilu/events{/privacy}","received_events_url":"https://api.github.com/users/pilu/received_events","type":"User","site_admin":false},"body":"This PR set the default value of `From` and `To` in the  `shhext_requestMessages` call in case only one of the 2 is set.\r\n\r\nCloses #933 \r\n\r\n","created_at":"2018-05-10T10:48:27Z","updated_at":"2018-05-10T11:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e4faec4ff2c40e7e0ec142e1ab9a1c04dd92b9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/934/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/934/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/934/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/a969a747131f92681fc819b40189e82dd13fecb9","head":{"label":"status-im:fix/shhext-request-messages-range","ref":"fix/shhext-request-messages-range","sha":"a969a747131f92681fc819b40189e82dd13fecb9","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-05-09T23:59:08Z","pushed_at":"2018-05-10T11:16:01Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":38483,"stargazers_count":387,"watchers_count":387,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":125,"open_issues":75,"watchers":387,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"f7dac0bcc443ba20f27e187ed7c49944a304b075","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-05-09T23:59:08Z","pushed_at":"2018-05-10T11:16:01Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":38483,"stargazers_count":387,"watchers_count":387,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":125,"open_issues":75,"watchers":387,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/934"},"html":{"href":"https://github.com/status-im/status-go/pull/934"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/934"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/a969a747131f92681fc819b40189e82dd13fecb9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adambabik"}}