{"action":"created","issue":{"url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/issues/3","repository_url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms","labels_url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/issues/3/comments","events_url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/issues/3/events","html_url":"https://github.com/parkito/BasicDataStructuresAndAlgorithms/pull/3","id":306936225,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc2MjQ0MjQx","number":3,"title":"Tentative patch for fixing NullPointerException","user":{"login":"lucesape","id":25684262,"node_id":"MDQ6VXNlcjI1Njg0MjYy","avatar_url":"https://avatars0.githubusercontent.com/u/25684262?v=4","gravatar_id":"","url":"https://api.github.com/users/lucesape","html_url":"https://github.com/lucesape","followers_url":"https://api.github.com/users/lucesape/followers","following_url":"https://api.github.com/users/lucesape/following{/other_user}","gists_url":"https://api.github.com/users/lucesape/gists{/gist_id}","starred_url":"https://api.github.com/users/lucesape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucesape/subscriptions","organizations_url":"https://api.github.com/users/lucesape/orgs","repos_url":"https://api.github.com/users/lucesape/repos","events_url":"https://api.github.com/users/lucesape/events{/privacy}","received_events_url":"https://api.github.com/users/lucesape/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-20T16:14:53Z","updated_at":"2018-10-20T21:39:07Z","closed_at":"2018-03-21T18:44:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/pulls/3","html_url":"https://github.com/parkito/BasicDataStructuresAndAlgorithms/pull/3","diff_url":"https://github.com/parkito/BasicDataStructuresAndAlgorithms/pull/3.diff","patch_url":"https://github.com/parkito/BasicDataStructuresAndAlgorithms/pull/3.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/issues/comments/431620030","html_url":"https://github.com/parkito/BasicDataStructuresAndAlgorithms/pull/3#issuecomment-431620030","issue_url":"https://api.github.com/repos/parkito/BasicDataStructuresAndAlgorithms/issues/3","id":431620030,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTYyMDAzMA==","user":{"login":"oskarb","id":482095,"node_id":"MDQ6VXNlcjQ4MjA5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/482095?v=4","gravatar_id":"","url":"https://api.github.com/users/oskarb","html_url":"https://github.com/oskarb","followers_url":"https://api.github.com/users/oskarb/followers","following_url":"https://api.github.com/users/oskarb/following{/other_user}","gists_url":"https://api.github.com/users/oskarb/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarb/subscriptions","organizations_url":"https://api.github.com/users/oskarb/orgs","repos_url":"https://api.github.com/users/oskarb/repos","events_url":"https://api.github.com/users/oskarb/events{/privacy}","received_events_url":"https://api.github.com/users/oskarb/received_events","type":"User","site_admin":false},"created_at":"2018-10-20T21:39:07Z","updated_at":"2018-10-20T21:39:07Z","author_association":"NONE","body":"@monperrus\r\n@parkito \r\n\r\nInteresting experiment @monperrus :)  I suppose this particular patch is an interesting example of the current limitations of the algorithm. It may fix a particular test failure, but it seems clear there is no deeper understanding of what the problem really is. When looking at the patch, one does wonder why the null-check would only be necessary in the else-part of the existing if-statement, but not in the if-part.\r\n\r\nIndeed, the following day the code was changed again to put the null check outside the existing if-statement so that it wraps it completely (https://github.com/parkito/BasicDataStructuresAndAlgorithms/commit/be919c4f3947de2ec9f2995a3e901a1a9920e0e0#diff-f62ed0ede838c6f14f83f7abe9d37b79):\r\n\r\n    private void detachCurrentNode(Node node) {\r\n        if (node.parent != null) {\r\n            if (node.isLeftChild) {\r\n                node.parent.leftChild = null;\r\n            } else {\r\n                node.parent.rightChild = null;\r\n            }\r\n        }\r\n    }\r\n\r\n"}}
{"actor":{"display_login":"oskarb"}}