{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/193467529","pull_request_review_id":126446049,"id":193467529,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ2NzUyOQ==","diff_hunk":"@@ -321,6 +321,25 @@ func validateVirtualMachineSpec(field *k8sfield.Path, spec *v1.VirtualMachineSpe\n \t\treturn causes\n \t}\n \n+\t// Validate memory size if values are not negative\n+\tif spec.Domain.Resources.Requests.Memory().Value() < 0 {","path":"pkg/virt-api/validating-webhook/validating-webhook.go","position":5,"original_position":5,"commit_id":"75978d190089de56d5d36c85b082c488764dd0ad","original_commit_id":"75978d190089de56d5d36c85b082c488764dd0ad","user":{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"body":"It's very easy to follow like you did it. Good enough for now.","created_at":"2018-06-06T16:05:18Z","updated_at":"2018-06-06T16:23:23Z","html_url":"https://github.com/kubevirt/kubevirt/pull/1106#discussion_r193467529","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/193467529"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1106#discussion_r193467529"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106"}},"in_reply_to_id":193466673},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106","id":192923386,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTIzMzg2","html_url":"https://github.com/kubevirt/kubevirt/pull/1106","diff_url":"https://github.com/kubevirt/kubevirt/pull/1106.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1106.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1106","number":1106,"state":"open","locked":false,"title":"Fixed memory calculation for virtual machine ","user":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"body":"Bugfix for issue: https://github.com/kubevirt/kubevirt/issues/1100\r\n\r\nChanges:\r\n- changed memory unit from MB to B\r\n- extended tests for memory calculation","created_at":"2018-06-06T07:30:04Z","updated_at":"2018-06-06T16:23:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8288f02a6f34f42e4737571a0c433621e91ac68","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vladikr","id":1035064,"node_id":"MDQ6VXNlcjEwMzUwNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1035064?v=4","gravatar_id":"","url":"https://api.github.com/users/vladikr","html_url":"https://github.com/vladikr","followers_url":"https://api.github.com/users/vladikr/followers","following_url":"https://api.github.com/users/vladikr/following{/other_user}","gists_url":"https://api.github.com/users/vladikr/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikr/subscriptions","organizations_url":"https://api.github.com/users/vladikr/orgs","repos_url":"https://api.github.com/users/vladikr/repos","events_url":"https://api.github.com/users/vladikr/events{/privacy}","received_events_url":"https://api.github.com/users/vladikr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1106/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/75978d190089de56d5d36c85b082c488764dd0ad","head":{"label":"mfranczy:fixed-vm-mem-calculation","ref":"fixed-vm-mem-calculation","sha":"75978d190089de56d5d36c85b082c488764dd0ad","user":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"repo":{"id":135268431,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNjg0MzE=","name":"kubevirt","full_name":"mfranczy/kubevirt","owner":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfranczy/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":true,"url":"https://api.github.com/repos/mfranczy/kubevirt","forks_url":"https://api.github.com/repos/mfranczy/kubevirt/forks","keys_url":"https://api.github.com/repos/mfranczy/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfranczy/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfranczy/kubevirt/teams","hooks_url":"https://api.github.com/repos/mfranczy/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/mfranczy/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/mfranczy/kubevirt/events","assignees_url":"https://api.github.com/repos/mfranczy/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/mfranczy/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/mfranczy/kubevirt/tags","blobs_url":"https://api.github.com/repos/mfranczy/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfranczy/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfranczy/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfranczy/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfranczy/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/mfranczy/kubevirt/languages","stargazers_url":"https://api.github.com/repos/mfranczy/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/mfranczy/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/mfranczy/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/mfranczy/kubevirt/subscription","commits_url":"https://api.github.com/repos/mfranczy/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfranczy/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfranczy/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfranczy/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfranczy/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/mfranczy/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfranczy/kubevirt/merges","archive_url":"https://api.github.com/repos/mfranczy/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfranczy/kubevirt/downloads","issues_url":"https://api.github.com/repos/mfranczy/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/mfranczy/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/mfranczy/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/mfranczy/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfranczy/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/mfranczy/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/mfranczy/kubevirt/deployments","created_at":"2018-05-29T08:52:57Z","updated_at":"2018-06-06T12:18:58Z","pushed_at":"2018-06-06T15:54:23Z","git_url":"git://github.com/mfranczy/kubevirt.git","ssh_url":"git@github.com:mfranczy/kubevirt.git","clone_url":"https://github.com/mfranczy/kubevirt.git","svn_url":"https://github.com/mfranczy/kubevirt","homepage":"","size":65094,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"e4052284b8fba0a04a56c36979d434fa2c8ff642","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-06-06T14:42:22Z","pushed_at":"2018-06-06T16:19:35Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":65130,"stargazers_count":681,"watchers_count":681,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":138,"open_issues":125,"watchers":681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1106"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1106"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/75978d190089de56d5d36c85b082c488764dd0ad"}},"author_association":"NONE"}}
{"actor":{"display_login":"rmohr"}}