{"action":"opened","number":14195,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/14195","id":176157706,"html_url":"https://github.com/magento/magento2/pull/14195","diff_url":"https://github.com/magento/magento2/pull/14195.diff","patch_url":"https://github.com/magento/magento2/pull/14195.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/14195","number":14195,"state":"open","locked":false,"title":"[Forwardport] Performance: remove count() form the condition section of a loop","user":{"login":"dimonovp","id":29820715,"avatar_url":"https://avatars3.githubusercontent.com/u/29820715?v=4","gravatar_id":"","url":"https://api.github.com/users/dimonovp","html_url":"https://github.com/dimonovp","followers_url":"https://api.github.com/users/dimonovp/followers","following_url":"https://api.github.com/users/dimonovp/following{/other_user}","gists_url":"https://api.github.com/users/dimonovp/gists{/gist_id}","starred_url":"https://api.github.com/users/dimonovp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimonovp/subscriptions","organizations_url":"https://api.github.com/users/dimonovp/orgs","repos_url":"https://api.github.com/users/dimonovp/repos","events_url":"https://api.github.com/users/dimonovp/events{/privacy}","received_events_url":"https://api.github.com/users/dimonovp/received_events","type":"User","site_admin":false},"body":"### Original Pull Request \r\n https://github.com/magento/magento2/pull/13173\r\n### Description\r\nIn this PR I removed the `count()` method from condition section for some loops. When this method is used in the loop condition it will be executed every iteration which is not so good for process time (performance).\r\n\r\n### Fixed Issues (if relevant)\r\nN/A\r\n\r\n### Manual testing scenarios\r\nN/A\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-03-20T11:15:01Z","updated_at":"2018-03-20T11:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/14195/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/14195/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/14195/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/a478f9d9c5db7a6f35f554e97d066ea7c44ba136","head":{"label":"dimonovp:2.3-develop-PR-port-13173","ref":"2.3-develop-PR-port-13173","sha":"a478f9d9c5db7a6f35f554e97d066ea7c44ba136","user":{"login":"dimonovp","id":29820715,"avatar_url":"https://avatars3.githubusercontent.com/u/29820715?v=4","gravatar_id":"","url":"https://api.github.com/users/dimonovp","html_url":"https://github.com/dimonovp","followers_url":"https://api.github.com/users/dimonovp/followers","following_url":"https://api.github.com/users/dimonovp/following{/other_user}","gists_url":"https://api.github.com/users/dimonovp/gists{/gist_id}","starred_url":"https://api.github.com/users/dimonovp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimonovp/subscriptions","organizations_url":"https://api.github.com/users/dimonovp/orgs","repos_url":"https://api.github.com/users/dimonovp/repos","events_url":"https://api.github.com/users/dimonovp/events{/privacy}","received_events_url":"https://api.github.com/users/dimonovp/received_events","type":"User","site_admin":false},"repo":{"id":125848916,"name":"magento2","full_name":"dimonovp/magento2","owner":{"login":"dimonovp","id":29820715,"avatar_url":"https://avatars3.githubusercontent.com/u/29820715?v=4","gravatar_id":"","url":"https://api.github.com/users/dimonovp","html_url":"https://github.com/dimonovp","followers_url":"https://api.github.com/users/dimonovp/followers","following_url":"https://api.github.com/users/dimonovp/following{/other_user}","gists_url":"https://api.github.com/users/dimonovp/gists{/gist_id}","starred_url":"https://api.github.com/users/dimonovp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimonovp/subscriptions","organizations_url":"https://api.github.com/users/dimonovp/orgs","repos_url":"https://api.github.com/users/dimonovp/repos","events_url":"https://api.github.com/users/dimonovp/events{/privacy}","received_events_url":"https://api.github.com/users/dimonovp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimonovp/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/dimonovp/magento2","forks_url":"https://api.github.com/repos/dimonovp/magento2/forks","keys_url":"https://api.github.com/repos/dimonovp/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimonovp/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimonovp/magento2/teams","hooks_url":"https://api.github.com/repos/dimonovp/magento2/hooks","issue_events_url":"https://api.github.com/repos/dimonovp/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/dimonovp/magento2/events","assignees_url":"https://api.github.com/repos/dimonovp/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/dimonovp/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/dimonovp/magento2/tags","blobs_url":"https://api.github.com/repos/dimonovp/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimonovp/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimonovp/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimonovp/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimonovp/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/dimonovp/magento2/languages","stargazers_url":"https://api.github.com/repos/dimonovp/magento2/stargazers","contributors_url":"https://api.github.com/repos/dimonovp/magento2/contributors","subscribers_url":"https://api.github.com/repos/dimonovp/magento2/subscribers","subscription_url":"https://api.github.com/repos/dimonovp/magento2/subscription","commits_url":"https://api.github.com/repos/dimonovp/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimonovp/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimonovp/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimonovp/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimonovp/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/dimonovp/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimonovp/magento2/merges","archive_url":"https://api.github.com/repos/dimonovp/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimonovp/magento2/downloads","issues_url":"https://api.github.com/repos/dimonovp/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/dimonovp/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/dimonovp/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/dimonovp/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimonovp/magento2/labels{/name}","releases_url":"https://api.github.com/repos/dimonovp/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/dimonovp/magento2/deployments","created_at":"2018-03-19T11:43:56Z","updated_at":"2018-03-19T11:44:59Z","pushed_at":"2018-03-20T10:00:22Z","git_url":"git://github.com/dimonovp/magento2.git","ssh_url":"git@github.com:dimonovp/magento2.git","clone_url":"https://github.com/dimonovp/magento2.git","svn_url":"https://github.com/dimonovp/magento2","homepage":"http://www.magento.com","size":428955,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"447a24dbe43ba2d664cd193428d76b1ec3f1f398","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-03-20T09:14:47Z","pushed_at":"2018-03-20T11:13:23Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":428990,"stargazers_count":5376,"watchers_count":5376,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4442,"mirror_url":null,"archived":false,"open_issues_count":1208,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4442,"open_issues":1208,"watchers":5376,"default_branch":"2.2-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/14195"},"html":{"href":"https://github.com/magento/magento2/pull/14195"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/14195"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/14195/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/14195/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/14195/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/a478f9d9c5db7a6f35f554e97d066ea7c44ba136"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":17,"deletions":9,"changed_files":7}}
{"actor":{"display_login":"dimonovp"}}