{"action":"created","comment":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/228240515","pull_request_review_id":168468252,"id":228240515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI0MDUxNQ==","diff_hunk":"@@ -0,0 +1,119 @@\n+package org.geoserver.security.password;\n+\n+import org.jasypt.encryption.pbe.PBEStringEncryptor;\n+import org.jasypt.exceptions.EncryptionInitializationException;\n+import org.jasypt.util.text.BasicTextEncryptor;\n+import org.jasypt.util.text.TextEncryptor;\n+import org.springframework.dao.DataAccessException;\n+import org.springframework.security.crypto.password.PasswordEncoder;\n+\n+/**\n+ * Wrapper class for jasypt PBEPasswordEncoder enabling the class to return the Spring 5.1 version\n+ * of PasswordEncoder\n+ *\n+ * @author vickdw Created on 10/23/18\n+ */\n+public class GSPBEPasswordEncoder extends AbstractGeoserverPasswordEncoder\n+        implements PasswordEncoder {\n+    private TextEncryptor textEncryptor = null;\n+    private PBEStringEncryptor pbeStringEncryptor = null;\n+    private Boolean useTextEncryptor = null;\n+\n+    public GSPBEPasswordEncoder() {}\n+\n+    /** Creates the encoder instance used when source is a string. */\n+    @Override\n+    protected PasswordEncoder createStringEncoder() {","path":"src/main/src/main/java/org/geoserver/security/password/GSPBEPasswordEncoder.java","position":30,"original_position":26,"commit_id":"2963faee5059c169073c4bcfe4ea6ac70b2f14d6","original_commit_id":"78cdb6f9d87a020768f26574d3e408bb7817eb8c","user":{"login":"vickdw","id":8900387,"node_id":"MDQ6VXNlcjg5MDAzODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8900387?v=4","gravatar_id":"","url":"https://api.github.com/users/vickdw","html_url":"https://github.com/vickdw","followers_url":"https://api.github.com/users/vickdw/followers","following_url":"https://api.github.com/users/vickdw/following{/other_user}","gists_url":"https://api.github.com/users/vickdw/gists{/gist_id}","starred_url":"https://api.github.com/users/vickdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vickdw/subscriptions","organizations_url":"https://api.github.com/users/vickdw/orgs","repos_url":"https://api.github.com/users/vickdw/repos","events_url":"https://api.github.com/users/vickdw/events{/privacy}","received_events_url":"https://api.github.com/users/vickdw/received_events","type":"User","site_admin":false},"body":"I just copied the internal code of the original class into this wrapper class.","created_at":"2018-10-25T16:14:05Z","updated_at":"2018-10-25T16:14:05Z","html_url":"https://github.com/geoserver/geoserver/pull/3202#discussion_r228240515","pull_request_url":"https://api.github.com/repos/geoserver/geoserver/pulls/3202","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/228240515"},"html":{"href":"https://github.com/geoserver/geoserver/pull/3202#discussion_r228240515"},"pull_request":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/3202"}},"in_reply_to_id":228090565},"pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/3202","id":225611423,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjExNDIz","html_url":"https://github.com/geoserver/geoserver/pull/3202","diff_url":"https://github.com/geoserver/geoserver/pull/3202.diff","patch_url":"https://github.com/geoserver/geoserver/pull/3202.patch","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/3202","number":3202,"state":"open","locked":false,"title":"Spring 5.1","user":{"login":"tbarsballe","id":9271497,"node_id":"MDQ6VXNlcjkyNzE0OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9271497?v=4","gravatar_id":"","url":"https://api.github.com/users/tbarsballe","html_url":"https://github.com/tbarsballe","followers_url":"https://api.github.com/users/tbarsballe/followers","following_url":"https://api.github.com/users/tbarsballe/following{/other_user}","gists_url":"https://api.github.com/users/tbarsballe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbarsballe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbarsballe/subscriptions","organizations_url":"https://api.github.com/users/tbarsballe/orgs","repos_url":"https://api.github.com/users/tbarsballe/repos","events_url":"https://api.github.com/users/tbarsballe/events{/privacy}","received_events_url":"https://api.github.com/users/tbarsballe/received_events","type":"User","site_admin":false},"body":"Update to Spring 5.1 and fix test failures.\r\nFairly substantial changes in gs-security, everything else is mostly unchanged or has only minor bugfixes.\r\nSeems to be passing all tests in maven on Java 11\r\n\r\nThere seems to be some test failures when running on Java 8.","created_at":"2018-10-25T03:17:38Z","updated_at":"2018-10-25T16:14:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13979389c3b64ff82e234fd247a3d0cbe08e547f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geoserver/geoserver/pulls/3202/commits","review_comments_url":"https://api.github.com/repos/geoserver/geoserver/pulls/3202/comments","review_comment_url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/3202/comments","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/2963faee5059c169073c4bcfe4ea6ac70b2f14d6","head":{"label":"geoserver:spring-5.1","ref":"spring-5.1","sha":"2963faee5059c169073c4bcfe4ea6ac70b2f14d6","user":{"login":"geoserver","id":186522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjUyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/186522?v=4","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUxMTk5","name":"geoserver","full_name":"geoserver/geoserver","private":false,"owner":{"login":"geoserver","id":186522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjUyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/186522?v=4","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/geoserver/geoserver/deployments","created_at":"2011-11-10T19:56:06Z","updated_at":"2018-10-25T15:21:12Z","pushed_at":"2018-10-25T15:59:54Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org/","size":209899,"stargazers_count":1290,"watchers_count":1290,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1177,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1177,"open_issues":12,"watchers":1290,"default_branch":"master"}},"base":{"label":"geoserver:jdk11","ref":"jdk11","sha":"393b1dba0ea471c11e90e126f83b33dcd22fbd6c","user":{"login":"geoserver","id":186522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjUyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/186522?v=4","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUxMTk5","name":"geoserver","full_name":"geoserver/geoserver","private":false,"owner":{"login":"geoserver","id":186522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjUyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/186522?v=4","gravatar_id":"","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","deployments_url":"https://api.github.com/repos/geoserver/geoserver/deployments","created_at":"2011-11-10T19:56:06Z","updated_at":"2018-10-25T15:21:12Z","pushed_at":"2018-10-25T15:59:54Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org/","size":209899,"stargazers_count":1290,"watchers_count":1290,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1177,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1177,"open_issues":12,"watchers":1290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/3202"},"html":{"href":"https://github.com/geoserver/geoserver/pull/3202"},"issue":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/3202"},"comments":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/3202/comments"},"review_comments":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/3202/comments"},"review_comment":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/3202/commits"},"statuses":{"href":"https://api.github.com/repos/geoserver/geoserver/statuses/2963faee5059c169073c4bcfe4ea6ac70b2f14d6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vickdw"}}