{"action":"created","issue":{"url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/issues/12","repository_url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext","labels_url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/issues/12/comments","events_url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/issues/12/events","html_url":"https://github.com/zendframework/zend-expressive-session-ext/pull/12","id":317857030,"number":12,"title":"Cache limiter support attempt","user":{"login":"pine3ree","id":3229979,"avatar_url":"https://avatars0.githubusercontent.com/u/3229979?v=4","gravatar_id":"","url":"https://api.github.com/users/pine3ree","html_url":"https://github.com/pine3ree","followers_url":"https://api.github.com/users/pine3ree/followers","following_url":"https://api.github.com/users/pine3ree/following{/other_user}","gists_url":"https://api.github.com/users/pine3ree/gists{/gist_id}","starred_url":"https://api.github.com/users/pine3ree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pine3ree/subscriptions","organizations_url":"https://api.github.com/users/pine3ree/orgs","repos_url":"https://api.github.com/users/pine3ree/repos","events_url":"https://api.github.com/users/pine3ree/events{/privacy}","received_events_url":"https://api.github.com/users/pine3ree/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-26T02:37:58Z","updated_at":"2018-04-26T04:00:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/pulls/12","html_url":"https://github.com/zendframework/zend-expressive-session-ext/pull/12","diff_url":"https://github.com/zendframework/zend-expressive-session-ext/pull/12.diff","patch_url":"https://github.com/zendframework/zend-expressive-session-ext/pull/12.patch"},"body":"Inject cache headers based on cache_limiter value, while removing the automatic job from the php engine.\r\n\r\nThe php engine automatically sends cache-http-headers based on the values of `session.cache_limiter`, `session.cache_expire` ini/session_start settings and the script last mtime.\r\n\r\nThe idea is to steal the value of `session.cache_limiter` inside the constructor and set an empty cache_limiter when starting the session, thus disabling the automatic headers.\r\n\r\nThen we recreate the logic of the zend-engine to build the headers ourselves and inject them into the response.\r\n\r\nTODO/TOCHECK\r\n- find a better/proper way to check the running script mtime\r\n- decide if/when to inject the cache header: right now if a cache header is found we assume that it was added programmatically in an internal middleware layer, so we skip injecting any of them. What should we do: override-headers? add-(multi-value)-headers? "},"comment":{"url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/issues/comments/384505979","html_url":"https://github.com/zendframework/zend-expressive-session-ext/pull/12#issuecomment-384505979","issue_url":"https://api.github.com/repos/zendframework/zend-expressive-session-ext/issues/12","id":384505979,"user":{"login":"pine3ree","id":3229979,"avatar_url":"https://avatars0.githubusercontent.com/u/3229979?v=4","gravatar_id":"","url":"https://api.github.com/users/pine3ree","html_url":"https://github.com/pine3ree","followers_url":"https://api.github.com/users/pine3ree/followers","following_url":"https://api.github.com/users/pine3ree/following{/other_user}","gists_url":"https://api.github.com/users/pine3ree/gists{/gist_id}","starred_url":"https://api.github.com/users/pine3ree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pine3ree/subscriptions","organizations_url":"https://api.github.com/users/pine3ree/orgs","repos_url":"https://api.github.com/users/pine3ree/repos","events_url":"https://api.github.com/users/pine3ree/events{/privacy}","received_events_url":"https://api.github.com/users/pine3ree/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T04:00:44Z","updated_at":"2018-04-26T04:00:44Z","author_association":"CONTRIBUTOR","body":"need to fix lowered coverage..."}}
{"actor":{"display_login":"pine3ree"}}