{"action":"created","comment":{"url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/comments/217167640","pull_request_review_id":154817801,"id":217167640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE2NzY0MA==","diff_hunk":"@@ -44,44 +53,73 @@\n \n     private final OktaClientResponseUtils oktaClientResponseUtils;\n \n-    private static final ImmutableSet UNSUPPORTED_OKTA_MFA_TYPES = ImmutableSet.of(\"push\", \"call\", \"sms\");\n+    private final AuthenticationClient client;\n \n     @Inject\n     public OktaAuthConnector(final OktaApiClientHelper oktaApiClientHelper,\n-                             final OktaClientResponseUtils oktaClientResponseUtils) {\n+                             final OktaClientResponseUtils oktaClientResponseUtils,\n+                             @Named(\"auth.connector.okta.base_url\") String oktaUrl,\n+                             @Named(\"auth.connector.okta.api_key\") String oktaApiKey) {\n+\n+        System.setProperty(\"okta.client.token\", oktaApiKey);\n+\n+        client = AuthenticationClients.builder()\n+                .setOrgUrl(oktaUrl)\n+                .build();\n+\n+        this.oktaApiClientHelper = oktaApiClientHelper;\n+        this.oktaClientResponseUtils = oktaClientResponseUtils;\n+    }\n+\n+//    For testing\n+    public OktaAuthConnector(final OktaApiClientHelper oktaApiClientHelper,","path":"src/main/java/com/nike/cerberus/auth/connector/okta/OktaAuthConnector.java","position":59,"original_position":59,"commit_id":"c3af628378e89539dfd0f109aa2c7a320488d1f1","original_commit_id":"c3af628378e89539dfd0f109aa2c7a320488d1f1","user":{"login":"fieldju","id":711726,"node_id":"MDQ6VXNlcjcxMTcyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/711726?v=4","gravatar_id":"","url":"https://api.github.com/users/fieldju","html_url":"https://github.com/fieldju","followers_url":"https://api.github.com/users/fieldju/followers","following_url":"https://api.github.com/users/fieldju/following{/other_user}","gists_url":"https://api.github.com/users/fieldju/gists{/gist_id}","starred_url":"https://api.github.com/users/fieldju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fieldju/subscriptions","organizations_url":"https://api.github.com/users/fieldju/orgs","repos_url":"https://api.github.com/users/fieldju/repos","events_url":"https://api.github.com/users/fieldju/events{/privacy}","received_events_url":"https://api.github.com/users/fieldju/received_events","type":"User","site_admin":false},"body":"- [ ] remove second constructor and create the client in the CMS Guice module and inject it into this class as a constructor argument.","created_at":"2018-09-12T19:57:27Z","updated_at":"2018-09-12T19:57:27Z","html_url":"https://github.com/Nike-Inc/cerberus-management-service/pull/177#discussion_r217167640","pull_request_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/comments/217167640"},"html":{"href":"https://github.com/Nike-Inc/cerberus-management-service/pull/177#discussion_r217167640"},"pull_request":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177"}},"in_reply_to_id":217165734},"pull_request":{"url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177","id":215041830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDQxODMw","html_url":"https://github.com/Nike-Inc/cerberus-management-service/pull/177","diff_url":"https://github.com/Nike-Inc/cerberus-management-service/pull/177.diff","patch_url":"https://github.com/Nike-Inc/cerberus-management-service/pull/177.patch","issue_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/177","number":177,"state":"open","locked":false,"title":"Updated existing MFA functionality to work with new Okta Auth SDK","user":{"login":"melanahammel","id":42477256,"node_id":"MDQ6VXNlcjQyNDc3MjU2","avatar_url":"https://avatars2.githubusercontent.com/u/42477256?v=4","gravatar_id":"","url":"https://api.github.com/users/melanahammel","html_url":"https://github.com/melanahammel","followers_url":"https://api.github.com/users/melanahammel/followers","following_url":"https://api.github.com/users/melanahammel/following{/other_user}","gists_url":"https://api.github.com/users/melanahammel/gists{/gist_id}","starred_url":"https://api.github.com/users/melanahammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melanahammel/subscriptions","organizations_url":"https://api.github.com/users/melanahammel/orgs","repos_url":"https://api.github.com/users/melanahammel/repos","events_url":"https://api.github.com/users/melanahammel/events{/privacy}","received_events_url":"https://api.github.com/users/melanahammel/received_events","type":"User","site_admin":false},"body":"-Updated existing MFA functionality of Google Authenticator and Okta Verify TOTP to work with new Okta Auth SDK\r\n-Turned off autocomplete for OTP entry on dashboard","created_at":"2018-09-12T17:38:32Z","updated_at":"2018-09-12T19:57:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a8333a6a9aef0d1e463bdb61457559877888255","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177/commits","review_comments_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177/comments","review_comment_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/177/comments","statuses_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/statuses/c3af628378e89539dfd0f109aa2c7a320488d1f1","head":{"label":"Nike-Inc:add_unsupported_mfa_factors","ref":"add_unsupported_mfa_factors","sha":"c3af628378e89539dfd0f109aa2c7a320488d1f1","user":{"login":"Nike-Inc","id":1435711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzU3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1435711?v=4","gravatar_id":"","url":"https://api.github.com/users/Nike-Inc","html_url":"https://github.com/Nike-Inc","followers_url":"https://api.github.com/users/Nike-Inc/followers","following_url":"https://api.github.com/users/Nike-Inc/following{/other_user}","gists_url":"https://api.github.com/users/Nike-Inc/gists{/gist_id}","starred_url":"https://api.github.com/users/Nike-Inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nike-Inc/subscriptions","organizations_url":"https://api.github.com/users/Nike-Inc/orgs","repos_url":"https://api.github.com/users/Nike-Inc/repos","events_url":"https://api.github.com/users/Nike-Inc/events{/privacy}","received_events_url":"https://api.github.com/users/Nike-Inc/received_events","type":"Organization","site_admin":false},"repo":{"id":70515162,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUxNTE2Mg==","name":"cerberus-management-service","full_name":"Nike-Inc/cerberus-management-service","owner":{"login":"Nike-Inc","id":1435711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzU3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1435711?v=4","gravatar_id":"","url":"https://api.github.com/users/Nike-Inc","html_url":"https://github.com/Nike-Inc","followers_url":"https://api.github.com/users/Nike-Inc/followers","following_url":"https://api.github.com/users/Nike-Inc/following{/other_user}","gists_url":"https://api.github.com/users/Nike-Inc/gists{/gist_id}","starred_url":"https://api.github.com/users/Nike-Inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nike-Inc/subscriptions","organizations_url":"https://api.github.com/users/Nike-Inc/orgs","repos_url":"https://api.github.com/users/Nike-Inc/repos","events_url":"https://api.github.com/users/Nike-Inc/events{/privacy}","received_events_url":"https://api.github.com/users/Nike-Inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nike-Inc/cerberus-management-service","description":"The main service that makes up a Cerberus environment. It includes a REST API, authentication and encryption features, as well as a self-service web UI for users.","fork":false,"url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service","forks_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/forks","keys_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/teams","hooks_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/hooks","issue_events_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/events{/number}","events_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/events","assignees_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/assignees{/user}","branches_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/branches{/branch}","tags_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/tags","blobs_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/languages","stargazers_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/stargazers","contributors_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/contributors","subscribers_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/subscribers","subscription_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/subscription","commits_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/contents/{+path}","compare_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/merges","archive_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/downloads","issues_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues{/number}","pulls_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/labels{/name}","releases_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/releases{/id}","deployments_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/deployments","created_at":"2016-10-10T18:07:11Z","updated_at":"2018-09-04T22:46:19Z","pushed_at":"2018-09-12T18:55:19Z","git_url":"git://github.com/Nike-Inc/cerberus-management-service.git","ssh_url":"git@github.com:Nike-Inc/cerberus-management-service.git","clone_url":"https://github.com/Nike-Inc/cerberus-management-service.git","svn_url":"https://github.com/Nike-Inc/cerberus-management-service","homepage":"http://nike-inc.github.io/cerberus","size":4278,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":2,"watchers":25,"default_branch":"master"}},"base":{"label":"Nike-Inc:master","ref":"master","sha":"2d702606cac994838c7df68ad4bdca8a2a1efecc","user":{"login":"Nike-Inc","id":1435711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzU3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1435711?v=4","gravatar_id":"","url":"https://api.github.com/users/Nike-Inc","html_url":"https://github.com/Nike-Inc","followers_url":"https://api.github.com/users/Nike-Inc/followers","following_url":"https://api.github.com/users/Nike-Inc/following{/other_user}","gists_url":"https://api.github.com/users/Nike-Inc/gists{/gist_id}","starred_url":"https://api.github.com/users/Nike-Inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nike-Inc/subscriptions","organizations_url":"https://api.github.com/users/Nike-Inc/orgs","repos_url":"https://api.github.com/users/Nike-Inc/repos","events_url":"https://api.github.com/users/Nike-Inc/events{/privacy}","received_events_url":"https://api.github.com/users/Nike-Inc/received_events","type":"Organization","site_admin":false},"repo":{"id":70515162,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUxNTE2Mg==","name":"cerberus-management-service","full_name":"Nike-Inc/cerberus-management-service","owner":{"login":"Nike-Inc","id":1435711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzU3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1435711?v=4","gravatar_id":"","url":"https://api.github.com/users/Nike-Inc","html_url":"https://github.com/Nike-Inc","followers_url":"https://api.github.com/users/Nike-Inc/followers","following_url":"https://api.github.com/users/Nike-Inc/following{/other_user}","gists_url":"https://api.github.com/users/Nike-Inc/gists{/gist_id}","starred_url":"https://api.github.com/users/Nike-Inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nike-Inc/subscriptions","organizations_url":"https://api.github.com/users/Nike-Inc/orgs","repos_url":"https://api.github.com/users/Nike-Inc/repos","events_url":"https://api.github.com/users/Nike-Inc/events{/privacy}","received_events_url":"https://api.github.com/users/Nike-Inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nike-Inc/cerberus-management-service","description":"The main service that makes up a Cerberus environment. It includes a REST API, authentication and encryption features, as well as a self-service web UI for users.","fork":false,"url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service","forks_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/forks","keys_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/teams","hooks_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/hooks","issue_events_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/events{/number}","events_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/events","assignees_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/assignees{/user}","branches_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/branches{/branch}","tags_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/tags","blobs_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/languages","stargazers_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/stargazers","contributors_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/contributors","subscribers_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/subscribers","subscription_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/subscription","commits_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/contents/{+path}","compare_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/merges","archive_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/downloads","issues_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues{/number}","pulls_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/labels{/name}","releases_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/releases{/id}","deployments_url":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/deployments","created_at":"2016-10-10T18:07:11Z","updated_at":"2018-09-04T22:46:19Z","pushed_at":"2018-09-12T18:55:19Z","git_url":"git://github.com/Nike-Inc/cerberus-management-service.git","ssh_url":"git@github.com:Nike-Inc/cerberus-management-service.git","clone_url":"https://github.com/Nike-Inc/cerberus-management-service.git","svn_url":"https://github.com/Nike-Inc/cerberus-management-service","homepage":"http://nike-inc.github.io/cerberus","size":4278,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177"},"html":{"href":"https://github.com/Nike-Inc/cerberus-management-service/pull/177"},"issue":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/177"},"comments":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/Nike-Inc/cerberus-management-service/statuses/c3af628378e89539dfd0f109aa2c7a320488d1f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fieldju"}}