{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular-cli/issues/11672","repository_url":"https://api.github.com/repos/angular/angular-cli","labels_url":"https://api.github.com/repos/angular/angular-cli/issues/11672/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/11672/comments","events_url":"https://api.github.com/repos/angular/angular-cli/issues/11672/events","html_url":"https://github.com/angular/angular-cli/issues/11672","id":344887292,"node_id":"MDU6SXNzdWUzNDQ4ODcyOTI=","number":11672,"title":"ng test --code-coverage in 6.1 improperly detecting branches","user":{"login":"jhage-accesso","id":26254891,"node_id":"MDQ6VXNlcjI2MjU0ODkx","avatar_url":"https://avatars3.githubusercontent.com/u/26254891?v=4","gravatar_id":"","url":"https://api.github.com/users/jhage-accesso","html_url":"https://github.com/jhage-accesso","followers_url":"https://api.github.com/users/jhage-accesso/followers","following_url":"https://api.github.com/users/jhage-accesso/following{/other_user}","gists_url":"https://api.github.com/users/jhage-accesso/gists{/gist_id}","starred_url":"https://api.github.com/users/jhage-accesso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhage-accesso/subscriptions","organizations_url":"https://api.github.com/users/jhage-accesso/orgs","repos_url":"https://api.github.com/users/jhage-accesso/repos","events_url":"https://api.github.com/users/jhage-accesso/events{/privacy}","received_events_url":"https://api.github.com/users/jhage-accesso/received_events","type":"User","site_admin":false},"labels":[{"id":957896443,"node_id":"MDU6TGFiZWw5NTc4OTY0NDM=","url":"https://api.github.com/repos/angular/angular-cli/labels/comp:%20devkit/build-angular","name":"comp: devkit/build-angular","color":"c5def5","default":false},{"id":531675050,"node_id":"MDU6TGFiZWw1MzE2NzUwNTA=","url":"https://api.github.com/repos/angular/angular-cli/labels/freq3:%20high","name":"freq3: high","color":"fbca04","default":false},{"id":372202241,"node_id":"MDU6TGFiZWwzNzIyMDIyNDE=","url":"https://api.github.com/repos/angular/angular-cli/labels/priority:%201%20(urgent)","name":"priority: 1 (urgent)","color":"0052cc","default":false},{"id":531675532,"node_id":"MDU6TGFiZWw1MzE2NzU1MzI=","url":"https://api.github.com/repos/angular/angular-cli/labels/severity5:%20regression","name":"severity5: regression","color":"5319e7","default":false},{"id":220593710,"node_id":"MDU6TGFiZWwyMjA1OTM3MTA=","url":"https://api.github.com/repos/angular/angular-cli/labels/type:%20bug","name":"type: bug","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-07-26T15:12:54Z","updated_at":"2018-08-03T20:16:08Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING\r\n-->\r\n### Bug Report or Feature Request (mark with an `x`)\r\n```\r\n- [ X ] bug report -> please search issues before submitting\r\n- [ ] feature request\r\n```\r\n\r\n### Command (mark with an `x`)\r\n```\r\n- [ ] new\r\n- [ ] build\r\n- [ ] serve\r\n- [ X ] test\r\n- [ ] e2e\r\n- [ ] generate\r\n- [ ] add\r\n- [ ] update\r\n- [ ] lint\r\n- [ ] xi18n\r\n- [ ] run\r\n- [ ] config\r\n- [ ] help\r\n- [ ] version\r\n- [ ] doc\r\n```\r\n\r\n### Versions\r\n<!--\r\nOutput from: `node --version`, `npm --version` and `ng --version`.\r\n  Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra? High Sierra?)\r\n-->\r\nOS: macOS Sierra\r\nNode: v8.9.4\r\nNPM: 6.2.0\r\n\r\nNg Version:\r\n```\r\nAngular CLI: 6.1.0\r\nNode: 8.9.4\r\nOS: darwin x64\r\nAngular: 6.1.0\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... http, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.7.0\r\n@angular-devkit/build-angular     0.7.0\r\n@angular-devkit/build-optimizer   0.7.0\r\n@angular-devkit/build-webpack     0.7.0\r\n@angular-devkit/core              0.7.0\r\n@angular-devkit/schematics        0.7.0\r\n@angular/cdk                      6.4.1\r\n@angular/flex-layout              6.0.0-beta.16\r\n@angular/material                 6.4.1\r\n@ngtools/webpack                  6.1.0\r\n@schematics/angular               0.7.0\r\n@schematics/update                0.7.0\r\nrxjs                              6.2.2\r\ntypescript                        2.9.2\r\nwebpack                           4.9.2\r\n```\r\n\r\n### Repro steps\r\n<!--\r\nSimple steps to reproduce this bug.\r\nPlease include: commands run (incl args), packages added, related code changes.\r\nA link to a sample repo would help too.\r\n-->\r\nRun `ng test --code-coverage`\r\nNotice that things like import statements are counted as if else branches.\r\n![image](https://user-images.githubusercontent.com/26254891/43271073-970f252c-90c4-11e8-93dc-116f603682c6.png)\r\n\r\n\r\n### The log given by the failure\r\n<!-- Normally this include a stack trace and some more information. -->\r\nNo log file\r\n\r\n\r\n### Desired functionality\r\n<!--\r\nWhat would like to see implemented?\r\nWhat is the usecase?\r\n-->\r\nI expect to see things like import statements and decorator metadata to not be marked as if else branches in the code coverage report.\r\n\r\n### Mention any other details that might be useful\r\n<!-- Please include a link to the repo if this is related to an OSS project. -->\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular-cli/issues/comments/410364848","html_url":"https://github.com/angular/angular-cli/issues/11672#issuecomment-410364848","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/11672","id":410364848,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDM2NDg0OA==","user":{"login":"brian428","id":140338,"node_id":"MDQ6VXNlcjE0MDMzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/140338?v=4","gravatar_id":"","url":"https://api.github.com/users/brian428","html_url":"https://github.com/brian428","followers_url":"https://api.github.com/users/brian428/followers","following_url":"https://api.github.com/users/brian428/following{/other_user}","gists_url":"https://api.github.com/users/brian428/gists{/gist_id}","starred_url":"https://api.github.com/users/brian428/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian428/subscriptions","organizations_url":"https://api.github.com/users/brian428/orgs","repos_url":"https://api.github.com/users/brian428/repos","events_url":"https://api.github.com/users/brian428/events{/privacy}","received_events_url":"https://api.github.com/users/brian428/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T20:16:08Z","updated_at":"2018-08-03T20:16:08Z","author_association":"NONE","body":"Hmm, updated to 0.7.2, but still no luck. tsconfig.spec.json doesn't set `sourceMap: false`. I even added `sourceMap: true` just to try it (even though it's already set to true in the base tsconfig.json), but had no effect. The test section of my angular.json also includes this, but no luck there either:\r\n\r\n```\r\n\"test\": {\r\n  \"builder\": \"@angular-devkit/build-angular:karma\",\r\n  \"options\": {\r\n    \"main\": \"src/test.ts\",\r\n    \"karmaConfig\": \"./karma.conf.js\",\r\n    \"sourceMap\": true,\r\n    ...\r\n  }\r\n}\r\n```\r\n\r\nNone of these tweaks make any difference. The coverage report is generated but the highlighting is all wrong."}}
{"actor":{"display_login":"brian428"}}