{"action":"opened","number":59431,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59431","id":167500217,"html_url":"https://github.com/kubernetes/kubernetes/pull/59431","diff_url":"https://github.com/kubernetes/kubernetes/pull/59431.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59431.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59431","number":59431,"state":"open","locked":false,"title":"Instance comparable host path","user":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nWhen creating a new TargetPool, insert new instances with the comparable host path instead of the full path, e.g. /zone/%s/instances/%s instead of the full https://www.googleapis.com/compute/v1/projects/... url. \r\n\r\nWith this change, `createTargetPoolAndHealthCheck` and `updateTargetPool` insert gceInstance paths in a consistent manner. \r\n\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-02-06T18:56:38Z","updated_at":"2018-02-06T18:56:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59431/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59431/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59431/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/41318d7596885fa1e6b7921d2ae55cb73b07f1c5","head":{"label":"agau4779:instance-comparable-host-path","ref":"instance-comparable-host-path","sha":"41318d7596885fa1e6b7921d2ae55cb73b07f1c5","user":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"repo":{"id":119419443,"name":"kubernetes","full_name":"agau4779/kubernetes","owner":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agau4779/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/agau4779/kubernetes","forks_url":"https://api.github.com/repos/agau4779/kubernetes/forks","keys_url":"https://api.github.com/repos/agau4779/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agau4779/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agau4779/kubernetes/teams","hooks_url":"https://api.github.com/repos/agau4779/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/agau4779/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/agau4779/kubernetes/events","assignees_url":"https://api.github.com/repos/agau4779/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/agau4779/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/agau4779/kubernetes/tags","blobs_url":"https://api.github.com/repos/agau4779/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agau4779/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agau4779/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/agau4779/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agau4779/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/agau4779/kubernetes/languages","stargazers_url":"https://api.github.com/repos/agau4779/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/agau4779/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/agau4779/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/agau4779/kubernetes/subscription","commits_url":"https://api.github.com/repos/agau4779/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/agau4779/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/agau4779/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/agau4779/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/agau4779/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/agau4779/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agau4779/kubernetes/merges","archive_url":"https://api.github.com/repos/agau4779/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agau4779/kubernetes/downloads","issues_url":"https://api.github.com/repos/agau4779/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/agau4779/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/agau4779/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/agau4779/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agau4779/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/agau4779/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/agau4779/kubernetes/deployments","created_at":"2018-01-29T17:56:20Z","updated_at":"2018-01-29T17:56:55Z","pushed_at":"2018-02-06T18:49:26Z","git_url":"git://github.com/agau4779/kubernetes.git","ssh_url":"git@github.com:agau4779/kubernetes.git","clone_url":"https://github.com/agau4779/kubernetes.git","svn_url":"https://github.com/agau4779/kubernetes","homepage":"http://kubernetes.io","size":533374,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b13092554cd335eb4f367d5108e79709947effe4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-06T18:44:21Z","pushed_at":"2018-02-06T18:40:41Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":750568,"stargazers_count":32220,"watchers_count":32220,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11397,"mirror_url":null,"archived":false,"open_issues_count":5304,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11397,"open_issues":5304,"watchers":32220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59431"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59431"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59431"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59431/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59431/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59431/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/41318d7596885fa1e6b7921d2ae55cb73b07f1c5"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":6,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"agau4779"}}