{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments/200054248","pull_request_review_id":134291863,"id":200054248,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA1NDI0OA==","diff_hunk":"@@ -41,4 +41,8 @@\n     <!--30 min-->\n     <ThriftSessionTimeout>1800000</ThriftSessionTimeout>\n \n+    <SSLEnabledProtocols>TLSv1,TLSv1.1,TLSv1.2</SSLEnabledProtocols>\n+\n+    <Ciphers>TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,TLS_DHE_RSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_DHE_RSA_WITH_AES_128_GCM_SHA256</Ciphers>","path":"components/carbon-authenticators/thrift-authenticator/org.wso2.carbon.identity.authenticator.thrift/src/main/resources/thrift-authentication.xml","position":6,"original_position":6,"commit_id":"7782eabde52499e84f1e80e1f59f2bc5f2f7aa5e","original_commit_id":"7782eabde52499e84f1e80e1f59f2bc5f2f7aa5e","user":{"login":"dulanjal","id":7952544,"node_id":"MDQ6VXNlcjc5NTI1NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7952544?v=4","gravatar_id":"","url":"https://api.github.com/users/dulanjal","html_url":"https://github.com/dulanjal","followers_url":"https://api.github.com/users/dulanjal/followers","following_url":"https://api.github.com/users/dulanjal/following{/other_user}","gists_url":"https://api.github.com/users/dulanjal/gists{/gist_id}","starred_url":"https://api.github.com/users/dulanjal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dulanjal/subscriptions","organizations_url":"https://api.github.com/users/dulanjal/orgs","repos_url":"https://api.github.com/users/dulanjal/repos","events_url":"https://api.github.com/users/dulanjal/events{/privacy}","received_events_url":"https://api.github.com/users/dulanjal/received_events","type":"User","site_admin":false},"body":"Let's not enable these (SSLEnabledProtocols and Ciphers) configurations by default. We should include this recommendation to https://docs.wso2.com/display/ADMIN44x/Configuring+Transport+Level+Security","created_at":"2018-07-04T08:53:45Z","updated_at":"2018-07-04T08:53:45Z","html_url":"https://github.com/wso2/carbon-identity-framework/pull/1673#discussion_r200054248","pull_request_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments/200054248"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/1673#discussion_r200054248"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673","id":198572716,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTcyNzE2","html_url":"https://github.com/wso2/carbon-identity-framework/pull/1673","diff_url":"https://github.com/wso2/carbon-identity-framework/pull/1673.diff","patch_url":"https://github.com/wso2/carbon-identity-framework/pull/1673.patch","issue_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1673","number":1673,"state":"open","locked":false,"title":"Add support to configure SSL protocols and ciphers in ThriftAuthenticationService","user":{"login":"emswbandara","id":8380730,"node_id":"MDQ6VXNlcjgzODA3MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8380730?v=4","gravatar_id":"","url":"https://api.github.com/users/emswbandara","html_url":"https://github.com/emswbandara","followers_url":"https://api.github.com/users/emswbandara/followers","following_url":"https://api.github.com/users/emswbandara/following{/other_user}","gists_url":"https://api.github.com/users/emswbandara/gists{/gist_id}","starred_url":"https://api.github.com/users/emswbandara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emswbandara/subscriptions","organizations_url":"https://api.github.com/users/emswbandara/orgs","repos_url":"https://api.github.com/users/emswbandara/repos","events_url":"https://api.github.com/users/emswbandara/events{/privacy}","received_events_url":"https://api.github.com/users/emswbandara/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/wso2/product-is/issues/3339","created_at":"2018-07-02T04:56:40Z","updated_at":"2018-07-04T08:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3208928f1d598c4b4ba9f49f7083bf50db24130","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1673/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/7782eabde52499e84f1e80e1f59f2bc5f2f7aa5e","head":{"label":"emswbandara:ssl-protocol","ref":"ssl-protocol","sha":"7782eabde52499e84f1e80e1f59f2bc5f2f7aa5e","user":{"login":"emswbandara","id":8380730,"node_id":"MDQ6VXNlcjgzODA3MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8380730?v=4","gravatar_id":"","url":"https://api.github.com/users/emswbandara","html_url":"https://github.com/emswbandara","followers_url":"https://api.github.com/users/emswbandara/followers","following_url":"https://api.github.com/users/emswbandara/following{/other_user}","gists_url":"https://api.github.com/users/emswbandara/gists{/gist_id}","starred_url":"https://api.github.com/users/emswbandara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emswbandara/subscriptions","organizations_url":"https://api.github.com/users/emswbandara/orgs","repos_url":"https://api.github.com/users/emswbandara/repos","events_url":"https://api.github.com/users/emswbandara/events{/privacy}","received_events_url":"https://api.github.com/users/emswbandara/received_events","type":"User","site_admin":false},"repo":{"id":89347002,"node_id":"MDEwOlJlcG9zaXRvcnk4OTM0NzAwMg==","name":"carbon-identity-framework","full_name":"emswbandara/carbon-identity-framework","owner":{"login":"emswbandara","id":8380730,"node_id":"MDQ6VXNlcjgzODA3MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8380730?v=4","gravatar_id":"","url":"https://api.github.com/users/emswbandara","html_url":"https://github.com/emswbandara","followers_url":"https://api.github.com/users/emswbandara/followers","following_url":"https://api.github.com/users/emswbandara/following{/other_user}","gists_url":"https://api.github.com/users/emswbandara/gists{/gist_id}","starred_url":"https://api.github.com/users/emswbandara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emswbandara/subscriptions","organizations_url":"https://api.github.com/users/emswbandara/orgs","repos_url":"https://api.github.com/users/emswbandara/repos","events_url":"https://api.github.com/users/emswbandara/events{/privacy}","received_events_url":"https://api.github.com/users/emswbandara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emswbandara/carbon-identity-framework","description":null,"fork":true,"url":"https://api.github.com/repos/emswbandara/carbon-identity-framework","forks_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/emswbandara/carbon-identity-framework/deployments","created_at":"2017-04-25T10:15:34Z","updated_at":"2017-04-25T10:15:42Z","pushed_at":"2018-07-02T12:25:26Z","git_url":"git://github.com/emswbandara/carbon-identity-framework.git","ssh_url":"git@github.com:emswbandara/carbon-identity-framework.git","clone_url":"https://github.com/emswbandara/carbon-identity-framework.git","svn_url":"https://github.com/emswbandara/carbon-identity-framework","homepage":null,"size":143637,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"e67174af286a87083ecfc8c84ebc83f5d7709839","user":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":52329722,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMyOTcyMg==","name":"carbon-identity-framework","full_name":"wso2/carbon-identity-framework","owner":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-identity-framework","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-identity-framework","forks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/wso2/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/wso2/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/deployments","created_at":"2016-02-23T04:20:26Z","updated_at":"2018-07-03T12:17:41Z","pushed_at":"2018-07-04T06:00:57Z","git_url":"git://github.com/wso2/carbon-identity-framework.git","ssh_url":"git@github.com:wso2/carbon-identity-framework.git","clone_url":"https://github.com/wso2/carbon-identity-framework.git","svn_url":"https://github.com/wso2/carbon-identity-framework","homepage":null,"size":110835,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":184,"open_issues":32,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/1673"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1673"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1673/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1673/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/7782eabde52499e84f1e80e1f59f2bc5f2f7aa5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dulanjal"}}