{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments/231242383","pull_request_review_id":172169676,"id":231242383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI0MjM4Mw==","diff_hunk":"@@ -975,7 +975,7 @@ int aws_socket_shutdown_dir(struct aws_socket *socket, enum aws_channel_directio\n  * 1st scenario, someone called write and we want to at least try and make a write call if we can or return an\n  * error if something bad has happened to the socket.\n  * 2nd scenario, the event loop notified us that the socket went writable. */\n-static int s_process_write_requests(struct aws_socket *socket, bool spawned_from_event) {\n+static int s_process_write_requests(struct aws_socket *socket, struct write_request *spawned_from_request) {","path":"source/posix/socket.c","position":5,"original_position":5,"commit_id":"168f2756f27b82d870ccd79b0d15a5410cf95317","original_commit_id":"168f2756f27b82d870ccd79b0d15a5410cf95317","user":{"login":"graebm","id":24399397,"node_id":"MDQ6VXNlcjI0Mzk5Mzk3","avatar_url":"https://avatars3.githubusercontent.com/u/24399397?v=4","gravatar_id":"","url":"https://api.github.com/users/graebm","html_url":"https://github.com/graebm","followers_url":"https://api.github.com/users/graebm/followers","following_url":"https://api.github.com/users/graebm/following{/other_user}","gists_url":"https://api.github.com/users/graebm/gists{/gist_id}","starred_url":"https://api.github.com/users/graebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graebm/subscriptions","organizations_url":"https://api.github.com/users/graebm/orgs","repos_url":"https://api.github.com/users/graebm/repos","events_url":"https://api.github.com/users/graebm/events{/privacy}","received_events_url":"https://api.github.com/users/graebm/received_events","type":"User","site_admin":false},"body":"sure, I was using an arg name similar to the one it was replacing, but I admit it was awkward","created_at":"2018-11-06T18:39:09Z","updated_at":"2018-11-06T18:59:11Z","html_url":"https://github.com/awslabs/aws-c-io/pull/48#discussion_r231242383","pull_request_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments/231242383"},"html":{"href":"https://github.com/awslabs/aws-c-io/pull/48#discussion_r231242383"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48"}},"in_reply_to_id":230976437},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48","id":228545976,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTQ1OTc2","html_url":"https://github.com/awslabs/aws-c-io/pull/48","diff_url":"https://github.com/awslabs/aws-c-io/pull/48.diff","patch_url":"https://github.com/awslabs/aws-c-io/pull/48.patch","issue_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/48","number":48,"state":"open","locked":false,"title":"replace aws_channel_init() with aws_channel_new()","user":{"login":"graebm","id":24399397,"node_id":"MDQ6VXNlcjI0Mzk5Mzk3","avatar_url":"https://avatars3.githubusercontent.com/u/24399397?v=4","gravatar_id":"","url":"https://api.github.com/users/graebm","html_url":"https://github.com/graebm","followers_url":"https://api.github.com/users/graebm/followers","following_url":"https://api.github.com/users/graebm/following{/other_user}","gists_url":"https://api.github.com/users/graebm/gists{/gist_id}","starred_url":"https://api.github.com/users/graebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graebm/subscriptions","organizations_url":"https://api.github.com/users/graebm/orgs","repos_url":"https://api.github.com/users/graebm/repos","events_url":"https://api.github.com/users/graebm/events{/privacy}","received_events_url":"https://api.github.com/users/graebm/received_events","type":"User","site_admin":false},"body":"Channel's can't just vanish, we'll need to move to some kind of ref-counting scheme, so in preparation...\r\n\r\n- Replace _init() and _clean_up() with _new() and _destroy().\r\n- Move channel struct declaration to .C file, since it doesn't need to be public anymore.\r\n- Remove some asserts 😞 that were checking against aws_channel's internal members (which are now private). I can put in query functions if we thinks these asserts (mostly in unit tests) are still valuable.\r\n- Fix aws_socket_write() so that, if it returns AWS_OP_ERROR, then the write callback is not ALSO invoked with an error code.\r\n    - Remove hacks in socket_channel_handler which were working around the previous behavior.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-06T01:20:35Z","updated_at":"2018-11-06T18:59:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"885b9f14ab9063538b1a2e9d472c320d425edf8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JonathanHenson","id":3926469,"node_id":"MDQ6VXNlcjM5MjY0Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/3926469?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanHenson","html_url":"https://github.com/JonathanHenson","followers_url":"https://api.github.com/users/JonathanHenson/followers","following_url":"https://api.github.com/users/JonathanHenson/following{/other_user}","gists_url":"https://api.github.com/users/JonathanHenson/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanHenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanHenson/subscriptions","organizations_url":"https://api.github.com/users/JonathanHenson/orgs","repos_url":"https://api.github.com/users/JonathanHenson/repos","events_url":"https://api.github.com/users/JonathanHenson/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanHenson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/48/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-c-io/statuses/168f2756f27b82d870ccd79b0d15a5410cf95317","head":{"label":"awslabs:channel-new","ref":"channel-new","sha":"168f2756f27b82d870ccd79b0d15a5410cf95317","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":123649788,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2NDk3ODg=","name":"aws-c-io","full_name":"awslabs/aws-c-io","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-c-io","description":"This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols. ","fork":false,"url":"https://api.github.com/repos/awslabs/aws-c-io","forks_url":"https://api.github.com/repos/awslabs/aws-c-io/forks","keys_url":"https://api.github.com/repos/awslabs/aws-c-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-c-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-c-io/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-c-io/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-c-io/events","assignees_url":"https://api.github.com/repos/awslabs/aws-c-io/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-c-io/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-c-io/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-c-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-c-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-c-io/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-c-io/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-c-io/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-c-io/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-c-io/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-c-io/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-c-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-c-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-c-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-c-io/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-c-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-c-io/merges","archive_url":"https://api.github.com/repos/awslabs/aws-c-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-c-io/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-c-io/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-c-io/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-c-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-c-io/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-c-io/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-c-io/deployments","created_at":"2018-03-03T01:50:50Z","updated_at":"2018-11-03T00:58:07Z","pushed_at":"2018-11-06T01:20:36Z","git_url":"git://github.com/awslabs/aws-c-io.git","ssh_url":"git@github.com:awslabs/aws-c-io.git","clone_url":"https://github.com/awslabs/aws-c-io.git","svn_url":"https://github.com/awslabs/aws-c-io","homepage":null,"size":1782,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"033e638d76c941925da2d077fe982d10012e4603","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":123649788,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2NDk3ODg=","name":"aws-c-io","full_name":"awslabs/aws-c-io","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/aws-c-io","description":"This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols. ","fork":false,"url":"https://api.github.com/repos/awslabs/aws-c-io","forks_url":"https://api.github.com/repos/awslabs/aws-c-io/forks","keys_url":"https://api.github.com/repos/awslabs/aws-c-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-c-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-c-io/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-c-io/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-c-io/events","assignees_url":"https://api.github.com/repos/awslabs/aws-c-io/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-c-io/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-c-io/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-c-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-c-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-c-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-c-io/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-c-io/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-c-io/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-c-io/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-c-io/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-c-io/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-c-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-c-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-c-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-c-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-c-io/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-c-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-c-io/merges","archive_url":"https://api.github.com/repos/awslabs/aws-c-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-c-io/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-c-io/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-c-io/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-c-io/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-c-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-c-io/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-c-io/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-c-io/deployments","created_at":"2018-03-03T01:50:50Z","updated_at":"2018-11-03T00:58:07Z","pushed_at":"2018-11-06T01:20:36Z","git_url":"git://github.com/awslabs/aws-c-io.git","ssh_url":"git@github.com:awslabs/aws-c-io.git","clone_url":"https://github.com/awslabs/aws-c-io.git","svn_url":"https://github.com/awslabs/aws-c-io","homepage":null,"size":1782,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48"},"html":{"href":"https://github.com/awslabs/aws-c-io/pull/48"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-c-io/issues/48"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-c-io/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-c-io/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-c-io/statuses/168f2756f27b82d870ccd79b0d15a5410cf95317"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"graebm"}}