{"action":"created","comment":{"url":"https://api.github.com/repos/Kinto/kinto/pulls/comments/226199659","pull_request_review_id":165962099,"id":226199659,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjE5OTY1OQ==","diff_hunk":"@@ -16,11 +16,12 @@ deps =\n     statsd\n install_command = pip install {opts} {packages}\n \n-[testenv:flake8]\n-commands = flake8 kinto tests docs/conf.py","path":"tox.ini","position":5,"original_position":5,"commit_id":"8e5a3a71c393d4efd583500779d6d09efcfcf5ef","original_commit_id":"8e5a3a71c393d4efd583500779d6d09efcfcf5ef","user":{"login":"leplatrem","id":546692,"node_id":"MDQ6VXNlcjU0NjY5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/546692?v=4","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"shouldn't you keep `flake8` for py35 on Travis?","created_at":"2018-10-18T07:48:42Z","updated_at":"2018-10-18T07:49:41Z","html_url":"https://github.com/Kinto/kinto/pull/1799#discussion_r226199659","pull_request_url":"https://api.github.com/repos/Kinto/kinto/pulls/1799","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/comments/226199659"},"html":{"href":"https://github.com/Kinto/kinto/pull/1799#discussion_r226199659"},"pull_request":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/1799"}}},"pull_request":{"url":"https://api.github.com/repos/Kinto/kinto/pulls/1799","id":221170317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTcwMzE3","html_url":"https://github.com/Kinto/kinto/pull/1799","diff_url":"https://github.com/Kinto/kinto/pull/1799.diff","patch_url":"https://github.com/Kinto/kinto/pull/1799.patch","issue_url":"https://api.github.com/repos/Kinto/kinto/issues/1799","number":1799,"state":"open","locked":false,"title":"Blackify code base","user":{"login":"Cnidarias","id":5615502,"node_id":"MDQ6VXNlcjU2MTU1MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5615502?v=4","gravatar_id":"","url":"https://api.github.com/users/Cnidarias","html_url":"https://github.com/Cnidarias","followers_url":"https://api.github.com/users/Cnidarias/followers","following_url":"https://api.github.com/users/Cnidarias/following{/other_user}","gists_url":"https://api.github.com/users/Cnidarias/gists{/gist_id}","starred_url":"https://api.github.com/users/Cnidarias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cnidarias/subscriptions","organizations_url":"https://api.github.com/users/Cnidarias/orgs","repos_url":"https://api.github.com/users/Cnidarias/repos","events_url":"https://api.github.com/users/Cnidarias/events{/privacy}","received_events_url":"https://api.github.com/users/Cnidarias/received_events","type":"User","site_admin":false},"body":"Letting black run over everything\r\n\r\n- [ ] Add documentation.\r\n- [ ] Add a changelog entry.\r\n- [x] Add your name in the contributors file.\r\n\r\nSo in light of my other pull request I suggested that we run black over everything and @leplatrem seemed to be in favor so here we are.\r\n\r\nI figured it would be best if we did this before adding all the type annotations to not have too many changes at once.\r\n\r\nI let black run over everything, adding a pre-commit (https://pre-commit.com) config file as well as a config file for black.\r\n\r\nI also had to add an ignore E203 in order for flake8 to be happy.\r\n\r\nIf this is okay then I would still have to add some documentation on how to set things up for development but I do think the result is actually quite nice!\r\n\r\nThoughts?","created_at":"2018-10-08T16:07:49Z","updated_at":"2018-10-18T07:49:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd8d5c6d3a077288b2973f2cc74095e7d6676e55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kinto/kinto/pulls/1799/commits","review_comments_url":"https://api.github.com/repos/Kinto/kinto/pulls/1799/comments","review_comment_url":"https://api.github.com/repos/Kinto/kinto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinto/kinto/issues/1799/comments","statuses_url":"https://api.github.com/repos/Kinto/kinto/statuses/8e5a3a71c393d4efd583500779d6d09efcfcf5ef","head":{"label":"Cnidarias:black","ref":"black","sha":"8e5a3a71c393d4efd583500779d6d09efcfcf5ef","user":{"login":"Cnidarias","id":5615502,"node_id":"MDQ6VXNlcjU2MTU1MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5615502?v=4","gravatar_id":"","url":"https://api.github.com/users/Cnidarias","html_url":"https://github.com/Cnidarias","followers_url":"https://api.github.com/users/Cnidarias/followers","following_url":"https://api.github.com/users/Cnidarias/following{/other_user}","gists_url":"https://api.github.com/users/Cnidarias/gists{/gist_id}","starred_url":"https://api.github.com/users/Cnidarias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cnidarias/subscriptions","organizations_url":"https://api.github.com/users/Cnidarias/orgs","repos_url":"https://api.github.com/users/Cnidarias/repos","events_url":"https://api.github.com/users/Cnidarias/events{/privacy}","received_events_url":"https://api.github.com/users/Cnidarias/received_events","type":"User","site_admin":false},"repo":{"id":151079253,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwNzkyNTM=","name":"kinto","full_name":"Cnidarias/kinto","private":false,"owner":{"login":"Cnidarias","id":5615502,"node_id":"MDQ6VXNlcjU2MTU1MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5615502?v=4","gravatar_id":"","url":"https://api.github.com/users/Cnidarias","html_url":"https://github.com/Cnidarias","followers_url":"https://api.github.com/users/Cnidarias/followers","following_url":"https://api.github.com/users/Cnidarias/following{/other_user}","gists_url":"https://api.github.com/users/Cnidarias/gists{/gist_id}","starred_url":"https://api.github.com/users/Cnidarias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cnidarias/subscriptions","organizations_url":"https://api.github.com/users/Cnidarias/orgs","repos_url":"https://api.github.com/users/Cnidarias/repos","events_url":"https://api.github.com/users/Cnidarias/events{/privacy}","received_events_url":"https://api.github.com/users/Cnidarias/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Cnidarias/kinto","description":"A generic JSON document store with sharing and synchronisation capabilities.","fork":true,"url":"https://api.github.com/repos/Cnidarias/kinto","forks_url":"https://api.github.com/repos/Cnidarias/kinto/forks","keys_url":"https://api.github.com/repos/Cnidarias/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cnidarias/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cnidarias/kinto/teams","hooks_url":"https://api.github.com/repos/Cnidarias/kinto/hooks","issue_events_url":"https://api.github.com/repos/Cnidarias/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/Cnidarias/kinto/events","assignees_url":"https://api.github.com/repos/Cnidarias/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/Cnidarias/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/Cnidarias/kinto/tags","blobs_url":"https://api.github.com/repos/Cnidarias/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cnidarias/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cnidarias/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cnidarias/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cnidarias/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/Cnidarias/kinto/languages","stargazers_url":"https://api.github.com/repos/Cnidarias/kinto/stargazers","contributors_url":"https://api.github.com/repos/Cnidarias/kinto/contributors","subscribers_url":"https://api.github.com/repos/Cnidarias/kinto/subscribers","subscription_url":"https://api.github.com/repos/Cnidarias/kinto/subscription","commits_url":"https://api.github.com/repos/Cnidarias/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cnidarias/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cnidarias/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cnidarias/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cnidarias/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/Cnidarias/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cnidarias/kinto/merges","archive_url":"https://api.github.com/repos/Cnidarias/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cnidarias/kinto/downloads","issues_url":"https://api.github.com/repos/Cnidarias/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/Cnidarias/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/Cnidarias/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/Cnidarias/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cnidarias/kinto/labels{/name}","releases_url":"https://api.github.com/repos/Cnidarias/kinto/releases{/id}","deployments_url":"https://api.github.com/repos/Cnidarias/kinto/deployments","created_at":"2018-10-01T11:43:01Z","updated_at":"2018-10-08T15:15:41Z","pushed_at":"2018-10-18T05:34:52Z","git_url":"git://github.com/Cnidarias/kinto.git","ssh_url":"git@github.com:Cnidarias/kinto.git","clone_url":"https://github.com/Cnidarias/kinto.git","svn_url":"https://github.com/Cnidarias/kinto","homepage":"http://docs.kinto-storage.org/","size":23416,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kinto:master","ref":"master","sha":"458d420906336a6951d93794c198ee5507370a50","user":{"login":"Kinto","id":13413813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDEzODEz","avatar_url":"https://avatars2.githubusercontent.com/u/13413813?v=4","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":31315021,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMxNTAyMQ==","name":"kinto","full_name":"Kinto/kinto","private":false,"owner":{"login":"Kinto","id":13413813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDEzODEz","avatar_url":"https://avatars2.githubusercontent.com/u/13413813?v=4","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Kinto/kinto","description":"A generic JSON document store with sharing and synchronisation capabilities.","fork":false,"url":"https://api.github.com/repos/Kinto/kinto","forks_url":"https://api.github.com/repos/Kinto/kinto/forks","keys_url":"https://api.github.com/repos/Kinto/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto/events","assignees_url":"https://api.github.com/repos/Kinto/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto/merges","archive_url":"https://api.github.com/repos/Kinto/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto/deployments","created_at":"2015-02-25T13:34:23Z","updated_at":"2018-10-18T07:19:21Z","pushed_at":"2018-10-18T07:19:18Z","git_url":"git://github.com/Kinto/kinto.git","ssh_url":"git@github.com:Kinto/kinto.git","clone_url":"https://github.com/Kinto/kinto.git","svn_url":"https://github.com/Kinto/kinto","homepage":"http://docs.kinto-storage.org/","size":23458,"stargazers_count":3574,"watchers_count":3574,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":307,"open_issues":96,"watchers":3574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/1799"},"html":{"href":"https://github.com/Kinto/kinto/pull/1799"},"issue":{"href":"https://api.github.com/repos/Kinto/kinto/issues/1799"},"comments":{"href":"https://api.github.com/repos/Kinto/kinto/issues/1799/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/1799/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/1799/commits"},"statuses":{"href":"https://api.github.com/repos/Kinto/kinto/statuses/8e5a3a71c393d4efd583500779d6d09efcfcf5ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leplatrem"}}