{"action":"created","issue":{"url":"https://api.github.com/repos/spacetelescope/mirage/issues/156","repository_url":"https://api.github.com/repos/spacetelescope/mirage","labels_url":"https://api.github.com/repos/spacetelescope/mirage/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/mirage/issues/156/comments","events_url":"https://api.github.com/repos/spacetelescope/mirage/issues/156/events","html_url":"https://github.com/spacetelescope/mirage/pull/156","id":354895207,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTUxMTI4","number":156,"title":"Pysiaf integration","user":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-28T20:40:31Z","updated_at":"2018-08-31T21:35:39Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/spacetelescope/mirage/pulls/156","html_url":"https://github.com/spacetelescope/mirage/pull/156","diff_url":"https://github.com/spacetelescope/mirage/pull/156.diff","patch_url":"https://github.com/spacetelescope/mirage/pull/156.patch"},"body":"NOTE: Re-opening this PR. An error broke the previous PR before it was merged.\r\n\r\nThis PR introduces code to use pysiaf when calculating things like subarray sizes and positions, and for translating between detector pixels and RA, Dec. This will eliminate the dependence on the subarray definition file in the config directory except for 2 pieces of information: the number of amplifiers used to read out a particular aperture, as well as the OPGS (I think?) name for the aperture. This name is needed only to populate metadata in the output file. The number of amplifiers used is needed in order to get an accurate result for the calculation of the readout time. \r\n\r\nCRDS formatted distortion reference files will still be used for RA, Dec -> pixel space coordinate transforms. This is because in the future these files will be the only source for filter-dependent distortion solutions. If these files are not present, then the code will fall back onto `pysiaf` for these transformations. \r\n\r\nI think this is ready for a final review. Does anyone have time to grab the branch and run a test or two? Everything works for me, but it'd be nice to have confirmation. @KevinVolkSTScI? @laurenmarietta?"},"comment":{"url":"https://api.github.com/repos/spacetelescope/mirage/issues/comments/417795269","html_url":"https://github.com/spacetelescope/mirage/pull/156#issuecomment-417795269","issue_url":"https://api.github.com/repos/spacetelescope/mirage/issues/156","id":417795269,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzc5NTI2OQ==","user":{"login":"bhilbert4","id":11775426,"node_id":"MDQ6VXNlcjExNzc1NDI2","avatar_url":"https://avatars3.githubusercontent.com/u/11775426?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilbert4","html_url":"https://github.com/bhilbert4","followers_url":"https://api.github.com/users/bhilbert4/followers","following_url":"https://api.github.com/users/bhilbert4/following{/other_user}","gists_url":"https://api.github.com/users/bhilbert4/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilbert4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilbert4/subscriptions","organizations_url":"https://api.github.com/users/bhilbert4/orgs","repos_url":"https://api.github.com/users/bhilbert4/repos","events_url":"https://api.github.com/users/bhilbert4/events{/privacy}","received_events_url":"https://api.github.com/users/bhilbert4/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T21:35:39Z","updated_at":"2018-08-31T21:35:39Z","author_association":"COLLABORATOR","body":"Hmmm. `test_apt.py` calls `yaml_generator.py`, which does actually need a real value for the MIRAGE_DATA environment variable, in order to populate the names of various reference files in the yaml outputs. I'm not sure how to do this in terms of the Travis run then."}}
{"actor":{"display_login":"bhilbert4"}}