{"action":"created","comment":{"url":"https://api.github.com/repos/logary/logary/pulls/comments/181583839","pull_request_review_id":112238793,"id":181583839,"diff_hunk":"@@ -25,62 +26,12 @@ type LogaryConf =\n   /// each logger's min level\n   abstract loggerLevels : (string * LogLevel) list\n \n-/// A data-structure that gives information about the outcome of a flush\n-/// operation on the Registry. This data structure is only relevant if the\n-/// flush operation had an associated timeout.\n-type FlushInfo = FlushInfo of acks:string list * timeouts:string list\n-\n-/// A data-structure that gives information about the outcome of a shutdown\n-/// operation on the Registry. This data structure is only relevant if the\n-/// shutdown operation had an associated timeout.\n-type ShutdownInfo = ShutdownInfo of acks:string list * timeouts:string list\n-\n-/// LogManager is the public interface to Logary and takes care of getting\n-/// loggers from names. It is also responsible for running Dispose at the\n-/// end of the application in order to run the target shutdown logic. That said,\n-/// the body of the software should be crash only, so even if you don't call dispose\n-/// terminating the application, it should continue working.\n-///\n-/// This is also a synchronous wrapper around the asynchronous actors that make\n-/// up logary\n-type LogManager =\n-  /// Gets the service name that is used to filter and process the logs further\n-  /// downstream. This property is configured at initialisation of Logary.\n-  abstract runtimeInfo: RuntimeInfo\n-\n-  /// Get a logger denoted by the name passed as the parameter. This name can either be\n-  /// a specific name that you keep for a sub-component of your application or\n-  /// the name of the class. Also have a look at Logging.GetCurrentLogger().\n-  abstract getLogger: PointName -> Logger\n-\n-  abstract getLoggerWithMiddleware: PointName -> Middleware -> Logger\n-\n-  /// Awaits that all targets finish responding to a flush message\n-  /// so that we can be certain they have processed all previous messages.\n-  /// This function is useful together with unit tests for the targets.\n-  abstract flushPending: Duration -> Alt<FlushInfo>\n-  abstract flushPending: unit -> Alt<unit>\n-\n-  /// Shuts Logary down after flushing, given a timeout duration to wait before\n-  /// counting the target as timed out in responding. The duration is applied\n-  /// to each actor's communication. Does an ordered shutdown.\n-  ///\n-  /// First duration: flush duration\n-  /// Second duration: shutdown duration\n-  /// Returns the shutdown book keeping info\n-  abstract shutdown: flush:Duration * shutdown:Duration -> Alt<FlushInfo * ShutdownInfo>\n-  abstract shutdown: unit -> Alt<unit>\n-\n-  /// Dynamically controls logger min level,\n-  /// this will only affect the loggers (its name, not its instance) which have been created beafore\n-  abstract switchLoggerLevel: string * LogLevel -> unit\n-\n /// This is the main state container in Logary.\n module Registry =\n   /// The holder for the channels of communicating with the registry.\n   type T =\n     private {\n-      runtimeInfo: RuntimeInfo\n+      runtime: RuntimeInfo","path":"src/Logary/Registry.fs","position":68,"original_position":68,"commit_id":"0f196e558b991030b526533eb37b4ab48bbbe249","original_commit_id":"0f196e558b991030b526533eb37b4ab48bbbe249","user":{"login":"haf","id":193115,"avatar_url":"https://avatars0.githubusercontent.com/u/193115?v=4","gravatar_id":"","url":"https://api.github.com/users/haf","html_url":"https://github.com/haf","followers_url":"https://api.github.com/users/haf/followers","following_url":"https://api.github.com/users/haf/following{/other_user}","gists_url":"https://api.github.com/users/haf/gists{/gist_id}","starred_url":"https://api.github.com/users/haf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haf/subscriptions","organizations_url":"https://api.github.com/users/haf/orgs","repos_url":"https://api.github.com/users/haf/repos","events_url":"https://api.github.com/users/haf/events{/privacy}","received_events_url":"https://api.github.com/users/haf/received_events","type":"User","site_admin":false},"body":"This is a breaking change; which is fine right now, but let's keep these to a minimum going forward.","created_at":"2018-04-15T13:55:00Z","updated_at":"2018-04-15T13:55:00Z","html_url":"https://github.com/logary/logary/pull/295#discussion_r181583839","pull_request_url":"https://api.github.com/repos/logary/logary/pulls/295","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/logary/logary/pulls/comments/181583839"},"html":{"href":"https://github.com/logary/logary/pull/295#discussion_r181583839"},"pull_request":{"href":"https://api.github.com/repos/logary/logary/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/logary/logary/pulls/295","id":180214401,"html_url":"https://github.com/logary/logary/pull/295","diff_url":"https://github.com/logary/logary/pull/295.diff","patch_url":"https://github.com/logary/logary/pull/295.patch","issue_url":"https://api.github.com/repos/logary/logary/issues/295","number":295,"state":"open","locked":false,"title":"WIP: redesign span/scope support","user":{"login":"lust4life","id":3074328,"avatar_url":"https://avatars2.githubusercontent.com/u/3074328?v=4","gravatar_id":"","url":"https://api.github.com/users/lust4life","html_url":"https://github.com/lust4life","followers_url":"https://api.github.com/users/lust4life/followers","following_url":"https://api.github.com/users/lust4life/following{/other_user}","gists_url":"https://api.github.com/users/lust4life/gists{/gist_id}","starred_url":"https://api.github.com/users/lust4life/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lust4life/subscriptions","organizations_url":"https://api.github.com/users/lust4life/orgs","repos_url":"https://api.github.com/users/lust4life/repos","events_url":"https://api.github.com/users/lust4life/events{/privacy}","received_events_url":"https://api.github.com/users/lust4life/received_events","type":"User","site_admin":false},"body":"need add this to logary first (and release), then aspnet core target in separate repo can reference it.","created_at":"2018-04-09T05:32:02Z","updated_at":"2018-04-15T13:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca77922e38049e5f26430942a343146a2bef60d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/logary/logary/pulls/295/commits","review_comments_url":"https://api.github.com/repos/logary/logary/pulls/295/comments","review_comment_url":"https://api.github.com/repos/logary/logary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logary/logary/issues/295/comments","statuses_url":"https://api.github.com/repos/logary/logary/statuses/0f196e558b991030b526533eb37b4ab48bbbe249","head":{"label":"logary:feature/support-scope","ref":"feature/support-scope","sha":"0f196e558b991030b526533eb37b4ab48bbbe249","user":{"login":"logary","id":7761717,"avatar_url":"https://avatars2.githubusercontent.com/u/7761717?v=4","gravatar_id":"","url":"https://api.github.com/users/logary","html_url":"https://github.com/logary","followers_url":"https://api.github.com/users/logary/followers","following_url":"https://api.github.com/users/logary/following{/other_user}","gists_url":"https://api.github.com/users/logary/gists{/gist_id}","starred_url":"https://api.github.com/users/logary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logary/subscriptions","organizations_url":"https://api.github.com/users/logary/orgs","repos_url":"https://api.github.com/users/logary/repos","events_url":"https://api.github.com/users/logary/events{/privacy}","received_events_url":"https://api.github.com/users/logary/received_events","type":"Organization","site_admin":false},"repo":{"id":20382492,"name":"logary","full_name":"logary/logary","owner":{"login":"logary","id":7761717,"avatar_url":"https://avatars2.githubusercontent.com/u/7761717?v=4","gravatar_id":"","url":"https://api.github.com/users/logary","html_url":"https://github.com/logary","followers_url":"https://api.github.com/users/logary/followers","following_url":"https://api.github.com/users/logary/following{/other_user}","gists_url":"https://api.github.com/users/logary/gists{/gist_id}","starred_url":"https://api.github.com/users/logary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logary/subscriptions","organizations_url":"https://api.github.com/users/logary/orgs","repos_url":"https://api.github.com/users/logary/repos","events_url":"https://api.github.com/users/logary/events{/privacy}","received_events_url":"https://api.github.com/users/logary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logary/logary","description":"Logs and metrics are one!","fork":false,"url":"https://api.github.com/repos/logary/logary","forks_url":"https://api.github.com/repos/logary/logary/forks","keys_url":"https://api.github.com/repos/logary/logary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logary/logary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logary/logary/teams","hooks_url":"https://api.github.com/repos/logary/logary/hooks","issue_events_url":"https://api.github.com/repos/logary/logary/issues/events{/number}","events_url":"https://api.github.com/repos/logary/logary/events","assignees_url":"https://api.github.com/repos/logary/logary/assignees{/user}","branches_url":"https://api.github.com/repos/logary/logary/branches{/branch}","tags_url":"https://api.github.com/repos/logary/logary/tags","blobs_url":"https://api.github.com/repos/logary/logary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logary/logary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logary/logary/git/refs{/sha}","trees_url":"https://api.github.com/repos/logary/logary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logary/logary/statuses/{sha}","languages_url":"https://api.github.com/repos/logary/logary/languages","stargazers_url":"https://api.github.com/repos/logary/logary/stargazers","contributors_url":"https://api.github.com/repos/logary/logary/contributors","subscribers_url":"https://api.github.com/repos/logary/logary/subscribers","subscription_url":"https://api.github.com/repos/logary/logary/subscription","commits_url":"https://api.github.com/repos/logary/logary/commits{/sha}","git_commits_url":"https://api.github.com/repos/logary/logary/git/commits{/sha}","comments_url":"https://api.github.com/repos/logary/logary/comments{/number}","issue_comment_url":"https://api.github.com/repos/logary/logary/issues/comments{/number}","contents_url":"https://api.github.com/repos/logary/logary/contents/{+path}","compare_url":"https://api.github.com/repos/logary/logary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logary/logary/merges","archive_url":"https://api.github.com/repos/logary/logary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logary/logary/downloads","issues_url":"https://api.github.com/repos/logary/logary/issues{/number}","pulls_url":"https://api.github.com/repos/logary/logary/pulls{/number}","milestones_url":"https://api.github.com/repos/logary/logary/milestones{/number}","notifications_url":"https://api.github.com/repos/logary/logary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logary/logary/labels{/name}","releases_url":"https://api.github.com/repos/logary/logary/releases{/id}","deployments_url":"https://api.github.com/repos/logary/logary/deployments","created_at":"2014-06-01T17:42:22Z","updated_at":"2018-04-13T00:14:59Z","pushed_at":"2018-04-14T09:25:31Z","git_url":"git://github.com/logary/logary.git","ssh_url":"git@github.com:logary/logary.git","clone_url":"https://github.com/logary/logary.git","svn_url":"https://github.com/logary/logary","homepage":"https://logary.github.io/","size":29381,"stargazers_count":333,"watchers_count":333,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":59,"open_issues":6,"watchers":333,"default_branch":"master"}},"base":{"label":"logary:master","ref":"master","sha":"cdeb46137a7d56e91ce0ff390769ed7fa449d493","user":{"login":"logary","id":7761717,"avatar_url":"https://avatars2.githubusercontent.com/u/7761717?v=4","gravatar_id":"","url":"https://api.github.com/users/logary","html_url":"https://github.com/logary","followers_url":"https://api.github.com/users/logary/followers","following_url":"https://api.github.com/users/logary/following{/other_user}","gists_url":"https://api.github.com/users/logary/gists{/gist_id}","starred_url":"https://api.github.com/users/logary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logary/subscriptions","organizations_url":"https://api.github.com/users/logary/orgs","repos_url":"https://api.github.com/users/logary/repos","events_url":"https://api.github.com/users/logary/events{/privacy}","received_events_url":"https://api.github.com/users/logary/received_events","type":"Organization","site_admin":false},"repo":{"id":20382492,"name":"logary","full_name":"logary/logary","owner":{"login":"logary","id":7761717,"avatar_url":"https://avatars2.githubusercontent.com/u/7761717?v=4","gravatar_id":"","url":"https://api.github.com/users/logary","html_url":"https://github.com/logary","followers_url":"https://api.github.com/users/logary/followers","following_url":"https://api.github.com/users/logary/following{/other_user}","gists_url":"https://api.github.com/users/logary/gists{/gist_id}","starred_url":"https://api.github.com/users/logary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logary/subscriptions","organizations_url":"https://api.github.com/users/logary/orgs","repos_url":"https://api.github.com/users/logary/repos","events_url":"https://api.github.com/users/logary/events{/privacy}","received_events_url":"https://api.github.com/users/logary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logary/logary","description":"Logs and metrics are one!","fork":false,"url":"https://api.github.com/repos/logary/logary","forks_url":"https://api.github.com/repos/logary/logary/forks","keys_url":"https://api.github.com/repos/logary/logary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logary/logary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logary/logary/teams","hooks_url":"https://api.github.com/repos/logary/logary/hooks","issue_events_url":"https://api.github.com/repos/logary/logary/issues/events{/number}","events_url":"https://api.github.com/repos/logary/logary/events","assignees_url":"https://api.github.com/repos/logary/logary/assignees{/user}","branches_url":"https://api.github.com/repos/logary/logary/branches{/branch}","tags_url":"https://api.github.com/repos/logary/logary/tags","blobs_url":"https://api.github.com/repos/logary/logary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logary/logary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logary/logary/git/refs{/sha}","trees_url":"https://api.github.com/repos/logary/logary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logary/logary/statuses/{sha}","languages_url":"https://api.github.com/repos/logary/logary/languages","stargazers_url":"https://api.github.com/repos/logary/logary/stargazers","contributors_url":"https://api.github.com/repos/logary/logary/contributors","subscribers_url":"https://api.github.com/repos/logary/logary/subscribers","subscription_url":"https://api.github.com/repos/logary/logary/subscription","commits_url":"https://api.github.com/repos/logary/logary/commits{/sha}","git_commits_url":"https://api.github.com/repos/logary/logary/git/commits{/sha}","comments_url":"https://api.github.com/repos/logary/logary/comments{/number}","issue_comment_url":"https://api.github.com/repos/logary/logary/issues/comments{/number}","contents_url":"https://api.github.com/repos/logary/logary/contents/{+path}","compare_url":"https://api.github.com/repos/logary/logary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logary/logary/merges","archive_url":"https://api.github.com/repos/logary/logary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logary/logary/downloads","issues_url":"https://api.github.com/repos/logary/logary/issues{/number}","pulls_url":"https://api.github.com/repos/logary/logary/pulls{/number}","milestones_url":"https://api.github.com/repos/logary/logary/milestones{/number}","notifications_url":"https://api.github.com/repos/logary/logary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logary/logary/labels{/name}","releases_url":"https://api.github.com/repos/logary/logary/releases{/id}","deployments_url":"https://api.github.com/repos/logary/logary/deployments","created_at":"2014-06-01T17:42:22Z","updated_at":"2018-04-13T00:14:59Z","pushed_at":"2018-04-14T09:25:31Z","git_url":"git://github.com/logary/logary.git","ssh_url":"git@github.com:logary/logary.git","clone_url":"https://github.com/logary/logary.git","svn_url":"https://github.com/logary/logary","homepage":"https://logary.github.io/","size":29381,"stargazers_count":333,"watchers_count":333,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":59,"open_issues":6,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logary/logary/pulls/295"},"html":{"href":"https://github.com/logary/logary/pull/295"},"issue":{"href":"https://api.github.com/repos/logary/logary/issues/295"},"comments":{"href":"https://api.github.com/repos/logary/logary/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/logary/logary/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/logary/logary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logary/logary/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/logary/logary/statuses/0f196e558b991030b526533eb37b4ab48bbbe249"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"haf"}}