{"action":"created","issue":{"url":"https://api.github.com/repos/isetbio/isetbio/issues/373","repository_url":"https://api.github.com/repos/isetbio/isetbio","labels_url":"https://api.github.com/repos/isetbio/isetbio/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/isetbio/isetbio/issues/373/comments","events_url":"https://api.github.com/repos/isetbio/isetbio/issues/373/events","html_url":"https://github.com/isetbio/isetbio/issues/373","id":355602239,"node_id":"MDU6SXNzdWUzNTU2MDIyMzk=","number":373,"title":"M-W optics","user":{"login":"DavidBrainard","id":1158757,"node_id":"MDQ6VXNlcjExNTg3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1158757?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidBrainard","html_url":"https://github.com/DavidBrainard","followers_url":"https://api.github.com/users/DavidBrainard/followers","following_url":"https://api.github.com/users/DavidBrainard/following{/other_user}","gists_url":"https://api.github.com/users/DavidBrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBrainard/subscriptions","organizations_url":"https://api.github.com/users/DavidBrainard/orgs","repos_url":"https://api.github.com/users/DavidBrainard/repos","events_url":"https://api.github.com/users/DavidBrainard/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBrainard/received_events","type":"User","site_admin":false},"labels":[{"id":332615451,"node_id":"MDU6TGFiZWwzMzI2MTU0NTE=","url":"https://api.github.com/repos/isetbio/isetbio/labels/discussion","name":"discussion","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-30T14:07:25Z","updated_at":"2018-08-30T15:02:11Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The M-W paper derives an OTF, and that OTF is what is coded\r\nup in isetbio.  There were two mysteries I was worried about.\r\n \r\n1) Converting from center in middle to center at upper left\r\nwas accomplished by fftshift rather than ifftshift.  This is backwards.\r\nIt turns out it doesn't matter when the pixel dimension is even, but does\r\nwhen it is odd.\r\n \r\nAs a practical matter, this will have no effect on the computations\r\nfor the default M-W optics, because the default dimension for\r\nthe OTF was even.  When the dimension is odd, I think there\r\nwould be an error in the computed retinal image, because\r\nthe OTF ends up different than it should be, and we compute\r\nthe effect of the optics by a multiplication in the frequency domain.\r\nIn particular, the DC component ends up wrong (not 1) for this\r\ncase.\r\n \r\n2) Converting from OTF to PSF was done with fft2 rather than ifft2.\r\nThis also produces an incorrect result (as evidenced by a failure of\r\nthe PSF to sum to one and by the fact that it has complex values.)\r\n\r\nSince we only really use the PSF for\r\nvisualization rather than for computing the retinal image, the fact\r\nthat it wasn't right is not so bad.  And the plotted PSFs are not way different,\r\nonly a little bit so."},"comment":{"url":"https://api.github.com/repos/isetbio/isetbio/issues/comments/417351872","html_url":"https://github.com/isetbio/isetbio/issues/373#issuecomment-417351872","issue_url":"https://api.github.com/repos/isetbio/isetbio/issues/373","id":417351872,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzM1MTg3Mg==","user":{"login":"DavidBrainard","id":1158757,"node_id":"MDQ6VXNlcjExNTg3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1158757?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidBrainard","html_url":"https://github.com/DavidBrainard","followers_url":"https://api.github.com/users/DavidBrainard/followers","following_url":"https://api.github.com/users/DavidBrainard/following{/other_user}","gists_url":"https://api.github.com/users/DavidBrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBrainard/subscriptions","organizations_url":"https://api.github.com/users/DavidBrainard/orgs","repos_url":"https://api.github.com/users/DavidBrainard/repos","events_url":"https://api.github.com/users/DavidBrainard/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBrainard/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T15:02:11Z","updated_at":"2018-08-30T15:02:11Z","author_association":"CONTRIBUTOR","body":"Issued PR to incorporate this change."}}
{"actor":{"display_login":"DavidBrainard"}}