{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/241678490","pull_request_review_id":185004097,"id":241678490,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY3ODQ5MA==","diff_hunk":"@@ -766,10 +766,28 @@ public function getClickedButton()\n         }\n     }\n \n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function getAllErrors()\n+    {\n+        return $this->getErrorIterator(true, true)->all();","path":"src/Symfony/Component/Form/Form.php","position":9,"original_position":9,"commit_id":"2b0a331f8ec2eaad1c7485b9ff22026ae841a66d","original_commit_id":"2b0a331f8ec2eaad1c7485b9ff22026ae841a66d","user":{"login":"vudaltsov","id":2552865,"node_id":"MDQ6VXNlcjI1NTI4NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2552865?v=4","gravatar_id":"","url":"https://api.github.com/users/vudaltsov","html_url":"https://github.com/vudaltsov","followers_url":"https://api.github.com/users/vudaltsov/followers","following_url":"https://api.github.com/users/vudaltsov/following{/other_user}","gists_url":"https://api.github.com/users/vudaltsov/gists{/gist_id}","starred_url":"https://api.github.com/users/vudaltsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vudaltsov/subscriptions","organizations_url":"https://api.github.com/users/vudaltsov/orgs","repos_url":"https://api.github.com/users/vudaltsov/repos","events_url":"https://api.github.com/users/vudaltsov/events{/privacy}","received_events_url":"https://api.github.com/users/vudaltsov/received_events","type":"User","site_admin":false},"body":"Why not to do it easier? \r\n`return iterator_to_array($this->getErrorIterator(true), false);`","created_at":"2018-12-14T08:43:47Z","updated_at":"2018-12-14T08:45:04Z","html_url":"https://github.com/symfony/symfony/pull/29535#discussion_r241678490","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/29535","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/241678490"},"html":{"href":"https://github.com/symfony/symfony/pull/29535#discussion_r241678490"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29535"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/29535","id":237086165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDg2MTY1","html_url":"https://github.com/symfony/symfony/pull/29535","diff_url":"https://github.com/symfony/symfony/pull/29535.diff","patch_url":"https://github.com/symfony/symfony/pull/29535.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/29535","number":29535,"state":"open","locked":false,"title":"[HackDay] Improve form errors","user":{"login":"chindit","id":2115451,"node_id":"MDQ6VXNlcjIxMTU0NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2115451?v=4","gravatar_id":"","url":"https://api.github.com/users/chindit","html_url":"https://github.com/chindit","followers_url":"https://api.github.com/users/chindit/followers","following_url":"https://api.github.com/users/chindit/following{/other_user}","gists_url":"https://api.github.com/users/chindit/gists{/gist_id}","starred_url":"https://api.github.com/users/chindit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chindit/subscriptions","organizations_url":"https://api.github.com/users/chindit/orgs","repos_url":"https://api.github.com/users/chindit/repos","events_url":"https://api.github.com/users/chindit/events{/privacy}","received_events_url":"https://api.github.com/users/chindit/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master \r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | #25738\r\n| License       | MIT\r\n| Doc PR        | Waiting for approve\r\n\r\nFollowing the issue [#25738](https://github.com/symfony/symfony/issues/25738) this PR is a proposal to make form error more explicit for everyone.\r\n\r\nTraditionnal `$form->getErrors()` is renamed as `$form->getErrorIterator()` with same signature and a new method called `getAllErrors()`, more explicit, will return an array of `FormErrors`\r\n\r\n`getErrors()` method is kept but marked as deprecated.\r\n\r\nI know this is a major change and it may be done differently.\r\nEspecially the `all()` method on `FormErrorsIterator`.\r\n\r\nThis is a proposal and I'm open to other ways of fixing this issue.\r\n\r\nTests are written to reflect this change (Yay!)\r\n\r\nIf this PR is approve, I'll make another PR to change doc accordingly.\r\n\r\n#SymfonyConHackday2018\r\n","created_at":"2018-12-08T19:17:58Z","updated_at":"2018-12-14T08:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29bdb9630d3dfaa8070f9f7a19b8d5972512bcad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":231677,"node_id":"MDU6TGFiZWwyMzE2Nzc=","url":"https://api.github.com/repos/symfony/symfony/labels/BC%20Break","name":"BC Break","color":"e10c02","default":false},{"id":337186922,"node_id":"MDU6TGFiZWwzMzcxODY5MjI=","url":"https://api.github.com/repos/symfony/symfony/labels/Deprecation","name":"Deprecation","color":"f1c40f","default":false},{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":173,"closed_issues":34,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-12-14T07:57:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/29535/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/29535/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/29535/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/2b0a331f8ec2eaad1c7485b9ff22026ae841a66d","head":{"label":"chindit:improveFormErrors","ref":"improveFormErrors","sha":"2b0a331f8ec2eaad1c7485b9ff22026ae841a66d","user":{"login":"chindit","id":2115451,"node_id":"MDQ6VXNlcjIxMTU0NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2115451?v=4","gravatar_id":"","url":"https://api.github.com/users/chindit","html_url":"https://github.com/chindit","followers_url":"https://api.github.com/users/chindit/followers","following_url":"https://api.github.com/users/chindit/following{/other_user}","gists_url":"https://api.github.com/users/chindit/gists{/gist_id}","starred_url":"https://api.github.com/users/chindit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chindit/subscriptions","organizations_url":"https://api.github.com/users/chindit/orgs","repos_url":"https://api.github.com/users/chindit/repos","events_url":"https://api.github.com/users/chindit/events{/privacy}","received_events_url":"https://api.github.com/users/chindit/received_events","type":"User","site_admin":false},"repo":{"id":160932187,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5MzIxODc=","name":"symfony","full_name":"chindit/symfony","private":false,"owner":{"login":"chindit","id":2115451,"node_id":"MDQ6VXNlcjIxMTU0NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2115451?v=4","gravatar_id":"","url":"https://api.github.com/users/chindit","html_url":"https://github.com/chindit","followers_url":"https://api.github.com/users/chindit/followers","following_url":"https://api.github.com/users/chindit/following{/other_user}","gists_url":"https://api.github.com/users/chindit/gists{/gist_id}","starred_url":"https://api.github.com/users/chindit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chindit/subscriptions","organizations_url":"https://api.github.com/users/chindit/orgs","repos_url":"https://api.github.com/users/chindit/repos","events_url":"https://api.github.com/users/chindit/events{/privacy}","received_events_url":"https://api.github.com/users/chindit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chindit/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/chindit/symfony","forks_url":"https://api.github.com/repos/chindit/symfony/forks","keys_url":"https://api.github.com/repos/chindit/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chindit/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chindit/symfony/teams","hooks_url":"https://api.github.com/repos/chindit/symfony/hooks","issue_events_url":"https://api.github.com/repos/chindit/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/chindit/symfony/events","assignees_url":"https://api.github.com/repos/chindit/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/chindit/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/chindit/symfony/tags","blobs_url":"https://api.github.com/repos/chindit/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chindit/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chindit/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chindit/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chindit/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/chindit/symfony/languages","stargazers_url":"https://api.github.com/repos/chindit/symfony/stargazers","contributors_url":"https://api.github.com/repos/chindit/symfony/contributors","subscribers_url":"https://api.github.com/repos/chindit/symfony/subscribers","subscription_url":"https://api.github.com/repos/chindit/symfony/subscription","commits_url":"https://api.github.com/repos/chindit/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chindit/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chindit/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chindit/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chindit/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/chindit/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chindit/symfony/merges","archive_url":"https://api.github.com/repos/chindit/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chindit/symfony/downloads","issues_url":"https://api.github.com/repos/chindit/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/chindit/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/chindit/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/chindit/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chindit/symfony/labels{/name}","releases_url":"https://api.github.com/repos/chindit/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/chindit/symfony/deployments","created_at":"2018-12-08T11:24:10Z","updated_at":"2018-12-08T11:24:29Z","pushed_at":"2018-12-09T16:12:42Z","git_url":"git://github.com/chindit/symfony.git","ssh_url":"git@github.com:chindit/symfony.git","clone_url":"https://github.com/chindit/symfony.git","svn_url":"https://github.com/chindit/symfony","homepage":"https://symfony.com","size":123000,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"7b03bff57a2782edc6558d57df7ccff99ed0f1a9","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-12-14T07:43:19Z","pushed_at":"2018-12-14T08:02:21Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":128064,"stargazers_count":19335,"watchers_count":19335,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6598,"mirror_url":null,"archived":false,"open_issues_count":826,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6598,"open_issues":826,"watchers":19335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29535"},"html":{"href":"https://github.com/symfony/symfony/pull/29535"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/29535"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/29535/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29535/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/29535/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/2b0a331f8ec2eaad1c7485b9ff22026ae841a66d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vudaltsov"}}