{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/comments/236984136","pull_request_review_id":179173476,"id":236984136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjk4NDEzNg==","diff_hunk":"@@ -48,6 +45,16 @@ class RouteCollector\n      */\n     private $routes = [];\n \n+    /**\n+     * @var array","path":"src/RouteCollector.php","position":15,"original_position":15,"commit_id":"cb40c46a92377115eceb5ec74f6bcbac3edcddae","original_commit_id":"cb40c46a92377115eceb5ec74f6bcbac3edcddae","user":{"login":"malukenho","id":3275172,"node_id":"MDQ6VXNlcjMyNzUxNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/3275172?v=4","gravatar_id":"","url":"https://api.github.com/users/malukenho","html_url":"https://github.com/malukenho","followers_url":"https://api.github.com/users/malukenho/followers","following_url":"https://api.github.com/users/malukenho/following{/other_user}","gists_url":"https://api.github.com/users/malukenho/gists{/gist_id}","starred_url":"https://api.github.com/users/malukenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malukenho/subscriptions","organizations_url":"https://api.github.com/users/malukenho/orgs","repos_url":"https://api.github.com/users/malukenho/repos","events_url":"https://api.github.com/users/malukenho/events{/privacy}","received_events_url":"https://api.github.com/users/malukenho/received_events","type":"User","site_admin":false},"body":"Shouldn't it be `@var Route[]`?","created_at":"2018-11-28T08:40:02Z","updated_at":"2018-11-28T08:41:30Z","html_url":"https://github.com/zendframework/zend-expressive-router/pull/78#discussion_r236984136","pull_request_url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/comments/236984136"},"html":{"href":"https://github.com/zendframework/zend-expressive-router/pull/78#discussion_r236984136"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78","id":230986580,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTg2NTgw","html_url":"https://github.com/zendframework/zend-expressive-router/pull/78","diff_url":"https://github.com/zendframework/zend-expressive-router/pull/78.diff","patch_url":"https://github.com/zendframework/zend-expressive-router/pull/78.patch","issue_url":"https://api.github.com/repos/zendframework/zend-expressive-router/issues/78","number":78,"state":"open","locked":false,"title":"Optimize route addition","user":{"login":"nightlinus","id":2681887,"node_id":"MDQ6VXNlcjI2ODE4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2681887?v=4","gravatar_id":"","url":"https://api.github.com/users/nightlinus","html_url":"https://github.com/nightlinus","followers_url":"https://api.github.com/users/nightlinus/followers","following_url":"https://api.github.com/users/nightlinus/following{/other_user}","gists_url":"https://api.github.com/users/nightlinus/gists{/gist_id}","starred_url":"https://api.github.com/users/nightlinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightlinus/subscriptions","organizations_url":"https://api.github.com/users/nightlinus/orgs","repos_url":"https://api.github.com/users/nightlinus/repos","events_url":"https://api.github.com/users/nightlinus/events{/privacy}","received_events_url":"https://api.github.com/users/nightlinus/received_events","type":"User","site_admin":false},"body":"This pr optimizes route addition by removing O(n) duplicate check. In case of big monolitic application this starts to bite performance of application initialization. By the way i have added test for documented feature of detecting duplicate names, it was failing on develop branch.","created_at":"2018-11-14T21:24:33Z","updated_at":"2018-11-28T08:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92acc22de68b2c06c05c3d947276445fa01c361e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-router/issues/78/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive-router/statuses/cb40c46a92377115eceb5ec74f6bcbac3edcddae","head":{"label":"nightlinus:develop","ref":"develop","sha":"cb40c46a92377115eceb5ec74f6bcbac3edcddae","user":{"login":"nightlinus","id":2681887,"node_id":"MDQ6VXNlcjI2ODE4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2681887?v=4","gravatar_id":"","url":"https://api.github.com/users/nightlinus","html_url":"https://github.com/nightlinus","followers_url":"https://api.github.com/users/nightlinus/followers","following_url":"https://api.github.com/users/nightlinus/following{/other_user}","gists_url":"https://api.github.com/users/nightlinus/gists{/gist_id}","starred_url":"https://api.github.com/users/nightlinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightlinus/subscriptions","organizations_url":"https://api.github.com/users/nightlinus/orgs","repos_url":"https://api.github.com/users/nightlinus/repos","events_url":"https://api.github.com/users/nightlinus/events{/privacy}","received_events_url":"https://api.github.com/users/nightlinus/received_events","type":"User","site_admin":false},"repo":{"id":157604792,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2MDQ3OTI=","name":"zend-expressive-router","full_name":"nightlinus/zend-expressive-router","private":false,"owner":{"login":"nightlinus","id":2681887,"node_id":"MDQ6VXNlcjI2ODE4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/2681887?v=4","gravatar_id":"","url":"https://api.github.com/users/nightlinus","html_url":"https://github.com/nightlinus","followers_url":"https://api.github.com/users/nightlinus/followers","following_url":"https://api.github.com/users/nightlinus/following{/other_user}","gists_url":"https://api.github.com/users/nightlinus/gists{/gist_id}","starred_url":"https://api.github.com/users/nightlinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightlinus/subscriptions","organizations_url":"https://api.github.com/users/nightlinus/orgs","repos_url":"https://api.github.com/users/nightlinus/repos","events_url":"https://api.github.com/users/nightlinus/events{/privacy}","received_events_url":"https://api.github.com/users/nightlinus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nightlinus/zend-expressive-router","description":"Router subcomponent for Expressive","fork":true,"url":"https://api.github.com/repos/nightlinus/zend-expressive-router","forks_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/forks","keys_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/teams","hooks_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/hooks","issue_events_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/issues/events{/number}","events_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/events","assignees_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/assignees{/user}","branches_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/branches{/branch}","tags_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/tags","blobs_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/statuses/{sha}","languages_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/languages","stargazers_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/stargazers","contributors_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/contributors","subscribers_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/subscribers","subscription_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/subscription","commits_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/contents/{+path}","compare_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/merges","archive_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/downloads","issues_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/issues{/number}","pulls_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/pulls{/number}","milestones_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/milestones{/number}","notifications_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/labels{/name}","releases_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/releases{/id}","deployments_url":"https://api.github.com/repos/nightlinus/zend-expressive-router/deployments","created_at":"2018-11-14T20:09:29Z","updated_at":"2018-11-14T20:09:31Z","pushed_at":"2018-11-28T04:37:35Z","git_url":"git://github.com/nightlinus/zend-expressive-router.git","ssh_url":"git@github.com:nightlinus/zend-expressive-router.git","clone_url":"https://github.com/nightlinus/zend-expressive-router.git","svn_url":"https://github.com/nightlinus/zend-expressive-router","homepage":null,"size":400,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:develop","ref":"develop","sha":"66b801bfbcc3473225030421d1c29968f98a08bf","user":{"login":"zendframework","id":296074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":47270878,"node_id":"MDEwOlJlcG9zaXRvcnk0NzI3MDg3OA==","name":"zend-expressive-router","full_name":"zendframework/zend-expressive-router","private":false,"owner":{"login":"zendframework","id":296074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zendframework/zend-expressive-router","description":"Router subcomponent for Expressive","fork":false,"url":"https://api.github.com/repos/zendframework/zend-expressive-router","forks_url":"https://api.github.com/repos/zendframework/zend-expressive-router/forks","keys_url":"https://api.github.com/repos/zendframework/zend-expressive-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-expressive-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-expressive-router/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-expressive-router/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-expressive-router/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-expressive-router/events","assignees_url":"https://api.github.com/repos/zendframework/zend-expressive-router/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-expressive-router/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-expressive-router/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-expressive-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-expressive-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-expressive-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-expressive-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive-router/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-expressive-router/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-expressive-router/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-expressive-router/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-expressive-router/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-expressive-router/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-expressive-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-expressive-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-expressive-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-expressive-router/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-expressive-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-expressive-router/merges","archive_url":"https://api.github.com/repos/zendframework/zend-expressive-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-expressive-router/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-expressive-router/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-expressive-router/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-expressive-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-expressive-router/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-expressive-router/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-expressive-router/deployments","created_at":"2015-12-02T15:42:36Z","updated_at":"2018-11-15T19:22:51Z","pushed_at":"2018-11-28T04:37:37Z","git_url":"git://github.com/zendframework/zend-expressive-router.git","ssh_url":"git@github.com:zendframework/zend-expressive-router.git","clone_url":"https://github.com/zendframework/zend-expressive-router.git","svn_url":"https://github.com/zendframework/zend-expressive-router","homepage":null,"size":400,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78"},"html":{"href":"https://github.com/zendframework/zend-expressive-router/pull/78"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/issues/78"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-expressive-router/statuses/cb40c46a92377115eceb5ec74f6bcbac3edcddae"}},"author_association":"NONE"}}
{"actor":{"display_login":"malukenho"}}