{"action":"created","issue":{"url":"https://api.github.com/repos/OHDSI/Atlas/issues/1095","repository_url":"https://api.github.com/repos/OHDSI/Atlas","labels_url":"https://api.github.com/repos/OHDSI/Atlas/issues/1095/labels{/name}","comments_url":"https://api.github.com/repos/OHDSI/Atlas/issues/1095/comments","events_url":"https://api.github.com/repos/OHDSI/Atlas/issues/1095/events","html_url":"https://github.com/OHDSI/Atlas/pull/1095","id":378283442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDI0MTEx","number":1095,"title":"Full project bundling","user":{"login":"johnSamilin","id":5821894,"node_id":"MDQ6VXNlcjU4MjE4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5821894?v=4","gravatar_id":"","url":"https://api.github.com/users/johnSamilin","html_url":"https://github.com/johnSamilin","followers_url":"https://api.github.com/users/johnSamilin/followers","following_url":"https://api.github.com/users/johnSamilin/following{/other_user}","gists_url":"https://api.github.com/users/johnSamilin/gists{/gist_id}","starred_url":"https://api.github.com/users/johnSamilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnSamilin/subscriptions","organizations_url":"https://api.github.com/users/johnSamilin/orgs","repos_url":"https://api.github.com/users/johnSamilin/repos","events_url":"https://api.github.com/users/johnSamilin/events{/privacy}","received_events_url":"https://api.github.com/users/johnSamilin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OHDSI/Atlas/milestones/21","html_url":"https://github.com/OHDSI/Atlas/milestone/21","labels_url":"https://api.github.com/repos/OHDSI/Atlas/milestones/21/labels","id":3814441,"node_id":"MDk6TWlsZXN0b25lMzgxNDQ0MQ==","number":21,"title":"V2.7.0. \"Bug free\"","description":"","creator":{"login":"pavgra","id":10010071,"node_id":"MDQ6VXNlcjEwMDEwMDcx","avatar_url":"https://avatars0.githubusercontent.com/u/10010071?v=4","gravatar_id":"","url":"https://api.github.com/users/pavgra","html_url":"https://github.com/pavgra","followers_url":"https://api.github.com/users/pavgra/followers","following_url":"https://api.github.com/users/pavgra/following{/other_user}","gists_url":"https://api.github.com/users/pavgra/gists{/gist_id}","starred_url":"https://api.github.com/users/pavgra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavgra/subscriptions","organizations_url":"https://api.github.com/users/pavgra/orgs","repos_url":"https://api.github.com/users/pavgra/repos","events_url":"https://api.github.com/users/pavgra/events{/privacy}","received_events_url":"https://api.github.com/users/pavgra/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":4,"state":"open","created_at":"2018-11-12T14:55:58Z","updated_at":"2018-11-15T09:18:22Z","due_on":null,"closed_at":null},"comments":30,"created_at":"2018-11-07T13:17:39Z","updated_at":"2018-11-15T20:07:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OHDSI/Atlas/pulls/1095","html_url":"https://github.com/OHDSI/Atlas/pull/1095","diff_url":"https://github.com/OHDSI/Atlas/pull/1095.diff","patch_url":"https://github.com/OHDSI/Atlas/pull/1095.patch"},"body":"Instead of an old bundling process where the script used to download the individual libs and compiled them to one file, this PR introduces using of npm as a provider for 3rd party libraries.\r\nIndividual files which used to be stored in the `assets` folder now replaced by `node_modules`.\r\n`npm run build` bundles the whole project and it's external dependencies (not including style files) in one file.\r\nThe compilation is done by requirejs optimizer with the help of babel (because `esprima` parser, which is used by requirejs, can't understand es6 features). \r\nThis PR contains tons of changes, all of them are there to make optimization possible:\r\n* there should not be anonymous modules (ie `define((require, exports)`) because it leads to collisions\r\n* some of the relative paths are being changed to absolute ones\r\n* `optional` loader cannot be used durung compile time, besides, it's useless\r\n* `document` is unavailable during compile time, so some additional checks added\r\n\r\nTo use bundled project, run `npm run build` and then change `index.html`:\r\n`<script data-main=\"js/main\" src=\"js/require.js\"></script>` -> `<script data-main=\"js/assets/bundle/bundle\" src=\"js/require.js\"></script>`\r\n\r\nNote: anyway, `npm install` must be executed in order to install 3rd party libraries, even if you're not going to compile the project"},"comment":{"url":"https://api.github.com/repos/OHDSI/Atlas/issues/comments/439173230","html_url":"https://github.com/OHDSI/Atlas/pull/1095#issuecomment-439173230","issue_url":"https://api.github.com/repos/OHDSI/Atlas/issues/1095","id":439173230,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTE3MzIzMA==","user":{"login":"chrisknoll","id":6818777,"node_id":"MDQ6VXNlcjY4MTg3Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6818777?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisknoll","html_url":"https://github.com/chrisknoll","followers_url":"https://api.github.com/users/chrisknoll/followers","following_url":"https://api.github.com/users/chrisknoll/following{/other_user}","gists_url":"https://api.github.com/users/chrisknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisknoll/subscriptions","organizations_url":"https://api.github.com/users/chrisknoll/orgs","repos_url":"https://api.github.com/users/chrisknoll/repos","events_url":"https://api.github.com/users/chrisknoll/events{/privacy}","received_events_url":"https://api.github.com/users/chrisknoll/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T20:07:49Z","updated_at":"2018-11-15T20:07:49Z","author_association":"COLLABORATOR","body":"Ok, good news is: bundle completed and web application launched!  \r\n\r\nI noticed that .less files are not being compiled into the bundle and so you get this:\r\n\r\n![image](https://user-images.githubusercontent.com/6818777/48578603-207e3980-e8e8-11e8-9627-119342a64e5e.png)\r\n\r\n276/333 of the requests were for `.less` files.  I'm wondering if we use a less plugin that works with the optimizer, if that could be improved.\r\n"}}
{"actor":{"display_login":"chrisknoll"}}