{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/6951","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/6951/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/6951/comments","events_url":"https://api.github.com/repos/helm/charts/issues/6951/events","html_url":"https://github.com/helm/charts/pull/6951","id":346805528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTgwMzg0","number":6951,"title":"[stable/concourse] Upgrade to Concourse 4","user":{"login":"wendorf","id":407342,"node_id":"MDQ6VXNlcjQwNzM0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/407342?v=4","gravatar_id":"","url":"https://api.github.com/users/wendorf","html_url":"https://github.com/wendorf","followers_url":"https://api.github.com/users/wendorf/followers","following_url":"https://api.github.com/users/wendorf/following{/other_user}","gists_url":"https://api.github.com/users/wendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/wendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendorf/subscriptions","organizations_url":"https://api.github.com/users/wendorf/orgs","repos_url":"https://api.github.com/users/wendorf/repos","events_url":"https://api.github.com/users/wendorf/events{/privacy}","received_events_url":"https://api.github.com/users/wendorf/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":{"login":"william-tran","id":1084441,"node_id":"MDQ6VXNlcjEwODQ0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1084441?v=4","gravatar_id":"","url":"https://api.github.com/users/william-tran","html_url":"https://github.com/william-tran","followers_url":"https://api.github.com/users/william-tran/followers","following_url":"https://api.github.com/users/william-tran/following{/other_user}","gists_url":"https://api.github.com/users/william-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/william-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-tran/subscriptions","organizations_url":"https://api.github.com/users/william-tran/orgs","repos_url":"https://api.github.com/users/william-tran/repos","events_url":"https://api.github.com/users/william-tran/events{/privacy}","received_events_url":"https://api.github.com/users/william-tran/received_events","type":"User","site_admin":false},"assignees":[{"login":"william-tran","id":1084441,"node_id":"MDQ6VXNlcjEwODQ0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1084441?v=4","gravatar_id":"","url":"https://api.github.com/users/william-tran","html_url":"https://github.com/william-tran","followers_url":"https://api.github.com/users/william-tran/followers","following_url":"https://api.github.com/users/william-tran/following{/other_user}","gists_url":"https://api.github.com/users/william-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/william-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-tran/subscriptions","organizations_url":"https://api.github.com/users/william-tran/orgs","repos_url":"https://api.github.com/users/william-tran/repos","events_url":"https://api.github.com/users/william-tran/events{/privacy}","received_events_url":"https://api.github.com/users/william-tran/received_events","type":"User","site_admin":false}],"milestone":null,"comments":31,"created_at":"2018-08-01T23:25:38Z","updated_at":"2018-09-15T14:46:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6951","html_url":"https://github.com/helm/charts/pull/6951","diff_url":"https://github.com/helm/charts/pull/6951.diff","patch_url":"https://github.com/helm/charts/pull/6951.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nSupports the recently-released Concourse 4, and drops support for versions earlier than 4.0.0\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #6873\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis is a big PR, potentially too big. I've split up the pieces of work into individual commits, so can easily remove pieces if needed. I've tried to capture all the desires in #6873, including removing old parameters not supported in 4.0. I have left one deprecated parameter, `CONCOURSE_POSTGRES_DATA_SOURCE`, because it's a little painful to change all of the documentation and usage to use the new split-up parameters, and this was already becoming a big PR. If that's something we would like, though, I can certainly do the work and update this PR."},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/421581233","html_url":"https://github.com/helm/charts/pull/6951#issuecomment-421581233","issue_url":"https://api.github.com/repos/helm/charts/issues/6951","id":421581233,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTU4MTIzMw==","user":{"login":"wendorf","id":407342,"node_id":"MDQ6VXNlcjQwNzM0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/407342?v=4","gravatar_id":"","url":"https://api.github.com/users/wendorf","html_url":"https://github.com/wendorf","followers_url":"https://api.github.com/users/wendorf/followers","following_url":"https://api.github.com/users/wendorf/following{/other_user}","gists_url":"https://api.github.com/users/wendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/wendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendorf/subscriptions","organizations_url":"https://api.github.com/users/wendorf/orgs","repos_url":"https://api.github.com/users/wendorf/repos","events_url":"https://api.github.com/users/wendorf/events{/privacy}","received_events_url":"https://api.github.com/users/wendorf/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T14:46:54Z","updated_at":"2018-09-15T14:46:54Z","author_association":"CONTRIBUTOR","body":"@william-tran responses inline:\r\n\r\n> On the presence guards, a template helper could be devised, thought needing to use dict to pass in params is also a bit ugly in its own way. Maybe list?\r\n\r\nThe Concourse team is working on [Investigate : Auto-magically generating K8s helm chart parameters](https://github.com/concourse/concourse/issues/2472) so I'm kinda tempted to punt on a perfect solution and just do ugly presence guards so the chart is more functional.\r\n\r\n> [...] the ideal scenario is where secrets is kept to a minimum; they only contain credentials, so that the management overhead of these values is kept to a minimum [...] I can also see that this forces the chart maintainers to think about what actually is a secret and what isn't, but this is an important thing for us to make that determination for the benefit of chart users.\r\n\r\nI'm on board, and can move non secrets out of this. I'll do my best determination of what is a secret and not, and hopefully get feedback if there are any mistakes.\r\n\r\n> In terms of moving from secrets.oidcAuth.clientsecret and oidcAuth.secrets.clientsecret, this is at best \"6 of 1, half a dozen of the other\", which doesn't warrant the change in structure.\r\n\r\nI'm not sure if you're saying you don't care about the structure, or if you'd prefer to keep it as `secrets.oidcAuth.clientsecret`. If that's what you'd prefer, I'm on board. If you don't care, I'd personally like to move to `oidcAuth.secrets.clientsecret`.\r\n\r\nI'm on vacation through the end of the month and won't have a lot of time to work on this PR, but will get to it ASAP."}}
{"actor":{"display_login":"wendorf"}}