{"action":"created","issue":{"url":"https://api.github.com/repos/knative/build/issues/470","repository_url":"https://api.github.com/repos/knative/build","labels_url":"https://api.github.com/repos/knative/build/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/knative/build/issues/470/comments","events_url":"https://api.github.com/repos/knative/build/issues/470/events","html_url":"https://github.com/knative/build/pull/470","id":380442347,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjM5Mjgz","number":470,"title":"No init containers","user":{"login":"aaron-prindle","id":1951658,"node_id":"MDQ6VXNlcjE5NTE2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1951658?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"labels":[{"id":859948640,"node_id":"MDU6TGFiZWw4NTk5NDg2NDA=","url":"https://api.github.com/repos/knative/build/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-13T21:57:47Z","updated_at":"2018-12-06T23:08:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/knative/build/pulls/470","html_url":"https://github.com/knative/build/pull/470","diff_url":"https://github.com/knative/build/pull/470.diff","patch_url":"https://github.com/knative/build/pull/470.patch"},"body":"Fixes #9\r\n\r\n## Proposed Changes\r\n\r\n  * Have Build Steps run as multiple \"normal\" containers in a Pod w/ entrypoint enforced linear execution vs. initContainers\r\n\r\nThis PR modifies the PodSpec generated by build to run Steps as normal containers and not initcontainers.  As Build requires Steps to run in a linear fashion and normal containers would typically all run at the same time, entrypoint rewriting is used in order to enforce the run order of the containers.  This should fix some of the issues described in #9 as normal container logs are not cleared as aggressively as initContainer logs.  This change change will also allow Build to use sidecar containers in the future.\r\n\r\nKnown Issues (These need to be fixed):\r\n\r\n- ~~As entrypoint is rewritten for these containers, containers relying on running `Entrypoint` and not `Command` will not work as expected.   This can be resolved by fetching and storing the container entrypoint information directly as done here: https://github.com/knative/build-pipeline/pull/183~~ An implementation of this has been added now\r\n- The entrypoint image is currently hosted in my own gcr.io repo.  It is based on https://github.com/kubernetes/test-infra/blob/master/prow/entrypoint/run.go"},"comment":{"url":"https://api.github.com/repos/knative/build/issues/comments/445063725","html_url":"https://github.com/knative/build/pull/470#issuecomment-445063725","issue_url":"https://api.github.com/repos/knative/build/issues/470","id":445063725,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTA2MzcyNQ==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T23:08:45Z","updated_at":"2018-12-06T23:08:45Z","author_association":"NONE","body":"@aaron-prindle: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-knative-build-build-tests | 3f5a056cb926ed5b5f9fb25f521585fc7363b730 | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_build/470/pull-knative-build-build-tests/1070811299669086208/) | `/test pull-knative-build-build-tests`\npull-knative-build-integration-tests | 3f5a056cb926ed5b5f9fb25f521585fc7363b730 | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_build/470/pull-knative-build-integration-tests/1070811299669086210/) | `/test pull-knative-build-integration-tests`\n\n[Full PR test history](https://gubernator.knative.dev/pr/knative_build/470). [Your PR dashboard](https://gubernator.knative.dev/pr/aaron-prindle).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"knative-prow-robot"}}