{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-druid/pulls/comments/224131333","pull_request_review_id":163424899,"id":224131333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDEzMTMzMw==","diff_hunk":"@@ -951,21 +951,35 @@ private static String getRandomId()\n     return suffix.toString();\n   }\n \n-  private KafkaConsumer<byte[], byte[]> getKafkaConsumer()\n+  private KafkaConsumer<byte[], byte[]> getKafkaConsumer() throws IOException\n   {\n-    final Properties props = new Properties();\n-\n-    props.setProperty(\"metadata.max.age.ms\", \"10000\");\n-    props.setProperty(\"group.id\", StringUtils.format(\"kafka-supervisor-%s\", getRandomId()));\n-\n-    props.putAll(ioConfig.getConsumerProperties());\n+    final Map<String, Object> configs = new HashMap<>();","path":"extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java","position":null,"original_position":29,"commit_id":"a65fe782517b1d0e1cb8c32f419fc559e49b189a","original_commit_id":"c52b3c7261f9c825c1b8ea1b9e27d67a202ea0d2","user":{"login":"a2l007","id":4603202,"node_id":"MDQ6VXNlcjQ2MDMyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4603202?v=4","gravatar_id":"","url":"https://api.github.com/users/a2l007","html_url":"https://github.com/a2l007","followers_url":"https://api.github.com/users/a2l007/followers","following_url":"https://api.github.com/users/a2l007/following{/other_user}","gists_url":"https://api.github.com/users/a2l007/gists{/gist_id}","starred_url":"https://api.github.com/users/a2l007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a2l007/subscriptions","organizations_url":"https://api.github.com/users/a2l007/orgs","repos_url":"https://api.github.com/users/a2l007/repos","events_url":"https://api.github.com/users/a2l007/events{/privacy}","received_events_url":"https://api.github.com/users/a2l007/received_events","type":"User","site_admin":false},"body":"I see your point. Fixed.","created_at":"2018-10-10T15:36:59Z","updated_at":"2018-10-10T15:36:59Z","html_url":"https://github.com/apache/incubator-druid/pull/6285#discussion_r224131333","pull_request_url":"https://api.github.com/repos/apache/incubator-druid/pulls/6285","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/comments/224131333"},"html":{"href":"https://github.com/apache/incubator-druid/pull/6285#discussion_r224131333"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/6285"}},"in_reply_to_id":214998699},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-druid/pulls/6285","id":212462999,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDYyOTk5","html_url":"https://github.com/apache/incubator-druid/pull/6285","diff_url":"https://github.com/apache/incubator-druid/pull/6285.diff","patch_url":"https://github.com/apache/incubator-druid/pull/6285.patch","issue_url":"https://api.github.com/repos/apache/incubator-druid/issues/6285","number":6285,"state":"open","locked":false,"title":"Securing passwords used for SSL connections to Kafka","user":{"login":"a2l007","id":4603202,"node_id":"MDQ6VXNlcjQ2MDMyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4603202?v=4","gravatar_id":"","url":"https://api.github.com/users/a2l007","html_url":"https://github.com/a2l007","followers_url":"https://api.github.com/users/a2l007/followers","following_url":"https://api.github.com/users/a2l007/following{/other_user}","gists_url":"https://api.github.com/users/a2l007/gists{/gist_id}","starred_url":"https://api.github.com/users/a2l007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a2l007/subscriptions","organizations_url":"https://api.github.com/users/a2l007/orgs","repos_url":"https://api.github.com/users/a2l007/repos","events_url":"https://api.github.com/users/a2l007/events{/privacy}","received_events_url":"https://api.github.com/users/a2l007/received_events","type":"User","site_admin":false},"body":"Fixes  #6265 \r\nThe user can now use `PasswordProvider` to secure the following Kafka consumer properties used for SSL connections to Kafka:\r\n`ssl.truststore.password`\r\n`ssl.keystore.password`\r\n`ssl.key.password`","created_at":"2018-08-31T18:32:54Z","updated_at":"2018-10-10T15:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"791e5be2be7f4227299ffd48290f77d0c5f7bdb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-druid/pulls/6285/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-druid/pulls/6285/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-druid/issues/6285/comments","statuses_url":"https://api.github.com/repos/apache/incubator-druid/statuses/a65fe782517b1d0e1cb8c32f419fc559e49b189a","head":{"label":"a2l007:fix_kafkapasswords","ref":"fix_kafkapasswords","sha":"a65fe782517b1d0e1cb8c32f419fc559e49b189a","user":{"login":"a2l007","id":4603202,"node_id":"MDQ6VXNlcjQ2MDMyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4603202?v=4","gravatar_id":"","url":"https://api.github.com/users/a2l007","html_url":"https://github.com/a2l007","followers_url":"https://api.github.com/users/a2l007/followers","following_url":"https://api.github.com/users/a2l007/following{/other_user}","gists_url":"https://api.github.com/users/a2l007/gists{/gist_id}","starred_url":"https://api.github.com/users/a2l007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a2l007/subscriptions","organizations_url":"https://api.github.com/users/a2l007/orgs","repos_url":"https://api.github.com/users/a2l007/repos","events_url":"https://api.github.com/users/a2l007/events{/privacy}","received_events_url":"https://api.github.com/users/a2l007/received_events","type":"User","site_admin":false},"repo":{"id":97611468,"node_id":"MDEwOlJlcG9zaXRvcnk5NzYxMTQ2OA==","name":"druid","full_name":"a2l007/druid","private":false,"owner":{"login":"a2l007","id":4603202,"node_id":"MDQ6VXNlcjQ2MDMyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4603202?v=4","gravatar_id":"","url":"https://api.github.com/users/a2l007","html_url":"https://github.com/a2l007","followers_url":"https://api.github.com/users/a2l007/followers","following_url":"https://api.github.com/users/a2l007/following{/other_user}","gists_url":"https://api.github.com/users/a2l007/gists{/gist_id}","starred_url":"https://api.github.com/users/a2l007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a2l007/subscriptions","organizations_url":"https://api.github.com/users/a2l007/orgs","repos_url":"https://api.github.com/users/a2l007/repos","events_url":"https://api.github.com/users/a2l007/events{/privacy}","received_events_url":"https://api.github.com/users/a2l007/received_events","type":"User","site_admin":false},"html_url":"https://github.com/a2l007/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/a2l007/druid","forks_url":"https://api.github.com/repos/a2l007/druid/forks","keys_url":"https://api.github.com/repos/a2l007/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a2l007/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a2l007/druid/teams","hooks_url":"https://api.github.com/repos/a2l007/druid/hooks","issue_events_url":"https://api.github.com/repos/a2l007/druid/issues/events{/number}","events_url":"https://api.github.com/repos/a2l007/druid/events","assignees_url":"https://api.github.com/repos/a2l007/druid/assignees{/user}","branches_url":"https://api.github.com/repos/a2l007/druid/branches{/branch}","tags_url":"https://api.github.com/repos/a2l007/druid/tags","blobs_url":"https://api.github.com/repos/a2l007/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a2l007/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a2l007/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/a2l007/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a2l007/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/a2l007/druid/languages","stargazers_url":"https://api.github.com/repos/a2l007/druid/stargazers","contributors_url":"https://api.github.com/repos/a2l007/druid/contributors","subscribers_url":"https://api.github.com/repos/a2l007/druid/subscribers","subscription_url":"https://api.github.com/repos/a2l007/druid/subscription","commits_url":"https://api.github.com/repos/a2l007/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/a2l007/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/a2l007/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/a2l007/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/a2l007/druid/contents/{+path}","compare_url":"https://api.github.com/repos/a2l007/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a2l007/druid/merges","archive_url":"https://api.github.com/repos/a2l007/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a2l007/druid/downloads","issues_url":"https://api.github.com/repos/a2l007/druid/issues{/number}","pulls_url":"https://api.github.com/repos/a2l007/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/a2l007/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/a2l007/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a2l007/druid/labels{/name}","releases_url":"https://api.github.com/repos/a2l007/druid/releases{/id}","deployments_url":"https://api.github.com/repos/a2l007/druid/deployments","created_at":"2017-07-18T14:57:15Z","updated_at":"2018-10-07T16:06:51Z","pushed_at":"2018-10-10T15:35:36Z","git_url":"git://github.com/a2l007/druid.git","ssh_url":"git@github.com:a2l007/druid.git","clone_url":"https://github.com/a2l007/druid.git","svn_url":"https://github.com/a2l007/druid","homepage":"http://druid.io","size":145482,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"09126c021a786ea13656e8a390732021a8e61b94","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"node_id":"MDEwOlJlcG9zaXRvcnk2MzU4MTg4","name":"incubator-druid","full_name":"apache/incubator-druid","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-druid","description":"Apache Druid (Incubating) - Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/apache/incubator-druid","forks_url":"https://api.github.com/repos/apache/incubator-druid/forks","keys_url":"https://api.github.com/repos/apache/incubator-druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-druid/teams","hooks_url":"https://api.github.com/repos/apache/incubator-druid/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-druid/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-druid/events","assignees_url":"https://api.github.com/repos/apache/incubator-druid/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-druid/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-druid/tags","blobs_url":"https://api.github.com/repos/apache/incubator-druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-druid/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-druid/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-druid/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-druid/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-druid/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-druid/subscription","commits_url":"https://api.github.com/repos/apache/incubator-druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-druid/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-druid/merges","archive_url":"https://api.github.com/repos/apache/incubator-druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-druid/downloads","issues_url":"https://api.github.com/repos/apache/incubator-druid/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-druid/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-druid/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-druid/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-druid/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2018-10-10T15:24:58Z","pushed_at":"2018-10-10T15:35:38Z","git_url":"git://github.com/apache/incubator-druid.git","ssh_url":"git@github.com:apache/incubator-druid.git","clone_url":"https://github.com/apache/incubator-druid.git","svn_url":"https://github.com/apache/incubator-druid","homepage":"http://druid.io","size":148825,"stargazers_count":7067,"watchers_count":7067,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1736,"mirror_url":null,"archived":false,"open_issues_count":1158,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1736,"open_issues":1158,"watchers":7067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/6285"},"html":{"href":"https://github.com/apache/incubator-druid/pull/6285"},"issue":{"href":"https://api.github.com/repos/apache/incubator-druid/issues/6285"},"comments":{"href":"https://api.github.com/repos/apache/incubator-druid/issues/6285/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/6285/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/6285/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-druid/statuses/a65fe782517b1d0e1cb8c32f419fc559e49b189a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"a2l007"}}