{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/169200911","pull_request_review_id":97688846,"id":169200911,"diff_hunk":"@@ -65,8 +65,9 @@ def deprecate_kwarg(old_arg_name, new_arg_name, mapping=None, stacklevel=2):\n     ----------\n     old_arg_name : str\n         Name of argument in function to deprecate\n-    new_arg_name : str\n-        Name of preferred argument in function\n+    new_arg_name : str | None\n+        Name of preferred argument in function. Use none to raise warning that","path":"pandas/util/_decorators.py","position":null,"original_position":7,"commit_id":"699805198f7e31e3f6787b612ec507dd71c056a6","original_commit_id":"261044a77168add13a18d982faabea39deb8f6ec","user":{"login":"EricChea","id":5069128,"avatar_url":"https://avatars2.githubusercontent.com/u/5069128?v=4","gravatar_id":"","url":"https://api.github.com/users/EricChea","html_url":"https://github.com/EricChea","followers_url":"https://api.github.com/users/EricChea/followers","following_url":"https://api.github.com/users/EricChea/following{/other_user}","gists_url":"https://api.github.com/users/EricChea/gists{/gist_id}","starred_url":"https://api.github.com/users/EricChea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricChea/subscriptions","organizations_url":"https://api.github.com/users/EricChea/orgs","repos_url":"https://api.github.com/users/EricChea/repos","events_url":"https://api.github.com/users/EricChea/events{/privacy}","received_events_url":"https://api.github.com/users/EricChea/received_events","type":"User","site_admin":false},"body":"Thanks for catching that.  Please refer to 699805198f7e31e3f6787b612ec507dd71c056a6","created_at":"2018-02-20T01:37:05Z","updated_at":"2018-02-20T01:37:05Z","html_url":"https://github.com/pandas-dev/pandas/pull/19751#discussion_r169200911","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/169200911"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19751#discussion_r169200911"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751"}},"in_reply_to_id":169113138},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751","id":169846817,"html_url":"https://github.com/pandas-dev/pandas/pull/19751","diff_url":"https://github.com/pandas-dev/pandas/pull/19751.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/19751.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19751","number":19751,"state":"open","locked":false,"title":"[Utils][Warnings] Add deprecation warning for factorize() keyword, or…","user":{"login":"EricChea","id":5069128,"avatar_url":"https://avatars2.githubusercontent.com/u/5069128?v=4","gravatar_id":"","url":"https://api.github.com/users/EricChea","html_url":"https://github.com/EricChea","followers_url":"https://api.github.com/users/EricChea/followers","following_url":"https://api.github.com/users/EricChea/following{/other_user}","gists_url":"https://api.github.com/users/EricChea/gists{/gist_id}","starred_url":"https://api.github.com/users/EricChea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricChea/subscriptions","organizations_url":"https://api.github.com/users/EricChea/orgs","repos_url":"https://api.github.com/users/EricChea/repos","events_url":"https://api.github.com/users/EricChea/events{/privacy}","received_events_url":"https://api.github.com/users/EricChea/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nIn response to #19727.\r\nAdds functionality to the ``deprecate_kwargs`` utility.  Currently, the utility doesn't allow the deprecation of an old keyword without having a new one in place.  The change proposed here allows the deprecation of an *old* keyword without specifying a *new* keyword by allowing users to pass ``new_arg_name=None``  to ``deprecate_kwargs``. \r\n\r\n#### PR checklist\r\n- [X] closes #19727\r\n- [X] tests added / passed\r\n- [X] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [X] whatsnew entry\r\n","created_at":"2018-02-18T19:54:51Z","updated_at":"2018-02-20T01:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db529e0454b8487ba639afd05fa1b24c5adbaa0a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":87485152,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Deprecate","name":"Deprecate","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19751/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/699805198f7e31e3f6787b612ec507dd71c056a6","head":{"label":"EricChea:dep_keyword","ref":"dep_keyword","sha":"699805198f7e31e3f6787b612ec507dd71c056a6","user":{"login":"EricChea","id":5069128,"avatar_url":"https://avatars2.githubusercontent.com/u/5069128?v=4","gravatar_id":"","url":"https://api.github.com/users/EricChea","html_url":"https://github.com/EricChea","followers_url":"https://api.github.com/users/EricChea/followers","following_url":"https://api.github.com/users/EricChea/following{/other_user}","gists_url":"https://api.github.com/users/EricChea/gists{/gist_id}","starred_url":"https://api.github.com/users/EricChea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricChea/subscriptions","organizations_url":"https://api.github.com/users/EricChea/orgs","repos_url":"https://api.github.com/users/EricChea/repos","events_url":"https://api.github.com/users/EricChea/events{/privacy}","received_events_url":"https://api.github.com/users/EricChea/received_events","type":"User","site_admin":false},"repo":{"id":121926971,"name":"pandas","full_name":"EricChea/pandas","owner":{"login":"EricChea","id":5069128,"avatar_url":"https://avatars2.githubusercontent.com/u/5069128?v=4","gravatar_id":"","url":"https://api.github.com/users/EricChea","html_url":"https://github.com/EricChea","followers_url":"https://api.github.com/users/EricChea/followers","following_url":"https://api.github.com/users/EricChea/following{/other_user}","gists_url":"https://api.github.com/users/EricChea/gists{/gist_id}","starred_url":"https://api.github.com/users/EricChea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricChea/subscriptions","organizations_url":"https://api.github.com/users/EricChea/orgs","repos_url":"https://api.github.com/users/EricChea/repos","events_url":"https://api.github.com/users/EricChea/events{/privacy}","received_events_url":"https://api.github.com/users/EricChea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricChea/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/EricChea/pandas","forks_url":"https://api.github.com/repos/EricChea/pandas/forks","keys_url":"https://api.github.com/repos/EricChea/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricChea/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricChea/pandas/teams","hooks_url":"https://api.github.com/repos/EricChea/pandas/hooks","issue_events_url":"https://api.github.com/repos/EricChea/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/EricChea/pandas/events","assignees_url":"https://api.github.com/repos/EricChea/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/EricChea/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/EricChea/pandas/tags","blobs_url":"https://api.github.com/repos/EricChea/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricChea/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricChea/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricChea/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricChea/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/EricChea/pandas/languages","stargazers_url":"https://api.github.com/repos/EricChea/pandas/stargazers","contributors_url":"https://api.github.com/repos/EricChea/pandas/contributors","subscribers_url":"https://api.github.com/repos/EricChea/pandas/subscribers","subscription_url":"https://api.github.com/repos/EricChea/pandas/subscription","commits_url":"https://api.github.com/repos/EricChea/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricChea/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricChea/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricChea/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricChea/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/EricChea/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricChea/pandas/merges","archive_url":"https://api.github.com/repos/EricChea/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricChea/pandas/downloads","issues_url":"https://api.github.com/repos/EricChea/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/EricChea/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/EricChea/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/EricChea/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricChea/pandas/labels{/name}","releases_url":"https://api.github.com/repos/EricChea/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/EricChea/pandas/deployments","created_at":"2018-02-18T06:52:25Z","updated_at":"2018-02-18T06:52:32Z","pushed_at":"2018-02-20T01:35:50Z","git_url":"git://github.com/EricChea/pandas.git","ssh_url":"git@github.com:EricChea/pandas.git","clone_url":"https://github.com/EricChea/pandas.git","svn_url":"https://github.com/EricChea/pandas","homepage":"http://pandas.pydata.org","size":116565,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"5bb5e33ffe01eb7c82e8eed327f8745cfacdaada","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-02-19T23:46:20Z","pushed_at":"2018-02-20T01:35:52Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":116719,"stargazers_count":12939,"watchers_count":12939,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5017,"mirror_url":null,"archived":false,"open_issues_count":2350,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5017,"open_issues":2350,"watchers":12939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19751"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19751"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19751/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19751/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/699805198f7e31e3f6787b612ec507dd71c056a6"}},"author_association":"NONE"}}
{"actor":{"display_login":"EricChea"}}