{"action":"created","comment":{"url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/comments/180252225","pull_request_review_id":110642037,"id":180252225,"diff_hunk":"@@ -0,0 +1,28 @@\n+# frozen_string_literal: true\n+\n+require \"rails_helper\"\n+\n+RSpec.describe SearchHelper, type: :helper do\n+","path":"spec/helpers/search_helper_spec.rb","position":6,"original_position":6,"commit_id":"f903c1f293bb0878db81ef253ab9dadf1dfdc4e4","original_commit_id":"f903c1f293bb0878db81ef253ab9dadf1dfdc4e4","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.","created_at":"2018-04-09T22:43:01Z","updated_at":"2018-04-09T22:43:01Z","html_url":"https://github.com/ODNZSL/nzsl-online/pull/158#discussion_r180252225","pull_request_url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/comments/180252225"},"html":{"href":"https://github.com/ODNZSL/nzsl-online/pull/158#discussion_r180252225"},"pull_request":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158","id":180446949,"html_url":"https://github.com/ODNZSL/nzsl-online/pull/158","diff_url":"https://github.com/ODNZSL/nzsl-online/pull/158.diff","patch_url":"https://github.com/ODNZSL/nzsl-online/pull/158.patch","issue_url":"https://api.github.com/repos/ODNZSL/nzsl-online/issues/158","number":158,"state":"open","locked":false,"title":"Bugfix/zendesk 296 body location in advanced search not working","user":{"login":"Rabid-Dan","id":33815339,"avatar_url":"https://avatars0.githubusercontent.com/u/33815339?v=4","gravatar_id":"","url":"https://api.github.com/users/Rabid-Dan","html_url":"https://github.com/Rabid-Dan","followers_url":"https://api.github.com/users/Rabid-Dan/followers","following_url":"https://api.github.com/users/Rabid-Dan/following{/other_user}","gists_url":"https://api.github.com/users/Rabid-Dan/gists{/gist_id}","starred_url":"https://api.github.com/users/Rabid-Dan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rabid-Dan/subscriptions","organizations_url":"https://api.github.com/users/Rabid-Dan/orgs","repos_url":"https://api.github.com/users/Rabid-Dan/repos","events_url":"https://api.github.com/users/Rabid-Dan/events{/privacy}","received_events_url":"https://api.github.com/users/Rabid-Dan/received_events","type":"User","site_admin":false},"body":"A bug is currently effecting the \"body\", \"arm\", and \"hand\" filters in the body location advanced search options menu.\r\nSelecting these and searching for any term adds the \"top of head\", \"eyes\" and \"nose\" options as filters instead. This is due to the javascript looking for the presence of a `main_image` class on these particular search option while assigning query params but not finding one. \r\n\r\nIt doesn't find one because that class is dynamically assigned in `search_helper.rb` and the lack of any spacing between the default classes and the dynamically assigned class is causing `main_image` to be chained onto the end of the last default class (i.e instead of the classes assigned being `image rounded main_image` they are `image roundedmain_image` meaning it has neither `rounded` or `main_image` and instead has `roundedmain_image`).\r\n\r\nThis fix adds a space to the end of the default class string and a comment explaining why it is necessary. It also lightly refactors the `classes_for_sign_attribute` method.\r\nI've chosen to add the beginnings of a search helper spec as well with some basic value assertions for the current cases in that method. \r\nHopefully this will provide some extra context in the event that someone in the future decides to ignore the commenting and remove the space from the default classes string.","created_at":"2018-04-09T22:42:54Z","updated_at":"2018-04-09T22:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a0db31f2f0cd606887cc41bbf03fc19ab1df6d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158/commits","review_comments_url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158/comments","review_comment_url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ODNZSL/nzsl-online/issues/158/comments","statuses_url":"https://api.github.com/repos/ODNZSL/nzsl-online/statuses/f903c1f293bb0878db81ef253ab9dadf1dfdc4e4","head":{"label":"rabid:bugfix/zendesk-296-body-location-in-advanced-search-not-working","ref":"bugfix/zendesk-296-body-location-in-advanced-search-not-working","sha":"f903c1f293bb0878db81ef253ab9dadf1dfdc4e4","user":{"login":"rabid","id":1941990,"avatar_url":"https://avatars0.githubusercontent.com/u/1941990?v=4","gravatar_id":"","url":"https://api.github.com/users/rabid","html_url":"https://github.com/rabid","followers_url":"https://api.github.com/users/rabid/followers","following_url":"https://api.github.com/users/rabid/following{/other_user}","gists_url":"https://api.github.com/users/rabid/gists{/gist_id}","starred_url":"https://api.github.com/users/rabid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabid/subscriptions","organizations_url":"https://api.github.com/users/rabid/orgs","repos_url":"https://api.github.com/users/rabid/repos","events_url":"https://api.github.com/users/rabid/events{/privacy}","received_events_url":"https://api.github.com/users/rabid/received_events","type":"Organization","site_admin":false},"repo":{"id":115059780,"name":"nzsl-online","full_name":"rabid/nzsl-online","owner":{"login":"rabid","id":1941990,"avatar_url":"https://avatars0.githubusercontent.com/u/1941990?v=4","gravatar_id":"","url":"https://api.github.com/users/rabid","html_url":"https://github.com/rabid","followers_url":"https://api.github.com/users/rabid/followers","following_url":"https://api.github.com/users/rabid/following{/other_user}","gists_url":"https://api.github.com/users/rabid/gists{/gist_id}","starred_url":"https://api.github.com/users/rabid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabid/subscriptions","organizations_url":"https://api.github.com/users/rabid/orgs","repos_url":"https://api.github.com/users/rabid/repos","events_url":"https://api.github.com/users/rabid/events{/privacy}","received_events_url":"https://api.github.com/users/rabid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rabid/nzsl-online","description":"New Zealand Sign Language Dictionary","fork":true,"url":"https://api.github.com/repos/rabid/nzsl-online","forks_url":"https://api.github.com/repos/rabid/nzsl-online/forks","keys_url":"https://api.github.com/repos/rabid/nzsl-online/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabid/nzsl-online/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabid/nzsl-online/teams","hooks_url":"https://api.github.com/repos/rabid/nzsl-online/hooks","issue_events_url":"https://api.github.com/repos/rabid/nzsl-online/issues/events{/number}","events_url":"https://api.github.com/repos/rabid/nzsl-online/events","assignees_url":"https://api.github.com/repos/rabid/nzsl-online/assignees{/user}","branches_url":"https://api.github.com/repos/rabid/nzsl-online/branches{/branch}","tags_url":"https://api.github.com/repos/rabid/nzsl-online/tags","blobs_url":"https://api.github.com/repos/rabid/nzsl-online/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabid/nzsl-online/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabid/nzsl-online/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabid/nzsl-online/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabid/nzsl-online/statuses/{sha}","languages_url":"https://api.github.com/repos/rabid/nzsl-online/languages","stargazers_url":"https://api.github.com/repos/rabid/nzsl-online/stargazers","contributors_url":"https://api.github.com/repos/rabid/nzsl-online/contributors","subscribers_url":"https://api.github.com/repos/rabid/nzsl-online/subscribers","subscription_url":"https://api.github.com/repos/rabid/nzsl-online/subscription","commits_url":"https://api.github.com/repos/rabid/nzsl-online/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabid/nzsl-online/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabid/nzsl-online/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabid/nzsl-online/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabid/nzsl-online/contents/{+path}","compare_url":"https://api.github.com/repos/rabid/nzsl-online/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabid/nzsl-online/merges","archive_url":"https://api.github.com/repos/rabid/nzsl-online/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabid/nzsl-online/downloads","issues_url":"https://api.github.com/repos/rabid/nzsl-online/issues{/number}","pulls_url":"https://api.github.com/repos/rabid/nzsl-online/pulls{/number}","milestones_url":"https://api.github.com/repos/rabid/nzsl-online/milestones{/number}","notifications_url":"https://api.github.com/repos/rabid/nzsl-online/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabid/nzsl-online/labels{/name}","releases_url":"https://api.github.com/repos/rabid/nzsl-online/releases{/id}","deployments_url":"https://api.github.com/repos/rabid/nzsl-online/deployments","created_at":"2017-12-22T00:40:54Z","updated_at":"2018-04-09T20:43:02Z","pushed_at":"2018-04-09T22:26:04Z","git_url":"git://github.com/rabid/nzsl-online.git","ssh_url":"git@github.com:rabid/nzsl-online.git","clone_url":"https://github.com/rabid/nzsl-online.git","svn_url":"https://github.com/rabid/nzsl-online","homepage":null,"size":15346,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"ODNZSL:staging","ref":"staging","sha":"c13a84c97f4b575cab1472deb7a64c7897397acb","user":{"login":"ODNZSL","id":6156419,"avatar_url":"https://avatars1.githubusercontent.com/u/6156419?v=4","gravatar_id":"","url":"https://api.github.com/users/ODNZSL","html_url":"https://github.com/ODNZSL","followers_url":"https://api.github.com/users/ODNZSL/followers","following_url":"https://api.github.com/users/ODNZSL/following{/other_user}","gists_url":"https://api.github.com/users/ODNZSL/gists{/gist_id}","starred_url":"https://api.github.com/users/ODNZSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ODNZSL/subscriptions","organizations_url":"https://api.github.com/users/ODNZSL/orgs","repos_url":"https://api.github.com/users/ODNZSL/repos","events_url":"https://api.github.com/users/ODNZSL/events{/privacy}","received_events_url":"https://api.github.com/users/ODNZSL/received_events","type":"Organization","site_admin":false},"repo":{"id":93797817,"name":"nzsl-online","full_name":"ODNZSL/nzsl-online","owner":{"login":"ODNZSL","id":6156419,"avatar_url":"https://avatars1.githubusercontent.com/u/6156419?v=4","gravatar_id":"","url":"https://api.github.com/users/ODNZSL","html_url":"https://github.com/ODNZSL","followers_url":"https://api.github.com/users/ODNZSL/followers","following_url":"https://api.github.com/users/ODNZSL/following{/other_user}","gists_url":"https://api.github.com/users/ODNZSL/gists{/gist_id}","starred_url":"https://api.github.com/users/ODNZSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ODNZSL/subscriptions","organizations_url":"https://api.github.com/users/ODNZSL/orgs","repos_url":"https://api.github.com/users/ODNZSL/repos","events_url":"https://api.github.com/users/ODNZSL/events{/privacy}","received_events_url":"https://api.github.com/users/ODNZSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ODNZSL/nzsl-online","description":"New Zealand Sign Language Dictionary","fork":false,"url":"https://api.github.com/repos/ODNZSL/nzsl-online","forks_url":"https://api.github.com/repos/ODNZSL/nzsl-online/forks","keys_url":"https://api.github.com/repos/ODNZSL/nzsl-online/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ODNZSL/nzsl-online/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ODNZSL/nzsl-online/teams","hooks_url":"https://api.github.com/repos/ODNZSL/nzsl-online/hooks","issue_events_url":"https://api.github.com/repos/ODNZSL/nzsl-online/issues/events{/number}","events_url":"https://api.github.com/repos/ODNZSL/nzsl-online/events","assignees_url":"https://api.github.com/repos/ODNZSL/nzsl-online/assignees{/user}","branches_url":"https://api.github.com/repos/ODNZSL/nzsl-online/branches{/branch}","tags_url":"https://api.github.com/repos/ODNZSL/nzsl-online/tags","blobs_url":"https://api.github.com/repos/ODNZSL/nzsl-online/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ODNZSL/nzsl-online/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ODNZSL/nzsl-online/git/refs{/sha}","trees_url":"https://api.github.com/repos/ODNZSL/nzsl-online/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ODNZSL/nzsl-online/statuses/{sha}","languages_url":"https://api.github.com/repos/ODNZSL/nzsl-online/languages","stargazers_url":"https://api.github.com/repos/ODNZSL/nzsl-online/stargazers","contributors_url":"https://api.github.com/repos/ODNZSL/nzsl-online/contributors","subscribers_url":"https://api.github.com/repos/ODNZSL/nzsl-online/subscribers","subscription_url":"https://api.github.com/repos/ODNZSL/nzsl-online/subscription","commits_url":"https://api.github.com/repos/ODNZSL/nzsl-online/commits{/sha}","git_commits_url":"https://api.github.com/repos/ODNZSL/nzsl-online/git/commits{/sha}","comments_url":"https://api.github.com/repos/ODNZSL/nzsl-online/comments{/number}","issue_comment_url":"https://api.github.com/repos/ODNZSL/nzsl-online/issues/comments{/number}","contents_url":"https://api.github.com/repos/ODNZSL/nzsl-online/contents/{+path}","compare_url":"https://api.github.com/repos/ODNZSL/nzsl-online/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ODNZSL/nzsl-online/merges","archive_url":"https://api.github.com/repos/ODNZSL/nzsl-online/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ODNZSL/nzsl-online/downloads","issues_url":"https://api.github.com/repos/ODNZSL/nzsl-online/issues{/number}","pulls_url":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls{/number}","milestones_url":"https://api.github.com/repos/ODNZSL/nzsl-online/milestones{/number}","notifications_url":"https://api.github.com/repos/ODNZSL/nzsl-online/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ODNZSL/nzsl-online/labels{/name}","releases_url":"https://api.github.com/repos/ODNZSL/nzsl-online/releases{/id}","deployments_url":"https://api.github.com/repos/ODNZSL/nzsl-online/deployments","created_at":"2017-06-08T22:47:00Z","updated_at":"2018-03-27T21:56:14Z","pushed_at":"2018-04-09T22:42:55Z","git_url":"git://github.com/ODNZSL/nzsl-online.git","ssh_url":"git@github.com:ODNZSL/nzsl-online.git","clone_url":"https://github.com/ODNZSL/nzsl-online.git","svn_url":"https://github.com/ODNZSL/nzsl-online","homepage":null,"size":15347,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":5,"open_issues":7,"watchers":5,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158"},"html":{"href":"https://github.com/ODNZSL/nzsl-online/pull/158"},"issue":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/issues/158"},"comments":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/ODNZSL/nzsl-online/statuses/f903c1f293bb0878db81ef253ab9dadf1dfdc4e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}