{"action":"created","comment":{"url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/comments/167608039","pull_request_review_id":95850630,"id":167608039,"diff_hunk":"@@ -1683,53 +1642,24 @@ public boolean onSingleTapConfirmed(MotionEvent e) {\n \t\t\t\t\t\t\t200, 100, 0);\n \t\t\t\t\tgv.dispatchTouchEvent(ev);\n \t\t\t\t} else { // other devices\n-\t\t\t\t\tint first = gv.getFirstVisiblePosition();\n-\t\t\t\t\tint total = itemsArray.size();\n-\t\t\t\t\tint last = gv.getLastVisiblePosition();\n-\t\t\t\t\tif (total == last + 1)\n-\t\t\t\t\t\treturn true;\n-\t\t\t\t\tint target = last + 1;\n-\t\t\t\t\tif (target > (total - 1))\n-\t\t\t\t\t\ttarget = total - 1;\n-\t\t\t\t\tRepeatedDownScroll ds = new RepeatedDownScroll();\n-\t\t\t\t\tds.doIt(first, target, 0);\n+\t\t\t\t\tif (!prefs.getBoolean(\"doNotHyph\", true)) {\n+\t\t\t\t\t\tsetItemsHeights(gv);","path":"app/src/main/java/com/gacode/relaunchx/ReLaunch.java","position":137,"original_position":137,"commit_id":"3d853e3d6ba6f962ec8b5a9069bf1a19ae7d447d","original_commit_id":"3d853e3d6ba6f962ec8b5a9069bf1a19ae7d447d","user":{"login":"jpawz","id":25390689,"avatar_url":"https://avatars3.githubusercontent.com/u/25390689?v=4","gravatar_id":"","url":"https://api.github.com/users/jpawz","html_url":"https://github.com/jpawz","followers_url":"https://api.github.com/users/jpawz/followers","following_url":"https://api.github.com/users/jpawz/following{/other_user}","gists_url":"https://api.github.com/users/jpawz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpawz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpawz/subscriptions","organizations_url":"https://api.github.com/users/jpawz/orgs","repos_url":"https://api.github.com/users/jpawz/repos","events_url":"https://api.github.com/users/jpawz/events{/privacy}","received_events_url":"https://api.github.com/users/jpawz/received_events","type":"User","site_admin":false},"body":"I know it, and that's another reason why I found scroll jump functionality not very helpful. The same situation happens when long press: jumps to the very end. But then pgup scrolls to beggining (or at least it should).","created_at":"2018-02-12T16:23:55Z","updated_at":"2018-02-12T16:23:55Z","html_url":"https://github.com/Leszek111/ReLaunchX/pull/9#discussion_r167608039","pull_request_url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/comments/167608039"},"html":{"href":"https://github.com/Leszek111/ReLaunchX/pull/9#discussion_r167608039"},"pull_request":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9"}},"in_reply_to_id":167392861},"pull_request":{"url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9","id":166902936,"html_url":"https://github.com/Leszek111/ReLaunchX/pull/9","diff_url":"https://github.com/Leszek111/ReLaunchX/pull/9.diff","patch_url":"https://github.com/Leszek111/ReLaunchX/pull/9.patch","issue_url":"https://api.github.com/repos/Leszek111/ReLaunchX/issues/9","number":9,"state":"closed","locked":false,"title":"More accurate scrolling with buttons.","user":{"login":"jpawz","id":25390689,"avatar_url":"https://avatars3.githubusercontent.com/u/25390689?v=4","gravatar_id":"","url":"https://api.github.com/users/jpawz","html_url":"https://github.com/jpawz","followers_url":"https://api.github.com/users/jpawz/followers","following_url":"https://api.github.com/users/jpawz/following{/other_user}","gists_url":"https://api.github.com/users/jpawz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpawz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpawz/subscriptions","organizations_url":"https://api.github.com/users/jpawz/orgs","repos_url":"https://api.github.com/users/jpawz/repos","events_url":"https://api.github.com/users/jpawz/events{/privacy}","received_events_url":"https://api.github.com/users/jpawz/received_events","type":"User","site_admin":false},"body":"When GridView items can have different heights (unchecked preference\r\n\"Single line output mode\"), scrolling up with button should calculate\r\ntarget top item based on previous items heights. Unfortunately do to\r\nviews recycling often upscrolling skips several items.","created_at":"2018-02-02T21:03:51Z","updated_at":"2018-02-12T16:23:55Z","closed_at":"2018-02-10T12:38:08Z","merged_at":null,"merge_commit_sha":"615a63637df232a99b800bb33cb5380b1a79195b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Leszek111/ReLaunchX/issues/9/comments","statuses_url":"https://api.github.com/repos/Leszek111/ReLaunchX/statuses/3d853e3d6ba6f962ec8b5a9069bf1a19ae7d447d","head":{"label":"jpawz:feat-better-scroll","ref":"feat-better-scroll","sha":"3d853e3d6ba6f962ec8b5a9069bf1a19ae7d447d","user":{"login":"jpawz","id":25390689,"avatar_url":"https://avatars3.githubusercontent.com/u/25390689?v=4","gravatar_id":"","url":"https://api.github.com/users/jpawz","html_url":"https://github.com/jpawz","followers_url":"https://api.github.com/users/jpawz/followers","following_url":"https://api.github.com/users/jpawz/following{/other_user}","gists_url":"https://api.github.com/users/jpawz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpawz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpawz/subscriptions","organizations_url":"https://api.github.com/users/jpawz/orgs","repos_url":"https://api.github.com/users/jpawz/repos","events_url":"https://api.github.com/users/jpawz/events{/privacy}","received_events_url":"https://api.github.com/users/jpawz/received_events","type":"User","site_admin":false},"repo":{"id":118003188,"name":"ReLaunchX","full_name":"jpawz/ReLaunchX","owner":{"login":"jpawz","id":25390689,"avatar_url":"https://avatars3.githubusercontent.com/u/25390689?v=4","gravatar_id":"","url":"https://api.github.com/users/jpawz","html_url":"https://github.com/jpawz","followers_url":"https://api.github.com/users/jpawz/followers","following_url":"https://api.github.com/users/jpawz/following{/other_user}","gists_url":"https://api.github.com/users/jpawz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpawz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpawz/subscriptions","organizations_url":"https://api.github.com/users/jpawz/orgs","repos_url":"https://api.github.com/users/jpawz/repos","events_url":"https://api.github.com/users/jpawz/events{/privacy}","received_events_url":"https://api.github.com/users/jpawz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpawz/ReLaunchX","description":"Filemanager / launcher for Onyx Boox Max (Nook Simple Touch, etc.)","fork":true,"url":"https://api.github.com/repos/jpawz/ReLaunchX","forks_url":"https://api.github.com/repos/jpawz/ReLaunchX/forks","keys_url":"https://api.github.com/repos/jpawz/ReLaunchX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpawz/ReLaunchX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpawz/ReLaunchX/teams","hooks_url":"https://api.github.com/repos/jpawz/ReLaunchX/hooks","issue_events_url":"https://api.github.com/repos/jpawz/ReLaunchX/issues/events{/number}","events_url":"https://api.github.com/repos/jpawz/ReLaunchX/events","assignees_url":"https://api.github.com/repos/jpawz/ReLaunchX/assignees{/user}","branches_url":"https://api.github.com/repos/jpawz/ReLaunchX/branches{/branch}","tags_url":"https://api.github.com/repos/jpawz/ReLaunchX/tags","blobs_url":"https://api.github.com/repos/jpawz/ReLaunchX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpawz/ReLaunchX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpawz/ReLaunchX/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpawz/ReLaunchX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpawz/ReLaunchX/statuses/{sha}","languages_url":"https://api.github.com/repos/jpawz/ReLaunchX/languages","stargazers_url":"https://api.github.com/repos/jpawz/ReLaunchX/stargazers","contributors_url":"https://api.github.com/repos/jpawz/ReLaunchX/contributors","subscribers_url":"https://api.github.com/repos/jpawz/ReLaunchX/subscribers","subscription_url":"https://api.github.com/repos/jpawz/ReLaunchX/subscription","commits_url":"https://api.github.com/repos/jpawz/ReLaunchX/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpawz/ReLaunchX/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpawz/ReLaunchX/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpawz/ReLaunchX/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpawz/ReLaunchX/contents/{+path}","compare_url":"https://api.github.com/repos/jpawz/ReLaunchX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpawz/ReLaunchX/merges","archive_url":"https://api.github.com/repos/jpawz/ReLaunchX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpawz/ReLaunchX/downloads","issues_url":"https://api.github.com/repos/jpawz/ReLaunchX/issues{/number}","pulls_url":"https://api.github.com/repos/jpawz/ReLaunchX/pulls{/number}","milestones_url":"https://api.github.com/repos/jpawz/ReLaunchX/milestones{/number}","notifications_url":"https://api.github.com/repos/jpawz/ReLaunchX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpawz/ReLaunchX/labels{/name}","releases_url":"https://api.github.com/repos/jpawz/ReLaunchX/releases{/id}","deployments_url":"https://api.github.com/repos/jpawz/ReLaunchX/deployments","created_at":"2018-01-18T15:46:55Z","updated_at":"2018-01-18T15:46:57Z","pushed_at":"2018-02-02T21:01:54Z","git_url":"git://github.com/jpawz/ReLaunchX.git","ssh_url":"git@github.com:jpawz/ReLaunchX.git","clone_url":"https://github.com/jpawz/ReLaunchX.git","svn_url":"https://github.com/jpawz/ReLaunchX","homepage":"","size":2055,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Leszek111:master","ref":"master","sha":"d0e9cc9352dc120aa7355f47453869bddcbbc454","user":{"login":"Leszek111","id":22171778,"avatar_url":"https://avatars0.githubusercontent.com/u/22171778?v=4","gravatar_id":"","url":"https://api.github.com/users/Leszek111","html_url":"https://github.com/Leszek111","followers_url":"https://api.github.com/users/Leszek111/followers","following_url":"https://api.github.com/users/Leszek111/following{/other_user}","gists_url":"https://api.github.com/users/Leszek111/gists{/gist_id}","starred_url":"https://api.github.com/users/Leszek111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leszek111/subscriptions","organizations_url":"https://api.github.com/users/Leszek111/orgs","repos_url":"https://api.github.com/users/Leszek111/repos","events_url":"https://api.github.com/users/Leszek111/events{/privacy}","received_events_url":"https://api.github.com/users/Leszek111/received_events","type":"User","site_admin":false},"repo":{"id":83361936,"name":"ReLaunchX","full_name":"Leszek111/ReLaunchX","owner":{"login":"Leszek111","id":22171778,"avatar_url":"https://avatars0.githubusercontent.com/u/22171778?v=4","gravatar_id":"","url":"https://api.github.com/users/Leszek111","html_url":"https://github.com/Leszek111","followers_url":"https://api.github.com/users/Leszek111/followers","following_url":"https://api.github.com/users/Leszek111/following{/other_user}","gists_url":"https://api.github.com/users/Leszek111/gists{/gist_id}","starred_url":"https://api.github.com/users/Leszek111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leszek111/subscriptions","organizations_url":"https://api.github.com/users/Leszek111/orgs","repos_url":"https://api.github.com/users/Leszek111/repos","events_url":"https://api.github.com/users/Leszek111/events{/privacy}","received_events_url":"https://api.github.com/users/Leszek111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Leszek111/ReLaunchX","description":"Filemanager / launcher for Onyx Boox Max (Nook Simple Touch, etc.)","fork":true,"url":"https://api.github.com/repos/Leszek111/ReLaunchX","forks_url":"https://api.github.com/repos/Leszek111/ReLaunchX/forks","keys_url":"https://api.github.com/repos/Leszek111/ReLaunchX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Leszek111/ReLaunchX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Leszek111/ReLaunchX/teams","hooks_url":"https://api.github.com/repos/Leszek111/ReLaunchX/hooks","issue_events_url":"https://api.github.com/repos/Leszek111/ReLaunchX/issues/events{/number}","events_url":"https://api.github.com/repos/Leszek111/ReLaunchX/events","assignees_url":"https://api.github.com/repos/Leszek111/ReLaunchX/assignees{/user}","branches_url":"https://api.github.com/repos/Leszek111/ReLaunchX/branches{/branch}","tags_url":"https://api.github.com/repos/Leszek111/ReLaunchX/tags","blobs_url":"https://api.github.com/repos/Leszek111/ReLaunchX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Leszek111/ReLaunchX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Leszek111/ReLaunchX/git/refs{/sha}","trees_url":"https://api.github.com/repos/Leszek111/ReLaunchX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Leszek111/ReLaunchX/statuses/{sha}","languages_url":"https://api.github.com/repos/Leszek111/ReLaunchX/languages","stargazers_url":"https://api.github.com/repos/Leszek111/ReLaunchX/stargazers","contributors_url":"https://api.github.com/repos/Leszek111/ReLaunchX/contributors","subscribers_url":"https://api.github.com/repos/Leszek111/ReLaunchX/subscribers","subscription_url":"https://api.github.com/repos/Leszek111/ReLaunchX/subscription","commits_url":"https://api.github.com/repos/Leszek111/ReLaunchX/commits{/sha}","git_commits_url":"https://api.github.com/repos/Leszek111/ReLaunchX/git/commits{/sha}","comments_url":"https://api.github.com/repos/Leszek111/ReLaunchX/comments{/number}","issue_comment_url":"https://api.github.com/repos/Leszek111/ReLaunchX/issues/comments{/number}","contents_url":"https://api.github.com/repos/Leszek111/ReLaunchX/contents/{+path}","compare_url":"https://api.github.com/repos/Leszek111/ReLaunchX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Leszek111/ReLaunchX/merges","archive_url":"https://api.github.com/repos/Leszek111/ReLaunchX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Leszek111/ReLaunchX/downloads","issues_url":"https://api.github.com/repos/Leszek111/ReLaunchX/issues{/number}","pulls_url":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls{/number}","milestones_url":"https://api.github.com/repos/Leszek111/ReLaunchX/milestones{/number}","notifications_url":"https://api.github.com/repos/Leszek111/ReLaunchX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Leszek111/ReLaunchX/labels{/name}","releases_url":"https://api.github.com/repos/Leszek111/ReLaunchX/releases{/id}","deployments_url":"https://api.github.com/repos/Leszek111/ReLaunchX/deployments","created_at":"2017-02-27T22:08:14Z","updated_at":"2018-02-04T09:48:45Z","pushed_at":"2018-02-10T12:11:57Z","git_url":"git://github.com/Leszek111/ReLaunchX.git","ssh_url":"git@github.com:Leszek111/ReLaunchX.git","clone_url":"https://github.com/Leszek111/ReLaunchX.git","svn_url":"https://github.com/Leszek111/ReLaunchX","homepage":"","size":2673,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":1,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9"},"html":{"href":"https://github.com/Leszek111/ReLaunchX/pull/9"},"issue":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/issues/9"},"comments":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Leszek111/ReLaunchX/statuses/3d853e3d6ba6f962ec8b5a9069bf1a19ae7d447d"}},"author_association":"NONE"}}
{"actor":{"display_login":"jpawz"}}