{"action":"created","issue":{"url":"https://api.github.com/repos/opencog/link-grammar/issues/741","repository_url":"https://api.github.com/repos/opencog/link-grammar","labels_url":"https://api.github.com/repos/opencog/link-grammar/issues/741/labels{/name}","comments_url":"https://api.github.com/repos/opencog/link-grammar/issues/741/comments","events_url":"https://api.github.com/repos/opencog/link-grammar/issues/741/events","html_url":"https://github.com/opencog/link-grammar/issues/741","id":315010603,"number":741,"title":"Add official word-graph display support","user":{"login":"ampli","id":879514,"avatar_url":"https://avatars3.githubusercontent.com/u/879514?v=4","gravatar_id":"","url":"https://api.github.com/users/ampli","html_url":"https://github.com/ampli","followers_url":"https://api.github.com/users/ampli/followers","following_url":"https://api.github.com/users/ampli/following{/other_user}","gists_url":"https://api.github.com/users/ampli/gists{/gist_id}","starred_url":"https://api.github.com/users/ampli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampli/subscriptions","organizations_url":"https://api.github.com/users/ampli/orgs","repos_url":"https://api.github.com/users/ampli/repos","events_url":"https://api.github.com/users/ampli/events{/privacy}","received_events_url":"https://api.github.com/users/ampli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-17T11:04:05Z","updated_at":"2018-04-23T20:17:18Z","closed_at":null,"author_association":"MEMBER","body":"The main reason why I didn't propose to include a default support for word-graph display is that  the library then includes code that issues exec/popen, a thing that potentially makes it \"less secure\".\r\nThe program is `dot`, and on Windows also `PhotoViewer`, and `link-parser` can invoke them by using an argument or a `!` command-line.\r\n\r\nHowever, many programs, e.g. `git`, include code to execute some programs (like `diff` or an editor), and even arbitrary programs controlled by environment variables like `EDITOR` and `PAGER`, that are searched in PATH. So there is actually nothing special in allowing a similar thing for `link-parser` (or any parser script that implements reading commands from its input).\r\nIn addition, if one for some reason wants to use an unmodified `link-parser` as a web service, the common practice is to discard environment variables (that should not be controllable by the Internet user anyway) and filter possible input (to exclude lines starting with `!` in that case) so there is also no problem here.\r\n\r\nAnother reason is that `dot` used to include double-free errors that randomly caused it to crash. But this may not a good enough reason. I also checked it with version 2.40.1 (Fedora 27) and it didn't crash on any sentence in the ru/en batches, so maybe this problem got fixed in recent versions.\r\n\r\nMy proposal:\r\n1. Enable word-graph display by default in `configure`.\r\n2. Add a String user variable to control it instead of the current `!test=wg:flags`. The name `wordgraph-display` is too long for displaying in `!variables`, so maybe it can be `wg-display` (e.g.: `!wg-display=s`).\r\n"},"comment":{"url":"https://api.github.com/repos/opencog/link-grammar/issues/comments/383708557","html_url":"https://github.com/opencog/link-grammar/issues/741#issuecomment-383708557","issue_url":"https://api.github.com/repos/opencog/link-grammar/issues/741","id":383708557,"user":{"login":"linas","id":94368,"avatar_url":"https://avatars2.githubusercontent.com/u/94368?v=4","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T20:17:18Z","updated_at":"2018-04-23T20:17:18Z","author_association":"OWNER","body":"I guess that's OK. Does this require new compile-time dependencies?"}}
{"actor":{"display_login":"linas"}}