{"action":"closed","number":3631,"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/3631","id":123499335,"html_url":"https://github.com/open-mpi/ompi/pull/3631","diff_url":"https://github.com/open-mpi/ompi/pull/3631.diff","patch_url":"https://github.com/open-mpi/ompi/pull/3631.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/3631","number":3631,"state":"closed","locked":false,"title":"WIP: consolidate some version checking code","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars2.githubusercontent.com/u/617316?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"body":"Based on conversations week of 29 May 2017:\r\n\r\n- we note that there's 2 separate autogen version checking codes: in autogen.pl and make_dist_tarball\r\n- regardless of decisions about what to do w.r.t. minimum enforced versions, it would be good to consolidate these codes together\r\n- autogen.pl currently checks for versions in a \"greater than or equal to\" manner, make_dist_tarball checks for \"exactly equal to\".  So the  consolidated code will need to be able to handle both.\r\n\r\nThis first cut is a WIP.  I'm not 100% happy with it yet, but I'm out of time for this window, and need to save it somewhere to return to it later.\r\n\r\nI added --autotools-eq=X and --autotools-ge=X options to autogen.pl, which take an arg of the form \"ac:X,am:X,lt:X\" where you specify the versions you want checked.  The thought was that make_dist_tarball could sepcify -eq or -ge (depending on whether --highok was specified or not) and specify the exact versions that it was looking for.\r\n\r\nThis commit does *not* adjust the default versions that autogen.pl is looking for, nor does it change the default \"greater than or equal to\" behavior.\r\n\r\nI put a comment in autogen.pl about what might be a better set of CLI options.  I made an obvious syntax error after the comment so that Future Jeff will be forced to find the comment and pick up from there.  :-)\r\n\r\nNote that the current stuff I added in this commit does not check for m4 and flex versions in autogen.pl -- but make_dist_tarball checks for these things (the flex version was quite important to distribution tarballs over time).  Need to expand to include those checks (not sure why we're checking for m4 versions, though...?  That sort of thing should be covered by Automake).\r\n\r\nNote that it is a separate question as to whether we want make_dist_tarball and autogen.pl to -- by default -- look for the same versions (i.e., and therefore potentially only have the versions listed in one place, not two).  If the versions in one are updated to match the other, note that it would probably be good to put comments in both places reminding Future Editors to change *both* places. \r\n\r\nSigned-off-by: Jeff Squyres <jsquyres@cisco.com>","created_at":"2017-06-01T13:30:09Z","updated_at":"2018-03-21T15:43:24Z","closed_at":"2018-03-21T15:43:24Z","merged_at":null,"merge_commit_sha":"e598af7d3d07a9cc653099eb396e07dbb16fa10d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":353324085,"url":"https://api.github.com/repos/open-mpi/ompi/labels/%E2%9A%A0%EF%B8%8F%20WIP-DNM!","name":"⚠️ WIP-DNM!","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/3631/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/3631/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/3631/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/2d68aeaed07a3e4a2f07b9356c051110894c7061","head":{"label":"jsquyres:pr/consolidate-version-checking-script-code","ref":"pr/consolidate-version-checking-script-code","sha":"2d68aeaed07a3e4a2f07b9356c051110894c7061","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars2.githubusercontent.com/u/617316?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"repo":{"id":24734558,"name":"ompi","full_name":"jsquyres/ompi","owner":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars2.githubusercontent.com/u/617316?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsquyres/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/jsquyres/ompi","forks_url":"https://api.github.com/repos/jsquyres/ompi/forks","keys_url":"https://api.github.com/repos/jsquyres/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsquyres/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsquyres/ompi/teams","hooks_url":"https://api.github.com/repos/jsquyres/ompi/hooks","issue_events_url":"https://api.github.com/repos/jsquyres/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/jsquyres/ompi/events","assignees_url":"https://api.github.com/repos/jsquyres/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/jsquyres/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/jsquyres/ompi/tags","blobs_url":"https://api.github.com/repos/jsquyres/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsquyres/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsquyres/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsquyres/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsquyres/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/jsquyres/ompi/languages","stargazers_url":"https://api.github.com/repos/jsquyres/ompi/stargazers","contributors_url":"https://api.github.com/repos/jsquyres/ompi/contributors","subscribers_url":"https://api.github.com/repos/jsquyres/ompi/subscribers","subscription_url":"https://api.github.com/repos/jsquyres/ompi/subscription","commits_url":"https://api.github.com/repos/jsquyres/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsquyres/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsquyres/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsquyres/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsquyres/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/jsquyres/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsquyres/ompi/merges","archive_url":"https://api.github.com/repos/jsquyres/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsquyres/ompi/downloads","issues_url":"https://api.github.com/repos/jsquyres/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/jsquyres/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/jsquyres/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/jsquyres/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsquyres/ompi/labels{/name}","releases_url":"https://api.github.com/repos/jsquyres/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/jsquyres/ompi/deployments","created_at":"2014-10-02T20:06:11Z","updated_at":"2016-03-25T22:01:17Z","pushed_at":"2018-03-21T11:43:31Z","git_url":"git://github.com/jsquyres/ompi.git","ssh_url":"git@github.com:jsquyres/ompi.git","clone_url":"https://github.com/jsquyres/ompi.git","svn_url":"https://github.com/jsquyres/ompi","homepage":null,"size":119256,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"5e9be7667bcf02cef45c0920b94cb1e6cff5226c","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars1.githubusercontent.com/u/2165682?v=4","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2018-03-21T15:39:19Z","pushed_at":"2018-03-21T15:39:10Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":114521,"stargazers_count":491,"watchers_count":491,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":354,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":309,"open_issues":354,"watchers":491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/3631"},"html":{"href":"https://github.com/open-mpi/ompi/pull/3631"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/3631"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/3631/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/3631/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/3631/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/2d68aeaed07a3e4a2f07b9356c051110894c7061"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":156,"deletions":48,"changed_files":2}}
{"actor":{"display_login":"hppritcha"}}