{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/199650828","pull_request_review_id":133811502,"id":199650828,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTY1MDgyOA==","diff_hunk":"@@ -63,9 +64,10 @@ def initialize(sandbox, aggregate_targets, pod_targets, analysis_result, install\n         def generate!\n           prepare\n           install_file_references\n-          @target_installation_results = install_libraries\n+          @target_installation_results = install_targets\n           integrate_targets(@target_installation_results.pod_target_installation_results)\n-          wire_target_dependencies(@target_installation_results)\n+          app_hosts = install_app_hosts","path":"lib/cocoapods/installer/xcode/pods_project_generator.rb","position":16,"original_position":16,"commit_id":"37dd0d6b18bfa49c34b90d6c3d93b5c965803dcf","original_commit_id":"37dd0d6b18bfa49c34b90d6c3d93b5c965803dcf","user":{"login":"dnkoutso","id":310370,"node_id":"MDQ6VXNlcjMxMDM3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"body":"nit: that was me, but rename to `app_hosts_by_host_key`","created_at":"2018-07-02T23:49:06Z","updated_at":"2018-07-02T23:49:06Z","html_url":"https://github.com/CocoaPods/CocoaPods/pull/7882#discussion_r199650828","pull_request_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/199650828"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/7882#discussion_r199650828"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882","id":197173676,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTczNjc2","html_url":"https://github.com/CocoaPods/CocoaPods/pull/7882","diff_url":"https://github.com/CocoaPods/CocoaPods/pull/7882.diff","patch_url":"https://github.com/CocoaPods/CocoaPods/pull/7882.patch","issue_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7882","number":7882,"state":"open","locked":false,"title":"[WIP] extract app host out of pod target installation","user":{"login":"dnkoutso","id":310370,"node_id":"MDQ6VXNlcjMxMDM3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"body":"`pod_target_installer.rb` is becoming too big and since we are using only one app host per test type it does not make sense to keep it within `pod_target_installer`. We also had to debounce to prevent adding an app host many times.","created_at":"2018-06-25T16:47:35Z","updated_at":"2018-07-02T23:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c48e32701ea491cab1613408db75cd03c198720c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones/34","html_url":"https://github.com/CocoaPods/CocoaPods/milestone/34","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones/34/labels","id":2960166,"node_id":"MDk6TWlsZXN0b25lMjk2MDE2Ng==","number":34,"title":"1.6.0","description":"","creator":{"login":"justinseanmartin","id":5855270,"node_id":"MDQ6VXNlcjU4NTUyNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/5855270?v=4","gravatar_id":"","url":"https://api.github.com/users/justinseanmartin","html_url":"https://github.com/justinseanmartin","followers_url":"https://api.github.com/users/justinseanmartin/followers","following_url":"https://api.github.com/users/justinseanmartin/following{/other_user}","gists_url":"https://api.github.com/users/justinseanmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/justinseanmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinseanmartin/subscriptions","organizations_url":"https://api.github.com/users/justinseanmartin/orgs","repos_url":"https://api.github.com/users/justinseanmartin/repos","events_url":"https://api.github.com/users/justinseanmartin/events{/privacy}","received_events_url":"https://api.github.com/users/justinseanmartin/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":97,"state":"open","created_at":"2017-12-05T18:27:15Z","updated_at":"2018-06-29T22:33:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7882/comments","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/37dd0d6b18bfa49c34b90d6c3d93b5c965803dcf","head":{"label":"dnkoutso:extract_app_host","ref":"extract_app_host","sha":"37dd0d6b18bfa49c34b90d6c3d93b5c965803dcf","user":{"login":"dnkoutso","id":310370,"node_id":"MDQ6VXNlcjMxMDM3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"repo":{"id":39788662,"node_id":"MDEwOlJlcG9zaXRvcnkzOTc4ODY2Mg==","name":"CocoaPods","full_name":"dnkoutso/CocoaPods","owner":{"login":"dnkoutso","id":310370,"node_id":"MDQ6VXNlcjMxMDM3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnkoutso/CocoaPods","description":"The Cocoa Dependency Manager.","fork":true,"url":"https://api.github.com/repos/dnkoutso/CocoaPods","forks_url":"https://api.github.com/repos/dnkoutso/CocoaPods/forks","keys_url":"https://api.github.com/repos/dnkoutso/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnkoutso/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnkoutso/CocoaPods/teams","hooks_url":"https://api.github.com/repos/dnkoutso/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/dnkoutso/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/dnkoutso/CocoaPods/events","assignees_url":"https://api.github.com/repos/dnkoutso/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/dnkoutso/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/dnkoutso/CocoaPods/tags","blobs_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnkoutso/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/dnkoutso/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/dnkoutso/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/dnkoutso/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/dnkoutso/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/dnkoutso/CocoaPods/subscription","commits_url":"https://api.github.com/repos/dnkoutso/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnkoutso/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnkoutso/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnkoutso/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/dnkoutso/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnkoutso/CocoaPods/merges","archive_url":"https://api.github.com/repos/dnkoutso/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnkoutso/CocoaPods/downloads","issues_url":"https://api.github.com/repos/dnkoutso/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/dnkoutso/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/dnkoutso/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/dnkoutso/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnkoutso/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/dnkoutso/CocoaPods/releases{/id}","deployments_url":"https://api.github.com/repos/dnkoutso/CocoaPods/deployments","created_at":"2015-07-27T17:39:59Z","updated_at":"2018-06-27T07:08:08Z","pushed_at":"2018-07-02T22:46:09Z","git_url":"git://github.com/dnkoutso/CocoaPods.git","ssh_url":"git@github.com:dnkoutso/CocoaPods.git","clone_url":"https://github.com/dnkoutso/CocoaPods.git","svn_url":"https://github.com/dnkoutso/CocoaPods","homepage":"cocoapods.org","size":56556,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"fa57420153107d0e92922e2ae445f9f41646d3b2","user":{"login":"CocoaPods","id":1189714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1189714?v=4","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":2203645,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAzNjQ1","name":"CocoaPods","full_name":"CocoaPods/CocoaPods","owner":{"login":"CocoaPods","id":1189714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1189714?v=4","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/CocoaPods","description":"The Cocoa Dependency Manager.","fork":false,"url":"https://api.github.com/repos/CocoaPods/CocoaPods","forks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/forks","keys_url":"https://api.github.com/repos/CocoaPods/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/CocoaPods/teams","hooks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/events","assignees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/tags","blobs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscription","commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/CocoaPods/merges","archive_url":"https://api.github.com/repos/CocoaPods/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/CocoaPods/downloads","issues_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/CocoaPods/releases{/id}","deployments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/deployments","created_at":"2011-08-14T00:10:53Z","updated_at":"2018-07-02T16:29:42Z","pushed_at":"2018-07-02T22:46:10Z","git_url":"git://github.com/CocoaPods/CocoaPods.git","ssh_url":"git@github.com:CocoaPods/CocoaPods.git","clone_url":"https://github.com/CocoaPods/CocoaPods.git","svn_url":"https://github.com/CocoaPods/CocoaPods","homepage":"https://cocoapods.org/","size":56368,"stargazers_count":10634,"watchers_count":10634,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1930,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1930,"open_issues":144,"watchers":10634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/7882"},"issue":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7882"},"comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7882/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7882/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/37dd0d6b18bfa49c34b90d6c3d93b5c965803dcf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dnkoutso"}}