{"action":"closed","number":306,"pull_request":{"url":"https://api.github.com/repos/rmagick/rmagick/pulls/306","id":222656020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjU2MDIw","html_url":"https://github.com/rmagick/rmagick/pull/306","diff_url":"https://github.com/rmagick/rmagick/pull/306.diff","patch_url":"https://github.com/rmagick/rmagick/pull/306.patch","issue_url":"https://api.github.com/repos/rmagick/rmagick/issues/306","number":306,"state":"closed","locked":false,"title":"fix argument count in Image#morphology_channel","user":{"login":"Watson1978","id":199156,"node_id":"MDQ6VXNlcjE5OTE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/199156?v=4","gravatar_id":"","url":"https://api.github.com/users/Watson1978","html_url":"https://github.com/Watson1978","followers_url":"https://api.github.com/users/Watson1978/followers","following_url":"https://api.github.com/users/Watson1978/following{/other_user}","gists_url":"https://api.github.com/users/Watson1978/gists{/gist_id}","starred_url":"https://api.github.com/users/Watson1978/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watson1978/subscriptions","organizations_url":"https://api.github.com/users/Watson1978/orgs","repos_url":"https://api.github.com/users/Watson1978/repos","events_url":"https://api.github.com/users/Watson1978/events{/privacy}","received_events_url":"https://api.github.com/users/Watson1978/received_events","type":"User","site_admin":false},"body":"Image_morphology_channel requires 4 arguments.\r\n\r\nhttps://github.com/rmagick/rmagick/blob/6759bf186355af107205c5ab98f3433856d25935/ext/RMagick/rmimage.c#L4211\r\n\r\nIf you pass 3 arguments, it causes a SEGV in RMagick.\r\n\r\n### Sample code\r\n\r\n```ruby\r\nrequire 'rmagick'\r\n\r\nimage = Magick::ImageList.new('./Flower_Hat.jpg').first\r\nkernel_info = Magick::KernelInfo.new(\"Octagon\")\r\n\r\n# new_img = image.morphology_channel(Magick::RedChannel, Magick::EdgeOutMorphology, 2, kernel_info)\r\n\r\n# This will cause a SEGV in RMagick.\r\nnew_img = image.morphology_channel(Magick::RedChannel, Magick::EdgeOutMorphology, 2)\r\n\r\nnew_img.write('./morphology_channel.png')\r\n```\r\n\r\n### Result\r\n\r\n```\r\n$ ruby morphology_channel.rb\r\nmorphology_channel.rb:7: [BUG] Segmentation fault at 0x0000000000000000\r\nruby 2.3.7p456 (2018-03-28 revision 63024) [x86_64-darwin18]\r\n\r\n-- Crash Report log information --------------------------------------------\r\n   See Crash Report log file under the one of following:\r\n     * ~/Library/Logs/CrashReporter\r\n     * /Library/Logs/CrashReporter\r\n     * ~/Library/Logs/DiagnosticReports\r\n     * /Library/Logs/DiagnosticReports\r\n   for more details.\r\nDon't forget to include the above Crash Report log file in bug reports.\r\n\r\n-- Control frame information -----------------------------------------------\r\nc:0003 p:---- s:0013 e:000012 CFUNC  :morphology_channel\r\nc:0002 p:0075 s:0007 E:000d78 EVAL   morphology_channel.rb:7 [FINISH]\r\nc:0001 p:0000 s:0002 E:001cf0 (none) [FINISH]\r\n\r\n-- Ruby level backtrace information ----------------------------------------\r\nmorphology_channel.rb:7:in `<main>'\r\nmorphology_channel.rb:7:in `morphology_channel'\r\n\r\n-- Machine register context ------------------------------------------------\r\n rax: 0x0000000000000014 rbx: 0x000000010621df80 rcx: 0x48f87d8948000000\r\n rdx: 0x00007f8e598e46c8 rdi: 0x00000001062461f8 rsi: 0x00007f8e598e46c8\r\n rbp: 0x00007ffee9ebf000 rsp: 0x00007ffee9ebef18  r8: 0x00000001062461f0\r\n  r9: 0x00007f8e598de110 r10: 0x00007f8e5b085ea0 r11: 0x0000000105df3370\r\n r12: 0x0000000000000003 r13: 0x00007f8e5956ace0 r14: 0x00007f8e5989ce90\r\n r15: 0x0000000000000003 rip: 0x0000000105df3415 rfl: 0x0000000000010212\r\n\r\n-- C level backtrace information -------------------------------------------\r\n0   ruby                                0x0000000105efe7d9 rb_vm_bugreport + 377\r\n1   ruby                                0x0000000105d8c8af rb_bug_context + 447\r\n2   ruby                                0x0000000105e6c304 sigsegv + 68\r\n3   libsystem_platform.dylib            0x00007fff6d2adb3d _sigtramp + 29\r\n4   ruby                                0x0000000105df3415 rb_obj_is_kind_of + 165\r\n5   ruby                                0x0000000105ef42ab vm_call_cfunc + 299\r\n6   ruby                                0x0000000105edd89f vm_exec_core + 10671\r\n7   ruby                                0x0000000105eee705 vm_exec + 117\r\n8   ruby                                0x0000000105d956d6 ruby_exec_internal + 150\r\n9   ruby                                0x0000000105d955e8 ruby_run_node + 56\r\n10  ruby                                0x0000000105d4148f main + 79\r\n--- snip ---\r\n```","created_at":"2018-10-13T15:13:17Z","updated_at":"2018-10-14T16:46:36Z","closed_at":"2018-10-14T16:46:36Z","merged_at":"2018-10-14T16:46:36Z","merge_commit_sha":"f3de06b4b4d3dd155e86917b2807e612cb874900","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rmagick/rmagick/pulls/306/commits","review_comments_url":"https://api.github.com/repos/rmagick/rmagick/pulls/306/comments","review_comment_url":"https://api.github.com/repos/rmagick/rmagick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rmagick/rmagick/issues/306/comments","statuses_url":"https://api.github.com/repos/rmagick/rmagick/statuses/203c1c919f0e078c8594f42e7712d2915950f630","head":{"label":"Watson1978:morphology","ref":"morphology","sha":"203c1c919f0e078c8594f42e7712d2915950f630","user":{"login":"Watson1978","id":199156,"node_id":"MDQ6VXNlcjE5OTE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/199156?v=4","gravatar_id":"","url":"https://api.github.com/users/Watson1978","html_url":"https://github.com/Watson1978","followers_url":"https://api.github.com/users/Watson1978/followers","following_url":"https://api.github.com/users/Watson1978/following{/other_user}","gists_url":"https://api.github.com/users/Watson1978/gists{/gist_id}","starred_url":"https://api.github.com/users/Watson1978/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watson1978/subscriptions","organizations_url":"https://api.github.com/users/Watson1978/orgs","repos_url":"https://api.github.com/users/Watson1978/repos","events_url":"https://api.github.com/users/Watson1978/events{/privacy}","received_events_url":"https://api.github.com/users/Watson1978/received_events","type":"User","site_admin":false},"repo":{"id":148740538,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3NDA1Mzg=","name":"rmagick","full_name":"Watson1978/rmagick","private":false,"owner":{"login":"Watson1978","id":199156,"node_id":"MDQ6VXNlcjE5OTE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/199156?v=4","gravatar_id":"","url":"https://api.github.com/users/Watson1978","html_url":"https://github.com/Watson1978","followers_url":"https://api.github.com/users/Watson1978/followers","following_url":"https://api.github.com/users/Watson1978/following{/other_user}","gists_url":"https://api.github.com/users/Watson1978/gists{/gist_id}","starred_url":"https://api.github.com/users/Watson1978/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watson1978/subscriptions","organizations_url":"https://api.github.com/users/Watson1978/orgs","repos_url":"https://api.github.com/users/Watson1978/repos","events_url":"https://api.github.com/users/Watson1978/events{/privacy}","received_events_url":"https://api.github.com/users/Watson1978/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Watson1978/rmagick","description":"Ruby bindings for ImageMagick","fork":true,"url":"https://api.github.com/repos/Watson1978/rmagick","forks_url":"https://api.github.com/repos/Watson1978/rmagick/forks","keys_url":"https://api.github.com/repos/Watson1978/rmagick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Watson1978/rmagick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Watson1978/rmagick/teams","hooks_url":"https://api.github.com/repos/Watson1978/rmagick/hooks","issue_events_url":"https://api.github.com/repos/Watson1978/rmagick/issues/events{/number}","events_url":"https://api.github.com/repos/Watson1978/rmagick/events","assignees_url":"https://api.github.com/repos/Watson1978/rmagick/assignees{/user}","branches_url":"https://api.github.com/repos/Watson1978/rmagick/branches{/branch}","tags_url":"https://api.github.com/repos/Watson1978/rmagick/tags","blobs_url":"https://api.github.com/repos/Watson1978/rmagick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Watson1978/rmagick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Watson1978/rmagick/git/refs{/sha}","trees_url":"https://api.github.com/repos/Watson1978/rmagick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Watson1978/rmagick/statuses/{sha}","languages_url":"https://api.github.com/repos/Watson1978/rmagick/languages","stargazers_url":"https://api.github.com/repos/Watson1978/rmagick/stargazers","contributors_url":"https://api.github.com/repos/Watson1978/rmagick/contributors","subscribers_url":"https://api.github.com/repos/Watson1978/rmagick/subscribers","subscription_url":"https://api.github.com/repos/Watson1978/rmagick/subscription","commits_url":"https://api.github.com/repos/Watson1978/rmagick/commits{/sha}","git_commits_url":"https://api.github.com/repos/Watson1978/rmagick/git/commits{/sha}","comments_url":"https://api.github.com/repos/Watson1978/rmagick/comments{/number}","issue_comment_url":"https://api.github.com/repos/Watson1978/rmagick/issues/comments{/number}","contents_url":"https://api.github.com/repos/Watson1978/rmagick/contents/{+path}","compare_url":"https://api.github.com/repos/Watson1978/rmagick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Watson1978/rmagick/merges","archive_url":"https://api.github.com/repos/Watson1978/rmagick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Watson1978/rmagick/downloads","issues_url":"https://api.github.com/repos/Watson1978/rmagick/issues{/number}","pulls_url":"https://api.github.com/repos/Watson1978/rmagick/pulls{/number}","milestones_url":"https://api.github.com/repos/Watson1978/rmagick/milestones{/number}","notifications_url":"https://api.github.com/repos/Watson1978/rmagick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Watson1978/rmagick/labels{/name}","releases_url":"https://api.github.com/repos/Watson1978/rmagick/releases{/id}","deployments_url":"https://api.github.com/repos/Watson1978/rmagick/deployments","created_at":"2018-09-14T05:36:55Z","updated_at":"2018-10-14T14:45:05Z","pushed_at":"2018-10-14T15:36:20Z","git_url":"git://github.com/Watson1978/rmagick.git","ssh_url":"git@github.com:Watson1978/rmagick.git","clone_url":"https://github.com/Watson1978/rmagick.git","svn_url":"https://github.com/Watson1978/rmagick","homepage":"https://rmagick.github.io/","size":8148,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"rmagick:develop","ref":"develop","sha":"6759bf186355af107205c5ab98f3433856d25935","user":{"login":"rmagick","id":12403326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAzMzI2","avatar_url":"https://avatars1.githubusercontent.com/u/12403326?v=4","gravatar_id":"","url":"https://api.github.com/users/rmagick","html_url":"https://github.com/rmagick","followers_url":"https://api.github.com/users/rmagick/followers","following_url":"https://api.github.com/users/rmagick/following{/other_user}","gists_url":"https://api.github.com/users/rmagick/gists{/gist_id}","starred_url":"https://api.github.com/users/rmagick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmagick/subscriptions","organizations_url":"https://api.github.com/users/rmagick/orgs","repos_url":"https://api.github.com/users/rmagick/repos","events_url":"https://api.github.com/users/rmagick/events{/privacy}","received_events_url":"https://api.github.com/users/rmagick/received_events","type":"Organization","site_admin":false},"repo":{"id":22215041,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIxNTA0MQ==","name":"rmagick","full_name":"rmagick/rmagick","private":false,"owner":{"login":"rmagick","id":12403326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAzMzI2","avatar_url":"https://avatars1.githubusercontent.com/u/12403326?v=4","gravatar_id":"","url":"https://api.github.com/users/rmagick","html_url":"https://github.com/rmagick","followers_url":"https://api.github.com/users/rmagick/followers","following_url":"https://api.github.com/users/rmagick/following{/other_user}","gists_url":"https://api.github.com/users/rmagick/gists{/gist_id}","starred_url":"https://api.github.com/users/rmagick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmagick/subscriptions","organizations_url":"https://api.github.com/users/rmagick/orgs","repos_url":"https://api.github.com/users/rmagick/repos","events_url":"https://api.github.com/users/rmagick/events{/privacy}","received_events_url":"https://api.github.com/users/rmagick/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rmagick/rmagick","description":"Ruby bindings for ImageMagick","fork":true,"url":"https://api.github.com/repos/rmagick/rmagick","forks_url":"https://api.github.com/repos/rmagick/rmagick/forks","keys_url":"https://api.github.com/repos/rmagick/rmagick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmagick/rmagick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmagick/rmagick/teams","hooks_url":"https://api.github.com/repos/rmagick/rmagick/hooks","issue_events_url":"https://api.github.com/repos/rmagick/rmagick/issues/events{/number}","events_url":"https://api.github.com/repos/rmagick/rmagick/events","assignees_url":"https://api.github.com/repos/rmagick/rmagick/assignees{/user}","branches_url":"https://api.github.com/repos/rmagick/rmagick/branches{/branch}","tags_url":"https://api.github.com/repos/rmagick/rmagick/tags","blobs_url":"https://api.github.com/repos/rmagick/rmagick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmagick/rmagick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmagick/rmagick/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmagick/rmagick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmagick/rmagick/statuses/{sha}","languages_url":"https://api.github.com/repos/rmagick/rmagick/languages","stargazers_url":"https://api.github.com/repos/rmagick/rmagick/stargazers","contributors_url":"https://api.github.com/repos/rmagick/rmagick/contributors","subscribers_url":"https://api.github.com/repos/rmagick/rmagick/subscribers","subscription_url":"https://api.github.com/repos/rmagick/rmagick/subscription","commits_url":"https://api.github.com/repos/rmagick/rmagick/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmagick/rmagick/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmagick/rmagick/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmagick/rmagick/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmagick/rmagick/contents/{+path}","compare_url":"https://api.github.com/repos/rmagick/rmagick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmagick/rmagick/merges","archive_url":"https://api.github.com/repos/rmagick/rmagick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmagick/rmagick/downloads","issues_url":"https://api.github.com/repos/rmagick/rmagick/issues{/number}","pulls_url":"https://api.github.com/repos/rmagick/rmagick/pulls{/number}","milestones_url":"https://api.github.com/repos/rmagick/rmagick/milestones{/number}","notifications_url":"https://api.github.com/repos/rmagick/rmagick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmagick/rmagick/labels{/name}","releases_url":"https://api.github.com/repos/rmagick/rmagick/releases{/id}","deployments_url":"https://api.github.com/repos/rmagick/rmagick/deployments","created_at":"2014-07-24T14:02:31Z","updated_at":"2018-10-09T09:44:11Z","pushed_at":"2018-10-14T16:46:36Z","git_url":"git://github.com/rmagick/rmagick.git","ssh_url":"git@github.com:rmagick/rmagick.git","clone_url":"https://github.com/rmagick/rmagick.git","svn_url":"https://github.com/rmagick/rmagick","homepage":"https://rmagick.github.io/","size":7857,"stargazers_count":407,"watchers_count":407,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":95,"open_issues":84,"watchers":407,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/rmagick/rmagick/pulls/306"},"html":{"href":"https://github.com/rmagick/rmagick/pull/306"},"issue":{"href":"https://api.github.com/repos/rmagick/rmagick/issues/306"},"comments":{"href":"https://api.github.com/repos/rmagick/rmagick/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/rmagick/rmagick/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/rmagick/rmagick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rmagick/rmagick/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/rmagick/rmagick/statuses/203c1c919f0e078c8594f42e7712d2915950f630"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vassilevsky","id":252023,"node_id":"MDQ6VXNlcjI1MjAyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/252023?v=4","gravatar_id":"","url":"https://api.github.com/users/vassilevsky","html_url":"https://github.com/vassilevsky","followers_url":"https://api.github.com/users/vassilevsky/followers","following_url":"https://api.github.com/users/vassilevsky/following{/other_user}","gists_url":"https://api.github.com/users/vassilevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/vassilevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vassilevsky/subscriptions","organizations_url":"https://api.github.com/users/vassilevsky/orgs","repos_url":"https://api.github.com/users/vassilevsky/repos","events_url":"https://api.github.com/users/vassilevsky/events{/privacy}","received_events_url":"https://api.github.com/users/vassilevsky/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":16,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"vassilevsky"}}