{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/219359536","pull_request_review_id":157504454,"id":219359536,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTM1OTUzNg==","diff_hunk":"@@ -460,7 +478,7 @@ export class Registry {\n    * @param {Function}    done       The callback that will be called with either an Error object or\n    *                                 the device twin instance.\n    */\n-  getTwin(deviceId: string, done: Registry.ResponseCallback): void {\n+  getTwin(deviceId: string, done: TripleValueCallback<any, any>): void {","path":"service/src/registry.ts","position":380,"original_position":380,"commit_id":"184a91f263cf86ec0ec51d1b75e477ba01ab5067","original_commit_id":"184a91f263cf86ec0ec51d1b75e477ba01ab5067","user":{"login":"pierreca","id":4979572,"node_id":"MDQ6VXNlcjQ5Nzk1NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"body":"not promisifying any of this?","created_at":"2018-09-21T01:02:01Z","updated_at":"2018-09-21T01:03:50Z","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/372#discussion_r219359536","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/219359536"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/372#discussion_r219359536"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372","id":216485915,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDg1OTE1","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/372","diff_url":"https://github.com/Azure/azure-iot-sdk-node/pull/372.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-node/pull/372.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/372","number":372,"state":"open","locked":false,"title":"Add support for Promises in azure-iot-device, azure-iothub, azure-iot-provisioning-device, azure-iot-provisioning-service packages","user":{"login":"kpajdzik","id":41709775,"node_id":"MDQ6VXNlcjQxNzA5Nzc1","avatar_url":"https://avatars3.githubusercontent.com/u/41709775?v=4","gravatar_id":"","url":"https://api.github.com/users/kpajdzik","html_url":"https://github.com/kpajdzik","followers_url":"https://api.github.com/users/kpajdzik/followers","following_url":"https://api.github.com/users/kpajdzik/following{/other_user}","gists_url":"https://api.github.com/users/kpajdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/kpajdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpajdzik/subscriptions","organizations_url":"https://api.github.com/users/kpajdzik/orgs","repos_url":"https://api.github.com/users/kpajdzik/repos","events_url":"https://api.github.com/users/kpajdzik/events{/privacy}","received_events_url":"https://api.github.com/users/kpajdzik/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for helping us improve the Azure IoT Node.js SDK!\r\n\r\n# Need Support?\r\n- **Have a feature request for SDKs?** Please post it on [User Voice](https://feedback.azure.com/forums/321918-azure-iot) to help us prioritize\r\n- **Have a technical question?** Ask on [Stack Overflow with tag \"azure-iot-hub\"](https://stackoverflow.com/questions/tagged/azure-iot-hub)\r\n- **Need Support?** Every customer with an active Azure subscription has access to [support](https://docs.microsoft.com/en-us/azure/azure-supportability/how-to-create-azure-support-request) with guaranteed response time.  Consider submitting a ticket and get assistance from Microsoft support team\r\n- **Found a bug?** Please help us fix it by thoroughly documenting it and filing an issue on GitHub (See below).\r\n\r\nHere's a little checklist of things that will help it make its way to the repository: Note that you don't have to check all the boxes, we can help you with that.\r\nThis being said, the more you do, the quicker it'll go through our gated build!\r\n-->\r\n\r\n# Checklist\r\n- [ ] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-node/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).\r\n- If this is a modification that impacts the behavior of a public API\r\n  - [ ] I edited the corresponding document in the `devdoc` folder and added or modified requirements.\r\n\r\n# Reference/Link to the issue solved with this PR (if any)\r\n\r\n# Description of the problem\r\n<!-- Please be as precise as possible: what issue you experienced, how often... -->\r\n\r\n# Description of the solution\r\n<!-- How you solved the issue and the other things you considered and maybe rejected -->\r\n","created_at":"2018-09-19T01:03:47Z","updated_at":"2018-09-21T01:03:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"731fe0d4f8f97ff8de554e46d62e6e4a71b20886","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BertKleewein","id":8028738,"node_id":"MDQ6VXNlcjgwMjg3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},{"login":"anthonyvercolano","id":9854568,"node_id":"MDQ6VXNlcjk4NTQ1Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/9854568?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyvercolano","html_url":"https://github.com/anthonyvercolano","followers_url":"https://api.github.com/users/anthonyvercolano/followers","following_url":"https://api.github.com/users/anthonyvercolano/following{/other_user}","gists_url":"https://api.github.com/users/anthonyvercolano/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyvercolano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyvercolano/subscriptions","organizations_url":"https://api.github.com/users/anthonyvercolano/orgs","repos_url":"https://api.github.com/users/anthonyvercolano/repos","events_url":"https://api.github.com/users/anthonyvercolano/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyvercolano/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/372/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/184a91f263cf86ec0ec51d1b75e477ba01ab5067","head":{"label":"kpajdzik:feature/kamip/promises-squashed","ref":"feature/kamip/promises-squashed","sha":"184a91f263cf86ec0ec51d1b75e477ba01ab5067","user":{"login":"kpajdzik","id":41709775,"node_id":"MDQ6VXNlcjQxNzA5Nzc1","avatar_url":"https://avatars3.githubusercontent.com/u/41709775?v=4","gravatar_id":"","url":"https://api.github.com/users/kpajdzik","html_url":"https://github.com/kpajdzik","followers_url":"https://api.github.com/users/kpajdzik/followers","following_url":"https://api.github.com/users/kpajdzik/following{/other_user}","gists_url":"https://api.github.com/users/kpajdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/kpajdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpajdzik/subscriptions","organizations_url":"https://api.github.com/users/kpajdzik/orgs","repos_url":"https://api.github.com/users/kpajdzik/repos","events_url":"https://api.github.com/users/kpajdzik/events{/privacy}","received_events_url":"https://api.github.com/users/kpajdzik/received_events","type":"User","site_admin":false},"repo":{"id":147736747,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MzY3NDc=","name":"azure-iot-sdk-node","full_name":"kpajdzik/azure-iot-sdk-node","private":false,"owner":{"login":"kpajdzik","id":41709775,"node_id":"MDQ6VXNlcjQxNzA5Nzc1","avatar_url":"https://avatars3.githubusercontent.com/u/41709775?v=4","gravatar_id":"","url":"https://api.github.com/users/kpajdzik","html_url":"https://github.com/kpajdzik","followers_url":"https://api.github.com/users/kpajdzik/followers","following_url":"https://api.github.com/users/kpajdzik/following{/other_user}","gists_url":"https://api.github.com/users/kpajdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/kpajdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpajdzik/subscriptions","organizations_url":"https://api.github.com/users/kpajdzik/orgs","repos_url":"https://api.github.com/users/kpajdzik/repos","events_url":"https://api.github.com/users/kpajdzik/events{/privacy}","received_events_url":"https://api.github.com/users/kpajdzik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kpajdzik/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":true,"url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/kpajdzik/azure-iot-sdk-node/deployments","created_at":"2018-09-06T21:39:29Z","updated_at":"2018-09-17T21:00:08Z","pushed_at":"2018-09-19T16:34:37Z","git_url":"git://github.com/kpajdzik/azure-iot-sdk-node.git","ssh_url":"git@github.com:kpajdzik/azure-iot-sdk-node.git","clone_url":"https://github.com/kpajdzik/azure-iot-sdk-node.git","svn_url":"https://github.com/kpajdzik/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":44574,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"6bc7c6347d1c1737def6910151fdedab4e896d7d","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70935002,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkzNTAwMg==","name":"azure-iot-sdk-node","full_name":"Azure/azure-iot-sdk-node","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/deployments","created_at":"2016-10-14T18:03:43Z","updated_at":"2018-09-20T00:29:33Z","pushed_at":"2018-09-20T00:29:31Z","git_url":"git://github.com/Azure/azure-iot-sdk-node.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-node.git","clone_url":"https://github.com/Azure/azure-iot-sdk-node.git","svn_url":"https://github.com/Azure/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":44454,"stargazers_count":115,"watchers_count":115,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":98,"open_issues":15,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/372"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/372"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/184a91f263cf86ec0ec51d1b75e477ba01ab5067"}},"author_association":"NONE"}}
{"actor":{"display_login":"pierreca"}}