{"action":"created","comment":{"url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments/244837159","pull_request_review_id":188807316,"id":244837159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDgzNzE1OQ==","diff_hunk":"@@ -26,6 +26,12 @@ contract PublicLock is ILockCore, ERC165, IERC721, Ownable {\n     bytes data; // Note: This can be expensive?\n   }\n \n+  // Events\n+  event PriceChanged(","path":"smart-contracts/contracts/PublicLock.sol","position":5,"original_position":5,"commit_id":"da33275a5cc326b8f5963f1821a1fbe0f8506b88","original_commit_id":"da33275a5cc326b8f5963f1821a1fbe0f8506b88","user":{"login":"julien51","id":17735,"node_id":"MDQ6VXNlcjE3NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/17735?v=4","gravatar_id":"","url":"https://api.github.com/users/julien51","html_url":"https://github.com/julien51","followers_url":"https://api.github.com/users/julien51/followers","following_url":"https://api.github.com/users/julien51/following{/other_user}","gists_url":"https://api.github.com/users/julien51/gists{/gist_id}","starred_url":"https://api.github.com/users/julien51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien51/subscriptions","organizations_url":"https://api.github.com/users/julien51/orgs","repos_url":"https://api.github.com/users/julien51/repos","events_url":"https://api.github.com/users/julien51/events{/privacy}","received_events_url":"https://api.github.com/users/julien51/received_events","type":"User","site_admin":false},"body":"That's a good practice, I'll update the PR. Thanks!","created_at":"2019-01-02T19:57:10Z","updated_at":"2019-01-02T19:57:10Z","html_url":"https://github.com/unlock-protocol/unlock/pull/882#discussion_r244837159","pull_request_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments/244837159"},"html":{"href":"https://github.com/unlock-protocol/unlock/pull/882#discussion_r244837159"},"pull_request":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882"}},"in_reply_to_id":244836298},"pull_request":{"url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882","id":241797690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzk3Njkw","html_url":"https://github.com/unlock-protocol/unlock/pull/882","diff_url":"https://github.com/unlock-protocol/unlock/pull/882.diff","patch_url":"https://github.com/unlock-protocol/unlock/pull/882.patch","issue_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/882","number":882,"state":"open","locked":false,"title":"Triggering an event when the price of keys on a lock was changed","user":{"login":"julien51","id":17735,"node_id":"MDQ6VXNlcjE3NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/17735?v=4","gravatar_id":"","url":"https://api.github.com/users/julien51","html_url":"https://github.com/julien51","followers_url":"https://api.github.com/users/julien51/followers","following_url":"https://api.github.com/users/julien51/following{/other_user}","gists_url":"https://api.github.com/users/julien51/gists{/gist_id}","starred_url":"https://api.github.com/users/julien51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien51/subscriptions","organizations_url":"https://api.github.com/users/julien51/orgs","repos_url":"https://api.github.com/users/julien51/repos","events_url":"https://api.github.com/users/julien51/events{/privacy}","received_events_url":"https://api.github.com/users/julien51/received_events","type":"User","site_admin":false},"body":"We're now triggering an event when the price of keys was changed on a lock\n\n\n- [X] 1 PR, 1 purpose: my Pull Request applies to a single purpose\n- [X] My code follows the style guidelines of this project, including naming conventions\n- [ ] I have commented my code, particularly in hard-to-understand areas\n- [X] I have added tests that prove my fix is effective or that my feature works\n- [ ] If my code adds or changes components, I have written corresponding stories with Storybook\n- [X] I have performed a self-review of my own code\n- [ ] If my code involves visual changes, I am adding applicable screenshots to this thread","created_at":"2019-01-02T17:02:18Z","updated_at":"2019-01-02T19:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1402c94b0c9d93032732e3b59109ba5c4f61db83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882/commits","review_comments_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882/comments","review_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/882/comments","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/da33275a5cc326b8f5963f1821a1fbe0f8506b88","head":{"label":"unlock-protocol:julien-updateLock-event","ref":"julien-updateLock-event","sha":"da33275a5cc326b8f5963f1821a1fbe0f8506b88","user":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112683472,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2ODM0NzI=","name":"unlock","full_name":"unlock-protocol/unlock","private":false,"owner":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unlock-protocol/unlock","description":"Unlock is the web's new business model","fork":false,"url":"https://api.github.com/repos/unlock-protocol/unlock","forks_url":"https://api.github.com/repos/unlock-protocol/unlock/forks","keys_url":"https://api.github.com/repos/unlock-protocol/unlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unlock-protocol/unlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unlock-protocol/unlock/teams","hooks_url":"https://api.github.com/repos/unlock-protocol/unlock/hooks","issue_events_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/events{/number}","events_url":"https://api.github.com/repos/unlock-protocol/unlock/events","assignees_url":"https://api.github.com/repos/unlock-protocol/unlock/assignees{/user}","branches_url":"https://api.github.com/repos/unlock-protocol/unlock/branches{/branch}","tags_url":"https://api.github.com/repos/unlock-protocol/unlock/tags","blobs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unlock-protocol/unlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/unlock-protocol/unlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/{sha}","languages_url":"https://api.github.com/repos/unlock-protocol/unlock/languages","stargazers_url":"https://api.github.com/repos/unlock-protocol/unlock/stargazers","contributors_url":"https://api.github.com/repos/unlock-protocol/unlock/contributors","subscribers_url":"https://api.github.com/repos/unlock-protocol/unlock/subscribers","subscription_url":"https://api.github.com/repos/unlock-protocol/unlock/subscription","commits_url":"https://api.github.com/repos/unlock-protocol/unlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/unlock-protocol/unlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/unlock-protocol/unlock/contents/{+path}","compare_url":"https://api.github.com/repos/unlock-protocol/unlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unlock-protocol/unlock/merges","archive_url":"https://api.github.com/repos/unlock-protocol/unlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unlock-protocol/unlock/downloads","issues_url":"https://api.github.com/repos/unlock-protocol/unlock/issues{/number}","pulls_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls{/number}","milestones_url":"https://api.github.com/repos/unlock-protocol/unlock/milestones{/number}","notifications_url":"https://api.github.com/repos/unlock-protocol/unlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unlock-protocol/unlock/labels{/name}","releases_url":"https://api.github.com/repos/unlock-protocol/unlock/releases{/id}","deployments_url":"https://api.github.com/repos/unlock-protocol/unlock/deployments","created_at":"2017-12-01T02:08:01Z","updated_at":"2019-01-02T19:56:10Z","pushed_at":"2019-01-02T19:56:09Z","git_url":"git://github.com/unlock-protocol/unlock.git","ssh_url":"git@github.com:unlock-protocol/unlock.git","clone_url":"https://github.com/unlock-protocol/unlock.git","svn_url":"https://github.com/unlock-protocol/unlock","homepage":"https://unlock-protocol.com","size":13036,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":75,"watchers":77,"default_branch":"master"}},"base":{"label":"unlock-protocol:master","ref":"master","sha":"dc8ffee73c56888146cc59f5497dd1fe527ff0e3","user":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112683472,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2ODM0NzI=","name":"unlock","full_name":"unlock-protocol/unlock","private":false,"owner":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unlock-protocol/unlock","description":"Unlock is the web's new business model","fork":false,"url":"https://api.github.com/repos/unlock-protocol/unlock","forks_url":"https://api.github.com/repos/unlock-protocol/unlock/forks","keys_url":"https://api.github.com/repos/unlock-protocol/unlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unlock-protocol/unlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unlock-protocol/unlock/teams","hooks_url":"https://api.github.com/repos/unlock-protocol/unlock/hooks","issue_events_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/events{/number}","events_url":"https://api.github.com/repos/unlock-protocol/unlock/events","assignees_url":"https://api.github.com/repos/unlock-protocol/unlock/assignees{/user}","branches_url":"https://api.github.com/repos/unlock-protocol/unlock/branches{/branch}","tags_url":"https://api.github.com/repos/unlock-protocol/unlock/tags","blobs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unlock-protocol/unlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/unlock-protocol/unlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/{sha}","languages_url":"https://api.github.com/repos/unlock-protocol/unlock/languages","stargazers_url":"https://api.github.com/repos/unlock-protocol/unlock/stargazers","contributors_url":"https://api.github.com/repos/unlock-protocol/unlock/contributors","subscribers_url":"https://api.github.com/repos/unlock-protocol/unlock/subscribers","subscription_url":"https://api.github.com/repos/unlock-protocol/unlock/subscription","commits_url":"https://api.github.com/repos/unlock-protocol/unlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/unlock-protocol/unlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/unlock-protocol/unlock/contents/{+path}","compare_url":"https://api.github.com/repos/unlock-protocol/unlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unlock-protocol/unlock/merges","archive_url":"https://api.github.com/repos/unlock-protocol/unlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unlock-protocol/unlock/downloads","issues_url":"https://api.github.com/repos/unlock-protocol/unlock/issues{/number}","pulls_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls{/number}","milestones_url":"https://api.github.com/repos/unlock-protocol/unlock/milestones{/number}","notifications_url":"https://api.github.com/repos/unlock-protocol/unlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unlock-protocol/unlock/labels{/name}","releases_url":"https://api.github.com/repos/unlock-protocol/unlock/releases{/id}","deployments_url":"https://api.github.com/repos/unlock-protocol/unlock/deployments","created_at":"2017-12-01T02:08:01Z","updated_at":"2019-01-02T19:56:10Z","pushed_at":"2019-01-02T19:56:09Z","git_url":"git://github.com/unlock-protocol/unlock.git","ssh_url":"git@github.com:unlock-protocol/unlock.git","clone_url":"https://github.com/unlock-protocol/unlock.git","svn_url":"https://github.com/unlock-protocol/unlock","homepage":"https://unlock-protocol.com","size":13036,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":75,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882"},"html":{"href":"https://github.com/unlock-protocol/unlock/pull/882"},"issue":{"href":"https://api.github.com/repos/unlock-protocol/unlock/issues/882"},"comments":{"href":"https://api.github.com/repos/unlock-protocol/unlock/issues/882/comments"},"review_comments":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882/comments"},"review_comment":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/882/commits"},"statuses":{"href":"https://api.github.com/repos/unlock-protocol/unlock/statuses/da33275a5cc326b8f5963f1821a1fbe0f8506b88"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"julien51"}}