{"action":"created","comment":{"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments/172920021","pull_request_review_id":102021326,"id":172920021,"diff_hunk":"@@ -1,9 +1,11 @@\n import { Component, OnInit } from '@angular/core';\n import { Observable } from 'rxjs/Rx';\n \n+import { AccessControlConfigService } from '../../../services/access-control-config.service';\n+\n import { FabricAuthMemberSearchService } from '../../../services/fabric-auth-member-search.service';\n-import { AuthMemberSearchRequest } from '../../../models/authMemberSearchRequest';\n-import { AuthMemberSearchResult } from '../../../models/authMemberSearchResult';","path":"Fabric.Authorization.AccessControl/src/app/modules/access-control/member-list/member-list.component.ts","position":8,"original_position":8,"commit_id":"56b76cc58486fe2ac769d600a077317c9dc21753","original_commit_id":"56b76cc58486fe2ac769d600a077317c9dc21753","user":{"login":"bsmithvt","id":6453904,"avatar_url":"https://avatars1.githubusercontent.com/u/6453904?v=4","gravatar_id":"","url":"https://api.github.com/users/bsmithvt","html_url":"https://github.com/bsmithvt","followers_url":"https://api.github.com/users/bsmithvt/followers","following_url":"https://api.github.com/users/bsmithvt/following{/other_user}","gists_url":"https://api.github.com/users/bsmithvt/gists{/gist_id}","starred_url":"https://api.github.com/users/bsmithvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsmithvt/subscriptions","organizations_url":"https://api.github.com/users/bsmithvt/orgs","repos_url":"https://api.github.com/users/bsmithvt/repos","events_url":"https://api.github.com/users/bsmithvt/events{/privacy}","received_events_url":"https://api.github.com/users/bsmithvt/received_events","type":"User","site_admin":false},"body":"Minor note: the `index.ts` file in the `models` (and other) directories allow `import` statements to be consolidated on a single line. The 2 lines below could become:\r\n\r\n`import { AuthMemberSearchRequest, AuthMemberSearchResult } from '../../../models'`","created_at":"2018-03-07T17:25:04Z","updated_at":"2018-03-07T17:28:06Z","html_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/171#discussion_r172920021","pull_request_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments/172920021"},"html":{"href":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/171#discussion_r172920021"},"pull_request":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171","id":173513268,"html_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/171","diff_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/171.diff","patch_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/171.patch","issue_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/171","number":171,"state":"open","locked":false,"title":"added a config service for providing configuration data and functions to the access control module","user":{"login":"kpaul","id":1791420,"avatar_url":"https://avatars3.githubusercontent.com/u/1791420?v=4","gravatar_id":"","url":"https://api.github.com/users/kpaul","html_url":"https://github.com/kpaul","followers_url":"https://api.github.com/users/kpaul/followers","following_url":"https://api.github.com/users/kpaul/following{/other_user}","gists_url":"https://api.github.com/users/kpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/kpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpaul/subscriptions","organizations_url":"https://api.github.com/users/kpaul/orgs","repos_url":"https://api.github.com/users/kpaul/repos","events_url":"https://api.github.com/users/kpaul/events{/privacy}","received_events_url":"https://api.github.com/users/kpaul/received_events","type":"User","site_admin":false},"body":"the idea is that the app that installs the access control module will create a service that implements the functions and sets the properties we need to access the backend services (i.e. api urls, access token, client id). we can then import that service into any access control module services that require backend services. ","created_at":"2018-03-07T16:59:20Z","updated_at":"2018-03-07T17:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e108cee0a75e06a71880bf3b1316f7e6468c4a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benjanderson","id":1934453,"avatar_url":"https://avatars2.githubusercontent.com/u/1934453?v=4","gravatar_id":"","url":"https://api.github.com/users/benjanderson","html_url":"https://github.com/benjanderson","followers_url":"https://api.github.com/users/benjanderson/followers","following_url":"https://api.github.com/users/benjanderson/following{/other_user}","gists_url":"https://api.github.com/users/benjanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/benjanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjanderson/subscriptions","organizations_url":"https://api.github.com/users/benjanderson/orgs","repos_url":"https://api.github.com/users/benjanderson/repos","events_url":"https://api.github.com/users/benjanderson/events{/privacy}","received_events_url":"https://api.github.com/users/benjanderson/received_events","type":"User","site_admin":false},{"login":"michaelvidal24","id":26312461,"avatar_url":"https://avatars3.githubusercontent.com/u/26312461?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelvidal24","html_url":"https://github.com/michaelvidal24","followers_url":"https://api.github.com/users/michaelvidal24/followers","following_url":"https://api.github.com/users/michaelvidal24/following{/other_user}","gists_url":"https://api.github.com/users/michaelvidal24/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelvidal24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelvidal24/subscriptions","organizations_url":"https://api.github.com/users/michaelvidal24/orgs","repos_url":"https://api.github.com/users/michaelvidal24/repos","events_url":"https://api.github.com/users/michaelvidal24/events{/privacy}","received_events_url":"https://api.github.com/users/michaelvidal24/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171/commits","review_comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171/comments","review_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/171/comments","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/56b76cc58486fe2ac769d600a077317c9dc21753","head":{"label":"HealthCatalyst:user/kpaul/access-token-service","ref":"user/kpaul/access-token-service","sha":"56b76cc58486fe2ac769d600a077317c9dc21753","user":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":90079030,"name":"Fabric.Authorization","full_name":"HealthCatalyst/Fabric.Authorization","owner":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalyst/Fabric.Authorization","description":"Permissions service for applications","fork":false,"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization","forks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/forks","keys_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/teams","hooks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/events","assignees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/tags","blobs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/languages","stargazers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscription","commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/merges","archive_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/downloads","issues_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/deployments","created_at":"2017-05-02T21:20:07Z","updated_at":"2017-10-16T23:37:14Z","pushed_at":"2018-03-07T16:59:20Z","git_url":"git://github.com/HealthCatalyst/Fabric.Authorization.git","ssh_url":"git@github.com:HealthCatalyst/Fabric.Authorization.git","clone_url":"https://github.com/HealthCatalyst/Fabric.Authorization.git","svn_url":"https://github.com/HealthCatalyst/Fabric.Authorization","homepage":"","size":2964,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"HealthCatalyst:master","ref":"master","sha":"8c9c9b563d114a49e253c0c102bffd18327c2ae1","user":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":90079030,"name":"Fabric.Authorization","full_name":"HealthCatalyst/Fabric.Authorization","owner":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalyst/Fabric.Authorization","description":"Permissions service for applications","fork":false,"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization","forks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/forks","keys_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/teams","hooks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/events","assignees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/tags","blobs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/languages","stargazers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscription","commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/merges","archive_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/downloads","issues_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/deployments","created_at":"2017-05-02T21:20:07Z","updated_at":"2017-10-16T23:37:14Z","pushed_at":"2018-03-07T16:59:20Z","git_url":"git://github.com/HealthCatalyst/Fabric.Authorization.git","ssh_url":"git@github.com:HealthCatalyst/Fabric.Authorization.git","clone_url":"https://github.com/HealthCatalyst/Fabric.Authorization.git","svn_url":"https://github.com/HealthCatalyst/Fabric.Authorization","homepage":"","size":2964,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171"},"html":{"href":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/171"},"issue":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/171"},"comments":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/56b76cc58486fe2ac769d600a077317c9dc21753"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bsmithvt"}}