{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/176945846","pull_request_review_id":106735527,"id":176945846,"diff_hunk":"@@ -1248,6 +1248,34 @@ int ObjectRef::l_get_inventory_formspec(lua_State *L)\n \treturn 1;\n }\n \n+// set_inventory_formspec(self, formspec)","path":"src/script/lua_api/l_object.cpp","position":4,"original_position":4,"commit_id":"c7f53cfc8779ae57588d4fff3eeb38e8c918ac1f","original_commit_id":"c7f53cfc8779ae57588d4fff3eeb38e8c918ac1f","user":{"login":"sfan5","id":1042418,"avatar_url":"https://avatars1.githubusercontent.com/u/1042418?v=4","gravatar_id":"","url":"https://api.github.com/users/sfan5","html_url":"https://github.com/sfan5","followers_url":"https://api.github.com/users/sfan5/followers","following_url":"https://api.github.com/users/sfan5/following{/other_user}","gists_url":"https://api.github.com/users/sfan5/gists{/gist_id}","starred_url":"https://api.github.com/users/sfan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfan5/subscriptions","organizations_url":"https://api.github.com/users/sfan5/orgs","repos_url":"https://api.github.com/users/sfan5/repos","events_url":"https://api.github.com/users/sfan5/events{/privacy}","received_events_url":"https://api.github.com/users/sfan5/received_events","type":"User","site_admin":false},"body":"all functions are documented in this manner, leave it like this","created_at":"2018-03-25T16:30:21Z","updated_at":"2018-03-25T16:30:21Z","html_url":"https://github.com/minetest/minetest/pull/7099#discussion_r176945846","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/7099","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/176945846"},"html":{"href":"https://github.com/minetest/minetest/pull/7099#discussion_r176945846"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7099"}},"in_reply_to_id":176915566},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/7099","id":172731925,"html_url":"https://github.com/minetest/minetest/pull/7099","diff_url":"https://github.com/minetest/minetest/pull/7099.diff","patch_url":"https://github.com/minetest/minetest/pull/7099.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7099","number":7099,"state":"open","locked":false,"title":"Add formspec theming using prepended strings","user":{"login":"rubenwardy","id":2122943,"avatar_url":"https://avatars2.githubusercontent.com/u/2122943?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenwardy","html_url":"https://github.com/rubenwardy","followers_url":"https://api.github.com/users/rubenwardy/followers","following_url":"https://api.github.com/users/rubenwardy/following{/other_user}","gists_url":"https://api.github.com/users/rubenwardy/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenwardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenwardy/subscriptions","organizations_url":"https://api.github.com/users/rubenwardy/orgs","repos_url":"https://api.github.com/users/rubenwardy/repos","events_url":"https://api.github.com/users/rubenwardy/events{/privacy}","received_events_url":"https://api.github.com/users/rubenwardy/received_events","type":"User","site_admin":false},"body":"Fixes #7068\r\n\r\nAfter this PR, default/init.lua should be changed to:\r\n\r\n```lua\r\ndefault.gui_bg     = \"\"\r\ndefault.gui_bg_img = \"\"\r\ndefault.gui_slots  = \"\"\r\n\r\nminetest.register_on_joinplayer(function(player)\r\n\tplayer:set_formspec_prepend(\"bgcolor[#080808BB;true]\" .. \r\n\t\t\t\"background[5,5;1,1;gui_formbg.png;true]\" ..\r\n\t\t\t\"listcolors[#00000069;#5A5A5A;#141318;#30434C;#FFF]\")\r\nend)\r\n```\r\n\r\n-----\r\n* `set_formspec_prepend(formspec)`:\r\n    * the formspec string will be added to every formspec shown to the user.\r\n    * This should be used to set style elements such as background[] and\r\n      bgcolor[], any non-style elements (eg: label) may result in weird behaviour.\r\n    * Only affects formspecs shown after this is called.\r\n* `get_formspec_prepend(formspec)`: returns a formspec string.","created_at":"2018-03-04T17:58:49Z","updated_at":"2018-03-25T16:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c27b164127f8f7283edfe65d6478e7752e46f7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":73368983,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Script%20API","name":"@ Script API","color":"0e8a16","default":false},{"id":471238548,"url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/7099/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/7099/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7099/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/c7f53cfc8779ae57588d4fff3eeb38e8c918ac1f","head":{"label":"rubenwardy:formspecprepend","ref":"formspecprepend","sha":"c7f53cfc8779ae57588d4fff3eeb38e8c918ac1f","user":{"login":"rubenwardy","id":2122943,"avatar_url":"https://avatars2.githubusercontent.com/u/2122943?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenwardy","html_url":"https://github.com/rubenwardy","followers_url":"https://api.github.com/users/rubenwardy/followers","following_url":"https://api.github.com/users/rubenwardy/following{/other_user}","gists_url":"https://api.github.com/users/rubenwardy/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenwardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenwardy/subscriptions","organizations_url":"https://api.github.com/users/rubenwardy/orgs","repos_url":"https://api.github.com/users/rubenwardy/repos","events_url":"https://api.github.com/users/rubenwardy/events{/privacy}","received_events_url":"https://api.github.com/users/rubenwardy/received_events","type":"User","site_admin":false},"repo":{"id":21541807,"name":"minetest","full_name":"rubenwardy/minetest","owner":{"login":"rubenwardy","id":2122943,"avatar_url":"https://avatars2.githubusercontent.com/u/2122943?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenwardy","html_url":"https://github.com/rubenwardy","followers_url":"https://api.github.com/users/rubenwardy/followers","following_url":"https://api.github.com/users/rubenwardy/following{/other_user}","gists_url":"https://api.github.com/users/rubenwardy/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenwardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenwardy/subscriptions","organizations_url":"https://api.github.com/users/rubenwardy/orgs","repos_url":"https://api.github.com/users/rubenwardy/repos","events_url":"https://api.github.com/users/rubenwardy/events{/privacy}","received_events_url":"https://api.github.com/users/rubenwardy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubenwardy/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/rubenwardy/minetest","forks_url":"https://api.github.com/repos/rubenwardy/minetest/forks","keys_url":"https://api.github.com/repos/rubenwardy/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubenwardy/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubenwardy/minetest/teams","hooks_url":"https://api.github.com/repos/rubenwardy/minetest/hooks","issue_events_url":"https://api.github.com/repos/rubenwardy/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/rubenwardy/minetest/events","assignees_url":"https://api.github.com/repos/rubenwardy/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/rubenwardy/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/rubenwardy/minetest/tags","blobs_url":"https://api.github.com/repos/rubenwardy/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubenwardy/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubenwardy/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubenwardy/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubenwardy/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/rubenwardy/minetest/languages","stargazers_url":"https://api.github.com/repos/rubenwardy/minetest/stargazers","contributors_url":"https://api.github.com/repos/rubenwardy/minetest/contributors","subscribers_url":"https://api.github.com/repos/rubenwardy/minetest/subscribers","subscription_url":"https://api.github.com/repos/rubenwardy/minetest/subscription","commits_url":"https://api.github.com/repos/rubenwardy/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubenwardy/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubenwardy/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubenwardy/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubenwardy/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/rubenwardy/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubenwardy/minetest/merges","archive_url":"https://api.github.com/repos/rubenwardy/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubenwardy/minetest/downloads","issues_url":"https://api.github.com/repos/rubenwardy/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/rubenwardy/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/rubenwardy/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/rubenwardy/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubenwardy/minetest/labels{/name}","releases_url":"https://api.github.com/repos/rubenwardy/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/rubenwardy/minetest/deployments","created_at":"2014-07-06T14:43:25Z","updated_at":"2018-03-14T03:25:36Z","pushed_at":"2018-03-24T23:19:09Z","git_url":"git://github.com/rubenwardy/minetest.git","ssh_url":"git@github.com:rubenwardy/minetest.git","clone_url":"https://github.com/rubenwardy/minetest.git","svn_url":"https://github.com/rubenwardy/minetest","homepage":"http://minetest.net/","size":56295,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"540e07e3ef07de760100c2948dc3a756e48b1c72","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game engine with support for survival and crafting. Also see https://github.com/minetest/minetest_game","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2018-03-25T13:13:53Z","pushed_at":"2018-03-25T10:07:24Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":56145,"stargazers_count":3197,"watchers_count":3197,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":890,"mirror_url":null,"archived":false,"open_issues_count":925,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":890,"open_issues":925,"watchers":3197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7099"},"html":{"href":"https://github.com/minetest/minetest/pull/7099"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/7099"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/7099/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7099/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/7099/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/c7f53cfc8779ae57588d4fff3eeb38e8c918ac1f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sfan5"}}