{"action":"created","comment":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/comments/221587238","pull_request_review_id":160268306,"id":221587238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU4NzIzOA==","diff_hunk":"@@ -1,145 +1,67 @@\n import React from 'react'\n import { Button, Grid, Popup } from '@stardust-ui/react'\n \n+class PopupArrowExample extends React.Component<any, any> {\n+  state = { popupOpen: false }\n+\n+  togglePopupState = () => {","path":"docs/src/examples/components/Popup/Variations/PopupExamplePosition.shorthand.tsx","position":7,"original_position":7,"commit_id":"7bdcf292c66409d7d2e6bcefabbade77e8b0511e","original_commit_id":"8862d390e9fabd1bb1bd71b26d2a105233712fbc","user":{"login":"Bugaa92","id":5442794,"node_id":"MDQ6VXNlcjU0NDI3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5442794?v=4","gravatar_id":"","url":"https://api.github.com/users/Bugaa92","html_url":"https://github.com/Bugaa92","followers_url":"https://api.github.com/users/Bugaa92/followers","following_url":"https://api.github.com/users/Bugaa92/following{/other_user}","gists_url":"https://api.github.com/users/Bugaa92/gists{/gist_id}","starred_url":"https://api.github.com/users/Bugaa92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bugaa92/subscriptions","organizations_url":"https://api.github.com/users/Bugaa92/orgs","repos_url":"https://api.github.com/users/Bugaa92/repos","events_url":"https://api.github.com/users/Bugaa92/events{/privacy}","received_events_url":"https://api.github.com/users/Bugaa92/received_events","type":"User","site_admin":false},"body":"I mean examples like this one below where we do not have to add custom logic or handlers for handling basic popup functionality; this used to work in SUIR and I believe we should still have it\r\n\r\n```\r\nimport React from 'react'\r\nimport { Button, Popup } from '@stardust-ui/react'\r\n\r\nconst PopupExample = () => (\r\n  <Popup trigger={<Button icon=\"expand\" />} content=\"Add users to your feed.\" />\r\n)\r\n\r\nexport default PopupExample\r\n```","created_at":"2018-10-01T12:17:54Z","updated_at":"2018-10-01T12:17:55Z","html_url":"https://github.com/stardust-ui/react/pull/282#discussion_r221587238","pull_request_url":"https://api.github.com/repos/stardust-ui/react/pulls/282","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments/221587238"},"html":{"href":"https://github.com/stardust-ui/react/pull/282#discussion_r221587238"},"pull_request":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/282"}},"in_reply_to_id":220904344},"pull_request":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/282","id":218303961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzAzOTYx","html_url":"https://github.com/stardust-ui/react/pull/282","diff_url":"https://github.com/stardust-ui/react/pull/282.diff","patch_url":"https://github.com/stardust-ui/react/pull/282.patch","issue_url":"https://api.github.com/repos/stardust-ui/react/issues/282","number":282,"state":"open","locked":false,"title":"feat(Popup): refactor and add controlled mode","user":{"login":"kuzhelov","id":9024564,"node_id":"MDQ6VXNlcjkwMjQ1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9024564?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzhelov","html_url":"https://github.com/kuzhelov","followers_url":"https://api.github.com/users/kuzhelov/followers","following_url":"https://api.github.com/users/kuzhelov/following{/other_user}","gists_url":"https://api.github.com/users/kuzhelov/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzhelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzhelov/subscriptions","organizations_url":"https://api.github.com/users/kuzhelov/orgs","repos_url":"https://api.github.com/users/kuzhelov/repos","events_url":"https://api.github.com/users/kuzhelov/events{/privacy}","received_events_url":"https://api.github.com/users/kuzhelov/received_events","type":"User","site_admin":false},"body":"### TODO\r\n- [ ] add CHANGELOG entry\r\n- [ ] add CHANGELOG entry for the #218 \r\n\r\n--------------\r\n\r\nThe following issues are aimed to be addressed by the proposed PR:\r\n- simplify logic of `Popup` component\r\n  - reduce amount of abstraction layers (primary reason for that is to simplify logic of refs capturing)\r\n  - eliminate unnecessary props\r\n- address subtle problems with logic\r\n  - it turns out that in RTL mode we were 'flipping' CSS position properties three times (instead of just one), and this RTL positioning could be easily broken with custom component/DOM element being provided as value for `as` prop\r\n  - custom `as` components/elements could cause breaks in ref capturing logic\r\n- introduce controlled mode to `Popup`\r\n  - by adding `open` and `defaultOpen` props","created_at":"2018-09-26T12:50:23Z","updated_at":"2018-10-01T12:17:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb38e6cb30c93d78b36bf51609f26f24ad90e421","assignee":null,"assignees":[],"requested_reviewers":[{"login":"levithomason","id":5067638,"node_id":"MDQ6VXNlcjUwNjc2Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/5067638?v=4","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},{"login":"davezuko","id":6439050,"node_id":"MDQ6VXNlcjY0MzkwNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6439050?v=4","gravatar_id":"","url":"https://api.github.com/users/davezuko","html_url":"https://github.com/davezuko","followers_url":"https://api.github.com/users/davezuko/followers","following_url":"https://api.github.com/users/davezuko/following{/other_user}","gists_url":"https://api.github.com/users/davezuko/gists{/gist_id}","starred_url":"https://api.github.com/users/davezuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezuko/subscriptions","organizations_url":"https://api.github.com/users/davezuko/orgs","repos_url":"https://api.github.com/users/davezuko/repos","events_url":"https://api.github.com/users/davezuko/events{/privacy}","received_events_url":"https://api.github.com/users/davezuko/received_events","type":"User","site_admin":false},{"login":"miroslavstastny","id":9615899,"node_id":"MDQ6VXNlcjk2MTU4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9615899?v=4","gravatar_id":"","url":"https://api.github.com/users/miroslavstastny","html_url":"https://github.com/miroslavstastny","followers_url":"https://api.github.com/users/miroslavstastny/followers","following_url":"https://api.github.com/users/miroslavstastny/following{/other_user}","gists_url":"https://api.github.com/users/miroslavstastny/gists{/gist_id}","starred_url":"https://api.github.com/users/miroslavstastny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miroslavstastny/subscriptions","organizations_url":"https://api.github.com/users/miroslavstastny/orgs","repos_url":"https://api.github.com/users/miroslavstastny/repos","events_url":"https://api.github.com/users/miroslavstastny/events{/privacy}","received_events_url":"https://api.github.com/users/miroslavstastny/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1025396700,"node_id":"MDU6TGFiZWwxMDI1Mzk2NzAw","url":"https://api.github.com/repos/stardust-ui/react/labels/ready%20for%20review","name":"ready for review","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stardust-ui/react/pulls/282/commits","review_comments_url":"https://api.github.com/repos/stardust-ui/react/pulls/282/comments","review_comment_url":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stardust-ui/react/issues/282/comments","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/7bdcf292c66409d7d2e6bcefabbade77e8b0511e","head":{"label":"stardust-ui:feat/refactor-popup","ref":"feat/refactor-popup","sha":"7bdcf292c66409d7d2e6bcefabbade77e8b0511e","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","private":false,"owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-09-30T15:49:40Z","pushed_at":"2018-10-01T11:29:06Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":22248,"stargazers_count":61,"watchers_count":61,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":63,"watchers":61,"default_branch":"master"}},"base":{"label":"stardust-ui:master","ref":"master","sha":"b252a8a3c828282e4e87f5d4557977b8765d945f","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","private":false,"owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-09-30T15:49:40Z","pushed_at":"2018-10-01T11:29:06Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":22248,"stargazers_count":61,"watchers_count":61,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":63,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/282"},"html":{"href":"https://github.com/stardust-ui/react/pull/282"},"issue":{"href":"https://api.github.com/repos/stardust-ui/react/issues/282"},"comments":{"href":"https://api.github.com/repos/stardust-ui/react/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/stardust-ui/react/statuses/7bdcf292c66409d7d2e6bcefabbade77e8b0511e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Bugaa92"}}