{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/185074293","pull_request_review_id":116393784,"id":185074293,"diff_hunk":"@@ -725,7 +729,7 @@ def was_seen(name):\n         } else {\n           throw new Error(xhr.statusText + \" : \" + xhr.responseURL);\n         }\n-      };\n+      }; ","path":"tools/file_packager.py","position":16,"original_position":16,"commit_id":"0654ca870396a74f682e57241f37f1f5db4129fc","original_commit_id":"0654ca870396a74f682e57241f37f1f5db4129fc","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"unneeded space","created_at":"2018-04-30T18:48:05Z","updated_at":"2018-04-30T18:49:12Z","html_url":"https://github.com/kripken/emscripten/pull/6446#discussion_r185074293","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/6446","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/185074293"},"html":{"href":"https://github.com/kripken/emscripten/pull/6446#discussion_r185074293"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6446"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/6446","id":181808411,"html_url":"https://github.com/kripken/emscripten/pull/6446","diff_url":"https://github.com/kripken/emscripten/pull/6446.diff","patch_url":"https://github.com/kripken/emscripten/pull/6446.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/6446","number":6446,"state":"open","locked":false,"title":"Updated the fetchRemotePackage function","user":{"login":"thezillion","id":1927507,"avatar_url":"https://avatars1.githubusercontent.com/u/1927507?v=4","gravatar_id":"","url":"https://api.github.com/users/thezillion","html_url":"https://github.com/thezillion","followers_url":"https://api.github.com/users/thezillion/followers","following_url":"https://api.github.com/users/thezillion/following{/other_user}","gists_url":"https://api.github.com/users/thezillion/gists{/gist_id}","starred_url":"https://api.github.com/users/thezillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezillion/subscriptions","organizations_url":"https://api.github.com/users/thezillion/orgs","repos_url":"https://api.github.com/users/thezillion/repos","events_url":"https://api.github.com/users/thezillion/events{/privacy}","received_events_url":"https://api.github.com/users/thezillion/received_events","type":"User","site_admin":false},"body":"If the Browse is Chrome/Safari/IE the file needs to be served using SimpleHTTPServer or the like. If the html file is run in these browsers, the XHR script throws an error. The XHR open call has been replaced with am if-else block that checks for the browser and protocol and gracefully exits.","created_at":"2018-04-16T09:56:26Z","updated_at":"2018-04-30T18:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29656e42ebabe5313e8a499d237a35281155f385","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/6446/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/6446/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/6446/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/0654ca870396a74f682e57241f37f1f5db4129fc","head":{"label":"thezillion:graceful-cors-file-protocol","ref":"graceful-cors-file-protocol","sha":"0654ca870396a74f682e57241f37f1f5db4129fc","user":{"login":"thezillion","id":1927507,"avatar_url":"https://avatars1.githubusercontent.com/u/1927507?v=4","gravatar_id":"","url":"https://api.github.com/users/thezillion","html_url":"https://github.com/thezillion","followers_url":"https://api.github.com/users/thezillion/followers","following_url":"https://api.github.com/users/thezillion/following{/other_user}","gists_url":"https://api.github.com/users/thezillion/gists{/gist_id}","starred_url":"https://api.github.com/users/thezillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezillion/subscriptions","organizations_url":"https://api.github.com/users/thezillion/orgs","repos_url":"https://api.github.com/users/thezillion/repos","events_url":"https://api.github.com/users/thezillion/events{/privacy}","received_events_url":"https://api.github.com/users/thezillion/received_events","type":"User","site_admin":false},"repo":{"id":129721191,"name":"emscripten","full_name":"thezillion/emscripten","owner":{"login":"thezillion","id":1927507,"avatar_url":"https://avatars1.githubusercontent.com/u/1927507?v=4","gravatar_id":"","url":"https://api.github.com/users/thezillion","html_url":"https://github.com/thezillion","followers_url":"https://api.github.com/users/thezillion/followers","following_url":"https://api.github.com/users/thezillion/following{/other_user}","gists_url":"https://api.github.com/users/thezillion/gists{/gist_id}","starred_url":"https://api.github.com/users/thezillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezillion/subscriptions","organizations_url":"https://api.github.com/users/thezillion/orgs","repos_url":"https://api.github.com/users/thezillion/repos","events_url":"https://api.github.com/users/thezillion/events{/privacy}","received_events_url":"https://api.github.com/users/thezillion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thezillion/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/thezillion/emscripten","forks_url":"https://api.github.com/repos/thezillion/emscripten/forks","keys_url":"https://api.github.com/repos/thezillion/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thezillion/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thezillion/emscripten/teams","hooks_url":"https://api.github.com/repos/thezillion/emscripten/hooks","issue_events_url":"https://api.github.com/repos/thezillion/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/thezillion/emscripten/events","assignees_url":"https://api.github.com/repos/thezillion/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/thezillion/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/thezillion/emscripten/tags","blobs_url":"https://api.github.com/repos/thezillion/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thezillion/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thezillion/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/thezillion/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thezillion/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/thezillion/emscripten/languages","stargazers_url":"https://api.github.com/repos/thezillion/emscripten/stargazers","contributors_url":"https://api.github.com/repos/thezillion/emscripten/contributors","subscribers_url":"https://api.github.com/repos/thezillion/emscripten/subscribers","subscription_url":"https://api.github.com/repos/thezillion/emscripten/subscription","commits_url":"https://api.github.com/repos/thezillion/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/thezillion/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/thezillion/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/thezillion/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/thezillion/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/thezillion/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thezillion/emscripten/merges","archive_url":"https://api.github.com/repos/thezillion/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thezillion/emscripten/downloads","issues_url":"https://api.github.com/repos/thezillion/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/thezillion/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/thezillion/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/thezillion/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thezillion/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/thezillion/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/thezillion/emscripten/deployments","created_at":"2018-04-16T09:49:33Z","updated_at":"2018-04-16T09:49:54Z","pushed_at":"2018-04-17T04:40:25Z","git_url":"git://github.com/thezillion/emscripten.git","ssh_url":"git@github.com:thezillion/emscripten.git","clone_url":"https://github.com/thezillion/emscripten.git","svn_url":"https://github.com/thezillion/emscripten","homepage":"","size":158961,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"incoming"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"40584e0e4f65c2ad5056a5b4f6916934e7f4957a","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/kripken/emscripten/deployments","created_at":"2011-02-12T05:23:30Z","updated_at":"2018-04-30T18:39:10Z","pushed_at":"2018-04-30T18:35:46Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":159164,"stargazers_count":14564,"watchers_count":14564,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":1444,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1722,"open_issues":1444,"watchers":14564,"default_branch":"incoming"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6446"},"html":{"href":"https://github.com/kripken/emscripten/pull/6446"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/6446"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/6446/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6446/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6446/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/0654ca870396a74f682e57241f37f1f5db4129fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"kripken"}}