{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/47120","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/47120/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47120/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/47120/events","html_url":"https://github.com/saltstack/salt/pull/47120","id":315073659,"number":47120,"title":"Use correct path to ipaddress","user":{"login":"thkukuk","id":5908016,"avatar_url":"https://avatars3.githubusercontent.com/u/5908016?v=4","gravatar_id":"","url":"https://api.github.com/users/thkukuk","html_url":"https://github.com/thkukuk","followers_url":"https://api.github.com/users/thkukuk/followers","following_url":"https://api.github.com/users/thkukuk/following{/other_user}","gists_url":"https://api.github.com/users/thkukuk/gists{/gist_id}","starred_url":"https://api.github.com/users/thkukuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thkukuk/subscriptions","organizations_url":"https://api.github.com/users/thkukuk/orgs","repos_url":"https://api.github.com/users/thkukuk/repos","events_url":"https://api.github.com/users/thkukuk/events{/privacy}","received_events_url":"https://api.github.com/users/thkukuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-17T14:01:19Z","updated_at":"2018-04-18T15:13:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47120","html_url":"https://github.com/saltstack/salt/pull/47120","diff_url":"https://github.com/saltstack/salt/pull/47120.diff","patch_url":"https://github.com/saltstack/salt/pull/47120.patch"},"body":"### What does this PR do?\r\nFix call of ipaddress.ip_network, so that network.default_route does not throw an exception.\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://bugzilla.suse.com/show_bug.cgi?id=1089501\r\n\r\n### Previous Behavior\r\nnetwork.default_route throws exception\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n### Commits signed with GPG?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/382422546","html_url":"https://github.com/saltstack/salt/pull/47120#issuecomment-382422546","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47120","id":382422546,"user":{"login":"thkukuk","id":5908016,"avatar_url":"https://avatars3.githubusercontent.com/u/5908016?v=4","gravatar_id":"","url":"https://api.github.com/users/thkukuk","html_url":"https://github.com/thkukuk","followers_url":"https://api.github.com/users/thkukuk/followers","following_url":"https://api.github.com/users/thkukuk/following{/other_user}","gists_url":"https://api.github.com/users/thkukuk/gists{/gist_id}","starred_url":"https://api.github.com/users/thkukuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thkukuk/subscriptions","organizations_url":"https://api.github.com/users/thkukuk/orgs","repos_url":"https://api.github.com/users/thkukuk/repos","events_url":"https://api.github.com/users/thkukuk/events{/privacy}","received_events_url":"https://api.github.com/users/thkukuk/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T15:13:44Z","updated_at":"2018-04-18T15:13:44Z","author_association":"NONE","body":"On Wed, Apr 18, Mike Place wrote:\n\n> This doesn't seem like the right fix to me. That module and function are most\n> certainly present. Do you not see them present in your installation?\n\nThe module and function are loaded into the ipaddress namespace, not\nsalt.ext. Please look at the import statement in the beginning of that\nsoruce file. So salt.ext.ipaddress does not exist. In all other places,\nonly ipaddress is used, too.\n\n[ERROR   ] An un-handled exception was caught by salt's global exception handler:\nAttributeError: module 'salt.ext' has no attribute 'ipaddress'\nTraceback (most recent call last):\n  File \"/usr/bin/salt-call\", line 11, in <module>\n    salt_call()\n  File \"/usr/lib/python3.6/site-packages/salt/scripts.py\", line 400, in salt_call\n    client.run()\n  File \"/usr/lib/python3.6/site-packages/salt/cli/call.py\", line 57, in run\n    caller.run()\n  File \"/usr/lib/python3.6/site-packages/salt/cli/caller.py\", line 134, in run\n    ret = self.call()\n  File \"/usr/lib/python3.6/site-packages/salt/cli/caller.py\", line 212, in call\n    ret['return'] = func(*args, **kwargs)\n  File \"/usr/lib/python3.6/site-packages/salt/modules/network.py\", line 1662, in default_route\n    _routes = routes()\n  File \"/usr/lib/python3.6/site-packages/salt/modules/network.py\", line 1619, in routes\n    routes_ = _ip_route_linux()\n  File \"/usr/lib/python3.6/site-packages/salt/modules/network.py\", line 518, in _ip_route_linux\n    address_mask = convert_cidr(comps[0])\n  File \"/usr/lib/python3.6/site-packages/salt/modules/network.py\", line 1143, in convert_cidr\n    network_info = salt.ext.ipaddress.ip_network(cidr)\nAttributeError: module 'salt.ext' has no attribute 'ipaddress'\n\n\n\n\n-- \nThorsten Kukuk, Distinguished Engineer, Senior Architect SLES & CaaSP\nSUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany\nGF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)\n"}}
{"actor":{"display_login":"thkukuk"}}