{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/1969","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/1969/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1969/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/1969/events","html_url":"https://github.com/ocaml/ocaml/pull/1969","id":347864011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzUyNjA1","number":1969,"title":"Simplify error messages for illegal includes","user":{"login":"Octachron","id":7689388,"node_id":"MDQ6VXNlcjc2ODkzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/7689388?v=4","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"labels":[{"id":489423308,"node_id":"MDU6TGFiZWw0ODk0MjMzMDg=","url":"https://api.github.com/repos/ocaml/ocaml/labels/no-change-entry-needed","name":"no-change-entry-needed","color":"FFFFFF","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-06T10:18:48Z","updated_at":"2018-08-07T08:34:08Z","closed_at":"2018-08-07T08:34:08Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1969","html_url":"https://github.com/ocaml/ocaml/pull/1969","diff_url":"https://github.com/ocaml/ocaml/pull/1969.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1969.patch"},"body":"This small PR proposes to replace\r\n\r\n> Error: Illegal shadowing of included type t/1143 by t/1147\r\n       File \"cannot_shadow_error.ml\", line 22, characters 2-19:\r\n         Type t/1143 came from this include\r\n       File \"cannot_shadow_error.ml\", line 13, characters 2-43:\r\n         The value print has no valid type if t/1143 is shadowed\r\n\r\nwith\r\n\r\n> Error: Illegal shadowing of included type t/1 by t/2\r\n       File \"cannot_shadow_error.ml\", line 22, characters 2-19:\r\n         Type t/1 came from this include\r\n       File \"cannot_shadow_error.ml\", line 13, characters 2-43:\r\n         The value print has no valid type if t/1 is shadowed\r\n\r\nIn this simplified error message, the ident stamps (1143/1147) have been replaced by 1/2 since they bring little information for ordinary users and they make it very easy to break the testsuite (cf #1956, #1959 ) . \r\n\r\nNote that another option in term of implementation would be to use the name collision mechanism of `Printtyp`."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/410978848","html_url":"https://github.com/ocaml/ocaml/pull/1969#issuecomment-410978848","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1969","id":410978848,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDk3ODg0OA==","user":{"login":"Octachron","id":7689388,"node_id":"MDQ6VXNlcjc2ODkzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/7689388?v=4","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T08:34:08Z","updated_at":"2018-08-07T08:34:08Z","author_association":"CONTRIBUTOR","body":"Let's close this PR. Once the alternative is implemented, I will open a mantis ticket on the conflicting nomenclature used by printtyp and the illegal shadowing include for name collisions."}}
{"actor":{"display_login":"Octachron"}}