{"action":"opened","issue":{"url":"https://api.github.com/repos/FStarLang/FStar/issues/1490","repository_url":"https://api.github.com/repos/FStarLang/FStar","labels_url":"https://api.github.com/repos/FStarLang/FStar/issues/1490/labels{/name}","comments_url":"https://api.github.com/repos/FStarLang/FStar/issues/1490/comments","events_url":"https://api.github.com/repos/FStarLang/FStar/issues/1490/events","html_url":"https://github.com/FStarLang/FStar/issues/1490","id":338780054,"node_id":"MDU6SXNzdWUzMzg3ODAwNTQ=","number":1490,"title":"Use full hash when reporting git commit ","user":{"login":"parno","id":1816417,"node_id":"MDQ6VXNlcjE4MTY0MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1816417?v=4","gravatar_id":"","url":"https://api.github.com/users/parno","html_url":"https://github.com/parno","followers_url":"https://api.github.com/users/parno/followers","following_url":"https://api.github.com/users/parno/following{/other_user}","gists_url":"https://api.github.com/users/parno/gists{/gist_id}","starred_url":"https://api.github.com/users/parno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parno/subscriptions","organizations_url":"https://api.github.com/users/parno/orgs","repos_url":"https://api.github.com/users/parno/repos","events_url":"https://api.github.com/users/parno/events{/privacy}","received_events_url":"https://api.github.com/users/parno/received_events","type":"User","site_admin":false},"labels":[{"id":90066078,"node_id":"MDU6TGFiZWw5MDA2NjA3OA==","url":"https://api.github.com/repos/FStarLang/FStar/labels/kind/enhancement","name":"kind/enhancement","color":"fef2c0","default":false},{"id":258451056,"node_id":"MDU6TGFiZWwyNTg0NTEwNTY=","url":"https://api.github.com/repos/FStarLang/FStar/labels/priority/low","name":"priority/low","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-06T02:03:28Z","updated_at":"2018-07-06T02:03:28Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is a minor tweak, but it would be helpful if F*, when reporting version information with `--version`, reported the full git commit hash.  At the moment, it's reporting a truncated hash, and the length of the truncation seems to vary based on which git client you're using (we've seen 5, 9, and 10 characters for the same git commit) and how many objects the F* repository has in it (see https://forum.lede-project.org/t/git-2-11-and-commit-hash-abbrev-length/532 for fun details).  This makes it tricky to communicate and mechanically check the F* version across different developer machines.\r\n\r\nI don't pretend to understand how F* gets built, but my best guess is that if, in this line:\r\nhttps://github.com/FStarLang/FStar/blob/master/src/tools/get_commit#L3\r\nyou change the `%h` to `%H`, then the right thing might happen."}}
{"actor":{"display_login":"parno"}}