{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46934","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46934/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46934/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46934/events","html_url":"https://github.com/kubernetes/kubernetes/issues/46934","id":233429070,"number":46934,"title":"Consider moving rollback out of the Deployment controller","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"labels":[{"id":382474515,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/workload-api/deployment","name":"area/workload-api/deployment","color":"0052cc","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":122775691,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":114528223,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":404091735,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false}],"state":"closed","locked":false,"assignee":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars1.githubusercontent.com/u/4876867?v=4","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"assignees":[{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars1.githubusercontent.com/u/4876867?v=4","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},{"login":"kow3ns","id":11380896,"avatar_url":"https://avatars3.githubusercontent.com/u/11380896?v=4","gravatar_id":"","url":"https://api.github.com/users/kow3ns","html_url":"https://github.com/kow3ns","followers_url":"https://api.github.com/users/kow3ns/followers","following_url":"https://api.github.com/users/kow3ns/following{/other_user}","gists_url":"https://api.github.com/users/kow3ns/gists{/gist_id}","starred_url":"https://api.github.com/users/kow3ns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kow3ns/subscriptions","organizations_url":"https://api.github.com/users/kow3ns/orgs","repos_url":"https://api.github.com/users/kow3ns/repos","events_url":"https://api.github.com/users/kow3ns/events{/privacy}","received_events_url":"https://api.github.com/users/kow3ns/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2017-06-04T11:57:01Z","updated_at":"2018-02-27T21:04:49Z","closed_at":"2018-02-27T21:04:49Z","author_association":"MEMBER","body":"Currently, in order for a Deployment to rollback:\r\ni. a user needs to set `d.spec.rollbackTo.revision`\r\nii. the controller notices the populated rollback spec and it updates the pod template of the deployment plus it cleans up the `rollbackTo` field.\r\n\r\nStep ii. is breaking the declarative model for the Deployment API. We should consider dropping `rollbackTo` from the spec and instead either 1. make the `deployments/{name}/rollback` endpoint perform the rollback or 2. have the rollback endpoint simply return a dry-run of the rolled back Deployment which then clients can PUT.\r\n\r\nIf we do 1. we need an option for dry-run, 2. is what we do in OpenShift.\r\n\r\n@kubernetes/sig-apps-api-reviews \r\n\r\nps. sparked by the decision to have rollback client-side initially for DaemonSets and StatefulSets."}}
{"actor":{"display_login":"k8s-ci-robot"}}