{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments/238038471","pull_request_review_id":180495463,"id":238038471,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODAzODQ3MQ==","diff_hunk":"@@ -234,4 +235,60 @@ export class SubscriptionClient extends Client {\n     return this._context.managementClient!.receiveDeferredMessages(sequenceNumbers,\n       this.receiveMode);\n   }\n+\n+  //#region topic-filters\n+\n+  /**\n+   * Get all the rules associated with the subscription\n+   */\n+  async getRules(): Promise<RuleDescription[]> {\n+    return this._context.managementClient!.getRules();\n+  }\n+\n+  /**\n+   * Removes the rule on the subscription identified by the given rule name.\n+   * @param ruleName\n+   */\n+  async removeRule(ruleName: string): Promise<void> {\n+    return this._context.managementClient!.removeRule(ruleName);\n+  }\n+\n+  /**\n+   * Adds a rule on the subscription as defined by the given rule name, filter and action\n+   * @param ruleName Name of the rule\n+   * @param filter true or false\n+   * @param sqlRuleActionExpression Action to perform if the message satisfies the filtering expression\n+   */\n+  async addBooleanRule(ruleName: string, filter: boolean, sqlRuleActionExpression?: string): Promise<void> {","path":"lib/subscriptionClient.ts","position":36,"original_position":36,"commit_id":"81e8db78d445ec94cc4148b3d3e4aac998087df0","original_commit_id":"81e8db78d445ec94cc4148b3d3e4aac998087df0","user":{"login":"ramya-rao-a","id":16890566,"node_id":"MDQ6VXNlcjE2ODkwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/16890566?v=4","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"body":"I am also debating having a single addRule vs multiple. The single one would look like\r\n\r\n`async addRule(ruleName, filter: boolean|SQLFilter|CorrelationFilter, sqlRuleActionExpression?: string): Promise<void>`","created_at":"2018-12-01T00:11:29Z","updated_at":"2018-12-01T00:11:29Z","html_url":"https://github.com/Azure/azure-service-bus-node/pull/24#discussion_r238038471","pull_request_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments/238038471"},"html":{"href":"https://github.com/Azure/azure-service-bus-node/pull/24#discussion_r238038471"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24","id":234490965,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDkwOTY1","html_url":"https://github.com/Azure/azure-service-bus-node/pull/24","diff_url":"https://github.com/Azure/azure-service-bus-node/pull/24.diff","patch_url":"https://github.com/Azure/azure-service-bus-node/pull/24.patch","issue_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/24","number":24,"state":"open","locked":false,"title":"Implement Topic Filters","user":{"login":"ramya-rao-a","id":16890566,"node_id":"MDQ6VXNlcjE2ODkwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/16890566?v=4","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"body":"This PR adds support to features listed in #12 i.e Topic Filters\r\n\r\n","created_at":"2018-11-29T02:45:24Z","updated_at":"2018-12-01T00:11:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"253c86b0d902b3d19f76fb0122fa0b762d6df874","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amarzavery","id":4521223,"node_id":"MDQ6VXNlcjQ1MjEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4521223?v=4","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/24/comments","statuses_url":"https://api.github.com/repos/Azure/azure-service-bus-node/statuses/81e8db78d445ec94cc4148b3d3e4aac998087df0","head":{"label":"ramya-rao-a:topic-filter","ref":"topic-filter","sha":"81e8db78d445ec94cc4148b3d3e4aac998087df0","user":{"login":"ramya-rao-a","id":16890566,"node_id":"MDQ6VXNlcjE2ODkwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/16890566?v=4","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"repo":{"id":158473903,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0NzM5MDM=","name":"azure-service-bus-node","full_name":"ramya-rao-a/azure-service-bus-node","private":false,"owner":{"login":"ramya-rao-a","id":16890566,"node_id":"MDQ6VXNlcjE2ODkwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/16890566?v=4","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ramya-rao-a/azure-service-bus-node","description":null,"fork":true,"url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node","forks_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/forks","keys_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/teams","hooks_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/hooks","issue_events_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/issues/events{/number}","events_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/events","assignees_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/assignees{/user}","branches_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/branches{/branch}","tags_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/tags","blobs_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/statuses/{sha}","languages_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/languages","stargazers_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/stargazers","contributors_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/contributors","subscribers_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/subscribers","subscription_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/subscription","commits_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/contents/{+path}","compare_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/merges","archive_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/downloads","issues_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/issues{/number}","pulls_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/pulls{/number}","milestones_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/milestones{/number}","notifications_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/labels{/name}","releases_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/releases{/id}","deployments_url":"https://api.github.com/repos/ramya-rao-a/azure-service-bus-node/deployments","created_at":"2018-11-21T01:34:24Z","updated_at":"2018-11-21T01:34:26Z","pushed_at":"2018-11-30T23:13:25Z","git_url":"git://github.com/ramya-rao-a/azure-service-bus-node.git","ssh_url":"git@github.com:ramya-rao-a/azure-service-bus-node.git","clone_url":"https://github.com/ramya-rao-a/azure-service-bus-node.git","svn_url":"https://github.com/ramya-rao-a/azure-service-bus-node","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"1098ee68217bb3614f73315e4bfefe0d18d6d4e9","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":71311975,"node_id":"MDEwOlJlcG9zaXRvcnk3MTMxMTk3NQ==","name":"azure-service-bus-node","full_name":"Azure/azure-service-bus-node","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-service-bus-node","description":null,"fork":false,"url":"https://api.github.com/repos/Azure/azure-service-bus-node","forks_url":"https://api.github.com/repos/Azure/azure-service-bus-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-service-bus-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-service-bus-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-service-bus-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-service-bus-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-service-bus-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-service-bus-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-service-bus-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-service-bus-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-service-bus-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-service-bus-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-service-bus-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-service-bus-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-service-bus-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-service-bus-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-service-bus-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-service-bus-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-service-bus-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-service-bus-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-service-bus-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-service-bus-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-service-bus-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-service-bus-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-service-bus-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-service-bus-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-service-bus-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-service-bus-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-service-bus-node/deployments","created_at":"2016-10-19T02:42:46Z","updated_at":"2018-11-22T03:26:01Z","pushed_at":"2018-11-30T23:13:26Z","git_url":"git://github.com/Azure/azure-service-bus-node.git","ssh_url":"git@github.com:Azure/azure-service-bus-node.git","clone_url":"https://github.com/Azure/azure-service-bus-node.git","svn_url":"https://github.com/Azure/azure-service-bus-node","homepage":null,"size":276,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24"},"html":{"href":"https://github.com/Azure/azure-service-bus-node/pull/24"},"issue":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/24"},"comments":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-service-bus-node/statuses/81e8db78d445ec94cc4148b3d3e4aac998087df0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ramya-rao-a"}}