{"action":"created","issue":{"url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113","repository_url":"https://api.github.com/repos/Prospress/action-scheduler","labels_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113/comments","events_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113/events","html_url":"https://github.com/Prospress/action-scheduler/pull/113","id":304564911,"number":113,"title":"Add new Admin UI using data store instead of post APIs","user":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"labels":[{"id":866147833,"url":"https://api.github.com/repos/Prospress/action-scheduler/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"e2c75a","default":false}],"state":"open","locked":false,"assignee":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"assignees":[{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},{"login":"JPry","id":871924,"avatar_url":"https://avatars0.githubusercontent.com/u/871924?v=4","gravatar_id":"","url":"https://api.github.com/users/JPry","html_url":"https://github.com/JPry","followers_url":"https://api.github.com/users/JPry/followers","following_url":"https://api.github.com/users/JPry/following{/other_user}","gists_url":"https://api.github.com/users/JPry/gists{/gist_id}","starred_url":"https://api.github.com/users/JPry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPry/subscriptions","organizations_url":"https://api.github.com/users/JPry/orgs","repos_url":"https://api.github.com/users/JPry/repos","events_url":"https://api.github.com/users/JPry/events{/privacy}","received_events_url":"https://api.github.com/users/JPry/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Prospress/action-scheduler/milestones/1","html_url":"https://github.com/Prospress/action-scheduler/milestone/1","labels_url":"https://api.github.com/repos/Prospress/action-scheduler/milestones/1/labels","id":2522584,"number":1,"title":"2.0","description":"","creator":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2017-05-15T21:02:31Z","updated_at":"2018-03-16T17:22:59Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-03-12T22:34:00Z","updated_at":"2018-04-13T19:36:30Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113","html_url":"https://github.com/Prospress/action-scheduler/pull/113","diff_url":"https://github.com/Prospress/action-scheduler/pull/113.diff","patch_url":"https://github.com/Prospress/action-scheduler/pull/113.patch"},"body":"This is a redo of PR #88 for Issue #85. I'm opening a new PR as #88 has become unwieldy in its history. This PR has merged `1-6-dev` (I couldn't rebase without losing subtree data for the pp list table), and adds additional commits to add sortable columns, display Claim ID and a few other patches to bring the admin UI closer to completeness. The only feature remaining for it to have feature parity with the old admin UI and close #85 is a _Search_ box.\r\n\r\nThis PR also negates #110, which attempted to solve the problem of accessing an actions data by moving that data into the action itself. The changes required to achieve that are excessive, so I've opted to return to the approach of using the data store for accessing that data, as it is much cleaner for now. It also avoids issues like whether data on the action should be changed, e.g. if it's a _pending_ action's status should be changed to _completed_ after `execute()` is called - something which makes sense, but which is an entirely new paradigm for Action Scheduler, and which may have unforeseen implications.\r\n\r\nThis PR is ready for review, but I'd encourage you to avoid reviewing the commit history, as it's still unwieldy."},"comment":{"url":"https://api.github.com/repos/Prospress/action-scheduler/issues/comments/381240566","html_url":"https://github.com/Prospress/action-scheduler/pull/113#issuecomment-381240566","issue_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113","id":381240566,"user":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T19:36:30Z","updated_at":"2018-04-13T19:36:30Z","author_association":"OWNER","body":"I've just added some more commits to this monstrosity. See 591f664...6925e1d. The most notable items are:\r\n\r\n* fixes to display of the next schedule date, and row actions on pending actions\r\n* addition of a search box\r\n* removal of the `'all'` status concept\r\n\r\nI've also extended the `PP_List_Table` class and cleaned it up a little so that it takes care of a bit more common work, like displaying status filters.\r\n\r\nWhile the code (and docblocks etc.) here could still use a lot of cleaning up, it's ready for review and with the addition of the _Search_ box, it now checks off all items on #85."}}
{"actor":{"display_login":"thenbrent"}}