{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70992","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70992/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70992/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70992/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70992","id":380151459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDE3NTg3","number":70992,"title":"e2e/storage: avoid definining unusable tests","user":{"login":"pohly","id":22076,"node_id":"MDQ6VXNlcjIyMDc2","avatar_url":"https://avatars1.githubusercontent.com/u/22076?v=4","gravatar_id":"","url":"https://api.github.com/users/pohly","html_url":"https://github.com/pohly","followers_url":"https://api.github.com/users/pohly/followers","following_url":"https://api.github.com/users/pohly/following{/other_user}","gists_url":"https://api.github.com/users/pohly/gists{/gist_id}","starred_url":"https://api.github.com/users/pohly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pohly/subscriptions","organizations_url":"https://api.github.com/users/pohly/orgs","repos_url":"https://api.github.com/users/pohly/repos","events_url":"https://api.github.com/users/pohly/events{/privacy}","received_events_url":"https://api.github.com/users/pohly/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"node_id":"MDU6TGFiZWw2ODc1NjU4MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":496752236,"node_id":"MDU6TGFiZWw0OTY3NTIyMzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-longterm","name":"priority/important-longterm","color":"eb6420","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"msau42","id":24448061,"node_id":"MDQ6VXNlcjI0NDQ4MDYx","avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false},"assignees":[{"login":"msau42","id":24448061,"node_id":"MDQ6VXNlcjI0NDQ4MDYx","avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-11-13T10:15:56Z","updated_at":"2018-11-30T07:39:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70992","html_url":"https://github.com/kubernetes/kubernetes/pull/70992","diff_url":"https://github.com/kubernetes/kubernetes/pull/70992.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70992.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n/kind cleanup\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAfter the recent `test/e2e/storage` refactoring (merged for 1.13), a lot of tests get defined that can only run with specific cluster providers. Those tests then get skipped at runtime. Even tests that get skipped take time (test setup, creating client set or worse, deploying the driver if the driver needs that) and the list of skipped tests in the CI grew a lot without adding any information (skip reason not captured). Therefore this PR:\r\n- enables the definition of tests depending on the test context\r\n- changes the \"skip test\" API so that test definition gets skipped, while still allowing runtime skipping\r\n- changes the CSI and in-tree drivers to skip definition as much as possible\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis contains PR #70862 because of code conflicts, so that PR must be merged first.\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n/sig storage\r\n/cc @mkimuram \r\n/assign @msau42 \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/443118428","html_url":"https://github.com/kubernetes/kubernetes/pull/70992#issuecomment-443118428","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70992","id":443118428,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzExODQyOA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T07:39:57Z","updated_at":"2018-11-30T07:39:57Z","author_association":"CONTRIBUTOR","body":"@pohly: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce-device-plugin-gpu | 41616b5ed02c1a833215a899a38f4716335cda39 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70992/pull-kubernetes-e2e-gce-device-plugin-gpu/54516/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-gce | 41616b5ed02c1a833215a899a38f4716335cda39 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70992/pull-kubernetes-e2e-gce/61433/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-bazel-build | 41616b5ed02c1a833215a899a38f4716335cda39 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70992/pull-kubernetes-bazel-build/66400/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-kubemark-e2e-gce-big | 41616b5ed02c1a833215a899a38f4716335cda39 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70992/pull-kubernetes-kubemark-e2e-gce-big/30830/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-typecheck | 41616b5ed02c1a833215a899a38f4716335cda39 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70992/pull-kubernetes-typecheck/33319/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-e2e-kops-aws | 41616b5ed02c1a833215a899a38f4716335cda39 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70992/pull-kubernetes-e2e-kops-aws/115378/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://gubernator.k8s.io/pr/70992). [Your PR dashboard](https://gubernator.k8s.io/pr/pohly). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}