{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/14119","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/14119/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/14119/comments","events_url":"https://api.github.com/repos/facebook/react/issues/14119/events","html_url":"https://github.com/facebook/react/pull/14119","id":377725766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTk4OTc2","number":14119,"title":"Restrict effect return type to a function or nothing","user":{"login":"acdlite","id":3624098,"node_id":"MDQ6VXNlcjM2MjQwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-06T07:41:33Z","updated_at":"2018-11-06T19:29:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/14119","html_url":"https://github.com/facebook/react/pull/14119","diff_url":"https://github.com/facebook/react/pull/14119.diff","patch_url":"https://github.com/facebook/react/pull/14119.patch"},"body":"We already warn in dev if the wrong type is returned. This updates the Flow type."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/436378579","html_url":"https://github.com/facebook/react/pull/14119#issuecomment-436378579","issue_url":"https://api.github.com/repos/facebook/react/issues/14119","id":436378579,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjM3ODU3OQ==","user":{"login":"acdlite","id":3624098,"node_id":"MDQ6VXNlcjM2MjQwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T19:29:20Z","updated_at":"2018-11-06T19:29:20Z","author_association":"MEMBER","body":"> Also the return value from the destroy function itself should always be void.\r\n\r\nThat's can be annoying if you use an arrow function. For example, sometimes \"destroy\" -type functions return a boolean:\r\n\r\n```js\r\nuseEffect(() => {\r\n  mySet.add(thing);\r\n  return () => mySet.delete(thing);\r\n});\r\n```"}}
{"actor":{"display_login":"acdlite"}}