{"action":"created","issue":{"url":"https://api.github.com/repos/pennlabs/components/issues/2","repository_url":"https://api.github.com/repos/pennlabs/components","labels_url":"https://api.github.com/repos/pennlabs/components/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/pennlabs/components/issues/2/comments","events_url":"https://api.github.com/repos/pennlabs/components/issues/2/events","html_url":"https://github.com/pennlabs/components/pull/2","id":369395185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzQ2NDM5","number":2,"title":"[WIP] Improvements + Discussion","user":{"login":"LeoNero","id":7756101,"node_id":"MDQ6VXNlcjc3NTYxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7756101?v=4","gravatar_id":"","url":"https://api.github.com/users/LeoNero","html_url":"https://github.com/LeoNero","followers_url":"https://api.github.com/users/LeoNero/followers","following_url":"https://api.github.com/users/LeoNero/following{/other_user}","gists_url":"https://api.github.com/users/LeoNero/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoNero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoNero/subscriptions","organizations_url":"https://api.github.com/users/LeoNero/orgs","repos_url":"https://api.github.com/users/LeoNero/repos","events_url":"https://api.github.com/users/LeoNero/events{/privacy}","received_events_url":"https://api.github.com/users/LeoNero/received_events","type":"User","site_admin":false},"labels":[{"id":1044466258,"node_id":"MDU6TGFiZWwxMDQ0NDY2MjU4","url":"https://api.github.com/repos/pennlabs/components/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1044466259,"node_id":"MDU6TGFiZWwxMDQ0NDY2MjU5","url":"https://api.github.com/repos/pennlabs/components/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T04:30:18Z","updated_at":"2018-10-12T17:22:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pennlabs/components/pulls/2","html_url":"https://github.com/pennlabs/components/pull/2","diff_url":"https://github.com/pennlabs/components/pull/2.diff","patch_url":"https://github.com/pennlabs/components/pull/2.patch"},"body":"Hey! I decided to explore the project during fall break and see how to improve it. I ended up doing the following thing and would like to discuss them with the team :DDDD\r\n\r\n### Things I did\r\n- moved some packages to devDeps and added some packages do peerDeps\r\n- removed ^ from package (because we can't trust the people behind the packages follow Semantic Versioning in the right way...)\r\n- moved /components to /src\r\n- added eslint and prop-types\r\n- removed Button component (it did nothing :P I thought it would be better to do it again from scratch)\r\n- remove login and signup forms (they were very similar and, according to eslint, were not following some accessibility rules :/ I thought it would be better to do them again from scratch)\r\n\r\n\r\n### Things that can improve the project and questions\r\n- add CircleCI\r\n- add storybook's action addon\r\n- improve /stories structure\r\n- see what else we can add to package.json [https://docs.npmjs.com/files/package.json](https://docs.npmjs.com/files/package.json)\r\n- add Rollup in order to create production bundles (/dist folder)\r\n- add Babel\r\n- add Jest, Enzyme and discuss about a test workflow\r\n- add Docz\r\n- is docker necessary?\r\n\r\n\r\nWhat do you guys think about each thing? Are they necessary now? :)"},"comment":{"url":"https://api.github.com/repos/pennlabs/components/issues/comments/429399014","html_url":"https://github.com/pennlabs/components/pull/2#issuecomment-429399014","issue_url":"https://api.github.com/repos/pennlabs/components/issues/2","id":429399014,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTM5OTAxNA==","user":{"login":"kirubarajan","id":6424868,"node_id":"MDQ6VXNlcjY0MjQ4Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/6424868?v=4","gravatar_id":"","url":"https://api.github.com/users/kirubarajan","html_url":"https://github.com/kirubarajan","followers_url":"https://api.github.com/users/kirubarajan/followers","following_url":"https://api.github.com/users/kirubarajan/following{/other_user}","gists_url":"https://api.github.com/users/kirubarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/kirubarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirubarajan/subscriptions","organizations_url":"https://api.github.com/users/kirubarajan/orgs","repos_url":"https://api.github.com/users/kirubarajan/repos","events_url":"https://api.github.com/users/kirubarajan/events{/privacy}","received_events_url":"https://api.github.com/users/kirubarajan/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T17:22:11Z","updated_at":"2018-10-12T17:22:11Z","author_association":"CONTRIBUTOR","body":"Wow! Lot's of good progress (and I'm a big fan of the commit message convention). I'll clone and address some of the points before today's meeting. We can merge then."}}
{"actor":{"display_login":"kirubarajan"}}