{"action":"created","issue":{"url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4509","repository_url":"https://api.github.com/repos/metasfresh/metasfresh","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4509/labels{/name}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4509/comments","events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4509/events","html_url":"https://github.com/metasfresh/metasfresh/issues/4509","id":352936182,"node_id":"MDU6SXNzdWUzNTI5MzYxODI=","number":4509,"title":"NPE in Compensation Groups creation","user":{"login":"metas-rc","id":16001442,"node_id":"MDQ6VXNlcjE2MDAxNDQy","avatar_url":"https://avatars3.githubusercontent.com/u/16001442?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-rc","html_url":"https://github.com/metas-rc","followers_url":"https://api.github.com/users/metas-rc/followers","following_url":"https://api.github.com/users/metas-rc/following{/other_user}","gists_url":"https://api.github.com/users/metas-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-rc/subscriptions","organizations_url":"https://api.github.com/users/metas-rc/orgs","repos_url":"https://api.github.com/users/metas-rc/repos","events_url":"https://api.github.com/users/metas-rc/events{/privacy}","received_events_url":"https://api.github.com/users/metas-rc/received_events","type":"User","site_admin":false},"labels":[{"id":536706344,"node_id":"MDU6TGFiZWw1MzY3MDYzNDQ=","url":"https://api.github.com/repos/metasfresh/metasfresh/labels/branch:master","name":"branch:master","color":"0e8a16","default":false},{"id":269476094,"node_id":"MDU6TGFiZWwyNjk0NzYwOTQ=","url":"https://api.github.com/repos/metasfresh/metasfresh/labels/type:bug","name":"type:bug","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-22T12:40:40Z","updated_at":"2018-08-24T10:16:18Z","closed_at":"2018-08-24T10:16:18Z","author_association":"CONTRIBUTOR","body":"### Is this a bug or feature request?\r\n* Bug\r\n### What is the current behavior?\r\n* Currently, the process \"Group lines\"  from C_Order doesn't have the Name parameter mandatory. Nevertheless, it is required to be not null by the code. Because of this, I get a NPE when I run the process.\r\n\r\n<details/>\r\n  <summary>Stacktrace</summary>\r\n\r\njava.lang.NullPointerException: name\r\n\tat de.metas.order.compensationGroup.GroupTemplate.<init>(GroupTemplate.java:56)\r\n\tat de.metas.order.compensationGroup.GroupTemplate.<init>(GroupTemplate.java:54)\r\n\tat de.metas.order.compensationGroup.GroupTemplate$GroupTemplateBuilder.build(GroupTemplate.java:53)\r\n\tat de.metas.order.process.C_Order_CreateCompensationGroup.createNewGroupTemplate(C_Order_CreateCompensationGroup.java:80)\r\n\tat de.metas.order.process.C_Order_CreateCompensationGroup.doIt(C_Order_CreateCompensationGroup.java:60)\r\n\tat de.metas.process.JavaProcess.startProcess(JavaProcess.java:295)\r\n\tat de.metas.process.ProcessExecutor.startJavaProcess(ProcessExecutor.java:564)\r\n\tat de.metas.process.ProcessExecutor.startJavaOrScriptProcess(ProcessExecutor.java:460)\r\n\tat de.metas.process.ProcessExecutor.access$5(ProcessExecutor.java:449)\r\n\tat de.metas.process.ProcessExecutor$1.run(ProcessExecutor.java:224)\r\n\tat org.adempiere.ad.trx.api.impl.TrxCallableWrappers$3.call(TrxCallableWrappers.java:145)\r\n\tat org.adempiere.ad.trx.api.impl.TrxCallableWrappers$3.call(TrxCallableWrappers.java:1)\r\n\tat org.adempiere.ad.trx.api.impl.AbstractTrxManager.call0(AbstractTrxManager.java:775)\r\n\tat org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:688)\r\n\tat org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:589)\r\n\tat org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:520)\r\n\tat org.adempiere.ad.trx.api.impl.AbstractTrxManager.run(AbstractTrxManager.java:506)\r\n\tat de.metas.process.ProcessExecutor.executeNow(ProcessExecutor.java:286)\r\n\tat de.metas.process.ProcessExecutor.executeSync(ProcessExecutor.java:171)\r\n\tat de.metas.process.ProcessExecutor.access$1(ProcessExecutor.java:130)\r\n\tat de.metas.process.ProcessExecutor$Builder.executeSync(ProcessExecutor.java:651)\r\n\tat de.metas.ui.web.process.adprocess.ADProcessInstanceController.executeADProcess(ADProcessInstanceController.java:332)\r\n\tat de.metas.ui.web.process.adprocess.ADProcessInstanceController.startProcess(ADProcessInstanceController.java:309)\r\n\tat de.metas.ui.web.process.ProcessRestController.lambda$11(ProcessRestController.java:261)\r\n\tat de.metas.ui.web.process.adprocess.ADProcessInstancesRepository.forProcessInstanceWritable(ADProcessInstancesRepository.java:419)\r\n\tat de.metas.ui.web.process.ProcessRestController.lambda$10(ProcessRestController.java:260)\r\n\tat de.metas.ui.web.window.controller.Execution$ExecutionBuilder.lambda$2(Execution.java:237)\r\n\tat de.metas.ui.web.window.controller.Execution$ExecutionBuilder.execute(Execution.java:260)\r\n\tat de.metas.ui.web.process.ProcessRestController.startProcess(ProcessRestController.java:259)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat java.lang.reflect.Method.invoke(Method.java:498)\r\n\tat org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)\r\n\tat org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)\r\n\tat org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)\r\n\tat org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)\r\n\tat org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)\r\n\tat org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)\r\n\tat org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963)\r\n\tat org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897)\r\n\tat org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)\r\n\tat org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:861)\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:635)\r\n\tat org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:742)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.boot.web.filter.ApplicationContextHeaderFilter.doFilterInternal(ApplicationContextHeaderFilter.java:55)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat de.metas.ui.web.config.WebConfig$1.doFilter(WebConfig.java:82)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat de.metas.ui.web.config.ServletLoggingFilter.doFilter(ServletLoggingFilter.java:89)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat de.metas.ui.web.config.CORSFilter.doFilter(CORSFilter.java:85)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.boot.actuate.trace.WebRequestTraceFilter.doFilterInternal(WebRequestTraceFilter.java:110)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:105)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:81)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.session.web.http.SessionRepositoryFilter.doFilterInternal(SessionRepositoryFilter.java:167)\r\n\tat org.springframework.session.web.http.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:80)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:197)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.springframework.boot.actuate.autoconfigure.MetricsFilter.doFilterInternal(MetricsFilter.java:106)\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\r\n\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)\r\n\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)\r\n\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)\r\n\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)\r\n\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)\r\n\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)\r\n\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)\r\n\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)\r\n\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)\r\n\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:861)\r\n\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)\r\n\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)\r\n\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)\r\n\tat java.lang.Thread.run(Thread.java:748)\r\n\r\n</details>\r\n\r\n\r\n\r\n#### Which are the steps to reproduce?\r\n* Try to run that process without a name\r\n### What is the expected or desired behavior?\r\n* There shall be no NPE"},"comment":{"url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments/415717246","html_url":"https://github.com/metasfresh/metasfresh/issues/4509#issuecomment-415717246","issue_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4509","id":415717246,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTcxNzI0Ng==","user":{"login":"metas-dh","id":18696715,"node_id":"MDQ6VXNlcjE4Njk2NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/18696715?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-dh","html_url":"https://github.com/metas-dh","followers_url":"https://api.github.com/users/metas-dh/followers","following_url":"https://api.github.com/users/metas-dh/following{/other_user}","gists_url":"https://api.github.com/users/metas-dh/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-dh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-dh/subscriptions","organizations_url":"https://api.github.com/users/metas-dh/orgs","repos_url":"https://api.github.com/users/metas-dh/repos","events_url":"https://api.github.com/users/metas-dh/events{/privacy}","received_events_url":"https://api.github.com/users/metas-dh/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T10:16:18Z","updated_at":"2018-08-24T10:16:18Z","author_association":"CONTRIBUTOR","body":"Results of IT2\r\ntested in mf15\r\n\r\n* en error msg now displayed when user setting en_US: OK\r\n* de error msg displayed when user setting de_de / de_CH: OK"}}
{"actor":{"display_login":"metas-dh"}}