{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/42","id":202524234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTI0MjM0","html_url":"https://github.com/danielRivera521/ChoresForCoinsiOS/pull/42","diff_url":"https://github.com/danielRivera521/ChoresForCoinsiOS/pull/42.diff","patch_url":"https://github.com/danielRivera521/ChoresForCoinsiOS/pull/42.patch","issue_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/42","number":42,"state":"closed","locked":false,"title":"Andrew release candidate fixes","user":{"login":"AndrewGHarrington","id":17679425,"node_id":"MDQ6VXNlcjE3Njc5NDI1","avatar_url":"https://avatars1.githubusercontent.com/u/17679425?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewGHarrington","html_url":"https://github.com/AndrewGHarrington","followers_url":"https://api.github.com/users/AndrewGHarrington/followers","following_url":"https://api.github.com/users/AndrewGHarrington/following{/other_user}","gists_url":"https://api.github.com/users/AndrewGHarrington/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewGHarrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewGHarrington/subscriptions","organizations_url":"https://api.github.com/users/AndrewGHarrington/orgs","repos_url":"https://api.github.com/users/AndrewGHarrington/repos","events_url":"https://api.github.com/users/AndrewGHarrington/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewGHarrington/received_events","type":"User","site_admin":false},"body":"I made this new branch from the work that you did in the Daniel_data_visualization_fix_and_merge branch.\r\n\r\n- I've got the circle charts working, but not the line graph. I think why it's not working is because it's looking for a completed_date from the database, but I don't believe that ever gets set anywhere in the app.\r\n- The overview page doesn't show duplicate cells anymore\r\n- the overview page has the redeem button implemented now for children\r\n- one of the user suggestions for me was kids wanted to be able to make chores, so that has been re-enabled for kids.\r\n- There's a really weird thing going on where in the getCoinTotals method in the chore list view controller, the closure for the observeSingleEvent gets called 2 times, and I have no idea what is making that second call. It's making the coin total in the header double what it should be. If you leave the page and come back to it, it fixes itself.\r\n- The mark as complete button now segues to the take a picture view","created_at":"2018-07-19T11:09:33Z","updated_at":"2018-07-27T07:11:10Z","closed_at":"2018-07-27T07:11:10Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/42/commits","review_comments_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/42/comments","review_comment_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/42/comments","statuses_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/statuses/1e97816c820aaf57cd76ad7cb54fddbb85c069d8","head":{"label":"danielRivera521:Andrew_ReleaseCandidateFixes","ref":"Andrew_ReleaseCandidateFixes","sha":"1e97816c820aaf57cd76ad7cb54fddbb85c069d8","user":{"login":"danielRivera521","id":33106533,"node_id":"MDQ6VXNlcjMzMTA2NTMz","avatar_url":"https://avatars1.githubusercontent.com/u/33106533?v=4","gravatar_id":"","url":"https://api.github.com/users/danielRivera521","html_url":"https://github.com/danielRivera521","followers_url":"https://api.github.com/users/danielRivera521/followers","following_url":"https://api.github.com/users/danielRivera521/following{/other_user}","gists_url":"https://api.github.com/users/danielRivera521/gists{/gist_id}","starred_url":"https://api.github.com/users/danielRivera521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielRivera521/subscriptions","organizations_url":"https://api.github.com/users/danielRivera521/orgs","repos_url":"https://api.github.com/users/danielRivera521/repos","events_url":"https://api.github.com/users/danielRivera521/events{/privacy}","received_events_url":"https://api.github.com/users/danielRivera521/received_events","type":"User","site_admin":false},"repo":{"id":137509559,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MDk1NTk=","name":"ChoresForCoinsiOS","full_name":"danielRivera521/ChoresForCoinsiOS","owner":{"login":"danielRivera521","id":33106533,"node_id":"MDQ6VXNlcjMzMTA2NTMz","avatar_url":"https://avatars1.githubusercontent.com/u/33106533?v=4","gravatar_id":"","url":"https://api.github.com/users/danielRivera521","html_url":"https://github.com/danielRivera521","followers_url":"https://api.github.com/users/danielRivera521/followers","following_url":"https://api.github.com/users/danielRivera521/following{/other_user}","gists_url":"https://api.github.com/users/danielRivera521/gists{/gist_id}","starred_url":"https://api.github.com/users/danielRivera521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielRivera521/subscriptions","organizations_url":"https://api.github.com/users/danielRivera521/orgs","repos_url":"https://api.github.com/users/danielRivera521/repos","events_url":"https://api.github.com/users/danielRivera521/events{/privacy}","received_events_url":"https://api.github.com/users/danielRivera521/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielRivera521/ChoresForCoinsiOS","description":null,"fork":false,"url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS","forks_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/forks","keys_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/teams","hooks_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/hooks","issue_events_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/events{/number}","events_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/events","assignees_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/assignees{/user}","branches_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/branches{/branch}","tags_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/tags","blobs_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/statuses/{sha}","languages_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/languages","stargazers_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/stargazers","contributors_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/contributors","subscribers_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/subscribers","subscription_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/subscription","commits_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/contents/{+path}","compare_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/merges","archive_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/downloads","issues_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues{/number}","pulls_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls{/number}","milestones_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/milestones{/number}","notifications_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/labels{/name}","releases_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/releases{/id}","deployments_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/deployments","created_at":"2018-06-15T16:25:28Z","updated_at":"2018-07-27T01:06:01Z","pushed_at":"2018-07-27T07:10:21Z","git_url":"git://github.com/danielRivera521/ChoresForCoinsiOS.git","ssh_url":"git@github.com:danielRivera521/ChoresForCoinsiOS.git","clone_url":"https://github.com/danielRivera521/ChoresForCoinsiOS.git","svn_url":"https://github.com/danielRivera521/ChoresForCoinsiOS","homepage":null,"size":91905,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"danielRivera521:master","ref":"master","sha":"ba92f8d0247b308cada4d902a71e43d05859cc4f","user":{"login":"danielRivera521","id":33106533,"node_id":"MDQ6VXNlcjMzMTA2NTMz","avatar_url":"https://avatars1.githubusercontent.com/u/33106533?v=4","gravatar_id":"","url":"https://api.github.com/users/danielRivera521","html_url":"https://github.com/danielRivera521","followers_url":"https://api.github.com/users/danielRivera521/followers","following_url":"https://api.github.com/users/danielRivera521/following{/other_user}","gists_url":"https://api.github.com/users/danielRivera521/gists{/gist_id}","starred_url":"https://api.github.com/users/danielRivera521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielRivera521/subscriptions","organizations_url":"https://api.github.com/users/danielRivera521/orgs","repos_url":"https://api.github.com/users/danielRivera521/repos","events_url":"https://api.github.com/users/danielRivera521/events{/privacy}","received_events_url":"https://api.github.com/users/danielRivera521/received_events","type":"User","site_admin":false},"repo":{"id":137509559,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MDk1NTk=","name":"ChoresForCoinsiOS","full_name":"danielRivera521/ChoresForCoinsiOS","owner":{"login":"danielRivera521","id":33106533,"node_id":"MDQ6VXNlcjMzMTA2NTMz","avatar_url":"https://avatars1.githubusercontent.com/u/33106533?v=4","gravatar_id":"","url":"https://api.github.com/users/danielRivera521","html_url":"https://github.com/danielRivera521","followers_url":"https://api.github.com/users/danielRivera521/followers","following_url":"https://api.github.com/users/danielRivera521/following{/other_user}","gists_url":"https://api.github.com/users/danielRivera521/gists{/gist_id}","starred_url":"https://api.github.com/users/danielRivera521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielRivera521/subscriptions","organizations_url":"https://api.github.com/users/danielRivera521/orgs","repos_url":"https://api.github.com/users/danielRivera521/repos","events_url":"https://api.github.com/users/danielRivera521/events{/privacy}","received_events_url":"https://api.github.com/users/danielRivera521/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielRivera521/ChoresForCoinsiOS","description":null,"fork":false,"url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS","forks_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/forks","keys_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/teams","hooks_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/hooks","issue_events_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/events{/number}","events_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/events","assignees_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/assignees{/user}","branches_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/branches{/branch}","tags_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/tags","blobs_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/statuses/{sha}","languages_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/languages","stargazers_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/stargazers","contributors_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/contributors","subscribers_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/subscribers","subscription_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/subscription","commits_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/contents/{+path}","compare_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/merges","archive_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/downloads","issues_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues{/number}","pulls_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls{/number}","milestones_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/milestones{/number}","notifications_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/labels{/name}","releases_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/releases{/id}","deployments_url":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/deployments","created_at":"2018-06-15T16:25:28Z","updated_at":"2018-07-27T01:06:01Z","pushed_at":"2018-07-27T07:10:21Z","git_url":"git://github.com/danielRivera521/ChoresForCoinsiOS.git","ssh_url":"git@github.com:danielRivera521/ChoresForCoinsiOS.git","clone_url":"https://github.com/danielRivera521/ChoresForCoinsiOS.git","svn_url":"https://github.com/danielRivera521/ChoresForCoinsiOS","homepage":null,"size":91905,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/42"},"html":{"href":"https://github.com/danielRivera521/ChoresForCoinsiOS/pull/42"},"issue":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/42"},"comments":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/danielRivera521/ChoresForCoinsiOS/statuses/1e97816c820aaf57cd76ad7cb54fddbb85c069d8"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":12,"additions":7742,"deletions":9350,"changed_files":63}}
{"actor":{"display_login":"AndrewGHarrington"}}