{"action":"created","issue":{"url":"https://api.github.com/repos/gpuweb/gpuweb/issues/93","repository_url":"https://api.github.com/repos/gpuweb/gpuweb","labels_url":"https://api.github.com/repos/gpuweb/gpuweb/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/gpuweb/gpuweb/issues/93/comments","events_url":"https://api.github.com/repos/gpuweb/gpuweb/issues/93/events","html_url":"https://github.com/gpuweb/gpuweb/pull/93","id":366140200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODkwOTI4","number":93,"title":"Fixed pipeline layout in compute/render passes","user":{"login":"kvark","id":107301,"node_id":"MDQ6VXNlcjEwNzMwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-03T01:27:14Z","updated_at":"2018-10-03T16:32:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gpuweb/gpuweb/pulls/93","html_url":"https://github.com/gpuweb/gpuweb/pull/93","diff_url":"https://github.com/gpuweb/gpuweb/pull/93.diff","patch_url":"https://github.com/gpuweb/gpuweb/pull/93.patch"},"body":"This PR includes #92, which includes #91 (we need to go deeper!), so only the last commit needs to be taken into consideration. It's sort of a proposal/RFC, open for discussion.\r\n\r\nBasically, since our render/compute passes encapsulate the resource binding scope, it seems natural to require all those resources to belong to the same pipeline layout. Changing the pipeline layout in practice in low-level APIs like D3D12/Vulkan requires re-binding of some of the resources, based on the layout compatibility rules, and is not generally something that is done often. Chances are that if you are going to use a completely different pipeline layout, you'd also render into different render targets, so this is going to be happening in a different pass.\r\n\r\nAn alternative would be to allow (automatic?) pipeline layout changes through a pass. That would require us to document precisely when the change is possible, how it is achieved, and likely also to provide the pipeline layout argument for binding the resource groups."},"comment":{"url":"https://api.github.com/repos/gpuweb/gpuweb/issues/comments/426705097","html_url":"https://github.com/gpuweb/gpuweb/pull/93#issuecomment-426705097","issue_url":"https://api.github.com/repos/gpuweb/gpuweb/issues/93","id":426705097,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjcwNTA5Nw==","user":{"login":"magcius","id":40890,"node_id":"MDQ6VXNlcjQwODkw","avatar_url":"https://avatars1.githubusercontent.com/u/40890?v=4","gravatar_id":"","url":"https://api.github.com/users/magcius","html_url":"https://github.com/magcius","followers_url":"https://api.github.com/users/magcius/followers","following_url":"https://api.github.com/users/magcius/following{/other_user}","gists_url":"https://api.github.com/users/magcius/gists{/gist_id}","starred_url":"https://api.github.com/users/magcius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magcius/subscriptions","organizations_url":"https://api.github.com/users/magcius/orgs","repos_url":"https://api.github.com/users/magcius/repos","events_url":"https://api.github.com/users/magcius/events{/privacy}","received_events_url":"https://api.github.com/users/magcius/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T16:32:04Z","updated_at":"2018-10-03T16:32:04Z","author_association":"NONE","body":"That kind of refactor can be tricky for an engine not designed for it. They also might have to change shaders to point to a different BindGroup index. It seems overkill for a minor implementation cost and API design cleanup."}}
{"actor":{"display_login":"magcius"}}