{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/comments/235935253","pull_request_review_id":177919590,"id":235935253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkzNTI1Mw==","diff_hunk":"@@ -23,21 +26,42 @@ var Lockscreen = GObject.registerClass({\n         super._init(props);\n \n         this._overlay = new Gtk.EventBox({\n+            aboveChild: true,\n             expand: true,\n-            visible: true,\n         });\n-        this._overlay.get_style_context().add_class('lockscreen');\n-        this._updateUI();\n-\n+        this.add_overlay(this._overlay);\n         this._overlay.connect('button-release-event', () => {\n             this.emit('overlay-clicked');\n             return Gdk.EVENT_PROPAGATE;\n         });\n \n+        this._css_provider = new Gtk.CssProvider();\n+        this._style = this._overlay.get_style_context();\n+        this._style.add_provider(\n+            this._css_provider,\n+            Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION\n+        );\n+        this._playbin = new Playbin({ visible: true });","path":"src/lockscreen.js","position":37,"original_position":37,"commit_id":"ae95acff0a9c0c6514ecb097095e9831a881ef93","original_commit_id":"ae95acff0a9c0c6514ecb097095e9831a881ef93","user":{"login":"tchx84","id":481418,"node_id":"MDQ6VXNlcjQ4MTQxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/481418?v=4","gravatar_id":"","url":"https://api.github.com/users/tchx84","html_url":"https://github.com/tchx84","followers_url":"https://api.github.com/users/tchx84/followers","following_url":"https://api.github.com/users/tchx84/following{/other_user}","gists_url":"https://api.github.com/users/tchx84/gists{/gist_id}","starred_url":"https://api.github.com/users/tchx84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchx84/subscriptions","organizations_url":"https://api.github.com/users/tchx84/orgs","repos_url":"https://api.github.com/users/tchx84/repos","events_url":"https://api.github.com/users/tchx84/events{/privacy}","received_events_url":"https://api.github.com/users/tchx84/received_events","type":"User","site_admin":false},"body":"Making it visible here is messing with some toolboxes logic where some panels/lock should only shown after another has been unlocked.","created_at":"2018-11-23T13:06:22Z","updated_at":"2018-11-23T13:06:22Z","html_url":"https://github.com/endlessm/hack-toolbox-app/pull/87#discussion_r235935253","pull_request_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/comments/235935253"},"html":{"href":"https://github.com/endlessm/hack-toolbox-app/pull/87#discussion_r235935253"},"pull_request":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87","id":233069611,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDY5NjEx","html_url":"https://github.com/endlessm/hack-toolbox-app/pull/87","diff_url":"https://github.com/endlessm/hack-toolbox-app/pull/87.diff","patch_url":"https://github.com/endlessm/hack-toolbox-app/pull/87.patch","issue_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/87","number":87,"state":"open","locked":false,"title":"WIP: Lockscreen: use a video for animations","user":{"login":"xjuan","id":17505171,"node_id":"MDQ6VXNlcjE3NTA1MTcx","avatar_url":"https://avatars0.githubusercontent.com/u/17505171?v=4","gravatar_id":"","url":"https://api.github.com/users/xjuan","html_url":"https://github.com/xjuan","followers_url":"https://api.github.com/users/xjuan/followers","following_url":"https://api.github.com/users/xjuan/following{/other_user}","gists_url":"https://api.github.com/users/xjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/xjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjuan/subscriptions","organizations_url":"https://api.github.com/users/xjuan/orgs","repos_url":"https://api.github.com/users/xjuan/repos","events_url":"https://api.github.com/users/xjuan/events{/privacy}","received_events_url":"https://api.github.com/users/xjuan/received_events","type":"User","site_admin":false},"body":"Instead of implementing every animations with css or code, simply use a video\r\nwith a key color as transparency.\r\n\r\nVideos and stills goes under data/lockscreens/lockId/\r\n\r\nhttps://phabricator.endlessm.com/T24541","created_at":"2018-11-22T20:36:31Z","updated_at":"2018-11-23T13:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db2c48332746dff98bcc443675b66ead02d533bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87/commits","review_comments_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87/comments","review_comment_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/87/comments","statuses_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/statuses/ae95acff0a9c0c6514ecb097095e9831a881ef93","head":{"label":"endlessm:T24541","ref":"T24541","sha":"ae95acff0a9c0c6514ecb097095e9831a881ef93","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":147884880,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4ODQ4ODA=","name":"hack-toolbox-app","full_name":"endlessm/hack-toolbox-app","private":false,"owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endlessm/hack-toolbox-app","description":"App containing all toolboxes for Endless Hack","fork":false,"url":"https://api.github.com/repos/endlessm/hack-toolbox-app","forks_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/forks","keys_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/teams","hooks_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/hooks","issue_events_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/events","assignees_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/tags","blobs_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/languages","stargazers_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/stargazers","contributors_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/contributors","subscribers_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/subscribers","subscription_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/subscription","commits_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/merges","archive_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/downloads","issues_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/deployments","created_at":"2018-09-07T23:48:22Z","updated_at":"2018-11-22T19:58:08Z","pushed_at":"2018-11-22T20:36:32Z","git_url":"git://github.com/endlessm/hack-toolbox-app.git","ssh_url":"git@github.com:endlessm/hack-toolbox-app.git","clone_url":"https://github.com/endlessm/hack-toolbox-app.git","svn_url":"https://github.com/endlessm/hack-toolbox-app","homepage":null,"size":24857,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"86177916b514501ff4fc1d7bd3cc79c6a45cff19","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":147884880,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4ODQ4ODA=","name":"hack-toolbox-app","full_name":"endlessm/hack-toolbox-app","private":false,"owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endlessm/hack-toolbox-app","description":"App containing all toolboxes for Endless Hack","fork":false,"url":"https://api.github.com/repos/endlessm/hack-toolbox-app","forks_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/forks","keys_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/teams","hooks_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/hooks","issue_events_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/events","assignees_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/tags","blobs_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/languages","stargazers_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/stargazers","contributors_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/contributors","subscribers_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/subscribers","subscription_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/subscription","commits_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/merges","archive_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/downloads","issues_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/hack-toolbox-app/deployments","created_at":"2018-09-07T23:48:22Z","updated_at":"2018-11-22T19:58:08Z","pushed_at":"2018-11-22T20:36:32Z","git_url":"git://github.com/endlessm/hack-toolbox-app.git","ssh_url":"git@github.com:endlessm/hack-toolbox-app.git","clone_url":"https://github.com/endlessm/hack-toolbox-app.git","svn_url":"https://github.com/endlessm/hack-toolbox-app","homepage":null,"size":24857,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87"},"html":{"href":"https://github.com/endlessm/hack-toolbox-app/pull/87"},"issue":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/87"},"comments":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/hack-toolbox-app/statuses/ae95acff0a9c0c6514ecb097095e9831a881ef93"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tchx84"}}