{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/1953","repository_url":"https://api.github.com/repos/hyperledger/iroha","labels_url":"https://api.github.com/repos/hyperledger/iroha/issues/1953/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1953/comments","events_url":"https://api.github.com/repos/hyperledger/iroha/issues/1953/events","html_url":"https://github.com/hyperledger/iroha/pull/1953","id":391088124,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzAzMzgw","number":1953,"title":"No in-place logger creation I","user":{"login":"Akvinikym","id":16174976,"node_id":"MDQ6VXNlcjE2MTc0OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/16174976?v=4","gravatar_id":"","url":"https://api.github.com/users/Akvinikym","html_url":"https://github.com/Akvinikym","followers_url":"https://api.github.com/users/Akvinikym/followers","following_url":"https://api.github.com/users/Akvinikym/following{/other_user}","gists_url":"https://api.github.com/users/Akvinikym/gists{/gist_id}","starred_url":"https://api.github.com/users/Akvinikym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akvinikym/subscriptions","organizations_url":"https://api.github.com/users/Akvinikym/orgs","repos_url":"https://api.github.com/users/Akvinikym/repos","events_url":"https://api.github.com/users/Akvinikym/events{/privacy}","received_events_url":"https://api.github.com/users/Akvinikym/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-14T12:15:23Z","updated_at":"2018-12-21T21:36:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1953","html_url":"https://github.com/hyperledger/iroha/pull/1953","diff_url":"https://github.com/hyperledger/iroha/pull/1953.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1953.patch"},"body":"[IR-98](https://jira.hyperledger.org/browse/IR-98)\r\n\r\n### Description of the Change\r\n\r\nThe logger should not be created in-place in components, so this PR is one of the two, which reworks this dependency, so that logger is passed explicitly to constructors.\r\n\r\n### Benefits\r\n\r\nEasier logger objects manipulation. Ability to create objects of the same class with different logger titles.\r\n\r\n### Possible Drawbacks \r\n\r\nNone."},"comment":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/comments/449504445","html_url":"https://github.com/hyperledger/iroha/pull/1953#issuecomment-449504445","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1953","id":449504445,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTUwNDQ0NQ==","user":{"login":"l4l","id":5658339,"node_id":"MDQ6VXNlcjU2NTgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5658339?v=4","gravatar_id":"","url":"https://api.github.com/users/l4l","html_url":"https://github.com/l4l","followers_url":"https://api.github.com/users/l4l/followers","following_url":"https://api.github.com/users/l4l/following{/other_user}","gists_url":"https://api.github.com/users/l4l/gists{/gist_id}","starred_url":"https://api.github.com/users/l4l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l4l/subscriptions","organizations_url":"https://api.github.com/users/l4l/orgs","repos_url":"https://api.github.com/users/l4l/repos","events_url":"https://api.github.com/users/l4l/events{/privacy}","received_events_url":"https://api.github.com/users/l4l/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T21:36:53Z","updated_at":"2018-12-21T21:36:53Z","author_association":"MEMBER","body":"> The logger should not be created in-place in components\r\n\r\nQuite arguable fix, I hope that will not lead to more pain to ctors juggling"}}
{"actor":{"display_login":"l4l"}}