{"action":"closed","number":1294,"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1294","id":202183163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTgzMTYz","html_url":"https://github.com/googlecartographer/cartographer/pull/1294","diff_url":"https://github.com/googlecartographer/cartographer/pull/1294.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/1294.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1294","number":1294,"state":"closed","locked":false,"title":"Return the proto from Submap::ToProto instead of passing pointer.","user":{"login":"schwoere","id":6522266,"node_id":"MDQ6VXNlcjY1MjIyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6522266?v=4","gravatar_id":"","url":"https://api.github.com/users/schwoere","html_url":"https://github.com/schwoere","followers_url":"https://api.github.com/users/schwoere/followers","following_url":"https://api.github.com/users/schwoere/following{/other_user}","gists_url":"https://api.github.com/users/schwoere/gists{/gist_id}","starred_url":"https://api.github.com/users/schwoere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwoere/subscriptions","organizations_url":"https://api.github.com/users/schwoere/orgs","repos_url":"https://api.github.com/users/schwoere/repos","events_url":"https://api.github.com/users/schwoere/events{/privacy}","received_events_url":"https://api.github.com/users/schwoere/received_events","type":"User","site_admin":false},"body":"Submap::ToProto now returns the proto. \r\n\r\nThis PR makes the interfaces for serialization more consistent: In `mapping_state_serialization.cc` all `ToProto` methods return the proto except Submap::ToProto. ","created_at":"2018-07-18T09:00:30Z","updated_at":"2018-07-20T13:16:45Z","closed_at":"2018-07-20T13:16:44Z","merged_at":"2018-07-20T13:16:44Z","merge_commit_sha":"f1ac8967297965b8eb6f2f4b08a538e052b5a75b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielsievers","id":35999903,"node_id":"MDQ6VXNlcjM1OTk5OTAz","avatar_url":"https://avatars3.githubusercontent.com/u/35999903?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsievers","html_url":"https://github.com/danielsievers","followers_url":"https://api.github.com/users/danielsievers/followers","following_url":"https://api.github.com/users/danielsievers/following{/other_user}","gists_url":"https://api.github.com/users/danielsievers/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsievers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsievers/subscriptions","organizations_url":"https://api.github.com/users/danielsievers/orgs","repos_url":"https://api.github.com/users/danielsievers/repos","events_url":"https://api.github.com/users/danielsievers/events{/privacy}","received_events_url":"https://api.github.com/users/danielsievers/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":418020229,"node_id":"MDU6TGFiZWw0MTgwMjAyMjk=","url":"https://api.github.com/repos/googlecartographer/cartographer/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1294/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1294/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1294/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/6796429314e66b3323203126d358ad90cc26abae","head":{"label":"schwoere:submap_toproto_returns_proto","ref":"submap_toproto_returns_proto","sha":"6796429314e66b3323203126d358ad90cc26abae","user":{"login":"schwoere","id":6522266,"node_id":"MDQ6VXNlcjY1MjIyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6522266?v=4","gravatar_id":"","url":"https://api.github.com/users/schwoere","html_url":"https://github.com/schwoere","followers_url":"https://api.github.com/users/schwoere/followers","following_url":"https://api.github.com/users/schwoere/following{/other_user}","gists_url":"https://api.github.com/users/schwoere/gists{/gist_id}","starred_url":"https://api.github.com/users/schwoere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwoere/subscriptions","organizations_url":"https://api.github.com/users/schwoere/orgs","repos_url":"https://api.github.com/users/schwoere/repos","events_url":"https://api.github.com/users/schwoere/events{/privacy}","received_events_url":"https://api.github.com/users/schwoere/received_events","type":"User","site_admin":false},"repo":{"id":128075870,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwNzU4NzA=","name":"cartographer","full_name":"schwoere/cartographer","owner":{"login":"schwoere","id":6522266,"node_id":"MDQ6VXNlcjY1MjIyNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/6522266?v=4","gravatar_id":"","url":"https://api.github.com/users/schwoere","html_url":"https://github.com/schwoere","followers_url":"https://api.github.com/users/schwoere/followers","following_url":"https://api.github.com/users/schwoere/following{/other_user}","gists_url":"https://api.github.com/users/schwoere/gists{/gist_id}","starred_url":"https://api.github.com/users/schwoere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwoere/subscriptions","organizations_url":"https://api.github.com/users/schwoere/orgs","repos_url":"https://api.github.com/users/schwoere/repos","events_url":"https://api.github.com/users/schwoere/events{/privacy}","received_events_url":"https://api.github.com/users/schwoere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schwoere/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":true,"url":"https://api.github.com/repos/schwoere/cartographer","forks_url":"https://api.github.com/repos/schwoere/cartographer/forks","keys_url":"https://api.github.com/repos/schwoere/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schwoere/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schwoere/cartographer/teams","hooks_url":"https://api.github.com/repos/schwoere/cartographer/hooks","issue_events_url":"https://api.github.com/repos/schwoere/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/schwoere/cartographer/events","assignees_url":"https://api.github.com/repos/schwoere/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/schwoere/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/schwoere/cartographer/tags","blobs_url":"https://api.github.com/repos/schwoere/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schwoere/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schwoere/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/schwoere/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schwoere/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/schwoere/cartographer/languages","stargazers_url":"https://api.github.com/repos/schwoere/cartographer/stargazers","contributors_url":"https://api.github.com/repos/schwoere/cartographer/contributors","subscribers_url":"https://api.github.com/repos/schwoere/cartographer/subscribers","subscription_url":"https://api.github.com/repos/schwoere/cartographer/subscription","commits_url":"https://api.github.com/repos/schwoere/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/schwoere/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/schwoere/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/schwoere/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/schwoere/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/schwoere/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schwoere/cartographer/merges","archive_url":"https://api.github.com/repos/schwoere/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schwoere/cartographer/downloads","issues_url":"https://api.github.com/repos/schwoere/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/schwoere/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/schwoere/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/schwoere/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schwoere/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/schwoere/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/schwoere/cartographer/deployments","created_at":"2018-04-04T14:40:21Z","updated_at":"2018-04-16T11:24:52Z","pushed_at":"2018-07-20T12:42:13Z","git_url":"git://github.com/schwoere/cartographer.git","ssh_url":"git@github.com:schwoere/cartographer.git","clone_url":"https://github.com/schwoere/cartographer.git","svn_url":"https://github.com/schwoere/cartographer","homepage":"","size":4983,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"2de0e5f04b843af9eaf29d1c1eeffb6edb10e6f6","user":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64732358,"node_id":"MDEwOlJlcG9zaXRvcnk2NDczMjM1OA==","name":"cartographer","full_name":"googlecartographer/cartographer","owner":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer","forks_url":"https://api.github.com/repos/googlecartographer/cartographer/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer/deployments","created_at":"2016-08-02T06:55:43Z","updated_at":"2018-07-20T12:42:01Z","pushed_at":"2018-07-20T13:16:44Z","git_url":"git://github.com/googlecartographer/cartographer.git","ssh_url":"git@github.com:googlecartographer/cartographer.git","clone_url":"https://github.com/googlecartographer/cartographer.git","svn_url":"https://github.com/googlecartographer/cartographer","homepage":"","size":4881,"stargazers_count":3534,"watchers_count":3534,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1158,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1158,"open_issues":58,"watchers":3534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1294"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1294"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1294"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1294/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1294/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1294/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer/statuses/6796429314e66b3323203126d358ad90cc26abae"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wally-the-cartographer","id":33023963,"node_id":"MDQ6VXNlcjMzMDIzOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/33023963?v=4","gravatar_id":"","url":"https://api.github.com/users/wally-the-cartographer","html_url":"https://github.com/wally-the-cartographer","followers_url":"https://api.github.com/users/wally-the-cartographer/followers","following_url":"https://api.github.com/users/wally-the-cartographer/following{/other_user}","gists_url":"https://api.github.com/users/wally-the-cartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/wally-the-cartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wally-the-cartographer/subscriptions","organizations_url":"https://api.github.com/users/wally-the-cartographer/orgs","repos_url":"https://api.github.com/users/wally-the-cartographer/repos","events_url":"https://api.github.com/users/wally-the-cartographer/events{/privacy}","received_events_url":"https://api.github.com/users/wally-the-cartographer/received_events","type":"User","site_admin":false},"comments":3,"review_comments":6,"maintainer_can_modify":false,"commits":10,"additions":21,"deletions":21,"changed_files":9}}
{"actor":{"display_login":"wally-the-cartographer"}}