{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/comments/191160226","pull_request_review_id":123679927,"id":191160226,"diff_hunk":"@@ -114,7 +114,17 @@ representing the resource name and `unit` labels representing the resource unit.\n   * kube_pod_container_resource_limits_memory_bytes\n   * kube_pod_container_resource_requests_nvidia_gpu_devices\n   * kube_pod_container_resource_limits_nvidia_gpu_devices\n-  \n+* **The following non-generic resource metrics for nodes are marked deprecated. They will be removed in kube-state-metrics v2.0.0.**","path":"README.md","position":5,"original_position":5,"commit_id":"cc9604ad5f4cd0ffa7776085e0591efd0f8c93b3","original_commit_id":"cc9604ad5f4cd0ffa7776085e0591efd0f8c93b3","user":{"login":"andyxning","id":2404712,"avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"body":"Yep. Considering more and more metrics maybe deprecated, maybe we should make a decision about whether we need to add:\r\n* separate knob\r\n* global knob\r\nto control the whether to scrape the old deprecated metrics.\r\n\r\nThe first option will give end users more fine control on what deprecated metrics to disable and what deprecated metrics should still be collected.\r\nThe second option will make the deprecation of all old metrics more easily. However, the end user control requirement above maybe not satisfied.","created_at":"2018-05-28T09:35:19Z","updated_at":"2018-05-28T09:35:20Z","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/466#discussion_r191160226","pull_request_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/comments/191160226"},"html":{"href":"https://github.com/kubernetes/kube-state-metrics/pull/466#discussion_r191160226"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466"}},"in_reply_to_id":191153426},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466","id":190836975,"html_url":"https://github.com/kubernetes/kube-state-metrics/pull/466","diff_url":"https://github.com/kubernetes/kube-state-metrics/pull/466.diff","patch_url":"https://github.com/kubernetes/kube-state-metrics/pull/466.patch","issue_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/466","number":466,"state":"open","locked":false,"title":"add generic node resource capacity and allocatable","user":{"login":"andyxning","id":2404712,"avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n* Adds `disable-node-none-generic-resource-metrics` command line argument to kube-state-metrics to disable old not labeled resource metrics.\r\n* Adds generic new `kube_node_status_capacity` and `kube_node_status_allocatable`.\r\n\r\n\r\n","created_at":"2018-05-28T05:17:04Z","updated_at":"2018-05-28T09:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b152e6c26d4201539b3f409c252ee1e8e757cef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764086825,"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485759093,"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":694117710,"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/466/comments","statuses_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/statuses/cc9604ad5f4cd0ffa7776085e0591efd0f8c93b3","head":{"label":"andyxning:add_generic_node_resource_capacity_and_allocatable","ref":"add_generic_node_resource_capacity_and_allocatable","sha":"cc9604ad5f4cd0ffa7776085e0591efd0f8c93b3","user":{"login":"andyxning","id":2404712,"avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"repo":{"id":81286219,"name":"kube-state-metrics","full_name":"andyxning/kube-state-metrics","owner":{"login":"andyxning","id":2404712,"avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyxning/kube-state-metrics","description":"Add-on agent to generate and expose cluster-level metrics.","fork":true,"url":"https://api.github.com/repos/andyxning/kube-state-metrics","forks_url":"https://api.github.com/repos/andyxning/kube-state-metrics/forks","keys_url":"https://api.github.com/repos/andyxning/kube-state-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyxning/kube-state-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyxning/kube-state-metrics/teams","hooks_url":"https://api.github.com/repos/andyxning/kube-state-metrics/hooks","issue_events_url":"https://api.github.com/repos/andyxning/kube-state-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/andyxning/kube-state-metrics/events","assignees_url":"https://api.github.com/repos/andyxning/kube-state-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/andyxning/kube-state-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/andyxning/kube-state-metrics/tags","blobs_url":"https://api.github.com/repos/andyxning/kube-state-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyxning/kube-state-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyxning/kube-state-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyxning/kube-state-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyxning/kube-state-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/andyxning/kube-state-metrics/languages","stargazers_url":"https://api.github.com/repos/andyxning/kube-state-metrics/stargazers","contributors_url":"https://api.github.com/repos/andyxning/kube-state-metrics/contributors","subscribers_url":"https://api.github.com/repos/andyxning/kube-state-metrics/subscribers","subscription_url":"https://api.github.com/repos/andyxning/kube-state-metrics/subscription","commits_url":"https://api.github.com/repos/andyxning/kube-state-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyxning/kube-state-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyxning/kube-state-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyxning/kube-state-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyxning/kube-state-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/andyxning/kube-state-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyxning/kube-state-metrics/merges","archive_url":"https://api.github.com/repos/andyxning/kube-state-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyxning/kube-state-metrics/downloads","issues_url":"https://api.github.com/repos/andyxning/kube-state-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/andyxning/kube-state-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/andyxning/kube-state-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/andyxning/kube-state-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyxning/kube-state-metrics/labels{/name}","releases_url":"https://api.github.com/repos/andyxning/kube-state-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/andyxning/kube-state-metrics/deployments","created_at":"2017-02-08T04:07:55Z","updated_at":"2017-02-08T04:07:57Z","pushed_at":"2018-05-28T05:23:55Z","git_url":"git://github.com/andyxning/kube-state-metrics.git","ssh_url":"git@github.com:andyxning/kube-state-metrics.git","clone_url":"https://github.com/andyxning/kube-state-metrics.git","svn_url":"https://github.com/andyxning/kube-state-metrics","homepage":"","size":7977,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"437e9475f5c703cea3053f4726ce5c1ab4ea01a4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":58184885,"name":"kube-state-metrics","full_name":"kubernetes/kube-state-metrics","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kube-state-metrics","description":"Add-on agent to generate and expose cluster-level metrics.","fork":false,"url":"https://api.github.com/repos/kubernetes/kube-state-metrics","forks_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/forks","keys_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/teams","hooks_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/events","assignees_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/tags","blobs_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/subscription","commits_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/merges","archive_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/downloads","issues_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/deployments","created_at":"2016-05-06T06:10:13Z","updated_at":"2018-05-28T07:53:37Z","pushed_at":"2018-05-28T05:23:56Z","git_url":"git://github.com/kubernetes/kube-state-metrics.git","ssh_url":"git@github.com:kubernetes/kube-state-metrics.git","clone_url":"https://github.com/kubernetes/kube-state-metrics.git","svn_url":"https://github.com/kubernetes/kube-state-metrics","homepage":"","size":9118,"stargazers_count":664,"watchers_count":664,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":194,"open_issues":31,"watchers":664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466"},"html":{"href":"https://github.com/kubernetes/kube-state-metrics/pull/466"},"issue":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/466"},"comments":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kube-state-metrics/statuses/cc9604ad5f4cd0ffa7776085e0591efd0f8c93b3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andyxning"}}