{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/hydra/issues/552","repository_url":"https://api.github.com/repos/NixOS/hydra","labels_url":"https://api.github.com/repos/NixOS/hydra/issues/552/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/hydra/issues/552/comments","events_url":"https://api.github.com/repos/NixOS/hydra/issues/552/events","html_url":"https://github.com/NixOS/hydra/pull/552","id":309257880,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc3OTU2NTI3","number":552,"title":"nix-prefetch-git: Fix git submodule checkout","user":{"login":"joranvar","id":346548,"node_id":"MDQ6VXNlcjM0NjU0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/346548?v=4","gravatar_id":"","url":"https://api.github.com/users/joranvar","html_url":"https://github.com/joranvar","followers_url":"https://api.github.com/users/joranvar/followers","following_url":"https://api.github.com/users/joranvar/following{/other_user}","gists_url":"https://api.github.com/users/joranvar/gists{/gist_id}","starred_url":"https://api.github.com/users/joranvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joranvar/subscriptions","organizations_url":"https://api.github.com/users/joranvar/orgs","repos_url":"https://api.github.com/users/joranvar/repos","events_url":"https://api.github.com/users/joranvar/events{/privacy}","received_events_url":"https://api.github.com/users/joranvar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-28T07:55:37Z","updated_at":"2018-06-30T00:37:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NixOS/hydra/pulls/552","html_url":"https://github.com/NixOS/hydra/pull/552","diff_url":"https://github.com/NixOS/hydra/pull/552.diff","patch_url":"https://github.com/NixOS/hydra/pull/552.patch"},"body":"When fetching git submodules, nix-prefetch-git would fail on line 160 with \"cd: too many arguments\".  I'm not sure if the `git submodule status` output has changed, or whether init_submodules() is called in different situations where it does work.  But this change works for me (the submodule is checked out correctly), so it may benefit someone else as well.\r\n\r\n**Separate git submodule dir from `git describe` part when parsing**\r\n\r\n**Ignore first character of `git submodule status` output**\r\nThe submodule may possibly already be initialized, thus lacking the\r\ninitially expected dash (`-`).\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/hydra/issues/comments/401505004","html_url":"https://github.com/NixOS/hydra/pull/552#issuecomment-401505004","issue_url":"https://api.github.com/repos/NixOS/hydra/issues/552","id":401505004,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTUwNTAwNA==","user":{"login":"kquick","id":787421,"node_id":"MDQ6VXNlcjc4NzQyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/787421?v=4","gravatar_id":"","url":"https://api.github.com/users/kquick","html_url":"https://github.com/kquick","followers_url":"https://api.github.com/users/kquick/followers","following_url":"https://api.github.com/users/kquick/following{/other_user}","gists_url":"https://api.github.com/users/kquick/gists{/gist_id}","starred_url":"https://api.github.com/users/kquick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kquick/subscriptions","organizations_url":"https://api.github.com/users/kquick/orgs","repos_url":"https://api.github.com/users/kquick/repos","events_url":"https://api.github.com/users/kquick/events{/privacy}","received_events_url":"https://api.github.com/users/kquick/received_events","type":"User","site_admin":false},"created_at":"2018-06-30T00:37:11Z","updated_at":"2018-06-30T00:37:11Z","author_association":"NONE","body":"With all due respect to this solution from @joranvar, I have just submitted https://github.com/NixOS/hydra/pull/570 which is a superset of this PR, fixing some other issues in nix-prefetch-get by taking a bit of a different approach.  I would appreciate confirmation from anyone that tested this PR (#552) that #570 also resolves the issues they encountered.   Thanks!"}}
{"actor":{"display_login":"kquick"}}