{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/1061","repository_url":"https://api.github.com/repos/square/p2","labels_url":"https://api.github.com/repos/square/p2/issues/1061/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/1061/comments","events_url":"https://api.github.com/repos/square/p2/issues/1061/events","html_url":"https://github.com/square/p2/pull/1061","id":334524462,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDc1MDAz","number":1061,"title":"Modify p2-preparer to read pod whitelist from pod_whitelist_file","user":{"login":"akun1012","id":3346348,"node_id":"MDQ6VXNlcjMzNDYzNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3346348?v=4","gravatar_id":"","url":"https://api.github.com/users/akun1012","html_url":"https://github.com/akun1012","followers_url":"https://api.github.com/users/akun1012/followers","following_url":"https://api.github.com/users/akun1012/following{/other_user}","gists_url":"https://api.github.com/users/akun1012/gists{/gist_id}","starred_url":"https://api.github.com/users/akun1012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akun1012/subscriptions","organizations_url":"https://api.github.com/users/akun1012/orgs","repos_url":"https://api.github.com/users/akun1012/repos","events_url":"https://api.github.com/users/akun1012/events{/privacy}","received_events_url":"https://api.github.com/users/akun1012/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-06-21T14:38:16Z","updated_at":"2018-07-09T22:44:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/1061","html_url":"https://github.com/square/p2/pull/1061","diff_url":"https://github.com/square/p2/pull/1061.diff","patch_url":"https://github.com/square/p2/pull/1061.patch"},"body":"Introducing pod whitelist file, which contains a list of while list pods. Particular uses case is after an host is re imaged, there may still be some sticky apps' manifest remain in node's intent store,  previously, once p2-prepare boosts, it starts to watch intent store immediately and download and install the app binaries, even without other fundamentals of the host are ready. \r\nSo here we introduces pod whitelist file, when p2-prepare is initialized, and before start normally working, we force p2-prepare to keep checking pod whitelist file, install all the pods in the whitelist, keep checking for update, until the pod whiltelist file is empty, which services as a signal that p2-prepare can proceed to play with it's full functionality. "},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/403643261","html_url":"https://github.com/square/p2/pull/1061#issuecomment-403643261","issue_url":"https://api.github.com/repos/square/p2/issues/1061","id":403643261,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzY0MzI2MQ==","user":{"login":"spenceral","id":10701033,"node_id":"MDQ6VXNlcjEwNzAxMDMz","avatar_url":"https://avatars2.githubusercontent.com/u/10701033?v=4","gravatar_id":"","url":"https://api.github.com/users/spenceral","html_url":"https://github.com/spenceral","followers_url":"https://api.github.com/users/spenceral/followers","following_url":"https://api.github.com/users/spenceral/following{/other_user}","gists_url":"https://api.github.com/users/spenceral/gists{/gist_id}","starred_url":"https://api.github.com/users/spenceral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spenceral/subscriptions","organizations_url":"https://api.github.com/users/spenceral/orgs","repos_url":"https://api.github.com/users/spenceral/repos","events_url":"https://api.github.com/users/spenceral/events{/privacy}","received_events_url":"https://api.github.com/users/spenceral/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T22:44:22Z","updated_at":"2018-07-09T22:44:22Z","author_association":"COLLABORATOR","body":"No I don't think it does, I don't see any pods in intent in that test. Imagine the intent store has pods `a` and `b`, but the whitelist file only contains pod `a`. Could you write a test that verifies that pod `b` would _not_ be installed?"}}
{"actor":{"display_login":"spenceral"}}