{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/comments/218755460","pull_request_review_id":156760242,"id":218755460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc1NTQ2MA==","diff_hunk":"@@ -0,0 +1,54 @@\n+'use strict';\n+\n+document.querySelector('.setup.hidden').classList.remove('hidden');\n+\n+var CHARACTERS_NAMES = ['Ивашко', 'Хуан Себастьян де ля Фонтан', 'Фридрих Хамутальевич', 'Саурон', 'Хуанхэ', 'Владимир Владимирович', 'Лютик', 'Донат'];","path":"js/setup.js","position":5,"original_position":5,"commit_id":"d8585b61c204dc60be3018ce81a3d98a1fa361c8","original_commit_id":"d8585b61c204dc60be3018ce81a3d98a1fa361c8","user":{"login":"cy6erskunk","id":754849,"node_id":"MDQ6VXNlcjc1NDg0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/754849?v=4","gravatar_id":"","url":"https://api.github.com/users/cy6erskunk","html_url":"https://github.com/cy6erskunk","followers_url":"https://api.github.com/users/cy6erskunk/followers","following_url":"https://api.github.com/users/cy6erskunk/following{/other_user}","gists_url":"https://api.github.com/users/cy6erskunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cy6erskunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cy6erskunk/subscriptions","organizations_url":"https://api.github.com/users/cy6erskunk/orgs","repos_url":"https://api.github.com/users/cy6erskunk/repos","events_url":"https://api.github.com/users/cy6erskunk/events{/privacy}","received_events_url":"https://api.github.com/users/cy6erskunk/received_events","type":"User","site_admin":false},"body":"Я бы предложил оставить по одному значению на строке. Это займет больше строк, но лучше читается и проще сравнивать изменения между коммитами (сейчас любое изменение в одном из значений будет отмечено как изменение в этой строке, это не очень удобно).\r\nАналогично для следующих массивов.","created_at":"2018-09-19T10:47:11Z","updated_at":"2018-09-19T10:47:11Z","html_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick/pull/3#discussion_r218755460","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/comments/218755460"},"html":{"href":"https://github.com/htmlacademy-javascript/863015-code-and-magick/pull/3#discussion_r218755460"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3","id":213660927,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjYwOTI3","html_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick/pull/3","diff_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick/pull/3.diff","patch_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues/3","number":3,"state":"open","locked":false,"title":"Учебный проект: нас орда","user":{"login":"noneofthelis","id":42800777,"node_id":"MDQ6VXNlcjQyODAwNzc3","avatar_url":"https://avatars0.githubusercontent.com/u/42800777?v=4","gravatar_id":"","url":"https://api.github.com/users/noneofthelis","html_url":"https://github.com/noneofthelis","followers_url":"https://api.github.com/users/noneofthelis/followers","following_url":"https://api.github.com/users/noneofthelis/following{/other_user}","gists_url":"https://api.github.com/users/noneofthelis/gists{/gist_id}","starred_url":"https://api.github.com/users/noneofthelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noneofthelis/subscriptions","organizations_url":"https://api.github.com/users/noneofthelis/orgs","repos_url":"https://api.github.com/users/noneofthelis/repos","events_url":"https://api.github.com/users/noneofthelis/events{/privacy}","received_events_url":"https://api.github.com/users/noneofthelis/received_events","type":"User","site_admin":false},"body":"Не удалось выполнить в точности все 4 пункта задания одновременно. Сделала 2 варианта, первый - setup.js (подключен в index.html), второй -  setup_2.js (подключала, работает). \r\n\r\nВ первом варианте не выполнен п.1 (\"Создайте массив, состоящий из 4 сгенерированных JS объектов, которые будут описывать похожих персонажей\"). Вместо этого создается один объект.\r\n\r\nВо втором варианте не соответствует требованию к коду (\"Стоит отдельно объявить функцию генерации случайных данных, функцию создания DOM-элемента на основе JS-объекта, функцию заполнения блока DOM-элементами на основе массива JS-объектов\").  Для двух последних действий у меня одна функция. \r\n\r\nНе смогла сообразить, как рационально выполнить все условия задания одновременно. \n\n---\n:mortar_board: [Учебный проект: нас орда](https://up.htmlacademy.ru/javascript/15/user/863015/tasks/12)\n\n:boom: https://htmlacademy-javascript.github.io/863015-code-and-magick/3/","created_at":"2018-09-06T15:31:29Z","updated_at":"2018-09-19T10:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebf02ebfefbbed2b01e126ede2cda2d341995fcd","assignee":{"login":"cy6erskunk","id":754849,"node_id":"MDQ6VXNlcjc1NDg0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/754849?v=4","gravatar_id":"","url":"https://api.github.com/users/cy6erskunk","html_url":"https://github.com/cy6erskunk","followers_url":"https://api.github.com/users/cy6erskunk/followers","following_url":"https://api.github.com/users/cy6erskunk/following{/other_user}","gists_url":"https://api.github.com/users/cy6erskunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cy6erskunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cy6erskunk/subscriptions","organizations_url":"https://api.github.com/users/cy6erskunk/orgs","repos_url":"https://api.github.com/users/cy6erskunk/repos","events_url":"https://api.github.com/users/cy6erskunk/events{/privacy}","received_events_url":"https://api.github.com/users/cy6erskunk/received_events","type":"User","site_admin":false},"assignees":[{"login":"cy6erskunk","id":754849,"node_id":"MDQ6VXNlcjc1NDg0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/754849?v=4","gravatar_id":"","url":"https://api.github.com/users/cy6erskunk","html_url":"https://github.com/cy6erskunk","followers_url":"https://api.github.com/users/cy6erskunk/followers","following_url":"https://api.github.com/users/cy6erskunk/following{/other_user}","gists_url":"https://api.github.com/users/cy6erskunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cy6erskunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cy6erskunk/subscriptions","organizations_url":"https://api.github.com/users/cy6erskunk/orgs","repos_url":"https://api.github.com/users/cy6erskunk/repos","events_url":"https://api.github.com/users/cy6erskunk/events{/privacy}","received_events_url":"https://api.github.com/users/cy6erskunk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/statuses/d8585b61c204dc60be3018ce81a3d98a1fa361c8","head":{"label":"noneofthelis:module3-task1","ref":"module3-task1","sha":"d8585b61c204dc60be3018ce81a3d98a1fa361c8","user":{"login":"noneofthelis","id":42800777,"node_id":"MDQ6VXNlcjQyODAwNzc3","avatar_url":"https://avatars0.githubusercontent.com/u/42800777?v=4","gravatar_id":"","url":"https://api.github.com/users/noneofthelis","html_url":"https://github.com/noneofthelis","followers_url":"https://api.github.com/users/noneofthelis/followers","following_url":"https://api.github.com/users/noneofthelis/following{/other_user}","gists_url":"https://api.github.com/users/noneofthelis/gists{/gist_id}","starred_url":"https://api.github.com/users/noneofthelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noneofthelis/subscriptions","organizations_url":"https://api.github.com/users/noneofthelis/orgs","repos_url":"https://api.github.com/users/noneofthelis/repos","events_url":"https://api.github.com/users/noneofthelis/events{/privacy}","received_events_url":"https://api.github.com/users/noneofthelis/received_events","type":"User","site_admin":false},"repo":{"id":146652284,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTIyODQ=","name":"863015-code-and-magick","full_name":"noneofthelis/863015-code-and-magick","private":false,"owner":{"login":"noneofthelis","id":42800777,"node_id":"MDQ6VXNlcjQyODAwNzc3","avatar_url":"https://avatars0.githubusercontent.com/u/42800777?v=4","gravatar_id":"","url":"https://api.github.com/users/noneofthelis","html_url":"https://github.com/noneofthelis","followers_url":"https://api.github.com/users/noneofthelis/followers","following_url":"https://api.github.com/users/noneofthelis/following{/other_user}","gists_url":"https://api.github.com/users/noneofthelis/gists{/gist_id}","starred_url":"https://api.github.com/users/noneofthelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noneofthelis/subscriptions","organizations_url":"https://api.github.com/users/noneofthelis/orgs","repos_url":"https://api.github.com/users/noneofthelis/repos","events_url":"https://api.github.com/users/noneofthelis/events{/privacy}","received_events_url":"https://api.github.com/users/noneofthelis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/noneofthelis/863015-code-and-magick","description":"Alisa Ianovskaia","fork":true,"url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick","forks_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/forks","keys_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/teams","hooks_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/hooks","issue_events_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/issues/events{/number}","events_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/events","assignees_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/assignees{/user}","branches_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/branches{/branch}","tags_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/tags","blobs_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/git/refs{/sha}","trees_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/statuses/{sha}","languages_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/languages","stargazers_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/stargazers","contributors_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/contributors","subscribers_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/subscribers","subscription_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/subscription","commits_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/commits{/sha}","git_commits_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/git/commits{/sha}","comments_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/comments{/number}","issue_comment_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/issues/comments{/number}","contents_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/contents/{+path}","compare_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/merges","archive_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/downloads","issues_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/issues{/number}","pulls_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/pulls{/number}","milestones_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/milestones{/number}","notifications_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/labels{/name}","releases_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/releases{/id}","deployments_url":"https://api.github.com/repos/noneofthelis/863015-code-and-magick/deployments","created_at":"2018-08-29T20:05:10Z","updated_at":"2018-09-06T09:03:14Z","pushed_at":"2018-09-18T11:32:51Z","git_url":"git://github.com/noneofthelis/863015-code-and-magick.git","ssh_url":"git@github.com:noneofthelis/863015-code-and-magick.git","clone_url":"https://github.com/noneofthelis/863015-code-and-magick.git","svn_url":"https://github.com/noneofthelis/863015-code-and-magick","homepage":null,"size":1085,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"8abf1d468b1a0a74915efd35370d19c0d0f43b93","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":146572803,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1NzI4MDM=","name":"863015-code-and-magick","full_name":"htmlacademy-javascript/863015-code-and-magick","private":false,"owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick","description":"Alisa Ianovskaia","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick","forks_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/deployments","created_at":"2018-08-29T08:54:26Z","updated_at":"2018-09-05T21:02:08Z","pushed_at":"2018-09-18T11:32:52Z","git_url":"git://github.com/htmlacademy-javascript/863015-code-and-magick.git","ssh_url":"git@github.com:htmlacademy-javascript/863015-code-and-magick.git","clone_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick.git","svn_url":"https://github.com/htmlacademy-javascript/863015-code-and-magick","homepage":"https://github.com/noneofthelis/863015-code-and-magick","size":1092,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3"},"html":{"href":"https://github.com/htmlacademy-javascript/863015-code-and-magick/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/863015-code-and-magick/statuses/d8585b61c204dc60be3018ce81a3d98a1fa361c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cy6erskunk"}}