{"push_id":2515846729,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"25ad2f75f5d105d30d2ca716a66138a6b32a8c68","before":"a785bc3667d3c11a014da77436a23b1b865458a4","commits":[{"sha":"c5b277033a72650c221084ec0f1326623a810fd0","author":{"name":"James O'Beirne","email":"84db0524bf873c1b07b44adaaf003596dd218869@gmail.com"},"message":"Add purpose arg to Wallet::getAddress\n\nAlso make all arguments to getAddress required and document args at call sites.","distinct":true,"url":"https://api.github.com/repos/bitcoin/bitcoin/commits/c5b277033a72650c221084ec0f1326623a810fd0"},{"sha":"8cdcaee4c7b256c5c3b70f1cfb04a5fb547311cd","author":{"name":"James O'Beirne","email":"84db0524bf873c1b07b44adaaf003596dd218869@gmail.com"},"message":"[qt] Display more helpful message when adding a send address has failed\n\nAddresses #12796.\n\nWhen we're unable to add a sending address to the address book because it\nalready exists as a receiving address, display a message indicating as much.\nThis should help avoid confusion about an address supposedly already in the\nbook but which isn't currently visible in the interface.","distinct":true,"url":"https://api.github.com/repos/bitcoin/bitcoin/commits/8cdcaee4c7b256c5c3b70f1cfb04a5fb547311cd"},{"sha":"9c01be1b85f8ad11a8a0826a4a2bcdc2668a5c1f","author":{"name":"James O'Beirne","email":"84db0524bf873c1b07b44adaaf003596dd218869@gmail.com"},"message":"[tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage\n\nConfirmMessage is reused in future tests apart from its single usage here.","distinct":true,"url":"https://api.github.com/repos/bitcoin/bitcoin/commits/9c01be1b85f8ad11a8a0826a4a2bcdc2668a5c1f"},{"sha":"5109fc4a9cb2cbd73c33197fb9129e1413ab051b","author":{"name":"James O'Beirne","email":"84db0524bf873c1b07b44adaaf003596dd218869@gmail.com"},"message":"[tests] [qt] Add tests for address book manipulation via EditAddressDialog\n\nAlso modifies corresponding QT code to allow for use within test cases.","distinct":true,"url":"https://api.github.com/repos/bitcoin/bitcoin/commits/5109fc4a9cb2cbd73c33197fb9129e1413ab051b"},{"sha":"25ad2f75f5d105d30d2ca716a66138a6b32a8c68","author":{"name":"Wladimir J. van der Laan","email":"bbc07dc96bb50bf6868a2ddfc4dae14fbed703d9@gmail.com"},"message":"Merge #12830: [qt] [tests] Clarify address book error messages, add tests\n\n5109fc4 [tests] [qt] Add tests for address book manipulation via EditAddressDialog (James O'Beirne)\n9c01be1 [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage (James O'Beirne)\n8cdcaee [qt] Display more helpful message when adding a send address has failed (James O'Beirne)\nc5b2770 Add purpose arg to Wallet::getAddress (James O'Beirne)\n\nPull request description:\n\n  Addresses https://github.com/bitcoin/bitcoin/issues/12796.\n\n  When a user attempts to add to the address book a sending address which is already present as a receiving address, they're presented with a confusing error indicating the address is already present in the book, despite the fact that this row is currently invisible.\n\n  ![selection_011](https://user-images.githubusercontent.com/73197/38096704-8a2948d2-3341-11e8-9632-7d563201f28c.jpg)\n\n  This change adds a more specific error message indicating its existence as a receiving address (as discussed in the linked issue).\n\n  ![selection_016](https://user-images.githubusercontent.com/73197/38198467-fa26164e-365a-11e8-8fc5-ddab9caf2fbd.jpg)\n\n  This change also adds some tests exercising use of the address book via QT. Adding so much test code for such a trivial change may seem weird, but it's my hope that this will make further test-writing for address book usage (and other QT features) more approachable.\n\nTree-SHA512: fbdd5564f7a9a2380bbe437f3378e8d4d5fd9201efff4879b72bc23f2cc1c2eecaf2b811994c25070ee052422e48e47901787c2e62cc584774a997fe6a2a327a","distinct":true,"url":"https://api.github.com/repos/bitcoin/bitcoin/commits/25ad2f75f5d105d30d2ca716a66138a6b32a8c68"}]}
{"actor":{"display_login":"laanwj"}}