{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/8","id":170219653,"html_url":"https://github.com/ghiscoding/aurelia-slickgrid/pull/8","diff_url":"https://github.com/ghiscoding/aurelia-slickgrid/pull/8.diff","patch_url":"https://github.com/ghiscoding/aurelia-slickgrid/pull/8.patch","issue_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues/8","number":8,"state":"closed","locked":false,"title":"feat(grid): expose objectIdProperty with bindable prop","user":{"login":"jmzagorski","id":8404957,"avatar_url":"https://avatars2.githubusercontent.com/u/8404957?v=4","gravatar_id":"","url":"https://api.github.com/users/jmzagorski","html_url":"https://github.com/jmzagorski","followers_url":"https://api.github.com/users/jmzagorski/followers","following_url":"https://api.github.com/users/jmzagorski/following{/other_user}","gists_url":"https://api.github.com/users/jmzagorski/gists{/gist_id}","starred_url":"https://api.github.com/users/jmzagorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmzagorski/subscriptions","organizations_url":"https://api.github.com/users/jmzagorski/orgs","repos_url":"https://api.github.com/users/jmzagorski/repos","events_url":"https://api.github.com/users/jmzagorski/events{/privacy}","received_events_url":"https://api.github.com/users/jmzagorski/received_events","type":"User","site_admin":false},"body":"This pull requests adds a bindable property for the `objectIdProperty` parameter on the `setItems` dataview method. Many of my APIs had to use a property other than \"id\" so slickgrid throws an error `Each data element must implement a unique 'id' property`. Adding this bindable property allows the consumer to specify their unique key if it is other than \"id\" and defaults to \"id\" if not specified.","created_at":"2018-02-20T15:12:26Z","updated_at":"2018-02-23T02:29:24Z","closed_at":"2018-02-23T02:29:24Z","merged_at":"2018-02-23T02:29:24Z","merge_commit_sha":"4dda68dce6485d73cafe2373ff20f52de4996c2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues/8/comments","statuses_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/statuses/0f0c2b7a1d902a9e543caa7deb2748a1aa69a4b9","head":{"label":"jmzagorski:feat/bindable_objectIdProperty","ref":"feat/bindable_objectIdProperty","sha":"0f0c2b7a1d902a9e543caa7deb2748a1aa69a4b9","user":{"login":"jmzagorski","id":8404957,"avatar_url":"https://avatars2.githubusercontent.com/u/8404957?v=4","gravatar_id":"","url":"https://api.github.com/users/jmzagorski","html_url":"https://github.com/jmzagorski","followers_url":"https://api.github.com/users/jmzagorski/followers","following_url":"https://api.github.com/users/jmzagorski/following{/other_user}","gists_url":"https://api.github.com/users/jmzagorski/gists{/gist_id}","starred_url":"https://api.github.com/users/jmzagorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmzagorski/subscriptions","organizations_url":"https://api.github.com/users/jmzagorski/orgs","repos_url":"https://api.github.com/users/jmzagorski/repos","events_url":"https://api.github.com/users/jmzagorski/events{/privacy}","received_events_url":"https://api.github.com/users/jmzagorski/received_events","type":"User","site_admin":false},"repo":{"id":121762591,"name":"aurelia-slickgrid","full_name":"jmzagorski/aurelia-slickgrid","owner":{"login":"jmzagorski","id":8404957,"avatar_url":"https://avatars2.githubusercontent.com/u/8404957?v=4","gravatar_id":"","url":"https://api.github.com/users/jmzagorski","html_url":"https://github.com/jmzagorski","followers_url":"https://api.github.com/users/jmzagorski/followers","following_url":"https://api.github.com/users/jmzagorski/following{/other_user}","gists_url":"https://api.github.com/users/jmzagorski/gists{/gist_id}","starred_url":"https://api.github.com/users/jmzagorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmzagorski/subscriptions","organizations_url":"https://api.github.com/users/jmzagorski/orgs","repos_url":"https://api.github.com/users/jmzagorski/repos","events_url":"https://api.github.com/users/jmzagorski/events{/privacy}","received_events_url":"https://api.github.com/users/jmzagorski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmzagorski/aurelia-slickgrid","description":"Slickgrid the best javascript datagrid now available in Aurelia","fork":true,"url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid","forks_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/forks","keys_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/teams","hooks_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/hooks","issue_events_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/issues/events{/number}","events_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/events","assignees_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/assignees{/user}","branches_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/branches{/branch}","tags_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/tags","blobs_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/languages","stargazers_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/stargazers","contributors_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/contributors","subscribers_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/subscribers","subscription_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/subscription","commits_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/contents/{+path}","compare_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/merges","archive_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/downloads","issues_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/issues{/number}","pulls_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/labels{/name}","releases_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/releases{/id}","deployments_url":"https://api.github.com/repos/jmzagorski/aurelia-slickgrid/deployments","created_at":"2018-02-16T14:53:47Z","updated_at":"2018-02-16T14:53:49Z","pushed_at":"2018-02-22T19:58:05Z","git_url":"git://github.com/jmzagorski/aurelia-slickgrid.git","ssh_url":"git@github.com:jmzagorski/aurelia-slickgrid.git","clone_url":"https://github.com/jmzagorski/aurelia-slickgrid.git","svn_url":"https://github.com/jmzagorski/aurelia-slickgrid","homepage":"https://ghiscoding.github.io/aurelia-slickgrid/#/slickgrid","size":41939,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ghiscoding:master","ref":"master","sha":"730ed15ed22f4ec5d3c99a31be82241f23fd2ed6","user":{"login":"ghiscoding","id":643976,"avatar_url":"https://avatars0.githubusercontent.com/u/643976?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiscoding","html_url":"https://github.com/ghiscoding","followers_url":"https://api.github.com/users/ghiscoding/followers","following_url":"https://api.github.com/users/ghiscoding/following{/other_user}","gists_url":"https://api.github.com/users/ghiscoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiscoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiscoding/subscriptions","organizations_url":"https://api.github.com/users/ghiscoding/orgs","repos_url":"https://api.github.com/users/ghiscoding/repos","events_url":"https://api.github.com/users/ghiscoding/events{/privacy}","received_events_url":"https://api.github.com/users/ghiscoding/received_events","type":"User","site_admin":false},"repo":{"id":78310416,"name":"aurelia-slickgrid","full_name":"ghiscoding/aurelia-slickgrid","owner":{"login":"ghiscoding","id":643976,"avatar_url":"https://avatars0.githubusercontent.com/u/643976?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiscoding","html_url":"https://github.com/ghiscoding","followers_url":"https://api.github.com/users/ghiscoding/followers","following_url":"https://api.github.com/users/ghiscoding/following{/other_user}","gists_url":"https://api.github.com/users/ghiscoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiscoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiscoding/subscriptions","organizations_url":"https://api.github.com/users/ghiscoding/orgs","repos_url":"https://api.github.com/users/ghiscoding/repos","events_url":"https://api.github.com/users/ghiscoding/events{/privacy}","received_events_url":"https://api.github.com/users/ghiscoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghiscoding/aurelia-slickgrid","description":"Slickgrid the best javascript datagrid now available in Aurelia","fork":false,"url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid","forks_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/forks","keys_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/teams","hooks_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/hooks","issue_events_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues/events{/number}","events_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/events","assignees_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/assignees{/user}","branches_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/branches{/branch}","tags_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/tags","blobs_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/languages","stargazers_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/stargazers","contributors_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/contributors","subscribers_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/subscribers","subscription_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/subscription","commits_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/contents/{+path}","compare_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/merges","archive_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/downloads","issues_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues{/number}","pulls_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/labels{/name}","releases_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/releases{/id}","deployments_url":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/deployments","created_at":"2017-01-07T23:41:42Z","updated_at":"2018-02-19T14:47:24Z","pushed_at":"2018-02-23T02:29:24Z","git_url":"git://github.com/ghiscoding/aurelia-slickgrid.git","ssh_url":"git@github.com:ghiscoding/aurelia-slickgrid.git","clone_url":"https://github.com/ghiscoding/aurelia-slickgrid.git","svn_url":"https://github.com/ghiscoding/aurelia-slickgrid","homepage":"https://ghiscoding.github.io/aurelia-slickgrid/#/slickgrid","size":42930,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/8"},"html":{"href":"https://github.com/ghiscoding/aurelia-slickgrid/pull/8"},"issue":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues/8"},"comments":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ghiscoding/aurelia-slickgrid/statuses/0f0c2b7a1d902a9e543caa7deb2748a1aa69a4b9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ghiscoding","id":643976,"avatar_url":"https://avatars0.githubusercontent.com/u/643976?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiscoding","html_url":"https://github.com/ghiscoding","followers_url":"https://api.github.com/users/ghiscoding/followers","following_url":"https://api.github.com/users/ghiscoding/following{/other_user}","gists_url":"https://api.github.com/users/ghiscoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiscoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiscoding/subscriptions","organizations_url":"https://api.github.com/users/ghiscoding/orgs","repos_url":"https://api.github.com/users/ghiscoding/repos","events_url":"https://api.github.com/users/ghiscoding/events{/privacy}","received_events_url":"https://api.github.com/users/ghiscoding/received_events","type":"User","site_admin":false},"comments":18,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":5,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"ghiscoding"}}