{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/182232878","pull_request_review_id":112997199,"id":182232878,"diff_hunk":"@@ -508,6 +533,10 @@ func (ig internetGateway) ARN() string {\n \treturn fmt.Sprintf(\"arn:aws:ec2:%s:%s:internet-gateway/%s\", ig.Region, ig.Account, ig.ID)\n }\n \n+func (ig internetGateway) ResourceKey() string {\n+\treturn sg.ARN()","path":"maintenance/aws-janitor/main.go","position":133,"original_position":133,"commit_id":"da2c4e06a1c3c40cd4214f2c90c2269068b52951","original_commit_id":"da2c4e06a1c3c40cd4214f2c90c2269068b52951","user":{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars3.githubusercontent.com/u/1108148?v=4","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},"body":"ig :-)","created_at":"2018-04-17T21:03:15Z","updated_at":"2018-04-17T21:03:15Z","html_url":"https://github.com/kubernetes/test-infra/pull/7740#discussion_r182232878","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/182232878"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/7740#discussion_r182232878"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740","id":182296038,"html_url":"https://github.com/kubernetes/test-infra/pull/7740","diff_url":"https://github.com/kubernetes/test-infra/pull/7740.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/7740.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7740","number":7740,"state":"open","locked":false,"title":"AWS Janitor: Clean up leaked IAM roles","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"We use the normal mark & sweep, but we also consider the roleID, because\r\notherwise if we delete a role and create a new role with the same name,\r\nthey will look the same, and we would eventually hit the TTL.\r\n\r\nI believe the RoleID changes when a role is deleted and recreated.\r\n\r\nIssue #7736","created_at":"2018-04-17T20:55:27Z","updated_at":"2018-04-17T21:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"addde2835a12265ccee03560e188ab0cfaead803","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars0.githubusercontent.com/u/4942464?v=4","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484580953,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":671133125,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7740/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/da2c4e06a1c3c40cd4214f2c90c2269068b52951","head":{"label":"justinsb:aws_janitor_iam_role","ref":"aws_janitor_iam_role","sha":"da2c4e06a1c3c40cd4214f2c90c2269068b52951","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"repo":{"id":59797912,"name":"test-infra","full_name":"justinsb/test-infra","owner":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinsb/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/justinsb/test-infra","forks_url":"https://api.github.com/repos/justinsb/test-infra/forks","keys_url":"https://api.github.com/repos/justinsb/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinsb/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinsb/test-infra/teams","hooks_url":"https://api.github.com/repos/justinsb/test-infra/hooks","issue_events_url":"https://api.github.com/repos/justinsb/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/justinsb/test-infra/events","assignees_url":"https://api.github.com/repos/justinsb/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/justinsb/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/justinsb/test-infra/tags","blobs_url":"https://api.github.com/repos/justinsb/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinsb/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinsb/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinsb/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinsb/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/justinsb/test-infra/languages","stargazers_url":"https://api.github.com/repos/justinsb/test-infra/stargazers","contributors_url":"https://api.github.com/repos/justinsb/test-infra/contributors","subscribers_url":"https://api.github.com/repos/justinsb/test-infra/subscribers","subscription_url":"https://api.github.com/repos/justinsb/test-infra/subscription","commits_url":"https://api.github.com/repos/justinsb/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinsb/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinsb/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinsb/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinsb/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/justinsb/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinsb/test-infra/merges","archive_url":"https://api.github.com/repos/justinsb/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinsb/test-infra/downloads","issues_url":"https://api.github.com/repos/justinsb/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/justinsb/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/justinsb/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/justinsb/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinsb/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/justinsb/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/justinsb/test-infra/deployments","created_at":"2016-05-27T02:29:42Z","updated_at":"2016-05-27T02:29:43Z","pushed_at":"2018-04-17T20:57:23Z","git_url":"git://github.com/justinsb/test-infra.git","ssh_url":"git@github.com:justinsb/test-infra.git","clone_url":"https://github.com/justinsb/test-infra.git","svn_url":"https://github.com/justinsb/test-infra","homepage":null,"size":47864,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b572f0b15e99981aa648abaec734f1d89a8cd921","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-04-17T20:47:11Z","pushed_at":"2018-04-17T20:57:25Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":48880,"stargazers_count":335,"watchers_count":335,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"open_issues_count":303,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":411,"open_issues":303,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/7740"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/7740"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/7740/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7740/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/da2c4e06a1c3c40cd4214f2c90c2269068b52951"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"krzyzacy"}}